Timeline
Jun 4, 2013:
- 9:38 PM Changeset in webkit [151198] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] Make precedence of logical operators explicit
https://bugs.webkit.org/show_bug.cgi?id=117216
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-04
Reviewed by Martin Robinson.
There's a couple of cases where we mix && and in the same expression. In ChromeClient::contentsSizeChanged() the lack of
parentheses actually makes the expression wrong.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::contentsSizeChanged):
- 9:22 PM Changeset in webkit [151197] by
-
- 2 edits in trunk/Source/WebKit2
Tighten plugin sandbox profiles against symlink attacks
https://bugs.webkit.org/show_bug.cgi?id=117219
<rdar://problem/13044569>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-04
Reviewed by Sam Weinig.
This inserts deny rules for creating symbolic links. The rules are
inserted at the end of sandbox profile compilation by overriding the
finalizer. The initial value of %finalize must be the last function
called.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 9:17 PM Changeset in webkit [151196] by
-
- 8 edits in trunk/Tools
Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
<rdar://problem/14042021>.
Reviewed by Brent Fulgham.
- Scripts/build-api-tests:
- Scripts/build-dumprendertree:
- Scripts/build-webkit:
- Scripts/update-webkit-dependency:
- Scripts/update-webkit-support-libs:
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
(setupAppleWinEnv):
(setupCygwinEnv):
- 8:58 PM Changeset in webkit [151195] by
-
- 2 edits in trunk/Source/WebCore
[curl] Headers should be parsed as utf8 if possible
https://bugs.webkit.org/show_bug.cgi?id=117196
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-04
Reviewed by Brent Fulgham.
Testcase already present: http/tests/download/literal-utf-8.html
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback): Parse the header as an utf8 string if possible.
- 6:33 PM Changeset in webkit [151194] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL Gardening. Move mozilla-focus-blur.html to efl-wk2, because it is only failing on EFL WK2.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 6:21 PM Changeset in webkit [151193] by
-
- 5 edits in trunk/Source/WebCore
Prevent throttling while resources are being loaded
https://bugs.webkit.org/show_bug.cgi?id=117218
Reviewed by Gavin Barraclough.
Make use of the page activity assertion infrastructure to delay
throttling while we are waiting on resource loads.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::completed):
(WebCore::FrameLoader::started):
- loader/FrameLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::init):
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
- loader/SubresourceLoader.h:
- 5:00 PM Changeset in webkit [151192] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL Gardening.
fast/canvas/DrawImageSinglePixelStretch.html has being passed after r137150.
- platform/efl/TestExpectations:
- 4:48 PM Changeset in webkit [151191] by
-
- 5 edits in trunk/Tools
[Windows] NRWT is not putting crash logs in proper place (corrections)
https://bugs.webkit.org/show_bug.cgi?id=117212
Reviewed by Dirk Pranke.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.init): Accept a result directory argument in constructor.
(CrashLogs.find_newest_log): Don't require 'port' argument anymore.
(CrashLogs._find_newest_log_win): No longer use 'port' argument.
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_log_win): Simplify test.
- Scripts/webkitpy/common/system/executive.py:
(Executive.running_pids): Handle "win32" case separately from "cygwin" case.
- Scripts/webkitpy/port/win.py:
(WinPort._get_crash_log): No longer require 'port' argument.
- 4:47 PM Changeset in webkit [151190] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL Gardening.
fast/forms/datalist/update-range-with-datalist.html was fixed after r122290.
- platform/efl/TestExpectations:
- 3:39 PM WebKitGTK/2.0.x edited by
- (diff)
- 3:31 PM Changeset in webkit [151189] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=115508
Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-06-04
Reviewed by Gustavo Noronha Silva (kov).
- hi.po: Updated.
- 3:20 PM WebKitGTK/2.0.x edited by
- (diff)
- 3:15 PM WebKitGTK/2.0.x edited by
- (diff)
- 3:15 PM Changeset in webkit [151188] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Updated Telugu [te] Translations for WebKitGTK+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=115856
Patch by Krishnababu Krothapalli <kkrothap@redhat.com> on 2013-06-04
Reviewed by Gustavo Noronha Silva (kov).
- te.po: Updated.
- 3:10 PM Changeset in webkit [151187] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=116825
Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-06-04
Reviewed by Gustavo Noronha Silva (kov).
- or.po: Updated.
- 3:06 PM WebKitGTK/2.0.x edited by
- (diff)
- 2:56 PM Changeset in webkit [151186] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[kn] Kannada Translation for webkit - Updated
https://bugs.webkit.org/show_bug.cgi?id=116941
Patch by Shankar Prasad <svenkate@redhat.com> on 2013-06-04
Reviewed by Gustavo Noronha Silva (kov).
- kn.po: Updated.
- 2:39 PM Changeset in webkit [151185] by
-
- 2 edits in trunk/Tools
Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 2:31 PM Changeset in webkit [151184] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
The DFG JIT should populate frame bytecodeOffsets on OSR exit.
https://bugs.webkit.org/show_bug.cgi?id=117103.
Reviewed by Geoffrey Garen.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- 2:01 PM Changeset in webkit [151183] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, build fix.
- interpreter/Interpreter.h:
- 1:27 PM Changeset in webkit [151182] by
-
- 10 edits in trunk
Remove [NoInterfaceObject] from XPathExpression and NodeIterator
https://bugs.webkit.org/show_bug.cgi?id=117204
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Remove [NoInterfaceObject] from XPathExpression and NodeIterator to match
their respective specifications:
- http://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathExpression
- http://www.w3.org/TR/DOM-Level-2-Traversal-Range/traversal.html#Traversal-NodeIterator
No new tests, already covered by:
fast/js/global-constructors-attributes.html
- dom/NodeIterator.idl:
- xml/XPathExpression.idl:
LayoutTests:
Rebaseline fast/js/global-constructors-attributes.html and fast/dom/dom-constructors.html
now that XPathExpression and NodeIterator properties are exposed on the global Window
object.
- fast/dom/dom-constructors-expected.txt:
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 1:05 PM Changeset in webkit [151181] by
-
- 2 edits in trunk/Source/WebKit2
AX: WK2: accessibility position is calculated every time window frame is updated
https://bugs.webkit.org/show_bug.cgi?id=117201
Reviewed by Tim Horton.
Only calculate the AX position if AX has already been enabled when updating the
WKView's window and frame.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
(-[WKView _accessibilityRegisterUIProcessTokens]):
Don't call accessibilityAttributeValue: here because it could enable accessibility prematurely.
(-[WKView enableAccessibilityIfNecessary]):
After enabling AX for the first time, also update the frame so that the AX position is correct.
(-[WKView accessibilityFocusedUIElement]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):
Tell the AXObjectCache that AX is now enabled.
- 12:25 PM Changeset in webkit [151180] by
-
- 2 edits in trunk/Source/WebCore
AX: MathML multiscripts not exposed in Accessibility
https://bugs.webkit.org/show_bug.cgi?id=115069
Unreviewed, build fix.
Remove an accessibility iOS method that was erroneously added.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
- 12:21 PM Changeset in webkit [151179] by
-
- 21 edits in trunk
Add "VisibleOnly" key to search predicate
https://bugs.webkit.org/show_bug.cgi?id=115491
Patch by Greg Hughes <ghughes@apple.com> on 2013-06-04
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for accessibility clients to use the search predicate to find only visible elements
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::AccessibilityObject::isOnscreen):
(WebCore):
- accessibility/AccessibilityObject.h:
(AccessibilitySearchCriteria):
(WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
(AccessibilityObject):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Tools:
Added support for accessibility clients to use the search predicate to find only visible elements
- DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementForSearchPredicateCallback):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
LayoutTests:
Added tests support for visibleOnly search predicate.
- platform/mac/accessibility/search-predicate-expected.txt:
- platform/mac/accessibility/search-predicate.html:
- 12:15 PM Changeset in webkit [151178] by
-
- 9 edits1 delete in trunk
Unreviewed. Rollout of r151146. Broke some tests.
- 12:05 PM Changeset in webkit [151177] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build fix. The last check-in lost CR/LF endings on the batch file,
causing build failure.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
DOS-style CR/LF endings.
- 11:25 AM Changeset in webkit [151176] by
-
- 2 edits in trunk/Source/WebCore
Refactor the code that decides whether to enable WebGL from settings to helper functions
https://bugs.webkit.org/show_bug.cgi?id=117181
This removes some #ifdef crud out of the getContext() function.
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-06-04
Reviewed by Benjamin Poulain.
- html/HTMLCanvasElement.cpp:
(WebCore::requiresAcceleratedCompositingForWebGL):
(WebCore::shouldEnableWebGL):
(WebCore::HTMLCanvasElement::getContext):
- 11:11 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:07 AM Changeset in webkit [151175] by
-
- 3 edits in trunk/Source/WebCore
Prevent race when pad caps is set on gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=115355
Patch by Thiago Santos <thiago.sousa.santos@collabora.com> on 2013-06-04
Reviewed by Philippe Normand.
Prevent race when pad caps is set on gstreamer player and
Also protect internal paint buffer with a mutex.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
(MediaPlayerPrivateGStreamerBase):
- 9:59 AM Changeset in webkit [151174] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Add floating point absolute function support in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117147
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-06-04
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
(JSC::MacroAssemblerSH4::absDouble):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::dabs):
(JSC::SH4Assembler::printInstr):
- 9:27 AM Changeset in webkit [151173] by
-
- 3 edits in trunk/Tools
[Windows] Unreviewed test correction.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
QuartzCore dll's, which are needed by TestWebKitAPI.
- TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
with VS2010 will run when linked against VS2005 support libraries.
- 9:26 AM Changeset in webkit [151172] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r151043): Frequent crashes inside WebPageProxy::getPlugInInformation
<http://webkit.org/b/117180>
Reviewed by Brady Eidson.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::getPlugInInformation): Return early when plugInProcessProxy is null
since there's nothing we can do.
- 8:26 AM WebKitIDL edited by
- Add documentation for [GlobalContext] introduced in r151169 (diff)
- 7:48 AM WebKitGTK/2.0.x edited by
- Add a proposed merge for the next 2.0 stable release. (diff)
- 7:44 AM Changeset in webkit [151171] by
-
- 4 edits1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Rebaselining after r150798.
- platform/qt-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Moved to qt-5.0-wk2.
- platform/qt/TestExpectations:
- 7:41 AM Changeset in webkit [151170] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix a crash in QtPixmapRuntime.
https://bugs.webkit.org/show_bug.cgi?id=117193
https://bugreports.qt-project.org/browse/QTBUG-30736
Reviewed by Allan Sandfeld Jensen.
The crash could only be reproduced in release builds on Windows.
JSClassCreate calculates the size of JSClassDefinition.staticValues
and staticFunctions by iterating until an entry with a null name is found.
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntime::getClassRef):
- 7:17 AM Changeset in webkit [151169] by
-
- 31 edits in trunk
Automatically generate WorkerContext constructor attributes
https://bugs.webkit.org/show_bug.cgi?id=117183
Reviewed by Kentaro Hara.
.:
Update GENERATE_BINDINGS macro to take an additional _workercontext_constructors_file
optional argument.
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
Add [GlobalContext=WindowOnly|WorkerOnly|WindowAndWorker] IDL extended attribute
to indicate to the bindings generator on which global context the constructor
attribute should be generated for interfaces without [NoInterfaceObject]:
- WindowOnly: only on the global Window object (default if ommitted)
- WorkerOnly: only on the worker context
- WindowAndWorker: On both the global Window object and the worker context
This covers all the current use cases.
The JSC bindings generator now automatically generates the Constructor attributes
on the WorkerContext for non-callback interfaces which do not have the
[NoInterfaceObject] extended attribute but have [GlobalContext=WorkerOnly|WindowAndWorker]
extended attribute.
No new tests, already covered by:
fast/js/global-constructors-attributes.html
fast/js/global-constructors-attributes-worker.html
- CMakeLists.txt:
- DerivedSources.make: Pass new --workerContextConstructorsFile argument to preprocess-idls.pl.
- DerivedSources.pri: Ditto.
- GNUmakefile.am: Ditto.
- PlatformBlackBerry.cmake: Ditto.
- UseJSC.cmake: Ditto.
- bindings/scripts/IDLAttributes.txt: Add [GlobalContext=WindowOnly|WorkerOnly|WindowAndWorker]
IDL extended attribute.
- bindings/scripts/preprocess-idls.pl: Add support for [GlobalContext] extended attribute and
generate a partial interface for WorkerContext global constructors that are automatically
generated.
- dom/MessageEvent.idl: Add [GlobalContext=WindowAndWorker].
- fileapi/Blob.idl: Add [GlobalContext=WindowAndWorker].
- fileapi/FileReader.idl: Add [GlobalContext=WindowAndWorker].
- fileapi/FileReaderSync.idl: Add [GlobalContext=WorkerOnly] and remove [NoInterfaceObject]
as the interface should only be visible in worker environment as per the spec.
- html/DOMURL.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/ArrayBuffer.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/DataView.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Float32Array.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Float64Array.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Int16Array.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Int32Array.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Int8Array.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Uint16Array.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Uint32Array.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Uint8Array.idl: Add [GlobalContext=WindowAndWorker].
- html/canvas/Uint8ClampedArray.idl: Add [GlobalContext=WindowAndWorker].
- workers/WorkerContext.idl: Remove several Constructor attributes which are now automatically
generated.
- workers/WorkerLocation.idl: Add [GlobalContext=WorkerOnly] and remove [NoInterfaceObject]
as the interface should only be visible in worker environment as per the spec.
Tools:
Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
tests.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):
- 7:02 AM Changeset in webkit [151168] by
-
- 4 edits in trunk/Source/WebKit2
[EFl][WK2] Sub menu items should be of EWK_SUBMENU_TYPE and not checkable
https://bugs.webkit.org/show_bug.cgi?id=116959
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-04
Reviewed by Gyuyoung Kim.
Currently using ewk API it is possible to create a sub menu item which is not an EWK_SUBMENU_TYPE
or set checkable flag for it, while it is not possible for items created by WebKit.
This patch changes ewk context menu API to match WebKit2 behaviour, by creating sub menus with
proper type and checkable flags.
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(ewk_context_menu_item_new_with_submenu):
- UIProcess/API/efl/ewk_context_menu_item.h:
- UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(showContextMenu):
- 4:55 AM Changeset in webkit [151167] by
-
- 18 edits in branches/dfgFourthTier
Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148720 | oliver@apple.com | 2013-04-18 18:34:07 -0700 (Thu, 18 Apr 2013) | 19 lines
StackFrame::column() returning bogus value
https://bugs.webkit.org/show_bug.cgi?id=114840
------------------------------------------------------------------------
r149205 | oliver@apple.com | 2013-04-26 13:12:04 -0700 (Fri, 26 Apr 2013) | 10 lines
Make stack tracing more robust
https://bugs.webkit.org/show_bug.cgi?id=115272
------------------------------------------------------------------------
r149404 | oliver@apple.com | 2013-04-30 15:15:47 -0700 (Tue, 30 Apr 2013) | 45 lines
JSC Stack walking logic craches in the face of inlined functions triggering VM re-entry
https://bugs.webkit.org/show_bug.cgi?id=115449
------------------------------------------------------------------------
r150160 | oliver@apple.com | 2013-05-15 17:29:25 -0700 (Wed, 15 May 2013) | 42 lines
RefCountedArray needs to use vector initialisers for its backing store
https://bugs.webkit.org/show_bug.cgi?id=116194
------------------------------------------------------------------------
Source/WebCore: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r150160 | oliver@apple.com | 2013-05-15 17:29:25 -0700 (Wed, 15 May 2013) | 42 lines
RefCountedArray needs to use vector initialisers for its backing store
https://bugs.webkit.org/show_bug.cgi?id=116194
------------------------------------------------------------------------
Source/WTF: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r150160 | oliver@apple.com | 2013-05-15 17:29:25 -0700 (Wed, 15 May 2013) | 42 lines
RefCountedArray needs to use vector initialisers for its backing store
https://bugs.webkit.org/show_bug.cgi?id=116194
------------------------------------------------------------------------
LayoutTests: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r149404 | oliver@apple.com | 2013-04-30 15:15:47 -0700 (Tue, 30 Apr 2013) | 45 lines
JSC Stack walking logic craches in the face of inlined functions triggering VM re-entry
https://bugs.webkit.org/show_bug.cgi?id=115449
------------------------------------------------------------------------
- 4:19 AM Changeset in webkit [151166] by
-
- 2 edits in trunk/Tools
[EFL] File dialog of MiniBrowser have broken background.
https://bugs.webkit.org/show_bug.cgi?id=117189
Reviewed by Christophe Dumez.
- MiniBrowser/efl/main.c:
(on_file_chooser_request): Added elm_bg for elm_win of file chooser.
- 3:44 AM Changeset in webkit [151165] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=117186
Mark accessibility/text-role-with-aria-hidden-inside.html as failing on EFL
after added r151079.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-04
- platform/efl-wk2/TestExpectations:
- 3:26 AM Changeset in webkit [151164] by
-
- 3 edits in trunk/Source/WebCore
Use ASSERT_DISABLED option for assertion purpose code in InlineBox
https://bugs.webkit.org/show_bug.cgi?id=117146
Reviewed by Alexey Proskuryakov.
We can distinguish assertion code with debug purpose by using ASSERT_DISABLED option.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::~InlineBox):
(WebCore::InlineBox::destroy):
(WebCore::InlineBox::operator delete):
- rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
- 2:49 AM Changeset in webkit [151163] by
-
- 11 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Rebaselining after r150798.
- platform/qt/TestExpectations: Skip faling test after r151146.
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt: Rebaselining after r151140.
- platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/qt/editing/inserting/insert-3907422-fix-expected.txt:
- platform/qt/editing/pasteboard/4944770-2-expected.txt:
- platform/qt/editing/pasteboard/8145-2-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/qt/editing/pasteboard/paste-text-008-expected.txt:
- platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- 2:04 AM Changeset in webkit [151162] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Custom context menu items cannot be selected
https://bugs.webkit.org/show_bug.cgi?id=116830
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-04
Reviewed by Gyuyoung Kim.
Custom item added using ewk_context_menu_item_append had no
pointer to parent menu, and custom submenu added using with the
the same function had no pointer to EwkView. Both issues
prevented items to be selected.
- UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::appendItem):
(EwkContextMenu::contextMenuItemSelected):
(ewk_context_menu_item_append):
(ewk_context_menu_item_select):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu):
(EwkContextMenu::setEwkView):
- 1:55 AM Changeset in webkit [151161] by
-
- 2 edits in trunk/Tools
[WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
https://bugs.webkit.org/show_bug.cgi?id=117184
Reviewed by Gyuyoung Kim.
Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
- 1:30 AM CommitterTips edited by
- Reflect that we now use contributors.json instead of committers.py (diff)
- 1:10 AM Changeset in webkit [151160] by
-
- 3 edits2 adds in trunk
Fix an assertion failure in Range::textNodeSplit by Text::splitText
https://bugs.webkit.org/show_bug.cgi?id=116509
Reviewed by Ryosuke Niwa.
Source/WebCore:
Range::textNodeSplit is called in Text::splitText, and it assumes the
next sibling node is still a Text node. A DOM mutation event handler can
break this assumption.
We had better postpone DOM mutation events dispatched in Node::insertBefore
until exiting splitText to avoid inconsistent Range state.
This imports http://src.chromium.org/viewvc/blink?view=revision&revision=150493 .
Test: fast/dom/Range/split-text-in-range.html
- dom/Text.cpp:
(WebCore::Text::splitText): Add EventQueueScope.
LayoutTests:
- fast/dom/Range/split-text-in-range-expected.txt: Added.
- fast/dom/Range/split-text-in-range.html: Added.
- 1:08 AM Changeset in webkit [151159] by
-
- 5 edits2 adds in trunk
[JSC] Test262 15.5.4.9_3 test is failing
https://bugs.webkit.org/show_bug.cgi?id=116789
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Bring the String.prototype.localeCompare behavior in line wit ES5 15.9.4.9.
If method is not given enough arguments, the minimal amount of arguments must be assumed, with their value being undefined.
The first argument to localeCompare, in its string form, is used as the 'that' string that's used in the comparison.
Therefor, when calling str.localeCompare() or str.localeCompare(undefined), the first argument isundefinedand the
string "undefined" is used as the string to which value of str is compared.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncLocaleCompare): Remove the early return in case of no given arguments to achieve the desired behavior.
LayoutTests:
Add the 15.5.4.9_3 test from the test262 test suite to cover proper behavior of String.prototype.localeCompare
when no arguments are passed to it. The test tests that str.localeCompare() and str.localeCompare(undefined) work
the same way, i.e. using the string 'undefined' as the string with which str is compared (meaning that the first argument
defaults to 'undefined' when not given).
The test and the rationale behind it originates from bug #1245 in ECMAScript Bugzilla.
https://bugs.ecmascript.org/show_bug.cgi?id=1245
- fast/js/kde/StringObject-expected.txt: Update the baseline.
- fast/js/kde/script-tests/StringObject.js: Update the expected return of the localeCompare test case with no arguments. -1 is
expected as the missing argument defaults to 'undefined' and is then compared to the string on which localeCompare is called.
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.9_String.prototype.localeCompare/S15.5.4.9_3-expected.txt: Added.
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.9_String.prototype.localeCompare/S15.5.4.9_3.html: Added.
- 12:18 AM Changeset in webkit [151158] by
-
- 2 edits10 adds in trunk/LayoutTests
Unreviewed, added missing new line in baseline.
Those tests can be passed on EFL port as gtk port.
- platform/efl/TestExpectations:
- platform/efl/fast/css/color-correction-on-background-image-expected.txt: Added.
- platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Added.
- platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Added.
- platform/efl/fast/css/color-correction-on-text-expected.txt: Added.
- platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Added.
Jun 3, 2013:
- 11:27 PM Changeset in webkit [151157] by
-
- 3 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148820 | mark.lam@apple.com | 2013-04-21 02:04:09 -0700 (Sun, 21 Apr 2013) | 11 lines
Refactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
out into the common section.
https://bugs.webkit.org/show_bug.cgi?id=114910.
------------------------------------------------------------------------
- 11:03 PM Changeset in webkit [151156] by
-
- 2 edits in trunk/Source/WebKit2
Unable to play videos in Safari using QuickTime plug-in until I've played those videos in Chrome first
https://bugs.webkit.org/show_bug.cgi?id=117174
<rdar://problem/13711687>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-03
Reviewed by Alexey Proskuryakov.
Pull in fixes that allow https connections within the plugin
environment.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 10:37 PM Changeset in webkit [151155] by
-
- 53 edits4 copies1 delete in branches/dfgFourthTier
Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Add LLINT and baseline JIT support for timing out scripts.
https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
r148641 | mark.lam@apple.com | 2013-04-17 15:57:33 -0700 (Wed, 17 Apr 2013) | 10 lines
Fix broken build. Replaced a static const with a #define.
https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
r148655 | mark.lam@apple.com | 2013-04-17 20:17:44 -0700 (Wed, 17 Apr 2013) | 10 lines
Avoid using a branch range that is too far for some CPU architectures.
https://bugs.webkit.org/show_bug.cgi?id=114782.
------------------------------------------------------------------------
r148709 | mark.lam@apple.com | 2013-04-18 15:45:25 -0700 (Thu, 18 Apr 2013) | 11 lines
Interpreter entry points should throw the TerminatedExecutionException from the caller frame.
https://bugs.webkit.org/show_bug.cgi?id=114816.
------------------------------------------------------------------------
r148893 | mark.lam@apple.com | 2013-04-22 10:37:29 -0700 (Mon, 22 Apr 2013) | 30 lines
Change baseline JIT watchdog timer check to use the proper fast slow path
infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=114963.
------------------------------------------------------------------------
r148899 | mark.lam@apple.com | 2013-04-22 11:40:58 -0700 (Mon, 22 Apr 2013) | 20 lines
Fix broken 32-bit build to green the bots.
https://bugs.webkit.org/show_bug.cgi?id=114968.
------------------------------------------------------------------------
r148942 | mark.lam@apple.com | 2013-04-22 21:47:08 -0700 (Mon, 22 Apr 2013) | 11 lines
Fix a typo in MacroAssemblerARMv7.h.
https://bugs.webkit.org/show_bug.cgi?id=115011.
------------------------------------------------------------------------
r148989 | mark.lam@apple.com | 2013-04-23 13:54:34 -0700 (Tue, 23 Apr 2013) | 21 lines
Simplify the baseline JIT loop hint call site.
https://bugs.webkit.org/show_bug.cgi?id=115052.
------------------------------------------------------------------------
r149089 | mark.lam@apple.com | 2013-04-24 19:59:51 -0700 (Wed, 24 Apr 2013) | 40 lines
Add watchdog timer polling for the DFG.
https://bugs.webkit.org/show_bug.cgi?id=115134.
------------------------------------------------------------------------
r149420 | mark.lam@apple.com | 2013-04-30 19:38:19 -0700 (Tue, 30 Apr 2013) | 17 lines
JSContextGroupSetExecutionTimeLimit() should not pass a callback to the
VM watchdog if its client did not pass one in.
https://bugs.webkit.org/show_bug.cgi?id=115461.
------------------------------------------------------------------------
r150449 | mark.lam@apple.com | 2013-05-21 09:44:01 -0700 (Tue, 21 May 2013) | 8 lines
Added missing assert condition for PositiveOrZero in ARM branch32().
https://bugs.webkit.org/show_bug.cgi?id=116538.
------------------------------------------------------------------------
Source/WebCore: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Add LLINT and baseline JIT support for timing out scripts.
https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
Source/WTF: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Added currentCPUTime() and currentCPUTimeMS().
https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
- 10:09 PM Changeset in webkit [151154] by
-
- 2 edits in trunk/Source/WebCore
Remove unused arithmetic operation in RenderListItem
https://bugs.webkit.org/show_bug.cgi?id=117175
Reviewed by Brent Fulgham.
Variable 'markerLogicalLeft' is reassigned a value before the old one has been used.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
- 10:01 PM Changeset in webkit [151153] by
-
- 2 edits in trunk/Tools
validate-committer-lists script is now outdated and does not work
https://bugs.webkit.org/show_bug.cgi?id=115860
Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-03
Reviewed by Brent Fulgham.
The script validate-committer-lists was outdated, still using the deprecated log
system and having the old addresses for the mailing lists, as well as still referring
to committers.py, after this was renamed to contributors.json. This patch fixes that
so it can be used again.
- Scripts/validate-committer-lists: Replace calls to log and error with the
new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
to committers.py, which should be contributors.json.
(CommitterListFromMailingList):
(CommitterListFromMailingList.check_for_emails_missing_from_list):
(CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
(CommitterListFromGit._fill_in_emails_for_old_logins):
(CommitterListFromGit.print_committers_missing_from_committer_list):
- 9:51 PM Changeset in webkit [151152] by
-
- 1 edit1 add in trunk/Tools
add a script to dump the tests run most recently by a given worker
https://bugs.webkit.org/show_bug.cgi?id=116571
Reviewed by Brent Fulgham.
The tests_run*.txt results files in layout-test-results/ were removed
in r137356, in favor of collecting more data about how the tests were
run and compressing it and storing it in stats.json. However, it was
nice to just be able to look at a flat text file.
This script will extract the tests run by a given worker from a
given stats.json file, and should help to address that.
- Scripts/dump-webkit-tests-run: Added.
(main):
(convert_trie_to_flat_paths):
- 9:02 PM Changeset in webkit [151151] by
-
- 10 edits in trunk/Tools
[Windows] NRWT is not putting crash logs in proper place
https://bugs.webkit.org/show_bug.cgi?id=117098
Reviewed by Ryosuke Niwa.
Provide windows-specific overloads for various Port features needed to create and capture
crash logs. This change makes it possible to view crash logs (when created) as part of the
summary report at the end of the NRWT run.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_newest_log): Add support for win32 crash logs
(CrashLogs._find_newest_log_win): Added
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(make_mock_crash_report_win): Added
(CrashLogsTest.test_find_log_win): Added.
- Scripts/webkitpy/common/system/executive.py:
(Executive.running_pids): Add support for Cygwin win32 crash logs
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.init):
- Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_read_and_write_file): Add tests for
malformed ascii/utf8 handling (i.e., Windows log files)
- Scripts/webkitpy/port/base.py:
(Port.find_system_pid): Added
- Scripts/webkitpy/port/server_process.py:
(ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
- Scripts/webkitpy/port/win.py:
(WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
for user to hit enter.
(WinPort._get_crash_log): Added
(WinPort.look_for_new_crash_logs): Added
(WinPort.find_system_pid): Added
- Scripts/webkitpy/port/win_unittest.py:
(WinPortTest.test_get_crash_log): Added test
- 9:00 PM Changeset in webkit [151150] by
-
- 44 edits2 deletes in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148119 | ggaren@apple.com | 2013-04-10 11:51:47 -0700 (Wed, 10 Apr 2013) | 106 lines
Removed bitrotted TimeoutChecker code
Source/JavaScriptCore:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebKit/blackberry:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebKit/mac:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebKit/qt:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebKit2:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
- 8:20 PM Changeset in webkit [151149] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
[EFL] Implement GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=95923
Patch by Hojong Han <hojong.han@samsung.com> on 2013-06-03
Reviewed by Geoffrey Garen.
Implements the activity triggered garbage collector.
Additional GCs can be triggered by platfrom timer.
It has sort of compaction effect not to make JSC heap grow fast
so that memory usage becomes lower than usual.
- PlatformEfl.cmake: Added.
- heap/HeapTimer.cpp:
(JSC):
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::add):
(JSC::HeapTimer::stop):
(JSC::HeapTimer::timerEvent):
- heap/HeapTimer.h:
(HeapTimer):
- jsc.cpp:
(main):
- runtime/GCActivityCallback.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
- runtime/GCActivityCallback.h:
(GCActivityCallback):
(JSC::GCActivityCallback::GCActivityCallback):
(DefaultGCActivityCallback):
- 7:57 PM Changeset in webkit [151148] by
-
- 20 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
r147858 | oliver@apple.com | 2013-04-06 15:47:56 -0700 (Sat, 06 Apr 2013) | 62 lines
Unify the many and varied stack trace mechanisms, and make the result sane.
Source/JavaScriptCore:
https://bugs.webkit.org/show_bug.cgi?id=114072
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=114072
Tools:
https://bugs.webkit.org/show_bug.cgi?id=114072
- 6:44 PM Changeset in webkit [151147] by
-
- 6 edits2 moves in trunk
Unreviewed. Some AppleWin VS2010 house cleaning.
- WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
- WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
- win/tools32/scripts/auto-version.sh: Replaced with win/tools32/scripts/auto-version2010.sh.
- win/tools32/scripts/auto-version2010.sh: Removed.
- win/tools32/scripts/feature-defines.sh: Replaced with win/tools32/scripts/feature-defines2010.sh.
- win/tools32/scripts/feature-defines2010.sh: Removed.
- WebCore.vcxproj/build-generated-files.sh:
- 6:16 PM Changeset in webkit [151146] by
-
- 9 edits1 add in trunk
clearLayoutOverflow should never be called before calling layer()->updateScrollInfoAfterLayout().
https://bugs.webkit.org/show_bug.cgi?id=116689.
Reviewed by Ojan Vafai.
Make sure that clearLayoutOverflow only gets called after layer()->updateScrollInfoAfterLayout().
Also move clearLayoutOverflow to RenderBlock so we can keep all the delayed scroll update logic together.
Test: fast/flexbox/clear-overflow-before-scroll-update.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layout): Remove call to clearLayoutOverflow.
(WebCore::RenderBlock::finishDelayUpdateScrollInfo): Add call to clearLayoutOverflow.
(WebCore::RenderBlock::updateScrollInfoAfterLayout): Ditto.
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
(WebCore::RenderBox::layoutOverflowRect): Remove from layoutOverflowRect.
(RenderBox):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock): This should call updateScrollInfoAfterLayout() intead of directly calling layer()->updateScrollInfoAfterLayout().
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock): Ditto.
- 6:09 PM Changeset in webkit [151145] by
-
- 5 edits in trunk
[EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=116726
Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-03
Reviewed by Gyuyoung Kim.
.:
Bump required version of ATK to 2.8.0 in EFL CMake's build.
- Source/cmake/FindATK.cmake: Adds macro to check required version
- Source/cmake/OptionsEfl.cmake: Specifies required version of ATK to be 2.8.0
Tools:
Current version of ATK in efl-ews environment is 2.4.0 and is taken from
the platform (it is not listed in jhbuild moduleset). That version is
old-ish and contain deprecated symbols and missing API, that are blocking
patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
moduleset, which is the same version the gtk port uses.
See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
why this is needed.
- efl/jhbuild.modules: Adds ATK module as dependency
- 5:11 PM Changeset in webkit [151144] by
-
- 6 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: all cached put_by_id transitions, even ones that weren't inlined by the DFG, should be propagated by the GC
https://bugs.webkit.org/show_bug.cgi?id=117170
Reviewed by Mark Hahnenberg.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::propagateTransitions):
(JSC):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/PolymorphicPutByIdList.h:
(JSC):
(PutByIdAccess):
(PolymorphicPutByIdList):
- bytecode/StructureStubInfo.h:
(StructureStubInfo):
- jit/JITCode.h:
(JSC::JITCode::couldBeInterpreted):
(JITCode):
- 4:42 PM Changeset in webkit [151143] by
-
- 15 edits in branches/dfgFourthTier
Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk
r146505 | mark.lam@apple.com | 2013-03-21 13:06:26 -0700 (Thu, 21 Mar 2013) | 21 lines
Fix lexer charPosition computation when "rewind"ing the lexer.
https://bugs.webkit.org/show_bug.cgi?id=112952.
r146552 | mark.lam@apple.com | 2013-03-21 18:56:17 -0700 (Thu, 21 Mar 2013) | 50 lines
Fix O(n2) op_debug bytecode charPosition to column computation.
https://bugs.webkit.org/show_bug.cgi?id=112957.
Source/WTF: Merged from http://svn.webkit.org/repository/webkit/trunk
r146552 | mark.lam@apple.com | 2013-03-21 18:56:17 -0700 (Thu, 21 Mar 2013) | 50 lines
Introducing String::findNextLineStart().
https://bugs.webkit.org/show_bug.cgi?id=112957.
- 3:52 PM Changeset in webkit [151142] by
-
- 2 edits in tags/Safari-537.43.57/Source/WebKit2
Merged r151035. <rdar://problem/14050413>
- 3:47 PM Changeset in webkit [151141] by
-
- 2 edits in trunk/Source/WebCore
[harfbuzz] WebKit fails to build with MinGW compiler because of invalid cast in HarfBuzzShaper.cpp
https://bugs.webkit.org/show_bug.cgi?id=108373
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-06-03
Reviewed by Darin Adler.
Fix building on platforms where UChar is defined as wchar_t.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
- 3:45 PM Changeset in webkit [151140] by
-
- 33 edits2 adds in trunk
REGRESSION: Undoing autocorrection doesn't prevent a future autocorrection
https://bugs.webkit.org/show_bug.cgi?id=117165
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by SpellingCorrectionCommand returning true in callsAppliedEditingInDoApply, which prevented
the command from being registered to the undo manager. This behavior was introduced in r148306 because TypingCommand
registeres itself to the undo manager in appliedEditing.
Fixed the bug by reverting both r122176 and r148306 and implementing a better fix for the bug 90487.
Instead of using InsertTextCommand, simply don't specify ReplaceSelectionCommand::PreventNesting so that the command
doesn't try to break out of a blockquote.
Also fix a bug in ReplaceSelectionCommand::completeHTMLReplacement uncovered by this change. We were only merging
text nodes at the beginning of the replaced content but not at the end. Call mergeTextNodesAroundPosition for the
second time to fix whitespace at the end of the replaced content.
Test: platform/mac/editing/spelling/autocorrection-respets-undo.html
- editing/CompositeEditCommand.cpp: Explictily check isTypingCommand now that callsAppliedEditingInDoApply has been
removed from SpellingCorrectionCommand and TypingCommand and SpellingCorrectionCommand were only classes that
returned true in callsAppliedEditingInDoApply. See r148306 that introduced this function.
(WebCore::CompositeEditCommand::apply):
- editing/CompositeEditCommand.h: Removed callsAppliedEditingInDoApply.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
- editing/SpellingCorrectionCommand.cpp: Removed callsAppliedEditingInDoApply, which was the culprit of this bug,
so that CompositeEditCommand::apply correctly registers this command with the undo manager.
(WebCore::SpellingCorrectionCommand::doApply): Use ReplaceSelectionCommand instead of TypingCommand as noted above.
- editing/SpellingCorrectionCommand.h:
- editing/TypingCommand.cpp: Deleted callsAppliedEditingInDoApply.
- editing/TypingCommand.h:
LayoutTests:
Add a regression test and rebaseline other tests as ReplaceSelectionCommand now merges text nodes at
the end of replaced text.
- editing/deleting/merge-paragraph-from-address-expected.txt:
- editing/deleting/merge-paragraph-from-h6-expected.txt:
- editing/deleting/merge-paragraph-from-listing-expected.txt:
- editing/deleting/paste-with-transparent-background-color-expected.txt:
- editing/inserting/insert-3907422-fix-expected.txt:
- editing/pasteboard/copy-image-with-alt-text-expected.txt:
- editing/pasteboard/merge-end-4-expected.txt:
- editing/pasteboard/nested-blocks-with-text-area-expected.txt:
- editing/pasteboard/nested-blocks-with-text-field-expected.txt:
- editing/pasteboard/paste-text-001-expected.txt:
- editing/pasteboard/paste-unrendered-select-expected.txt:
- editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/mac/editing/pasteboard/4944770-2-expected.txt:
- platform/mac/editing/pasteboard/8145-2-expected.txt:
- platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/mac/editing/pasteboard/paste-text-008-expected.txt:
- platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
- platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
- platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added more asssertions to ensure that
the autocorrected text is in the blockquote. r122176 modified the test description saying that this test
already checks this condition but it never did so explicitly; it assumed that the autocorrected text was
inside a blockquote as long as it started at a certain offset in the text node.
- platform/mac/editing/spelling/autocorrection-respets-undo-expected.txt: Added.
- platform/mac/editing/spelling/autocorrection-respets-undo.html: Added.
- platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt:
- 3:32 PM Changeset in webkit [151139] by
-
- 4 edits in tags/Safari-537.43.57/Source
Versioning.
- 3:29 PM Changeset in webkit [151138] by
-
- 2 edits in trunk/Source/WebCore
Reduce indentation in Widget::paint in WidgetMac.mm
https://bugs.webkit.org/show_bug.cgi?id=117171
Reviewed by Darin Adler.
Use an early return for the common case to reduce indentation in the complex case.
- platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
- 3:29 PM Changeset in webkit [151137] by
-
- 1 copy in tags/Safari-537.43.57
New Tag.
- 3:28 PM Changeset in webkit [151136] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. AppleWin VS2010 build fix.
- WebCore.vcxproj/migrate-scripts.sh:
- 3:25 PM Changeset in webkit [151135] by
-
- 3 edits in trunk/Tools
[GTK] Respect PKG_CONFIG env variable when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=117168
Patch by Erik van Pienbroek <epienbro@fedoraproject.org> on 2013-06-03
Reviewed by Martin Robinson.
The tool generate-gtkdoc internally calls pkg-config.
When cross-compiling it shouldn't use pkg-config, but
it should use the pkg-config which was detected by
the ./configure script (for example this can be
i686-w64-mingw32-pkg-config when cross-compiling)
- GNUmakefile.am:
- gtk/gtkdoc.py:
(PkgConfigGTKDoc.init):
- 3:23 PM Changeset in webkit [151134] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build fix.
- TestWebKitAPI/win/main.cpp: Embed proper manifest information to
allow VS2010 builds to use VS2005 runtime libraries as needed.
- 3:13 PM Changeset in webkit [151133] by
-
- 7 edits98 deletes in trunk
Nuke VS2005 files from the tree.
<rdar://problem/14042021>.
Rubberstamped by Brent Fulgham.
- 3:06 PM Changeset in webkit [151132] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] REGRESSION(r150798): scrolling coordinator is not being enabled when WebPage is set to use fixed layout
https://bugs.webkit.org/show_bug.cgi?id=117163
Reviewed by Darin Adler.
Moved call to WebPage::settings()->setScrollingCoordinatorEnabled()
from CoordinatedLayerTreeHost constructor to WebPage::setUseFixedLayout().
The scrolling coordinator must be enabled or disabled following the
WebPage's use of fixed layout.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
- 2:51 PM Changeset in webkit [151131] by
-
- 7 edits in trunk
AX: WebKit should join substrings on single space when concatenating the accessible name of an element
https://bugs.webkit.org/show_bug.cgi?id=117100
Reviewed by Darin Adler.
Source/WebCore:
When concatenating text from underneath an element append spaces between objects and trim whitespace.
Modified existing tests reflect the new behavior.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement):
LayoutTests:
- accessibility/text-role-with-aria-hidden-inside-expected.txt:
- accessibility/text-role-with-aria-hidden-inside.html:
- platform/mac/accessibility/internal-link-anchors2-expected.txt:
- platform/mac/accessibility/table-with-aria-role-expected.txt:
- 2:49 PM Changeset in webkit [151130] by
-
- 2 edits in branches/dfgFourthTier/LayoutTests
Unreviewed, unbreak all of the tests.
Printing "Some tests failed" is great for the silentTestPass mode, but breaks all previous
expected-to-fail tests. Changed it so we only print this helpful message if we're in
silentTestPass mode.
- fast/js/resources/js-test-pre.js:
(isSuccessfullyParsed):
- 2:47 PM Changeset in webkit [151129] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
https://bugs.webkit.org/show_bug.cgi?id=117167
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
Add WebKit::WebPage API for setting whether to show accelerated compositing
debug borders.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setShowDebugBorders):
(WebKit):
- Api/WebPage.h:
- 2:41 PM Changeset in webkit [151128] by
-
- 5 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
r147798 | fpizlo@apple.com | 2013-04-05 14:34:15 -0700 (Fri, 05 Apr 2013) | 14 lines
If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid
CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should
be robust against this
https://bugs.webkit.org/show_bug.cgi?id=114062
- 2:23 PM Changeset in webkit [151127] by
-
- 5 edits3 copies in branches/dfgFourthTier
Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk
r147670 | oliver@apple.com | 2013-04-04 14:25:26 -0700 (Thu, 04 Apr 2013) | 42 lines
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952
r147690 | Christophe Dumez | 2013-04-04 17:44:28 -0700 (Thu, 04 Apr 2013) | 7 lines
Unreviewed EFL build fix.
We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.
LayoutTests: Merged from http://svn.webkit.org/repository/webkit/trunk
r147670 | oliver@apple.com | 2013-04-04 14:25:26 -0700 (Thu, 04 Apr 2013) | 42 lines
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952
- 2:03 PM Changeset in webkit [151126] by
-
- 5 edits in trunk/Source/WebCore
Remove XMLMIMETypeRegExp
https://bugs.webkit.org/show_bug.cgi?id=116861
Reviewed by Alexey Proskuryakov.
Remove the XMLMIMETypeRegExp class. It contained a regular expression that was used
for checking for valid XML MIME types in DOMImplementation::isXMLMIMEType. The thread-global
instance was stored in ThreadGlobalData.
The class is removed, with DOMImplementation::isXMLMIMEType now testing that the given MIME type
is of proper form and contains only valid characters.
No new tests - no change in functionality.
- dom/DOMImplementation.cpp:
(WebCore::isValidXMLMIMETypeChar): A helper method that returns true only for characters that
are acceptable in a valid XML MIME type (apart from the forward slash).
(WebCore::DOMImplementation::isXMLMIMEType): Instead of using a regular expression, determine
whether the given string is a valid non-standard XML mime type by checking for the '+xml' ending,
proper forward slash position, and that no invalid characters are used in the string.
- dom/DOMImplementation.h:
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData): The OwnPtr<XMLMIMETypeRegExp> member variable is being removed.
(WebCore::ThreadGlobalData::destroy): Ditto.
- platform/ThreadGlobalData.h:
(WebCore): No need for the XMLMIMETypeRegExp forward declaration.
(ThreadGlobalData): Remove the OwnPtr<XMLMIMETypeRegExp> member variable.
- 1:52 PM Changeset in webkit [151125] by
-
- 7 edits in trunk
[GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words
https://bugs.webkit.org/show_bug.cgi?id=115406
Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-03
Reviewed by Martin Robinson.
Source/WebCore:
Replace pango API for drawing underline error on misspelled words, in favor of
drawErrorUnderline() method, removing the platform #ifdef check. As this was the
only usage of Pango in GraphicsContextCairo, it no longer includes pango.h.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker): Removes
pango_cairo_show_error_underline() in favor of drawErrorUnderline().
- platform/graphics/cairo/DrawErrorUnderline.h:
(drawErrorUnderline): Fills the cairo path at the end of the drawing.
LayoutTests:
Update PNG expectations for some spell checking tests to pass pixel hash comparison.
The images are not visually modified.
- platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Rebaseline
image to pass pixel hash
- platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Rebasline
image to pass pixel hash
- platform/gtk/editing/spelling/spelling-expected.png: Rebasline
image to pass pixel hash
- 12:41 PM Changeset in webkit [151124] by
-
- 8 edits in trunk/Tools
AX: MathML multiscripts not exposed in Accessibility
https://bugs.webkit.org/show_bug.cgi?id=115069
Reviewed by Tim Horton.
Add methods to help output components of math multiscripts for accessibility.
- DumpRenderTree/AccessibilityUIElement.cpp:
(mathPostscriptsDescriptionCallback):
(mathPrescriptsDescriptionCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(convertMathMultiscriptPairsToString):
(AccessibilityUIElement::mathPostscriptsDescription):
(AccessibilityUIElement::mathPrescriptsDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::_convertMathMultiscriptPairsToString):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
- 12:35 PM Changeset in webkit [151123] by
-
- 10 edits2 adds in trunk
AX: MathML multiscripts not exposed in Accessibility
https://bugs.webkit.org/show_bug.cgi?id=115069
Reviewed by Tim Horton.
Source/WebCore:
Math multiscript tags allow for an arbitrary number of prescripts and postscripts
around a base object.
This MathML tag currently is not supported in the render tree, but that doesn't need to
stop it from being exposed through accessibility, as a base object with an array of postscripts
and an array of prescripts.
Test: platform/mac/accessibility/mathml-multiscript.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isMathMultiscript):
(AccessibilityObject):
(WebCore::AccessibilityObject::mathPrescripts):
(WebCore::AccessibilityObject::mathPostscripts):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMathMultiscript):
(WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathPrescripts):
(WebCore::AccessibilityRenderObject::mathPostscripts):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSuperscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityMathPostscripts]):
(-[WebAccessibilityObjectWrapper accessibilityMathPrescripts]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(convertMathPairsToNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapperBase accessibilityPlatformMathSuperscriptKey]):
(-[WebAccessibilityObjectWrapperBase accessibilityMathPostscriptPairs]):
(-[WebAccessibilityObjectWrapperBase accessibilityMathPrescriptPairs]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSuperscriptKey]):
- mathml/mathtags.in:
LayoutTests:
- platform/mac/accessibility/mathml-multiscript-expected.txt: Added.
- platform/mac/accessibility/mathml-multiscript.html: Added.
- 12:19 PM Changeset in webkit [151122] by
-
- 5 edits2 adds in trunk/LayoutTests
[Layout Tests] Update testharness scripts, add WebIDLParser.js and idlharness.js
https://bugs.webkit.org/show_bug.cgi?id=116983
Reviewed by Sam Weinig.
Update the testharness scripts that are used by the W3C tests that are located under LayoutTests/http/tests/w3c. Also add the
WebIDLParser.js and idlharness.js scripts that will be used by tests imported in the future. The files are being updated or impoted
off the 06cab30bcee2 changeset in the http://w3c-test.org/resources repository.
No test is affected by this update, though some tests will require rebaselining due to the baselines containing stack traces of which
line numbers will change due to the updated scripts.
- http/tests/w3c/README: List the currently-imported directories, noting from where they originate, at which changeset were
they imported and what files can or should be modified. Also note what script should be used to import/update the files, if available.
- http/tests/w3c/resources/WebIDLParser.js: Added. Will be used by future tests imported from the W3C test suites.
- http/tests/w3c/resources/idlharness.js: Ditto.
- http/tests/w3c/resources/testharness.css: Updated.
- http/tests/w3c/resources/testharness.js: Updated.
- http/tests/w3c/resources/testharnessreport.js: Updated. Removed the default completion callback and readded
the completion callback that was in use until now.
- 11:33 AM Changeset in webkit [151121] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions.html fails
https://bugs.webkit.org/show_bug.cgi?id=117035
Forced relayout to ensure the hover event has propagated before checking the results.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-03
Reviewed by Alexandru Chiculita.
- fast/regions/hover-on-child-parent-different-regions.html:
- 11:31 AM Changeset in webkit [151120] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Add radar number to ChangeLog.
- 11:30 AM Changeset in webkit [151119] by
-
- 3 edits in trunk/Source/WebKit2
Send mouse events to the banner for as long as the mouse button is down
https://bugs.webkit.org/show_bug.cgi?id=117161
Reviewed by Beth Dakin.
Keep track of whether the mouse was pressed in a banner and keep sending mouse events to it,
even if they are outside the banner's bounds for as long as the mouse is down.
- WebProcess/WebPage/PageBanner.h:
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::PageBanner):
(WebKit::PageBanner::mouseEvent):
- 10:57 AM Changeset in webkit [151118] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Selection handles are not cleared when displaying error pages.
https://bugs.webkit.org/show_bug.cgi?id=117158
Reviewed by Carlos Garcia Campos.
PR 342159.
Add explicit cancel of selection state when loading an error page
as it is not always cleared.
Internally Reviewed by Nima Ghanavatian.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 10:31 AM Changeset in webkit [151117] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: node->parentNode(), Heap-use-after-free in WebCore::RenderBox::exclusionShapeOutsideInfo
https://bugs.webkit.org/show_bug.cgi?id=117155
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-03
Reviewed by David Hyatt.
Source/WebCore:
Ported from a Blink patch by kenrb@chromium.org:
Clear floats on RenderBlocks that haven't had layout
WebKit revision 150084 creates a condition where a RenderBlock
can have a populated floating object list even when it has not
previously had layout. Since clearing of floats is optimized
to not search through parts of the tree that have not had layout,
references to floating objects were not being cleared in some cases.
This patch causes markAllDescendantsWithFloatsForLayout() to proceed
in the above case, in order to clear floats for a RenderBlock that has
not had layout.
Test: fast/block/float/float-list-changed-before-layout-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
LayoutTests:
Test for crash. Note that this will only crash when run under a memory
checking tool like ASAN.
- fast/block/float/float-list-changed-before-layout-crash-expected.txt: Added.
- fast/block/float/float-list-changed-before-layout-crash.html: Added.
- 10:21 AM Changeset in webkit [151116] by
-
- 4 edits6 adds in trunk
[CSS Shapes] inset-rectangle support for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=116641
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-03
Reviewed by Alexandru Chiculita.
Source/WebCore:
Implement support for using inset-rectangles in a shape-outside.
Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape): An inset-rectangle is
simply a rectangle with the dimensions calculated differently. So
just use ExclusionRectangle after converting the dimensions.
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable inset
rectangles for shape-outside.
LayoutTests:
Add tests for inset-rectangles.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html: Added.
- 10:17 AM Changeset in webkit [151115] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ROI details are not always cleared when using back navigation.
https://bugs.webkit.org/show_bug.cgi?id=117159
Reviewed by Carlos Garcia Campos.
PR 328557.
Secondary change to ensure when restoreViewState is triggered
ROI is reset.
Internally Reviewed by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::restoreViewState):
- 8:45 AM Changeset in webkit [151114] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Slider UX updates.
https://bugs.webkit.org/show_bug.cgi?id=117148
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-03
Reviewed by Rob Buis.
BlackBerry PR 342328
Internally Reviewed by Jeff Rogers.
Change image and reduce handle size when it is disabled.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):
- 7:45 AM Changeset in webkit [151113] by
-
- 2 edits17 adds in trunk/LayoutTests
[Qt] [WK2] Unreviewed gardening. Unskipping passing tests and generate new test expectations where needed.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-03
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/compositing/geometry/video-opacity-overlay-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/video-opacity-overlay-expected.txt: Added.
- platform/qt-5.0-wk2/editing/spelling/grammar-markers-expected.png: Added.
- platform/qt-5.0-wk2/editing/spelling/grammar-markers-expected.txt: Added.
- platform/qt-5.0-wk2/editing/spelling/grammar-markers-hidpi-expected.png: Added.
- platform/qt-5.0-wk2/editing/spelling/grammar-markers-hidpi-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
- 7:26 AM Changeset in webkit [151112] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112031
Unreviewed EFL gardening.
accessibility/placeholder.html passes after r151103.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-03
- platform/efl-wk2/TestExpectations:
- 6:58 AM Changeset in webkit [151111] by
-
- 11 edits in trunk
Unreviewed, rolling out r151109.
http://trac.webkit.org/changeset/151109
https://bugs.webkit.org/show_bug.cgi?id=117145
"Plugins in WK2 aren't implemented yet." (Requested by
jturcotte on #webkit).
Source/WebCore:
- platform/FileSystem.h:
- platform/qt/FileSystemQt.cpp:
(WebCore::unloadModule):
- plugins/mac/PluginPackageMac.cpp:
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- plugins/mac/PluginViewMac.mm:
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::windowResizerRect):
Tools:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/unix/default_pre.prf:
- 6:37 AM Changeset in webkit [151110] by
-
- 3 edits4 adds in trunk
REGRESSION (r143070): Overflow:scroll content does not get clipped properly when the parent box has CSS3 filter on.
https://bugs.webkit.org/show_bug.cgi?id=116859
Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-03
Reviewed by Simon Fraser.
Apply proper clipping for overflow:scroll, when parent dictates
full repaint to ensure correct CSS3 filter effect.
When a particular layer has 'pixel moving' CSS3 filter(drop shadow, blur), it sets clipToDirtyRect
to false to force no clipping on itself and on the child layers too.
No clipping makes overflow:scroll behave like overflow:display, because
overflow::scroll gets clipped at RenderLayer level (as opposed to overflow::hidden).
This patch makes sure that both full repaint and clipping are ensured.
Source/WebCore:
Tests: css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html
css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
- css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-expected.html: Added.
- css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent-expected.html: Added.
- css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html: Added.
- css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html: Added.
- 6:13 AM Changeset in webkit [151109] by
-
- 11 edits in trunk
[Qt] Re-enable plugins on Mac.
https://bugs.webkit.org/show_bug.cgi?id=116622
Reviewed by Tor Arne Vestbø.
Source/WebCore:
- platform/FileSystem.h:
- platform/qt/FileSystemQt.cpp:
(WebCore::unloadModule):
- Q_WS_* aren't defined since Qt5, use Q_OS_MACX instead.
- plugins/mac/PluginPackageMac.cpp:
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- createCFString now does the adoption itself.
- plugins/mac/PluginViewMac.mm:
- Add missing include.
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::windowResizerRect):
- Add missing parenthese.
Tools:
Plugins on Mac were only enabled if !embedded but the later was set if
QPA is enabled, which is the default since Qt 5.0.
Remove references to 'embedded' and fix various build issues,
PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
months.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/unix/default_pre.prf:
- 6:12 AM Changeset in webkit [151108] by
-
- 2 edits in trunk/LayoutTests
[EFL] Remove obsolete test case from TestExpectations
Unreviewed EFL gardening.
xmlviewer/extensions-api.html case has been removed since r151080.
- platform/efl/TestExpectations:
- 6:12 AM Changeset in webkit [151107] by
-
- 4 edits in trunk/Source/WebCore
[Qt][Mac] Allow drawing plugins with QWindow by always using an intermediate bitmap.
https://bugs.webkit.org/show_bug.cgi?id=116620
Reviewed by Tor Arne Vestbø.
The isolation of QWidget along with QPA in Qt5 is abstracting away the native CGContext
of a QWidget and we would need to create a non-public API to be able to achieve it.
Instead of adding complexity to this rarely touched code, always draw into an
intermediate bitmap that we then paint into our QPainter afterward.
- Use CGBitmapContextCreate to allocate a buffer directly instead of creating a QPixmap and extract an CGContextRef out of it.
- Get rid of the "if (platformPluginWidget())" code path since we don't paint directly into the QWidget's backing store anymore.
- Always use m_contextRef to draw the plugin instead of alternating between direct and indirect drawing.
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/mac/PluginViewMac.mm:
(WebCore::createBitmapContext):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
- 6:12 AM Changeset in webkit [151106] by
-
- 4 edits in trunk/Source/WebCore
[Qt][Mac] Remove Carbon and QuickDraw support for plugins.
https://bugs.webkit.org/show_bug.cgi?id=116619
Reviewed by Tor Arne Vestbø.
They are only enabled for 32bit builds of QtWebKit and are rarely tested.
Other browsers support them through a 32bit host process.
PluginViewMac.mm is only used by Qt since the Wx port was removed.
- Only support the Cocoa event model
- Only support the CoreGraphics drawing model
- Remove all NP_NO_CARBON and NP_NO_QUICKDRAW blocks in PluginViewMac.mm
- plugins/PluginView.cpp:
(WebCore::PluginView::setValue):
(WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleWheelEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::handleKeyboardEvent):
- 6:07 AM Changeset in webkit [151105] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations: Unskip after r151104.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations: Skip crashing test.
- 5:52 AM Changeset in webkit [151104] by
-
- 3 edits in trunk/LayoutTests
[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions.html fails
https://bugs.webkit.org/show_bug.cgi?id=117035
Used waitUntilDone() to ensure correct results.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-03
Reviewed by Antti Koivisto.
- fast/regions/hover-on-child-parent-different-regions-expected.txt:
- fast/regions/hover-on-child-parent-different-regions.html:
- 5:40 AM Changeset in webkit [151103] by
-
- 4 edits in trunk
[GTK][WK2] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106344
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.
Tools:
Adds support for retrieving attribute value.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute):
(WTR::AccessibilityUIElement::stringAttributeValue):
LayoutTests:
Unskipping failing test. It's been fixed.
- platform/gtk-wk2/TestExpectations:
- 5:38 AM Changeset in webkit [151102] by
-
- 2 edits in trunk/Source/WTF
Unreviewed WinCE build fix after r150833.
- wtf/DateMath.cpp:
(WTF::calculateDSTOffset):
- 4:47 AM Changeset in webkit [151101] by
-
- 4 edits in trunk
'onended' event is not received in AudioBufferSourceNode and OscillatorNode.
https://bugs.webkit.org/show_bug.cgi?id=117132.
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-03
Reviewed by Christophe Dumez.
Source/WebCore:
The listener argument is a PassRefPtr which becomes NULL after the call to
setAttributeEventListener() in setOnended(). This causes the m_hasEndedListener
boolean to be incorrectly initialized. This patch reverses the two statements so
that the m_hasEndedListener is updated before the call to setAttributeEventListener().
No new tests, already covered by existing tests.
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::setOnended):
LayoutTests:
Unskip webaudio test cases that were failing due to the 'onended' event not being fired.
- platform/efl/TestExpectations:
- 3:30 AM Changeset in webkit [151100] by
-
- 5 edits in trunk
[EFL]<select> element's text is clipped when a height is specified along with CSS line-height.
https://bugs.webkit.org/show_bug.cgi?id=114862
Patch by Rashmi Kulakarni <rashmi.vijay@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.
Source/WebCore:
Fix <select> element getting clipped when element height becomes less than the line-height.
Set minimum height for <select> element.
No new tests, no behavior change.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
LayoutTests:
Rebaselined the test case fast/forms/001.html.
- platform/efl/fast/forms/001-expected.png:
- platform/efl/fast/forms/001-expected.txt:
- 1:58 AM Changeset in webkit [151099] by
-
- 5 edits4 adds in trunk
Source/WebCore: Webkit crashes while loading content from Application Cache.
https://bugs.webkit.org/show_bug.cgi?id=116814
Reviewed by Darin Adler.
With the refacor for 112722, which removes MainResourceLoader and moves the functionality to DocumentLoader,
the processing of appcache for main resource error (because of network error) was moved DocumentLoader::
mainReceivedError(), which was trigged by ResourceHandle::didFail->SubResourceLoader::didFail, which already
in a Finishing state after notifying the DocumentLoader of the load failure.
Before patch for 112722, the appcache for main resource error was in MainResourceLoader::didFail(),
which will start processing the potential fallback before notifying DocumentLoader and moving the the state
of the resource loader to finishing state.
So we should move maybeLoadFallbackForMainError out of DocumentLoader::mainReceivedError, and move it to
ApplicationCacheHost::maybeLoadFallbackForError, if the resource that has error is the main resource.
Test: http/tests/appcache/main-resource-fallback-for-network-error-crash.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainReceivedError):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):
- loader/appcache/ApplicationCacheHost.h:
LayoutTests: Webkit crashes while loading content from Application Cache.
https://bugs.webkit.org/show_bug.cgi?id=116814
Reviewed by Darin Adler.
- http/tests/appcache/main-resource-fallback-for-network-error-crash-expected.txt: Added.
- http/tests/appcache/main-resource-fallback-for-network-error-crash.html: Added.
- http/tests/appcache/resources/main-resource-fallback-for-network-error-crash.manifest: Added.
- http/tests/appcache/resources/success-and-notify-done.html: Added.
- 1:34 AM Changeset in webkit [151098] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=105156
Patch by Sergio Correia <Sergio Correia> on 2013-06-03
Reviewed by Christophe Dumez.
When using WEB_PROCESS_CMD_PREFIX - which allows us for instance to analyze
WebProcess under tools like valgrind or gdb -, the ProcessLauncher would
spawn the new process using system(), which would, among other things, keep
an extra UIProcess waiting and executing the shell.
This patch handles the normal case and the case where we have something to
prefix WebProcess (i.e., by using WEB_PROCESS_CMD_PREFIX in a debug build)
the same way, through a call to execvp().
To achieve this a function was introduced to create an array with the given
arguments to the full command to be executed, to be used by execvp(). We use
a Vector<OwnArrayPtr<char>>, so that we can take advantage of the destructor
of OwnArrayPtr to handle the memory deallocation when it goes out of scope.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::createArgsArray): This function creates the array to be used by
execvp(), out of the Strings given as arguments.
(WebKit::ProcessLauncher::launchProcess): Rework the logic to accomodate
both the cases with and without WEB_PROCESS_CMD_PREFIX. The execl() call
was replaced with an execvp() call, since now we should deal with having
a variable number of arguments (WEB_PROCESS_CMD_PREFIX) as well.
- 1:02 AM Changeset in webkit [151097] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline 2 printing test cases on EFL port.
- platform/efl/printing/compositing-layer-printing-expected.png:
- platform/efl/printing/compositing-layer-printing-expected.txt:
- platform/efl/printing/page-rule-in-media-query-expected.png:
- platform/efl/printing/page-rule-in-media-query-expected.txt:
- 12:48 AM Changeset in webkit [151096] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip 2 webaudio tests that are failing due to the onended event not getting
fired.
- platform/efl/TestExpectations:
- 12:44 AM Changeset in webkit [151095] by
-
- 11 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several test cases on EFL.
- platform/efl-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
- platform/efl-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
- platform/efl-wk2/fast/dynamic/002-expected.txt:
- platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.png:
- platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
- platform/efl/fast/dynamic/002-expected.png:
- platform/efl/fast/table/007-expected.png:
- platform/efl/fast/table/007-expected.txt:
- platform/efl/fast/table/colspanMinWidth-expected.png:
- platform/efl/fast/table/colspanMinWidth-expected.txt:
- platform/efl/fast/table/spanOverlapRepaint-expected.png:
- platform/efl/fast/table/spanOverlapRepaint-expected.txt:
- 12:14 AM Changeset in webkit [151094] by
-
- 37 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several mozilla tables layout tests for EFL port.
- platform/efl/tables/mozilla/bugs/bug13169-expected.png:
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17138-expected.png:
- platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17548-expected.png:
- platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
- platform/efl/tables/mozilla/bugs/bug220536-expected.png:
- platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6304-expected.png:
- platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
- platform/efl/tables/mozilla/bugs/bug73321-expected.png:
- platform/efl/tables/mozilla/bugs/bug73321-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8858-expected.png:
- platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
- platform/efl/tables/mozilla/core/bloomberg-expected.png:
- platform/efl/tables/mozilla/core/bloomberg-expected.txt:
- platform/efl/tables/mozilla/core/cell_heights-expected.png:
- platform/efl/tables/mozilla/core/cell_heights-expected.txt:
- platform/efl/tables/mozilla/other/test6-expected.png:
- platform/efl/tables/mozilla/other/test6-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- 12:09 AM Changeset in webkit [151093] by
-
- 2 edits in trunk/Source/WTF
[WTF] Add OwnArrayPtr vectortraits template
https://bugs.webkit.org/show_bug.cgi?id=117131
Reviewed by Darin Adler.
To support Vector<OwnArrayPtr<P>>, which will be used by EFL port.
- wtf/VectorTraits.h:
