⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 8, 2013:

11:36 PM Changeset in webkit [151353] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Coordinated Graphics] Pass the ownership of GraphicsSurface explicitly
​https://bugs.webkit.org/show_bug.cgi?id=117379

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-06-08
Reviewed by Noam Rosenthal.

When creating WebCoordinatedSurface with GraphicsSurface, it is clearer
to pass the ownership of the created GraphicsSurface explicitly.

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::create):

10:38 PM Changeset in webkit [151352] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source

fourthTier: Recursive deadlock in DFG::ByteCodeParser
​https://bugs.webkit.org/show_bug.cgi?id=117376

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Leave the lock early to prevent a deadlock beneath get().

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

Source/WTF:

Reviewed by Mark Hahnenberg.

I've often wanted to leave a lock early. Now I have that power!

  • wtf/Locker.h:

(WTF::Locker::Locker):
(WTF::Locker::~Locker):
(Locker):
(WTF::Locker::unlockEarly):
(WTF::Locker::lock):

7:43 PM Changeset in webkit [151351] by igor.o@sisa.samsung.com
  • 4 edits
    3 adds in trunk

before/after generated content is not working with HTMLSummaryElement and HTMLDetailsElement.
​https://bugs.webkit.org/show_bug.cgi?id=117374

Source/WebCore:

Allow before/after pseudo generated content be added in HTMLDetailsElement and HTMLSumamaryElement.

Reviewed by Ryosuke Niwa.

Test: fast/css-generated-content/details-summary-before-after.html

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::childShouldCreateRenderer):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::childShouldCreateRenderer):

LayoutTests:

Reviewed by Ryosuke Niwa.

  • fast/css-generated-content/details-summary-before-after.html: Added.
  • platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
  • platform/mac/fast/css-generated-content/details-summary-before-after-expected.png: Added
4:58 PM Changeset in webkit [151350] by kalyan.kondapally@intel.com
  • 2 edits
    2 adds in trunk/LayoutTests

[EFL][WebGL] Enable webgl-background-color test.
​https://bugs.webkit.org/show_bug.cgi?id=111428

Reviewed by Christophe Dumez.

This patch adds platform specific test expectation files for the
test and enables it for efl port.

  • platform/efl/TestExpectations:
  • platform/efl/compositing/webgl/webgl-background-color-expected.png: Added.
  • platform/efl/compositing/webgl/webgl-background-color-expected.txt: Added.
2:42 PM Changeset in webkit [151349] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] TestWebKitAPI fails to link.
​https://bugs.webkit.org/show_bug.cgi?id=117345

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-06-08
Reviewed by Brent Fulgham.

Need to link with WTF.lib.

  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
2:33 PM Changeset in webkit [151348] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl] Allow headers with empty value
​https://bugs.webkit.org/show_bug.cgi?id=117344

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-06-08
Reviewed by Brent Fulgham.

No new tests, already covered by:
http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
http/tests/xmlhttprequest/post-blob-content-type-sync.html

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

1:36 PM Changeset in webkit [151347] by mark.lam@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Removed bogus assertion in CallFrame::setLocationAsBytecodeOffset().
​https://bugs.webkit.org/show_bug.cgi?id=117373.

Reviewed by Oliver Hunt.

The assertion wrongly assumes that the incoming offset argument is in
units of bytes. This is not true. It is in units of Instruction*. Hence,
the assertion which checks for the low 2 bits to be clear can fail.

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::setLocationAsBytecodeOffset):

4:34 AM Changeset in webkit [151346] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl] Handling of blob elements is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=117301

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-06-08
Reviewed by Kenneth Rohde Christiansen.

No new tests, covered by existing ones:
http/tests/fileapi/xhr-send-form-data-filename-escaping.html
http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::getFormElementsCount): Resolve Blob elements.

Jun 7, 2013:

7:11 PM Changeset in webkit [151345] by fpizlo@apple.com
  • 28 edits
    2 deletes in branches/dfgFourthTier/Source/JavaScriptCore

Unreviewed, roll out ​http://trac.webkit.org/changeset/151342
It broke Kraken crypto tests in debug build. That results in a pretty bad
loss of test coverage.

(JSC):
(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:

(JIT):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emitSlow_op_sub):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

  • jit/JITExceptions.cpp:

(JSC):
(JSC::genericThrow):

  • jit/JITExceptions.h:

(ExceptionHandler):
(JSC):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_strcat):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emit_op_strcat):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:

(JSC):

  • jit/JITStubsARM.h:

(JSC):

  • jit/JITStubsARMv7.h:

(JSC):

  • jit/JITStubsMIPS.h:

(JSC):

  • jit/JITStubsSH4.h:

(JSC):

  • jit/JITStubsX86.h:

(JSC):

  • jit/JITStubsX86_64.h:

(JSC):

  • jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

  • jit/SlowPathCall.h: Removed.
  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):
(SlowPathReturnType):
(JSC::LLInt::encodeResult):
(JSC::LLInt::decodeResult):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/CommonSlowPaths.cpp: Removed.
  • runtime/CommonSlowPaths.h:
  • runtime/JSCJSValue.h:

(JSValue):

5:11 PM Changeset in webkit [151344] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Coalesce multiple calls to WebPageProxy::windowAndViewFramesChanged
​https://bugs.webkit.org/show_bug.cgi?id=117364
<rdar://problem/14042099>

Reviewed by Geoffrey Garen.

-[WKView _updateWindowAndViewFrames] can be called many times per run loop iteration so coalesce calls
to WebPageProxy::windowAndViewFrames using dispatch_async.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

5:05 PM Changeset in webkit [151343] by fpizlo@apple.com
  • 10 edits in branches/dfgFourthTier

fourthTier: don't insert ForceOSRExits except for inadequate coverage
​https://bugs.webkit.org/show_bug.cgi?id=117363

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Previously (in ​http://trac.webkit.org/changeset/151303) I made it so that we
inserted ForceOSRExits more eagerly. I now think it's better to have
contradictions execute normally and exit with full OSR exit profiling. It's
better at catching the few cases where the DFG will end up with different
types than the baseline engines.

This simplifies a bunch of code. For example it gets rid of
ConstantFoldingPhase::paintUnreachableCode().

You can think of this as a partial roll-out of r151303, except that it uses
the facilities introduced by that patch to give us run-time assertions that
check the CFA's correctness: if the CFA thought that something was a
contradiction but the code didn't exit, we'll now trap.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::startExecuting):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::filter):
(JSC::DFG::AbstractState::filterArrayModes):
(JSC::DFG::AbstractState::filterByValue):
(DFG):

  • dfg/DFGAbstractState.h:

(AbstractState):
(JSC::DFG::AbstractState::filter):
(JSC::DFG::AbstractState::filterArrayModes):
(JSC::DFG::AbstractState::filterByValue):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(ConstantFoldingPhase):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

LayoutTests:

Reviewed by Mark Hahnenberg.

Convert this test, since this was the test originally added for
ConstantFoldingPhase::paintUnreachableCode(). I wanted to make sure that I had good coverage
for this since I am removing that method.

  • fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop-expected.txt:
  • fast/js/script-tests/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.js:
4:46 PM Changeset in webkit [151342] by msaboff@apple.com
  • 28 edits
    2 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: The baseline jit and LLint should use common slow paths
​https://bugs.webkit.org/show_bug.cgi?id=116889

Reviewed by Filip Pizlo.

Moved the llint_slow_paths that return JSValue along with several others to CommonSlowPaths.cpp.
Eliminated the related JIT stubs. Changes the baseline JIT to call these new common stubs.
Added a simple slow path call class that uses argument registers or the stack instead of
JITStackFrame. Changes the exception mechanism for to check for an exception after making
a slowpath call instead of returning to the handler directly form the slowpath function.

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:

(JIT):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emitSlow_op_sub):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

  • jit/JITExceptions.cpp:

(JSC::getExceptionLocation):
(JSC::genericThrow):
(JSC::jitThrowNew):

  • jit/JITExceptions.h:

(ExceptionHandler):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_strcat):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emit_op_strcat):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::cti_vm_throw_slowpath):

  • jit/JITStubs.h:
  • jit/JITStubsARM.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsMIPS.h:
  • jit/JITStubsSH4.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
  • jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

  • jit/SlowPathCall.h: Added.

(JITSlowPathCall):
(JSC::JITSlowPathCall::JITSlowPathCall):
(JSC::JITSlowPathCall::call):

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

  • llint/LLIntSlowPaths.cpp:

(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/CommonSlowPaths.cpp: Added.

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

(SlowPathReturnType):
(JSC::encodeResult):
(JSC::decodeResult):

  • runtime/JSCJSValue.h:

(JSValue):

4:25 PM Changeset in webkit [151341] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

MathML line fraction needs to parse number values
​https://bugs.webkit.org/show_bug.cgi?id=117305

Unreviewed. Rebaseline math fractions test on EFL.

  • platform/efl/mathml/presentation/fractions-expected.png:
  • platform/efl/mathml/presentation/fractions-expected.txt:
4:21 PM Changeset in webkit [151340] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

MathML line fraction needs to parse number values
​https://bugs.webkit.org/show_bug.cgi?id=117305

Unreviewed. Rebaseline math fractions test on GTK.

  • platform/gtk/mathml/presentation/fractions-expected.png:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
3:36 PM Changeset in webkit [151339] by Alexandru Chiculita
  • 3 edits in trunk/Source/WebCore

[CSS Regions] Layers inside the RenderFlowThread should be collected by the layer of RenderView
​https://bugs.webkit.org/show_bug.cgi?id=117270

Reviewed by David Hyatt.

RenderNamedFlowThreads are attached to the RenderView, but they are painted
and hit-tested through their regions. The easiest way to prevent the RenderView
from seeing the RenderNamedFlowThreads as its own children was to avoid collecting
the layers of the RenderNamedFlowThreads as children layers of the RenderView.

However, most of the code is analyzing the layers tree starting from the root,
so having the RenderNamedFlowThread participate in the layer tree is needed
in order to enable compositing for layers inside the flow thread.

This patch makes the RenderNamedFlowThread visible to the RenderView, but
ignores it when iterates the children of the RenderView in paint and hit-test methods.

No new tests, no visible changes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateLayerBounds):
(WebCore::RenderLayer::collectLayers):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

3:04 PM Changeset in webkit [151338] by betravis@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSS Exclusions][CSS Shapes] Incorrect compile flag in LayoutState.h
​https://bugs.webkit.org/show_bug.cgi?id=117318

Reviewed by Alexandru Chiculita.

m_exclusionShapeInsideInfo should be guarded by the CSS_SHAPES flag,
not the CSS_EXCLUSIONS flag.

No tests required.

  • rendering/LayoutState.h:
2:53 PM Changeset in webkit [151337] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Get rid of not very helpful test that fails only on some machines because xcrun is not installed.

Rubberstamped by Ryousuke Niwa.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_build_check):

2:27 PM Changeset in webkit [151336] by Christophe Dumez
  • 147 edits in trunk/Source

Get rid of outdated raises() from Web IDL
​https://bugs.webkit.org/show_bug.cgi?id=117350

Reviewed by Darin Adler.

Source/WebCore:

Stop using "raises()" in the IDL as this is no longer part of the Web IDL
specification. Web IDL no longer specifies exceptions for operations. Instead
it is now explained in prose.

WebKit still needs to know if the method can throw an exception (but does not
need the exception name) so this patch adds a WebKit specific IDL extended
attribute: [RaisesException]. The naming is consistent with Blink.

This results in more standard and concise IDL. This also simplifies a lot
the code of the IDL parser.

No new tests, no behavior change.

  • Modules/battery/BatteryManager.idl:
  • Modules/encryptedmedia/MediaKeySession.idl:
  • Modules/encryptedmedia/MediaKeys.idl:
  • Modules/filesystem/DirectoryEntrySync.idl:
  • Modules/filesystem/DirectoryReaderSync.idl:
  • Modules/filesystem/EntrySync.idl:
  • Modules/filesystem/FileEntrySync.idl:
  • Modules/filesystem/FileWriter.idl:
  • Modules/filesystem/FileWriterSync.idl:
  • Modules/filesystem/WorkerContextFileSystem.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/NavigatorMediaStream.idl:
  • Modules/mediastream/RTCDTMFSender.idl:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/navigatorcontentutils/NavigatorContentUtils.idl:
  • Modules/networkinfo/NetworkInfoConnection.idl:
  • Modules/notifications/Notification.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/speech/SpeechRecognition.idl:
  • Modules/vibration/NavigatorVibration.idl:
  • Modules/webaudio/AudioBuffer.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/WorkerContextWebDatabase.idl:
  • Modules/websockets/WebSocket.idl:
  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):
(GenerateFunctions):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/IDLParser.pm:

(parseOperationRest):

  • bindings/scripts/test/TestEventTarget.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestSupplemental.idl:
  • bindings/scripts/test/TestTypedefs.idl:
  • css/CSSHostRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSSupportsRule.idl:
  • css/FontLoader.idl:
  • css/MediaList.idl:
  • css/WebKitCSSMatrix.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/DataTransferItemList.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/EventTarget.idl:
  • dom/MessagePort.idl:
  • dom/MutationObserver.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeIterator.idl:
  • dom/Range.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • dom/WebKitNamedFlow.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • html/DOMTokenList.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDialogElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLVideoElement.idl:
  • html/MediaController.idl:
  • html/TimeRanges.idl:
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/DOMPath.idl:
  • html/canvas/DataView.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/track/AudioTrackList.idl:
  • html/track/TextTrack.idl:
  • html/track/TextTrackCue.idl:
  • html/track/TextTrackList.idl:
  • html/track/VideoTrackList.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Crypto.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • page/History.idl:
  • page/Performance.idl:
  • storage/Storage.idl:
  • svg/SVGAngle.idl:
  • svg/SVGAnimationElement.idl:
  • svg/SVGColor.idl:
  • svg/SVGDocument.idl:
  • svg/SVGLength.idl:
  • svg/SVGLengthList.idl:
  • svg/SVGLocatable.idl:
  • svg/SVGMatrix.idl:
  • svg/SVGNumberList.idl:
  • svg/SVGPaint.idl:
  • svg/SVGPathSegList.idl:
  • svg/SVGPointList.idl:
  • svg/SVGStringList.idl:
  • svg/SVGTextContentElement.idl:
  • svg/SVGTransformList.idl:
  • testing/InternalSettings.idl:
  • testing/Internals.idl:
  • workers/AbstractWorker.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/Worker.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathExpression.idl:
  • xml/XPathResult.idl:

Source/WebKit/win:

Replace raises() by [RaisesException].

  • Interfaces/DOMEvents.idl:
1:52 PM Changeset in webkit [151335] by beidson@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r151088): Crash navigating away from non-loaded main resources with non-loaded scripts.
<rdar://problem/14052886> and ​https://bugs.webkit.org/show_bug.cgi?id=117278

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/slow-loading-page-with-slow-script.php

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::isPendingScriptReady): The script runner might be told about a script

after it has already been detached (the main resource load has finished/failed/cancelled).
Don't dereference a null document in that case.

LayoutTests:

  • http/tests/navigation/slow-loading-page-with-slow-script-expected.txt: Added.
  • http/tests/navigation/slow-loading-page-with-slow-script.php: Added.
1:33 PM Changeset in webkit [151334] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

Compile WebCoreTestShimLibrary.cpp on iOS, but exclude the Carbon bits
​https://bugs.webkit.org/show_bug.cgi?id=117360

Reviewed by Mark Rowe.

In r150114 we tried to make the WebCoreTestShim target build on iOS by
excluding its only source file from the build. While this allowed the
target to build, it prevented the target's product (WebCoreTestShim.dylib)
from being created. This causes xcodebuild to fail if you ask it to
install the target.

Fix this by building the target's product on iOS. Just use the
preprocessor to exclude the bits that won't build on iOS.

  • Configurations/WebCoreTestShim.xcconfig:
  • testing/WebCoreTestShimLibrary.cpp:
1:25 PM Changeset in webkit [151333] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Unreviewed, fix release build.

  • ftl/FTLLink.cpp:
1:16 PM Changeset in webkit [151332] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Reproducible crash with triple-finger-tap "define word" gesture on a Netflix video
​https://bugs.webkit.org/show_bug.cgi?id=117020

Patch by Thomas Deniau <​deniau@apple.com> on 2013-06-07
Reviewed by Ryosuke Niwa.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation):
Don't invoke the Dictionary lookup when we failed to extract the range of the token
surrounding the tapped position.

1:11 PM Changeset in webkit [151331] by Hugo Parente Lima
  • 2 edits in trunk/Tools

[Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
​https://bugs.webkit.org/show_bug.cgi?id=117315

Reviewed by Benjamin Poulain.

Qt doesn't use the default values specified on FeatureList since r44681,
this patch just remove a bit of noise.

  • Scripts/webkitperl/FeatureList.pm:
12:07 PM Changeset in webkit [151330] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed. Makefile fix. Copy WTF.dll over as well.

  • WTF.vcxproj/WTF.make:
11:23 AM Changeset in webkit [151329] by mark.lam@apple.com
  • 10 edits in branches/dfgFourthTier/Source/JavaScriptCore

32-bit CallFrame::Location should use Instruction* for BytecodeLocation, not bytecodeOffset.
​https://bugs.webkit.org/show_bug.cgi?id=117327.

Reviewed by Michael Saboff.

  • Renamed CallFrame::Location's Type to TypeTag.
  • Made the CallFrame::Location::TypeTag private, and provided type specific encoder functions. This reduces verbosity in client code.
  • Fixed the DFG's reifyInlinedCallFrames() on 32-bit ports to store a bytecode Instruction* in the CallFrame location instead of a bytecode offset.
  • Fixed places in JIT and FTL code which populate the CallFrame location (i.e. ArgumentCount tag) to use a Location encoder instead of storing the bytecodeOffset directly. This doesn't make any semantic difference, but it does assert that the stored value does not have bits where we would expect Location TypeTags to be.
  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::beginCall):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::setLocationAsBytecodeOffset):

  • interpreter/CallFrame.h:

(Location):

  • interpreter/CallFrameInlines.h:

(JSC::CallFrame::Location::encodeAsBytecodeOffset):
(JSC::CallFrame::Location::encodeAsBytecodeInstruction):
(JSC::CallFrame::Location::encodeAsCodeOriginIndex):
(JSC::CallFrame::Location::encodeAsInlinedCode):
(JSC::CallFrame::Location::isBytecodeLocation):
(JSC::CallFrame::setIsInlinedFrame):
(JSC::CallFrame::hasLocationAsBytecodeOffset):
(JSC::CallFrame::setLocationAsBytecodeOffset):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITInlines.h:

(JSC::JIT::updateTopCallFrame):

11:20 AM Changeset in webkit [151328] by commit-queue@webkit.org
  • 5 edits
    1 delete in trunk/Source/WTF

Unreviewed, rolling out r151318.
​http://trac.webkit.org/changeset/151318
​https://bugs.webkit.org/show_bug.cgi?id=117356

Broke Windows Release Build (Requested by bfulgham on
#webkit).

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTFCommon.props:
  • WTF.vcxproj/WTFCoreFoundation.props: Removed.
  • WTF.vcxproj/WTFDebug.props:
  • WTF.vcxproj/WTFRelease.props:
10:59 AM Changeset in webkit [151327] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

REGRESSION: Lines jump up and down while typing Chinese or Japanese
​https://bugs.webkit.org/show_bug.cgi?id=115931

Reviewed by Darin Adler.

The bug was caused by Font::width caching the width of text even when the font fallbacks existed when fallbackFonts
argument was null; because of this, a later call to Font::width was returning the width without filling up
fallbackFonts even if it was not null this time.

Fixed the bug by adding a local fallback fonts hash set, and checking the emptiness of this variable in Font::width.
Also added pass fallbackFonts around in various places to make use of the cached font fallbacks.

No new tests. Unfortunately I haven't been able to make a reliable reduction for this bug.

  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::measureHyphenWidth):
(WebCore::setLogicalWidthForTextRun):
(WebCore::textWidth):
(WebCore::tryHyphenating):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

  • rendering/RenderText.cpp:

(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):

10:22 AM Changeset in webkit [151326] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Reenable the DFG optimization fixpoint now that it's profitable to do so with concurrent compilation
​https://bugs.webkit.org/show_bug.cgi?id=117331

Rubber stamped by Sam Weinig.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

10:15 AM Changeset in webkit [151325] by zandobersek@gmail.com
  • 4 edits in trunk

[regression] build failure WebKitFontFamilyNames.h missing
​https://bugs.webkit.org/show_bug.cgi?id=117178

Reviewed by Sam Weinig.

.:

  • GNUmakefile.am: List platform_sources under the BUILT_SOURCES list.

Source/WebCore:

  • GNUmakefile.am: Make libPlatform and other sources depend on the generated platform sources. This should prevent

build failures in source code that's depending on the generated platform sources.

9:37 AM Changeset in webkit [151324] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Weird behaviour and no clues to the user when the shared memory file can't be opened
​https://bugs.webkit.org/show_bug.cgi?id=117063

Patch by Enrique Ocana Gonzalez <​eocanha@igalia.com> on 2013-06-07
Reviewed by Anders Carlsson.

Log error message when the shared memory file can't be opened in
Unix platform using a release build

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create):

8:57 AM Changeset in webkit [151323] by Chris Fleizach
  • 10 edits in trunk

MathML line fraction needs to parse number values
​https://bugs.webkit.org/show_bug.cgi?id=117305

Reviewed by Darin Adler.

Source/WebCore:

The line fraction thickness was not handling arbitrary thickness numbers.
The accessibility code was not handling default values for line thickness, so
it made sense to have AX rely on the RenderFraction object to retrive the thickness.

Modified existing tests to cover new behavior.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::mathLineThickness):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

  • rendering/mathml/RenderMathMLFraction.h:

(WebCore::RenderMathMLFraction::lineThickness):
(WebCore::toRenderMathMLFraction):

LayoutTests:

Math fractions test now encodes for an arbitrary thickness number.
Accessibility test handles the default line thickness.

  • mathml/presentation/fractions.xhtml:
  • platform/mac/accessibility/mathml-line-fraction-expected.txt:
  • platform/mac/accessibility/mathml-line-fraction.html:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
8:38 AM WebKitIDL edited by Christophe Dumez
Add documentation for [GetterRaisesException] / … (diff)
8:36 AM Changeset in webkit [151322] by Claudio Saavedra
  • 4 edits in trunk/Source/WebCore

[rendering] Use foreground color to render the overtype caret
​https://bugs.webkit.org/show_bug.cgi?id=117347

Reviewed by Darin Adler.

Currently, the overtype caret is rendered using the colors of
a normal selection, which is confusing. This patch enables RenderObject
to differentiate between a normal and a overtype caret selection,
in order to use a different color for the latter.

Also, let RenderView update the selection if this is unchanged
when going from a overtype caret to one character selection and
viceversa.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionBackgroundColor):

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection):

  • rendering/RenderView.h:
8:32 AM Changeset in webkit [151321] by Christophe Dumez
  • 67 edits in trunk/Source/WebCore

Get rid of outdated getter / setter raises from Web IDL
​https://bugs.webkit.org/show_bug.cgi?id=117346

Reviewed by Darin Adler.

Stop using "getter / setter raises" in the IDL as this is no longer part of
the Web IDL specification. Web IDL no longer specifies exceptions for
attribute getters or setters. Instead, it is now explained in prose.

WebKit still needs to know if the getter / setter can throw an exception
(but does not need the exception name) so this patch adds 2 WebKit specific
IDL extended attributes: [GetterRaisesException] / [SetterRaisesException].
The naming is consistent with Blink.

This results in more standard and concise IDL. This also simplifies a lot
the code of the IDL parser.

Note that this patch does not remove "raises()" from the IDL methods yet.
This should be replaced by [RaisesException] IDL extended attribute in a
later patch.

No new tests, no behavior change.

  • Modules/indexeddb/IDBRequest.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescription.idl:
  • Modules/mediastream/RTCStatsResponse.idl:
  • Modules/webaudio/AnalyserNode.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webdatabase/SQLResultSet.idl:
  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateFunctions):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/IDLParser.pm:

(parseAttributeRest):
(parseAttributeRestOld):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedefs.idl:
  • css/CSSCharsetRule.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • css/MediaList.idl:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/Document.idl:
  • dom/Node.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Range.idl:
  • dom/ShadowRoot.idl:
  • dom/TreeWalker.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMeterElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLProgressElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/MediaController.idl:
  • html/track/TextTrackCue.idl:
  • html/track/TextTrackRegion.idl:
  • page/DOMWindow.idl:
  • storage/Storage.idl:
  • svg/SVGAltGlyphElement.idl:
  • svg/SVGAngle.idl:
  • svg/SVGAnimatedBoolean.idl:
  • svg/SVGAnimatedEnumeration.idl:
  • svg/SVGAnimatedInteger.idl:
  • svg/SVGAnimatedNumber.idl:
  • svg/SVGAnimatedString.idl:
  • svg/SVGElement.idl:
  • svg/SVGGlyphRefElement.idl:
  • svg/SVGLangSpace.idl:
  • svg/SVGLength.idl:
  • svg/SVGPreserveAspectRatio.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGScriptElement.idl:
  • svg/SVGStyleElement.idl:
  • svg/SVGViewSpec.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XPathResult.idl:
8:19 AM Changeset in webkit [151320] by kangil.han@samsung.com
  • 3 edits in trunk/Source/WebCore

Remove unused header includes in Document
​https://bugs.webkit.org/show_bug.cgi?id=117339

Reviewed by Andreas Kling.

Minor code cleanup.

  • dom/Document.cpp:
  • dom/Document.h:
8:12 AM Changeset in webkit [151319] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Unnecessary use of Layout types in GraphicsLayer::paintGraphicsLayerContents
​https://bugs.webkit.org/show_bug.cgi?id=117340

Reviewed by Darin Adler.

There is no reason to use Layout types when copying from Int types to Int types.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::paintGraphicsLayerContents):

7:43 AM Changeset in webkit [151318] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WTF

[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
​https://bugs.webkit.org/show_bug.cgi?id=117294

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-06-07
Reviewed by Darin Adler.

WinCairo build should not use CoreFoundation.

  • WTF.vcxproj/WTF.vcxproj: Exclude unneeded file from WinCairo build.
  • WTF.vcxproj/WTFCommon.props: Removed CoreFoundation.lib from common props.
  • WTF.vcxproj/WTFCoreFoundation.props: Added.
  • WTF.vcxproj/WTFDebug.props: Inherit from WTFCoreFoundations.props.
  • WTF.vcxproj/WTFRelease.props: Inherit from WTFCoreFoundations.props.
7:40 AM Changeset in webkit [151317] by kihong.kwon@samsung.com
  • 3 edits in trunk/LayoutTests

REGRESSION: r149001 made proximity test fail.
​https://bugs.webkit.org/show_bug.cgi?id=117343

Reviewed by Christophe Dumez.

Update window-property.html test cases for Device Proximity Event.
The global constructors are no longer enumerable after r149001.

  • proximity/window-property-expected.txt:
  • proximity/window-property.html:
6:36 AM Changeset in webkit [151316] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL][GTK] TextCheckerEnchant uses deprecated enchant_dict_add_to_personal
​https://bugs.webkit.org/show_bug.cgi?id=117335

Reviewed by Christophe Dumez.

enchant_dict_add_to_personal has been deprecated at r22321 in Enchant repository.

No behavior change, no new tests needed.

  • platform/text/enchant/TextCheckerEnchant.cpp:

(WebCore::TextCheckerEnchant::learnWord):
Use enchant_dict_add instead of enchant_dict_add_to_personal.

6:09 AM Changeset in webkit [151315] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping failing tests.
​https://bugs.webkit.org/show_bug.cgi?id=117295
​https://bugs.webkit.org/show_bug.cgi?id=117336
​https://bugs.webkit.org/show_bug.cgi?id=117338

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-06-07

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt/TestExpectations:
5:26 AM Changeset in webkit [151314] by g.czajkowski@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Context menu spellchecking items are not available when "Check Spelling While Typing" is off
​https://bugs.webkit.org/show_bug.cgi?id=117190

Reviewed by Christophe Dumez.

Context menu items (suggestions, learn and ignore word) are not available
due to missing dictionary. To get the suggestions for the misspelled word,
the dictionary has to be loaded first.

WebKit loads the default dictionary when check spelling while typing is being enabled.
However, context menu spellchecking items should be present even if this setting is off.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
Load the user's default dictionary to ensure context menu spellchecking items.
The dictionary is loaded asynchronously so it shouldn't delay application.

  • UIProcess/API/efl/ewk_text_checker.h:

Update doc. Spelling suggestions, learn and ignore word should be available
independently of checking spelling while typing setting.

  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(onContextMenuShow):
(TEST_F):
Add two unit tests to check whether the default dictionary is loaded and
whether the context menu spelling items are available.

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Not set the default dictionary while enabling the setting, it's already loaded.

4:20 AM Changeset in webkit [151313] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Implement customContextMenuItemSelected
​https://bugs.webkit.org/show_bug.cgi?id=117298

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-07
Reviewed by Christophe Dumez.

When custom context menu item is selected using ewk API, the feedback is not
sent back to application, as customContextMenuItemSelected was unimplemented in
contextMenuClientEfl.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::customContextMenuItemSelected):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/ewk_view.h: added custom_item_selected callback.
  • UIProcess/efl/ContextMenuClientEfl.cpp:

(customContextMenuItemSelected):
(ContextMenuClientEfl::ContextMenuClientEfl):

3:35 AM Changeset in webkit [151312] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Frame flattening: crash when child iframe is removed during beforeload.
​https://bugs.webkit.org/show_bug.cgi?id=116220

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-07
Reviewed by Antti Koivisto.

FrameView can get destroyed in updateWidget(). Normally, it is protected by layout()
but with frame flattening on, it can also be called asynchronously through the
post layout timer.

Source/WebCore:

Test: fast/frames/flattening/crash-remove-iframe-during-object-beforeload.html

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

LayoutTests:

  • fast/frames/flattening/crash-remove-iframe-during-object-beforeload-expected.txt: Added.
  • fast/frames/flattening/crash-remove-iframe-during-object-beforeload.html: Added.
3:07 AM Changeset in webkit [151311] by commit-queue@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

[CSS Regions] The presence of a flow-from declaration in a CSS rule using :hover effectively disables the rule
​https://bugs.webkit.org/show_bug.cgi?id=111585

Created tests for changing flow-into and flow-from inside the :hover pseudo-class.
The actual problem was fixed along with ​https://bugs.webkit.org/show_bug.cgi?id=7555

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-07
Reviewed by Antti Koivisto.

  • fast/regions/hover-single-flow-from-none-expected.html: Added.
  • fast/regions/hover-single-flow-from-none.html: Added.
  • fast/regions/hover-single-flow-from-other-expected.html: Added.
  • fast/regions/hover-single-flow-from-other.html: Added.
  • fast/regions/hover-single-flow-into-none-expected.html: Added.
  • fast/regions/hover-single-flow-into-none.html: Added.
  • fast/regions/hover-single-flow-into-other-expected.html: Added.
  • fast/regions/hover-single-flow-into-other.html: Added.
1:57 AM Changeset in webkit [151310] by Carlos Garcia Campos
  • 11 edits in trunk/Source/WebCore

Make CachedResource virtual methods overridden in derived classes private
​https://bugs.webkit.org/show_bug.cgi?id=117289

Reviewed by Darin Adler.

And mark them as OVERRIDE too. Also mark all CachedResource
derived classes as FINAL.

  • inspector/InspectorPageAgent.cpp:

(WebCore::cachedResourcesForFrame):

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedShader.h:
  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.h:
1:00 AM Changeset in webkit [151309] by mihnea@adobe.com
  • 7 edits
    2 adds in trunk

[CSSRegions] getBoundingClientRect wrong for inline content nodes
​https://bugs.webkit.org/show_bug.cgi?id=117290

Reviewed by Alexandru Chiculita.

Source/WebCore:

getBoundingClientRect returned incorrect values for inline content that
was directly flowed inside regions because its mapLocalToContainer was not
properly patched as its RenderBox counterpart. This patch adds mapLocalToContainer
method in RenderFlowThread so that is properly called for all the elements inside the
flow thread.

Also, modified offsetFromContainer so that if the container is the flow thread,
offsetDependsOnPoint is set to true which further sets RenderGeometryMapStep::m_isNonUniform
to true for each step added in pushMappingToContainer methods.

Test: fast/regions/flowed-inline-content-bounding-client-rect.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::pushMappingToContainer):
(WebCore::RenderBox::offsetFromContainer):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::mapLocalToContainer):

  • rendering/RenderFlowThread.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetFromContainer):

LayoutTests:

Add test for inline content nodes flowed in regions and in regions with transform.

  • fast/regions/flowed-inline-content-bounding-client-rect-expected.txt: Added.
  • fast/regions/flowed-inline-content-bounding-client-rect.html: Added.
12:51 AM Changeset in webkit [151308] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Implement colorpicker for HTML5 input type color on Minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=115890

Patch by Jungsik Tae <​davidtlay88@gmail.com> on 2013-06-07
Reviewed by Christophe Dumez.

When user clicks HTML5 input type color,
color selector window is created on browser object by using elm_colorchooser_add().
It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
The evas_object_color_set() sets a color value returning to browser.

  • MiniBrowser/efl/main.c:

(window_free): When we delete parent window, deleting the colorpicker object.
(on_color_changed): Change color of rectangle to show color selected by user.
(on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
(on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
(on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
(on_color_picker_dismiss): Delete colorpicker object.
(on_color_picker_request): Create colorpicker window object.
(window_create):

Note: See TracTimeline for information about the timeline view.