Context Navigation

← Previous Period
Next Period →

Timeline

Jun 15, 2013:

7:21 PM Changeset in webkit [151620] by Darin Adler

6 edits in trunk/Source/WebCore

Move Pasteboard::getStringSelection to Editor, fixing a layering violation
https://bugs.webkit.org/show_bug.cgi?id=117673

Reviewed by Ryosuke Niwa.

editing/Editor.h: Added stringSelectionForPasteboardWithImageAltText.

editing/mac/EditorMac.mm:

(WebCore::Editor::stringSelectionForPasteboard): Moved code here from the Pasteboard
class, since all the Pasteboard class did really was turn around and call back here.
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText): Added. Variant of
the function above that includes image alt text. Separate named functions are often
the best pattern for something like this unless there are many different combinations.

platform/Pasteboard.h: Remove the Mac-only Pasteboard::getStringSelectioon.

platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::writeSelection):

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelectionForTypes):
Call the two new functions instead of the old Pasteboard::getStringSelection.

7:15 PM Changeset in webkit [151619] by Darin Adler

3 edits in trunk/Source/WebCore

Support using clang instead of gcc for bindings preprocessing
https://bugs.webkit.org/show_bug.cgi?id=117674

Reviewed by Sam Weinig.

I couldn't build on my computer because I don't have gcc installed.
This is my cut at fixing it.

bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces): Use clang if present.

bindings/scripts/preprocessor.pm:

(applyPreprocessor): Ditto.

6:49 PM Changeset in webkit [151618] by fpizlo@apple.com

8 edits in branches/dfgFourthTier/Source

Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy
https://bugs.webkit.org/show_bug.cgi?id=117676

Reviewed by Sam Weinig.

Source/JavaScriptCore:

CodeBlock now caches m_hash, and the DFG Driver will force its computation if we're doing debug dumps of any kind.

Also made sure that CodeBlock::CodeBlock initializes all of its fields; it was previously missing the
initialization of m_capabilityLevelState.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hash):
(JSC::CodeBlock::CodeBlock):

bytecode/CodeBlock.h:

(CodeBlock):

bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::CodeBlockHash):

bytecode/CodeBlockHash.h:

(CodeBlockHash):
(JSC::CodeBlockHash::isSet):
(JSC::CodeBlockHash::operator!):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

Source/WebCore:

Remove the broken hack for the concurrent JIT, since now the concurrent JIT won't use this code anymore.

No new tests because no new behavior.

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

3:56 PM Changeset in webkit [151617] by dino@apple.com

2 edits in trunk/Source/WebKit2

Crash in supportsSnapshotting
https://bugs.webkit.org/show_bug.cgi?id=117670
<rdar://problem/14059711>

Reviewed by Darin Adler.

Speculative fix for deferencing a null RefPtr in supportsSnapshotting.
It seems like it was possible to get in a state where the plugin machinery
would fire up and attempt to get a screenshot before there was an active
connection to the plugin process (usually under periods of high load, such
as opening a lot of tabs at once). In this case we're now returning false
from supportsSnapshotting, which will trigger the plugin to restart, but
that's better than requesting a snapshot on something that doesn't yet exist.

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::supportsSnapshotting): Guard for an empty connection object.

3:37 PM Changeset in webkit [151616] by fpizlo@apple.com

26 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should support op_switch_imm
https://bugs.webkit.org/show_bug.cgi?id=117559

Reviewed by Oliver Hunt.

Implement integer (i.e. immediate) switches in the DFG. Reduce the minimum
threshold for using op_switch.

Also get rid of edge code support, since we haven't used it in the year since
I introduced it. It was supposed to allow us to break critical edges late in
the backend, thus enabling global register allocation from an SSA-form graph.
But we aren't doing that so I figure we should just kill the code for now. It
would have made implementing switch harder.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::timesPtr):

assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::dumpWithName):
(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::dump):
(MacroAssemblerCodeRef):
(JSC::MacroAssemblerCodeRef::dump):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shrinkToFit):

bytecode/JumpTable.h:

(SimpleJumpTable):
(JSC::SimpleJumpTable::clear):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeToSuccessors):

dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGCommon.h:
dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::determineReachability):

dfg/DFGGraph.h:

(Graph):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JITCompiler):
(JSC::DFG::JITCompiler::blockHeads):

dfg/DFGNode.h:

(DFG):
(JSC::DFG::SwitchCase::SwitchCase):
(SwitchCase):
(SwitchData):
(JSC::DFG::SwitchData::SwitchData):
(Node):
(JSC::DFG::Node::isSwitch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::switchData):
(JSC::DFG::Node::numSuccessors):
(JSC::DFG::Node::successor):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::emitSwitchImmIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitch):
(JSC::DFG::SpeculativeJIT::linkBranches):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branch64):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

parser/Nodes.h:

(CaseBlockNode):

3:29 PM Changeset in webkit [151615] by fpizlo@apple.com

2 edits in branches/dfgFourthTier/Source/WTF

Printing a StringImpl* should really guard against NULL
https://bugs.webkit.org/show_bug.cgi?id=117675

Reviewed by Mark Hahnenberg.

wtf/PrintStream.cpp:

(WTF::printInternal):

8:44 AM Changeset in webkit [151614] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed. Reorder my email addresses.
https://bugs.webkit.org/show_bug.cgi?id=100122

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-06-15

Scripts/webkitpy/common/config/contributors.json:

Jun 14, 2013:

11:59 PM Changeset in webkit [151613] by robert@webkit.org

3 edits
2 adds in trunk

REGRESSION (r148367): Facebook and Twitter icons at macworld.com are stacked vertically, obscuring Twitter one
https://bugs.webkit.org/show_bug.cgi?id=117284

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/text/whitespace/inline-whitespace-wrapping-7.html

We were looking for line breaks in trailing collapsed whitespace even when inside a nowrap inline.
It's wrong to do this as we don't know yet if we will want or need to break - that decision has to
be deferred until we enter a part of the line that is autowrap.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

fast/text/whitespace/inline-whitespace-wrapping-7-expected.html: Added.
fast/text/whitespace/inline-whitespace-wrapping-7.html: Added.

9:42 PM Changeset in webkit [151612] by commit-queue@webkit.org

3 edits
2 adds in trunk

background-color is not preserved when inserting a new paragraph
https://bugs.webkit.org/show_bug.cgi?id=117138

Patch by Lukasz Gajowy <l.gajowy@samsung.com> on 2013-06-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

The style isn't copied because background-color isn't defined as inheritable property.

Test: editing/inserting/insert-paragraph-not-preserving-background-color.html

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
Passing EditingPropertiesInEffect instead of implicit parameter OnlyEditingInheritableProperties.

LayoutTests:

Adding layout test and expected result to reproduce the issue.

editing/inserting/insert-paragraph-with-font-and-background-color-expected.txt: Added.
editing/inserting/insert-paragraph-with-font-and-background-color.html: Added.

4:05 PM Changeset in webkit [151611] by abarth@webkit.org

3 edits
3 adds in trunk

Threaded HTML parser can ASSERT in some situations
https://bugs.webkit.org/show_bug.cgi?id=117662

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch merges https://chromium.googlesource.com/chromium/blink/+/3c0a112b42d72c7623f78463166dd7f04d680b4c

--->8---
The parser is supposed to stop processing data when there's a pending
location change, but before this CL we would actually process the first
token from every chunk when there was a pending location change.

If the first token in a chunk was a "script" start tag, that would put
the tree builder into TextMode, which can only process character
tokens. If the next chunk starts with another start tag token, the tree
builder would be sad and hit an ASSERT.

This CL reorders a couple lines in HTMLDocumentParser so that we check
for pending location changes before processing any tokens. This change
stops us from processing the first token from each chunk while there is
a pending location change.

This issue can reproduce on any platform, but it reproduced often on
Android because mobile markup often elides spaces between consecutive
script tags. If there are space characters between the script tags,
then those space characters will be the first ones processes in the
chunk, which doesn't trigger the ASSERT.
---8<---

Since we landed this patch in Blink, we've been able to reproduce this
issue on desktops as well. I spoke with rniwa in #webkit and he said
that WebKit doesn't have any current plans to enable the threaded
parser but that it was probably worth merging this patch anyway.

Test: http/tests/navigation/pending-location-change-assert.html

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):

LayoutTests:

http/tests/navigation/pending-location-change-assert-expected.txt: Added.
http/tests/navigation/pending-location-change-assert.html: Added.
http/tests/resources/slow-notify-done.php: Added.

3:49 PM Changeset in webkit [151610] by Patrick Gansterer

17 edits in trunk

Introduce USE(WINGDI) for the Windows port
https://bugs.webkit.org/show_bug.cgi?id=116138

Reviewed by Ryosuke Niwa.

Using USE(WINGDI) instead of OS(WINCE) will allow us to
compile the GDI based Windows port on WinNT too.

Source/cmake/OptionsWinCE.cmake:

Source/WebCore:

config.h:
platform/graphics/BitmapImage.h:
platform/graphics/FontPlatformData.h:
platform/graphics/GlyphBuffer.h:

(WebCore):
(GlyphBuffer):

platform/graphics/Gradient.h:

(Gradient):

platform/graphics/GraphicsContext.cpp:

(WebCore):

platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

platform/graphics/ImageBufferData.h:
platform/graphics/NativeImagePtr.h:

(WebCore):

platform/graphics/Path.h:
platform/graphics/Pattern.h:
plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::snapshot):

Source/WTF:

wtf/Platform.h:

3:40 PM Changeset in webkit [151609] by jer.noble@apple.com

10 edits in trunk/Source/WebCore

Report the memory cost of HTMLMediaElements to GC.
https://bugs.webkit.org/show_bug.cgi?id=117608

Reviewed by Darin Adler.

Report the extra memory cost of a HTMLMediaElement to the VM, in order to
encourage GC to occur after a media element is removed from the DOM.

Because we cannot know for sure the memory cost of our underlying media
framework objects, use the worst case scenario for the media memory cost:
the buffered percentage of movie * the total data length of the movie.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_reportedExtraMemoryCost.
(WebCore::HTMLMediaElement::removedFrom): Report the extra memory cost.

html/HTMLMediaElement.h:
html/TimeRanges.cpp:

(TimeRanges::totalDuration): Added convenience function.

html/TimeRanges.h:
platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::extraMemoryCost): Pass to MediaPlayerPrivate.

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::extraMemoryCost): Default to 0.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): Return the percentage

loaded * total data length.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

3:27 PM Changeset in webkit [151608] by jer.noble@apple.com

5 edits in trunk/Source

Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController.
https://bugs.webkit.org/show_bug.cgi?id=117597

Reviewed by Eric Carlson.

Source/WebCore:

Check for media elements with AVFoundation media types and create a AVPlayerLayer
rather than a QTMovieLayer.

platform/mac/WebVideoFullscreenController.h:
platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setupVideoOverlay:]): Take a CALayer rather than a

QTMovieLayer. Move the code which connects the layer with it's media source into
setMediaElement.

(-[WebVideoFullscreenController windowDidLoad]): Give the window's contentView a generic

CALayer instaead of a QTMovieLayer.

(-[WebVideoFullscreenController setMediaElement:]): Test whether the incoming media

element is backed by a QTMovie or an AVPlayer, and create the appropriate layer.

(-[WebVideoFullscreenController windowDidExitFullscreen]): Remove the observer of

AVPlayer's rate property.

(-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):

If the keyPath is "rate", call rateChanged.

Source/WebKit/mac:

Allow AVFoundation to be enabled even when the FullScreen API is disabled.

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

3:21 PM Changeset in webkit [151607] by enrica@apple.com

8 edits
1 add in trunk

WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
https://bugs.webkit.org/show_bug.cgi?id=117647
<rdar://problem/13881024>

Source/WebCore:

Reviewed by Darin Adler.

The API returns the matched ranges in the DOM order regardless of the
find direction, but the index of the first match after the user selection
should take the find direction into account.

Extended existing test in TestWebKitAPI.

page/Page.cpp:

(WebCore::Page::findStringMatchingRanges): Added handling of the Backwards case.

page/Page.h: Fixed incorrect name of the enum.

Source/WebKit2:

Extended existing test in TestWebKitAPI.

Shared/API/c/WKFindOptions.h: Added enum for the case where there are

no matches after the user selection in the direction of the find.

Tools:

Reviewed by Darin Adler.

The test now uses content with a selection and tests both
forwards and backward find as well as the case of a find
that has no matches after the user selection.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2/FindMatches.mm:

(TestWebKitAPI::didFindStringMatches):

TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.

2:55 PM Changeset in webkit [151606] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r150651): Web Audio doesn't work at all (silence or squawks) on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=117652

Reviewed by Eric Carlson.

r150651 disabled setting the buffer size to a large value, but in so doing, also
disabled setting the buffer size to a small value for Web Audio. Narrow the Mountain
Lion protection to just the <video> element case.

platform/audio/mac/AudioSessionManagerMac.cpp:

(AudioSessionManager::updateSessionState):

1:36 PM Changeset in webkit [151605] by rniwa@webkit.org

9 edits in trunk/Source

Function names on Object.prototype should be common identifiers
https://bugs.webkit.org/show_bug.cgi?id=117614

Reviewed by Darin Adler.

Source/JavaScriptCore:

Patch written by Sam Weinig. Make Object's prototype function names common identififers since they're used frequently.

runtime/CommonIdentifiers.h:
runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSObject.h:
runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

Source/WebCore:

Use the added common identifiers.

bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::updateDocument):

1:13 PM Changeset in webkit [151604] by a.bah@samsung.com

3 edits
2 adds in trunk

Editing: wrong text position when you click enter on the text behind the image
https://bugs.webkit.org/show_bug.cgi?id=115023

Reviewed by Ryosuke Niwa.

Source/WebCore:

When trying to break a line after an image followed by some text, contrary
to the expected behavior the text doesn't move to a new line, instead, the
caret position just shifts to the end of line.

As per the existing implementation for inserting a paragraph separator,
the insertion position obtained corresponds to the point after the image
element.
Since the insertion position doesn't resolve to being offset in the
following text node (0 offset), no splitting of text occurs and the block
to be inserted is placed after the containing (start) block (thereby
causing the caret position to shift).

If the computed insertionPosition points to an element that shall be
ignored for editing purposes (i.e. cannot have a VisiblePosition inside
it), and the position lies either at the start or at the end of such
an element, we should move our Position either upstream or
downstream (respectively) so as to obtain a valid position which can
be used further for splitting of the text.

Test: editing/inserting/insert-paragraph-after-non-editable-node-before-text.html

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):
Moving the insertionPosition either upstream or downstream, if the point
lies either at the start or at the end of the anchor node.
The ensuing position, if a text node, can then be used for splitting of
the text correctly.

LayoutTests:

editing/inserting/insert-paragraph-after-non-editable-node-before-text-expected.txt: Added.
editing/inserting/insert-paragraph-after-non-ediatble-node-before-text.html: Added.

Layout test added for verifying the insert paragraph behavior between an inline node
which is ignored for editing purposes and some text.

1:02 PM Changeset in webkit [151603] by commit-queue@webkit.org

7 edits
4 deletes in trunk/Source

[BlackBerry] Remove implementation of ContextMenu classes
https://bugs.webkit.org/show_bug.cgi?id=114860

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-14
Reviewed by Rob Buis.

This code is not being used so we can safely remove it.

Source/WebCore:

PlatformBlackBerry.cmake:
platform/blackberry/ContextMenuBlackBerry.cpp: Removed.
platform/blackberry/ContextMenuItemBlackBerry.cpp: Removed.
platform/blackberry/LocalizedStringsBlackBerry.cpp:

Source/WebKit:

PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

WebCoreSupport/ContextMenuClientBlackBerry.cpp: Removed.
WebCoreSupport/ContextMenuClientBlackBerry.h: Removed.

12:37 PM Changeset in webkit [151602] by timothy@apple.com

3 edits in trunk/Websites/webkit.org

Shrink larger images to fit the width of the blog.

blog-files/new-inspector/hero-labeled.png:
blog-files/new-inspector/hero.png:

12:34 PM Changeset in webkit [151601] by Brent Fulgham

5 edits in trunk/Source/WebCore

[Windows] Provide simple <meter> drawing logic for testing.
https://bugs.webkit.org/show_bug.cgi?id=117645.

Reviewed by Anders Carlsson.

accessbility/meter-element.html

rendering/RenderThemeSafari.cpp: Simple test implementation

(WebCore::RenderThemeSafari::adjustMeterStyle): Added.
(WebCore::RenderThemeSafari::supportsMeter): Added.
(WebCore::RenderThemeSafari::meterSizeForBounds): Added.
(WebCore::RenderThemeSafari::paintMeter): Added.

rendering/RenderThemeSafari.h:
rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::progressBarTheme): Added.
(WebCore::RenderThemeWin::getClassicThemeData): Support meters.
(WebCore::RenderThemeWin::getThemeData): Support meter theme.
(WebCore::RenderThemeWin::adjustMeterStyle): Added.
(WebCore::RenderThemeWin::supportsMeter): Added.
(WebCore::RenderThemeWin::meterSizeForBounds): Added.
(WebCore::RenderThemeWin::paintMeter): Added.

rendering/RenderThemeWin.h:

10:18 AM Changeset in webkit [151600] by eric.carlson@apple.com

4 edits
2 adds in trunk

Potential use-after-free with an event fired at a HTMLMediaElement which is currently being deleted
https://bugs.webkit.org/show_bug.cgi?id=117466

Reviewed by Oliver Hunt.

Merge https://chromium.googlesource.com/chromium/blink/+/f4200a0093b3d9376f703961615359ec7fb712b4

If an event is created using as target an HTMLMediaElement which is
currently being deleted it becomes a heap-use-after free situation.

The GenericEventQueue instance is already owned by the HTMLMediaElement,
and there already is an underlying mechanism to set the target of the
event to NULL, if their target is owner of the queue.

In order to avoid creating this reference in the first place, we enqueue
the event with a NULL target to defer the refcount increment until the
timer for dispatching the event happens (which won't happen at all if
garbage collection is already destroying the objects).

Source/WebCore:

Test: media/track/media-element-enqueue-event-crash.html

dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::enqueueEvent): Don't ASSERT if the event has no target.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Close the event queue so it won't try to

dispatch any pending events.

(WebCore::HTMLMediaElement::scheduleEvent): Don't set the event target, it will happen just

prior to event dispatch.

(WebCore::HTMLMediaElement::stop): Close the event queue.

LayoutTests:

media/track/media-element-enqueue-event-crash-expected.txt: Added.
media/track/media-element-enqueue-event-crash.html: Added.

10:09 AM Changeset in webkit [151599] by dino@apple.com

4 edits in trunk/Source/WebCore

Clicking on snapshotting plug-ins does not restart them
https://bugs.webkit.org/show_bug.cgi?id=117620
<rdar://problem/13821729>

Follow-up review comments from Darin Adler, with some
discussion on IRC.

Sprinkle OVERRIDE on virtual functions where needed. Also
make sure that the Event is a MouseEvent before casting to it.

html/HTMLPlugInElement.h: Move defaultEventHandler back to protected and add OVERRIDE.
html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::defaultEventHandler): Check for MouseEvent and
use toMouseEvent().

html/HTMLPlugInImageElement.h: Sprinkle some OVERRIDEs, and move defaultEventHandler

to private.

9:52 AM Changeset in webkit [151598] by timothy@apple.com

2 edits in trunk/Source/WebCore

Remove front-end from the WebCore Xcode project.
https://bugs.webkit.org/show_bug.cgi?id=117640

Reviewed by Darin Adler.

WebCore.xcodeproj/project.pbxproj:

9:36 AM Changeset in webkit [151597] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

CSSParser::parseImageSet() doesn't need a parameter.
https://bugs.webkit.org/show_bug.cgi?id=117617

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-06-14
Reviewed by Darin Adler.

parseImageSet() can get m_valueList directly.
And minor fixes.

No new tests, no behavior change.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):

css/CSSParser.h:

9:25 AM Changeset in webkit [151596] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Dropdown button UX updates.
https://bugs.webkit.org/show_bug.cgi?id=117642.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-14
Reviewed by Rob Buis.

JIRA 388652
Internally Reviewed by Jeff Rogers.

Change arrow assert.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMenuList):

8:00 AM Changeset in webkit [151595] by anilsson@rim.com

16 edits in trunk/Source

[BlackBerry] LayerTiler fails to tile really big layers
https://bugs.webkit.org/show_bug.cgi?id=117211

Reviewed by Carlos Garcia Campos.

PR 273550

Source/WebCore:

The cause for this bug was that LayerTiler computed which tiles are
visible by exhaustively mapping every tile to normalized device
coordinates and checking if it intersected the viewport. If there was a
lot of tiles, it would get stuck in this loop, iterating over all
tiles, for a very long time. Also, the visibility information was
transferred to the WebKit thread using mutexes, which added unnecessary
mutex contention to the mix.

Fixed by doing the reverse calculation, unprojecting the visible part
of the layer to layer coordinate space to find which tiles are visible.
Instead of doing a traditional unprojection of point to line and see
where the line intersects the layer, this patch uses the w-coordinates
of triangle vertices to perform "perspective correct texturing" of the
intersection points in device space, which is equivalent to
unprojection since perspective correct texturing computes a 2D
coordinate in (normalized) layer coordinate space which is easily
scaled up to the layer bounds and get the visible region expressed in
layer coordinate space.

The visible area is approximated by a rectangle, and a set of tiles
needing render are added to the mix, and we have a swappable data
structure so visbility can be transferred to WebKit thread without
mutexes, but instead using atomic swap.

No new tests, covered by existing tests.

platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):

platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:

(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):

platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:

(EGLImageLayerCompositingThreadClient):

platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):

platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):

platform/graphics/blackberry/LayerCompositingThreadClient.h:

(WebCore):
(LayerCompositingThreadClient):

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeLayersRecursive):

platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::discardContents):

platform/graphics/blackberry/LayerTile.h:

(LayerTile):
(WebCore::LayerTile::contentsScale):
(WebCore::LayerTile::setContentsDirty):

platform/graphics/blackberry/LayerTiler.cpp:

(LayerVisibility):
(WebCore::LayerVisibility::LayerVisibility):
(WebCore::LayerVisibility::visibleRect):
(WebCore::LayerVisibility::setVisibleRect):
(WebCore::LayerVisibility::needsRender):
(WebCore::LayerVisibility::tileNeedsRender):
(WebCore::LayerVisibility::willRenderTile):
(WebCore::LayerVisibility::swapTilesNeedingRender):
(WebCore::LayerVisibility::merge):
(WebCore):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::~LayerTiler):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::swapFrontVisibility):
(WebCore::LayerTiler::setFrontVisibility):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
(WebCore::inflateViewport):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::rectForTile):

platform/graphics/blackberry/LayerTiler.h:

(WebCore):
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::takeFrontVisibility):

platform/graphics/blackberry/LayerUtilities.h:

(WebCore):
(WebCore::det):
(WebCore::dot):
(LayerClipEdge):
(WebCore::LayerClipEdge::LayerClipEdge):
(WebCore::LayerClipEdge::isPointInside):
(WebCore::LayerClipEdge::computeIntersection):
(WebCore::intersectPolygonWithRect):
(WebCore::computeBarycentricCoordinates):
(WebCore::manhattanDistanceToViewport):
(UnprojectionVertex):
(WebCore::compareManhattanDistanceToViewport):
(WebCore::unproject):

Source/WebKit/blackberry:

Adapt to changes in LayerCompositingThreadClient interface.

Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):

Api/WebOverlay_p.h:

(WebOverlayLayerCompositingThreadClient):

7:53 AM Changeset in webkit [151594] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Compilation problems - hb.h not found
https://bugs.webkit.org/show_bug.cgi?id=117636

Unreviewed GTK+ build fix.

Patch by Andres Gomez <Andres Gomez> on 2013-06-14

GNUmakefile.am: Added freetype cflags for WebKit2 GTK+ Platform

library.

7:50 AM Changeset in webkit [151593] by zarvai@inf.u-szeged.hu

3 edits
26 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Generate new baseline to some tests and bot greening.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-14

platform/qt-5.0-wk2/TestExpectations:
platform/qt-5.0-wk2/animations/3d/change-transform-in-end-event-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/border-radius-percent-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/border-radius-wide-border-05-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/border-radius-with-box-shadow-expected.png: Added.
platform/qt-5.0-wk2/fast/css-generated-content/details-summary-before-after-expected.png: Added.
platform/qt-5.0-wk2/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
platform/qt-5.0-wk2/fast/forms/zoomed-controls-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
platform/qt-5.0-wk2/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/marker-orient-auto-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/marker-orient-auto-expected.txt: Added.
platform/qt-5.0-wk2/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
platform/qt-5.0-wk2/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
platform/qt-5.0-wk2/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
platform/qt-5.0-wk2/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
platform/qt/TestExpectations:

7:43 AM Changeset in webkit [151592] by Antoine Quint

3 edits in trunk/Source/WebCore

[Mac] clicking caption track glyph should dismiss menu
https://bugs.webkit.org/show_bug.cgi?id=117621

We now correctly capture all click events while the captions track menu
is showing, and ensure that no other control in the media player can be
activated as the track list gets dismissed by clicking anywhere but on
itself.

Reviewed by Eric Carlson.

html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::showClosedCaptionTrackList):
Make the controls panel non-interactive and track click events in the
capture phase also on the controls container itself such that we can
identify correctly whether a click in the <video> shadow tree is on
the track list or another element (the target could only be resolved
to a shadow tree node if the event is handled within the shadow tree).

(WebCore::MediaControlsApple::hideClosedCaptionTrackList):
Make the controls panel interactive again and remove the new click
event handler on the controls container.

(WebCore::MediaControlsApple::handleClickEvent):
Capture any click event that targets a node anywhere outside of the track
list container and its subtree and hide the track list in this condition.

(WebCore::MediaControlsAppleEventListener::handleEvent):
Call handleClickEvent() on the media controls when a click event is handled.

html/shadow/MediaControlsApple.h:

New public handleClickEvent() API such that it can be called from
MediaControlsAppleEventListener::handleEvent().

7:04 AM Changeset in webkit [151591] by anilsson@rim.com

9 edits
1 add in trunk/Source/WebCore

[BlackBerry] Accelerated compositing layers that intersect the image plane are incorrectly transformed
https://bugs.webkit.org/show_bug.cgi?id=117067

Reviewed by Carlos Garcia Campos.

PR 273550

The BlackBerry port used to mathematically project each corner of each
layer bounds rectangle, which gives the wrong results when the layer
intersects the image plane.

For display lists, we still got the correct appearance of the layer
contents, since the display list results in geometry that's transformed
in the vertex shader, on the GPU.

However, the transformed bounds are used for drawing the debug border,
performing visibility calculations on the CPU and drawing of WebGL,
masks/reflections and filters. Using the mathematical projection of
points that lie behind the image plane gives the wrong results.

The most important consequence of this bug was that the wrong area of
the layer would be considered visible, so a tiled layer would not
populate the right tiles (or any tiles at all).

Fixed by implementing something along the lines of the recipe in
section 6.2 of http://www.w3.org/TR/css3-transforms.

No new tests, manually testable by enabling debug border on
https://developer.mozilla.org/en-US/demos/detail/the-box/launch.

platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:

(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):

platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::LayerCompositingThread):
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore):
(WebCore::LayerCompositingThread::textureCoordinates):
(WebCore::LayerCompositingThread::drawTextures):

platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):
(WebCore::LayerCompositingThread::transformedBounds):
(WebCore::LayerCompositingThread::ws):
(WebCore::LayerCompositingThread::centerW):

platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::applyActions):

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::compareLayerW):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):

platform/graphics/blackberry/LayerRenderer.h:

(WebCore):
(LayerRenderer):

platform/graphics/blackberry/LayerRendererSurface.cpp:

(WebCore::LayerRendererSurface::boundingBox):
(WebCore::LayerRendererSurface::transformedBounds):

platform/graphics/blackberry/LayerRendererSurface.h:

(WebCore::LayerRendererSurface::setDrawTransform):
(WebCore::LayerRendererSurface::setReplicaDrawTransform):
(LayerRendererSurface):

platform/graphics/blackberry/LayerUtilities.h: Added.

(WebCore):
(LayerClipPlane):
(WebCore::LayerClipPlane::LayerClipPlane):
(WebCore::LayerClipPlane::isPointInside):
(WebCore::LayerClipPlane::computeIntersection):
(WebCore::intersect):
(WebCore::boundingBox):
(WebCore::multVecMatrix):
(WebCore::toVector):

5:53 AM Changeset in webkit [151590] by zarvai@inf.u-szeged.hu

28 edits
48 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Some more rebaselining after r151205 and r150798.

platform/qt-5.0-wk2/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
platform/qt-5.0-wk2/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
platform/qt-5.0-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-09-d-expected.png: Added.
platform/qt-5.0-wk2/css3/selectors3/html/css3-modsel-70-expected.png: Added.
platform/qt-5.0-wk2/css3/selectors3/xhtml/css3-modsel-131b-expected.png: Added.
platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png:
platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png:
platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png:
platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png:
platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png:
platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png:
platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png:
platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png:
platform/qt-5.0-wk2/fast/css/error-in-last-decl-expected.png: Added.
platform/qt-5.0-wk2/fast/css/font-size-negative-expected.png: Added.
platform/qt-5.0-wk2/fast/css/namespaces/004-expected.png: Added.
platform/qt-5.0-wk2/fast/css/table-text-align-strict-expected.png: Added.
platform/qt-5.0-wk2/fast/dom/34176-expected.png:
platform/qt-5.0-wk2/fast/dom/inner-text-expected.png: Added.
platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png:
platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png:
platform/qt-5.0-wk2/fast/forms/button-cannot-be-nested-expected.png: Added.
platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png:
platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png:
platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png:
platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png:
platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png:
platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png:
platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png:
platform/qt-5.0-wk2/fast/invalid/014-expected.png: Added.
platform/qt-5.0-wk2/fast/overflow/childFocusRingClip-expected.png: Added.
platform/qt-5.0-wk2/fast/overflow/hit-test-overflow-controls-expected.png: Added.
platform/qt-5.0-wk2/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
platform/qt-5.0-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
platform/qt-5.0-wk2/fast/runin/generated-expected.png: Added.
platform/qt-5.0-wk2/fast/table/multiple-captions-display-expected.png: Added.
platform/qt-5.0-wk2/fast/table/remove-td-display-none-expected.png: Added.
platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/text-ctm-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png:
platform/qt-5.0-wk2/tables/mozilla/bugs/bug81934-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/marvin/tables_bgcolor_red-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/marvin/tfoot_align_left-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_align_right-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_class-expected.png: Added.

4:43 AM Changeset in webkit [151589] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[Qt] Unreviewed TestExpectation cleanup
https://bugs.webkit.org/show_bug.cgi?id=117626

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-06-14

platform/qt-5.0-wk1/TestExpectations:
platform/qt/TestExpectations:

4:34 AM Changeset in webkit [151588] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[Qt] Map rewind and fast forward keys to match GoogleTV
https://bugs.webkit.org/show_bug.cgi?id=117634

Reviewed by Jocelyn Turcotte.

Set the same keycode for media keys rewind and fast-forward as
GoogleTV does.

platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

4:26 AM Changeset in webkit [151587] by zandobersek@gmail.com

2 edits in trunk/Source/Platform

Unreviewed GTK build fix.

GNUmakefile.am: Add the Freetype CFLAGS to the list of libPlatformGtk's CPPFLAGS. These are required as there are

specific build targets that end up including the HarfBuzz headers which are included in the Freetype CFLAGS variable.

3:59 AM Changeset in webkit [151586] by Carlos Garcia Campos

24 edits in trunk/Source/WebCore

Avoid unnecessary data copies when loading subresources with DoNotBufferData option
https://bugs.webkit.org/show_bug.cgi?id=115804

Reviewed by Darin Adler.

When DoNotBufferData option is used to load a resource its data
is always copied before sending it to the CachedResource. Most
of the cached resources ignore the incremental data and wait
until all data has been received to save the ResourceBuffer,
that will be NULL anyway when DoNotBufferData is used.
CachedRawResource notifies its clients about the incremental
data, but it doesn't save the data when DoNotBufferData option
is present. In those cases we are unnecessary copying the data.

CachedResource::data has been split into
CachedResource::addDataBuffer() used for incremental data chunks
when buffering data, CachedResource::addData() used for
incremental data chunks when not buffering and
CachedResource::finishLoading() used to finish the loading. This
way we get rid of the allDataReceived boolean parameter and cached
resources not interested in incremenetal data chunks only have to
implement finishLoading() without having to check if all data have
been received or not.

SubresourceLoader::sendDataToResource was always called after
checking if loading multipart content, and then it was checked
again to decided whether to copy the data or not. It has been
removed in favor of calling directly the resource methods,
finishLoading for multipart content, addDataBuffer for data chunks
when buffering and addData for data chunks when not buffering.

No new functionality, covered by existing tests.

html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::appendBytes): Update to API changes.
(WebCore::ImageDocumentParser::finish): Ditto.

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Call
finishLoading() for multipart content.
(WebCore::SubresourceLoader::didReceiveDataOrBuffer): Add data to
the resource using addDataBuffer or addData depending on whether
we are buffering or not.
(WebCore::SubresourceLoader::didFinishLoading): Call
finishLoading() for the cached resource instead of data.

loader/SubresourceLoader.h:
loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::finishLoading):

loader/cache/CachedCSSStyleSheet.h:
loader/cache/CachedFont.cpp:

(WebCore::CachedFont::finishLoading):

loader/cache/CachedFont.h:
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::isValidDecodedImageSize): Helper function
to check if the image size is valid.
(WebCore::CachedImage::addIncrementalDataBuffer): Helper function
to add incremental data buffer.
(WebCore::CachedImage::addDataBuffer): Call
addIncrementalDataBuffer().
(WebCore::CachedImage::addData): Create a ResourceBuffer and call
addIncrementalDataBuffer().
(WebCore::CachedImage::finishLoading):

loader/cache/CachedImage.h:
loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::calculateIncrementalDataChunk):
Returns a pointer to the data corresponding to the current chunk
and its length.
(WebCore::CachedRawResource::addDataBuffer): Assert to make sure
this is only called when BufferData option is present. Use
calculateIncrementalDataChunk().
(WebCore::CachedRawResource::addData): Assert to make sure this is
only called when DoNotBufferData option is present.
(WebCore::CachedRawResource::finishLoading):
(WebCore::CachedRawResource::notifyClientsDataWasReceived): Helper
private function to notify the clients about data received.

loader/cache/CachedRawResource.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addDataBuffer):
(WebCore::CachedResource::addData):
(WebCore::CachedResource::finishLoading):

loader/cache/CachedResource.h:
loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::finishLoading):

loader/cache/CachedSVGDocument.h:
loader/cache/CachedScript.cpp:

(WebCore::CachedScript::finishLoading):

loader/cache/CachedScript.h:
loader/cache/CachedShader.cpp:

(WebCore::CachedShader::finishLoading):

loader/cache/CachedShader.h:
loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::addDataBuffer):
(WebCore::CachedTextTrack::finishLoading):

loader/cache/CachedTextTrack.h:
loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::finishLoading):

loader/cache/CachedXSLStyleSheet.h:

3:03 AM Changeset in webkit [151585] by vestbo@webkit.org

2 edits in trunk/Tools

Remove myself from Qt build system watchlist

1:26 AM Changeset in webkit [151584] by zarvai@inf.u-szeged.hu

2 edits
73 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r151205.

platform/qt-5.0-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
platform/qt-5.0-wk2/css3/selectors3/html/css3-modsel-39-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/create-list-with-hr-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/4960120-2-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/5057506-expected.png: Added.
platform/qt-5.0-wk2/fast/invalid/003-expected.png: Added.
platform/qt-5.0-wk2/fast/selectors/061-expected.png: Added.
platform/qt-5.0-wk2/fast/table/table-display-types-strict-expected.png: Added.
platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/use-font-face-crash-expected.png:
platform/qt-5.0-wk2/tables/mozilla/bugs/bug727-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/marvin/tables_border_1-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png: Added.

1:20 AM Changeset in webkit [151583] by commit-queue@webkit.org

2 edits in trunk

[GTK][WK1] Missing symbols
https://bugs.webkit.org/show_bug.cgi?id=117629

Unreviewed GTK+ build fix.

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-06-14

Source/autotools/symbols.filter: Added missing symbols needed when

compiling WK1.

12:55 AM Changeset in webkit [151582] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL] Fix build when DRAG_SUPPORT is set OFF
https://bugs.webkit.org/show_bug.cgi?id=117628

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-14
Reviewed by Gyuyoung Kim.

Context Navigation

Timeline

Jun 15, 2013:

Jun 14, 2013:

Download in other formats: