Timeline
Jun 20, 2013:
- 11:02 PM Changeset in webkit [151825] by
-
- 8 edits1 add in trunk/Source
[WK2] Looping for EINTR on close() is incorrect for Linux, at least
https://bugs.webkit.org/show_bug.cgi?id=117266
Patch by Sergio Correia <Sergio Correia> on 2013-06-20
Reviewed by Darin Adler.
Source/WebKit2:
Call closeWithRetry() to work around a difference in how the retry needs to
be done on Linux.
- Platform/CoreIPC/unix/AttachmentUnix.cpp:
(CoreIPC::Attachment::dispose):
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::createWebProcessConnection):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess): All these places had
close-followed-by-EINTR-handling replaced with the new closeWithRetry()
function added in this commit.
Source/WTF:
Added file UniStdExtras with a closeWithRetry() function that works around
the EINTR behavior on Linux during a close() call: it closes the descriptor
unconditionally even when the call is interrupted.
- wtf/UniStdExtras.h: Added.
(WTF::closeWithRetry): Wrapper around POSIX close() that handles EINTR
correctly.
- 9:21 PM Changeset in webkit [151824] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Structure should have a dump()
https://bugs.webkit.org/show_bug.cgi?id=117859
Reviewed by Geoffrey Garen.
This is pretty cool. Anywhere we previously printed Structure pointers in dumps,
we now print a bunch of other info as well. For example, for an object literal
like "{f:42, g:64, h:24}", when we print the structure we'll now get:
0x107a0af80:[Object, {f:0, g:1, h:2}, NonArray, Proto:0x107a8fff0]
This also changes a bunch of places to use the dump method.
- bytecode/StructureSet.h:
(JSC::StructureSet::dump):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::dump):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dump):
- runtime/Structure.cpp:
(JSC::Structure::dump):
(JSC):
- runtime/Structure.h:
(Structure):
- 9:00 PM Changeset in webkit [151823] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r151808): fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html fails
https://bugs.webkit.org/show_bug.cgi?id=117862
Add a failing test expectation.
- platform/mac/TestExpectations:
- 8:52 PM Changeset in webkit [151822] by
-
- 4 edits2 adds in trunk
REGRESSION(r145788): mouse drag on canvas shouldn't start selection
https://bugs.webkit.org/show_bug.cgi?id=117860
Reviewed by Benjamin Poulain.
Source/WebCore:
Like HTMLImageElement, HTMLCanvasElement shouldn't start selection.
Also uninline some virtual function overrides.
Test: fast/events/mosuedrag-on-canvas-should-not-start-selection.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::areAuthorShadowsAllowed):
(WebCore::HTMLCanvasElement::canContainRangeEndPoint):
(WebCore::HTMLCanvasElement::canStartSelection):
- html/HTMLCanvasElement.h:
LayoutTests:
Add a regression test for dragging mouse inside a canvas.
The canvas should not be selected and mouseup event should fire.
- fast/events/mosuedrag-on-canvas-should-not-start-selection-expected.txt: Added.
- fast/events/mosuedrag-on-canvas-should-not-start-selection.html: Added.
- 8:50 PM Changeset in webkit [151821] by
-
- 3 edits2 adds in trunk
REGRESSION(r149652): accessing items in .children via id doesn't work when element is not rooted in DOM tree
https://bugs.webkit.org/show_bug.cgi?id=117836
Reviewed by Benjamin Poulain.
Source/WebCore:
When the root node of a HTML collection is not in the document or in a shadow tree,
we shouldn't use its tree scope's id and name maps to find name getters.
Always use the slow path in such cases.
Test: fast/dom/htmlallcollection-detached-node-children.html
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItem):
LayoutTests:
Add a regression test for named getter for a detached element.
- fast/dom/htmlallcollection-detached-node-children-expected.txt: Added.
- fast/dom/htmlallcollection-detached-node-children.html: Added.
- 7:57 PM Changeset in webkit [151820] by
-
- 19 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: There should only be one table of SimpleJumpTables
https://bugs.webkit.org/show_bug.cgi?id=117856
Reviewed by Geoffrey Garen.
Having multiple tables of SimpleJumpTables just means we have to duplicate a
ton of code. This patch deduplicates all of it.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfSwitchJumpTables):
(JSC::CodeBlock::addSwitchJumpTable):
(JSC::CodeBlock::switchJumpTable):
(JSC::CodeBlock::clearSwitchJumpTables):
(RareData):
- bytecode/PreciseJumpTargets.cpp:
(JSC):
(JSC::computePreciseJumpTargets):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::shrinkToFit):
(JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables):
(JSC::UnlinkedCodeBlock::addSwitchJumpTable):
(JSC::UnlinkedCodeBlock::switchJumpTable):
(RareData):
- bytecompiler/BytecodeGenerator.cpp:
(JSC):
(JSC::prepareJumpTableForSwitch):
(JSC::BytecodeGenerator::endSwitch):
- dfg/DFGByteCodeParser.cpp:
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 7:52 PM Changeset in webkit [151819] by
-
- 5 edits in tags/Safari-537.46.2/Source
Versioning.
- 7:50 PM Changeset in webkit [151818] by
-
- 1 copy in tags/Safari-537.46.2
New Tag.
- 7:49 PM Changeset in webkit [151817] by
-
- 2 edits in trunk/Source/WTF
Refine the StackBounds computation for Windows.
https://bugs.webkit.org/show_bug.cgi?id=117854.
Reviewed by Brent Fulgham.
- wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
- 7:29 PM Changeset in webkit [151816] by
-
- 1 delete in branches/safari-537-branch/LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements.html
correct mismerge from 151799. <rdar://problem/14159682>
- 7:26 PM Changeset in webkit [151815] by
-
- 8 edits in trunk
[CMAKE][EFL] Enable DOM4 Events Constructor
https://bugs.webkit.org/show_bug.cgi?id=117858
Reviewed by Laszlo Gombos.
.:
- Source/cmake/OptionsEfl.cmake: Enabled ENABLE_DOM4_EVENTS_CONSTRUCTOR.
- Source/cmake/WebKitFeatures.cmake: Added ENABLE_DOM4_EVENTS_CONSTRUCTOR.
- Source/cmakeconfig.h.cmake: Ditto.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
LayoutTests:
- platform/efl/TestExpectations: Unskip the related tests.
- 7:24 PM Changeset in webkit [151814] by
-
- 16 edits4 deletes in branches/safari-537-branch
Merged r151799. <rdar://problem/14159682>
- 7:17 PM Changeset in webkit [151813] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151762. <rdar://problem/13837412>
- 5:44 PM Changeset in webkit [151812] by
-
- 3 edits2 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=116495
Fix null-pointer deref in DocumentLoader::responseReceived()
Patch by Nate Chapin, reviewed by Mike West and myself.
Test: http/tests/security/XFrameOptions/x-frame-options-deny-delete-frame-in-load-event.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): Added a null check.
- 4:43 PM Changeset in webkit [151811] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Roll out part of r150618.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
- 4:36 PM Changeset in webkit [151810] by
-
- 2 edits in trunk/Source/WTF
[Windows] Undoing r150621 to roll r150600 back in as the jsc test
failures have been fixed in r151808.
https://bugs.webkit.org/show_bug.cgi?id=116661.
Reviewed by Brent Fulgham.
- wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
- 3:52 PM Changeset in webkit [151809] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Send the correct offsets for misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=117846
JIRA116916.
When the caret is placed after a word, the offsets were calculated around
the proceeding space. As such, words that end a sentence worked correctly, but
midsentence words did not. The 'startOfWord' was calculated for the space ahead
and not for the word before it. Now finding the start of the word correctly and
calculating the end from there.
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-06-20
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
- 3:17 PM Changeset in webkit [151808] by
-
- 2 edits in trunk/Source/JavaScriptCore
Change stack capacity requirement to be more reasonable.
https://bugs.webkit.org/show_bug.cgi?id=117801.
Reviewed by Geoffrey Garen.
Previously, the requiredStack in StackPolicy::StackPolicy() was set to
to a high value like 256K to reduce the chances of encountering an
undetected stack overflow in a scenario where we have a combination of
deeply nested divs and a large amount recursive re-entries into the VM.
However, this high value of requiredStack still does not completely
ensure that we will never encounter an undetected stack overflow. It
only lessens the probability of encountering it.
Secondly, on some platforms, the total stack size can be less than 256K
to start with. Hence, this high value requiredStack renders the VM
unuseable on those platforms.
This patch will fix the requiredStack to be more reasonable based on
real world stack usage by the VM. We won't (and cannot) try to prevent
undetected stack overflows outside of JSC as well. External code that
do deep recursion (e.g. Documnet::updateLayout()) should do their own
stack checks.
From a previous experiment, we measured the following:
On a debug build on OSX:
- Stack usage different between recursive calls to interpreter entry: 7744 bytes
On a release build on OSX:
- Stack usage difference between recursive calls to interpreter entry: 6352 bytes
Using these as a guide, we'll pick the following values for the
StackPolicy:
requiredStack: 32K
errorModeRequiredStack: 16K
The requiredStack is chosen to be 4x the measured usage above. The
additional 3x is a conservative estimate to account for stack space
that may be needed by other native functions called while in the
interpreter.
The errorModeRequiredStack has to be less than the requiredStack or we
won't be able to reenter the interpreter to do error handling work when
an imminent stack overflow is detected. It is assumed that the error
handling code will only do minimal work to allocate an exception and its
stack trace, and not run any arbitrary JS code. As such, it is safe to
allow re-entry into the interpreter with only 2x the measured usage in
this case.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::StackPolicy::StackPolicy):
- 3:15 PM Changeset in webkit [151807] by
-
- 3 edits2 adds in trunk
Initial advance on the first glyph of the run is not correctly set for rtl text.
https://bugs.webkit.org/show_bug.cgi?id=117839
<rdar://problem/13860717>
Reviewed by Sam Weinig.
Source/WebCore:
We need to set the initial advance to the glyphBuffer, using the
initial advance of the complex run that will be drawn first.
In order to choose the run correctly we must consider the text direction.
Test: fast/text/complex-first-glyph-with-initial-advance.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::advance):
LayoutTests:
- fast/text/complex-first-glyph-with-initial-advance-expected.html: Added.
- fast/text/complex-first-glyph-with-initial-advance.html: Added.
- 2:42 PM Changeset in webkit [151806] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should clear character switch jump tables
https://bugs.webkit.org/show_bug.cgi?id=117852
Reviewed by Sam Weinig.
The FTL just uses LLVM's switch, which results in LLVM allocating its own switch
jump tables as needed.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::clearCharacterSwitchJumpTables):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- 2:37 PM Changeset in webkit [151805] by
-
- 5 edits in trunk/Source/WebCore
Fixed WebGL compile errors on Windows.
https://bugs.webkit.org/show_bug.cgi?id=117805
Reviewed by Brent Fulgham.
- html/canvas/WebGLRenderingContext.cpp: Included CString.h.
Added PLATFORM(WIN) to existing lists of platform macros.
- platform/graphics/ANGLEWebKitBridge.h:
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):
- platform/graphics/OpenGLESShims.h:
- 2:28 PM Changeset in webkit [151804] by
-
- 6 edits in trunk/Source
FrameView needs to initialize paintsEntireContents on creation
https://bugs.webkit.org/show_bug.cgi?id=117844
Source/WebCore:
Reviewed by Anders Carlsson.
In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.
- page/ChromeClient.h:
(WebCore::ChromeClient::shouldPaintEntireContents):
- page/FrameView.cpp:
(WebCore::FrameView::init):
Source/WebKit/mac:
Reviewed by Anders Carlsson.
In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldPaintEntireContents):
- 2:28 PM Changeset in webkit [151803] by
-
- 2 edits in trunk/Source/WebCore
Sticky elements are missing or misplaced sometimes when reloading a page that scrolls to a named anchor
https://bugs.webkit.org/show_bug.cgi?id=117819
Reviewed by Anders Carlsson.
At the end of FrameView::performPostLayoutTasks() we call scrollToAnchor() which attempts
to restore the scroll position to a named anchor, even when the document has been
changed by layout. This ends up in a call to ScrollView::scrollTo(), which in turn
calls repaintFixedElementsAfterScrolling(). However, repaintFixedElementsAfterScrolling()
would bail if m_nestedLayoutCount != 0, so we never updated layer positions which
depend on scroll position (but which would not be updated by layout, since their
renderers are not marked for layout when scrolling happens).
We've solved this problem once before in updateFixedElementsAfterScrolling() which
checks for m_nestedLayoutCount <= 1, so that we do work on the outermost nested layout.
Apply that same fix to repaintFixedElementsAfterScrolling().
Very timing-dependent, so hard to make a test.
- page/FrameView.cpp:
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
- 2:18 PM Changeset in webkit [151802] by
-
- 17 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support SwitchChar
https://bugs.webkit.org/show_bug.cgi?id=117849
Reviewed by Geoffrey Garen.
This adds Switch(SwitchChar) to the FTL and also implicitly does some other things.
SwitchChar requires calling a slow path to resolve ropes. Previously the FTL had no
support for calling slow paths, and we avoided adding coverage that would require
that. Well, this patch adds the ability to call slow paths and just uses that for
resolving ropes for SwitchChar. Also SwitchChar required adding awareness of strings,
so I did that, too.
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::addCodeOrigin):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNode.cpp:
(WTF):
(WTF::printInternal):
- dfg/DFGNode.h:
(WTF):
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- ftl/FTLAbbreviations.h:
(JSC::FTL::int16Type):
(JSC::FTL::constInt):
- ftl/FTLAbstractHeapRepository.h:
(FTL):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
(CommonValues):
- ftl/FTLIntrinsicRepository.cpp:
(JSC::FTL::IntrinsicRepository::IntrinsicRepository):
(FTL):
- ftl/FTLIntrinsicRepository.h:
(FTL):
(IntrinsicRepository):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::buildSwitch):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowString):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isObject):
(JSC::FTL::LowerDFGToLLVM::isNotString):
(JSC::FTL::LowerDFGToLLVM::isString):
(JSC::FTL::LowerDFGToLLVM::isNotObject):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::speculateString):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::LowerDFGToLLVM::vmCall):
(JSC::FTL::LowerDFGToLLVM::callPreflight):
(JSC::FTL::LowerDFGToLLVM::callCheck):
(JSC::FTL::LowerDFGToLLVM::lowBlock):
- ftl/FTLOutput.h:
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt8):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::load16):
(JSC::FTL::Output::isNull):
(JSC::FTL::Output::notNull):
(JSC::FTL::Output::testIsZero32):
(JSC::FTL::Output::testNonZero32):
(Output):
(JSC::FTL::Output::operation):
(JSC::FTL::Output::crash):
- 2:10 PM Changeset in webkit [151801] by
-
- 6 edits3 deletes in trunk/LayoutTests
Unreviewed, rolling out r151463.
http://trac.webkit.org/changeset/151463
https://bugs.webkit.org/show_bug.cgi?id=117850
"r151451 was rolled out" (Requested by rhogan on #webkit).
- platform/efl/fast/forms/button-positioned-expected.txt:
- platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- platform/gtk/fast/forms/button-positioned-expected.txt:
- platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
- platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- platform/win/fast/forms/onselect-textfield-expected.txt: Removed.
- 2:09 PM Changeset in webkit [151800] by
-
- 63 edits in trunk/Source
HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
https://bugs.webkit.org/show_bug.cgi?id=117830
Reviewed by Anders Carlsson.
The order of the template arguments at HashSet alternate 'find', 'contains' and
'add' methods is reversed so that callers can just pass the translator
and let the compiler deduce input argument type.
Source/JavaScriptCore:
- runtime/Identifier.h:
(JSC::IdentifierTable::add):
Source/WebCore:
No new tests. No new functionality.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::QualifiedName):
- platform/graphics/cg/SubimageCacheWithTimer.cpp:
(WebCore::SubimageCacheWithTimer::getSubimage):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::isSupportedAttribute):
- svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::isSupportedAttribute):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::isSupportedAttribute):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
- svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::isSupportedAttribute):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::isSupportedAttribute):
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):
- svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::isSupportedAttribute):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::isSupportedAttribute):
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::isSupportedAttribute):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::isSupportedAttribute):
- svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::isSupportedAttribute):
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::isSupportedAttribute):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::isSupportedAttribute):
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::isSupportedAttribute):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::isSupportedAttribute):
(WebCore::SVGFilterElement::childShouldCreateRenderer):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::isSupportedAttribute):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::isSupportedAttribute):
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::isSupportedAttribute):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::isSupportedAttribute):
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::isSupportedAttribute):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::isSupportedAttribute):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::isSupportedAttribute):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::isSupportedAttribute):
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::isSupportedAttribute):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::isSupportedAttribute):
- svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::isSupportedAttribute):
- svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::isSupportedAttribute):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::isSupportedAttribute):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::isSupportedAttribute):
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::isSupportedAttribute):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::isSupportedAttribute):
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::isSupportedAttribute):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::isDisallowedElement):
- svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::isSupportedAttribute):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::isSupportedAttribute):
Source/WTF:
- wtf/HashSet.h:
- wtf/text/AtomicString.cpp:
(WTF::addToStringTable):
(WTF::findString):
- 1:46 PM Changeset in webkit [151799] by
-
- 16 edits5 deletes in trunk
Unreviewed, rolling out r151451.
http://trac.webkit.org/changeset/151451
https://bugs.webkit.org/show_bug.cgi?id=117848
"Broke quite a lot of sites" (Requested by rhogan on #webkit).
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
- rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
- rendering/RenderButton.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):
- rendering/RenderListBox.h:
- rendering/RenderMenuList.h:
- rendering/RenderReplaced.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):
- rendering/RenderTextControl.h:
LayoutTests:
- fast/forms/onselect-textfield-expected.txt:
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Removed.
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- fast/replaced/width-and-height-of-positioned-replaced-elements.html: Removed.
- platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
- platform/qt/fast/forms/button-positioned-expected.txt:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
- 1:37 PM Changeset in webkit [151798] by
-
- 10 edits2 deletes in trunk
Unreviewed, rolling out r151788.
http://trac.webkit.org/changeset/151788
https://bugs.webkit.org/show_bug.cgi?id=117847
"This is the wrong fix" (Requested by rhogan on #webkit).
Source/WebCore:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):
LayoutTests:
- fast/forms/onselect-textfield-expected.txt:
- fast/replaced/height-of-positioned-text-control-expected.html: Removed.
- fast/replaced/height-of-positioned-text-control.html: Removed.
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
- 1:19 PM Changeset in webkit [151797] by
-
- 5 edits in trunk
[Gstreamer] cleanup buffering and state updates
https://bugs.webkit.org/show_bug.cgi?id=116642
Reviewed by Philippe Normand.
Source/WebCore:
Covered by existing media tests, especially the ones that have been unskipped.
Always do download buffering. It should not differ if preload is "none" because
it's about when to start buffering, not about how. Fix a bunch other subtle issues
to make this change go smoothly with the tests. As a bonus some tests that were
failing so far started to pass.
It is possible to further tweak the buffering in a way that will enable us to support
a different and appropriate behavior for preload="metadata" but it should be managed
a bit differently. I will implement it in a follow-up.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Don't call setDownloadBuffering
yet. Now it also responsible for starting the fill timer and it turned out that
setting the download flag before the pipeline is set to a state has negative
effect on some tests. Most probably GStreamer starts buffering too early if
we set the download flag.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): Call setDownloadBuffering now.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto, plus set m_delayingLoad to false
because otherwise setPreload will wrongly assume that the load has not been committed
yet if prepareToPlay is not called before play.
(WebCore::MediaPlayerPrivateGStreamer::pause): Make sure we don't commit a load here
if it was not committed yet by looking in the pipeline state.
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): No need to observe the
type of buffering.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Introduced m_downloadFinished to update
ready and network states in updateStates based on it. The previously used condition
- (maxTimeLoaded() == duration()) - was not correct in the case when duration is not known.
(WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): Removed a lie. If the fill timer is not active
it does not necesarily means that download has been finished. This lie was actually ensuring
a lot of tests to pass because it made the condition (maxTimeLoaded() == duration()) true.
Now that state updates has been cleaned up we don't need to lie.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Merge all the parts that takes part in updating
ready and network states. It was untrackable. Unset download buffering for for live streams early so
we don't need to restart them.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer): Removed m_startedBuffering because there is no need for it now.
LayoutTests:
Remove failure expectations from tests that started to pass.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 1:14 PM Changeset in webkit [151796] by
-
- 5 edits2 adds in trunk
ASSERT removing then adding a <track> element
https://bugs.webkit.org/show_bug.cgi?id=117814
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/add-and-remove-track.html
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedInto): Always call ensureTrack before adding the track
to the parent <video> element.
(WebCore::HTMLTrackElement::ensureTrack): Call m_track->setTrackElement() in case the
parent was cleared after m_track was created.
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::setTrackElement): New, set m_trackElement.
- html/track/LoadableTextTrack.h:
LayoutTests:
- media/track/add-and-remove-track-expected.txt: Added.
- media/track/add-and-remove-track.html: Added.
- 1:12 PM Changeset in webkit [151795] by
-
- 6 edits in trunk/Source/WebKit2
WebProcess hangs loading eff.org (Waiting forever on a sync XHR, NetworkProcess unable to service it).
<rdar://problem/14112329> and https://bugs.webkit.org/show_bug.cgi?id=117842
Reviewed by Alexey Proskuryakov.
- NetworkProcess/HostRecord.cpp:
(WebKit::removeLoaderFromQueue): Utility to clear a Loader out of a LoaderQueue.
(WebKit::HostRecord::removeLoader): Use removeLoaderFromQueue, and also try to clear the loader from m_syncLoadersPending.
(WebKit::HostRecord::servePendingRequestsForQueue): Small refactoring/cleanup.
(WebKit::HostRecord::limitsRequests): Change so that if the number of loaders in flight is exactly equal to the limit, then
allow serving a synchronous loader to go exactly one beyond the limit.
- NetworkProcess/HostRecord.h:
Make the static maxRequestsInFlightPerHost a member of the NetworkResourceLoadScheduler, instead:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::NetworkResourceLoadScheduler):
(WebKit::NetworkResourceLoadScheduler::hostForURL):
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost): Tell CFNetwork to allow
7 connections per host instead of 6, but tell the scheduler that 6 is still the normal limit.
- 1:12 PM Changeset in webkit [151794] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Build fix for Apple Windows port.
- rendering/RenderThemeWin.cpp:
(WebCore::cssValueIdToSysColorIndex):
- 1:06 PM Changeset in webkit [151793] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Downloaded file name encoding is incorrect when download link opens in a new window
https://bugs.webkit.org/show_bug.cgi?id=117818
<rdar://problem/14212635>
Reviewed by Brady Eidson.
No tests added. The machinery we have for logging downloaded file name is very
far from being able to work in a secondary window.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Made a targeted fix - don't update encoding fallback array if we already have one, there is no chance for it to be more correct. In this case, it's incorrect because it comes from a new blank window, instead of original referer. We have a lot of code in addExtraFieldsToRequest() to struggle with this, and we have a FIXME to try not calling it from policy delegate.
- 12:44 PM Changeset in webkit [151792] by
-
- 5 edits in trunk/Source
Versioning.
- 12:32 PM Changeset in webkit [151791] by
-
- 2 edits in trunk
[GTK] remove bashism from configure
https://bugs.webkit.org/show_bug.cgi?id=117796
Reviewed by Gustavo Noronha Silva.
- Source/autotools/FindDependencies.m4: Perform string appending by redeclaring the base string to the value
of the base string followed by the string that's being appended. This replaces the use of the '+=' operator
that works under bash but is not supported by other shells.
- 12:16 PM Changeset in webkit [151790] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/repaint/positioned-movement.html as flaky on Mountain Lion Debug
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-20
- platform/mac-wk2/TestExpectations:
The test fails regularly in Debug on Mountain Lion.
- 12:10 PM Changeset in webkit [151789] by
-
- 4 edits in trunk/LayoutTests
[Qt][WK2] REGRESSION(r151737): fast/replaced/width100percent-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=117824
Unreviewed, rebaselining.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt:
- 11:58 AM Changeset in webkit [151788] by
-
- 10 edits2 adds in trunk
REGRESSION (r151451): Text not vertically centered correctly on icloud.com
https://bugs.webkit.org/show_bug.cgi?id=117744
Reviewed by David Hyatt.
Source/WebCore:
The positioned height and width computation adds in the element's border and padding so
don't add it to the intrinsic height and preferred widths of text controls that are
absolutely positioned.
Test: fast/replaced/height-of-positioned-text-control.html
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):
LayoutTests:
- fast/forms/onselect-textfield-expected.txt:
- fast/replaced/height-of-positioned-text-control-expected.html: Added.
- fast/replaced/height-of-positioned-text-control.html: Added.
- fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
- platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
- 11:55 AM Changeset in webkit [151787] by
-
- 8 edits in trunk/Source
Make Windows makefile copy build output to a different folder.
<rdar://problem/14219184>.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- WebCore.vcxproj/WebCore.make:
- WebKit.vcxproj/WebKit.make:
- 11:36 AM Changeset in webkit [151786] by
-
- 3 edits in trunk/Source/JavaScriptCore
Improper deallocation of JSManagedValue causes crashes during autorelease pool draining
https://bugs.webkit.org/show_bug.cgi?id=117840
Reviewed by Geoffrey Garen.
Improperly managing a JSManagedValue can cause a crash when the JSC::Weak inside the
JSManagedValue is destroyed upon deallocation. We would rather have improperly maintained
JSManagedValues cause memory leaks than take down the whole app.
The fix is to use the callback to the JSC::Weak on the destruction of the VM so that we
can safely null it out. This will prevent ~Weak from crashing.
- API/JSManagedValue.mm:
(-[JSManagedValue JSC::JSC::]):
(JSManagedValueHandleOwner::finalize):
- API/tests/testapi.mm: Added a test that crashed prior to this fix due to a leaked
managed reference. Also fixed a small style nit I noticed in another test.
- 11:24 AM Changeset in webkit [151785] by
-
- 2 edits in trunk/Source/WebCore
Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
https://bugs.webkit.org/show_bug.cgi?id=117811
Reviewed by Eric Carlson.
When comparing Generic cues, we should check that their type is Generic, not WebVTT.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isOrderedBefore):
- 11:07 AM Changeset in webkit [151784] by
-
- 2 edits in trunk/Source/WebCore
[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=117711
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-20
Reviewed by Laszlo Gombos.
No new tests, no CMake platforms currently enable this functionality.
- CMakeLists.txt:
- 11:04 AM Changeset in webkit [151783] by
-
- 44 edits in trunk/Source/WebCore
Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.
https://bugs.webkit.org/show_bug.cgi?id=117829
Reviewed by Andreas Kling.
A lot of call sites were using integers to represent them. While it's
not incorrect per se, it's not ideal for various reason such as type
safety or to remove ambiguity.
This patch eradicate the wrong usage by not letting any integer based
API for getting CSSValueIDs or CSSPropertyIDs from CSSPrimitiveValues.
Instead we use new but typed functions to construct the values as well
as getting them. Two customs and internal types were added to CSSPrimitiveValue
to handle correctly the new APIs.
It's good to note that in order to preserve compatibility on the
CSSPrimitiveValue type whenever CSSPrimitiveValue handles a CSSValueID
or a CSSPropertyID the return type for the public API will be CSS_IDENT
despite it is a separate internal type.
No new tests: refactor, existing tests should cover.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyMatches):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSGradientValue.cpp:
(WebCore::positionFromValue):
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseSystemColor):
(WebCore::isFillPositionKeyword):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isBlendMode):
(WebCore::CSSParser::isCompositeOperator):
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::propertyName):
(WebCore::valueName):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isValueID):
(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createParserOperator):
(WebCore::CSSPrimitiveValue::getPropertyID):
(WebCore::CSSPrimitiveValue::getValueID):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
(WebCore::CSSPrimitiveValue::operator PrintColorAdjust):
(WebCore::CSSPrimitiveValue::operator EBorderStyle):
(WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
(WebCore::CSSPrimitiveValue::operator CompositeOperator):
(WebCore::CSSPrimitiveValue::operator ControlPart):
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
(WebCore::CSSPrimitiveValue::operator EFillAttachment):
(WebCore::CSSPrimitiveValue::operator EFillBox):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
(WebCore::CSSPrimitiveValue::operator EBoxDirection):
(WebCore::CSSPrimitiveValue::operator EBoxLines):
(WebCore::CSSPrimitiveValue::operator EBoxOrient):
(WebCore::CSSPrimitiveValue::operator ECaptionSide):
(WebCore::CSSPrimitiveValue::operator EClear):
(WebCore::CSSPrimitiveValue::operator ECursor):
(WebCore::CSSPrimitiveValue::operator CursorVisibility):
(WebCore::CSSPrimitiveValue::operator EDisplay):
(WebCore::CSSPrimitiveValue::operator EEmptyCell):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EFlexDirection):
(WebCore::CSSPrimitiveValue::operator EAlignContent):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
(WebCore::CSSPrimitiveValue::operator EFloat):
(WebCore::CSSPrimitiveValue::operator LineBreak):
(WebCore::CSSPrimitiveValue::operator EListStylePosition):
(WebCore::CSSPrimitiveValue::operator EListStyleType):
(WebCore::CSSPrimitiveValue::operator EMarginCollapse):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
(WebCore::CSSPrimitiveValue::operator RegionFragment):
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
(WebCore::CSSPrimitiveValue::operator ENBSPMode):
(WebCore::CSSPrimitiveValue::operator EOverflow):
(WebCore::CSSPrimitiveValue::operator EPageBreak):
(WebCore::CSSPrimitiveValue::operator EPosition):
(WebCore::CSSPrimitiveValue::operator EResize):
(WebCore::CSSPrimitiveValue::operator ETableLayout):
(WebCore::CSSPrimitiveValue::operator ETextAlign):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
(WebCore::CSSPrimitiveValue::operator TextJustify):
(WebCore::CSSPrimitiveValue::operator TextDecoration):
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
(WebCore::CSSPrimitiveValue::operator ETextSecurity):
(WebCore::CSSPrimitiveValue::operator ETextTransform):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
(WebCore::CSSPrimitiveValue::operator EUserDrag):
(WebCore::CSSPrimitiveValue::operator EUserModify):
(WebCore::CSSPrimitiveValue::operator EUserSelect):
(WebCore::CSSPrimitiveValue::operator EVerticalAlign):
(WebCore::CSSPrimitiveValue::operator EVisibility):
(WebCore::CSSPrimitiveValue::operator EWhiteSpace):
(WebCore::CSSPrimitiveValue::operator EWordBreak):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
(WebCore::CSSPrimitiveValue::operator TextDirection):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator TextCombine):
(WebCore::CSSPrimitiveValue::operator RubyPosition):
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition):
(WebCore::CSSPrimitiveValue::operator TextOverflow):
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill):
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning):
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode):
(WebCore::CSSPrimitiveValue::operator FontWeight):
(WebCore::CSSPrimitiveValue::operator FontItalic):
(WebCore::CSSPrimitiveValue::operator FontSmallCaps):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator ColorSpace):
(WebCore::CSSPrimitiveValue::operator Hyphens):
(WebCore::CSSPrimitiveValue::operator LineSnap):
(WebCore::CSSPrimitiveValue::operator LineAlign):
(WebCore::CSSPrimitiveValue::operator Order):
(WebCore::CSSPrimitiveValue::operator ESpeak):
(WebCore::CSSPrimitiveValue::operator BlendMode):
(WebCore::CSSPrimitiveValue::operator LineCap):
(WebCore::CSSPrimitiveValue::operator LineJoin):
(WebCore::CSSPrimitiveValue::operator WindRule):
(WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
(WebCore::CSSPrimitiveValue::operator EBorderCollapse):
(WebCore::CSSPrimitiveValue::operator EBorderFit):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
(WebCore::CSSPrimitiveValue::operator ColumnAxis):
(WebCore::CSSPrimitiveValue::operator ColumnProgression):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::convertToLength):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EDominantBaseline):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
(WebCore::CSSPrimitiveValue::operator ETextAnchor):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):
(WebCore::CSSPrimitiveValue::operator EVectorEffect):
(WebCore::CSSPrimitiveValue::operator EMaskType):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/Counter.h:
(WebCore::Counter::listStyleIdent):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/MediaQueryEvaluator.cpp:
(WebCore::orientationMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::colorForCSSValue):
(WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- editing/ApplyStyleCommand.cpp:
(WebCore::toIdentifier):
- editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::create):
(WebCore::HTMLElementEquivalent::HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::create):
(WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::fontWeightIsBold):
(WebCore::legacyFontSizeFromCSSValue):
(WebCore::isTransparentColorValue):
- editing/EditingStyle.h:
- editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::systemFont):
- platform/blackberry/RenderThemeBlackBerry.h:
(WebCore::RenderThemeBlackBerry::systemFont):
- platform/blackberry/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::systemFont):
- platform/blackberry/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::systemFont):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::systemFont):
- platform/gtk/RenderThemeGtk.h:
- platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::systemColor):
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::systemColor):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::systemColor):
- platform/qt/RenderThemeQt.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::systemColor):
- rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::systemFont):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::systemFont):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):
- rendering/RenderThemeWin.h:
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):
- rendering/RenderThemeWinCE.h:
- 10:57 AM Changeset in webkit [151782] by
-
- 1 copy in branches/safari-537-branch
New Branch.
- 10:54 AM Changeset in webkit [151781] by
-
- 22 edits8 adds in branches/dfgFourthTier
fourthTier: DFG should have switch_char
https://bugs.webkit.org/show_bug.cgi?id=117710
Source/JavaScriptCore:
Reviewed by Michael Saboff.
Add op_switch_char. Most of this is fairly simple, except for the whole
LazyJSValue thing.
It's long been the case that anytime you wanted the DFG to speak of a string
that didn't appear in the constant pool, you would have a hard time since
the DFG isn't allowed to allocate in the GC heap. For example, if you know
that you want to speak of a single character string, you might find that
the one you wanted to speak of had been GC'd. Another example is if you
wanted to add constant folding for string concatenation - something we don't
have yet but will want eventually.
I solve this by finally adding the notion of LazyJSValue. In the future I
anticipate using this for a variety of string-related things. The idea here
is that the DFG can either say that it already knows what the value is, or
it can describe the value. For example, in this patch I needed to be able to
describe single-character strings.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/JumpTable.h:
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::payloadGPR):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpTable):
(DFG):
(JSC::DFG::JITCompiler::numberOfJumpTables):
(JSC::DFG::JITCompiler::linkSwitches):
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- dfg/DFGLazyJSValue.cpp: Added.
(DFG):
(JSC::DFG::LazyJSValue::getValue):
(JSC::DFG::equalToSingleCharacter):
(JSC::DFG::LazyJSValue::strictEqual):
(JSC::DFG::LazyJSValue::dump):
- dfg/DFGLazyJSValue.h: Added.
(DFG):
(LazyJSValue):
(JSC::DFG::LazyJSValue::LazyJSValue):
(JSC::DFG::LazyJSValue::singleCharacterString):
(JSC::DFG::LazyJSValue::tryGetValue):
(JSC::DFG::LazyJSValue::value):
(JSC::DFG::LazyJSValue::character):
(JSC::DFG::LazyJSValue::switchLookupValue):
- dfg/DFGNode.h:
(JSC::DFG::SwitchCase::SwitchCase):
(SwitchCase):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(JSC::DFG::SpeculativeJIT::emitSwitchImmIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::emitSwitch):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
Source/WTF:
Reviewed by Michael Saboff.
I wanted to be able to say stringImpl->at(index), and now I can!
Also made it possible to convert a UChar to a utf8 CString without
allocating a StringImpl.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::utf8Impl):
(WTF):
(WTF::StringImpl::utf8ForCharacters):
(WTF::StringImpl::utf8ForRange):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::at):
(WTF::StringImpl::operator[]):
LayoutTests:
Rubber stamped by Mark Hahnenberg.
- fast/js/regress/script-tests/switch-char-constant.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/switch-char.js: Added.
(foo):
(bar):
- fast/js/regress/switch-char-constant-expected.txt: Added.
- fast/js/regress/switch-char-constant.html: Added.
- fast/js/regress/switch-char-expected.txt: Added.
- fast/js/regress/switch-char.html: Added.
- 10:14 AM Changeset in webkit [151780] by
-
- 6 edits in trunk
[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
https://bugs.webkit.org/show_bug.cgi?id=117827
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-20
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Add DumpRenderTreeClient::willSendRequestForFrame() to handle
dispatchWillSendRequest() in DRT.
Fixes tests
fast/loader/onload-willSendRequest-null-for-script.html and
fast/loader/willSendRequest-null-for-preload.html.
- Api/DumpRenderTreeClient.h:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Tools:
Reset the passed in request if willSendRequestReturnsNull() is
true or willSendRequestReturnsNullOnRedirect() is true and it's a
redirection.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
- 9:59 AM Changeset in webkit [151779] by
-
- 2 edits in trunk/Tools
Commit queue shouldn't reopen unrelated bugs because of flakiness
https://bugs.webkit.org/show_bug.cgi?id=117503
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
(_follow_duplicate_chain):
(_update_bug_for_flaky_test):
- 9:16 AM Changeset in webkit [151778] by
-
- 7 edits in trunk/Source/WebCore
AX: List Items should support a default action
https://bugs.webkit.org/show_bug.cgi?id=117812
Reviewed by Chris Fleizach.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::actionVerb): Provide a "select" verb
for use in ListItemRole objects.
- platform/LocalizedStrings.cpp:
(WebCore::AXListItemActionVerb): Added.
- platform/LocalizedStrings.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXListItemActionVerb):
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXListItemActionVerb):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXListItemActionVerb):
- 9:13 AM Changeset in webkit [151777] by
-
- 36 edits3 copies4 adds in trunk
[CSS Regions] Add new regionOversetChange event
https://bugs.webkit.org/show_bug.cgi?id=117508
Source/WebCore:
Added regionOversetChange event and tests for it. The overset value of the region has been moved to the ElementRareData
object instead of the RenderRegion object. This was needed for the case when a reattach is performed (for instance by changing
the display type of the region's containing block) and the RenderRegion object is destroyed. When computing the overset again,
there would be no "previous" value to compare it to and decide whether the regionOversetChange event must be dispatched.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.
Tests: fast/regions/webkit-named-flow-event-add-to-flow.html:
fast/regions/webkit-named-flow-event-auto-height.html:
fast/regions/webkit-named-flow-event-crash.html:
fast/regions/webkit-named-flow-event-no-regions.html:
fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
fast/regions/webkit-named-flow-event-remove-from-dom.html:
fast/regions/webkit-named-flow-event-remove-from-flow.html:
fast/regions/webkit-named-flow-event-target.html:
fast/regions/webkit-named-flow-event-to-null.html:
fast/regions/webkit-named-flow-event.html:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::Element::setRegionOversetState):
(WebCore::Element::regionOversetState):
(WebCore::Element::webkitRegionOverset):
- dom/Element.h:
- dom/ElementRareData.cpp:
- dom/ElementRareData.h:
(WebCore::ElementRareData::regionOversetState):
(WebCore::ElementRareData::setRegionOversetState):
(WebCore::ElementRareData::ElementRareData):
- dom/EventNames.h:
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore::WebKitNamedFlow::dispatchRegionOversetChangeEvent):
- dom/WebKitNamedFlow.h:
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):
- rendering/RegionOversetState.h: Added.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOversetStateForRegions):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
- rendering/RenderNamedFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):
- rendering/RenderRegion.h:
LayoutTests:
Changed regionLayoutUpdate tests to regionOversetChange and added new tests for regionOversetChange.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.
- fast/regions/webkit-named-flow-event-add-to-flow-expected.txt:
- fast/regions/webkit-named-flow-event-add-to-flow.html:
- fast/regions/webkit-named-flow-event-auto-height-expected.txt:
- fast/regions/webkit-named-flow-event-auto-height.html: Added.
- fast/regions/webkit-named-flow-event-crash-expected.txt:
- fast/regions/webkit-named-flow-event-crash.html:
- fast/regions/webkit-named-flow-event-expected.txt:
- fast/regions/webkit-named-flow-event-no-regions-expected.txt:
- fast/regions/webkit-named-flow-event-no-regions.html:
- fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt:
- fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
- fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt:
- fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
- fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt:
- fast/regions/webkit-named-flow-event-remove-from-dom.html:
- fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt:
- fast/regions/webkit-named-flow-event-remove-from-flow.html:
- fast/regions/webkit-named-flow-event-target-expected.txt:
- fast/regions/webkit-named-flow-event-target.html:
- fast/regions/webkit-named-flow-event-to-null-expected.txt:
- fast/regions/webkit-named-flow-event-to-null.html:
- fast/regions/webkit-named-flow-event.html:
- 9:08 AM Changeset in webkit [151776] by
-
- 9 edits in trunk
AX: aria-required is not exposed on all expected roles
https://bugs.webkit.org/show_bug.cgi?id=115123
Patch by James Craig <james@cookiecrook.com> on 2013-06-20
Reviewed by Chris Fleizach.
aria-required is now exposed on more roles. Updated existing test file.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsRequiredAttribute):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
LayoutTests:
- platform/mac/accessibility/aria-required-expected.txt:
- platform/mac/accessibility/aria-required.html:
- platform/mac/accessibility/radio-button-group-members-expected.txt:
- 7:26 AM WebKitGTK/StartHacking edited by
- More minor changes (diff)
- 7:24 AM WebKitGTK/StartHacking edited by
- Minor change (diff)
- 7:20 AM WebKitGTK/StartHacking edited by
- Minor styling (diff)
- 7:17 AM WebKitGTK/StartHacking edited by
- (diff)
- 7:11 AM Changeset in webkit [151775] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Update text checker documentation.
https://bugs.webkit.org/show_bug.cgi?id=117828
Reviewed by Christophe Dumez.
- UIProcess/API/efl/ewk_text_checker.h:
The client is not responsible for destroying the memory.
- 7:09 AM WebKitGTK/StartHacking edited by
- Added choosing distribution section (diff)
- 6:21 AM Changeset in webkit [151774] by
-
- 9 edits2 deletes in trunk
Web Inspector: Use console.timeStamp instead of console.markTimeline
https://bugs.webkit.org/show_bug.cgi?id=117810
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-20
Reviewed by Joseph Pecoraro.
Source/WebCore:
Webkit supports both console.timeStamp and console.markTimeline.
And they do the exact same thing.
This patch gets rid of console.markTimeline for Chrome/Firebug compatibility.
No new functionality, no new tests.
- WebCore.order:
- page/Console.cpp:
- page/Console.h:
- page/Console.idl:
LayoutTests:
Use 'console.timeStamp' instead of 'console.markTimeline' in LayoutTests.
And remove inspector/timeline/timeline-mark-timeline.html.
- inspector/console/console-messages-stack-traces-expected.txt:
- inspector/console/console-messages-stack-traces.html:
- inspector/timeline/timeline-mark-timeline-expected.txt: Removed.
- inspector/timeline/timeline-mark-timeline.html: Removed.
- inspector/timeline/timeline-timer-fired-from-eval-call-site.html:
- 1:22 AM Changeset in webkit [151773] by
-
- 2 edits6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
Rebselining after r151761, see bug 115372.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/vertical-overflow-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/vertical-overflow-parent-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/vertical-overflow-same-expected.txt: Added.
- 1:04 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:39 AM Changeset in webkit [151772] by
-
- 4 edits6 adds in trunk
background-color and text-decoration are not preserved when merging paragraphs
https://bugs.webkit.org/show_bug.cgi?id=116215
Reviewed by Ryosuke Niwa.
Source/WebCore:
In mergeInlineAndImplicitStyleOfElement(), style from matched rules are retrieved.
If they contain either background-color or text-decoration they will be removed
by removeNonEditingProperties() due to copyEditingProperties() implicit
'OnlyInheritableEditingProperties' parameter.
We have already had similar issue at https://bugs.webkit.org/show_bug.cgi?id=53196
Tests: editing/deleting/merge-div-from-span-with-style.html
editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html
editing/deleting/merge-paragraph-from-span-with-style.html
- editing/EditingStyle.cpp:
(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
Add EditingStyle:: due to move EditingPropertiesToInclude to EditingStyle.h.
(WebCore::toEditingProperties):
Add a helper to easy convert PropertiesToInclude to EditingPropertiesToInclude,
needed in mergeInlineAndImplicitStyleOfElement().
(WebCore::EditingStyle::removeAllButEditingProperties):
Add a parameter to choose which editing properties should be preserved while
removing all properties (OnlyInheritableEditingProperties implicite).
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
Call removeAllButEditingProperties with parameter.
- editing/EditingStyle.h:
Move EditingPropertiesType to the header as it's needed by removeAllButEditingProperties().
Change EditingPropertiesType to EditingPropertiesToInclude to be consistent with
PropertiesToInclude.
Change removeNonEditingProperties() to removeAllButEditingProperties().
LayoutTests:
Added tests for verifying merge of paragraph/div from span with non-inline styles.
- editing/deleting/merge-div-from-span-with-style-expected.txt: Added.
- editing/deleting/merge-div-from-span-with-style.html: Added.
- editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration-expected.txt: Added.
- editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html: Added.
- editing/deleting/merge-paragraph-from-span-with-style-expected.txt: Added.
- editing/deleting/merge-paragraph-from-span-with-style.html: Added.
Jun 19, 2013:
- 10:44 PM Changeset in webkit [151771] by
-
- 2 edits in trunk/Source/WebCore
The order of the generated supplemental code is not guaranteed
https://bugs.webkit.org/show_bug.cgi?id=117820
Reviewed by Kentaro Hara.
Sort the supplemental idl files before generating the code so that it is
generated in a consistent order.
No new tests, covered by existing bindings tests.
- bindings/scripts/generate-bindings.pl:
- 10:39 PM Changeset in webkit [151770] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r151769.
http://trac.webkit.org/changeset/151769
https://bugs.webkit.org/show_bug.cgi?id=117821
Broke windows build due to missing GL/glext.h header.
(Requested by bfulgham on #webkit).
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 10:06 PM Changeset in webkit [151769] by
-
- 3 edits in trunk/Source/WebCore
Added WebGL files to Windows build without enabling them.
https://bugs.webkit.org/show_bug.cgi?id=117809
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-06-19
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
- 10:04 PM Changeset in webkit [151768] by
-
- 4 edits in trunk/Source/WebCore
Windows build should include WebGL generated files if WebGL is enabled.
https://bugs.webkit.org/show_bug.cgi?id=117802
Reviewed by Brent Fulgham.
Added WebGL generated files to Windows build if WebGL is enabled.
- DerivedSources.cpp:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 9:30 PM Changeset in webkit [151767] by
-
- 8 edits in trunk/Source/WebKit2
Expose plug-ins CFBundleShortVersionString in the WKPluginInformation dictionary
https://bugs.webkit.org/show_bug.cgi?id=117816
Reviewed by Geoffrey Garen.
- Adds a new key for the WKPluginInformation dictionary: WKPluginInformationBundleShortVersionKey().
- Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationBundleShortVersionKey):
- Shared/API/c/WKPluginInformation.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::pluginInformationBundleShortVersionKey):
- Shared/Plugins/Netscape/PluginInformation.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
(WebKit::getPlatformPluginModuleInformation):
- Shared/Plugins/PluginModuleInfo.h:
- 9:22 PM Changeset in webkit [151766] by
-
- 1 edit1 add in trunk/LayoutTests
Adding a Mac pixel result.
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
- 9:20 PM Changeset in webkit [151765] by
-
- 1 edit3 adds in trunk/LayoutTests
[Windows] Unreviewed AX test expecation gardening.
- platform/win/accessibility/aria-labelledby-on-input-expected.txt: Added.
- platform/win/accessibility/aria-list-and-listitem-expected.txt: Added.
- platform/win/accessibility/aria-roles-expected.txt: Added.
- 9:14 PM Changeset in webkit [151764] by
-
- 2 edits in trunk/Tools
[Windows] AX: Expand notification support.
https://bugs.webkit.org/show_bug.cgi?id=117761
Reviewed by Anders Carlsson.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isPressActionSupported): Provide implementation.
(AccessibilityUIElement::press): Provide implementation.
- 7:35 PM Changeset in webkit [151763] by
-
- 2 edits in trunk/LayoutTests
Unskip feSpecularLight-premultiplied.svg on Mountain Lion
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
- platform/mac/TestExpectations:
The test is failing on Lion exclusively.
- 7:18 PM Changeset in webkit [151762] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Common crashes when playing media
https://bugs.webkit.org/show_bug.cgi?id=117813
<rdar://problem/13837412>
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]): This method may be called from a secondary thread, but it does things that are not thread safe.
- 6:06 PM Changeset in webkit [151761] by
-
- 4 edits12 adds in trunk
Incomplete repaint of input elements in writing-mode overflow
https://bugs.webkit.org/show_bug.cgi?id=110246
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-19
Reviewed by Simon Fraser.
Source/WebCore:
We calculate repaint rect using unflipped rect.
However, RenderBox::applyCachedClipAndScrollOffsetForRepaint() which is called from repaint rect calculation
wants that its argument rect is flipped.
The reason is:
- paintRect.move(-scrolledContentOffset()); cannot scroll if the rect is unflipped.
- It cannot clip using intersect.
Passing unflipped rect to applyCachedClipAndScrollOffsetForRepaint() cause invalid clipping.
Therefore, this patch flipped the rect at the first part of the function and unflipped it at the last part of the function.
Scroll bar rect is absolute rect, so it is flipped rect.
RenderLayer::invalidateScrollbarRect() pass the rect to repaintRectangle() which expects an argument rect is unflipped.
This cause part of overlapping scroll bar doesn't fade out.
Therefore, this patch flipped the rect and pass it to repaintRectangle().
Tests: fast/repaint/horizontal-bt-overflow-child.html
fast/repaint/horizontal-bt-overflow-parent.html
fast/repaint/horizontal-bt-overflow-same.html
fast/repaint/vertical-overflow-child.html
fast/repaint/vertical-overflow-parent.html
fast/repaint/vertical-overflow-same.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateScrollbarRect):
LayoutTests:
- fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
- fast/repaint/horizontal-bt-overflow-child.html: Added.
- fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
- fast/repaint/horizontal-bt-overflow-parent.html: Added.
- fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
- fast/repaint/horizontal-bt-overflow-same.html: Added.
- fast/repaint/vertical-overflow-child-expected.txt: Added.
- fast/repaint/vertical-overflow-child.html: Added.
- fast/repaint/vertical-overflow-parent-expected.txt: Added.
- fast/repaint/vertical-overflow-parent.html: Added.
- fast/repaint/vertical-overflow-same-expected.txt: Added.
- fast/repaint/vertical-overflow-same.html: Added.
- 5:10 PM Changeset in webkit [151760] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/14197983> Rename functions from Bug 117667 and add safeguards for !ENABLE(VIDEO) platforms (117765)
https://bugs.webkit.org/show_bug.cgi?id=117765
Patch by Ruth Fong <ruth_fong@apple.com>.
Reviewed by Brady Eidson.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultGetMediaType): Updated to use mediaType().
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaType): Updated.
Renamed getMediaType() to mediaType() and now handles !ENABLE(VIDEO) platforms.
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- 4:37 PM Changeset in webkit [151759] by
-
- 2 edits in trunk/LayoutTests
Unskip two canvas tests that only fail on Lion
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
- platform/mac/TestExpectations:
- 4:17 PM Changeset in webkit [151758] by
-
- 2 edits in trunk/LayoutTests
Rebaseline 24bit-22khz-resample on Mac
The result did not match the expectation after a system update.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
- platform/mac-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav:
Comparing the files, they have the exact same length, sample rate, bit per sample and binary size.
I cannot ear a difference in the files.
- 3:41 PM Changeset in webkit [151757] by
-
- 28 edits in trunk
Use the PlatformEvent timestamp when creating a DOM Event
https://bugs.webkit.org/show_bug.cgi?id=117179
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
Reviewed by Darin Adler.
Source/WebCore:
Previously, the platform event's timestamp was ignored by WebCore and each
new event would get a new timestamp by calling WTF::currentTime().
The problem is there can be a significant delay between the input event and
it being dispatched to JavaScript. Computing the velocity/acceleration of the cursor
is impossible since the delay vary from event to events.
On WebKit2, the delay per event typically vary between 0 and 30ms.
This patch changes the Event creation code to use the timer passed by the underlying platform event.
- WebCore.exp.in:
- dom/Event.cpp:
(WebCore::Event::Event):
- dom/Event.h:
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::GestureEvent):
- dom/GestureEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
- dom/MouseEvent.h:
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
- dom/MouseRelatedEvent.h:
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
- dom/UIEvent.cpp:
(WebCore::UIEvent::UIEvent):
- dom/UIEvent.h:
- dom/UIEventWithKeyState.h:
(WebCore::UIEventWithKeyState::UIEventWithKeyState):
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
- dom/WheelEvent.h:
(WebCore::WheelEvent::create):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
Source/WebKit/mac:
- WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
Source/WebKit2:
- Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebGestureEvent):
Tools:
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):
- 3:28 PM Changeset in webkit [151756] by
-
- 1 edit in trunk/Source/WTF/ChangeLog
Fixed reviewer name
- 3:27 PM Changeset in webkit [151755] by
-
- 2 edits in trunk/Source/WTF
Remove the SegmentedVector inline segment to shrink CodeBlock by 6X
https://bugs.webkit.org/show_bug.cgi?id=117808
Reviewed by Geoffrey Garen.
SegmentedVector allocation isn't super hot, but we do tend to have many
live SegmentedVectors at runtime, particularly in CodeBlocks, so the
right tradeoff is to allocate segments out-of-line as needed.
This reduces startup memory usage @ google.com by about 6MB.
No regression on SunSpider.
- wtf/SegmentedVector.h:
(WTF::SegmentedVector::SegmentedVector):
(WTF::SegmentedVector::at):
(WTF::SegmentedVector::append):
(WTF::SegmentedVector::removeLast):
(WTF::SegmentedVector::clear):
(WTF::SegmentedVector::deleteAllSegments): No more inline segment.
(WTF::SegmentedVector::ensureSegmentsFor): This code used to assume
that there was always a 0 segment, so the math would underflow if there
were no 0 segment. I udpated the math to account for having no segments.
- 3:16 PM BuildingGtk edited by
- Added links to root pages (diff)
- 3:12 PM WebKitGTK/StartHacking edited by
- (diff)
- 3:11 PM WebKitGTK/StartHacking edited by
- Added hacking guide section (diff)
- 3:07 PM WebKitGTK/Chroot edited by
- (diff)
- 3:07 PM Changeset in webkit [151754] by
-
- 21 edits in trunk/Source/WebCore
Make sure to use CSSValueID and CSSPropertyID rather than integers
https://bugs.webkit.org/show_bug.cgi?id=117481
Reviewed by Benjamin Poulain.
This will ensure that types are enforced when passing arguments in various
css functions. Having a compile time check make sure that no mistakes
will be done over the type.
The parser was also patched to directly use CSSValueID over integers.
This patch also fixes various call sites abusing the usage of integers.
This is part 1 of 2.
No new tests : existing ones should cover.
- WebCore.xcodeproj/project.pbxproj: copy CSSValueKeywords.h as it could be used in WebKit/ for example.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForRepeatRule):
(WebCore::cssIdentifierForFontSizeKeyword):
(WebCore::identifierForFamily):
(WebCore::valueForFamily):
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseLineHeight):
(WebCore::CSSParser::parseFontSize):
(WebCore::CSSParser::createFontWeightValueKeyword):
(WebCore::CSSParser::parseFontWeight):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::rewriteSpecifiers):
- css/CSSParser.h:
- css/CSSParserValues.h:
- css/CSSPrimitiveValue.h:
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createIdentifierValue):
- css/CSSValuePool.h:
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::setProperty):
- css/StylePropertySet.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
- dom/StyledElement.h:
- editing/EditingStyle.cpp:
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::prepareToApplyAt):
- editing/EditorCommand.cpp:
(WebCore::executeApplyStyle):
(WebCore::executeFontSize):
- html/HTMLElement.cpp:
(WebCore::unicodeBidiAttributeForDirAuto):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
(WebCore::HTMLFontElement::collectStyleForPresentationAttribute):
- html/HTMLFontElement.h:
- html/HTMLTableElement.cpp:
(WebCore::leakBorderStyle):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getCSSWritingDirection):
(WebCore::TextTrackCue::getCSSWritingMode):
- html/track/TextTrackCue.h:
- 2:54 PM WebKitGTK/Chroot edited by
- Minor fix (diff)
- 2:53 PM WebKitGTK/Chroot edited by
- Added Fixes (diff)
- 1:54 PM Changeset in webkit [151753] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Correct style on last patch.
Reviewed by Tim Horton.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
- 1:51 PM Changeset in webkit [151752] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed build correction.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Make sure returned generic
type is a CFStringRef before casting.
- 1:37 PM Changeset in webkit [151751] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed build fix for Apple Windows port.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
- 1:11 PM Changeset in webkit [151750] by
-
- 6 edits in trunk/Source/WebCore
Fix a few missed renames from Exclusions -> Shapes
https://bugs.webkit.org/show_bug.cgi?id=117803
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-19
Reviewed by David Hyatt.
In the great CSS Exclusions to CSS Shapes rename, a few instances were
missed. This fixes those instances.
No new tests, no behavior change, just renames.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
(WebCore::RenderBlock::updateRegionsAndShapesAfterChildLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
- rendering/RenderBlock.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- 1:09 PM Changeset in webkit [151749] by
-
- 9 edits1 add in branches/dfgFourthTier/Source/JavaScriptCore
Refactor ObjCCallbackFunction to inherit directly from InternalFunction
https://bugs.webkit.org/show_bug.cgi?id=117595
Reviewed by Geoffrey Garen.
- API/APICallbackFunction.h: Added. New struct that allows JSCallbackFunction and
ObjCCallbackFunction to share their host call() implementation through the magic of
templates.
(JSC::APICallbackFunction::call):
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::getCallData): Changed to get the template-ized version of
the host function.
- API/JSCallbackFunction.h:
- API/ObjCCallbackFunction.h: Now inherits directly from InternalFunction.
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunction::ObjCCallbackFunction):
(JSC::ObjCCallbackFunction::getCallData): Ditto.
- GNUmakefile.list.am: Build files!
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:05 PM Changeset in webkit [151748] by
-
- 8 edits in trunk/Source/WebKit2
REGRESSION: Cannot open Silverlight preferences via context menu
https://bugs.webkit.org/show_bug.cgi?id=117806
<rdar://problem/14166644>
Reviewed by Beth Dakin.
Hook the LSOpenCFURLRef function and make the UI process open the URL if it's the URL for the
Silverlight Preferences application. This is what we do for the Flash updater.
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::openCFURLRef):
(WebKit::initializeShim):
(WebKit::PluginProcess::openURL):
- PluginProcess/mac/PluginProcessShim.h:
- PluginProcess/mac/PluginProcessShim.mm:
(WebKit::shimLSOpenCFURLRef):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isSilverlightPreferencesURL):
(WebKit::shouldOpenURL):
(WebKit::PluginProcessProxy::openURL):
- 12:45 PM Changeset in webkit [151747] by
-
- 2 edits in trunk/Source/WebCore
Incorrect use of jsCast in a finalizer
https://bugs.webkit.org/show_bug.cgi?id=117807
Reviewed by Geoffrey Garen.
We can't use jsCast in a finalizer as it checks an object's structure,
and the structure may already have been swept by that point. Use a
static_cast instead.
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::destroy):
- 11:54 AM Changeset in webkit [151746] by
-
- 26 edits in trunk/LayoutTests
Rebaseline results on GTK and EFL after r151737
Unreviewed, gardening.
- platform/efl/fast/css/word-space-extra-expected.txt:
- platform/efl/fast/replaced/width100percent-image-expected.png:
- platform/efl/fast/replaced/width100percent-image-expected.txt:
- platform/efl/fast/replaced/width100percent-menulist-expected.png:
- platform/efl/fast/replaced/width100percent-menulist-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.png:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- platform/efl/fast/replaced/width100percent-textarea-expected.png:
- platform/efl/fast/replaced/width100percent-textarea-expected.txt:
- platform/efl/fast/replaced/width100percent-textfield-expected.png:
- platform/efl/fast/replaced/width100percent-textfield-expected.txt:
- platform/efl/tables/mozilla/bugs/bug57828-expected.png:
- platform/efl/tables/mozilla/bugs/bug57828-expected.txt:
- platform/gtk/fast/css/word-space-extra-expected.txt:
- platform/gtk/fast/replaced/width100percent-image-expected.png:
- platform/gtk/fast/replaced/width100percent-image-expected.txt:
- platform/gtk/fast/replaced/width100percent-menulist-expected.png:
- platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.png:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
- platform/gtk/fast/replaced/width100percent-textarea-expected.png:
- platform/gtk/fast/replaced/width100percent-textarea-expected.txt:
- platform/gtk/fast/replaced/width100percent-textfield-expected.png:
- platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57828-expected.txt:
- 11:45 AM Changeset in webkit [151745] by
-
- 8 edits in trunk/Source
../WebCore: [Windows] AX: Extend notification handling
https://bugs.webkit.org/show_bug.cgi?id=117761.
Reviewed by Anders Carlsson.
accessibility/press-works-on-control-types.html
- accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Add handlers for more event notifications.
- accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Protect against null
pointer dereference found during testing.
- dom/Document.cpp:
(WebCore::Document::implicitClose): Execute notification handler for Windows as well as Mac.
- page/FrameView.cpp:
(WebCore::FrameView::layout): Ditto.
../WebKit/win: [Windows] AX: Extend notification support.
https://bugs.webkit.org/show_bug.cgi?id=117761
Reviewed by Anders Carlsson.
- AccessibleDocument.cpp:
(AccessibleDocument::state): Improve handling of focus state.
- AccessibleDocument.h: Provide signature for new state override.
- 11:38 AM Changeset in webkit [151744] by
-
- 14 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Arity fixup should be done while on same stack
https://bugs.webkit.org/show_bug.cgi?id=117102
Reviewed by Oliver Hunt.
Removed the fixup part of op_call_arityCheck() and op_construct_arityCheck() and moved it to
a thunk for the JITs and as assembly for the llint. This patch provides the plumbing needed to
move to the C stack for JS execution. The fixup thunk and llint code would need to be change to
work with a stack that grows down when we do move to the C stack.
Due to an issue with the offline assembler, I moved the const at the top of LowLevelInterpreter64.asm
and LowLevelInterpreter32_64.asm to LowLevelInterpreter.asm. The problem is that a const defined in
one file that are used in a macro doesn't resolve the const if the macro is used in another file. This
seemed like the quickest path.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- jit/ThunkGenerators.cpp:
(JSC::arityFixup):
- jit/ThunkGenerators.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
- 11:17 AM Changeset in webkit [151743] by
-
- 4 edits1 delete in trunk/Source/WebCore
[WinCairo] Webfont rendering is broken.
https://bugs.webkit.org/show_bug.cgi?id=117695
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-19
Reviewed by Brent Fulgham.
The native font handle created from webfont data is invalid.
In much the same way it's done in WinApple, we first need to install the webfont,
create a native font handle from the new font name,
and pass the font handle to the FontPlatformData object, where it's needed to get the glyphs.
- platform/graphics/FontPlatformData.h: Added HFONT parameter to constructor.
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Release installed webfont.
(WebCore::FontCustomPlatformData::fontPlatformData): Create valid HFONT handle for webfont.
(WebCore::createUniqueFontName): Added method to create webfont name.
(WebCore::createFontCustomPlatformData): Install font from webfont data.
- platform/graphics/win/FontCustomPlatformDataCairo.h: Removed.
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Added HFONT parameter to constructor.
- 11:05 AM Changeset in webkit [151742] by
-
- 3 edits in trunk/Source/WebKit/win
[WinCairo] Does not compile.
https://bugs.webkit.org/show_bug.cgi?id=117798
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-19
Reviewed by Brent Fulgham.
Add USE(CFNETWORK) guards.
- WebCoreSupport/WebFrameNetworkingContext.cpp: Add USE(CFNETWORK) guard.
(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Change USE(CF_NETWORK) to USE(CFNETWORK).
- WebCoreSupport/WebFrameNetworkingContext.h: Add USE(CFNETWORK) guard.
- 10:42 AM Changeset in webkit [151741] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
FTL: arm build is broken in ToT
https://bugs.webkit.org/show_bug.cgi?id=117800
Unreviewed build fixes.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler): Merge of r147941
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mod): Moved variable declaration back inside #ifdef where used.
- 10:40 AM Changeset in webkit [151740] by
-
- 18 edits1 copy9 adds in trunk/Source/WebCore
Implement WebIDL implements
https://bugs.webkit.org/show_bug.cgi?id=117785
Reviewed by Kentaro Hara.
Add support for Web IDL 'implements' statements to the bindings generator:
http://www.w3.org/TR/WebIDL/#dfn-implements-statement
Introduce ChildNode IDL interface and have Element, DocumentType and
CharacterData implement it, to match the specification:
http://dom.spec.whatwg.org/#childnode
There is no change in behavior, merely refactoring to match the
specification by leveraging support for Web IDL implements statements.
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- bindings/scripts/generate-bindings.pl:
- bindings/scripts/preprocess-idls.pl:
(GeneratePartialInterface):
(getImplementersFromIDL):
- bindings/scripts/test/CPP/WebDOMTestImplements.cpp: Added.
- bindings/scripts/test/CPP/WebDOMTestImplements.h: Added.
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
(WebDOMTestInterface::implementsStr1):
(WebDOMTestInterface::implementsStr2):
(WebDOMTestInterface::setImplementsStr2):
(WebDOMTestInterface::implementsNode):
(WebDOMTestInterface::setImplementsNode):
(WebDOMTestInterface::implementsMethod1):
(WebDOMTestInterface::implementsMethod4):
- bindings/scripts/test/CPP/WebDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestImplements.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestImplements.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_implements_method1):
(webkit_dom_test_interface_implements_method2):
(webkit_dom_test_interface_implements_method4):
(webkit_dom_test_interface_get_implements_str1):
(webkit_dom_test_interface_get_implements_str2):
(webkit_dom_test_interface_set_implements_str2):
(webkit_dom_test_interface_get_implements_node):
(webkit_dom_test_interface_set_implements_node):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/JS/JSTestImplements.cpp: Added.
- bindings/scripts/test/JS/JSTestImplements.h: Added.
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr):
(WebCore::jsTestInterfaceImplementsStr1):
(WebCore::jsTestInterfaceImplementsStr2):
(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr):
(WebCore::setJSTestInterfaceImplementsStr2):
(WebCore::setJSTestInterfaceImplementsStr3):
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3):
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4):
(WebCore::jsTestInterfaceIMPLEMENTSCONSTANT1):
(WebCore::jsTestInterfaceIMPLEMENTSCONSTANT2):
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestImplements.cpp: Added.
- bindings/scripts/test/ObjC/DOMTestImplements.h: Added.
- bindings/scripts/test/ObjC/DOMTestInterface.h:
- bindings/scripts/test/ObjC/DOMTestInterface.mm:
(-[DOMTestInterface implementsStr1]):
(-[DOMTestInterface implementsStr2]):
(-[DOMTestInterface setImplementsStr2:]):
(-[DOMTestInterface implementsStr3]):
(-[DOMTestInterface setImplementsStr3:]):
(-[DOMTestInterface implementsNode]):
(-[DOMTestInterface setImplementsNode:]):
(-[DOMTestInterface implementsMethod1]):
(-[DOMTestInterface implementsMethod2:objArg:]):
(-[DOMTestInterface implementsMethod3]):
(-[DOMTestInterface implementsMethod4]):
- bindings/scripts/test/TestImplements.idl: Added.
- dom/CharacterData.idl:
- dom/ChildNode.idl: Copied from Source/WebCore/dom/DocumentType.idl.
- dom/DocumentType.idl:
- dom/Element.idl:
- 10:33 AM Changeset in webkit [151739] by
-
- 2 edits in trunk/Source/WTF
BUILD FIX (r151663): Fix build for iOS WebKit
- wtf/text/AtomicStringTable.cpp: Include MainThread.h.
(WTF::AtomicStringTable::create): Use AtomicStringTable::destroy
instead of non-existent destroyAtomicStringTable function.
- 10:29 AM Changeset in webkit [151738] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Copying array or object output does not contain values
https://bugs.webkit.org/show_bug.cgi?id=117669
ConsoleCommandResult was overriding toClipboardString() but wasn't using the complex code
in ConsoleMessageImpl's toClipboardString() to provide a nicely formatted output for objects.
We now use a "clipboarPrefixString" property to customize the prefix used in the clipboard
and, additionally, only use that prefix if we're copying more than a single message since it's
the only situation where it's useful to have the ">" or "<" prefix shown. Console messages with
a log level always print the level and when saving the console log using Cmd+S, all messages
contain their prefix as well.
Reviewed by Timothy Hatcher.
- UserInterface/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.toClipboardString):
Handle the new isPrefixOptional argument.
- UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.get clipboarPrefixString):
Provide a custom "< " prefix and set "enforcesClipboardPrefixString" to false such that
the prefix isn't printed out in situations when it may not.
- UserInterface/ConsoleMessageImpl.js:
Set "enforcesClipboardPrefixString" to true since we always want to log the log level
prefix in all situations.
(WebInspector.ConsoleMessageImpl.prototype.get clipboarPrefixString):
Implement this new getter to return our clipboard string such that subclasses may
customize it.
(WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
Take into account both isPrefixOptional and the "enforcesClipboardPrefixString" property
to only log the prefix if necessary.
- UserInterface/LogContentView.js:
(WebInspector.LogContentView.prototype._formatMessagesAsData):
Make the logging of prefix optional when we have a single message selected and we're
not saving via Cmd+S.
- 10:20 AM Changeset in webkit [151737] by
-
- 15 edits2 adds in trunk
Incorrect computation of shrink-to-fit width for block with white-space:nowrap and floating children
https://bugs.webkit.org/show_bug.cgi?id=114879
Source/WebCore:
Reviewed by David Hyatt.
Per http://www.w3.org/TR/CSS21/visudet.html#Computing_widths_and_margins when width is auto then floating non-replaced,
absolute non-replaced, and inline-block non-replaced elements should use shrink-to-fit width. This trumps any no-wrap property
on the element so if we are shrinking to fit ensure our minimum width respects all possible line breaks.
Test: fast/block/shrink-to-fit-width-container-with-floating-children.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
LayoutTests:
Reviewed by David Hyatt.
- fast/block/shrink-to-fit-width-container-with-floating-children-expected.txt: Added.
- fast/block/shrink-to-fit-width-container-with-floating-children.html: Added.
- platform/qt/fast/css/word-space-extra-expected.txt:
- platform/qt/fast/replaced/width100percent-image-expected.txt:
- platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
- platform/qt/fast/replaced/width100percent-textfield-expected.txt:
- platform/qt/tables/mozilla/bugs/bug57828-expected.txt:
- 10:20 AM WebKitGtkLayoutTests edited by
- (diff)
- 10:19 AM WebKitGTK/Chroot created by
- Initial editing
- 10:12 AM Changeset in webkit [151736] by
-
- 14 edits7 deletes in trunk/Source/WebCore
Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter] is used
https://bugs.webkit.org/show_bug.cgi?id=117795
Reviewed by Kentaro Hara.
Fix the JS bindings generator so that it stops including JS*Custom.h header whenever
[CustomPutFunction] or [CustomNamedSetter] IDL extended attributes are used. We don't
really need this custom header and this forces the developer to create dummy custom
headers so that it builds.
If the developer really needs such custom header to be included, he can still use
[JSCustomHeader] IDL extended attribute to do so.
This patch also remove the dummy custom headers that were created but are no longer
required to build.
No new tests, no behavior change. Already covered by the following bindings test:
TestInterface.idl
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMStringMapCustom.h: Removed.
- bindings/js/JSHTMLAppletElementCustom.cpp:
- bindings/js/JSHTMLAppletElementCustom.h: Removed.
- bindings/js/JSHTMLEmbedElementCustom.cpp:
- bindings/js/JSHTMLEmbedElementCustom.h: Removed.
- bindings/js/JSHTMLObjectElementCustom.cpp:
- bindings/js/JSHTMLObjectElementCustom.h: Removed.
- bindings/js/JSHistoryCustom.cpp:
- bindings/js/JSHistoryCustom.h: Removed.
- bindings/js/JSLocationCustom.cpp:
- bindings/js/JSLocationCustom.h: Removed.
- bindings/js/JSStorageCustom.cpp:
- bindings/js/JSStorageCustom.h: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- 10:11 AM WebKitGTK/StartHacking edited by
- Added other section (diff)
- 9:27 AM WebKitGTK/StartHacking edited by
- Added contributin patches section (diff)
- 9:16 AM WebKitGTK/StartHacking edited by
- Added compilation issues section (diff)
- 9:09 AM WebKitGTK/StartHacking edited by
- Added continuous integration section (diff)
- 9:08 AM WebKitGTK/StartHacking edited by
- Added continuous integration section (diff)
- 9:01 AM WebKitGTK/Debugging edited by
- (diff)
- 9:00 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 8:55 AM WebKitGTK/Debugging created by
- Initial editing
- 8:47 AM WebKitGTK/StartHacking edited by
- Added debugging section (diff)
- 8:45 AM WebKitGTK/StartHacking edited by
- Added rebuild and testing (diff)
- 8:30 AM Changeset in webkit [151735] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
https://bugs.webkit.org/show_bug.cgi?id=117799
https://jira.bbqnx.net/browse/BRWSR-11712
JIRA413289
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-19
Reviewed by Carlos Garcia Campos.
Discovered by Xuefei Ren.
If, in rare cases, renderContents() returns false,
the for() loop in render() will take a tile buffer from
the surface pool but due to aborting the iteration early,
won't put it into the new tile map. In order to prevent
losing the buffer, we need to put it back into the
surface pool before continuing.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
- 8:23 AM Changeset in webkit [151734] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Several tests crash due to an assert when creating an ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=117793
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-19
Reviewed by Rob Buis.
JIRA 388741
Fixes a crash in several layout tests due to an assert when
creating an ImageBuffer with an empty size.
- platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::ImageBuffer): Return early if the given
size is empty.
- 8:03 AM Changeset in webkit [151733] by
-
- 4 edits in trunk
[GStreamer] [texmap] the bytesPerLine is wrong when updating the texture
https://bugs.webkit.org/show_bug.cgi?id=117551
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-19
Reviewed by Philippe Normand.
Source/WebCore:
The bytesPerLine (or stride) is wrong when updating the texture
content. This is because the naturalSize() is not updated to the
current buffer. This patch extracts the current value of the size and
the stride.
No tests required.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
LayoutTests:
- platform/gtk-wk2/TestExpectations:
enabled media/video-display-aspect-ratio.html
- 7:23 AM Changeset in webkit [151732] by
-
- 1 edit2 adds in trunk/LayoutTests
[Qt] Unreviewed rebaselining after 151705.
- platform/qt/http/tests/cache/partitioned-cache-expected.txt: Added.
- platform/qt/http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
- 6:22 AM Changeset in webkit [151731] by
-
- 2 edits in trunk/Source/WebCore
Adjust internal size on gstreamer source element when receiving data if necessary
https://bugs.webkit.org/show_bug.cgi?id=116534
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-06-19
Reviewed by Philippe Normand.
If the size received in didReceiveResponse is smaller than the actual size of the received data
update the internal size and the appsrc size to the proper value.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveData):
- 6:10 AM Changeset in webkit [151730] by
-
- 2 edits in trunk/LayoutTests
[Qt] TestExpectation sorting on Qt WK2.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-19
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/TestExpectations:
- 5:36 AM WebKitGTK/StartHacking edited by
- Added compiling section (diff)
- 5:12 AM WebKitGTK/SpeedUpBuild edited by
- (diff)
- 5:11 AM WebKitGTK/SpeedUpBuild edited by
- Indenting (diff)
- 5:05 AM WebKitGTK/SpeedUpBuild created by
- Initial editing
- 4:49 AM WebKitGTK/StartHacking edited by
- Added initial compiling section (diff)
- 4:29 AM WebKitGTK/StartHacking created by
- 3:53 AM Changeset in webkit [151729] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Implement unit test callback: onSettingChange.
https://bugs.webkit.org/show_bug.cgi?id=117728
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-06-19
Reviewed by Christophe Dumez.
It is finally possible to implement missing unit tests as WebKit2-EFL
has delivered sub menu (r150254).
Add two unit tests for checking onSettingChange callback behaviour,
when toggling "Check Spelling While Typing" in context menu.
Changed types inside callbacksExecutionStats struct from bit field to bool,
because casting from bit field to &bool is invalid (in using waitUntilTrue method).
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(resetCallbacksExecutionStats):
(onSettingChange):
(findContextMenuItem):
Get determined option from context menu.
(checkCorrectnessOfSpellingItems):
Changed the name of onContextMenuShow method to be consistent with new methods.
(toogleCheckSpellingWhileTyping):
Select "Check Spelling While Typing" in context menu to test whether
onSettingChange is called.
- 3:30 AM WebKitGTK edited by
- Added newbies section (diff)
- 2:14 AM Changeset in webkit [151728] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Potential race condition when getting the video sink caps.
https://bugs.webkit.org/show_bug.cgi?id=117736
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-19
Reviewed by Philippe Normand.
There is a potential race condition with the pad setting caps, as the
buffer and the caps won't match when renegotiation happens, and might
cause a crash.
This patch keeps an instance of the current caps in the video sink,
and it is accessible through a getter method. Hence the player can ask
for the current caps without running into a race condition.
No new tests. No change in behaviour.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkGetProperty):
(webkitVideoSinkStop):
(webkitVideoSinkSetCaps):
(webkit_video_sink_class_init):
- 1:07 AM Changeset in webkit [151727] by
-
- 11 edits2 moves3 adds in trunk
Vibration can be canceled even if page visibility status is hidden
https://bugs.webkit.org/show_bug.cgi?id=117333
Reviewed by Gyuyoung Kim.
Source/WebCore:
vibration can be canceled in the onvisibilitychange listener even if page visibility is changed to hidden status.
Therefore cancelVibration needs to work when page visibility is hidden.
Tests: vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html
- Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
- Modules/vibration/Vibration.h:
(WebCore::Vibration::isVibrating):
- testing/Internals.cpp:
(WebCore::Internals::isVibrating):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add a test case for cancel vibration after page visibility is changed to hidden status.
In addition, move navigator-vibration.html to vibration directory.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- vibration/cancelVibration-after-pagevisibility-changed-to-hidden-expected.txt: Added.
- vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html: Added.
- vibration/navigator-vibration-expected.txt: Renamed from LayoutTests/fast/dom/navigator-vibration-expected.txt.
- vibration/navigator-vibration.html: Renamed from LayoutTests/fast/dom/navigator-vibration.html.
- 12:33 AM Changeset in webkit [151726] by
-
- 4 edits in trunk/Source/WebKit2
[GTK][SOUP] Migrate SoupRequestManager to GTask
https://bugs.webkit.org/show_bug.cgi?id=117157
Reviewed by Gustavo Noronha Silva.
GSimpleAsyncResult has been deprecated in favour of GTask.
- WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::releaseTask):
(WebKit::WebSoupRequestManager::didHandleURIRequest):
(WebKit::WebSoupRequestManager::didFailURIRequest):
(WebKit::WebSoupRequestManager::send):
(WebKit::WebSoupRequestManager::finish):
- WebProcess/soup/WebSoupRequestManager.h:
- 12:24 AM Changeset in webkit [151725] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitFaviconDatabase to GTask
https://bugs.webkit.org/show_bug.cgi?id=117156
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(processPendingIconsForPageURL):
(webkit_favicon_database_get_favicon):
(webkit_favicon_database_get_favicon_finish):
- 12:19 AM Changeset in webkit [151724] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitWebView to GTask
https://bugs.webkit.org/show_bug.cgi?id=117154
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitWebView.cpp:
(didValidateCommand):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_can_execute_editing_command_finish):
(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(webkit_web_view_run_javascript_finish):
(resourcesStreamReadCallback):
(webkit_web_view_run_javascript_from_gresource):
(webkit_web_view_run_javascript_from_gresource_finish):
(fileReplaceContentsCallback):
(getContentsAsMHTMLDataCallback):
(webkit_web_view_save):
(webkit_web_view_save_finish):
(webkit_web_view_save_to_file):
(webkit_web_view_save_to_file_finish):
(webKitWebViewDidReceiveSnapshot):
(webkit_web_view_get_snapshot):
(webkit_web_view_get_snapshot_finish):
- 12:13 AM Changeset in webkit [151723] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitCookieManager to GTask
https://bugs.webkit.org/show_bug.cgi?id=117150
Reviewed by Gustavo Noronha Silva.
Don't use helper structs for async data since the cancellable is
now accessible from the GTask.
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerGetAcceptPolicyCallback):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_get_accept_policy_finish):
(webkitCookieManagerGetDomainsWithCookiesCallback):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_get_domains_with_cookies_finish):
