⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 21, 2013:

10:56 PM Changeset in webkit [151876] by fpizlo@apple.com
  • 4 edits
    3 adds in branches/dfgFourthTier

fourthTier: DFG should CSE MakeRope
​https://bugs.webkit.org/show_bug.cgi?id=117905

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Adds MakeRope to the CSE phase and removes the comment that says that
we could do it but aren't doing it.

Also fixed SpeculatedType dumping so that if you have a Cell type then
it just prints "Cell" and if you just have Object then it just prints
"Object", instead of printing the long list of types.

  • bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

LayoutTests:

Reviewed by Geoffrey Garen.

This benchmark speeds up by 50%.

  • fast/js/regress/make-rope-cse-expected.txt: Added.
  • fast/js/regress/make-rope-cse.html: Added.
  • fast/js/regress/script-tests/make-rope-cse.js: Added.

(foo):

7:36 PM Changeset in webkit [151875] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
​https://bugs.webkit.org/show_bug.cgi?id=117903

Reviewed by Darin Adler.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments): Add a NULL check for
RenderStyle here...
(WebCore::StyleResolver::loadPendingResources): ...and here.

7:27 PM Changeset in webkit [151874] by fpizlo@apple.com
  • 7 edits
    3 adds in branches/dfgFourthTier

fourthTier: DFG should't exit just because it GetByVal'd a big character
​https://bugs.webkit.org/show_bug.cgi?id=117899

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Add a slow path. Also clarify handling of GetByVal in PutStructure elimination.
Previously it would fail due to canExit() but now we can also fail because
GetByVal(String) can allocate. Just make it so GetByVal is totally poisoned, in
a very explicit way.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):

LayoutTests:

Reviewed by Mark Hahnenberg.

This benchmark speeds up by 3x.

  • fast/js/regress/script-tests/string-get-by-val-big-char.js: Added.

(foo):

  • fast/js/regress/string-get-by-val-big-char-expected.txt: Added.
  • fast/js/regress/string-get-by-val-big-char.html: Added.
6:10 PM Changeset in webkit [151873] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Occasional crash swiping between pages
​https://bugs.webkit.org/show_bug.cgi?id=117902

Reviewed by Beth Dakin.

m_scrollingStateTree->rootStateNode() can be null when quickly swiping between pages,
so check this in ScrollingCoordinatorMac::commitTreeState().

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::commitTreeState):

5:25 PM Changeset in webkit [151872] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed crash protection for DRT

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines

to avoid crashing during test runs.

5:13 PM Changeset in webkit [151871] by mark.lam@apple.com
  • 2 edits in branches/dfgFourthTier/Source/WebCore

Fixed broken build: updated to match SmallStrings changes in r151864.

Not reviewed.

No new tests.

  • bindings/js/JSDOMBinding.h:

(WebCore::jsStringWithCache):

5:08 PM Changeset in webkit [151870] by Brent Fulgham
  • 1 edit
    1 add in trunk/LayoutTests

[Windows] Unreviewed gardening.

  • platform/win/accessibility/aria-menubar-menuitems-expected.txt: Added.
4:58 PM Changeset in webkit [151869] by mark.lam@apple.com
  • 11 edits
    1 add in trunk

Source/JavaScriptCore: Introducing the VMStackBounds class.
​https://bugs.webkit.org/show_bug.cgi?id=117862.

Reviewed by Geoffrey Garen.

  • Removed Interpreter::StackPolicy.
  • The new VMStackBounds will take over choosing the appropriate stack size requirements, and invoking the underlying WTF::StackBounds to to the real bounds check.
  • VMStackBounds will now be used universally throughout JSC instead of WTF::StackBounds.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • interpreter/Interpreter.h:

(JSC::Interpreter::isInErrorHandlingMode):

  • parser/Parser.cpp:

(JSC::::Parser):

  • parser/Parser.h:
  • runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):

  • runtime/VMStackBounds.h: Added.

(JSC::VMStackBounds::VMStackBounds):
(JSC::VMStackBounds::isSafeToRecurse):
(JSC::VMStackBounds::requiredCapacity):

LayoutTests: Reverting failure expectation for fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
​https://bugs.webkit.org/show_bug.cgi?id=117862.

Reviewed by Geoffrey Garen.

  • platform/mac/TestExpectations:
4:39 PM Changeset in webkit [151868] by Brent Fulgham
  • 3 edits
    3 adds in trunk

AX: Title for ListItemRole should consist of concatenated child text elements.
​https://bugs.webkit.org/show_bug.cgi?id=117892

Reviewed by Chris Fleizach.

Source/WebCore:

accessibility/listitem-title.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::visibleText): Add ListItemRole to set of
elements that concatenate their children for display purposes.
(WebCore::AccessibilityNodeObject::title): Ditto.

LayoutTests:

  • accessibility/listitem-title.html: Added.
  • platform/mac/accessibility/listitem-title-expected.txt: Added.
  • platform/win/accessibility/listitem-title-expected.txt: Added.
4:28 PM Changeset in webkit [151867] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit

Merged r151847. <rdar://problem/14231905>

4:27 PM Changeset in webkit [151866] by Lucas Forschler
  • 8 edits in branches/safari-537-branch/Source

Merged r151787. <rdar://problem/14219184>

4:23 PM Changeset in webkit [151865] by Lucas Forschler
  • 6 edits
    3 deletes in branches/safari-537-branch/LayoutTests

Merged r151801.

4:05 PM Changeset in webkit [151864] by fpizlo@apple.com
  • 8 edits
    3 adds in branches/dfgFourthTier

fourthTier: Small strings shouldn't get GC'd
​https://bugs.webkit.org/show_bug.cgi?id=117897

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Kill off the code needed to allocate them lazily and finalize them.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • runtime/JSString.h:

(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring8):
(JSC::jsSubstring):
(JSC::jsOwnedString):

  • runtime/NumberPrototype.cpp:

(JSC::integerValueToString):

  • runtime/SmallStrings.cpp:

(JSC):
(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::visitStrongReferences):

  • runtime/SmallStrings.h:

(JSC::SmallStrings::singleCharacterString):
(SmallStrings):

LayoutTests:

Reviewed by Mark Hahnenberg.

This test speeds up by 5%.

  • fast/js/regress/script-tests/string-get-by-val.js: Added.

(foo):

  • fast/js/regress/string-get-by-val-expected.txt: Added.
  • fast/js/regress/string-get-by-val.html: Added.
3:50 PM Changeset in webkit [151863] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[MediaStream]: Remove >= 0 assertion from a size_t variable
​https://bugs.webkit.org/show_bug.cgi?id=117890

Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Adam Barth.

This patch fixes a strict build by removing the >= 0 assertion from
a size_t (unsigned type) variable in RTCStatsResponse.cpp.

No new tests; build fix.

  • Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addStatistic): Remove >=0assertion,
since the variable is unsigned and is always >= 0.

3:20 PM Changeset in webkit [151862] by Lucas Forschler
  • 5 edits in tags/Safari-537.46.4/Source

Versioning.

3:13 PM Changeset in webkit [151861] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception when pretty printing WebInspector.Script
​https://bugs.webkit.org/show_bug.cgi?id=117893

This was an issue with an earlier refactoring. The sourceCode is a Script,
so replace the non-existent local variable "script" with "this._sourceCode".

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-21
Reviewed by Timothy Hatcher.

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):

3:13 PM Changeset in webkit [151860] by Lucas Forschler
  • 2 edits in tags/Safari-537.46.4/Source/WebKit

Merged r151847. <rdar://problem/14231905>

3:07 PM Changeset in webkit [151859] by Lucas Forschler
  • 8 edits in tags/Safari-537.46.4/Source

Merged r151787. <rdar://problem/14219184>

2:55 PM Changeset in webkit [151858] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

GraphicsContext3DNEON.h cannot be found on Windows and does not need to be found.
​https://bugs.webkit.org/show_bug.cgi?id=117894

Reviewed by Brent Fulgham.

  • platform/graphics/GraphicsContext3D.cpp:

Added #if HAVE(ARM_NEON_INTRINSICS) around #include "GraphicsContext3DNEON.h"

2:33 PM Changeset in webkit [151857] by Lucas Forschler
  • 1 copy in tags/Safari-537.46.4

New Tag.

2:27 PM Changeset in webkit [151856] by fpizlo@apple.com
  • 15 edits
    1 add in branches/dfgFourthTier/Source

fourthTier: Merge r146932 and 146933 so that we can profile from DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=117891

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Merging the JSC part of these changes required creating a fresh VM to JSONify
the profiler database, because that's the only truly safe way to do it. This
is because we don't really know when the profiler would be asked to dump JSON,
and we might be in the middle of VM shutdown. That's a bug in the ToT version
of this, but we didn't catch it because we didn't have enough assertions to
that effect.

  • jsc.cpp:

(jscmain):

  • profiler/ProfilerDatabase.cpp:

(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::toJSON):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::performAtExitSave):
(JSC::Profiler::Database::removeFirstAtExitDatabase):
(JSC::Profiler::Database::atExitCallback):

  • profiler/ProfilerDatabase.h:

(Database):
(JSC::Profiler::Database::databaseID):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::createContextGroup):
(JSC::VM::create):
(JSC::VM::createLeaked):
(JSC::VM::sharedInstance):

  • runtime/VM.h:

(VM):

Source/WTF:

Reviewed by Mark Hahnenberg.

The WTF part of this change is a straight-up merge with nothing interesting.

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::dumpProfile):

  • wtf/ProcessID.h: Added.

(WTF):
(WTF::getCurrentProcessID):

  • wtf/text/StringImpl.cpp:

(WTF::StringStats::printStats):

2:04 PM Changeset in webkit [151855] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Ignoring padding-right of inline elements in containers with undefined width
​https://bugs.webkit.org/show_bug.cgi?id=76451

Reviewed by David Hyatt.

Source/WebCore:

Collapsed trailing space on a normal wrap line should not cause a line-break
if it is the difference between fitting on the line and breaking. Likewise, on a line that
has a mix of auto-wrap and no-wrap inlines we don't want a trailing space at the end of a no-wrap inline
to be the difference between that no-wrap inline fitting or breaking the line. This latter
scenario is covered already by inline-whitespace-wrapping-8.html.

Test: fast/text/whitespace/inline-whitespace-wrapping-9.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/whitespace/inline-whitespace-wrapping-9-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-9.html: Added.
1:57 PM Changeset in webkit [151854] by achristensen@apple.com
  • 8 edits in trunk/Source/WebCore

Added WebGL source files to Windows build and made Windows build successfully with them.
​https://bugs.webkit.org/show_bug.cgi?id=117853

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
  • WebCore.vcxproj/WebCorePreBuild.cmd: Copy ANGLE headers and glext.h before building WebCore (which now uses them).
  • platform/graphics/ANGLEWebKitBridge.h: Look in newly copied directory for ShaderLang.h.
  • platform/graphics/OpenGLShims.h: Include GL/glext.h.
  • platform/graphics/gpu/LoopBlinnShader.cpp:

(WebCore::LoopBlinnShader::use): Fixed parameter ordering in call to uniformMatrix4fv.

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createOffScreenSurface): Added notImplemented for non-EGL builds for now.

1:37 PM Changeset in webkit [151853] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

Update platform text track menu
​https://bugs.webkit.org/show_bug.cgi?id=117884

Reviewed by Jer Noble.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSelectedTextTrack):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::platformTextTrack):

  • platform/graphics/PlatformTextTrack.h:

(WebCore::PlatformTextTrack::create):
(WebCore::PlatformTextTrack::uniqueId):
(WebCore::PlatformTextTrack::captionMenuOffItem):
(WebCore::PlatformTextTrack::captionMenuAutomaticItem):
(WebCore::PlatformTextTrack::PlatformTextTrack):

1:21 PM Changeset in webkit [151852] by commit-queue@webkit.org
  • 5 edits in trunk

AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
​https://bugs.webkit.org/show_bug.cgi?id=117883

Patch by James Craig <​james@cookiecrook.com> on 2013-06-21
Reviewed by Chris Fleizach.

Some of the media controls were returning the wrong role. Updated existing test coverage.

Source/WebCore:

  • accessibility/AccessibilityMediaControls.h:

(WebCore::AccessibilityMediaTimeDisplay::roleValue):

LayoutTests:

  • accessibility/media-element.html:
  • platform/mac/accessibility/media-element-expected.txt:
12:59 PM Changeset in webkit [151851] by achristensen@apple.com
  • 1 edit
    2 adds in trunk/Source/WebCore

Added glext.h from ​http://www.opengl.org/registry/oldspecs/glext.h for Windows
This file does not meet WebKit style guidelines.
Part of ​https://bugs.webkit.org/show_bug.cgi?id=117853

Reviewed by Brent Fulgham.

  • platform/graphics/win/GL: Added.
  • platform/graphics/win/GL/glext.h: Added.
12:53 PM WebKitGTK/2.0.x edited by zandobersek@gmail.com
Add three more merge proposals for the 2.0.4 release. (diff)
12:46 PM Changeset in webkit [151850] by Lucas Forschler
  • 5 edits in tags/Safari-537.46.3/Source

Versioning.

12:38 PM Changeset in webkit [151849] by Lucas Forschler
  • 1 copy in tags/Safari-537.46.3

New Tag.

12:25 PM Changeset in webkit [151848] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier

Merge trunk r146548.

Source/JavaScriptCore:

2013-03-21 Filip Pizlo <​fpizlo@apple.com>


JSC profiler should have an at-a-glance report of the success of DFG optimization
​https://bugs.webkit.org/show_bug.cgi?id=112988


Reviewed by Geoffrey Garen.


  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleCall): (JSC::DFG::ByteCodeParser::handleGetById): (JSC::DFG::ByteCodeParser::parseBlock):
  • profiler/ProfilerCompilation.cpp: (JSC::Profiler::Compilation::Compilation): (JSC::Profiler::Compilation::toJS):
  • profiler/ProfilerCompilation.h: (JSC::Profiler::Compilation::noticeInlinedGetById): (JSC::Profiler::Compilation::noticeInlinedPutById): (JSC::Profiler::Compilation::noticeInlinedCall): (Compilation):
  • runtime/CommonIdentifiers.h:

Tools:

2013-03-21 Filip Pizlo <​fpizlo@apple.com>


JSC profiler should have an at-a-glance report of the success of DFG optimization
​https://bugs.webkit.org/show_bug.cgi?id=112988


Reviewed by Geoffrey Garen.


  • Scripts/display-profiler-output:
11:47 AM Changeset in webkit [151847] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed. Fix a missing parenthesis in include directory path.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:
11:16 AM Changeset in webkit [151846] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Stop removing and re-adding breakpoints from the backend on reload.

On reload the sourceCode for breakpoints are nulled out, which fires DisplayLocationDidChange.
Then the sourceCode is reassociated, firing DisplayLocationDidChange again. In these cases we
don't need to update the backend, since nothing really changed.

​https://bugs.webkit.org/show_bug.cgi?id=117877

Reviewed by Joseph Pecoraro.

  • UserInterface/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype._breakpointDisplayLocationDidChange): Return early when
_ignoreBreakpointDisplayLocationDidChangeEvent is true.
(WebInspector.DebuggerManager.prototype.reset): Set _ignoreBreakpointDisplayLocationDidChangeEvent.
(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode): Ditto.

11:08 AM Changeset in webkit [151845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix TextTrackCue::cueIndex() to handle the null case of TextTrack::cues(() properly
​https://bugs.webkit.org/show_bug.cgi?id=117815
<rdar://problem/14211041>

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-06-21
Reviewed by Ryosuke Niwa.

This patch adds assert statements to try to catch when
track()->cues() returns a null pointer.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::cueIndex):

10:52 AM Changeset in webkit [151844] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[iOS] Hang drawing captions after pressing the home button while playing a video
​https://bugs.webkit.org/show_bug.cgi?id=117882

Reviewed by Eric Carlson.

Instead of rendering in a callback on the main thread, pre-render the captions and pass to the main
thread as a CGImage. As such, rename paintTextTrackRepresentation() to createTextTrackRepresentationImage().

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage): Renamed from

paintTextTrackRepresentation. Now returns an Image object.

  • html/shadow/MediaControlElements.h:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/TextTrackRepresentation.h:
10:42 AM Changeset in webkit [151843] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[CSS Regions] Move overset compute code from flow thread to named flow thread
​https://bugs.webkit.org/show_bug.cgi?id=117835

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-21
Reviewed by Andreas Kling.

Moved computeOversetStateForRegions() and overset() methods from RenderFlowThread to RenderNamedFlowThread.
Added ASSERTS in RenderRegion::regionOversetState and RenderRegion::setRegionOversetState to ensure
the region was created from an element.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):

  • rendering/RenderNamedFlowThread.h:

(WebCore::RenderNamedFlowThread::overset):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):

9:48 AM Changeset in webkit [151842] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r151838.
​http://trac.webkit.org/changeset/151838
​https://bugs.webkit.org/show_bug.cgi?id=117880

Breaks MediaPlayerPrivateQt on Mac (Requested by carewolf on
#webkit).

  • html/HTMLMediaElement.h:
9:35 AM Changeset in webkit [151841] by Brent Fulgham
  • 6 edits
    3 adds in trunk

Source/WebCore: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs
​https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

accessibility/aria-tab-role-on-buttons.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canSetSelectedAttribute): Indicate that certain accessibility
types (such as Tabs) can be selected.

  • accessibility/AccessibilityNodeObject.h: Signature for canSelectAttribute override.

Source/WebKit/win: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
​https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

  • AccessibleBase.cpp:

(MSAARole): Don't expose TabRole as a radio button to satisfy buggy screen readers.

LayoutTests: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
​https://bugs.webkit.org/show_bug.cgi?id=117837

Reviewed by Chris Fleizach.

  • accessibility/aria-tab-role-on-buttons.html: Added.
  • accessibility/aria-tab-role-on-buttons-expected.txt: Added.
  • platform/win/aria-tab-role-on-buttons-expected.txt: Added.
9:12 AM Changeset in webkit [151840] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

Remove unused GesturePinch events
​https://bugs.webkit.org/show_bug.cgi?id=117875

Reviewed by Andreas Kling.

The gesturePinch events have not been used for some time, even Chromium
had stop using them before moving out of webkit.

  • dom/GestureEvent.cpp:

(WebCore::GestureEvent::create):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/PlatformEvent.h:
9:03 AM Changeset in webkit [151839] by commit-queue@webkit.org
  • 13 edits
    3 moves
    1 add
    1 delete in trunk

Improve the reattaching process while applying the :hover style
​https://bugs.webkit.org/show_bug.cgi?id=117590

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-21
Reviewed by Andreas Kling.

Source/WebCore:

Changes made:

  • context is properly propagated to the element's children and to Shadow DOM elements.
  • context is properly set on the lazyReattach method.
  • another hit-testing is triggered when needed.
  • when a hovered element is detached, it's ancestors are also removed from the hovered state.

Tests: fast/css/hover-display-block-inline.html

fast/css/hover-display-block-none.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::attach):
(WebCore::ContainerNode::detach):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::attachChildren):
(WebCore::ContainerNode::detachChildrenIfNeeded):
(WebCore::ContainerNode::detachChildren):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::updateHoverActiveState):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::detach):

  • dom/ElementShadow.h:
  • dom/Node.h:

(WebCore::Node::lazyReattach):

LayoutTests:

Moved hover-display-block-inline.html and hover-display-block-none.html from fast/regions to fast/css.
Updated hover-display-block-none.html and hover-single-flow-into-other.html to ensure the outcome won't be affected by the machine's speed.
Updated input-file-re-render.html to stop it from failing on windows and linux machines (a more detailed description can be found inside the test itself).

  • fast/css/hover-display-block-inline-expected.txt: Renamed from LayoutTests/fast/regions/hover-display-block-inline-expected.txt.
  • fast/css/hover-display-block-inline.html: Renamed from LayoutTests/fast/regions/hover-display-block-inline.html.
  • fast/css/hover-display-block-none-expected.txt: Renamed from LayoutTests/fast/regions/hover-display-block-none-expected.txt.
  • fast/css/hover-display-block-none.html: Added.
  • fast/css/hover-update-expected.txt:
  • fast/css/hover-update.html:
  • fast/forms/file/input-file-re-render.html:
  • fast/regions/hover-display-block-none.html: Removed.
  • fast/regions/hover-single-flow-into-other.html:
9:01 AM Changeset in webkit [151838] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement should inherit from MediaPlayerClient privately
​https://bugs.webkit.org/show_bug.cgi?id=117874

Reviewed by Andreas Kling.

Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium port.
This can now be fixed to a private inheritance.

  • html/HTMLMediaElement.h:
8:58 AM Changeset in webkit [151837] by allan.jensen@digia.com
  • 1 edit
    2 deletes in trunk/Source/WebCore

Remove Chromium-only TouchDisambiguation
​https://bugs.webkit.org/show_bug.cgi?id=117873

Reviewed by Andreas Kling.

  • page/TouchDisambiguation.cpp: Removed.
  • page/TouchDisambiguation.h: Removed.
8:45 AM Changeset in webkit [151836] by commit-queue@webkit.org
  • 7 edits in trunk

Rollout r150602: Restoring text-overflow vs. floating rendering behaviour.
​https://bugs.webkit.org/show_bug.cgi?id=117871

Unreviewed. Rolling out r150602.
Undesirable rendering behaviour.

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-21

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

  • fast/css/text-overflow-ellipsis-behind-floats-expected.html:
  • fast/css/text-overflow-ellipsis-behind-floats.html:
  • fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html:
  • fast/css/text-overflow-ellipsis-full-truncate-rtl.html:
7:31 AM Changeset in webkit [151835] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Integrate new regionOversetChange event into inspector
​https://bugs.webkit.org/show_bug.cgi?id=117833

Source/WebCore:

Added the new regionOversetChange event to the WebInspector.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-21
Reviewed by Joseph Pecoraro.

Tests: inspector/styles/protocol-css-regions-commands.html:

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):
(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didChangeRegionOverset):
(WebCore::InspectorCSSAgent::regionOversetChanged):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didChangeRegionOversetImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didChangeRegionOverset):

  • inspector/front-end/CSSNamedFlowCollectionsView.js:

(WebInspector.CSSNamedFlowCollectionsView.prototype._regionOversetChanged):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype._regionOversetChanged):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.CSSDispatcher.prototype.regionOversetChanged):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):

LayoutTests:

Tests for the new regionOversetChange event.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-21
Reviewed by Joseph Pecoraro.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
6:59 AM Changeset in webkit [151834] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] NetworkStateNotifierEfl: Use closeWithRetry instead of looping for EINTR on close
​https://bugs.webkit.org/show_bug.cgi?id=117872

Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Christophe Dumez.

closeWithRetry works around the Linux behavior of closing the file descriptor
unconditionally even if the close() call is interrupted.

No new tests, no behavior change.

  • platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::~NetworkStateNotifier): Use closeWithRetry instead of
looping for EINTR on close.

4:41 AM Changeset in webkit [151833] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Do not try to load videos in unit tests
​https://bugs.webkit.org/show_bug.cgi?id=117866

Reviewed by Philippe Normand.

It makes the tests slower, and generates and error because we use
a fake src.

  • UIProcess/API/gtk/tests/TestContextMenu.cpp:

(testContextMenuDefaultMenu): Use preload='none' in video tag.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget): Ditto.

3:34 AM Changeset in webkit [151832] by Christophe Dumez
  • 33 edits in trunk

REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
​https://bugs.webkit.org/show_bug.cgi?id=117825

Reviewed by Kentaro Hara.

Source/WebCore:

Partially revert r150663 so that we use Settings to enable WebAudio instead of
RuntimeEnabledFeatures.

Introduce a new [EnabledBySetting] IDL extended attribute which behaves similarly to
the existing [EnabledAtRuntime] but relies on Settings instead of RuntimeEnabledFeatures
to determine if the feature should be enabled. Make use of this new IDL attribute for
webkitAudioContext interface.

No new tests, no behavior change.

  • Modules/webaudio/AudioContext.idl:
  • WebCore.exp.in:
  • WebCore.order:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttribute):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj TestSubObjEnabledBySetting]):
(-[DOMTestObj setTestSubObjEnabledBySetting:]):

  • bindings/scripts/test/TestObj.idl:
  • page/Settings.in:

Source/WebKit/efl:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setWebAudioEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Source/WebKit/win:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::overridePreference):

3:33 AM Changeset in webkit [151831] by commit-queue@webkit.org
  • 6 edits
    4 moves in trunk

[ATK] Added support for aria-required attribute.
​https://bugs.webkit.org/show_bug.cgi?id=117730

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-06-21
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/aria-required.html

accessibility/html5-required-attribute.html

The aria-required attribute is used to indicate that user input is required on an
element before a form can be submitted.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

Tools:

Added support for testing aria-required attribute.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isRequired):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isRequired):

LayoutTests:

Moving specific platform accessibility tests.

  • accessibility/aria-required-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-required-expected.txt.
  • accessibility/aria-required.html: Renamed from LayoutTests/platform/mac/accessibility/aria-required.html.
  • accessibility/html5-required-attribute-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html5-required-attribute-expected.txt.
  • accessibility/html5-required-attribute.html: Renamed from LayoutTests/platform/mac/accessibility/html5-required-attribute.html.
2:36 AM Changeset in webkit [151830] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

IndieUI: Add basic IndieUI infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=117367

Unreviewed. Update Lion expected results.

  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
1:55 AM Changeset in webkit [151829] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

IndieUI: Add basic IndieUI infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=117367

Unreviewed. Revert erroneous file that was included accidentally.

  • accessibility/AccessibilityNodeObject.h:
1:52 AM Changeset in webkit [151828] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL]: Invalidate the ProcessLauncher when the process is terminated before it has finished launching
​https://bugs.webkit.org/show_bug.cgi?id=117865

Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Christophe Dumez.

Original patch from Carlos Garcia Campos for the Gtk port.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::terminateProcess): If process is still
launching, just invalidate the launcher. Reset the process
identifier after killing the process.

1:51 AM Changeset in webkit [151827] by Chris Fleizach
  • 25 edits
    2 copies
    9 adds in trunk

IndieUI: Add basic IndieUI infrastructure
​https://bugs.webkit.org/show_bug.cgi?id=117367

Reviewed by Ryosuke Niwa.

Source/WebCore:

IndieUI is a new W3C spec that aims to abstract the connection between input and action, so that
a user (possibly using assistive technologies like a screen reader) does not need a specific kind
of device (like a mouse) to interact with an object.
​http://www.w3.org/WAI/IndieUI/

This initial patch adds in the basic support for UIRequestEvent and the uiactions attribute.
It modifies the config files to enable and build this feature.

Tests: indieui/create-uirequestevent.html

indieui/uiactions.html

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • Modules/indieui: Added.
  • Modules/indieui/UIRequestEvent.cpp: Added.

(WebCore::UIRequestEventInit::UIRequestEventInit):
(WebCore::UIRequestEvent::create):
(WebCore::UIRequestEvent::UIRequestEvent):
(WebCore::UIRequestEvent::~UIRequestEvent):
(WebCore::UIRequestEvent::interfaceName):
(WebCore::UIRequestEventDispatchMediator::UIRequestEventDispatchMediator):
(WebCore::UIRequestEventDispatchMediator::event):
(WebCore::UIRequestEventDispatchMediator::dispatchEvent):

  • Modules/indieui/UIRequestEvent.h: Added.

(WebCore::UIRequestEvent::receiver):
(WebCore::UIRequestEventDispatchMediator::create):

  • Modules/indieui/UIRequestEvent.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.h:
  • dom/Element.cpp:

(WebCore::Element::setUIActions):
(WebCore::Element::UIActions):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp:

(WebCore::EventInit::EventInit):

  • dom/Event.h:
  • dom/EventNames.in:
  • dom/Node.cpp:

(WebCore::Node::dispatchUIRequestEvent):

  • dom/Node.h:
  • dom/UIEvent.cpp:

(WebCore::UIEventInit::UIEventInit):

  • dom/UIEvent.h:
  • html/HTMLAttributeNames.in:

LayoutTests:

  • fast/js/dom-static-property-for-in-iteration-expected.txt:
  • fast/js/global-constructors-attributes-expected.txt:
  • indieui: Added.
  • indieui/create-uirequestevent-expected.txt: Added.
  • indieui/create-uirequestevent.html: Added.
  • indieui/uiactions-expected.txt: Added.
  • indieui/uiactions.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
  • platform/win/TestExpectations:
  • platform/win/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
1:07 AM Changeset in webkit [151826] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Migrate WebKitWebResource to GTask
​https://bugs.webkit.org/show_bug.cgi?id=117152

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebResource.cpp:

(resourceDataCallback):
(webkit_web_resource_get_data):
(webkit_web_resource_get_data_finish):

12:08 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com
Add two proposed patches for 2.0.4. (diff)

Jun 20, 2013:

11:02 PM Changeset in webkit [151825] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source

[WK2] Looping for EINTR on close() is incorrect for Linux, at least
​https://bugs.webkit.org/show_bug.cgi?id=117266

Patch by Sergio Correia <Sergio Correia> on 2013-06-20
Reviewed by Darin Adler.

Source/WebKit2:

Call closeWithRetry() to work around a difference in how the retry needs to
be done on Linux.

  • Platform/CoreIPC/unix/AttachmentUnix.cpp:

(CoreIPC::Attachment::dispose):

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate):

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::createWebProcessConnection):

  • SharedWorkerProcess/SharedWorkerProcess.cpp:

(WebKit::SharedWorkerProcess::createWebProcessConnection):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): All these places had
close-followed-by-EINTR-handling replaced with the new closeWithRetry()
function added in this commit.

Source/WTF:

Added file UniStdExtras with a closeWithRetry() function that works around
the EINTR behavior on Linux during a close() call: it closes the descriptor
unconditionally even when the call is interrupted.

  • wtf/UniStdExtras.h: Added.

(WTF::closeWithRetry): Wrapper around POSIX close() that handles EINTR
correctly.

9:21 PM Changeset in webkit [151824] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure should have a dump()
​https://bugs.webkit.org/show_bug.cgi?id=117859

Reviewed by Geoffrey Garen.

This is pretty cool. Anywhere we previously printed Structure pointers in dumps,
we now print a bunch of other info as well. For example, for an object literal
like "{f:42, g:64, h:24}", when we print the structure we'll now get:

0x107a0af80:[Object, {f:0, g:1, h:2}, NonArray, Proto:0x107a8fff0]


This also changes a bunch of places to use the dump method.

  • bytecode/StructureSet.h:

(JSC::StructureSet::dump):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::dump):

  • runtime/Structure.cpp:

(JSC::Structure::dump):
(JSC):

  • runtime/Structure.h:

(Structure):

9:00 PM Changeset in webkit [151823] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r151808): fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html fails
​https://bugs.webkit.org/show_bug.cgi?id=117862

Add a failing test expectation.

  • platform/mac/TestExpectations:
8:52 PM Changeset in webkit [151822] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION(r145788): mouse drag on canvas shouldn't start selection
​https://bugs.webkit.org/show_bug.cgi?id=117860

Reviewed by Benjamin Poulain.

Source/WebCore:

Like HTMLImageElement, HTMLCanvasElement shouldn't start selection.

Also uninline some virtual function overrides.

Test: fast/events/mosuedrag-on-canvas-should-not-start-selection.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::areAuthorShadowsAllowed):
(WebCore::HTMLCanvasElement::canContainRangeEndPoint):
(WebCore::HTMLCanvasElement::canStartSelection):

  • html/HTMLCanvasElement.h:

LayoutTests:

Add a regression test for dragging mouse inside a canvas.
The canvas should not be selected and mouseup event should fire.

  • fast/events/mosuedrag-on-canvas-should-not-start-selection-expected.txt: Added.
  • fast/events/mosuedrag-on-canvas-should-not-start-selection.html: Added.
8:50 PM Changeset in webkit [151821] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r149652): accessing items in .children via id doesn't work when element is not rooted in DOM tree
​https://bugs.webkit.org/show_bug.cgi?id=117836

Reviewed by Benjamin Poulain.

Source/WebCore:

When the root node of a HTML collection is not in the document or in a shadow tree,
we shouldn't use its tree scope's id and name maps to find name getters.

Always use the slow path in such cases.

Test: fast/dom/htmlallcollection-detached-node-children.html

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::namedItem):

LayoutTests:

Add a regression test for named getter for a detached element.

  • fast/dom/htmlallcollection-detached-node-children-expected.txt: Added.
  • fast/dom/htmlallcollection-detached-node-children.html: Added.
7:57 PM Changeset in webkit [151820] by fpizlo@apple.com
  • 19 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: There should only be one table of SimpleJumpTables
​https://bugs.webkit.org/show_bug.cgi?id=117856

Reviewed by Geoffrey Garen.

Having multiple tables of SimpleJumpTables just means we have to duplicate a
ton of code. This patch deduplicates all of it.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfSwitchJumpTables):
(JSC::CodeBlock::addSwitchJumpTable):
(JSC::CodeBlock::switchJumpTable):
(JSC::CodeBlock::clearSwitchJumpTables):
(RareData):

  • bytecode/PreciseJumpTargets.cpp:

(JSC):
(JSC::computePreciseJumpTargets):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::shrinkToFit):
(JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables):
(JSC::UnlinkedCodeBlock::addSwitchJumpTable):
(JSC::UnlinkedCodeBlock::switchJumpTable):
(RareData):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC):
(JSC::prepareJumpTableForSwitch):
(JSC::BytecodeGenerator::endSwitch):

  • dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
7:52 PM Changeset in webkit [151819] by Lucas Forschler
  • 5 edits in tags/Safari-537.46.2/Source

Versioning.

7:50 PM Changeset in webkit [151818] by Lucas Forschler
  • 1 copy in tags/Safari-537.46.2

New Tag.

7:49 PM Changeset in webkit [151817] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

Refine the StackBounds computation for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=117854.

Reviewed by Brent Fulgham.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

7:29 PM Changeset in webkit [151816] by Lucas Forschler
  • 1 delete in branches/safari-537-branch/LayoutTests/fast/replaced/width-and-height-of-positioned-replaced-elements.html

correct mismerge from 151799. <rdar://problem/14159682>

7:26 PM Changeset in webkit [151815] by ryuan.choi@samsung.com
  • 8 edits in trunk

[CMAKE][EFL] Enable DOM4 Events Constructor
​https://bugs.webkit.org/show_bug.cgi?id=117858

Reviewed by Laszlo Gombos.

.:

  • Source/cmake/OptionsEfl.cmake: Enabled ENABLE_DOM4_EVENTS_CONSTRUCTOR.
  • Source/cmake/WebKitFeatures.cmake: Added ENABLE_DOM4_EVENTS_CONSTRUCTOR.
  • Source/cmakeconfig.h.cmake: Ditto.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.

LayoutTests:

  • platform/efl/TestExpectations: Unskip the related tests.
7:24 PM Changeset in webkit [151814] by Lucas Forschler
  • 16 edits
    4 deletes in branches/safari-537-branch

Merged r151799. <rdar://problem/14159682>

7:17 PM Changeset in webkit [151813] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151762. <rdar://problem/13837412>

5:44 PM Changeset in webkit [151812] by ap@apple.com
  • 3 edits
    2 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=116495
Fix null-pointer deref in DocumentLoader::responseReceived()

Patch by Nate Chapin, reviewed by Mike West and myself.

Test: http/tests/security/XFrameOptions/x-frame-options-deny-delete-frame-in-load-event.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::responseReceived): Added a null check.
4:43 PM Changeset in webkit [151811] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Roll out part of r150618.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
4:36 PM Changeset in webkit [151810] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

[Windows] Undoing r150621 to roll r150600 back in as the jsc test
failures have been fixed in r151808.
​https://bugs.webkit.org/show_bug.cgi?id=116661.

Reviewed by Brent Fulgham.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

3:52 PM Changeset in webkit [151809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Send the correct offsets for misspelled words.
​https://bugs.webkit.org/show_bug.cgi?id=117846

JIRA116916.
When the caret is placed after a word, the offsets were calculated around
the proceeding space. As such, words that end a sentence worked correctly, but
midsentence words did not. The 'startOfWord' was calculated for the space ahead
and not for the word before it. Now finding the start of the word correctly and
calculating the end from there.

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-06-20
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

3:17 PM Changeset in webkit [151808] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Change stack capacity requirement to be more reasonable.
​https://bugs.webkit.org/show_bug.cgi?id=117801.

Reviewed by Geoffrey Garen.

Previously, the requiredStack in StackPolicy::StackPolicy() was set to
to a high value like 256K to reduce the chances of encountering an
undetected stack overflow in a scenario where we have a combination of
deeply nested divs and a large amount recursive re-entries into the VM.

However, this high value of requiredStack still does not completely
ensure that we will never encounter an undetected stack overflow. It
only lessens the probability of encountering it.

Secondly, on some platforms, the total stack size can be less than 256K
to start with. Hence, this high value requiredStack renders the VM
unuseable on those platforms.

This patch will fix the requiredStack to be more reasonable based on
real world stack usage by the VM. We won't (and cannot) try to prevent
undetected stack overflows outside of JSC as well. External code that
do deep recursion (e.g. Documnet::updateLayout()) should do their own
stack checks.

From a previous experiment, we measured the following:

On a debug build on OSX:

  1. Stack usage different between recursive calls to interpreter entry: 7744 bytes

On a release build on OSX:

  1. Stack usage difference between recursive calls to interpreter entry: 6352 bytes

Using these as a guide, we'll pick the following values for the
StackPolicy:

requiredStack: 32K
errorModeRequiredStack: 16K

The requiredStack is chosen to be 4x the measured usage above. The
additional 3x is a conservative estimate to account for stack space
that may be needed by other native functions called while in the
interpreter.

The errorModeRequiredStack has to be less than the requiredStack or we
won't be able to reenter the interpreter to do error handling work when
an imminent stack overflow is detected. It is assumed that the error
handling code will only do minimal work to allocate an exception and its
stack trace, and not run any arbitrary JS code. As such, it is safe to
allow re-entry into the interpreter with only 2x the measured usage in
this case.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::StackPolicy::StackPolicy):

3:15 PM Changeset in webkit [151807] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Initial advance on the first glyph of the run is not correctly set for rtl text.
​https://bugs.webkit.org/show_bug.cgi?id=117839
<rdar://problem/13860717>

Reviewed by Sam Weinig.

Source/WebCore:

We need to set the initial advance to the glyphBuffer, using the
initial advance of the complex run that will be drawn first.
In order to choose the run correctly we must consider the text direction.

Test: fast/text/complex-first-glyph-with-initial-advance.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):

LayoutTests:

  • fast/text/complex-first-glyph-with-initial-advance-expected.html: Added.
  • fast/text/complex-first-glyph-with-initial-advance.html: Added.
2:42 PM Changeset in webkit [151806] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should clear character switch jump tables
​https://bugs.webkit.org/show_bug.cgi?id=117852

Reviewed by Sam Weinig.

The FTL just uses LLVM's switch, which results in LLVM allocating its own switch
jump tables as needed.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::clearCharacterSwitchJumpTables):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

2:37 PM Changeset in webkit [151805] by achristensen@apple.com
  • 5 edits in trunk/Source/WebCore

Fixed WebGL compile errors on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=117805

Reviewed by Brent Fulgham.

  • html/canvas/WebGLRenderingContext.cpp: Included CString.h.

Added PLATFORM(WIN) to existing lists of platform macros.

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):

  • platform/graphics/OpenGLESShims.h:
2:28 PM Changeset in webkit [151804] by Simon Fraser
  • 6 edits in trunk/Source

FrameView needs to initialize paintsEntireContents on creation
​https://bugs.webkit.org/show_bug.cgi?id=117844

Source/WebCore:

Reviewed by Anders Carlsson.

In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.

  • page/ChromeClient.h:

(WebCore::ChromeClient::shouldPaintEntireContents):

  • page/FrameView.cpp:

(WebCore::FrameView::init):

Source/WebKit/mac:

Reviewed by Anders Carlsson.

In WebKit1, if the WebView is layer-backed, WebHTMLView gets a layer.
In this mode, FrameView::paintsEntireContents() is true. However,
we would only call setPaintsEntireContents(true) on the FrameView
when the view's layer-backed status changes. FrameView also needs
to fetch this state when it is initialized, because we may be creating
a new FrameView for an already layer-backed WebHTMLView.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldPaintEntireContents):

2:28 PM Changeset in webkit [151803] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Sticky elements are missing or misplaced sometimes when reloading a page that scrolls to a named anchor
​https://bugs.webkit.org/show_bug.cgi?id=117819

Reviewed by Anders Carlsson.

At the end of FrameView::performPostLayoutTasks() we call scrollToAnchor() which attempts
to restore the scroll position to a named anchor, even when the document has been
changed by layout. This ends up in a call to ScrollView::scrollTo(), which in turn
calls repaintFixedElementsAfterScrolling(). However, repaintFixedElementsAfterScrolling()
would bail if m_nestedLayoutCount != 0, so we never updated layer positions which
depend on scroll position (but which would not be updated by layout, since their
renderers are not marked for layout when scrolling happens).

We've solved this problem once before in updateFixedElementsAfterScrolling() which
checks for m_nestedLayoutCount <= 1, so that we do work on the outermost nested layout.
Apply that same fix to repaintFixedElementsAfterScrolling().

Very timing-dependent, so hard to make a test.

  • page/FrameView.cpp:

(WebCore::FrameView::repaintFixedElementsAfterScrolling):

2:18 PM Changeset in webkit [151802] by fpizlo@apple.com
  • 17 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support SwitchChar
​https://bugs.webkit.org/show_bug.cgi?id=117849

Reviewed by Geoffrey Garen.

This adds Switch(SwitchChar) to the FTL and also implicitly does some other things.
SwitchChar requires calling a slow path to resolve ropes. Previously the FTL had no
support for calling slow paths, and we avoided adding coverage that would require
that. Well, this patch adds the ability to call slow paths and just uses that for
resolving ropes for SwitchChar. Also SwitchChar required adding awareness of strings,
so I did that, too.

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::addCodeOrigin):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNode.cpp:

(WTF):
(WTF::printInternal):

  • dfg/DFGNode.h:

(WTF):

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::int16Type):
(JSC::FTL::constInt):

  • ftl/FTLAbstractHeapRepository.h:

(FTL):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCommonValues.cpp:

(JSC::FTL::CommonValues::CommonValues):

  • ftl/FTLCommonValues.h:

(CommonValues):

  • ftl/FTLIntrinsicRepository.cpp:

(JSC::FTL::IntrinsicRepository::IntrinsicRepository):
(FTL):

  • ftl/FTLIntrinsicRepository.h:

(FTL):
(IntrinsicRepository):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::buildSwitch):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowString):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isObject):
(JSC::FTL::LowerDFGToLLVM::isNotString):
(JSC::FTL::LowerDFGToLLVM::isString):
(JSC::FTL::LowerDFGToLLVM::isNotObject):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::speculateString):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::LowerDFGToLLVM::vmCall):
(JSC::FTL::LowerDFGToLLVM::callPreflight):
(JSC::FTL::LowerDFGToLLVM::callCheck):
(JSC::FTL::LowerDFGToLLVM::lowBlock):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt8):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::load16):
(JSC::FTL::Output::isNull):
(JSC::FTL::Output::notNull):
(JSC::FTL::Output::testIsZero32):
(JSC::FTL::Output::testNonZero32):
(Output):
(JSC::FTL::Output::operation):
(JSC::FTL::Output::crash):

2:10 PM Changeset in webkit [151801] by commit-queue@webkit.org
  • 6 edits
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r151463.
​http://trac.webkit.org/changeset/151463
​https://bugs.webkit.org/show_bug.cgi?id=117850

"r151451 was rolled out" (Requested by rhogan on #webkit).

  • platform/efl/fast/forms/button-positioned-expected.txt:
  • platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • platform/gtk/fast/forms/button-positioned-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • platform/win/fast/forms/onselect-textfield-expected.txt: Removed.
2:09 PM Changeset in webkit [151800] by mikhail.pozdnyakov@intel.com
  • 63 edits in trunk/Source

HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
​https://bugs.webkit.org/show_bug.cgi?id=117830

Reviewed by Anders Carlsson.

The order of the template arguments at HashSet alternate 'find', 'contains' and
'add' methods is reversed so that callers can just pass the translator
and let the compiler deduce input argument type.

Source/JavaScriptCore:

  • runtime/Identifier.h:

(JSC::IdentifierTable::add):

Source/WebCore:

No new tests. No new functionality.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::QualifiedName):

  • platform/graphics/cg/SubimageCacheWithTimer.cpp:

(WebCore::SubimageCacheWithTimer::getSubimage):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::isSupportedAttribute):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::isSupportedAttribute):

  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::isSupportedAttribute):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::isSupportedAttribute):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute):

  • svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::isSupportedAttribute):

  • svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::isSupportedAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::isSupportedAttribute):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::isSupportedAttribute):

  • svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::isSupportedAttribute):

  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::isSupportedAttribute):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::isSupportedAttribute):

  • svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::isSupportedAttribute):

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute):

  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute):

  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::isSupportedAttribute):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::isSupportedAttribute):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::isSupportedAttribute):

  • svg/SVGFEMergeNodeElement.cpp:

(WebCore::SVGFEMergeNodeElement::isSupportedAttribute):

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::isSupportedAttribute):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::isSupportedAttribute):

  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::isSupportedAttribute):

  • svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::isSupportedAttribute):

  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::isSupportedAttribute):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::isSupportedAttribute):
(WebCore::SVGFilterElement::childShouldCreateRenderer):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::isSupportedAttribute):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::isSupportedAttribute):

  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::isSupportedAttribute):

  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::isSupportedAttribute):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isSupportedAttribute):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::isSupportedAttribute):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::isSupportedAttribute):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::isSupportedAttribute):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::isSupportedAttribute):

  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::isSupportedAttribute):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::isSupportedAttribute):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::isSupportedAttribute):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::isSupportedAttribute):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::isSupportedAttribute):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::isSupportedAttribute):

  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::isSupportedAttribute):

  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::isSupportedAttribute):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::isSupportedAttribute):

  • svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::isSupportedAttribute):

  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::isSupportedAttribute):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::isSupportedAttribute):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::isSupportedAttribute):

  • svg/SVGTextElement.cpp:

(WebCore::SVGTextElement::isSupportedAttribute):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::isSupportedAttribute):

  • svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::isSupportedAttribute):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::isDisallowedElement):

  • svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::isSupportedAttribute):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::isSupportedAttribute):

Source/WTF:

  • wtf/HashSet.h:
  • wtf/text/AtomicString.cpp:

(WTF::addToStringTable):
(WTF::findString):

1:46 PM Changeset in webkit [151799] by commit-queue@webkit.org
  • 16 edits
    5 deletes in trunk

Unreviewed, rolling out r151451.
​http://trac.webkit.org/changeset/151451
​https://bugs.webkit.org/show_bug.cgi?id=117848

"Broke quite a lot of sites" (Requested by rhogan on #webkit).

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::intrinsicSize):

  • rendering/RenderButton.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):

  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):

  • rendering/RenderTextControl.h:

LayoutTests:

  • fast/forms/onselect-textfield-expected.txt:
  • fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Removed.
  • fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • fast/replaced/width-and-height-of-positioned-replaced-elements.html: Removed.
  • platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • platform/mac/fast/forms/button-positioned-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
  • platform/qt/fast/forms/button-positioned-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
1:37 PM Changeset in webkit [151798] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r151788.
​http://trac.webkit.org/changeset/151788
​https://bugs.webkit.org/show_bug.cgi?id=117847

"This is the wrong fix" (Requested by rhogan on #webkit).

Source/WebCore:

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

  • fast/forms/onselect-textfield-expected.txt:
  • fast/replaced/height-of-positioned-text-control-expected.html: Removed.
  • fast/replaced/height-of-positioned-text-control.html: Removed.
  • fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
1:19 PM Changeset in webkit [151797] by kbalazs@webkit.org
  • 5 edits in trunk

[Gstreamer] cleanup buffering and state updates
​https://bugs.webkit.org/show_bug.cgi?id=116642

Reviewed by Philippe Normand.

Source/WebCore:

Covered by existing media tests, especially the ones that have been unskipped.

Always do download buffering. It should not differ if preload is "none" because
it's about when to start buffering, not about how. Fix a bunch other subtle issues
to make this change go smoothly with the tests. As a bonus some tests that were
failing so far started to pass.
It is possible to further tweak the buffering in a way that will enable us to support
a different and appropriate behavior for preload="metadata" but it should be managed
a bit differently. I will implement it in a follow-up.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Don't call setDownloadBuffering
yet. Now it also responsible for starting the fill timer and it turned out that
setting the download flag before the pipeline is set to a state has negative
effect on some tests. Most probably GStreamer starts buffering too early if
we set the download flag.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): Call setDownloadBuffering now.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto, plus set m_delayingLoad to false
because otherwise setPreload will wrongly assume that the load has not been committed
yet if prepareToPlay is not called before play.
(WebCore::MediaPlayerPrivateGStreamer::pause): Make sure we don't commit a load here
if it was not committed yet by looking in the pipeline state.
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): No need to observe the
type of buffering.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Introduced m_downloadFinished to update
ready and network states in updateStates based on it. The previously used condition

  • (maxTimeLoaded() == duration()) - was not correct in the case when duration is not known.

(WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): Removed a lie. If the fill timer is not active
it does not necesarily means that download has been finished. This lie was actually ensuring
a lot of tests to pass because it made the condition (maxTimeLoaded() == duration()) true.
Now that state updates has been cleaned up we don't need to lie.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Merge all the parts that takes part in updating
ready and network states. It was untrackable. Unset download buffering for for live streams early so
we don't need to restart them.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer): Removed m_startedBuffering because there is no need for it now.

LayoutTests:

Remove failure expectations from tests that started to pass.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
1:14 PM Changeset in webkit [151796] by eric.carlson@apple.com
  • 5 edits
    2 adds in trunk

ASSERT removing then adding a <track> element
​https://bugs.webkit.org/show_bug.cgi?id=117814

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/add-and-remove-track.html

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedInto): Always call ensureTrack before adding the track

to the parent <video> element.

(WebCore::HTMLTrackElement::ensureTrack): Call m_track->setTrackElement() in case the

parent was cleared after m_track was created.

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::setTrackElement): New, set m_trackElement.

  • html/track/LoadableTextTrack.h:

LayoutTests:

  • media/track/add-and-remove-track-expected.txt: Added.
  • media/track/add-and-remove-track.html: Added.
1:12 PM Changeset in webkit [151795] by beidson@apple.com
  • 6 edits in trunk/Source/WebKit2

WebProcess hangs loading eff.org (Waiting forever on a sync XHR, NetworkProcess unable to service it).
<rdar://problem/14112329> and ​https://bugs.webkit.org/show_bug.cgi?id=117842

Reviewed by Alexey Proskuryakov.

  • NetworkProcess/HostRecord.cpp:

(WebKit::removeLoaderFromQueue): Utility to clear a Loader out of a LoaderQueue.
(WebKit::HostRecord::removeLoader): Use removeLoaderFromQueue, and also try to clear the loader from m_syncLoadersPending.
(WebKit::HostRecord::servePendingRequestsForQueue): Small refactoring/cleanup.
(WebKit::HostRecord::limitsRequests): Change so that if the number of loaders in flight is exactly equal to the limit, then

allow serving a synchronous loader to go exactly one beyond the limit.

  • NetworkProcess/HostRecord.h:

Make the static maxRequestsInFlightPerHost a member of the NetworkResourceLoadScheduler, instead:

  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::NetworkResourceLoadScheduler):
(WebKit::NetworkResourceLoadScheduler::hostForURL):

  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:

(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost): Tell CFNetwork to allow

7 connections per host instead of 6, but tell the scheduler that 6 is still the normal limit.

1:12 PM Changeset in webkit [151794] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Build fix for Apple Windows port.

  • rendering/RenderThemeWin.cpp:

(WebCore::cssValueIdToSysColorIndex):

1:06 PM Changeset in webkit [151793] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Downloaded file name encoding is incorrect when download link opens in a new window
​https://bugs.webkit.org/show_bug.cgi?id=117818
<rdar://problem/14212635>

Reviewed by Brady Eidson.

No tests added. The machinery we have for logging downloaded file name is very
far from being able to work in a secondary window.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Made a targeted fix - don't update encoding fallback array if we already have one, there is no chance for it to be more correct. In this case, it's incorrect because it comes from a new blank window, instead of original referer. We have a lot of code in addExtraFieldsToRequest() to struggle with this, and we have a FIXME to try not calling it from policy delegate.
12:44 PM Changeset in webkit [151792] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

12:32 PM Changeset in webkit [151791] by zandobersek@gmail.com
  • 2 edits in trunk

[GTK] remove bashism from configure
​https://bugs.webkit.org/show_bug.cgi?id=117796

Reviewed by Gustavo Noronha Silva.

  • Source/autotools/FindDependencies.m4: Perform string appending by redeclaring the base string to the value

of the base string followed by the string that's being appended. This replaces the use of the '+=' operator
that works under bash but is not supported by other shells.

12:16 PM Changeset in webkit [151790] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Mark compositing/repaint/positioned-movement.html as flaky on Mountain Lion Debug

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-06-20

  • platform/mac-wk2/TestExpectations:

The test fails regularly in Debug on Mountain Lion.

12:10 PM Changeset in webkit [151789] by robert@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r151737): fast/replaced/width100percent-image.html fails
​https://bugs.webkit.org/show_bug.cgi?id=117824

Unreviewed, rebaselining.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt:
11:58 AM Changeset in webkit [151788] by robert@webkit.org
  • 10 edits
    2 adds in trunk

REGRESSION (r151451): Text not vertically centered correctly on icloud.com
​https://bugs.webkit.org/show_bug.cgi?id=117744

Reviewed by David Hyatt.

Source/WebCore:

The positioned height and width computation adds in the element's border and padding so
don't add it to the intrinsic height and preferred widths of text controls that are
absolutely positioned.

Test: fast/replaced/height-of-positioned-text-control.html

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

  • fast/forms/onselect-textfield-expected.txt:
  • fast/replaced/height-of-positioned-text-control-expected.html: Added.
  • fast/replaced/height-of-positioned-text-control.html: Added.
  • fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
  • platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:
11:55 AM Changeset in webkit [151787] by roger_fong@apple.com
  • 8 edits in trunk/Source

Make Windows makefile copy build output to a different folder.
<rdar://problem/14219184>.

  • WTF.vcxproj/WTF.make:
  • JavaScriptCore.vcxproj/JavaScriptCore.make:
  • WebCore.vcxproj/WebCore.make:
  • WebKit.vcxproj/WebKit.make:
11:36 AM Changeset in webkit [151786] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Improper deallocation of JSManagedValue causes crashes during autorelease pool draining
​https://bugs.webkit.org/show_bug.cgi?id=117840

Reviewed by Geoffrey Garen.

Improperly managing a JSManagedValue can cause a crash when the JSC::Weak inside the
JSManagedValue is destroyed upon deallocation. We would rather have improperly maintained
JSManagedValues cause memory leaks than take down the whole app.

The fix is to use the callback to the JSC::Weak on the destruction of the VM so that we
can safely null it out. This will prevent ~Weak from crashing.

  • API/JSManagedValue.mm:

(-[JSManagedValue JSC::JSC::]):
(JSManagedValueHandleOwner::finalize):

  • API/tests/testapi.mm: Added a test that crashed prior to this fix due to a leaked

managed reference. Also fixed a small style nit I noticed in another test.

11:24 AM Changeset in webkit [151785] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
​https://bugs.webkit.org/show_bug.cgi?id=117811

Reviewed by Eric Carlson.

When comparing Generic cues, we should check that their type is Generic, not WebVTT.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::isOrderedBefore):

11:07 AM Changeset in webkit [151784] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=117711

Patch by Ralph Thomas <​ralpht@gmail.com> on 2013-06-20
Reviewed by Laszlo Gombos.

No new tests, no CMake platforms currently enable this functionality.

  • CMakeLists.txt:
11:04 AM Changeset in webkit [151783] by alexis@webkit.org
  • 44 edits in trunk/Source/WebCore

Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=117829

Reviewed by Andreas Kling.

A lot of call sites were using integers to represent them. While it's
not incorrect per se, it's not ideal for various reason such as type
safety or to remove ambiguity.

This patch eradicate the wrong usage by not letting any integer based
API for getting CSSValueIDs or CSSPropertyIDs from CSSPrimitiveValues.

Instead we use new but typed functions to construct the values as well
as getting them. Two customs and internal types were added to CSSPrimitiveValue
to handle correctly the new APIs.

It's good to note that in order to preserve compatibility on the
CSSPrimitiveValue type whenever CSSPrimitiveValue handles a CSSValueID
or a CSSPropertyID the return type for the public API will be CSS_IDENT
despite it is a separate internal type.

No new tests: refactor, existing tests should cover.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyMatches):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSGradientValue.cpp:

(WebCore::positionFromValue):
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSystemColor):
(WebCore::isFillPositionKeyword):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isBlendMode):
(WebCore::CSSParser::isCompositeOperator):

  • css/CSSParser.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::propertyName):
(WebCore::valueName):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isValueID):
(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createParserOperator):
(WebCore::CSSPrimitiveValue::getPropertyID):
(WebCore::CSSPrimitiveValue::getValueID):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
(WebCore::CSSPrimitiveValue::operator PrintColorAdjust):
(WebCore::CSSPrimitiveValue::operator EBorderStyle):
(WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
(WebCore::CSSPrimitiveValue::operator CompositeOperator):
(WebCore::CSSPrimitiveValue::operator ControlPart):
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
(WebCore::CSSPrimitiveValue::operator EFillAttachment):
(WebCore::CSSPrimitiveValue::operator EFillBox):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
(WebCore::CSSPrimitiveValue::operator EBoxDirection):
(WebCore::CSSPrimitiveValue::operator EBoxLines):
(WebCore::CSSPrimitiveValue::operator EBoxOrient):
(WebCore::CSSPrimitiveValue::operator ECaptionSide):
(WebCore::CSSPrimitiveValue::operator EClear):
(WebCore::CSSPrimitiveValue::operator ECursor):
(WebCore::CSSPrimitiveValue::operator CursorVisibility):
(WebCore::CSSPrimitiveValue::operator EDisplay):
(WebCore::CSSPrimitiveValue::operator EEmptyCell):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EFlexDirection):
(WebCore::CSSPrimitiveValue::operator EAlignContent):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
(WebCore::CSSPrimitiveValue::operator EFloat):
(WebCore::CSSPrimitiveValue::operator LineBreak):
(WebCore::CSSPrimitiveValue::operator EListStylePosition):
(WebCore::CSSPrimitiveValue::operator EListStyleType):
(WebCore::CSSPrimitiveValue::operator EMarginCollapse):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
(WebCore::CSSPrimitiveValue::operator RegionFragment):
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
(WebCore::CSSPrimitiveValue::operator ENBSPMode):
(WebCore::CSSPrimitiveValue::operator EOverflow):
(WebCore::CSSPrimitiveValue::operator EPageBreak):
(WebCore::CSSPrimitiveValue::operator EPosition):
(WebCore::CSSPrimitiveValue::operator EResize):
(WebCore::CSSPrimitiveValue::operator ETableLayout):
(WebCore::CSSPrimitiveValue::operator ETextAlign):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
(WebCore::CSSPrimitiveValue::operator TextJustify):
(WebCore::CSSPrimitiveValue::operator TextDecoration):
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
(WebCore::CSSPrimitiveValue::operator ETextSecurity):
(WebCore::CSSPrimitiveValue::operator ETextTransform):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
(WebCore::CSSPrimitiveValue::operator EUserDrag):
(WebCore::CSSPrimitiveValue::operator EUserModify):
(WebCore::CSSPrimitiveValue::operator EUserSelect):
(WebCore::CSSPrimitiveValue::operator EVerticalAlign):
(WebCore::CSSPrimitiveValue::operator EVisibility):
(WebCore::CSSPrimitiveValue::operator EWhiteSpace):
(WebCore::CSSPrimitiveValue::operator EWordBreak):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
(WebCore::CSSPrimitiveValue::operator TextDirection):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator TextCombine):
(WebCore::CSSPrimitiveValue::operator RubyPosition):
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition):
(WebCore::CSSPrimitiveValue::operator TextOverflow):
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill):
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning):
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode):
(WebCore::CSSPrimitiveValue::operator FontWeight):
(WebCore::CSSPrimitiveValue::operator FontItalic):
(WebCore::CSSPrimitiveValue::operator FontSmallCaps):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator ColorSpace):
(WebCore::CSSPrimitiveValue::operator Hyphens):
(WebCore::CSSPrimitiveValue::operator LineSnap):
(WebCore::CSSPrimitiveValue::operator LineAlign):
(WebCore::CSSPrimitiveValue::operator Order):
(WebCore::CSSPrimitiveValue::operator ESpeak):
(WebCore::CSSPrimitiveValue::operator BlendMode):
(WebCore::CSSPrimitiveValue::operator LineCap):
(WebCore::CSSPrimitiveValue::operator LineJoin):
(WebCore::CSSPrimitiveValue::operator WindRule):
(WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
(WebCore::CSSPrimitiveValue::operator EBorderCollapse):
(WebCore::CSSPrimitiveValue::operator EBorderFit):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
(WebCore::CSSPrimitiveValue::operator ColumnAxis):
(WebCore::CSSPrimitiveValue::operator ColumnProgression):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::convertToLength):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EDominantBaseline):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
(WebCore::CSSPrimitiveValue::operator ETextAnchor):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):
(WebCore::CSSPrimitiveValue::operator EVectorEffect):
(WebCore::CSSPrimitiveValue::operator EMaskType):

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):

  • css/Counter.h:

(WebCore::Counter::listStyleIdent):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):

  • css/MediaQueryEvaluator.cpp:

(WebCore::orientationMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

  • css/StyleResolver.cpp:

(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::colorForCSSValue):
(WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):

  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::getViewportArgumentValue):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • editing/ApplyStyleCommand.cpp:

(WebCore::toIdentifier):

  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::create):
(WebCore::HTMLElementEquivalent::HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::create):
(WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::fontWeightIsBold):
(WebCore::legacyFontSizeFromCSSValue):
(WebCore::isTransparentColorValue):

  • editing/EditingStyle.h:
  • editing/markup.cpp:

(WebCore::propertyMissingOrEqualToNone):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::systemFont):

  • platform/blackberry/RenderThemeBlackBerry.h:

(WebCore::RenderThemeBlackBerry::systemFont):

  • platform/blackberry/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::systemFont):

  • platform/blackberry/RenderThemeEfl.h:

(WebCore::RenderThemeEfl::systemFont):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::systemFont):

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::RenderThemeGtk::systemColor):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::systemColor):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::systemColor):

  • platform/qt/RenderThemeQt.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::systemColor):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::systemColor):

  • rendering/RenderThemeSafari.h:

(WebCore::RenderThemeSafari::systemFont):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::systemFont):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):

  • rendering/RenderThemeWin.h:
  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):

  • rendering/RenderThemeWinCE.h:
10:57 AM Changeset in webkit [151782] by Lucas Forschler
  • 1 copy in branches/safari-537-branch

New Branch.

10:54 AM Changeset in webkit [151781] by fpizlo@apple.com
  • 22 edits
    8 adds in branches/dfgFourthTier

fourthTier: DFG should have switch_char
​https://bugs.webkit.org/show_bug.cgi?id=117710

Source/JavaScriptCore:

Reviewed by Michael Saboff.

Add op_switch_char. Most of this is fairly simple, except for the whole
LazyJSValue thing.

It's long been the case that anytime you wanted the DFG to speak of a string
that didn't appear in the constant pool, you would have a hard time since
the DFG isn't allowed to allocate in the GC heap. For example, if you know
that you want to speak of a single character string, you might find that
the one you wanted to speak of had been GC'd. Another example is if you
wanted to add constant folding for string concatenation - something we don't
have yet but will want eventually.

I solve this by finally adding the notion of LazyJSValue. In the future I
anticipate using this for a variety of string-related things. The idea here
is that the DFG can either say that it already knows what the value is, or
it can describe the value. For example, in this patch I needed to be able to
describe single-character strings.

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/JumpTable.h:
  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGPRInfo.h:

(JSC::DFG::JSValueRegs::payloadGPR):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpTable):
(DFG):
(JSC::DFG::JITCompiler::numberOfJumpTables):
(JSC::DFG::JITCompiler::linkSwitches):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGLazyJSValue.cpp: Added.

(DFG):
(JSC::DFG::LazyJSValue::getValue):
(JSC::DFG::equalToSingleCharacter):
(JSC::DFG::LazyJSValue::strictEqual):
(JSC::DFG::LazyJSValue::dump):

  • dfg/DFGLazyJSValue.h: Added.

(DFG):
(LazyJSValue):
(JSC::DFG::LazyJSValue::LazyJSValue):
(JSC::DFG::LazyJSValue::singleCharacterString):
(JSC::DFG::LazyJSValue::tryGetValue):
(JSC::DFG::LazyJSValue::value):
(JSC::DFG::LazyJSValue::character):
(JSC::DFG::LazyJSValue::switchLookupValue):

  • dfg/DFGNode.h:

(JSC::DFG::SwitchCase::SwitchCase):
(SwitchCase):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(JSC::DFG::SpeculativeJIT::emitSwitchImmIntJump):
(DFG):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::emitSwitch):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

Source/WTF:

Reviewed by Michael Saboff.

I wanted to be able to say stringImpl->at(index), and now I can!

Also made it possible to convert a UChar to a utf8 CString without
allocating a StringImpl.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::utf8Impl):
(WTF):
(WTF::StringImpl::utf8ForCharacters):
(WTF::StringImpl::utf8ForRange):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::at):
(WTF::StringImpl::operator[]):

LayoutTests:

Rubber stamped by Mark Hahnenberg.

  • fast/js/regress/script-tests/switch-char-constant.js: Added.

(foo):
(bar):

  • fast/js/regress/script-tests/switch-char.js: Added.

(foo):
(bar):

  • fast/js/regress/switch-char-constant-expected.txt: Added.
  • fast/js/regress/switch-char-constant.html: Added.
  • fast/js/regress/switch-char-expected.txt: Added.
  • fast/js/regress/switch-char.html: Added.
10:14 AM Changeset in webkit [151780] by commit-queue@webkit.org
  • 6 edits in trunk

[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
​https://bugs.webkit.org/show_bug.cgi?id=117827

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-06-20
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Add DumpRenderTreeClient::willSendRequestForFrame() to handle
dispatchWillSendRequest() in DRT.

Fixes tests
fast/loader/onload-willSendRequest-null-for-script.html and
fast/loader/willSendRequest-null-for-preload.html.

  • Api/DumpRenderTreeClient.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):

Tools:

Reset the passed in request if willSendRequestReturnsNull() is
true or willSendRequestReturnsNullOnRedirect() is true and it's a
redirection.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
9:59 AM Changeset in webkit [151779] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Commit queue shouldn't reopen unrelated bugs because of flakiness
​https://bugs.webkit.org/show_bug.cgi?id=117503

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:

(_follow_duplicate_chain):
(_update_bug_for_flaky_test):

9:16 AM Changeset in webkit [151778] by Brent Fulgham
  • 7 edits in trunk/Source/WebCore

AX: List Items should support a default action
​https://bugs.webkit.org/show_bug.cgi?id=117812

Reviewed by Chris Fleizach.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::actionVerb): Provide a "select" verb
for use in ListItemRole objects.

  • platform/LocalizedStrings.cpp:

(WebCore::AXListItemActionVerb): Added.

  • platform/LocalizedStrings.h:
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:

(WebCore::AXListItemActionVerb):

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXListItemActionVerb):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXListItemActionVerb):

9:13 AM Changeset in webkit [151777] by commit-queue@webkit.org
  • 36 edits
    3 copies
    4 adds in trunk

[CSS Regions] Add new regionOversetChange event
​https://bugs.webkit.org/show_bug.cgi?id=117508

Source/WebCore:

Added regionOversetChange event and tests for it. The overset value of the region has been moved to the ElementRareData
object instead of the RenderRegion object. This was needed for the case when a reattach is performed (for instance by changing
the display type of the region's containing block) and the RenderRegion object is destroyed. When computing the overset again,
there would be no "previous" value to compare it to and decide whether the regionOversetChange event must be dispatched.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.

Tests: fast/regions/webkit-named-flow-event-add-to-flow.html:

fast/regions/webkit-named-flow-event-auto-height.html:
fast/regions/webkit-named-flow-event-crash.html:
fast/regions/webkit-named-flow-event-no-regions.html:
fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
fast/regions/webkit-named-flow-event-remove-from-dom.html:
fast/regions/webkit-named-flow-event-remove-from-flow.html:
fast/regions/webkit-named-flow-event-target.html:
fast/regions/webkit-named-flow-event-to-null.html:
fast/regions/webkit-named-flow-event.html:

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp:

(WebCore::Element::setRegionOversetState):
(WebCore::Element::regionOversetState):
(WebCore::Element::webkitRegionOverset):

  • dom/Element.h:
  • dom/ElementRareData.cpp:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::regionOversetState):
(WebCore::ElementRareData::setRegionOversetState):
(WebCore::ElementRareData::ElementRareData):

  • dom/EventNames.h:
  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore::WebKitNamedFlow::dispatchRegionOversetChangeEvent):

  • dom/WebKitNamedFlow.h:

(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):

  • rendering/RegionOversetState.h: Added.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOversetStateForRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):

  • rendering/RenderRegion.h:

LayoutTests:

Changed regionLayoutUpdate tests to regionOversetChange and added new tests for regionOversetChange.

Patch by Radu Stavila <​stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.

  • fast/regions/webkit-named-flow-event-add-to-flow-expected.txt:
  • fast/regions/webkit-named-flow-event-add-to-flow.html:
  • fast/regions/webkit-named-flow-event-auto-height-expected.txt:
  • fast/regions/webkit-named-flow-event-auto-height.html: Added.
  • fast/regions/webkit-named-flow-event-crash-expected.txt:
  • fast/regions/webkit-named-flow-event-crash.html:
  • fast/regions/webkit-named-flow-event-expected.txt:
  • fast/regions/webkit-named-flow-event-no-regions-expected.txt:
  • fast/regions/webkit-named-flow-event-no-regions.html:
  • fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt:
  • fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
  • fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt:
  • fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
  • fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt:
  • fast/regions/webkit-named-flow-event-remove-from-dom.html:
  • fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt:
  • fast/regions/webkit-named-flow-event-remove-from-flow.html:
  • fast/regions/webkit-named-flow-event-target-expected.txt:
  • fast/regions/webkit-named-flow-event-target.html:
  • fast/regions/webkit-named-flow-event-to-null-expected.txt:
  • fast/regions/webkit-named-flow-event-to-null.html:
  • fast/regions/webkit-named-flow-event.html:
9:08 AM Changeset in webkit [151776] by commit-queue@webkit.org
  • 9 edits in trunk

AX: aria-required is not exposed on all expected roles
​https://bugs.webkit.org/show_bug.cgi?id=115123

Patch by James Craig <​james@cookiecrook.com> on 2013-06-20
Reviewed by Chris Fleizach.

aria-required is now exposed on more roles. Updated existing test file.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::supportsRequiredAttribute):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/aria-required-expected.txt:
  • platform/mac/accessibility/aria-required.html:
  • platform/mac/accessibility/radio-button-group-members-expected.txt:
7:26 AM WebKitGTK/StartHacking edited by Andres Gomez
More minor changes (diff)
7:24 AM WebKitGTK/StartHacking edited by Andres Gomez
Minor change (diff)
7:20 AM WebKitGTK/StartHacking edited by Andres Gomez
Minor styling (diff)
7:17 AM WebKitGTK/StartHacking edited by eocanha@igalia.com
(diff)
7:11 AM Changeset in webkit [151775] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Update text checker documentation.
​https://bugs.webkit.org/show_bug.cgi?id=117828

Reviewed by Christophe Dumez.

  • UIProcess/API/efl/ewk_text_checker.h:

The client is not responsible for destroying the memory.

7:09 AM WebKitGTK/StartHacking edited by Andres Gomez
Added choosing distribution section (diff)
6:21 AM Changeset in webkit [151774] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

Web Inspector: Use console.timeStamp instead of console.markTimeline
​https://bugs.webkit.org/show_bug.cgi?id=117810

Patch by Seokju Kwon <Seokju Kwon> on 2013-06-20
Reviewed by Joseph Pecoraro.

Source/WebCore:

Webkit supports both console.timeStamp and console.markTimeline.
And they do the exact same thing.
This patch gets rid of console.markTimeline for Chrome/Firebug compatibility.

No new functionality, no new tests.

  • WebCore.order:
  • page/Console.cpp:
  • page/Console.h:
  • page/Console.idl:

LayoutTests:

Use 'console.timeStamp' instead of 'console.markTimeline' in LayoutTests.
And remove inspector/timeline/timeline-mark-timeline.html.

  • inspector/console/console-messages-stack-traces-expected.txt:
  • inspector/console/console-messages-stack-traces.html:
  • inspector/timeline/timeline-mark-timeline-expected.txt: Removed.
  • inspector/timeline/timeline-mark-timeline.html: Removed.
  • inspector/timeline/timeline-timer-fired-from-eval-call-site.html:
1:22 AM Changeset in webkit [151773] by zarvai@inf.u-szeged.hu
  • 2 edits
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

Rebselining after r151761, see bug 115372.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/vertical-overflow-child-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/vertical-overflow-parent-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/vertical-overflow-same-expected.txt: Added.
1:04 AM WebKitGTK/2.0.x edited by agarcia@igalia.com
(diff)
12:39 AM Changeset in webkit [151772] by g.czajkowski@samsung.com
  • 4 edits
    6 adds in trunk

background-color and text-decoration are not preserved when merging paragraphs
​https://bugs.webkit.org/show_bug.cgi?id=116215

Reviewed by Ryosuke Niwa.

Source/WebCore:

In mergeInlineAndImplicitStyleOfElement(), style from matched rules are retrieved.
If they contain either background-color or text-decoration they will be removed
by removeNonEditingProperties() due to copyEditingProperties() implicit
'OnlyInheritableEditingProperties' parameter.
We have already had similar issue at ​https://bugs.webkit.org/show_bug.cgi?id=53196

Tests: editing/deleting/merge-div-from-span-with-style.html

editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html
editing/deleting/merge-paragraph-from-span-with-style.html

  • editing/EditingStyle.cpp:

(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
Add EditingStyle:: due to move EditingPropertiesToInclude to EditingStyle.h.

(WebCore::toEditingProperties):
Add a helper to easy convert PropertiesToInclude to EditingPropertiesToInclude,
needed in mergeInlineAndImplicitStyleOfElement().

(WebCore::EditingStyle::removeAllButEditingProperties):
Add a parameter to choose which editing properties should be preserved while
removing all properties (OnlyInheritableEditingProperties implicite).

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
Call removeAllButEditingProperties with parameter.

  • editing/EditingStyle.h:

Move EditingPropertiesType to the header as it's needed by removeAllButEditingProperties().
Change EditingPropertiesType to EditingPropertiesToInclude to be consistent with
PropertiesToInclude.
Change removeNonEditingProperties() to removeAllButEditingProperties().

LayoutTests:

Added tests for verifying merge of paragraph/div from span with non-inline styles.

  • editing/deleting/merge-div-from-span-with-style-expected.txt: Added.
  • editing/deleting/merge-div-from-span-with-style.html: Added.
  • editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html: Added.
  • editing/deleting/merge-paragraph-from-span-with-style-expected.txt: Added.
  • editing/deleting/merge-paragraph-from-span-with-style.html: Added.
Note: See TracTimeline for information about the timeline view.