⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 29, 2013:

1:27 PM Changeset in webkit [152214] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Avoid calling into Objective-C every time we get the scrollbar width
​https://bugs.webkit.org/show_bug.cgi?id=118216

Reviewed by Geoffrey Garen.

Profiling shows that calling Scrollbar::isOverlayScrollbar() is somewhat
expensive, because it calls down into Objective-C. Fix by caching in
ScrollbarThemeMac whether we're using overlay scrollbars. We update this
cache on creation, and when preferences change; ScrollAnimatorMac::updateScrollerStyle()
is the function that gets called when the user changes the setting in System Preferences.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::usesOverlayScrollbarsChanged):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::updateScrollerStyle):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::preferencesChanged):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):

1:22 PM Changeset in webkit [152213] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Avoid calling isSimpleContainerCompositingLayer() an extra time
​https://bugs.webkit.org/show_bug.cgi?id=118218

Reviewed by Tim Horton.

containsPaintedContent() called isSimpleContainerCompositingLayer(), which
is not particularly cheap. But the caller already has this information,
so pass it in.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::containsPaintedContent):

  • rendering/RenderLayerBacking.h:
1:19 PM Changeset in webkit [152212] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer is this
​https://bugs.webkit.org/show_bug.cgi?id=118215

Reviewed by Tim Horton.

When the RenderGeometryMap code path was added, RenderBox::outlineBoundsForRepaint()
actually got slower if no coordinate mapping was needed. So avoid doing work when
we can, including avoiding the FloatQuad construction.

Speeds up scrolling overflow:scroll areas with large numbers of layer children.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::outlineBoundsForRepaint):

8:49 AM Changeset in webkit [152211] by kangil.han@samsung.com
  • 14 edits in trunk/Source

Adopt is/toHTMLOptGroupElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=118213

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLOptGroupElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):

  • html/HTMLOptGroupElement.h:

(WebCore::isHTMLOptGroupElement):
(WebCore::toHTMLOptGroupElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::recalcListItems):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isSelectScopeMarker):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsLabel):

Source/WebKit/blackberry:

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

8:15 AM Changeset in webkit [152210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for unguarded SVGGraphicsElement
​https://bugs.webkit.org/show_bug.cgi?id=118214

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-06-29
Reviewed by Christophe Dumez.

Add the SVG condition to SVGGraphicsElement.idl

No new tests required since no functionality changed.

  • svg/SVGGraphicsElement.idl:
7:59 AM Changeset in webkit [152209] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Follow-up to r152206: also update HashFlags8BitBuffer in the LLInt.

  • llint/LowLevelInterpreter.asm:
1:18 AM Changeset in webkit [152208] by kangil.han@samsung.com
  • 24 edits in trunk/Source

Adopt is/toHTMLOptionElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=118212

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLOptionElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::setElement):
(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityHitTest):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::index):

  • html/HTMLOptionElement.h:

(WebCore::isHTMLOptionElement):
(WebCore::toHTMLOptionElement):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isSelectScopeMarker):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsSelected):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

Source/WebKit/blackberry:

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):

  • WebKitSupport/SelectPopupClient.cpp:

(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):

12:25 AM Changeset in webkit [152207] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

REGRESSION(151586): multipart/x-mixed-replace images are broken
​https://bugs.webkit.org/show_bug.cgi?id=118169

Reviewed by Alexey Proskuryakov.

When loading multipart content the resource data will change as
the next part is loaded, so we need to make a copy of the data
before sending it to the resource.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):

Jun 28, 2013:

11:02 PM Changeset in webkit [152206] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Un-crashify JSC tests on debug bots after Anders had his way with StringImpl.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

10:53 PM Changeset in webkit [152205] by akling@apple.com
  • 4 edits in trunk

Fix Windows builds after deprecatedCharactersWithNullTermination() removal.

Source/WebKit2:

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::createServerAndClientIdentifiers):

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(addFontFallbackIfPresent):
(removeFontFallbackIfPresent):

7:55 PM Changeset in webkit [152204] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] adopt new AVFoundation caption API
​https://bugs.webkit.org/show_bug.cgi?id=118207

Reviewed by Dean Jackson.

No new tests, I was not able to come up with a reliable layout test.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::flushCues): New, call currentTrack->resetCueValues().
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]): New delegate method.

7:41 PM Changeset in webkit [152203] by kangil.han@samsung.com
  • 22 edits in trunk/Source

Adopt is/toHTMLImageElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=118182

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLImageElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isNativeImage):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::url):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):

  • dom/Clipboard.cpp:

(WebCore::Clipboard::setDragImage):

  • dom/Node.cpp:

(WebCore::Node::enclosingLinkEventParentOrSelf):

  • editing/Editor.cpp:

(WebCore::imageElementFromImageDocument):

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):

  • html/HTMLImageElement.h:

(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

  • html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):

  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):

  • platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPage::blockZoom):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::isElementClickable):

6:45 PM Changeset in webkit [152202] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

PageThrottler::shouldThrottleTimers is wrong.
​https://bugs.webkit.org/show_bug.cgi?id=118210

Reviewed by Anders Carlson.

m_throttleState == PageNotThrottledState

-> page NOT throttled, so should NOT throttle timers

m_throttleState != PageNotThrottledState

-> page NOT NOT throttled, so should throttle timers

This needs cleaning up, but for now, 1 character fix.

  • page/PageThrottler.h:

(WebCore::PageThrottler::shouldThrottleTimers):

-> !=

6:39 PM Changeset in webkit [152201] by andersca@apple.com
  • 11 edits in trunk

Remove String::deprecatedCharactersWithNullTermination() and related code
​https://bugs.webkit.org/show_bug.cgi?id=118211

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • API/JSStringRef.cpp:

(JSStringCreateWithCharactersNoCopy):
Update call to StringImpl::createWithoutCopying.

Source/WTF:

Remove String::deprecatedCharactersWithNullTermination, StringImpl::createWithTerminatingNullCharacter
and the s_hashFlagHasTerminatingNullCharacter flag. We no longer care about whether strings have a
terminating null character.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::sizeInBytes):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::isolatedCopy):

  • wtf/text/WTFString.cpp:
  • wtf/text/WTFString.h:

Tools:

Remove all hasTerminatingNullCharacter() checks.

  • TestWebKitAPI/Tests/WTF/AtomicString.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

6:39 PM Changeset in webkit [152200] by dino@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Update Apple System fonts in auto-complete
​https://bugs.webkit.org/show_bug.cgi?id=118205
<rdar://problem/14308488>

Reviewed by Joseph Pecoraro.

Update for the new Apple System font names, and remove some invalid entries.

  • UserInterface/CSSKeywordCompletions.js: General cleanup. Note that

"apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)

6:25 PM Changeset in webkit [152199] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
​https://bugs.webkit.org/show_bug.cgi?id=118122

Patch by James Craig <​james@cookiecrook.com> on 2013-06-28
Reviewed by Timothy Hatcher.

Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by ​http://webkit.org/b/118162

  • UserInterface/FilterBar.css:

(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):

  • UserInterface/FilterBar.js:

(WebInspector.FilterBar):

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):

  • UserInterface/SearchBar.css:

(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):

  • UserInterface/SearchBar.js:

(WebInspector.SearchBar):

5:09 PM Changeset in webkit [152198] by rniwa@webkit.org
  • 4 edits
    4 adds in trunk

An element with -webkit-user-select: all should be selected on single click
​https://bugs.webkit.org/show_bug.cgi?id=117864

Reviewed by Darin Adler.

Source/WebCore:

Set m_mouseDownMayStartSelect true even when the node cannot start selection
if the node was inside an element with -webkit-user-select: all.

Test: editing/selection/user-select-all-with-single-click.html

  • page/EventHandler.cpp:

(WebCore::canMouseDownStartSelect):

LayoutTests:

Add tests for single clicking on an element with user-select: all.
We select the entire element regardless of whether the user had clicked on text or an image
to be consistent even though Firefox requires a double click on the latter case.

  • editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
  • editing/selection/user-select-all-with-image-single-click.html: Added.
  • editing/selection/user-select-all-with-single-click-expected.txt: Added.
  • editing/selection/user-select-all-with-single-click.html: Added.
5:01 PM Changeset in webkit [152197] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused attachChildrenLazily method and make attach/detachChildren private
​https://bugs.webkit.org/show_bug.cgi?id=118016

Reviewed by Darin Adler.

Merge ​https://chromium.googlesource.com/chromium/blink/+/009520dc31c9458e0cf71cf212fa5688c4ca68b0

No one should be manually trying to attach or detach all their children so there's
no reason for these methods to be public.

In doing this I realized that attachChildrenLazily is not used and can be removed.

I also realized that we were detaching all our children before the ShadowRoots which
is sad since the InsertionPoints will call detach() on them as well, and then when we
call ContainerNode::detach at the end of Element::detach we'll go detach them again!
This patch makes it so we only go through and detach them twice instead of three times.
In the future we should figure out a way to only do this once.

  • dom/ContainerNode.h:
  • dom/Element.cpp:

(WebCore::Element::detach):

4:57 PM Changeset in webkit [152196] by ap@apple.com
  • 4 edits
    2 adds in trunk

[Mac] Crash when loading is stopped from -didReceiveResponse
​https://bugs.webkit.org/show_bug.cgi?id=118209
<rdar://problem/14259249>

Reviewed by Brady Eidson.

Test: TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm.

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Added yet another check for reachedTerminalState().
4:40 PM Changeset in webkit [152195] by aestes@apple.com
  • 2 edits in trunk/Tools

[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=118208

Reviewed by Mark Rowe.

Newer versions of clang use a default template depth of 128, but this
is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
previous default.

Clang lowered the default to keep recursive template instantiation
from overflowing the stack (see <rdar://problem/13935016>), but
TestWebKitAPI's C++ files don't trigger a stack overflow even with the
higher limit. If for some reason this starts happening then we can
lower the limit back down.

  • TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
4:11 PM Changeset in webkit [152194] by Beth Dakin
  • 6 edits in trunk/Source/WebCore

Cached pages don't update their backing scale factor when it changes
​https://bugs.webkit.org/show_bug.cgi?id=118206
-and-
<rdar://problem/14261627>

Reviewed by Tim Horton.

It is not sufficient to mark pages in the PageCache as needing a full style
recalc. We also need to ensure that the RenderLayerCompositors for the CachesPages
get updated.

Keep track of whether device scale has been updated with
m_needsDeviceScaleChanged. If that has been marked true, then restore() will call
Frame::deviceOrPageScaleFactorChanged().

  • history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):

  • history/CachedPage.h:

(WebCore::CachedPage::markForDeviceScaleChanged):

Propagate markForDeviceScaleChanged() to all of the CachedPages.

  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForDeviceScaleChanged):

  • history/PageCache.h:

Call PageCache::markPagesForDeviceScaleChanged()

  • page/Page.cpp:

(WebCore::Page::setDeviceScaleFactor):

3:48 PM Changeset in webkit [152193] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Added template parameters to std::min to fix compile errors in Visual Studio x64.
​https://bugs.webkit.org/show_bug.cgi?id=118204

Reviewed by Geoffrey Garen.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeURLToDataObject): Added <unsigned> to std::min.
(WebCore::createGlobalImageFileDescriptor): Added <int> to std::min.

3:43 PM Changeset in webkit [152192] by achristensen@apple.com
  • 5 edits in trunk/Source/WebCore

Added WebGL files to Windows build.
​https://bugs.webkit.org/show_bug.cgi?id=118200

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.vcxproj: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
  • platform/graphics/cairo/GLContext.cpp: Only include GLContextEGL.h or GLContextGLX.h if they're needed.
  • platform/graphics/cg/GraphicsContext3DCG.cpp: Only include GraphicsContext3DNEON.h if it's needed.
3:21 PM Changeset in webkit [152191] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
​https://bugs.webkit.org/show_bug.cgi?id=118195

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-06-28
Reviewed by Daniel Bates.

Currently, ports that use jhbuild fail to determine jhbuild directory
when "webKitBranchBuild" git configuration property is enabled. To reproduce
that issue in Efl port, enable that flag in .git/config, switch to a git branch
other than "master" and try to build webkit. The build will fail to
locate dependencies due to lack of pkg-config paths which should be set
by jhbuild.

For more details about "webKitBranchBuild" option, see:
​https://trac.webkit.org/wiki/UsingGitWithWebKit

  • Scripts/webkitdirs.pm:

(getJhbuildPath):

3:15 PM Changeset in webkit [152190] by timothy_horton@apple.com
  • 11 edits in trunk/Source/WebKit2

[wk2] WKView shouldn't force scrolling off if shouldClipToVisibleRect is set
​https://bugs.webkit.org/show_bug.cgi?id=118174
<rdar://problem/14301175>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateViewExposedRect]):
Pass whether or not clips-to-visibleRect is enabled down to the WebPageProxy.

(-[WKView setMinimumSizeForAutoLayout:]):
Disable scrolling when using autolayout instead of when using clips-to-visibleRect.

(-[WKView setShouldClipToVisibleRect:]):
Clipping to the WKView's visibleRect does not strictly require scrolling to be disabled,
and in fact there are cases (RTL/TB pagination) where we *must* scroll, even when the view
is big enough to fit the content (the case clip-to-visibleRect was added for).

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::viewExposedRectChanged):
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Keep track of and forward to the drawing area whether or not clips-to-visibleRect is enabled.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setClipsToExposedRect): Added.
(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame): Added a missing space.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewExposedRectChanged):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Forward clips-to-visibleRect enabled state to the drawing area.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

Add storage for m_clipsToExposedRect.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Check m_clipsToExposedRect instead of the main-frame's isScrollable() to determine
whether we should tell our TiledBackings to clip to the exposed rect we provide.

We don't need to listen to mainFrameScrollabilityChanged anymore.

2:48 PM Changeset in webkit [152189] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Tools

Merged r152188. <rdar://problem/14306452>

2:45 PM Changeset in webkit [152188] by jberlin@webkit.org
  • 2 edits in trunk/Tools

WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
​https://bugs.webkit.org/show_bug.cgi?id=118201

Reviewed by Dean Jackson.

  • WebKitTestRunner/mac/main.mm:

(main):
Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
setAutomaticDashSubstitutionEnabled are not exposed on WKView.

1:40 PM Changeset in webkit [152187] by barraclough@apple.com
  • 2 edits in trunk/Source/WebKit2

Stale occlusion state after moving page back into window
​https://bugs.webkit.org/show_bug.cgi?id=118202

Reviewed by Anders Carlsson.

We need to update the occlusion state when the page goes back into the window.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):

  • update occlusion state.
1:38 PM Changeset in webkit [152186] by dfarler@apple.com
  • 9 edits in trunk/Tools

Upstream WebKit Nightly’s WebKitLauncher
​https://bugs.webkit.org/show_bug.cgi?id=117418

Reviewed by Mark Rowe.

Literal patch from Nightly's OpenSource repo.

  • WebKitLauncher/Configurations/Base.xcconfig:
  • WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
  • WebKitLauncher/Info.plist:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncherURLProtocol.m:

(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
(-[WebKitLauncherURLProtocol resourceNotFound]):

  • WebKitLauncher/WebKitNightlyEnablerSparkle.m:

(initializeSparkle):

  • WebKitLauncher/main.m:

(determineExecutablePath):
(currentMacOSXVersion):
(main):

  • WebKitLauncher/start.html:
12:59 PM Changeset in webkit [152185] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

-webkit-line-break: after-white-space sometimes truncates DOM on copy & paste
​https://bugs.webkit.org/show_bug.cgi?id=118164

Reviewed by Sam Weinig.

Source/WebCore:

We can't assume that all subsequent ancestors contain exactly one child since they could have been
added in the first if statement matching: currentNode->parentNode() != rootNode && isRemovableBlock(currentNode)

Exit early when we encounter such an ancestor since removing its ancestor (that contains multiple children
some of which aren't in nodesToRemove) can clobber more nodes than we're allowed to remove.

Test: editing/pasteboard/simplfiying-markup-should-not-strip-content.html

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):

LayoutTests:

Add a regression test.

  • editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt: Added.
  • editing/pasteboard/simplfiying-markup-should-not-strip-content.html: Added.
12:55 PM Changeset in webkit [152184] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

media/video-currentTime.html flakey
​https://bugs.webkit.org/show_bug.cgi?id=118198

Reviewed by Jessie Berlin.

Update video-currentTime.html so that it listens for timeupdate events, and ends the test
after the first one with a >0 currentTime. Add a 3s watchdog for the failure case.

  • media/video-currentTime-expected.txt:
  • media/video-currentTime.html:
12:09 PM Changeset in webkit [152183] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source

Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=104360

Patch by Gwang Yoon Hwang <​ryumiel@company100.net> on 2013-06-28
Reviewed by Noam Rosenthal.

The CoordinatedLayerTreeHost has too many responsibilities. It
implements LayerTreeHost, GraphicsLayerClient,
CoordinatedGraphicsLayerClient, CoordinatedImageBacking::Client,
UpdateAtlas::Client, GraphicsLayerFactory and
WebCustomFilterProgramProxyClient.

This refactoring reduces the responsibilities of CoordinatedLayerTreeHost.

This patch introduces a new class called CompositingCoordinator, which
takes the responsibility of managing compositing resources in
WebProcess.

CoordinatedLayerTreeHost is responsible only for the scheduling and
IPC-specific stuff, which are relevant only for WebKit2.

No new tests, covered by existing tests.

Source/WebCore:

  • CMakeLists.txt:
  • Target.pri:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Added.

(WebCore::CompositingCoordinator::create):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::sizeDidChange):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):
(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::syncLayerState):
(WebCore::CompositingCoordinator::createImageBackingIfNeeded):
(WebCore::CompositingCoordinator::createImageBacking):
(WebCore::CompositingCoordinator::updateImageBacking):
(WebCore::CompositingCoordinator::clearImageBackingContents):
(WebCore::CompositingCoordinator::removeImageBacking):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::notifyAnimationStarted):
(WebCore::CompositingCoordinator::notifyFlushRequired):
(WebCore::CompositingCoordinator::paintContents):
(WebCore::CompositingCoordinator::createGraphicsLayer):
(WebCore::CompositingCoordinator::deviceScaleFactor):
(WebCore::CompositingCoordinator::pageScaleFactor):
(WebCore::CompositingCoordinator::createUpdateAtlas):
(WebCore::CompositingCoordinator::removeUpdateAtlas):
(WebCore::CompositingCoordinator::visibleContentsRect):
(WebCore::CompositingCoordinator::mainContentsLayer):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebCore::CompositingCoordinator::detachLayer):
(WebCore::CompositingCoordinator::commitScrollOffset):
(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::purgeBackingStores):
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h: Added.

(WebCore::CompositingCoordinator::clearRootLayer):
(WebCore::CompositingCoordinator::rootLayer):
(WebCore::CompositingCoordinator::state):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::willSyncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesForAnimations):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/LayerTreeHost.h:
11:57 AM Changeset in webkit [152182] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make the UI process run the Java Updater
​https://bugs.webkit.org/show_bug.cgi?id=118197
<rdar://problem/14255677>

Reviewed by Sam Weinig.

Patch the relevant NSWorkspace method and pipe through the request to launch the Java updater to the UI process.

  • PluginProcess/PluginProcess.h:
  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::replacedNSWorkspace_launchApplicationAtURL_options_configuration_error):
(WebKit::initializeCocoaOverrides):
(WebKit::PluginProcess::launchApplicationAtURL):

  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::isJavaUpdaterURL):
(WebKit::shouldLaunchApplicationAtURL):
(WebKit::PluginProcessProxy::launchApplicationAtURL):

11:47 AM Changeset in webkit [152181] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r152135.
​http://trac.webkit.org/changeset/152135
​https://bugs.webkit.org/show_bug.cgi?id=118199

Rolling out temporary patch used for debugging the test bots
(Requested by rfong on #webkit).

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::load):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):

11:08 AM Changeset in webkit [152180] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Update TestExpectations so new Shapes tests are skipped where the old ones were
​https://bugs.webkit.org/show_bug.cgi?id=118192

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-28
Reviewed by Brent Fulgham.

Shapes still aren't enabled on some ports, so skip the tests there.
As part of this patch, it was discovered that they work on EFL, so the
skipping has been removed from there.

  • platform/efl/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
11:07 AM Changeset in webkit [152179] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] back/forward keyboard shortcuts are non-intuitive
​https://bugs.webkit.org/show_bug.cgi?id=118193

Patch by Balazs Kelemen <​b.kelemen@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.

Changed shortcuts for go-back/go-forward to alt+left and alt+right.

  • EWebLauncher/main.c:

(on_key_down):

  • MiniBrowser/efl/main.c:

(on_key_down):

11:00 AM Changeset in webkit [152178] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

SVG relayout problem when displayed with different image box heights
​https://bugs.webkit.org/show_bug.cgi?id=118140

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-06-28
Reviewed by Philip Rogers.

Source/WebCore:

If the root element is an SVG, its position and height are affected
by the view height.

Test: svg/as-image/same-source-different-height.html

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

LayoutTests:

  • svg/as-image/same-source-different-height-expected.html: Added.
  • svg/as-image/same-source-different-height.html: Added.
10:54 AM Changeset in webkit [152177] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WARN_UNUSED_RESULT can't be used in API headers, but WKBundlePageExtendIncrementalRenderingSuppression tries to
​https://bugs.webkit.org/show_bug.cgi?id=118196
<rdar://problem/14303613>

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
10:54 AM Changeset in webkit [152176] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=118194.

Reviewed by Brent Fulgham.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dllLauncherEntryPoint):

  • WinLauncher/WinLauncher.cpp:

(dllLauncherEntryPoint):

10:31 AM Changeset in webkit [152175] by Simon Fraser
  • 12 edits
    3 deletes in trunk/Source/WebCore

Allow some LayoutPoint and LayoutSize conversions to be inlined
​https://bugs.webkit.org/show_bug.cgi?id=118167

Reviewed by Ryosuke Niwa.

Construction of FloatSize from LayoutSize, and FloatPoint's move(const LayoutSize&)
and moveBy(const LayoutPoint&) were not inlined, and showed up on some profiles.

Make them inlined by removing the overloaded functions, and instead providing
conversion operators from LayoutSize to FloatSize, and LayoutPoint to FloatPoint.
Do the same to allow a LayoutRect to be converted to a FloatRect.

This is nice because it removes pollution of FloatRect, FloatPoint and FloatSize with
Layout* entirely.

Remove Qt-specific conversions on LayoutRect, LayoutPoint and LayoutSize. Qt can
convert via IntRect/FloatRect as necessary.

  • platform/graphics/FloatPoint.cpp:
  • platform/graphics/FloatPoint.h:

(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):

  • platform/graphics/FloatRect.cpp:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp:
  • platform/graphics/FloatSize.h:
  • platform/graphics/LayoutPoint.h:

(WebCore::LayoutPoint::operator FloatPoint):

  • platform/graphics/LayoutRect.cpp:
  • platform/graphics/LayoutRect.h:

(WebCore::LayoutRect::operator FloatRect):

  • platform/graphics/LayoutSize.h:

(WebCore::LayoutSize::operator FloatSize):

10:13 AM Changeset in webkit [152174] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Unreviewed build fix for AppleWin port. Fix some file paths.

  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
9:50 AM Changeset in webkit [152173] by jberlin@webkit.org
  • 5 edits in branches/safari-537-branch/LayoutTests

Merged r151942. <rdar://problem/14299780>

9:39 AM Changeset in webkit [152172] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

accessibility/media-element.html does not support platforms without subroles
​https://bugs.webkit.org/show_bug.cgi?id=118187

Reviewed by Chris Fleizach.

Update the test to be more friendly with platforms not supporting subroles.

  • accessibility/media-element.html: Updated test.
9:23 AM Changeset in webkit [152171] by roger_fong@apple.com
  • 4 edits
    2 adds in trunk/Tools

Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
​https://bugs.webkit.org/show_bug.cgi?id=118160.

Reviewed by Brent Fulgham.

  • WinLauncher/AccessibilityDelegate.cpp: Added.

(AccessibilityDelegate::QueryInterface):
(AccessibilityDelegate::AddRef):
(AccessibilityDelegate::Release):
(AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
(AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.

  • WinLauncher/AccessibilityDelegate.h: Added.

(AccessibilityDelegate::AccessibilityDelegate):

  • WinLauncher/WinLauncher.cpp:

(dllLauncherEntryPoint):

  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
9:11 AM WebKitIDL edited by Christophe Dumez
Remove ExtendsDOMGlobalObject and IsWorkerContext after r152168 (diff)
9:08 AM Changeset in webkit [152170] by Christophe Dumez
  • 2 edits in trunk/Tools

Clean up temporary files created by the bindings test script
​https://bugs.webkit.org/show_bug.cgi?id=118189

Reviewed by Kentaro Hara.

Remove temporary files created by preprocess-idls.pl script after
the bindings tests are executed.

Based on Blink 153236 by Kentaro Hara <​haraken@chromium.org>.

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.main):

9:07 AM Changeset in webkit [152169] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/win

[WinCairo] Compilation error.
​https://bugs.webkit.org/show_bug.cgi?id=118131

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-06-28
Reviewed by Brent Fulgham.

  • Interfaces/IWebView.idl: Include needed accessibility interface.
  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::AXFinishFrameLoad): Accessibility methods should not be inside FULLSCREEN_API ifdef.

9:01 AM Changeset in webkit [152168] by Christophe Dumez
  • 7 edits in trunk/Source/WebCore

Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
​https://bugs.webkit.org/show_bug.cgi?id=118191

Reviewed by Kentaro Hara.

Remove WebKit-specific [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] IDL
extended attributes and update the JSC bindings generator to figure this out
on its own.

No new tests, no behavior change.

  • bindings/scripts/CodeGeneratorJS.pm:

(IsDOMGlobalObject):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):

  • bindings/scripts/IDLAttributes.txt:
  • page/DOMWindow.idl:
  • workers/DedicatedWorkerGlobalScope.idl:
  • workers/SharedWorkerGlobalScope.idl:
  • workers/WorkerGlobalScope.idl:
8:58 AM Changeset in webkit [152167] by Christophe Dumez
  • 80 edits
    1 copy
    2 moves in trunk

Introduce SVGGraphicsElement IDL interface
​https://bugs.webkit.org/show_bug.cgi?id=118178

Reviewed by Kentaro Hara.

Source/WebCore:

Introduce SVGGraphicsElement IDL interface as per the latest SVG
specification:

SVGGraphicsElement is a merge of SVGLocatable and SVGTransformable.
This is one step towards simplifying inheritance in SVG and matching
the latest SVG2 specification.

No new tests, already covered by existing tests.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetGnuVTableOffsetForType):

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::RenderSVGEllipse):

  • rendering/svg/RenderSVGEllipse.h:
  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::RenderSVGPath):

  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGResourceMarker.cpp:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):

  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/RenderSVGTransformableContainer.h:
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::SVGAElement):
(WebCore::SVGAElement::parseAttribute):
(WebCore::SVGAElement::svgAttributeChanged):
(WebCore::SVGAElement::defaultEventHandler):
(WebCore::SVGAElement::supportsFocus):
(WebCore::SVGAElement::isURLAttribute):

  • svg/SVGAElement.h:
  • svg/SVGAElement.idl:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::SVGCircleElement):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):

  • svg/SVGCircleElement.h:
  • svg/SVGCircleElement.idl:
  • svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::parseAttribute):
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):

  • svg/SVGClipPathElement.h:
  • svg/SVGClipPathElement.idl:
  • svg/SVGDefsElement.cpp:

(WebCore::SVGDefsElement::SVGDefsElement):

  • svg/SVGDefsElement.h:
  • svg/SVGDefsElement.idl:
  • svg/SVGElement.h:

(WebCore::SVGElement::isSVGGraphicsElement):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):

  • svg/SVGEllipseElement.h:
  • svg/SVGEllipseElement.idl:
  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
(WebCore::SVGForeignObjectElement::rendererIsNeeded):

  • svg/SVGForeignObjectElement.h:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::SVGGElement):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):

  • svg/SVGGElement.h:
  • svg/SVGGElement.idl:
  • svg/SVGGraphicsElement.cpp: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.cpp.

(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::~SVGGraphicsElement):
(WebCore::SVGGraphicsElement::getCTM):
(WebCore::SVGGraphicsElement::getScreenCTM):
(WebCore::SVGGraphicsElement::animatedLocalTransform):
(WebCore::SVGGraphicsElement::supplementalTransform):
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
(WebCore::SVGGraphicsElement::nearestViewportElement):
(WebCore::SVGGraphicsElement::farthestViewportElement):
(WebCore::SVGGraphicsElement::getBBox):
(WebCore::SVGGraphicsElement::createRenderer):
(WebCore::SVGGraphicsElement::toClipPath):

  • svg/SVGGraphicsElement.h: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.h.

(WebCore::SVGGraphicsElement::localCoordinateSpaceTransform):
(WebCore::SVGGraphicsElement::synchronizeRequiredFeatures):
(WebCore::SVGGraphicsElement::synchronizeRequiredExtensions):
(WebCore::SVGGraphicsElement::synchronizeSystemLanguage):
(WebCore::toSVGGraphicsElement):

  • svg/SVGGraphicsElement.idl: Copied from Source/WebCore/svg/SVGForeignObjectElement.idl.
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::collectStyleForPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
(WebCore::SVGImageElement::attach):
(WebCore::SVGImageElement::insertedInto):
(WebCore::SVGImageElement::addSubresourceAttributeURLs):
(WebCore::SVGImageElement::didMoveToNewDocument):

  • svg/SVGImageElement.h:
  • svg/SVGImageElement.idl:
  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::SVGLineElement):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):

  • svg/SVGLineElement.h:
  • svg/SVGLineElement.idl:
  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::insertedInto):
(WebCore::SVGPathElement::removedFrom):

  • svg/SVGPathElement.h:
  • svg/SVGPathElement.idl:
  • svg/SVGPatternElement.cpp:
  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::SVGPolyElement):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):

  • svg/SVGPolyElement.h:
  • svg/SVGPolygonElement.idl:
  • svg/SVGPolylineElement.idl:
  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):

  • svg/SVGRectElement.h:
  • svg/SVGRectElement.idl:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl:
  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::localCoordinateSpaceTransform):

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::SVGSwitchElement):

  • svg/SVGSwitchElement.h:
  • svg/SVGSwitchElement.idl:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::finishParsingChildren):

  • svg/SVGUseElement.h:
  • svg/SVGUseElement.idl:

LayoutTests:

Rebaseline js/global-constructors-attributes.html test case now that
SVGGraphicsElement is exposed on the global Window object.

  • fast/js/global-constructors-attributes-expected.txt:
  • platform/efl/fast/js/global-constructors-attributes-expected.txt:
  • platform/gtk/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
  • platform/qt/fast/js/global-constructors-attributes-expected.txt:
8:00 AM Changeset in webkit [152166] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't fire process-became-responsive callback when disconnecting it.
<​http://webkit.org/b/118166>

Reviewed by Anders Carlsson.

When disconnecting from a web process, call ResponsivenessTimer::invalidate() instead of
stop() to avoid firing the didBecomeResponsive() callback.

This lets the UI process react faster to actually unresponsive processes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):

7:52 AM WebKitIDL edited by Christophe Dumez
Update documentation for [GlobalContext] after r152100 (diff)
7:49 AM Changeset in webkit [152165] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] 100% CPU usage rendering a page with animations
​https://bugs.webkit.org/show_bug.cgi?id=117703

Reviewed by Martin Robinson.

Unconditionally update the value of m_lastFlushTime in
::flushAndRenderLayers. By doing that we avoid a neverending
sequence of layer flushes that happened when m_lastFlushTime==0
and flushPendingLayerChanges() was false. In that situation the
value m_lastFlushTime was never updated so a new flush was always
rescheduled.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::flushAndRenderLayers):

7:29 AM Changeset in webkit [152164] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping failing tests, and mathml tests because not yet supported.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-06-28

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
6:31 AM Changeset in webkit [152163] by commit-queue@webkit.org
  • 2 edits in trunk

[Autotools] Properly quote harfbuzz-icu pkg-config check
​https://bugs.webkit.org/show_bug.cgi?id=118186

Patch by Sean Bright <​sean@malleable.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.

A secondary test was added in r150963 to check for harfbuzz-icu
when it was split into two packages, but the test is not properly
quoted. If the test fails you get an error about missing
version "./configure.9.8" instead of the expected "0.9.8."

  • Source/autotools/FindDependencies.m4:
5:28 AM Changeset in webkit [152162] by gyuyoung.kim@samsung.com
  • 9 edits in trunk

Add new schemes to content utils.
​https://bugs.webkit.org/show_bug.cgi?id=118181

Reviewed by Christophe Dumez.

Source/WebCore:

According to latest content handler spec, new schemes are added to it.
Those are "geo, magnet, sip, ssh and xmpp".

​http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers

Tests: fast/dom/register-protocol-handler.html

fast/dom/unregister-protocol-handler.html

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::initProtocolHandlerWhitelist):

LayoutTests:

Add new schemes as well as change SYNTAX_ERR, SECURITY_ERR.

  • fast/dom/register-protocol-handler-expected.txt:
  • fast/dom/register-protocol-handler.html:
  • fast/dom/unregister-protocol-handler-expected.txt:
  • fast/dom/unregister-protocol-handler.html:
  • platform/efl/fast/dom/register-protocol-handler-expected.txt:
  • platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
4:14 AM Changeset in webkit [152161] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid duplicating hostWindow() call in ScrollView.cpp
​https://bugs.webkit.org/show_bug.cgi?id=118168

Patch by Sanghyup Lee <​sh53.lee@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.

Remove redundant hostWindow() calls in ScrollView.cpp.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):

4:00 AM Changeset in webkit [152160] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

[GTK] Unreviewed gardening. Unskip and reorganize tests no longer failing in GTK-WK and GTK-WK2
​https://bugs.webkit.org/show_bug.cgi?id=118180

Unreviewed GTK gardening.

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-06-28

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
3:59 AM Changeset in webkit [152159] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition
​https://bugs.webkit.org/show_bug.cgi?id=118177

Patch by Iago Toral Quiroga <​itoral@igalia.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::contentsSizeChanged):

3:18 AM Changeset in webkit [152158] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed, EFL rebaseline.

SECURITY_ERR and SYNTAX_ERR have been changed with SecurityError and SyntaxError since r135162.

  • platform/efl/fast/dom/register-protocol-handler-expected.txt:
  • platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
2:33 AM Changeset in webkit [152157] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix GTK build after r152156.

  • GNUmakefile.list.am:
1:34 AM Changeset in webkit [152156] by Christophe Dumez
  • 57 edits
    1 delete in trunk/Source/WebCore

Merge SVGLangSpace into SVGElement
​https://bugs.webkit.org/show_bug.cgi?id=118170

Reviewed by Kentaro Hara.

Remove SVGLangSpace IDL interface and move its attributes to SVGElement
to match the latest specification and simplify inheritance in SVG:

No new tests, no behavior change.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAElement.h:
  • svg/SVGAElement.idl:
  • svg/SVGCircleElement.h:
  • svg/SVGCircleElement.idl:
  • svg/SVGClipPathElement.h:
  • svg/SVGClipPathElement.idl:
  • svg/SVGDefsElement.h:
  • svg/SVGDefsElement.idl:
  • svg/SVGDescElement.h:
  • svg/SVGDescElement.idl:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::parseAttribute):

  • svg/SVGElement.h:
  • svg/SVGElement.idl:
  • svg/SVGEllipseElement.h:
  • svg/SVGEllipseElement.idl:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterElement.idl:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGGElement.h:
  • svg/SVGGElement.idl:
  • svg/SVGImageElement.h:
  • svg/SVGImageElement.idl:
  • svg/SVGLangSpace.idl: Removed.
  • svg/SVGLineElement.h:
  • svg/SVGLineElement.idl:
  • svg/SVGMarkerElement.h:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.h:
  • svg/SVGMaskElement.idl:
  • svg/SVGPathElement.h:
  • svg/SVGPathElement.idl:
  • svg/SVGPatternElement.h:
  • svg/SVGPatternElement.idl:
  • svg/SVGPolyElement.h:
  • svg/SVGPolygonElement.idl:
  • svg/SVGPolylineElement.idl:
  • svg/SVGRectElement.h:
  • svg/SVGRectElement.idl:
  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl:
  • svg/SVGStyleElement.h:
  • svg/SVGStyleElement.idl:
  • svg/SVGSwitchElement.h:
  • svg/SVGSwitchElement.idl:
  • svg/SVGSymbolElement.h:
  • svg/SVGSymbolElement.idl:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextContentElement.idl:
  • svg/SVGTitleElement.h:
  • svg/SVGTitleElement.idl:
  • svg/SVGUseElement.h:
  • svg/SVGUseElement.idl:
1:28 AM Changeset in webkit [152155] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings
​https://bugs.webkit.org/show_bug.cgi?id=117538

Patch by Andres Gomez <Andres Gomez> on 2013-06-28
Reviewed by Carlos Garcia Campos.

If the XDG specification is not working for the "Downloads"
directory, let's use HOME as fallback.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkitDownloadDecideDestination):

1:20 AM Changeset in webkit [152154] by Christophe Dumez
  • 4 edits in trunk/Source/WebCore

Use & instead of | in the value of [CallWith]
​https://bugs.webkit.org/show_bug.cgi?id=118054

Reviewed by Kentaro Hara.

[CallWith=ScriptExecutionContext|ScriptState] meant that both the
ScriptExecutionContext AND the ScriptState would be passed as
arguments to the implementation (not one OR the other).

This patch changes the semantics for those IDL extended attributes
to make it less confusing. Proper usage is now:
[CallWith=ScriptExecutionContext&ScriptState]

No new tests, covered by existing bindings tests.

  • bindings/scripts/CodeGenerator.pm:

(ExtendedAttributeContains):

  • bindings/scripts/test/TestObj.idl:
  • page/Console.idl:
12:34 AM Changeset in webkit [152153] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit2

[EFL][WK2] Add spellcheck API tests in unit tests.
​https://bugs.webkit.org/show_bug.cgi?id=118123

Patch by Dariusz Frankiewicz <Dariusz Frankiewicz> on 2013-06-28
Reviewed by Christophe Dumez.

According to discussion in bug ​https://bugs.webkit.org/show_bug.cgi?id=113742
we're moving spelling tests from layout tests to unit tests.

  • UIProcess/API/efl/tests/resources/spelling_selection_tests.html: Added.

New file is needed to make tests, with and without spellcheck attribute.
File contains basic site with content editable fields and buttons which select
different parts of misspelled words.

  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(countContextMenuItems):
Added method used to count number of items in context menu.

Note: See TracTimeline for information about the timeline view.