⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 1, 2013:

11:03 PM Changeset in webkit [152280] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC]: Fix maybe-uninitialized gcc 4.8 warning in DFGSpeculativeJIT.cpp
​https://bugs.webkit.org/show_bug.cgi?id=118278

Patch by Sergio Correia <Sergio Correia> on 2013-07-01
Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
Initialize valueGPR with InvalidGPRReg.

9:33 PM Changeset in webkit [152279] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should run LICM after AA setup
​https://bugs.webkit.org/show_bug.cgi?id=118277

Reviewed by Maciej Stachowiak.

LICM queries alias analysis. Hence, just like GVN, it should run after
we have set up the alias analysis.

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

9:07 PM Changeset in webkit [152278] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should run AA passes before GVN
​https://bugs.webkit.org/show_bug.cgi?id=118276

Rubber stamped by Geoffrey Garen.

These enable load elimination in GVN.

Immediately gives us a speed-up on a bunch of benchmarks I hacked to run
properly in the FTL. One example is 20% on imaging-gaussian-blur. (Fair
warning: the stock version of that benchmark won't see speed-ups -
probably slow-downs instead - because the FTL can't do OSR entry yet.)
Another example is the findGraphNode function, which now sees a 7%
speed-up, and that's without even doing LICM or other good things.

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

7:00 PM Changeset in webkit [152277] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
​https://bugs.webkit.org/show_bug.cgi?id=118267

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-07-01
Reviewed by Gyuyoung Kim.

After r152226 (from ​https://bugs.webkit.org/show_bug.cgi?id=117249)
WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.

  • efl/jhbuildrc:
  • gtk/jhbuildrc:
6:01 PM Changeset in webkit [152276] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Windows should be included in the list of platforms that can use OpenGL ES 2.
​https://bugs.webkit.org/show_bug.cgi?id=118264

Reviewed by Dean Jackson.

  • platform/graphics/GraphicsContext3D.h: Added PLATFORM(WIN) to platforms using OpenGL ES 2.
6:00 PM Changeset in webkit [152275] by kov@webkit.org
  • 18 edits
    14 deletes in trunk

[GTK] Remove unsupported AC backends
​https://bugs.webkit.org/show_bug.cgi?id=117362

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-07-01
Reviewed by Martin Robinson.

.:

  • Source/autotools/FindDependencies.m4: remove checks related to acceleration backend,

turn them into a check for OpenGL being available, simply.

  • Source/autotools/ReadCommandLineArguments.m4: remove command line option to select

accelerated backend, it's now auto-detected.

  • Source/autotools/SetupAutoconfHeader.m4: no longer defines USE_CLUTTER and

USE_TEXTURE_MAPPER_CAIRO.

  • Source/autotools/SetupAutomake.m4: remove checks related to acceleration backend,

turn them into a check for OpenGL being available, simply.

  • Source/autotools/Versions.m4: no longer check for clutter/clutter-gtk.

Source/WebCore:

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Source/WebCore/platform/graphics/PlatformLayer.h: Removed mentions of clutter

and the texmap cairo backend.

  • platform/graphics/clutter/DrawingBufferClutter.cpp: Removed.
  • platform/graphics/clutter/GraphicsContext3DClutter.cpp: Removed.
  • platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Removed.
  • platform/graphics/clutter/GraphicsContext3DPrivate.h: Removed.
  • platform/graphics/clutter/GraphicsLayerActor.cpp: Removed.
  • platform/graphics/clutter/GraphicsLayerActor.h: Removed.
  • platform/graphics/clutter/GraphicsLayerClutter.cpp: Removed.
  • platform/graphics/clutter/GraphicsLayerClutter.h: Removed.
  • platform/graphics/clutter/PlatformClutterAnimation.cpp: Removed.
  • platform/graphics/clutter/PlatformClutterAnimation.h: Removed.
  • platform/graphics/clutter/PlatformClutterLayerClient.h: Removed.
  • platform/graphics/clutter/TransformationMatrixClutter.cpp: Removed.
  • Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: Removed cogl

matrix type conversion.

Source/WebKit/gtk:

  • GNUmakefile.am:
  • WebCoreSupport/AcceleratedCompositingContext.h: removed clutter and cairo

additions.

  • WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Removed.
  • WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Removed.
  • webkit/webkitglobals.cpp:

(webkitInit): removed clutter-gtk initialization.

Tools:

  • gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter

and cogl, so removed.

5:45 PM Changeset in webkit [152274] by Lucas Forschler
  • 7 edits in branches/safari-537-branch/Source/WebKit2

Merged r152273. <rdar://problem/13078036>

5:08 PM Changeset in webkit [152273] by ap@apple.com
  • 7 edits in trunk/Source/WebKit2

Clean up private browsing session tracking
​https://bugs.webkit.org/show_bug.cgi?id=118266
<rdar://problem/13078036>

Reviewed by Brady Eidson.

Instead of counting API calls, we now watch actual WebPreferences objects.

  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPrivateBrowsingEnabled): Removed code that used to notify WebContext. It's now done by WebPreferences.
  • UIProcess/WebContext.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess): Instead of counting the number of times API was called, rely on WebPreferences tracking. (WebKit::WebContext::willStartUsingPrivateBrowsing): Ditto. This function is now only called when we detect a change in private browsing state. (WebKit::WebContext::willStopUsingPrivateBrowsing): Ditto. (WebKit::WebContext::createNewWebProcess): Tell the new process to create a private browsing session if needed.
  • UIProcess/WebPreferences.h:
  • UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::addPageGroup): Count how many page groups use private browsing, and notify WebContext when a session is needed. Note that we don't notify WebContext about WebPreferences without any page groups, because it's likely that preferences will be updated by the client before groups are associated. (WebKit::WebPreferences::removePageGroup): Ditto. (WebKit::WebPreferences::updateBoolValueForKey): Perform special handling for private browsing mode changes. (WebKit::WebPreferences::updatePrivateBrowsingValue): Notify WebContext when it's time to create or destroy a private browsing session. (WebKit::WebPreferences::anyPageGroupsAreUsingPrivateBrowsing): A getter for WebContext to know when any page groups are in private browsing mode.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Don't create a private browsing session implicitly, UI process takes care of it.
4:36 PM Changeset in webkit [152272] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-537-branch

Merged r152265. <rdar://problem/14301217>

4:33 PM Changeset in webkit [152271] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebKit2

Merged r152266. <rdar://problem/14301166>

4:31 PM Changeset in webkit [152270] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebKit2

Merged r152077. <rdar://problem/14270933>

4:21 PM Changeset in webkit [152269] by achristensen@apple.com
  • 4 edits in trunk/Source/WebCore

DrawingBuffer constructor and destructor were not defined for Windows.
I moved duplicate code from Cairo and Qt to DrawingBuffer.cpp to be used by Qt, Cairo, and Windows.
​https://bugs.webkit.org/show_bug.cgi?id=118262

Reviewed by Dean Jackson.

  • platform/graphics/cairo/DrawingBufferCairo.cpp: Removed duplicate DrawingBuffer constructor and destructor.
  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer): Moved from Cairo and Qt implementation.

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp: Removed duplicate DrawingBuffer constructor and destructor.
3:44 PM Changeset in webkit [152268] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed unreachable return when GLX or EGL are used with WebGL.
​https://bugs.webkit.org/show_bug.cgi?id=118263

Reviewed by Noam Rosenthal.

  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::createOffScreenContext): Fixed unreachable return.

3:23 PM Changeset in webkit [152267] by timothy@apple.com
  • 14 edits in trunk

Link to WebInspectorUI.framework at build time instead of soft linking.

​https://bugs.webkit.org/show_bug.cgi?id=118261

Reviewed by Joseph Pecoraro.

.:

  • Source/Makefile: Build WebInspectorUI before WebKit and WebKit2.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:
  • WebCoreSupport/WebInspectorClient.mm:

(useWebKitWebInspector):

Source/WebKit2:

  • Configurations/WebKit2.xcconfig:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::inspectorReallyUsesWebKitUserInterface):

Tools:

  • Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
2:47 PM Changeset in webkit [152266] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
​https://bugs.webkit.org/show_bug.cgi?id=118173
<rdar://problem/14301166>

Reviewed by Anders Carlsson.

Offset the exposed rect passed from the WKView by the main frame's current scroll position
before sending it to our TiledBackings, so that it is in the same coordinate space as their
ordinary visibleRects.

This has the side effect of making clips-to-exposed-rect testable (though useless) in Safari.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

Add updateScrolledExposedRect() and m_scrolledExposedRect.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scroll):
Call updateScrolledExposedRect when the main frame scrolls.

(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
Remove a FIXME about this change.
Call updateScrolledExposedRect instead of passing down the unscrolled rect.

(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
Call updateScrolledExposedRect, because that method will short-circuit if
setClipsToExposedRect is false, so we need to update here for correctness
if we get a setExposedRect(), setClipsToExposedRect(true) pair.

(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
Update m_scrolledExposedRect and propagate it to our TiledBackings.

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Use the scrolled exposed rect.

2:35 PM Changeset in webkit [152265] by timothy_horton@apple.com
  • 6 edits
    2 adds in trunk

Maximum scroll position can be negative in some cases
​https://bugs.webkit.org/show_bug.cgi?id=118175
<rdar://problem/14301217>

Reviewed by Anders Carlsson.

Test (API): WebKit2.ResizeReversePaginatedWebView

  • page/FrameView.cpp:

(WebCore::FrameView::maximumScrollPosition):

  • page/FrameView.h:

Override maximumScrollPosition() in FrameView and don't clamp to zero if
a reverse pagination mode is enabled, as it is possible (and common) to
have a negative maximum scroll position with reverse pagination.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):
Drive-by adoption of toIntSize().

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.

(TestWebKitAPI::didRunJavaScript):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.

Add a test that loads a vertical-lr document, paginates it horizontally
from right to left, resizes the view to fit the entire document, and
verifies that the scroll position is negative, as it must be for the
document to be enclosed by the view.

2:19 PM Changeset in webkit [152264] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152230. <rdar://problem/14306784>

2:17 PM Changeset in webkit [152263] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebCore

Merged r152204. <rdar://problem/14205335>

2:16 PM Changeset in webkit [152262] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r152200. <rdar://problem/14308488>

2:13 PM Changeset in webkit [152261] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152187. <rdar://problem/14250167>

2:12 PM Changeset in webkit [152260] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r152185. <rdar://problem/13926528>

2:10 PM Changeset in webkit [152259] by Lucas Forschler
  • 6 edits in branches/safari-537-branch/Source/WebKit2

Merged r152182. <rdar://problem/14255677>

2:09 PM Changeset in webkit [152258] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537-branch/Source/WebInspectorUI

Merged r152092. <rdar://problem/5847649>

2:07 PM Changeset in webkit [152257] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152075. <rdar://problem/14271105>

2:05 PM Changeset in webkit [152256] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152073. <rdar://problem/14194077>

2:04 PM Changeset in webkit [152255] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152072. <rdar://problem/13643935>

2:02 PM Changeset in webkit [152254] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152063. <rdar://problem/13888138>

2:00 PM Changeset in webkit [152253] by Lucas Forschler
  • 13 edits in branches/safari-537-branch/Source

Merged r152234. <rdar://problem/14083280>

1:57 PM Changeset in webkit [152252] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152231. <rdar://problem/14321403>

1:54 PM Changeset in webkit [152251] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152207. <rdar://problem/14242032>

1:53 PM Changeset in webkit [152250] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152202. <rdar://problem/14247819>

1:45 PM Changeset in webkit [152249] by adachan@apple.com
  • 2 edits in trunk/Source/WebKit2

Properly hide the header and footer banners if they are set to null.
​https://bugs.webkit.org/show_bug.cgi?id=118219

Reviewed by Beth Dakin.

Call Page::addFooterWithHeight(0) to remove the parent layer that hosts the banner when
the footer banner is detached. Similarly for the header banner.

  • WebProcess/WebPage/mac/PageBannerMac.mm:

(WebKit::PageBanner::detachFromPage):

1:43 PM Changeset in webkit [152248] by Lucas Forschler
  • 4 edits
    4 copies in branches/safari-537-branch

Merged r152198. <rdar://problem/13488092>

1:39 PM Changeset in webkit [152247] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537-branch

Merged r152196. <rdar://problem/14259249>

1:38 PM Changeset in webkit [152246] by Lucas Forschler
  • 6 edits in branches/safari-537-branch/Source/WebCore

Merged r152194. <rdar://problem/14261627>

1:36 PM Changeset in webkit [152245] by Lucas Forschler
  • 11 edits in branches/safari-537-branch/Source/WebKit2

Merged r152190. <rdar://problem/14301175>

1:34 PM Changeset in webkit [152244] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152177. <rdar://problem/14303613>

1:33 PM Changeset in webkit [152243] by Lucas Forschler
  • 8 edits in branches/safari-537-branch/Source/WebCore

Merged r152117. <rdar://problem/14278960>

1:30 PM Changeset in webkit [152242] by Lucas Forschler
  • 4 edits in branches/safari-537-branch

Merged r152091. <rdar://problem/12679475>

1:07 PM Changeset in webkit [152241] by Lucas Forschler
  • 14 edits
    1 copy in branches/safari-537-branch/Source

Merged r152065. <rdar://problem/10055712>

12:48 PM Changeset in webkit [152240] by achristensen@apple.com
  • 8 edits in trunk/Source/WebCore

Removed all references to DrawingBuffer methods unused since the removal of Chromium:
DrawingBuffer::prepareBackBuffer,
DrawingBuffer::requiresCopyFromBackToFrontBuffer, and
DrawingBuffer::clearPlatformLayer.
​https://bugs.webkit.org/show_bug.cgi?id=118257

Reviewed by Darin Adler.

  • platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:

(WebCore::DrawingBuffer::platformLayer):

  • platform/graphics/cairo/DrawingBufferCairo.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/clutter/DrawingBufferClutter.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::clear):

  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::frontColorBuffer):

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

12:33 PM Changeset in webkit [152239] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build correction.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Need to export tag for textarea element.
12:24 PM Changeset in webkit [152238] by jochen@chromium.org
  • 30 edits in trunk/Source

Remove support for consumable user gestures
​https://bugs.webkit.org/show_bug.cgi?id=118247

Reviewed by Geoffrey Garen.

Source/WebCore:

The features was not enabled on any port, and is meanwhile broken, so we
should delete it.

No new tests, just deleting dead code.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeScript):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeScriptInWorld):

  • dom/UserGestureIndicator.cpp:

(WebCore::isDefinite):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):

  • dom/UserGestureIndicator.h:

(WebCore::UserGestureIndicator::processingUserGesture):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::openInNewTab):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::FrontendMenuProvider::contextMenuItemSelected):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::navigate):

  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledURLNavigation::didStartTimer):
(WebCore::ScheduledRedirect::fire):
(WebCore::ScheduledRefresh::fire):
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
(WebCore::ScheduledFormSubmission::didStartTimer):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):

  • page/DOMTimer.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::showModalDialog):

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • page/EventHandler.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::toggleMediaFullscreenState):
(WebCore::HitTestResult::enterFullscreenForVideo):

Source/WebKit/blackberry:

  • WebKitSupport/NotificationManager.cpp:

(BlackBerry::WebKit::NotificationManager::notificationClicked):

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::evaluate):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView sendEvent:isDrawRect:]):

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::notificationClicked):

Source/WebKit/win:

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

Source/WebKit2:

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::didClickNotification):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performFrameLoadURLRequest):
(WebKit::PluginView::evaluate):

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

12:14 PM Changeset in webkit [152237] by Lucas Forschler
  • 12 edits in branches/safari-537-branch/Source

Merged r151978. <rdar://problem/14102739>

11:54 AM Changeset in webkit [152236] by benjamin@webkit.org
  • 1 edit
    2 adds in trunk/Websites/webkit.org

Add screenshot of the inspector color picker for the blog

  • blog-files/last-week-in-webkit: Added.
  • blog-files/last-week-in-webkit/Inspector_color_picker.png: Added.
11:41 AM Changeset in webkit [152235] by commit-queue@webkit.org
  • 14 edits
    8 adds in trunk

Add Support for mspace element
​https://bugs.webkit.org/show_bug.cgi?id=115610

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-07-01
Reviewed by Chris Fleizach.

Source/WebCore:

This patch adds basic support for the MathML mspace element. This is
important to let people control spacing of mathematical formulas.
Attributes width, height and depth are implemented. For the moment,
only nonnegative width are accepted.

  • CMakeLists.txt: add references to the RenderMathMLSpace files.
  • GNUmakefile.list.am: ditto.
  • Target.pri: ditto.
  • WebCore.vcxproj/WebCore.vcxproj: ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • css/mathml.css:

(mtable[columnlines="dashed"] > mtr > mtd + mtd): remove the obsolete linebreaking rule.

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::createRenderer): map mspaceTag to RenderMathMLSpace.

  • mathml/mathattrs.in: add width, height and depth attributes
  • mathml/mathtags.in: add mspace element
  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::parseMathMLLength): fix int to float conversion.

  • rendering/mathml/RenderMathMLBlock.h: declare isRenderMathMLSpace.

(WebCore::RenderMathMLBlock::isRenderMathMLSpace):

  • rendering/mathml/RenderMathMLSpace.cpp: Added.

(WebCore::RenderMathMLSpace::RenderMathMLSpace):
(WebCore::RenderMathMLSpace::isChildAllowed):
(WebCore::RenderMathMLSpace::computePreferredLogicalWidths):
(WebCore::RenderMathMLSpace::updateFromElement):
(WebCore::RenderMathMLSpace::updateLogicalWidth):
(WebCore::RenderMathMLSpace::updateLogicalHeight):
(WebCore::RenderMathMLSpace::layout):
(WebCore::RenderMathMLSpace::styleDidChange):
(WebCore::RenderMathMLSpace::firstLineBoxBaseline):

  • rendering/mathml/RenderMathMLSpace.h: Added.

(WebCore::RenderMathMLSpace::isRenderMathMLSpace):
(WebCore::RenderMathMLSpace::renderName):
(WebCore::toRenderMathMLSpace):

LayoutTests:

Add a reftest for the mspace element (width, height and depth) and
the parsing of MathML lengths. Import a reftest from Gecko to check
positive namedspace values.

  • mathml/presentation/mspace-expected.html: Added.
  • mathml/presentation/mspace-units-expected.html: Added.
  • mathml/presentation/mspace-units.html: Added.
  • mathml/presentation/mspace.html: Added.
  • mathml/presentation/positive-namedspace-expected.html: Added.
  • mathml/presentation/positive-namedspace.html: Added.
11:40 AM Changeset in webkit [152234] by jer.noble@apple.com
  • 13 edits in trunk/Source

Audio in apps which embed WebViews is corrupted.
​https://bugs.webkit.org/show_bug.cgi?id=118163

Reviewed by Maciej Stachowiak.

Source/WebCore:

Add a preference, which defaults to off, which controls whether the
AudioSessionManager will switch to a large audio buffer setting for
power-savings during <video> playback.

  • WebCore.exp.in:
  • page/Settings.cpp:

(WebCore::Settings::setLowPowerVideoAudioBufferSizeEnabled): Added. Simple setter.

  • page/Settings.h:

(WebCore::Settings::lowPowerVideoAudioBufferSizeEnabled): Added. Simple getter.

  • platform/audio/mac/AudioSessionManagerMac.cpp:

(AudioSessionManager::updateSessionState): Only set the large audio buffer

size if lowPowerVideoAudioBufferSize is enabled.

Source/WebKit/mac:

Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit clients.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences lowPowerVideoAudioBufferSizeEnabled]):
(-[WebPreferences setLowPowerVideoAudioBufferSizeEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit2 clients.

  • Shared/WebPreferencesStore.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

11:12 AM Changeset in webkit [152233] by Brent Fulgham
  • 2 edits in trunk/WebKitLibraries

[Windows] Unreviewed correction to DEBUG_ALL target. Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
which prevented proper build operation.

  • win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL

macros when building with 'debugsuffix' target.

11:04 AM Changeset in webkit [152232] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[ATK] Leak: leaks in WebKitAccessibleInterfaceText
​https://bugs.webkit.org/show_bug.cgi?id=118248

Fixed memory leaks.

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-01
Reviewed by Christophe Dumez.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getPangoLayoutForAtk):
(webkitAccessibleTextGetText):

10:53 AM Changeset in webkit [152231] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's.
<rdar://problem/14321403>

  • WebCore.vcxproj/WebCore.make:
10:45 AM Changeset in webkit [152230] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

WKPageLoadDataWithUserData neglects to set the base URL that is passed in
<rdar://problem/14306784>
​https://bugs.webkit.org/show_bug.cgi?id=118256

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadData):
Pass the baseURL, not blankURL(), and remove an unnecessary multiplication by sizeof(uint8_t) which is always 1.

9:47 AM Changeset in webkit [152229] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[Curl] WebDownload init method is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=118241

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.

The WebDownload::init() method called when a normal load is changed to a download
because of a decision by the policy delegate, is not implemented for Curl.

  • WebDownloadCurl.cpp:

(WebDownload::init): Implement init() method.

9:38 AM Changeset in webkit [152228] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Win] Crash when scrolling page with images.
​https://bugs.webkit.org/show_bug.cgi?id=117832

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.

Avoid access violation by returning early from method if image frame doesn't have pixel data.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::hasPixelData): Added method to check if frame has pixel data.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::haveDecodedRow): Early return if frame doesn't have pixel data.

9:32 AM Changeset in webkit [152227] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Avoid calling RenderLayerBacking::resetContentsRect() if possible
​https://bugs.webkit.org/show_bug.cgi?id=118217

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-07-01
Reviewed by Simon Fraser.

Call resetContentsRect() only if the layer has a contentsLayer.
Otherwise the contentsRect is redundant for the GraphicsLayer.

No new tests - optimization only. This is covered by plenty of existing
tests in webgl/ and compositing/.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore::GraphicsLayerTextureMapper::hasContentsLayer):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Added hasContentsLayer calls for TextureMapper/CoordinatedGraphics

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

9:25 AM Changeset in webkit [152226] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

[EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
​https://bugs.webkit.org/show_bug.cgi?id=117249

Patch by Raphael Kubo da Costa <​raphael.kubo.da.costa@intel.com> on 2013-07-01
Reviewed by Brent Fulgham.

Finish converting all use cases of WEBKITOUTPUTDIR to
WEBKIT_OUTPUTDIR, which seems to be preferred these days.

  • DumpRenderTree/efl/FontManagement.cpp:

(getCustomBuildDir):
(getPlatformFontsPath):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(getOutputDir):

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):
(usesPerConfigurationBuildDirectory):

  • Scripts/webkitpy/port/base.py:

(Port.to.setup_environ_for_server):

  • Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server):

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::getOutputDir):

  • jhbuild/jhbuildutils.py:

(get_dependencies_path):

8:39 AM Changeset in webkit [152225] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Fix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h
​https://bugs.webkit.org/show_bug.cgi?id=118242

Reviewed by Mark Hahnenberg.

  • heap/HandleBlockInlines.h:

(JSC::HandleBlock::nodes):

8:29 AM Changeset in webkit [152224] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Tools

Unreviewed change of my email address.

  • Scripts/webkitpy/common/config/contributors.json:
7:36 AM Changeset in webkit [152223] by timothy_horton@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Un-break the WebCore ChangeLog after ​http://trac.webkit.org/changeset/152219.

7:29 AM Changeset in webkit [152222] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=118244

Reviewed by Noam Rosenthal.

In Qt 5.0 we had to create invisible windows, but in Qt 5.1
we can now create specific offscreen surfaces.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):

6:31 AM Changeset in webkit [152221] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping unsupported tests.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-07-01

  • platform/qt/TestExpectations:
6:29 AM Changeset in webkit [152220] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Remove long unused Qt4 forward definitions

Unreviewed cleanu-up.

  • platform/graphics/GraphicsContext3D.h:
6:27 AM Changeset in webkit [152219] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Use DeferrableOneShotTimer for deleting decoded data
​https://bugs.webkit.org/show_bug.cgi?id=118150

Reviewed by Andreas Kling.

Adam Barth pointed out that the virtual function for overriding the default delay doesn't work
as expected from base class constructor.

  • loader/cache/CachedResource.cpp:

(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::CachedResource):

Use static function instead of calling a virtual.

  • loader/cache/CachedResource.h:
  • loader/cache/CachedScript.cpp:
  • loader/cache/CachedScript.h:
3:43 AM Changeset in webkit [152218] by kangil.han@samsung.com
  • 26 edits in trunk/Source

Adopt toHTMLTextAreaElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=118226

Reviewed by Andreas Kling.

To enhance readability, this patch adopts toHTMLTextAreaElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::text):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendText):

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

  • html/HTMLTextAreaElement.h:

(WebCore::toHTMLTextAreaElement):

  • page/FocusController.cpp:

(WebCore::clearSelectionIfNeeded):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::isContentEditable):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):
(WebCore::RenderTextControlMultiLine::computeControlLogicalHeight):

  • testing/Internals.cpp:

(WebCore::Internals::wasLastChangeUserEdit):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textDidChangeInTextArea):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):

Source/WebKit2:

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::createAnnotationElement):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::textDidChangeInTextArea):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormControls):

1:44 AM Changeset in webkit [152217] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add missing string headers that are used when LOG_DISABLED is 0.
​https://bugs.webkit.org/show_bug.cgi?id=118227

Patch by Kwang Yul Seo <​skyul@company100.net> on 2013-07-01
Reviewed by Andreas Kling.

Build fix for LOG_DISABLED=0.

No new tests, no behavior change.

  • html/track/InbandTextTrack.cpp:
  • rendering/RenderLayerCompositor.cpp:
1:44 AM Changeset in webkit [152216] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Use PassOwnPtr for the returned value of createBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=118230

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-07-01
Reviewed by Andreas Kling.

It would be better that createBackingStore returns PassOwnPtr instread of OwnPtr
to keep compatibility with c++0x.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::createBackingStore):

1:10 AM Applications using WebKit edited by alexandre.morgaut@4d.com
Wakanda server updates (diff)
12:11 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)

Jun 30, 2013:

10:30 AM Changeset in webkit [152215] by zandobersek@gmail.com
  • 5 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure expectations for other current failures.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/editing/selection/user-select-all-image-with-single-click-expected.txt: Added.
  • platform/gtk/editing/selection/user-select-all-with-single-click-expected.txt: Added.
  • platform/gtk/fast/events/ondragenter-expected.txt: Added.
  • platform/gtk/fast/js/global-constructors-attributes-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
Note: See TracTimeline for information about the timeline view.