Timeline
Jul 7, 2013:
- 11:52 PM Changeset in webkit [152440] by
-
- 22 edits in trunk/Source/WebCore
Adopt is/toHTMLTableElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118393
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLTableElement.
This also helps out to reduce duplicated use of static_cast.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::title):
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetCaption):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetDescription):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- dom/Position.cpp:
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
- editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
- editing/htmlediting.cpp:
(WebCore::isNonTableCellHTMLBlockElement):
- editing/markup.cpp:
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLTableElement.h:
(WebCore::isHTMLTableElement):
(WebCore::toHTMLTableElement):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::findParentTable):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::virtualItemAfter):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
- platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _computedStringForNode:property:]):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
- 9:40 PM Changeset in webkit [152439] by
-
- 12 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Graph::clearAndDerefChild() makes no sense anymore, and neither does Nop
https://bugs.webkit.org/show_bug.cgi?id=118452
Reviewed by Sam Weinig.
Noticed that ArgumentsSimplificationPhase was converting something to a Nop and then
resetting its children using clearAndDerefChild(). Using Nop instead of Phantom is a
holdover from back when we needed a no-MustGenerate no-op. We don't anymore. Using
clearAndDerefChild() was necessary back when we did eager reference counting. We
don't need to do that anymore, and in fact clearAndDerefChild() appeared to not do
any reference counting, so it was badly named to begin with.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Jul 6, 2013:
- 11:46 PM Changeset in webkit [152438] by
-
- 2 edits in trunk/Source/WTF
Fix the performance regressions introduced by r152418
https://bugs.webkit.org/show_bug.cgi?id=118438
Reviewed by Sam Weinig.
- wtf/text/StringImpl.h:
(WTF::equal):
Looping between two arbitrary pointers prevents important loop
optimizations.
- 1:08 PM Changeset in webkit [152437] by
-
- 10 edits in trunk
createElement("image") creates an HTMLImageElement, although this hack should exist in parser only
https://bugs.webkit.org/show_bug.cgi?id=88360
Reviewed by Sam Weinig.
Source/WebCore:
Create a HTMLElement when using createElement('image'), but keep the HTML5 parser constructing HTMLImageelement for it.
- html/HTMLTagNames.in:
LayoutTests:
Update tests to reflect new behavior. This matches FireFox and Opera 12.
- fast/canvas/webgl/context-lost.html:
- fast/dom/prefixed-image-tag-expected.txt:
- fast/dom/prefixed-image-tag.xhtml:
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- 10:12 AM Changeset in webkit [152436] by
-
- 3 edits in trunk/Tools
Update list of EFL WK2 API tests
https://bugs.webkit.org/show_bug.cgi?id=118443
Patch by Sergio Correia <Sergio Correia> on 2013-07-06
Reviewed by Christophe Dumez.
The following tests were included:
Passing:
- CloseThenTerminate
- DidAssociateFormControls
- PageVisibilityState
- ResponsivenessTimerDoesntFireEarly
- TerminateTwice
- WillLoad
Failing:
- ResizeReversePaginatedWebView
- ScrollPinningBehaviors
This patch also modified
test_webkit2_api_BINARIES list so that it is in
alphabetical order.
- TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
- TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
- 12:24 AM Changeset in webkit [152435] by
-
- 2 edits in trunk/Source/WebCore
Stop hardcoding interfaces that have indexed getters returning strings
https://bugs.webkit.org/show_bug.cgi?id=118414
Reviewed by Kentaro Hara.
Stop hardcoding the names of interfaces that have indexed getters returning
strings in the bindings generator. Now that we use the latest Web IDL indexed
getter, more information is provided in the IDL files and the generator is
able to figure out if the indexed getter is returning a DOMString on its own.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
