Timeline
Jul 8, 2013:
- 11:46 PM Changeset in webkit [152484] by
-
- 2 edits in trunk/Tools
KURL unit test fixture class should have a meaningful name
https://bugs.webkit.org/show_bug.cgi?id=118467
Reviewed by Sam Weinig.
- TestWebKitAPI/Tests/WebCore/KURL.cpp:
(TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
instead of the generic and inappropriate 'WebCore' name.
- 10:39 PM Changeset in webkit [152483] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] webkit_set_cache_model is not turning the cache off
https://bugs.webkit.org/show_bug.cgi?id=118345
Reviewed by Gustavo Noronha Silva.
Our documentation says that WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER
disables the cache completely, but we are only setting the cache
capacities to 0. Cache capacities are not checked when resources
are added to the cache, but when it's pruned. To disable the cache
we need to call MemoryCache::setDisabled explicitly.
- webkit/webkitglobals.cpp:
(webkit_set_cache_model): Disable the cache when min dead, max
dead and total capacities are all set to 0.
- 10:21 PM Changeset in webkit [152482] by
-
- 2 edits in trunk
Add WebInspectorUI to WebKit.xcworkspace
https://bugs.webkit.org/show_bug.cgi?id=118491
Reviewed by Sam Weinig.
- WebKit.xcworkspace/contents.xcworkspacedata:
- 10:08 PM Changeset in webkit [152481] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
NaturalLoops + Profiler = Crash
https://bugs.webkit.org/show_bug.cgi?id=118486
Reviewed by Geoffrey Garen.
I borked dominators in:
http://trac.webkit.org/changeset/152431/branches/dfgFourthTier/Source/JavaScriptCore/dfg/DFGDominators.h
This patch also adds some debug support, and fixes the loop that adds a block to
an already-existing natural loop. Note that we currently don't take that path in
most programs, but it will arise, for example if you use 'continue' - though you'd
have to use it rather cleverly since the bytecode will not jump to the loop header
in most uses of 'continue'.
- dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::dump):
(DFG):
- dfg/DFGDominators.h:
(JSC::DFG::Dominators::dominates):
(Dominators):
- dfg/DFGNaturalLoops.cpp:
(JSC::DFG::NaturalLoops::compute):
- 8:22 PM Changeset in webkit [152480] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG::AbstractState::beginBasicBlock() should set m_haveStructures if any of the valuesAtHead have either a current known structure or a non-top/non-bottom array modes
https://bugs.webkit.org/show_bug.cgi?id=118489
Reviewed by Mark Hahnenberg.
- bytecode/ArrayProfile.h:
(JSC::arrayModesAreClearOrTop):
(JSC):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::hasClobberableState):
(AbstractValue):
- 8:09 PM Changeset in webkit [152479] by
-
- 83 edits in trunk
[CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}
https://bugs.webkit.org/show_bug.cgi?id=103336
Reviewed by Tony Chang.
Source/WebCore:
Rename -webkit-grid-{rows|columns} to -webkit-grid-definition-{rows|columns}.
The latest version of the spec has renamed these properties.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle the new names.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Ditto.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): Ditto.
- css/CSSPropertyNames.in: Add support for the new names.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): Handle the new names.
LayoutTests:
Update tests to reflect the rename of -webkit-grid-{rows|columns} to
-webkit-grid-definition-{rows|columns}.
- fast/css-grid-layout: Mass search and replace for the new name.
- 7:48 PM Changeset in webkit [152478] by
-
- 4 edits2 adds in trunk
DeleteSelectionCommand does not handle correctly deletion with two consecutive BR element.
https://bugs.webkit.org/show_bug.cgi?id=118457
<rdar://problem/14160912>
Reviewed by Simon Fraser.
Source/WebCore:
In DeleteSelectionCommand::handleSpecialCareBRDelete we did not
handle correctly the case where we had <br><br> in the markup and
nothing was being deleted. We should consider this like
the case where the <br> is on the line by itself and remove it.
Test: editing/deleting/delete-image-followed-by-two-br.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
LayoutTests:
- editing/deleting/delete-image-followed-by-two-br-expected.txt: Added.
- editing/deleting/delete-image-followed-by-two-br.html: Added.
- platform/mac/editing/deleting/delete-br-002-expected.txt: Rebased.
- 6:07 PM Changeset in webkit [152477] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
CheckArray should call the right version of filterArrayModes
https://bugs.webkit.org/show_bug.cgi?id=118488
Reviewed by Filip Pizlo.
Currently in the CFA CheckArray doesn't call the right filterArrayMode which can cause
the CFA to ignore when it sees a contradiction.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- 5:31 PM Changeset in webkit [152476] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152315. <rdar://problem/13895483>
- 5:30 PM Changeset in webkit [152475] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Updating fast/js/global-constructors-attributes.html results.
- fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- 5:28 PM Changeset in webkit [152474] by
-
- 6 edits3 copies in branches/safari-537-branch
Merged r152303. <rdar://problem/14301271>
- 5:20 PM Changeset in webkit [152473] by
-
- 14 edits in branches/safari-537-branch
Merged r152267. <rdar://problem/14205300>
- 4:47 PM Changeset in webkit [152472] by
-
- 8 edits1 copy in branches/safari-537-branch/Source
Merged r152052. <rdar://problem/14351519>
- 4:41 PM Changeset in webkit [152471] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Merge r152470.
2013-07-08 Alexey Proskuryakov <ap@apple.com>
[Mac] Multiple compositing/patterns test fail
https://bugs.webkit.org/show_bug.cgi?id=118490
- platform/mac/TestExpectations: The failures appear to be WK2 only in my testing, so moved the expectations to mac-wk2.
- platform/mac-wk2/TestExpectations: Updated bug numbers.
- 4:36 PM Changeset in webkit [152470] by
-
- 3 edits in trunk/LayoutTests
[Mac] Multiple compositing/patterns test fail
https://bugs.webkit.org/show_bug.cgi?id=118490
- platform/mac/TestExpectations: The failures appear to be WK2 only in my testing, so moved the expectations to mac-wk2.
- platform/mac-wk2/TestExpectations: Updated bug numbers.
- 4:32 PM Changeset in webkit [152469] by
-
- 3 edits2 deletes in branches/safari-537-branch
Rollout of r151510. <rdar://problem/14380353>
- 4:02 PM Changeset in webkit [152468] by
-
- 4 edits in branches/safari-537-branch/Source
Merged r152306. <rdar://problem/14284360>
- 3:57 PM Changeset in webkit [152467] by
-
- 2 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r152314. <rdar://problem/14165332>
- 2:24 PM Changeset in webkit [152466] by
-
- 14 edits2 adds in trunk
NamedFlowCollection getters should return undefined when there's no NamedFlow
https://bugs.webkit.org/show_bug.cgi?id=118463
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-08
Reviewed by Christophe Dumez.
Source/WebCore:
Added new TreatReturnedNullObjectAs attribute for generated methods and set it to Undefined
for the item and namedItem methods of DOMNamedFlowCollection.
Test: fast/regions/webkit-named-flow-collection-undefined.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementationFunctionCall):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::treatReturnedNullObjectAsUndefined):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_treat_returned_null_object_as_undefined):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTreatReturnedNullObjectAsUndefined):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj treatReturnedNullObjectAsUndefined]):
- bindings/scripts/test/TestObj.idl:
- dom/DOMNamedFlowCollection.idl:
LayoutTests:
Added test that validates that NamedFlowCollection getters return undefined
when no named flows exist.
- fast/regions/webkit-named-flow-collection-undefined-expected.txt: Added.
- fast/regions/webkit-named-flow-collection-undefined.html: Added.
- 2:05 PM Changeset in webkit [152465] by
-
- 3 edits in trunk/Source/WebCore
Remove unused variables in FocusCandidate.
https://bugs.webkit.org/show_bug.cgi?id=118449
Patch by Changhun Kang <temoochin@company100.net> on 2013-07-06
Reviewed by Antonio Gomes.
The variables for parent in FocusCandidate are not used anymore.
No new tests. No change in behavior.
- page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
- page/SpatialNavigation.h:
(WebCore::FocusCandidate::FocusCandidate):
- 2:03 PM Changeset in webkit [152464] by
-
- 2 edits in trunk/Source/WebCore
AX: iOS: SVG paths are not offset by the parent bounding box
https://bugs.webkit.org/show_bug.cgi?id=118433
The path for SVG shapes is in terms of its parent's view space. We need to offset
the path by that amount so that it's in the right location.
Reviewed by Tim Horton.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementPath):
- 1:02 PM Changeset in webkit [152463] by
-
- 3 edits in trunk/LayoutTests
fast/repaint/fixed-right-in-page-scale.html also crashing on Mountain Lion.
https://bugs.webkit.org/show_bug.cgi?id=118479
Moved expectation to higher-level mac and marked as [ Pass Crash ].
- platform/mac-lion/TestExpectations:
- platform/mac/TestExpectations:
- 12:46 PM Changeset in webkit [152462] by
-
- 2 edits in trunk/LayoutTests
Mark fast/text/international/synthesized-italic-vertical-latin.html as failing on Lion.
https://bugs.webkit.org/show_bug.cgi?id=118480
Unreviewed TestExpectation change.
- platform/mac-lion/TestExpectations:
Mark fast/text/international/synthesized-italic-vertical-latin.html as Failure.
- 12:15 PM Changeset in webkit [152461] by
-
- 2 edits in trunk/LayoutTests
Skip fast/repaint/fixed-right-in-page-scale.html on Lion.
https://bugs.webkit.org/show_bug.cgi?id=118479
Unreviewed: test marked as crashing.
- platform/mac-lion/TestExpectations:
Skip fast/repaint/fixed-right-in-page-scale.html.
- 11:57 AM Changeset in webkit [152460] by
-
- 6 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing header files.
Source/WebCore:
- GNUmakefile.list.am: Add missing header files.
Source/WTF:
- GNUmakefile.list.am: Add missing header files.
- 11:33 AM Changeset in webkit [152459] by
-
- 2 edits in trunk/Source/WebCore
Fix TextTrackCue::cueIndex() to handle the null case of TextTrack::cues(() properly
https://bugs.webkit.org/show_bug.cgi?id=117815
<rdar://problem/14211041>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-08
Reviewed by Eric Carlson.
Merge https://src.chromium.org/viewvc/blink?revision=153206&view=revision
No new tests, only behavior change is preventing a crash in the release build.
cueIndex() is only used for sorting cues, so returning an invalidCueIndex in the case
where track()->cues() is null makes sense and won't modify behavior.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::cueIndex):
- 11:16 AM Changeset in webkit [152458] by
-
- 15 edits2 copies in branches/safari-537-branch
Merged r151737. <rdar://problem/14294837>
- 10:19 AM Changeset in webkit [152457] by
-
- 1 edit1 move in branches/safari-537-branch/LayoutTests
Merge r151913.
2013-06-24 Brent Fulgham <Brent Fulgham>
[Mac] Unreviewed build correction after r151868
New test expecation had been placed in the wrong directory.
- platform/mac/accessibility/listitem-title-expected.txt: Copied from platform/mac/listitem-title-actual.txt.
- platform/mac/listitem-title-actual.txt: Removed.
- 10:07 AM Changeset in webkit [152456] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r152416.
http://trac.webkit.org/changeset/152416
https://bugs.webkit.org/show_bug.cgi?id=118476
Wrong fix for the bug (Requested by ap on #webkit).
- platform/text/TextEncodingRegistry.cpp:
(WebCore::newTextCodec):
- 9:57 AM WebKitIDL edited by
- Added TreatReturnedNullObjectAs attribute. (diff)
- 8:57 AM Changeset in webkit [152455] by
-
- 2 edits in trunk
[GTK] Acceleration description isn't displayed in configured options.
https://bugs.webkit.org/show_bug.cgi?id=118441
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-07-08
Reviewed by Gustavo Noronha Silva.
The acceleration_backend_description has been changed to acceleration_description from r152275.
- Source/autotools/PrintBuildConfiguration.m4:
- 8:54 AM Changeset in webkit [152454] by
-
- 2 edits in trunk
[Autoconf] Define WTF_USE_OPENGL when OpenGL was found
https://bugs.webkit.org/show_bug.cgi?id=118341
Reviewed by Gustavo Noronha Silva.
After r152275, WTF_USE_OPENGL is only defined if the accelerated compositing is enabled.
This breaks the build if disabling the accelerated compositing feature as the OpenGL-specific
code is not compiled anymore even if it's still required.
To avoid that, WTF_USE_OPENGL should be defined if OpenGL was found. The accelerated compositing
feature also relies on this condition, exiting the configuration process with an error otherwise.
- Source/autotools/SetupAutoconfHeader.m4:
- 8:53 AM Changeset in webkit [152453] by
-
- 9 edits2 adds in trunk
REGRESSION(r125294): A style rule with more than 8192 selectors can cause style corruption.
<http://webkit.org/b/118369>
<rdar://problem/14291428>
Reviewed by Antti Koivisto.
Source/WebCore:
Add a semi-hard cap of 8192 selectors per CSS rule. Rules with longer selector lists will be split into
multiple rules (with 8192 selectors per rule.) The style properties are shared behind the scenes
so it's all pretty efficient.
This does generate a different CSSOM for gigantic selector lists, I've added a test to document this.
Note that setting CSSStyleRule.selectorText with over 8192 selectors will now fail, the splitting into
multiple rules only happens when parsing full style sheets.
Test: fast/css/rule-selector-overflow.html
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::selectorCount):
Add a helper to count the number of selectors in a list (not the number of raw selector components.)
- css/RuleSet.h:
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
Add RuleData::maximumSelectorCount constant and cap CSSStyleRule.selectorText to that many selectors.
- css/CSSSelectorList.h:
(WebCore::CSSSelectorList::adoptSelectorArray):
- css/StyleRule.cpp:
(WebCore::StyleRule::create):
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorCount):
- css/StyleRule.h:
(WebCore::StyleRule::parserAdoptSelectorArray):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAppendRule):
The meat of this change. Split rules with >8K selectors into multiple rules with 8K selectors in each.
- css/StyleRule.h:
(WebCore::toStyleRule):
Added a toStyleRule() helper for good measure.
LayoutTests:
Added a test to document the new cap of 8192 selectors per CSS rule.
- fast/css/rule-selector-overflow-expected.txt: Added.
- fast/css/rule-selector-overflow.html: Added.
- 8:37 AM Changeset in webkit [152452] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Block Zoom does not zoom in on narrow paragraphs properly
https://bugs.webkit.org/show_bug.cgi?id=118472
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-07-08.
Reviewed by Rob Buis.
Internally reviewed Arvid Nilsson and Genevieve Mak.
JIRA 114653
For the narrow paragraphs on www.nytimes.com, the first best node for
block zoom under the point is deprecated due to the limits of maximum
block zoom scale(3) and default maximum WebPage zoom scale(4) and instead
it picks up an ancestor node which is wider so that it looks like doesn't
zoom in properly.
To fix that, enlarge the default maximum WebPage zoom scale slightly
and use maximumScale() instead of maxBlockZoomScale() so that we can
accept more nodes. And also we'll still clamp the new scale by
maxBlockZoomScale() when we block zoom the WebPage, in which way those
nodes can be showed in the center of the viewport and surrounded by a
few other nodes within the viewport which shows better user experience.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::maximumScale):
(BlackBerry::WebKit::WebPagePrivate::adjustedBlockZoomNodeForZoomAndExpandingRatioLimits):
- 8:36 AM Changeset in webkit [152451] by
-
- 4 edits in trunk/Source/WebCore
Introduce DECLARE_FORWARDING_ATTRIBUTE_EVENT_LISTENER() macro
https://bugs.webkit.org/show_bug.cgi?id=118408
Reviewed by Philip Rogers.
Split DEFINE_FORWARDING_ATTRIBUTE_EVENT_LISTENER() macro into separate
DECLARE and DEFINE macros to reduce the number of header includes in
SVG.
No new tests, no behavior change.
- dom/EventTarget.h:
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::create):
(WebCore::SVGElementInstance::toNode):
(WebCore::SVGElementInstance::ownerDocument):
- svg/SVGElementInstance.h:
- 7:12 AM Changeset in webkit [152450] by
-
- 2 edits in trunk/Source/WebCore
[Coordinated Graphics] Rename variables in UpdateAtlas
https://bugs.webkit.org/show_bug.cgi?id=118403
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-08
Reviewed by Noam Rosenthal.
As of r149292, non-composited contents layer was removed from
CoordinatedGraphics. So, the variables should be renamed for
clarification.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- 6:22 AM Changeset in webkit [152449] by
-
- 4 edits1 add in trunk
Add Deque::removeLast
https://bugs.webkit.org/show_bug.cgi?id=118466
Source/WTF:
Reviewed by Andreas Kling.
Deque can remove both the first and the last element efficiently.
Test: TestWebKitAPI/Tests/WTF/Deque.cpp
- wtf/Deque.h:
(WTF::::takeLast):
(WTF::::removeLast):
Tools:
Reviewed by Andreas Kling.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
(TestWebKitAPI::TEST):
- 5:56 AM Changeset in webkit [152448] by
-
- 3 edits in trunk/Source/WebCore
[Qt] Incremental build fix after r145712.
https://bugs.webkit.org/show_bug.cgi?id=112576.
Reviewed by Jocelyn Turcotte.
- DerivedSources.pri: Added dependence to INSPECTOR_JSON.
- inspector/front-end/WebKit.qrc: Added missing JS file.
- 3:22 AM Changeset in webkit [152447] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=118462
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-08
- platform/gtk/TestExpectations: Skip media/track/track-legacyapi-with-automatic-mode.html
and mark media/media-element-play-after-eos.html as flaky.
- 3:13 AM Changeset in webkit [152446] by
-
- 3 edits in trunk/Source
[GTK] FrameLoaderClient: Refactor naked pointers to use smart pointers
https://bugs.webkit.org/show_bug.cgi?id=118417
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-08
Reviewed by Carlos Garcia Campos.
Use GOwnPtr and GRefPtr where possible.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFailLoad):
- 2:02 AM Changeset in webkit [152445] by
-
- 2 edits in trunk/Source/WTF
[Qt][Windows] Buildfix after r152426.
Reviewed by Csaba Osztrogonác.
- wtf/Platform.h: Do not include WTFHeaderDetection.h on Qt build.
- 2:00 AM Changeset in webkit [152444] by
-
- 2 edits in trunk/Tools
[GTK] Leak: GFile* leaking in beginDragWithFilesCallback
https://bugs.webkit.org/show_bug.cgi?id=118412
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-08
Reviewed by Martin Robinson.
An adoptRef is required to balance ref and deref calls.
- DumpRenderTree/gtk/EventSender.cpp:
(beginDragWithFilesCallback):
- 1:37 AM Changeset in webkit [152443] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=118453
Added new baseline for EFL after r151841
Patch by Krzysztof Czech <k.czech@ymail.com> on 2013-07-08
- platform/efl/accessibility/aria-tab-role-on-buttons-expected.txt: Added.
- 1:19 AM Changeset in webkit [152442] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Runtime critical warning when unloading a module that failed to load
https://bugs.webkit.org/show_bug.cgi?id=118425
Reviewed by Martin Robinson.
- Platform/gtk/ModuleGtk.cpp:
(WebKit::Module::load): Show an error message when the module
fails to load.
(WebKit::Module::unload): Check module pointer before calling
unload method.
- 12:39 AM Changeset in webkit [152441] by
-
- 10 edits in trunk
vibrate function have to return boolean value.
https://bugs.webkit.org/show_bug.cgi?id=118288
Reviewed by Gyuyoung Kim.
Source/WebCore:
According to latest Vibration API which is LC, vibrate() needs to return boolean value
and exception code is removed also. In addition, remove condition for canceling vibration
can be called when visibility state is hidden.
http://www.w3.org/TR/vibration/
No new tests. vibration/navigator-vibration.html is changed.
- Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
- Modules/vibration/NavigatorVibration.h:
- Modules/vibration/NavigatorVibration.idl:
- Modules/vibration/Vibration.cpp:
(WebCore::Vibration::vibrate):
- Modules/vibration/Vibration.h:
LayoutTests:
Update navigator-vibration.html to adjust latest spec.
Add vibration/cancelVibration-during-pattern-vibrating.html to TestExpactations
until Vibration API support visibilitychane event.
- platform/efl/TestExpectations:
- vibration/navigator-vibration-expected.txt:
- vibration/navigator-vibration.html:
Jul 7, 2013:
- 11:52 PM Changeset in webkit [152440] by
-
- 22 edits in trunk/Source/WebCore
Adopt is/toHTMLTableElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118393
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLTableElement.
This also helps out to reduce duplicated use of static_cast.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::title):
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetCaption):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetDescription):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- dom/Position.cpp:
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
- editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
- editing/htmlediting.cpp:
(WebCore::isNonTableCellHTMLBlockElement):
- editing/markup.cpp:
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLTableElement.h:
(WebCore::isHTMLTableElement):
(WebCore::toHTMLTableElement):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::findParentTable):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::virtualItemAfter):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
- platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _computedStringForNode:property:]):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
- 9:40 PM Changeset in webkit [152439] by
-
- 12 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Graph::clearAndDerefChild() makes no sense anymore, and neither does Nop
https://bugs.webkit.org/show_bug.cgi?id=118452
Reviewed by Sam Weinig.
Noticed that ArgumentsSimplificationPhase was converting something to a Nop and then
resetting its children using clearAndDerefChild(). Using Nop instead of Phantom is a
holdover from back when we needed a no-MustGenerate no-op. We don't anymore. Using
clearAndDerefChild() was necessary back when we did eager reference counting. We
don't need to do that anymore, and in fact clearAndDerefChild() appeared to not do
any reference counting, so it was badly named to begin with.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
