Timeline
Jul 11, 2013:
- 11:42 PM WebKitGTK/Wayland edited by
- (diff)
- 6:59 PM Changeset in webkit [152583] by
-
- 2 edits in trunk/Websites/webkit.org
Add 'partner.samsung.com' to domain affiliations
https://bugs.webkit.org/show_bug.cgi?id=118580
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-07-11
Reviewed by Antonio Gomes.
- team.html:
- 5:50 PM Changeset in webkit [152582] by
-
- 7 edits1 add in trunk/LayoutTests
Replace simple_blank.swf with lines.swf for snapshotting tests.
https://bugs.webkit.org/show_bug.cgi?id=118581.
Reviewed by Tim Horton.
- plugins/resources/lines.swf: Added.
- plugins/snapshotting/autoplay-dominant.html:
- plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html:
- plugins/snapshotting/autoplay-similar-to-dominant.html:
- plugins/snapshotting/plugin-receives-click-event.html:
- plugins/snapshotting/restart.html:
- plugins/snapshotting/simple.html:
- 4:59 PM Changeset in webkit [152581] by
-
- 9 edits in branches/dfgFourthTier/Source/JavaScriptCore
Resurrect the CLoop LLINT on the FTL branch.
https://bugs.webkit.org/show_bug.cgi?id=118144.
Reviewed by Mark Hahnenberg.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::jitType):
- Fix the CodeBlock jitType to be InterpreterThunk when !ENABLE_JIT.
- bytecode/JumpTable.h:
(JSC::SimpleJumpTable::clear):
- interpreter/StackIterator.cpp:
(JSC::StackIterator::Frame::bytecodeOffset):
(JSC::StackIterator::Frame::print):
- jit/JITCode.cpp:
(JSC):
- jit/JITExceptions.cpp:
(JSC::getExceptionLocation):
- llint/LowLevelInterpreter.cpp:
- offlineasm/cloop.rb:
- runtime/Structure.cpp:
- 4:53 PM Changeset in webkit [152580] by
-
- 8 edits2 adds in trunk
Plugins that don't support snapshotting should not all autostart.
https://bugs.webkit.org/show_bug.cgi?id=118572
<rdar://problem/14324391>.
Reviewed by Dean Jackson.
Test: plugins/snapshotting/quicktime-plugin-snapshotted.html
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Pass in information about whether or not a snapshot exists
to the shadow dom.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::shouldNotAddLayer): This method determines whether or not we should add the plugin's layer to the tree.
It should not be added if the plugin is in it's snapshotted state but does not actually support snapshotting.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): We should only add the layer to the tree when the plugin
is actually playing. Otherwise we run into an issue where the contents of the layer initially appear on the screen briefly
on page load before we display the substitute for a plugin that doesn't support snapshotting.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldNotAddLayer): This method determines whether or not we should add the plugin's layer to the tree.
It should not be added if the plugin is in it's snapshotted state but does not actually support snapshotting.
(WebKit::PluginView::pluginSnapshotTimerFired): If the plugin does not support snapshotting go straight
to the the DisplayingSnapshot state.
- WebProcess/Plugins/PluginView.h:
- platform/mac-wk2/plugins/snapshotting/quicktime-plugin-snapshotted-expected.txt: Added.
- plugins/snapshotting/quicktime-plugin-snapshotted.html: Added.
- 3:33 PM Changeset in webkit [152579] by
-
- 5 edits in trunk/Source
[mac] No API for getting the page visibility state of a WebView
https://bugs.webkit.org/show_bug.cgi?id=118578
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.exp.in: Export WebCore::Page::visibilityState().
Source/WebKit/mac:
- WebView/WebView.mm:
(kit): Added. Converts from WebCore::PageVisibilityState to WebPageVisibilityState.
(-[WebView _visibilityState]): Added.
- WebView/WebViewPrivate.h: Declared -_visibilityState.
- 3:27 PM Changeset in webkit [152578] by
-
- 2 edits in trunk/Source/WebKit2
WebResourceCacheManager::cfURLCacheHostNamesWithCallback leaks an array (pointed out by the
clang static analyzer)
https://bugs.webkit.org/show_bug.cgi?id=118533
Reviewed by Anders Carlsson.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):
- 2:57 PM Changeset in webkit [152577] by
-
- 3 edits in trunk/Source/JavaScriptCore
Attempt to fix the windows build.
- 2:40 PM Changeset in webkit [152576] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Added expected failures after r152574.
- platform/gtk/TestExpectations: Added test failures.
- 12:40 PM Changeset in webkit [152575] by
-
- 2 edits in trunk/Source/WebKit2
Use GOwnPtr in PluginProcessProxyUnix to manage stdOut variable
https://bugs.webkit.org/show_bug.cgi?id=118568
Patch by Sergio Correia <Sergio Correia> on 2013-07-11
Reviewed by Martin Robinson.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 11:57 AM Changeset in webkit [152574] by
-
- 4 edits in trunk
[GTK] Layout Test accessibility/deleting-iframe-destroys-axcache.html, platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html are failing
https://bugs.webkit.org/show_bug.cgi?id=118552
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-07-11
Reviewed by Chris Fleizach.
Source/WebCore:
Do not assume always that we have a RenderText renderer when
calling to toRenderText(), since we might be executing that part
of the code due to have requested to include all the children.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Add
missing guard for RenderText, needed after r152537.
LayoutTests:
Remove tests that are no longer expected to crash.
- platform/gtk/TestExpectations: Removed tests.
- 11:35 AM Changeset in webkit [152573] by
-
- 8 edits in trunk
NativeExecutable cache needs to use both call and construct functions for key
https://bugs.webkit.org/show_bug.cgi?id=118545
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Make the native executable cache make use a key pair so we don't decide to
treat all subsequent functions as not being constructors.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
- jit/JITThunks.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
- runtime/JSCell.cpp:
(JSC::JSCell::getCallData):
(JSC::JSCell::getConstructData):
LayoutTests:
Make sure we don't decide that all bound functions aren't constructors.
- fast/js/function-bind-expected.txt:
- fast/js/script-tests/function-bind.js:
- 9:17 AM Changeset in webkit [152572] by
-
- 6 edits4 adds in trunk
[CSS Regions] In a region chain with auto-height regions, lines get their length based only on the first region
https://bugs.webkit.org/show_bug.cgi?id=118531
Reviewed by Alexandru Chiculita.
Source/WebCore:
When computing the height a flow thread it's possible to overflow the maximum LayoutUnit and obtain a negative value.
This leads to invalid results during layout when computing the region range and the RenderBoxRegion info for the
descendant boxes of the flow thread.
This issue appears especially during the auto-height algorithm because it initializes the auto-height regions
height with the LayoutUnit::max() / 2 value. Summing two such regions overflows and results in a negative value.
The fix clamps the maximum height of the flow thread to LayoutUnit::max() / 2. This doesn't affect the auto-height
algorithm because regionAtBlockOffset() will still return the correct values as the auto-height regions content
is established and their height updated.
Tests: fast/regions/autoheight-correct-region-for-lines-2.html
fast/regions/autoheight-correct-region-for-lines.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::maxPageLogicalHeight):
LayoutTests:
Add tests verifying the lines widths are correctly computed in auto-height regions with and without a max-height set.
- fast/regions/autoheight-correct-region-for-lines-2-expected.html: Added.
- fast/regions/autoheight-correct-region-for-lines-2.html: Added.
- fast/regions/autoheight-correct-region-for-lines-expected.html: Added.
- fast/regions/autoheight-correct-region-for-lines.html: Added.
- 8:43 AM Changeset in webkit [152571] by
-
- 12 edits in trunk/Source
Revert r152267 and soft link WebInspectorUI.framework again.
https://bugs.webkit.org/show_bug.cgi?id=118544
Reviewed by David Kilzer.
Source/WebCore:
- platform/mac/SoftLinking.h: Rename SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL
to SOFT_LINK_STAGED_FRAMEWORK and ASSERT since we don't want to silently
fail anymore when using this macro.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
Source/WebKit2:
- Configurations/WebKit2.xcconfig:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- 8:17 AM Changeset in webkit [152570] by
-
- 5 edits in trunk/Source
[Coordinated Graphics] Parameter of commitSceneState should be const
https://bugs.webkit.org/show_bug.cgi?id=118564
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-11
Reviewed by Noam Rosenthal.
Parameter of commitSceneState should be const as there should not be any
modifications to the passed CoordinatedGraphicsState.
Source/WebCore:
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 7:54 AM Changeset in webkit [152569] by
-
- 14 edits2 adds2 deletes in trunk
NamedFlowCollection getters should follow the same pattern as HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=118561
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-11
Reviewed by Christophe Dumez.
Source/WebCore:
Modified item and namedItem methods from DOMNamedFlowCollection to return null instead of undefined.
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22617
Completely removed the TreatReturnedNullObjectAs attribute as it was only used by the DOMNamedFlowCollection interface.
Test: fast/regions/webkit-named-flow-collection-empty-getters.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementationFunctionCall):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::treatReturnedNullObjectAsUndefined):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_treat_returned_null_object_as_undefined):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTreatReturnedNullObjectAsUndefined):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj treatReturnedNullObjectAsUndefined]):
- bindings/scripts/test/TestObj.idl:
- dom/DOMNamedFlowCollection.idl:
LayoutTests:
Updated test for NamedFlowCollection getters when no named flows are created.
- fast/regions/webkit-named-flow-collection-empty-getters-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-undefined-expected.txt.
- fast/regions/webkit-named-flow-collection-empty-getters.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-undefined.html.
- 7:45 AM Changeset in webkit [152568] by
-
- 2 edits in trunk/Source/WebCore
Revert r149313: Don't check for @media rules affected by viewport changes in every layout.
<rdar://problem/14277905>
Rubber-stamped by Antti Koivisto.
This changed caused more harm than good. setFrameRect() is not the only path in FrameView
that can cause media queries to need invalidation.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::layout):
- 6:56 AM WebKitIDL edited by
- (diff)
- 5:43 AM Changeset in webkit [152567] by
-
- 4 edits in trunk/Source/WebCore
Introduce isHTMLTitleElement and toHTMLTitleElement
https://bugs.webkit.org/show_bug.cgi?id=118558
Reviewed by Andreas Kling.
To enhance readability, this patch introduces isHTMLTitleElement and toHTMLTitleElement.
This also helps out to reduce duplicated use of static_cast.
- dom/Document.cpp:
(WebCore::Document::setTitle):
(WebCore::Document::removeTitle):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::removeHeadContents):
- html/HTMLTitleElement.h:
(WebCore::isHTMLTitleElement):
(WebCore::toHTMLTitleElement):
- 4:43 AM Changeset in webkit [152566] by
-
- 2 edits6 deletes in trunk/Source
Remove unused Windows CE files
https://bugs.webkit.org/show_bug.cgi?id=118557
Reviewed by Andreas Kling.
Source/WebCore:
- platform/wince/CursorWinCE.cpp: Removed.
- platform/wince/PasteboardWinCE.cpp: Removed.
- platform/wince/SearchPopupMenuWinCE.cpp: Removed.
Source/WTF:
- wtf/wince/FastMallocWinCE.h: Removed.
- wtf/wince/MemoryManager.cpp: Removed.
- wtf/wince/MemoryManager.h: Removed.
- 4:19 AM Changeset in webkit [152565] by
-
- 16 edits11 copies3 moves4 adds in trunk/Source/WebCore
Get rid of SVGPathSeg* special casing in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=118525
Reviewed by Kentaro Hara.
Have one header per SVGPathSeg* type so that we no longer need special casing
for them in the JSC bindings generator.
No new tests, no behavior change.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSVGPathSegCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(NativeToJSValue):
- svg/SVGPathElement.cpp:
- svg/SVGPathSegArc.h:
- svg/SVGPathSegArcAbs.h: Added.
(WebCore::SVGPathSegArcAbs::create):
(WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
(WebCore::SVGPathSegArcAbs::pathSegType):
(WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter):
- svg/SVGPathSegArcRel.h: Added.
(WebCore::SVGPathSegArcRel::create):
(WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
(WebCore::SVGPathSegArcRel::pathSegType):
(WebCore::SVGPathSegArcRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubic.h:
- svg/SVGPathSegCurvetoCubicAbs.h: Added.
(WebCore::SVGPathSegCurvetoCubicAbs::create):
(WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicRel.h: Added.
(WebCore::SVGPathSegCurvetoCubicRel::create):
(WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicSmooth.h:
- svg/SVGPathSegCurvetoCubicSmoothAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoCubicSmooth.h.
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicSmoothRel.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoCubicSmooth.h.
(WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadratic.h:
- svg/SVGPathSegCurvetoQuadraticAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadratic.h.
(WebCore::SVGPathSegCurvetoQuadraticAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticRel.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadratic.h.
(WebCore::SVGPathSegCurvetoQuadraticRel::create):
(WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadraticSmooth.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticSmoothRel.h: Renamed from Source/WebCore/svg/SVGPathSegCurvetoQuadraticSmooth.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoAbs.h: Copied from Source/WebCore/svg/SVGPathSegLineto.h.
(WebCore::SVGPathSegLinetoAbs::create):
(WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
(WebCore::SVGPathSegLinetoAbs::pathSegType):
(WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoHorizontal.h:
- svg/SVGPathSegLinetoHorizontalAbs.h: Copied from Source/WebCore/svg/SVGPathSegLinetoHorizontal.h.
(WebCore::SVGPathSegLinetoHorizontalAbs::create):
(WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoHorizontalRel.h: Copied from Source/WebCore/svg/SVGPathSegLinetoHorizontal.h.
(WebCore::SVGPathSegLinetoHorizontalRel::create):
(WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoRel.h: Renamed from Source/WebCore/svg/SVGPathSegLineto.h.
(WebCore::SVGPathSegLinetoRel::create):
(WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
(WebCore::SVGPathSegLinetoRel::pathSegType):
(WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoVertical.h:
- svg/SVGPathSegLinetoVerticalAbs.h: Copied from Source/WebCore/svg/SVGPathSegLinetoVertical.h.
(WebCore::SVGPathSegLinetoVerticalAbs::create):
(WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegType):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoVerticalRel.h: Copied from Source/WebCore/svg/SVGPathSegLinetoVertical.h.
(WebCore::SVGPathSegLinetoVerticalRel::create):
(WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegType):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter):
- svg/SVGPathSegListBuilder.cpp:
- svg/SVGPathSegMovetoAbs.h: Copied from Source/WebCore/svg/SVGPathSegMoveto.h.
(WebCore::SVGPathSegMovetoAbs::create):
(WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
(WebCore::SVGPathSegMovetoAbs::pathSegType):
(WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter):
- svg/SVGPathSegMovetoRel.h: Renamed from Source/WebCore/svg/SVGPathSegMoveto.h.
(WebCore::SVGPathSegMovetoRel::create):
(WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
(WebCore::SVGPathSegMovetoRel::pathSegType):
(WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter):
- 3:53 AM Changeset in webkit [152564] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r152426.
- config.h:
- 3:28 AM Changeset in webkit [152563] by
-
- 2 edits in trunk/Source/WebCore
[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont
https://bugs.webkit.org/show_bug.cgi?id=118532
Patch by Fabienne Semeria <fsemeria@nds.com> on 2013-07-11
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- 2:09 AM Changeset in webkit [152562] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Added crash expectations in debug builds after r152537
- platform/gtk/TestExpectations: Added two crashing tests.
- 1:36 AM Changeset in webkit [152561] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Refactor code for translating offsets between WebCore a11y and ATK
https://bugs.webkit.org/show_bug.cgi?id=118179
Reviewed by Chris Fleizach.
Encapsulate better and make more clear the translation of offsets
between our ATK implementation and WebCore's accessibility layer.
Values for offsets can differ sometimes between those two worlds
due to some extra flattening we need to do in ATK based ports to
properly expose the accessibility hierarchy to ATs, which
sometimes means adding extra text elements in the exposed text
through the AtkText interface (e.g. list items markers).
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(offsetAdjustmentForListItem): Helper function to refactor code
needed to translate offsets from WebCore to ATK worlds. Currently
related to considering list item markers in LTR text only.
(webCoreOffsetToAtkOffset): Convenience function for code
readability purposes. It just calls offsetAdjustmentForListItem.
(atkOffsetToWebCoreOffset): Likewise.
(getSelectionOffsetsForObject): Use webCoreOffsetToAtkOffset.
(webkitAccessibleTextGetCaretOffset): Use webCoreOffsetToAtkOffset
to translate an offset from WebCore to ATK before returning it.
(webkitAccessibleTextSetSelection): Use atkOffsetToWebCoreOffset
to translate an offset from WebCore to ATK before using it.
(webkitAccessibleTextSetCaretOffset): Likewise.
- 12:00 AM Changeset in webkit [152560] by
-
- 2 edits in trunk/Tools
Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=118538
Patch by Sergio Correia <Sergio Correia> on 2013-07-10
Reviewed by Christophe Dumez.
When attempting some odd url such as
foo, MiniBrowser will now show an
error message such as "Cannot resolve hostname (foo)".
Previously, it had the following behavior if MiniBrowser was started with
such urls, e.g./MiniBrowser foo:
- Debug:
It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
- Release:
No asserts, naturally, but the view would remain blank, even if we tried to
change to a valid url.
- MiniBrowser/efl/main.c:
(window_create):
Jul 10, 2013:
- 6:15 PM Changeset in webkit [152559] by
-
- 1 copy in tags/Safari-537.49
New Tag.
- 5:46 PM Changeset in webkit [152558] by
-
- 3 edits2 deletes in branches/safari-537-branch
Rollout of r152556. <rdar://problem/14305675>
- 5:31 PM Changeset in webkit [152557] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152555. <rdar://problem/14395759>
- 5:14 PM Changeset in webkit [152556] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152554. <rdar://problem/14305675>
- 5:13 PM Changeset in webkit [152555] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/14395759> PluginProcess sometimes logs an error about being unable to load WebKit2.framework.
Reviewed by Alexey Proskuryakov.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::createPropertyListFile): Ensure that any environment variables
specified in dynamic linker load commands are passed to the subprocess that we spawn to create
the MIME type property list.
- 4:56 PM Changeset in webkit [152554] by
-
- 3 edits2 adds in trunk
Range.getClientRects() not working correctly for partially contained vertically styled text nodes
<rdar://problem/14305675>
https://bugs.webkit.org/show_bug.cgi?id=118447
Reviewed by David Hyatt.
Source/WebCore:
Original patch by Mac Murrett, tweaked by me.
Test: fast/dom/Range/getClientRects-vertical.html
- rendering/RenderText.cpp:
(WebCore::localQuadForTextBox):
Use the physical accessors rather than the logical ones to get the correct metrics.
LayoutTests:
- fast/dom/Range/getClientRects-vertical-expected.txt: Added.
- fast/dom/Range/getClientRects-vertical.html: Added.
- 4:48 PM Changeset in webkit [152553] by
-
- 58 edits2 adds in trunk/Source/WebCore
Reduce number of header includes in SVG
https://bugs.webkit.org/show_bug.cgi?id=118474
Reviewed by Rob Buis.
Reduce number of header includes in SVG. In particular, SVGAnimatedPropertyMacros.h
no longer brings SVGElement.h header include. This means that the SVGElement
class can now have animated properties.
This patch is a prerequirement to merge SVGStyledElement into SVGElement.
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- svg/GradientAttributes.h:
- svg/SVGAllInOne.cpp:
- svg/SVGAnimateMotionElement.cpp:
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimatedTypeAnimator.cpp: Added.
(WebCore::SVGElementAnimatedProperties::SVGElementAnimatedProperties):
(WebCore::SVGAnimatedTypeAnimator::SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::~SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndToValues):
(WebCore::SVGAnimatedTypeAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
- svg/SVGAnimatedTypeAnimator.h:
- svg/SVGAnimationElement.h:
- svg/SVGCursorElement.cpp:
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
- svg/SVGElementInstanceList.cpp:
- svg/SVGElementInstanceList.h:
- svg/SVGElementRareData.h:
- svg/SVGFEImageElement.cpp:
- svg/SVGFilterElement.cpp:
- svg/SVGFitToViewBox.h:
- svg/SVGFontData.cpp:
- svg/SVGFontData.h:
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.cpp:
- svg/SVGGlyphMap.h:
- svg/SVGGradientElement.cpp:
- svg/SVGMPathElement.cpp:
- svg/SVGMPathElement.h:
- svg/SVGPathBlender.cpp:
- svg/SVGPathBlender.h:
- svg/SVGPathBuilder.cpp:
- svg/SVGPathBuilder.h:
- svg/SVGPathParser.cpp:
- svg/SVGPathParser.h:
- svg/SVGPathSegListBuilder.h:
- svg/SVGPathTraversalStateBuilder.cpp:
- svg/SVGPathTraversalStateBuilder.h:
- svg/SVGPathUtilities.h:
- svg/SVGPatternElement.cpp:
- svg/SVGPointList.h:
- svg/SVGScriptElement.cpp:
- svg/SVGStyledElement.h:
- svg/SVGTests.h:
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp:
- svg/SVGTransformable.h:
- svg/SVGURIReference.cpp:
- svg/SVGURIReference.h:
- svg/SVGVKernElement.cpp:
- svg/SVGVKernElement.h:
- svg/SVGZoomAndPan.h:
- svg/properties/SVGAnimatedProperty.cpp: Added.
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::commitChange):
(WebCore::SVGAnimatedProperty::animatedPropertyCache):
- svg/properties/SVGAnimatedProperty.h:
- svg/properties/SVGAnimatedPropertyMacros.h:
(WebCore::SVGSynchronizableAnimatedProperty::synchronize):
- svg/properties/SVGAnimatedStaticPropertyTearOff.h:
- svg/properties/SVGListProperty.h:
- 3:39 PM Changeset in webkit [152552] by
-
- 3 edits in trunk/Source/WebCore
Fix build against GTK+ 2.0
https://bugs.webkit.org/show_bug.cgi?id=117895
Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-07-10
Reviewed by Martin Robinson.
GTK2 build fails for undefined GDK_IS_X11_DISPLAY
GTK 2.0 does define GDK_WINDOWING_X11,but GDK_IS_X11_DISPLAY is not
present in GTK+ 2.0. A dummy defines is sufficient, as GTK 2.0 is not
that multiple backend aware anyway...
- platform/gtk/GtkVersioning.h: Define GDK_IS_X11_DISPLAY for GTK+ 2.0 and compatibility for gtk_widget_get_preferred_size()
- plugins/gtk/gtk2xtbin.c: Include config.h
- 2:40 PM Changeset in webkit [152551] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152539. <rdar://problem/14286390>
- 2:37 PM Changeset in webkit [152550] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152548. <rdar://problem/14286329>
- 2:34 PM Changeset in webkit [152549] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152541. <rdar://problem/14262126>
- 2:15 PM Changeset in webkit [152548] by
-
- 2 edits in trunk/Source/WebCore
Deferring layer flushes can cause painting without layout being done
https://bugs.webkit.org/show_bug.cgi?id=118493
Reviewed by Simon Fraser.
r147797 added a mechanism for the TileController to inform RenderLayerCompositor
that it had performed an action (setNeedsDisplay, etc.) that would cause CoreAnimation
to call back into us to paint in this runloop, and that it shouldn't throttle the next
layer flush.
However, if tiles were created and left unparented (because the TileController was
out-of-window), when they are later parented, we failed to inform RenderLayerCompositor
that they were about to call back for painting, and so it would happily throttle the
next layer flush, and layout would be out of date, and garbage and corruption could result.
To resolve this, rework the logic surrounding parenting existing-but-unparented tiles
to ensure that they get added to the TileController's dirtyRect.
No new tests; the bug only reproduces under specific timing circumstances, and
manifests itself as an assertion failure or garbage on the screen, so it's quite
hard to make a workable test.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::revalidateTiles):
- Factor out the code to parent unparented tiles so that it is shared between the
created-new-tile and reparenting-existing-tile cases.
- Keep track of whether we updated the frame of a pre-existing tile.
- If the tile is dirty and needed to be parented (because either it's new
or hadn't been parented before), add it to the dirty rect list.
- If the tile changed size, add it to the dirty rect list.
(WebCore::TileController::ensureTilesForRect):
Ditto everything from revalidateTiles.
(WebCore::TileController::createTileLayer):
- Explicitly mark fresh tiles as needing display, so that we can depend on
[WebTileLayer needsDisplay] in revalidateTiles to tell us that it's dirty.
- 2:03 PM Changeset in webkit [152547] by
-
- 9 edits2 adds in trunk
[Mac] every enabled text track should be listed in the track menu
https://bugs.webkit.org/show_bug.cgi?id=118477
Reviewed by Jer Noble.
Source/WebCore:
Test: media/video-controls-captions-trackmenu-includes-enabled-track.html
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Don't select the
"Off" menu item if a track is enabled.
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Always include a track
that is showing in the menu. Add more diagnostic logging.
LayoutTests:
- media/trackmenu-test.js: Add some new utility functions.
- media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt: Added.
- media/video-controls-captions-trackmenu-includes-enabled-track.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 1:46 PM Changeset in webkit [152546] by
-
- 2 edits in branches/safari-537-branch/Source/WTF
Merged r152429. <rdar://problem/14341205>
- 1:44 PM Changeset in webkit [152545] by
-
- 2 edits in branches/safari-537-branch/Source/WTF
Merged r152427. <rdar://problem/14341205>
- 1:40 PM Changeset in webkit [152544] by
-
- 7 edits in branches/safari-537-branch/Source
Merged r152426. <rdar://problem/14341205>
- 1:40 PM Changeset in webkit [152543] by
-
- 16 edits2 deletes in trunk
Remove ElementTimeControl and expose SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=118349
Reviewed by Rob Buis.
Source/WebCore:
Remove ElementTimeControl IDL interface and move its attributes
to the SVGAnimationElement IDL interface as per the latest SVG2
specification:
https://svgwg.org/svg2-draft/animate.html#InterfaceSVGAnimationElement
Also remove [NoInterfaceObject] IDL extended attribute from
SVGAnimationElement as it is not present in the specification.
This is one step towards removing IDL multiple inheritance in SVG and
complying with the latest SVG2 specification.
No new tests, covered by existing test cases.
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorObjC.pm:
- svg/ElementTimeControl.h: Removed.
- svg/ElementTimeControl.idl: Removed.
- svg/SVGAnimationElement.h:
- svg/SVGAnimationElement.idl:
LayoutTests:
Rebaseline several test cases now that SVGAnimationElement is exposed
on the global Window object.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- svg/custom/global-constructors-expected.txt:
- 1:31 PM Changeset in webkit [152542] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: "Always enable" profiling does not work
https://bugs.webkit.org/show_bug.cgi?id=118487
Enable profiler when loading panel if profiler is enabled in inspector
settings.
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-07-10
Reviewed by Timothy Hatcher.
- inspector/front-end/ProfilesPanel.js:
- 12:30 PM Changeset in webkit [152541] by
-
- 3 edits2 adds in trunk
HTMLPluginElement's state should be Playing before firing mouse click event.
https://bugs.webkit.org/show_bug.cgi?id=118398.
<rdar://problem/14262126>
Reviewed by Dean Jackson.
Test: plugins/snapshotting/plugin-receives-click-event.html
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired):
The defaultEventHandler returns early if the state is not Playing.
This is because we only want the plugin to deal with user interaction normally if the
plugin is actually enabled (not being snapshotted).
When we click on the snapshotted plugin to start it, we mimic what would happen to the plugin
normally by dispatching another click event on top of where we just clicked.
However, we were sending the click event before setting the state to Playing which meant that our
simulated click was not being handled.
We should be setting this state before sending the click, not after.
- platform/mac-wk2/plugins/snapshotting/plugin-receives-click-event-expected.txt: Added.
- plugins/snapshotting/plugin-receives-click-event.html: Added.
- 11:42 AM Changeset in webkit [152540] by
-
- 2 edits in trunk/Source/WebCore
Fix a bug in MediaStreamDescriptor::removeVideoComponent
https://bugs.webkit.org/show_bug.cgi?id=118446
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-10
Reviewed by Eric Carlson.
MediaStreamDescriptor::removeVideoComponent is currently trying to
remove the 'videoComponent' from the wrong vector.
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::removeVideoComponent):
- 11:34 AM Changeset in webkit [152539] by
-
- 2 edits in trunk/Source/WebKit2
Some Java plugin instances can deadlock with the WebProcess on NPP_Destroy.
<rdar://problem/14286390> and https://bugs.webkit.org/show_bug.cgi?id=118535
Reviewed by Alexey Proskuryakov.
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::~NPObjectProxy): ASSERT this is the main thread.
(WebKit::NPObjectProxy::NP_Deallocate): If this isn't the main thread, call it again on the main thread.
- 10:02 AM Changeset in webkit [152538] by
-
- 6 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
r146831 | mark.lam@apple.com | 2013-03-25 17:36:18 -0700 (Mon, 25 Mar 2013) | 19 lines
Offlineasm cloop backend compiles op+branch incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=113146.
- dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- llint/LLIntOfflineAsmConfig.h:
- offlineasm/cloop.rb:
- 9:20 AM Changeset in webkit [152537] by
-
- 10 edits in trunk
AX: Allow requesting the full plain text for an object with textUnderElement()
https://bugs.webkit.org/show_bug.cgi?id=105214
Reviewed by Chris Fleizach.
Source/WebCore:
Allow specifying different function modes for textUnderElement(),
so we can effectively ask for the "normal" result (e.g to retrieve
test to be exposed as the 'title') or for the full text under the
element (without omitting any child in the subtree). This is
needed for the implementation of atk_text_get_text() in GTK/EFL.
- accessibility/AccessibilityObject.h: Add new enumeration to
specify the different modes for textUnderElement().
(WebCore::AccessibilityObject::textUnderElement): Added parameter.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldUseAccessiblityObjectInnerText): Always return
'true' when using the "include all children" mode.
(WebCore::AccessibilityNodeObject::textUnderElement): Updated call
to shouldUseAccessiblityObjectInnerText().
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Removed
GTK specific code and expand the usage of text iterators beyond
text render objects, using it also when in the "include all
children" mode.
- accessibility/AccessibilityRenderObject.h:
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::getLengthForTextRange): Updated
call to textUnderElement(), preserving the previous behavior.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Updated call to textUnderElement(),
using the "include all children" mode.
LayoutTests:
Removed tests that are not longer expected to fail.
- platform/gtk/TestExpectations: Removed tests.
- 8:52 AM Changeset in webkit [152536] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove some dead code from WebNSURLExtras _web_hostString
https://bugs.webkit.org/show_bug.cgi?id=118519
Reviewed by Anders Carlsson.
- Misc/WebNSURLExtras.mm:
(-[NSURL _web_hostString]):
NSString initWithData:encoding: does not throw an exception when passing nil for the data, so
just delete the code that wasn't being run.
- 7:38 AM Changeset in webkit [152535] by
-
- 2 edits in trunk/Websites/planet.webkit.org
[Planet WebKit] Remove my website from the list of feeds
https://bugs.webkit.org/show_bug.cgi?id=118510
Reviewed by Andreas Kling.
With various awesome folks at Apple having taken over the Last
Week in WebKit series and my blog now featuring Last Week in
Blink, there's no reason for it to be included on the Planet
anymore.
- config.ini:
- 6:57 AM Changeset in webkit [152534] by
-
- 4 edits in trunk/Source
Remove the meshType from CoordinatedCustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=118529
Patch by Sergio Correia <Sergio Correia> on 2013-07-10
Reviewed by Noam Rosenthal.
Following the removal of the meshType from CustomFilterOperation in r149153,
remove also the meshType from CoordinatedCustomFilterOperation.
No new tests, no new functionality.
Source/WebCore:
- platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h:
(WebCore::CoordinatedCustomFilterOperation::create): Remove unused meshType parameter.
(WebCore::CoordinatedCustomFilterOperation::CoordinatedCustomFilterOperation): Ditto.
Ditto.
Source/WebKit2:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode): Remove dead comment.
(CoreIPC::::decode): Remove meshType from CoordinatedCustomFilterOperation
call.
- 3:05 AM Changeset in webkit [152533] by
-
- 4 edits4 deletes in trunk/LayoutTests
[GTK] Unreviewed gardening. Update new baselines after r152494 and r152478
https://bugs.webkit.org/show_bug.cgi?id=118527
Unreviewed GTK gardening
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-10
- platform/gtk/editing/deleting/delete-br-002-expected.txt: Updated after r152478.
- platform/gtk/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed to pick general one after r152494.
- platform/gtk/editing/execCommand/outdent-blockquote-test2-expected.txt: Ditto.
- platform/gtk/editing/execCommand/outdent-blockquote-test3-expected.txt: Ditto.
- platform/gtk/editing/execCommand/outdent-blockquote-test4-expected.txt: Ditto.
- platform/gtk/fast/events/remove-target-with-shadow-in-drag-expected.txt: Updated after r152494.
- platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Updated after r152494.
- 1:57 AM Changeset in webkit [152532] by
-
- 7 edits in trunk
AX: AccessibilityNodeObject::supportsRequiredAttribute() should switch on CellRole
https://bugs.webkit.org/show_bug.cgi?id=117817
Patch by James Craig <james@cookiecrook.com> on 2013-07-10
Reviewed by Chris Fleizach.
Source/WebCore:
CellRole supports the required attribute now for accessibility, according to ARIA spec.
Updated existing test coverage.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
LayoutTests:
CellRole supports the required attribute now for accessibility, according to ARIA spec.
- platform/mac/accessibility/table-attributes-expected.txt:
- platform/mac/accessibility/table-cell-spans-expected.txt:
- platform/mac/accessibility/table-cells-expected.txt:
- platform/mac/accessibility/table-sections-expected.txt:
- 1:46 AM Changeset in webkit [152531] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r151957): WebGL textures do not show
https://bugs.webkit.org/show_bug.cgi?id=118464
Reviewed by Christophe Dumez.
After r151957 decoder.frameIsCompleteAtIndex(0) doesn't trigger image decoding,
we have to call decoder.createFrameAtIndex(0) explicitly to ensure it.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- 1:41 AM Changeset in webkit [152530] by
-
- 3 edits in trunk/Tools
[GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
https://bugs.webkit.org/show_bug.cgi?id=118509
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-10
Reviewed by Martin Robinson.
In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
when trying to remove an event already removed, if another event is
processed in the middle. By using a Deque's takeFirst, we ensure the
element is removed before we dispatch it.
fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
crashes after this fix is added.
- WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
from the queue.
- 1:36 AM Changeset in webkit [152529] by
-
- 2 edits in trunk/Source/WTF
Workaround for x86 optimizer bug in MSVC 2012.
https://bugs.webkit.org/show_bug.cgi?id=118478
Reviewed by Benjamin Poulain.
This is a workaround for a bug in the x86 MSVC 2012 optimizer.
The problem is that the range comparison gets optimized out when
the templated inline function toASCIIUpper. Copying the methods
content fixes the problem.
This is unfortunately not the nicest fix, but the alternative would
be to turn off optimization for StringImpl::upper on the x86 MSVC 2012
build, which might impact overall performance negatively.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper):
- 1:13 AM Changeset in webkit [152528] by
-
- 1 edit4 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening.
Remove platform specific expetations after r152494 because the generic is good for Qt.
- platform/qt/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed after r152494.
- platform/qt/editing/execCommand/outdent-blockquote-test2-expected.txt: Removed after r152494.
- platform/qt/editing/execCommand/outdent-blockquote-test3-expected.txt: Removed after r152494.
- platform/qt/editing/execCommand/outdent-blockquote-test4-expected.txt: Removed after r152494.
- 12:41 AM Changeset in webkit [152527] by
-
- 2 edits in trunk/Source/WebCore
Change recently ratified extensions prefixes from WEBKIT_WEBGL_ to WEBGL_
https://bugs.webkit.org/show_bug.cgi?id=117786
Patch by Karol Świniarski <k.swiniarsk2@samsung.com> on 2013-07-10
Reviewed by Dean Jackson.
According to WebGL's revision 10, extensions should be named: WEBGL_lose_context,
WEBGL_depth_texture, WEBGL_compressed_texture_s3tc.
No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/extensions/get-extension.html
LayoutTests/webgl/conformance/context/context-lost.html
LayoutTests/webgl/conformance/extensions/webgl-depth-texture.html
LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-s3tc.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
