Timeline
Jul 12, 2013:
- 8:44 PM Changeset in webkit [152609] by
-
- 2 edits in trunk/Tools
Unreviewed. Add an email address and update my domain of experts.
- Scripts/webkitpy/common/config/contributors.json:
- 4:59 PM Changeset in webkit [152608] by
-
- 4 edits in trunk/Source/WebKit/mac
Remove some dead stores pointed out by the clang static analyzer.
https://bugs.webkit.org/show_bug.cgi?id=118608
Reviewed by Anders Carlsson.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
kr is never read after this point, so there is no reason to assign to it.
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage getPluginInfoFromPLists]):
The extensions array is only used in the while loop. Move the declaration to the first place
it is used in the while loop. Since it is always reassigned at that location, and since it
is never read after the subsequent for loop, the assignment to an array containing the empty
string is never used. Remove it.
Similarly, the value of the description is always overwritten before used to assign to
mimeClassInfo.desc or to pluginInfo.desc, so the code to assign it to the empty string is
never used. Remove it.
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _placePopupWindow:]):
maxWidth is never read (and never was since it was added in r7311) after it is used on the
line above to set windowFrame.size.width.
- 4:35 PM Changeset in webkit [152607] by
-
- 2 edits in trunk/Source/WebCore
[iOS] TextTrackRepresentation not cleared when captions are disabled
https://bugs.webkit.org/show_bug.cgi?id=118623
Reviewed by Dean Jackson.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Do not return immediately
when captions are disabled so the necessary cleanup happens.
- 3:37 PM Changeset in webkit [152606] by
-
- 4 edits in trunk
Source/JavaScriptCore: Optimize addStrackTraceIfNecessary to be faster in the case when it's not necessary
https://bugs.webkit.org/show_bug.cgi?id=118328
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-12
Reviewed by Geoffrey Garen.
Retrieving the stack is costly. We want to get it only once. By moving the check
for the .stack property above the code to retrieve the stack, we ensure this.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
LayoutTests: By optimizing when the stack is added a two tests needed to be modifed to show correct results.
https://bugs.webkit.org/show_bug.cgi?id=118328
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-12
Reviewed by Geoffrey Garen.
- inspector/console/console-exception-stack-traces.html: This test compares the console's currect
stack with the error object's stack. The test was failing on decodeURI() and eval() which create
a new frame on the stack to execute. The console's stack was unaware of these calls and the size
of the stacks would not match. I added a check to pass if it was the specific case with decodeURI
or eval.
- 1:05 PM Changeset in webkit [152605] by
-
- 2 edits in trunk/Tools
[jhbuild] Avoid restarting from scratch failed initial checkouts
https://bugs.webkit.org/show_bug.cgi?id=118603
Patch by Emanuele Aina <Emanuele Aina> on 2013-07-12
Reviewed by Martin Robinson.
If the initial checkout is interrupted midway (eg. because the internet
connection went down) config files do not get generated and that causes
the next checkout to start from scratch (the missing files cause the
script to delete the build root and the downloaded sources).
By generating the files before invoking jhbuild, subsequent runs are able
to start where the previous run left.
- Scripts/update-webkit-libs-jhbuild:
(saveJhbuildMd5): invoke it before runJhbuild().
- 12:51 PM Changeset in webkit [152604] by
-
- 2 edits in trunk/Tools
[Windows] Remove single-worker restriction on tests.
- Scripts/webkitpy/port/win.py: Remove restriction of one worker.
- 12:30 PM Changeset in webkit [152603] by
-
- 3 edits in trunk/Source/WebCore
[Windows] Attempt to satisfy the Open Source Windows bots.
- DerivedSources.make: Restore the HAVE_AVCF macro detection.
- config.h: Return to using HAVE_AVCF to activate AVFoundation code.
- 12:05 PM Changeset in webkit [152602] by
-
- 3 edits1 delete in trunk/Tools
Unreviewed, rolling out r152599.
http://trac.webkit.org/changeset/152599
https://bugs.webkit.org/show_bug.cgi?id=118612
This patch includes a failing unit test (Requested by
mrobinson on #webkit).
- Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
- Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
- Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
- 11:57 AM Changeset in webkit [152601] by
-
- 2 edits in trunk/Tools
[Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=91223
Patch by Emanuele Aina <Emanuele Aina> on 2013-07-12
Reviewed by Martin Robinson.
When run on a clean checkout,
build-webkitcomplains that no
GNUmakefile exists when trying to detect the previously configured
architecture, but in this case there's no previous configuration so
the warning is pointless.
- Scripts/webkitdirs.pm:
(determineArchitecture): Redirect grep stderr to /dev/null.
- 11:54 AM Changeset in webkit [152600] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Build correction after r152573/r152577.
https://bugs.webkit.org/show_bug.cgi?id=118610
Reviewed by Oliver Hunt.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub): Hand-feed MSVC++ the fact that we want the second
argument of the make_pair to be a function pointer.
- 11:36 AM Changeset in webkit [152599] by
-
- 3 edits1 add in trunk/Tools
check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
https://bugs.webkit.org/show_bug.cgi?id=118592
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-12
Reviewed by Martin Robinson.
Added a suppression for pylint false positives and a unit test.
- Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
- Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
- Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
(test_popen):
- 11:31 AM Changeset in webkit [152598] by
-
- 17 edits in trunk/Source/WebInspectorUI
Update CodeMirror to 7f560afa1c (3.14+).
https://bugs.webkit.org/show_bug.cgi?id=118605
Reviewed by Sam Weinig.
- Tools/PrettyPrinting/CodeMirrorFormatters.js:
- Tools/PrettyPrinting/Formatter.js:
- Tools/PrettyPrinting/FormatterContentBuilder.js:
- Tools/PrettyPrinting/codemirror.css:
- Tools/PrettyPrinting/codemirror.js:
- Tools/PrettyPrinting/css.js:
- Tools/PrettyPrinting/javascript.js:
- UserInterface/External/CodeMirror/codemirror.css:
- UserInterface/External/CodeMirror/codemirror.js:
- UserInterface/External/CodeMirror/coffeescript.js:
- UserInterface/External/CodeMirror/comment.js:
- UserInterface/External/CodeMirror/css.js:
- UserInterface/External/CodeMirror/javascript.js:
- UserInterface/External/CodeMirror/matchbrackets.js:
- UserInterface/External/CodeMirror/sql.js:
- UserInterface/External/CodeMirror/xml.js:
- 10:56 AM Changeset in webkit [152597] by
-
- 1 copy in tags/Safari-537.50
New Tag.
- 10:53 AM Changeset in webkit [152596] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- 9:40 AM Changeset in webkit [152595] by
-
- 2 edits in trunk/Source/WTF
Improve StringImpl::constructInternal() method
https://bugs.webkit.org/show_bug.cgi?id=118503
Reviewed by Benjamin Poulain.
StringImpl::constructInternal used 'if ()' statement to decide which constructor
to invoke hence compiler had to compile both branches even though optimizer would
have then removed one of those, and as the function is inline it could affect
slightly the compilation time.
The problem is solved via template specialization.
- wtf/text/StringImpl.h:
(WTF::LChar):
(WTF::UChar):
- 9:36 AM Changeset in webkit [152594] by
-
- 12 edits in branches/safari-537-branch/Source
Merged r152571. <rdar://problem/14364171>
- 9:28 AM Changeset in webkit [152593] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=118461
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-12
Reviewed by Brent Fulgham.
- config.h: Only enable AVFOUNDATION for Windows if CoreGraphics is used.
- 9:28 AM Changeset in webkit [152592] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 7:42 AM Changeset in webkit [152591] by
-
- 2 edits in trunk/Source/WebCore
[EFL] --minimal build fails while linking libwebcore_efl.so
https://bugs.webkit.org/show_bug.cgi?id=118549
Patch by Oleg Beletski <oleg.beletski@gmail.com> on 2013-07-12
Reviewed by Christophe Dumez.
- CMakeLists.txt:
Moving file plugins/PluginPackage.cpp to ENABLE_NETSCAPE_PLUGIN_API block.
- 6:16 AM Changeset in webkit [152590] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping new failing test on Qt.
https://bugs.webkit.org/show_bug.cgi?id=118595
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-12
- platform/qt/TestExpectations:
- 5:55 AM Changeset in webkit [152589] by
-
- 4 edits in trunk/LayoutTests
Unreviewed typo fix.
- fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
- fast/css-grid-layout/grid-element-change-columns-repaint.html:
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
- 5:45 AM Changeset in webkit [152588] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
https://bugs.webkit.org/show_bug.cgi?id=118589
Patch by Seokju Kwon <Seokju Kwon> on 2013-07-12
Reviewed by Timothy Hatcher.
sidebarPanels : It is necessary to get correct argument after r152141.
Without this, error messages can be displayed.
role : Could pass null for it since default value is "group".
- UserInterface/Main.js:
(WebInspector.contentLoaded):
- 3:33 AM Changeset in webkit [152587] by
-
- 2 edits in tags/Safari-537.49.1/Source/WebKit2
Build fix.
- Configurations/BaseTarget.xcconfig: Ensure that /System/Library/PrivateFrameworks is on the framework
search path.
- 3:33 AM Changeset in webkit [152586] by
-
- 5 edits in tags/Safari-537.49.1/Source
Versioning.
- 3:25 AM Changeset in webkit [152585] by
-
- 1 copy in tags/Safari-537.49.1
New tag.
- 1:22 AM Changeset in webkit [152584] by
-
- 3 edits in trunk/Source/WebCore
Insufficient viewport repaints when FrameView::paintsEntireContents
https://bugs.webkit.org/show_bug.cgi?id=118562
Reviewed by Simon Fraser.
When the frameview paints entire content, the visualOverflowRect of RenderView
should be the same as the layoutOverflowRect.
This affects the requested repaints on resize of the frameview.
- rendering/RenderView.cpp:
(WebCore::RenderView::visualOverflowRect):
- rendering/RenderView.h:
Jul 11, 2013:
- 11:42 PM WebKitGTK/Wayland edited by
- (diff)
- 6:59 PM Changeset in webkit [152583] by
-
- 2 edits in trunk/Websites/webkit.org
Add 'partner.samsung.com' to domain affiliations
https://bugs.webkit.org/show_bug.cgi?id=118580
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-07-11
Reviewed by Antonio Gomes.
- team.html:
- 5:50 PM Changeset in webkit [152582] by
-
- 7 edits1 add in trunk/LayoutTests
Replace simple_blank.swf with lines.swf for snapshotting tests.
https://bugs.webkit.org/show_bug.cgi?id=118581.
Reviewed by Tim Horton.
- plugins/resources/lines.swf: Added.
- plugins/snapshotting/autoplay-dominant.html:
- plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html:
- plugins/snapshotting/autoplay-similar-to-dominant.html:
- plugins/snapshotting/plugin-receives-click-event.html:
- plugins/snapshotting/restart.html:
- plugins/snapshotting/simple.html:
- 4:59 PM Changeset in webkit [152581] by
-
- 9 edits in branches/dfgFourthTier/Source/JavaScriptCore
Resurrect the CLoop LLINT on the FTL branch.
https://bugs.webkit.org/show_bug.cgi?id=118144.
Reviewed by Mark Hahnenberg.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::jitType):
- Fix the CodeBlock jitType to be InterpreterThunk when !ENABLE_JIT.
- bytecode/JumpTable.h:
(JSC::SimpleJumpTable::clear):
- interpreter/StackIterator.cpp:
(JSC::StackIterator::Frame::bytecodeOffset):
(JSC::StackIterator::Frame::print):
- jit/JITCode.cpp:
(JSC):
- jit/JITExceptions.cpp:
(JSC::getExceptionLocation):
- llint/LowLevelInterpreter.cpp:
- offlineasm/cloop.rb:
- runtime/Structure.cpp:
- 4:53 PM Changeset in webkit [152580] by
-
- 8 edits2 adds in trunk
Plugins that don't support snapshotting should not all autostart.
https://bugs.webkit.org/show_bug.cgi?id=118572
<rdar://problem/14324391>.
Reviewed by Dean Jackson.
Test: plugins/snapshotting/quicktime-plugin-snapshotted.html
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Pass in information about whether or not a snapshot exists
to the shadow dom.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::shouldNotAddLayer): This method determines whether or not we should add the plugin's layer to the tree.
It should not be added if the plugin is in it's snapshotted state but does not actually support snapshotting.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): We should only add the layer to the tree when the plugin
is actually playing. Otherwise we run into an issue where the contents of the layer initially appear on the screen briefly
on page load before we display the substitute for a plugin that doesn't support snapshotting.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldNotAddLayer): This method determines whether or not we should add the plugin's layer to the tree.
It should not be added if the plugin is in it's snapshotted state but does not actually support snapshotting.
(WebKit::PluginView::pluginSnapshotTimerFired): If the plugin does not support snapshotting go straight
to the the DisplayingSnapshot state.
- WebProcess/Plugins/PluginView.h:
- platform/mac-wk2/plugins/snapshotting/quicktime-plugin-snapshotted-expected.txt: Added.
- plugins/snapshotting/quicktime-plugin-snapshotted.html: Added.
- 3:33 PM Changeset in webkit [152579] by
-
- 5 edits in trunk/Source
[mac] No API for getting the page visibility state of a WebView
https://bugs.webkit.org/show_bug.cgi?id=118578
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.exp.in: Export WebCore::Page::visibilityState().
Source/WebKit/mac:
- WebView/WebView.mm:
(kit): Added. Converts from WebCore::PageVisibilityState to WebPageVisibilityState.
(-[WebView _visibilityState]): Added.
- WebView/WebViewPrivate.h: Declared -_visibilityState.
- 3:27 PM Changeset in webkit [152578] by
-
- 2 edits in trunk/Source/WebKit2
WebResourceCacheManager::cfURLCacheHostNamesWithCallback leaks an array (pointed out by the
clang static analyzer)
https://bugs.webkit.org/show_bug.cgi?id=118533
Reviewed by Anders Carlsson.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):
- 2:57 PM Changeset in webkit [152577] by
-
- 3 edits in trunk/Source/JavaScriptCore
Attempt to fix the windows build.
- 2:40 PM Changeset in webkit [152576] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Added expected failures after r152574.
- platform/gtk/TestExpectations: Added test failures.
- 12:40 PM Changeset in webkit [152575] by
-
- 2 edits in trunk/Source/WebKit2
Use GOwnPtr in PluginProcessProxyUnix to manage stdOut variable
https://bugs.webkit.org/show_bug.cgi?id=118568
Patch by Sergio Correia <Sergio Correia> on 2013-07-11
Reviewed by Martin Robinson.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 11:57 AM Changeset in webkit [152574] by
-
- 4 edits in trunk
[GTK] Layout Test accessibility/deleting-iframe-destroys-axcache.html, platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html are failing
https://bugs.webkit.org/show_bug.cgi?id=118552
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-07-11
Reviewed by Chris Fleizach.
Source/WebCore:
Do not assume always that we have a RenderText renderer when
calling to toRenderText(), since we might be executing that part
of the code due to have requested to include all the children.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Add
missing guard for RenderText, needed after r152537.
LayoutTests:
Remove tests that are no longer expected to crash.
- platform/gtk/TestExpectations: Removed tests.
- 11:35 AM Changeset in webkit [152573] by
-
- 8 edits in trunk
NativeExecutable cache needs to use both call and construct functions for key
https://bugs.webkit.org/show_bug.cgi?id=118545
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Make the native executable cache make use a key pair so we don't decide to
treat all subsequent functions as not being constructors.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
- jit/JITThunks.h:
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
- runtime/JSCell.cpp:
(JSC::JSCell::getCallData):
(JSC::JSCell::getConstructData):
LayoutTests:
Make sure we don't decide that all bound functions aren't constructors.
- fast/js/function-bind-expected.txt:
- fast/js/script-tests/function-bind.js:
- 9:17 AM Changeset in webkit [152572] by
-
- 6 edits4 adds in trunk
[CSS Regions] In a region chain with auto-height regions, lines get their length based only on the first region
https://bugs.webkit.org/show_bug.cgi?id=118531
Reviewed by Alexandru Chiculita.
Source/WebCore:
When computing the height a flow thread it's possible to overflow the maximum LayoutUnit and obtain a negative value.
This leads to invalid results during layout when computing the region range and the RenderBoxRegion info for the
descendant boxes of the flow thread.
This issue appears especially during the auto-height algorithm because it initializes the auto-height regions
height with the LayoutUnit::max() / 2 value. Summing two such regions overflows and results in a negative value.
The fix clamps the maximum height of the flow thread to LayoutUnit::max() / 2. This doesn't affect the auto-height
algorithm because regionAtBlockOffset() will still return the correct values as the auto-height regions content
is established and their height updated.
Tests: fast/regions/autoheight-correct-region-for-lines-2.html
fast/regions/autoheight-correct-region-for-lines.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::maxPageLogicalHeight):
LayoutTests:
Add tests verifying the lines widths are correctly computed in auto-height regions with and without a max-height set.
- fast/regions/autoheight-correct-region-for-lines-2-expected.html: Added.
- fast/regions/autoheight-correct-region-for-lines-2.html: Added.
- fast/regions/autoheight-correct-region-for-lines-expected.html: Added.
- fast/regions/autoheight-correct-region-for-lines.html: Added.
- 8:43 AM Changeset in webkit [152571] by
-
- 12 edits in trunk/Source
Revert r152267 and soft link WebInspectorUI.framework again.
https://bugs.webkit.org/show_bug.cgi?id=118544
Reviewed by David Kilzer.
Source/WebCore:
- platform/mac/SoftLinking.h: Rename SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL
to SOFT_LINK_STAGED_FRAMEWORK and ASSERT since we don't want to silently
fail anymore when using this macro.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
Source/WebKit2:
- Configurations/WebKit2.xcconfig:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- 8:17 AM Changeset in webkit [152570] by
-
- 5 edits in trunk/Source
[Coordinated Graphics] Parameter of commitSceneState should be const
https://bugs.webkit.org/show_bug.cgi?id=118564
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-11
Reviewed by Noam Rosenthal.
Parameter of commitSceneState should be const as there should not be any
modifications to the passed CoordinatedGraphicsState.
Source/WebCore:
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 7:54 AM Changeset in webkit [152569] by
-
- 14 edits2 adds2 deletes in trunk
NamedFlowCollection getters should follow the same pattern as HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=118561
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-11
Reviewed by Christophe Dumez.
Source/WebCore:
Modified item and namedItem methods from DOMNamedFlowCollection to return null instead of undefined.
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22617
Completely removed the TreatReturnedNullObjectAs attribute as it was only used by the DOMNamedFlowCollection interface.
Test: fast/regions/webkit-named-flow-collection-empty-getters.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementationFunctionCall):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::treatReturnedNullObjectAsUndefined):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_treat_returned_null_object_as_undefined):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTreatReturnedNullObjectAsUndefined):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj treatReturnedNullObjectAsUndefined]):
- bindings/scripts/test/TestObj.idl:
- dom/DOMNamedFlowCollection.idl:
LayoutTests:
Updated test for NamedFlowCollection getters when no named flows are created.
- fast/regions/webkit-named-flow-collection-empty-getters-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-undefined-expected.txt.
- fast/regions/webkit-named-flow-collection-empty-getters.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-undefined.html.
- 7:45 AM Changeset in webkit [152568] by
-
- 2 edits in trunk/Source/WebCore
Revert r149313: Don't check for @media rules affected by viewport changes in every layout.
<rdar://problem/14277905>
Rubber-stamped by Antti Koivisto.
This changed caused more harm than good. setFrameRect() is not the only path in FrameView
that can cause media queries to need invalidation.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::layout):
- 6:56 AM WebKitIDL edited by
- (diff)
- 5:43 AM Changeset in webkit [152567] by
-
- 4 edits in trunk/Source/WebCore
Introduce isHTMLTitleElement and toHTMLTitleElement
https://bugs.webkit.org/show_bug.cgi?id=118558
Reviewed by Andreas Kling.
To enhance readability, this patch introduces isHTMLTitleElement and toHTMLTitleElement.
This also helps out to reduce duplicated use of static_cast.
- dom/Document.cpp:
(WebCore::Document::setTitle):
(WebCore::Document::removeTitle):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::removeHeadContents):
- html/HTMLTitleElement.h:
(WebCore::isHTMLTitleElement):
(WebCore::toHTMLTitleElement):
- 4:43 AM Changeset in webkit [152566] by
-
- 2 edits6 deletes in trunk/Source
Remove unused Windows CE files
https://bugs.webkit.org/show_bug.cgi?id=118557
Reviewed by Andreas Kling.
Source/WebCore:
- platform/wince/CursorWinCE.cpp: Removed.
- platform/wince/PasteboardWinCE.cpp: Removed.
- platform/wince/SearchPopupMenuWinCE.cpp: Removed.
Source/WTF:
- wtf/wince/FastMallocWinCE.h: Removed.
- wtf/wince/MemoryManager.cpp: Removed.
- wtf/wince/MemoryManager.h: Removed.
- 4:19 AM Changeset in webkit [152565] by
-
- 16 edits11 copies3 moves4 adds in trunk/Source/WebCore
Get rid of SVGPathSeg* special casing in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=118525
Reviewed by Kentaro Hara.
Have one header per SVGPathSeg* type so that we no longer need special casing
for them in the JSC bindings generator.
No new tests, no behavior change.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSVGPathSegCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(NativeToJSValue):
- svg/SVGPathElement.cpp:
- svg/SVGPathSegArc.h:
- svg/SVGPathSegArcAbs.h: Added.
(WebCore::SVGPathSegArcAbs::create):
(WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
(WebCore::SVGPathSegArcAbs::pathSegType):
(WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter):
- svg/SVGPathSegArcRel.h: Added.
(WebCore::SVGPathSegArcRel::create):
(WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
(WebCore::SVGPathSegArcRel::pathSegType):
(WebCore::SVGPathSegArcRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubic.h:
- svg/SVGPathSegCurvetoCubicAbs.h: Added.
(WebCore::SVGPathSegCurvetoCubicAbs::create):
(WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicRel.h: Added.
(WebCore::SVGPathSegCurvetoCubicRel::create):
(WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicSmooth.h:
- svg/SVGPathSegCurvetoCubicSmoothAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoCubicSmooth.h.
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoCubicSmoothRel.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoCubicSmooth.h.
(WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadratic.h:
- svg/SVGPathSegCurvetoQuadraticAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadratic.h.
(WebCore::SVGPathSegCurvetoQuadraticAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticRel.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadratic.h.
(WebCore::SVGPathSegCurvetoQuadraticRel::create):
(WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.h: Copied from Source/WebCore/svg/SVGPathSegCurvetoQuadraticSmooth.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter):
- svg/SVGPathSegCurvetoQuadraticSmoothRel.h: Renamed from Source/WebCore/svg/SVGPathSegCurvetoQuadraticSmooth.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoAbs.h: Copied from Source/WebCore/svg/SVGPathSegLineto.h.
(WebCore::SVGPathSegLinetoAbs::create):
(WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
(WebCore::SVGPathSegLinetoAbs::pathSegType):
(WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoHorizontal.h:
- svg/SVGPathSegLinetoHorizontalAbs.h: Copied from Source/WebCore/svg/SVGPathSegLinetoHorizontal.h.
(WebCore::SVGPathSegLinetoHorizontalAbs::create):
(WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoHorizontalRel.h: Copied from Source/WebCore/svg/SVGPathSegLinetoHorizontal.h.
(WebCore::SVGPathSegLinetoHorizontalRel::create):
(WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoRel.h: Renamed from Source/WebCore/svg/SVGPathSegLineto.h.
(WebCore::SVGPathSegLinetoRel::create):
(WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
(WebCore::SVGPathSegLinetoRel::pathSegType):
(WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoVertical.h:
- svg/SVGPathSegLinetoVerticalAbs.h: Copied from Source/WebCore/svg/SVGPathSegLinetoVertical.h.
(WebCore::SVGPathSegLinetoVerticalAbs::create):
(WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegType):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter):
- svg/SVGPathSegLinetoVerticalRel.h: Copied from Source/WebCore/svg/SVGPathSegLinetoVertical.h.
(WebCore::SVGPathSegLinetoVerticalRel::create):
(WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegType):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter):
- svg/SVGPathSegListBuilder.cpp:
- svg/SVGPathSegMovetoAbs.h: Copied from Source/WebCore/svg/SVGPathSegMoveto.h.
(WebCore::SVGPathSegMovetoAbs::create):
(WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
(WebCore::SVGPathSegMovetoAbs::pathSegType):
(WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter):
- svg/SVGPathSegMovetoRel.h: Renamed from Source/WebCore/svg/SVGPathSegMoveto.h.
(WebCore::SVGPathSegMovetoRel::create):
(WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
(WebCore::SVGPathSegMovetoRel::pathSegType):
(WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter):
- 3:53 AM Changeset in webkit [152564] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r152426.
- config.h:
- 3:28 AM Changeset in webkit [152563] by
-
- 2 edits in trunk/Source/WebCore
[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont
https://bugs.webkit.org/show_bug.cgi?id=118532
Patch by Fabienne Semeria <fsemeria@nds.com> on 2013-07-11
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- 2:09 AM Changeset in webkit [152562] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Added crash expectations in debug builds after r152537
- platform/gtk/TestExpectations: Added two crashing tests.
- 1:36 AM Changeset in webkit [152561] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Refactor code for translating offsets between WebCore a11y and ATK
https://bugs.webkit.org/show_bug.cgi?id=118179
Reviewed by Chris Fleizach.
Encapsulate better and make more clear the translation of offsets
between our ATK implementation and WebCore's accessibility layer.
Values for offsets can differ sometimes between those two worlds
due to some extra flattening we need to do in ATK based ports to
properly expose the accessibility hierarchy to ATs, which
sometimes means adding extra text elements in the exposed text
through the AtkText interface (e.g. list items markers).
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(offsetAdjustmentForListItem): Helper function to refactor code
needed to translate offsets from WebCore to ATK worlds. Currently
related to considering list item markers in LTR text only.
(webCoreOffsetToAtkOffset): Convenience function for code
readability purposes. It just calls offsetAdjustmentForListItem.
(atkOffsetToWebCoreOffset): Likewise.
(getSelectionOffsetsForObject): Use webCoreOffsetToAtkOffset.
(webkitAccessibleTextGetCaretOffset): Use webCoreOffsetToAtkOffset
to translate an offset from WebCore to ATK before returning it.
(webkitAccessibleTextSetSelection): Use atkOffsetToWebCoreOffset
to translate an offset from WebCore to ATK before using it.
(webkitAccessibleTextSetCaretOffset): Likewise.
- 12:00 AM Changeset in webkit [152560] by
-
- 2 edits in trunk/Tools
Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=118538
Patch by Sergio Correia <Sergio Correia> on 2013-07-10
Reviewed by Christophe Dumez.
When attempting some odd url such as
foo, MiniBrowser will now show an
error message such as "Cannot resolve hostname (foo)".
Previously, it had the following behavior if MiniBrowser was started with
such urls, e.g./MiniBrowser foo:
- Debug:
It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
- Release:
No asserts, naturally, but the view would remain blank, even if we tried to
change to a valid url.
- MiniBrowser/efl/main.c:
(window_create):
