Context Navigation

← Previous Period
Next Period →

Timeline

Jul 13, 2013:

11:12 PM Changeset in webkit [152613] by commit-queue@webkit.org

12 edits in trunk/Source

Unreviewed, rolling out r151978.
http://trac.webkit.org/changeset/151978
https://bugs.webkit.org/show_bug.cgi?id=118651

Caused regressions at least 3 websites (Requested by rniwa on
#webkit).

Source/JavaScriptCore:

runtime/JSCJSValue.h:
runtime/JSString.h:

Source/WebCore:

bindings/js/JSDOMBinding.cpp:
bindings/js/JSDOMBinding.h:
bindings/scripts/CodeGeneratorJS.pm:

(GetNativeTypeFromSignature):
(JSValueToNative):

bindings/scripts/IDLAttributes.txt:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):

dom/Document.idl:
dom/Element.idl:
dom/Node.idl:

11:03 PM Changeset in webkit [152612] by joone.hur@intel.com

4 edits
5 adds in trunk

Caret should respect text background color
https://bugs.webkit.org/show_bug.cgi?id=117493

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch allows the caret to become visible in the black background
by getting the caret color from the color of the element containing
the text, not the parent element that has the contentEditable attribute.

Test: editing/caret/caret-color.html

editing/FrameSelection.cpp:

(WebCore::CaretBase::paintCaret):

LayoutTests:

This tests to make sure that the caret is visible in the black background
by getting the caret color from the color of the element(span) containing
the text, not the parent element(div) that has the contentEditable
attribute.

editing/caret/caret-color-expected.txt: Added.
editing/caret/caret-color.html: Added.
platform/efl/editing/caret/caret-color-expected.png: Added.
platform/mac/TestExpectations: Skip this test case.

6:11 PM Changeset in webkit [152611] by rniwa@webkit.org

8 edits in trunk/Source/WebCore

Avoid upconverting strings in various places in WebCore
https://bugs.webkit.org/show_bug.cgi?id=118632

Reviewed by Andreas Kling.

Avoid calling String::characters() in various places since it upconverts 8-bit strings to 16-bit strings.

Merge
https://chromium.googlesource.com/chromium/blink/+/a6162e2ad7c7870e22445d3c463d17e7ac871e80
https://chromium.googlesource.com/chromium/blink/+/18095209b3f467758b83894e7b14f813f6953f81
https://chromium.googlesource.com/chromium/blink/+/fefcf2b95d55f24c60fd2e95978cf4544f3c92ca
https://chromium.googlesource.com/chromium/blink/+/8e0527b0fb33998318aedfd74b3511025f7ff294
https://chromium.googlesource.com/chromium/blink/+/feaf798b04597b0849b4000fc305264895d3eac5
https://chromium.googlesource.com/chromium/blink/+/bd1a49103a6e07b1023d2c742d8217769efbffb4

css/CSSParser.cpp:

(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::rewriteSpecifiers):

css/CSSParserValues.h:

(WebCore::CSSParserString::init):
(WebCore::CSSParserString::clear):

dom/DatasetDOMStringMap.cpp:

(WebCore::isValidAttributeName):
(WebCore::convertAttributeNameToPropertyName):
(WebCore::propertyNameMatchesAttributeName):
(WebCore::isValidPropertyName):
(WebCore::convertPropertyNameToAttributeName):

dom/Range.cpp:

(WebCore::Range::toString):

dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::measureText):

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes):

8:32 AM Changeset in webkit [152610] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

parseHTMLInteger shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118629

Reviewed by Sam Weinig.

Merge https://chromium.googlesource.com/chromium/blink/+/e0ebab23e0c16b49dc90c9c39b8bbbf4f243a01e.

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLInteger):

Jul 12, 2013:

8:44 PM Changeset in webkit [152609] by kseo@webkit.org

2 edits in trunk/Tools

Unreviewed. Add an email address and update my domain of experts.

Scripts/webkitpy/common/config/contributors.json:

4:59 PM Changeset in webkit [152608] by jberlin@webkit.org

4 edits in trunk/Source/WebKit/mac

Remove some dead stores pointed out by the clang static analyzer.
https://bugs.webkit.org/show_bug.cgi?id=118608

Reviewed by Anders Carlsson.

Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin):
kr is never read after this point, so there is no reason to assign to it.

Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage getPluginInfoFromPLists]):
The extensions array is only used in the while loop. Move the declaration to the first place
it is used in the while loop. Since it is always reassigned at that location, and since it
is never read after the subsequent for loop, the assignment to an array containing the empty
string is never used. Remove it.
Similarly, the value of the description is always overwritten before used to assign to
mimeClassInfo.desc or to pluginInfo.desc, so the code to assign it to the empty string is
never used. Remove it.

WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController _placePopupWindow:]):
maxWidth is never read (and never was since it was added in r7311) after it is used on the
line above to set windowFrame.size.width.

4:35 PM Changeset in webkit [152607] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[iOS] TextTrackRepresentation not cleared when captions are disabled
https://bugs.webkit.org/show_bug.cgi?id=118623

Reviewed by Dean Jackson.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Do not return immediately

when captions are disabled so the necessary cleanup happens.

3:37 PM Changeset in webkit [152606] by commit-queue@webkit.org

4 edits in trunk

Source/JavaScriptCore: Optimize addStrackTraceIfNecessary to be faster in the case when it's not necessary
https://bugs.webkit.org/show_bug.cgi?id=118328

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-12
Reviewed by Geoffrey Garen.

Retrieving the stack is costly. We want to get it only once. By moving the check
for the .stack property above the code to retrieve the stack, we ensure this.

interpreter/Interpreter.cpp:

(JSC::Interpreter::addStackTraceIfNecessary):

LayoutTests: By optimizing when the stack is added a two tests needed to be modifed to show correct results.
https://bugs.webkit.org/show_bug.cgi?id=118328

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-12
Reviewed by Geoffrey Garen.

inspector/console/console-exception-stack-traces.html: This test compares the console's currect

stack with the error object's stack. The test was failing on decodeURI() and eval() which create
a new frame on the stack to execute. The console's stack was unaware of these calls and the size
of the stacks would not match. I added a check to pass if it was the specific case with decodeURI
or eval.

1:05 PM Changeset in webkit [152605] by commit-queue@webkit.org

2 edits in trunk/Tools

[jhbuild] Avoid restarting from scratch failed initial checkouts
https://bugs.webkit.org/show_bug.cgi?id=118603

Patch by Emanuele Aina <Emanuele Aina> on 2013-07-12
Reviewed by Martin Robinson.

If the initial checkout is interrupted midway (eg. because the internet
connection went down) config files do not get generated and that causes
the next checkout to start from scratch (the missing files cause the
script to delete the build root and the downloaded sources).

By generating the files before invoking jhbuild, subsequent runs are able
to start where the previous run left.

Scripts/update-webkit-libs-jhbuild:

(saveJhbuildMd5): invoke it before runJhbuild().

12:51 PM Changeset in webkit [152604] by Brent Fulgham

2 edits in trunk/Tools

[Windows] Remove single-worker restriction on tests.

Scripts/webkitpy/port/win.py: Remove restriction of one worker.

12:30 PM Changeset in webkit [152603] by Brent Fulgham

3 edits in trunk/Source/WebCore

[Windows] Attempt to satisfy the Open Source Windows bots.

DerivedSources.make: Restore the HAVE_AVCF macro detection.
config.h: Return to using HAVE_AVCF to activate AVFoundation code.

12:05 PM Changeset in webkit [152602] by commit-queue@webkit.org

3 edits
1 delete in trunk/Tools

Unreviewed, rolling out r152599.
http://trac.webkit.org/changeset/152599
https://bugs.webkit.org/show_bug.cgi?id=118612

This patch includes a failing unit test (Requested by
mrobinson on #webkit).

Scripts/webkitpy/style/checkers/python.py:

(Pylinter):

Scripts/webkitpy/style/checkers/python_unittest.py:

(PythonCheckerTest.test_check):

Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.

11:57 AM Changeset in webkit [152601] by commit-queue@webkit.org

2 edits in trunk/Tools

[Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=91223

Patch by Emanuele Aina <Emanuele Aina> on 2013-07-12
Reviewed by Martin Robinson.

When run on a clean checkout, build-webkit complains that no
GNUmakefile exists when trying to detect the previously configured
architecture, but in this case there's no previous configuration so
the warning is pointless.

Scripts/webkitdirs.pm:

(determineArchitecture): Redirect grep stderr to /dev/null.

11:54 AM Changeset in webkit [152600] by Brent Fulgham

2 edits in trunk/Source/JavaScriptCore

[Windows] Build correction after r152573/r152577.
https://bugs.webkit.org/show_bug.cgi?id=118610

Reviewed by Oliver Hunt.

jit/JITThunks.cpp:

(JSC::JITThunks::hostFunctionStub): Hand-feed MSVC++ the fact that we want the second
argument of the make_pair to be a function pointer.

11:36 AM Changeset in webkit [152599] by commit-queue@webkit.org

3 edits
1 add in trunk/Tools

check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
https://bugs.webkit.org/show_bug.cgi?id=118592

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-12
Reviewed by Martin Robinson.

Added a suppression for pylint false positives and a unit test.

Scripts/webkitpy/style/checkers/python.py:

(Pylinter):

Scripts/webkitpy/style/checkers/python_unittest.py:

(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):

Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.

(test_popen):

11:31 AM Changeset in webkit [152598] by timothy@apple.com

17 edits in trunk/Source/WebInspectorUI

Update CodeMirror to 7f560afa1c (3.14+).

https://bugs.webkit.org/show_bug.cgi?id=118605

Reviewed by Sam Weinig.

Tools/PrettyPrinting/CodeMirrorFormatters.js:
Tools/PrettyPrinting/Formatter.js:
Tools/PrettyPrinting/FormatterContentBuilder.js:
Tools/PrettyPrinting/codemirror.css:
Tools/PrettyPrinting/codemirror.js:
Tools/PrettyPrinting/css.js:
Tools/PrettyPrinting/javascript.js:
UserInterface/External/CodeMirror/codemirror.css:
UserInterface/External/CodeMirror/codemirror.js:
UserInterface/External/CodeMirror/coffeescript.js:
UserInterface/External/CodeMirror/comment.js:
UserInterface/External/CodeMirror/css.js:
UserInterface/External/CodeMirror/javascript.js:
UserInterface/External/CodeMirror/matchbrackets.js:
UserInterface/External/CodeMirror/sql.js:
UserInterface/External/CodeMirror/xml.js:

10:56 AM Changeset in webkit [152597] by Lucas Forschler

1 copy in tags/Safari-537.50

New Tag.

10:53 AM Changeset in webkit [152596] by a.renevier@samsung.com

2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

9:40 AM Changeset in webkit [152595] by mikhail.pozdnyakov@intel.com

2 edits in trunk/Source/WTF

Improve StringImpl::constructInternal() method
https://bugs.webkit.org/show_bug.cgi?id=118503

Reviewed by Benjamin Poulain.

StringImpl::constructInternal used 'if ()' statement to decide which constructor
to invoke hence compiler had to compile both branches even though optimizer would
have then removed one of those, and as the function is inline it could affect
slightly the compilation time.

The problem is solved via template specialization.

wtf/text/StringImpl.h:

(WTF::LChar):
(WTF::UChar):

9:36 AM Changeset in webkit [152594] by Lucas Forschler

12 edits in branches/safari-537-branch/Source

Merged r152571. <rdar://problem/14364171>

9:28 AM Changeset in webkit [152593] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=118461

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-12
Reviewed by Brent Fulgham.

config.h: Only enable AVFOUNDATION for Windows if CoreGraphics is used.

9:28 AM Changeset in webkit [152592] by Lucas Forschler

5 edits in branches/safari-537-branch/Source

Versioning.

7:42 AM Changeset in webkit [152591] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL] --minimal build fails while linking libwebcore_efl.so
https://bugs.webkit.org/show_bug.cgi?id=118549

Patch by Oleg Beletski <oleg.beletski@gmail.com> on 2013-07-12
Reviewed by Christophe Dumez.

CMakeLists.txt:

Moving file plugins/PluginPackage.cpp to ENABLE_NETSCAPE_PLUGIN_API block.

6:16 AM Changeset in webkit [152590] by zarvai@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping new failing test on Qt.
https://bugs.webkit.org/show_bug.cgi?id=118595

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-12

platform/qt/TestExpectations:

5:55 AM Changeset in webkit [152589] by Csaba Osztrogonác

4 edits in trunk/LayoutTests

Unreviewed typo fix.

fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
fast/css-grid-layout/grid-element-change-columns-repaint.html:
platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:

5:45 AM Changeset in webkit [152588] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Pass null for sidebarPanels and role in WebInspector.Sidebar()
https://bugs.webkit.org/show_bug.cgi?id=118589

Patch by Seokju Kwon <Seokju Kwon> on 2013-07-12
Reviewed by Timothy Hatcher.

sidebarPanels : It is necessary to get correct argument after r152141.
Without this, error messages can be displayed.
role : Could pass null for it since default value is "group".