⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 14, 2013:

11:41 PM Changeset in webkit [152624] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebInspectorUI

Unreviewed, rolling out r152598.
http://trac.webkit.org/changeset/152598
https://bugs.webkit.org/show_bug.cgi?id=118658

totally broke the web inspector (JS ERROR: SyntaxError:
Expected token '}') (Requested by thorton on #webkit).

  • Tools/PrettyPrinting/CodeMirrorFormatters.js:
  • Tools/PrettyPrinting/Formatter.js:
  • Tools/PrettyPrinting/FormatterContentBuilder.js:
  • Tools/PrettyPrinting/codemirror.css:

(.CodeMirror-scrollbar-filler):
(.CodeMirror-gutters):
(.CodeMirror-vscrollbar, .CodeMirror-hscrollbar, .CodeMirror-scrollbar-filler):
(.CodeMirror-widget):

  • Tools/PrettyPrinting/codemirror.js:

(window.CodeMirror):
(window.CodeMirror.):
(.do):
(moveVisually):

  • Tools/PrettyPrinting/css.js:

(.):
(CodeMirror):

  • Tools/PrettyPrinting/javascript.js:

(.):

  • UserInterface/External/CodeMirror/codemirror.css:

(.CodeMirror-widget):

  • UserInterface/External/CodeMirror/codemirror.js:

(window.CodeMirror):
(window.CodeMirror.):

  • UserInterface/External/CodeMirror/coffeescript.js:
  • UserInterface/External/CodeMirror/comment.js:

(.):

  • UserInterface/External/CodeMirror/css.js:

(.):
(CodeMirror):

  • UserInterface/External/CodeMirror/javascript.js:

(.):

  • UserInterface/External/CodeMirror/matchbrackets.js:

(.):

  • UserInterface/External/CodeMirror/sql.js:
  • UserInterface/External/CodeMirror/xml.js:
11:11 PM Changeset in webkit [152623] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Origins with invalid ports are not marked as unique (118652)
https://bugs.webkit.org/show_bug.cgi?id=118652
<rdar://problem/14437753>

Reviewed by Sam Weinig.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::create): Return a unique origin if the port is out of range.

6:27 PM Changeset in webkit [152622] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Another Qt build fix attempt after r152619.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

6:22 PM Changeset in webkit [152621] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt build fix attempt after r152619.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

6:01 PM Changeset in webkit [152620] by kseo@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add Company100 to team.html
https://bugs.webkit.org/show_bug.cgi?id=118633

Reviewed by Andreas Kling.

  • team.html:
5:47 PM Changeset in webkit [152619] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix attempt after r152615.

  • svg/SVGFilterElement.h:
5:45 PM Changeset in webkit [152618] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299

Reviewed by Andreas Kling.

Address Ben's review comment.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

5:35 PM Changeset in webkit [152617] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

apply-style-command-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118634

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/a30dad44ded92d24ed56761434cf6041688659a0.

Also replace CRLF to LF and get rid of svn:executable.

  • editing/execCommand/apply-style-command-crash.html:
7:49 AM Changeset in webkit [152616] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLTextFormControlElement::valueWithHardLineBreaks shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118631

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/2c7c70a7bd3d61bfbf97de95c459ec9f40b46e31.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

6:59 AM Changeset in webkit [152615] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Add toSVGFilterElement() and use it.
https://bugs.webkit.org/show_bug.cgi?id=118653

Reviewed by Ryosuke Niwa.

We can use toSVGFilterElement() instead of using static_cast<..> to improve readability.
Blink also uses it.

No new tests, no behavior change.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::resourceBoundingBox):

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::RenderSVGResourceFilter::filterUnits):
(WebCore::RenderSVGResourceFilter::primitiveUnits):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGFilterElement.h:

(WebCore::toSVGFilterElement):

1:55 AM Changeset in webkit [152614] by kangil.han@samsung.com
  • 10 edits in trunk/Source

Introduce toHTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=118582

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch introduces toHTMLVideoElement.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getPluginProxyParams):

  • html/HTMLVideoElement.h:

(WebCore::toHTMLVideoElement):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::enterFullscreenForVideo):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::videoElement):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::mediaContentUrlByElementId):

  • WebCoreSupport/FullScreenVideoQt.cpp:

(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):

Jul 13, 2013:

11:12 PM Changeset in webkit [152613] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Unreviewed, rolling out r151978.
http://trac.webkit.org/changeset/151978
https://bugs.webkit.org/show_bug.cgi?id=118651

Caused regressions at least 3 websites (Requested by rniwa on
#webkit).

Source/JavaScriptCore:

  • runtime/JSCJSValue.h:
  • runtime/JSString.h:

Source/WebCore:

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetNativeTypeFromSignature):
(JSValueToNative):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):

  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
11:03 PM Changeset in webkit [152612] by joone.hur@intel.com
  • 4 edits
    5 adds in trunk

Caret should respect text background color
https://bugs.webkit.org/show_bug.cgi?id=117493

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch allows the caret to become visible in the black background
by getting the caret color from the color of the element containing
the text, not the parent element that has the contentEditable attribute.

Test: editing/caret/caret-color.html

  • editing/FrameSelection.cpp:

(WebCore::CaretBase::paintCaret):

LayoutTests:

This tests to make sure that the caret is visible in the black background
by getting the caret color from the color of the element(span) containing
the text, not the parent element(div) that has the contentEditable
attribute.

  • editing/caret/caret-color-expected.txt: Added.
  • editing/caret/caret-color.html: Added.
  • platform/efl/editing/caret/caret-color-expected.png: Added.
  • platform/mac/TestExpectations: Skip this test case.
6:11 PM Changeset in webkit [152611] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Avoid upconverting strings in various places in WebCore
https://bugs.webkit.org/show_bug.cgi?id=118632

Reviewed by Andreas Kling.

Avoid calling String::characters() in various places since it upconverts 8-bit strings to 16-bit strings.

Merge
https://chromium.googlesource.com/chromium/blink/+/a6162e2ad7c7870e22445d3c463d17e7ac871e80
https://chromium.googlesource.com/chromium/blink/+/18095209b3f467758b83894e7b14f813f6953f81
https://chromium.googlesource.com/chromium/blink/+/fefcf2b95d55f24c60fd2e95978cf4544f3c92ca
https://chromium.googlesource.com/chromium/blink/+/8e0527b0fb33998318aedfd74b3511025f7ff294
https://chromium.googlesource.com/chromium/blink/+/feaf798b04597b0849b4000fc305264895d3eac5
https://chromium.googlesource.com/chromium/blink/+/bd1a49103a6e07b1023d2c742d8217769efbffb4

  • css/CSSParser.cpp:

(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::rewriteSpecifiers):

  • css/CSSParserValues.h:

(WebCore::CSSParserString::init):
(WebCore::CSSParserString::clear):

  • dom/DatasetDOMStringMap.cpp:

(WebCore::isValidAttributeName):
(WebCore::convertAttributeNameToPropertyName):
(WebCore::propertyNameMatchesAttributeName):
(WebCore::isValidPropertyName):
(WebCore::convertPropertyNameToAttributeName):

  • dom/Range.cpp:

(WebCore::Range::toString):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::measureText):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes):

8:32 AM Changeset in webkit [152610] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

parseHTMLInteger shouldn't upconvert 8-bit string
https://bugs.webkit.org/show_bug.cgi?id=118629

Reviewed by Sam Weinig.

Merge https://chromium.googlesource.com/chromium/blink/+/e0ebab23e0c16b49dc90c9c39b8bbbf4f243a01e.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLInteger):

Note: See TracTimeline for information about the timeline view.