⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 15, 2013:

11:55 PM Changeset in webkit [152707] by yutak@chromium.org
  • 4 edits
    3 adds in trunk

Source/WebCore: Fix a crash in Range::processContents().

NULL ptr in WebCore::Range::processAncestorsAndTheirSiblings
​https://bugs.webkit.org/show_bug.cgi?id=77614

Reviewed by Ryosuke Niwa.

This change is ported from Blink revision 153483:
​https://src.chromium.org/viewvc/blink?revision=153483&view=revision

This crash can be initiated by calling Range.detach() while deleteContents()
is processing the same range. Range::processContents() should save the state
of the range since mutation events can change the state of the range.

Test: fast/dom/Range/detach-range-during-deletecontents.html

  • dom/Range.cpp:

(WebCore::Range::processContents):

  • dom/RangeBoundaryPoint.h:

(WebCore::RangeBoundaryPoint::RangeBoundaryPoint):

LayoutTests: NULL ptr in WebCore::Range::processAncestorsAndTheirSiblings
​https://bugs.webkit.org/show_bug.cgi?id=77614

Reviewed by Ryosuke Niwa.

This change is ported from Blink revision 153483:
​https://src.chromium.org/viewvc/blink?revision=153483&view=revision

  • fast/dom/Range/detach-range-during-deletecontents-expected.txt: Added.
  • fast/dom/Range/detach-range-during-deletecontents.html: Added.
  • fast/dom/Range/resources/detach-range-during-deletecontents-iframe.xhtml: Added.
11:32 PM Changeset in webkit [152706] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Add a threading assertion to AtomicString::remove
​https://bugs.webkit.org/show_bug.cgi?id=118695

Reviewed by Sam Weinig.

  • wtf/text/AtomicString.cpp:

(WTF::AtomicString::remove): The destructor of StringImpl remove
the string from the string table if it is atomic. This needs to be done
on the same thread as the one on which the string was added (otherwise the original
table would keep a dangling pointer to a dead string).

10:19 PM Changeset in webkit [152705] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Input element that becomes visible during a simulated click event from an associated label element doesn't get focused
​https://bugs.webkit.org/show_bug.cgi?id=118700

Reviewed by Kent Tamura.

Source/WebCore:

Inspired by ​https://chromium.googlesource.com/chromium/blink/+/6435f70d53403b250e261a914f30d55142f81476.

The bug was caused by isMouseFocusable() check in HTMLLabelElement::defaultEventHandler not updating the layout even
though the call to dispatchSimulatedClick may have dirtied the render tree.

Explicitly update the layout so that we have up-to-date render tree.

Test: fast/forms/label/label-becomes-visible-while-clicking-on-label.html

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::defaultEventHandler):

LayoutTests:

Add a regression test.

  • fast/forms/label/label-becomes-visible-while-clicking-on-label-expected.txt: Added.
  • fast/forms/label/label-becomes-visible-while-clicking-on-label.html: Added.
10:01 PM Changeset in webkit [152704] by kangil.han@samsung.com
  • 11 edits in trunk/Source

Introduce toHTMLIFrameElement
​https://bugs.webkit.org/show_bug.cgi?id=118672

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.

Source/WebCore:

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • dom/Document.cpp:

(WebCore::Document::seamlessParentIFrame):

  • html/HTMLIFrameElement.h:

(WebCore::toHTMLIFrameElement):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::viewCleared):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::isSeamless):
(WebCore::RenderIFrame::flattenFrame):

Source/WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLIFrameElement::contentFrame):

Source/WebKit2:

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):

9:56 PM Changeset in webkit [152703] by timothy_horton@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed rebaselines after r152701.

  • editing/pasteboard/paste-noplugin-expected.txt:
  • http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
  • platform/mac/accessibility/plugin-expected.txt:
9:55 PM Changeset in webkit [152702] by crogers@google.com
  • 12 edits
    9 adds in trunk

Add support for WaveShaperNode.oversample
​https://bugs.webkit.org/show_bug.cgi?id=117435

Reviewed by Kenneth Russell.

Source/WebCore:

Adapted from Blink:
​https://codereview.chromium.org/15619003/

Please see specification for details:
​https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#WaveShaperNode

.oversample specifies what type of oversampling (if any) should be used when applying the shaping curve.
The default value is "none", meaning the curve will be applied directly to the input samples.
A value of "2x" or "4x" can improve the quality of the processing by avoiding some aliasing,
with the "4x" value yielding the highest quality.

Tests: webaudio/waveshaper-oversample-2x.html

webaudio/waveshaper-oversample-4x.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webaudio/WaveShaperDSPKernel.cpp:

(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
(WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
(WebCore::WaveShaperDSPKernel::process):
(WebCore::WaveShaperDSPKernel::processCurve):
(WebCore::WaveShaperDSPKernel::processCurve2x):
(WebCore::WaveShaperDSPKernel::processCurve4x):
(WebCore::WaveShaperDSPKernel::reset):
(WebCore::WaveShaperDSPKernel::latencyTime):

  • Modules/webaudio/WaveShaperDSPKernel.h:
  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setOversample):
(WebCore::WaveShaperNode::oversample):

  • Modules/webaudio/WaveShaperNode.h:

(WebCore::WaveShaperNode::latency):

  • Modules/webaudio/WaveShaperNode.idl:
  • Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::WaveShaperProcessor):
(WebCore::WaveShaperProcessor::setOversample):

  • Modules/webaudio/WaveShaperProcessor.h:

(WebCore::WaveShaperProcessor::oversample):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/DownSampler.cpp: Added.

(WebCore::DownSampler::DownSampler):
(WebCore::DownSampler::initializeKernel):
(WebCore::DownSampler::process):
(WebCore::DownSampler::reset):
(WebCore::DownSampler::latencyFrames):

  • platform/audio/DownSampler.h: Added.
  • platform/audio/UpSampler.cpp: Added.

(WebCore::UpSampler::UpSampler):
(WebCore::UpSampler::initializeKernel):
(WebCore::UpSampler::process):
(WebCore::UpSampler::reset):
(WebCore::UpSampler::latencyFrames):

  • platform/audio/UpSampler.h: Added.

LayoutTests:

  • webaudio/resources/waveshaper-testing.js: Added.

(T0):
(T1):
(T2):
(T3):
(T4):
(generateWaveShapingCurve):
(checkShapedCurve):
(createImpulseBuffer):
(runWaveShaperOversamplingTest):

  • webaudio/waveshaper-oversample-2x-expected.txt: Added.
  • webaudio/waveshaper-oversample-2x.html: Added.
  • webaudio/waveshaper-oversample-4x-expected.txt: Added.
  • webaudio/waveshaper-oversample-4x.html: Added.
9:01 PM Changeset in webkit [152701] by timothy_horton@apple.com
  • 38 edits
    1 add in trunk

Update blocked/missing plug-in UI
​https://bugs.webkit.org/show_bug.cgi?id=118347
<rdar://problem/14209318>

Reviewed by Sam Weinig.
Patch by Anders Carlsson, Antoine Quint, Sam Weinig, and myself.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSDefaultStyleSheets.cpp:
  • css/unavailablePlugIns.css: Added.

Add new Source/WebCore/css/unavailablePlugIns.css stylesheet.

  • dom/EventListener.h:

New event listener type to support the creation of an event listener
for the label and icon for missing / blocked plug-in UI.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
Remove explicit event handling since we're now using a DOM event handler
on the label and icon in the shadow root.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
Don't populate the shadow root with plugin snapshotting elements
if we're not planning on showing a snapshot, because this means that
the shadow root was created for the unavailable plugin indicator instead.

  • page/ChromeClient.h:

(WebCore::ChromeClient::shouldUnavailablePluginMessageIncludeButton):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::shouldUnavailablePluginMessageIncludeButton):
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.

(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonDescription):
Set custom text to be displayed in the unavailability indicator.

(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginButtonClickEvent):
(WebCore::RenderEmbeddedObject::willBeDestroyed):
(WebCore::RenderEmbeddedObject::isReplacementObscured):
(WebCore::RenderEmbeddedObjectEventListener::handleEvent):
(WebCore::RenderEmbeddedObjectEventListener::operator==):
Remove the old code used to render the missing / blocked plug-in UI in C++ in favor
of populating a shadow root in setPluginUnavailabilityReason(). We add a DOM event
listener in the shadow root to eventually call into unavailablePluginButtonClicked()
on the ChromeClient.

(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::layout):
Paint and lay out UA shadow root children.

(WebCore::RenderEmbeddedObject::canHaveChildren):
canHaveChildren can use the existence of a UA shadow root to decide
whether a RenderEmbeddedObject can have children.

  • rendering/RenderEmbeddedObject.h:

(WebCore::RenderEmbeddedObjectEventListener::create):
(WebCore::RenderEmbeddedObjectEventListener::cast):
(WebCore::RenderEmbeddedObjectEventListener::RenderEmbeddedObjectEventListener):
Create the new event listener class necessary to handle events in the shadow root.

(WebCore::RenderEmbeddedObject::pluginUnavailabilityReasonDescription): Added.

  • rendering/RenderWidget.h:

Promote willBeDestroyed() to be public so we may override it in the RenderEmbeddedObject subclass.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldUnavailablePluginMessageIncludeButton):
Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add a 6 argument -> 4 reply message handler.
(It seems that FindPlugin is getting a little out of hand.)

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::pluginLoadPolicy):

  • UIProcess/WebLoaderClient.h:

Add an unavailability description out-argument to a new version of
pluginLoadPolicy, so clients can override the text of the unavailable
plugin indicator. Bump the WKPageLoaderClient version and update APIClientTraits.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Plumb the unavailability description through to the WebProcess via
the FindPlugin message.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didClose):
Make a strongly referencing copy of the list of PluginProxies, so we can
throw them away without the HashMap being mutated underneath us (see the comment).

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginProcessCrashed):
Invalidate the plug-in's widget before setting the plugin unavailability reason,
because doing so would cause the plug-in's renderer to be torn down, making
invalidate() crash.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldUnavailablePluginMessageIncludeButton):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Rename from shouldUnavailablePluginMessageBeButton to
shouldUnavailablePluginMessageIncludeButton for accuracy.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Acquire the unavailability description from the client
(via FindPlugin) and hand it to the RenderEmbeddedObject.
(WebKit::WebPage::canPluginHandleResponse):
Re-acquire the plugin's renderer, in case setPluginUnavailabilityReason destroyed it.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
Match new WKPageLoaderClient entry.

8:56 PM Changeset in webkit [152700] by kseo@webkit.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed. Add Gwang Yoon Hwang to contributor list.

8:32 PM Changeset in webkit [152699] by jpfau@apple.com
  • 2 edits in trunk/LayoutTests

Mark svg/custom/xlink-prefix-in-attributes.html as failing on Mac
​https://bugs.webkit.org/show_bug.cgi?id=118701

Unreviewed, changing test expectations

  • platform/mac/TestExpectations:
7:36 PM Changeset in webkit [152698] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

PluginProcess deny file-read-data /Library/Application Support/Macromedia/FlashPlayerTrust
​https://bugs.webkit.org/show_bug.cgi?id=118690
<rdar://problem/14255963>

Patch by Simon Cooper <​scooper@apple.com> on 2013-07-15
Reviewed by Dean Jackson.

Silently deny access to FlashPlayerTrust. This location contains
files containing lists of paths that Flash Player will
"allow" access to (without asking the user). Since the plugin
sandbox won't permit the access to the listed paths it is better
to silently block attempts to read these "whitelists". The
"whitelists" are created by other Adobe "installer" like
applications.

  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
7:24 PM Changeset in webkit [152697] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

7:22 PM Changeset in webkit [152696] by Lucas Forschler
  • 1 copy in tags/Safari-537.51

New Tag.

7:17 PM Changeset in webkit [152695] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

7:00 PM Changeset in webkit [152694] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-537-branch/Tools

Merged r152498. <rdar://problem/13686836>

6:44 PM Changeset in webkit [152693] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source

Merged r152689. <rdar://problem/14446014>

6:34 PM Changeset in webkit [152692] by fpizlo@apple.com
  • 45 edits
    18 adds in branches/dfgFourthTier/Source

fourthTier: DFG should have an SSA form for use by FTL
​https://bugs.webkit.org/show_bug.cgi?id=118338

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Adds an SSA form to the DFG. We can convert ThreadedCPS form into SSA form
after breaking critical edges. The conversion algorithm follows Aycock and
Horspool, and the SSA form itself follows something I've done before, where
instead of having Phi functions specify input nodes corresponding to block
predecessors, we instead have Upsilon functions in the predecessors that
specify which value in that block goes into which subsequent Phi. Upsilons
don't have to dominate Phis (usually they don't) and they correspond to a
non-SSA "mov" into the Phi's "variable". This gives all of the good
properties of SSA, while ensuring that a bunch of CFG transformations don't
have to be SSA-aware.

So far the only DFG phases that are SSA-aware are DCE and CFA. CFG
simplification is probably SSA-aware by default, though I haven't tried it.
Constant folding probably needs a few tweaks, but is likely ready. Ditto
for CSE, though it's not clear that we'd want to use block-local CSE when
we could be doing GVN.

Currently only the FTL can generate code from the SSA form, and there is no
way to convert from SSA to ThreadedCPS or LoadStore. There probably will
never be such a capability.

In order to handle OSR exit state in the SSA, we place MovHints at Phi
points. Other than that, you can reconstruct state-at-exit by forward
propagating MovHints. Note that MovHint is the new SetLocal in SSA.
SetLocal and GetLocal only survive into SSA if they are on captured
variables, or in the case of flushes. A "live SetLocal" will be
NodeMustGenerate and will always correspond to a flush. Computing the
state-at-exit requires running SSA liveness analysis, OSR availability
analysis, and flush liveness analysis. The FTL runs all of these prior to
generating code. While OSR exit continues to be tricky, much of the logic
is now factored into separate phases and the backend has to do less work
to reason about what happened outside of the basic block that is being
lowered.

Conversion from DFG SSA to LLVM SSA is done by ensuring that we generate
code in depth-first order, thus guaranteeing that a node will always be
lowered (and hence have a LValue) before any of the blocks dominated by
that node's block have code generated. For Upsilon/Phi, we just use
alloca's. We could do something more clever there, but it's probably not
worth it, at least not now.

Finally, while the SSA form is currently only being converted to LLVM IR,
there is nothing that prevents us from considering other backends in the
future - with the caveat that this form is designed to be first lowered to
a lower-level SSA before actual machine code generation commences. So we
ought to either use LLVM (the intended path) or we will have to write our
own SSA low-level backend.

This runs all of the code that the FTL was known to run previously. No
change in performance for now. But it does open some exciting
possibilities!

(JSC::OperandValueTraits::dump):
(JSC::Operands::fill):
(Operands):
(JSC::Operands::clear):
(JSC::Operands::operator==):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::setLiveValues):
(DFG):
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::merge):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::justOneChild):
(AdjacencyList):

  • dfg/DFGBasicBlock.cpp: Added.

(DFG):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::~BasicBlock):
(JSC::DFG::BasicBlock::ensureLocals):
(JSC::DFG::BasicBlock::isInPhis):
(JSC::DFG::BasicBlock::isInBlock):
(JSC::DFG::BasicBlock::removePredecessor):
(JSC::DFG::BasicBlock::replacePredecessor):
(JSC::DFG::BasicBlock::dump):
(JSC::DFG::BasicBlock::SSAData::SSAData):
(JSC::DFG::BasicBlock::SSAData::~SSAData):

  • dfg/DFGBasicBlock.h:

(BasicBlock):
(JSC::DFG::BasicBlock::operator[]):
(JSC::DFG::BasicBlock::successor):
(JSC::DFG::BasicBlock::successorForCondition):
(SSAData):

  • dfg/DFGBasicBlockInlines.h:

(DFG):

  • dfg/DFGBlockInsertionSet.cpp: Added.

(DFG):
(JSC::DFG::BlockInsertionSet::BlockInsertionSet):
(JSC::DFG::BlockInsertionSet::~BlockInsertionSet):
(JSC::DFG::BlockInsertionSet::insert):
(JSC::DFG::BlockInsertionSet::insertBefore):
(JSC::DFG::BlockInsertionSet::execute):

  • dfg/DFGBlockInsertionSet.h: Added.

(DFG):
(BlockInsertionSet):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run):

  • dfg/DFGCFGSimplificationPhase.cpp:
  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):

  • dfg/DFGCommon.cpp:

(WTF::printInternal):

  • dfg/DFGCommon.h:

(JSC::DFG::doesKill):
(DFG):
(JSC::DFG::killStatusForDoesKill):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::isCapturedAtOrAfter):

  • dfg/DFGCriticalEdgeBreakingPhase.cpp: Added.

(DFG):
(CriticalEdgeBreakingPhase):
(JSC::DFG::CriticalEdgeBreakingPhase::CriticalEdgeBreakingPhase):
(JSC::DFG::CriticalEdgeBreakingPhase::run):
(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge):
(JSC::DFG::performCriticalEdgeBreaking):

  • dfg/DFGCriticalEdgeBreakingPhase.h: Added.

(DFG):

  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):
(JSC::DFG::DCEPhase::findTypeCheckRoot):
(JSC::DFG::DCEPhase::countNode):
(DCEPhase):
(JSC::DFG::DCEPhase::countEdge):
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGEdge.cpp:

(JSC::DFG::Edge::dump):

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::setUseKind):
(JSC::DFG::Edge::setProofStatus):
(JSC::DFG::Edge::willNotHaveCheck):
(JSC::DFG::Edge::willHaveCheck):
(Edge):
(JSC::DFG::Edge::killStatusUnchecked):
(JSC::DFG::Edge::killStatus):
(JSC::DFG::Edge::setKillStatus):
(JSC::DFG::Edge::doesKill):
(JSC::DFG::Edge::doesNotKill):
(JSC::DFG::Edge::shift):
(JSC::DFG::Edge::makeWord):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGFlushFormat.cpp: Added.

(WTF):
(WTF::printInternal):

  • dfg/DFGFlushFormat.h: Added.

(DFG):
(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):
(WTF):

  • dfg/DFGFlushLivenessAnalysisPhase.cpp: Added.

(DFG):
(FlushLivenessAnalysisPhase):
(JSC::DFG::FlushLivenessAnalysisPhase::FlushLivenessAnalysisPhase):
(JSC::DFG::FlushLivenessAnalysisPhase::run):
(JSC::DFG::FlushLivenessAnalysisPhase::process):
(JSC::DFG::FlushLivenessAnalysisPhase::setForNode):
(JSC::DFG::FlushLivenessAnalysisPhase::flushFormat):
(JSC::DFG::performFlushLivenessAnalysis):

  • dfg/DFGFlushLivenessAnalysisPhase.h: Added.

(DFG):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(DFG):
(JSC::DFG::Graph::addForDepthFirstSort):
(JSC::DFG::Graph::getBlocksInDepthFirstOrder):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::convertToConstant):
(JSC::DFG::Graph::valueProfileFor):
(Graph):

  • dfg/DFGInsertionSet.h:

(DFG):
(JSC::DFG::InsertionSet::execute):

  • dfg/DFGLivenessAnalysisPhase.cpp: Added.

(DFG):
(LivenessAnalysisPhase):
(JSC::DFG::LivenessAnalysisPhase::LivenessAnalysisPhase):
(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::process):
(JSC::DFG::LivenessAnalysisPhase::addChildUse):
(JSC::DFG::performLivenessAnalysis):

  • dfg/DFGLivenessAnalysisPhase.h: Added.

(DFG):

  • dfg/DFGNode.cpp:

(JSC::DFG::Node::hasVariableAccessData):
(DFG):

  • dfg/DFGNode.h:

(DFG):
(Node):
(JSC::DFG::Node::hasLocal):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::hasPhi):
(JSC::DFG::Node::phi):
(JSC::DFG::Node::takenBlock):
(JSC::DFG::Node::notTakenBlock):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::successorForCondition):
(JSC::DFG::nodeComparator):
(JSC::DFG::nodeListDump):
(JSC::DFG::nodeMapDump):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp: Added.

(DFG):
(OSRAvailabilityAnalysisPhase):
(JSC::DFG::OSRAvailabilityAnalysisPhase::OSRAvailabilityAnalysisPhase):
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::performOSRAvailabilityAnalysis):

  • dfg/DFGOSRAvailabilityAnalysisPhase.h: Added.

(DFG):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSSAConversionPhase.cpp: Added.

(DFG):
(SSAConversionPhase):
(JSC::DFG::SSAConversionPhase::SSAConversionPhase):
(JSC::DFG::SSAConversionPhase::run):
(JSC::DFG::SSAConversionPhase::forwardPhiChildren):
(JSC::DFG::SSAConversionPhase::forwardPhi):
(JSC::DFG::SSAConversionPhase::forwardPhiEdge):
(JSC::DFG::SSAConversionPhase::deduplicateChildren):
(JSC::DFG::SSAConversionPhase::addFlushedLocalOp):
(JSC::DFG::SSAConversionPhase::addFlushedLocalEdge):
(JSC::DFG::performSSAConversion):

  • dfg/DFGSSAConversionPhase.h: Added.

(DFG):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):
(Validate):
(JSC::DFG::Validate::validateCPS):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::flushFormat):
(VariableAccessData):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(JSC::FTL::LowerDFGToLLVM::compileWeakJSConstant):
(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):
(JSC::FTL::LowerDFGToLLVM::compileArithAbs):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileBitAnd):
(JSC::FTL::LowerDFGToLLVM::compileBitOr):
(JSC::FTL::LowerDFGToLLVM::compileBitXor):
(JSC::FTL::LowerDFGToLLVM::compileBitRShift):
(JSC::FTL::LowerDFGToLLVM::compileBitLShift):
(JSC::FTL::LowerDFGToLLVM::compileBitURShift):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileInt32ToDouble):
(JSC::FTL::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileGetGlobalVar):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::lowStorage):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateBoolean):
(JSC::FTL::LowerDFGToLLVM::isLive):
(JSC::FTL::LowerDFGToLLVM::use):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
(JSC::FTL::LowerDFGToLLVM::setInt32):
(JSC::FTL::LowerDFGToLLVM::setJSValue):
(JSC::FTL::LowerDFGToLLVM::setBoolean):
(JSC::FTL::LowerDFGToLLVM::setStorage):
(JSC::FTL::LowerDFGToLLVM::setDouble):
(JSC::FTL::LowerDFGToLLVM::isValid):

  • ftl/FTLLoweredNodeValue.h: Added.

(FTL):
(LoweredNodeValue):
(JSC::FTL::LoweredNodeValue::LoweredNodeValue):
(JSC::FTL::LoweredNodeValue::isSet):
(JSC::FTL::LoweredNodeValue::operator!):
(JSC::FTL::LoweredNodeValue::value):
(JSC::FTL::LoweredNodeValue::block):

  • ftl/FTLValueFromBlock.h:

(JSC::FTL::ValueFromBlock::ValueFromBlock):
(ValueFromBlock):

  • ftl/FTLValueSource.cpp:

(JSC::FTL::ValueSource::dump):

  • ftl/FTLValueSource.h:

Source/WTF:

Reviewed by Mark Hahnenberg.

  • Extend variadicity of PrintStream and dataLog.


  • Give HashSet the ability to add a span of things.


  • Give HashSet the ability to == another HashSet.


  • Note FIXME's in HashTable concerning copying performance, that affects the way that the DFG now uses HashSets and HashMaps.


  • Factor out the bulk-insertion logic of JSC::DFG::InsertionSet into WTF::Insertion, so that it can be used in more places.


  • Create a dumper for lists and maps.
  • WTF.xcodeproj/project.pbxproj:
  • wtf/DataLog.h:

(WTF):
(WTF::dataLog):

  • wtf/HashSet.h:

(HashSet):
(WTF):
(WTF::::add):
(WTF::=):

  • wtf/HashTable.h:

(WTF::::HashTable):
(WTF::=):

  • wtf/Insertion.h: Added.

(WTF):
(Insertion):
(WTF::Insertion::Insertion):
(WTF::Insertion::index):
(WTF::Insertion::element):
(WTF::Insertion::operator<):
(WTF::executeInsertions):

  • wtf/ListDump.h: Added.

(WTF):
(ListDump):
(WTF::ListDump::ListDump):
(WTF::ListDump::dump):
(MapDump):
(WTF::MapDump::MapDump):
(WTF::MapDump::dump):
(WTF::listDump):
(WTF::sortedListDump):
(WTF::lessThan):
(WTF::mapDump):
(WTF::sortedMapDump):

  • wtf/PrintStream.h:

(PrintStream):
(WTF::PrintStream::print):

6:29 PM Changeset in webkit [152691] by Chris Fleizach
  • 2 edits in trunk/Tools

Update James Craig's email address.

  • Scripts/webkitpy/common/config/contributors.json:
6:21 PM Changeset in webkit [152690] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-537-branch

Merged r152653. <rdar://problem/14442444>

6:19 PM Changeset in webkit [152689] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Pack WebCore::Font slightly better.
<​http://webkit.org/b/118681>
<rdar://problem/14446014>

Reviewed by Sam Weinig.

Knock 8 bytes off of Font by packing the members better. Reduces memory consumption by 429 kB when
viewing the full HTML5 spec at <​http://whatwg.org/c>

  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures):

6:19 PM Changeset in webkit [152688] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r152652. <rdar://problem/14413607>

6:17 PM Changeset in webkit [152687] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source

Rollout of r152686. Previously merged.

6:14 PM Changeset in webkit [152686] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source

Merged r152382. <rdar://problem/14252733>

5:37 PM Changeset in webkit [152685] by rwlbuis@webkit.org
  • 14 edits
    2 adds in trunk

XMLSerializer doesn't include namespaces on nodes in HTML documents
​https://bugs.webkit.org/show_bug.cgi?id=16496

Patch by Rob Buis <​rwlbuis@webkit.org> on 2013-07-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Introduce a xml fragment serialization mode as indicated by
​http://html5.org/specs/dom-parsing.html#xmlserializer (commit 00b84d2). In this mode
the XML fragment serialization algorithm is respected, the changes in this patch do the following:

This is achieved by always, when in xml fragment serialization mode, attempting to write out the element/attribute namespace,
preventing using the XML namespace as a default namespace and special casing the use of element's in XML namespace by using the xml prefix.

The chosen approach matches FireFox 25 behavior.

Test: fast/dom/dom-serialize-namespace.html

  • WebCore.order: Adapt to changed createMarkup signature.
  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::MarkupAccumulator):
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): makes sure xml namespace/prefix is known so it is never used in namespace declarations.
(WebCore::MarkupAccumulator::appendNamespace): Avoid adding namespace declarations that do not differ from current default namespace.
(WebCore::MarkupAccumulator::appendOpenTag): Print xml prefix if the element's namespace is XML to avoid conflicts.
(WebCore::MarkupAccumulator::appendAttribute):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute): Also take into account xmlns attributes with no namespace.
(WebCore::MarkupAccumulator::shouldSelfClose): Force self-closing to create well-formed XML elements.

  • editing/MarkupAccumulator.h: Use EFragmentSerialization.

(WebCore::MarkupAccumulator::inXMLFragmentSerialization):

  • editing/markup.cpp:

(WebCore::createMarkup):

  • editing/markup.h: Add EFragmentSerialization enum.
  • xml/XMLSerializer.cpp:

(WebCore::XMLSerializer::serializeToString):

LayoutTests:

The updated tests are progressions and match FF.

  • fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt:
  • fast/dom/Element/script-tests/getAttribute-check-case-sensitivity.js:
  • fast/dom/XMLSerializer-xml-namespace-expected.txt:
  • fast/dom/dom-serialize-namespace-expected.txt: Added.
  • fast/dom/dom-serialize-namespace.html: Added.
  • fast/xsl/xslt-processor-expected.txt:
  • inspector/elements/set-outer-html-expected.txt:
  • svg/custom/xlink-prefix-in-attributes-expected.txt:
5:32 PM Changeset in webkit [152684] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused columns from select query in ImageUtilities.js
​https://bugs.webkit.org/show_bug.cgi?id=118694

Patch by Seokju Kwon <Seokju Kwon> on 2013-07-15
Reviewed by Timothy Hatcher.

  • UserInterface/ImageUtilities.js: Remove pixelRatio and formatVersion from select query.
5:22 PM Changeset in webkit [152683] by Lucas Forschler
  • 7 edits
    2 copies in branches/safari-537-branch

Merged r152642. <rdar://problem/14293352>

5:18 PM Changeset in webkit [152682] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152623. <rdar://problem/14437753>

5:15 PM Changeset in webkit [152681] by Lucas Forschler
  • 12 edits in branches/safari-537-branch/Source

Merged r152613. <rdar://problem/14408012>

5:08 PM Changeset in webkit [152680] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r152588. <rdar://problem/14425513>

5:04 PM Changeset in webkit [152679] by Lucas Forschler
  • 8 edits
    2 copies in branches/safari-537-branch

Merged r152580. <rdar://problem/14324391>

5:00 PM Changeset in webkit [152678] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/JavaScriptCore

Merged r152577. <rdar://problem/13927795>

4:54 PM Changeset in webkit [152677] by Lucas Forschler
  • 8 edits in branches/safari-537-branch

Merged r152573. <rdar://problem/13927795>

4:47 PM Changeset in webkit [152676] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152568. <rdar://problem/14421170>

4:47 PM Changeset in webkit [152675] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add fallback for TestWebKitAPI if opengl is not available.
​https://bugs.webkit.org/show_bug.cgi?id=118583

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-15
Reviewed by Christophe Dumez.

There're many fails on efl webkit2 API test if opengl is not available.
So, add fallback to non-opengl evas engine.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::initEcoreEvas):

4:44 PM Changeset in webkit [152674] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r152554. <rdar://problem/14305675>

4:42 PM Changeset in webkit [152673] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

MediaFragmentURIParser::parseFragments shouldn't upconvert 8-bit string
​https://bugs.webkit.org/show_bug.cgi?id=118692

Reviewed by Michael Saboff.

Merge ​https://chromium.googlesource.com/chromium/blink/+/2aa17cc56a807f7e05d386d6eb66cda25e6b0542.

  • html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseFragments):

4:41 PM Changeset in webkit [152672] by kseo@webkit.org
  • 5 edits in trunk/Source

NetworkStorageSession::createDefaultSession is only implemented by Soup
​https://bugs.webkit.org/show_bug.cgi?id=118679

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Remove NetworkStorageSession::createDefaultSession() because
NetworkStorageSession::defaultStorageSession() returns the default
session.

No new tests, no behavior change.

  • platform/network/NetworkStorageSession.h:
  • platform/network/soup/NetworkStorageSessionSoup.cpp:

Source/WebKit/efl:

Replace NetworkStorageSession::createDefaultSession() with
NetworkStorageSession::defaultStorageSession().

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(EWKPrivate::storageSession):

4:34 PM Changeset in webkit [152671] by Lucas Forschler
  • 9 edits
    2 copies in branches/safari-537-branch

Merged r152547. <rdar://problem/13832062>

4:31 PM Changeset in webkit [152670] by Lucas Forschler
  • 7 edits in branches/safari-537-branch

Merged r152532. <rdar://problem/14212242>

4:31 PM Changeset in webkit [152669] by timothy@apple.com
  • 19 edits in trunk/Source/WebInspectorUI

Update CodeMirror to 3.14.1.

​https://bugs.webkit.org/show_bug.cgi?id=118605

Reviewed by Joseph Pecoraro.

  • Scripts/update-codemirror-resources.rb: Updated the list to add closebrackets.js and sorted the files.
  • Tools/PrettyPrinting/CodeMirrorFormatters.js:
  • Tools/PrettyPrinting/Formatter.js:
  • Tools/PrettyPrinting/FormatterContentBuilder.js:
  • Tools/PrettyPrinting/codemirror.css:
  • Tools/PrettyPrinting/codemirror.js:
  • Tools/PrettyPrinting/css.js:
  • Tools/PrettyPrinting/javascript.js:
  • UserInterface/External/CodeMirror/closebrackets.js:
  • UserInterface/External/CodeMirror/codemirror.css:
  • UserInterface/External/CodeMirror/codemirror.js:
  • UserInterface/External/CodeMirror/coffeescript.js:
  • UserInterface/External/CodeMirror/comment.js:
  • UserInterface/External/CodeMirror/css.js:
  • UserInterface/External/CodeMirror/javascript.js:
  • UserInterface/External/CodeMirror/matchbrackets.js:
  • UserInterface/External/CodeMirror/sql.js:
  • UserInterface/External/CodeMirror/xml.js:
4:28 PM Changeset in webkit [152668] by rniwa@webkit.org
  • 5 edits in trunk

compositionstart event should contain the text to be replaced
​https://bugs.webkit.org/show_bug.cgi?id=118684

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/9e04f728a95ad7d4783b1d31c3cdc1412dd6cc4d.

DOM3 level 3 specifies compositionstart event's data to be the text to be replaced.
​http://www.w3.org/TR/DOM-Level-3-Events/#event-type-compositionstart

According to the author of the Blink change, IE10 on Windows and Firefox22 on Linux confirms
to the specified behavior.

Test: fast/events/ime-composition-events-001.html

  • editing/Editor.cpp:

(WebCore::Editor::setComposition):

LayoutTests:

Add a test case.

  • fast/events/ime-composition-events-001-expected.txt:
  • fast/events/ime-composition-events-001.html:
4:27 PM Changeset in webkit [152667] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

xmlDocPtrForString shouldn't upconvert 8-bit string
​https://bugs.webkit.org/show_bug.cgi?id=118693

Reviewed by Michael Saboff.

Merge ​https://chromium.googlesource.com/chromium/blink/+/5d9b240db74591c3689415c7b7c5180fadb379e9

Prior to this changeset, we were upconverting the entire XML document.
Let xmllib2 parse a document as iso-8859-1 when it's a 8-bit string.

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::nativeEndianUTF16Encoding):
(WebCore::xmlDocPtrForString):

4:23 PM Changeset in webkit [152666] by Lucas Forschler
  • 5 edits in branches/safari-537-branch

Merged r152522. <rdar://problem/14376358>

4:10 PM Changeset in webkit [152665] by Lucas Forschler
  • 16 edits in branches/safari-537-branch/Source

Merged r152520. <rdar://problem/9504664>

4:08 PM Changeset in webkit [152664] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152459. <rdar://problem/14211041>

4:04 PM Changeset in webkit [152663] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-537-branch

Merged r152388. <rdar://problem/14207940>

4:01 PM Changeset in webkit [152662] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Tools

Merged r152366. <rdar://problem/14281956>

3:58 PM Changeset in webkit [152661] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebCore

Merged r152345. <rdar://problem/14324895>

3:50 PM Changeset in webkit [152660] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r152330. <rdar://problem/14297760>

3:42 PM Changeset in webkit [152659] by Lucas Forschler
  • 22 edits in branches/safari-537-branch

Merged r152320. <rdar://problem/14324895>

3:20 PM Changeset in webkit [152658] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152316. <rdar://problem/13917901>

3:18 PM Changeset in webkit [152657] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152249. <rdar://problem/13917901>

3:15 PM Changeset in webkit [152656] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151845. <rdar://problem/14211041>

1:46 PM Changeset in webkit [152655] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Replace WKCACFTypes include with d3d9 include.

Rubberstamped by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
1:44 PM Changeset in webkit [152654] by roger_fong@apple.com
  • 11 deletes in trunk/WebKitLibraries/win/tools/vsprops

Unreviewed. Remove unused vsprops files.

  • win/tools/vsprops/FeatureDefines.vsprops: Removed.
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Removed.
  • win/tools/vsprops/WinCairo.vsprops: Removed.
  • win/tools/vsprops/cURL.vsprops: Removed.
  • win/tools/vsprops/common.vsprops: Removed.
  • win/tools/vsprops/debug.vsprops: Removed.
  • win/tools/vsprops/debug_all.vsprops: Removed.
  • win/tools/vsprops/debug_wincairo.vsprops: Removed.
  • win/tools/vsprops/production.vsprops: Removed.
  • win/tools/vsprops/release.vsprops: Removed.
  • win/tools/vsprops/releaseproduction.vsprops: Removed.
1:07 PM Changeset in webkit [152653] by ddkilzer@apple.com
  • 3 edits
    3 adds in trunk

Text with "text-overflow:ellipsis" and an SVG font do not render correctly
​https://bugs.webkit.org/show_bug.cgi?id=118669

Patch by Antoine Quint <Antoine Quint> on 2013-07-15
Reviewed by David Kilzer.

Source/WebCore:

Partial runs may be routed through the complex path in several Font functions. While incomplete,
we can check for a non-NULL run.renderingContext() and exempt runs that have it from being forced
down the complex path. A more thorough fix is already tracked by ​http://webkit.org/b/100050.

Adding a new testcase which is a copy of svg/text/text-overflow-ellipsis-svgfont.html with kerning
and ligatures turned on explicitly since DRT runs with those off by default and this option is required
to be on for the issue to reproduce.

Fix courtesy of Dan Bernstein.

Test: svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html

  • platform/graphics/Font.cpp:

(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):

LayoutTests:

  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.png: Added.
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt: Added.
  • svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html: Added.
12:46 PM Changeset in webkit [152652] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Make sure to add main resources for sub-frames to the Network Timeline.

​https://bugs.webkit.org/show_bug.cgi?id=118649

Reviewed by Joseph Pecoraro.

  • UserInterface/TimelineManager.js:

(WebInspector.TimelineManager.prototype._mainResourceDidChange): Remove the
call to _clear() and early return for event.target.isMainFrame(). The _clear()
is already handled if needed by the call to _startAutoRecording(), so it was
redundant here and caused the erroneous addition of isMainFrame() early return.

11:53 AM Changeset in webkit [152651] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Properly handle style text changes while the color popover is open.

​https://bugs.webkit.org/show_bug.cgi?id=118575

Reviewed by Joseph Pecoraro.

  • UserInterface/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._colorSwatchClicked.updateCodeMirror):
The original text marker might have been cleared by a style update, in this case we need to
find the new color text marker so we know the right range for the new style color text.

11:48 AM Changeset in webkit [152650] by timothy_horton@apple.com
  • 2 edits in branches/safari-537-branch/LayoutTests

Unreviewed, fix a mismerge from r152303.

  • platform/mac/TestExpectations:
11:22 AM Changeset in webkit [152649] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] Download does not replace existing file.
​https://bugs.webkit.org/show_bug.cgi?id=118356

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-07-15
Reviewed by Brent Fulgham.

If the download target file already exists, it is not replaced after the download has finished.
At this point, the user would have already approved to replace the file, so it should be replaced.

  • platform/network/curl/CurlDownload.cpp:

(CurlDownload::moveFileToDestination): Move file and replace it if it already exists.
If the new file is on a different volume, do a copy/delete operation.

10:53 AM Changeset in webkit [152648] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0

Merge r152412 - [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
​https://bugs.webkit.org/show_bug.cgi?id=111434

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-07-05
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

  • UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:

(testNotInitialized):
(testSetDirectory):
(testClearDatabase):
(testGetFavicon):
(testGetFaviconURI): Removed gconstpointer parameter.
(testWebViewFavicon): Fixed to make it work together with the
other tests and removed gconstpointer parameter.
(testFaviconDatabase): Created to call all tests in the proper
order.
(beforeAll): Changed to call only testFaviconDatabase instead of
the separate tests.

10:50 AM Changeset in webkit [152647] by Luciano Miguel Wolf
  • 2 edits in trunk/Source/WebCore

[CoordinatedGraphics] Crash at CoordinatedGraphicsScene::updateImageBacking
​https://bugs.webkit.org/show_bug.cgi?id=118613

The operations of creating/removing/updating/clearing weren't in the
right sequence. Changing the order solves the issue because when an image is
replaced the old one is deleted before the new one is created, and IDs are
not unique in cairo (they're based on the image pointer).

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::syncImageBackings):

10:42 AM Changeset in webkit [152646] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r152627 - [GTK] [WK2] Check if the keyEventQueue is empty in WebPageProxy::getEditorCommandsForKeyEvent
​https://bugs.webkit.org/show_bug.cgi?id=118530

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

When a key event is started in the WebProcess (e.g. in the inspector)
it doesn't have an associated GdkEvent queued. Adding a check in
WebPageProxy::getEditorCommandsForKeyEvent ensures there's always a queued
key event to process.

In GTK-WK2, inspector-protocol/input/dispatchKeyEvent.html no longer crashes once
this fix is in place.

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): Ensure m_keyEventQueue is
not empty.

10:38 AM Changeset in webkit [152645] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r152631 - [ATK] Leak: Leak in WebKitAccessibleTextGetText
​https://bugs.webkit.org/show_bug.cgi?id=118596

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

Fixed memory leak.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getGailTextUtilForAtk):

10:34 AM Changeset in webkit [152644] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r152398 - [GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
​https://bugs.webkit.org/show_bug.cgi?id=118386

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-04
Reviewed by Carlos Garcia Campos.

Free PangoFontDescription* allocated by gtk_style_context_get (transfer full).

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::spinButtonArrowSize):

10:22 AM Changeset in webkit [152643] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r144636 - [GTK] WebCore::returnString is unsafe and should be removed!
​https://bugs.webkit.org/show_bug.cgi?id=110423

Reviewed by Martin Robinson.

Remove returnString() and replace it in callers with a new
function that will cache and return the values of string
properties for ATK interfaces in the private section of the
wrapper AtkObject WebKitAccessible.

  • accessibility/atk/WebKitAccessibleUtil.cpp: Remove returnString().
  • accessibility/atk/WebKitAccessibleUtil.h: Ditto.
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(_WebKitAccessiblePrivate): New private structure to store cached
values of string property for the different ATK interfaces.
(cacheAndReturnAtkProperty): New helper function to make sure the
returned const gchar* value is previously cached in the private
section of the wrapper AtkObject.
(webkitAccessibleGetName): Use the new helper function.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleInit): Initialize pointer to private structure.
(webkitAccessibleFinalize): Remove unneeded code.
(webkitAccessibleClassInit): Add private struct to class type/

  • accessibility/atk/WebKitAccessibleWrapperAtk.h:

(_WebKitAccessible): New member pointing to the private structure,
made the new helper function cacheAndReturnAtkProperty() available
to external callers (implementation files for ATK interfaces).
(AtkCachedProperty): New enum to allow reusing code when calling
cacheAndReturnAtkProperty() to cache and return different properties.

  • accessibility/atk/WebKitAccessibleInterfaceAction.cpp:

(webkitAccessibleActionGetKeybinding): Replace calls to returnString()
with calls to the new helper function cacheAndReturnAtkProperty().
(webkitAccessibleActionGetName): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:

(documentAttributeValue): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImageDescription): Ditto.

Remove returnString() from WebKitAccessibleHyperlink (which is not
an AtkObject, but a GObject) as well, replacing it in callers with
simple code that will cache and return the required values in the
private section of these kind of objects.

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(_WebKitAccessibleHyperlinkPrivate): Added two new fields to cache
string values for the key binding and name properties from the
AtkAction interface, which is implemented by AtkHyperlink.
(webkitAccessibleHyperlinkActionGetKeybinding): Cache the string
value for the key binding before returning a const gchar* pointer.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Do not cache the URI here, as
this function returns a gchar* that will be owned by the caller.

10:16 AM Changeset in webkit [152642] by jonlee@apple.com
  • 7 edits
    2 adds in trunk

Source/WebKit/mac: [WK2] Calling Notification.requestPermission() without a callback crashes
​https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

  • WebCoreSupport/WebNotificationClient.mm:

(-[WebNotificationPolicyListener initWithCallback:]): The callback can be NULL, so remove the ASSERT.
(-[WebNotificationPolicyListener allow]): Check for the callback before asking it to handle the event.
(-[WebNotificationPolicyListener deny]): Ditto.

Source/WebKit2: Calling Notification.requestPermission() without a callback crashes
​https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

When requestPermission() is called, we short-circuit if we know the permission was already set.
The callback handler gets invoked. But now that callbacks are optional, we need to check to make
sure a callback was provided.

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest): Check for the callback.

LayoutTests: [WK2] Calling Notification.requestPermission() without a callback crashes
​https://bugs.webkit.org/show_bug.cgi?id=118654
<rdar://problem/14293352>

Reviewed by Alexey Proskuryakov.

  • http/tests/notifications/notification-request-permission-expected.txt:
  • http/tests/notifications/notification-request-permission.html: Add additional subtests that check

that the call succeeds even after granting or denying permission.

  • http/tests/notifications/notification-request-permission-no-callback-expected.txt: Added.
  • http/tests/notifications/notification-request-permission-no-callback.html: Added. Similar test to

notification-request-permission, without the callback function.

9:55 AM Changeset in webkit [152641] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r152298 - [ATK] Leak: leaks in AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=118297

Fixed memory leak.

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::stringValue):

9:50 AM Changeset in webkit [152640] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r152232 - [ATK] Leak: leaks in WebKitAccessibleInterfaceText
​https://bugs.webkit.org/show_bug.cgi?id=118248

Fixed memory leaks.

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-01
Reviewed by Christophe Dumez.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getPangoLayoutForAtk):
(webkitAccessibleTextGetText):

9:43 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
9:32 AM Changeset in webkit [152639] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
​https://bugs.webkit.org/show_bug.cgi?id=118592

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-15
Reviewed by Martin Robinson.

Added a suppression for pylint false positives and a unit test.

  • Scripts/webkitpy/style/checkers/python.py:

(Pylinter):

  • Scripts/webkitpy/style/checkers/python_unittest.py:

(PythonCheckerTest.test_check):
(PythonCheckerTest):
(PythonCheckerTest.test_pylint_false_positives):
(PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):

  • Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.

(test_popen):

9:29 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
9:28 AM Changeset in webkit [152638] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r152483 - [GTK] webkit_set_cache_model is not turning the cache off
​https://bugs.webkit.org/show_bug.cgi?id=118345

Reviewed by Gustavo Noronha Silva.

Our documentation says that WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER
disables the cache completely, but we are only setting the cache
capacities to 0. Cache capacities are not checked when resources
are added to the cache, but when it's pruned. To disable the cache
we need to call MemoryCache::setDisabled explicitly.

  • webkit/webkitglobals.cpp:

(webkit_set_cache_model): Disable the cache when min dead, max
dead and total capacities are all set to 0.

9:25 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
9:24 AM Changeset in webkit [152637] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r152626 - [WK2][GTK] SIGSEV in webkitWebViewBaseSizeAllocate
​https://bugs.webkit.org/show_bug.cgi?id=118052

Patch by Alberto Garcia <​berto@igalia.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

We don't need to check whether the drawing area is empty or not in
order to set needsResizeOnMap.

It can also happen that the drawing area pointer is null (if
e.g. the web process crashes), which is the reason for this
SIGSEGV.

A test to prevent this was added in r88646 but was later moved to
resizeWebKitWebViewBaseFromAllocation().

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSizeAllocate):

9:21 AM Changeset in webkit [152636] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r152367 - [GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
​https://bugs.webkit.org/show_bug.cgi?id=116867

Reviewed by Anders Carlsson.

We did not reset the clients on WebPageProxy::close(), so right
clicking on a link after starting the navigation to some other
page was causing crashes because code was trying to access an
already freed m_contextMenuClient.

There were some other clients that could potentially trigger the
same issues. Reset them all to null to prevent this situation.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

9:20 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
9:15 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
9:06 AM Changeset in webkit [152635] by Carlos Garcia Campos
  • 3 edits
    1 delete in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r148440 - [GTK] Remove platform specific implementation of KURL::fileSystemPath()
​https://bugs.webkit.org/show_bug.cgi?id=114133

Reviewed by Martin Robinson.

r147883 added a generic implementation of this function,
which can be used by all ports to share the code.

  • GNUmakefile.list.am:
  • platform/KURL.cpp:

(WebCore):

  • platform/gtk/KURLGtk.cpp: Removed.
8:59 AM Changeset in webkit [152634] by Carlos Garcia Campos
  • 5 edits
    4 deletes in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r147883 - Add default implementation for KURL::fileSystemPath()
​https://bugs.webkit.org/show_bug.cgi?id=108326

Reviewed by Benjamin Poulain.

The code for KURL::fileSystemPath() has been duplicated in different ports.
Add an implementation of this function to KURL.cpp for this ports and
get rid of the very similar port specific implementation files.

  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
  • platform/KURL.cpp:

(WebCore):
(WebCore::KURL::fileSystemPath):

  • platform/blackberry/KURLBlackBerry.cpp: Removed.
  • platform/efl/KURLEfl.cpp: Removed.
  • platform/wince/KURLWinCE.cpp: Removed.
  • platform/wx/KURLWx.cpp: Removed.
8:36 AM Changeset in webkit [152633] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Remote inspector server should send an error page if resources not found
​https://bugs.webkit.org/show_bug.cgi?id=117137

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-07-15
Reviewed by Gustavo Noronha Silva.

Sometimes it is difficult to understand why remote inspector fails to deliver the content.
This patch gives an option to show error page with some basic explanation.

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):

7:47 AM Changeset in webkit [152632] by zarvai@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed cleanup for pixel tester bot.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
  • platform/qt-5.0-wk2/editing/selection/move-by-character-004-expected.png:
  • platform/qt-5.0-wk2/fast/canvas/setWidthResetAfterForcedRender-expected.png:
6:24 AM Changeset in webkit [152631] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[ATK] Leak: Leak in WebKitAccessibleTextGetText
​https://bugs.webkit.org/show_bug.cgi?id=118596

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

Fixed memory leak.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getGailTextUtilForAtk):

5:02 AM Changeset in webkit [152630] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Skipping bad pixel results.

  • platform/qt-5.0-wk2/TestExpectations:
3:01 AM Changeset in webkit [152629] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Increase the JHBuild version of GStreamer to 1.0.7
​https://bugs.webkit.org/show_bug.cgi?id=115166

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-07-15
Reviewed by Philippe Normand.

  • gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2:44 AM Changeset in webkit [152628] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Skipping bad pixel results.

  • platform/qt-5.0-wk2/TestExpectations:
2:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:49 AM Changeset in webkit [152627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Check if the keyEventQueue is empty in WebPageProxy::getEditorCommandsForKeyEvent
​https://bugs.webkit.org/show_bug.cgi?id=118530

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

When a key event is started in the WebProcess (e.g. in the inspector)
it doesn't have an associated GdkEvent queued. Adding a check in
WebPageProxy::getEditorCommandsForKeyEvent ensures there's always a queued
key event to process.

In GTK-WK2, inspector-protocol/input/dispatchKeyEvent.html no longer crashes once
this fix is in place.

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::getEditorCommandsForKeyEvent): Ensure m_keyEventQueue is
not empty.

1:14 AM Changeset in webkit [152626] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] SIGSEV in webkitWebViewBaseSizeAllocate
​https://bugs.webkit.org/show_bug.cgi?id=118052

Patch by Alberto Garcia <​berto@igalia.com> on 2013-07-15
Reviewed by Carlos Garcia Campos.

We don't need to check whether the drawing area is empty or not in
order to set needsResizeOnMap.

It can also happen that the drawing area pointer is null (if
e.g. the web process crashes), which is the reason for this
SIGSEGV.

A test to prevent this was added in r88646 but was later moved to
resizeWebKitWebViewBaseFromAllocation().

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSizeAllocate):

1:08 AM Changeset in webkit [152625] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Minor cleaning of AtomicString::addSlowCase
​https://bugs.webkit.org/show_bug.cgi?id=118615

Reviewed by Geoffrey Garen.

Give the variable a proper name.
Add assertions to clarify the in and out states.

  • wtf/text/AtomicString.cpp:

(WTF::AtomicString::addSlowCase):

Jul 14, 2013:

11:41 PM Changeset in webkit [152624] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebInspectorUI

Unreviewed, rolling out r152598.
​http://trac.webkit.org/changeset/152598
​https://bugs.webkit.org/show_bug.cgi?id=118658

totally broke the web inspector (JS ERROR: SyntaxError:
Expected token '}') (Requested by thorton on #webkit).

  • Tools/PrettyPrinting/CodeMirrorFormatters.js:
  • Tools/PrettyPrinting/Formatter.js:
  • Tools/PrettyPrinting/FormatterContentBuilder.js:
  • Tools/PrettyPrinting/codemirror.css:

(.CodeMirror-scrollbar-filler):
(.CodeMirror-gutters):
(.CodeMirror-vscrollbar, .CodeMirror-hscrollbar, .CodeMirror-scrollbar-filler):
(.CodeMirror-widget):

  • Tools/PrettyPrinting/codemirror.js:

(window.CodeMirror):
(window.CodeMirror.):
(.do):
(moveVisually):

  • Tools/PrettyPrinting/css.js:

(.):
(CodeMirror):

  • Tools/PrettyPrinting/javascript.js:

(.):

  • UserInterface/External/CodeMirror/codemirror.css:

(.CodeMirror-widget):

  • UserInterface/External/CodeMirror/codemirror.js:

(window.CodeMirror):
(window.CodeMirror.):

  • UserInterface/External/CodeMirror/coffeescript.js:
  • UserInterface/External/CodeMirror/comment.js:

(.):

  • UserInterface/External/CodeMirror/css.js:

(.):
(CodeMirror):

  • UserInterface/External/CodeMirror/javascript.js:

(.):

  • UserInterface/External/CodeMirror/matchbrackets.js:

(.):

  • UserInterface/External/CodeMirror/sql.js:
  • UserInterface/External/CodeMirror/xml.js:
11:11 PM Changeset in webkit [152623] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Origins with invalid ports are not marked as unique (118652)
​https://bugs.webkit.org/show_bug.cgi?id=118652
<rdar://problem/14437753>

Reviewed by Sam Weinig.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::create): Return a unique origin if the port is out of range.

6:27 PM Changeset in webkit [152622] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Another Qt build fix attempt after r152619.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

6:22 PM Changeset in webkit [152621] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt build fix attempt after r152619.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

6:01 PM Changeset in webkit [152620] by kseo@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add Company100 to team.html
​https://bugs.webkit.org/show_bug.cgi?id=118633

Reviewed by Andreas Kling.

  • team.html:
5:47 PM Changeset in webkit [152619] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix attempt after r152615.

  • svg/SVGFilterElement.h:
5:45 PM Changeset in webkit [152618] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
​https://bugs.webkit.org/show_bug.cgi?id=118299

Reviewed by Andreas Kling.

Address Ben's review comment.

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::toString):

5:35 PM Changeset in webkit [152617] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

apply-style-command-crash.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=118634

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/a30dad44ded92d24ed56761434cf6041688659a0.

Also replace CRLF to LF and get rid of svn:executable.

  • editing/execCommand/apply-style-command-crash.html:
7:49 AM Changeset in webkit [152616] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLTextFormControlElement::valueWithHardLineBreaks shouldn't upconvert 8-bit string
​https://bugs.webkit.org/show_bug.cgi?id=118631

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/2c7c70a7bd3d61bfbf97de95c459ec9f40b46e31.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

6:59 AM Changeset in webkit [152615] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Add toSVGFilterElement() and use it.
​https://bugs.webkit.org/show_bug.cgi?id=118653

Reviewed by Ryosuke Niwa.

We can use toSVGFilterElement() instead of using static_cast<..> to improve readability.
Blink also uses it.

No new tests, no behavior change.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::resourceBoundingBox):

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::RenderSVGResourceFilter::filterUnits):
(WebCore::RenderSVGResourceFilter::primitiveUnits):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGFilterElement.h:

(WebCore::toSVGFilterElement):

1:55 AM Changeset in webkit [152614] by kangil.han@samsung.com
  • 10 edits in trunk/Source

Introduce toHTMLVideoElement
​https://bugs.webkit.org/show_bug.cgi?id=118582

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch introduces toHTMLVideoElement.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getPluginProxyParams):

  • html/HTMLVideoElement.h:

(WebCore::toHTMLVideoElement):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::enterFullscreenForVideo):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::videoElement):

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::mediaContentUrlByElementId):

  • WebCoreSupport/FullScreenVideoQt.cpp:

(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):

Note: See TracTimeline for information about the timeline view.