Timeline

Jul 17, 2013:

11:36 PM Changeset in webkit [152830] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix a typo in WebInspector.loaded
​https://bugs.webkit.org/show_bug.cgi?id=118834

Patch by Seokju Kwon <Seokju Kwon> on 2013-07-17
Reviewed by Timothy Hatcher.

• UserInterface/Main.js:

(WebInspector.loaded):

10:16 PM Changeset in webkit [152829] by fpizlo@apple.com

• 8 edits
  2 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Add a phase to create loop pre-headers
​https://bugs.webkit.org/show_bug.cgi?id=118778

Reviewed by Oliver Hunt.

Add a loop pre-header creation phase. Any loop that doesn't already have
just one predecessor that isn't part of the loop has a pre-header
prepended. All non-loop predecessors then jump to that pre-header.

Also fix a handful of bugs:

• DFG::Analysis should set m_valid before running the analysis, since that makes it easier to use ASSERT(m_valid) in the analysis' methods, which may be called by the analysis before the analysis completes. NaturalLoops does this with loopsOf().

• NaturalLoops::headerOf() was missing a check for innerMostLoopOf() returning 0, since that'll happen if the block isn't in any loop.

• Change BlockInsertionSet to dethread the graph, since anyone using it will want to do so.

• Change dethreading to ignore SSA form graphs.

This also adds NaturalLoops::belongsTo(), which I always used in the
pre-header creation phase. I didn't end up using it but I'll probably use
it in the near future.

• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGAnalysis.h:

(JSC::DFG::Analysis::computeIfNecessary):

• dfg/DFGBlockInsertionSet.cpp:

(JSC::DFG::BlockInsertionSet::execute):

• dfg/DFGCriticalEdgeBreakingPhase.cpp:

(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dethread):

• dfg/DFGLoopPreHeaderCreationPhase.cpp: Added.

(DFG):
(LoopPreHeaderCreationPhase):
(JSC::DFG::LoopPreHeaderCreationPhase::LoopPreHeaderCreationPhase):
(JSC::DFG::LoopPreHeaderCreationPhase::run):
(JSC::DFG::performLoopPreHeaderCreation):

• dfg/DFGLoopPreHeaderCreationPhase.h: Added.

(DFG):

• dfg/DFGNaturalLoops.h:

(NaturalLoop):
(JSC::DFG::NaturalLoops::headerOf):
(JSC::DFG::NaturalLoops::innerMostLoopOf):
(JSC::DFG::NaturalLoops::innerMostOuterLoop):
(JSC::DFG::NaturalLoops::belongsTo):
(NaturalLoops):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

9:38 PM Changeset in webkit [152828] by fpizlo@apple.com

• 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Rationalize Node::replacement
​https://bugs.webkit.org/show_bug.cgi?id=118774

Reviewed by Oliver Hunt.

• Clearing of replacements is now done in Graph::clearReplacements().

• New nodes now have replacement set to 0.

• Node::replacement is now part of a 'misc' union. I'll be putting at least one other field into that union as part of LICM work (see ​https://bugs.webkit.org/show_bug.cgi?id=118749).

• dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performBlockCSE):

• dfg/DFGGraph.cpp:

(DFG):
(JSC::DFG::Graph::clearReplacements):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::performSubstitutionForEdge):
(Graph):

• dfg/DFGNode.h:

(JSC::DFG::Node::Node):

• dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

7:13 PM Changeset in webkit [152827] by gyuyoung.kim@samsung.com

• 4 edits in trunk/Source/WebCore

Introduce toSVGInlineFlowBox() and use it
​https://bugs.webkit.org/show_bug.cgi?id=118794

Reviewed by Andreas Kling.

As a step to change static_cast with toSVGXXX, static_cast<SVGInlineFlowBox*> can
be changed with toSVGInlineFlowBox().

Blink merge from ​https://src.chromium.org/viewvc/blink?view=rev&revision=154385

No new tests, no behavior change.

• rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paintSelectionBackground):

• rendering/svg/SVGInlineFlowBox.h:

(WebCore::toSVGInlineFlowBox):

• rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):

7:12 PM Changeset in webkit [152826] by gyuyoung.kim@samsung.com

• 4 edits in trunk/Source/WebCore

Use toSVGMarkerElement() instead of static_cast<>
​https://bugs.webkit.org/show_bug.cgi?id=118800

Reviewed by Andreas Kling.

Though there is toSVGMarkerElement(), some files still use static_cast<SVGMarkerElement*>.
To remove all static_cast<> use, we need to change argument from SVGElement to Node.

No new tests, no behavior changes.

• rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::referencePoint):
(WebCore::RenderSVGResourceMarker::angle):
(WebCore::RenderSVGResourceMarker::markerTransformation):
(WebCore::RenderSVGResourceMarker::viewportTransform):
(WebCore::RenderSVGResourceMarker::calcViewport):

• rendering/svg/RenderSVGResourceMarker.h:

(WebCore::RenderSVGResourceMarker::markerUnits):

• svg/SVGMarkerElement.h:

(WebCore::toSVGMarkerElement):

6:02 PM Changeset in webkit [152825] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Dereference null pointer crash in Length::decrementCalculatedRef()
​https://bugs.webkit.org/show_bug.cgi?id=118686

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-07-17
Reviewed by Simon Fraser.

Source/WebCore:

Length(Calculated) won't insert any CalculationValue to CalculationValueHandleMap;
therefore, we dereference null CalculationValue pointer when the temporary
Length object goes out of the scope.
Length(Calculated) is not allowed as it doesn't make sense that we construct
a Calculated Length object with uninitialized calc expression.
The code just wants to blend with zero. To fix the bug, we can just blend
with Length(0, Fixed) here as we currently can blend different type units
and zero has the same behavior regardless of unit.

Test: transitions/transition-transform-translate-calculated-length-crash.html

• platform/graphics/transforms/TranslateTransformOperation.cpp:

(WebCore::TranslateTransformOperation::blend):

LayoutTests:

• transitions/transition-transform-translate-calculated-length-crash-expected.txt: Added.
• transitions/transition-transform-translate-calculated-length-crash.html: Added.

5:43 PM Changeset in webkit [152824] by timothy_horton@apple.com

• 18 edits in trunk

Update blocked/missing plug-in UI
​https://bugs.webkit.org/show_bug.cgi?id=118347
<rdar://problem/14209318>

Reviewed by Sam Weinig.

• WebCore.exp.in:

Export RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription.

• rendering/RenderEmbeddedObject.cpp:

(WebCore::replacementTextRoundedRectPressedColor):
(WebCore::replacementTextRoundedRectColor):
(WebCore::replacementTextColor):
Change colors to new design and add some more constants.

(WebCore::shouldUnavailablePluginMessageBeButton): Added.

(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription): Added.
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
Call through to the -WithDescription variant.

(WebCore::RenderEmbeddedObject::paintReplaced):
Fill the background, and otherwise match the new design.

(WebCore::addReplacementArrowPath):
Add an arrow to the given path, inside the given rect.

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
Add a 1px padding to the bottom of the text.
Add a circle and an arrow into the indicator as per the new design.

(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
Hit-test the indicator arrow as well; otherwise, the fact that the arrow
is a hole in the path means it won't be hit.

• rendering/RenderEmbeddedObject.h:

• Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add a 6 argument -> 4 reply message handler.
(It seems that FindPlugin is getting a little out of hand.)

• Shared/APIClientTraits.cpp:
• Shared/APIClientTraits.h:
• UIProcess/API/C/WKPage.h:
• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::pluginLoadPolicy):

• UIProcess/WebLoaderClient.h:

Add an unavailability description out-argument to a new version of
pluginLoadPolicy, so clients can override the text of the unavailable
plugin indicator. Bump the WKPageLoaderClient version and update APIClientTraits.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

Plumb the unavailability description through to the WebProcess via
the FindPlugin message.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Acquire the unavailability description from the client
(via FindPlugin) and hand it to the RenderEmbeddedObject.

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
Match new WKPageLoaderClient entry.

5:35 PM Changeset in webkit [152823] by Brent Fulgham

• 2 edits in trunk/Websites/planet.webkit.org

Another attempt to make planet cron job happy

5:30 PM Changeset in webkit [152822] by Stephanie Lewis

• 2 edits in trunk/LayoutTests

Skip crashing MathML tests while waiting for a fix for
​https://bugs.webkit.org/show_bug.cgi?id=118601

Unreviewed.

• platform/mac/TestExpectations:

5:23 PM Changeset in webkit [152821] by achristensen@apple.com

• 5 edits in trunk/Source/ThirdParty/ANGLE

Made a repeatable process for updating ANGLE that does not include manually editing any files.
​https://bugs.webkit.org/show_bug.cgi?id=118815

Reviewed by Dean Jackson.

• src/compiler/glslang.y:
• src/compiler/glslang_lex.cpp:
• src/compiler/glslang_tab.cpp:
• src/compiler/glslang_tab.h: Put YYLTYPE definition in %union instead of prologue and ran Bison.

4:54 PM Changeset in webkit [152820] by Lucas Forschler

• 2 edits in tags/Safari-537.51.1/Source/JavaScriptCore

Rollout of r152600. <rdar://problem/14474400>

4:53 PM Changeset in webkit [152819] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/JavaScriptCore

Rollout of r152600. <rdar://problem/14474400>

4:43 PM Changeset in webkit [152818] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix 32-bit after ​http://trac.webkit.org/changeset/152813

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunctionNoCheck):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:41 PM Changeset in webkit [152817] by ggaren@apple.com

• 2 edits in trunk/Source/JavaScriptCore

API tests should test for JSStringCreateWithCFString with empty string
​https://bugs.webkit.org/show_bug.cgi?id=118819

Reviewed by Mark Hahnenberg.

• API/tests/testapi.c:

(main): Test!

4:37 PM Changeset in webkit [152816] by benjamin@webkit.org

• 3 edits in trunk/Source/WTF

Add a thread safety assertion when creating an AtomicString from a StringImpl
​https://bugs.webkit.org/show_bug.cgi?id=118637

Reviewed by Sam Weinig.

The goal is to prevent this kind of use:
-Someone create a String from a StringImpl.
-At some point, the string becomes atomic.
-Later, when the string only has one ref, its ownership is 'passed' to an other thread

without checking String::isSafeToSendToAnotherThread().

-In the thread B, an AtomicString is created from the String.
->The AtomicString's StringImpl returned is not in the current thread string table.

• wtf/text/AtomicString.cpp:

(WTF::AtomicString::isInAtomicStringTable):

• wtf/text/AtomicString.h:

(WTF::AtomicString::add):

4:34 PM Changeset in webkit [152815] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

Simplify AtomicString::lower()
​https://bugs.webkit.org/show_bug.cgi?id=118719
<rdar://problem/14452883>

Reviewed by Gavin Barraclough.

• wtf/text/AtomicString.cpp:

(WTF::AtomicString::lower): Previously, the code was using a copy constructor for two path
and one regular construction in another path.
Just put the StringImpl where it needs to be instead.

4:32 PM Changeset in webkit [152814] by commit-queue@webkit.org

• 44 edits
  1 delete in trunk

Unreviewed, rolling out r152701, r152703, r152739, r152754,
and r152756.
​http://trac.webkit.org/changeset/152701
​http://trac.webkit.org/changeset/152703
​http://trac.webkit.org/changeset/152739
​http://trac.webkit.org/changeset/152754
​http://trac.webkit.org/changeset/152756
​https://bugs.webkit.org/show_bug.cgi?id=118821

this was a buggy fix and we're going to try something
different (Requested by thorton on #webkit).

Source/WebCore:

• CMakeLists.txt:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.am:
• WebCore.exp.in:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

• css/unavailablePlugIns.css: Removed.
• dom/EventListener.h:
• html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::updateWidget):

• html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):

• page/ChromeClient.h:

(WebCore::ChromeClient::shouldUnavailablePluginMessageBeButton):

• rendering/RenderEmbeddedObject.cpp:

(WebCore::replacementTextRoundedRectPressedColor):
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsPressed):
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
(WebCore::RenderEmbeddedObject::replacementTextRect):
(WebCore::RenderEmbeddedObject::isReplacementObscured):
(WebCore::RenderEmbeddedObject::layout):
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
(WebCore::shouldUnavailablePluginMessageBeButton):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
(WebCore::RenderEmbeddedObject::getCursor):
(WebCore::RenderEmbeddedObject::canHaveChildren):

• rendering/RenderEmbeddedObject.h:
• rendering/RenderWidget.h:

Source/WebKit/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::shouldUnavailablePluginMessageBeButton):

Source/WebKit2:

• Platform/CoreIPC/HandleMessage.h:
• Shared/APIClientTraits.cpp:
• Shared/APIClientTraits.h:
• UIProcess/API/C/WKPage.h:
• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::pluginLoadPolicy):

• UIProcess/WebLoaderClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didClose):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginProcessCrashed):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):

Tools:

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

LayoutTests:

• editing/pasteboard/paste-noplugin-expected.txt:
• http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
• platform/mac/accessibility/plugin-expected.txt:

4:27 PM Changeset in webkit [152813] by fpizlo@apple.com

• 12 edits
  12 adds in trunk

DFG assumes that NewFunction will never pass its input through
​https://bugs.webkit.org/show_bug.cgi?id=118798

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Previously the DFG was assuming that NewFunction always returns a function. That's not
the case. It may return whatever was passed to it, if it wasn't passed SpecEmpty.

This fact needed to be wired through the compiler.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

• dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::makeTop):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Sam Weinig.

• fast/js/dfg-use-function-as-variable-expected.txt: Added.
• fast/js/dfg-use-function-as-variable-merge-structure-expected.txt: Added.
• fast/js/dfg-use-function-as-variable-merge-structure.html: Added.
• fast/js/dfg-use-function-as-variable-not-constant-expected.txt: Added.
• fast/js/dfg-use-function-as-variable-not-constant.html: Added.
• fast/js/dfg-use-function-as-variable-with-closure-expected.txt: Added.
• fast/js/dfg-use-function-as-variable-with-closure.html: Added.
• fast/js/dfg-use-function-as-variable.html: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-use-function-as-variable-merge-structure.js: Added.

(.x):
(run_tests):

• fast/js/script-tests/dfg-use-function-as-variable-not-constant.js: Added.

(run_tests.x):
(run_tests):

• fast/js/script-tests/dfg-use-function-as-variable-with-closure.js: Added.

(run_tests.x):
(run_tests.y):
(run_tests):

• fast/js/script-tests/dfg-use-function-as-variable.js: Added.

(run_tests.x):
(run_tests):

4:27 PM Changeset in webkit [152812] by Brent Fulgham

• 2 edits in trunk/Websites/planet.webkit.org

Correct webkit.org blog RSS address.

4:06 PM Changeset in webkit [152811] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merged r152600. <rdar://problem/14474400>

4:05 PM Changeset in webkit [152810] by Lucas Forschler

• 2 edits in tags/Safari-537.51.1/Source/JavaScriptCore

Merged r152600. <rdar://problem/14474400>

4:04 PM Changeset in webkit [152809] by achristensen@apple.com

• 3 edits in trunk/LayoutTests

Unreviewed. Skip more failing WebGL tests on Mac.

• platform/mac-lion/TestExpectations:
• platform/mac/TestExpectations:

4:02 PM Changeset in webkit [152808] by Stephanie Lewis

• 2 edits in trunk/LayoutTests

fullscreen/full-screen-iframe-with-max-width-height.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=118820

Unreviewed.

Label a flaky test as flaky

• platform/mac/TestExpectations:

3:14 PM Changeset in webkit [152807] by ggaren@apple.com

• 3 edits in trunk/Source/JavaScriptCore

JSStringCreateWithCFString should not convert the empty string into the NULL string
​https://bugs.webkit.org/show_bug.cgi?id=118816

Reviewed by Sam Weinig.

• API/JSStringRef.cpp:

(JSStringCreateWithUTF8CString): Removed an extraneous comment, which
a previous version of the patch made incorrect.

• API/JSStringRefCF.cpp:

(JSStringCreateWithCFString): Don't convert the empty string into the
null string.

3:08 PM Changeset in webkit [152806] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Optimize RenderLayerCompositor's OverlapMap
​https://bugs.webkit.org/show_bug.cgi?id=118764

Reviewed by Tim Horton.

Overlap stack items can have RectLists with hundreds of rectangles.
This makes the linear search in OverlapMap::overlapsLayers() very slow.

Optimize by storing the bounding rect of the list of rects, and doing an early
check on that. This reduces time spent in RenderLayer::scrollTo() by 13% in some
content with lots of layers inside an overflow:scroll.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::popCompositingContainer):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::append):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::intersects):

3:05 PM Changeset in webkit [152805] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

[Mac] Crashes in CFURLGetBytes under WebProcess::updateActivePages()
​https://bugs.webkit.org/show_bug.cgi?id=118814
<rdar://problem/14173389>

Reviewed by Brady Eidson.

Speculative fix. It's unclear how we end up with an invalid URL when committing
a load.

• WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::updateActivePages): Added a null check.

2:48 PM Changeset in webkit [152804] by Lucas Forschler

• 5 edits in tags/Safari-537.51.1/Source

Versioning

2:22 PM Changeset in webkit [152803] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed gardening after r152800.
​https://bugs.webkit.org/show_bug.cgi?id=118810.

CSS_SHAPES not yet supported on AppleWin port.

• platform/win/TestExpectations:

2:16 PM Changeset in webkit [152802] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed gardening.
Skip some tests on AppleWin port that requires AVFoundation, since it does not support it yet.

• platform/win/TestExpectations:

1:42 PM Changeset in webkit [152801] by roger_fong@apple.com

• 2 edits
  1 add in trunk/LayoutTests

Unreviewed. Rebaseline tests for AppleWin port after r152789.

• platform/win/editing/pasteboard/paste-noplugin-expected.txt: Added.
• platform/win/platform/win/plugins/draws-gradient-expected.txt:

1:31 PM Changeset in webkit [152800] by betravis@adobe.com

• 9 edits
  5 copies
  202 moves
  6 adds in trunk/LayoutTests

[CSS Shapes][CSS Exclusions] Cleanup tests to reflect split between CSS Shapes and CSS Exclusions
​https://bugs.webkit.org/show_bug.cgi?id=117164

Reviewed by Alexandru Chiculita.

Moving shapes tests from the fast/exclusions directory to the new fast/shapes directory.
In addition, some parsing tests which included both exclusions and shapes properties
have been split in order for each piece of functionality to sit within its own directory.

• fast/exclusions/parsing/script-tests/parsing-test-utils.js:
• fast/shapes/css-shapes-disabled-expected.txt: Added.
• fast/shapes/css-shapes-disabled.html: Added.
• fast/shapes/css-shapes-enabled-expected.txt: Added.
• fast/shapes/css-shapes-enabled.html: Added.
• fast/shapes/parsing/parsing-shape-inside-expected.txt: Added.
• fast/shapes/parsing/parsing-shape-inside.html: Added.
• fast/shapes/parsing/parsing-shape-lengths-expected.txt: Added.
• fast/shapes/parsing/parsing-shape-lengths.html: Added.
• fast/shapes/parsing/parsing-shape-margin-expected.txt: Added.
• fast/shapes/parsing/parsing-shape-margin.html: Added.
• fast/shapes/parsing/parsing-shape-outside-expected.txt: Added.
• fast/shapes/parsing/parsing-shape-outside.html: Added.
• fast/shapes/parsing/parsing-shape-padding-expected.txt: Added.
• fast/shapes/parsing/parsing-shape-padding.html: Added.
• fast/shapes/parsing/script-tests/parsing-shape-inside.js: Added.
• fast/shapes/parsing/script-tests/parsing-shape-lengths.js: Added.
• fast/shapes/parsing/script-tests/parsing-shape-margin.js: Added.
• fast/shapes/parsing/script-tests/parsing-shape-outside.js: Added.
• fast/shapes/parsing/script-tests/parsing-shape-padding.js: Added.
• fast/shapes/parsing/script-tests/parsing-test-utils.js: Added.
• fast/shapes/resources/multi-segment-polygon.js: Added.
• fast/shapes/resources/rounded-rectangle.js: Added.
• fast/shapes/resources/simple-polygon.js: Added.
• fast/shapes/resources/simple-rectangle.js: Added.
• fast/shapes/resources/subpixel-utils.js: Added.
• fast/shapes/shape-inside/shape-inside-animation-expected.txt: Added.
• fast/shapes/shape-inside/shape-inside-animation.html: Added.
• fast/shapes/shape-inside/shape-inside-bottom-edge-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-bottom-edge.html: Added.
• fast/shapes/shape-inside/shape-inside-box-sizing-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-box-sizing.html: Added.
• fast/shapes/shape-inside/shape-inside-circle-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-circle-padding-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-circle-padding.html: Added.
• fast/shapes/shape-inside/shape-inside-circle.html: Added.
• fast/shapes/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-coincident-vertices.html: Added.
• fast/shapes/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-collinear-vertices.html: Added.
• fast/shapes/shape-inside/shape-inside-counterclockwise-polygon-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-counterclockwise-polygon.html: Added.
• fast/shapes/shape-inside/shape-inside-dynamic-nested-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-dynamic-nested.html: Added.
• fast/shapes/shape-inside/shape-inside-dynamic-shape-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-dynamic-shape.html: Added.
• fast/shapes/shape-inside/shape-inside-dynamic-text-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-dynamic-text.html: Added.
• fast/shapes/shape-inside/shape-inside-ellipse-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-ellipse-padding-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-ellipse-padding.html: Added.
• fast/shapes/shape-inside/shape-inside-ellipse.html: Added.
• fast/shapes/shape-inside/shape-inside-empty-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-empty-segments-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-empty-segments.html: Added.
• fast/shapes/shape-inside/shape-inside-empty.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-001-horizontal-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-001-horizontal.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-001-vertical-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-001-vertical.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-002-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-002.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-003-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-003.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-004-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-004.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-reflex-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-first-fit-reflex.html: Added.
• fast/shapes/shape-inside/shape-inside-floats-simple-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-floats-simple.html: Added.
• fast/shapes/shape-inside/shape-inside-inline-elements-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-inline-elements.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-blocks-dynamic.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-blocks-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-blocks-vertical.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-blocks.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-segments-001-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-segments-001.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-segments-002-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-segments-002.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-segments-003-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-segments-003.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-segments-004-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-multiple-segments-004.html: Added.
• fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Added.
• fast/shapes/shape-inside/shape-inside-outside-shape-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-outside-shape.html: Added.
• fast/shapes/shape-inside/shape-inside-overflow-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html: Added.
• fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
• fast/shapes/shape-inside/shape-inside-overflow.html: Added.
• fast/shapes/shape-inside/shape-inside-partial-fill-001-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-partial-fill-001.html: Added.
• fast/shapes/shape-inside/shape-inside-partial-fill-002-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-partial-fill-002.html: Added.
• fast/shapes/shape-inside/shape-inside-percentage-auto-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-percentage-auto.html: Added.
• fast/shapes/shape-inside/shape-inside-percentage-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-percentage.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-layout-expected.txt: Added.
• fast/shapes/shape-inside/shape-inside-polygon-layout.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-padding-001-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-padding-001.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-padding-002-expected.txt: Added.
• fast/shapes/shape-inside/shape-inside-polygon-padding-002.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-padding-003-expected.txt: Added.
• fast/shapes/shape-inside/shape-inside-polygon-padding-003.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-rectangle-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-rectangle.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-zoom-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-polygon-zoom.html: Added.
• fast/shapes/shape-inside/shape-inside-rectangle-padding-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rectangle-padding.html: Added.
• fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rectilinear-polygon-001.html: Added.
• fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rectilinear-polygon-002.html: Added.
• fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rectilinear-polygon-003.html: Added.
• fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rectilinear-polygon-004.html: Added.
• fast/shapes/shape-inside/shape-inside-recursive-layout-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-recursive-layout.html: Added.
• fast/shapes/shape-inside/shape-inside-regular-polygon16-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-regular-polygon16.html: Added.
• fast/shapes/shape-inside/shape-inside-regular-polygon8-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-regular-polygon8.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-001-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-001.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-004.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-001.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-003.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-rounded-rectangle-padding.html: Added.
• fast/shapes/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-shape-logical-top.html: Added.
• fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.
• fast/shapes/shape-inside/shape-inside-simple-polygon-001-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-simple-polygon-001.html: Added.
• fast/shapes/shape-inside/shape-inside-simple-polygon-002-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-simple-polygon-002.html: Added.
• fast/shapes/shape-inside/shape-inside-simple-polygon-003-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-simple-polygon-003.html: Added.
• fast/shapes/shape-inside/shape-inside-simple-polygon-004-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-simple-polygon-004.html: Added.
• fast/shapes/shape-inside/shape-inside-subsequent-blocks-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-subsequent-blocks.html: Added.
• fast/shapes/shape-inside/shape-inside-text-align-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-text-align.html: Added.
• fast/shapes/shape-inside/shape-inside-text-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-text.html: Added.
• fast/shapes/shape-inside/shape-inside-vertical-text-expected.html: Added.
• fast/shapes/shape-inside/shape-inside-vertical-text.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-polygon-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-polygon.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-percentage-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-percentage.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-stacked-expected.html: Added.
• fast/shapes/shape-outside-floats/shape-outside-floats-stacked.html: Added.

12:53 PM Changeset in webkit [152799] by Lucas Forschler

• 5 edits
  3 copies in branches/safari-537-branch

Merged r152742. <rdar://problem/14202134>

12:52 PM Changeset in webkit [152798] by Lucas Forschler

• 5 edits
  3 copies in tags/Safari-537.51.1

Merged r152742. <rdar://problem/14202134>

12:49 PM Changeset in webkit [152797] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152740. <rdar://problem/14300350>

12:48 PM Changeset in webkit [152796] by Lucas Forschler

• 2 edits in tags/Safari-537.51.1/Source/WebKit2

Merged r152740. <rdar://problem/14300350>

12:31 PM Changeset in webkit [152795] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebKit2

Unreviewed, rolling out r152786 and r152789.
​http://trac.webkit.org/changeset/152786
​http://trac.webkit.org/changeset/152789
​https://bugs.webkit.org/show_bug.cgi?id=118807

overly platform specific and dirty API (and Sam says no)
(Requested by thorton on #webkit).

• WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
• WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
• WebProcess/WebPage/PageOverlay.cpp:
• WebProcess/WebPage/PageOverlay.h:
• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

12:24 PM Changeset in webkit [152794] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[CSS Shapes] Port refactoring of shape-outside code from Blink
​https://bugs.webkit.org/show_bug.cgi?id=118757

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-07-17
Reviewed by Dean Jackson.

Refactor the left and right offset methods to reduce the number of
arguments by splitting the methods into smaller methods. This
refactoring was requested as part of porting support for stacked
floats with shape-outside to Blink.

Also add a variable when calling computeSegmentsForLine to make it
more readable and easier to follow the coordinate system change.

No new tests, no behavior change.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat): Update to use

the refactored IgnoringShapeOutside methods.

(WebCore::RenderBlock::logicalLeftFloatOffsetForLine): New method to

compute the offset contributed by left floats.

(WebCore::RenderBlock::adjustLogicalLeftOffsetForLine): New method to

compute misc adjustments to the left offset.

(WebCore::RenderBlock::logicalRightFloatOffsetForLine): New method to

compute the offset contributed by right floats.

(WebCore::RenderBlock::adjustLogicalRightOffsetForLine): New method to

compute misc adjustments to the right offset.

• rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForLine): Implement original

method in terms of the float offset computation method and the
offset adjustment method. This method takes into account the
shape-outside on any floats when computing the offset.

(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalRightOffsetForLineIgnoringShapeOutside):

Compute the right offset as if there was no shape-outside on any
of the floats.

(WebCore::RenderBlock::logicalLeftOffsetForLineIgnoringShapeOutside):

Compute the left offset as if there was no shape-outside on any
of the floats.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Update

to use a variable to make the calls to computeSegmentsForLine more
explicit about the coordinate system conversion.

11:46 AM Changeset in webkit [152793] by akling@apple.com

• 7 edits
  2 adds in trunk

Wrong linebox height, when block element parent has vertical-align property defined.
​https://bugs.webkit.org/show_bug.cgi?id=118245

Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-17
Reviewed by David Hyatt.

Do not push the current element to the next, when it is still considered empty, even with
some object(s) in front. Behave as if it was actually empty.
Inline elements like <span></span> generate such lines.

Source/WebCore:

Test: fast/css/empty-span-with-parent-div-and-vertical-align.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

• fast/css/empty-span-with-parent-div-and-vertical-align-expected.html: Added.
• fast/css/empty-span-with-parent-div-and-vertical-align.html: Added.
• platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.png: Rebased.
• platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Rebased.
• platform/mac/tables/mozilla/marvin/backgr_index-expected.png: Rebased.
• platform/mac/tables/mozilla/marvin/backgr_index-expected.txt: Rebased.

11:35 AM Changeset in webkit [152792] by Lucas Forschler

• 1 copy in tags/Safari-537.51.1

New Tag.

11:07 AM Changeset in webkit [152791] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r151535.
​http://trac.webkit.org/changeset/151535
​https://bugs.webkit.org/show_bug.cgi?id=118804

Re-disable WinEWS tests (Requested by rfong on #webkit).

• Scripts/webkitpy/common/config/ews.json:

10:59 AM Changeset in webkit [152790] by achristensen@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed. Skip failing WebGL tests.

• platform/mac/TestExpectations:

10:38 AM Changeset in webkit [152789] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

AX: VoiceOver not working with data detection page overlays
​https://bugs.webkit.org/show_bug.cgi?id=118680

Reviewed by Anders Carlsson.

Bump the API version after r152786.

• WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:

10:21 AM Changeset in webkit [152788] by akling@apple.com

• 11 edits in trunk

CSS selector list splitting should be by component, not by selector.
<​http://webkit.org/b/118761>
<rdar://problem/14421609>

Reviewed by Antti Koivisto.

Source/WebCore:

Test (amended): fast/css/rule-selector-overflow.html

• css/CSSSelectorList.h:
• css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::componentCount):

• css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::setSelectorText):

Renamed CSSSelectorList::length() to componentCount() and made it public.

• css/RuleSet.h:

maximumSelectorCount => maximumSelectorComponentCount

• css/StyleRule.cpp:

(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):

Make the splits after accumulating 'maximumSelectorComponentCount' components.

• css/StyleRule.h:
• css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAppendRule):

splitIntoMultipleRulesWithMaximumSelectorCount => splitIntoMultipleRulesWithMaximumSelectorComponentCount

LayoutTests:

Added more cases to the already existing selector list splitting test.

• fast/css/rule-selector-overflow-expected.txt:
• fast/css/rule-selector-overflow.html:

10:10 AM Changeset in webkit [152787] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

YouTube webcam capture (Flash Plug-in) in Safari can't see built-in camera
​https://bugs.webkit.org/show_bug.cgi?id=118787
<rdar://problem/14418799>

Patch by Simon Cooper <​scooper@apple.com> on 2013-07-17
Reviewed by Alexey Proskuryakov.

Add support for built-in cameras, including the original iSight.

• Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
• Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:

9:44 AM Changeset in webkit [152786] by Chris Fleizach

• 8 edits in trunk/Source/WebKit2

AX: VoiceOver not working with data detection page overlays
​https://bugs.webkit.org/show_bug.cgi?id=118680

Reviewed by Tim Horton.

Expose API methods so that a client implementing data detectors is able to respond
to the needs of accessibility clients like VoiceOver.

• WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(PageOverlayClientImpl::supportsDataDetection):
(PageOverlayClientImpl::dataDetectorExistsAtPoint):
(PageOverlayClientImpl::dataDetectorCopyTypeAtPoint):
(PageOverlayClientImpl::showDataDetectorMenuAtPoint):

• WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
• WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::supportsDataDetection):
(WebKit::PageOverlay::dataDetectorExistsAtPoint):
(WebKit::PageOverlay::dataDetectorCopyTypeAtPoint):
(WebKit::PageOverlay::dataDetectorOpenMenuAtPoint):

• WebProcess/WebPage/PageOverlay.h:

(WebKit::PageOverlay::Client::supportsDataDetection):
(WebKit::PageOverlay::Client::dataDetectorExistsAtPoint):
(WebKit::PageOverlay::Client::dataDetectorCopyTypeAtPoint):
(WebKit::PageOverlay::Client::showDataDetectorMenuAtPoint):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::pageOverlayOpenDataDetectorMenuAtPoint):
(WebKit::WebPage::pageOverlayDataDetectorCopyTypeAtPoint):
(WebKit::WebPage::pageOverlayDataDetectorExistsAtPoint):
(WebKit::WebPage::pageOverlaySupportsDataDetection):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject _convertScreenPointToWindow:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):

9:40 AM Changeset in webkit [152785] by rwlbuis@webkit.org

• 5 edits in trunk

[Mac] REGRESSION(r152685): svg/custom/xlink-prefix-in-attributes.html failed unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=118701

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use the computed attribute prefix, otherwise href being in xlink namespace but not having any prefix
will cause outputting the xlink namespace in appendNamespace.

Patch fixes svg/custom/xlink-prefix-in-attributes.html.

• editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendAttribute):

LayoutTests:

• platform/mac/TestExpectations:
• platform/qt/TestExpectations:

9:26 AM Changeset in webkit [152784] by commit-queue@webkit.org

• 8 edits in trunk/Source/JavaScriptCore

Naming convention on createInvalidParamError is incorrect.
​https://bugs.webkit.org/show_bug.cgi?id=118756

Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-07-17
Reviewed by Geoffrey Garen.

Changed the naming of createInvalidParamError to createInvalidParameterError.
This corrects the naming convention for the function listed in the WebKit code styling.

• interpreter/Interpreter.cpp:

(JSC::loadVarargs):

• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::opIn):

• runtime/ExceptionHelpers.cpp:

(JSC::createInvalidParameterError):

• runtime/ExceptionHelpers.h:
• runtime/JSObject.cpp:

(JSC::JSObject::hasInstance):

9:15 AM Changeset in webkit [152783] by Chris Fleizach

• 3 edits
  2 adds in trunk

Regression: columnheader/rowheader roles not exposed correctly
​https://bugs.webkit.org/show_bug.cgi?id=113628

Reviewed by Tim Horton.

Source/WebCore:

When we determine the row and column headers we look at the ARIA role being returned, but
since TableCell overrides the determineAccessibilityRole method, the ARIA role is never set.

Test: platform/mac/accessibility/aria-columnrowheaders.html

• accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::determineAccessibilityRole):

LayoutTests:

• platform/mac/accessibility/aria-columnrowheaders-expected.txt: Added.
• platform/mac/accessibility/aria-columnrowheaders.html: Added.

8:34 AM Changeset in webkit [152782] by commit-queue@webkit.org

• 4 edits in trunk

[GTK] Make DRT obbey testRunner's addURLToRedirect
​https://bugs.webkit.org/show_bug.cgi?id=118239

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-07-17
Reviewed by Gustavo Noronha Silva.

Tools:

Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
to the proper URI when indicated.

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(willSendRequestCallback):

LayoutTests:

Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now that DRT obbeys
testRunner's addURLToRedirect.

• platform/gtk/TestExpectations:

8:23 AM WebKitGTK/WebKit2Roadmap edited by brian.holt@samsung.com

Brian to implement authentication dialog API (diff)

6:54 AM Changeset in webkit [152781] by zarvai@inf.u-szeged.hu

• 2 edits
  2 adds in trunk/LayoutTests

[Qt] Unreviewd gardening. Rebase and skip failing tests.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-07-17

• platform/qt-5.0-wk2/TestExpectations:
• platform/qt-5.0-wk2/fast/replaced/border-radius-clip-expected.png: Added.
• platform/qt-5.0-wk2/fast/replaced/border-radius-clip-expected.txt: Added.

3:27 AM Changeset in webkit [152780] by Christophe Dumez

• 23 edits
  1 add in trunk/Source/WebCore

Get rid of SVGPoint special case from the bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=118783

Reviewed by Kentaro Hara.

Get rid of SVGPoint special case from the bindings generator by adding a
new SVGPoint.h header that contains a typedef to FloatPoint.

Also use SVGPoint type in the implementation API for consistency with
the IDL.

No new tests, no behavior change.

• bindings/scripts/CodeGenerator.pm:

(SkipIncludeHeader):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionImmutablePointFunction):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionImmutablePointFunction):

• bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj mutablePoint]):
(-[DOMTestObj immutablePoint]):
(-[DOMTestObj mutablePointFunction]):
(-[DOMTestObj immutablePointFunction]):

• bindings/scripts/test/ObjC/DOMTestTypedefs.mm:

(-[DOMTestTypedefs immutablePointFunction]):

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):

• rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::startPositionOfCharacter):
(WebCore::SVGTextQuery::endPositionOfCharacter):
(WebCore::SVGTextQuery::characterNumberAtPosition):

• rendering/svg/SVGTextQuery.h:
• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::getPointAtLength):

• svg/SVGPathElement.h:
• svg/SVGPathTraversalStateBuilder.cpp:

(WebCore::SVGPathTraversalStateBuilder::currentPoint):

• svg/SVGPathTraversalStateBuilder.h:
• svg/SVGPathUtilities.cpp:

(WebCore::getPointAtLengthOfSVGPathByteStream):

• svg/SVGPathUtilities.h:
• svg/SVGPoint.h: Added.
• svg/SVGPointList.cpp:

(WebCore::SVGPointList::valueAsString):

• svg/SVGPointList.h:
• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::createSVGPoint):

• svg/SVGSVGElement.h:
• svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::getStartPositionOfChar):
(WebCore::SVGTextContentElement::getEndPositionOfChar):
(WebCore::SVGTextContentElement::getCharNumAtPosition):

• svg/SVGTextContentElement.h:
• svg/SVGZoomEvent.cpp:

(WebCore::SVGZoomEvent::previousTranslate):
(WebCore::SVGZoomEvent::newTranslate):

• svg/SVGZoomEvent.h:

3:11 AM Changeset in webkit [152779] by Csaba Osztrogonác

• 2 edits in trunk/Tools

Add a new find-resolved-bugs command to webkit-patch.
​https://bugs.webkit.org/show_bug.cgi?id=118060

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-07-17
Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/tool/commands/queries.py:

(PrintBaselines._platform_for_path):
(FindResolvedBugs):
(FindResolvedBugs.execute):

2:39 AM Changeset in webkit [152778] by Carlos Garcia Campos

• 9 edits
  4 adds in trunk/Source/WebCore

[GStreamer] webkitwebsrc: use SubResourceLoader
​https://bugs.webkit.org/show_bug.cgi?id=73743

Reviewed by Philippe Normand.

• GNUmakefile.list.am: Add new files to compilation.
• PlatformEfl.cmake: Ditto.
• PlatformGTK.cmake: Ditto.
• loader/SubresourceLoader.h: Add getOrCreateReadBuffer() when

using SOUP.

• loader/cache/CachedRawResource.h:
• loader/cache/CachedRawResourceClient.h:

(WebCore::CachedRawResourceClient::getOrCreateReadBuffer): Added
to allow the client to allocate the read buffer.

• loader/cache/CachedResource.h:

(WebCore::CachedResource::getOrCreateReadBuffer):

• loader/soup/CachedRawResourceSoup.cpp: Added.

(WebCore::CachedRawResource::getOrCreateReadBuffer): Iterate the
clients until one returns a valid read buffer or return NULL to
fallback to the default read buffer.

• loader/soup/SubresourceLoaderSoup.cpp: Added.

(WebCore::SubresourceLoader::getOrCreateReadBuffer): Call
CachedResource::getOrCreateReadBuffer().

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient): Make this a CachedRawResourceClient.
(_WebKitWebSrcPrivate): Remove frame and resourceHandle and add a
cached resource handle.
(webKitWebSrcDispose): Clear the player pointer.
(webKitWebSrcStop): Remove the client from the cached resource.
(webKitWebSrcStart): Use CachedResourceLoader to schedule a
CachedRawResource load for the media without buffering the data.
(webKitWebSrcNeedDataMainCb): Call CachedResource::setDefersLoading.
(webKitWebSrcEnoughDataMainCb): Ditto.
(webKitWebSrcSetMediaPlayer): Simply update the player pointer.
(StreamingClient::responseReceived): Update to the
CachedRawResourceClient API.
(StreamingClient::dataReceived): Ditto.
(StreamingClient::getOrCreateReadBuffer): Ditto.
(StreamingClient::notifyFinished): Ditto.

2:16 AM Changeset in webkit [152777] by commit-queue@webkit.org

• 1 edit
  30 adds
  54 deletes in trunk/LayoutTests

Replace MathML pixel tests by reftests.
​https://bugs.webkit.org/show_bug.cgi?id=118599

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-07-17
Reviewed by Chris Fleizach.

• attributes.xhtml is replaced by attributes*.html

• underover.xhtml, under.xhtml, sub.xhtml, sup.xhtml, over.xhtml and subsup.xhtml are replaced by scripts*.html and bug*.html.

• tokenElements.xhtml is replaced by replaced tokenElements-mathvariant.html

• mathml/presentation/attributes-background-color-expected.html: Added.
• mathml/presentation/attributes-background-color.html: Added.
• mathml/presentation/attributes-display-expected.html: Added.
• mathml/presentation/attributes-display.html: Added.
• mathml/presentation/attributes-mathsize-expected.html: Added.
• mathml/presentation/attributes-mathsize.html: Added.
• mathml/presentation/attributes-mathvariant-expected.html: Added.
• mathml/presentation/attributes-mathvariant.html: Added.
• mathml/presentation/attributes-style-expected-mismatch.html: Added.
• mathml/presentation/attributes-style.html: Added.
• mathml/presentation/attributes.xhtml: Removed.
• mathml/presentation/bug95015-expected.html: Added.
• mathml/presentation/bug95015.html: Added.
• mathml/presentation/bug95404-expected.html: Added.
• mathml/presentation/bug95404.html: Added.
• mathml/presentation/bug97990-expected.html: Added.
• mathml/presentation/bug97990.html: Added.
• mathml/presentation/over.xhtml: Removed.
• mathml/presentation/scripts-font-size-expected-mismatch.html: Added.
• mathml/presentation/scripts-font-size.html: Added.
• mathml/presentation/scripts-height-expected.html: Added.
• mathml/presentation/scripts-height.html: Added.
• mathml/presentation/scripts-mrow-expected.html: Added.
• mathml/presentation/scripts-mrow.html: Added.
• mathml/presentation/scripts-subsup-expected.html: Added.
• mathml/presentation/scripts-subsup.html: Added.
• mathml/presentation/scripts-underover-expected.html: Added.
• mathml/presentation/scripts-underover.html: Added.
• mathml/presentation/scripts-width-expected.html: Added.
• mathml/presentation/scripts-width.html: Added.
• mathml/presentation/sub.xhtml: Removed.
• mathml/presentation/subsup.xhtml: Removed.
• mathml/presentation/sup.xhtml: Removed.
• mathml/presentation/tokenElements-mathvariant-expected.html: Added.
• mathml/presentation/tokenElements-mathvariant.html: Added.
• mathml/presentation/tokenElements.xhtml: Removed.
• mathml/presentation/under.xhtml: Removed.
• mathml/presentation/underover.xhtml: Removed.

1:47 AM Changeset in webkit [152776] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2CookieManagerTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118721

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(compareHostNames):
(onCookiesChanged):
(EWK2CookieManagerTest::getAcceptPolicy):
(EWK2CookieManagerTest::getHostnamesWithCookies):
(EWK2CookieManagerTest::freeHostNames):
(EWK2CookieManagerTest::countHostnamesWithCookies):
(TEST_F):

1:40 AM Changeset in webkit [152775] by kseo@webkit.org

• 2 edits in trunk/Source/WebCore

Remove unused member variable m_domURL from WorkerGlobalScope
​https://bugs.webkit.org/show_bug.cgi?id=118784

Reviewed by Christophe Dumez.

WorkerContext::webkitURL() was removed in r107082, and this was the
only place where the member variable |m_domURL| in WorkerContext was
mutated. This variable is no longer needed and so it should be removed.

No behavior change.

• workers/WorkerGlobalScope.h:

1:37 AM Changeset in webkit [152774] by kbalazs@webkit.org

• 13 edits in trunk

[CMake] Undefined references should be detected at build time
​https://bugs.webkit.org/show_bug.cgi?id=110236

Patch by Balazs Kelemen <​kbalazs@webkit.org> on 2013-07-16
Reviewed by Christophe Dumez.

.:

Pass the --no-undefined argument to the linker on platforms where it is available.

• Source/cmake/OptionsCommon.cmake:

Source/WebKit:

Add library dependencies that were not defined explicitly before.

• CMakeLists.txt:
• PlatformEfl.cmake:

Source/WebKit2:

Add library dependencies that were not defined explicitly before.

• CMakeLists.txt:
• PlatformEfl.cmake:

Tools:

Add library dependencies that were not defined explicitly before.

• DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
• TestWebKitAPI/CMakeLists.txt:
• WebKitTestRunner/CMakeLists.txt:

12:27 AM Changeset in webkit [152773] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2WindowFeaturesTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118780

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_window_features.cpp:

(EWK2WindowFeaturesTest::createDefaultWindow):
(EWK2WindowFeaturesTest::createWindow):
(TEST_F):

12:26 AM Changeset in webkit [152772] by zoltan@webkit.org

• 2 edits in trunk/LayoutTests

[CSS Shapes] Remove setCSSShapesEnabled(true) from shape-inside-on-first-region-inline-content-expected.html since it's no longer using shapes
​https://bugs.webkit.org/show_bug.cgi?id=117952

Reviewed by Alexandru Chiculita.

• fast/regions/shape-inside/shape-inside-on-first-region-inline-content-expected.html:

12:25 AM Changeset in webkit [152771] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2ViewTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118779

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(EWK2ViewTest::onLoadFinishedForRedirection):
(EWK2ViewTest::serverCallbackNavigation):
(EWK2ViewTest::onFormAboutToBeSubmitted):
(EWK2ViewTest::fullScreenCallback):
(EWK2ViewTest::fullScreenExitCallback):
(EWK2ViewTest::checkAlert):
(EWK2ViewTest::checkConfirm):
(EWK2ViewTest::checkPrompt):
(EWK2ViewTest::onTextFound):
(EWK2ViewTest::onVibrate):
(EWK2ViewTest::onCancelVibration):
(EWK2ViewTest::loadVibrationHTMLString):
(EWK2ViewTest::onContentsSizeChangedPortrait):
(EWK2ViewTest::onContentsSizeChangedLandscape):
(EWK2ViewTest::PageContentsAsMHTMLCallback):
(EWK2ViewTest::PageContentsAsStringCallback):
(TEST_F):

12:23 AM Changeset in webkit [152770] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2StorageManagerTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118777

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:

(EWK2StorageManagerTest::OriginData::OriginData):
(EWK2StorageManagerTest::getStorageOriginsCallback):
(EWK2StorageManagerTest::timerCallback):
(EWK2StorageManagerTest::checkOrigin):
(TEST_F):

12:22 AM Changeset in webkit [152769] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2PopupMenuTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118775

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:

(EWK2PopupMenuTest::checkBasicPopupMenuItem):
(EWK2PopupMenuTest::selectItemAfterDelayed):
(EWK2PopupMenuTest::showPopupMenu):
(TEST_F):

12:20 AM Changeset in webkit [152768] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

ASSERTION FAILED: layoutState->m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage
​https://bugs.webkit.org/show_bug.cgi?id=118587

Patch by Mihai Maerean <Mihai Maerean> on 2013-07-17
Reviewed by David Hyatt.

Source/WebCore:

The fix consists in not calling containingBlockLogicalHeightForPositioned for flow threads (in
RenderBox::availableLogicalHeightUsing) as it gets to handle the RenderView as it would have been flowed into
the flow thread.

Test: fast/regions/crash-div-outside-body-vertical-rl.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeightUsing):

LayoutTests:

• fast/regions/crash-div-outside-body-vertical-rl-expected.html: Added.
• fast/regions/crash-div-outside-body-vertical-rl.html: Added.

12:19 AM Changeset in webkit [152767] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2FileChooserRequestTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118773

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:

(EWK2FileChooserRequestTest::onFileChooserRequest):
(EWK2FileChooserRequestTest::compareStrings):
(EWK2FileChooserRequestTest::freeStringList):
(TEST_F):

12:18 AM Changeset in webkit [152766] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2FaviconDatabaseTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118772

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:

(EWK2FaviconDatabaseTest::serverCallback):
(EWK2FaviconDatabaseTest::requestFaviconData):
(TEST_F):

12:16 AM Changeset in webkit [152765] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2EinaSharedStringTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118771

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:

(EWK2EinaSharedStringTest::checkString):
(TEST_F):

12:15 AM Changeset in webkit [152764] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2DownloadJobTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118769

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_download_job.cpp:

(EWK2DownloadJobTest::fileExists):
(EWK2DownloadJobTest::serverCallback):
(EWK2DownloadJobTest::on_download_requested):
(EWK2DownloadJobTest::on_download_cancelled):
(EWK2DownloadJobTest::on_download_failed):
(EWK2DownloadJobTest::on_download_finished):
(TEST_F):

12:12 AM Changeset in webkit [152763] by kangil.han@samsung.com

• 26 edits in trunk/Source

Use toHTMLMediaElement
​https://bugs.webkit.org/show_bug.cgi?id=118727

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch uses toHTMLMediaElement for code cleanup.

Source/WebCore:

• bindings/js/JSHTMLMediaElementCustom.cpp:

(WebCore::JSHTMLMediaElement::setController):

• html/HTMLMediaElement.h:

(WebCore::toHTMLMediaElement):

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::removedFrom):
(WebCore::HTMLTrackElement::mediaElement):

• html/shadow/MediaControlElementTypes.cpp:

(WebCore::toParentMediaElement):

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):

• page/FrameView.cpp:

(WebCore::FrameView::updateWidget):

• platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):
(WebCore::RenderThemeEfl::paintMediaToggleClosedCaptionsButton):

• platform/graphics/wince/MediaPlayerProxy.cpp:

(WebCore::WebMediaPlayerProxy::initEngine):
(WebCore::WebMediaPlayerProxy::element):

• platform/gtk/RenderThemeGtk.cpp:

(WebCore::getMediaElementFromRenderObject):

• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::mediaElement):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForVideo):

• rendering/RenderMedia.cpp:

(WebCore::RenderMedia::mediaElement):

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):

• rendering/RenderThemeWinCE.cpp:

(WebCore::mediaElementParent):

• testing/Internals.cpp:

(WebCore::Internals::simulateAudioInterruption):

Source/WebKit/blackberry:

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):

Source/WebKit/gtk:

• WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::enterFullscreenForNode):
(WebKit::ChromeClient::exitFullscreenForNode):
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _enterFullscreenForNode:WebCore::]):

Source/WebKit/win:

• WebView.cpp:

(WebView::enterFullscreenForNode):

12:11 AM Changeset in webkit [152762] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2AuthRequestTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118766

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:

(EWK2AuthRequestTest::serverCallback):
(EWK2AuthRequestTest::onAuthenticationRequest):
(EWK2AuthRequestTest::onLoadFinished):
(TEST_F):

12:09 AM Changeset in webkit [152761] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2ContextMenuTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118767

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:

(EWK2ContextMenuTest::checkBasicContextMenuItem):
(EWK2ContextMenuTest::customItemSelected):
(EWK2ContextMenuTest::showContextMenu):
(EWK2ContextMenuTest::showContextMenuForRemoveAndAppend):
(EWK2ContextMenuTest::showContextMenuForSubmenu):
(EWK2ContextMenuTest::hideContextMenu):
(TEST_F):

12:06 AM Changeset in webkit [152760] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2ContextTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118763

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_context.cpp:

(EWK2ContextTest::schemeRequestCallback):
(TEST_F):

12:05 AM Changeset in webkit [152759] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2DatabaseManagerTest should be defined by inheriting from EWK2UnitTestBase
​https://bugs.webkit.org/show_bug.cgi?id=118726

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:

(EWK2DatabaseManagerTest::OriginData::OriginData):
(EWK2DatabaseManagerTest::databaseOriginsCallback):
(EWK2DatabaseManagerTest::timerCallback):
(TEST_F):

12:03 AM Changeset in webkit [152758] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2ColorPickerTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118762

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-17
Reviewed by Christophe Dumez.

It should be defined as relevant test class specific to each test file for more readability.
It could be helpful to remove unnecessary static methods.

• UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:

(EWK2ColorPickerTest::onColorPickerDone):
(EWK2ColorPickerTest::setColorPickerColor):
(EWK2ColorPickerTest::showColorPicker):
(EWK2ColorPickerTest::hideColorPicker):
(EWK2ColorPickerTest::hideColorPickerByRemovingElement):
(TEST_F):

Jul 16, 2013:

11:43 PM Changeset in webkit [152757] by ryuan.choi@samsung.com

• 4 edits in trunk/Source/WebCore

Remove Platform(EFL) guard from Widget::frameRectsChanged
​https://bugs.webkit.org/show_bug.cgi?id=118782

Reviewed by Christophe Dumez.

Since r58487, Widget::frameRectsChanged was moved to cpp and guarded.
But we can move back to header because WebKit/Efl refactored related code in r145710.

No new tests, refactoring.

• platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header.
• platform/Widget.h:

(WebCore::Widget::frameRectsChanged):

• platform/efl/WidgetEfl.cpp:

11:04 PM Changeset in webkit [152756] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

setPluginUnavailabilityReason can destroy renderObject before obscurity check
​https://bugs.webkit.org/show_bug.cgi?id=118770
<rdar://problem/14462331>

Patch by Gordon Sheridan <​gordon_sheridan@apple.com> on 2013-07-16
Reviewed by Tim Horton.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Moved obscurity check to before renderObject is potentially destroyed.

10:34 PM Changeset in webkit [152755] by achristensen@apple.com

• 43 edits
  1 move
  3 adds
  1 delete in trunk/Source

Source/ThirdParty/ANGLE: Update ANGLE from r1987 to r2426 while keeping these changes:
Keeping #if defined(_MSC_VER) around #pragma warning(disable: 4718) in DependencyGraph.cpp.
Keeping include khrplatform.h instead of KHR/khrplatform.h in ShaderLang.h.
Added static_casts in Intermediate.cpp to fix compiling on Mac.
Changed enum bit fields to just enums for GCC in Types.h to fix compiling for GTK.
Ran Bison on Mac after removing the unsupported %code tag (See diff uploaded to bug for details).
Added YYLTYPE definition to glslang_tab.h which would have been put there by the unsupported %code tag.

​https://bugs.webkit.org/show_bug.cgi?id=118550

Reviewed by Dean Jackson.

• ANGLE.plist: Updated revision of ANGLE to 2426.
• ANGLE.xcodeproj/project.pbxproj:
• GNUmakefile.am:
• Target.pri:

Renamed DetectRecursion to DetectCallDepth and added builtin_symbol_table.

• include/GLSLANG/ShaderLang.h:
• src/common/version.h:
• src/compiler/BaseTypes.h:

(getQualifierString):

• src/compiler/Common.h:
• src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::detectCallDepth):
(TCompiler::enforceTimingRestrictions):
(TCompiler::limitExpressionComplexity):

• src/compiler/ConstantUnion.h:

(ConstantUnion::ConstantUnion):

• src/compiler/DetectCallDepth.cpp: Added.

(DetectCallDepth::FunctionNode::FunctionNode):
(DetectCallDepth::FunctionNode::getName):
(DetectCallDepth::FunctionNode::addCallee):
(DetectCallDepth::FunctionNode::detectCallDepth):
(DetectCallDepth::FunctionNode::reset):
(DetectCallDepth::DetectCallDepth):
(DetectCallDepth::~DetectCallDepth):
(DetectCallDepth::visitAggregate):
(DetectCallDepth::checkExceedsMaxDepth):
(DetectCallDepth::resetFunctionNodes):
(DetectCallDepth::detectCallDepthForFunction):
(DetectCallDepth::detectCallDepth):
(DetectCallDepth::findFunctionByName):

• src/compiler/DetectCallDepth.h: Added.

(DetectCallDepth::getInfoSink):

• src/compiler/DetectRecursion.cpp: Removed.
• src/compiler/DetectRecursion.h: Removed.
• src/compiler/Diagnostics.cpp:

(TDiagnostics::writeInfo):

• src/compiler/ForLoopUnroll.cpp:

(ForLoopUnroll::evaluateIntConstant):

• src/compiler/InfoSink.cpp:

(TInfoSinkBase::prefix):
(TInfoSinkBase::location):
(TInfoSinkBase::message):

• src/compiler/InfoSink.h:
• src/compiler/Initialize.cpp:

(TBuiltIns::initialize):
(IdentifyBuiltIns):
(InitExtensionBehavior):

• src/compiler/Intermediate.cpp: Updated and added static_casts to fix build errors on Mac.

(TIntermediate::addSymbol):
(TIntermediate::addBinaryMath):
(TIntermediate::addAssign):
(TIntermediate::addIndex):
(TIntermediate::addUnaryMath):
(TIntermediate::setAggregateOperator):
(TIntermediate::addConversion):
(TIntermediate::growAggregate):
(TIntermediate::makeAggregate):
(TIntermediate::addSelection):
(TIntermediate::addComma):
(TIntermediate::addConstantUnion):
(TIntermediate::addSwizzle):
(TIntermediate::addLoop):
(TIntermediate::addBranch):
(TIntermUnary::promote):
(TIntermBinary::promote):
(CompareStruct):
(CompareStructure):
(TIntermConstantUnion::fold):
(TIntermediate::promoteConstantUnion):

• src/compiler/OutputGLSL.cpp:

(TOutputGLSL::visitSymbol):

• src/compiler/OutputGLSL.h:
• src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::writeVariableType):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitBinary):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::getTypeName):
(TOutputGLSLBase::hashFunctionName):
(TOutputGLSLBase::structDeclared):
(TOutputGLSLBase::declareStruct):

• src/compiler/OutputGLSLBase.h:
• src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::initializer):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::writeConstantUnion):
(sh::OutputHLSL::decorateField):

• src/compiler/OutputHLSL.h:
• src/compiler/ParseHelper.cpp:

(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::containsSampler):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::findFunction):
(TParseContext::isVariableBuiltIn):
(TParseContext::executeInitializer):
(TParseContext::addConstructor):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::structNestingErrorCheck):

• src/compiler/ParseHelper.h:

(TParseContext::TParseContext):
(TParseContext::pragma):

• src/compiler/PoolAlloc.cpp:

(TPoolAllocator::allocate):

• src/compiler/ShHandle.h:
• src/compiler/ShaderLang.cpp:

(ShInitBuiltInResources):

• src/compiler/SymbolTable.cpp:

(TType::TType):
(TType::buildMangledName):
(TType::getObjectSize):
(TStructure::containsArrays):
(TStructure::buildMangledName):
(TStructure::calculateObjectSize):
(TStructure::calculateDeepestNesting):
(TSymbolTableLevel::relateToExtension):

• src/compiler/SymbolTable.h:

(TSymbol::relateToExtension):
(TSymbol::getExtension):
(TVariable::TVariable):
(TVariable::setQualifier):
(TVariable::shareConstPointer):

• src/compiler/Types.h: Updated and changed enum bit fields to enums to fix compiling with GCC.

(TField::TField):
(TField::type):
(TField::name):
(NewPoolTFieldList):
(TStructure::TStructure):
(TStructure::name):
(TStructure::fields):
(TStructure::mangledName):
(TStructure::objectSize):
(TStructure::deepestNesting):
(TType::TType):
(TType::clearArrayness):
(TType::getStruct):
(TType::setStruct):
(TType::getMangledName):
(TType::getDeepestStructNesting):
(TType::isStructureContainingArrays):
(TPublicType::setBasic):

• src/compiler/VariableInfo.cpp:

(getUserDefinedVariableInfo):

• src/compiler/builtin_symbol_table.cpp: Added.

(builtin1):
(builtin2):
(builtin3):
(InsertBuiltInFunctionsCommon):
(InsertBuiltInFunctionsVertex):

• src/compiler/builtin_symbol_table.h: Added.
• src/compiler/glslang.l:
• src/compiler/glslang.y:
• src/compiler/glslang_lex.cpp:

(yy_get_previous_state):
(yy_try_NUL_trans):
(yyget_lloc):
(yyset_lloc):
(string_input):
(check_type):
(reserved_word):
(glslang_scan):

• src/compiler/glslang_tab.cpp:

(yysyntax_error):
(yyerror):
(glslang_parse):

• src/compiler/glslang_tab.h: Readded YYLTYPE definition after Bison removed it.
• src/compiler/intermOut.cpp:

(TOutputTraverser::visitUnary):
(TOutputTraverser::visitAggregate):
(TOutputTraverser::visitConstantUnion):

• src/compiler/intermediate.h:

(TIntermNode::TIntermNode):
(TIntermNode::~TIntermNode):
(TIntermNode::getLine):
(TIntermNode::setLine):
(TIntermNode::getAsLoopNode):
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
(TIntermAggregate::TIntermAggregate):
(TIntermTraverser::TIntermTraverser):
(TIntermTraverser::getMaxDepth):
(TIntermTraverser::incrementDepth):

• src/compiler/localintermediate.h:
• src/compiler/parseConst.cpp:

(TConstTraverser::visitSymbol):
(TConstTraverser::visitBinary):
(TConstTraverser::visitUnary):
(TConstTraverser::visitAggregate):
(TConstTraverser::visitSelection):
(TConstTraverser::visitConstantUnion):
(TConstTraverser::visitLoop):
(TConstTraverser::visitBranch):
(TIntermediate::parseConstTree):

• src/compiler/preprocessor/ExpressionParser.cpp:
• src/compiler/timing/RestrictVertexShaderTiming.cpp:

(RestrictVertexShaderTiming::visitSymbol):

Updated ANGLE to r2426 and ran Bison.

Source/WebCore: Update ANGLE to r2426.
​https://bugs.webkit.org/show_bug.cgi?id=118550

Reviewed by Dean Jackson.

• CMakeLists.txt: Renamed DetectRecursion to DetectCallDepth and added builtin_symbol_table.

7:04 PM Changeset in webkit [152754] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebCore

Many crashes loading Java applets after r152701
​https://bugs.webkit.org/show_bug.cgi?id=118760
<rdar://problem/14462836>

Reviewed by Dean Jackson.

• html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::updateWidget):
Re-acquire the renderer after calling createJavaAppletWidget,
because it can cause reattach, leaving our renderer pointer stale.

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::createJavaAppletWidget):
Null-check renderer, as element->renderEmbeddedObject() can very clearly
return null in some cases.

6:09 PM Changeset in webkit [152753] by Lucas Forschler

• 38 edits
  1 delete in tags/Safari-537.51

Rollout of r152701. <rdar://problem/14209318>

6:07 PM Changeset in webkit [152752] by Lucas Forschler

• 4 edits in tags/Safari-537.51/LayoutTests

Rollout of r152703. <rdar://problem/14209318>

5:50 PM Changeset in webkit [152751] by commit-queue@webkit.org

• 2 edits in trunk/Websites/bugs.webkit.org

AX: Add a 'choose product' link for the new-ax-bug alias.
​https://bugs.webkit.org/show_bug.cgi?id=118697

Patch by James Craig <​james@cookiecrook.com> on 2013-07-16
Reviewed by Chris Fleizach.

• template/en/custom/global/choose-product.html.tmpl: Added new link for accessibility bugs.

5:33 PM Changeset in webkit [152750] by psolanki@apple.com

• 2 edits in trunk/Source/WebCore

Missing break in WebGLRenderingContext::validateCompressedTexFuncData()
​https://bugs.webkit.org/show_bug.cgi?id=118742

Reviewed by Ryosuke Niwa.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

5:32 PM Changeset in webkit [152749] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: InspectorFrontendHost is undefined
​https://bugs.webkit.org/show_bug.cgi?id=118715

Patch by Seokju Kwon <Seokju Kwon> on 2013-07-16
Reviewed by Timothy Hatcher.

Add InspectorFrontendHostStub.js to New Inspector because of the InspectorFrontendHost initialization.

• UserInterface/InspectorFrontendHostStub.js: Added.

(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.platform):
(.WebInspector.InspectorFrontendHostStub.prototype.port):
(.WebInspector.InspectorFrontendHostStub.prototype.bringToFront):
(.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
(.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):
(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowWidth):
(.WebInspector.InspectorFrontendHostStub.prototype.setToolbarHeight):
(.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
(.WebInspector.InspectorFrontendHostStub.prototype.loaded):
(.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
(.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.InspectorFrontendHostStub.prototype.openInNewTab):
(.WebInspector.InspectorFrontendHostStub.prototype.canSave):
(.WebInspector.InspectorFrontendHostStub.prototype.save):
(.WebInspector.InspectorFrontendHostStub.prototype.append):
(.WebInspector.InspectorFrontendHostStub.prototype.close.cleanup):
(.WebInspector.InspectorFrontendHostStub.prototype.close):
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):

• UserInterface/Main.html:

5:12 PM Changeset in webkit [152748] by kseo@webkit.org

• 3 edits in trunk/Tools

check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
​https://bugs.webkit.org/show_bug.cgi?id=118755

Reviewed by Ryosuke Niwa.

Fix r152719 to check "using namespace foo;" only in headers.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_using_namespace):
(check_style):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_using_namespace):

4:24 PM Changeset in webkit [152747] by dfarler@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Typo in DFGInsertionSet.h header guard: "DFGInsectionSet_h" -> "DFGInsertionSet_h"
​https://bugs.webkit.org/show_bug.cgi?id=118753

Reviewed by Geoffrey Garen.

• dfg/DFGInsertionSet.h:

"DFGInsectionSet_h" -> "DFGInsertionSet_h"

3:57 PM Changeset in webkit [152746] by achristensen@apple.com

• 2 edits in trunk/LayoutTests

Added passing WebGL tests.
​https://bugs.webkit.org/show_bug.cgi?id=118696

Reviewed by Dean Jackson.

• platform/mac/TestExpectations: Replaced webgl directory with list of failing webgl tests.

3:50 PM Changeset in webkit [152745] by fpizlo@apple.com

• 7 edits in branches/dfgFourthTier/Source

fourthTier: NaturalLoops should be able to quickly answer questions like "what loops own this basic block"
​https://bugs.webkit.org/show_bug.cgi?id=118750

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

• dfg/DFGBasicBlock.h:

(BasicBlock):

• dfg/DFGNaturalLoops.cpp:

(JSC::DFG::NaturalLoops::compute):
(JSC::DFG::NaturalLoops::loopsOf):

• dfg/DFGNaturalLoops.h:

(DFG):
(JSC::DFG::NaturalLoop::NaturalLoop):
(NaturalLoop):
(JSC::DFG::NaturalLoop::index):
(JSC::DFG::NaturalLoop::isOuterMostLoop):
(JSC::DFG::NaturalLoop::addBlock):
(JSC::DFG::NaturalLoops::headerOf):
(JSC::DFG::NaturalLoops::innerMostLoopOf):
(NaturalLoops):
(JSC::DFG::NaturalLoops::innerMostOuterLoop):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

Source/WTF:

Reviewed by Mark Hahnenberg.

Add a utility function for inserting an element into a vector that has bounded size,
and where the insertion causes things to drop off the end.

• wtf/StdLibExtras.h:

(WTF):
(WTF::insertIntoBoundedVector):

3:08 PM Changeset in webkit [152744] by fpizlo@apple.com

• 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: don't GC when shutting down the VM
​https://bugs.webkit.org/show_bug.cgi?id=118751

Reviewed by Mark Hahnenberg.

• heap/Heap.h:

(Heap):

• runtime/VM.cpp:

(JSC::VM::~VM):

3:03 PM Changeset in webkit [152743] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Atomicize HTMLAnchorElement.hash before passing it to JS.
<​http://webkit.org/b/118748>
<rdar://problem/14459780>

Reviewed by Sam Weinig.

Instead of generating a unique string from '#' + the URL hash every time HTMLAnchorElement.hash
is queried, turn it into an AtomicString. This prevents massive memory usage in scripts that
fetch .hash a lot.

Reduces memory consumption by 4.65 MB when viewing the full HTML5 spec at <​http://whatwg.org/c>

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::hash):

2:41 PM Changeset in webkit [152742] by fpizlo@apple.com

• 5 edits
  3 adds in trunk

MakeRope fixup shouldn't lead to an Identity without kids
​https://bugs.webkit.org/show_bug.cgi?id=118745

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Make the empty string pruning part of fixupMakeRope() stop if it's on the last child.

Make Node::convertToIdentity release-assert that it has exactly one kid.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupMakeRope):

• dfg/DFGNode.h:

(JSC::DFG::Node::convertToIdentity):

LayoutTests:

Reviewed by Mark Hahnenberg.

• fast/js/dfg-make-rope-all-empty-strings.html: Added.
• fast/js/dfg-make-rope-all-empty-strings-expected.txt: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-make-rope-all-empty-strings.js: Added.

(foo):
(bar):

2:34 PM Changeset in webkit [152741] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

Make WebVTTParser return cue data instead of cue DOM objects
​https://bugs.webkit.org/show_bug.cgi?id=118687

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-07-16
Reviewed by Eric Carlson.

No new tests because this doesn't change functionality.

• html/track/InbandTextTrack.cpp:

Make TextTrackCueMap handle WebVTTCues instead of just generic cues.
m_dataToCueMap and m_cueToDataMap were renamed m_genericDataToCueMap
and m_genericCueToDataMap. The cue maps were turned into pointers so we
only allocate the ones we need.
(WebCore::TextTrackCueMap::TextTrackCueMap): Initialize maps to 0.
(WebCore::TextTrackCueMap::~TextTrackCueMap): Delete allocated maps.
(WebCore::TextTrackCueMap::add): Changed to allocate cue maps as needed, and added WebVTT version.
(WebCore::TextTrackCueMap::find): Checked to check if cue maps are allocated, and added WebVTT version.
(WebCore::TextTrackCueMap::findGenericData): Changed to accept TextTrackCue instead of TextTrackCueGeneric.
(WebCore::TextTrackCueMap::findWebVTTData): Same as findGenericData, except for WebVTTCueData.
(WebCore::TextTrackCueMap::remove): Accept TextTrackCue instead of TextTrackCueGeneric, and look in both maps.
(WebCore::InbandTextTrack::addWebVTTCue): Added, based on addGenericCue.
(WebCore::InbandTextTrack::removeWebVTTCue): Added, almost identical to removeGenericCue.
(WebCore::InbandTextTrack::removeCue): m_cueMap.remove() takes a TextTrackCue now so it can remove both types of cue.
(WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Use ASSERT_UNUSED instead of UNUSED_PARAM + ASSERT.

• html/track/InbandTextTrack.h: Add new functions above, change maps to pointers and add maps for holding WebVTT cues.
• html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::getNewCues): Return WebVTTCueData instead of TextTrackCue.
(WebCore::WebVTTParser::createNewCue): Create WebVTTCueData instead of TextTrackCue.

• html/track/WebVTTParser.h: Add WebVTTCueData class, based on GenericCueData.

The following functions are just constructors, destructors, getters, or setters.
(WebCore::WebVTTCueData::create):
(WebCore::WebVTTCueData::~WebVTTCueData):
(WebCore::WebVTTCueData::startTime):
(WebCore::WebVTTCueData::setStartTime):
(WebCore::WebVTTCueData::endTime):
(WebCore::WebVTTCueData::setEndTime):
(WebCore::WebVTTCueData::id):
(WebCore::WebVTTCueData::setId):
(WebCore::WebVTTCueData::content):
(WebCore::WebVTTCueData::setContent):
(WebCore::WebVTTCueData::settings):
(WebCore::WebVTTCueData::setSettings):
(WebCore::WebVTTCueData::WebVTTCueData):

• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::getNewCues): Convert WebVTTCueData to TextTrackCue when we get them.

• platform/graphics/InbandTextTrackPrivateClient.h: Add addWebVTTCue and removeWebVTTCue functions to the interface.

2:14 PM Changeset in webkit [152740] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION (r150291): Chinese predictive input pop-up disappears on twitter.com
​https://bugs.webkit.org/show_bug.cgi?id=118739
<rdar://problem/14300350>

Reviewed by Daniel Bates.

EditorState tracking on UI side is very fragile. This is a targeted fix just for
this specific scenario.

The issue was that we had a stale m_temporarilyClosedComposition flag, which was
making UI process believe that a composition was closed from WebProcess side,
and notify input method about that. It shouldn't have been a problem, because there
is no composition at this point indeed, but this extra call is a problem for
predictive input, which works in a somewhat unconventional way (<rdar://problem/14458297>).

• UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::insertText): Reset m_temporarilyClosedComposition flag when getting new EditorState in response to performing this action. There is certainly no composition after insertText, and all interested parties are on the same page already.

2:02 PM Changeset in webkit [152739] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Use the correct cursor value for the unavailable plugin indicator
​https://bugs.webkit.org/show_bug.cgi?id=118747
<rdar://problem/14456498>

Reviewed by Dean Jackson.

CSS says "pointer" is the hand cursor, not "hand".

• css/unavailablePlugIns.css:

(object::-webkit-unavailable-plugin-content > div):
(object::-webkit-unavailable-plugin-content > div > span):

1:37 PM Changeset in webkit [152738] by fpizlo@apple.com

• 1 edit
  4 adds in branches/dfgFourthTier/Tools

fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
​https://bugs.webkit.org/show_bug.cgi?id=118647

Rubber stamped by Geoffrey Garen and Mark Hahnenberg.

Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
way that the FTL would.

Also add a tool that combines multiple LLVM modules generated by FTL into a
single module.

• ReducedFTL: Added.
• ReducedFTL/ReducedFTL.c: Added.

(usage):
(currentTime):
(MemorySection):
(mmAllocateCodeSection):
(mmAllocateDataSection):
(mmApplyPermissions):
(mmDestroy):
(symbolLookupCallback):
(main):

• ReducedFTL/build.sh: Added.
• ReducedFTL/combineModules.rb: Added.

1:35 PM Changeset in webkit [152737] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Remove reference to JSValueStructSupport.h from JSExport.h
​https://bugs.webkit.org/show_bug.cgi?id=118746

Reviewed by Filip Pizlo.

• API/JSExport.h: No such header exists, so it doesn't make sense to reference it.

1:32 PM Changeset in webkit [152736] by roger_fong@apple.com

• 1 edit
  2 adds in trunk/LayoutTests

Unreviewed rebaseline test added in r152612 for Apple Windows port.

• platform/win/editing/caret: Added.
• platform/win/editing/caret/caret-color-expected.txt: Added.

12:38 PM Changeset in webkit [152735] by roger_fong@apple.com

• 3 edits in trunk/LayoutTests

Unreviewed rebaselines, AppleWin port.

• platform/win/fast/js/global-constructors-attributes-dedicated-worker-expected.txt:
• platform/win/fast/js/global-constructors-attributes-shared-worker-expected.txt:

11:51 AM Changeset in webkit [152734] by roger_fong@apple.com

• 3 edits in trunk/LayoutTests

Unreviewed. Adjust test and update results for AppleWin port after r151868.

• platform/win/accessibility/multiple-select-element-role-expected.txt:
• platform/win/accessibility/multiple-select-element-role.html:

11:44 AM Changeset in webkit [152733] by Simon Fraser

• 7 edits in trunk/Source

Source/WebCore: Protect against the LayerFlushController being deleted inside its flushLayers() callback
​https://bugs.webkit.org/show_bug.cgi?id=118741

Reviewed by Tim Horton.

It's possible (especially on iOS) for the LayerFlushController to be destroyed
inside its callback, via -[WebView _close]. Protect against this by making
it refcounted, and holding a ref across the callback.

Due to the odd relationship in which LayerFlushController owns its LayerFlushScheduler
by value, we achieve this by allowing subclasses of LayerFlushScheduler
to override runLoopObserverCallback(). WebViewLayerFlushScheduler uses the
override to protect the owner of the LayerFlushScheduler, which is the
LayerFlushController, when the callback is firing.

• WebCore.exp.in:
• platform/graphics/ca/LayerFlushScheduler.h: Make runLoopObserverCallback() and the dtor virtual.

Source/WebKit/mac: Protect against the LayerFlushController being deleted inside its flushLayers() callback
​https://bugs.webkit.org/show_bug.cgi?id=118741
<rdar://problem/14402651>

Reviewed by Tim Horton.

It's possible (especially on iOS) for the LayerFlushController to be destroyed
inside its callback, via -[WebView _close]. Protect against this by making
it refcounted, and holding a ref across the callback.

Due to the odd relationship in which LayerFlushController owns its LayerFlushScheduler
by value, we achieve this by allowing subclasses of LayerFlushScheduler
to override runLoopObserverCallback(). WebViewLayerFlushScheduler uses the
override to protect the owner of the LayerFlushScheduler, which is the
LayerFlushController, when the callback is firing.

• WebView/WebView.mm:

(-[WebView _close]):

• WebView/WebViewData.h:

(WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
(LayerFlushController::create):

• WebView/WebViewData.mm:

(LayerFlushController::invalidate):
(WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):

11:38 AM Changeset in webkit [152732] by roger_fong@apple.com

• 1 edit
  2 adds in trunk/LayoutTests

Unreviewed rebaselines, AppleWin port.

• platform/win/fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Added.
• platform/win/fast/js/global-constructors-attributes-shared-worker-expected.txt: Added.

11:16 AM Changeset in webkit [152731] by roger_fong@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed gardening. -webkit-user-select: all not supported on AppleWin port.
​https://bugs.webkit.org/show_bug.cgi?id=118740

• platform/win/TestExpectations:

11:04 AM Changeset in webkit [152730] by jberlin@webkit.org

• 5 edits in trunk/Source

Fix some NSDictionary misuse pointed out by the clang static analyzer
​https://bugs.webkit.org/show_bug.cgi?id=118736

Reviewed by Anders Carlsson.

Source/WebKit/mac:

• Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):
Explicitly cast the CFStringRef to an NSString *.

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::documentFragmentFromAttributedString):
Do not put a key with a nil value pair into the NSDictionary.

Source/WebKit2:

• WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::documentFragmentFromAttributedString):
Do not put a key with a nil value pair into the NSDictionary.

9:57 AM WebKitGTK/2.0.x edited by calvaris@igalia.com

(diff)

9:54 AM WebKitGTK/2.0.x edited by calvaris@igalia.com

(diff)

9:51 AM Changeset in webkit [152729] by Lucas Forschler

• 4 edits in tags/Safari-537.51/LayoutTests

Merged r152703. <rdar://problem/14209318>

9:51 AM Changeset in webkit [152728] by Lucas Forschler

• 38 edits
  1 copy in tags/Safari-537.51

Merged r152701. <rdar://problem/14209318>

9:48 AM Changeset in webkit [152727] by Lucas Forschler

• 4 edits in branches/safari-537-branch/LayoutTests

Merged r152703. <rdar://problem/14209318>

9:47 AM Changeset in webkit [152726] by Lucas Forschler

• 38 edits
  1 copy in branches/safari-537-branch

Merged r152701. <rdar://problem/14209318>

9:24 AM Changeset in webkit [152725] by Christophe Dumez

• 9 edits in trunk

Get rid of multiple inheritance support from the bindings generators
​https://bugs.webkit.org/show_bug.cgi?id=118353

Reviewed by Kentaro Hara.

Source/WebCore:

Remove multiple inheritance support from the bindings generators (except
the ObjC one which still needs it for now). Multiple inheritance is no
longer supported in Web IDL and it makes the scripts more complex than
they needs to be.

Multiple inheritance support is no longer needed now that our SVG
interfaces have been updated to use the simpler SVG2 inheritance model
and use Web IDL 'implements' statements.

Note that the IDL parser still support multiple inheritance for now in
order not to break the ObjC bindings generator.

No new tests, no behavior change.

• bindings/scripts/CodeGenerator.pm:
• bindings/scripts/CodeGeneratorCPP.pm:

(GetParentImplClassName):
(GetParent):
(GenerateImplementation):

• bindings/scripts/CodeGeneratorGObject.pm:

(GetParentClassName):
(GetParentImplClassName):
(GetParentGObjType):

• bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDefinition):

• bindings/scripts/CodeGeneratorObjC.pm:

(AddMethodsConstantsAndAttributesFromParentInterfaces):
(GenerateImplementation):

• bindings/scripts/IDLParser.pm:

(parseInterface):
(parseException):
(parseInheritance):

Tools:

Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
deprecated domInterface->parents.

• WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(_parentInterface):

9:24 AM Changeset in webkit [152724] by Lucas Forschler

• 2 edits in tags/Safari-537.51/Source/WebKit2

Merged r152698. <rdar://problem/14255963>

9:22 AM Changeset in webkit [152723] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152698. <rdar://problem/14255963>

9:08 AM Changeset in webkit [152722] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening. Update test expectations after r152701
​https://bugs.webkit.org/show_bug.cgi?id=118731

Unreviewed GTK gardening.

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-07-16

• platform/gtk/TestExpectations: Skip failing tests after r152701.

8:12 AM Changeset in webkit [152721] by eric.carlson@apple.com

• 3 edits
  4 adds in trunk

HTMLMediaElement should not add cues for disabled text tracks
​https://bugs.webkit.org/show_bug.cgi?id=118682

Source/WebCore:

Reviewed by Ryosuke Niwa.

Merge ​https://src.chromium.org/viewvc/blink?view=rev&revision=153810

Tests: media/track/track-disabled-addcue.html

media/track/track-disabled.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackAddCues): Do nothing if the track is disabled.
(WebCore::HTMLMediaElement::textTrackAddCue): Ditto.

LayoutTests:

Merge ​https://src.chromium.org/viewvc/blink?view=rev&revision=153810

Reviewed by Ryosuke Niwa.

• media/track/track-disabled-addcue-expected.txt: Added.
• media/track/track-disabled-addcue.html: Added.
• media/track/track-disabled-expected.txt: Added.
• media/track/track-disabled.html: Added.

6:51 AM Changeset in webkit [152720] by michael.bruning@digia.com

• 2 edits in trunk/Source/WebKit2

[Qt] Replace Nokia with Qt Project in service name.
​https://bugs.webkit.org/show_bug.cgi?id=118729

Reviewed by Simon Hausmann.

• UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

6:05 AM Changeset in webkit [152719] by commit-queue@webkit.org

• 3 edits in trunk/Tools

check-webkit-style: "using namespace foo;" should be flagged as an error in headers
​https://bugs.webkit.org/show_bug.cgi?id=57241

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-16
Reviewed by Ryosuke Niwa.

Added check for "using namespace foo" and unit test.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_using_namespace):
(check_style):
(CppChecker):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_using_namespace):

6:03 AM Changeset in webkit [152718] by commit-queue@webkit.org

• 4 edits in trunk

[GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=110222

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-07-16
Reviewed by Gustavo Noronha Silva.

Tools:

Added handling of zero mouse scroll deltas in EventSender.

• DumpRenderTree/gtk/EventSender.cpp:

(mouseScrollByCallback):

LayoutTests:

• platform/gtk/TestExpectations:

5:58 AM Changeset in webkit [152717] by commit-queue@webkit.org

• 2 edits in trunk/Tools

webkitpy: replace urllib with urllib2 for downloading additional modules
​https://bugs.webkit.org/show_bug.cgi?id=118671

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-16
Reviewed by Ryosuke Niwa.

Urllib2 is available whereever urllib is, but has better proxy support.

• Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._download_to_stream):

5:55 AM Changeset in webkit [152716] by commit-queue@webkit.org

• 6 edits
  4 moves in trunk

[ATK] Adds support for aria-haspopup property.
​https://bugs.webkit.org/show_bug.cgi?id=117834

Source/WebCore:

Patch by Krzysztof Czech <​k.czech@ymail.com> on 2013-07-16
Reviewed by Christophe Dumez.

Adds support for aria-haspopup property.

Tests: accessibility/element-haspopup.html

accessibility/popup-button-title.html

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

Tools:

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-07-16
Reviewed by Christophe Dumez.

Adds implementation for testing aria-haspopup property.

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(getAttributeSetValueForId):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::hasPopup):

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::getAttributeSetValueForId):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::hasPopup):

LayoutTests:

Patch by Krzysztof Czech <​k.czech@ymail.com> on 2013-07-16
Reviewed by Christophe Dumez.

Moving accessibility tests related to aria-haspopup property.

• accessibility/element-haspopup-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-haspopup-expected.txt.
• accessibility/element-haspopup.html: Renamed from LayoutTests/platform/mac/accessibility/element-haspopup.html.
• accessibility/popup-button-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/popup-button-title-expected.txt.
• accessibility/popup-button-title.html: Renamed from LayoutTests/platform/mac/accessibility/popup-button-title.html.

5:22 AM Changeset in webkit [152715] by michael.bruning@digia.com

• 6 edits in trunk

[Qt] Replace Nokia references.
​https://bugs.webkit.org/show_bug.cgi?id=118728

Reviewed by Simon Hausmann.

Source/WebKit/qt:

• Api/qwebkitplatformplugin.h:
• examples/platformplugin/qwebkitplatformplugin.h:

Tools:

• MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::MiniBrowserApplication):

• QtTestBrowser/qttestbrowser.cpp:

(LauncherApplication::LauncherApplication):

4:57 AM Changeset in webkit [152714] by zarvai@inf.u-szeged.hu

• 3 edits
  7 adds in trunk/LayoutTests

[Qt]Unreviewed gardening. New baseline and skip failing tests.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-07-16

• platform/qt-5.0-wk1/TestExpectations:
• platform/qt-5.0-wk1/http/tests/security/contentSecurityPolicy/object-src-none-allowed-expected.txt: Added.
• platform/qt/TestExpectations:
• platform/qt/editing/caret/caret-color-expected.png: Added.
• platform/qt/editing/caret/caret-color-expected.txt: Added.
• platform/qt/http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt: Added.

4:10 AM Changeset in webkit [152713] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

EWK2BackForwardListTest should be defined by inheriting from EWK2UnitTestBase.
​https://bugs.webkit.org/show_bug.cgi?id=118717

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-16
Reviewed by Christophe Dumez.

• UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:

(EWK2BackForwardListTest::checkItem):
(EWK2BackForwardListTest::urlFromTitle):
(EWK2BackForwardListTest::freeEinaList):
(TEST_F):

3:47 AM Changeset in webkit [152712] by Carlos Garcia Campos

• 2 edits in trunk

[GTK] Remove compile warnings about GTK+ API deprecated after 3.6
​https://bugs.webkit.org/show_bug.cgi?id=118237

Reviewed by Philippe Normand.

We depend on GTK+3.6 so we are not interested in compile warnings
about deprecated API after 3.6

• Source/autotools/SetupAutoconfHeader.m4: Define

GDK_VERSION_MIN_REQUIRED in config.h.

3:16 AM Changeset in webkit [152711] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

[texmap][GStreamer] upload onto the texture only the buffer to be painted
​https://bugs.webkit.org/show_bug.cgi?id=118471

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-07-16
Reviewed by Philippe Normand.

Right now all the buffers are uploaded onto the texture. With this
logic pose situations where buffers that will not be painted are
uploaded.

This patch uploads only the buffers that are going to be shown.

With this approach, the buffers may arrive before a GraphicsLayer is
set, so we should be more cautious with GraphicsLayerTextureMapper's
client.

No new tests, covered by existing tests.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::~GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):

2:50 AM Changeset in webkit [152710] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] verify and log the received caps in the video sink
​https://bugs.webkit.org/show_bug.cgi?id=118559

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-07-16
Reviewed by Philippe Normand.

Verify the correctness of the received caps in the video sink, and
also log them for debugging purposes.

No new tests, no behavior change.

• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkSetCaps):

2:20 AM Changeset in webkit [152709] by kangil.han@samsung.com

• 9 edits in trunk/Source

Use toHTMLSelectElement and dismiss isHTMLSelectElement
​https://bugs.webkit.org/show_bug.cgi?id=118714

Reviewed by Ryosuke Niwa.

To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
Additionally, this patch removes isHTMLSelectElement because not all element subclasses can be checked by a combination of tag names.

Source/WebCore:

• html/HTMLSelectElement.h:

(WebCore::toHTMLSelectElement):

• testing/Internals.cpp:

(WebCore::Internals::isSelectPopupVisible):

Source/WebKit/blackberry:

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndex):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):

Source/WebKit/win:

• DOMHTMLClasses.cpp:

(DOMHTMLSelectElement::options):
(DOMHTMLSelectElement::activateItemAtIndex):

Source/WebKit2:

• WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::commit):

12:35 AM Changeset in webkit [152708] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Replace mouseClick with more meaningful method in test_ewk2_text_checker.cpp
​https://bugs.webkit.org/show_bug.cgi?id=118699

Patch by Dong-Gwan Kim <​donggwan.kim@samsung.com> on 2013-07-16
Reviewed by Christophe Dumez.

Many mouseClick methods are used in test_ewk2_text_checker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.

• UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(EWK2TextCheckerTest::clickSelectAllWordsWithSpellcheckButton):
(EWK2TextCheckerTest::clickSelectAllWordsWithoutSpellcheckButton):
(EWK2TextCheckerTest::clickSelectSubWordWithSpellcheckButton):
(EWK2TextCheckerTest::showContextMenuWithFirstLineText):
(EWK2TextCheckerTest::showContextMenuWithSecondLineText):
(EWK2TextCheckerTest::selectFirstWordInFirstLineText):
(EWK2TextCheckerTest::selectFirstWordInSecondLineText):
(TEST_F):