⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 31, 2013:

11:44 PM Changeset in webkit [153573] by bshafiei@apple.com
  • 1 copy in tags/Safari-537.54

New tag.

10:55 PM Changeset in webkit [153572] by berto@igalia.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
10:23 PM Changeset in webkit [153571] by Seokju Kwon
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening
​https://bugs.webkit.org/show_bug.cgi?id=119283

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Remove duplicated entry.
9:41 PM Changeset in webkit [153570] by Seokju Kwon
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
9:25 PM Changeset in webkit [153569] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Skip media/track/track-language-preference.html and media/track/track-prefer-captions.html
rather than just marking them as [ Pass Fail ] since they timeout so often and slow
everything down.

  • platform/mac/TestExpectations:
9:06 PM Changeset in webkit [153568] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Clobbering window.console is not cool because it makes debugging tests
harder.

  • media/video-test.js:

(logConsole):

8:43 PM Changeset in webkit [153567] by Simon Fraser
  • 2 edits in trunk/LayoutTests

r153462 erroneously unskipped http/tests/multipart/invalid-image-data-standalone.html
so put it back.

  • platform/mac/TestExpectations:
8:42 PM Changeset in webkit [153566] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

FINALize StyleSheet subclasses.
<​http://webkit.org/b/119370>

Reviewed by Anders Carlsson.

CSSStyleSheet and XSLStyleSheet have no further subclasses so make them final.

  • css/CSSStyleSheet.h:
  • xml/XSLStyleSheet.h:
8:34 PM Changeset in webkit [153565] by Simon Fraser
  • 2 edits in trunk/LayoutTests

compositing/patterns/direct-pattern-compositing tests suffer
from colorspace issues that cause image failures on some machines.

  • platform/mac/TestExpectations:
8:30 PM Changeset in webkit [153564] by Simon Fraser
  • 2 edits in trunk/LayoutTests

media/video-controls-captions-trackmenu.html either crashes,
fails or passes.

  • platform/mac/TestExpectations:
8:17 PM Changeset in webkit [153563] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Gardening:

webkit.org/b/119374 fast/workers/termination-early.html [ Pass Crash ]
webkit.org/b/119375 fast/workers/worker-call.html [ Failure ]

  • platform/mac/TestExpectations:
7:20 PM Changeset in webkit [153562] by zhajiang@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page scrolls when width equals device width and initial scale is greater than 0.92
​https://bugs.webkit.org/show_bug.cgi?id=119365

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-07-31
Reviewed by Rob Buis.
Internally reviewed by Gen Mak and Konrad Piascik.

JIRA 445423
layoutSize (deviceScreenSize/devicePixelRatio) is FloatSize as devicePixelRatio
is float. We have to round that to IntSize as ScrollView needs IntSize
fixedLayoutSize. Based on conversion result, zoomToFitWidthScale will
hardly equal to zoomToFitHeightScale in this case. And unfortunately
zoomToFitHeightScale is a little bit greater than zoomToFitWidthScale
in this case so that we have to pick up zoomToFitHeightScale which makes
the page scollable horizontally.
The way to fix that is to define an accurate contentsSize area which
potentially has float layoutSize rounding error and can cause upexpected
scroll based on the ideal contentsSize area first, and then don't scroll
only if the scale is zoomToFitScale as "contentsSize > visibleViewportSize"
still works well if the scale is larger than zoomToFitScale.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::hasFloatLayoutSizeRoundingError):

  • Api/WebPage_p.h:
  • WebKitSupport/WebKitThreadViewportAccessor.cpp:

(BlackBerry::WebKit::WebKitThreadViewportAccessor::cannotScrollIfHasFloatLayoutSizeRoundingError):

  • WebKitSupport/WebKitThreadViewportAccessor.h:
7:17 PM Changeset in webkit [153561] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

Introduce toSVGFontFaceElement, and use it
​https://bugs.webkit.org/show_bug.cgi?id=119330

Reviewed by Andreas Kling.

As a step to change static_cast with toSVGXXX, static_cast<SVGFontFaceElement*> can
be changed with toSVGFontFaceElement().

Blink merge from ​https://src.chromium.org/viewvc/blink?view=rev&revision=155082

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • svg/SVGFontFaceElement.h:

(WebCore::toSVGFontFaceElement):

  • svg/SVGFontFaceFormatElement.cpp:

(WebCore::SVGFontFaceFormatElement::childrenChanged):

  • svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::childrenChanged):

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::childrenChanged):

6:49 PM Changeset in webkit [153560] by Simon Fraser
  • 2 edits in branches/safari-537-branch/LayoutTests

Merge r153498.

2013-07-30 Alexey Proskuryakov <​ap@apple.com>

REGRESSION(r139282): Fix document leak when selection is created inside the document
​https://bugs.webkit.org/show_bug.cgi?id=119122

OK'd by Ryosuke Niwa.

The added test was very flaky. Trying to make it better with a gc() call at the beginning.

  • editing/selection/leak-document-with-selection-inside.html:
6:34 PM Changeset in webkit [153559] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Introduce toSVGSMILElement, and use it
​https://bugs.webkit.org/show_bug.cgi?id=119260

Reviewed by Darin Adler.

As a step to change static_cast with toSVGXXX, static_cast<SVGSMILElement*> can
be changed with toSVGSMILElement().

Blink merge from ​https://src.chromium.org/viewvc/blink?view=rev&revision=155048

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):

  • svg/animation/SVGSMILElement.h:

(WebCore::toSVGSMILElement):

6:31 PM Changeset in webkit [153558] by Simon Fraser
  • 2 edits in branches/safari-537-branch/LayoutTests

Merge r151893

2013-06-23 Brent Fulgham <​bfulgham@gmail.com>

AX: Rebaseline test after r151868
​https://bugs.webkit.org/show_bug.cgi?id=117892

Rubber stamped by Chris Fleizach.

  • platform/mac/accessibility/lists-expected.txt:
6:25 PM Changeset in webkit [153557] by Simon Fraser
  • 3 edits in branches/safari-537-branch/LayoutTests

Merge r152847

2013-07-18 Zalan Bujtas <Alan Bujtas>

fullscreen/full-screen-iframe-with-max-width-height.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=118820

Reviewed by Andreas Kling.

Don't start the test until after the iframe has finished loading.

  • fullscreen/full-screen-iframe-with-max-width-height-expected.txt:
  • fullscreen/full-screen-iframe-with-max-width-height.html:
  • platform/mac/TestExpectations:
6:09 PM Changeset in webkit [153556] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

More cleanup in PropertySlot
​https://bugs.webkit.org/show_bug.cgi?id=119359

Reviewed by Geoff Garen.

m_slotBase is overloaded to store the (receiver) thisValue and the object that contains the property,
This is confusing, and means that slotBase cannot be typed correctly (can only be a JSObject).

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):

  • No need to ASSERT slotBase is an object.
  • jit/JITStubs.cpp:

(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

  • No need to ASSERT slotBase is an object.
  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::fillGetterPropertySlot):

  • Pass an object through to setGetterSlot.
  • runtime/JSObject.h:

(JSC::PropertySlot::getValue):

  • Moved from PropertySlot (need to know anout JSObject).
  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

  • update per member name changes
  • runtime/PropertySlot.h:

(JSC::PropertySlot::PropertySlot):

  • Argument to constructor set to 'thisValue'.

(JSC::PropertySlot::slotBase):

  • This returns a JSObject*.

(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setCustom):
(JSC::PropertySlot::setCacheableCustom):
(JSC::PropertySlot::setCustomIndex):
(JSC::PropertySlot::setGetterSlot):
(JSC::PropertySlot::setCacheableGetterSlot):

  • slotBase is a JSObject*, make setGetterSlot set slotBase for consistency.
  • runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayEntry::get):

  • Pass an object through to setGetterSlot.
  • runtime/SparseArrayValueMap.h:
    • Pass an object through to setGetterSlot.
6:08 PM Changeset in webkit [153555] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Clobbering window.console is not cool
​https://bugs.webkit.org/show_bug.cgi?id=119364

Reviewed by Tim Horton.

full-screen-test.js overrides window.console, which is hella
confusing if you're trying to use console.log to debug a fullscreen test.

  • fullscreen/full-screen-test.js:

(logConsole):

  • fullscreen/resources/not-allowed.html:
5:57 PM Changeset in webkit [153554] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Gardening: changing expectation for fast/forms/color/input-color-onchange-event.html
to "Crash Pass" instead of "Skip".

Not reviewed.

5:51 PM Changeset in webkit [153553] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Reuse of XMLHttpRequests causes character corruption in response text
​https://bugs.webkit.org/show_bug.cgi?id=119358

Reviewed by Anders Carlsson.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/6496e7bb9a0b46bc79032b86d5993b25f127a4cb

Test: http/tests/xmlhttprequest/reopen-encoding.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::didFinishLoading):

LayoutTests:

  • http/tests/xmlhttprequest/reopen-encoding-expected.txt: Added.
  • http/tests/xmlhttprequest/reopen-encoding.html: Added.
  • http/tests/xmlhttprequest/resources/get-utf-8.cgi: Added.
  • http/tests/xmlhttprequest/resources/get-windows-1251.cgi: Added.
5:28 PM Changeset in webkit [153552] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Bot greening.

Not reviewed.

5:21 PM Changeset in webkit [153551] by ap@apple.com
  • 19 edits in trunk/Source/WebCore

Make ActiveDOMObject overrides private
​https://bugs.webkit.org/show_bug.cgi?id=119352

Reviewed by Sam Weinig.

There is no need to call these through derived classes. And it's quite harmful for
anyone except for ScriptExecutionContext to call suspend/resume in particular -
ScriptExecutionContext won't know, and it will try to manage the state on its own.

  • Modules/filesystem/DOMFileSystem.h:
  • Modules/filesystem/FileWriter.h:
  • Modules/geolocation/Geolocation.h:
  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.h:
  • Modules/mediasource/MediaSource.h:
  • Modules/notifications/Notification.h:
  • Modules/notifications/NotificationCenter.h:
  • Modules/websockets/WebSocket.h:
  • fileapi/FileReader.h:
  • html/HTMLMediaElement.h:
  • html/canvas/WebGLRenderingContext.h:
  • page/DOMTimer.h:
  • page/EventSource.h:
  • page/SuspendableTimer.h:
  • workers/AbstractWorker.h:
  • xml/XMLHttpRequest.h:
5:10 PM Changeset in webkit [153550] by Bem Jones-Bey
  • 3 edits in trunk/Tools

W3C test import script prefixes some properties that it shouldn't
​https://bugs.webkit.org/show_bug.cgi?id=119357

Reviewed by Dirk Pranke.

Some prefixed properties also have unprefixed implemetations, but when
the implementations aren't identical, they aren't declared in
CSSPropertyNames.in on the same line. This fixes the import script so
that it catches all instances of prefixed properties that have an
unprefixed variant, and does not add the prefix in those cases.

  • Scripts/webkitpy/w3c/test_converter.py:

(W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
the properties on every line and record if they are prefixed or not.
Use this information to only return prefixed properties that do not
have any unprefixed variant. The prefixed property list has also
changed to not include the '-webkit-' prefix, making it much easier to
do the comparison, and removing the need to remove the prefix later.
(W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
longer needs to remove the '-webkit-' prefix, but needs to add it in
the case where a property that needs a prefix is found.

  • Scripts/webkitpy/w3c/test_converter_unittest.py:

(W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
for '-webkit-' prefix, as it is no longer included in the properties
in the prefixed property list.

5:06 PM Changeset in webkit [153549] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Remove didFinishLoad order quirk
​https://bugs.webkit.org/show_bug.cgi?id=119354
<rdar://problem/11510686>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Remove the quirk.

  • page/Settings.in:

Remove the setting controlling the quirk.

Source/WebKit/mac:

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Don't set the now-removed preference.

5:03 PM Changeset in webkit [153548] by kseo@webkit.org
  • 3 edits in trunk/Source/WebCore

Replace CRASH() on overflow with Checked<>
​https://bugs.webkit.org/show_bug.cgi?id=119327

Reviewed by Oliver Hunt.

Use a checked type that allows us to automate bound checks. We use a
non-recording Checked<> to keep the behavior.

No behavior change, no new tests needed.

  • dom/Text.cpp:

(WebCore::Text::wholeText):

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::allocate):

4:57 PM Changeset in webkit [153547] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Reduce JSC API static value setter/getter overhead.
​https://bugs.webkit.org/show_bug.cgi?id=119277

Patch by Yi Shen <​max.hong.shen@gmail.com> on 2013-07-31
Reviewed by Geoffrey Garen.

Add property name to the static value entry, so that OpaqueJSString::create() doesn't
need to get called every time when set or get the static value.

  • API/JSCallbackObjectFunctions.h:

(JSC::::put):
(JSC::::putByIndex):
(JSC::::getStaticValue):

  • API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • API/JSClassRef.h:

(StaticValueEntry::StaticValueEntry):

4:54 PM Changeset in webkit [153546] by kseo@webkit.org
  • 13 edits in trunk/Source

Use emptyString instead of String("")
​https://bugs.webkit.org/show_bug.cgi?id=119335

Reviewed by Darin Adler.

Use emptyString() instead of String("") because it is better style and
faster. This is a followup to r116908, removing all occurrences of
String("") from WebKit.

Source/JavaScriptCore:

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

Source/WebCore:

No behavior change, no new tests needed.

  • platform/graphics/blackberry/LayerAnimation.h:

(WebCore::LayerAnimation::name):

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::textFromEvent):
(WebCore::unmodifiedTextFromEvent):
(WebCore::keyIdentifierForKeyEvent):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::userAgent):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::runJavaScriptPrompt):

Source/WebKit2:

  • Shared/mac/WebEventFactory.mm:

(WebKit::textFromEvent):
(WebKit::unmodifiedTextFromEvent):

4:21 PM Changeset in webkit [153545] by Bem Jones-Bey
  • 3 edits in trunk/Tools

Update location of w3c shapes tests to reflect new import location
​https://bugs.webkit.org/show_bug.cgi?id=118156

Reviewed by Dirk Pranke.

Partial imports should not be imported to the same place as the full
import, so this adds an option to allow importing to a different
location than the default. In doing that, I found that imports from
contributor directories didn't seem to be working correctly, so I
updated the import to be smarter about both contributor directories
and the test status directories. It should now be more likely that the
script guesses the root directory properly.

  • Scripts/webkitpy/w3c/test_importer.py: Remove comment about the

script not working with the full set of contributors, as that is
no longer true, and I didn't see a good way to keep that behavior.
Also update documentation to properly explain what happens when a
contributor dir is imported.

(main): Attempt to find the proper repo dir by looking at the

directory above the "test status" in the given path, this is still
not exactly right, but is less error prone than just trimming.

(parse_args): Add -d option to set the import directory.
(TestImporter.init): Stop appending the subdirs to the

destination_directory because it was making things more complex
and isn't really needed.

(TestImporter.update_test_status): Remove hardcoded strings and use

the TEST_STATUS constants instead.

  • Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add

support for new option.

(TestImporterTest.test_import_dir_with_no_tests): Ditto.

4:08 PM Changeset in webkit [153544] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Winlauncher shouldn't look for Safari Install Directory
​https://bugs.webkit.org/show_bug.cgi?id=119351

Reviewed by Darin Adler.

  • win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for

the Safari install location. Instead, use the proper support
library path for the build architecture.

2:09 PM Changeset in webkit [153543] by rwlbuis@webkit.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Convert SVG test from r153433 to a reftest
​https://bugs.webkit.org/show_bug.cgi?id=119346

Reviewed by Philip Rogers.

Reftest taken from ​https://chromium.googlesource.com/chromium/blink/+/ac10e305a870c8fd500b42e90075aee3aa48da8d.

  • platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt: Removed.
  • svg/animations/attributeNameAndAttributeTypeMismatch-expected.html: Added.
  • svg/animations/attributeNameAndAttributeTypeMismatch.html: Added.
  • svg/animations/attributeNameAndAttributeTypeMissmatch.svg: Removed.
2:04 PM Changeset in webkit [153542] by benjamin@webkit.org
  • 1 edit
    5 adds in trunk/Websites/webkit.org

Upload images for a potential blog post

  • blog-files/size-matters: Added.
  • blog-files/size-matters/JavaScript-growth.png: Added.
  • blog-files/size-matters/WebCore-growth-baseline.png: Added.
  • blog-files/size-matters/WebCore-growth.png: Added.
  • blog-files/size-matters/WebKit-growth.png: Added.
1:47 PM Changeset in webkit [153541] by commit-queue@webkit.org
  • 34 edits
    2 adds in trunk

<input type=color> Mac UI behaviour
<rdar://problem/10269922> and ​https://bugs.webkit.org/show_bug.cgi?id=61276

Source/JavaScriptCore:

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

  • Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.

Source/WebCore:

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

This patch turns on INPUT_TYPE_COLOR and implements it using the native
Mac color panel.

No new tests added.

Currently, there are no automated ways to test the types of changes made in this patch. (i.e. checking
which color is being displayed in the color panel, checking which color element is currently
associated to the color panel, checking the state of color elements after directing away and
being directed back to its page, etc.)

  • Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::handleDOMActivateEvent): Reattaches the color picker if

a color picker has already been shown for an element

(WebCore::ColorInputType::shouldResetOnDocumentActivation): Always returns true, needed to

detach the color picker when caching a page.

  • html/ColorInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::documentDidResumeFromPageCache): For <input type='color'>,

don't reset the element.

(WebCore::HTMLInputElement::documentWillSuspendForPageCache): For <input type='color'>, call detach().

  • html/HTMLInputElement.h:
  • platform/ColorChooser.h:

(WebCore::ColorChooser::reattachColorChooser): Added definition.

Source/WebKit/mac:

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

  • Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createColorPicker): Added stub implementation.

Source/WebKit2:

Implemented <input type='color'> on Mac using the native color picker.

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

Code for WebColorPickerMac is derived from Chromium's color_chooser_mac.mm:
​https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/cocoa/color_chooser_mac.mm

  • Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createColorPicker): Replaced stub implementation

and return a WebColorPickerMac object.

  • UIProcess/WebColorPicker.cpp:

(WebKit::WebColorPicker::invalidate): Updated to call endChooser().
(WebKit::WebColorPicker::showColorPicker): Added stub implementation.

  • UIProcess/WebColorPicker.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Removed invalidation of removed color picker objects.
(WebKit::WebPageProxy::showColorPicker): Updated so that it works for

multiple <input type='color'> elements on a page.

(WebKit::WebPageProxy::didEndColorPicker): Removed cleanup of removed color picker objects.
(WebKit::WebPageProxy::resetStateAfterProcessExited): Removed cleanup of removed color picker objects.

  • UIProcess/mac/WebColorPickerMac.h: Added.
  • UIProcess/mac/WebColorPickerMac.mm: Added.

(WebKit::WebColorPickerMac::create):
(WebKit::WebColorPickerMac::~WebColorPickerMac):
(WebKit::WebColorPickerMac::WebColorPickerMac):
(WebKit::WebColorPickerMac::endPicker):
(WebKit::WebColorPickerMac::setSelectedColor):
(WebKit::WebColorPickerMac::didChooseColor):
(WebKit::WebColorPickerMac::showColorPicker):
WebColorPickerMac contains a reference to a WKColorPanelMac object

and is responsible for maintaining the color picker UI.

(-[WKColorPanelMac setAndShowPicker:withColor:]):
(-[WKColorPanelMac invalidate]):
(-[WKColorPanelMac windowWillClose:]):
(-[WKColorPanelMac didChooseColor:]):
(-[WKColorPanelMac setColor:]):
WKColorPanelMac is a wrapper for a NSColorPanel object and

is responsible for the color picker UI.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createColorChooser): Updated to always create a

WebColorChooser object.

  • WebProcess/WebCoreSupport/WebColorChooser.cpp:

(WebKit::WebColorChooser::reattachColorChooser): Sets the page's

active color chooser to the current object and pings the UIProcess
to show the color picker.

(WebKit::WebColorChooser::setSelectedColor): Only sets the color in the

color picker if the WebColorChooser object is the active color element.

  • WebProcess/WebCoreSupport/WebColorChooser.h:

Source/WTF:

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

  • wtf/FeatureDefines.h: Enabled INPUT_TYPE_COLOR on Mac port.

LayoutTests:

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.

Updated tests to reflect <input type='color'> being implemented with a native color picker.

  • fast/forms/color/input-color-onchange-event-expected.txt:
  • platform/mac/TestExpectations: Enabled fast/form/color tests on Mac.
  • platform/mac/accessibility/color-well-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription.html:
  • platform/mac/fast/forms/color/input-appearance-color-expected.txt: Updated test expectations

on Mac to reflect the fact that the list attribute for <input type='color'> is not yet supported.

1:24 PM Changeset in webkit [153540] by mhahnenberg@apple.com
  • 3 edits
    3 adds in trunk

DFG doesn't account for inlining of functions with switch statements that haven't been executed by the baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=119349

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Prior to this patch, the baseline JIT was responsible for resizing the ctiOffsets Vector for
SimpleJumpTables to be equal to the size of the branchOffsets Vector. The DFG implicitly relied
on code it compiled with any switch statements to have been run in the baseline JIT first.
However, if the DFG chooses to inline a function that has never been compiled by the baseline
JIT then this resizing never happens and we crash at link time in the DFG.

We can fix this by also doing the resize in the DFG to catch this case.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

LayoutTests:

  • fast/js/dfg-inline-switch-imm-expected.txt: Added.
  • fast/js/dfg-inline-switch-imm.html: Added.
  • fast/js/script-tests/dfg-inline-switch-imm.js: Added.

(foo):
(bar):

12:55 PM Changeset in webkit [153539] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-537-branch

Merged r153511. <rdar://problem/14213012>

12:51 PM Changeset in webkit [153538] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153487. <rdar://problem/14502050>

12:32 PM Changeset in webkit [153537] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

Reviewed by NOBODY

  • runtime/JSString.cpp:

(JSC::JSRopeString::getIndexSlowCase):

  • runtime/JSString.h:
12:27 PM Changeset in webkit [153536] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

RenderEmbeddedObject::isReplacementObscured is wrong if an obscuring element has pointer-events: none set
​https://bugs.webkit.org/show_bug.cgi?id=119348

Reviewed by Dean Jackson.

Change the expected outcome of the test to want a visually-obscured
but clickable embed (because the obscuring element has pointer-events: none)
to be considered obscured.

Also, adjust the test so that it runs all of the subtests even if
some of them fail.

  • plugins/unavailable-plugin-indicator-obscurity-expected.txt:
  • plugins/unavailable-plugin-indicator-obscurity.html:
12:26 PM Changeset in webkit [153535] by Bem Jones-Bey
  • 9 edits in trunk/Tools

Update scripts to reference contributors.json instead of committers.py in messaging
​https://bugs.webkit.org/show_bug.cgi?id=119342

Reviewed by Ryosuke Niwa.

Change the scripts to point people to contributors.json instead of
committers.py since the latter no longer contains the list of
contributors.

  • Scripts/webkitpy/common/config/committervalidator.py:

(CommitterValidator._contributors_json_path):
(CommitterValidator._flag_permission_rejection_message):

  • Scripts/webkitpy/common/config/committervalidator_unittest.py:

(CommitterValidatorTest.test_flag_permission_rejection_message):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._commit_queue_flag):

  • Scripts/webkitpy/common/watchlist/watchlistparser.py:

(WatchListParser._validate):

  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

(WatchListParserTest.test_cc_rule_with_invalid_email):

  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:

(ValidateReviewer.run):

12:22 PM Changeset in webkit [153534] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Re-enable WinEWS tests following r153527.

  • Scripts/webkitpy/common/config/ews.json:
12:20 PM Changeset in webkit [153533] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. AppleWin port.

  • platform/win/editing/selection/move-left-right-expected.txt:
12:03 PM Changeset in webkit [153532] by barraclough@apple.com
  • 80 edits in trunk/Source

Some cleanup in JSValue::get
​https://bugs.webkit.org/show_bug.cgi?id=119343

Reviewed by Geoff Garen.

Source/JavaScriptCore:

JSValue::get is implemented to:

1) Check if the value is a cell – if not, synthesize a prototype to search,
2) call getOwnPropertySlot on the cell,
3) if this returns false, cast to JSObject to get the prototype, and walk the prototype chain.

By all rights this should crash when passed a string and accessing a property that does not exist, because
the string is a cell, getOwnPropertySlot should return false, and the cast to JSObject should be unsafe.
To work around this, JSString::getOwnPropertySlot actually implements 'get' functionality - searching the
prototype chain, and faking out a return value of undefined if no property is found.

This is a huge hazard, since fixing JSString::getOwnPropertySlot or calling getOwnPropertySlot on cells
from elsewhere would introduce bugs. Fortunately it is only ever called in this one place.

The fix here is to move getOwnPropertySlot onto JSObjecte and end this madness - cells don't have property
slots anyway.

Interesting changes are in JSCJSValueInlines.h, JSString.cpp - the rest is pretty much all JSCell -> JSObject.

Source/WebCore:

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):

  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):

  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlot):

  • bridge/runtime_object.h:
    • getOwnPropertySlot, JSCell -> JSObject

Source/WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertySlot):

  • WebProcess/Plugins/Netscape/JSNPObject.h:
    • getOwnPropertySlot, JSCell -> JSObject
11:48 AM Changeset in webkit [153531] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r153406): DOM intervals are not properly restarted when resumed
​https://bugs.webkit.org/show_bug.cgi?id=119345

Reviewed by Sam Weinig.

  • page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Call base class version of repeatInterval(), not our version that will just return the current value of m_savedRepeatInterval in this situation.
11:44 AM Changeset in webkit [153530] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid calling nextRenderer() in some cases
​https://bugs.webkit.org/show_bug.cgi?id=119313

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/3207cfda52082f4fd6a04c7819c18a980de58beb.

  • dom/Text.cpp:

(WebCore::Text::textRendererIsNeeded):

11:41 AM Changeset in webkit [153529] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Convert most callers of setInlineStyleProperty passing strings to enums or doubles instead
​https://bugs.webkit.org/show_bug.cgi?id=119304

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/8157dd9381716759f183fabbfed29c52962be746

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::setFontSize):

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
(WebCore::TextTrackCueGeneric::setFontSize):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

11:18 AM Changeset in webkit [153528] by Bem Jones-Bey
  • 27 edits in trunk/LayoutTests

[CSS Shapes] Stop using internals in shape-outside tests
​https://bugs.webkit.org/show_bug.cgi?id=119229

Reviewed by Alexandru Chiculita.

We no longer need to use window.internals for shape-outside, since it
is enabled by default on ports where it is compiled in. To make the
w3c spec test cleaner, that reference has been removed from all of the
tests.

  • csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html:
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html:
  • csswg/submitted/shapes/shape-outside/w3c-import.log:
11:03 AM Changeset in webkit [153527] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win] JavaScript crash.
​https://bugs.webkit.org/show_bug.cgi?id=119339

Reviewed by Mark Hahnenberg.

  • jit/JITStubsX86.h: Implement ctiVMThrowTrampoline and

ctiVMThrowTrampolineSlowpath the same way as the gcc x86 version does.

10:47 AM Changeset in webkit [153526] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Test assignment to indexed window properties
​https://bugs.webkit.org/show_bug.cgi?id=119307

Reviewed by Geoffrey Garen.

Merge ​https://chromium.googlesource.com/chromium/blink/+/bdeca10fa79477f669cab1e5b081a480e743fd3f

  • http/tests/security/xss-DENIED-window-index-assign-expected.txt: Added.
  • http/tests/security/xss-DENIED-window-index-assign.html: Added.
9:52 AM Changeset in webkit [153525] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test to ensure SelectElement removes an option when null is assigned by indexed setter
​https://bugs.webkit.org/show_bug.cgi?id=119311

Reviewed by Alexey Proskuryakov.

Merge a test in ​https://chromium.googlesource.com/chromium/blink/+/da5c8d908b87f75c5ba3d1457c2353642e999963
even though the regression never existed in WebKit.

  • fast/forms/select/select-assign-null-expected.txt: Added.
  • fast/forms/select/select-assign-null.html: Added.
9:24 AM Changeset in webkit [153524] by Bem Jones-Bey
  • 2 edits in trunk/Tools

Unreviewed: Adding myself to the committers' list.

  • Scripts/webkitpy/common/config/contributors.json:
9:08 AM Changeset in webkit [153523] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Coordinated Graphics] Use m_ prefix only for member variable
​https://bugs.webkit.org/show_bug.cgi?id=119250

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-07-31
Reviewed by Noam Rosenthal.

WebKit coding style suggests to use m_ prefix only for data members.
This patch also removes unnecessary copy by passing const-reference
parameter values.

  • platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:

(WebCore::CoordinatedCustomFilterProgram::create):

7:39 AM Changeset in webkit [153522] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Images are down-scaled badly
​https://bugs.webkit.org/show_bug.cgi?id=119263

Reviewed by Jocelyn Turcotte.

QPainter only does bilinear filtering, which means it will downscaling beyond
0.5x will start skipping pixel and start to degrade the end result. Scaling in
QImage and QPixmap however uses a better but much more expensive sampling that
counts all pixels.

To get the high quality downscaling we must therefore prescale the images before
painting them. To avoid a performance impact on repeated paints the prescaled
image are saved in the QPixmapCache.

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

7:35 AM Changeset in webkit [153521] by simon.pena@samsung.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening. Remove flaky tests from TestExpectations.

  • platform/gtk/TestExpectations: Remove tests no longer flaky after

webkit.org/b/100688 was fixed in r140166.

6:09 AM Changeset in webkit [153520] by allan.jensen@digia.com
  • 6 edits in trunk

[Qt] Build WebKit with C++11
​https://bugs.webkit.org/show_bug.cgi?id=119337

Reviewed by Csaba Osztrogonác.

Source/WebKit2:

We no longer need to enable C++11 specifically for WebKit2.

  • WebKit2.pri:

Tools:

Enable building with C++11.

  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/unix/default_post.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
5:49 AM Changeset in webkit [153519] by allan.jensen@digia.com
  • 2 edits in trunk/Tools

[Qt] ASSERTS trigger in release builds
​https://bugs.webkit.org/show_bug.cgi?id=119336

Reviewed by Jocelyn Turcotte.

Ensure the qmake also defaults to release if no configuration is known.

  • qmake/mkspecs/features/default_post.prf:
5:42 AM Changeset in webkit [153518] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[texmap][GStreamer][GTK] composited video shows tearing
​https://bugs.webkit.org/show_bug.cgi?id=118253

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.

The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.

5:12 AM Changeset in webkit [153517] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt][WK1] navigator.plugins shows too few entries.
​https://bugs.webkit.org/show_bug.cgi?id=119332

Reviewed by Jocelyn Turcotte.

Based on input by Choon Sik Cho.

PlatformStrategiesQt::getPluginInfo was using the
WTF::Vector::resize method wrongly.

This patch removes the call to Vector::resize as
Vector::append will take care of increasing capacity
if needed.

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::getPluginInfo):

4:56 AM Changeset in webkit [153516] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk/Source

[Qt] Add interface API for origin whitelisting
​https://bugs.webkit.org/show_bug.cgi?id=117823

Patch by Deepjyoti Saha <​deesaha@cisco.com> on 2013-07-31
Reviewed by Jocelyn Turcotte.

Adding interface APIs in QWebSecurityOrigin to add and remove whiteList entires.

Re-used most of the test cases written by Carol Szabo <​carol.szabo@nokia.com>
for ​https://bugs.webkit.org/show_bug.cgi?id=31875 and added the same.

  • Api/qwebsecurityorigin.cpp:

(QWebSecurityOrigin::addAccessWhitelistEntry):
(QWebSecurityOrigin::removeAccessWhitelistEntry):

  • Api/qwebsecurityorigin.h:
  • tests/qwebsecurityorigin: Added.
  • tests/qwebsecurityorigin/qwebsecurityorigin.pro: Added.
  • tests/qwebsecurityorigin/resources: Added.
  • tests/qwebsecurityorigin/resources/test.html: Added.
  • tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp: Added.

(tst_QWebSecurityOrigin::tst_QWebSecurityOrigin):
(tst_QWebSecurityOrigin::~tst_QWebSecurityOrigin):
(tst_QWebSecurityOrigin::init):
(tst_QWebSecurityOrigin::cleanup):
(tst_QWebSecurityOrigin::whiteList_data):
(tst_QWebSecurityOrigin::whiteList):

  • tests/qwebsecurityorigin/tst_qwebsecurityorigin.qrc: Added.
2:44 AM Changeset in webkit [153515] by g.czajkowski@samsung.com
  • 6 edits in trunk/Source/WebCore

Remove guessesVector param from isUngrammatical
​https://bugs.webkit.org/show_bug.cgi?id=119241

Reviewed by Ryosuke Niwa.

TextCheckingHelper::isUngrammatical(Vector<String>& guessesVector) doesn't return
guesses for ungrammatical phrases through its parameter.
Editor::isSelectionUngrammatical() uses it to check whether the selection
is ungrammatical.

r71009 showed that isUngrammatical(Vector<String>& guessesVector) had not supported
grammar guesses.

The grammar guesses can be retrieved by guessesForMisspelledOrUngrammaticalRange
when UNIFIED_TEXT_CHECKING is on.

No new tests, this is dead code due to no WebKit port implements grammar using
legacy text checker.

  • WebCore.exp.in: Removed ZN7WebCore6Editor32guessesForUngrammaticalSelectionEv.
  • editing/Editor.cpp:

(WebCore::Editor::isSelectionUngrammatical):
(WebCore::Editor::guessesForMisspelledOrUngrammatical):

  • editing/Editor.h: Removed guessesForUngrammaticalSelection. Dead code.
  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::isUngrammatical):

  • editing/TextCheckingHelper.h:
1:12 AM Changeset in webkit [153514] by akling@apple.com
  • 3 edits in trunk/Source/WTF

Shrink Vectors with inline capacity.
<​http://webkit.org/b/119295>
<rdar://problem/14598360>

Reviewed by Anders Carlsson.

Pack Vector::m_size next to VectorBufferBase::m_capacity so there's no space wasted
on padding when sizeof(T) >= 8. Since m_size is not conceptually part of the buffer,
I just using'ed it into Vector.

  • wtf/SizeLimits.cpp:
  • wtf/Vector.h:

(WTF::VectorBufferBase::VectorBufferBase):
(WTF::VectorBuffer::VectorBuffer):
(WTF::Vector::Vector):
(WTF::::Vector):

1:06 AM Changeset in webkit [153513] by g.czajkowski@samsung.com
  • 3 edits in trunk/Source/WebCore

Unnecessary const_cast<TextCheckingHelper*>(this)->findFirstBadGrammar
​https://bugs.webkit.org/show_bug.cgi?id=119244

Reviewed by Ryosuke Niwa.

Added missing const modifier to findFirstBadGrammar (and findFirstGrammarDetail
respectively) to call it in 'isUngrammatical() const' without const casting.

No new tests, no behavior change.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
Added const.

(WebCore::TextCheckingHelper::isUngrammatical):
Now const_cast can be removed.

  • editing/TextCheckingHelper.h:
12:23 AM Changeset in webkit [153512] by g.czajkowski@samsung.com
  • 3 edits in trunk/Source/WebCore

findFirstGrammarDetail doesn't need to be exposed.
​https://bugs.webkit.org/show_bug.cgi?id=119249

Reviewed by Darin Adler.

Make TextCheckingHelper::findFirstGrammarDetail private.
Remove badGrammarPhraseLength param. It's not used any longer.

No new tests, no behavior change.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):

  • editing/TextCheckingHelper.h:

Jul 30, 2013:

10:57 PM Changeset in webkit [153511] by timothy_horton@apple.com
  • 5 edits
    2 adds in trunk

DHTML drag can result in a null-deref under WebDragClient::startDrag
​https://bugs.webkit.org/show_bug.cgi?id=119297
<rdar://problem/14213012>

Reviewed by Simon Fraser.

Test: fast/events/setDragImage-in-document-element-crash.html

  • page/mac/FrameSnapshottingMac.mm:

(WebCore::snapshotDragImage):
We shouldn't waste time painting an empty image, nor should we return
an image with no size.

Add a test that ensures that using a zero-size in-document non-<img>
element for setDragImage() doesn't crash.

  • fast/events/setDragImage-in-document-element-crash-expected.txt: Added.
  • fast/events/setDragImage-in-document-element-crash.html: Added.
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):
ShareableBitmap::createShareable can return null, but shouldn't dereference that.

9:59 PM Changeset in webkit [153510] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Dotted borders render w/ artifacts and sometimes as solid lines
​https://bugs.webkit.org/show_bug.cgi?id=3964

Patch by Pravin D <​pravind@samsung.com> on 2013-07-30
Reviewed by Elliott Sprehn.

Source/WebCore:

While drawing the dotted border, the common borders are drawn by the cells sharing them. The dotted borders
become(tend) solid when the starting and the end points of the border drawn by the two cells don't match. This
fixes the same.

Test: fast/table/border-collapsing/dotted-collapsed-border.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::alignLeftRightBorderPaintRect):
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect):

Helper function to decide if border's start point requires any adjustment.

(WebCore::RenderTableCell::paintCollapsedBorders):
Added logic to handle dotted borders so that they do not become solid.

  • rendering/RenderTableCell.h: Helper function declarations.

LayoutTests:

  • fast/table/border-collapsing/dotted-collapsed-border-expected.txt: Added.
  • fast/table/border-collapsing/dotted-collapsed-border.html: Added.
  • platform/qt/fast/table/border-collapsing/dotted-collapsed-border-expected.png: Added.
9:55 PM Changeset in webkit [153509] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Gmail reply email - Bold and Italic style get stuck
​https://bugs.webkit.org/show_bug.cgi?id=118185

Patch by Vani Hegde <​vani.hegde@samsung.com> on 2013-07-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

When bold/italic style is applied to a content with mixed editability,
style is applied appropriately for the first time.
But after this, style toggling does not work any more. Same behavior
can be observed when the content on which style is applied contains
text node without renderer (Ex: text node corresponding to tab/space etc)

When bold/italic style is applied on a selection, we actually apply the
style only for text nodes that have renderers and also are contenteditable.
Similarly during style toggling, to check whether a style has been already
applied on a selection

Tests: editing/style/toggle-style-bold-italic-mixed-editability.html

editing/style/toggle-style-bold-italic.html

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle):
A particular selection on which style is applied may contain text nodes
without renderers(text nodes corresponding to tab/space) or text nodes
that are not contenteditable. We do not apply style to such text nodes.
Hence, even during style toggling we should not consider the styles
present in such nodes.

LayoutTests:

Layout tests added to test bold/italic style toggling on a content
with mixed editability.

  • editing/editing.js:

(runDumpAsTextEditingTest): Replaced markupResultList with
elementsForDumpingMarkupList to store all markup data to be logged
at the end of test.
(debugForDumpAsText): Changed to use elementsForDumpingMarkupList.
(startNewMarkupGroup): Added utility function to hold intermediate
data by separating <ol>.

  • editing/style/toggle-style-bold-italic-expected.txt: Added.
  • editing/style/toggle-style-bold-italic-mixed-editability-expected.txt: Added.
  • editing/style/toggle-style-bold-italic-mixed-editability.html: Added.
  • editing/style/toggle-style-bold-italic.html: Added.
6:59 PM Changeset in webkit [153508] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

XMLSerializer should reset default namespace when necessary
​https://bugs.webkit.org/show_bug.cgi?id=16739
XMLSerializer's handling of namespaces seems to be pretty broken
​https://bugs.webkit.org/show_bug.cgi?id=106531

Reviewed by Ryosuke Niwa.

Source/WebCore:

Write out empty default namespace declaration if the element is not in any namespace, as
described in ​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-xhtml-syntax.html#xml-fragment-serialization-algorithm.

Tests: fast/dom/XMLSerializer-element-empty-namespace.html

fast/dom/XMLSerializer-element-empty-namespace2.html

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::appendOpenTag):

  • editing/MarkupAccumulator.h:

LayoutTests:

Add tests based on the testcases of both bugs.

  • fast/dom/XMLSerializer-element-empty-namespace-expected.txt: Added.
  • fast/dom/XMLSerializer-element-empty-namespace.html: Added.
  • fast/dom/XMLSerializer-element-empty-namespace2-expected.txt: Added.
  • fast/dom/XMLSerializer-element-empty-namespace2.html: Added.
6:50 PM Changeset in webkit [153507] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Don't post accessibility notification on object in detached document.
​https://bugs.webkit.org/show_bug.cgi?id=119286

Reviewed by Ryosuke Niwa.

Merge ​https://chromium.googlesource.com/chromium/blink/+/ef9fc9e70202dcf33e5cf2f0f0a2135945ffe17e%5E%21/#F0

Don't post accessibility notification on object in detached document.

This can happen if an accessibility notification is queued on a node,
then that node is reparented to a different document that's not attached
anywhere before the accessibility notification is fired.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):

6:18 PM Changeset in webkit [153506] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

6:13 PM Changeset in webkit [153505] by Lucas Forschler
  • 1 copy in tags/Safari-537.53

New Tag.

5:58 PM Changeset in webkit [153504] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit2

Rename <input type='color'> functions in WebPageProxy, WebColorPicker
<rdar://problem/14549771> and ​https://bugs.webkit.org/show_bug.cgi?id=119097

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-07-30
Reviewed by Tim Horton.

In bug 119025, WebColorChooserProxy was renamed WebColorPicker. This patch makes the UIProcess consistent
by renaming UIProcess INPUT_TYPE_COLOR functions from ...colorChooser to ...colorPicker.

  • UIProcess/WebColorPicker.cpp:

(WebKit::WebColorPicker::endPicker):

  • UIProcess/WebColorPicker.h:
  • UIProcess/WebColorPickerResultListenerProxy.cpp:

(WebKit::WebColorPickerResultListenerProxy::setColor):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::setColorPickerColor):
(WebKit::WebPageProxy::endColorPicker):
(WebKit::WebPageProxy::didEndColorPicker):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/WebColorPickerQt.cpp:

(WebKit::WebColorPickerQt::createItem):
(WebKit::WebColorPickerQt::notifyColorSelected):
(WebKit::WebColorPickerQt::endPicker):

  • UIProcess/qt/WebColorPickerQt.h:
  • WebProcess/WebCoreSupport/WebColorChooser.cpp:

(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::setSelectedColor):
(WebKit::WebColorChooser::endChooser):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didEndColorPicker):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:19 PM Changeset in webkit [153503] by ruthiecftg@gmail.com
  • 2 edits in trunk/Tools

Unreviewed: Adding myself to the committers' list.

  • Scripts/webkitpy/common/config/contributors.json:
4:13 PM Changeset in webkit [153502] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Content filter replacement data uses the encoding from the blocked page's response headers
​https://bugs.webkit.org/show_bug.cgi?id=119237

Reviewed by Darin Adler.

When a document specifies an encoding in an HTTP response header, or
when the embedder specifies an override encoding, and the content filter
blocks the document, we interpret the content filter's replacement data
using this encoding. This might be the wrong.

Forget about encodings determined from these sources. The replacement
data will specify an encoding in a <meta charset>, so let that be used
instead.

No new tests. We don't currently have a mechanism for testing the
content filter from WebKit.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData): Pretend as if no encoding is
specified if the content filter blocked the load.
(WebCore::DocumentLoader::dataReceived): Stopped calling commitLoad()
before early-returning if the content filter needs more data. This isn't
necessary.

3:43 PM Changeset in webkit [153501] by ap@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

REGRESSION: Crash when opening a message on Gmail
​https://bugs.webkit.org/show_bug.cgi?id=119105

Landing missing test results.

  • fast/js/dfg-get-by-id-unset-then-proto-expected.txt: Added.
  • fast/js/dfg-get-by-id-unset-then-proto-less-warmup-expected.txt: Added.
  • fast/js/dfg-get-by-id-unset-then-proto-more-warmup-expected.txt: Added.
3:41 PM Changeset in webkit [153500] by mhahnenberg@apple.com
  • 4 edits
    3 adds in trunk

GetByVal on Arguments does the wrong size load when checking the Arguments object length
​https://bugs.webkit.org/show_bug.cgi?id=119281

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This leads to out of bounds accesses and subsequent crashes.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

  • fast/js/dfg-strict-mode-arguments-get-beyond-length-expected.txt: Added.
  • fast/js/dfg-strict-mode-arguments-get-beyond-length.html: Added.
  • fast/js/script-tests/dfg-strict-mode-arguments-get-beyond-length.js: Added.

(foo):
(bar):

3:20 PM Changeset in webkit [153499] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Speculative fix for crash due to string access on multiple threads
​https://bugs.webkit.org/show_bug.cgi?id=119279
<rdar://problem/14267833>

Reviewed by Darin Adler.

We can't use String::isolatedCopy for passing the local storage directory to the storage thread since
that returns a String that's copied and then destroyed after the call to bind returns, leaving a small window
where the refcount can be accessed simultaneously from two threads.

Work around this by passing a PassRefPtr<StringImpl> to bind instead; the act of copying the PassRefPtr will
clear out the original and so when the original is destroyed the underlying StringImpl pointer will be null.

  • UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectory):
(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):

  • UIProcess/Storage/LocalStorageDatabaseTracker.h:
3:17 PM Changeset in webkit [153498] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r139282): Fix document leak when selection is created inside the document
​https://bugs.webkit.org/show_bug.cgi?id=119122

OK'd by Ryosuke Niwa.

The added test was very flaky. Trying to make it better with a gc() call at the beginning.

  • editing/selection/leak-document-with-selection-inside.html:
3:12 PM Changeset in webkit [153497] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add an assertion to SpeculateCellOperand
​https://bugs.webkit.org/show_bug.cgi?id=119276

Reviewed by Michael Saboff.

More assertions are better

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

3:01 PM Changeset in webkit [153496] by ap@apple.com
  • 3 edits in trunk/LayoutTests

[Mac] can-read-in-dragstart-event.html and can-read-in-copy-and-cut-events.html fail
​https://bugs.webkit.org/show_bug.cgi?id=113094

The test still fails on WK1, and needs to be marked accordingly.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
2:44 PM Changeset in webkit [153495] by Christophe Dumez
  • 12 edits in trunk

Add 'colno' attribute to ErrorEvent interface
​https://bugs.webkit.org/show_bug.cgi?id=119257

Reviewed by Darin Adler.

Source/WebCore:

Add 'colno' attribute to ErrorEvent interface to match the latest specification:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#errorevent

The 'colno' attribute is already supported by IE10 and Blink.

No new tests, covered by existing tests.

  • dom/ErrorEvent.cpp:

(WebCore::ErrorEventInit::ErrorEventInit):
(WebCore::ErrorEvent::ErrorEvent):

  • dom/ErrorEvent.h:
  • dom/ErrorEvent.idl:

LayoutTests:

Update several test cases to check the new ErrorEvent.colno
attribute.

  • fast/events/constructors/error-event-constructor-expected.txt:
  • fast/events/constructors/error-event-constructor.html:
  • fast/events/window-onerror9-expected.txt:
  • fast/events/window-onerror9.html:
  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
  • http/tests/workers/worker-importScriptsOnError-expected.txt:
2:32 PM Changeset in webkit [153494] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Inactive style sheets should not trigger style recalc when loaded.
<​http://webkit.org/b/119236>
<rdar://problem/14588132>

Reviewed by Antti Koivisto.

Style sheets that are either alternate sheets or are excluded by their media query should not trigger
a full style recalc when they finish loading, since the end result will not be observably different.

The sheets are still inspectable through document.styleSheets.

Changed enums from Blocking/NonBlocking to ActiveSheet/InactiveSheet to clarify what's going on.

  • html/HTMLLinkElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::startLoadingDynamicSheet):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

2:27 PM Changeset in webkit [153493] by timothy_horton@apple.com
  • 7 edits in trunk/Source

Fix typo in enum name ("SelectionInSnaphot" -> "SelectionInSnapshot")
​https://bugs.webkit.org/show_bug.cgi?id=119275

Reviewed by Simon Fraser.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::paintContentsForSnapshot):

  • page/FrameView.h:

Fix typo.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):
Fix typo.

2:19 PM Changeset in webkit [153492] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Compile fix for WebGL on 32-bit Windows.
​https://bugs.webkit.org/show_bug.cgi?id=119235

Reviewed by Darin Adler.

  • platform/graphics/GLContext.cpp:

Created GLNativeWindowType typedef.
(WebCore::GLContext::createContextForWindow):

  • platform/graphics/GLContext.h:

Replaced uint64_t with GLNativeWindowType.

2:06 PM Changeset in webkit [153491] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153486. <rdar://problem/14440207>

2:00 PM Changeset in webkit [153490] by Lucas Forschler
  • 1 edit in branches/safari-537-branch/Source/WebKit2/ChangeLog

Merged r153449. <rdar://problem/14440207>

1:33 PM Changeset in webkit [153489] by Christophe Dumez
  • 2 edits in trunk/Tools

Unreviewed, add my new email to contributors.json.

  • Scripts/webkitpy/common/config/contributors.json:
12:45 PM Changeset in webkit [153488] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Plug-in process crashes if plug-in is destroyed as a result of sending NPObjectMessageReceiver::Deallocate
​https://bugs.webkit.org/show_bug.cgi?id=119270
<rdar://problem/13368226>

Reviewed by Darin Adler.

Normally we use the PluginDestructionProtector RAII object to prevent plug-ins from being destroyed while
they're executing code. However, in the case of the NPObjectMessageReceiver::Deallocate message, we can't do this
since we don't know the plug-in or connection.

Instead, add a counter to Connection that keeps track of whether sendSync is currently called and defer plug-in
destruction if it is. (This approach is actually more robust and we should investigate getting rid of the destruction protector).

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):
(CoreIPC::Connection::sendSyncMessage):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::inSendSync):

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::destroy):

12:42 PM Changeset in webkit [153487] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Null deref under WebPage::scaledSnapshotWithOptions
​https://bugs.webkit.org/show_bug.cgi?id=119243
<rdar://problem/14502050>

Reviewed by Darin Adler.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):
WebFrame::coreFrame() can be null (if the Frame is already torn down),
so we should check it.

12:38 PM Changeset in webkit [153486] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Null deref under PluginView::handlesPageScaleFactor()
​https://bugs.webkit.org/show_bug.cgi?id=119231
<rdar://problem/14440207>

Reviewed by Darin Adler.

Null-check the PluginView in the caller as well.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::handlesPageScaleGesture):

12:01 PM Changeset in webkit [153485] by Patrick Gansterer
  • 5 edits in trunk/Source

[WIN] Remove dependency on CoreFoundation from DownloadBundle
​https://bugs.webkit.org/show_bug.cgi?id=119247

Reviewed by Anders Carlsson.

  • platform/network/cf/DownloadBundle.h:
  • platform/network/curl/DownloadBundle.h:
  • platform/network/win/DownloadBundleWin.cpp:

(WebCore::DownloadBundle::magicNumber):
(WebCore::DownloadBundle::appendResumeData):
(WebCore::DownloadBundle::extractResumeData):

11:54 AM Changeset in webkit [153484] by Patrick Gansterer
  • 1 edit
    2 deletes in trunk/Source/WebKit2

Remove unused Download*.cpp files
​https://bugs.webkit.org/show_bug.cgi?id=119248

Reviewed by Anders Carlsson.

  • Shared/Downloads/cfnet/DownloadCFNet.cpp: Removed.
  • Shared/Downloads/curl/DownloadCurl.cpp: Removed.
11:54 AM Changeset in webkit [153483] by Patrick Gansterer
  • 14 edits
    1 move in trunk/Source

Move WindowsExtras.h from WebCore to WTF
​https://bugs.webkit.org/show_bug.cgi?id=118125

Reviewed by Anders Carlsson.

Move it to WTF to be able to use the functions in WTF too.

Source/WebCore:

  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
  • platform/win/MIMETypeRegistryWin.cpp:
  • platform/win/PasteboardWin.cpp:
  • platform/win/PopupMenuWin.cpp:
  • platform/win/RunLoopWin.cpp:
  • platform/win/SharedTimerWin.cpp:
  • platform/win/WindowMessageListener.h:
  • plugins/win/PluginDatabaseWin.cpp:

Source/WTF:

  • wtf/WindowsExtras.h: Renamed from Source/WebCore/platform/win/WindowsExtras.h.

(WTF::getRegistryValue):
(WTF::getWindowPointer):
(WTF::setWindowPointer):

  • wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

11:28 AM Changeset in webkit [153482] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Page for WKPageLoaderClient processDidCrash callback always reports a process identifier of 0
​https://bugs.webkit.org/show_bug.cgi?id=119269
<rdar://problem/14582393>

Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processIdentifier):
Return 0 if the page is closed instead of requiring isValid().

10:40 AM Changeset in webkit [153481] by kseo@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Move the implementation of WebEditorClient::checkTextOfParagraph to WebEditorClient.cpp
​https://bugs.webkit.org/show_bug.cgi?id=119034

Reviewed by Anders Carlsson.

The Mac and EFL ports use the same implementation of
WebEditorClient::checkTextOfParagraph and GTK will use the same
implementation too. So rather than duplicating the same code in
platform specific files, move the implementation to platform agnostic
WebProcess/WebCoreSupport/WebEditorClient.cpp.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkTextOfParagraph):

  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
10:38 AM Changeset in webkit [153480] by Christophe Dumez
  • 34 edits in trunk

Pass column as 4th argument to WorkerGlobalScope.onerror and Window.onerror handlers
​https://bugs.webkit.org/show_bug.cgi?id=119251

Reviewed by Geoffrey Garen.

Source/WebCore:

As per the latest specification, the WorkerGlobalScope.onerror and Window.onerror event
handlers should be given the column as fourth argument:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope
​http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#onerroreventhandler

The column argument is already supported by IE10 and Blink.

No new tests, covered by existing tests.

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • dom/ErrorEvent.cpp:

(WebCore::ErrorEvent::ErrorEvent):

  • dom/ErrorEvent.h:

(WebCore::ErrorEvent::create):
(WebCore::ErrorEvent::colno):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::sanitizeScriptError):
(WebCore::ScriptExecutionContext::reportException):
(WebCore::ScriptExecutionContext::dispatchErrorEvent):

  • dom/ScriptExecutionContext.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::performTask):

LayoutTests:

Update several tests to make use of the new column argument passed to
WorkerGlobalScope.onerror and Window.onerror handlers.

  • fast/events/window-onerror1-expected.txt:
  • fast/events/window-onerror1.html:
  • fast/events/window-onerror11-expected.txt:
  • fast/events/window-onerror11.html:
  • fast/events/window-onerror12-expected.txt:
  • fast/events/window-onerror12.html:
  • fast/events/window-onerror13.html:
  • fast/events/window-onerror14.html:
  • fast/events/window-onerror16.html:
  • fast/events/window-onerror2-expected.txt:
  • fast/events/window-onerror2.html:
  • fast/events/window-onerror4-expected.txt:
  • fast/events/window-onerror4.html:
  • fast/events/window-onerror5-expected.txt:
  • fast/events/window-onerror5.html:
  • fast/events/window-onerror6-expected.txt:
  • fast/events/window-onerror6.html:
  • fast/events/window-onerror7-expected.txt:
  • fast/events/window-onerror7.html:
  • fast/events/window-onerror8-expected.txt:
  • fast/events/window-onerror8.html:
  • fast/events/window-onerror9-expected.txt:
  • fast/events/window-onerror9.html:
  • fast/workers/resources/worker-script-error-handled.js:

(onerror):

  • fast/workers/worker-script-error-expected.txt:
10:30 AM Changeset in webkit [153479] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WebKit2] [Gtk] WebKitResponsePolicyDecision URI response property incorrect
​https://bugs.webkit.org/show_bug.cgi?id=119258

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-30
Reviewed by Martin Robinson.

Corrected the installed URI response property from PROP_REQUEST to
PROP_RESPONSE and type from WEBKIT_TYPE_URI_REQUEST to
WEBKIT_TYPE_URI_RESPONSE.

  • UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:

(webkit_response_policy_decision_class_init):

10:27 AM Changeset in webkit [153478] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Use OwnPtr in RenderThemeWin and ScrollbarThemeWin
​https://bugs.webkit.org/show_bug.cgi?id=117978

Reviewed by Brent Fulgham.

Use OwnPtr to avoid manual deletion of objects.

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::paintTrackPiece):

  • rendering/RenderThemeWin.cpp:

(WebCore::drawControl):

10:01 AM Changeset in webkit [153477] by mark.lam@apple.com
  • 18 edits in trunk

Fix problems with divot and lineStart mismatches.
​https://bugs.webkit.org/show_bug.cgi?id=118662.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

r152494 added the recording of lineStart values for divot positions.
This is needed for the computation of column numbers. Similarly, it also
added the recording of line numbers for the divot positions. One problem
with the approach taken was that the line and lineStart values were
recorded independently, and hence were not always guaranteed to be
sampled at the same place that the divot position is recorded. This
resulted in potential mismatches that cause some assertions to fail.

The solution is to introduce a JSTextPosition abstraction that records
the divot position, line, and lineStart as a single quantity. Wherever
we record the divot position as an unsigned int previously, we now record
its JSTextPosition which captures all 3 values in one go. This ensures
that the captured line and lineStart will always match the captured divot
position.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitDebugHook):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitExpressionInfo):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • bytecompiler/NodesCodegen.cpp:

(JSC::ThrowableExpressionData::emitThrowReferenceError):
(JSC::ResolveNode::emitBytecode):
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::NewExprNode::emitBytecode):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
(JSC::DeleteResolveNode::emitBytecode):
(JSC::DeleteBracketNode::emitBytecode):
(JSC::DeleteDotNode::emitBytecode):
(JSC::PrefixNode::emitResolve):
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
(JSC::UnaryOpNode::emitBytecode):
(JSC::BinaryOpNode::emitStrcat):
(JSC::BinaryOpNode::emitBytecode):
(JSC::ThrowableBinaryOpNode::emitBytecode):
(JSC::InstanceOfNode::emitBytecode):
(JSC::emitReadModifyAssignment):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::AssignDotNode::emitBytecode):
(JSC::ReadModifyDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
(JSC::ReadModifyBracketNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • parser/ASTBuilder.h:
  • Replaced ASTBuilder::PositionInfo with JSTextPosition.

(JSC::ASTBuilder::BinaryOpInfo::BinaryOpInfo):
(JSC::ASTBuilder::AssignmentInfo::AssignmentInfo):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::appendBinaryExpressionInfo):
(JSC::ASTBuilder::appendUnaryToken):
(JSC::ASTBuilder::unaryTokenStackLastStart):
(JSC::ASTBuilder::assignmentStackAppend):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::setExceptionLocation):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • parser/Lexer.cpp:

(JSC::::lex):

  • Added support for capturing the appropriate JSTextPositions instead of just the character offset.
  • parser/Lexer.h:

(JSC::Lexer::currentPosition):
(JSC::::lexExpectIdentifier):

  • Added support for capturing the appropriate JSTextPositions instead of just the character offset.
  • parser/NodeConstructors.h:

(JSC::Node::Node):
(JSC::ResolveNode::ResolveNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PostfixNode::PostfixNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::PrefixNode::PrefixNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::WithNode::WithNode):
(JSC::ForInNode::ForInNode):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • parser/Nodes.cpp:

(JSC::StatementNode::setLoc):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • parser/Nodes.h:

(JSC::Node::lineNo):
(JSC::Node::startOffset):
(JSC::Node::lineStartOffset):
(JSC::Node::position):
(JSC::ThrowableExpressionData::ThrowableExpressionData):
(JSC::ThrowableExpressionData::setExceptionSourceCode):
(JSC::ThrowableExpressionData::divot):
(JSC::ThrowableExpressionData::divotStart):
(JSC::ThrowableExpressionData::divotEnd):
(JSC::ThrowableSubExpressionData::ThrowableSubExpressionData):
(JSC::ThrowableSubExpressionData::setSubexpressionInfo):
(JSC::ThrowableSubExpressionData::subexpressionDivot):
(JSC::ThrowableSubExpressionData::subexpressionStart):
(JSC::ThrowableSubExpressionData::subexpressionEnd):
(JSC::ThrowablePrefixedSubExpressionData::ThrowablePrefixedSubExpressionData):
(JSC::ThrowablePrefixedSubExpressionData::setSubexpressionInfo):
(JSC::ThrowablePrefixedSubExpressionData::subexpressionDivot):
(JSC::ThrowablePrefixedSubExpressionData::subexpressionStart):
(JSC::ThrowablePrefixedSubExpressionData::subexpressionEnd):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseInner):

  • Use JSTextPosition instead of passing line and lineStart explicitly.

(JSC::::didFinishParsing):

  • Remove setting of m_lastLine value. We always pass in the value from m_lastLine anyway. So, this assignment is effectively a nop.

(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseTryStatement):
(JSC::::parseBlockStatement):
(JSC::::parseFunctionDeclaration):
(JSC::LabelInfo::LabelInfo):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseAssignmentExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parsePrimaryExpression):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • parser/Parser.h:

(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::getToken):
(JSC::Parser::tokenStartPosition):
(JSC::Parser::tokenEndPosition):
(JSC::Parser::lastTokenEndPosition):
(JSC::::parse):

  • Use JSTextPosition instead of passing line and lineStart explicitly.
  • parser/ParserTokens.h:

(JSC::JSTextPosition::JSTextPosition):
(JSC::JSTextPosition::operator+):
(JSC::JSTextPosition::operator-):
(JSC::JSTextPosition::operator int):

  • Added JSTextPosition.
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::appendBinaryExpressionInfo):
(JSC::SyntaxChecker::operatorStackPop):

  • Use JSTextPosition instead of passing line and lineStart explicitly.

LayoutTests:

Added regression test cases from ​https://bugs.webkit.org/show_bug.cgi?id=118662
and ​https://bugs.webkit.org/show_bug.cgi?id=118664.

  • fast/js/line-column-numbers-expected.txt:
  • fast/js/line-column-numbers.html:
  • fast/js/script-tests/line-column-numbers.js:

(try.toFuzz1):
(try.toFuzz2):

9:33 AM Changeset in webkit [153476] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Added include directories to Visual Studio for WebGL.
​https://bugs.webkit.org/show_bug.cgi?id=119161

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCoreCommon.props: Added more include directories.
9:32 AM Changeset in webkit [153475] by Csaba Osztrogonác
  • 12 edits in trunk/Source/WebCore

Unreviewed, rolling out r151957 and r152531.
​http://trac.webkit.org/changeset/151957
​http://trac.webkit.org/changeset/152531
​https://bugs.webkit.org/show_bug.cgi?id=119267

They revealed a bug on Mac I can't fix (Requested by Ossy on
#webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2013-07-30

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameIsCompleteAtIndex):
(WebCore::BitmapImage::frameDurationAtIndex):

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex):

  • platform/graphics/ImageSource.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::frameIsCompleteAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::frameHasAlphaAtIndex):

  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::gifComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::frameContext):

9:26 AM Changeset in webkit [153474] by simon.pena@samsung.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening. Updated TestExpectations

  • platform/gtk/TestExpectations: Mark transitions/created-while-suspended.html

as slow after r153396.

9:18 AM Changeset in webkit [153473] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitLibraries

Missing the rename REGISTER_PROCOTOL_HANDLER Macro to NAVIGATOR_CONTENT_UTILS in WebKitLibraries.
​https://bugs.webkit.org/show_bug.cgi?id=119239

According to "​https://bugs.webkit.org/show_bug.cgi?id=94920", REGISTER_PROCOTOL_HANDLER macro was changed to NAVIGATOR_CONTENT_UTILS.
But, FeatureDefines.props and FeatureDefinesCairo.props was not changed.

Patch by Sanghyun Park <​sh919.park@samsung.com> on 2013-07-30
Reviewed by Brent Fulgham.

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefinesCairo.props:
8:38 AM WebKitGTK/2.0.x edited by brian.holt@samsung.com
added ​​https://bugs.webkit.org/show_bug.cgi?id=119258 to 2.0.5 (diff)
7:12 AM Changeset in webkit [153472] by simon.pena@samsung.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening. Update TestExpectations

Some GTK tests are flaky or time out after the FTL merge.

  • platform/gtk/TestExpectations:
6:52 AM Changeset in webkit [153471] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: doesn't use localized user interface at remote inspector
​https://bugs.webkit.org/show_bug.cgi?id=119252

Patch by Roland Takács <​rtakacs@inf.u-szeged.hu> on 2013-07-30
Reviewed by Timothy Hatcher.

Added a flag in order to not use localizedStrings in remote inspector.

  • UserInterface/InspectorFrontendHostStub.js:
  • UserInterface/LoadLocalizedStrings.js:
  • UserInterface/Main.js:

(WebInspector.UIString):

6:51 AM Changeset in webkit [153470] by Christophe Dumez
  • 2 edits in trunk/Tools

[EFL] REGRESSION after r153439: layout tests do not run.
​https://bugs.webkit.org/show_bug.cgi?id=119240

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-07-30
Reviewed by Christophe Dumez.

Changed attribute name from check_xvfb to check_driver.

  • Scripts/webkitpy/port/efl.py:

(EflPort.check_sys_deps):

6:49 AM Changeset in webkit [153469] by kseo@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove using namespace std from SpatialNavigation
​https://bugs.webkit.org/show_bug.cgi?id=119242

Reviewed by Antonio Gomes.

"using namespace" statements in headers are dangerous and should be
avoided. check-webkit-style has been changed to flag them as an error
since r152719. Use explicit std:: qualifiers instead.

No behavior change, no new tests needed.

  • page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):

  • page/SpatialNavigation.h:

(WebCore::maxDistance):

6:38 AM Changeset in webkit [153468] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] fast/regions/firstletter-inside-flowthread.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=106592

Unreviewed gardening.

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-07-30

  • platform/gtk/TestExpectations: Unflag test as it is passing without

problems now.

6:34 AM Changeset in webkit [153467] by kadam@inf.u-szeged.hu
  • 2 edits in trunk

[Qt] Workaround to make syncqt run and generate forwarding headers in SVN repositories too.
​https://bugs.webkit.org/show_bug.cgi?id=118725.

Reviewed by Tor Arne Vestbø.

  • .qmake.conf:
6:14 AM Changeset in webkit [153466] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and Versions.m4 for 2.1.4 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.1.4.
5:12 AM Changeset in webkit [153465] by Antoine Quint
  • 2 edits in trunk/LayoutTests

[Mac] can-read-in-dragstart-event.html and can-read-in-copy-and-cut-events.html fail
​https://bugs.webkit.org/show_bug.cgi?id=113094

The test can-read-in-copy-and-cut-events.html now passes on mac-wk2.

  • platform/mac/TestExpectations:
5:01 AM Changeset in webkit [153464] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Extend disabling of whole-program-optimizations to MSVC 2012
​https://bugs.webkit.org/show_bug.cgi?id=119238

Reviewed by Jocelyn Turcotte.

As suggested in ​https://bugreports.qt-project.org/browse/QTBUG-20556,
the WebKit build with MSVC 2012 is affected by the same size
limitations.

  • WebCore.pri:
4:42 AM Changeset in webkit [153463] by Antoine Quint
  • 2 edits in trunk/LayoutTests

Mark compositing/patterns tests as passing for mac-wk2
​https://bugs.webkit.org/show_bug.cgi?id=119246

These tests run fine on WK2.

  • platform/mac-wk2/TestExpectations:
4:23 AM Changeset in webkit [153462] by Antoine Quint
  • 1 edit in trunk/LayoutTests/platform/mac/TestExpectations

REGRESSION: iframes with composited contents are not transparent in WK1
​https://bugs.webkit.org/show_bug.cgi?id=76478

Unskip these tests since the root cause has been fixed long ago already.

4:14 AM Changeset in webkit [153461] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore
REGRESION(r151091) ASSERTION FAILED: m_readableData
m_writableData

​https://bugs.webkit.org/show_bug.cgi?id=119142

Reviewed by Jocelyn Turcotte.

Remove invalid assert.

Covered by existing tests.

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::readData):

Note: See TracTimeline for information about the timeline view.