Timeline
Aug 1, 2013:
- 11:09 PM Changeset in webkit [153636] by
-
- 2 edits in trunk/Source/WTF
<rdar://problem/14235491> FastMalloc zone enumerator responding to MALLOC_PTR_REGION_RANGE_TYPE with individual allocations
Teach PageMapMemoryUsageRecorder::recordPendingRegions to only record data of the type that it's asked for.
This also fixes the vmmap output to associate some regions with the FastMalloc malloc zone that were previously
associated with it only via the VM tag, meaning they were incorrectly being omitted from the malloc statistics
section of the report.
Reviewed by Dan Bernstein.
- wtf/FastMalloc.cpp:
(WTF::PageMapMemoryUsageRecorder::recordPendingRegions): Report the individual allocations only when requested. Add
the ability to report the regions containing pointers separately from the allocations.
- 11:01 PM Changeset in webkit [153635] by
-
- 2 edits in trunk/Source/WTF
<rdar://problem/14528244> False-positive leaks from FastMalloc.
A logic error in the page map enumeration code within FastMalloc could result in a subset of the memory regions
owned by FastMalloc being skipped by the malloc zone enumeration code used by leaks and other performance tools.
If the only reference to an allocated object lived within one of the skipped memory regions, leaks would believe
it had been leaked since it would not find any references to the object.
The logic error manifested when a FastMalloc span owned a region of memory that crossed a 16MB address space boundary,
and when there was one or more other spans immediately after it in the address space. Crossing the 16MB address space
boundary means that the start and end points of the span are in different leaf nodes of the page map trie, and the
code within the page map's visitValues method didn't correctly account this case when skipping to the end of the span
after visiting it. It would resume iterating from the start of the next leaf node rather than continuing to skip values
until the end of the span was passed. The value representing the end of the span would then be processed as if it were
the start of a new span, and more values would be skipped even though they may contain actual spans.
The solution is to rework the algorithm used in visitValues so that it will skip the correct number of values even when
some of the values are in different leaf nodes. This is a more involved change than it may seem since it's also necessary
to deal with the case where a memory region spans two separate root nodes, which can happen if the region happens to cross
a 64GB boundary in the address space.
Reviewed by Geoff Garen.
- wtf/TCPageMap.h:
(TCMalloc_PageMap3::visitValues): Use a single loop to iterate, with the loop index being the key in to the page map in the
same form as used by get and set. This allows us to correctly deal with the index being skipped to a different intermediate or
root node as a result of visiting a span that crosses a 16MB boundary in memory.
(TCMalloc_PageMap2::visitValues): Ditto, but without having to deal with intermediate nodes.
- 7:39 PM Changeset in webkit [153634] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r153608.
http://trac.webkit.org/changeset/153608
https://bugs.webkit.org/show_bug.cgi?id=119425
Snorkled fast/multicol/overflow-content-expected.html
(Requested by kling on #webkit).
Source/WebCore:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyMatchedProperties):
LayoutTests:
- fast/css/identical-logical-height-decl-expected.html: Removed.
- fast/css/identical-logical-height-decl.html: Removed.
- 7:07 PM Changeset in webkit [153633] by
-
- 14 edits in trunk/Source
[Forms: color] <input type='color'> popover color well implementation
<rdar://problem/14411008> and https://bugs.webkit.org/show_bug.cgi?id=119356
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-08-01
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Added and enabled INPUT_TYPE_COLOR_POPOVER.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Added and enabled INPUT_TYPE_COLOR_POPOVER.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Added and enabled INPUT_TYPE_COLOR_POPOVER.
Source/WebKit2:
This patch adds an popover implementation of <input type='color'>.
- Configurations/FeatureDefines.xcconfig: Added and enabled INPUT_TYPE_COLOR_POPOVER.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createColorPicker): Updated to pass the
coordinates of the <input type='color'> element and the WKView
object for the window.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewWillStartLiveResize): Close popover color
picker when the view is resized.
(WebKit::WebPageProxy::viewInWindowStateDidChange): Close popover color
picker when the view is no longer in the window.
(WebKit::WebPageProxy::showColorPicker): Updated to show either a color panel
or a popover color picker depending on whether INPUT_TYPE_COLOR_POPOVER is enabled.
- UIProcess/mac/WebColorPickerMac.h:
- UIProcess/mac/WebColorPickerMac.mm:
(WebKit::WebColorPickerMac::create):
(WebKit::WebColorPickerMac::~WebColorPickerMac):
(WebKit::WebColorPickerMac::WebColorPickerMac):
(WebKit::WebColorPickerMac::endPicker):
(WebKit::WebColorPickerMac::setSelectedColor):
(WebKit::WebColorPickerMac::showColorPicker):
Methods updated to handle both the color panel implementation and
the popover implementation; also renamed m_panel to m_colorPickerUI.
(-[WKColorPopoverMac initWithFrame:WebCore::inView:]):
(-[WKColorPopoverMac setAndShowPicker:WebKit::withColor:]):
(-[WKColorPopoverMac dealloc]):
(-[WKColorPopoverMac invalidate]):
(-[WKColorPopoverMac windowWillClose:]):
(-[WKColorPopoverMac didChooseColor:]):
(-[WKColorPopoverMac setColor:]):
WKColorPopoverMac provides the popover implementation of <input type='color'>.
(-[WKColorPanelMac didChooseColor:]): Updated to match the interface of
WKColorPickerMac::didChooseColor.
Source/WTF:
- wtf/FeatureDefines.h: Added and enabled INPUT_TYPE_COLOR_POPOVER.
- 6:57 PM Changeset in webkit [153632] by
-
- 2 edits in trunk/Source/WebCore
FormAssociatedElement shouldn't create out-of-tree FormAttributeTargetObserver
https://bugs.webkit.org/show_bug.cgi?id=119309
Reviewed by Kent Tamura.
Merge https://chromium.googlesource.com/chromium/blink/+/6fbdcbf311de539107bc28711b3f7a527176e97b.
I'm not merging the test since the attached test case only works when the shadow DOM API is enabled.
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
- 6:00 PM Changeset in webkit [153631] by
-
- 11 edits6 adds in trunk
selectors should match attribute name with case sensitivity based on element & document type
https://bugs.webkit.org/show_bug.cgi?id=71152
Reviewed by Darin Adler.
Source/WebCore:
Support case-sensitive attribute name selecting for non HTML. In order to do this we have to
store the attribute name in the selector as-is when css parsing, and get the lowercase localName
on demand for case-insensitive matching. The only time we want case-insensitive matching is when
we try to match a HTML element in a HTML document.
Tests: fast/dom/SelectorAPI/attrname-case-insensitive.html
fast/dom/SelectorAPI/attrname-case-sensitive.xhtml
svg/css/case-sensitive-attrname-selectors.html
- css/CSSGrammar.y.in: do not lowercase attribute selector name.
- css/CSSParserValues.h:
(WebCore::CSSParserSelector::setAttribute):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::setAttribute):
- css/CSSSelector.h: allow access to lowered version of attribute localName if needed.
(WebCore::CSSSelector::attributeCanonicalLocalName):
- css/SelectorChecker.cpp:
(WebCore::anyAttributeMatches): do only case-insensitive matching for HTML.
(WebCore::SelectorChecker::checkOne):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::checkExactAttribute): do only case-insensitive matching for HTML.
- css/SelectorCheckerFastPath.cpp:
(WebCore::HTMLNames::checkExactAttributeValue):
- css/SelectorCheckerFastPath.h:
(WebCore::SelectorCheckerFastPath::matchesRightmostAttributeSelector):
- dom/Attribute.h:
(WebCore::Attribute::matches): use more convenient parameters.
LayoutTests:
Results matches FireFox nightly.
- fast/dom/SelectorAPI/attrname-case-insensitive-expected.txt: Added.
- fast/dom/SelectorAPI/attrname-case-insensitive.html: Check that in HTML documents CSS selectors
use case-insensitive attribute name matching for HTML elements, case-sensitive otherwise.
- fast/dom/SelectorAPI/attrname-case-sensitive-expected.txt: Added.
- fast/dom/SelectorAPI/attrname-case-sensitive.xhtml: Check that in XHTML documents CSS selectors
always use case-sensitive attribute name matching.
- svg/css/case-sensitive-attrname-selectors-expected.txt: Added.
- svg/css/case-sensitive-attrname-selectors.html: Check that in HTML documents CSS selectors in stylesheets
use case-insensitive attribute name matching for HTML elements, case-sensitive otherwise.
- 5:44 PM Changeset in webkit [153630] by
-
- 4 edits in branches/safari-537-branch
Bot greening. Merge r153629.
2013-08-01 Alexey Proskuryakov <ap@apple.com>
<rdar://problem/14625616> http/tests/download/basic-ascii.html and http/tests/download/literal-utf-8.html fails
Changed the PHP files to not have a BOM, which confuses some versions of PHP.
They are both ASCII anyway.
- http/tests/download/resources/basic-ascii.php:
- http/tests/download/resources/literal-utf-8.php:
- 5:23 PM Changeset in webkit [153629] by
-
- 3 edits in trunk/LayoutTests
<rdar://problem/14625616> http/tests/download/basic-ascii.html and http/tests/download/literal-utf-8.html fails
Changed the PHP files to not have a BOM, which confuses some versions of PHP.
They are both ASCII anyway.
- http/tests/download/resources/basic-ascii.php:
- http/tests/download/resources/literal-utf-8.php:
- 5:07 PM Changeset in webkit [153628] by
-
- 11 edits in trunk
[Windows] WebKit1 Fullscreen Video Play is Broken
https://bugs.webkit.org/show_bug.cgi?id=119415
Reviewed by Jer Noble.
Source/WebCore:
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add
call for ACFPlayerLayerSetFrame
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::platformSetVisible):
Tear down video player when leaving Fullscreen mode and not using
the newer Fullscreen feature.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper):
Disconnect from notifications for AVCFPlayerItemPresentationSizeChangedNotification,
AVCFPlayerItemDuratoinChangedNotification, and disconnect any
LegibleOutput items added to the player item.
(WebCore::AVFWrapper::createPlayerItem): Add notifications for
AVCFPlayerItemPresentationSizeChanged.
(WebCore::LayerClient::platformCALayerLayoutSublayersOfLayer): Notify
the AVCFPLayerLayer when the display size has changed.
- platform/graphics/ca/win/CACFLayerTreeHost.h:
(WebCore::CACFLayerTreeHost::manualCreateRenderer): Added.
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
(WebCore::WKCACFViewLayerTreeHost::manualCreateRenderer): Added.
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Minor
cleanups.
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
Make sure a Direct3D renderer is created when building the full screen
window for Video playback.
Source/WebKit/win:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Set accelerated
rendering on by default on systems that support it.
- WebView.cpp:
(WebView::exitFullscreen): Clean up Fullscreen video controller
once it is no longer used. This was preventing users from being
able to reenter Fullscreen mode after leaving it.
(WebView::fullScreenClientForceRepaint): Change assert to
match the member actually being used in the method.
Tools:
- WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint): Activate full screen mode via
IWebPreferencesInternal interface.
- 5:02 PM Changeset in webkit [153627] by
-
- 5 edits12 adds in trunk
srcset algorithm breaks base64 src attributes
https://bugs.webkit.org/show_bug.cgi?id=119413
Reviewed by Darin Adler.
Source/WebCore:
Base64 encoded src attributes typically have a COMMA
character which was breaking in the candidate matching
algorithm. Make sure to handle that case, and to unescape
any incoming URLs.
Slight cleanup of the srcset matching algorithm. The
candidates are now gathered from a single update
method. I've renamed the methods in the process.
This means we now reparse the srcset attribute if
only the src changes, but I think the code is
cleaner this way.
Tests: fast/hidpi/image-srcset-data-src.html
fast/hidpi/image-srcset-data-srcset.html
fast/hidpi/image-srcset-nomodifier.html
fast/hidpi/image-srcset-viewport-modifiers.html
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::HTMLImageElement): No need to initialise m_bestFitImageURL.
(WebCore::HTMLImageElement::imageSourceURL): Use isEmpty() rather than checking for nullAtom.
(WebCore::HTMLImageElement::determineBestImageForScaleFactor): New renamed method that selects the best
candidate for the image source.
(WebCore::HTMLImageElement::collectImageCandidatesFromSrcSet): Gather the srcset images. Changes include
simplifying the whitespace and skipping candidates that we don't yet support.
(WebCore::HTMLImageElement::collectImageCandidateFromSrc): Add the src attribute to the list of candidates.
(WebCore::HTMLImageElement::parseAttribute): Now both attributes call determineBestImageForScaleFactor.
- html/HTMLImageElement.h: No need for m_srcImageIndex any more.
LayoutTests:
Four new tests that exercise candidate matching. In particular:
- base64 encoded src attributes
- base64 encoded srcset attributes that are escaped
- attributes without scale modifiers
- attributes that have modifiers other than scale
- fast/hidpi/image-srcset-change-dynamically-from-js.html: Minor change to add scale modifier.
- fast/hidpi/image-srcset-data-src.html: Added.
- fast/hidpi/image-srcset-data-srcset.html: Added.
- fast/hidpi/image-srcset-nomodifier.html: Added.
- fast/hidpi/image-srcset-viewport-modifiers.html: Added.
- platform/mac/fast/hidpi/image-srcset-data-src-expected.png: Added.
- platform/mac/fast/hidpi/image-srcset-data-src-expected.txt: Added.
- platform/mac/fast/hidpi/image-srcset-data-srcset-expected.png: Added.
- platform/mac/fast/hidpi/image-srcset-data-srcset-expected.txt: Added.
- platform/mac/fast/hidpi/image-srcset-nomodifier-expected.png: Added.
- platform/mac/fast/hidpi/image-srcset-nomodifier-expected.txt: Added.
- platform/mac/fast/hidpi/image-srcset-viewport-modifiers-expected.png: Added.
- platform/mac/fast/hidpi/image-srcset-viewport-modifiers-expected.txt: Added.
- 5:02 PM Changeset in webkit [153626] by
-
- 3 edits3 copies in branches/safari-537-branch
Merged r153615. <rdar://problem/14625273>
- 5:01 PM Changeset in webkit [153625] by
-
- 12 edits3 adds in trunk/LayoutTests
Minor cleanup for srcset tests
https://bugs.webkit.org/show_bug.cgi?id=119407
Reviewed by Tim Horton.
Other than small typos and style tweaks, there are three
main changes here:
- Collect duplicated code into a helper file.
- Make sure the tests that add or remove the attributes
can run standalone outside of DRT.
- Update the -simple test with new images that make it
more clear what srcset is doing.
- fast/hidpi/image-srcset-change-dynamically-from-js.html:
- fast/hidpi/image-srcset-invalid-inputs-correct-src.html:
- fast/hidpi/image-srcset-invalid-inputs-except-one.html:
- fast/hidpi/image-srcset-invalid-inputs.html:
- fast/hidpi/image-srcset-only-src-attribute.html:
- fast/hidpi/image-srcset-remove-dynamically-from-js.html:
- fast/hidpi/image-srcset-same-alternative-for-both-attributes.html:
- fast/hidpi/image-srcset-simple.html:
- fast/hidpi/image-srcset-src-selection.html:
- fast/hidpi/resources/image-set-1x.png: Added.
- fast/hidpi/resources/image-set-2x.png: Added.
- fast/hidpi/resources/srcset-helper.js: Added.
- platform/mac/fast/hidpi/image-srcset-simple-expected.png:
- platform/mac/fast/hidpi/image-srcset-simple-expected.txt:
- 5:00 PM Changeset in webkit [153624] by
-
- 6 edits27 adds in trunk
Implement img element's srcset attribute
https://bugs.webkit.org/show_bug.cgi?id=110252
Patch by Romain Perier <Romain Perier> on 2013-08-01
Reviewed by Dean Jackson.
Source/WebCore:
Tests: fast/hidpi/image-srcset-simple.html
fast/hidpi/image-srcset-src-selection.html
fast/hidpi/image-srcset-simple.html
fast/hidpi/image-srcset-src-selection.html
fast/hidpi/image-srcset-only-src-attribute.html
fast/hidpi/image-srcset-same-alternative-for-both-attributes.html
fast/hidpi/image-srcset-invalid-inputs.html
fast/hidpi/image-srcset-invalid-inputs-except-one.html
fast/hidpi/image-srcset-invalid-inputs-correct-src.html
fast/hidpi/image-srcset-change-dynamically-from-js.html
fast/hidpi/image-srcset-remove-dynamically-from-js.html
- html/HTMLAttributeNames.in: Add srcset attribute.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::HTMLImageElement):
Adding initialization for new variables member.
(WebCore::HTMLImageElement::imageSourceURL):
Override this method to return the choosen image transparently to the ImageLoader.
(WebCore::HTMLImageElement::updateBestImageForScaleFactor):
New method to select the good image candidate dependending on the scale factor. This method is separated from
parsing because it will be useful for selecting a new image candidate on the fly if the device scale factor changes.
(WebCore::HTMLImageElement::updateImagesFromSrcSet):
New method for parsing the srcset attribute and build a list of images with the corresponding scale factor.
(WebCore::HTMLImageElement::parseAttribute):
Adding support for processing the image candidates, select the good one and call ImageLoader for rendering.
- html/HTMLImageElement.h:
- Adding new methods declarations.
- Adding new type definition.
- Adding new variable member to store the URL of the choosen image.
- Adding new variable member to store the index of the src image.
- Adding new Vector to store the list of images after parsing.
- html/HTMLImageElement.idl: Adding srcset attribute for the differents existing bidings.
LayoutTests:
- fast/hidpi/image-srcset-simple.html: Ensures that the good image
is selected from srcset by the user agent according to the choosen scale factor.
- fast/hidpi/image-srcset-src-selection.html: Ensures that the image
from the src attribute is collected by the parsing algorithm and selected by the user agent
when no other candidate matches the scale factor.
- fast/hidpi/image-srcset-only-src-attribute.html: Ensures that the algorithms used for srcset
does not change the behaviour of the src attribute when the srcset attribute is not defined,
even using scale factor greater than 1.
- fast/hidpi/image-srcset-same-alternative-for-both-attributes.html: Ensures that the good image
is selected by the user agent when src and srcset contain an image with a scale factor of 1.
- fast/hidpi/image-srcset-invalid-inputs.html: Ensures that the parsing and the selection
algorithms support invalid inputs. Theses ones are simply ignored.
- fast/hidpi/image-srcset-invalid-inputs-except-one.html: Ensures that a valid image
is selected even if this one is part of a set containing invalid inputs.
- fast/hidpi/image-srcset-invalid-inputs-correct-src.html: Ensures that the image from
the src attribute is choosen when srcset contains only invalid inputs, this selection
should not depend on the scale factor.
- fast/hidpi/image-srcset-change-dynamically-from-js.html: Ensures that src and srcset attributes
can be changed dynamically from javascript.
- fast/hidpi/image-srcset-remove-dynamically-from-js.html: Ensures that src attribute
can be removed dynamically from javascript.
- platform/mac/fast/hidpi/image-srcset-simple-expected.png:
- platform/mac/fast/hidpi/image-srcset-simple-expected.txt:
- platform/mac/fast/hidpi/image-srcset-src-selection-expected.png:
- platform/mac/fast/hidpi/image-srcset-src-selection-expected.txt:
- platform/mac/fast/hidpi/image-srcset-only-src-attribute-expected.png:
- platform/mac/fast/hidpi/image-srcset-only-src-attribute-expected.txt:
- platform/mac/fast/hidpi/image-srcset-same-alternative-for-both-attributes-expected.png:
- platform/mac/fast/hidpi/image-srcset-same-alternative-for-both-attributes-expected.txt:
- platform/mac/fast/hidpi/image-srcset-invalid-inputs-expected.png:
- platform/mac/fast/hidpi/image-srcset-invalid-inputs-expected.txt:
- platform/mac/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.png:
- platform/mac/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt:
- platform/mac/fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.png:
- platform/mac/fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.txt:
- platform/mac/fast/hidpi/image-srcset-change-dynamically-from-js-expected.png:
- platform/mac/fast/hidpi/image-srcset-change-dynamically-from-js-expected.txt:
- platform/mac/fast/hidpi/image-srcset-remove-dynamically-from-js-expected.png:
- platform/mac/fast/hidpi/image-srcset-remove-dynamically-from-js-expected.txt:
- 4:44 PM Changeset in webkit [153623] by
-
- 2 edits2 adds4 deletes in trunk/LayoutTests
[CSS Shapes] New positioning model: support for stacked floats with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=118087
Reviewed by Alexandru Chiculita.
Import new test for stacked floats from the CSSWG's repository to
replace the old tests. The simple horizontal rectangle test is no
longer applicable now that float stacking ignores shapes, so it has
just been removed.
- TestExpectations: Remove skipping for replaced tests.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple-expected.html: Removed.
- fast/shapes/shape-outside-floats/shape-outside-floats-simple-rectangle-horizontal-multiple.html: Removed.
- fast/shapes/shape-outside-floats/shape-outside-floats-stacked-expected.html: Removed.
- fast/shapes/shape-outside-floats/shape-outside-floats-stacked.html: Removed.
- 4:17 PM Changeset in webkit [153622] by
-
- 4 edits in trunk/LayoutTests
Update polygon shape-outside tests for upstream changes
https://bugs.webkit.org/show_bug.cgi?id=119414
Reviewed by Alexandru Chiculita.
The refs were updated upstream to make them work properly in Blink.
This pulls in that change to keep things in sync.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html:
- 3:53 PM Changeset in webkit [153621] by
-
- 3 edits in branches/safari-537-branch/Source/JavaScriptCore
Merge patch for <rdar://problem/14527940>.
- 3:42 PM Changeset in webkit [153620] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r153595. <rdar://problem/14615802>
- 3:40 PM Changeset in webkit [153619] by
-
- 3 edits4 copies in branches/safari-537-branch
Merged r153553. <rdar://problem/14612613>
- 3:36 PM Changeset in webkit [153618] by
-
- 2 edits in trunk/Tools
Unreviewed. Add an alternative address to show my affiliation in team.html.
- Scripts/webkitpy/common/config/contributors.json:
- 3:34 PM Changeset in webkit [153617] by
-
- 3 edits in branches/safari-537-branch/Source/WTF
Merged r153514. <rdar://problem/14598360>
- 3:27 PM Changeset in webkit [153616] by
-
- 3 edits in trunk/Source/WebKit2
Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins()
https://bugs.webkit.org/show_bug.cgi?id=119412
Reviewed by Simon Fraser.
For some sick reason, the WKContextClient plugInInformationBecameAvailable callback function
expects a +1 reference to the plug-in array. Isolate that hack to WebContextClient so that
we don't leak the array if there is no WKContextClient.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInInformationBecameAvailable):
- 3:18 PM Changeset in webkit [153615] by
-
- 3 edits3 adds in trunk
DFG is not enforcing correct ordering of ToString conversion in MakeRope
https://bugs.webkit.org/show_bug.cgi?id=119408
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Construct ToString and Phantom nodes in advance of MakeRope
nodes to ensure that ordering is ensured, and correct values
will be reified on OSR exit.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
LayoutTests:
Add tests
- fast/js/dfg-make-rope-side-effects-expected.txt: Added.
- fast/js/dfg-make-rope-side-effects.html: Added.
- fast/js/script-tests/dfg-make-rope-side-effects.js: Added.
(f):
(k.valueOf):
(k.toString):
- 3:15 PM Changeset in webkit [153614] by
-
- 3 edits in branches/safari-537-branch/Source/WebKit2
Merged r153499. <rdar://problem/14267833>
- 3:14 PM Changeset in webkit [153613] by
-
- 4 edits3 adds in trunk
DFG optimizations don't handle neutered arrays properly
https://bugs.webkit.org/show_bug.cgi?id=119409
Reviewed by Mark Hahnenberg and Oliver Hunt.
Source/WebCore:
Test: fast/js/dfg-typed-array-neuter.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::neuterView):
(WebCore::SerializedScriptValue::transferArrayBuffers):
(WebCore::SerializedScriptValue::create):
- bindings/js/SerializedScriptValue.h:
LayoutTests:
- fast/js/dfg-typed-array-neuter-expected.txt: Added.
- fast/js/dfg-typed-array-neuter.html: Added.
- fast/js/script-tests/dfg-typed-array-neuter.js: Added.
(foo):
(bar):
- 2:57 PM Changeset in webkit [153612] by
-
- 5 edits in trunk/Source/JavaScriptCore
REGRESSION: Crash beneath cti_vm_throw_slowpath due to invalid CallFrame pointer
https://bugs.webkit.org/show_bug.cgi?id=119140
Reviewed by Filip Pizlo.
Ensure that ExceptionHandler is returned by functions in two registers by encoding the value as a 64 bit int.
- jit/JITExceptions.cpp:
(JSC::encode):
- jit/JITExceptions.h:
- jit/JITStubs.cpp:
(JSC::cti_vm_throw_slowpath):
- jit/JITStubs.h:
- 2:50 PM Changeset in webkit [153611] by
-
- 2 edits in trunk/Source/WebKit2
Remove return statement in void function
https://bugs.webkit.org/show_bug.cgi?id=119379
Reviewed by Darin Adler.
It does not make sense to return a value in void function.
- WebProcess/WebProcess.cpp:
(WebKit::addCaseFoldedCharacters):
- 2:48 PM Changeset in webkit [153610] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Add USE(SOUP) guard in WebProcess::destroyPrivateBrowsingSession
https://bugs.webkit.org/show_bug.cgi?id=119381
Reviewed by Darin Adler.
The is a followup to r153355. I missed to add USE(SOUP) guard in
WebProcess::destroyPrivateBrowsingSession.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::destroyPrivateBrowsingSession):
- 2:41 PM Changeset in webkit [153609] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being copied into the wrong location
https://bugs.webkit.org/show_bug.cgi?id=112833
Reviewed by Sam Weinig.
AutodrainedPool.h and SchedulePair.h should just be project headers, not
private headers, so they get copied into <build dir>/usr/local/include/wtf
not <build dir>/usr/local/include
- WTF.xcodeproj/project.pbxproj:
- 2:25 PM Changeset in webkit [153608] by
-
- 3 edits2 adds in trunk
REGRESSION (Safari 6 - ToT): Incorrectly assumes that RenderStyle data can be shared
https://bugs.webkit.org/show_bug.cgi?id=113058
Source/WebCore:
Before sharing CSS properties with an element in the cache, we need to
check that the new element is suitable for this, just like we check
elements before inserting them into the cache.
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-08-01
Reviewed by Andreas Kling.
Test: fast/css/identical-logical-height-decl.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyMatchedProperties):
LayoutTests:
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-08-01
Reviewed by Andreas Kling.
- fast/css/identical-logical-height-decl-expected.html: Added.
- fast/css/identical-logical-height-decl.html: Added.
- 2:13 PM Changeset in webkit [153607] by
-
- 29 edits in trunk/Source/WebCore
Fixed expected test results for run-bindings-tests after r153532, r153537.
https://bugs.webkit.org/show_bug.cgi?id=119410.
Reviewed by Simon Fraser.
No new tests.
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayPrototype::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertySlotByIndex):
- bindings/scripts/test/JS/JSFloat64Array.h:
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertySlot):
(WebCore::JSTestActiveDOMObjectPrototype::getOwnPropertySlot):
(WebCore::JSTestActiveDOMObject::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterPrototype::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlotByIndex):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::getOwnPropertySlot):
(WebCore::JSTestEventTargetPrototype::getOwnPropertySlot):
(WebCore::JSTestEventTarget::getOwnPropertySlot):
(WebCore::JSTestEventTarget::getOwnPropertySlotByIndex):
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::getOwnPropertySlot):
(WebCore::JSTestException::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfacePrototype::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::getOwnPropertySlot):
(WebCore::JSTestNode::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::getOwnPropertySlot):
(WebCore::JSTestOverloadedConstructors::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::getOwnPropertySlot):
(WebCore::JSTestTypedefsPrototype::getOwnPropertySlot):
(WebCore::JSTestTypedefs::getOwnPropertySlot):
- bindings/scripts/test/JS/JSTestTypedefs.h:
- 2:07 PM Changeset in webkit [153606] by
-
- 2 edits in trunk/LayoutTests
Mark some ref tests that sometimes file becaues of colorspace
issues as both Pass and ImageOnlyFailure.
- platform/mac/TestExpectations:
- 2:01 PM Changeset in webkit [153605] by
-
- 3 edits in branches/safari-537-branch/Source/WebCore
Merged r153494. <rdar://problem/14588132>
- 1:56 PM Changeset in webkit [153604] by
-
- 4 edits in branches/safari-537-branch/Source/WebKit2
Merged r153488. <rdar://problem/13368226>
- 1:54 PM Changeset in webkit [153603] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r153482. <rdar://problem/14582393>
- 1:34 PM Changeset in webkit [153602] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r153448) video-controls-captions-trackmenu.html is failing
https://bugs.webkit.org/show_bug.cgi?id=119376
Reviewed by Simon Fraser.
Call showMenu() before attempting to click on the caption menu items.
- media/video-controls-captions-trackmenu.html:
- platform/mac/TestExpectations:
- 1:24 PM Changeset in webkit [153601] by
-
- 2 edits in trunk/Source/WebCore
Copy eglplatform.h to be found by Windows WebGL build.
https://bugs.webkit.org/show_bug.cgi?id=119299
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCorePreBuild.cmd: Copy eglplatform.h.
- 1:21 PM Changeset in webkit [153600] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
Fixed wrong static_casting in ANGLE from r153064.
https://bugs.webkit.org/show_bug.cgi?id=119296
Reviewed by Dean Jackson.
- src/compiler/Intermediate.cpp:
(TIntermediate::promoteConstantUnion):
Undid erroneous static_cast change.
- src/compiler/intermediate.h:
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
Made getters use size_t instead of int.
- 1:10 PM Changeset in webkit [153599] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore: WebCore::AudioSession::beganAudioInterruption + 62
https://bugs.webkit.org/show_bug.cgi?id=119406
Reviewed by Eric Carlson.
Unregister for AudioSession interruption events when being destroyed.
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::~AudioDestinationIOS):
- 1:04 PM Changeset in webkit [153598] by
-
- 26 edits2 deletes in branches/safari-537-branch
<rdar://problem/14616729> REGRESSION (r144350): Overflow bounding boxes are way
too big; prevents VoiceOver taps from activating the right elements
Reviewed by Darin Adler.
Source/WebCore:
This is a partial-rollout of http://trac.webkit.org/changeset/144350 which is the
change that caused this regression. This patch rolls out most of that patch, and
it only leaves in the part that added a paintContainer variable to PaintInfo since
that is now used in other places in the code. All uses of the paintContainer that
were added with this patch have been removed since they contribute to the
regression.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addFocusRingRects):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):
- rendering/RenderInline.h:
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
- rendering/RenderListBox.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::paintOutline):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::paintOutlineForRowIfNeeded):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects):
- rendering/RenderTextControl.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
(WebCore::RenderSVGContainer::addFocusRingRects):
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
(WebCore::RenderSVGImage::addFocusRingRects):
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::addFocusRingRects):
- rendering/svg/RenderSVGShape.h:
LayoutTests:
Rollout http://trac.webkit.org/changeset/144350
- compositing/sub-layer-focus-ring-expected.html: Removed.
- compositing/sub-layer-focus-ring.html: Removed.
- 12:39 PM Changeset in webkit [153597] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/ChangeLog
Rollout of r153596, it had already been merged.
- 12:33 PM Changeset in webkit [153596] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/ChangeLog
Merged r153498. <rdar://problem/14597172>
- 12:19 PM Changeset in webkit [153595] by
-
- 2 edits in trunk/Source/WebCore
Layout should force a StyleResolver rebuild if there isn't one at all.
<http://webkit.org/b/119378>
Reviewed by Antti Koivisto.
We can't tell if viewport-dependent media queries have been invalidated at layout,
unless we have a StyleResolver to ask about this.
In case there isn't one, take the same path as we would with an invalidated query
instead of relying on ensureStyleResolver() to build it.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 11:58 AM Changeset in webkit [153594] by
-
- 3 edits in trunk/LayoutTests
Crashing Test: fast/forms/color/input-color-onchange-event.html
<rdar://problem/14621667> and https://bugs.webkit.org/show_bug.cgi?id=119403
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-08-01
Reviewed by Tim Horton.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 11:43 AM Changeset in webkit [153593] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Adding myself to list of reviewers since I am one (see https://www.webkit.org/blog/2691/antoine-quint-is-now-a-webkit-reviewer/).
- 11:12 AM Changeset in webkit [153592] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Crash at absoluteClippedOverflowRect() in PluginView::calculateClipRect()
https://bugs.webkit.org/show_bug.cgi?id=119401
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-01.
Reviewed by George Staikos.
JIRA 462881
The renderer of the PluginView's element has been detached due to transition
to a new load. We should return an empty contentRect if there even isn't
a renderer. This is a speculative fix based on the stack trace provided.
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::calculateClipRect):
- 10:59 AM Changeset in webkit [153591] by
-
- 2 edits in trunk/Source/WebCore
Unavailable plug-in indicator arrow should be inside the rounded rect, not in its own circle
https://bugs.webkit.org/show_bug.cgi?id=119400
<rdar://problem/14616012>
Reviewed by Anders Carlsson.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
Shift the arrow in by 9px, and make the text's rounded rect include it,
instead of having the arrow in a separate circle.
- 10:39 AM Changeset in webkit [153590] by
-
- 2 edits in trunk/Tools
Duplicate property names can cause test to fail
https://bugs.webkit.org/show_bug.cgi?id=119399
Reviewed by Dirk Pranke.
This problem was noticed when porting the patch for
http://wkb.ug/119357 to Blink: a test would fail because the converted
and test property lists weren't the same length, but they contained
all of the same property names. It looks like this is actually caused
by a bug in converting the HTML, which is being currently rewritten.
In the meantime, as long as this compares the number of unique
properties, it makes the test more robust.
- Scripts/webkitpy/w3c/test_converter_unittest.py:
(verify_prefixed_properties):
- 10:07 AM Changeset in webkit [153589] by
-
- 2 edits1 add1 delete in trunk/Source/WebCore
Merge FrameWinCE into FrameWin
https://bugs.webkit.org/show_bug.cgi?id=117988
Reviewed by Brent Fulgham.
Reuse the code from FrameWin.cpp instead of duplicating it.
- PlatformWinCE.cmake:
- page/win/FrameGdiWin.cpp: Added.
(WebCore::imageFromRect):
- page/wince/FrameWinCE.cpp: Removed.
- 9:53 AM Changeset in webkit [153588] by
-
- 6 edits in trunk/Source/WebCore
Made OESTextureHalfFloat work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=119298
Reviewed by Christophe Dumez.
- DerivedSources.cpp: Added JSOESTextureHalfFloat.cpp inside of #if ENABLE(WEBGL).
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Added JSOESTextureHalfFloat.cpp and JSOESTextureHalfFloat.h.
- html/canvas/OESTextureHalfFloat.idl: Added newline to end of file.
- html/canvas/WebGLObject.cpp: Removed unused #includes.
- 9:47 AM Changeset in webkit [153587] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding my expertise.
- Scripts/webkitpy/common/config/contributors.json:
- 9:23 AM Changeset in webkit [153586] by
-
- 7 edits in trunk/Source
Rearrange the code of FrameWin
https://bugs.webkit.org/show_bug.cgi?id=117984
Reviewed by Brent Fulgham.
Source/WebCore:
Move code from the CG implementation into the general file so we can
share the code with Windows CE port in a next step. In a first step
it only shares more code between the CG and Cairo implementations.
Also use OwnPtr instead of plain pointers to make ownership more clear.
- page/win/FrameCGWin.cpp:
(WebCore::imageFromRect):
- page/win/FrameCairoWin.cpp:
(WebCore::imageFromRect):
- page/win/FrameWin.cpp:
(WebCore::imageFromSelection):
(WebCore::Frame::dragImageForSelection):
(WebCore::Frame::nodeImage):
- page/win/FrameWin.h:
Source/WebKit/win:
- WebView.cpp:
(WebView::generateSelectionImage):
- 8:35 AM Changeset in webkit [153585] by
-
- 2 edits in trunk/LayoutTests
http/tests/multipart/invalid-image-data-standalone.html needs to skipped, not
just marked as failing, otherwise it gets listed as a test that times out.
- platform/mac/TestExpectations:
- 8:03 AM Changeset in webkit [153584] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer. Yoo-hoo! \o/
- Scripts/webkitpy/common/config/contributors.json:
- 6:28 AM Changeset in webkit [153583] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(FTL): Fix sh4 implementation of ctiVMThrowTrampolineSlowpath.
https://bugs.webkit.org/show_bug.cgi?id=119391
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-01
Reviewed by Csaba Osztrogonác.
- jit/JITStubsSH4.h: Fix ctiVMThrowTrampolineSlowpath implementation:
- Call frame is in r14 register.
- Do not restore registers from JIT stack frame here.
- 6:03 AM Changeset in webkit [153582] by
-
- 3 edits24 adds in trunk
mask-repeat: round bug
Source/WebCore:
Added the round functionality to -webkit-mask-repeat and background-repeat. The tile size of the
image is scaled so that the image can fit a whole number of times in the background.
https://bugs.webkit.org/show_bug.cgi?id=119080
Patch by Andrei Parvu <parvu@adobe.com> on 2013-08-01
Reviewed by Dirk Schulze.
Tests: css3/masking/mask-repeat-round-auto1.html
css3/masking/mask-repeat-round-auto2.html
css3/masking/mask-repeat-round-border.html
css3/masking/mask-repeat-round-content.html
css3/masking/mask-repeat-round-padding.html
css3/background/background-repeat-round-auto1.html
css3/background/background-repeat-round-auto2.html
css3/background/background-repeat-round-border.html
css3/background/background-repeat-round-content.html
css3/background/background-repeat-round-padding.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
LayoutTests:
Added tests for the -webkit-mask-repeat: round property.
https://bugs.webkit.org/show_bug.cgi?id=119080
Patch by Andrei Parvu <parvu@adobe.com> on 2013-08-01
Reviewed by Dirk Schulze.
- css3/masking/mask-repeat-round-auto1-expected.html: Added.
- css3/masking/mask-repeat-round-auto1.html: Added.
- css3/masking/mask-repeat-round-auto2-expected.html: Added.
- css3/masking/mask-repeat-round-auto2.html: Added.
- css3/masking/mask-repeat-round-border-expected.html: Added.
- css3/masking/mask-repeat-round-border.html: Added.
- css3/masking/mask-repeat-round-content-expected.html: Added.
- css3/masking/mask-repeat-round-content.html: Added.
- css3/masking/mask-repeat-round-padding-expected.html: Added.
- css3/masking/mask-repeat-round-padding.html: Added.
- css3/masking/resources/circle.png: Added.
- css3/background/background-repeat-round-auto1-expected.html: Added.
- css3/background/background-repeat-round-auto1.html: Added.
- css3/background/background-repeat-round-auto2-expected.html: Added.
- css3/background/background-repeat-round-auto2.html: Added.
- css3/background/background-repeat-round-border-expected.html: Added.
- css3/background/background-repeat-round-border.html: Added.
- css3/background/background-repeat-round-content-expected.html: Added.
- css3/background/background-repeat-round-content.html: Added.
- css3/background/background-repeat-round-padding-expected.html: Added.
- css3/background/background-repeat-round-padding.html: Added.
- css3/background/resources/circle.png: Added.
- 5:26 AM Changeset in webkit [153581] by
-
- 10 edits in trunk/Source/WebCore
Reduce CSSProperty's StylePropertyMetadata memory footprint by half when used inside a ImmutableStylePropertySet.
https://bugs.webkit.org/show_bug.cgi?id=117715
Reviewed by Andreas Kling.
Today CSSProperty holds its metadata in the following way :
| m_propertyID : 14 We use 14 bits because CSSPropertyIDs start at 1001. |
| m_shorthandID : 14 id of the shorthand this property was set, 0 if not part of a shorthand|
| m_important : 1 |
| m_implicit : 1 |
| m_inherited : 1 |
The proposal to decrease the memory footprint on CSSProperty's metadata
only stand when stored inside ImmutableStylePropertySet which uses a custom
way to allocate and lay out the StylePropertyMetadata and the CSSValues in
memory because the idea behind is that the content will not change.
The MutableStylePropertySet uses a regular vector to retrieve, remove
and modify the CSSProperties. ImmutableStylePropertySet is used by default
when parsing up until someone start to access the CSSOM like
div.style which will convert the immutable to a mutable set. It is also good
to note that a CSSProperty is created for every single statement inside a block
in a stylesheet so we do have quite a bunch around. Another consideration is
that the only client to the m_shorthandID is the inspector which uses it
to group the longhands into a shorthand drop down list.
The new proposal is the following one :
- Reduce m_propertyID to 10 bits by not starting the CSSPropertyIDs from
1001 but rather 0 (or 3 as two are hardcoded CSSPropertyInvalid and CSSPropertyVariable).
- Use the fact that we statically know which longhand belong to which shorthand. So
we create a static mapping between longhands and shorthands.
Here is the new layout :
| m_propertyID : 10 (up to 1024 properties), we have less than 400 today |
| m_isSetFromShorthand : 1 and then use the mapping in StylePropertyShorthand |
| m_indexInShorthandsVector : 2 |
| m_important : 1 (unchanged) |
| m_implicit : 1 (unchanged) |
| m_inherited : 1 (unchanged) |
it was set from using the new code in StylePropertyShorthand.
- m_indexInShorthandsVector : 2 bits, unfortunately there are few longhands which belong to multiple
shorthands so we need to store which was this longhand was part at parsing time. Notice
that it does not store the CSSPropertyID of the matching shorthand but rather its position
in the vector of matching shorthands. CSSProperty::m_shorthandID() method make it transparent
for call sites and return the actual CSSPropertyID of the shorthand. So far 2 bits seems
enough as there is only few longhands with ambiguity and they belong to 3 shorthands.
Profiling the benchmark with Intel Vtune to find out the performance regression
showed that copying uint16_t, so StylePropertyMetadata, is not
a fast operation in term of assembly code and has a big penalty on Windows
MSVC over unsigned for example. The latter produces a much faster code
when using unsigned over uint16_t (45% difference in the benchmark).
The patch avoid the copies of StylePropertyMetadata when applicable (by using const ref).
The second part of the fix is avoiding the conversion from an int (enum) to
an uint16_t in a tight loop such as StylePropertySet::findPropertyIndex
(which is the hotspot of the benchmark).
On my Windows 7 64 bits Core i5 machine CSSPropertySetterGetter results are :
- avg : 2714 runs/s with the patch
- avg : 2696 runs/s without the patch
According to Andreas Kling this patch save up ~1.8Mb on membuster.
No new tests : refactor, old ones should cover.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::addPropertyWithPrefixingVariant):
(WebCore::CSSParser::addProperty):
- css/CSSProperty.cpp:
(WebCore::StylePropertyMetadata::shorthandID):
(WebCore::borderDirections):
- css/CSSProperty.h:
(WebCore::StylePropertyMetadata::StylePropertyMetadata): Use uint16_t type for bitfields so sizeof() returns 2 bytes.
(WebCore::CSSProperty::CSSProperty):
(WebCore::CSSProperty::isSetFromShorthand):
(WebCore::CSSProperty::shorthandID):
- css/StylePropertySet.cpp:
(WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
(WebCore::getIndexInShorthandVectorForPrefixingVariant):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::setPrefixingVariantProperty):
- css/StylePropertySet.h:
(WebCore::StylePropertySet::PropertyReference::shorthandID):
- css/StylePropertyShorthand.cpp:
(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::webkitBorderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::markerShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::transitionShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitAnimationShorthandForParsing):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitFlexShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitGridColumnShorthand):
(WebCore::webkitGridRowShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::widthShorthand):
(WebCore::heightShorthand):
(WebCore::matchingShorthandsForLonghand):
(WebCore::indexOfShorthandForLonghand):
- css/StylePropertyShorthand.h:
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::id):
- css/makeprop.pl:
- 4:06 AM Changeset in webkit [153580] by
-
- 4 edits in trunk/Source/WebKit2
[Qt] Enable QML handling of crashed/unresponsive QtWebProcess
https://bugs.webkit.org/show_bug.cgi?id=108474
Forward the processDidCrash, didRelaunchProcess, processDidBecomeUnresponsive
and processDidBecomeResponsive signals to QML's WebView.experimental.
Patch by Milian Wolff <milian.wolff@kdab.com> on 2013-08-01
Reviewed by Jocelyn Turcotte.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewPrivate::processDidBecomeUnresponsive):
(QQuickWebViewPrivate::processDidBecomeResponsive):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- 2:42 AM Changeset in webkit [153579] by
-
- 62 edits6 adds in trunk/LayoutTests
[Qt] Unreviewed expected pixel test result update after r153522.
- platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png:
- platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png:
- platform/qt-5.0-wk2/compositing/visibility/visibility-simple-video-layer-expected.png:
- platform/qt-5.0-wk2/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-14-d-expected.png:
- platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-24-d-expected.png:
- platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-34-d-expected.png:
- platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-44-d-expected.png:
- platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
- platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
- platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
- platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
- platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Added.
- platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-stacking-expected.png:
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize09-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize10-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize11-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/qt-5.0-wk2/fast/borders/border-image-side-reduction-expected.png:
- platform/qt-5.0-wk2/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
- platform/qt-5.0-wk2/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
- platform/qt-5.0-wk2/svg/custom/createImageElement-expected.png:
- platform/qt-5.0-wk2/svg/custom/createImageElement2-expected.png:
- platform/qt-5.0-wk2/svg/custom/image-parent-translation-expected.png:
- platform/qt-5.0-wk2/svg/custom/js-update-image-and-display-expected.png:
- platform/qt-5.0-wk2/svg/custom/js-update-image-and-display2-expected.png:
- platform/qt-5.0-wk2/svg/custom/js-update-image-and-display3-expected.png:
- platform/qt-5.0-wk2/svg/custom/js-update-image-expected.png:
- platform/qt-5.0-wk2/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/qt-5.0-wk2/svg/custom/pointer-events-image-expected.png:
- platform/qt-5.0-wk2/svg/custom/text-image-opacity-expected.png:
- platform/qt-5.0-wk2/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
- platform/qt-5.0-wk2/svg/hixie/perf/004-expected.png:
- platform/qt-5.0-wk2/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug101674-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug11026-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug1188-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug1296-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug1430-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug2981-2-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug4284-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug4427-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug56563-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug625-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug97383-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/core/bloomberg-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/core/misc-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/other/cell_widths-expected.png:
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- 2:17 AM Changeset in webkit [153578] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r153518.
http://trac.webkit.org/changeset/153518
https://bugs.webkit.org/show_bug.cgi?id=119386
The Jhbuild dep bump of GTK+ is not actually required by
layout testing, is causing pango dep problems (Requested by
zdobersek on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-08-01
- gtk/jhbuild.modules:
- 2:13 AM Changeset in webkit [153577] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 12:33 AM Changeset in webkit [153576] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 12:07 AM Changeset in webkit [153575] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 12:02 AM Changeset in webkit [153574] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
Jul 31, 2013:
- 11:44 PM Changeset in webkit [153573] by
-
- 1 copy in tags/Safari-537.54
New tag.
- 10:55 PM Changeset in webkit [153572] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 10:23 PM Changeset in webkit [153571] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=119283
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Remove duplicated entry.
- 9:41 PM Changeset in webkit [153570] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 9:25 PM Changeset in webkit [153569] by
-
- 2 edits in trunk/LayoutTests
Skip media/track/track-language-preference.html and media/track/track-prefer-captions.html
rather than just marking them as [ Pass Fail ] since they timeout so often and slow
everything down.
- platform/mac/TestExpectations:
- 9:06 PM Changeset in webkit [153568] by
-
- 2 edits in trunk/LayoutTests
Clobbering window.console is not cool because it makes debugging tests
harder.
- media/video-test.js:
(logConsole):
- 8:43 PM Changeset in webkit [153567] by
-
- 2 edits in trunk/LayoutTests
r153462 erroneously unskipped http/tests/multipart/invalid-image-data-standalone.html
so put it back.
- platform/mac/TestExpectations:
- 8:42 PM Changeset in webkit [153566] by
-
- 3 edits in trunk/Source/WebCore
FINALize StyleSheet subclasses.
<http://webkit.org/b/119370>
Reviewed by Anders Carlsson.
CSSStyleSheet and XSLStyleSheet have no further subclasses so make them final.
- css/CSSStyleSheet.h:
- xml/XSLStyleSheet.h:
- 8:34 PM Changeset in webkit [153565] by
-
- 2 edits in trunk/LayoutTests
compositing/patterns/direct-pattern-compositing tests suffer
from colorspace issues that cause image failures on some machines.
- platform/mac/TestExpectations:
- 8:30 PM Changeset in webkit [153564] by
-
- 2 edits in trunk/LayoutTests
media/video-controls-captions-trackmenu.html either crashes,
fails or passes.
- platform/mac/TestExpectations:
- 8:17 PM Changeset in webkit [153563] by
-
- 2 edits in trunk/LayoutTests
Gardening:
webkit.org/b/119374 fast/workers/termination-early.html [ Pass Crash ]
webkit.org/b/119375 fast/workers/worker-call.html [ Failure ]
- platform/mac/TestExpectations:
- 7:20 PM Changeset in webkit [153562] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Page scrolls when width equals device width and initial scale is greater than 0.92
https://bugs.webkit.org/show_bug.cgi?id=119365
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-07-31
Reviewed by Rob Buis.
Internally reviewed by Gen Mak and Konrad Piascik.
JIRA 445423
layoutSize (deviceScreenSize/devicePixelRatio) is FloatSize as devicePixelRatio
is float. We have to round that to IntSize as ScrollView needs IntSize
fixedLayoutSize. Based on conversion result, zoomToFitWidthScale will
hardly equal to zoomToFitHeightScale in this case. And unfortunately
zoomToFitHeightScale is a little bit greater than zoomToFitWidthScale
in this case so that we have to pick up zoomToFitHeightScale which makes
the page scollable horizontally.
The way to fix that is to define an accurate contentsSize area which
potentially has float layoutSize rounding error and can cause upexpected
scroll based on the ideal contentsSize area first, and then don't scroll
only if the scale is zoomToFitScale as "contentsSize > visibleViewportSize"
still works well if the scale is larger than zoomToFitScale.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hasFloatLayoutSizeRoundingError):
- Api/WebPage_p.h:
- WebKitSupport/WebKitThreadViewportAccessor.cpp:
(BlackBerry::WebKit::WebKitThreadViewportAccessor::cannotScrollIfHasFloatLayoutSizeRoundingError):
- WebKitSupport/WebKitThreadViewportAccessor.h:
- 7:17 PM Changeset in webkit [153561] by
-
- 6 edits in trunk/Source/WebCore
Introduce toSVGFontFaceElement, and use it
https://bugs.webkit.org/show_bug.cgi?id=119330
Reviewed by Andreas Kling.
As a step to change static_cast with toSVGXXX, static_cast<SVGFontFaceElement*> can
be changed with toSVGFontFaceElement().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155082
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- svg/SVGFontFaceElement.h:
(WebCore::toSVGFontFaceElement):
- svg/SVGFontFaceFormatElement.cpp:
(WebCore::SVGFontFaceFormatElement::childrenChanged):
- svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::childrenChanged):
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::childrenChanged):
- 6:49 PM Changeset in webkit [153560] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merge r153498.
2013-07-30 Alexey Proskuryakov <ap@apple.com>
REGRESSION(r139282): Fix document leak when selection is created inside the document
https://bugs.webkit.org/show_bug.cgi?id=119122
OK'd by Ryosuke Niwa.
The added test was very flaky. Trying to make it better with a gc() call at the beginning.
- editing/selection/leak-document-with-selection-inside.html:
- 6:34 PM Changeset in webkit [153559] by
-
- 5 edits in trunk/Source/WebCore
Introduce toSVGSMILElement, and use it
https://bugs.webkit.org/show_bug.cgi?id=119260
Reviewed by Darin Adler.
As a step to change static_cast with toSVGXXX, static_cast<SVGSMILElement*> can
be changed with toSVGSMILElement().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155048
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
- svg/animation/SVGSMILElement.h:
(WebCore::toSVGSMILElement):
- 6:31 PM Changeset in webkit [153558] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merge r151893
2013-06-23 Brent Fulgham <bfulgham@gmail.com>
AX: Rebaseline test after r151868
https://bugs.webkit.org/show_bug.cgi?id=117892
Rubber stamped by Chris Fleizach.
- platform/mac/accessibility/lists-expected.txt:
- 6:25 PM Changeset in webkit [153557] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Merge r152847
2013-07-18 Zalan Bujtas <Alan Bujtas>
fullscreen/full-screen-iframe-with-max-width-height.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118820
Reviewed by Andreas Kling.
Don't start the test until after the iframe has finished loading.
- fullscreen/full-screen-iframe-with-max-width-height-expected.txt:
- fullscreen/full-screen-iframe-with-max-width-height.html:
- platform/mac/TestExpectations:
- 6:09 PM Changeset in webkit [153556] by
-
- 9 edits in trunk/Source/JavaScriptCore
More cleanup in PropertySlot
https://bugs.webkit.org/show_bug.cgi?id=119359
Reviewed by Geoff Garen.
m_slotBase is overloaded to store the (receiver) thisValue and the object that contains the property,
This is confusing, and means that slotBase cannot be typed correctly (can only be a JSObject).
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
- No need to ASSERT slotBase is an object.
- jit/JITStubs.cpp:
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- No need to ASSERT slotBase is an object.
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::fillGetterPropertySlot):
- Pass an object through to setGetterSlot.
- runtime/JSObject.h:
(JSC::PropertySlot::getValue):
- Moved from PropertySlot (need to know anout JSObject).
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
- update per member name changes
- runtime/PropertySlot.h:
(JSC::PropertySlot::PropertySlot):
- Argument to constructor set to 'thisValue'.
(JSC::PropertySlot::slotBase):
- This returns a JSObject*.
(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setCustom):
(JSC::PropertySlot::setCacheableCustom):
(JSC::PropertySlot::setCustomIndex):
(JSC::PropertySlot::setGetterSlot):
(JSC::PropertySlot::setCacheableGetterSlot):
- slotBase is a JSObject*, make setGetterSlot set slotBase for consistency.
- runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayEntry::get):
- Pass an object through to setGetterSlot.
- runtime/SparseArrayValueMap.h:
- Pass an object through to setGetterSlot.
- 6:08 PM Changeset in webkit [153555] by
-
- 3 edits in trunk/LayoutTests
Clobbering window.console is not cool
https://bugs.webkit.org/show_bug.cgi?id=119364
Reviewed by Tim Horton.
full-screen-test.js overrides window.console, which is hella
confusing if you're trying to use console.log to debug a fullscreen test.
- fullscreen/full-screen-test.js:
(logConsole):
- fullscreen/resources/not-allowed.html:
- 5:57 PM Changeset in webkit [153554] by
-
- 2 edits in trunk/LayoutTests
Gardening: changing expectation for fast/forms/color/input-color-onchange-event.html
to "Crash Pass" instead of "Skip".
Not reviewed.
- 5:51 PM Changeset in webkit [153553] by
-
- 3 edits4 adds in trunk
Reuse of XMLHttpRequests causes character corruption in response text
https://bugs.webkit.org/show_bug.cgi?id=119358
Reviewed by Anders Carlsson.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/6496e7bb9a0b46bc79032b86d5993b25f127a4cb
Test: http/tests/xmlhttprequest/reopen-encoding.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::didFinishLoading):
LayoutTests:
- http/tests/xmlhttprequest/reopen-encoding-expected.txt: Added.
- http/tests/xmlhttprequest/reopen-encoding.html: Added.
- http/tests/xmlhttprequest/resources/get-utf-8.cgi: Added.
- http/tests/xmlhttprequest/resources/get-windows-1251.cgi: Added.
- 5:28 PM Changeset in webkit [153552] by
-
- 2 edits in trunk/LayoutTests
Bot greening.
Not reviewed.
- TestExpectations:
- Skipping fast/forms/color/input-color-onchange-event.html which will crash with a failed assertion on debug builds. This should be un-skipped when https://bugs.webkit.org/show_bug.cgi?id=119094 is fixed.
- 5:21 PM Changeset in webkit [153551] by
-
- 19 edits in trunk/Source/WebCore
Make ActiveDOMObject overrides private
https://bugs.webkit.org/show_bug.cgi?id=119352
Reviewed by Sam Weinig.
There is no need to call these through derived classes. And it's quite harmful for
anyone except for ScriptExecutionContext to call suspend/resume in particular -
ScriptExecutionContext won't know, and it will try to manage the state on its own.
- Modules/filesystem/DOMFileSystem.h:
- Modules/filesystem/FileWriter.h:
- Modules/geolocation/Geolocation.h:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.h:
- Modules/mediasource/MediaSource.h:
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationCenter.h:
- Modules/websockets/WebSocket.h:
- fileapi/FileReader.h:
- html/HTMLMediaElement.h:
- html/canvas/WebGLRenderingContext.h:
- page/DOMTimer.h:
- page/EventSource.h:
- page/SuspendableTimer.h:
- workers/AbstractWorker.h:
- xml/XMLHttpRequest.h:
- 5:10 PM Changeset in webkit [153550] by
-
- 3 edits in trunk/Tools
W3C test import script prefixes some properties that it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=119357
Reviewed by Dirk Pranke.
Some prefixed properties also have unprefixed implemetations, but when
the implementations aren't identical, they aren't declared in
CSSPropertyNames.in on the same line. This fixes the import script so
that it catches all instances of prefixed properties that have an
unprefixed variant, and does not add the prefix in those cases.
- Scripts/webkitpy/w3c/test_converter.py:
(W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
the properties on every line and record if they are prefixed or not.
Use this information to only return prefixed properties that do not
have any unprefixed variant. The prefixed property list has also
changed to not include the '-webkit-' prefix, making it much easier to
do the comparison, and removing the need to remove the prefix later.
(W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
longer needs to remove the '-webkit-' prefix, but needs to add it in
the case where a property that needs a prefix is found.
- Scripts/webkitpy/w3c/test_converter_unittest.py:
(W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
for '-webkit-' prefix, as it is no longer included in the properties
in the prefixed property list.
- 5:06 PM Changeset in webkit [153549] by
-
- 6 edits in trunk/Source
Remove didFinishLoad order quirk
https://bugs.webkit.org/show_bug.cgi?id=119354
<rdar://problem/11510686>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Remove the quirk.
- page/Settings.in:
Remove the setting controlling the quirk.
Source/WebKit/mac:
- Misc/WebKitVersionChecks.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Don't set the now-removed preference.
- 5:03 PM Changeset in webkit [153548] by
-
- 3 edits in trunk/Source/WebCore
Replace CRASH() on overflow with Checked<>
https://bugs.webkit.org/show_bug.cgi?id=119327
Reviewed by Oliver Hunt.
Use a checked type that allows us to automate bound checks. We use a
non-recording Checked<> to keep the behavior.
No behavior change, no new tests needed.
- dom/Text.cpp:
(WebCore::Text::wholeText):
- platform/audio/AudioArray.h:
(WebCore::AudioArray::allocate):
- 4:57 PM Changeset in webkit [153547] by
-
- 4 edits in trunk/Source/JavaScriptCore
Reduce JSC API static value setter/getter overhead.
https://bugs.webkit.org/show_bug.cgi?id=119277
Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-07-31
Reviewed by Geoffrey Garen.
Add property name to the static value entry, so that OpaqueJSString::create() doesn't
need to get called every time when set or get the static value.
- API/JSCallbackObjectFunctions.h:
(JSC::::put):
(JSC::::putByIndex):
(JSC::::getStaticValue):
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
- API/JSClassRef.h:
(StaticValueEntry::StaticValueEntry):
- 4:54 PM Changeset in webkit [153546] by
-
- 13 edits in trunk/Source
Use emptyString instead of String("")
https://bugs.webkit.org/show_bug.cgi?id=119335
Reviewed by Darin Adler.
Use emptyString() instead of String("") because it is better style and
faster. This is a followup to r116908, removing all occurrences of
String("") from WebKit.
Source/JavaScriptCore:
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncCompile):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
Source/WebCore:
No behavior change, no new tests needed.
- platform/graphics/blackberry/LayerAnimation.h:
(WebCore::LayerAnimation::name):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::textFromEvent):
(WebCore::unmodifiedTextFromEvent):
(WebCore::keyIdentifierForKeyEvent):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::userAgent):
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::runJavaScriptPrompt):
Source/WebKit2:
- Shared/mac/WebEventFactory.mm:
(WebKit::textFromEvent):
(WebKit::unmodifiedTextFromEvent):
- 4:21 PM Changeset in webkit [153545] by
-
- 3 edits in trunk/Tools
Update location of w3c shapes tests to reflect new import location
https://bugs.webkit.org/show_bug.cgi?id=118156
Reviewed by Dirk Pranke.
Partial imports should not be imported to the same place as the full
import, so this adds an option to allow importing to a different
location than the default. In doing that, I found that imports from
contributor directories didn't seem to be working correctly, so I
updated the import to be smarter about both contributor directories
and the test status directories. It should now be more likely that the
script guesses the root directory properly.
- Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
script not working with the full set of contributors, as that is
no longer true, and I didn't see a good way to keep that behavior.
Also update documentation to properly explain what happens when a
contributor dir is imported.
(main): Attempt to find the proper repo dir by looking at the
directory above the "test status" in the given path, this is still
not exactly right, but is less error prone than just trimming.
(parse_args): Add -d option to set the import directory.
(TestImporter.init): Stop appending the subdirs to the
destination_directory because it was making things more complex
and isn't really needed.
(TestImporter.update_test_status): Remove hardcoded strings and use
the TEST_STATUS constants instead.
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
support for new option.
(TestImporterTest.test_import_dir_with_no_tests): Ditto.
- 4:08 PM Changeset in webkit [153544] by
-
- 2 edits in trunk/Tools
[Windows] Winlauncher shouldn't look for Safari Install Directory
https://bugs.webkit.org/show_bug.cgi?id=119351
Reviewed by Darin Adler.
- win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
the Safari install location. Instead, use the proper support
library path for the build architecture.
- 2:09 PM Changeset in webkit [153543] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
Convert SVG test from r153433 to a reftest
https://bugs.webkit.org/show_bug.cgi?id=119346
Reviewed by Philip Rogers.
Reftest taken from https://chromium.googlesource.com/chromium/blink/+/ac10e305a870c8fd500b42e90075aee3aa48da8d.
- platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt: Removed.
- svg/animations/attributeNameAndAttributeTypeMismatch-expected.html: Added.
- svg/animations/attributeNameAndAttributeTypeMismatch.html: Added.
- svg/animations/attributeNameAndAttributeTypeMissmatch.svg: Removed.
- 2:04 PM Changeset in webkit [153542] by
-
- 1 edit5 adds in trunk/Websites/webkit.org
Upload images for a potential blog post
- blog-files/size-matters: Added.
- blog-files/size-matters/JavaScript-growth.png: Added.
- blog-files/size-matters/WebCore-growth-baseline.png: Added.
- blog-files/size-matters/WebCore-growth.png: Added.
- blog-files/size-matters/WebKit-growth.png: Added.
- 1:47 PM Changeset in webkit [153541] by
-
- 34 edits2 adds in trunk
<input type=color> Mac UI behaviour
<rdar://problem/10269922> and https://bugs.webkit.org/show_bug.cgi?id=61276
Source/JavaScriptCore:
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.
- Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
Source/WebCore:
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.
This patch turns on INPUT_TYPE_COLOR and implements it using the native
Mac color panel.
No new tests added.
Currently, there are no automated ways to test the types of changes made in this patch. (i.e. checking
which color is being displayed in the color panel, checking which color element is currently
associated to the color panel, checking the state of color elements after directing away and
being directed back to its page, etc.)
- Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- html/ColorInputType.cpp:
(WebCore::ColorInputType::handleDOMActivateEvent): Reattaches the color picker if
a color picker has already been shown for an element
(WebCore::ColorInputType::shouldResetOnDocumentActivation): Always returns true, needed to
detach the color picker when caching a page.
- html/ColorInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::documentDidResumeFromPageCache): For <input type='color'>,
don't reset the element.
(WebCore::HTMLInputElement::documentWillSuspendForPageCache): For <input type='color'>, call detach().
- html/HTMLInputElement.h:
- platform/ColorChooser.h:
(WebCore::ColorChooser::reattachColorChooser): Added definition.
Source/WebKit/mac:
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.
- Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createColorPicker): Added stub implementation.
Source/WebKit2:
Implemented <input type='color'> on Mac using the native color picker.
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.
Code for WebColorPickerMac is derived from Chromium's color_chooser_mac.mm:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/cocoa/color_chooser_mac.mm
- Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createColorPicker): Replaced stub implementation
and return a WebColorPickerMac object.
- UIProcess/WebColorPicker.cpp:
(WebKit::WebColorPicker::invalidate): Updated to call endChooser().
(WebKit::WebColorPicker::showColorPicker): Added stub implementation.
- UIProcess/WebColorPicker.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Removed invalidation of removed color picker objects.
(WebKit::WebPageProxy::showColorPicker): Updated so that it works for
multiple <input type='color'> elements on a page.
(WebKit::WebPageProxy::didEndColorPicker): Removed cleanup of removed color picker objects.
(WebKit::WebPageProxy::resetStateAfterProcessExited): Removed cleanup of removed color picker objects.
- UIProcess/mac/WebColorPickerMac.h: Added.
- UIProcess/mac/WebColorPickerMac.mm: Added.
(WebKit::WebColorPickerMac::create):
(WebKit::WebColorPickerMac::~WebColorPickerMac):
(WebKit::WebColorPickerMac::WebColorPickerMac):
(WebKit::WebColorPickerMac::endPicker):
(WebKit::WebColorPickerMac::setSelectedColor):
(WebKit::WebColorPickerMac::didChooseColor):
(WebKit::WebColorPickerMac::showColorPicker):
WebColorPickerMac contains a reference to a WKColorPanelMac object
and is responsible for maintaining the color picker UI.
(-[WKColorPanelMac setAndShowPicker:withColor:]):
(-[WKColorPanelMac invalidate]):
(-[WKColorPanelMac windowWillClose:]):
(-[WKColorPanelMac didChooseColor:]):
(-[WKColorPanelMac setColor:]):
WKColorPanelMac is a wrapper for a NSColorPanel object and
is responsible for the color picker UI.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createColorChooser): Updated to always create a
WebColorChooser object.
- WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::reattachColorChooser): Sets the page's
active color chooser to the current object and pings the UIProcess
to show the color picker.
(WebKit::WebColorChooser::setSelectedColor): Only sets the color in the
color picker if the WebColorChooser object is the active color element.
- WebProcess/WebCoreSupport/WebColorChooser.h:
Source/WTF:
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.
- wtf/FeatureDefines.h: Enabled INPUT_TYPE_COLOR on Mac port.
LayoutTests:
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
Reviewed by Brady Eidson.
Updated tests to reflect <input type='color'> being implemented with a native color picker.
- fast/forms/color/input-color-onchange-event-expected.txt:
- platform/mac/TestExpectations: Enabled fast/form/color tests on Mac.
- platform/mac/accessibility/color-well-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- platform/mac/fast/forms/color/input-appearance-color-expected.txt: Updated test expectations
on Mac to reflect the fact that the list attribute for <input type='color'> is not yet supported.
- 1:24 PM Changeset in webkit [153540] by
-
- 3 edits3 adds in trunk
DFG doesn't account for inlining of functions with switch statements that haven't been executed by the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=119349
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Prior to this patch, the baseline JIT was responsible for resizing the ctiOffsets Vector for
SimpleJumpTables to be equal to the size of the branchOffsets Vector. The DFG implicitly relied
on code it compiled with any switch statements to have been run in the baseline JIT first.
However, if the DFG chooses to inline a function that has never been compiled by the baseline
JIT then this resizing never happens and we crash at link time in the DFG.
We can fix this by also doing the resize in the DFG to catch this case.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
LayoutTests:
- fast/js/dfg-inline-switch-imm-expected.txt: Added.
- fast/js/dfg-inline-switch-imm.html: Added.
- fast/js/script-tests/dfg-inline-switch-imm.js: Added.
(foo):
(bar):
- 12:55 PM Changeset in webkit [153539] by
-
- 5 edits2 copies in branches/safari-537-branch
Merged r153511. <rdar://problem/14213012>
- 12:51 PM Changeset in webkit [153538] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r153487. <rdar://problem/14502050>
- 12:32 PM Changeset in webkit [153537] by
-
- 3 edits in trunk/Source/JavaScriptCore
Speculative Windows build fix.
Reviewed by NOBODY
- runtime/JSString.cpp:
(JSC::JSRopeString::getIndexSlowCase):
- runtime/JSString.h:
- 12:27 PM Changeset in webkit [153536] by
-
- 3 edits in trunk/LayoutTests
RenderEmbeddedObject::isReplacementObscured is wrong if an obscuring element has pointer-events: none set
https://bugs.webkit.org/show_bug.cgi?id=119348
Reviewed by Dean Jackson.
Change the expected outcome of the test to want a visually-obscured
but clickable embed (because the obscuring element has pointer-events: none)
to be considered obscured.
Also, adjust the test so that it runs all of the subtests even if
some of them fail.
- plugins/unavailable-plugin-indicator-obscurity-expected.txt:
- plugins/unavailable-plugin-indicator-obscurity.html:
- 12:26 PM Changeset in webkit [153535] by
-
- 9 edits in trunk/Tools
Update scripts to reference contributors.json instead of committers.py in messaging
https://bugs.webkit.org/show_bug.cgi?id=119342
Reviewed by Ryosuke Niwa.
Change the scripts to point people to contributors.json instead of
committers.py since the latter no longer contains the list of
contributors.
- Scripts/webkitpy/common/config/committervalidator.py:
(CommitterValidator._contributors_json_path):
(CommitterValidator._flag_permission_rejection_message):
- Scripts/webkitpy/common/config/committervalidator_unittest.py:
(CommitterValidatorTest.test_flag_permission_rejection_message):
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._commit_queue_flag):
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
(WatchListParser._validate):
- Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
(WatchListParserTest.test_cc_rule_with_invalid_email):
- Scripts/webkitpy/tool/bot/feeders_unittest.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
(ValidateReviewer.run):
- 12:22 PM Changeset in webkit [153534] by
-
- 2 edits in trunk/Tools
Unreviewed. Re-enable WinEWS tests following r153527.
- Scripts/webkitpy/common/config/ews.json:
- 12:20 PM Changeset in webkit [153533] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/editing/selection/move-left-right-expected.txt:
- 12:03 PM Changeset in webkit [153532] by
-
- 80 edits in trunk/Source
Some cleanup in JSValue::get
https://bugs.webkit.org/show_bug.cgi?id=119343
Reviewed by Geoff Garen.
Source/JavaScriptCore:
JSValue::get is implemented to:
1) Check if the value is a cell – if not, synthesize a prototype to search,
2) call getOwnPropertySlot on the cell,
3) if this returns false, cast to JSObject to get the prototype, and walk the prototype chain.
By all rights this should crash when passed a string and accessing a property that does not exist, because
the string is a cell, getOwnPropertySlot should return false, and the cast to JSObject should be unsafe.
To work around this, JSString::getOwnPropertySlot actually implements 'get' functionality - searching the
prototype chain, and faking out a return value of undefined if no property is found.
This is a huge hazard, since fixing JSString::getOwnPropertySlot or calling getOwnPropertySlot on cells
from elsewhere would introduce bugs. Fortunately it is only ever called in this one place.
The fix here is to move getOwnPropertySlot onto JSObjecte and end this madness - cells don't have property
slots anyway.
Interesting changes are in JSCJSValueInlines.h, JSString.cpp - the rest is pretty much all JSCell -> JSObject.
Source/WebCore:
- WebCore.exp.in:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
- bridge/objc/objc_runtime.h:
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
- bridge/runtime_array.h:
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::getOwnPropertySlot):
- bridge/runtime_method.h:
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
- bridge/runtime_object.h:
- getOwnPropertySlot, JSCell -> JSObject
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertySlot):
- WebProcess/Plugins/Netscape/JSNPObject.h:
- getOwnPropertySlot, JSCell -> JSObject
- 11:48 AM Changeset in webkit [153531] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r153406): DOM intervals are not properly restarted when resumed
https://bugs.webkit.org/show_bug.cgi?id=119345
Reviewed by Sam Weinig.
- page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Call base class version of repeatInterval(), not our version that will just return the current value of m_savedRepeatInterval in this situation.
- 11:44 AM Changeset in webkit [153530] by
-
- 2 edits in trunk/Source/WebCore
Avoid calling nextRenderer() in some cases
https://bugs.webkit.org/show_bug.cgi?id=119313
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/3207cfda52082f4fd6a04c7819c18a980de58beb.
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
- 11:41 AM Changeset in webkit [153529] by
-
- 8 edits in trunk/Source/WebCore
Convert most callers of setInlineStyleProperty passing strings to enums or doubles instead
https://bugs.webkit.org/show_bug.cgi?id=119304
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/8157dd9381716759f183fabbfed29c52962be746
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setFontSize):
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
(WebCore::TextTrackCueGeneric::setFontSize):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- 11:18 AM Changeset in webkit [153528] by
-
- 27 edits in trunk/LayoutTests
[CSS Shapes] Stop using internals in shape-outside tests
https://bugs.webkit.org/show_bug.cgi?id=119229
Reviewed by Alexandru Chiculita.
We no longer need to use window.internals for shape-outside, since it
is enabled by default on ports where it is compiled in. To make the
w3c spec test cleaner, that reference has been removed from all of the
tests.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html:
- csswg/submitted/shapes/shape-outside/w3c-import.log:
- 11:03 AM Changeset in webkit [153527] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] JavaScript crash.
https://bugs.webkit.org/show_bug.cgi?id=119339
Reviewed by Mark Hahnenberg.
- jit/JITStubsX86.h: Implement ctiVMThrowTrampoline and
ctiVMThrowTrampolineSlowpath the same way as the gcc x86 version does.
- 10:47 AM Changeset in webkit [153526] by
-
- 1 edit2 adds in trunk/LayoutTests
Test assignment to indexed window properties
https://bugs.webkit.org/show_bug.cgi?id=119307
Reviewed by Geoffrey Garen.
Merge https://chromium.googlesource.com/chromium/blink/+/bdeca10fa79477f669cab1e5b081a480e743fd3f
- http/tests/security/xss-DENIED-window-index-assign-expected.txt: Added.
- http/tests/security/xss-DENIED-window-index-assign.html: Added.
- 9:52 AM Changeset in webkit [153525] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test to ensure SelectElement removes an option when null is assigned by indexed setter
https://bugs.webkit.org/show_bug.cgi?id=119311
Reviewed by Alexey Proskuryakov.
Merge a test in https://chromium.googlesource.com/chromium/blink/+/da5c8d908b87f75c5ba3d1457c2353642e999963
even though the regression never existed in WebKit.
- fast/forms/select/select-assign-null-expected.txt: Added.
- fast/forms/select/select-assign-null.html: Added.
- 9:24 AM Changeset in webkit [153524] by
-
- 2 edits in trunk/Tools
Unreviewed: Adding myself to the committers' list.
- Scripts/webkitpy/common/config/contributors.json:
- 9:08 AM Changeset in webkit [153523] by
-
- 2 edits in trunk/Source/WebCore
[Coordinated Graphics] Use m_ prefix only for member variable
https://bugs.webkit.org/show_bug.cgi?id=119250
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-31
Reviewed by Noam Rosenthal.
WebKit coding style suggests to use m_ prefix only for data members.
This patch also removes unnecessary copy by passing const-reference
parameter values.
- platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:
(WebCore::CoordinatedCustomFilterProgram::create):
- 7:39 AM Changeset in webkit [153522] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Images are down-scaled badly
https://bugs.webkit.org/show_bug.cgi?id=119263
Reviewed by Jocelyn Turcotte.
QPainter only does bilinear filtering, which means it will downscaling beyond
0.5x will start skipping pixel and start to degrade the end result. Scaling in
QImage and QPixmap however uses a better but much more expensive sampling that
counts all pixels.
To get the high quality downscaling we must therefore prescale the images before
painting them. To avoid a performance impact on repeated paints the prescaled
image are saved in the QPixmapCache.
- platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):
- 7:35 AM Changeset in webkit [153521] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Remove flaky tests from TestExpectations.
- platform/gtk/TestExpectations: Remove tests no longer flaky after
webkit.org/b/100688 was fixed in r140166.
- 6:09 AM Changeset in webkit [153520] by
-
- 6 edits in trunk
[Qt] Build WebKit with C++11
https://bugs.webkit.org/show_bug.cgi?id=119337
Reviewed by Csaba Osztrogonác.
Source/WebKit2:
We no longer need to enable C++11 specifically for WebKit2.
- WebKit2.pri:
Tools:
Enable building with C++11.
- qmake/mkspecs/features/default_pre.prf:
- qmake/mkspecs/features/unix/default_post.prf:
- qmake/mkspecs/features/unix/default_pre.prf:
- 5:49 AM Changeset in webkit [153519] by
-
- 2 edits in trunk/Tools
[Qt] ASSERTS trigger in release builds
https://bugs.webkit.org/show_bug.cgi?id=119336
Reviewed by Jocelyn Turcotte.
Ensure the qmake also defaults to release if no configuration is known.
- qmake/mkspecs/features/default_post.prf:
- 5:42 AM Changeset in webkit [153518] by
-
- 2 edits in trunk/Tools
[texmap][GStreamer][GTK] composited video shows tearing
https://bugs.webkit.org/show_bug.cgi?id=118253
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
- 5:12 AM Changeset in webkit [153517] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt][WK1] navigator.plugins shows too few entries.
https://bugs.webkit.org/show_bug.cgi?id=119332
Reviewed by Jocelyn Turcotte.
Based on input by Choon Sik Cho.
PlatformStrategiesQt::getPluginInfo was using the
WTF::Vector::resize method wrongly.
This patch removes the call to Vector::resize as
Vector::append will take care of increasing capacity
if needed.
- WebCoreSupport/PlatformStrategiesQt.cpp:
(PlatformStrategiesQt::getPluginInfo):
- 4:56 AM Changeset in webkit [153516] by
-
- 5 edits6 adds in trunk/Source
[Qt] Add interface API for origin whitelisting
https://bugs.webkit.org/show_bug.cgi?id=117823
Patch by Deepjyoti Saha <deesaha@cisco.com> on 2013-07-31
Reviewed by Jocelyn Turcotte.
Adding interface APIs in QWebSecurityOrigin to add and remove whiteList entires.
Re-used most of the test cases written by Carol Szabo <carol.szabo@nokia.com>
for https://bugs.webkit.org/show_bug.cgi?id=31875 and added the same.
- Api/qwebsecurityorigin.cpp:
(QWebSecurityOrigin::addAccessWhitelistEntry):
(QWebSecurityOrigin::removeAccessWhitelistEntry):
- Api/qwebsecurityorigin.h:
- tests/qwebsecurityorigin: Added.
- tests/qwebsecurityorigin/qwebsecurityorigin.pro: Added.
- tests/qwebsecurityorigin/resources: Added.
- tests/qwebsecurityorigin/resources/test.html: Added.
- tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp: Added.
(tst_QWebSecurityOrigin::tst_QWebSecurityOrigin):
(tst_QWebSecurityOrigin::~tst_QWebSecurityOrigin):
(tst_QWebSecurityOrigin::init):
(tst_QWebSecurityOrigin::cleanup):
(tst_QWebSecurityOrigin::whiteList_data):
(tst_QWebSecurityOrigin::whiteList):
- tests/qwebsecurityorigin/tst_qwebsecurityorigin.qrc: Added.
- 2:44 AM Changeset in webkit [153515] by
-
- 6 edits in trunk/Source/WebCore
Remove guessesVector param from isUngrammatical
https://bugs.webkit.org/show_bug.cgi?id=119241
Reviewed by Ryosuke Niwa.
TextCheckingHelper::isUngrammatical(Vector<String>& guessesVector) doesn't return
guesses for ungrammatical phrases through its parameter.
Editor::isSelectionUngrammatical() uses it to check whether the selection
is ungrammatical.
r71009 showed that isUngrammatical(Vector<String>& guessesVector) had not supported
grammar guesses.
The grammar guesses can be retrieved by guessesForMisspelledOrUngrammaticalRange
when UNIFIED_TEXT_CHECKING is on.
No new tests, this is dead code due to no WebKit port implements grammar using
legacy text checker.
- WebCore.exp.in: Removed ZN7WebCore6Editor32guessesForUngrammaticalSelectionEv.
- editing/Editor.cpp:
(WebCore::Editor::isSelectionUngrammatical):
(WebCore::Editor::guessesForMisspelledOrUngrammatical):
- editing/Editor.h: Removed guessesForUngrammaticalSelection. Dead code.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::isUngrammatical):
- editing/TextCheckingHelper.h:
- 1:12 AM Changeset in webkit [153514] by
-
- 3 edits in trunk/Source/WTF
Shrink Vectors with inline capacity.
<http://webkit.org/b/119295>
<rdar://problem/14598360>
Reviewed by Anders Carlsson.
Pack Vector::m_size next to VectorBufferBase::m_capacity so there's no space wasted
on padding when sizeof(T) >= 8. Since m_size is not conceptually part of the buffer,
I just using'ed it into Vector.
- wtf/SizeLimits.cpp:
- wtf/Vector.h:
(WTF::VectorBufferBase::VectorBufferBase):
(WTF::VectorBuffer::VectorBuffer):
(WTF::Vector::Vector):
(WTF::::Vector):
- 1:06 AM Changeset in webkit [153513] by
-
- 3 edits in trunk/Source/WebCore
Unnecessary const_cast<TextCheckingHelper*>(this)->findFirstBadGrammar
https://bugs.webkit.org/show_bug.cgi?id=119244
Reviewed by Ryosuke Niwa.
Added missing const modifier to findFirstBadGrammar (and findFirstGrammarDetail
respectively) to call it in 'isUngrammatical() const' without const casting.
No new tests, no behavior change.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
Added const.
(WebCore::TextCheckingHelper::isUngrammatical):
Now const_cast can be removed.
- editing/TextCheckingHelper.h:
- 12:23 AM Changeset in webkit [153512] by
-
- 3 edits in trunk/Source/WebCore
findFirstGrammarDetail doesn't need to be exposed.
https://bugs.webkit.org/show_bug.cgi?id=119249
Reviewed by Darin Adler.
Make TextCheckingHelper::findFirstGrammarDetail private.
Remove badGrammarPhraseLength param. It's not used any longer.
No new tests, no behavior change.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
- editing/TextCheckingHelper.h:
