⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 5, 2013:

11:45 PM Changeset in webkit [153742] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebGL] validateRenderingState method name change
​https://bugs.webkit.org/show_bug.cgi?id=119485

According to validateRenderingState method functionality its name should be
changed. This method validates only vertex attributes.

Patch by Przemyslaw Szymanski <​p.szymanski3@samsung.com> on 2013-08-05
Reviewed by Dean Jackson.

No new tests. Covered by existing tests. No changes in functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateVertexAttributes):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):

  • html/canvas/WebGLRenderingContext.h:
11:21 PM Changeset in webkit [153741] by dino@apple.com
  • 1 edit in trunk/Websites/webkit.org/demos/srcset/index.html

Forgot to add alt text to the example image :(

  • demos/srcset/index.html:
11:01 PM Changeset in webkit [153740] by dino@apple.com
  • 1 edit
    4 moves
    1 add in trunk/Websites/webkit.org

Move previous commit into /demos.

  • demos/srcset/image-1x.png: Renamed from Websites/webkit.org/blog-files/srcset/image-1x.png.
  • demos/srcset/image-2x.png: Renamed from Websites/webkit.org/blog-files/srcset/image-2x.png.
  • demos/srcset/image-src.png: Renamed from Websites/webkit.org/blog-files/srcset/image-src.png.
  • demos/srcset/index.html: Renamed from Websites/webkit.org/blog-files/srcset/index.html.
8:16 PM Changeset in webkit [153739] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit/win

Another Windows release build fix.

  • WebKitLogging.cpp: Wrap the implementation file in !LOG_DISABLED #if's too.
8:10 PM Changeset in webkit [153738] by mrowe@apple.com
  • 2 edits in trunk/Source/WTF

Build fix for Windows.

  • wtf/Assertions.cpp: Include StringExtras.h rather than StdLibExtras.h, since the former is where

strncasecmp is declared.

8:03 PM Changeset in webkit [153737] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit/win

Build fix for Windows release build.

  • WebKitLogging.h: Wrap things in !LOG_DISABLED so that we don't attempt to use macros that have not been defined.
7:53 PM Changeset in webkit [153736] by mrowe@apple.com
  • 44 edits
    1 delete in trunk/Source

Logging should be configurable using human-readable channel names rather than crazy bitmasks
<​http://webkit.org/b/119031>

Implement shared logic for initializing logging channels based on human-readable channel names in WTF,
and rework the WebCore, WebKit and WebKit2 logging initialization on top of it.

Logging channels may now be enabled by providing a comma-separated list of channel names, with the special
"all" name enabling all channels. Channel names prefixed with a leading "-" will result in the named channel
being disabled. For instance, specifying "all,-history,-loading" will result in all logging channels except
for history and loading being enabled.

For OS X developers, this also changes the name of the user defaults used to enable logging. This is done to allow
the old user defaults to remain set for those people that need to switch between version of WebKit before and
after this change. Where the old user default keys were WebCoreLogLevel, WebKitLogLevel and WebKit2LogLevel,
the new user default keys are WebCoreLogging, WebKitLogging and WebKit2Logging.

For GTK developers, this changes the separator used in the WEBKIT_DEBUG environment variable to a comma for
consistency with the other platforms and to enable more code sharing.

While doing this work I've also taken the opportunity to eliminate the need to touch multiple files when
adding a new logging channel. Now only the header in the relevant project needs to be updated.

Reviewed by Sam Weinig.

Source/WebCore:

  • GNUmakefile.list.am: Remove the now-unused InitializeLogging.h
  • Target.pri: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/InitializeLogging.h: Removed. Ditto.
  • platform/Logging.cpp: Use WEBCORE_LOG_CHANNELS to define all of the channels.

(WebCore::logChannelByName): Renamed to match our naming conventions. Calls through to the new WTF function
to find a log channel rather than repeating the names of the log channels a further two times each.
(WebCore::initializeLoggingChannelsIfNecessary): Pass the channels and the log level string to the new
WTF function that handles the initialization.

  • platform/Logging.h: Declare a WEBCORE_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

  • platform/blackberry/LoggingBlackBerry.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable.

  • platform/efl/LoggingEfl.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable, and then prepend
NotYetImplemented to it so that that channel will be enabled by default.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink): Accommodate the rename to logChannelByName.

  • platform/gtk/LoggingGtk.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable, and then prepend
NotYetImplemented to it so that that channel will be enabled by default.

  • platform/mac/LoggingMac.mm:

(WebCore::logLevelString): Pull the value out of the WebCoreLogging user default key.

  • platform/qt/LoggingQt.cpp:

(WebCore::logLevelString): Pull the value out of the QT_WEBKIT_LOG environment variable, and then prepend
NotYetImplemented to it so that the channel will be enabled by default.

  • platform/win/LoggingWin.cpp:

(WebCore::logLevelString): Pull the value out of the WebCoreLogging environment variable.

Source/WebKit/blackberry:

  • Api/BlackBerryGlobal.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/efl:

  • ewk/ewk_main.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/gtk:

  • webkit/webkitglobals.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/mac:

  • Misc/WebKitLogging.h: Declare a WEBKIT_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

  • Misc/WebKitLogging.m: Use WEBKIT_LOG_CHANNELS to define all of the channels. Pass the channels and the

preference value to the new WTF function that handles the initialization.

  • WebView/WebPreferenceKeysPrivate.h: Remove a key that does not need to be here.
  • WebView/WebView.mm: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/qt:

  • WebCoreSupport/InitWebCoreQt.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/win:

  • WebKitLogging.cpp: Declare a WEBKIT_LOG_CHANNELS macro that can be used to apply a preprocessor macro across

the set of all logging channels. Use this macro to declare the logging channels.

  • WebKitLogging.h: Use WEBKIT_LOG_CHANNELS to define all of the channels. Pass the channels to the new WTF

function that handles the initialization. As per the previous implementation a developer needs to hard-code
their desired log level here.

  • WebView.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit2:

  • NetworkProcess/NetworkProcess.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.
  • Platform/Logging.cpp: Use WEBKIT2_LOG_CHANNELS to define all of the channels.

(WebKit::initializeLogChannelsIfNecessary): Pass the channels and the log level string to the new WTF function
that handles the initialization.
(WebKit::logChannelByName): Renamed to match our naming conventions. Calls through to the new WTF function
to find a log channel rather than repeating the names of the log channels a further two times each.
(WebKit::logLevelString): Provide a no-op implementation.

  • Platform/Logging.h: Declare a WEBKIT2_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

  • Platform/efl/LoggingEfl.cpp:

(WebKit::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable.

  • Platform/gtk/LoggingGtk.cpp:

(WebKit::logLevelString): Ditto.

  • Platform/mac/Logging.mac.mm:

(WebKit::logLevelString): Pull the value out of the WebKit2Logging user default key.

  • Platform/qt/LoggingQt.cpp:

(WebKit::logLevelString): Pull the value out of the QT_WEBKIT_LOG environment variable.

  • Shared/WebKit2Initialize.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.
  • UIProcess/WebContext.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WTF:

  • wtf/Assertions.cpp:

(WTFLogChannelByName): Iterate over the provided array of log channels, returning the first whose name
matches case-insensitively.
(setStateOfAllChannels): Helper function to set the state of all channels to a single value.
(WTFInitializeLogChannelStatesFromString): Parse a string containing a case-insensitive, comma-separated list
of channel names to enable or disable, with the latter being prefixed by a "-".

  • wtf/Assertions.h: Update the layout of WTFLogChannel to include only the state of the channel and its name.

Declare WTFLogChannelByName and WTFInitializeLogChannelStatesFromString.

  • wtf/RefCountedLeakCounter.cpp: Update to the new format of WTFLogChannel.
7:03 PM Changeset in webkit [153735] by dino@apple.com
  • 1 edit
    5 adds in trunk/Websites/webkit.org

Upload example for a blog post.

  • blog-files/srcset/image-1x.png: Added.
  • blog-files/srcset/image-2x.png: Added.
  • blog-files/srcset/image-src.png: Added.
  • blog-files/srcset/index.html: Added.
7:02 PM Changeset in webkit [153734] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers
​https://bugs.webkit.org/show_bug.cgi?id=119501

Reviewed by Enrica Casucci.

Exit early in updateMarkersForWordsAffectedByEditing before calling startOfWord and endOfWord if there are no document markers.

  • dom/DocumentMarkerController.h:

(WebCore::DocumentMarkerController::hasMarkers): Added.

  • editing/Editor.cpp:

(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

6:13 PM Changeset in webkit [153733] by dino@apple.com
  • 9 edits
    2 adds in trunk

Update HTMLPreloadScanner to handle img srcset
​https://bugs.webkit.org/show_bug.cgi?id=119360

Reviewed by Sam Weinig.

This patch is a merge of similar patches from Yoav Weiss <​yoav@yoav.ws>
and Dean Jackson.

Source/WebCore:

Test: fast/preloader/image-srcset.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Move srcset parsing into
HTMLParserIdioms, and call it when we hit src or srcset.

  • html/HTMLImageElement.h: Remove code that was moved to HTMLParserIdioms.
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer): Pass device scale into preloader.
(WebCore::HTMLDocumentParser::insert):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner): Takes device scale as a parameter.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): Resolve between src and srcSet if necessary.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Add support for srcset attribute.
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): New flag to indicate if we should
replace any existing value.
(WebCore::TokenPreloadScanner::TokenPreloadScanner): Takes device scale.
(WebCore::TokenPreloadScanner::scanCommon): Pass device scale.
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):

  • html/parser/HTMLPreloadScanner.h: New attribute to constructor for device scale. New member

variable on TokenPreloadScanner that holds the srcset value.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::ImageWithScale::operator==): Used for sorting.
(WebCore::compareByScaleFactor): Used for sorting.
(WebCore::bestFitSourceForImageAttributes): New method that takes the code from HTMLImageElement
for parsing src and srcset attributes, and finding the best match.

  • html/parser/HTMLParserIdioms.h:

LayoutTests:

New test to make sure the HTML preloader takes the
value of srcset if available.

  • fast/preloader/image-srcset-expected.txt: Added.
  • fast/preloader/image-srcset.html: Added.
5:41 PM Changeset in webkit [153732] by achristensen@apple.com
  • 7 edits
    1 add in trunk/Source/ThirdParty/ANGLE

Added optimizations to Windows ANGLE builds.
​https://bugs.webkit.org/show_bug.cgi?id=119500

Reviewed by Brent Fulgham.

  • ANGLE.vcxproj/ANGLERelease.props: Added.
  • ANGLE.vcxproj/libEGL.vcxproj:
  • ANGLE.vcxproj/libGLESv2.vcxproj:
  • ANGLE.vcxproj/preprocessor.vcxproj:
  • ANGLE.vcxproj/translator_common.vcxproj:
  • ANGLE.vcxproj/translator_glsl.vcxproj:
  • ANGLE.vcxproj/translator_hlsl.vcxproj:

Use ANGLERelease.props for Release, Release_WinCairo, and Production configurations.

5:39 PM Changeset in webkit [153731] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebKit

Gardening: fix build after r153728.

Not reviewed.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:28 PM Changeset in webkit [153730] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Disable <meter> by default on iOS, it is enabled through the xconfig files
​https://bugs.webkit.org/show_bug.cgi?id=119503

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-08-05
Reviewed by Alexey Proskuryakov.

  • wtf/FeatureDefines.h:
4:06 PM Changeset in webkit [153729] by ap@apple.com
  • 2 edits in trunk/LayoutTests

<rdar://problem/13128990> chunked-progress-event-expectedLength.html is flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=119498

Reviewed by Brady Eidson.

  • http/tests/xmlhttprequest/resources/chunked-transfer.php: This test relies on length not being known upfront, which is not the case when the resource is served form cache.
3:11 PM Changeset in webkit [153728] by oliver@apple.com
  • 122 edits
    15 moves
    13 adds in trunk/Source

Move TypedArray implementation into JSC
​https://bugs.webkit.org/show_bug.cgi?id=119489

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Move TypedArray implementation into JSC in advance of re-implementation

  • GNUmakefile.list.am:
  • JSCTypedArrayStubs.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/ArrayBuffer.cpp: Renamed from Source/WTF/wtf/ArrayBuffer.cpp.

(JSC::ArrayBuffer::transfer):
(JSC::ArrayBuffer::addView):
(JSC::ArrayBuffer::removeView):

  • runtime/ArrayBuffer.h: Renamed from Source/WTF/wtf/ArrayBuffer.h.

(JSC::ArrayBufferContents::ArrayBufferContents):
(JSC::ArrayBufferContents::data):
(JSC::ArrayBufferContents::sizeInBytes):
(JSC::ArrayBufferContents::transfer):
(JSC::ArrayBufferContents::copyTo):
(JSC::ArrayBuffer::isNeutered):
(JSC::ArrayBuffer::~ArrayBuffer):
(JSC::ArrayBuffer::clampValue):
(JSC::ArrayBuffer::create):
(JSC::ArrayBuffer::createUninitialized):
(JSC::ArrayBuffer::ArrayBuffer):
(JSC::ArrayBuffer::data):
(JSC::ArrayBuffer::byteLength):
(JSC::ArrayBuffer::slice):
(JSC::ArrayBuffer::sliceImpl):
(JSC::ArrayBuffer::clampIndex):
(JSC::ArrayBufferContents::tryAllocate):
(JSC::ArrayBufferContents::~ArrayBufferContents):

  • runtime/ArrayBufferView.cpp: Renamed from Source/WTF/wtf/ArrayBufferView.cpp.

(JSC::ArrayBufferView::ArrayBufferView):
(JSC::ArrayBufferView::~ArrayBufferView):
(JSC::ArrayBufferView::neuter):

  • runtime/ArrayBufferView.h: Renamed from Source/WTF/wtf/ArrayBufferView.h.

(JSC::ArrayBufferView::buffer):
(JSC::ArrayBufferView::baseAddress):
(JSC::ArrayBufferView::byteOffset):
(JSC::ArrayBufferView::setNeuterable):
(JSC::ArrayBufferView::isNeuterable):
(JSC::ArrayBufferView::verifySubRange):
(JSC::ArrayBufferView::clampOffsetAndNumElements):
(JSC::ArrayBufferView::setImpl):
(JSC::ArrayBufferView::setRangeImpl):
(JSC::ArrayBufferView::zeroRangeImpl):
(JSC::ArrayBufferView::calculateOffsetAndLength):

  • runtime/Float32Array.h: Renamed from Source/WTF/wtf/Float32Array.h.

(JSC::Float32Array::set):
(JSC::Float32Array::getType):
(JSC::Float32Array::create):
(JSC::Float32Array::createUninitialized):
(JSC::Float32Array::Float32Array):
(JSC::Float32Array::subarray):

  • runtime/Float64Array.h: Renamed from Source/WTF/wtf/Float64Array.h.

(JSC::Float64Array::set):
(JSC::Float64Array::getType):
(JSC::Float64Array::create):
(JSC::Float64Array::createUninitialized):
(JSC::Float64Array::Float64Array):
(JSC::Float64Array::subarray):

  • runtime/Int16Array.h: Renamed from Source/WTF/wtf/Int16Array.h.

(JSC::Int16Array::getType):
(JSC::Int16Array::create):
(JSC::Int16Array::createUninitialized):
(JSC::Int16Array::Int16Array):
(JSC::Int16Array::subarray):

  • runtime/Int32Array.h: Renamed from Source/WTF/wtf/Int32Array.h.

(JSC::Int32Array::getType):
(JSC::Int32Array::create):
(JSC::Int32Array::createUninitialized):
(JSC::Int32Array::Int32Array):
(JSC::Int32Array::subarray):

  • runtime/Int8Array.h: Renamed from Source/WTF/wtf/Int8Array.h.

(JSC::Int8Array::getType):
(JSC::Int8Array::create):
(JSC::Int8Array::createUninitialized):
(JSC::Int8Array::Int8Array):
(JSC::Int8Array::subarray):

  • runtime/IntegralTypedArrayBase.h: Renamed from Source/WTF/wtf/IntegralTypedArrayBase.h.

(JSC::IntegralTypedArrayBase::set):
(JSC::IntegralTypedArrayBase::IntegralTypedArrayBase):

  • runtime/TypedArrayBase.h: Renamed from Source/WTF/wtf/TypedArrayBase.h.

(JSC::TypedArrayBase::data):
(JSC::TypedArrayBase::set):
(JSC::TypedArrayBase::setRange):
(JSC::TypedArrayBase::zeroRange):
(JSC::TypedArrayBase::length):
(JSC::TypedArrayBase::byteLength):
(JSC::TypedArrayBase::item):
(JSC::TypedArrayBase::checkInboundData):
(JSC::TypedArrayBase::TypedArrayBase):
(JSC::TypedArrayBase::create):
(JSC::TypedArrayBase::createUninitialized):
(JSC::TypedArrayBase::subarrayImpl):
(JSC::TypedArrayBase::neuter):

  • runtime/Uint16Array.h: Renamed from Source/WTF/wtf/Uint16Array.h.

(JSC::Uint16Array::getType):
(JSC::Uint16Array::create):
(JSC::Uint16Array::createUninitialized):
(JSC::Uint16Array::Uint16Array):
(JSC::Uint16Array::subarray):

  • runtime/Uint32Array.h: Renamed from Source/WTF/wtf/Uint32Array.h.

(JSC::Uint32Array::getType):
(JSC::Uint32Array::create):
(JSC::Uint32Array::createUninitialized):
(JSC::Uint32Array::Uint32Array):
(JSC::Uint32Array::subarray):

  • runtime/Uint8Array.h: Renamed from Source/WTF/wtf/Uint8Array.h.

(JSC::Uint8Array::getType):
(JSC::Uint8Array::create):
(JSC::Uint8Array::createUninitialized):
(JSC::Uint8Array::Uint8Array):
(JSC::Uint8Array::subarray):

  • runtime/Uint8ClampedArray.h: Renamed from Source/WTF/wtf/Uint8ClampedArray.h.

(JSC::Uint8ClampedArray::getType):
(JSC::Uint8ClampedArray::create):
(JSC::Uint8ClampedArray::createUninitialized):
(JSC::Uint8ClampedArray::zeroFill):
(JSC::Uint8ClampedArray::set):
(JSC::Uint8ClampedArray::Uint8ClampedArray):
(JSC::Uint8ClampedArray::subarray):

  • runtime/VM.h:

Source/WebCore:

Update WebCore for new location of TypedArray implementation.

  • ForwardingHeaders/runtime/ArrayBuffer.h: Added.
  • ForwardingHeaders/runtime/ArrayBufferView.h: Added.
  • ForwardingHeaders/runtime/Float32Array.h: Added.
  • ForwardingHeaders/runtime/Float64Array.h: Added.
  • ForwardingHeaders/runtime/Int16Array.h: Added.
  • ForwardingHeaders/runtime/Int32Array.h: Added.
  • ForwardingHeaders/runtime/Int8Array.h: Added.
  • ForwardingHeaders/runtime/IntegralTypedArrayBase.h: Added.
  • ForwardingHeaders/runtime/TypedArrayBase.h: Added.
  • ForwardingHeaders/runtime/Uint16Array.h: Added.
  • ForwardingHeaders/runtime/Uint32Array.h: Added.
  • ForwardingHeaders/runtime/Uint8Array.h: Added.
  • ForwardingHeaders/runtime/Uint8ClampedArray.h: Added.
  • Modules/webaudio/AnalyserNode.h:

(WebCore::AnalyserNode::getFloatFrequencyData):
(WebCore::AnalyserNode::getByteFrequencyData):
(WebCore::AnalyserNode::getByteTimeDomainData):

  • Modules/webaudio/AsyncAudioDecoder.cpp:
  • Modules/webaudio/AsyncAudioDecoder.h:

(WebCore::AsyncAudioDecoder::DecodingTask::audioData):

  • Modules/webaudio/AudioBuffer.h:
  • Modules/webaudio/AudioContext.cpp:
  • Modules/webaudio/AudioParam.h:
  • Modules/webaudio/AudioParamTimeline.h:
  • Modules/webaudio/PeriodicWave.h:
  • Modules/webaudio/RealtimeAnalyser.cpp:
  • Modules/webaudio/RealtimeAnalyser.h:
  • Modules/webaudio/ScriptProcessorNode.cpp:
  • Modules/webaudio/WaveShaperProcessor.h:
  • Modules/websockets/ThreadableWebSocketChannel.h:
  • Modules/websockets/WebSocket.cpp:
  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketChannel.cpp:
  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • WebCore.exp.in:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSArrayBufferViewHelper.h:
  • bindings/js/JSAudioContextCustom.cpp:
  • bindings/js/JSCryptoCustom.cpp:
  • bindings/js/JSDictionary.h:
  • bindings/js/JSFileReaderCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):

  • bindings/js/SerializedScriptValue.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateHeader):
(NativeToJSValue):

  • dom/MessageEvent.h:
  • fileapi/FileReader.cpp:
  • fileapi/FileReader.h:
  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderLoader.h:
  • fileapi/FileReaderSync.cpp:
  • fileapi/FileReaderSync.h:
  • fileapi/WebKitBlobBuilder.cpp:
  • fileapi/WebKitBlobBuilder.h:
  • html/HTMLMediaElement.cpp:
  • html/ImageData.h:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/DataView.h:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLBuffer.h:

(WebCore::WebGLBuffer::elementArrayBuffer):

  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • inspector/InspectorMemoryAgent.cpp:
  • page/Crypto.cpp:
  • page/Crypto.h:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEConvolveMatrix.cpp:
  • platform/graphics/filters/FECustomFilter.cpp:
  • platform/graphics/filters/FEDisplacementMap.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:
  • platform/graphics/filters/FETurbulence.cpp:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
  • testing/Internals.h:
  • xml/XMLHttpRequest.cpp:
  • xml/XMLHttpRequest.h:

(WebCore::XMLHttpRequest::optionalResponseArrayBuffer):

Source/WTF:

Remove TypedArray implementation from WTF

  • GNUmakefile.list.am:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/Forward.h:
3:11 PM Changeset in webkit [153727] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537-branch

Merged r153725. <rdar://problem/14637103>

3:05 PM Changeset in webkit [153726] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153724. <rdar://problem/14610818>

2:56 PM Changeset in webkit [153725] by ap@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way
of text when dictating an e-mail
​https://bugs.webkit.org/show_bug.cgi?id=119496

Reviewed by Ryosuke Niwa.

Test: platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRectForRange): FloatRect::unite() doesn't preserve empty rects, which we need here. We alrady handle the case of collapsed range in Editor::firstRectForRange(), and this is similar, but we can't currently cover both with one simple fix.
2:26 PM Changeset in webkit [153724] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Ignore the Apple Java placeholder plug-in
​https://bugs.webkit.org/show_bug.cgi?id=119494
<rdar://problem/14610818>

Reviewed by Beth Dakin.

Never attempt to load the Java placeholder plug-in.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin):

2:20 PM Changeset in webkit [153723] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

Region based columns not painted correctly in non-default writing-modes
​https://bugs.webkit.org/show_bug.cgi?id=118506

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-08-05
Reviewed by David Hyatt.

Source/WebCore:

The column translation offset was calculated incorrectly.
The dirty rect intersection check was also wrong.

Added some documentation, to make it clear what's going on.

Tests: fast/multicol/newmulticol/hide-box-horizontal-bt.html

fast/multicol/newmulticol/hide-box-vertical-lr.html
fast/multicol/newmulticol/hide-box-vertical-rl.html

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::collectLayerFragments):

LayoutTests:

  • fast/multicol/newmulticol/hide-box-horizontal-bt-expected.html: Added.
  • fast/multicol/newmulticol/hide-box-horizontal-bt.html: Added.
  • fast/multicol/newmulticol/hide-box-vertical-lr-expected.html: Added.
  • fast/multicol/newmulticol/hide-box-vertical-lr.html: Added.
  • fast/multicol/newmulticol/hide-box-vertical-rl-expected.html: Added.
  • fast/multicol/newmulticol/hide-box-vertical-rl.html: Added.
2:17 PM Changeset in webkit [153722] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

Region based columns not clipped properly
​https://bugs.webkit.org/show_bug.cgi?id=118499

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-08-05
Reviewed by David Hyatt.

Source/WebCore:

Need to call RenderRegion::overflowRectForFlowThreadPortion() first,
and THEN clip in the column gaps. overflowRectForFlowThreadPortion()
expands the logical left and right to the flow thread's overflow
rectangle, effectively defeating inline direction clipping completely.

Tests: fast/multicol/newmulticol/clipping-overflow-hidden.html

fast/multicol/newmulticol/clipping-top-overflow.html
fast/multicol/newmulticol/clipping.html

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):

LayoutTests:

  • fast/multicol/newmulticol/clipping-expected.html: Added.
  • fast/multicol/newmulticol/clipping-overflow-hidden-expected.html: Added.
  • fast/multicol/newmulticol/clipping-overflow-hidden.html: Added.
  • fast/multicol/newmulticol/clipping-top-overflow-expected.html: Added.
  • fast/multicol/newmulticol/clipping-top-overflow.html: Added.
  • fast/multicol/newmulticol/clipping.html: Added.
1:26 PM Changeset in webkit [153721] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Implement leak checking with valgrind
​https://bugs.webkit.org/show_bug.cgi?id=118785

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-08-05
Reviewed by Dirk Pranke.

Launch the DRT under Valgrind to generate xml files with details
of leaks found.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.init):
(GtkPort.default_timeout_ms): Allow extra time to run under
Valgrind.
(GtkPort.setup_environ_for_server): Pass Valgrind instructions
using environment variables.

12:52 PM Changeset in webkit [153720] by fpizlo@apple.com
  • 17 edits
    1 add in trunk/Source/JavaScriptCore

Copied space should be able to handle more than one copied backing store per JSCell
​https://bugs.webkit.org/show_bug.cgi?id=119471

Reviewed by Mark Hahnenberg.

This allows a cell to call copyLater() multiple times for multiple different
backing stores, and then have copyBackingStore() called exactly once for each
of those. A token tells it which backing store to copy. All backing stores
must be named using the CopyToken, an enumeration which currently cannot
exceed eight entries.

When copyBackingStore() is called, it's up to the callee to (a) use the token
to decide what to copy and (b) call its base class's copyBackingStore() in
case the base class had something that needed copying. The only exception is
that JSCell never asks anything to be copied, and so if your base is JSCell
then you don't have to do anything.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/CopiedBlock.h:
  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

  • heap/CopyToken.h: Added.
  • heap/CopyVisitor.cpp:

(JSC::CopyVisitor::copyFromShared):

  • heap/CopyVisitor.h:
  • heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::visitItem):

  • heap/CopyWorkList.h:

(JSC::CopyWorklistItem::CopyWorklistItem):
(JSC::CopyWorklistItem::cell):
(JSC::CopyWorklistItem::token):
(JSC::CopyWorkListSegment::get):
(JSC::CopyWorkListSegment::append):
(JSC::CopyWorkListSegment::data):
(JSC::CopyWorkListIterator::get):
(JSC::CopyWorkListIterator::operator*):
(JSC::CopyWorkListIterator::operator->):
(JSC::CopyWorkList::append):

  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::copyLater):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::copyBackingStore):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitButterfly):
(JSC::JSObject::copyBackingStore):

  • runtime/JSObject.h:
12:38 PM Changeset in webkit [153719] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152884. <rdar://problem/14472043>

12:35 PM Changeset in webkit [153718] by Lucas Forschler
  • 7 edits in branches/safari-537-branch/Source/WebCore

Merged r152876. <rdar://problem/14472043>

12:31 PM Changeset in webkit [153717] by Lucas Forschler
  • 11 edits in branches/safari-537-branch

Merged r153628. <rdar://problem/14498362>

12:27 PM Changeset in webkit [153716] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153377. <rdar://problem/13011371>

12:25 PM Changeset in webkit [153715] by Lucas Forschler
  • 17 edits
    6 copies in branches/safari-537-branch

Merged r152861. <rdar://problem/13011371>

11:04 AM Changeset in webkit [153714] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebCore

Merged r153706. <rdar://problem/14637544>

10:49 AM Changeset in webkit [153713] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebCore

Merged r153699. <rdar://problem/14643481>

10:42 AM Changeset in webkit [153712] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebCore

Merged r153696. <rdar://problem/14643349>

10:33 AM Changeset in webkit [153711] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebCore

Merged r153695. <rdar://problem/14616012>

10:27 AM Changeset in webkit [153710] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153591. <rdar://problem/14616012>

10:20 AM Changeset in webkit [153709] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WTF

Merged r153455. <rdar://problem/14528244>

10:13 AM Changeset in webkit [153708] by Lucas Forschler
  • 4 edits
    3 adds in branches/safari-537-branch

Merge patch for <rdar://problem/14624998>

9:26 AM Changeset in webkit [153707] by vivek.vg@samsung.com
  • 4 edits in trunk/Source/WebCore

XMLTreeViewer should be created only in the XML viewer mode
​https://bugs.webkit.org/show_bug.cgi?id=119483

Reviewed by Alexey Proskuryakov.

XMLTreeViewer is created even for the XSL transform which is avoided by the patch.
The XMLTreeViewer::hasNoStyleInformation() is moved to XMLDocumentParserLibxml2.cpp
as static inline method as XMLTreeViewer should not have the responsibility for it.
Also removes an unnecessary conditional check while deciding for XML viewer mode.

Blink patch review links:
​https://codereview.chromium.org/19552003/
​https://codereview.chromium.org/22150003/

No new tests as the patch is about code refactoring.

  • xml/XMLTreeViewer.cpp:
  • xml/XMLTreeViewer.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::hasNoStyleInformation):
(WebCore::XMLDocumentParser::doEnd):

8:29 AM Changeset in webkit [153706] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Loading a video with a custom URL scheme will result in stalling playback
​https://bugs.webkit.org/show_bug.cgi?id=119469

Reviewed by Eric Carlson.

Break the assumption that only one AVAssetResourceRequest will be outstanding simultaneously
by storing a HashMap of AVAssetResourceRequests and their resulting WebCoreAVFResourceLoader.
When loading is stopped (due to completion or error), notify the MediaPlayerPrivateAVFoundation
parent so that the map can be emptied.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Store the request

in m_resourceLoaderMap.

(WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest): Pull the request from

m_resourceLoaderMap.

(WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest): Remove the requset from

m_resourceLoaderMap.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::create): Return a PassRefPtr, rather than a PassOwnPtr.
(WebCore::WebCoreAVFResourceLoader::stopLoading): Call didStopLoadingRequest.

7:23 AM Changeset in webkit [153705] by commit-queue@webkit.org
  • 47 edits in trunk/LayoutTests

Make tests platform agnostic, fix async tests, remove broken blend modes: hue, saturation, color, luminosity, soft-light.
The test suite should now pass on windows.

​https://bugs.webkit.org/show_bug.cgi?id=119463

Patch by Mihai Tica <​mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

  • fast/canvas/canvas-blending-clipping-expected.txt:
  • fast/canvas/canvas-blending-clipping.html:
  • fast/canvas/canvas-blending-color-over-color-expected.txt:
  • fast/canvas/canvas-blending-color-over-color.html:
  • fast/canvas/canvas-blending-color-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-color-over-gradient.html:
  • fast/canvas/canvas-blending-color-over-image-expected.txt:
  • fast/canvas/canvas-blending-color-over-image.html:
  • fast/canvas/canvas-blending-color-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-color-over-pattern.html:
  • fast/canvas/canvas-blending-fill-style-expected.txt:
  • fast/canvas/canvas-blending-fill-style.html:
  • fast/canvas/canvas-blending-global-alpha-expected.txt:
  • fast/canvas/canvas-blending-global-alpha.html:
  • fast/canvas/canvas-blending-gradient-over-color-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-color.html:
  • fast/canvas/canvas-blending-gradient-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-gradient.html:
  • fast/canvas/canvas-blending-gradient-over-image-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-image.html:
  • fast/canvas/canvas-blending-gradient-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-pattern.html:
  • fast/canvas/canvas-blending-helpers.js:

(separateBlendFunctions.hardLight):
(nonSeparateBlendFunctions.hue):
(nonSeparateBlendFunctions.saturation):
(nonSeparateBlendFunctions.color):
(nonSeparateBlendFunctions.luminosity):

  • fast/canvas/canvas-blending-image-over-color-expected.txt:
  • fast/canvas/canvas-blending-image-over-color.html:
  • fast/canvas/canvas-blending-image-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-image-over-gradient.html:
  • fast/canvas/canvas-blending-image-over-image-expected.txt:
  • fast/canvas/canvas-blending-image-over-image.html:
  • fast/canvas/canvas-blending-image-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-image-over-pattern.html:
  • fast/canvas/canvas-blending-pattern-over-color-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-color.html:
  • fast/canvas/canvas-blending-pattern-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-gradient.html:
  • fast/canvas/canvas-blending-pattern-over-image-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-image.html:
  • fast/canvas/canvas-blending-pattern-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-pattern.html:
  • fast/canvas/canvas-blending-shadow-expected.txt:
  • fast/canvas/canvas-blending-shadow.html:
  • fast/canvas/canvas-blending-text-expected.txt:
  • fast/canvas/canvas-blending-text.html:
  • fast/canvas/canvas-blending-transforms-expected.txt:
  • fast/canvas/canvas-blending-transforms.html:
  • platform/win/TestExpectations:
6:09 AM Changeset in webkit [153704] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Spatial Navigation should avoid unwanted calculation while deciding focus candidate.
​https://bugs.webkit.org/show_bug.cgi?id=117265

Patch by Abhijeet Kandalkar <​abhijeet.k@samsung.com> on 2013-08-05
Reviewed by Antonio Gomes.

Source/WebCore:

Spatial Navigation should consider only those nodes as candidate which are exactly in the focus-direction.
e.g. If we are moving down then the nodes that are above CURRENT focused node should be considered as invalid.
Added isValidCandidate() which checks whether node is exactly in the focus-direction.

Test: fast/spatial-navigation/snav-search-optimization.html

  • page/FocusController.cpp:

(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::setLastSpatialNavigationCandidateCount):
(WebCore::Page::lastSpatialNavigationCandidateCount):

  • page/SpatialNavigation.cpp:

(WebCore::isValidCandidate):

  • page/SpatialNavigation.h:
  • testing/Internals.cpp:

(WebCore::Internals::lastSpatialNavigationCandidateCount):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added testcases to count how many target nodes were tested before choosing a final target.

  • fast/spatial-navigation/snav-search-optimization-expected.txt: Added.
  • fast/spatial-navigation/snav-search-optimization.html: Added.
12:58 AM Changeset in webkit [153703] by zandobersek@gmail.com
  • 6 edits in trunk

[Automake] Define ENABLE_JIT through the Autoconf header
​https://bugs.webkit.org/show_bug.cgi?id=119445

Reviewed by Martin Robinson.

.:

Instead of defining the ENABLE_JIT value through JSC_CPPFLAGS, the feature define is
set to be either enabled or disabled through the Autoconf header, based on the value
passed through the configuration flag. The 'auto' value is used as default, meaning
that the feature is enabled or disabled in the Platform.h header based on the platform
configuration (OS, architecture etc.).

  • Source/autotools/FindDependencies.m4: Remove the JSC_CPPFLAGS definition.
  • Source/autotools/ReadCommandLineArguments.m4: Change the default value to 'auto' instead

of 'autodetect', as used by other configuration options that take a similar approach to enabling
a specific feature.

  • Source/autotools/SetupAutoconfHeader.m4: Set a strict value for the ENABLE_JIT define through

the Autoconf header if the feature was specifically enabled or disabled.

Source/JavaScriptCore:

  • GNUmakefile.am: Remove JSC_CPPFLAGS from the cpp flags for the JSC library.
12:16 AM Changeset in webkit [153702] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Source/WebCore: [CSS Background Blending] Specifying background-image and background-color
with opaque image doesn't trigger blending. The fix consists of adding a
check whether blend mode is set in hasOpaqueImage.

​https://bugs.webkit.org/show_bug.cgi?id=119434

Patch by Mihai Tica <​mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-separate-layer-declaration.html

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):

LayoutTests: [CSS Background Blending] Specifying background-image and background-color with opaque
image doesn't trigger blending. Adding ref test to validate the fix.

​https://bugs.webkit.org/show_bug.cgi?id=119434i

Patch by Mihai Tica <​mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-separate-layer-declaration-expected.html: Added.
  • css3/compositing/background-blend-mode-separate-layer-declaration.html: Added.
  • css3/compositing/resources/gray_square.svg: Added.

Aug 4, 2013:

2:29 PM Changeset in webkit [153701] by Alan Bujtas
  • 8 edits
    1 add in trunk

Background doesn't fully repaint when body has margins.
​https://bugs.webkit.org/show_bug.cgi?id=119033

Reviewed by Simon Fraser.

Ensure that background-color changes do not leave unpainted areas when
body has margins.

Both <body> and <html> background-color get propagated up to the viewport.
If <body> has background-color attribute set, while <html> doesn't, the color is
applied not only on the <body> but on both the <html> and the viewport. However,
it's not enough to mark the RenderView dirty because with tiles backing on,
there could be areas outside of the viewport that need repaint. By marking
the RenderView's graphics layer dirty instead, we ensure that all the related
tiles get marked dirty too and the new background color covers all areas.

Manual test added. When forcing top-level composition on (even with embedded iframe to
make sure we don't do paintsIntoWindow rendering), the test case execution changes so much,
that the repaint rects don't reflect the functionality difference anymore.

.:

Reviewed by Simon Fraser.

  • ManualTests/compositing/background-color-change-on-body-with-margin.html: Added.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::layout):

  • page/FrameView.h:

(WebCore::FrameView::needsFullRepaint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintRootContents):
(WebCore::RenderView::repaintViewAndCompositedLayers):

  • rendering/RenderView.h:
9:17 AM Changeset in webkit [153700] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Document needn't expose its active element.
<​http://webkit.org/b/119466>

Reviewed by Antonio Gomes.

The Document::m_activeElement pointer is only used inside updateHoverActiveState(),
so we can remove the activeElement()/setActiveElement() accessors.

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

8:57 AM Changeset in webkit [153699] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Inserting a rule into an empty style sheet shouldn't trigger style recalc unless necessary.
<​http://webkit.org/b/119475>
<rdar://problem/14643481>

Reviewed by Antti Koivisto.

This is kind of a cheesy optimization, but it turns out that the use case is quite common.
The pattern goes like this:

(1) Create <style> element.
(2) Add it to the document's <head>.
(3) .addRule() one rule through the CSSOM API.

Prior to this patch, (3) would always cause a full (deferred) style recalc.

Now that we exclude empty style sheets from the document's (effective) active set,
we can piggyback on the style invalidation analysis when transitioning from an empty
sheet to a single-rule sheet.

In other words, add a special code path for the first rule insertion into an empty,
in-document style sheet to minimize the amount of invalidation that happens.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):

  • css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope):
(WebCore::CSSStyleSheet::RuleMutationScope::~RuleMutationScope):

7:35 AM Changeset in webkit [153698] by Claudio Saavedra
  • 2 edits in trunk/Source/WebCore

[GTK] Fix a C++11 warning.

Rubber-stamped by Martin Robinson.

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::sharedResourcesPath): Fix a C++11 warning.

6:03 AM Changeset in webkit [153697] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Remove legacy hack in CodeGeneratorGObject.pm
​https://bugs.webkit.org/show_bug.cgi?id=117545

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-08-04
Reviewed by Carlos Garcia Campos.

There's a checking that sets gtype to uint in case it's ushort. gtype
is a value obtained from GetGValueTypeName(), which never returns
ushort.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty): remove unnecessary glitch

12:41 AM Changeset in webkit [153696] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

[Mac] Disable screen font substitution at WebCore-level in OS X 10.9+
<​http://webkit.org/b/119474>
<rdar://problem/14643349>

Reviewed by Dan Bernstein.

Disable screen font substitution by default in Settings so internal WebCore clients
such as SVG-as-image will get the right default setting.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::shouldEnableScreenFontSubstitutionByDefault):
(WebCore::Settings::setScreenFontSubstitutionEnabled):

  • page/Settings.h:

(WebCore::Settings::screenFontSubstitutionEnabled):

  • page/Settings.in:
  • page/mac/SettingsMac.mm:

(WebCore::Settings::shouldEnableScreenFontSubstitutionByDefault):

Note: See TracTimeline for information about the timeline view.