Timeline

Aug 6, 2013:

9:04 PM Changeset in webkit [153778] by fpizlo@apple.com

• 9 edits
  3 adds in trunk

DFG FixupPhase should insert Int32ToDouble nodes for number uses in NewArray, and SpeculativeJIT 64-bit should not try to coerce integer constants to double constants
​https://bugs.webkit.org/show_bug.cgi?id=119528

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Either of the two fixes would solve the crash I saw. Basically, for best performance, we want the DFG register allocator to track double uses and non-double
uses of a node separately, and we accomplish this by inserting Int32ToDouble nodes in the FixupPhase. But even if FixupPhase fails to do this, we still want
the DFG register allocator to do the right thing: if it encounters a double use of an integer, it should perform a conversion and preserve the original
format of the value (namely, that it was an integer). For constants, the best format to preserve is None, so that future integer uses rematerialize the int
from scratch. This only affects the 64-bit backend; the 32-bit backend was already doing the right thing.

This also fixes some more debug dumping code, and adds some stronger assertions for integer arrays.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

• dfg/DFGDriver.cpp:

(JSC::DFG::compile):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

• runtime/JSObject.h:

(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):

LayoutTests:

• fast/js/dfg-new-array-double-const-then-int-const.html: Added.
• fast/js/dfg-new-array-double-const-then-int-const-expected.txt: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/dfg-new-array-double-const-then-int-const.js: Added.

(bar):
(foo):

8:07 PM Changeset in webkit [153777] by Lucas Forschler

• 5 edits in branches/safari-537-branch/Source

Versioning.

8:05 PM Changeset in webkit [153776] by Lucas Forschler

• 1 copy in tags/Safari-537.55

New Tag.

7:41 PM Changeset in webkit [153775] by Stephanie Lewis

• 8 edits in trunk/Source

Update Order Files for Safari
<rdar://problem/14517392>

Unreviewed.

Source/JavaScriptCore:

• JavaScriptCore.order:

Source/WebCore:

No change in functionality.

• WebCore.order:

Source/WebKit/mac:

• WebKit.order:

Source/WebKit2:

• mac/WebKit2.order:

5:19 PM Changeset in webkit [153774] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Assertion failure in emitExpressionInfo when reloading with Web Inspector open.
​https://bugs.webkit.org/show_bug.cgi?id=119532.

Reviewed by Oliver Hunt.

• parser/Parser.cpp:

(JSC::::Parser):

• Just need to initialize the Parser's JSTokenLocation's initial line and startOffset as well during Parser construction.

5:13 PM Changeset in webkit [153773] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

Crash when entering fullscreen video playback from a WebView using WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=119531

Reviewed by Tim Horton.

Initialize wkWindowSetScaledFrame and wkWindowSetAlpha when initializing WebCoreSystemInterface.

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:22 PM Changeset in webkit [153772] by weinig@apple.com

• 75 edits
  15 deletes in trunk

.: Remove support for HTML5 MicroData
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• Source/autotools/SetupWebKitFeatures.m4:
• Source/cmake/OptionsBlackBerry.cmake:
• Source/cmake/OptionsEfl.cmake:
• Source/cmake/OptionsGTK.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmakeconfig.h.cmake:

Source/JavaScriptCore: Remove support for HTML5 MicroData
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore: Remove support for HTML5 Microdata
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• DerivedSources.cpp:
• DerivedSources.make:
• DerivedSources.pri:
• GNUmakefile.list.am:
• Target.pri:
• UseJSC.cmake:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/gobject/GNUmakefile.am:
• bindings/js/JSBindingsAllInOne.cpp:
• bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

• bindings/js/JSHTMLElementCustom.cpp:
• bindings/js/JSMicroDataItemValueCustom.cpp: Removed.
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• dom/Document.cpp:
• dom/Document.h:
• dom/Document.idl:
• dom/Element.cpp:

(WebCore::Element::ensureCachedHTMLCollection):

• dom/LiveNodeList.cpp:

(WebCore::LiveNodeListBase::rootNode):
(WebCore::LiveNodeListBase::invalidateCache):
(WebCore::LiveNodeList::namedItem):

• dom/LiveNodeList.h:

(WebCore::LiveNodeListBase::shouldInvalidateTypeOnAttributeChange):

• dom/MicroDataItemList.cpp: Removed.
• dom/MicroDataItemList.h: Removed.
• dom/Node.cpp:
• dom/Node.h:
• dom/NodeRareData.cpp:
• dom/NodeRareData.h:
• dom/PropertyNodeList.cpp: Removed.
• dom/PropertyNodeList.h: Removed.
• dom/PropertyNodeList.idl: Removed.
• html/CollectionType.h:
• html/HTMLAnchorElement.cpp:
• html/HTMLAnchorElement.h:
• html/HTMLAreaElement.cpp:
• html/HTMLAreaElement.h:
• html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isMatchingElement):
(WebCore::LiveNodeListBase::item):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::isURLAttribute):

• html/HTMLElement.h:
• html/HTMLElement.idl:
• html/HTMLEmbedElement.cpp:
• html/HTMLEmbedElement.h:
• html/HTMLIFrameElement.cpp:
• html/HTMLIFrameElement.h:
• html/HTMLImageElement.cpp:
• html/HTMLImageElement.h:
• html/HTMLLinkElement.cpp:
• html/HTMLLinkElement.h:
• html/HTMLMediaElement.cpp:
• html/HTMLMediaElement.h:
• html/HTMLMetaElement.cpp:
• html/HTMLMetaElement.h:
• html/HTMLObjectElement.cpp:
• html/HTMLObjectElement.h:
• html/HTMLPropertiesCollection.cpp: Removed.
• html/HTMLPropertiesCollection.h: Removed.
• html/HTMLPropertiesCollection.idl: Removed.
• html/HTMLSourceElement.cpp:
• html/HTMLSourceElement.h:
• html/HTMLTrackElement.cpp:
• html/HTMLTrackElement.h:
• html/MicroDataAttributeTokenList.cpp: Removed.
• html/MicroDataAttributeTokenList.h: Removed.
• html/MicroDataItemValue.cpp: Removed.
• html/MicroDataItemValue.h: Removed.
• html/MicroDataItemValue.idl: Removed.

Source/WebKit/blackberry: Remove support for HTML5 MicroData
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/mac: Remove support for HTML5 MicroData
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2: Remove support for HTML5 MicroData
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• Configurations/FeatureDefines.xcconfig:

Source/WTF: Remove support for HTML5 MicroData
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• wtf/FeatureDefines.h:

Tools: Remove support for HTML5 MicroData
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• Scripts/webkitperl/FeatureList.pm:
• qmake/mkspecs/features/features.pri:

LayoutTests: Remove support for HTML5 MicroData
​https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

• fast/dom/MicroData: Removed.
• fast/dom/MicroData/001-expected.txt: Removed.
• fast/dom/MicroData/001.html: Removed.
• fast/dom/MicroData/002-expected.txt: Removed.
• fast/dom/MicroData/002.html: Removed.
• fast/dom/MicroData/003-expected.txt: Removed.
• fast/dom/MicroData/003.html: Removed.
• fast/dom/MicroData/004-expected.txt: Removed.
• fast/dom/MicroData/004.html: Removed.
• fast/dom/MicroData/005-expected.txt: Removed.
• fast/dom/MicroData/005.html: Removed.
• fast/dom/MicroData/006-expected.txt: Removed.
• fast/dom/MicroData/006.html: Removed.
• fast/dom/MicroData/007-expected.txt: Removed.
• fast/dom/MicroData/007.html: Removed.
• fast/dom/MicroData/008-expected.txt: Removed.
• fast/dom/MicroData/008.html: Removed.
• fast/dom/MicroData/009-expected.txt: Removed.
• fast/dom/MicroData/009.html: Removed.
• fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree-expected.txt: Removed.
• fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree.html: Removed.
• fast/dom/MicroData/domsettabletokenlist-attributes-add-token-expected.txt: Removed.
• fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html: Removed.
• fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index-expected.txt: Removed.
• fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html: Removed.
• fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Removed.
• fast/dom/MicroData/element-with-empty-itemprop.html: Removed.
• fast/dom/MicroData/getitems-empty-string-as-arg-expected.txt: Removed.
• fast/dom/MicroData/getitems-empty-string-as-arg.html: Removed.
• fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Removed.
• fast/dom/MicroData/getitems-multiple-itemtypes.html: Removed.
• fast/dom/MicroData/item-not-attached-to-domtree-expected.txt: Removed.
• fast/dom/MicroData/item-not-attached-to-domtree.html: Removed.
• fast/dom/MicroData/item-with-itemprop-attr-expected.txt: Removed.
• fast/dom/MicroData/item-with-itemprop-attr.html: Removed.
• fast/dom/MicroData/item-with-itemref-pointing-to-itself-expected.txt: Removed.
• fast/dom/MicroData/item-with-itemref-pointing-to-itself.html: Removed.
• fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Removed.
• fast/dom/MicroData/itemid-attribute-test-001.html: Removed.
• fast/dom/MicroData/itemid-attribute-test-expected.txt: Removed.
• fast/dom/MicroData/itemid-attribute-test.html: Removed.
• fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Removed.
• fast/dom/MicroData/itemid-must-see-resolved-url.html: Removed.
• fast/dom/MicroData/itemprop-add-remove-tokens-expected.txt: Removed.
• fast/dom/MicroData/itemprop-add-remove-tokens.html: Removed.
• fast/dom/MicroData/itemprop-for-an-element-must-be-correct-expected.txt: Removed.
• fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html: Removed.
• fast/dom/MicroData/itemprop-must-be-read-only-expected.txt: Removed.
• fast/dom/MicroData/itemprop-must-be-read-only.html: Removed.
• fast/dom/MicroData/itemprop-names-override-builtin-properties-expected.txt: Removed.
• fast/dom/MicroData/itemprop-names-override-builtin-properties.html: Removed.
• fast/dom/MicroData/itemprop-reflected-by-itemProp-property-expected.txt: Removed.
• fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html: Removed.
• fast/dom/MicroData/itemref-add-remove-tokens-expected.txt: Removed.
• fast/dom/MicroData/itemref-add-remove-tokens.html: Removed.
• fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property-expected.txt: Removed.
• fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html: Removed.
• fast/dom/MicroData/itemref-for-an-element-must-be-correct-expected.txt: Removed.
• fast/dom/MicroData/itemref-for-an-element-must-be-correct.html: Removed.
• fast/dom/MicroData/itemref-must-be-read-only-expected.txt: Removed.
• fast/dom/MicroData/itemref-must-be-read-only.html: Removed.
• fast/dom/MicroData/itemref-pointing-to-root-node-expected.txt: Removed.
• fast/dom/MicroData/itemref-pointing-to-root-node.html: Removed.
• fast/dom/MicroData/itemref-refers-first-element-with-given-id-expected.txt: Removed.
• fast/dom/MicroData/itemref-refers-first-element-with-given-id.html: Removed.
• fast/dom/MicroData/itemscope-attribute-test-expected.txt: Removed.
• fast/dom/MicroData/itemscope-attribute-test.html: Removed.
• fast/dom/MicroData/itemscope-must-be-read-write-expected.txt: Removed.
• fast/dom/MicroData/itemscope-must-be-read-write.html: Removed.
• fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Removed.
• fast/dom/MicroData/itemtype-add-remove-tokens.html: Removed.
• fast/dom/MicroData/itemtype-attribute-test-expected.txt: Removed.
• fast/dom/MicroData/itemtype-attribute-test.html: Removed.
• fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html: Removed.
• fast/dom/MicroData/itemvalue-reflects-href-attr-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-reflects-href-attr.html: Removed.
• fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html: Removed.
• fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html: Removed.
• fast/dom/MicroData/itemvalue-reflects-the-src-attr-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-reflects-the-src-attr.html: Removed.
• fast/dom/MicroData/itemvalue-returns-element-itself-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-returns-element-itself.html: Removed.
• fast/dom/MicroData/itemvalue-returns-null-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-returns-null.html: Removed.
• fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html: Removed.
• fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002-expected.txt: Removed.
• fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html: Removed.
• fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens-expected.txt: Removed.
• fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens.html: Removed.
• fast/dom/MicroData/nameditem-must-be-case-sensitive-expected.txt: Removed.
• fast/dom/MicroData/nameditem-must-be-case-sensitive.html: Removed.
• fast/dom/MicroData/nameditem-must-return-correct-item-properties-expected.txt: Removed.
• fast/dom/MicroData/nameditem-must-return-correct-item-properties.html: Removed.
• fast/dom/MicroData/nameditem-returns-propertynodelist-expected.txt: Removed.
• fast/dom/MicroData/nameditem-returns-propertynodelist.html: Removed.
• fast/dom/MicroData/names-item-out-of-range-index-expected.txt: Removed.
• fast/dom/MicroData/names-item-out-of-range-index.html: Removed.
• fast/dom/MicroData/names-property-must-be-correct-expected.txt: Removed.
• fast/dom/MicroData/names-property-must-be-correct.html: Removed.
• fast/dom/MicroData/names-property-test-expected.txt: Removed.
• fast/dom/MicroData/names-property-test.html: Removed.
• fast/dom/MicroData/properties-collection-add-remove-itemref-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-add-remove-itemref.html: Removed.
• fast/dom/MicroData/properties-collection-add-remove-property-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-add-remove-property.html: Removed.
• fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html: Removed.
• fast/dom/MicroData/properties-collection-must-be-correct-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-must-be-correct.html: Removed.
• fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html: Removed.
• fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html: Removed.
• fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html: Removed.
• fast/dom/MicroData/properties-collection-nameditem-test-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-nameditem-test.html: Removed.
• fast/dom/MicroData/properties-collection-test-expected.txt: Removed.
• fast/dom/MicroData/properties-collection-test.html: Removed.
• fast/dom/MicroData/propertiescollection-crash-expected.txt: Removed.
• fast/dom/MicroData/propertiescollection-crash.html: Removed.
• fast/dom/MicroData/propertiescollection-on-changing-id-attr-expected.txt: Removed.
• fast/dom/MicroData/propertiescollection-on-changing-id-attr.html: Removed.
• fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens-expected.txt: Removed.
• fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens.html: Removed.
• fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens-expected.txt: Removed.
• fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens.html: Removed.
• fast/dom/MicroData/propertynodelist-crash-expected.txt: Removed.
• fast/dom/MicroData/propertynodelist-crash.html: Removed.
• fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element-expected.txt: Removed.
• fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html: Removed.
• fast/dom/MicroData/propertynodelist-getvalues-test-expected.txt: Removed.
• fast/dom/MicroData/propertynodelist-getvalues-test.html: Removed.
• fast/dom/MicroData/propertynodelist-test-add-remove-element-expected.txt: Removed.
• fast/dom/MicroData/propertynodelist-test-add-remove-element.html: Removed.
• fast/dom/MicroData/resources: Removed.
• fast/dom/MicroData/resources/microdata-common.js: Removed.

4:21 PM Changeset in webkit [153771] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebCore

Remove PlatformCALayer::contentsTransform and ::setContentsTransform
​https://bugs.webkit.org/show_bug.cgi?id=119529

Reviewed by Sam Weinig.

No new tests, removing dead code.

These methods are not used and are currently unimplemented.

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:
• platform/graphics/ca/win/PlatformCALayerWin.cpp:

4:01 PM Changeset in webkit [153770] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk/Source/WebKit2

[EFL][WK2] Implement gesture recognizer.
​https://bugs.webkit.org/show_bug.cgi?id=102643

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2013-08-06
Reviewed by Gyuyoung Kim.

Recognize tap, pan and pinch gestures using touch events.
The tap gesture is separated into single tap, double tap and
'tap and hold'.

This patch references the webkit NIX port.
​https://github.com/WebKitNix/webkitnix

• PlatformEfl.cmake:
• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::doneWithTouchEvent):

• UIProcess/API/efl/EwkView.h:
• UIProcess/API/efl/GestureRecognizer.cpp: Added.

(WebKit::GestureHandler::create):
(WebKit::GestureHandler::GestureHandler):
(WebKit::GestureHandler::handleSingleTap):
(WebKit::GestureHandler::handleDoubleTap):
(WebKit::GestureHandler::handleTapAndHold):
(WebKit::GestureHandler::handlePanStarted):
(WebKit::GestureHandler::handlePan):
(WebKit::GestureHandler::handlePanFinished):
(WebKit::GestureHandler::handlePinchStarted):
(WebKit::GestureHandler::handlePinch):
(WebKit::GestureHandler::handlePinchFinished):
(WebKit::GestureRecognizer::GestureRecognizer):
(WebKit::GestureRecognizer::~GestureRecognizer):
(WebKit::GestureRecognizer::processTouchEvent):
(WebKit::GestureRecognizer::doubleTapTimerCallback):
(WebKit::GestureRecognizer::tapAndHoldTimerCallback):
(WebKit::GestureRecognizer::exceedsPanThreshold):
(WebKit::GestureRecognizer::exceedsDoubleTapThreshold):
(WebKit::getPointAtIndex):
(WebKit::createVectorWithWKArray):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::singleTapGesture):
(WebKit::GestureRecognizer::doubleTapGesture):
(WebKit::GestureRecognizer::panGesture):
(WebKit::GestureRecognizer::pinchGesture):
(WebKit::GestureRecognizer::reset):
(WebKit::GestureRecognizer::stopTapTimers):

• UIProcess/API/efl/GestureRecognizer.h: Added.

(WebKit::GestureRecognizer::create):

3:16 PM Changeset in webkit [153769] by hmuller@adobe.com

• 6 edits in trunk/LayoutTests

[CSS Shapes] New positioning model: scripted shape-margin tests
​https://bugs.webkit.org/show_bug.cgi?id=119491

Update some of the shape-margin tests to work with the new positioning model. Floats
that specify shape-outside are now positioned according to their margin box, not the
bounding box of the shape-outside shape. The tests have been revised to reflect the
change.

Reviewed by Alexandru Chiculita.

• TestExpectations:
• fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html:
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
• fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:

3:11 PM Changeset in webkit [153768] by achristensen@apple.com

• 6 edits in trunk/Source

Enabled WebGL on WinCairo port.
​https://bugs.webkit.org/show_bug.cgi?id=119502

Reviewed by Benjamin Poulain.

Source/WebKit:

• WebKit.vcxproj/WebKit.sln: Build ANGLE libraries.
• WebKit.vcxproj/WebKit/WebKitCFLite.props: Link to ANGLE libraries.

Source/WTF:

• wtf/FeatureDefines.h: Enabled WebGL.
• wtf/Platform.h: Added definitions required for WebGL on Windows.

3:10 PM Changeset in webkit [153767] by mrowe@apple.com

• 2 edits in trunk/Source/WTF

<rdar://problem/5927399> FastMalloc should support MallocStackLogging

Call the malloc stack logging function from within the various entry points to FastMalloc
when stack logging is enabled.

Reviewed by Oliver Hunt and Geoff Garen.

• wtf/FastMalloc.cpp:

Call in to MallocHook::InvokeNewHook / MallocHook::InvokeDeleteHook at the appropriate entry
points to FastMalloc. The naming comes from TCMalloc's existing, unused concept of malloc hooks.
(WTF::MallocHook::record): Call the stack logging function with appropriate argument types.
(WTF::MallocHook::recordAllocation): Out-of-line slow path for when stack logging is enabled
that calls record with the values in the right arguments.
(WTF::MallocHook::recordDeallocation): Ditto.
(WTF::MallocHook::init): Stack logging is enabled if the system allocator has enabled stack logging.
(WTF::MallocHook::InvokeNewHook): Call recordAllocation in the unlikely event that stack logging is
enabled.
(WTF::MallocHook::InvokeDeleteHook): Ditto for recordDeallocation.
(WTF::TCMalloc_ThreadCache::InitModule): Initialize the malloc hook.

2:55 PM Changeset in webkit [153766] by achristensen@apple.com

• 5 edits
  2 moves in trunk/Source/WebCore

Moved GraphicsContext3DPrivate out of cairo directory to be used by the AppleWin port.
​https://bugs.webkit.org/show_bug.cgi?id=119525

Reviewed by Dean Jackson.

• GNUmakefile.list.am:
• PlatformGTK.cmake:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:

Changed location of GraphicsContext3DPrivate.cpp and GraphicsContext3DPrivate.h.

• platform/graphics/GraphicsContext3DPrivate.cpp: Copied from WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp.
• platform/graphics/GraphicsContext3DPrivate.h: Copied from WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.h.
• platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Removed.
• platform/graphics/cairo/GraphicsContext3DPrivate.h: Removed.

2:38 PM Changeset in webkit [153765] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove stale code in ResourceContentView
​https://bugs.webkit.org/show_bug.cgi?id=119527

The handling of Resource Type changes moved to ResourceClusterContentView,
this removeEventListener is stale and doesn't do anything anymore.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-08-06
Reviewed by Timothy Hatcher.

• UserInterface/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype.closed):

2:31 PM Changeset in webkit [153764] by Brent Fulgham

• 4 edits in trunk/Source

[Windows] Unreviewed build correction after r153754 and r153757.

Source/WebCore:

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Don't force std::remainder, since we are using our own
custom implementation on Windows.

Source/WTF:

• wtf/MathExtras.h:

(remainder): Provide implementation of C99 remainder for VS2010 (and earlier).

2:20 PM Changeset in webkit [153763] by oliver@apple.com

• 8 edits
  3 adds in trunk

Delay Arguments creation in strict mode
​https://bugs.webkit.org/show_bug.cgi?id=119505

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Make use of the write tracking performed by the parser to
allow us to know if we're modifying the parameters to a function.
Then use that information to make strict mode function opt out
of eager arguments creation.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):
(JSC::BytecodeGenerator::emitReturn):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldTearOffArgumentsEagerly):

• parser/Nodes.h:

(JSC::ScopeNode::modifiesParameter):

• parser/Parser.cpp:

(JSC::::parseInner):

• parser/Parser.h:

(JSC::Scope::declareParameter):
(JSC::Scope::getCapturedVariables):
(JSC::Parser::declareWrite):

• parser/ParserModes.h:

LayoutTests:

Add performance testcase for lazy creation of arguments in strict mode

• fast/js/regress/delay-tear-off-arguments-strictmode-expected.txt: Added.
• fast/js/regress/delay-tear-off-arguments-strictmode.html: Added.
• fast/js/regress/script-tests/delay-tear-off-arguments-strictmode.js: Added.

(bar):

1:51 PM Changeset in webkit [153762] by Patrick Gansterer

• 2 edits in trunk/Source/JavaScriptCore

Remove useless code from COMPILER(RVCT) JITStubs
​https://bugs.webkit.org/show_bug.cgi?id=119521

Reviewed by Geoffrey Garen.

• jit/JITStubsARMv7.h:

(JSC::ctiVMThrowTrampoline): "ldr r6, [sp, #PRESERVED_R6_OFFSET]" was called twice.
(JSC::ctiOpThrowNotCaught): Ditto.

1:37 PM Changeset in webkit [153761] by timothy@apple.com

• 29 edits
  17 copies
  76 adds
  53 deletes in trunk/Source/WebInspectorUI

Convert all Web Inspector PDFs to SVGs.

Some PDFs need to stay around until bug 119492 is fixed. But the SVGs are there for when they are needed.
Updated some of the existing SVGs to be consistent with the format of the new SVGs.

​https://bugs.webkit.org/show_bug.cgi?id=118677

Rubber-stamped by Joseph Pecoraro.

• UserInterface/BreakpointIcons.css:
• UserInterface/BreakpointTreeElement.css:
• UserInterface/CallFrameIcons.css:
• UserInterface/DatabaseContentView.css:
• UserInterface/FilterBar.css:
• UserInterface/HierarchicalPathComponent.css:
• UserInterface/Images/BackArrow.svg: Added.
• UserInterface/Images/BottomUpTree.svg: Added.
• UserInterface/Images/BreakpointButton.pdf: Removed.
• UserInterface/Images/BreakpointButton.svg: Added.
• UserInterface/Images/BreakpointInactiveButton.pdf: Removed.
• UserInterface/Images/BreakpointInactiveButton.svg: Added.
• UserInterface/Images/Breakpoints.svg: Added.
• UserInterface/Images/Close.svg: Added.
• UserInterface/Images/Crosshair.svg: Added.
• UserInterface/Images/DOMCharacterData.pdf: Removed.
• UserInterface/Images/DOMCharacterData.svg: Added.
• UserInterface/Images/DOMComment.pdf: Removed.
• UserInterface/Images/DOMComment.svg: Added.
• UserInterface/Images/DOMDocument.pdf: Removed.
• UserInterface/Images/DOMDocument.svg: Added.
• UserInterface/Images/DOMDocumentType.pdf: Removed.
• UserInterface/Images/DOMDocumentType.svg: Added.
• UserInterface/Images/DOMElement.pdf: Removed.
• UserInterface/Images/DOMElement.svg: Added.
• UserInterface/Images/DOMNode.pdf: Removed.
• UserInterface/Images/DOMNode.svg: Added.
• UserInterface/Images/DOMTextNode.pdf: Removed.
• UserInterface/Images/DOMTextNode.svg: Added.
• UserInterface/Images/DOMTree.pdf: Removed.
• UserInterface/Images/DOMTree.svg: Added.
• UserInterface/Images/DisclosureTriangleSmallClosed.svg: Added.
• UserInterface/Images/DisclosureTriangleSmallOpen.svg: Added.
• UserInterface/Images/DisclosureTriangleTinyClosed.svg: Added.
• UserInterface/Images/DisclosureTriangleTinyOpen.svg: Added.
• UserInterface/Images/DockBottom.svg: Added.
• UserInterface/Images/DockRight.svg: Added.
• UserInterface/Images/Error.pdf: Removed.
• UserInterface/Images/Error.svg: Added.
• UserInterface/Images/ErrorSmall.pdf: Removed.
• UserInterface/Images/Errors.svg:
• UserInterface/Images/ErrorsEnabled.svg:
• UserInterface/Images/EventListener.pdf: Removed.
• UserInterface/Images/EventListener.svg: Added.
• UserInterface/Images/Exception.pdf: Removed.
• UserInterface/Images/Exception.svg: Added.
• UserInterface/Images/FilterFieldGlyph.pdf: Removed.
• UserInterface/Images/FilterFieldGlyph.svg: Added.
• UserInterface/Images/ForwardArrow.svg: Added.
• UserInterface/Images/Function.pdf: Removed.
• UserInterface/Images/Function.svg: Added.
• UserInterface/Images/GoToArrow.svg: Added.
• UserInterface/Images/HierarchicalNavigationItemChevron.pdf: Removed.
• UserInterface/Images/HierarchicalNavigationItemChevron.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner1.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner1.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner10.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner10.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner11.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner11.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner12.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner12.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner2.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner2.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner3.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner3.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner4.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner4.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner5.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner5.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner6.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner6.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner7.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner7.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner8.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner8.svg: Added.
• UserInterface/Images/IndeterminateProgressSpinner9.pdf: Removed.
• UserInterface/Images/IndeterminateProgressSpinner9.svg: Added.
• UserInterface/Images/Issues.svg:
• UserInterface/Images/IssuesEnabled.svg:
• UserInterface/Images/LayerBorders.svg: Added.
• UserInterface/Images/LessColumns.svg: Added.
• UserInterface/Images/Locked.svg: Added.
• UserInterface/Images/Logs.svg:
• UserInterface/Images/Memory.svg:
• UserInterface/Images/MoreColumns.svg: Added.
• UserInterface/Images/Native.pdf: Removed.
• UserInterface/Images/Native.svg: Added.
• UserInterface/Images/NavigationItemAngleBrackets.svg: Added.
• UserInterface/Images/NavigationItemBrushAndRuler.svg: Added.
• UserInterface/Images/NavigationItemBug.svg: Added.
• UserInterface/Images/NavigationItemCurleyBraces.svg: Added.
• UserInterface/Images/NavigationItemFile.svg: Added.
• UserInterface/Images/NavigationItemLayers.svg: Added.
• UserInterface/Images/NavigationItemLog.svg: Added.
• UserInterface/Images/NavigationItemMagnifyingGlass.svg: Added.
• UserInterface/Images/NavigationItemStopwatch.svg: Added.
• UserInterface/Images/NavigationItemStorage.svg: Added.
• UserInterface/Images/NavigationItemTrash.svg: Added.
• UserInterface/Images/NavigationItemVariable.svg: Added.
• UserInterface/Images/NetworkBarLabelCalloutLeft.pdf: Removed.
• UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Added.
• UserInterface/Images/NetworkBarLabelCalloutRight.pdf: Removed.
• UserInterface/Images/NetworkBarLabelCalloutRight.svg: Added.
• UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.pdf: Removed.
• UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Added.
• UserInterface/Images/NetworkBarLabelCalloutWhiteRight.pdf: Removed.
• UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Added.
• UserInterface/Images/Pause.svg: Added.
• UserInterface/Images/Percent.svg: Added.
• UserInterface/Images/Plus.svg: Added.
• UserInterface/Images/PseudoElement.pdf: Removed.
• UserInterface/Images/PseudoElement.svg: Added.
• UserInterface/Images/Reflection.pdf: Removed.
• UserInterface/Images/Reflection.svg: Added.
• UserInterface/Images/Reload.svg:
• UserInterface/Images/ReloadSelected.svg:
• UserInterface/Images/Request.pdf: Removed.
• UserInterface/Images/Request.svg: Added.
• UserInterface/Images/Resources.svg:
• UserInterface/Images/Response.pdf: Removed.
• UserInterface/Images/Response.svg: Added.
• UserInterface/Images/ResultLine.pdf: Removed.
• UserInterface/Images/ResultLine.svg: Added.
• UserInterface/Images/Resume.svg: Added.
• UserInterface/Images/ShadowDOM.svg: Added.
• UserInterface/Images/SortIndicatorDownArrow.svg: Added.
• UserInterface/Images/SortIndicatorUpArrow.svg: Added.
• UserInterface/Images/SourceCode.pdf: Removed.
• UserInterface/Images/SourceCode.svg: Added.
• UserInterface/Images/SplitToggleDown.svg: Added.
• UserInterface/Images/SplitToggleUp.svg: Added.
• UserInterface/Images/StepInto.svg: Added.
• UserInterface/Images/StepOut.svg: Added.
• UserInterface/Images/StepOver.svg: Added.
• UserInterface/Images/StyleRuleAuthor.pdf: Removed.
• UserInterface/Images/StyleRuleAuthor.svg: Added.
• UserInterface/Images/StyleRuleInherited.pdf: Removed.
• UserInterface/Images/StyleRuleInherited.svg: Added.
• UserInterface/Images/StyleRuleInheritedElement.pdf: Removed.
• UserInterface/Images/StyleRuleInheritedElement.svg: Added.
• UserInterface/Images/StyleRuleInspector.pdf: Removed.
• UserInterface/Images/StyleRuleInspector.svg: Added.
• UserInterface/Images/StyleRuleUser.pdf: Removed.
• UserInterface/Images/StyleRuleUser.svg: Added.
• UserInterface/Images/StyleRuleUserAgent.pdf: Removed.
• UserInterface/Images/StyleRuleUserAgent.svg: Added.
• UserInterface/Images/Time.svg:
• UserInterface/Images/Undock.svg: Added.
• UserInterface/Images/UpDownArrows.svg:
• UserInterface/Images/UserInputPrompt.pdf: Removed.
• UserInterface/Images/UserInputPrompt.svg: Added.
• UserInterface/Images/UserInputPromptPrevious.pdf: Removed.
• UserInterface/Images/UserInputPromptPrevious.svg: Added.
• UserInterface/Images/UserInputPromptPreviousSelected.pdf: Removed.
• UserInterface/Images/UserInputPromptPreviousSelected.svg: Added.
• UserInterface/Images/UserInputResult.pdf: Removed.
• UserInterface/Images/UserInputResult.svg: Added.
• UserInterface/Images/UserInputResultSelected.pdf: Removed.
• UserInterface/Images/UserInputResultSelected.svg: Added.
• UserInterface/Images/Warning.pdf: Removed.
• UserInterface/Images/Warning.svg: Added.
• UserInterface/Images/WarningSmall.pdf: Removed.
• UserInterface/Images/Weight.svg:
• UserInterface/IndeterminateProgressSpinner.css:
• UserInterface/LayerTreeSidebarPanel.css:
• UserInterface/LogContentView.css:
• UserInterface/Main.css:
• UserInterface/NetworkTimeline.css:
• UserInterface/PathComponentIcons.css:
• UserInterface/QuickConsole.css:
• UserInterface/RulesStyleDetailsPanel.css:
• UserInterface/SearchIcons.css:
• UserInterface/StyleRuleIcons.css:

12:33 PM Changeset in webkit [153760] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153758. <rdar://problem/14627254>

11:53 AM Changeset in webkit [153759] by Bem Jones-Bey

• 2 edits
  4 moves in trunk/LayoutTests

[CSS Shapes] New positioning model: support for shape-margin
​https://bugs.webkit.org/show_bug.cgi?id=118088

Reviewed by Alexandru Chiculita.

Update simple shape-margin tests to work with new positioning model.
Also move them to the CSSWG's repo.

• TestExpectations: Remove replaced tests.
• csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html.
• csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon.html.
• csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html.
• csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon.html.

11:39 AM Changeset in webkit [153758] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

Improper Calculation of In-band Cue Colors
​https://bugs.webkit.org/show_bug.cgi?id=119523

Reviewed by Eric Carlson.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::makeRGBA32FromARGBCFArray): Remove redundant multiplication by

255. The internal conversion logic already converts to bytes.

11:11 AM Changeset in webkit [153757] by rwlbuis@webkit.org

• 2 edits in trunk/Source/WebCore

Speculative build fix after r153754.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

10:43 AM Changeset in webkit [153756] by dfarler@apple.com

• 37 edits
  3 adds in trunk

Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
​https://bugs.webkit.org/show_bug.cgi?id=117762

Reviewed by Mark Rowe.

Source/JavaScriptCore:

• Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• Configurations/JavaScriptCore.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• Configurations/ToolExecutable.xcconfig:

Don't use ASAN for build tools.

Source/ThirdParty:

• gtest/xcode/Config/General.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• gtest/xcode/Config/StaticLibraryTarget.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Source/ThirdParty/ANGLE:

• Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Source/WebCore:

No new tests necessary.

• Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• Configurations/WebCore.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• Configurations/WebCoreTestShim.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• Configurations/WebCoreTestSupport.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• WebCore.xcodeproj/project.pbxproj:

Don't use ASAN for build tools.

Source/WebInspectorUI:

• Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

Source/WebKit/mac:

• Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• Configurations/WebKit.xcconfig:

Add ASAN_OTHER_LDFLAGS.

Source/WebKit2:

• Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• Configurations/WebContentProcess.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• Configurations/WebKit2.xcconfig:

Add ASAN_OTHER_LDFLAGS.

Source/WTF:

• Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Tools:

• DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• MiniBrowser/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• Scripts/check-for-weak-vtables-and-externals:

Ignore _asan externals, these are populated by compiler-rt.

• TestWebKitAPI/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• WebKitLauncher/Configurations/Base.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• WebKitTestRunner/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

• WebKitTestRunner/Configurations/InjectedBundle.xcconfig:

Add ASAN_OTHER_LDFLAGS.

• asan/asan.xcconfig: Added.
• asan/webkit-asan-ignore.txt: Added.

9:16 AM Changeset in webkit [153755] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153753. <rdar://problem/14648086>

8:54 AM Changeset in webkit [153754] by rwlbuis@webkit.org

• 6 edits in trunk

SVG stroke-dasharray is not animatable
​https://bugs.webkit.org/show_bug.cgi?id=118574

Reviewed by Dirk Schulze.

Source/WebCore:

Make stroke-dasharray a property that can be animated using CSS transitions.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::CSSPropertyAnimation::ensurePropertyMap):

• rendering/style/RenderStyle.h:

LayoutTests:

Add test for animating stroke-dasharray in addition to the original SVG tests.

• transitions/svg-transitions-expected.txt:
• transitions/svg-transitions.html:

8:40 AM Changeset in webkit [153753] by akling@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION(r151403): Resizing is extremely laggy on many sites when plugins are disallowed.
<​http://webkit.org/b/119516>
<rdar://problem/14648086>

Reviewed by Simon Fraser.

The web process relies on the WindowAndViewFramesChanged mechanism for caching a copy
of the window rect for fast access from DOMWindow APIs.

We retain part of the optimization introduced in r151403, namely not computing the
viewFrameInWindowCoordinates and accessibilityPosition unless the web process needs them.

• UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

8:08 AM Changeset in webkit [153752] by sergio@webkit.org

• 8 edits
  2 adds in trunk

[CSS Grid Layout] Allow defining named grid lines on the grid element
​https://bugs.webkit.org/show_bug.cgi?id=118255

Reviewed by Andreas Kling.

From Blink r149798 by <​jchaffraix@chromium.org>

Source/WebCore:

This change adds parsing, style resolution and getComputedStyle
support for named grid lines at the grid element level
(i.e. extends our <track-list> support). Per the specification, we
allow multiple grid lines with the same name.

To fully support resolving the grid lines to a position on our
grid, we need to add the parsing at the grid item's level (which
means extending our <grid-line> support). This will be done in a
follow-up change.

Test: fast/css-grid-layout/named-grid-line-get-set.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackList):

• css/StyleResolver.cpp:

(WebCore::createGridTrackList):
(WebCore::StyleResolver::applyProperty):

• rendering/style/RenderStyle.h:
• rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

• rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):

LayoutTests:

• fast/css-grid-layout/named-grid-line-get-set-expected.txt: Added.
• fast/css-grid-layout/named-grid-line-get-set.html: Added.

6:58 AM Changeset in webkit [153751] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit/qt

[Qt] Add Page Visibility API support
​https://bugs.webkit.org/show_bug.cgi?id=109422

Patch by Benjamin Dupont <​bdupont@nds.com> on 2013-08-06
Reviewed by Simon Hausmann.

• WebCoreSupport/QWebPageAdapter.cpp:

(webPageVisibilityStateToWebCoreVisibilityState):
(webCoreVisibilityStateToWebPageVisibilityState):
(QWebPageAdapter::setVisibilityState):
(QWebPageAdapter::visibilityState):

• WebCoreSupport/QWebPageAdapter.h:
• WidgetApi/qwebpage.cpp:

(QWebPage::setVisibilityState):
(QWebPage::visibilityState):

• WidgetApi/qwebpage.h:
• tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::changeVisibilityState):

5:52 AM Changeset in webkit [153750] by allan.jensen@digia.com

• 2 edits in trunk/Source/WebCore

[Qt] Fix minimal build.

Unreviewed build fix.

Fix build witt XSLT disabled

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::hasNoStyleInformation):

5:45 AM Changeset in webkit [153749] by zandobersek@gmail.com

• 4 edits in trunk/Source

webkit-gtk fails to build with bison-3.0
​https://bugs.webkit.org/show_bug.cgi?id=119373

Reviewed by Gustavo Noronha Silva.

Source/ThirdParty/ANGLE:

• GNUmakefile.am: Stop relying on generated glslang_tab.(cpp|h) and glslang.cpp sources as Bison 3.0

produces non-compilable source code. Instead, compile these pregenerated files as they're included in
the tree. Originally, the ANGLE source tree provides these files as generated by Bison 2.7, but they're
at the moment regenerated with Bison 2.3 when the third-party ANGLE source is being updated.

Source/WebCore:

• GNUmakefile.am: Remove rules for generating ANGLE's glslang source files with Bison.

4:45 AM Changeset in webkit [153748] by sergio@webkit.org

• 16 edits in trunk

[CSS Grid Layout] Add support for parsing <grid-line> that includes a 'span'
​https://bugs.webkit.org/show_bug.cgi?id=118051

Reviewed by Andreas Kling.

From Blink r148766 by <​jchaffraix@chromium.org>

Source/WebCore:

This adds the parsing, style resolution and getComputedStyle bits
to our code. The rendering code was not made aware of the new type
of GridPosition yet.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridPosition):

• css/CSSParser.h:
• css/CSSValueKeywords.in:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::createGridPosition):

• css/StyleResolver.h:
• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):

• rendering/style/GridPosition.h:

(WebCore::GridPosition::isInteger):
(WebCore::GridPosition::isSpan):
(WebCore::GridPosition::setSpanPosition):
(WebCore::GridPosition::spanPosition):

LayoutTests:

Added several test cases to check that we properly parse the
keyword 'span' in <grid-line>.

• fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
• fast/css-grid-layout/grid-item-column-row-get-set.html:
• fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
• fast/css-grid-layout/grid-item-end-after-get-set.html:
• fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
• fast/css-grid-layout/grid-item-start-before-get-set.html:

4:08 AM Changeset in webkit [153747] by simon.pena@samsung.com

• 2 edits in trunk

Build fix for GTK 32-bit after r153736

• Source/autotools/symbols.filter: expose WebCore::SerializedScriptValue::create.

3:33 AM Changeset in webkit [153746] by sergio@webkit.org

• 19 edits in trunk

[CSS Grid Layout] Rename grid placement properties
​https://bugs.webkit.org/show_bug.cgi?id=117878

Reviewed by Andreas Kling.

Renamed the grid placement properties to match the latest version
of the spec. The new names are -webkit-grid-column-{start|end} and
-webkit-grid-row-{start|end}.

Source/WebCore:

No new tests needed as we're just renaming some properties,
functionality already covered by existing tests in
fast/css-grid-layout.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

• css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

• css/CSSPropertyNames.in:
• css/StylePropertyShorthand.cpp:

(WebCore::webkitGridColumnShorthand):
(WebCore::webkitGridRowShorthand):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::RenderGrid::resolveGridPositionFromStyle):

• rendering/RenderGrid.h:
• rendering/style/RenderStyle.h:
• rendering/style/StyleGridItemData.cpp:

(WebCore::StyleGridItemData::StyleGridItemData):

• rendering/style/StyleGridItemData.h:

(WebCore::StyleGridItemData::operator==):

LayoutTests:

• fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
• fast/css-grid-layout/grid-item-column-row-get-set.html:
• fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
• fast/css-grid-layout/grid-item-end-after-get-set.html:
• fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
• fast/css-grid-layout/grid-item-start-before-get-set.html:

3:04 AM Changeset in webkit [153745] by Patrick Gansterer

• 2 edits in trunk/Source/JavaScriptCore

Build fix for ARM MSVC after r153222 and r153648.

• jit/JITStubsARM.h: Added ctiVMThrowTrampolineSlowpath.

3:03 AM Changeset in webkit [153744] by Patrick Gansterer

• 4 edits in trunk/Source/JavaScriptCore

Build fix for ARM MSVC after r150109.

Read the stub template from a header files instead of the JITStubs.cpp.

• CMakeLists.txt:
• DerivedSources.pri:
• create_jit_stubs:

2:36 AM Changeset in webkit [153743] by simon.pena@samsung.com

• 2 edits in trunk

Build fix for GTK after r153736

• Source/autotools/symbols.filter: expose missing symbols

WebCore::SerializedScriptValue::create and WebCore::toJS to Internals.

Aug 5, 2013:

11:45 PM Changeset in webkit [153742] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[WebGL] validateRenderingState method name change
​https://bugs.webkit.org/show_bug.cgi?id=119485

According to validateRenderingState method functionality its name should be
changed. This method validates only vertex attributes.

Patch by Przemyslaw Szymanski <​p.szymanski3@samsung.com> on 2013-08-05
Reviewed by Dean Jackson.

No new tests. Covered by existing tests. No changes in functionality.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateVertexAttributes):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):

• html/canvas/WebGLRenderingContext.h:

11:21 PM Changeset in webkit [153741] by dino@apple.com

• 1 edit in trunk/Websites/webkit.org/demos/srcset/index.html

Forgot to add alt text to the example image :(

• demos/srcset/index.html:

11:01 PM Changeset in webkit [153740] by dino@apple.com

• 1 edit
  4 moves
  1 add in trunk/Websites/webkit.org

Move previous commit into /demos.

• demos/srcset/image-1x.png: Renamed from Websites/webkit.org/blog-files/srcset/image-1x.png.
• demos/srcset/image-2x.png: Renamed from Websites/webkit.org/blog-files/srcset/image-2x.png.
• demos/srcset/image-src.png: Renamed from Websites/webkit.org/blog-files/srcset/image-src.png.
• demos/srcset/index.html: Renamed from Websites/webkit.org/blog-files/srcset/index.html.

8:16 PM Changeset in webkit [153739] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit/win

Another Windows release build fix.

• WebKitLogging.cpp: Wrap the implementation file in !LOG_DISABLED #if's too.

8:10 PM Changeset in webkit [153738] by mrowe@apple.com

• 2 edits in trunk/Source/WTF

Build fix for Windows.

• wtf/Assertions.cpp: Include StringExtras.h rather than StdLibExtras.h, since the former is where

strncasecmp is declared.

8:03 PM Changeset in webkit [153737] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit/win

Build fix for Windows release build.

• WebKitLogging.h: Wrap things in !LOG_DISABLED so that we don't attempt to use macros that have not been defined.

7:53 PM Changeset in webkit [153736] by mrowe@apple.com

• 44 edits
  1 delete in trunk/Source

Logging should be configurable using human-readable channel names rather than crazy bitmasks
<​http://webkit.org/b/119031>

Implement shared logic for initializing logging channels based on human-readable channel names in WTF,
and rework the WebCore, WebKit and WebKit2 logging initialization on top of it.

Logging channels may now be enabled by providing a comma-separated list of channel names, with the special
"all" name enabling all channels. Channel names prefixed with a leading "-" will result in the named channel
being disabled. For instance, specifying "all,-history,-loading" will result in all logging channels except
for history and loading being enabled.

For OS X developers, this also changes the name of the user defaults used to enable logging. This is done to allow
the old user defaults to remain set for those people that need to switch between version of WebKit before and
after this change. Where the old user default keys were WebCoreLogLevel, WebKitLogLevel and WebKit2LogLevel,
the new user default keys are WebCoreLogging, WebKitLogging and WebKit2Logging.

For GTK developers, this changes the separator used in the WEBKIT_DEBUG environment variable to a comma for
consistency with the other platforms and to enable more code sharing.

While doing this work I've also taken the opportunity to eliminate the need to touch multiple files when
adding a new logging channel. Now only the header in the relevant project needs to be updated.

Reviewed by Sam Weinig.

Source/WebCore:

• GNUmakefile.list.am: Remove the now-unused InitializeLogging.h
• Target.pri: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• platform/InitializeLogging.h: Removed. Ditto.
• platform/Logging.cpp: Use WEBCORE_LOG_CHANNELS to define all of the channels.

(WebCore::logChannelByName): Renamed to match our naming conventions. Calls through to the new WTF function
to find a log channel rather than repeating the names of the log channels a further two times each.
(WebCore::initializeLoggingChannelsIfNecessary): Pass the channels and the log level string to the new
WTF function that handles the initialization.

• platform/Logging.h: Declare a WEBCORE_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

• platform/blackberry/LoggingBlackBerry.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable.

• platform/efl/LoggingEfl.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable, and then prepend
NotYetImplemented to it so that that channel will be enabled by default.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink): Accommodate the rename to logChannelByName.

• platform/gtk/LoggingGtk.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable, and then prepend
NotYetImplemented to it so that that channel will be enabled by default.

• platform/mac/LoggingMac.mm:

(WebCore::logLevelString): Pull the value out of the WebCoreLogging user default key.

• platform/qt/LoggingQt.cpp:

(WebCore::logLevelString): Pull the value out of the QT_WEBKIT_LOG environment variable, and then prepend
NotYetImplemented to it so that the channel will be enabled by default.

• platform/win/LoggingWin.cpp:

(WebCore::logLevelString): Pull the value out of the WebCoreLogging environment variable.

Source/WebKit/blackberry:

• Api/BlackBerryGlobal.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/efl:

• ewk/ewk_main.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/gtk:

• webkit/webkitglobals.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/mac:

• Misc/WebKitLogging.h: Declare a WEBKIT_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

• Misc/WebKitLogging.m: Use WEBKIT_LOG_CHANNELS to define all of the channels. Pass the channels and the

preference value to the new WTF function that handles the initialization.

• WebView/WebPreferenceKeysPrivate.h: Remove a key that does not need to be here.
• WebView/WebView.mm: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/qt:

• WebCoreSupport/InitWebCoreQt.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/win:

• WebKitLogging.cpp: Declare a WEBKIT_LOG_CHANNELS macro that can be used to apply a preprocessor macro across

the set of all logging channels. Use this macro to declare the logging channels.

• WebKitLogging.h: Use WEBKIT_LOG_CHANNELS to define all of the channels. Pass the channels to the new WTF

function that handles the initialization. As per the previous implementation a developer needs to hard-code
their desired log level here.

• WebView.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit2:

• NetworkProcess/NetworkProcess.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.
• Platform/Logging.cpp: Use WEBKIT2_LOG_CHANNELS to define all of the channels.

(WebKit::initializeLogChannelsIfNecessary): Pass the channels and the log level string to the new WTF function
that handles the initialization.
(WebKit::logChannelByName): Renamed to match our naming conventions. Calls through to the new WTF function
to find a log channel rather than repeating the names of the log channels a further two times each.
(WebKit::logLevelString): Provide a no-op implementation.

• Platform/Logging.h: Declare a WEBKIT2_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

• Platform/efl/LoggingEfl.cpp:

(WebKit::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable.

• Platform/gtk/LoggingGtk.cpp:

(WebKit::logLevelString): Ditto.

• Platform/mac/Logging.mac.mm:

(WebKit::logLevelString): Pull the value out of the WebKit2Logging user default key.

• Platform/qt/LoggingQt.cpp:

(WebKit::logLevelString): Pull the value out of the QT_WEBKIT_LOG environment variable.

• Shared/WebKit2Initialize.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.
• UIProcess/WebContext.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WTF:

• wtf/Assertions.cpp:

(WTFLogChannelByName): Iterate over the provided array of log channels, returning the first whose name
matches case-insensitively.
(setStateOfAllChannels): Helper function to set the state of all channels to a single value.
(WTFInitializeLogChannelStatesFromString): Parse a string containing a case-insensitive, comma-separated list
of channel names to enable or disable, with the latter being prefixed by a "-".

• wtf/Assertions.h: Update the layout of WTFLogChannel to include only the state of the channel and its name.

Declare WTFLogChannelByName and WTFInitializeLogChannelStatesFromString.

• wtf/RefCountedLeakCounter.cpp: Update to the new format of WTFLogChannel.

7:03 PM Changeset in webkit [153735] by dino@apple.com

• 1 edit
  5 adds in trunk/Websites/webkit.org

Upload example for a blog post.

• blog-files/srcset/image-1x.png: Added.
• blog-files/srcset/image-2x.png: Added.
• blog-files/srcset/image-src.png: Added.
• blog-files/srcset/index.html: Added.

7:02 PM Changeset in webkit [153734] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers
​https://bugs.webkit.org/show_bug.cgi?id=119501

Reviewed by Enrica Casucci.

Exit early in updateMarkersForWordsAffectedByEditing before calling startOfWord and endOfWord if there are no document markers.

• dom/DocumentMarkerController.h:

(WebCore::DocumentMarkerController::hasMarkers): Added.

• editing/Editor.cpp:

(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

6:13 PM Changeset in webkit [153733] by dino@apple.com

• 9 edits
  2 adds in trunk

Update HTMLPreloadScanner to handle img srcset
​https://bugs.webkit.org/show_bug.cgi?id=119360

Reviewed by Sam Weinig.

This patch is a merge of similar patches from Yoav Weiss <​yoav@yoav.ws>
and Dean Jackson.

Source/WebCore:

Test: fast/preloader/image-srcset.html

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Move srcset parsing into
HTMLParserIdioms, and call it when we hit src or srcset.

• html/HTMLImageElement.h: Remove code that was moved to HTMLParserIdioms.

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer): Pass device scale into preloader.
(WebCore::HTMLDocumentParser::insert):

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner): Takes device scale as a parameter.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): Resolve between src and srcSet if necessary.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Add support for srcset attribute.
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): New flag to indicate if we should
replace any existing value.
(WebCore::TokenPreloadScanner::TokenPreloadScanner): Takes device scale.
(WebCore::TokenPreloadScanner::scanCommon): Pass device scale.
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):

• html/parser/HTMLPreloadScanner.h: New attribute to constructor for device scale. New member

variable on TokenPreloadScanner that holds the srcset value.

• html/parser/HTMLParserIdioms.cpp:

(WebCore::ImageWithScale::operator==): Used for sorting.
(WebCore::compareByScaleFactor): Used for sorting.
(WebCore::bestFitSourceForImageAttributes): New method that takes the code from HTMLImageElement
for parsing src and srcset attributes, and finding the best match.

• html/parser/HTMLParserIdioms.h:

LayoutTests:

New test to make sure the HTML preloader takes the
value of srcset if available.

• fast/preloader/image-srcset-expected.txt: Added.
• fast/preloader/image-srcset.html: Added.

5:41 PM Changeset in webkit [153732] by achristensen@apple.com

• 7 edits
  1 add in trunk/Source/ThirdParty/ANGLE

Added optimizations to Windows ANGLE builds.
​https://bugs.webkit.org/show_bug.cgi?id=119500

Reviewed by Brent Fulgham.

• ANGLE.vcxproj/ANGLERelease.props: Added.
• ANGLE.vcxproj/libEGL.vcxproj:
• ANGLE.vcxproj/libGLESv2.vcxproj:
• ANGLE.vcxproj/preprocessor.vcxproj:
• ANGLE.vcxproj/translator_common.vcxproj:
• ANGLE.vcxproj/translator_glsl.vcxproj:
• ANGLE.vcxproj/translator_hlsl.vcxproj:

Use ANGLERelease.props for Release, Release_WinCairo, and Production configurations.

5:39 PM Changeset in webkit [153731] by mark.lam@apple.com

• 2 edits in trunk/Source/WebKit

Gardening: fix build after r153728.

Not reviewed.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

5:28 PM Changeset in webkit [153730] by benjamin@webkit.org

• 2 edits in trunk/Source/WTF

Disable <meter> by default on iOS, it is enabled through the xconfig files
​https://bugs.webkit.org/show_bug.cgi?id=119503

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-08-05
Reviewed by Alexey Proskuryakov.

• wtf/FeatureDefines.h:

4:06 PM Changeset in webkit [153729] by ap@apple.com

• 2 edits in trunk/LayoutTests

<rdar://problem/13128990> chunked-progress-event-expectedLength.html is flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=119498

Reviewed by Brady Eidson.

• http/tests/xmlhttprequest/resources/chunked-transfer.php: This test relies on length not being known upfront, which is not the case when the resource is served form cache.

3:11 PM Changeset in webkit [153728] by oliver@apple.com

• 122 edits
  15 moves
  13 adds in trunk/Source

Move TypedArray implementation into JSC
​https://bugs.webkit.org/show_bug.cgi?id=119489

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Move TypedArray implementation into JSC in advance of re-implementation

• GNUmakefile.list.am:
• JSCTypedArrayStubs.h:
• JavaScriptCore.xcodeproj/project.pbxproj:
• runtime/ArrayBuffer.cpp: Renamed from Source/WTF/wtf/ArrayBuffer.cpp.

(JSC::ArrayBuffer::transfer):
(JSC::ArrayBuffer::addView):
(JSC::ArrayBuffer::removeView):

• runtime/ArrayBuffer.h: Renamed from Source/WTF/wtf/ArrayBuffer.h.

(JSC::ArrayBufferContents::ArrayBufferContents):
(JSC::ArrayBufferContents::data):
(JSC::ArrayBufferContents::sizeInBytes):
(JSC::ArrayBufferContents::transfer):
(JSC::ArrayBufferContents::copyTo):
(JSC::ArrayBuffer::isNeutered):
(JSC::ArrayBuffer::~ArrayBuffer):
(JSC::ArrayBuffer::clampValue):
(JSC::ArrayBuffer::create):
(JSC::ArrayBuffer::createUninitialized):
(JSC::ArrayBuffer::ArrayBuffer):
(JSC::ArrayBuffer::data):
(JSC::ArrayBuffer::byteLength):
(JSC::ArrayBuffer::slice):
(JSC::ArrayBuffer::sliceImpl):
(JSC::ArrayBuffer::clampIndex):
(JSC::ArrayBufferContents::tryAllocate):
(JSC::ArrayBufferContents::~ArrayBufferContents):

• runtime/ArrayBufferView.cpp: Renamed from Source/WTF/wtf/ArrayBufferView.cpp.

(JSC::ArrayBufferView::ArrayBufferView):
(JSC::ArrayBufferView::~ArrayBufferView):
(JSC::ArrayBufferView::neuter):

• runtime/ArrayBufferView.h: Renamed from Source/WTF/wtf/ArrayBufferView.h.

(JSC::ArrayBufferView::buffer):
(JSC::ArrayBufferView::baseAddress):
(JSC::ArrayBufferView::byteOffset):
(JSC::ArrayBufferView::setNeuterable):
(JSC::ArrayBufferView::isNeuterable):
(JSC::ArrayBufferView::verifySubRange):
(JSC::ArrayBufferView::clampOffsetAndNumElements):
(JSC::ArrayBufferView::setImpl):
(JSC::ArrayBufferView::setRangeImpl):
(JSC::ArrayBufferView::zeroRangeImpl):
(JSC::ArrayBufferView::calculateOffsetAndLength):

• runtime/Float32Array.h: Renamed from Source/WTF/wtf/Float32Array.h.

(JSC::Float32Array::set):
(JSC::Float32Array::getType):
(JSC::Float32Array::create):
(JSC::Float32Array::createUninitialized):
(JSC::Float32Array::Float32Array):
(JSC::Float32Array::subarray):

• runtime/Float64Array.h: Renamed from Source/WTF/wtf/Float64Array.h.

(JSC::Float64Array::set):
(JSC::Float64Array::getType):
(JSC::Float64Array::create):
(JSC::Float64Array::createUninitialized):
(JSC::Float64Array::Float64Array):
(JSC::Float64Array::subarray):

• runtime/Int16Array.h: Renamed from Source/WTF/wtf/Int16Array.h.

(JSC::Int16Array::getType):
(JSC::Int16Array::create):
(JSC::Int16Array::createUninitialized):
(JSC::Int16Array::Int16Array):
(JSC::Int16Array::subarray):

• runtime/Int32Array.h: Renamed from Source/WTF/wtf/Int32Array.h.

(JSC::Int32Array::getType):
(JSC::Int32Array::create):
(JSC::Int32Array::createUninitialized):
(JSC::Int32Array::Int32Array):
(JSC::Int32Array::subarray):

• runtime/Int8Array.h: Renamed from Source/WTF/wtf/Int8Array.h.

(JSC::Int8Array::getType):
(JSC::Int8Array::create):
(JSC::Int8Array::createUninitialized):
(JSC::Int8Array::Int8Array):
(JSC::Int8Array::subarray):

• runtime/IntegralTypedArrayBase.h: Renamed from Source/WTF/wtf/IntegralTypedArrayBase.h.

(JSC::IntegralTypedArrayBase::set):
(JSC::IntegralTypedArrayBase::IntegralTypedArrayBase):

• runtime/TypedArrayBase.h: Renamed from Source/WTF/wtf/TypedArrayBase.h.

(JSC::TypedArrayBase::data):
(JSC::TypedArrayBase::set):
(JSC::TypedArrayBase::setRange):
(JSC::TypedArrayBase::zeroRange):
(JSC::TypedArrayBase::length):
(JSC::TypedArrayBase::byteLength):
(JSC::TypedArrayBase::item):
(JSC::TypedArrayBase::checkInboundData):
(JSC::TypedArrayBase::TypedArrayBase):
(JSC::TypedArrayBase::create):
(JSC::TypedArrayBase::createUninitialized):
(JSC::TypedArrayBase::subarrayImpl):
(JSC::TypedArrayBase::neuter):

• runtime/Uint16Array.h: Renamed from Source/WTF/wtf/Uint16Array.h.

(JSC::Uint16Array::getType):
(JSC::Uint16Array::create):
(JSC::Uint16Array::createUninitialized):
(JSC::Uint16Array::Uint16Array):
(JSC::Uint16Array::subarray):

• runtime/Uint32Array.h: Renamed from Source/WTF/wtf/Uint32Array.h.

(JSC::Uint32Array::getType):
(JSC::Uint32Array::create):
(JSC::Uint32Array::createUninitialized):
(JSC::Uint32Array::Uint32Array):
(JSC::Uint32Array::subarray):

• runtime/Uint8Array.h: Renamed from Source/WTF/wtf/Uint8Array.h.

(JSC::Uint8Array::getType):
(JSC::Uint8Array::create):
(JSC::Uint8Array::createUninitialized):
(JSC::Uint8Array::Uint8Array):
(JSC::Uint8Array::subarray):

• runtime/Uint8ClampedArray.h: Renamed from Source/WTF/wtf/Uint8ClampedArray.h.

(JSC::Uint8ClampedArray::getType):
(JSC::Uint8ClampedArray::create):
(JSC::Uint8ClampedArray::createUninitialized):
(JSC::Uint8ClampedArray::zeroFill):
(JSC::Uint8ClampedArray::set):
(JSC::Uint8ClampedArray::Uint8ClampedArray):
(JSC::Uint8ClampedArray::subarray):

• runtime/VM.h:

Source/WebCore:

Update WebCore for new location of TypedArray implementation.

• ForwardingHeaders/runtime/ArrayBuffer.h: Added.
• ForwardingHeaders/runtime/ArrayBufferView.h: Added.
• ForwardingHeaders/runtime/Float32Array.h: Added.
• ForwardingHeaders/runtime/Float64Array.h: Added.
• ForwardingHeaders/runtime/Int16Array.h: Added.
• ForwardingHeaders/runtime/Int32Array.h: Added.
• ForwardingHeaders/runtime/Int8Array.h: Added.
• ForwardingHeaders/runtime/IntegralTypedArrayBase.h: Added.
• ForwardingHeaders/runtime/TypedArrayBase.h: Added.
• ForwardingHeaders/runtime/Uint16Array.h: Added.
• ForwardingHeaders/runtime/Uint32Array.h: Added.
• ForwardingHeaders/runtime/Uint8Array.h: Added.
• ForwardingHeaders/runtime/Uint8ClampedArray.h: Added.
• Modules/webaudio/AnalyserNode.h:

(WebCore::AnalyserNode::getFloatFrequencyData):
(WebCore::AnalyserNode::getByteFrequencyData):
(WebCore::AnalyserNode::getByteTimeDomainData):

• Modules/webaudio/AsyncAudioDecoder.cpp:
• Modules/webaudio/AsyncAudioDecoder.h:

(WebCore::AsyncAudioDecoder::DecodingTask::audioData):

• Modules/webaudio/AudioBuffer.h:
• Modules/webaudio/AudioContext.cpp:
• Modules/webaudio/AudioParam.h:
• Modules/webaudio/AudioParamTimeline.h:
• Modules/webaudio/PeriodicWave.h:
• Modules/webaudio/RealtimeAnalyser.cpp:
• Modules/webaudio/RealtimeAnalyser.h:
• Modules/webaudio/ScriptProcessorNode.cpp:
• Modules/webaudio/WaveShaperProcessor.h:
• Modules/websockets/ThreadableWebSocketChannel.h:
• Modules/websockets/WebSocket.cpp:
• Modules/websockets/WebSocket.h:
• Modules/websockets/WebSocketChannel.cpp:
• Modules/websockets/WebSocketChannel.h:
• Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
• Modules/websockets/WorkerThreadableWebSocketChannel.h:
• WebCore.exp.in:
• bindings/js/JSArrayBufferCustom.cpp:
• bindings/js/JSArrayBufferViewHelper.h:
• bindings/js/JSAudioContextCustom.cpp:
• bindings/js/JSCryptoCustom.cpp:
• bindings/js/JSDictionary.h:
• bindings/js/JSFileReaderCustom.cpp:
• bindings/js/JSWebGLRenderingContextCustom.cpp:
• bindings/js/JSXMLHttpRequestCustom.cpp:
• bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):

• bindings/js/SerializedScriptValue.h:
• bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateHeader):
(NativeToJSValue):

• dom/MessageEvent.h:
• fileapi/FileReader.cpp:
• fileapi/FileReader.h:
• fileapi/FileReaderLoader.cpp:
• fileapi/FileReaderLoader.h:
• fileapi/FileReaderSync.cpp:
• fileapi/FileReaderSync.h:
• fileapi/WebKitBlobBuilder.cpp:
• fileapi/WebKitBlobBuilder.h:
• html/HTMLMediaElement.cpp:
• html/ImageData.h:
• html/canvas/ArrayBuffer.idl:
• html/canvas/ArrayBufferView.idl:
• html/canvas/CanvasRenderingContext2D.cpp:
• html/canvas/DataView.h:
• html/canvas/Float32Array.idl:
• html/canvas/Float64Array.idl:
• html/canvas/Int16Array.idl:
• html/canvas/Int32Array.idl:
• html/canvas/Int8Array.idl:
• html/canvas/Uint16Array.idl:
• html/canvas/Uint32Array.idl:
• html/canvas/Uint8Array.idl:
• html/canvas/Uint8ClampedArray.idl:
• html/canvas/WebGLBuffer.h:

(WebCore::WebGLBuffer::elementArrayBuffer):

• html/canvas/WebGLGetInfo.cpp:
• html/canvas/WebGLGetInfo.h:
• html/canvas/WebGLRenderingContext.cpp:
• html/canvas/WebGLRenderingContext.h:
• inspector/InspectorMemoryAgent.cpp:
• page/Crypto.cpp:
• page/Crypto.h:
• platform/graphics/GraphicsContext3D.cpp:
• platform/graphics/ImageBuffer.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/cg/ImageBufferDataCG.h:
• platform/graphics/filters/FEBlend.cpp:
• platform/graphics/filters/FEColorMatrix.cpp:
• platform/graphics/filters/FEComponentTransfer.cpp:
• platform/graphics/filters/FEComposite.cpp:
• platform/graphics/filters/FEConvolveMatrix.cpp:
• platform/graphics/filters/FECustomFilter.cpp:
• platform/graphics/filters/FEDisplacementMap.cpp:
• platform/graphics/filters/FEDropShadow.cpp:
• platform/graphics/filters/FEGaussianBlur.cpp:
• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMorphology.cpp:
• platform/graphics/filters/FETurbulence.cpp:
• platform/graphics/filters/FilterEffect.cpp:
• platform/graphics/filters/FilterEffect.h:
• platform/graphics/mac/GraphicsContext3DMac.mm:
• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
• testing/Internals.h:
• xml/XMLHttpRequest.cpp:
• xml/XMLHttpRequest.h:

(WebCore::XMLHttpRequest::optionalResponseArrayBuffer):

Source/WTF:

Remove TypedArray implementation from WTF

• GNUmakefile.list.am:
• WTF.xcodeproj/project.pbxproj:
• wtf/Forward.h:

3:11 PM Changeset in webkit [153727] by Lucas Forschler

• 4 edits
  2 copies in branches/safari-537-branch

Merged r153725. <rdar://problem/14637103>

3:05 PM Changeset in webkit [153726] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153724. <rdar://problem/14610818>

2:56 PM Changeset in webkit [153725] by ap@apple.com

• 4 edits
  2 adds in trunk

<rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way
of text when dictating an e-mail
​https://bugs.webkit.org/show_bug.cgi?id=119496

Reviewed by Ryosuke Niwa.

Test: platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html

• rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRectForRange): FloatRect::unite() doesn't preserve empty rects, which we need here. We alrady handle the case of collapsed range in Editor::firstRectForRange(), and this is similar, but we can't currently cover both with one simple fix.

2:26 PM Changeset in webkit [153724] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Ignore the Apple Java placeholder plug-in
​https://bugs.webkit.org/show_bug.cgi?id=119494
<rdar://problem/14610818>

Reviewed by Beth Dakin.

Never attempt to load the Java placeholder plug-in.

• UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin):

2:20 PM Changeset in webkit [153723] by commit-queue@webkit.org

• 3 edits
  6 adds in trunk

Region based columns not painted correctly in non-default writing-modes
​https://bugs.webkit.org/show_bug.cgi?id=118506

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-08-05
Reviewed by David Hyatt.

Source/WebCore:

The column translation offset was calculated incorrectly.
The dirty rect intersection check was also wrong.

Added some documentation, to make it clear what's going on.

Tests: fast/multicol/newmulticol/hide-box-horizontal-bt.html

fast/multicol/newmulticol/hide-box-vertical-lr.html
fast/multicol/newmulticol/hide-box-vertical-rl.html

• rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::collectLayerFragments):

LayoutTests:

• fast/multicol/newmulticol/hide-box-horizontal-bt-expected.html: Added.
• fast/multicol/newmulticol/hide-box-horizontal-bt.html: Added.
• fast/multicol/newmulticol/hide-box-vertical-lr-expected.html: Added.
• fast/multicol/newmulticol/hide-box-vertical-lr.html: Added.
• fast/multicol/newmulticol/hide-box-vertical-rl-expected.html: Added.
• fast/multicol/newmulticol/hide-box-vertical-rl.html: Added.

2:17 PM Changeset in webkit [153722] by commit-queue@webkit.org

• 3 edits
  6 adds in trunk

Region based columns not clipped properly
​https://bugs.webkit.org/show_bug.cgi?id=118499

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-08-05
Reviewed by David Hyatt.

Source/WebCore:

Need to call RenderRegion::overflowRectForFlowThreadPortion() first,
and THEN clip in the column gaps. overflowRectForFlowThreadPortion()
expands the logical left and right to the flow thread's overflow
rectangle, effectively defeating inline direction clipping completely.

Tests: fast/multicol/newmulticol/clipping-overflow-hidden.html

fast/multicol/newmulticol/clipping-top-overflow.html
fast/multicol/newmulticol/clipping.html

• rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):

LayoutTests:

• fast/multicol/newmulticol/clipping-expected.html: Added.
• fast/multicol/newmulticol/clipping-overflow-hidden-expected.html: Added.
• fast/multicol/newmulticol/clipping-overflow-hidden.html: Added.
• fast/multicol/newmulticol/clipping-top-overflow-expected.html: Added.
• fast/multicol/newmulticol/clipping-top-overflow.html: Added.
• fast/multicol/newmulticol/clipping.html: Added.

1:26 PM Changeset in webkit [153721] by commit-queue@webkit.org

• 3 edits in trunk/Tools

[GTK] Implement leak checking with valgrind
​https://bugs.webkit.org/show_bug.cgi?id=118785

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-08-05
Reviewed by Dirk Pranke.

Launch the DRT under Valgrind to generate xml files with details
of leaks found.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

• Scripts/webkitpy/port/gtk.py:

(GtkPort.init):
(GtkPort.default_timeout_ms): Allow extra time to run under
Valgrind.
(GtkPort.setup_environ_for_server): Pass Valgrind instructions
using environment variables.

12:52 PM Changeset in webkit [153720] by fpizlo@apple.com

• 17 edits
  1 add in trunk/Source/JavaScriptCore

Copied space should be able to handle more than one copied backing store per JSCell
​https://bugs.webkit.org/show_bug.cgi?id=119471

Reviewed by Mark Hahnenberg.

This allows a cell to call copyLater() multiple times for multiple different
backing stores, and then have copyBackingStore() called exactly once for each
of those. A token tells it which backing store to copy. All backing stores
must be named using the CopyToken, an enumeration which currently cannot
exceed eight entries.

When copyBackingStore() is called, it's up to the callee to (a) use the token
to decide what to copy and (b) call its base class's copyBackingStore() in
case the base class had something that needed copying. The only exception is
that JSCell never asks anything to be copied, and so if your base is JSCell
then you don't have to do anything.

• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/CopiedBlock.h:
• heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

• heap/CopyToken.h: Added.
• heap/CopyVisitor.cpp:

(JSC::CopyVisitor::copyFromShared):

• heap/CopyVisitor.h:
• heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::visitItem):

• heap/CopyWorkList.h:

(JSC::CopyWorklistItem::CopyWorklistItem):
(JSC::CopyWorklistItem::cell):
(JSC::CopyWorklistItem::token):
(JSC::CopyWorkListSegment::get):
(JSC::CopyWorkListSegment::append):
(JSC::CopyWorkListSegment::data):
(JSC::CopyWorkListIterator::get):
(JSC::CopyWorkListIterator::operator*):
(JSC::CopyWorkListIterator::operator->):
(JSC::CopyWorkList::append):

• heap/SlotVisitor.h:
• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::copyLater):

• runtime/ClassInfo.h:
• runtime/JSCell.cpp:

(JSC::JSCell::copyBackingStore):

• runtime/JSCell.h:
• runtime/JSObject.cpp:

(JSC::JSObject::visitButterfly):
(JSC::JSObject::copyBackingStore):

• runtime/JSObject.h:

12:38 PM Changeset in webkit [153719] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152884. <rdar://problem/14472043>

12:35 PM Changeset in webkit [153718] by Lucas Forschler

• 7 edits in branches/safari-537-branch/Source/WebCore

Merged r152876. <rdar://problem/14472043>

12:31 PM Changeset in webkit [153717] by Lucas Forschler

• 11 edits in branches/safari-537-branch

Merged r153628. <rdar://problem/14498362>

12:27 PM Changeset in webkit [153716] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153377. <rdar://problem/13011371>

12:25 PM Changeset in webkit [153715] by Lucas Forschler

• 17 edits
  6 copies in branches/safari-537-branch

Merged r152861. <rdar://problem/13011371>

11:04 AM Changeset in webkit [153714] by Lucas Forschler

• 5 edits in branches/safari-537-branch/Source/WebCore

Merged r153706. <rdar://problem/14637544>

10:49 AM Changeset in webkit [153713] by Lucas Forschler

• 3 edits in branches/safari-537-branch/Source/WebCore

Merged r153699. <rdar://problem/14643481>

10:42 AM Changeset in webkit [153712] by Lucas Forschler

• 5 edits in branches/safari-537-branch/Source/WebCore

Merged r153696. <rdar://problem/14643349>

10:33 AM Changeset in webkit [153711] by Lucas Forschler

• 3 edits in branches/safari-537-branch/Source/WebCore

Merged r153695. <rdar://problem/14616012>

10:27 AM Changeset in webkit [153710] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153591. <rdar://problem/14616012>

10:20 AM Changeset in webkit [153709] by Lucas Forschler

• 2 edits in branches/safari-537-branch/Source/WTF

Merged r153455. <rdar://problem/14528244>

10:13 AM Changeset in webkit [153708] by Lucas Forschler

• 4 edits
  3 adds in branches/safari-537-branch

Merge patch for <rdar://problem/14624998>

9:26 AM Changeset in webkit [153707] by vivek.vg@samsung.com

• 4 edits in trunk/Source/WebCore

XMLTreeViewer should be created only in the XML viewer mode
​https://bugs.webkit.org/show_bug.cgi?id=119483

Reviewed by Alexey Proskuryakov.

XMLTreeViewer is created even for the XSL transform which is avoided by the patch.
The XMLTreeViewer::hasNoStyleInformation() is moved to XMLDocumentParserLibxml2.cpp
as static inline method as XMLTreeViewer should not have the responsibility for it.
Also removes an unnecessary conditional check while deciding for XML viewer mode.

Blink patch review links:
​https://codereview.chromium.org/19552003/
​https://codereview.chromium.org/22150003/

No new tests as the patch is about code refactoring.

• xml/XMLTreeViewer.cpp:
• xml/XMLTreeViewer.h:
• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::hasNoStyleInformation):
(WebCore::XMLDocumentParser::doEnd):

8:29 AM Changeset in webkit [153706] by jer.noble@apple.com

• 5 edits in trunk/Source/WebCore

Loading a video with a custom URL scheme will result in stalling playback
​https://bugs.webkit.org/show_bug.cgi?id=119469

Reviewed by Eric Carlson.

Break the assumption that only one AVAssetResourceRequest will be outstanding simultaneously
by storing a HashMap of AVAssetResourceRequests and their resulting WebCoreAVFResourceLoader.
When loading is stopped (due to completion or error), notify the MediaPlayerPrivateAVFoundation
parent so that the map can be emptied.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Store the request

in m_resourceLoaderMap.

(WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest): Pull the request from

m_resourceLoaderMap.

(WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest): Remove the requset from

m_resourceLoaderMap.

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::create): Return a PassRefPtr, rather than a PassOwnPtr.
(WebCore::WebCoreAVFResourceLoader::stopLoading): Call didStopLoadingRequest.

7:23 AM Changeset in webkit [153705] by commit-queue@webkit.org

• 47 edits in trunk/LayoutTests

Make tests platform agnostic, fix async tests, remove broken blend modes: hue, saturation, color, luminosity, soft-light.
The test suite should now pass on windows.

​https://bugs.webkit.org/show_bug.cgi?id=119463

Patch by Mihai Tica <​mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

• fast/canvas/canvas-blending-clipping-expected.txt:
• fast/canvas/canvas-blending-clipping.html:
• fast/canvas/canvas-blending-color-over-color-expected.txt:
• fast/canvas/canvas-blending-color-over-color.html:
• fast/canvas/canvas-blending-color-over-gradient-expected.txt:
• fast/canvas/canvas-blending-color-over-gradient.html:
• fast/canvas/canvas-blending-color-over-image-expected.txt:
• fast/canvas/canvas-blending-color-over-image.html:
• fast/canvas/canvas-blending-color-over-pattern-expected.txt:
• fast/canvas/canvas-blending-color-over-pattern.html:
• fast/canvas/canvas-blending-fill-style-expected.txt:
• fast/canvas/canvas-blending-fill-style.html:
• fast/canvas/canvas-blending-global-alpha-expected.txt:
• fast/canvas/canvas-blending-global-alpha.html:
• fast/canvas/canvas-blending-gradient-over-color-expected.txt:
• fast/canvas/canvas-blending-gradient-over-color.html:
• fast/canvas/canvas-blending-gradient-over-gradient-expected.txt:
• fast/canvas/canvas-blending-gradient-over-gradient.html:
• fast/canvas/canvas-blending-gradient-over-image-expected.txt:
• fast/canvas/canvas-blending-gradient-over-image.html:
• fast/canvas/canvas-blending-gradient-over-pattern-expected.txt:
• fast/canvas/canvas-blending-gradient-over-pattern.html:
• fast/canvas/canvas-blending-helpers.js:

(separateBlendFunctions.hardLight):
(nonSeparateBlendFunctions.hue):
(nonSeparateBlendFunctions.saturation):
(nonSeparateBlendFunctions.color):
(nonSeparateBlendFunctions.luminosity):

• fast/canvas/canvas-blending-image-over-color-expected.txt:
• fast/canvas/canvas-blending-image-over-color.html:
• fast/canvas/canvas-blending-image-over-gradient-expected.txt:
• fast/canvas/canvas-blending-image-over-gradient.html:
• fast/canvas/canvas-blending-image-over-image-expected.txt:
• fast/canvas/canvas-blending-image-over-image.html:
• fast/canvas/canvas-blending-image-over-pattern-expected.txt:
• fast/canvas/canvas-blending-image-over-pattern.html:
• fast/canvas/canvas-blending-pattern-over-color-expected.txt:
• fast/canvas/canvas-blending-pattern-over-color.html:
• fast/canvas/canvas-blending-pattern-over-gradient-expected.txt:
• fast/canvas/canvas-blending-pattern-over-gradient.html:
• fast/canvas/canvas-blending-pattern-over-image-expected.txt:
• fast/canvas/canvas-blending-pattern-over-image.html:
• fast/canvas/canvas-blending-pattern-over-pattern-expected.txt:
• fast/canvas/canvas-blending-pattern-over-pattern.html:
• fast/canvas/canvas-blending-shadow-expected.txt:
• fast/canvas/canvas-blending-shadow.html:
• fast/canvas/canvas-blending-text-expected.txt:
• fast/canvas/canvas-blending-text.html:
• fast/canvas/canvas-blending-transforms-expected.txt:
• fast/canvas/canvas-blending-transforms.html:
• platform/win/TestExpectations:

6:09 AM Changeset in webkit [153704] by commit-queue@webkit.org

• 10 edits
  2 adds in trunk

Spatial Navigation should avoid unwanted calculation while deciding focus candidate.
​https://bugs.webkit.org/show_bug.cgi?id=117265

Patch by Abhijeet Kandalkar <​abhijeet.k@samsung.com> on 2013-08-05
Reviewed by Antonio Gomes.

Source/WebCore:

Spatial Navigation should consider only those nodes as candidate which are exactly in the focus-direction.
e.g. If we are moving down then the nodes that are above CURRENT focused node should be considered as invalid.
Added isValidCandidate() which checks whether node is exactly in the focus-direction.

Test: fast/spatial-navigation/snav-search-optimization.html

• page/FocusController.cpp:

(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

• page/Page.cpp:

(WebCore::Page::Page):

• page/Page.h:

(WebCore::Page::setLastSpatialNavigationCandidateCount):
(WebCore::Page::lastSpatialNavigationCandidateCount):

• page/SpatialNavigation.cpp:

(WebCore::isValidCandidate):

• page/SpatialNavigation.h:
• testing/Internals.cpp:

(WebCore::Internals::lastSpatialNavigationCandidateCount):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Added testcases to count how many target nodes were tested before choosing a final target.

• fast/spatial-navigation/snav-search-optimization-expected.txt: Added.
• fast/spatial-navigation/snav-search-optimization.html: Added.

12:58 AM Changeset in webkit [153703] by zandobersek@gmail.com

• 6 edits in trunk

[Automake] Define ENABLE_JIT through the Autoconf header
​https://bugs.webkit.org/show_bug.cgi?id=119445

Reviewed by Martin Robinson.

.:

Instead of defining the ENABLE_JIT value through JSC_CPPFLAGS, the feature define is
set to be either enabled or disabled through the Autoconf header, based on the value
passed through the configuration flag. The 'auto' value is used as default, meaning
that the feature is enabled or disabled in the Platform.h header based on the platform
configuration (OS, architecture etc.).

• Source/autotools/FindDependencies.m4: Remove the JSC_CPPFLAGS definition.
• Source/autotools/ReadCommandLineArguments.m4: Change the default value to 'auto' instead

of 'autodetect', as used by other configuration options that take a similar approach to enabling
a specific feature.

• Source/autotools/SetupAutoconfHeader.m4: Set a strict value for the ENABLE_JIT define through

the Autoconf header if the feature was specifically enabled or disabled.

Source/JavaScriptCore:

• GNUmakefile.am: Remove JSC_CPPFLAGS from the cpp flags for the JSC library.

12:16 AM Changeset in webkit [153702] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

Source/WebCore: [CSS Background Blending] Specifying background-image and background-color
with opaque image doesn't trigger blending. The fix consists of adding a
check whether blend mode is set in hasOpaqueImage.

​https://bugs.webkit.org/show_bug.cgi?id=119434

Patch by Mihai Tica <​mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-separate-layer-declaration.html

• rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):

LayoutTests: [CSS Background Blending] Specifying background-image and background-color with opaque
image doesn't trigger blending. Adding ref test to validate the fix.

​https://bugs.webkit.org/show_bug.cgi?id=119434i

Patch by Mihai Tica <​mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

• css3/compositing/background-blend-mode-separate-layer-declaration-expected.html: Added.
• css3/compositing/background-blend-mode-separate-layer-declaration.html: Added.
• css3/compositing/resources/gray_square.svg: Added.