⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 7, 2013:

11:28 PM Changeset in webkit [153814] by abucur@adobe.com
  • 12 edits
    12 adds in trunk

[CSS Regions] Propagate overflow from the flow thread to the first and last region
https://bugs.webkit.org/show_bug.cgi?id=118526

Reviewed by David Hyatt.

Source/WebCore:

The patch implements layout overflow propagation for the first and last regions. The approach
taken is triggering a simple layout on the regions after the named flows are laid out
that extracts the layout overflow from the flow thread and adds it to the regions.

The process is based on adding two new layout phases: the overflow phase and the final phase.
The overflow phase is set after the flow threads are laid out and it marks the regions as
needing to extract the overflow from the flow thread. In case there are blocks with auto overflow
it's possible the overflow to create scrollbars that shrink the regions. In this case the flow
thread is relaid out and set in the final phase, forcing the regions to recollect the layout
overflow. In theory this would be an N-step layout because scrollbars can force content to change
regions and create overflow for other blocks (and thus creating more scrollbars). For now, we are
limiting this to the first pass by inserting this new final layout phase.

A short description of the processing model for a document:

  • layout the document (all the flow threads should be in the constrained layout phase after this step)
  • reverse iterate through the flow threads and mark the regions for simplified layout (we need to

reverse iterate so the overflow can correctly propagate with nested regions)

  • if the layout changes the size of a region, invalidate the flow thread and when laying it out mark

it as needing a new pass

  • make a secondary pass through the flow threads that changed after scrollbars have been added and

recompute the overflow for their regions; mark the flow threads in the final phase (flow threads can't
be invalidated in the final phase)

  • after the overflow was propagated update all the flow threads in the normal layout phase

There are some issues with the patch:

  • the simplified layout doesn't compute correct overflow values for inline blocks
  • the layout overflow from the flow thread doesn't take the region size into account

The first issue is not related to regions and will be fixed in a future patch. The second issue
will be fixed when box overflow will be region bound.

Tests: fast/regions/overflow-scrollable-1.html

fast/regions/overflow-scrollable-2.html
fast/regions/overflow-scrollable-3.html
fast/regions/overflow-scrollable-fit-complex.html
fast/regions/overflow-scrollable-fit.html
fast/regions/overflow-scrollable-nested.html

  • rendering/FlowThreadController.cpp: Flow threads layout driver functions.

(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoOverflowPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoFinalPhase):

  • rendering/FlowThreadController.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedNormalFlowLayout):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::firstRegion): This getter should work even though the region chain is invalid.
(WebCore::RenderFlowThread::lastRegion): This getter should work even though the region chain is invalid.
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded): If the flow thread has no overflow do nothing.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::maxPageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Used to get the flow thread visual or layout overflow.
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::updateLogicalHeight):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::layoutContentToComputeOverflowInRegions):
(WebCore::RenderView::layout):

  • rendering/RenderView.h:

LayoutTests:

Add tests for scrolling of regions in containers in different situations: regions with
transforms, nested regions, regions affected by scrollbars etc.

  • fast/regions/overflow-scrollable-1-expected.html: Added.
  • fast/regions/overflow-scrollable-1.html: Added.
  • fast/regions/overflow-scrollable-2-expected.html: Added.
  • fast/regions/overflow-scrollable-2.html: Added.
  • fast/regions/overflow-scrollable-3-expected.html: Added.
  • fast/regions/overflow-scrollable-3.html: Added.
  • fast/regions/overflow-scrollable-fit-complex-expected.html: Added.
  • fast/regions/overflow-scrollable-fit-complex.html: Added.
  • fast/regions/overflow-scrollable-fit-expected.html: Added.
  • fast/regions/overflow-scrollable-fit.html: Added.
  • fast/regions/overflow-scrollable-nested-expected.txt: Added.
  • fast/regions/overflow-scrollable-nested.html: Added.
9:20 PM Changeset in webkit [153813] by benjamin@webkit.org
  • 1 edit
    3 adds in trunk/Websites/webkit.org

Update the images for the blog size-matters

  • blog-files/size-matters/JavaScriptCore-relative-binary-growth.png: Added.
  • blog-files/size-matters/WebCore-relative-binary-growth.png: Added.
  • blog-files/size-matters/WebKit-relative-binary-growth.png: Added.
9:08 PM Changeset in webkit [153812] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix on Efl port after r153785.

  • CMakeLists.txt: Added "${WEBCORE_DIR}/style" in include list.
7:13 PM Changeset in webkit [153811] by Simon Fraser
  • 2 edits in trunk/Tools

Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
https://bugs.webkit.org/show_bug.cgi?id=119317

Reviewed by Tim Horton.

The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
the test to complete, which is not power friendly. Although DRT instances
are generally busy anyway, not sitting in a busy loop should free up some CPU
cycles for other instances of DRT.

Editing tests continue to pass. All Java tests are skipped and were not
tested, but when run fail similarly with and without the patch.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump):
(runTest):

7:00 PM Changeset in webkit [153810] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Avoid spurious "all repaint" layouts when scrolling WebViews on Retina displays
https://bugs.webkit.org/show_bug.cgi?id=119564

Reviewed by Beth Dakin.

When scrolling WebViews on Macs with Retina displays, AppKit uses
device pixels for the scroll offset, so [scrollView() documentVisibleRect]
can return a CGRect with non-integral origin. This rect is used by layout,
via layoutSize(), to decide whether the view size changed, which prompts
a full repaint. However, FrameView gets a value which has been rounded
by enclosingIntRect(), which increases the height or width by 1px if the
y or x offset is on a half-pixel, causing spurious full repaints.

Fix by plumbing through platformVisibleContentSize(), which just
gets the size of the -documentVisibleRect.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Don't get layoutHeight and layoutWidth
separately, since that is two calls down into platformVisibleContentSize.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::platformVisibleContentSize):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformVisibleContentSize):

6:31 PM Changeset in webkit [153809] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Be more aggressive about sending fake mouse events less frequently
https://bugs.webkit.org/show_bug.cgi?id=119563
<rdar://problem/14669029>

Reviewed by Tim Horton.

r109151 added code that throttles back the fake mouse events that we
send during scrolling, but in such a way that a page could take up to
100ms to handle a single mousemove, and we'd still send fake mousemove
events every 100ms. This could cause serious scrolling stutter.

Fix by changing when we drop back to sending events every 250ms, rather than every
100ms: if the slowest mousemove takes 10ms or more (less than one frame), drop back
to a 250ms fake move interval.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):

5:51 PM Changeset in webkit [153808] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove pointless const in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=119550

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-07
Reviewed by Rob Buis.
Internally reviewed by Leo Yang and Mike Fenton.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
(BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):

  • WebKitSupport/InputHandler.h:
4:05 PM Changeset in webkit [153807] by cavalcantii@gmail.com
  • 2 edits in trunk/Source/WebCore

[rendering] Implement PaintInfo interfaces
https://bugs.webkit.org/show_bug.cgi?id=119388

Reviewed by Benjamin Poulain.

In discussion in IRC, it was decided to remove this comment since implementing such change
would have a vast impact on rendering classes.

  • rendering/PaintInfo.h:
3:41 PM Changeset in webkit [153806] by Lucas Forschler
  • 8 edits in branches/safari-537-branch/Source

Merged r153775. <rdar://problem/14517392>

3:16 PM Changeset in webkit [153805] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Don't remove contents layer from its parent unless necessary
https://bugs.webkit.org/show_bug.cgi?id=119560

Reviewed by Simon Fraser.

RenderLayerBacking::updateInternalHierarchy() is called in some
instances where there doesn't need to be a complete reparenting of the
the m_graphicsLayer. For example, on OS X when the user changes the
scrollbar styles to/from always visible. We don't need to always
remove the graphics layer from its parent - any reparenting does that
automatically.

Unfortunately we can't trigger this situation in an automated test.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateInternalHierarchy): Don't call removeFromParent().

3:00 PM Changeset in webkit [153804] by dbates@webkit.org
  • 2 edits in trunk/Tools

Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
<https://bugs.webkit.org/show_bug.cgi?id=119558>

Reviewed by Martin Robinson.

Currently we build the command line to execute jsDriver.pl twice so as to both
print it to standard output and actually execute it. We should only build up
this command line once. Moreover, we should print to standard output the actual
command line that we are going to use including the GTK- and EFL-specific call
to /Tools/jhbuild/jhbuild-wrapper.

  • Scripts/run-javascriptcore-tests:
2:49 PM Changeset in webkit [153803] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merge patch for <rdar://problem/14655517>

2:44 PM Changeset in webkit [153802] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merged r153793. <rdar://problem/14666354>

2:38 PM Changeset in webkit [153801] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

Fixed wrong definition for AppleWin port's WebGL after r153768.

Rubberstamped by Benjamin Poulain.

  • wtf/Platform.h: Replaced WTF_USE_SURFACE with WTF_USE_GRAPHICS_SURFACE.
2:31 PM Changeset in webkit [153800] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153773. <rdar://problem/14652681>

2:27 PM Changeset in webkit [153799] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-537-branch

Merged r153374. <rdar://problem/14443495>

2:13 PM Changeset in webkit [153798] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] REGRESSION after r153432: some accessibility tests crash.
https://bugs.webkit.org/show_bug.cgi?id=119333

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-08-07
Reviewed by Darin Adler.

Use a RefPtr to store a reference to the parent element of
an AccessibilityUIElement instead of the raw pointer, so we
never derefence a function from an invalid pointer.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.

12:52 PM Changeset in webkit [153797] by timothy_horton@apple.com
  • 7 edits
    3 adds in trunk

Fall out of simple image layer optimization if the image has EXIF rotation
https://bugs.webkit.org/show_bug.cgi?id=119535
<rdar://problem/14071174>

Reviewed by Simon Fraser.

Test: fast/images/exif-orientation-composited.html

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameOrientationAtIndex):
Ensure that the frame is cached if we're requesting the orientation,
so we can acquire orientation information at any given time.

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageFromImage):

  • platform/graphics/BitmapImage.h:

Rename currentFrameOrientation to frameOrientationForCurrentFrame to match
the similarly-behaving nativeImageForCurrentFrame.

  • platform/graphics/Image.h:

(WebCore::Image::orientationForCurrentFrame): Added. Virtual, overriden by BitmapImage.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
If the given image has a non-default image orientation, don't use direct compositing.

Add a test that ensures that composited images with EXIF orientation paint correctly.

  • fast/images/exif-orientation-composited-expected.txt: Added.
  • fast/images/exif-orientation-composited.html: Added.
  • platform/mac/fast/images/exif-orientation-composited-expected.png: Added.
12:13 PM Changeset in webkit [153796] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

fast/frames/seamless/seamless-custom-font-pruning-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=119557

Rubber-stamped by Eric Carlson.

Pass Style::Detach style change to seamless document as Style::Force. Style::resolveTree does not expect to be called with Detach.

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::didRecalcStyle):

11:40 AM Changeset in webkit [153795] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data
https://bugs.webkit.org/show_bug.cgi?id=115354

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-08-07
Reviewed by Philippe Normand.

The default value for the HTTP "Accept-Encoding:" header field in the request allows
compressed data to be received on requests.
While this works fine for most cases, it can break the webkit source that needs to rely on the
the proper data size when receiving the response (even though the received data is already
uncompressed the size reported in ResourceResponse::expectedContentLength() is the same
represented by the HTTP header field "Content-Length" which is the size of the compressed data).

This patch disables the HTTP "Accept-Encoding:" header field when using the request
as we don't want the received response to be encoded in any way, as we need to rely on the proper
size of the returned data on ResourceHandle::didReceiveResponse().

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/soup/ResourceRequest.h:

(ResourceRequestBase):
(WebCore::ResourceRequest::acceptEncoding):
(WebCore::ResourceRequest::setAcceptEncoding):
(WebCore::ResourceRequest::ResourceRequestBase):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

11:40 AM Changeset in webkit [153794] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit/win

Try to fix Win WK1 build.

Not reviewed.

  • WebFrame.cpp:

(WebFrame::invalidate):

11:36 AM Changeset in webkit [153793] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state
https://bugs.webkit.org/show_bug.cgi?id=119555

Reviewed by Geoffrey Garen.

It uses a speculationCheck where it should be using a DFG_TYPE_CHECK like the 64-bit backend does.
This was causing crashes on maps.google.com in 32-bit debug builds.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:30 AM Changeset in webkit [153792] by ctruta@gmail.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
9:56 AM Changeset in webkit [153791] by allan.jensen@digia.com
  • 2 edits in trunk/LayoutTests

[Qt] Skip background-blending-mode tests

Unreviewed gardening.

  • platform/qt/TestExpectations:
9:34 AM Changeset in webkit [153790] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r) Two pixel result fail after r153522
https://bugs.webkit.org/show_bug.cgi?id=119392

Reviewed by Jocelyn Turcotte.

Consider scaling transform on the painter to determine final destination size.

Covered by existing tests.

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::prescaleImageIfRequired):
(WebCore::BitmapImage::draw):

9:17 AM Changeset in webkit [153789] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=119405

Reviewed by Geoffrey Garen.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString): For X86 32 bit, construct an indexed address
ourselves to save a register and then load from it.

8:02 AM Changeset in webkit [153788] by Antti Koivisto
  • 6 edits in trunk

2.5% regression on page cycler moz
https://bugs.webkit.org/show_bug.cgi?id=102822

Source/WebCore:

Reviewed by Andreas Kling.

DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache() triggers a style recalc for quirks mode
documents in the beginning of document parsing via Document::setCompatibilityMode. This often coalesces
with style recalc triggered by stylesheet loading. However on very simple documents it can generate genuinely
unnecessary work.

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):

Check that we actually have cached injected stylesheets before triggering style recalc.


  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):

Fix a misspelling.

(WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):

Always invalidate style when user sheets change since we don't do that in
DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache anymore.

  • page/PageGroup.h:

LayoutTests:

Reviewed by Andreas Kling.

This is a progression.

  • inspector/timeline/timeline-script-tag-1-expected.txt:
8:00 AM Changeset in webkit [153787] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Do no check seek offset against internal size on gstreamer source element
https://bugs.webkit.org/show_bug.cgi?id=116533

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-08-07
Reviewed by Philippe Normand.

The internal size on gstreamer source element may be wrong in case the received size in
didReceiveResponse is not accurate. Lets just try to seek and let it fail if necessary.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcSeekDataCb):

7:31 AM Changeset in webkit [153786] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit2

Try to fix EFL build.

Not reviewed.

  • CMakeLists.txt:
7:22 AM Changeset in webkit [153785] by Antti Koivisto
  • 10 edits
    2 moves
    1 add in trunk/Source/WebCore

Create WebCore/style and move StyleResolveTree there
https://bugs.webkit.org/show_bug.cgi?id=119543

Reviewed by Andreas Kling.

WebCore/css is bloated. We should move the internal style representation and the style resolver
related code to a directory of their own. CSS language related code including parser and
CSSOM stays under css.

Things named StyleFoo should generally move under WebCore/style. They should also be moved to
the Style namespace at the same time.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.pri:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCoreCommon.props:
  • WebCore.vcxproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • css/StyleResolveTree.cpp: Removed.
  • css/StyleResolveTree.h: Removed.
  • style: Added.
  • style/StyleResolveTree.cpp: Copied from Source/WebCore/css/StyleResolveTree.cpp.
  • style/StyleResolveTree.h: Copied from Source/WebCore/css/StyleResolveTree.h.
6:42 AM Changeset in webkit [153784] by commit-queue@webkit.org
  • 1 edit
    17 adds in trunk/LayoutTests

[CSS Blending] Add test suite to validate background blending with different properties
https://bugs.webkit.org/show_bug.cgi?id=118243

Patch by Mirela Budaes <mbudaes@adobe.com> on 2013-08-07
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-background-attachement-fixed-expected.html: Added.
  • css3/compositing/background-blend-mode-background-attachement-fixed.html: Added.
  • css3/compositing/background-blend-mode-background-clip-content-box-expected.html: Added.
  • css3/compositing/background-blend-mode-background-clip-content-box.html: Added.
  • css3/compositing/background-blend-mode-background-clip-padding-box-expected.html: Added.
  • css3/compositing/background-blend-mode-background-clip-padding-box.html: Added.
  • css3/compositing/background-blend-mode-background-origin-border-box-expected.html: Added.
  • css3/compositing/background-blend-mode-background-origin-border-box.html: Added.
  • css3/compositing/background-blend-mode-background-position-percentage-expected.html: Added.
  • css3/compositing/background-blend-mode-background-position-percentage.html: Added.
  • css3/compositing/background-blend-mode-background-repeat-no-repeat-expected.html: Added.
  • css3/compositing/background-blend-mode-background-repeat-no-repeat.html: Added.
  • css3/compositing/background-blend-mode-background-size-contain-expected.html: Added.
  • css3/compositing/background-blend-mode-background-size-contain.html: Added.
  • css3/compositing/background-blend-mode-background-size-cover-expected.html: Added.
  • css3/compositing/background-blend-mode-background-size-cover.html: Added.
  • css3/compositing/resources/white_square.svg: Added.
5:02 AM Changeset in webkit [153783] by Antti Koivisto
  • 42 edits
    2 adds in trunk/Source/WebCore

Move style recalculation out from Element
https://bugs.webkit.org/show_bug.cgi?id=119497

Reviewed by Andreas Kling.

Element currently does too much. Element::recalcStyle() and the related functions can be turned into
standalone functions that operate on DOM tree. This will also give more freedom for future refactoring,
for example making style recalculation non-recursive.

  • WebCore.xcodeproj/project.pbxproj:
  • css/StyleResolveTree.cpp: Added.

(WebCore::Style::determineChange):

  • moved and renamed from Node::diff
  • factored to use early return style
  • simplifield the null input logic

(WebCore::Style::pseudoStyleCacheIsInvalid):

  • moved from Element::pseudoStyleCacheIsInvalid
  • narrowed to take RenderObject rather than operate on Element

(WebCore::Style::resolveLocal):

  • split from Element::recalcStyle
  • factored to use early return style

(WebCore::Style::resolveTree):

  • moved and renamed from Element::recalcStyle
  • css/StyleResolveTree.h: Added.


  • introcuduce Style namespace for style related classes and functions
  • move and rename Node::StyleChange -> Style::Change
  • css/StyleResolver.h:

(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
(WebCore::StyleResolverParentPusher::push):
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):

Moved this stack helper to StyleResolver.h for now since it is needed by both
StyleRecalculation and Element.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::attach):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::webkitWillEnterFullScreenForElement):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::shouldIgnoreAttributeCase):
(WebCore::Element::updatePseudoElement):
(WebCore::Element::resetComputedStyle):
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):

  • dom/Element.h:


  • remove Element::recalcStyle
  • make a few private functions needed by StyleRecalculation public
  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::recalcStyle):

  • dom/ElementShadow.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • remove Node::StyleChange
  • remove Node::diff
  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::didRecalcStyle):

  • dom/PseudoElement.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):
(WebCore::ShadowRoot::setResetStyleInheritance):

  • dom/ShadowRoot.h:
  • dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

  • dom/Text.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::didRecalcStyle):

  • html/HTMLFormControlElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::willRecalcStyle):

  • html/HTMLFrameSetElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::didRecalcStyle):

  • html/HTMLIFrameElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didRecalcStyle):

  • html/HTMLMediaElement.h:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::didRecalcStyle):

  • html/HTMLOptionElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):

  • html/HTMLPlugInImageElement.h:
  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::reportDataReceived):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::willRecalcStyle):

  • svg/SVGElement.h:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::willRecalcStyle):

  • svg/SVGUseElement.h:
4:41 AM Changeset in webkit [153782] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Build fix after r153751

Unreviewed build fix.

Fix build when PAGE_VISIBILITY_API is disabled.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::visibilityState):

2:11 AM Changeset in webkit [153781] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Wrong auto-height region computation for nested named flows
https://bugs.webkit.org/show_bug.cgi?id=119517

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/abspos-autoheight-nested-region.html

In the case of an (inner) auto-height region that is absolutely positioned in a named flow that is displayed in an (outer) auto-height region,
when we are doing the layout for the named flow we need to add a "forced region break" also for the case of simplified layout, otherwise
the outer auto-height region will not get the chance to compute its auto-height, ending up with a huge value that was used to initialize
the auto-height computed value before the start of the layout algorithm.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedLayout):

LayoutTests:

  • fast/regions/abspos-autoheight-nested-region-expected.txt: Added.
  • fast/regions/abspos-autoheight-nested-region.html: Added.
2:09 AM Changeset in webkit [153780] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] REGRESSION after r153432: marking crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=119539

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-08-07

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
12:19 AM Changeset in webkit [153779] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/win

Remove dependency on CoreFoundation from WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=119390

Reviewed by Brent Fulgham.

  • WebURLResponse.cpp:

(localizedShortDescriptionForStatusCode):
(WebURLResponse::localizedStringForStatusCode):

Aug 6, 2013:

9:04 PM Changeset in webkit [153778] by fpizlo@apple.com
  • 9 edits
    3 adds in trunk

DFG FixupPhase should insert Int32ToDouble nodes for number uses in NewArray, and SpeculativeJIT 64-bit should not try to coerce integer constants to double constants
https://bugs.webkit.org/show_bug.cgi?id=119528

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Either of the two fixes would solve the crash I saw. Basically, for best performance, we want the DFG register allocator to track double uses and non-double
uses of a node separately, and we accomplish this by inserting Int32ToDouble nodes in the FixupPhase. But even if FixupPhase fails to do this, we still want
the DFG register allocator to do the right thing: if it encounters a double use of an integer, it should perform a conversion and preserve the original
format of the value (namely, that it was an integer). For constants, the best format to preserve is None, so that future integer uses rematerialize the int
from scratch. This only affects the 64-bit backend; the 32-bit backend was already doing the right thing.

This also fixes some more debug dumping code, and adds some stronger assertions for integer arrays.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

  • runtime/JSObject.h:

(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):

LayoutTests:

  • fast/js/dfg-new-array-double-const-then-int-const.html: Added.
  • fast/js/dfg-new-array-double-const-then-int-const-expected.txt: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-new-array-double-const-then-int-const.js: Added.

(bar):
(foo):

8:07 PM Changeset in webkit [153777] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

8:05 PM Changeset in webkit [153776] by Lucas Forschler
  • 1 copy in tags/Safari-537.55

New Tag.

7:41 PM Changeset in webkit [153775] by Stephanie Lewis
  • 8 edits in trunk/Source

Update Order Files for Safari
<rdar://problem/14517392>

Unreviewed.

Source/JavaScriptCore:

Source/WebCore:

No change in functionality.

  • WebCore.order:

Source/WebKit/mac:

  • WebKit.order:

Source/WebKit2:

  • mac/WebKit2.order:
5:19 PM Changeset in webkit [153774] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Assertion failure in emitExpressionInfo when reloading with Web Inspector open.
https://bugs.webkit.org/show_bug.cgi?id=119532.

Reviewed by Oliver Hunt.

  • parser/Parser.cpp:

(JSC::::Parser):

  • Just need to initialize the Parser's JSTokenLocation's initial line and startOffset as well during Parser construction.
5:13 PM Changeset in webkit [153773] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when entering fullscreen video playback from a WebView using WebKit2
https://bugs.webkit.org/show_bug.cgi?id=119531

Reviewed by Tim Horton.

Initialize wkWindowSetScaledFrame and wkWindowSetAlpha when initializing WebCoreSystemInterface.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:22 PM Changeset in webkit [153772] by weinig@apple.com
  • 75 edits
    15 deletes in trunk

.: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore: Remove support for HTML5 Microdata
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

  • bindings/js/JSHTMLElementCustom.cpp:
  • bindings/js/JSMicroDataItemValueCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::ensureCachedHTMLCollection):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeListBase::rootNode):
(WebCore::LiveNodeListBase::invalidateCache):
(WebCore::LiveNodeList::namedItem):

  • dom/LiveNodeList.h:

(WebCore::LiveNodeListBase::shouldInvalidateTypeOnAttributeChange):

  • dom/MicroDataItemList.cpp: Removed.
  • dom/MicroDataItemList.h: Removed.
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/NodeRareData.cpp:
  • dom/NodeRareData.h:
  • dom/PropertyNodeList.cpp: Removed.
  • dom/PropertyNodeList.h: Removed.
  • dom/PropertyNodeList.idl: Removed.
  • html/CollectionType.h:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp:
  • html/HTMLAreaElement.h:
  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isMatchingElement):
(WebCore::LiveNodeListBase::item):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::isURLAttribute):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:
  • html/HTMLImageElement.h:
  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLMetaElement.cpp:
  • html/HTMLMetaElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLPropertiesCollection.cpp: Removed.
  • html/HTMLPropertiesCollection.h: Removed.
  • html/HTMLPropertiesCollection.idl: Removed.
  • html/HTMLSourceElement.cpp:
  • html/HTMLSourceElement.h:
  • html/HTMLTrackElement.cpp:
  • html/HTMLTrackElement.h:
  • html/MicroDataAttributeTokenList.cpp: Removed.
  • html/MicroDataAttributeTokenList.h: Removed.
  • html/MicroDataItemValue.cpp: Removed.
  • html/MicroDataItemValue.h: Removed.
  • html/MicroDataItemValue.idl: Removed.

Source/WebKit/blackberry: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/mac: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • wtf/FeatureDefines.h:

Tools: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

LayoutTests: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • fast/dom/MicroData: Removed.
  • fast/dom/MicroData/001-expected.txt: Removed.
  • fast/dom/MicroData/001.html: Removed.
  • fast/dom/MicroData/002-expected.txt: Removed.
  • fast/dom/MicroData/002.html: Removed.
  • fast/dom/MicroData/003-expected.txt: Removed.
  • fast/dom/MicroData/003.html: Removed.
  • fast/dom/MicroData/004-expected.txt: Removed.
  • fast/dom/MicroData/004.html: Removed.
  • fast/dom/MicroData/005-expected.txt: Removed.
  • fast/dom/MicroData/005.html: Removed.
  • fast/dom/MicroData/006-expected.txt: Removed.
  • fast/dom/MicroData/006.html: Removed.
  • fast/dom/MicroData/007-expected.txt: Removed.
  • fast/dom/MicroData/007.html: Removed.
  • fast/dom/MicroData/008-expected.txt: Removed.
  • fast/dom/MicroData/008.html: Removed.
  • fast/dom/MicroData/009-expected.txt: Removed.
  • fast/dom/MicroData/009.html: Removed.
  • fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree-expected.txt: Removed.
  • fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree.html: Removed.
  • fast/dom/MicroData/domsettabletokenlist-attributes-add-token-expected.txt: Removed.
  • fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html: Removed.
  • fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index-expected.txt: Removed.
  • fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html: Removed.
  • fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Removed.
  • fast/dom/MicroData/element-with-empty-itemprop.html: Removed.
  • fast/dom/MicroData/getitems-empty-string-as-arg-expected.txt: Removed.
  • fast/dom/MicroData/getitems-empty-string-as-arg.html: Removed.
  • fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Removed.
  • fast/dom/MicroData/getitems-multiple-itemtypes.html: Removed.
  • fast/dom/MicroData/item-not-attached-to-domtree-expected.txt: Removed.
  • fast/dom/MicroData/item-not-attached-to-domtree.html: Removed.
  • fast/dom/MicroData/item-with-itemprop-attr-expected.txt: Removed.
  • fast/dom/MicroData/item-with-itemprop-attr.html: Removed.
  • fast/dom/MicroData/item-with-itemref-pointing-to-itself-expected.txt: Removed.
  • fast/dom/MicroData/item-with-itemref-pointing-to-itself.html: Removed.
  • fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Removed.
  • fast/dom/MicroData/itemid-attribute-test-001.html: Removed.
  • fast/dom/MicroData/itemid-attribute-test-expected.txt: Removed.
  • fast/dom/MicroData/itemid-attribute-test.html: Removed.
  • fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Removed.
  • fast/dom/MicroData/itemid-must-see-resolved-url.html: Removed.
  • fast/dom/MicroData/itemprop-add-remove-tokens-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-add-remove-tokens.html: Removed.
  • fast/dom/MicroData/itemprop-for-an-element-must-be-correct-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html: Removed.
  • fast/dom/MicroData/itemprop-must-be-read-only-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-must-be-read-only.html: Removed.
  • fast/dom/MicroData/itemprop-names-override-builtin-properties-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-names-override-builtin-properties.html: Removed.
  • fast/dom/MicroData/itemprop-reflected-by-itemProp-property-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html: Removed.
  • fast/dom/MicroData/itemref-add-remove-tokens-expected.txt: Removed.
  • fast/dom/MicroData/itemref-add-remove-tokens.html: Removed.
  • fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property-expected.txt: Removed.
  • fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html: Removed.
  • fast/dom/MicroData/itemref-for-an-element-must-be-correct-expected.txt: Removed.
  • fast/dom/MicroData/itemref-for-an-element-must-be-correct.html: Removed.
  • fast/dom/MicroData/itemref-must-be-read-only-expected.txt: Removed.
  • fast/dom/MicroData/itemref-must-be-read-only.html: Removed.
  • fast/dom/MicroData/itemref-pointing-to-root-node-expected.txt: Removed.
  • fast/dom/MicroData/itemref-pointing-to-root-node.html: Removed.
  • fast/dom/MicroData/itemref-refers-first-element-with-given-id-expected.txt: Removed.
  • fast/dom/MicroData/itemref-refers-first-element-with-given-id.html: Removed.
  • fast/dom/MicroData/itemscope-attribute-test-expected.txt: Removed.
  • fast/dom/MicroData/itemscope-attribute-test.html: Removed.
  • fast/dom/MicroData/itemscope-must-be-read-write-expected.txt: Removed.
  • fast/dom/MicroData/itemscope-must-be-read-write.html: Removed.
  • fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Removed.
  • fast/dom/MicroData/itemtype-add-remove-tokens.html: Removed.
  • fast/dom/MicroData/itemtype-attribute-test-expected.txt: Removed.
  • fast/dom/MicroData/itemtype-attribute-test.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-href-attr-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-href-attr.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-the-src-attr-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-the-src-attr.html: Removed.
  • fast/dom/MicroData/itemvalue-returns-element-itself-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-returns-element-itself.html: Removed.
  • fast/dom/MicroData/itemvalue-returns-null-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-returns-null.html: Removed.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html: Removed.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html: Removed.
  • fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens-expected.txt: Removed.
  • fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens.html: Removed.
  • fast/dom/MicroData/nameditem-must-be-case-sensitive-expected.txt: Removed.
  • fast/dom/MicroData/nameditem-must-be-case-sensitive.html: Removed.
  • fast/dom/MicroData/nameditem-must-return-correct-item-properties-expected.txt: Removed.
  • fast/dom/MicroData/nameditem-must-return-correct-item-properties.html: Removed.
  • fast/dom/MicroData/nameditem-returns-propertynodelist-expected.txt: Removed.
  • fast/dom/MicroData/nameditem-returns-propertynodelist.html: Removed.
  • fast/dom/MicroData/names-item-out-of-range-index-expected.txt: Removed.
  • fast/dom/MicroData/names-item-out-of-range-index.html: Removed.
  • fast/dom/MicroData/names-property-must-be-correct-expected.txt: Removed.
  • fast/dom/MicroData/names-property-must-be-correct.html: Removed.
  • fast/dom/MicroData/names-property-test-expected.txt: Removed.
  • fast/dom/MicroData/names-property-test.html: Removed.
  • fast/dom/MicroData/properties-collection-add-remove-itemref-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-add-remove-itemref.html: Removed.
  • fast/dom/MicroData/properties-collection-add-remove-property-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-add-remove-property.html: Removed.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html: Removed.
  • fast/dom/MicroData/properties-collection-must-be-correct-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-must-be-correct.html: Removed.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html: Removed.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html: Removed.
  • fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html: Removed.
  • fast/dom/MicroData/properties-collection-nameditem-test-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-nameditem-test.html: Removed.
  • fast/dom/MicroData/properties-collection-test-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-test.html: Removed.
  • fast/dom/MicroData/propertiescollection-crash-expected.txt: Removed.
  • fast/dom/MicroData/propertiescollection-crash.html: Removed.
  • fast/dom/MicroData/propertiescollection-on-changing-id-attr-expected.txt: Removed.
  • fast/dom/MicroData/propertiescollection-on-changing-id-attr.html: Removed.
  • fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens.html: Removed.
  • fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens.html: Removed.
  • fast/dom/MicroData/propertynodelist-crash-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-crash.html: Removed.
  • fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html: Removed.
  • fast/dom/MicroData/propertynodelist-getvalues-test-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-getvalues-test.html: Removed.
  • fast/dom/MicroData/propertynodelist-test-add-remove-element-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-test-add-remove-element.html: Removed.
  • fast/dom/MicroData/resources: Removed.
  • fast/dom/MicroData/resources/microdata-common.js: Removed.
4:21 PM Changeset in webkit [153771] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebCore

Remove PlatformCALayer::contentsTransform and ::setContentsTransform
https://bugs.webkit.org/show_bug.cgi?id=119529

Reviewed by Sam Weinig.

No new tests, removing dead code.

These methods are not used and are currently unimplemented.

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
4:01 PM Changeset in webkit [153770] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Implement gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=102643

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-08-06
Reviewed by Gyuyoung Kim.

Recognize tap, pan and pinch gestures using touch events.
The tap gesture is separated into single tap, double tap and
'tap and hold'.

This patch references the webkit NIX port.
https://github.com/WebKitNix/webkitnix

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::doneWithTouchEvent):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/GestureRecognizer.cpp: Added.

(WebKit::GestureHandler::create):
(WebKit::GestureHandler::GestureHandler):
(WebKit::GestureHandler::handleSingleTap):
(WebKit::GestureHandler::handleDoubleTap):
(WebKit::GestureHandler::handleTapAndHold):
(WebKit::GestureHandler::handlePanStarted):
(WebKit::GestureHandler::handlePan):
(WebKit::GestureHandler::handlePanFinished):
(WebKit::GestureHandler::handlePinchStarted):
(WebKit::GestureHandler::handlePinch):
(WebKit::GestureHandler::handlePinchFinished):
(WebKit::GestureRecognizer::GestureRecognizer):
(WebKit::GestureRecognizer::~GestureRecognizer):
(WebKit::GestureRecognizer::processTouchEvent):
(WebKit::GestureRecognizer::doubleTapTimerCallback):
(WebKit::GestureRecognizer::tapAndHoldTimerCallback):
(WebKit::GestureRecognizer::exceedsPanThreshold):
(WebKit::GestureRecognizer::exceedsDoubleTapThreshold):
(WebKit::getPointAtIndex):
(WebKit::createVectorWithWKArray):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::singleTapGesture):
(WebKit::GestureRecognizer::doubleTapGesture):
(WebKit::GestureRecognizer::panGesture):
(WebKit::GestureRecognizer::pinchGesture):
(WebKit::GestureRecognizer::reset):
(WebKit::GestureRecognizer::stopTapTimers):

  • UIProcess/API/efl/GestureRecognizer.h: Added.

(WebKit::GestureRecognizer::create):

3:16 PM Changeset in webkit [153769] by hmuller@adobe.com
  • 6 edits in trunk/LayoutTests

[CSS Shapes] New positioning model: scripted shape-margin tests
https://bugs.webkit.org/show_bug.cgi?id=119491

Update some of the shape-margin tests to work with the new positioning model. Floats
that specify shape-outside are now positioned according to their margin box, not the
bounding box of the shape-outside shape. The tests have been revised to reflect the
change.

Reviewed by Alexandru Chiculita.

  • TestExpectations:
  • fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
3:11 PM Changeset in webkit [153768] by achristensen@apple.com
  • 6 edits in trunk/Source

Enabled WebGL on WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=119502

Reviewed by Benjamin Poulain.

Source/WebKit:

  • WebKit.vcxproj/WebKit.sln: Build ANGLE libraries.
  • WebKit.vcxproj/WebKit/WebKitCFLite.props: Link to ANGLE libraries.

Source/WTF:

  • wtf/FeatureDefines.h: Enabled WebGL.
  • wtf/Platform.h: Added definitions required for WebGL on Windows.
3:10 PM Changeset in webkit [153767] by mrowe@apple.com
  • 2 edits in trunk/Source/WTF

<rdar://problem/5927399> FastMalloc should support MallocStackLogging

Call the malloc stack logging function from within the various entry points to FastMalloc
when stack logging is enabled.

Reviewed by Oliver Hunt and Geoff Garen.

  • wtf/FastMalloc.cpp:

Call in to MallocHook::InvokeNewHook / MallocHook::InvokeDeleteHook at the appropriate entry
points to FastMalloc. The naming comes from TCMalloc's existing, unused concept of malloc hooks.
(WTF::MallocHook::record): Call the stack logging function with appropriate argument types.
(WTF::MallocHook::recordAllocation): Out-of-line slow path for when stack logging is enabled
that calls record with the values in the right arguments.
(WTF::MallocHook::recordDeallocation): Ditto.
(WTF::MallocHook::init): Stack logging is enabled if the system allocator has enabled stack logging.
(WTF::MallocHook::InvokeNewHook): Call recordAllocation in the unlikely event that stack logging is
enabled.
(WTF::MallocHook::InvokeDeleteHook): Ditto for recordDeallocation.
(WTF::TCMalloc_ThreadCache::InitModule): Initialize the malloc hook.

2:55 PM Changeset in webkit [153766] by achristensen@apple.com
  • 5 edits
    2 moves in trunk/Source/WebCore

Moved GraphicsContext3DPrivate out of cairo directory to be used by the AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=119525

Reviewed by Dean Jackson.

  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Changed location of GraphicsContext3DPrivate.cpp and GraphicsContext3DPrivate.h.

  • platform/graphics/GraphicsContext3DPrivate.cpp: Copied from WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp.
  • platform/graphics/GraphicsContext3DPrivate.h: Copied from WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.h.
  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Removed.
  • platform/graphics/cairo/GraphicsContext3DPrivate.h: Removed.
2:38 PM Changeset in webkit [153765] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove stale code in ResourceContentView
https://bugs.webkit.org/show_bug.cgi?id=119527

The handling of Resource Type changes moved to ResourceClusterContentView,
this removeEventListener is stale and doesn't do anything anymore.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-08-06
Reviewed by Timothy Hatcher.

  • UserInterface/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype.closed):

2:31 PM Changeset in webkit [153764] by Brent Fulgham
  • 4 edits in trunk/Source

[Windows] Unreviewed build correction after r153754 and r153757.

Source/WebCore:

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Don't force std::remainder, since we are using our own
custom implementation on Windows.

Source/WTF:

  • wtf/MathExtras.h:

(remainder): Provide implementation of C99 remainder for VS2010 (and earlier).

2:20 PM Changeset in webkit [153763] by oliver@apple.com
  • 8 edits
    3 adds in trunk

Delay Arguments creation in strict mode
https://bugs.webkit.org/show_bug.cgi?id=119505

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Make use of the write tracking performed by the parser to
allow us to know if we're modifying the parameters to a function.
Then use that information to make strict mode function opt out
of eager arguments creation.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):
(JSC::BytecodeGenerator::emitReturn):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldTearOffArgumentsEagerly):

  • parser/Nodes.h:

(JSC::ScopeNode::modifiesParameter):

  • parser/Parser.cpp:

(JSC::::parseInner):

  • parser/Parser.h:

(JSC::Scope::declareParameter):
(JSC::Scope::getCapturedVariables):
(JSC::Parser::declareWrite):

  • parser/ParserModes.h:

LayoutTests:

Add performance testcase for lazy creation of arguments in strict mode

  • fast/js/regress/delay-tear-off-arguments-strictmode-expected.txt: Added.
  • fast/js/regress/delay-tear-off-arguments-strictmode.html: Added.
  • fast/js/regress/script-tests/delay-tear-off-arguments-strictmode.js: Added.

(bar):

1:51 PM Changeset in webkit [153762] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Remove useless code from COMPILER(RVCT) JITStubs
https://bugs.webkit.org/show_bug.cgi?id=119521

Reviewed by Geoffrey Garen.

  • jit/JITStubsARMv7.h:

(JSC::ctiVMThrowTrampoline): "ldr r6, [sp, #PRESERVED_R6_OFFSET]" was called twice.
(JSC::ctiOpThrowNotCaught): Ditto.

1:37 PM Changeset in webkit [153761] by timothy@apple.com
  • 29 edits
    17 copies
    76 adds
    53 deletes in trunk/Source/WebInspectorUI

Convert all Web Inspector PDFs to SVGs.

Some PDFs need to stay around until bug 119492 is fixed. But the SVGs are there for when they are needed.
Updated some of the existing SVGs to be consistent with the format of the new SVGs.

https://bugs.webkit.org/show_bug.cgi?id=118677

Rubber-stamped by Joseph Pecoraro.

  • UserInterface/BreakpointIcons.css:
  • UserInterface/BreakpointTreeElement.css:
  • UserInterface/CallFrameIcons.css:
  • UserInterface/DatabaseContentView.css:
  • UserInterface/FilterBar.css:
  • UserInterface/HierarchicalPathComponent.css:
  • UserInterface/Images/BackArrow.svg: Added.
  • UserInterface/Images/BottomUpTree.svg: Added.
  • UserInterface/Images/BreakpointButton.pdf: Removed.
  • UserInterface/Images/BreakpointButton.svg: Added.
  • UserInterface/Images/BreakpointInactiveButton.pdf: Removed.
  • UserInterface/Images/BreakpointInactiveButton.svg: Added.
  • UserInterface/Images/Breakpoints.svg: Added.
  • UserInterface/Images/Close.svg: Added.
  • UserInterface/Images/Crosshair.svg: Added.
  • UserInterface/Images/DOMCharacterData.pdf: Removed.
  • UserInterface/Images/DOMCharacterData.svg: Added.
  • UserInterface/Images/DOMComment.pdf: Removed.
  • UserInterface/Images/DOMComment.svg: Added.
  • UserInterface/Images/DOMDocument.pdf: Removed.
  • UserInterface/Images/DOMDocument.svg: Added.
  • UserInterface/Images/DOMDocumentType.pdf: Removed.
  • UserInterface/Images/DOMDocumentType.svg: Added.
  • UserInterface/Images/DOMElement.pdf: Removed.
  • UserInterface/Images/DOMElement.svg: Added.
  • UserInterface/Images/DOMNode.pdf: Removed.
  • UserInterface/Images/DOMNode.svg: Added.
  • UserInterface/Images/DOMTextNode.pdf: Removed.
  • UserInterface/Images/DOMTextNode.svg: Added.
  • UserInterface/Images/DOMTree.pdf: Removed.
  • UserInterface/Images/DOMTree.svg: Added.
  • UserInterface/Images/DisclosureTriangleSmallClosed.svg: Added.
  • UserInterface/Images/DisclosureTriangleSmallOpen.svg: Added.
  • UserInterface/Images/DisclosureTriangleTinyClosed.svg: Added.
  • UserInterface/Images/DisclosureTriangleTinyOpen.svg: Added.
  • UserInterface/Images/DockBottom.svg: Added.
  • UserInterface/Images/DockRight.svg: Added.
  • UserInterface/Images/Error.pdf: Removed.
  • UserInterface/Images/Error.svg: Added.
  • UserInterface/Images/ErrorSmall.pdf: Removed.
  • UserInterface/Images/Errors.svg:
  • UserInterface/Images/ErrorsEnabled.svg:
  • UserInterface/Images/EventListener.pdf: Removed.
  • UserInterface/Images/EventListener.svg: Added.
  • UserInterface/Images/Exception.pdf: Removed.
  • UserInterface/Images/Exception.svg: Added.
  • UserInterface/Images/FilterFieldGlyph.pdf: Removed.
  • UserInterface/Images/FilterFieldGlyph.svg: Added.
  • UserInterface/Images/ForwardArrow.svg: Added.
  • UserInterface/Images/Function.pdf: Removed.
  • UserInterface/Images/Function.svg: Added.
  • UserInterface/Images/GoToArrow.svg: Added.
  • UserInterface/Images/HierarchicalNavigationItemChevron.pdf: Removed.
  • UserInterface/Images/HierarchicalNavigationItemChevron.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner1.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner1.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner10.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner10.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner11.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner11.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner12.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner12.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner2.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner2.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner3.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner3.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner4.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner4.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner5.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner5.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner6.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner6.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner7.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner7.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner8.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner8.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner9.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner9.svg: Added.
  • UserInterface/Images/Issues.svg:
  • UserInterface/Images/IssuesEnabled.svg:
  • UserInterface/Images/LayerBorders.svg: Added.
  • UserInterface/Images/LessColumns.svg: Added.
  • UserInterface/Images/Locked.svg: Added.
  • UserInterface/Images/Logs.svg:
  • UserInterface/Images/Memory.svg:
  • UserInterface/Images/MoreColumns.svg: Added.
  • UserInterface/Images/Native.pdf: Removed.
  • UserInterface/Images/Native.svg: Added.
  • UserInterface/Images/NavigationItemAngleBrackets.svg: Added.
  • UserInterface/Images/NavigationItemBrushAndRuler.svg: Added.
  • UserInterface/Images/NavigationItemBug.svg: Added.
  • UserInterface/Images/NavigationItemCurleyBraces.svg: Added.
  • UserInterface/Images/NavigationItemFile.svg: Added.
  • UserInterface/Images/NavigationItemLayers.svg: Added.
  • UserInterface/Images/NavigationItemLog.svg: Added.
  • UserInterface/Images/NavigationItemMagnifyingGlass.svg: Added.
  • UserInterface/Images/NavigationItemStopwatch.svg: Added.
  • UserInterface/Images/NavigationItemStorage.svg: Added.
  • UserInterface/Images/NavigationItemTrash.svg: Added.
  • UserInterface/Images/NavigationItemVariable.svg: Added.
  • UserInterface/Images/NetworkBarLabelCalloutLeft.pdf: Removed.
  • UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Added.
  • UserInterface/Images/NetworkBarLabelCalloutRight.pdf: Removed.
  • UserInterface/Images/NetworkBarLabelCalloutRight.svg: Added.
  • UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.pdf: Removed.
  • UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Added.
  • UserInterface/Images/NetworkBarLabelCalloutWhiteRight.pdf: Removed.
  • UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Added.
  • UserInterface/Images/Pause.svg: Added.
  • UserInterface/Images/Percent.svg: Added.
  • UserInterface/Images/Plus.svg: Added.
  • UserInterface/Images/PseudoElement.pdf: Removed.
  • UserInterface/Images/PseudoElement.svg: Added.
  • UserInterface/Images/Reflection.pdf: Removed.
  • UserInterface/Images/Reflection.svg: Added.
  • UserInterface/Images/Reload.svg:
  • UserInterface/Images/ReloadSelected.svg:
  • UserInterface/Images/Request.pdf: Removed.
  • UserInterface/Images/Request.svg: Added.
  • UserInterface/Images/Resources.svg:
  • UserInterface/Images/Response.pdf: Removed.
  • UserInterface/Images/Response.svg: Added.
  • UserInterface/Images/ResultLine.pdf: Removed.
  • UserInterface/Images/ResultLine.svg: Added.
  • UserInterface/Images/Resume.svg: Added.
  • UserInterface/Images/ShadowDOM.svg: Added.
  • UserInterface/Images/SortIndicatorDownArrow.svg: Added.
  • UserInterface/Images/SortIndicatorUpArrow.svg: Added.
  • UserInterface/Images/SourceCode.pdf: Removed.
  • UserInterface/Images/SourceCode.svg: Added.
  • UserInterface/Images/SplitToggleDown.svg: Added.
  • UserInterface/Images/SplitToggleUp.svg: Added.
  • UserInterface/Images/StepInto.svg: Added.
  • UserInterface/Images/StepOut.svg: Added.
  • UserInterface/Images/StepOver.svg: Added.
  • UserInterface/Images/StyleRuleAuthor.pdf: Removed.
  • UserInterface/Images/StyleRuleAuthor.svg: Added.
  • UserInterface/Images/StyleRuleInherited.pdf: Removed.
  • UserInterface/Images/StyleRuleInherited.svg: Added.
  • UserInterface/Images/StyleRuleInheritedElement.pdf: Removed.
  • UserInterface/Images/StyleRuleInheritedElement.svg: Added.
  • UserInterface/Images/StyleRuleInspector.pdf: Removed.
  • UserInterface/Images/StyleRuleInspector.svg: Added.
  • UserInterface/Images/StyleRuleUser.pdf: Removed.
  • UserInterface/Images/StyleRuleUser.svg: Added.
  • UserInterface/Images/StyleRuleUserAgent.pdf: Removed.
  • UserInterface/Images/StyleRuleUserAgent.svg: Added.
  • UserInterface/Images/Time.svg:
  • UserInterface/Images/Undock.svg: Added.
  • UserInterface/Images/UpDownArrows.svg:
  • UserInterface/Images/UserInputPrompt.pdf: Removed.
  • UserInterface/Images/UserInputPrompt.svg: Added.
  • UserInterface/Images/UserInputPromptPrevious.pdf: Removed.
  • UserInterface/Images/UserInputPromptPrevious.svg: Added.
  • UserInterface/Images/UserInputPromptPreviousSelected.pdf: Removed.
  • UserInterface/Images/UserInputPromptPreviousSelected.svg: Added.
  • UserInterface/Images/UserInputResult.pdf: Removed.
  • UserInterface/Images/UserInputResult.svg: Added.
  • UserInterface/Images/UserInputResultSelected.pdf: Removed.
  • UserInterface/Images/UserInputResultSelected.svg: Added.
  • UserInterface/Images/Warning.pdf: Removed.
  • UserInterface/Images/Warning.svg: Added.
  • UserInterface/Images/WarningSmall.pdf: Removed.
  • UserInterface/Images/Weight.svg:
  • UserInterface/IndeterminateProgressSpinner.css:
  • UserInterface/LayerTreeSidebarPanel.css:
  • UserInterface/LogContentView.css:
  • UserInterface/Main.css:
  • UserInterface/NetworkTimeline.css:
  • UserInterface/PathComponentIcons.css:
  • UserInterface/QuickConsole.css:
  • UserInterface/RulesStyleDetailsPanel.css:
  • UserInterface/SearchIcons.css:
  • UserInterface/StyleRuleIcons.css:
12:33 PM Changeset in webkit [153760] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153758. <rdar://problem/14627254>

11:53 AM Changeset in webkit [153759] by Bem Jones-Bey
  • 2 edits
    4 moves in trunk/LayoutTests

[CSS Shapes] New positioning model: support for shape-margin
https://bugs.webkit.org/show_bug.cgi?id=118088

Reviewed by Alexandru Chiculita.

Update simple shape-margin tests to work with new positioning model.
Also move them to the CSSWG's repo.

  • TestExpectations: Remove replaced tests.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon.html.
11:39 AM Changeset in webkit [153758] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Improper Calculation of In-band Cue Colors
https://bugs.webkit.org/show_bug.cgi?id=119523

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::makeRGBA32FromARGBCFArray): Remove redundant multiplication by

  1. The internal conversion logic already converts to bytes.
11:11 AM Changeset in webkit [153757] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative build fix after r153754.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

10:43 AM Changeset in webkit [153756] by dfarler@apple.com
  • 37 edits
    3 adds in trunk

Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
https://bugs.webkit.org/show_bug.cgi?id=117762

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Configurations/JavaScriptCore.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • Configurations/ToolExecutable.xcconfig:

Don't use ASAN for build tools.

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • gtest/xcode/Config/StaticLibraryTarget.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Source/ThirdParty/ANGLE:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Source/WebCore:

No new tests necessary.

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Configurations/WebCore.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • Configurations/WebCoreTestShim.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • Configurations/WebCoreTestSupport.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • WebCore.xcodeproj/project.pbxproj:

Don't use ASAN for build tools.

Source/WebInspectorUI:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Configurations/WebKit.xcconfig:

Add ASAN_OTHER_LDFLAGS.

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Configurations/WebContentProcess.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • Configurations/WebKit2.xcconfig:

Add ASAN_OTHER_LDFLAGS.

Source/WTF:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • MiniBrowser/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Scripts/check-for-weak-vtables-and-externals:

Ignore _asan externals, these are populated by compiler-rt.

  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • WebKitLauncher/Configurations/Base.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • asan/asan.xcconfig: Added.
  • asan/webkit-asan-ignore.txt: Added.
9:16 AM Changeset in webkit [153755] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153753. <rdar://problem/14648086>

8:54 AM Changeset in webkit [153754] by rwlbuis@webkit.org
  • 6 edits in trunk

SVG stroke-dasharray is not animatable
https://bugs.webkit.org/show_bug.cgi?id=118574

Reviewed by Dirk Schulze.

Source/WebCore:

Make stroke-dasharray a property that can be animated using CSS transitions.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::CSSPropertyAnimation::ensurePropertyMap):

  • rendering/style/RenderStyle.h:

LayoutTests:

Add test for animating stroke-dasharray in addition to the original SVG tests.

  • transitions/svg-transitions-expected.txt:
  • transitions/svg-transitions.html:
8:40 AM Changeset in webkit [153753] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r151403): Resizing is extremely laggy on many sites when plugins are disallowed.
<http://webkit.org/b/119516>
<rdar://problem/14648086>

Reviewed by Simon Fraser.

The web process relies on the WindowAndViewFramesChanged mechanism for caching a copy
of the window rect for fast access from DOMWindow APIs.

We retain part of the optimization introduced in r151403, namely not computing the
viewFrameInWindowCoordinates and accessibilityPosition unless the web process needs them.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

8:08 AM Changeset in webkit [153752] by sergio@webkit.org
  • 8 edits
    2 adds in trunk

[CSS Grid Layout] Allow defining named grid lines on the grid element
https://bugs.webkit.org/show_bug.cgi?id=118255

Reviewed by Andreas Kling.

From Blink r149798 by <jchaffraix@chromium.org>

Source/WebCore:

This change adds parsing, style resolution and getComputedStyle
support for named grid lines at the grid element level
(i.e. extends our <track-list> support). Per the specification, we
allow multiple grid lines with the same name.

To fully support resolving the grid lines to a position on our
grid, we need to add the parsing at the grid item's level (which
means extending our <grid-line> support). This will be done in a
follow-up change.

Test: fast/css-grid-layout/named-grid-line-get-set.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackList):

  • css/StyleResolver.cpp:

(WebCore::createGridTrackList):
(WebCore::StyleResolver::applyProperty):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

  • rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):

LayoutTests:

  • fast/css-grid-layout/named-grid-line-get-set-expected.txt: Added.
  • fast/css-grid-layout/named-grid-line-get-set.html: Added.
6:58 AM Changeset in webkit [153751] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/qt

[Qt] Add Page Visibility API support
https://bugs.webkit.org/show_bug.cgi?id=109422

Patch by Benjamin Dupont <bdupont@nds.com> on 2013-08-06
Reviewed by Simon Hausmann.

  • WebCoreSupport/QWebPageAdapter.cpp:

(webPageVisibilityStateToWebCoreVisibilityState):
(webCoreVisibilityStateToWebPageVisibilityState):
(QWebPageAdapter::setVisibilityState):
(QWebPageAdapter::visibilityState):

  • WebCoreSupport/QWebPageAdapter.h:
  • WidgetApi/qwebpage.cpp:

(QWebPage::setVisibilityState):
(QWebPage::visibilityState):

  • WidgetApi/qwebpage.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::changeVisibilityState):

5:52 AM Changeset in webkit [153750] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Fix minimal build.

Unreviewed build fix.

Fix build witt XSLT disabled

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::hasNoStyleInformation):

5:45 AM Changeset in webkit [153749] by zandobersek@gmail.com
  • 4 edits in trunk/Source

webkit-gtk fails to build with bison-3.0
https://bugs.webkit.org/show_bug.cgi?id=119373

Reviewed by Gustavo Noronha Silva.

Source/ThirdParty/ANGLE:

  • GNUmakefile.am: Stop relying on generated glslang_tab.(cpp|h) and glslang.cpp sources as Bison 3.0

produces non-compilable source code. Instead, compile these pregenerated files as they're included in
the tree. Originally, the ANGLE source tree provides these files as generated by Bison 2.7, but they're
at the moment regenerated with Bison 2.3 when the third-party ANGLE source is being updated.

Source/WebCore:

  • GNUmakefile.am: Remove rules for generating ANGLE's glslang source files with Bison.
4:45 AM Changeset in webkit [153748] by sergio@webkit.org
  • 16 edits in trunk

[CSS Grid Layout] Add support for parsing <grid-line> that includes a 'span'
https://bugs.webkit.org/show_bug.cgi?id=118051

Reviewed by Andreas Kling.

From Blink r148766 by <jchaffraix@chromium.org>

Source/WebCore:

This adds the parsing, style resolution and getComputedStyle bits
to our code. The rendering code was not made aware of the new type
of GridPosition yet.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridPosition):

  • css/CSSParser.h:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::createGridPosition):

  • css/StyleResolver.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):

  • rendering/style/GridPosition.h:

(WebCore::GridPosition::isInteger):
(WebCore::GridPosition::isSpan):
(WebCore::GridPosition::setSpanPosition):
(WebCore::GridPosition::spanPosition):

LayoutTests:

Added several test cases to check that we properly parse the
keyword 'span' in <grid-line>.

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
4:08 AM Changeset in webkit [153747] by simon.pena@samsung.com
  • 2 edits in trunk

Build fix for GTK 32-bit after r153736

  • Source/autotools/symbols.filter: expose WebCore::SerializedScriptValue::create.
3:33 AM Changeset in webkit [153746] by sergio@webkit.org
  • 19 edits in trunk

[CSS Grid Layout] Rename grid placement properties
https://bugs.webkit.org/show_bug.cgi?id=117878

Reviewed by Andreas Kling.

Renamed the grid placement properties to match the latest version
of the spec. The new names are -webkit-grid-column-{start|end} and
-webkit-grid-row-{start|end}.

Source/WebCore:

No new tests needed as we're just renaming some properties,
functionality already covered by existing tests in
fast/css-grid-layout.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StylePropertyShorthand.cpp:

(WebCore::webkitGridColumnShorthand):
(WebCore::webkitGridRowShorthand):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::RenderGrid::resolveGridPositionFromStyle):

  • rendering/RenderGrid.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.cpp:

(WebCore::StyleGridItemData::StyleGridItemData):

  • rendering/style/StyleGridItemData.h:

(WebCore::StyleGridItemData::operator==):

LayoutTests:

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
3:04 AM Changeset in webkit [153745] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for ARM MSVC after r153222 and r153648.

  • jit/JITStubsARM.h: Added ctiVMThrowTrampolineSlowpath.
3:03 AM Changeset in webkit [153744] by Patrick Gansterer
  • 4 edits in trunk/Source/JavaScriptCore

Build fix for ARM MSVC after r150109.

Read the stub template from a header files instead of the JITStubs.cpp.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • create_jit_stubs:
2:36 AM Changeset in webkit [153743] by simon.pena@samsung.com
  • 2 edits in trunk

Build fix for GTK after r153736

  • Source/autotools/symbols.filter: expose missing symbols

WebCore::SerializedScriptValue::create and WebCore::toJS to Internals.

Note: See TracTimeline for information about the timeline view.