Context Navigation

← Previous Period
Next Period →

Timeline

Aug 8, 2013:

11:44 PM Changeset in webkit [153877] by timothy_horton@apple.com

11 edits
2 adds in trunk

navigator.plugins has plugins in it when plugins are disabled
https://bugs.webkit.org/show_bug.cgi?id=119607
<rdar://problem/14678030>

Reviewed by Anders Carlsson.

Test: plugins/navigator-plugins-disabled.html

page/Settings.cpp:

(WebCore::Settings::setPluginsEnabled):
Refresh the plugin database when plugins are enabled or disabled.
This is necessary to ensure that navigator.plugins will have the
correct set of plugins after dynamically changing whether plugins
are enabled, which makes the test for this patch possible (but it
makes sense in the browser as well).

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):
Return a list of all plugins, and a list of only application plugins.

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPluginInfo):
Add applicationPlugin parameter to getPlugins, and storage for the returned list.

(WebKit::WebPlatformStrategies::populatePluginCache):
If plugins are disabled for the given page, give WebCore the list that
only includes application plugins. Otherwise, give it the whole list
as we are doing currently.

WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::getPluginInfo):
If plugins are disabled for the given page, give WebCore an empty list of
plugins. If WebKit1 had any application plugins, we'd return just them
instead.

Add a test that ensures that navigator.plugins only contains
application plugins when plugins are disabled.

plugins/navigator-plugins-disabled-expected.txt: Added.
plugins/navigator-plugins-disabled.html: Added.

11:39 PM Changeset in webkit [153876] by timothy@apple.com

9 edits
1 move
7 adds
5 deletes in trunk

Allow SVG images to be drawn into canvas without tainting.
https://bugs.webkit.org/show_bug.cgi?id=119492

Reviewed by Darin Adler.

Source/WebCore:

Tests: svg/as-image/svg-canvas-not-tainted.html

svg/as-image/svg-canvas-link-not-colored.html
svg/as-image/svg-canvas-xhtml-tainted.html

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute): Call shouldProhibitLinks.
(WebCore::shouldProhibitLinks): Added.

html/HTMLAnchorElement.h:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Call shouldProhibitLinks.

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::isEmbeddedThroughSVGImage): Use isInSVGImage.

svg/SVGAElement.cpp:

(WebCore::SVGAElement::svgAttributeChanged): Call shouldProhibitLinks.

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin): Added.
(WebCore::isInSVGImage): Added.

svg/graphics/SVGImage.h:

LayoutTests:

fast/canvas/svg-taint-expected.txt: Removed.
fast/canvas/svg-taint.html: Removed. Obsolete.
http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt: Removed.
http/tests/security/canvas-remote-read-data-url-svg-image.html: Removed. Obsolete.
http/tests/security/canvas-remote-read-svg-image-expected.txt: Removed.
http/tests/security/canvas-remote-read-svg-image.html: Removed. Obsolete.
svg/as-image/resources/link-xhtml-svg.svg: Added.
svg/as-image/resources/link-xhtml.svg: Added.
svg/as-image/resources/link.svg: Added.
svg/as-image/svg-canvas-link-not-colored-expected.txt: Added.
svg/as-image/svg-canvas-link-not-colored.html: Added.
svg/as-image/svg-canvas-not-tainted-expected.txt: Added.
svg/as-image/svg-canvas-not-tainted.html: Added.
svg/as-image/svg-canvas-xhtml-tainted-expected.txt: Added.
svg/as-image/svg-canvas-xhtml-tainted.html: Added.

7:40 PM Changeset in webkit [153875] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix ASSERT(m_contentsSolidColor.isValid()) assertion on iOS at nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=119603

Reviewed by Dean Jackson.

On iOS it's possible for a GraphicsLayer to transition between having
a solid background color, and containing media. This happens on nytimes.com
when playing video.

In this case, GraphicsLayerCA::updateContentsColorLayer() would assert
because m_contentsLayer had been already set up to contain media, but
it would be trying to update the color.

Fix by bailing from all the updateContents* functions if there is no
contents layer, or that layer exists for a different purpose.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateContentsMediaLayer):
(WebCore::GraphicsLayerCA::updateContentsCanvasLayer):
(WebCore::GraphicsLayerCA::updateContentsColorLayer):

7:12 PM Changeset in webkit [153874] by achristensen@apple.com

5 edits
2 adds in trunk/Source/ThirdParty/ANGLE

Link to correct DirectX libraries for Win64 ANGLE build.
https://bugs.webkit.org/show_bug.cgi?id=119600

Reviewed by Brent Fulgham.

ANGLE.vcxproj/DirectX32.props: Added with x86 DirectX library directory.
ANGLE.vcxproj/DirectX64.props: Added with x64 DirectX library directory.
ANGLE.vcxproj/libEGL.vcxproj:
ANGLE.vcxproj/libGLESv2.vcxproj:

Use DirectX32.props and DirectX64.props.

ANGLE.vcxproj/libEGLCommon.props:
ANGLE.vcxproj/libGLESv2Common.props:

Removed DirectX library directory.

5:49 PM Changeset in webkit [153873] by commit-queue@webkit.org

3 edits
4 deletes in trunk

Unreviewed, rolling out r153847.
http://trac.webkit.org/changeset/153847
https://bugs.webkit.org/show_bug.cgi?id=119609

caused new SVG animation test failures (Requested by smfr on
#webkit).

Source/WebCore:

svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateFromAndByValues):

LayoutTests:

svg/animations/non-additive-type-from-by-animation-expected.txt: Removed.
svg/animations/non-additive-type-from-by-animation.html: Removed.
svg/animations/resources/non-additive-type-from-by-animation.svg: Removed.
svg/animations/script-tests/non-additive-type-from-by-animation.js: Removed.

5:47 PM Changeset in webkit [153872] by Simon Fraser

6 edits in trunk/Source/WebCore

Kill updateStyleForAllDocuments()
https://bugs.webkit.org/show_bug.cgi?id=118093

Reviewed by Geoff Garen.

We should never have to eagerly update style, especially for all documents
that the process knows about. The WebKit model is to update style when
required for layout etc, not to update it eagerly.

This is historical code whose origins are lost in the mists of KHTML.
r42384 makes it possible to do away with this eager updating, and
r55568 removed some calls. Discussion in bug 32580 suggests that
form control code still need this, but tests still pass without it.

bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::unscheduleStyleRecalc):

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::setActive):

5:40 PM Changeset in webkit [153871] by jer.noble@apple.com

3 edits in trunk/LayoutTests

Unreviewed gardening; update test after addKey() was renamed to update().

media/encrypted-media/encrypted-media-v2-events-expected.txt:
media/encrypted-media/encrypted-media-v2-events.html:

5:16 PM Changeset in webkit [153870] by Lucas Forschler

17 edits in branches/safari-537-branch

Merged r153867. <rdar://problem/14691925>

5:14 PM Changeset in webkit [153869] by Lucas Forschler

17 edits in tags/Safari-537.55.1

Merged r153867. <rdar://problem/14691925>

5:11 PM Changeset in webkit [153868] by benjamin@webkit.org

5 edits
2 adds in trunk/Websites/webkit.org

Fix webkit.org content overflowing their content box

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-08-08
Rubberstamped by Simon Fraser.

More fixes to have webkit.org show properly on iPad and iPhone.

blog/wp-content/themes/webkit/header.php:

Add the correct viewport width for the blog.

building/debug.html:
building/launch-debugger-vs2010-small.png: Added.
building/set-debugging-properties-vs2010-small.png: Added.

Fix the images to make them fit in the page.

coding/adding-features.html:

Using <pre> for the example of email just make it looks like our code examples.
Change the source to use <blockquote> so that the text can reflow to the content box.

css/main.css:

(.code, pre, tt, code):
Scroll the content when it overflows the box for code and pre.

5:07 PM Changeset in webkit [153867] by jer.noble@apple.com

17 edits in trunk

[EME] MediaKey APIs should be prefixed.
https://bugs.webkit.org/show_bug.cgi?id=119606

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests; updated exsisting tests with new names.

Prefix all new classes with "WebKit" and new methods on existing unprefixed
classes with "webkit"

Modules/encryptedmedia/MediaKeyMessageEvent.idl: MediaKeyMessageEvent -> WebKitMediaKeyMessageEvent
Modules/encryptedmedia/MediaKeySession.idl: MediaKeySession -> WebKitMediaKeySession
Modules/encryptedmedia/MediaKeys.idl: MediaKeys -> WebKitMediaKeys
html/HTMLMediaElement.idl: keys -> webkitKeys, setMediaKeys -> webkitSetMediaKeys
html/MediaKeyError.idl: MediaKeyError -> WebKitMediaKeyError

LayoutTests:

media/encrypted-media/encrypted-media-constants-expected.txt:
media/encrypted-media/encrypted-media-constants.html:
media/encrypted-media/encrypted-media-events-expected.txt:
media/encrypted-media/encrypted-media-events.html:
media/encrypted-media/encrypted-media-is-type-supported-expected.txt:
media/encrypted-media/encrypted-media-is-type-supported.html:
media/encrypted-media/encrypted-media-v2-events-expected.txt:
media/encrypted-media/encrypted-media-v2-events.html:
media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
media/encrypted-media/encrypted-media-v2-syntax.html:

5:06 PM Changeset in webkit [153866] by Lucas Forschler

4 edits in branches/safari-537-branch

Merged r153851. <rdar://problem/14688700>

5:04 PM Changeset in webkit [153865] by Lucas Forschler

13 edits
2 copies in branches/safari-537-branch

Merged r153838. <rdar://problem/14688350>

5:02 PM Changeset in webkit [153864] by Lucas Forschler

2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153856. <rdar://problem/14267843>

4:57 PM Changeset in webkit [153863] by Lucas Forschler

5 edits in branches/safari-537-branch/Source/WebCore

Merged r153810. <rdar://problem/14669010>

4:47 PM Changeset in webkit [153862] by Lucas Forschler

4 edits in tags/Safari-537.55.1

Merged r153851. <rdar://problem/14688700>

4:41 PM Changeset in webkit [153861] by Lucas Forschler

13 edits
2 copies in tags/Safari-537.55.1

Merged r153838. <rdar://problem/14688350>

4:28 PM Changeset in webkit [153860] by dino@apple.com

2 edits in trunk/Source/WebInspectorUI

Remove use of prefixed transition event
https://bugs.webkit.org/show_bug.cgi?id=119598

Reviewed by Joseph Pecoraro.

"webkitTransitionEnd" -> "transitionend".

UserInterface/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.handleEvent):

4:28 PM Changeset in webkit [153859] by achristensen@apple.com

4 edits in trunk

Windows build fixes.

Rubberstamped by Brent Fulgham.

Tools:

DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:

Removed /SAFESEH link option which doesn't work with x64.

WebKitLibraries:

win/tools/vsprops/debug_wincairo.props: Removed MinimalRebuild option preventing parallel compiling.

4:25 PM Changeset in webkit [153858] by Lucas Forschler

5 edits in tags/Safari-537.55.1/Source

Versioning.

4:19 PM Changeset in webkit [153857] by Lucas Forschler

1 copy in tags/Safari-537.55.1

New Tag.

4:19 PM Changeset in webkit [153856] by barraclough@apple.com

2 edits in trunk/Source/WebKit2

Disable suppression of plugin process for Java
https://bugs.webkit.org/show_bug.cgi?id=119604

Reviewed by Sam Weinig.

Workaround, the Java plugin doesn't like this.

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):

+1 active task count on the java plugin, to inhibit supression.

4:12 PM Changeset in webkit [153855] by timothy_horton@apple.com

4 edits in trunk/LayoutTests

Unreviewed, remove TestExpectations for removed microdata tests.

platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:

3:51 PM Changeset in webkit [153854] by dbates@webkit.org

2 edits in trunk/Tools

Add iOS support to run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=119602

Reviewed by Joseph Pecoraro.

Make run-javascriptcore-tests work for iOS WebKit.

Scripts/run-javascriptcore-tests:

3:46 PM Changeset in webkit [153853] by benjamin@webkit.org

2 edits in trunk/Websites/webkit.org

Give a smaller viewport to webkit.org on devices

Rubberstamped by Simon Fraser.

The CSS of WebKit.org layout the content on 615px + a right margin of
215px + a left margin of 20px. The total layout width is 850px.

The standard viewport size on mobile devices is 980px. This leaves a gap
on the right side of the content when opening the size on iPhone/iPad.

This patch changes the layout width to be 860 to display more content on devices
while keeping a little margin.

header.inc:

3:38 PM Changeset in webkit [153852] by ap@apple.com

10 edits
1 delete in trunk

[WK2] loader/go-back-cached-main-resource.html fails
https://bugs.webkit.org/show_bug.cgi?id=116491

Reviewed by Tim Horton.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
DumpRenderTree/gtk/DumpRenderTree.cpp:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:
DumpRenderTree/win/DumpRenderTree.cpp: Added FIXMEs about making path printing normalization more compatible.

DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]): Return last path component in cases where we used to return a full path, which is never desirable. Added a null check to basePath to prevent potentially getting an Objective C exception.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::pathSuitableForTestResult): Changed to use path for main test window, not for a currently loading one (which is different for tests that use multiple windows). Changed to return "(null)" for empty URLs to match WK1 output. Changed to return last path component as last fallback. (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main frame URL here, and it was potentially a wrong frame. (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto. (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto. (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto. (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto. (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.

3:29 PM Changeset in webkit [153851] by jer.noble@apple.com

4 edits in trunk

[EME] setMediaKeys function as defined in the EME specification does not work
https://bugs.webkit.org/show_bug.cgi?id=119597

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests; updated media/encrypted-media/encrypted-media-v2-syntax.html

Rename the mediaKeys attribute 'keys' and make readonly, and add an explicit
setMediaKeys() method in HTMLMediaElement's IDL.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::keys):

html/HTMLMediaElement.idl:

LayoutTests:

media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
media/encrypted-media/encrypted-media-v2-syntax.html:

3:01 PM Changeset in webkit [153850] by weinig@apple.com

3 edits in trunk/Source/WebCore

Hashing SecurityOrigin's can lead to trouble if you mutate them :(
https://bugs.webkit.org/show_bug.cgi?id=119533
<rdar://problem/12978338>

Reviewed by Andreas Kling.

We are getting into trouble in the following circumstance:

You have a HashMap<RefPtr<SecurityOrigin>, Value> map.
You add security origin A (http, www.webkit.org, 80) to the map.
You mutate security origin A by domain relaxation, so that it has the domain webkit.org.
You add security origin B (http, www.webkit.org, 80) to the map.
You mutate security origin B by domain relaxation, so that it has the domain webkit.org.

You now have two identical keys in the map.

Add few more items to the map causing a rehash.
When you try to add A and B back into the map, you will have a collision, because they now equal each other.

We should probably stop using SecurityOrigins as keys in HashMaps (and move to using a non-mutable SecurityOriginTuple,
or something), but for now, we can just only use the scheme / host / port part for equality, which is what all the users
really want.

page/SecurityOriginHash.h:

(WebCore::SecurityOriginHash::equal):
Switch to using isSameSchemeHostPort() for SecurityOriginHash::equal().

2:37 PM Changeset in webkit [153849] by Lucas Forschler

3 edits in branches/safari-537-branch/Source/WebCore

Merged r153845. <rdar://problem/14688769>

2:33 PM Changeset in webkit [153848] by dino@apple.com

2 edits in trunk/Source/WebKit2

Add logging to the primary plugin detection
https://bugs.webkit.org/show_bug.cgi?id=119594

Reviewed by Tim Horton.

Add some simple logging to our primary plug-in detection.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

2:19 PM Changeset in webkit [153847] by rwlbuis@webkit.org

3 edits
4 adds in trunk

ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes
https://bugs.webkit.org/show_bug.cgi?id=113224

Reviewed by Dirk Schulze.

Source/WebCore:

Do not perform from-by animations for non-additive attributes.

Test: svg/animations/non-additive-type-from-by-animation.html

svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateFromAndByValues):

LayoutTests:

Add a test for animating non-additive attributes in from-by animations

svg/animations/non-additive-type-from-by-animation-expected.txt: Added.
svg/animations/non-additive-type-from-by-animation.html: Added.
svg/animations/resources/non-additive-type-from-by-animation.svg: Added.
svg/animations/script-tests/non-additive-type-from-by-animation.js: Added.

(sample):
(executeTest):

2:17 PM Changeset in webkit [153846] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708

Unreviewed gardening.

platform/mac/TestExpectations: Mark test as flakey, it doesn't always pass.

2:12 PM Changeset in webkit [153845] by Brent Fulgham

3 edits in trunk/Source/WebCore

[Windows] Improper Caption Button Displayed to Users
https://bugs.webkit.org/show_bug.cgi?id=119593

Reviewed by Eric Carlson.

Remove the custom drawing code for the Windows port, and
have it render using the CSS/SVG markup like we do on OS X.

rendering/RenderThemeWin.cpp: Remove drawing code.
rendering/RenderThemeWin.h: Remove declaration.

2:05 PM Changeset in webkit [153844] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

fast/events/scroll-div-with-prevent-default-in-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82747

Unreviewed gardening.

platform/mac/TestExpectations: Mark test as flakey, it doesn't always pass.

1:19 PM Changeset in webkit [153843] by achristensen@apple.com

6 edits in trunk/Source/WebCore

Work towards WebGL on AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=119562

Reviewed by Brent Fulgham.

WebCore.vcxproj/WebCore.vcxproj:

Build GLContext.cpp and GraphicsContext3DPrivate.cpp on AppleWin port.

WebCore.vcxproj/WebCore.vcxproj.filters:

Moved GLContext and GraphicsContext3DPrivate from Cairo filter to graphics.

platform/graphics/GraphicsContext3D.h:

Added m_webGLLayer for AppleWin port.

platform/graphics/GraphicsContext3DPrivate.cpp:

Protected inclusion of PlatformContextCairo.h in USE(CAIRO) macro for non-cairo ports.

platform/graphics/win/GraphicsContext3DWin.cpp:

Removed stub GraphicsContext3DPrivate implementation in favor of GraphicsContext3DPrivate.cpp.
(WebCore::GraphicsContext3D::GraphicsContext3D):
Added GraphicsContext3DPrivate and PlatformCALayer initialization.
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
Added implementation based on Cairo ports' to be refactored soon.
(WebCore::GraphicsContext3D::platformLayer):
Return PlatformCALayer's PlatformLayer instead of 0.

12:53 PM Changeset in webkit [153842] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

http/tests/navigation/back-twice-without-commit.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82980

Unreviewed gardening.

platform/mac/TestExpectations: Unskip passing test.

12:48 PM Changeset in webkit [153841] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK.
https://bugs.webkit.org/show_bug.cgi?id=104104

Unreviewed gardening.

platform/mac/TestExpectations: Unskip passing test.

12:22 PM Changeset in webkit [153840] by dino@apple.com

5 edits in trunk/Source/WebInspectorUI

Unprefix use of transitions in Web Inspector code
https://bugs.webkit.org/show_bug.cgi?id=119588

Reviewed by Tim Hatcher.

Replace "-webkit-transition" with "transition".

UserInterface/CSSCompletions.js:

(WebInspector.CSSCompletions.requestCSSNameCompletions.collectPropertyNameForCodeMirror):

UserInterface/FindBanner.css:

(.find-banner):
(.find-banner.showing):
(.supports-find-banner.no-find-banner-transition):
(.supports-find-banner):
(.supports-find-banner.showing-find-banner):

UserInterface/NetworkTimeline.css:

(.network-graph-side:hover .network-graph-label):

UserInterface/Popover.css:

(.popover.fade-out):

12:22 PM Changeset in webkit [153839] by ap@apple.com

2 edits in trunk/Source/WebKit2

WKBundleFrameCopyProvisionalURL crashes when there is no provisional loader
https://bugs.webkit.org/show_bug.cgi?id=119587

Reviewed by Darin Adler.

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::provisionalURL): Added a null check, like we already have in WebFrame::url().

12:17 PM Changeset in webkit [153838] by jer.noble@apple.com

13 edits
2 adds in trunk

[EME] Implement MediaKeys.isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=119586

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/encrypted-media/encrypted-media-is-type-supported.html

The EME spec has removed the extra keySystem parameter from
HTMLMediaElement.canPlayType() in favor of a new isTypeSupported()
method on MediaKeys.

To implement this method, the CDMFactory needs to know whether the
registered CDM supports the specified mime type. CDMs must register
this new factory method, which requires changes to CDMPrivateAVFoundation
and MockCDM.

Add the new MediaKeys.isTypeSupported() method:

Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::isTypeSupported):

Modules/encryptedmedia/MediaKeys.h:
Modules/encryptedmedia/MediaKeys.idl:

Add the new factory CDMSupportsKeySystemAndMimeType method:

Modules/encryptedmedia/CDM.cpp:

(WebCore::CDMFactory::CDMFactory): Now takes a third parameter.
(WebCore::installedCDMFactories): When adding the AVFoundation CDM, pass its new method.
(WebCore::CDM::registerCDMFactory): Now takes a third parameter.
(WebCore::CDM::keySystemSupportsMimeType): Added.

Modules/encryptedmedia/CDM.h:
WebCore.exp.in:

Modules/encryptedmedia/CDMPrivateAVFoundation.h:
Modules/encryptedmedia/CDMPrivateAVFoundation.mm:

(WebCore::CDMPrivateAVFoundation::supportsKeySystem):
(WebCore::CDMPrivateAVFoundation::supportsKeySystemAndMimeType):

testing/Internals.cpp:

(WebCore::Internals::initializeMockCDM):

testing/MockCDM.cpp:

(WebCore::MockCDM::supportsKeySystem):
(WebCore::MockCDM::supportsKeySystemAndMimeType):

testing/MockCDM.h:

LayoutTests:

media/encrypted-media/encrypted-media-is-type-supported-expected.txt: Added.
media/encrypted-media/encrypted-media-is-type-supported.html: Added.

11:47 AM Changeset in webkit [153837] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

fast/events/scroll-div-with-prevent-default-in-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82747

Unreviewed gardening.

platform/mac/TestExpectations: Unskip passing test.

11:40 AM Changeset in webkit [153836] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

REGRESSION(r130839): fast/canvas/webgl/arraybuffer-transfer-of-control.html is failing
https://bugs.webkit.org/show_bug.cgi?id=99096

Unreviewed gardening.

platform/mac/TestExpectations: Unskip passing test.

11:38 AM Changeset in webkit [153835] by rwlbuis@webkit.org

3 edits
2 adds in trunk

Crash in WTF::RefPtr<WebCore::SpaceSplitStringData>::operator UnspecifiedBoolType
https://bugs.webkit.org/show_bug.cgi?id=118839

Reviewed by Darin Adler.

Source/WebCore:

Take into account that elementData() can be null in classAttributeChanged.

Test: svg/animations/classAttributeSettingCrash.html

dom/Element.cpp:

(WebCore::Element::classAttributeChanged):

LayoutTests:

Add testcase that showed up to cause a crash by the fuzzer.

svg/animations/classAttributeSettingCrash-expected.txt: Added.
svg/animations/classAttributeSettingCrash.html: Added.

11:35 AM Changeset in webkit [153834] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708

Unreviewed gardening.

platform/mac/TestExpectations: Unskip passing test.

11:17 AM Changeset in webkit [153833] by rwlbuis@webkit.org

6 edits in trunk/LayoutTests

svg/custom/use-href-update-crash.svg failing on certain platforms
https://bugs.webkit.org/show_bug.cgi?id=104054

Reviewed by Darin Adler.

Fix mistake in use-href-update-crash.svg which caused the gc() not found problem. Update the test expectations
that had this marked as failure, it passes after the test fix.

platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
svg/custom/use-href-update-crash.svg:

11:13 AM Changeset in webkit [153832] by robert@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r147019): Page has extra space
https://bugs.webkit.org/show_bug.cgi?id=119424

Reviewed by David Hyatt.

Clear the overflow rect before recomputing it in table sections.

No new tests: the reduction uses jquery and I was unable to simulate the reduction without it.

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::computeOverflowFromCells):

10:47 AM Changeset in webkit [153831] by Lucas Forschler

2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merge 153819 for <rdar://problem/14680524>

10:41 AM Changeset in webkit [153830] by ap@apple.com

5 edits in trunk

WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
https://bugs.webkit.org/show_bug.cgi?id=116125

Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::pathSuitableForTestResult): Changed string operations to match _drt_descriptionSuitableForTestResult. (WTR::dumpRequestDescriptionSuitableForTestResult): (WTR::dumpResponseDescriptionSuitableForTestResult): (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): (WTR::InjectedBundlePage::didInitiateLoadForResource): (WTR::InjectedBundlePage::willSendRequestForFrame): (WTR::InjectedBundlePage::didReceiveResponseForResource): Pass the main frame's URL to pathSuitableForTestResult.
WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added WKBundlePageRef to willPerformClientRedirectForFrame.

10:41 AM Changeset in webkit [153829] by akling@apple.com

8 edits in trunk/Source/WebCore

Inserting multiple rules into an empty style sheet should avoid style recalc if possible.
<http://webkit.org/b/119568>

Reviewed by Antti Koivisto.

As a follow-up to <http://webkit.org/b/119475>, where I added a hack for inserting
a single rule into an empty style sheet, this broadens the optimization to support
any number of rules.

This optimizes the scenario where a style sheet is added to the DOM and then populated
rule-by-rule via CSSOM insertRule()/addRule() calls. Previously we'd do a full style
recalc for this case, but now we'll treat it the same as a full sheet added at once.

css/CSSStyleSheet.h:
css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::willMutateRules):

Made willMutateRules() return whether the style sheet contents were cloned by the
copy-on-write mechanism.

dom/Document.h:

(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):

Replaced the InsertionIntoEmptySheet mutation type by a general RuleInsertion.
The mutation callback checks if we're inserting into a rule that's not (yet) part
of the document's active sheet set. In that case, we defer doing the style sheet
until all the insertions are done (or something forces us to style+layout.)

Note that this optimization only happens if the style sheet had a single client.
Shared style sheets that just got cloned before mutation may have pointers into
them from the Document's StyleResolver, so we're forced to do an immediate sheet
update in that case.

(WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope):
(WebCore::CSSStyleSheet::RuleMutationScope::~RuleMutationScope):

Moved these out-of-line.

(WebCore::CSSStyleSheet::didMutateRuleFromCSSStyleDeclaration):

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleRuleCSSStyleDeclaration::didMutate):

Made a separate mutation callback for CSSStyleDeclaration since its needs are
so simple compared to the mutation callback from CSSStyleSheet. Seems better
than adding yet another mode to the enum.

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):

Added mechanism to defer doing a RecalcStyleIfNeeded.

(WebCore::Document::updateStyleIfNeeded):

Synchronize the optimized style sheet update if there's one scheduled.
This ensures that stuff like layout-dependent property access won't operate
on stale style.

dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::pendingUpdateType):
(WebCore::DocumentStyleSheetCollection::setPendingUpdateType):
(WebCore::DocumentStyleSheetCollection::flushPendingUpdates):

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

Have DSSC track the kind of style sheet update it needs to do (instead of just
a boolean "needs update.") This is used by Document::recalcStyle() to make sure
the right kind of update happens if there's one scheduled.

(WebCore::DocumentStyleSheetCollection::activeStyleSheetsContains):

Added helper to check if a CSSStyleSheet is part of the active set.

10:38 AM Changeset in webkit [153828] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[WK1] NPStream::headers not initialized
https://bugs.webkit.org/show_bug.cgi?id=119574

Reviewed by Alexey Proskuryakov.

Initialize the header field. According to user feedback that should solve some
cases of random crashes when loading plugins on Mac and Windows.

plugins/PluginStream.cpp:

(WebCore::PluginStream::PluginStream):

10:27 AM Changeset in webkit [153827] by akling@apple.com

1 edit in trunk/Source/WebCore/ChangeLog

Oops, didn't mean to implicate Mark Lam in the ChangeLog there.

10:25 AM Changeset in webkit [153826] by akling@apple.com

30 edits in trunk/Source

Element: Modernize attribute storage accessor functions.
<http://webkit.org/b/119578>

Source/WebCore:

Patch by Mark Lam <mark.lam@apple.com> on 2013-08-08
Reviewed by Antti Koivisto.

Rename these functions to more WebKit-style names.

const Attribute* attributeItem(index) => const Attribute& attributeAt(index)
const Attribute* getAttributeItem(name) => const Attribute* findAttributeByName(name)
unsigned getAttributeItemIndex(name) => unsigned findAttributeIndexByName(name)

Note that attributeAt() now returns a reference instead of a pointer. That's right.

css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):
(WebCore::anyAttributeMatches):

css/SelectorChecker.h:

(WebCore::SelectorChecker::checkExactAttribute):

dom/Attr.cpp:

(WebCore::Attr::elementAttribute):

dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):

dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::ElementData::isEquivalent):
(WebCore::ElementData::findAttributeIndexByNameSlowCase):
(WebCore::ElementData::findAttributeIndexByNameForAttributeNode):
(WebCore::UniqueElementData::findAttributeByName):
(WebCore::UniqueElementData::attributeAt):

dom/Element.h:

(WebCore::Element::findAttributeIndexByName):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::attributeAt):
(WebCore::Element::findAttributeByName):
(WebCore::ElementData::findAttributeByName):
(WebCore::ElementData::findAttributeIndexByName):
(WebCore::ElementData::attributeAt):

dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::item):

dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::compareDocumentPosition):

dom/StyledElement.cpp:

(WebCore::StyledElement::makePresentationAttributeCacheKey):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendElement):

editing/markup.cpp:

(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::appendElement):

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parametersForPlugin):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::createDigest):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):

page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

xml/XPathFunctions.cpp:

(WebCore::XPath::FunLang::evaluate):

xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

Source/WebKit/blackberry:

Reviewed by Antti Koivisto.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

Source/WebKit/qt:

Reviewed by Antti Koivisto.

Api/qwebelement.cpp:

(QWebElement::attributeNames):

9:57 AM Changeset in webkit [153825] by mark.lam@apple.com

6 edits in trunk/Source

Restoring use of StackIterator instead of Interpreter::getStacktrace().
https://bugs.webkit.org/show_bug.cgi?id=119575.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

interpreter/Interpreter.h:
Made getStackTrace() private.
interpreter/StackIterator.cpp:

(JSC::StackIterator::StackIterator):
(JSC::StackIterator::numberOfFrames):

Computes the number of frames by iterating through the whole stack from the starting frame. The iterator will save its current frame position before counting the frames, and then restoring it after the counting.

(JSC::StackIterator::gotoFrameAtIndex):
(JSC::StackIterator::gotoNextFrame):
(JSC::StackIterator::resetIterator):

Points the iterator to the starting frame.
interpreter/StackIteratorPrivate.h:

Source/WebCore:

No new tests.

bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

9:55 AM Changeset in webkit [153824] by commit-queue@webkit.org

12 edits
5 copies
34 adds in trunk

SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1
https://bugs.webkit.org/show_bug.cgi?id=117993

Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-08-08
Reviewed by George Staikos.

PerformanceTests/SunSpider:

Bump the SunSpider version to 1.0.1.

Unroll r149548 in order to restore version 1.0 to its original,
and add the 3d-morph fix to version 1.0.1 instead.

hosted/sunspider.html: Updated to version 1.0.1.
hosted/versions.html: Updated to version 1.0.1.
make-hosted: Added support for version 1.0.1.
resources/driver-TEMPLATE.html: Updated to version 1.0.1.
resources/results-TEMPLATE.html: Updated to version 1.0.1.
sunspider: Updated to version 1.0.1.
sunspider-compare-results: Updated to version 1.0.1.
tests/sunspider-1.0/3d-morph.js: Rolled back to the original version.
tests/sunspider-1.0.1/LIST: Added.
tests/sunspider-1.0.1/3d-cube.js: Added.
tests/sunspider-1.0.1/3d-morph.js: Added.
tests/sunspider-1.0.1/3d-raytrace.js: Added.
tests/sunspider-1.0.1/access-binary-trees.js: Added.
tests/sunspider-1.0.1/access-fannkuch.js: Added.
tests/sunspider-1.0.1/access-nbody.js: Added.
tests/sunspider-1.0.1/access-nsieve.js: Added.
tests/sunspider-1.0.1/bitops-3bit-bits-in-byte.js: Added.
tests/sunspider-1.0.1/bitops-bits-in-byte.js: Added.
tests/sunspider-1.0.1/bitops-bitwise-and.js: Added.
tests/sunspider-1.0.1/bitops-nsieve-bits.js: Added.
tests/sunspider-1.0.1/controlflow-recursive.js: Added.
tests/sunspider-1.0.1/crypto-aes.js: Added.
tests/sunspider-1.0.1/crypto-md5.js: Added.
tests/sunspider-1.0.1/crypto-sha1.js: Added.
tests/sunspider-1.0.1/date-format-tofte.js: Added.
tests/sunspider-1.0.1/date-format-xparb.js: Added.
tests/sunspider-1.0.1/math-cordic.js: Added.
tests/sunspider-1.0.1/math-partial-sums.js: Added.
tests/sunspider-1.0.1/math-spectral-norm.js: Added.
tests/sunspider-1.0.1/regexp-dna.js: Added.
tests/sunspider-1.0.1/string-base64.js: Added.
tests/sunspider-1.0.1/string-fasta.js: Added.
tests/sunspider-1.0.1/string-tagcloud.js: Added.
tests/sunspider-1.0.1/string-unpack-code.js: Added.
tests/sunspider-1.0.1/string-validate-input.js: Added.

Websites/webkit.org:

perf/sunspider-1.0.1/json2.js: Added.
perf/sunspider-1.0.1/sunspider-1.0.1/driver.html: Added.
perf/sunspider-1.0.1/sunspider-1.0.1/results.html: Added.
perf/sunspider-1.0.1/sunspider-1.0.1/sunspider-test-contents.js: Added.
perf/sunspider-1.0.1/sunspider-1.0.1/sunspider-test-prefix.js: Added.
perf/sunspider-1.0.1/sunspider-analyze-results.js: Added.
perf/sunspider-1.0.1/sunspider-compare-results.js: Added.
perf/sunspider-1.0.1/sunspider.css: Added.
perf/sunspider-1.0.1/sunspider.html: Added.
perf/sunspider/sunspider.html: Updated to version 1.0.1.
perf/sunspider/versions.html: Updated to version 1.0.1.

9:38 AM Changeset in webkit [153823] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

Moved ErrorConstructor and NativeErrorConstructor helper functions into
the Interpreter class.
https://bugs.webkit.org/show_bug.cgi?id=119576.

Reviewed by Oliver Hunt.

This change is needed to prepare for making Interpreter::getStackTrace()
private. It does not change the behavior of the code, only the lexical
scoping.

interpreter/Interpreter.h:
Added helper functions for ErrorConstructor and NativeErrorConstructor.
runtime/ErrorConstructor.cpp:

(JSC::Interpreter::constructWithErrorConstructor):
(JSC::ErrorConstructor::getConstructData):
(JSC::Interpreter::callErrorConstructor):
(JSC::ErrorConstructor::getCallData):

Don't want ErrorConstructor to call Interpreter::getStackTrace() directly. So, we moved the helper functions into the Interpreter class.
runtime/NativeErrorConstructor.cpp:

(JSC::Interpreter::constructWithNativeErrorConstructor):
(JSC::NativeErrorConstructor::getConstructData):
(JSC::Interpreter::callNativeErrorConstructor):
(JSC::NativeErrorConstructor::getCallData):

Don't want NativeErrorConstructor to call Interpreter::getStackTrace() directly. So, we moved the helper functions into the Interpreter class.

7:49 AM Changeset in webkit [153822] by Alan Bujtas

5 edits
2 adds in trunk

REGRESSION (r121551) Incorrect handling of invalid media query list.
https://bugs.webkit.org/show_bug.cgi?id=119164

Reviewed by Antti Koivisto.

Differentiate between syntactically invalid media queries and media queries with empty expressions.

Introduce a dedicated function for valid, but empty expression queries, so that passing NULL MediaQuerySet
object to CSSParser::createMediaRule() can indicate invalid media query.

Source/WebCore:

Test: fast/media/invalid-media-query-list.html

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createEmptyMediaRule):

css/CSSParser.h:

LayoutTests:

fast/media/invalid-media-query-list-expected.html: Added.
fast/media/invalid-media-query-list.html: Added.

6:30 AM Changeset in webkit [153821] by zarvai@inf.u-szeged.hu

25 edits
3 adds in trunk/LayoutTests

[Qt] Unreviewed rebaselining after r153647.

platform/qt/fast/css/input-search-padding-expected.png:
platform/qt/fast/css/input-search-padding-expected.txt:
platform/qt/fast/css/text-overflow-input-expected.png:
platform/qt/fast/css/text-overflow-input-expected.txt:
platform/qt/fast/forms/box-shadow-override-expected.png:
platform/qt/fast/forms/box-shadow-override-expected.txt:
platform/qt/fast/forms/control-restrict-line-height-expected.png:
platform/qt/fast/forms/control-restrict-line-height-expected.txt:
platform/qt/fast/forms/placeholder-position-expected.png:
platform/qt/fast/forms/placeholder-position-expected.txt:
platform/qt/fast/forms/placeholder-pseudo-style-expected.png:
platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
platform/qt/fast/forms/search-rtl-expected.png:
platform/qt/fast/forms/search-rtl-expected.txt:
platform/qt/fast/forms/search-styled-expected.png:
platform/qt/fast/forms/search-styled-expected.txt:
platform/qt/fast/forms/search-vertical-alignment-expected.png:
platform/qt/fast/forms/search-vertical-alignment-expected.txt:
platform/qt/fast/forms/search/search-size-with-decorations-expected.png: Added.
platform/qt/fast/forms/search/search-size-with-decorations-expected.txt: Added.
platform/qt/fast/repaint/search-field-cancel-expected.png:
platform/qt/fast/repaint/search-field-cancel-expected.txt:

4:00 AM Changeset in webkit [153820] by gyuyoung.kim@samsung.com

4 edits in trunk/Source/WebCore

Introduce toSVGMPathElement(), and use it
https://bugs.webkit.org/show_bug.cgi?id=119566

Reviewed by Andreas Kling.

As a step to change static_cast with toSVGXXX, static_cast<SVGMPathElement*> can
be changed with toSVGMPathElement().

svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::updateAnimationPath):

svg/SVGMPathElement.h:

(WebCore::toSVGMPathElement):

svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):

3:25 AM Changeset in webkit [153819] by Stephanie Lewis

2 edits in trunk/Source/JavaScriptCore

<rdar://problem/14680524> REGRESSION(153806): Crash @ yahoo.com when WebKit is built with a .order file

Unreviewed.

Ensure llint symbols are in source order.

JavaScriptCore.order:

2:54 AM Changeset in webkit [153818] by allan.jensen@digia.com

2 edits in trunk/LayoutTests

[Qt] Skip more tests depending on canvas blending.
https://bugs.webkit.org/show_bug.cgi?id=100072

Unreviewed gardening.

platform/qt/TestExpectations:

12:58 AM Changeset in webkit [153817] by vivek.vg@samsung.com

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Use granular DOMStorage modification events to avoid complete DataGrid update.
https://bugs.webkit.org/show_bug.cgi?id=119541

Reviewed by Joseph Pecoraro.

InspectorDOMStorageAgent sends more granular events about the storage modifications.
Using these would avoid the complete rebuilding of the DataGrid.

UserInterface/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView.prototype.itemsCleared):
(WebInspector.DOMStorageContentView.prototype.itemRemoved):
(WebInspector.DOMStorageContentView.prototype.itemAdded):
(WebInspector.DOMStorageContentView.prototype.itemUpdated):

UserInterface/DOMStorageObserver.js:

(WebInspector.DOMStorageObserver.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageObserver.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageObserver.prototype.domStorageItemAdded):
(WebInspector.DOMStorageObserver.prototype.domStorageItemUpdated):

UserInterface/StorageManager.js:

(WebInspector.StorageManager.prototype.domStorageItemsCleared):
(WebInspector.StorageManager.prototype.domStorageItemRemoved):
(WebInspector.StorageManager.prototype.domStorageItemAdded):
(WebInspector.StorageManager.prototype.domStorageItemUpdated):

12:18 AM Changeset in webkit [153816] by Antti Koivisto

10 edits in trunk/Source/WebCore

Move more style recalc code to StyleResolveTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=119553

Reviewed by Andreas Kling.

css/StyleResolver.cpp:
css/StyleResolver.h:

Remove now unused StyleResolver::styleForText.

dom/ElementShadow.cpp:
dom/ElementShadow.h:

Remove ElementShadow::recalcStyle.

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setResetStyleInheritance):

Use Style::resolveTree instead of ElementShadow::recalcStyle.

dom/ShadowRoot.h:

Remove ShadowRoot::recalcStyle.

dom/Text.cpp:
dom/Text.h:

Remove Text::recalcTextStyle.

style/StyleResolveTree.cpp:

(WebCore::Style::updateTextStyle):

Moved from Text::recalcTextStyle. Speed up by just setting the parent style on common case.

(WebCore::Style::resolveShadowTree):

Moved from ShadowRoot::recalcStyle.
Simplified to cover only cases that can occur with the current shadow DOM support.

(WebCore::Style::resolveTree):

12:16 AM Changeset in webkit [153815] by akling@apple.com

3 edits
2 adds in trunk

REGRESSION(r139282): Old caret sometimes gets "stuck" (not repainted) in contenteditable elements.
<http://webkit.org/b/119520>
<rdar://problem/14658929>

Reviewed by Simon Fraser.

Source/WebCore:

When computing a new caret rect, don't forget to repaint the old rect if the caret jumped
from one node to another.
We were being a little too clever, assuming that oldRect==newRect meant that no repaint was
necessary, but moving from (0,0) in one node to (0,0) in another would cause a ghost caret
in the old node.

Test: fast/repaint/caret-jump-between-nodes.html

editing/FrameSelection.cpp:

(WebCore::FrameSelection::recomputeCaretRect):

Fall through all the way down to caret repaints if the selection's new anchor node is not
the same as m_previousCaretNode.

LayoutTests:

fast/repaint/caret-jump-between-nodes-expected.txt: Added.
fast/repaint/caret-jump-between-nodes.html: Added.

Aug 7, 2013:

11:28 PM Changeset in webkit [153814] by abucur@adobe.com

12 edits
12 adds in trunk

[CSS Regions] Propagate overflow from the flow thread to the first and last region
https://bugs.webkit.org/show_bug.cgi?id=118526

Reviewed by David Hyatt.

Source/WebCore:

The patch implements layout overflow propagation for the first and last regions. The approach
taken is triggering a simple layout on the regions after the named flows are laid out
that extracts the layout overflow from the flow thread and adds it to the regions.

The process is based on adding two new layout phases: the overflow phase and the final phase.
The overflow phase is set after the flow threads are laid out and it marks the regions as
needing to extract the overflow from the flow thread. In case there are blocks with auto overflow
it's possible the overflow to create scrollbars that shrink the regions. In this case the flow
thread is relaid out and set in the final phase, forcing the regions to recollect the layout
overflow. In theory this would be an N-step layout because scrollbars can force content to change
regions and create overflow for other blocks (and thus creating more scrollbars). For now, we are
limiting this to the first pass by inserting this new final layout phase.

A short description of the processing model for a document:

layout the document (all the flow threads should be in the constrained layout phase after this step)
reverse iterate through the flow threads and mark the regions for simplified layout (we need to

reverse iterate so the overflow can correctly propagate with nested regions)

if the layout changes the size of a region, invalidate the flow thread and when laying it out mark

it as needing a new pass

make a secondary pass through the flow threads that changed after scrollbars have been added and

recompute the overflow for their regions; mark the flow threads in the final phase (flow threads can't
be invalidated in the final phase)

after the overflow was propagated update all the flow threads in the normal layout phase

There are some issues with the patch:

the simplified layout doesn't compute correct overflow values for inline blocks
the layout overflow from the flow thread doesn't take the region size into account

The first issue is not related to regions and will be fixed in a future patch. The second issue
will be fixed when box overflow will be region bound.

Tests: fast/regions/overflow-scrollable-1.html

fast/regions/overflow-scrollable-2.html
fast/regions/overflow-scrollable-3.html
fast/regions/overflow-scrollable-fit-complex.html
fast/regions/overflow-scrollable-fit.html
fast/regions/overflow-scrollable-nested.html

rendering/FlowThreadController.cpp: Flow threads layout driver functions.

(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoOverflowPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoFinalPhase):

rendering/FlowThreadController.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedNormalFlowLayout):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::firstRegion): This getter should work even though the region chain is invalid.
(WebCore::RenderFlowThread::lastRegion): This getter should work even though the region chain is invalid.
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded): If the flow thread has no overflow do nothing.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):

rendering/RenderFlowThread.h:
rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::maxPageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Used to get the flow thread visual or layout overflow.
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::updateLogicalHeight):

rendering/RenderRegion.h:
rendering/RenderView.cpp:

(WebCore::RenderView::layoutContentToComputeOverflowInRegions):
(WebCore::RenderView::layout):

rendering/RenderView.h:

LayoutTests:

Add tests for scrolling of regions in containers in different situations: regions with
transforms, nested regions, regions affected by scrollbars etc.

fast/regions/overflow-scrollable-1-expected.html: Added.
fast/regions/overflow-scrollable-1.html: Added.
fast/regions/overflow-scrollable-2-expected.html: Added.
fast/regions/overflow-scrollable-2.html: Added.
fast/regions/overflow-scrollable-3-expected.html: Added.
fast/regions/overflow-scrollable-3.html: Added.
fast/regions/overflow-scrollable-fit-complex-expected.html: Added.
fast/regions/overflow-scrollable-fit-complex.html: Added.
fast/regions/overflow-scrollable-fit-expected.html: Added.
fast/regions/overflow-scrollable-fit.html: Added.
fast/regions/overflow-scrollable-nested-expected.txt: Added.
fast/regions/overflow-scrollable-nested.html: Added.

9:20 PM Changeset in webkit [153813] by benjamin@webkit.org

1 edit
3 adds in trunk/Websites/webkit.org

Update the images for the blog size-matters

blog-files/size-matters/JavaScriptCore-relative-binary-growth.png: Added.
blog-files/size-matters/WebCore-relative-binary-growth.png: Added.
blog-files/size-matters/WebKit-relative-binary-growth.png: Added.

9:08 PM Changeset in webkit [153812] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit

Unreviewed build fix on Efl port after r153785.

CMakeLists.txt: Added "${WEBCORE_DIR}/style" in include list.

7:13 PM Changeset in webkit [153811] by Simon Fraser

2 edits in trunk/Tools

Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
https://bugs.webkit.org/show_bug.cgi?id=119317

Reviewed by Tim Horton.

The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
the test to complete, which is not power friendly. Although DRT instances
are generally busy anyway, not sitting in a busy loop should free up some CPU
cycles for other instances of DRT.

Editing tests continue to pass. All Java tests are skipped and were not
tested, but when run fail similarly with and without the patch.

DumpRenderTree/mac/DumpRenderTree.mm:

(dump):
(runTest):

7:00 PM Changeset in webkit [153810] by Simon Fraser

5 edits in trunk/Source/WebCore

Avoid spurious "all repaint" layouts when scrolling WebViews on Retina displays
https://bugs.webkit.org/show_bug.cgi?id=119564

Reviewed by Beth Dakin.

When scrolling WebViews on Macs with Retina displays, AppKit uses
device pixels for the scroll offset, so [scrollView() documentVisibleRect]
can return a CGRect with non-integral origin. This rect is used by layout,
via layoutSize(), to decide whether the view size changed, which prompts
a full repaint. However, FrameView gets a value which has been rounded
by enclosingIntRect(), which increases the height or width by 1px if the
y or x offset is on a half-pixel, causing spurious full repaints.

Fix by plumbing through platformVisibleContentSize(), which just
gets the size of the -documentVisibleRect.

page/FrameView.cpp:

(WebCore::FrameView::layout): Don't get layoutHeight and layoutWidth
separately, since that is two calls down into platformVisibleContentSize.

platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::platformVisibleContentSize):

platform/ScrollView.h:
platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformVisibleContentSize):

6:31 PM Changeset in webkit [153809] by Simon Fraser

2 edits in trunk/Source/WebCore

Be more aggressive about sending fake mouse events less frequently
https://bugs.webkit.org/show_bug.cgi?id=119563
<rdar://problem/14669029>

Reviewed by Tim Horton.

r109151 added code that throttles back the fake mouse events that we
send during scrolling, but in such a way that a page could take up to
100ms to handle a single mousemove, and we'd still send fake mousemove
events every 100ms. This could cause serious scrolling stutter.

Fix by changing when we drop back to sending events every 250ms, rather than every
100ms: if the slowest mousemove takes 10ms or more (less than one frame), drop back
to a 250ms fake move interval.

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):

5:51 PM Changeset in webkit [153808] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove pointless const in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=119550

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-07
Reviewed by Rob Buis.
Internally reviewed by Leo Yang and Mike Fenton.

Api/WebPageClient.h:
WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
(BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):

WebKitSupport/InputHandler.h:

4:05 PM Changeset in webkit [153807] by cavalcantii@gmail.com

2 edits in trunk/Source/WebCore

[rendering] Implement PaintInfo interfaces
https://bugs.webkit.org/show_bug.cgi?id=119388

Reviewed by Benjamin Poulain.

In discussion in IRC, it was decided to remove this comment since implementing such change
would have a vast impact on rendering classes.

rendering/PaintInfo.h:

3:41 PM Changeset in webkit [153806] by Lucas Forschler

8 edits in branches/safari-537-branch/Source

Merged r153775. <rdar://problem/14517392>

3:16 PM Changeset in webkit [153805] by dino@apple.com

2 edits in trunk/Source/WebCore

Don't remove contents layer from its parent unless necessary
https://bugs.webkit.org/show_bug.cgi?id=119560

Reviewed by Simon Fraser.

RenderLayerBacking::updateInternalHierarchy() is called in some
instances where there doesn't need to be a complete reparenting of the
the m_graphicsLayer. For example, on OS X when the user changes the
scrollbar styles to/from always visible. We don't need to always
remove the graphics layer from its parent - any reparenting does that
automatically.

Unfortunately we can't trigger this situation in an automated test.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateInternalHierarchy): Don't call removeFromParent().

3:00 PM Changeset in webkit [153804] by dbates@webkit.org

2 edits in trunk/Tools

Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
<https://bugs.webkit.org/show_bug.cgi?id=119558>

Reviewed by Martin Robinson.

Currently we build the command line to execute jsDriver.pl twice so as to both
print it to standard output and actually execute it. We should only build up
this command line once. Moreover, we should print to standard output the actual
command line that we are going to use including the GTK- and EFL-specific call
to /Tools/jhbuild/jhbuild-wrapper.

Scripts/run-javascriptcore-tests:

2:49 PM Changeset in webkit [153803] by Lucas Forschler

2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merge patch for <rdar://problem/14655517>

2:44 PM Changeset in webkit [153802] by Lucas Forschler

2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merged r153793. <rdar://problem/14666354>

2:38 PM Changeset in webkit [153801] by achristensen@apple.com

2 edits in trunk/Source/WTF

Fixed wrong definition for AppleWin port's WebGL after r153768.

Rubberstamped by Benjamin Poulain.

wtf/Platform.h: Replaced WTF_USE_SURFACE with WTF_USE_GRAPHICS_SURFACE.

2:31 PM Changeset in webkit [153800] by Lucas Forschler

2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153773. <rdar://problem/14652681>

2:27 PM Changeset in webkit [153799] by Lucas Forschler

4 edits
3 copies in branches/safari-537-branch

Merged r153374. <rdar://problem/14443495>

2:13 PM Changeset in webkit [153798] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] REGRESSION after r153432: some accessibility tests crash.
https://bugs.webkit.org/show_bug.cgi?id=119333

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-08-07
Reviewed by Darin Adler.

Use a RefPtr to store a reference to the parent element of
an AccessibilityUIElement instead of the raw pointer, so we
never derefence a function from an invalid pointer.

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.

12:52 PM Changeset in webkit [153797] by timothy_horton@apple.com

7 edits
3 adds in trunk

Fall out of simple image layer optimization if the image has EXIF rotation
https://bugs.webkit.org/show_bug.cgi?id=119535
<rdar://problem/14071174>

Reviewed by Simon Fraser.

Test: fast/images/exif-orientation-composited.html

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameOrientationAtIndex):
Ensure that the frame is cached if we're requesting the orientation,
so we can acquire orientation information at any given time.

platform/mac/DragImageMac.mm:

(WebCore::createDragImageFromImage):

platform/graphics/BitmapImage.h:

Rename currentFrameOrientation to frameOrientationForCurrentFrame to match
the similarly-behaving nativeImageForCurrentFrame.

platform/graphics/Image.h:

(WebCore::Image::orientationForCurrentFrame): Added. Virtual, overriden by BitmapImage.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
If the given image has a non-default image orientation, don't use direct compositing.

Add a test that ensures that composited images with EXIF orientation paint correctly.

fast/images/exif-orientation-composited-expected.txt: Added.
fast/images/exif-orientation-composited.html: Added.
platform/mac/fast/images/exif-orientation-composited-expected.png: Added.

12:13 PM Changeset in webkit [153796] by Antti Koivisto

2 edits in trunk/Source/WebCore

fast/frames/seamless/seamless-custom-font-pruning-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=119557

Rubber-stamped by Eric Carlson.

Pass Style::Detach style change to seamless document as Style::Force. Style::resolveTree does not expect to be called with Detach.

html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::didRecalcStyle):

11:40 AM Changeset in webkit [153795] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data
https://bugs.webkit.org/show_bug.cgi?id=115354

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-08-07
Reviewed by Philippe Normand.

The default value for the HTTP "Accept-Encoding:" header field in the request allows
compressed data to be received on requests.
While this works fine for most cases, it can break the webkit source that needs to rely on the
the proper data size when receiving the response (even though the received data is already
uncompressed the size reported in ResourceResponse::expectedContentLength() is the same
represented by the HTTP header field "Content-Length" which is the size of the compressed data).

This patch disables the HTTP "Accept-Encoding:" header field when using the request
as we don't want the received response to be encoded in any way, as we need to rely on the proper
size of the returned data on ResourceHandle::didReceiveResponse().

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

platform/network/soup/ResourceRequest.h:

(ResourceRequestBase):
(WebCore::ResourceRequest::acceptEncoding):
(WebCore::ResourceRequest::setAcceptEncoding):
(WebCore::ResourceRequest::ResourceRequestBase):

platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

11:40 AM Changeset in webkit [153794] by Antti Koivisto

2 edits in trunk/Source/WebKit/win

Try to fix Win WK1 build.

Not reviewed.

WebFrame.cpp:

(WebFrame::invalidate):

11:36 AM Changeset in webkit [153793] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state
https://bugs.webkit.org/show_bug.cgi?id=119555

Reviewed by Geoffrey Garen.

It uses a speculationCheck where it should be using a DFG_TYPE_CHECK like the 64-bit backend does.
This was causing crashes on maps.google.com in 32-bit debug builds.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:30 AM Changeset in webkit [153792] by ctruta@gmail.com

2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

Scripts/webkitpy/common/config/contributors.json:

9:56 AM Changeset in webkit [153791] by allan.jensen@digia.com

2 edits in trunk/LayoutTests

[Qt] Skip background-blending-mode tests

Unreviewed gardening.

platform/qt/TestExpectations:

9:34 AM Changeset in webkit [153790] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r) Two pixel result fail after r153522
https://bugs.webkit.org/show_bug.cgi?id=119392

Reviewed by Jocelyn Turcotte.

Consider scaling transform on the painter to determine final destination size.

Covered by existing tests.

platform/graphics/qt/ImageQt.cpp:

(WebCore::prescaleImageIfRequired):
(WebCore::BitmapImage::draw):

9:17 AM Changeset in webkit [153789] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=119405

Reviewed by Geoffrey Garen.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString): For X86 32 bit, construct an indexed address
ourselves to save a register and then load from it.

8:02 AM Changeset in webkit [153788] by Antti Koivisto

6 edits in trunk

2.5% regression on page cycler moz
https://bugs.webkit.org/show_bug.cgi?id=102822

Source/WebCore:

Reviewed by Andreas Kling.

DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache() triggers a style recalc for quirks mode
documents in the beginning of document parsing via Document::setCompatibilityMode. This often coalesces
with style recalc triggered by stylesheet loading. However on very simple documents it can generate genuinely
unnecessary work.

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):

Check that we actually have cached injected stylesheets before triggering style recalc.

page/PageGroup.cpp:

(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):

Fix a misspelling.

(WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):

Always invalidate style when user sheets change since we don't do that in
DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache anymore.

page/PageGroup.h:

LayoutTests:

Reviewed by Andreas Kling.

This is a progression.

inspector/timeline/timeline-script-tag-1-expected.txt:

8:00 AM Changeset in webkit [153787] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Do no check seek offset against internal size on gstreamer source element
https://bugs.webkit.org/show_bug.cgi?id=116533

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-08-07
Reviewed by Philippe Normand.

The internal size on gstreamer source element may be wrong in case the received size in
didReceiveResponse is not accurate. Lets just try to seek and let it fail if necessary.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcSeekDataCb):

7:31 AM Changeset in webkit [153786] by Antti Koivisto

2 edits in trunk/Source/WebKit2

Try to fix EFL build.

Not reviewed.

CMakeLists.txt:

7:22 AM Changeset in webkit [153785] by Antti Koivisto

10 edits
2 moves
1 add in trunk/Source/WebCore

Create WebCore/style and move StyleResolveTree there
https://bugs.webkit.org/show_bug.cgi?id=119543

Reviewed by Andreas Kling.

WebCore/css is bloated. We should move the internal style representation and the style resolver
related code to a directory of their own. CSS language related code including parser and
CSSOM stays under css.

Things named StyleFoo should generally move under WebCore/style. They should also be moved to
the Style namespace at the same time.

CMakeLists.txt:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.pri:
Target.pri:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCoreCommon.props:
WebCore.vcxproj/copyForwardingHeaders.cmd:
WebCore.xcodeproj/project.pbxproj:
css/StyleResolveTree.cpp: Removed.
css/StyleResolveTree.h: Removed.
style: Added.
style/StyleResolveTree.cpp: Copied from Source/WebCore/css/StyleResolveTree.cpp.
style/StyleResolveTree.h: Copied from Source/WebCore/css/StyleResolveTree.h.

6:42 AM Changeset in webkit [153784] by commit-queue@webkit.org

1 edit
17 adds in trunk/LayoutTests

[CSS Blending] Add test suite to validate background blending with different properties
https://bugs.webkit.org/show_bug.cgi?id=118243

Patch by Mirela Budaes <mbudaes@adobe.com> on 2013-08-07
Reviewed by Dirk Schulze.

css3/compositing/background-blend-mode-background-attachement-fixed-expected.html: Added.
css3/compositing/background-blend-mode-background-attachement-fixed.html: Added.
css3/compositing/background-blend-mode-background-clip-content-box-expected.html: Added.
css3/compositing/background-blend-mode-background-clip-content-box.html: Added.
css3/compositing/background-blend-mode-background-clip-padding-box-expected.html: Added.
css3/compositing/background-blend-mode-background-clip-padding-box.html: Added.
css3/compositing/background-blend-mode-background-origin-border-box-expected.html: Added.
css3/compositing/background-blend-mode-background-origin-border-box.html: Added.
css3/compositing/background-blend-mode-background-position-percentage-expected.html: Added.
css3/compositing/background-blend-mode-background-position-percentage.html: Added.
css3/compositing/background-blend-mode-background-repeat-no-repeat-expected.html: Added.
css3/compositing/background-blend-mode-background-repeat-no-repeat.html: Added.
css3/compositing/background-blend-mode-background-size-contain-expected.html: Added.
css3/compositing/background-blend-mode-background-size-contain.html: Added.
css3/compositing/background-blend-mode-background-size-cover-expected.html: Added.
css3/compositing/background-blend-mode-background-size-cover.html: Added.
css3/compositing/resources/white_square.svg: Added.

5:02 AM Changeset in webkit [153783] by Antti Koivisto

42 edits
2 adds in trunk/Source/WebCore

Move style recalculation out from Element
https://bugs.webkit.org/show_bug.cgi?id=119497

Reviewed by Andreas Kling.

Element currently does too much. Element::recalcStyle() and the related functions can be turned into
standalone functions that operate on DOM tree. This will also give more freedom for future refactoring,
for example making style recalculation non-recursive.

WebCore.xcodeproj/project.pbxproj:
css/StyleResolveTree.cpp: Added.

(WebCore::Style::determineChange):

moved and renamed from Node::diff
factored to use early return style
simplifield the null input logic

(WebCore::Style::pseudoStyleCacheIsInvalid):

moved from Element::pseudoStyleCacheIsInvalid
narrowed to take RenderObject rather than operate on Element

(WebCore::Style::resolveLocal):

split from Element::recalcStyle
factored to use early return style

(WebCore::Style::resolveTree):

moved and renamed from Element::recalcStyle

css/StyleResolveTree.h: Added.

introcuduce Style namespace for style related classes and functions
move and rename Node::StyleChange -> Style::Change

css/StyleResolver.h:

(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
(WebCore::StyleResolverParentPusher::push):
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):

Moved this stack helper to StyleResolver.h for now since it is needed by both
StyleRecalculation and Element.

dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::attach):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::webkitWillEnterFullScreenForElement):

dom/Document.h:
dom/Element.cpp:

(WebCore::shouldIgnoreAttributeCase):
(WebCore::Element::updatePseudoElement):
(WebCore::Element::resetComputedStyle):
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):

dom/Element.h:

remove Element::recalcStyle
make a few private functions needed by StyleRecalculation public

dom/ElementShadow.cpp:

(WebCore::ElementShadow::recalcStyle):

dom/ElementShadow.h:
dom/Node.cpp:
dom/Node.h:

remove Node::StyleChange
remove Node::diff

dom/PseudoElement.cpp:

(WebCore::PseudoElement::didRecalcStyle):

dom/PseudoElement.h:
dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):
(WebCore::ShadowRoot::setResetStyleInheritance):

dom/ShadowRoot.h:
dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

dom/Text.h:
html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::didRecalcStyle):

html/HTMLFormControlElement.h:
html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::willRecalcStyle):

html/HTMLFrameSetElement.h:
html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::didRecalcStyle):

html/HTMLIFrameElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didRecalcStyle):

html/HTMLMediaElement.h:
html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::didRecalcStyle):

html/HTMLOptionElement.h:
html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):

html/HTMLPlugInImageElement.h:
inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::reportDataReceived):

page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):

svg/SVGElement.cpp:

(WebCore::SVGElement::willRecalcStyle):

svg/SVGElement.h:
svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::willRecalcStyle):

svg/SVGUseElement.h:

4:41 AM Changeset in webkit [153782] by allan.jensen@digia.com

2 edits in trunk/Source/WebKit/qt

[Qt] Build fix after r153751

Unreviewed build fix.

Fix build when PAGE_VISIBILITY_API is disabled.

WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::visibilityState):

2:11 AM Changeset in webkit [153781] by mihnea@adobe.com

3 edits
2 adds in trunk

[CSSRegions] Wrong auto-height region computation for nested named flows
https://bugs.webkit.org/show_bug.cgi?id=119517

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/abspos-autoheight-nested-region.html

In the case of an (inner) auto-height region that is absolutely positioned in a named flow that is displayed in an (outer) auto-height region,
when we are doing the layout for the named flow we need to add a "forced region break" also for the case of simplified layout, otherwise
the outer auto-height region will not get the chance to compute its auto-height, ending up with a huge value that was used to initialize
the auto-height computed value before the start of the layout algorithm.