⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 12, 2013:

11:38 PM Changeset in webkit [153982] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Fix null dereference in HTMLAnchorElement::sendPings when frame is not attached to a page
​https://bugs.webkit.org/show_bug.cgi?id=119716

Reviewed by Darin Adler.

Add a regression test for r153975.

  • fast/html/detach-frame-while-clicking-on-anchor-with-ping-expected.txt: Added.
  • fast/html/detach-frame-while-clicking-on-anchor-with-ping.html: Added.
11:26 PM Changeset in webkit [153981] by zandobersek@gmail.com
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: type() == Percent in WebCore::Length::percent
​https://bugs.webkit.org/show_bug.cgi?id=116715

Reviewed by Darin Adler.

Source/WebCore:

Allow the Calculated type in the Length::percent method that returns the Length's
float value. This reflects the changes in r110148 that adjusted the Length::isPercent
method to return true for Length objects of either Percent or Calculated type.

Test: fast/css/calculated-length-as-percent-crash.html

  • platform/Length.h:

(WebCore::Length::percent): Assert that Length::isPercent is true when Length::percent
is called, ensuring the Length's type is either Percent or Calculated.

LayoutTests:

Add the test case, as produced by the Fuzzinator, that was causing assertions
in Length::percent due to Length objects of the Calculated type not being treated
as holding a proper percent value in that method, despite Length::isPercent
returning true for Length objects of either Percent or the Calculated type.

  • fast/css/calculated-length-as-percent-crash-expected.txt: Added.
  • fast/css/calculated-length-as-percent-crash.html: Added.
11:26 PM Changeset in webkit [153980] by mitz@apple.com
  • 2 edits in trunk/Tools

extract-localizable-strings output is not suited for parsing by Xcode
​https://bugs.webkit.org/show_bug.cgi?id=119728

Reviewed by Darin Adler.

Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
removed “ERROR” since messages that refer to a line in a file are shown as error by default,
added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
with 0).

  • Scripts/extract-localizable-strings:
11:16 PM Changeset in webkit [153979] by zandobersek@gmail.com
  • 2 edits in trunk

[Autotools] Adjust the help string for the configure's --enable-optimizations flag
​https://bugs.webkit.org/show_bug.cgi?id=119682

Reviewed by Martin Robinson.

  • Source/autotools/ReadCommandLineArguments.m4: Remove the 'GCC only' part of the help

string for the --enable-optimizations flag. This is not true and can lead to confusion
since the optimizations can be applied when compiling with Clang as well.

10:58 PM Changeset in webkit [153978] by Darin Adler
  • 18 edits in trunk/Source/WebCore

Move Clipboard::declareAndWriteDragImage to DragController
​https://bugs.webkit.org/show_bug.cgi?id=117683

Reviewed by Brent Fulgham.

  • dom/Clipboard.h: Removed declareAndWriteDragImage.
  • page/DragController.cpp:

(WebCore::selectImageBeforeDragging): Half of the old prepareClipboardForImageDrag
is now refactored into this function.
(WebCore::DragController::startDrag): Where we called prepareClipboardForImageDrag,
instead call selectImageBeforeDragging and declareAndWriteDragImage. This is needed
because declareAndWriteDragImage needs to be a member function, for Mac at least.

  • page/DragController.h: Added declareAndWriteDragImage.
  • page/efl/DragControllerEfl.cpp:

(WebCore::DragController::declareAndWriteDragImage): Added empty placeholder.
It would be better to delete this file rather than having these placeholders.
I don't think EFL actually has drag support, and it makes work to have to keep
source files up to date that are really unused.

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::declareAndWriteDragImage): Added. Calls to DragClient, which
does the work.

  • page/qt/DragControllerQt.cpp:

(WebCore::DragController::declareAndWriteDragImage): Added. Calls Pasteboard::writeImage.

  • page/win/DragControllerWin.cpp:

(WebCore::DragController::declareAndWriteDragImage): Added. Uses Pasteboard functions to
do the work.

  • platform/Clipboard.h: Changed the pasteboard function to return a non-const reference.

For now, it's not clear what const will mean for pasteboards, and it's currently not
possible to write to a const pasteboard, which we need to do in the new
DragController::declareAndWriteDragImage functions.

  • platform/Pasteboard.h: Added a new writeMarkup function, implemented only for Windows

at this time.

  • platform/efl/ClipboardEfl.cpp: Deleted declareAndWriteDragImage.
  • platform/gtk/ClipboardGtk.cpp: Ditto.
  • platform/ios/ClipboardIOS.h: Ditto.
  • platform/ios/ClipboardIOS.mm: Ditto.
  • platform/mac/ClipboardMac.mm: Ditto.
  • platform/qt/ClipboardQt.cpp: Ditto.
  • platform/win/ClipboardWin.cpp: Ditto.
  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writePlainTextToDataObject): Took out a pointless line of code.
(WebCore::Pasteboard::writeMarkup): Added. Currently implemented only for Windows.
This factors out a significant piece of DragController::declareAndWriteDragImage,
and will probably be handy for other platforms later.

10:55 PM Changeset in webkit [153977] by ryuan.choi@samsung.com
  • 5 edits in trunk

[EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
​https://bugs.webkit.org/show_bug.cgi?id=119585

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::provisionalURL):
Implemented to pass provisionalURL of main frame to DumpRenderTreeChrome.

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(pathSuitableForTestResult):
Return path string that's relative to main frame URL, or just file name if
the resource is not in the same directory subtree.
Referenced WebKitTestRunner code in r153852.
(descriptionSuitableForTestResult):
(DumpRenderTreeChrome::onFrameRedirectRequested):
(DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.

10:53 PM Changeset in webkit [153976] by mitz@apple.com
  • 3 edits in trunk/Tools

extract-localizable-strings doesn't know how to verify an existing strings file
​https://bugs.webkit.org/show_bug.cgi?id=119704

Reviewed by Darin Adler.

  • Scripts/extract-localizable-strings: Added an --exceptions option for specifying the

exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
exceptions file name to omitting the --exceptions option. Added a --skip option, changing
the way directories to skip are specified from prefixing the directory with a “-” to
specifying it with --skip.
Finally, added a --verify option. When specified, the strings file is not written to, but
instead read in and checked for consistency with the comments, keys and values derived from
the source files and the exceptions file. Missing keys, unused keys, mismatching values and
mismatching comments are reported as errors.

  • Scripts/update-webkit-localizable-strings: Updated for the new way of specifying

directories to skip and no exceptions file.

10:48 PM Changeset in webkit [153975] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist
​https://bugs.webkit.org/show_bug.cgi?id=119716

Reviewed by Darin Adler.

Merge ​https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1

No new tests since the test in the Blink change doesn't reproduce crash on WebKit.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::sendPings):

10:47 PM Changeset in webkit [153974] by Seokju Kwon
  • 2 edits in trunk/Source/WebCore

Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()
​https://bugs.webkit.org/show_bug.cgi?id=119710

Reviewed by Darin Adler.

No behavior change, no new tests needed.

  • rendering/RenderObject.cpp: Remove unused parameter warning.

(WebCore::shouldRepaintFixedBackgroundsOnScroll):

8:44 PM Changeset in webkit [153973] by ap@apple.com
  • 8 edits in trunk

http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=85522

Reviewed by Andy Estes.

Source/WebCore:

Drive-by FIXMEs and trivial fixes for WebCore issues I noticed while working
on this bug. No behavior change expected.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::findFrameForNavigation):

  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledFormSubmission::fire):

Tools:

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
when already done with a test. We already had this check in all UI delegate functions,
except for -webView:addMessageToConsole:withSource: somehow.

LayoutTests:

  • http/tests/security/sandboxed-iframe-form-top-expected.txt: Console logging got

improved while this test was marked as skipped or flaky, updating the results.

  • platform/mac/TestExpectations: Removed sandboxed-iframe-form-top.html, this test

no longer leaks output into later ones. The test was erroneously marked as flaky
instead of skipped, but now it's good.

8:34 PM Changeset in webkit [153972] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix variable name |end| -> |size| in EventTarget::fireEventListeners
​https://bugs.webkit.org/show_bug.cgi?id=119715

Reviewed by Benjamin Poulain.

Merge ​https://chromium.googlesource.com/chromium/blink/+/f58b017539c48059bb2b88d18ee0ee3d14decb01
and also fix variable names in FiringEventIterator.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::removeAllEventListeners):

  • dom/EventTarget.h:

(WebCore::FiringEventIterator::FiringEventIterator):

6:35 PM Changeset in webkit [153971] by ryuan.choi@samsung.com
  • 1 edit
    33 adds in trunk/LayoutTests

[EFL] Unreviewed gardening.

Add a missing result after r152911.

  • platform/efl/fast/multicol/pagination/BottomToTop-bt-expected.png: Added.
  • platform/efl/fast/multicol/pagination/BottomToTop-bt-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/BottomToTop-lr-expected.png: Added.
  • platform/efl/fast/multicol/pagination/BottomToTop-lr-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/BottomToTop-rl-expected.png: Added.
  • platform/efl/fast/multicol/pagination/BottomToTop-rl-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/BottomToTop-tb-expected.png: Added.
  • platform/efl/fast/multicol/pagination/BottomToTop-tb-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/LeftToRight-bt-expected.png: Added.
  • platform/efl/fast/multicol/pagination/LeftToRight-bt-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/LeftToRight-lr-expected.png: Added.
  • platform/efl/fast/multicol/pagination/LeftToRight-lr-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/LeftToRight-rl-expected.png: Added.
  • platform/efl/fast/multicol/pagination/LeftToRight-rl-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/LeftToRight-tb-expected.png: Added.
  • platform/efl/fast/multicol/pagination/LeftToRight-tb-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/RightToLeft-bt-expected.png: Added.
  • platform/efl/fast/multicol/pagination/RightToLeft-bt-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/RightToLeft-lr-expected.png: Added.
  • platform/efl/fast/multicol/pagination/RightToLeft-lr-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/RightToLeft-rl-expected.png: Added.
  • platform/efl/fast/multicol/pagination/RightToLeft-rl-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/RightToLeft-tb-expected.png: Added.
  • platform/efl/fast/multicol/pagination/RightToLeft-tb-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/TopToBottom-bt-expected.png: Added.
  • platform/efl/fast/multicol/pagination/TopToBottom-bt-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/TopToBottom-lr-expected.png: Added.
  • platform/efl/fast/multicol/pagination/TopToBottom-lr-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/TopToBottom-rl-expected.png: Added.
  • platform/efl/fast/multicol/pagination/TopToBottom-rl-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/TopToBottom-tb-expected.png: Added.
  • platform/efl/fast/multicol/pagination/TopToBottom-tb-expected.txt: Added.
6:12 PM Changeset in webkit [153970] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Encapsulate access to documentNamedItemMap and windowNamedItemMap
​https://bugs.webkit.org/show_bug.cgi?id=119701

Reviewed by Darin Adler.

Encapsulate m_documentNamedItem and m_windowNamedItem by adding various methods on HTMLDocument.
This will help us doing more refactorings in the future.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):

  • dom/Element.cpp:

(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForDocument):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::addDocumentNamedItem): Added.
(WebCore::HTMLDocument::removeDocumentNamedItem): Added.
(WebCore::HTMLDocument::addWindowNamedItem): Added.
(WebCore::HTMLDocument::removeWindowNamedItem): Added.

  • html/HTMLDocument.h:

(WebCore::HTMLDocument::documentNamedItem): Added.
(WebCore::HTMLDocument::hasDocumentNamedItem): Added.
(WebCore::HTMLDocument::documentNamedItemContainsMultipleElements): Added.
(WebCore::HTMLDocument::windowNamedItem): Added.
(WebCore::HTMLDocument::hasWindowNamedItem): Added.
(WebCore::HTMLDocument::windowNamedItemContainsMultipleElements): Added.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

6:10 PM Changeset in webkit [153969] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed an off-by-(sizeof(char*) - 1) bug.

Reviewed by Sam Weinig.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(WebKit::XPCServiceEventHandler): Allocate a sufficiently large buffer.

5:35 PM Changeset in webkit [153968] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[CMake] Use the correct list of files when compiling ANGLESupport on Windows
​https://bugs.webkit.org/show_bug.cgi?id=119439

Reviewed by Gyuyoung Kim.

  • CMakeLists.txt: Use ossource_win.cpp instead of ossource_posix.cpp on Windows platforms.
5:28 PM Changeset in webkit [153967] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Remove CodeBlock's notion of adding identifiers entirely
​https://bugs.webkit.org/show_bug.cgi?id=119708

Reviewed by Geoffrey Garen.

Remove addAdditionalIdentifier entirely, including the bogus assertion.
Move the addition of identifiers to DFGPlan::reallyAdd

  • bytecode/CodeBlock.h:
  • dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::reallyAdd):

  • dfg/DFGDesiredIdentifiers.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::finalize):

  • dfg/DFGPlan.h:
5:20 PM Changeset in webkit [153966] by ryuan.choi@samsung.com
  • 3 edits
    4 deletes in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Added pasteboard after r152185.
  • platform/efl/editing/deleting/delete-br-002-expected.txt: Updated after r152478.
  • platform/efl/editing/execCommand/outdent-blockquote-test1-expected.txt:

Removed platform specific expectations after r152494.

  • platform/efl/editing/execCommand/outdent-blockquote-test2-expected.txt: Ditto.
  • platform/efl/editing/execCommand/outdent-blockquote-test3-expected.txt: Ditto.
  • platform/efl/editing/execCommand/outdent-blockquote-test4-expected.txt: Ditto.
4:56 PM Changeset in webkit [153965] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix

4:42 PM Changeset in webkit [153964] by ap@apple.com
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=119693
[Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
because of connect-src-websocket-allowed.html

Reviewed by Darin Adler.

Starting a load of about:blank and immediately stopping it cancels outstanding
resource loads, but the page has to transition to committed state to have timers
or WebSockets stopped too.

  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to

ensure that transition to committed state happens before we start the next test.

4:41 PM Changeset in webkit [153963] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them
​https://bugs.webkit.org/show_bug.cgi?id=119705

Reviewed by Geoffrey Garen.

Relatively trivial refactoring

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfAdditionalIdentifiers):
(JSC::CodeBlock::addAdditionalIdentifier):
(JSC::CodeBlock::identifier):
(JSC::CodeBlock::numberOfIdentifiers):

  • dfg/DFGCommonData.h:
3:39 PM Changeset in webkit [153962] by oliver@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Stop making unnecessary copy of CodeBlock Identifier Vector
​https://bugs.webkit.org/show_bug.cgi?id=119702

Reviewed by Michael Saboff.

Make CodeBlock simply use a separate Vector for additional Identifiers
and use the UnlinkedCodeBlock for the initial set of identifiers.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfIdentifiers):
(JSC::CodeBlock::numberOfAdditionalIdentifiers):
(JSC::CodeBlock::addAdditionalIdentifier):
(JSC::CodeBlock::identifier):

  • dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::reallyAdd):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_arguments_length):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

3:05 PM Changeset in webkit [153961] by a.renevier@samsung.com
  • 4 edits in trunk/Source/WebCore

[cairo] memory corruption with putImageData and accelerated canvas.
​https://bugs.webkit.org/show_bug.cgi?id=118621

Reviewed by Martin Robinson.

When we have an accelerated imageBuffer, and we putByteArray with a
non zero destPoint, we create temporary surface of sourceSize. Then,
we write to image data with an offset. This results in an out of bound
write.

In order to avoid that, we use a 0 offset when writing data.

In addition, we also create image with the minimal needed size in
getImageData, and also use a 0 offset. This decrease data transfer
between cpu and gpu

Instead of the map/unmap mechanism, perform an explicit surface copy
when needed. This change also removes an unneeded glReadPixels at the
start of putByteArray

Add two parameters to copyRectFromOneSurfaceToAnother: destination
offset, and cairo drawing operator.

No new tests. Accelerated canvas is not enabled for testing yet.

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyRectFromOneSurfaceToAnother):

  • platform/graphics/cairo/CairoUtilities.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::copySurfaceToImageAndAdjustRect):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):

2:55 PM Changeset in webkit [153960] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK.
​https://bugs.webkit.org/show_bug.cgi?id=104104

Add back test expectation for Mac since it's still failing on ML WK1 bots.

  • platform/mac/TestExpectations:
  • platform/mac-wk2/TestExpectations:
2:50 PM Changeset in webkit [153959] by rniwa@webkit.org
  • 6 edits in trunk/Source

Use const AtomicStringImpl* in DocumentOrderedMap
​https://bugs.webkit.org/show_bug.cgi?id=119700

Reviewed by Benjamin Poulain.

Use const AtomicStringImpl* in DocumentOrderedMap. It caught at least one bug that HTMLNameCollection'
subclasses' nodeMatches were taking const AtomicString& instead of AtomicStringImpl*. This was forcing
DocumentOrderedMap::getElementByWindowNamedItem and DocumentOrderedMap::getElementByDocumentNamedItem
to create temporary AtomicStrings.

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesId):
(WebCore::keyMatchesName):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLabelForAttribute):
(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByName):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
(WebCore::DocumentOrderedMap::getAllElementsById):

  • dom/DocumentOrderedMap.h:

(WebCore::DocumentOrderedMap::containsSingle):
(WebCore::DocumentOrderedMap::contains):
(WebCore::DocumentOrderedMap::containsMultiple):

  • html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::nodeMatches):
(WebCore::DocumentNameCollection::nodeMatches):

  • html/HTMLNameCollection.h:

(WebCore::WindowNameCollection::nodeMatches):
(WebCore::DocumentNameCollection::nodeMatches):

2:37 PM Changeset in webkit [153958] by Beth Dakin
  • 6 edits
    2 adds in trunk

The LayoutMilestones didLayout callback should only fire for the main frame
​https://bugs.webkit.org/show_bug.cgi?id=119457

Reviewed by Sam Weinig.

Source/WebCore:

This patch makes it so that FrameLoader::didLayout(LayoutMilestones) is only ever
called for the main frame. Technically this will change existing API for
didFirstVisuallyNonEmptyLayoutInFrame and didFirstLayoutInFrame. Clients used to
be able to register for those callbacks for any frame they wanted, however, now
they will only ever get the callback when it applies to the main frame. We think
that this is acceptable since we don’t know of any clients that ever used those
APIs for a non-main frame. This change also makes nothing but sense for the
didLayout(LayoutMilestones) callback, since that is a Page-level concept, so it
should only fire for the main frame.

Only call didLayout for the main frame.

  • dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):

Assert that this is the main frame.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didLayout):

Only call didLayout for the main frame.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

Tools:

Now that the didLayout callback only fires for the main frame, we want to make
sure it will fire even when all of the content is in a subframe.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.

(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
2:02 PM Changeset in webkit [153957] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153917. <rdar://problem/14002715>

1:54 PM Changeset in webkit [153956] by Beth Dakin
  • 16 edits in trunk

Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=119658

Reviewed by Darin Adler.

Source/WebKit2:

Removing this function entirely will change some functionality in the Nightlies,
but we think that is an acceptable difference for the Nightlies. If is does cause
a problem though, we can roll out this patch and deprecate the function instead.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleLoaderClient):

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

12:47 PM Changeset in webkit [153955] by Christophe Dumez
  • 15 edits
    2 adds in trunk

Define DOM_KEY_LOCATION_* constants on KeyboardEvent
​https://bugs.webkit.org/show_bug.cgi?id=119341

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for the DOM_KEY_LOCATION_* constants on KeyboardEvent as per
the specification:
​http://www.w3.org/TR/DOM-Level-3-Events/#events-KeyboardEvent

Those constants are already supported by IE10, Firefox 22 and since
recently Blink.

Note that the following constants are not supported / exposed yet:
DOM_KEY_LOCATION_MOBILE and DOM_KEY_LOCATION_JOYSTICK.

Test: fast/events/keyboardevent-location-constants.html

  • dom/KeyboardEvent.cpp:

(WebCore::keyLocationCode):
(WebCore::KeyboardEvent::KeyboardEvent):

  • dom/KeyboardEvent.h:
  • dom/KeyboardEvent.idl:

LayoutTests:

Make use of the new DOM_KEY_LOCATION_* constants in the KeyboardEvent
test cases instead of hardcoding their values.

  • fast/events/constructors/keyboard-event-constructor-expected.txt:
  • fast/events/constructors/keyboard-event-constructor.html:
  • fast/events/js-keyboard-event-creation-expected.txt:
  • fast/events/js-keyboard-event-creation.html:
  • fast/events/keyboardevent-location-constants-expected.txt: Added.
  • fast/events/keyboardevent-location-constants.html: Added.
  • fast/events/keydown-leftright-keys-expected.txt:
  • fast/events/keydown-leftright-keys.html:
  • fast/events/keydown-numpad-keys-expected.txt:
  • fast/events/script-tests/keydown-numpad-keys.js:

(testKeyEventWithLocation):

  • platform/efl/fast/events/js-keyboard-event-creation-expected.txt:
  • platform/gtk/fast/events/js-keyboard-event-creation-expected.txt:
12:41 PM Changeset in webkit [153954] by Seokju Kwon
  • 2 edits in trunk/Tools

Remove glu's libtest rule from checker.py
​https://bugs.webkit.org/show_bug.cgi?id=119674

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
12:24 PM Changeset in webkit [153953] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Multiple CSP tests complain about undefined strings in echo-object-data.pl and echo-script-src.pl
​https://bugs.webkit.org/show_bug.cgi?id=119692

Reviewed by Darin Adler.

  • http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:
  • http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl:

Check whether optional CGI parameters are provided.

12:13 PM Changeset in webkit [153952] by timothy_horton@apple.com
  • 11 edits in trunk/Source/WebCore

dataLog dumpers for WebCore's basic geometry types
​https://bugs.webkit.org/show_bug.cgi?id=119636

Reviewed by Filip Pizlo.

  • platform/graphics/FloatPoint.cpp:

(WebCore::FloatPoint::dump):

  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::dump):

  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::dump):

  • platform/graphics/FloatSize.h:
  • platform/graphics/IntPoint.h:

(WebCore::IntPoint::dump):

  • platform/graphics/IntRect.cpp:

(WebCore::IntRect::dump):

  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:

(WebCore::IntSize::dump):

11:41 AM Changeset in webkit [153951] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Broken build with build-webkit --no-webgl
​https://bugs.webkit.org/show_bug.cgi?id=119272

Patch by Ragner Magalhaes <​ranger.n@samsung.com> on 2013-08-12
Reviewed by Alexandru Chiculita.

CSS_SHADERS requires WEBGL enabled.
Add error message to dependency failure.

  • wtf/FeatureDefines.h:
10:47 AM Changeset in webkit [153950] by Joseph Pecoraro
  • 2 edits
    3 adds in trunk/Source/WTF

[iOS] isMainThread implementation with USE(WEB_THREAD)
​https://bugs.webkit.org/show_bug.cgi?id=119644

Reviewed by Benjamin Poulain.

On iOS isMainThread() means that the current thread is either the
MainThread or WebThread and the current thread has the WebThreadLock.

  • wtf/ios/WebCoreThread.cpp: Added.
  • wtf/ios/WebCoreThread.h: Added.
  • wtf/mac/MainThreadMac.mm:

(WTF::isMainThread):

10:32 AM Changeset in webkit [153949] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] [WebKit2] Remove duplicate RAM Size calculation and reuse WTF::ramSize()
​https://bugs.webkit.org/show_bug.cgi?id=119663

Patch by Arunprasad Rajkumar <​arurajku@cisco.com> on 2013-08-12
Reviewed by Sam Weinig.

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformSetCacheModel):

10:23 AM Changeset in webkit [153948] by dino@apple.com
  • 3 edits
    2 adds in trunk

Shadows don't support viewport units
​https://bugs.webkit.org/show_bug.cgi?id=119649

Reviewed by Darin Adler.

Source/WebCore:

We don't yet support viewport units in shadows, so
fail parsing if we see one. The bug to fix this
completely is: ​https://webkit.org/b/119650

Test: fast/css/shadow-viewport-units.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow): Fail if we get one of
vh, vw, vmin, vmax.

LayoutTests:

Test that exercises a viewport unit in text-shadow to make sure we don't parse it.

  • fast/css/shadow-viewport-units-expected.txt: Added.
  • fast/css/shadow-viewport-units.html: Added.
10:16 AM Changeset in webkit [153947] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Don't load GAIL when using GTK 3.2 or greater
​https://bugs.webkit.org/show_bug.cgi?id=72735

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-08-12
Reviewed by Carlos Garcia Campos.

Source/WebKit/gtk:

  • tests/testatk.c:

(initializeTestingFramework):
(main):

Source/WebKit2:

  • UIProcess/API/gtk/tests/AccessibilityTestServer.cpp:

(main):

9:52 AM Changeset in webkit [153946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] Cookie is not set when url string is unicode.
​https://bugs.webkit.org/show_bug.cgi?id=119545

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-08-12
Reviewed by Brent Fulgham.

When the method setCookiesFromDOM is called with an unicode url parameter, the cookie is not correctly set.
We need to convert the cookie string to 8 bit, before passing it to the Curl api function.

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::setCookiesFromDOM): Convert cookie string to 8 bit, if needed.

9:49 AM Changeset in webkit [153945] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Revert r153912 because it broke some track tests.

Rubber-stamped by Antti Koivisto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack):

9:36 AM Changeset in webkit [153944] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Crash when starting second download.
​https://bugs.webkit.org/show_bug.cgi?id=119620

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-08-12
Reviewed by Brent Fulgham.

When a second download is started, a crash sometimes occurs in Curl.
This happens because the Curl easy handle is deleted and removed from the Curl multi handle twice.
This is solved by adding an array to keep track of active downloads to avoid double deletion.

  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownloadManager::CurlDownloadManager): Removed active download count member.
(WebCore::CurlDownloadManager::getActiveDownloadCount): Use active download array to return active download count.
(WebCore::CurlDownloadManager::updateHandleList): Remove Curl handles before adding, in case Curl reuses handles.
(WebCore::CurlDownloadManager::addToCurl): Add Curl handle to active download array.
(WebCore::CurlDownloadManager::removeFromCurl): Check if Curl handle is in active download array to avoid double deletion.
(WebCore::CurlDownloadManager::downloadThread): Removed active download count member.

  • platform/network/curl/CurlDownload.h: Added array of active downloads member, and removed download count member.
9:32 AM Changeset in webkit [153943] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[Win] TestWebKitAPI fails to link.
​https://bugs.webkit.org/show_bug.cgi?id=119619

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-08-12
Reviewed by Brent Fulgham.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export needed symbol.
8:52 AM Changeset in webkit [153942] by Antti Koivisto
  • 17 edits in trunk/Source/WebCore

Add ElementTraversal::next/previousSibling
​https://bugs.webkit.org/show_bug.cgi?id=119681

Reviewed by Andreas Kling.

Add nextSibling/previousSibling/lastWithin to ElementTraversal namespace.

  • Use them to replace internal use of Element::next/previousElementSibling DOM API for traversal.
  • Replace some Node::nextSibling() usage with ElementTraversal::nextSibling() for tighter code.
  • Replace ElementTraversal::nextSkippingChildren where it is used to traverse over immediate children only.
  • css/SelectorChecker.cpp:

(WebCore::isFirstChildElement):
(WebCore::isLastChildElement):
(WebCore::isFirstOfType):
(WebCore::isLastOfType):
(WebCore::countElementsBefore):
(WebCore::countElementsOfTypeBefore):
(WebCore::countElementsAfter):
(WebCore::countElementsOfTypeAfter):

  • dom/Element.cpp:

(WebCore::Element::lastElementChild):
(WebCore::Element::previousElementSibling):
(WebCore::Element::nextElementSibling):

  • dom/Element.h:
  • dom/ElementTraversal.h:

(WebCore::ElementTraversal::lastElementWithinTemplate):
(WebCore::ElementTraversal::lastWithin):
(WebCore::ElementTraversal::traverseNextSiblingElementTemplate):
(WebCore::ElementTraversal::nextSibling):
(WebCore::ElementTraversal::traversePreviousSiblingElementTemplate):
(WebCore::ElementTraversal::previousSibling):

  • editing/ApplyStyleCommand.cpp:

(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::tryIndentingAsListItem):

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::mergeWithNeighboringLists):

  • editing/markup.cpp:

(WebCore::createContextualFragment):

  • html/HTMLCollection.cpp:

(WebCore::firstMatchingChildElement):
(WebCore::nextMatchingSiblingElement):
(WebCore::HTMLCollection::traverseNextElement):
(WebCore::HTMLCollection::traverseForwardToOffset):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::childrenChanged):
(WebCore::HTMLFieldSetElement::legend):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::finishParsingChildren):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::containsJavaApplet):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title):

5:18 AM Changeset in webkit [153941] by allan.jensen@digia.com
  • 7 edits in trunk

[Qt] Add Support for canvas blend modes
​https://bugs.webkit.org/show_bug.cgi?id=100072

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Implement basic support for the blend-modes supported by QPainter.

Covered by existing tests.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::toQtCompositionMode):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

LayoutTests:

Unskip tests that now passes.

  • platform/qt/TestExpectations:
4:40 AM Changeset in webkit [153940] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebCore

Buildfix for !ENABLE(SVG). Fix warning by adding guard after r153901:
void WebCore::addString(WebCore::FeatureSet&, const char*)'
defined but not used [-Werror=unused-function]

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-08-12
Reviewed by Csaba Osztrogonác.

  • dom/DOMImplementation.cpp:
4:21 AM Changeset in webkit [153939] by Antti Koivisto
  • 34 edits
    1 add in trunk/Source/WebCore

Move ElementTraversal to ElementTraversal.h
​https://bugs.webkit.org/show_bug.cgi?id=119678

Rubber-stamped by Andreas Kling.

Move ElementTraversal namespace from NodeTraversal.h to a correctly named file.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:
  • css/StyleInvalidationAnalysis.cpp:
  • dom/Document.cpp:
  • dom/DocumentOrderedMap.cpp:
  • dom/Element.cpp:
  • dom/ElementTraversal.h: Added.

(WebCore::ElementTraversal::firstElementWithinTemplate):
(WebCore::ElementTraversal::firstWithin):
(WebCore::ElementTraversal::traverseNextElementTemplate):
(WebCore::ElementTraversal::next):
(WebCore::ElementTraversal::traverseNextElementSkippingChildrenTemplate):
(WebCore::ElementTraversal::nextSkippingChildren):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):

  • dom/Node.cpp:
  • dom/NodeTraversal.h:
  • dom/SelectorQuery.cpp:
  • dom/TreeScope.cpp:
  • dom/VisitedLinkState.cpp:
  • editing/FrameSelection.cpp:
  • editing/markup.cpp:
  • html/HTMLCollection.cpp:
  • html/HTMLFieldSetElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLLabelElement.cpp:
  • html/HTMLLegendElement.cpp:
  • html/HTMLMapElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/shadow/ContentDistributor.cpp:
  • page/FocusController.cpp:
  • rendering/RenderCounter.cpp:
  • rendering/RenderListItem.cpp:
  • svg/SVGSVGElement.cpp:
  • svg/SVGStyledElement.cpp:
  • svg/SVGUseElement.cpp:
  • svg/animation/SMILTimeContainer.cpp:
  • svg/graphics/SVGImage.cpp:
3:25 AM Changeset in webkit [153938] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Move some Document recalcStyle code to StyleResolveTree
​https://bugs.webkit.org/show_bug.cgi?id=119676

Reviewed by Andreas Kling.

Move the code that resolves the document and child styles to Style::resolveTree(Document*).

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

  • style/StyleResolveTree.h:
3:22 AM Changeset in webkit [153937] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Resource leak related to gstreamer and videos
​https://bugs.webkit.org/show_bug.cgi?id=109350

Reviewed by Eric Carlson.

Since active DOM object are only stopped once and can not be restarted, we can
unreference the media player there, instead of waiting for garbage collection.

If the r152778 is rolled back, this also breaks a circular reference between
GStreamer and WebKit which prevented garbage collecting from triggering.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::stop):

2:38 AM Changeset in webkit [153936] by rgabor@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed buildfix for webaudio.

  • Target.pri: Add missing files
2:17 AM Changeset in webkit [153935] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/win

More Windows build juice.

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

1:55 AM Changeset in webkit [153934] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Some build juice for the Windows bots after r153926 + r153927.

  • html/shadow/MediaControlElements.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::supportsFullscreen):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):

1:20 AM Changeset in webkit [153933] by zarvai@inf.u-szeged.hu
  • 12 edits
    13 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r153903.

  • platform/qt-5.0-wk1/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/cache/iframe-304-crash-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/loading/307-after-303-after-post-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/loading/redirect-methods-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
  • platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/qt-5.0-wk2/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • platform/qt-5.0-wk2/http/tests/misc/window-dot-stop-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • platform/qt-5.0-wk2/loader/go-back-cached-main-resource-expected.txt:
12:57 AM Changeset in webkit [153932] by g.czajkowski@samsung.com
  • 3 edits in trunk/LayoutTests

Update spellcheck-attribute.html description.
​https://bugs.webkit.org/show_bug.cgi?id=119486

Reviewed by Ryosuke Niwa.

r70512 r72782 added new fields to spellcheck-attribute.html to verify
spellcheck attribute.
Update the test to be more descriptive by dumping additional information
whether the misspelled word should be marked or not.

  • editing/spelling/spellcheck-attribute-expected.txt:
  • editing/spelling/spellcheck-attribute.html:
12:12 AM Changeset in webkit [153931] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.1.4

Tagging the WebKitGTK+ 2.1.4 release

Aug 11, 2013:

4:15 PM Changeset in webkit [153930] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Move RenderMathMLSpace.h/cpp to the right group in the Xcode project.

Reviewed by Dean Jackson.

  • WebCore.xcodeproj/project.pbxproj:
4:13 PM Changeset in webkit [153929] by dino@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Update localizedStrings - I think I checked in an unmerged version
in the previous commit.

  • Localizations/en.lproj/localizedStrings.js:
4:10 PM Changeset in webkit [153928] by dino@apple.com
  • 6 edits
    4 adds in trunk/Source/WebInspectorUI

Bootstrap canvas profiler
​https://bugs.webkit.org/show_bug.cgi?id=119652
<rdar://problem/14703665>

Reviewed by Joseph Pecoraro.

Add enough to get an empty Canvas profile recording
and displayed.

  • Localizations/en.lproj/localizedStrings.js: Add canvas strings.
  • UserInterface/CanvasProfileObject.js: Added. Mostly copied from CSS Selector Profiles.
  • UserInterface/CanvasProfileType.js: Added. Ditto.
  • UserInterface/CanvasDataGridNode.js: Added. Ditto.
  • UserInterface/CanvasProfileView.js: Added. Ditto.
  • UserInterface/ContentView.js:

(WebInspector.ContentView): Add support for the new View type.
(WebInspector.ContentView.isViewable):

  • UserInterface/InstrumentSidebarPanel.js:

(WebInspector.InstrumentSidebarPanel): Add support for canvas profiles.
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
(WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
(WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):

  • UserInterface/Main.html: Load the new files.
  • UserInterface/ProfileManager.js: New methods and support for canvas profiles.

(WebInspector.ProfileManager):
(WebInspector.ProfileManager.prototype.initialize):
(WebInspector.ProfileManager.prototype.isProfilingCanvas):
(WebInspector.ProfileManager.prototype.startProfilingCanvas):
(WebInspector.ProfileManager.prototype.stopProfilingCanvas):
(WebInspector.ProfileManager.prototype._checkForInterruptions):
(WebInspector.ProfileManager.prototype._attemptToResumeProfiling):

1:30 PM Changeset in webkit [153927] by akling@apple.com
  • 78 edits in trunk/Source

Make Page::settings() return a reference.
<​http://webkit.org/b/119662>

Reviewed by Anders Carlsson.

...and remove some pointless null checks that were exposed by doing this.

1:26 PM Changeset in webkit [153926] by akling@apple.com
  • 119 edits in trunk/Source

Make some things that return never-null pointers return references instead.
<​http://webkit.org/b/119660>

Reviewed by Antti Koivisto.

Source/WebCore:

These functions never return null anyway, so remove any ambiguity by letting
them return references instead of pointers.

  • Node::ensureRareData()
  • Element::ensureUniqueElementData()
  • Element::ensureShadow()
  • Element::ensureUserAgentShadowRoot()
  • StyledElement::ensureMutableInlineStyle()
  • NodeRareData::ensureNodeLists()
  • NodeRareData::ensureMutationObserverData()
  • EventTarget::ensureEventTargetData()
  • Document::ensureStyleResolver()
  • Document::selectorQueryCache()
  • Document::mediaQueryMatcher()
  • FlowThreadController::ensureRenderFlowThreadWithName()
  • HTMLTrackElement::ensureTrack()
  • SVGElement::ensureSVGRareData()
  • AnimationControllerPrivate::ensureCompositeAnimation()

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

1:11 PM Changeset in webkit [153925] by weinig@apple.com
  • 19 edits
    1 delete in trunk/Source/WebCore

Cleanup MediaQueryListListener
​https://bugs.webkit.org/show_bug.cgi?id=119664

Reviewed by Andreas Kling.

Make MediaQueryListListener a proper WebIDL callback.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Update project files.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(JSValueToNative):

  • bindings/scripts/IDLAttributes.txt:

Add support for CallbackNeedsOperatorEqual, which adds an operator==.

  • css/MediaAllInOne.cpp:

Remove MediaQueryListListener.cpp.

  • css/MediaQueryListListener.cpp:

Removed.

  • css/MediaQueryListListener.h:

(WebCore::MediaQueryListListener::~MediaQueryListListener):
(WebCore::MediaQueryListListener::MediaQueryListListener):

  • css/MediaQueryListListener.idl:

Convert to a proper WebIDL callback.

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::Listener::evaluate):
(WebCore::MediaQueryMatcher::styleResolverChanged):

  • css/MediaQueryMatcher.h:

Remove all traces of the ScriptState.

10:41 AM Changeset in webkit [153924] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and Versions.m4 for 2.1.4 release.

.:

  • Source/autotools/Versions.m4: Update version numbers.

Source/WebKit/gtk:

  • NEWS: Update release notes.
10:40 AM Changeset in webkit [153923] by ChangSeok Oh
  • 2 edits in trunk/Tools

Unreviewed. Change my primary mail address.

  • Scripts/webkitpy/common/config/contributors.json:
8:16 AM Changeset in webkit [153922] by Carlos Garcia Campos
  • 4 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/WebCore:

  • GNUmakefile.list.am: Remove unexistent header file.

Source/WTF:

  • GNUmakefile.list.am: Add missing header file.
Note: See TracTimeline for information about the timeline view.