⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 17, 2013:

8:08 PM Changeset in webkit [154245] by mhahnenberg@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

<​https://webkit.org/b/119919> Concurrent JIT crashes in various fast/js/dfg-* tests while the main thread is setting innerHTML

Reviewed by Filip Pizlo.

Added a new mode for DesiredWriteBarrier that allows it to track a position in a
Vector of WriteBarriers rather than the specific address. The fact that we were
arbitrarily storing into a Vector's backing store for constants at the end of
compilation after the Vector could have resized was causing crashes.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::constants):
(JSC::CodeBlock::addConstantLazily):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addConstant):

  • dfg/DFGDesiredWriteBarriers.cpp:

(JSC::DFG::DesiredWriteBarrier::DesiredWriteBarrier):
(JSC::DFG::DesiredWriteBarrier::trigger):
(JSC::DFG::initializeLazyWriteBarrierForConstant):

  • dfg/DFGDesiredWriteBarriers.h:

(JSC::DFG::DesiredWriteBarriers::add):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::truncateConstantToInt32):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::constantRegisterForConstant):

7:55 PM Changeset in webkit [154244] by bshafiei@apple.com
  • 5 edits in branches/safari-537-branch/Source

Versioning.

7:47 PM Changeset in webkit [154243] by bshafiei@apple.com
  • 1 copy in tags/Safari-537.60

New tag.

3:46 PM Changeset in webkit [154242] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

<​https://webkit.org/b/119963> Use TextNodeTraversal for getting sheet text in StyleElement

Reviewed by Andreas Kling.

  • dom/StyleElement.cpp:

(WebCore::StyleElement::process):

Use TextNodeTraversal::contentsAsString for the sheet text. The overflow check is removed as StringBuilder
(which is used by contentsAsString) does that itself. The behavior in case of overflow changes from empty
sheet to CRASH(). Thats what we do elsewhere in similar situations too (scripts for example). Continuing
with > 4GB of style sheet text nodes is probably not going to go well anyway.

3:05 PM Changeset in webkit [154241] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

<​https://webkit.org/b/119960> Remove some optimizations made obsolete by use of StringBuilder

Reviewed by Andreas Kling.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::scriptContent):

StringBuilder already optimizes for the single string case. If there is only one the original string is returned.

  • dom/Text.cpp:

(WebCore::Text::wholeText):

No need to traverse twice to compute the capacity. StringBuilder handles this efficiently.
Also in the common case there is only one string and the optimization here is actually hurting by disabling the StringBuilder one.

2:33 PM Changeset in webkit [154240] by Antti Koivisto
  • 18 edits
    2 adds in trunk/Source/WebCore

<​https://webkit.org/b/119959> Add TextNodeTraversal

Reviewed by Andreas Kling.

Add TextNodeTraversal for cleaner and more compact traversal of Text nodes.

Use it where appropriate.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged):

  • dom/NodeTraversal.h:

(WebCore::NodeTraversal::next):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::scriptContent):

  • dom/Text.cpp:

(WebCore::Text::wholeText):

  • dom/Text.h:

(WebCore::toText):

  • dom/TextNodeTraversal.cpp: Added.

(WebCore::TextNodeTraversal::appendContents):
(WebCore::TextNodeTraversal::contentsAsString):

Helpers for getting text content of a subtree.

  • dom/TextNodeTraversal.h: Added.

(WebCore::TextNodeTraversal::firstTextChildTemplate):
(WebCore::TextNodeTraversal::firstChild):
(WebCore::TextNodeTraversal::firstTextWithinTemplate):
(WebCore::TextNodeTraversal::firstWithin):
(WebCore::TextNodeTraversal::traverseNextTextTemplate):
(WebCore::TextNodeTraversal::next):
(WebCore::TextNodeTraversal::nextSibling):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::joinChildTextNodes):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultValue):
(WebCore::HTMLTextAreaElement::setDefaultValue):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::text):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::determineTextDirection):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsAboveCell):

  • xml/XPathUtil.cpp:

(WebCore::XPath::stringValue):

12:46 PM Changeset in webkit [154239] by akling@apple.com
  • 15 edits in trunk/Source

<​https://webkit.org/b/119957> Page::contextMenuController() should return a reference.

Reviewed by Antti Koivisto.

Page::m_contextMenuController is never null.

  • page/Page.h:

(WebCore::Page::contextMenuController):

11:05 AM Changeset in webkit [154238] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

<​https://webkit.org/b/119954> Page::dragCaretController() should return a reference.

Reviewed by Antti Koivisto.

Page::m_dragCaretController is never null.

  • dom/Document.cpp:

(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):

  • page/DragController.cpp:

(WebCore::DragController::cancelDrag):
(WebCore::DragController::dragEnded):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
(WebCore::DragController::placeDragCaret):

  • page/Page.h:

(WebCore::Page::dragCaretController):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret):

10:29 AM Changeset in webkit [154237] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

<​https://webkit.org/b/119952> Simplify Editor's back-pointer to the Frame.

Reviewed by Antti Koivisto.

Remove Editor's inheritance from FrameDestructionObserver. Editor is owned by Frame and
has no interest in observing frame destruction since its own destruction will soon follow.

Editor::m_frame is now a reference instead of a pointer. Removed some null checking.

10:23 AM Changeset in webkit [154236] by zandobersek@gmail.com
  • 2 edits
    1 add
    8 deletes in trunk/LayoutTests

<​https://webkit.org/b/119944> The fast/dom/gc-10.html layout test should dump text instead of render tree

Reviewed by Darin Adler.

The fast/dom/gc-10.html layout test is unnecessarily dumping the render tree and the pixel output.
Dumping the text output is sufficient enough for this test.

  • fast/dom/gc-10-expected.txt: Added.
  • fast/dom/gc-10.html:
  • platform/efl/fast/dom/gc-10-expected.png: Removed.
  • platform/efl/fast/dom/gc-10-expected.txt: Removed.
  • platform/gtk/fast/dom/gc-10-expected.txt: Removed.
  • platform/mac/fast/dom/gc-10-expected.png: Removed.
  • platform/mac/fast/dom/gc-10-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/dom/gc-10-expected.png: Removed.
  • platform/qt/fast/dom/gc-10-expected.png: Removed.
  • platform/qt/fast/dom/gc-10-expected.txt: Removed.
9:58 AM Changeset in webkit [154235] by akling@apple.com
  • 13 edits in trunk/Source

<​https://webkit.org/b/119950> Remove unused EditorClient::frameWillDetachPage() callback.

Reviewed by Antti Koivisto.

This callback was only used by the Chromium port.

  • editing/Editor.h:
  • editing/Editor.cpp:

Remove override of FrameDestructionObserver::willDetachPage().

  • page/EditorClient.h:

Remove frameWillDetachPage(). This is repeated in every EditorClient subclass.

9:36 AM Changeset in webkit [154234] by akling@apple.com
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Don't export Frame::settings() as it's an inline method now.

9:12 AM Changeset in webkit [154233] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/win

Windows build fix after r154219.

  • WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld):

8:43 AM Changeset in webkit [154232] by Antti Koivisto
  • 15 edits in trunk/Source/WebCore

<​https://webkit.org/b/119886> PseudoElement is abusing parent node pointer

Reviewed by Darin Adler.

PseudoElement sets its host node as its parent. This is confusing and wrong as it breaks
the basic tree consistency (a node is a child node of its parent node).

This patch adds an explicit host pointer PseudoElement and switches the call sites over. Memory
impact is negligible as there are not that many ::befores and ::afters.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseParent):

  • dom/EventPathWalker.cpp:

(WebCore::EventPathWalker::moveToParent):

  • dom/EventRetargeter.h:

(WebCore::EventRetargeter::eventTargetRespectingTargetRules):

  • dom/Node.cpp:

(WebCore::Node::~Node):

Add consistency assertions. Remove unnecessary clearing of sibling pointers. They should be cleared already.

(WebCore::Node::markAncestorsWithChildNeedsStyleRecalc):

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::PseudoElement):
(WebCore::PseudoElement::customStyleForRenderer):

  • dom/PseudoElement.h:

(WebCore::toPseudoElement):

Add casting functions.

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setInnerNode):
(WebCore::HitTestResult::setInnerNonSharedNode):

8:32 AM Changeset in webkit [154231] by Darin Adler
  • 4 edits in trunk/Source/WebCore

<​https://webkit.org/b/119948> Change drag-specific clipboard writing in DragController to go straight to Pasteboard, not forward through Clipboard

Reviewed by Andreas Kling.

  • dom/Clipboard.cpp: Removed writeRange, writePlainText, and writeURL functions.

All three are just unneeded forwarding to pasteboard.

  • dom/Clipboard.h: Ditto.
  • page/DragController.cpp:

(WebCore::DragController::startDrag): Move the logic in here. Later we might
want to straighten this out a bit, perhaps using functions in Editor, but it's
not much code so fine to just have it here for now.

8:21 AM Changeset in webkit [154230] by Darin Adler
  • 3 edits in trunk/Source/WebCore

<​https://webkit.org/b/119947> Remove LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS

Reviewed by Andreas Kling.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard):
(WebCore::Clipboard::~Clipboard):

  • dom/Clipboard.h:

Remove LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS, LEGACY_VIRTUAL, and LEGACY_PURE.
Keep only the !USE(LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS) side of all conditionals.

7:56 AM Changeset in webkit [154229] by Darin Adler
  • 4 edits in trunk/Source/WebCore

<​https://webkit.org/b/119946> Move some code used only by EventHandler from Clipboard to EventHandler

Reviewed by Andreas Kling.

Later it would be good to move this all to DragController, but there is no reason to have
these functions as member functions of the DOM-exposed Clipboard class.

  • dom/Clipboard.cpp: Deleted hasFileOfType, hasStringOfType, convertDropZoneOperationToDragOperation,

convertDragOperationToDropZoneOperation.

  • dom/Clipboard.h: Ditto.
  • page/EventHandler.cpp:

(WebCore::convertDropZoneOperationToDragOperation): Moved here.
(WebCore::convertDragOperationToDropZoneOperation): Moved here. Also changed to use ASCIILiteral.
(WebCore::hasFileOfType): Moved here and made a free function instead of a member function. Removed
canReadTypes check because Clipboard::files already takes care of that.
(WebCore::hasStringOfType): Moved here and made a free function instead of a member function.
Added a check for the null string because HashSet::contains will not work on a null string.
(WebCore::hasDropZoneType): Moved here and made a free function instead of a member function.
(WebCore::findDropZone): Call the hasDropZoneType function instead of Clipboard::hasDropZoneType.

7:48 AM Changeset in webkit [154228] by Darin Adler
  • 6 edits in trunk/Source/WebCore

<​https://webkit.org/b/119943> Clean up the Document class a bit

Reviewed by Antti Koivisto.

  • dom/Document.cpp:

(WebCore::Document::~Document): Fixed typo in comment.
(WebCore::Document::suggestedMIMEType): Use ASCIILiteral for literals.
Also name local variable just loader rather than documentLoader.
(WebCore::Document::updateTitle): Call loader rather than going indirectly
through frame to get to the loader.
(WebCore::Document::setTitleElement): Fixed formatting (add braces).
(WebCore::Document::removeTitle): Iterate elements instead of nodes.
(WebCore::Document::isPageBoxVisible): Use ensureStyleResolver to call
styleForPage to avoid the need for a simple forwarding function. Also
eliminated local variable to increase clarity.
(WebCore::Document::pageSizeAndMarginsInPixels): Use ensureStyleResolver
to call styleForPage to avoid the need for a simple forwarding function.
(WebCore::Document::setIsViewSource): Renamed a local variable.

  • dom/Document.h: Removed unneeded childNeedsAndNotInStyleRecalc and

styleForPage functions.

  • loader/FrameLoader.cpp: Removed unnneeded setTitle function.
  • loader/FrameLoader.h: Ditto.
  • page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty): Use ensureStyleResolver to call
styleForPage to avoid the need for a simple forwarding function.

7:41 AM Changeset in webkit [154227] by Darin Adler
  • 12 edits
    3 deletes in trunk/Source/WebCore

<​https://webkit.org/b/119939> Remove some unused clipboard and pasteboard code

Reviewed by Andreas Kling.

  • PlatformWinCE.cmake: Removed EditorWin.cpp.
  • WebCore.vcxproj/WebCore.vcxproj: Removed EditorWin.cpp.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Removed EditorWin.cpp.
  • WebCore.xcodeproj/project.pbxproj: Removed ClipboardIOS.h and

ClipboardIOS.mm, and also let Xcode edit/reorder this file.

  • editing/Editor.cpp:

(WebCore::Editor::dispatchCPPEvent): Removed some LEGACY_STYLE_ABSTRACT_CLIPBOARD
class code. Will remove the rest later.

  • editing/Editor.h: Removed declaration of newGeneralClipboard.
  • platform/Pasteboard.h: Removed declaration of writeClipboard. Also updated a

comment to make it clearer.

  • platform/blackberry/PasteboardBlackBerry.cpp: Removed Pasteboard::writeClipboard.
  • platform/efl/PasteboardEfl.cpp: Ditto.
  • platform/ios/PasteboardIOS.mm: Ditto.
  • platform/win/PasteboardWin.cpp: Ditto.
  • platform/ios/ClipboardIOS.h: Removed. Was an empty file.
  • platform/ios/ClipboardIOS.mm: Removed. Was an empty file.
  • platform/win/EditorWin.cpp: Removed. Had only newGeneralClipboard in the file,

a function that is never called.

7:39 AM Changeset in webkit [154226] by Darin Adler
  • 7 edits in trunk/Source/WebCore

<​https://webkit.org/b/119940> Rename Clipboard::m_dragLoc to m_dragLocation

Reviewed by Andreas Kling.

  • dom/Clipboard.h: Removed unused dragLocation member function.

Renamed m_dragLoc to m_dragLocation.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::setDragImage):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::Clipboard::createDragImage):

  • platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::createDragImage):

  • platform/qt/ClipboardQt.cpp:

(WebCore::Clipboard::createDragImage):

  • platform/win/ClipboardWin.cpp:

(WebCore::Clipboard::createDragImage):
Updated for new name.

7:37 AM Changeset in webkit [154225] by Darin Adler
  • 7 edits in trunk/Source/WebCore

<​https://webkit.org/b/119942> Remove unnecessary uses of Element::ownerDocument

Reviewed by Andreas Kling.

The Element::document is a simpler faster alternative to Element::ownerDocument.
The only behavior difference between the two is that ownerDocument returns 0 when
called on a Document.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::supportsFocus): Call document instead of ownerDocument.
(WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Removed null checking of
document and call to ownerDocument, since ownerDocument will never return non-null
if document returns null.
(WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): Call document instead
of ownerDocument.

  • inspector/DOMEditor.cpp:

(WebCore::DOMEditor::SetOuterHTMLAction::perform): Call document instead of ownerDocument.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode): Call document instead of ownerDocument.
(WebCore::InspectorCSSAgent::forcePseudoState): Call document instead of ownerDocument.
(WebCore::InspectorCSSAgent::resetPseudoStates): Call document instead of ownerDocument.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML): Call document instead of expression that
does the same thing in a roundabout way.
(WebCore::InspectorDOMAgent::focusNode): Call document instead of ownerDocument.
(WebCore::InspectorDOMAgent::resolveNode): Call document instead of expression that
does the same thing in a roundabout way.

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag): Call document instead of ownerDocument.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::ownerDocument): Call document instead of ownerDocument.

7:27 AM Changeset in webkit [154224] by Darin Adler
  • 19 edits in trunk/Source

<​https://webkit.org/b/119941> Make Page::dragController return a reference

Reviewed by Andreas Kling.

Source/WebCore:

  • page/Page.h:

(WebCore::Page::dragController): Return a reference instead of a pointer.

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateDragSourceActionsAllowed):
(WebCore::EventHandler::handleDrag):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passSubframeEventToSubframe):
Updated call sites.

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(dragExitedCallback):
(webkit_web_view_drag_motion):
(webkit_web_view_drag_data_received):
(webkit_web_view_drag_drop):
Updated call sites.

Source/WebKit/mac:

  • WebView/WebFrameView.mm:

(-[WebFrameView _setDocumentView:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView draggingSourceOperationMaskForLocal:]):
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

  • WebView/WebView.mm:

(-[WebView _setInitiatedDrag:]):
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):
(-[WebView moveDragCaretToPoint:]):
(-[WebView removeDragCaret]):
Updated call sites.

Source/WebKit/qt:

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::dragEntered):
(QWebPageAdapter::dragLeaveEvent):
(QWebPageAdapter::dragUpdated):
(QWebPageAdapter::performDrag):
Updated call sites.

Source/WebKit/win:

  • WebCoreSupport/WebDragClient.cpp:

(WebDragClient::startDrag):

  • WebView.cpp:

(WebView::keyStateToDragOperation):
(WebView::DragEnter):
(WebView::DragOver):
(WebView::DragLeave):
(WebView::Drop):
Updated call sites.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::dragEnded):
Updated call sites.

5:38 AM Changeset in webkit [154223] by ddkilzer@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

ANGLE fails to build with trunk clang: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
<​http://webkit.org/b/119931>
<rdar://problem/14763822>

Reviewed by Darin Adler.

  • src/compiler/glslang.l:
  • src/compiler/glslang_lex.cpp:
  • src/compiler/preprocessor/Tokenizer.cpp:
  • src/compiler/preprocessor/Tokenizer.l:

Add pragma statements to ignore -Wdeprecated-register warnings
in generated code. Also ignore -Wunknown-pragmas so this
doesn't cause a build failure in older versions of clang.

5:37 AM Changeset in webkit [154222] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 fails to build with trunk clang: error: 'WebPluginSiteDataManagerh' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
<​http://webkit.org/b/119935>
<rdar://problem/14764131>

Reviewed by Darin Adler.

  • UIProcess/Plugins/WebPluginSiteDataManager.h: Fix typo

introduced in r78647.

5:31 AM Changeset in webkit [154221] by commit-queue@webkit.org
  • 7 edits
    22 adds in trunk

<​https://webkit.org/b/119795> Propagate writing-mode from the first region to the flow thread

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-08-17
Reviewed by Darin Adler.

Source/WebCore:

Since the flow thread is a direct child of RenderView, it doesn't inherit
proper writing-mode automatically. It should be mentioned that if the thread's
contents' writing-mode differs from that of the first region, things are
typically going to look useless (although perhaps that's how it should be),
but as long as writing-mode is only specified on a common parent of the
thread's contents and the regions, things look fine, and also, we're now
following what the spec has to say on the matter:

​http://www.w3.org/TR/2013/WD-css3-regions-20130528/#the-flow-into-property

"The first region defines the principal writing mode for the entire flow.

The writing mode on subsequent regions is ignored."

This is a back-port of the fix for Blink bug 257965.
Reviewed by esprehn and mihnea there.
Blink review URL: ​https://chromiumcodereview.appspot.com/18374008

Tests: fast/regions/changing-writing-mode-2.html

fast/regions/changing-writing-mode-3.html
fast/regions/changing-writing-mode-4.html
fast/regions/changing-writing-mode-5.html
fast/regions/changing-writing-mode.html
fast/regions/invalid-first-region-with-writing-mode-2.html
fast/regions/invalid-first-region-with-writing-mode.html
fast/regions/subtree-with-horiz-bt.html
fast/regions/subtree-with-horiz-tb.html
fast/regions/subtree-with-vert-lr.html
fast/regions/subtree-with-vert-rl.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::styleDidChange):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::updateWritingMode):
(WebCore::RenderNamedFlowThread::addRegionToNamedFlowThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::regionChangedWritingMode):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::styleDidChange):

LayoutTests:

  • fast/regions/changing-writing-mode-2-expected.html: Added.
  • fast/regions/changing-writing-mode-2.html: Added.
  • fast/regions/changing-writing-mode-3-expected.html: Added.
  • fast/regions/changing-writing-mode-3.html: Added.
  • fast/regions/changing-writing-mode-4-expected.html: Added.
  • fast/regions/changing-writing-mode-4.html: Added.
  • fast/regions/changing-writing-mode-5-expected.html: Added.
  • fast/regions/changing-writing-mode-5.html: Added.
  • fast/regions/changing-writing-mode-expected.html: Added.
  • fast/regions/changing-writing-mode.html: Added.
  • fast/regions/invalid-first-region-with-writing-mode-2-expected.html: Added.
  • fast/regions/invalid-first-region-with-writing-mode-2.html: Added.
  • fast/regions/invalid-first-region-with-writing-mode-expected.html: Added.
  • fast/regions/invalid-first-region-with-writing-mode.html: Added.
  • fast/regions/subtree-with-horiz-bt-expected.html: Added.
  • fast/regions/subtree-with-horiz-bt.html: Added.
  • fast/regions/subtree-with-horiz-tb-expected.html: Added.
  • fast/regions/subtree-with-horiz-tb.html: Added.
  • fast/regions/subtree-with-vert-lr-expected.html: Added.
  • fast/regions/subtree-with-vert-lr.html: Added.
  • fast/regions/subtree-with-vert-rl-expected.html: Added.
  • fast/regions/subtree-with-vert-rl.html: Added.
5:11 AM Changeset in webkit [154220] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpecations: Unskip fast/dom/gc-10.html, the test seems to work now.
3:58 AM Changeset in webkit [154219] by akling@apple.com
  • 65 edits in trunk/Source

<​https://webkit.org/b/119903> Make Settings ref-counted (and let Frame keep a ref!)

Reviewed by Geoff Garen.

Let Frame hold a RefPtr<Settings> so Frame::settings() isn't forced to go through Page.
It now also returns a reference, as it can never be null.

Removed 8.8 million lines of null-checking as a result.

Aug 16, 2013:

10:50 PM Changeset in webkit [154218] by fpizlo@apple.com
  • 9 edits
    6 adds in trunk

DFG should optimize typedArray.byteLength
​https://bugs.webkit.org/show_bug.cgi?id=119909

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds typedArray.byteLength inlining to the DFG, and does so without changing
the IR: byteLength is turned into GetArrayLength followed by BitLShift. This is
legal since the byteLength of a typed array cannot exceed
numeric_limits<int32_t>::max().

  • bytecode/SpeculatedType.cpp:

(JSC::typedArrayTypeFromSpeculation):

  • bytecode/SpeculatedType.h:
  • dfg/DFGArrayMode.cpp:

(JSC::DFG::toArrayType):

  • dfg/DFGArrayMode.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):
(JSC::DFG::FixupPhase::attemptToMakeGetByteLength):
(JSC::DFG::FixupPhase::convertToGetArrayLength):
(JSC::DFG::FixupPhase::prependGetArrayLength):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::constantRegisterForConstant):
(JSC::DFG::Graph::convertToConstant):

  • runtime/TypedArrayType.h:

(JSC::logElementSize):
(JSC::elementSize):

LayoutTests:

Reviewed by Oliver Hunt.

Convert two of the tyepd array tests to use byteLength instead of length.
These tests show speed-ups around 2.5x-5x.

  • fast/js/regress/Int16Array-bubble-sort-with-byteLength-expected.txt: Added.
  • fast/js/regress/Int16Array-bubble-sort-with-byteLength.html: Added.
  • fast/js/regress/Int8Array-load-with-byteLength-expected.txt: Added.
  • fast/js/regress/Int8Array-load-with-byteLength.html: Added.
  • fast/js/regress/script-tests/Int16Array-bubble-sort-with-byteLength.js: Added.

(bubbleSort):
(myRandom):
(validateSort):

  • fast/js/regress/script-tests/Int8Array-load-with-byteLength.js: Added.

(adler32):

10:36 PM Changeset in webkit [154217] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG optimizes out strict mode arguments tear off
​https://bugs.webkit.org/show_bug.cgi?id=119504

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg and Oliver Hunt.

Don't do the optimization for strict mode.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::pruneObviousArgumentCreations):

LayoutTests:

Reviewed by Mark Hahnenberg and Oliver Hunt.

  • fast/js/dfg-arguments-strict-mode-expected.txt: Added.
  • fast/js/dfg-arguments-strict-mode.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arguments-strict-mode.js: Added.

(f):

7:50 PM Changeset in webkit [154216] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Unreviewed build fix after r154192

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):

6:47 PM Changeset in webkit [154215] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

6:44 PM Changeset in webkit [154214] by Lucas Forschler
  • 1 copy in tags/Safari-537.59

New Tag.

6:33 PM Changeset in webkit [154213] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

6:31 PM Changeset in webkit [154212] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

<​https://webkit.org/b/119536> Refactor highestEditableRoot to avoid a redundant call to rendererIsEditable

Reviewed by Benjamin Poulain.

Refactor highestEditableRoot to avoid an extra tree walk. We now walk up the ancestor chain up to
the first root editable element exactly once.

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditable): Change the order of conditions to make the evaluation faster
when we don't have to check RenderStyle's value.

  • editing/htmlediting.cpp:

(WebCore::highestEditableRoot):

6:31 PM Changeset in webkit [154211] by Lucas Forschler
  • 1 delete in tags/Safari-537.59

Remove Tag.

6:21 PM Changeset in webkit [154210] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

6:20 PM Changeset in webkit [154209] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove a useless #include of SelectorChecker.h

Rubber-stamped by Ryosuke Niwa.

  • dom/DocumentStyleSheetCollection.cpp:
6:19 PM Changeset in webkit [154208] by Lucas Forschler
  • 1 copy in tags/Safari-537.59

New Tag.

4:34 PM Changeset in webkit [154207] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] x86: improve code generation for xxxTest32
​https://bugs.webkit.org/show_bug.cgi?id=119876

Reviewed by Geoffrey Garen.

Try to use testb whenever possible when testing for an immediate value.

When the input is an address and an offset, we can tweak the mask
and offset to be able to generate testb for any byte of the mask.

When the input is a register, we can use testb if we are only interested
in testing the low bits.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::generateTest32):

2:56 PM Changeset in webkit [154206] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

<​https://webkit.org/b/119915> REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()

Add failing test expectations.

  • platform/mac-wk2/TestExpectations:
2:45 PM Changeset in webkit [154205] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Update RenderMediaControls for new API
​https://bugs.webkit.org/show_bug.cgi?id=119910

Reviewed by Eric Carlson.

  • rendering/RenderMediaControls.cpp: Update calls to WebKitSystemInterface for

the changed API.

2:40 PM Changeset in webkit [154204] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<​https://bugs.webkit.org/show_bug.cgi?id=119913> Baseline JIT gives erroneous
error message that an object is not a constructor though it expects a function

Reviewed by Michael Saboff.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

2:29 PM Changeset in webkit [154203] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

<​https://webkit.org/b/119912> Fix WebKit build error when SVG is disabled(broken since r154174)

Patch by Arunprasad Rajkumar <​arurajku@cisco.com> on 2013-08-16
Reviewed by Simon Fraser.

No new tests required, just a build fix.

Since r154174 CSS keywords alpha and luminance used by -webkit-mask-source-type. Move those
keywords from SVGCSSValueKeywords.in to CSSValueKeywords.in.

  • css/CSSValueKeywords.in:
  • css/SVGCSSValueKeywords.in:
1:04 PM Changeset in webkit [154202] by dfarler@apple.com
  • 2 edits in trunk/Websites/bugs.webkit.org

PrettyPatch: Wrap pre blocks
​https://bugs.webkit.org/show_bug.cgi?id=119906

Reviewed by Darin Adler.

  • PrettyPatch/PrettyPatch.rb:

<pre> will use the same wrap settings as the text class:
white-space: pre-wrap and word-wrap: break-word.

12:33 PM Changeset in webkit [154201] by commit-queue@webkit.org
  • 21 edits in trunk/Source

<​https://webkit.org/b/119785> Replace currentTime() with monotonicallyIncreasingTime() in WebCore

Patch by Arunprasad Rajkumar <​arurajku@cisco.com> on 2013-08-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

WTF::currentTime() is prone to DST changes and NTP adjustments, so use
WTF::monotonicallyIncreasingTime() to measure elapsed time.

  • Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::didWrite):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::elapsedTime):
(WebCore::Document::resetLastHandledUserGestureTimestamp):

  • dom/Element.cpp:

(WebCore::Element::setActive):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::didReceiveData):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::refreshCachedTime):
(WebCore::HTMLMediaElement::invalidateCachedTime):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
(WebCore::HTMLMediaElement::scheduleTimeupdateEvent):

  • html/HTMLMediaElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::documentHadRecentUserGesture):

  • html/MediaController.cpp:

(MediaController::scheduleTimeupdateEvent):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpPendingSpeculations):

  • html/parser/HTMLParserScheduler.h:

(WebCore::HTMLParserScheduler::checkForYieldBeforeToken):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::SelectorProfile):
(WebCore::SelectorProfile::totalMatchingTimeMs):
(WebCore::SelectorProfile::startSelector):
(WebCore::SelectorProfile::commitSelector):
(WebCore::SelectorProfile::commitSelectorTime):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::willProcessTask):
(WebCore::InspectorProfilerAgent::didProcessTask):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::timestamp):

  • inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):

  • page/FrameView.cpp:

(WebCore::FrameView::adjustedDeferredRepaintDelay):
(WebCore::FrameView::paintContents):

  • platform/ClockGeneric.cpp:

(ClockGeneric::now):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::flushContextIfNecessary):
(WebCore::ImageBuffer::flushContext):
(WebCore::ImageBuffer::copyNativeImage):

Source/WTF:

WTF::currentTime() is prone to DST changes and NTP adjustments, so use
WTF::monotonicallyIncreasingTime() to measure elapsed time.

  • wtf/CurrentTime.h:

(WTF::monotonicallyIncreasingTimeMS): Added mille second version of monotonic time API.

12:20 PM Changeset in webkit [154200] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

<​https://webkit.org/b/119891> [WinCairo] Compile error.

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-08-16
Reviewed by Brent Fulgham.

  • rendering/FlowThreadController.cpp: Need USE(ACCELERATED_COMPOSITING) guard.
  • rendering/FlowThreadController.h: Need USE(ACCELERATED_COMPOSITING) guard.
12:15 PM Changeset in webkit [154199] by fpizlo@apple.com
  • 10 edits
    3 adds in trunk

Object properties added using dot syntax (o.f = ...) from code that isn't in eval should be less likely to cause an object to become a dictionary
​https://bugs.webkit.org/show_bug.cgi?id=119897

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

6-10x speed-up on microbenchmarks that create large static objects. 40-65% speed-up
on Octane/gbemu. 3% overall speed-up on Octane. No slow-downs anywhere; our ability
to turn objects into dictionaries when you're storing using bracket syntax or using
eval is still in place.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::putByIdContext):

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):

  • runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::PutPropertySlot):
(JSC::PutPropertySlot::context):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

  • runtime/Structure.h:

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/regress/lots-of-fields-expected.txt: Added.
  • fast/js/regress/lots-of-fields.html: Added.
  • fast/js/regress/script-tests/lots-of-fields.js: Added.

(foo):

12:08 PM Changeset in webkit [154198] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] DRT is not using the same preferences as the Mac build.
​https://bugs.webkit.org/show_bug.cgi?id=119822

Reviewed by Darin Adler.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(runTest): Process Windows message queue using CFRunLoop to allow
dispatch routines to run properly.
(dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
to prevent problems on WinCairo port.

11:53 AM Changeset in webkit [154197] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebCore

<​https://webkit.org/b/119887> [Soup] The testing NetworkStorageSession should have a proper SoupSession

Reviewed by Martin Robinson.

After r154144, a testing NetworkStorageSession is enforced when running the layout tests
through WebKitTestRunner. Ports using the Soup networking backend don't assign any SoupSession
objects to such NetworkStorageSession objects as it's usually the case. This is causing problems
as the ResourceHandleInternal uses the SoupSession that's provided by the NetworkingContext's
NetworkStorageSession, which ends up being null if the testing-specific NetworkStorageSession is used.
As a result, all the layout tests are crashing under WKTR.

  • platform/network/NetworkStorageSession.h: Make the SoupSession member a GRefPtr.

(WebCore::NetworkStorageSession::soupSession): Return the GRefPtr's pointer.

  • platform/network/ResourceHandle.h: Declare the new createTestingSession method.
  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForSession): Instead of returning the default SoupCookieJar when there's no SoupSession
provided by the NetworkStorageSession, assert that there now always is one, and return the session's cookie
jar. For testing NetworkStorageSession objects, their SoupSession objects will always use the default cookie jar.

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession): Adopt the given SoupSession reference pointer.
(WebCore::NetworkStorageSession::switchToNewTestingSession): Use a newly-created, testing-specific SoupSession.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::createTestingSession): Define the new createTestingSession method. It creates a new
SoupSession through createSoupSession, but uses the default SoupCookieJar, as provided by WebCore::soupCookieJar.

11:43 AM Changeset in webkit [154196] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

<​https://webkit.org/b/118105> Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs

Patch by James Craig <​james@cookiecrook.com> on 2013-08-16
Reviewed by Joseph Pecoraro.

Updating accessibility roles and attributes for single-select toolbar item sets.

  • UserInterface/ActivateButtonNavigationItem.js:

(WebInspector.ActivateButtonNavigationItem):
(WebInspector.ActivateButtonNavigationItem.prototype.set activated):

  • UserInterface/ActivateButtonToolbarItem.js:

(WebInspector.ActivateButtonToolbarItem):

  • UserInterface/ButtonToolbarItem.js:

(WebInspector.ButtonToolbarItem):

  • UserInterface/SidebarPanel.js:

(WebInspector.SidebarPanel):

  • UserInterface/Toolbar.js:

(WebInspector.Toolbar):

11:42 AM Changeset in webkit [154195] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening. Rebaseline after r154124.

  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
11:06 AM Changeset in webkit [154194] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] URL printing code in DRT doesn't match WTR or Mac DRT
​https://bugs.webkit.org/show_bug.cgi?id=119583

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
component if the URL does not contain the expected base URL.

11:02 AM Changeset in webkit [154193] by Brent Fulgham
  • 3 edits in trunk/LayoutTests

[Windows] Unreviewed gardening. Correct Windows test expectations after JSC changes.

  • platform/win/fast/js/dom-static-property-for-in-iteration-expected.txt:
  • platform/win/fast/js/global-constructors-attributes-shared-worker-expected.txt:
10:55 AM Changeset in webkit [154192] by psolanki@apple.com
  • 78 edits in trunk

<​https://webkit.org/b/119852> Frame::scriptController() should return a reference

Reviewed by Andreas Kling.

m_script is never NULL so we can just return a reference. Also remove some pointless null
checks as a result of doing this.

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::toJS):
(WebCore::toJSDOMWindow):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::toJS):
(WebCore::toJSDOMWindowShell):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener):
(WebCore::eventListenerHandlerScriptState):

  • bindings/js/ScriptState.cpp:

(WebCore::mainWorldScriptState):
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):

  • bindings/objc/DOM.mm:

(-[DOMNode JSC::Bindings::]):

  • bindings/objc/DOMInternal.mm:

(-[WebScriptObject _initializeScriptDOMNodeImp]):

  • dom/Document.cpp:

(WebCore::Document::disableEval):
(WebCore::Document::ensurePlugInsInjectedScript):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::executeScript):

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createRenderer):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::rendererIsNeeded):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::controls):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::getInstance):
(WebCore::HTMLPlugInElement::getNPObject):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):

  • html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didClearWindowObjectInWorld):

  • inspector/InspectorClient.cpp:

(WebCore::InspectorClient::doDispatchMessageOnFrontendPage):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::evaluateInOverlay):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getScriptExecutionStatus):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::reportExecutionContextCreation):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::cancelAndClear):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::prepareForCachedPageRestore):
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestFrame):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

  • page/Frame.h:

(WebCore::Frame::script):

  • page/Navigator.cpp:

(WebCore::shouldHideFourDot):

  • page/Page.cpp:

(WebCore::Page::setDebugger):

  • platform/graphics/wince/MediaPlayerProxy.cpp:

(WebCore::WebMediaPlayerProxy::pluginInstance):
(WebCore::WebMediaPlayerProxy::invokeMethod):

  • plugins/PluginView.cpp:

(WebCore::PluginView::~PluginView):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::load):
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::getValue):

  • plugins/efl/PluginViewEfl.cpp:

(WebCore::PluginView::platformGetValue):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
(BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
(BlackBerry::WebKit::WebPage::globalContext):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportEfl::globalContextRefForFrame):

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):

  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):

  • ewk/ewk_view.cpp:

(ewk_view_js_object_add):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_get_global_context):

  • webkit/webkitwebview.cpp:

(webkit_web_view_execute_script):

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::cleanup):
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::getProperty):
(WebKit::NetscapePluginInstanceProxy::setProperty):
(WebKit::NetscapePluginInstanceProxy::removeProperty):
(WebKit::NetscapePluginInstanceProxy::hasProperty):
(WebKit::NetscapePluginInstanceProxy::hasMethod):
(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getVariable:value:]):
(-[WebNetscapePluginView _destroyPlugin]):

  • Plugins/WebPluginController.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):

  • WebView/WebFrame.mm:

(-[WebFrame _attachScriptDebugger]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
(-[WebFrame _globalContextForScriptWorld:]):
(-[WebFrame jsWrapperForNode:inScriptWorld:]):
(-[WebFrame windowObject]):
(-[WebFrame globalContext]):
(-[WebFrame javaScriptContext]):

  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::initGlobalCallFrame):
(WebScriptDebugger::callEvent):

  • WebView/WebView.mm:

(-[WebView windowScriptObject]):
(-[WebView aeDescByEvaluatingJavaScriptFromString:]):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(setupScriptContext):
(QWebElement::evaluateJavaScript):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):

  • WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::evaluateJavaScript):
(QWebFrameAdapter::addToJavaScriptWindowObject):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::globalContext):
(WebFrame::globalContextForScriptWorld):
(WebFrame::dispatchDidClearWindowObjectInWorld):
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::globalObject):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performJavaScriptURLRequest):
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::jsContext):
(WebKit::WebFrame::jsContextForWorld):
(WebKit::WebFrame::jsWrapperForWorld):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::didSave):
(WebKit::WebInspector::didAppend):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

Tools:

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

10:52 AM Changeset in webkit [154191] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537-branch

Merged r154147. <rdar://problem/14307781>

10:48 AM Changeset in webkit [154190] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit/mac

Merged r154114. <rdar://problem/14698870>

10:47 AM Changeset in webkit [154189] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

[Mac] [WK2] Some inspector tests intermittently asserts in InspectorOverlay::paint
​https://bugs.webkit.org/show_bug.cgi?id=105988

Unreviewed gardening. Mark tests as flakey (crashing) in WK1 expectations as well as WK2.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
9:21 AM Changeset in webkit [154188] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Qt/MountainLion build after r154142.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::commitLoad):

9:13 AM Changeset in webkit [154187] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/win

Windows build juice.

  • WebView.cpp:

(WebView::paintIntoBackingStore):

9:03 AM Changeset in webkit [154186] by allan.jensen@digia.com
  • 3 edits in trunk

[Qt] Kerning in fast font path breaks letter-spacing
​https://bugs.webkit.org/show_bug.cgi?id=119838

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Mark fonts with both kerning and letter-spacing as unsupported by the simple font-path.

Test: fast/text/letter-spacing-kerned.html

  • platform/graphics/WidthIterator.h:

(WebCore::WidthIterator::supportsTypesettingFeatures):

LayoutTests:

Test that kerning does not break letter spacing.

  • fast/text/letter-spacing-kerned-expected.html: Added.
  • fast/text/letter-spacing-kerned.html: Added.
8:52 AM Changeset in webkit [154185] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] Unreviewed gardening. Turn on a now-passing test.

  • platform/win/TestExpectations: Reactivate fast/text/split-text-crash.xhtml
8:47 AM Changeset in webkit [154184] by akling@apple.com
  • 42 edits in trunk/Source

<​https://webkit.org/b/119893> FrameView::frame() should return a reference.

Reviewed by Antti Koivisto.

FrameView::m_frame was only ever null for a brief moment during CachedFrame teardown.
Leave it alone instead, and update the assertion that depended on this behavior.
This enables us to make FrameView::frame() return a Frame&, exposing a ton of
unnecessary null checks.

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::destroy):

Remove call to FrameView::clearFrame() that was the only way to get a null
FrameView::m_frame. Immediately followed by a call to CachedFrame::clear() where
the FrameView would get destroyed anyway.

(WebCore::CachedFrame::clear):

Update an assertion to support the case where the Document's Frame pointer has
been cleared out and CachedFrame is still clinging to the FrameView.

  • history/CachedPage.h:

Made CachedPage::destroy() private as it was only called by ~CachedPage().

  • /:

Frame* FrameView::frame() => Frame& FrameView::frame()

8:44 AM Changeset in webkit [154183] by beidson@apple.com
  • 16 edits
    1 copy
    1 move
    3 adds
    3 deletes in trunk/Source

(NetworkProcess) Sync XHRs should load using async ResourceHandles, not ResourceHandle::loadResourceSynchronously
​https://bugs.webkit.org/show_bug.cgi?id=119493

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests (Covered by plenty of existing tests).

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/SynchronousLoaderClient.h: Make platformBadResponseError public
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::platformLoadResourceSynchronously): Add comments/FIXMEs spelling out how wrong this code is.

Source/WebKit2:

This patch does the following:

  • Consolidates SchedulableLoader and NetworkResourceLoader into one class.
  • Removes SyncNetworkResourceLoader.
  • Adds a NetworkLoaderClient interface that customizes certain behaviors of the NetworkResourceLoader.
  • Implements a SynchronousNetworkLoaderClient and AsynchronousNetworkLoaderClient for the two different types of loads.

The AsynchronousNetworkLoaderClient results in messaging back progress to the WebProcess as the load progresses.
The SynchronousNetworkLoaderClient accumulates the response, data, and error to be communicated back to the WebProcess
only when the load is complete.

Update small swaths of code to reflect that NetworkResourceLoader is the One True Loader (tm):

  • NetworkProcess/HostRecord.cpp:

(WebKit::HostRecord::scheduleResourceLoader):
(WebKit::HostRecord::addLoaderInProgress):
(WebKit::removeLoaderFromQueue):
(WebKit::HostRecord::removeLoader):
(WebKit::HostRecord::servePendingRequestsForQueue):
(WebKit::HostRecord::limitsRequests):

  • NetworkProcess/HostRecord.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkProcess.cpp:
  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::scheduleLoader):
(WebKit::NetworkResourceLoadScheduler::removeLoader):
(WebKit::NetworkResourceLoadScheduler::receivedRedirect):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):
(WebKit::NetworkResourceLoadScheduler::scheduleRemoveLoader):

  • NetworkProcess/NetworkResourceLoadScheduler.h:

Combine ScheduleableLoader and NetworkResourceLoader into NetworkResourceLoader:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::isSynchronous):
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::NetworkResourceLoader::willSendRequestAsync):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::didSendData):
(WebKit::NetworkResourceLoader::shouldUseCredentialStorage):
(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge):
(WebKit::NetworkResourceLoader::consumeSandboxExtensions):
(WebKit::NetworkResourceLoader::invalidateSandboxExtensions):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::create):
(WebKit::NetworkResourceLoader::connectionToWebProcess):
(WebKit::NetworkResourceLoader::priority):
(WebKit::NetworkResourceLoader::request):
(WebKit::NetworkResourceLoader::isLoadingMainResource):
(WebKit::NetworkResourceLoader::setHostRecord):
(WebKit::NetworkResourceLoader::hostRecord):
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):

Add an abstract NetworkLoaderClient to adapt a load to be either synchronous or asynchronous:

  • NetworkProcess/NetworkLoaderClient.h:

(WebKit::NetworkLoaderClient::~NetworkLoaderClient):
(WebKit::NetworkLoaderClient::isSynchronous):
(WebKit::NetworkLoaderClient::NetworkLoaderClient):

The asynchronous loader client, primarily to message progress back to the WebProcess as it happens:

  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp: Added.

(WebKit::AsynchronousNetworkLoaderClient::AsynchronousNetworkLoaderClient):
(WebKit::AsynchronousNetworkLoaderClient::willSendRequest):
(WebKit::AsynchronousNetworkLoaderClient::canAuthenticateAgainstProtectionSpace):
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
(WebKit::AsynchronousNetworkLoaderClient::didSendData):
(WebKit::AsynchronousNetworkLoaderClient::didFinishLoading):
(WebKit::AsynchronousNetworkLoaderClient::didFail):

  • NetworkProcess/AsynchronousNetworkLoaderClient.h:

(WebKit::AsynchronousNetworkLoaderClient::create):

The synchronous loader client, primarily to accumulate results of the load to send back to the WebProcess all at once:

  • NetworkProcess/SynchronousNetworkLoaderClient.cpp: Added.

(WebKit::SynchronousNetworkLoaderClient::SynchronousNetworkLoaderClient):
(WebKit::SynchronousNetworkLoaderClient::~SynchronousNetworkLoaderClient):
(WebKit::SynchronousNetworkLoaderClient::willSendRequest):
(WebKit::SynchronousNetworkLoaderClient::canAuthenticateAgainstProtectionSpace):
(WebKit::SynchronousNetworkLoaderClient::didReceiveResponse):
(WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
(WebKit::SynchronousNetworkLoaderClient::didFinishLoading):
(WebKit::SynchronousNetworkLoaderClient::didFail):
(WebKit::SynchronousNetworkLoaderClient::sendDelayedReply):

  • NetworkProcess/SynchronousNetworkLoaderClient.h: Added.

(WebKit::SynchronousNetworkLoaderClient::create):

  • NetworkProcess/SchedulableLoader.cpp: Removed.
  • NetworkProcess/SchedulableLoader.h: Removed.
  • NetworkProcess/SyncNetworkResourceLoader.cpp: Removed.
  • NetworkProcess/SyncNetworkResourceLoader.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
8:42 AM Changeset in webkit [154182] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

<​https://webkit.org/b/119889> [WinCairo] Compile error.

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-08-16
Reviewed by Brent Fulgham.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::certificatePath): Use correct function name.

8:33 AM Changeset in webkit [154181] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build correction after r154165.

  • WebCore.vcxproj/copyForwardingHeaders.cmd: Copy html/shadow header files

to WebKit include location.

8:27 AM Changeset in webkit [154180] by Brent Fulgham
  • 4 edits in trunk

Source/WebCore: [Windows] Prevent dangling CACFLayer when switching to/from Tiled backing.
​https://bugs.webkit.org/show_bug.cgi?id=119818

Reviewed by Darin Adler.

Covered by existing: compositing/tiling/empty-to-tiled.html

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::~PlatformCALayer): Remove deleted layer from its
parent layer

LayoutTests: [Windows] Enable previously-failing compositing/tiling/empty-to-tiled.html
​https://bugs.webkit.org/show_bug.cgi?id=119818

Reviewed by Darin Adler.

  • platform/win/TestExpectations: Re-enable empty-to-tiled.html
7:52 AM Changeset in webkit [154179] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase js tests after r154127.

Patch by Tamas Czene <​tczene@inf.u-szeged.hu> on 2013-08-16

  • platform/qt/fast/js/constructor-length-expected.txt:
  • platform/qt/fast/js/global-constructors-attributes-expected.txt:
6:05 AM Changeset in webkit [154178] by akling@apple.com
  • 71 edits in trunk/Source

<​https://webkit.org/b/119866> Frame::eventHandler() should return a reference.

Reviewed by Anders Carlsson.

Frame::m_eventHandler is never null.

5:38 AM Changeset in webkit [154177] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] fast/forms/datalist/input-list.html is failing

Unreviewed EFL gardening. unskip LayoutTests/fast/forms/datalist/input-list.html test.

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-08-16

  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/datalist/input-list-expected.txt: Added.
5:10 AM Changeset in webkit [154176] by zandobersek@gmail.com
  • 4 edits in trunk/Source

Unreviewed, rolling out r153749.
​http://trac.webkit.org/changeset/153749
​https://bugs.webkit.org/show_bug.cgi?id=119892

The bison generation of the glslang* files has now been fixed. (Requested by zdobersek on #webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2013-08-16

Source/ThirdParty/ANGLE:

  • GNUmakefile.am: Preserve the libANGLE.la dependency on the ANGLE's GNUmakefile.am.

Source/WebCore:

  • GNUmakefile.am:
4:50 AM Changeset in webkit [154175] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] fixing localizedString method name
​https://bugs.webkit.org/show_bug.cgi?id=119884

The method name defined in LocalizedStringsGtk.cpp doesn't not match
the one used in LocalizedStrings.h

Patch by Danilo Cesar Lemes de Paula <​danilo.cesar@collabora.co.uk> on 2013-08-16
Reviewed by Gustavo Noronha Silva.

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::textTrackOffMenuItemText):

4:41 AM Changeset in webkit [154174] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk

[CSS Masking] Add -webkit-mask-source-type property, with auto, alpha and luminance values
​https://bugs.webkit.org/show_bug.cgi?id=119614

Source/WebCore:

Added the -webkit-mask-source-type property, which can have a value of auto, alpha or
luminance. The default value is auto. This patch contains only the parsing of the property,
not the actual implementation of the types of masks. The parsing of mask-source-type in the
-webkit-mask property will be handled in a separate patch.

Patch by Andrei Parvu <​parvu@adobe.com> on 2013-08-16
Reviewed by Dirk Schulze.

Test: fast/masking/parsing-mask-source-type.html

  • css/CSSComputedStyleDeclaration.cpp: Added case for CSSPropertyWebkitMaskType.

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp: Parsed the values for CSSPropertyWebkitMaskType.

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in: Added -webkit-mask-type property.
  • css/CSSToStyleMap.cpp: map the provided mask type to the FillLayer class.

(WebCore::CSSToStyleMap::mapFillMaskType):

  • css/CSSToStyleMap.h:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/style/FillLayer.cpp: Added the m_maskType property to the FillLayer class.

(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):

  • rendering/style/FillLayer.h: Added methods for working with m_maskType.

(WebCore::FillLayer::maskType):
(WebCore::FillLayer::isMaskTypeSet):
(WebCore::FillLayer::setMaskType):
(WebCore::FillLayer::clearMaskType):
(WebCore::FillLayer::initialMaskType):

  • rendering/style/RenderStyleConstants.h: Added the EMaskSourceType enum.

LayoutTests:

Added tests for the parsing of the -webkit-mask-source-type property

Patch by Andrei Parvu <​parvu@adobe.com> on 2013-08-16
Reviewed by Dirk Schulze.

  • fast/masking/parsing-mask-expected.txt:
  • fast/masking/parsing-mask-source-type-expected.txt: Added.
  • fast/masking/parsing-mask-source-type.html: Added.
  • fast/masking/parsing-mask.html:
4:02 AM Changeset in webkit [154173] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

<​https://webkit.org/b/119742> REGRESSION(FTL): Fix register usage in mips implementation of ctiVMHandleException

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-08-16
Reviewed by Allan Sandfeld Jensen.

ctiVMHandleException must jump/return using register ra (r31).

  • jit/JITStubsMIPS.h:
3:08 AM Changeset in webkit [154172] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebCore

<​https://webkit.org/b/119885> [CMake] Always build our generated versions of ANGLE's glslang.cpp and glslang_tab.cpp

Reviewed by Gyuyoung Kim.

Now that r154109 has landed, all Bison versions (at least from 2.3 up
to the latest 3.0) should be able to generate versions of glslang* that
build correctly.

Since the idea is to remove the prebuilt files from future imports of
ANGLE, always building our own versions is a good idea, and allows us
to get rid of some very ugly CMake checks.

  • CMakeLists.txt: Always build glslang.cpp and glslang_tab.cpp from

DERIVED_SOURCES_WEBCORE_DIR.

2:58 AM Changeset in webkit [154171] by simon.pena@samsung.com
  • 7 edits
    3 adds in trunk/LayoutTests

[GTK] Unreviewed gardening. Rebaseline after r154127 and add new baseline after r153647.

  • platform/gtk-wk1/TestExpectations:

x-frame-options-deny-meta-tag-in-body.html fails in Release and
Debug.

  • platform/gtk/TestExpectations: CSS Image filter is not enabled

in GTK bots. Also remove entry for deleted test.

  • platform/gtk/fast/forms/search/search-size-with-decorations-expected.png: Added.
  • platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt: Added.
  • platform/gtk/fast/js/constructor-length-expected.txt:

Rebaselined after r154127.

  • platform/gtk/fast/js/global-constructors-attributes-dedicated-worker-expected.txt:

ditto.

  • platform/gtk/fast/js/global-constructors-attributes-expected.txt:

ditto.

  • platform/gtk/fast/js/global-constructors-attributes-shared-worker-expected.txt:

ditto.

2:25 AM Changeset in webkit [154170] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

<​https://webkit.org/b/119879> Fix sh4 build after r154156.

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-08-16
Reviewed by Allan Sandfeld Jensen.

Fix typo in JITStubsSH4.h file.

  • jit/JITStubsSH4.h:
2:07 AM Changeset in webkit [154169] by allan.jensen@digia.com
  • 2 edits in trunk/LayoutTests

Reskip tests that times out.

Unreviewed gardening.

  • platform/qt/TestExpectations:
1:52 AM Changeset in webkit [154168] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

<​https://webkit.org/b/119880> [Qt] Build fix (broken since r154142).

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-08-16
Reviewed by Gyuyoung Kim.

Since r154142, Frame::loader() is a reference (and not a pointer anymore).

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseStartElement):

1:05 AM Changeset in webkit [154167] by rgabor@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][ARM] Unreviewed buildfix after 154127.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h: Add missing header.
12:17 AM Changeset in webkit [154166] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebGL] Vertex attribute binding validation method
​https://bugs.webkit.org/show_bug.cgi?id=119515

This patch refactors WebGLRenderingContext code by moving the vertex
attribute binding validation to a separate method. It is now
possible to use that validation in other parts of the code. The
code is more clear now.

Patch by Przemyslaw Szymanski <​p.szymanski3@samsung.com> on 2013-08-16
Reviewed by Christophe Dumez.

No new tests. Covered by existing tests. No behaviour changed.
LayoutTests/webgl/resources/webgl_test_files/conformance/rendering/gl-drawelements.html
LayoutTests/webgl/resources/webgl_test_files/conformance/rendering/draw-elements-out-of-bounds.html
LayoutTests/webgl/resources/webgl_test_files/conformance/rendering/draw-arrays-out-of-bounds.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateVertexAttributes):

  • html/canvas/WebGLVertexArrayObjectOES.h:

(WebCore::WebGLVertexArrayObjectOES::VertexAttribState::isBound):
(WebCore::WebGLVertexArrayObjectOES::VertexAttribState::validateBinding):

Note: See TracTimeline for information about the timeline view.