Context Navigation

← Previous Period
Next Period →

Timeline

Aug 18, 2013:

11:40 PM Changeset in webkit [154264] by Darin Adler

12 edits in trunk/Source

<https://webkit.org/b/119989> Make use of Node::ownerDocument a compile time error

Reviewed by Sam Weinig.

Source/WebCore:

dom/Element.h: Deleted the ownerDocument function. For compilers that don't support

deleted functions, it is instead overrides the base class function with one that is
private and not defined, which accomplishes almost the same thing: An error, either
at compile time or link time.

bindings/js/JSHTMLElementCustom.cpp:

(WebCore::JSHTMLElement::pushEventHandlerScope): Use document instead of ownerDocument.

dom/Document.cpp:

(WebCore::Document::~Document): Added a comment about this clearly-incorrect code.

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didPushShadowRoot): Use document instead of ownerDocument.
(WebCore::InspectorInstrumentation::willPopShadowRoot): Ditto.

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheetForInlineStyle::setStyleText): Ditto.

plugins/PluginView.cpp:

(WebCore::getFrame): Removed ineffective call to ownerDocument after document when it
returns 0. It will never return anything other than 0 in that case.

rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize): Use document instead of ownerDocument.
Did not remove the null check at this time, although I'm pretty sure it's bogus. We can
fix that when/if we change the return type of Element::document to a reference.

svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::requestImageResource): Use document instead of ownerDocument.

Source/WebKit2:

WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement): Use document instead of
ownerDocument.

WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::createAnnotationElement): Ditto.

11:37 PM Changeset in webkit [154263] by Seokju Kwon

5 edits in trunk/LayoutTests

Unreviewed gardening after r154135

fast/js/array-sort-modifying-tostring.html was removed.

platform/qt-mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

10:25 PM Changeset in webkit [154262] by Darin Adler

11 edits
4 deletes in trunk/Source/WebCore

<https://webkit.org/b/119993> Remove most remaining platform-specific code from Clipboard class

Reviewed by Sam Weinig.

GNUmakefile.list.am: Removed ClipboardGtk.cpp.
PlatformEfl.cmake: Removed ClipboardEfl.cpp.
PlatformGTK.cmake: Removed ClipboardGtk.cpp.
PlatformWinCE.cmake: Removed ClipboardWin.cpp.
Target.pri: Removed ClipboardQt.cpp.
WebCore.vcxproj/WebCore.vcxproj: Removed ClipboardWin.cpp and ClipboardWin.h.
WebCore.vcxproj/WebCore.vcxproj.filters: Removed ClipboardWin.cpp and ClipboardWin.h.

dom/Clipboard.cpp:

(WebCore::Clipboard::createDragImage): Added. Version that works for all platforms
other than Mac, identical to the old one used in GTK and Qt, and close to the one used
on Windows.

platform/mac/ClipboardMac.mm: Trimmed includes down, and added a FIXME about next steps.

platform/qt/DataTransferItemListQt.h: Removed "friend class ClipboardQt", which refers

to a now-nonexistent class.

platform/efl/ClipboardEfl.cpp: Removed.
platform/gtk/ClipboardGtk.cpp: Removed.
platform/qt/ClipboardQt.cpp: Removed.
platform/win/ClipboardWin.cpp: Removed.

9:46 PM Changeset in webkit [154261] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r154218): DFG::FixupPhase no longer turns GetById's child1 into CellUse
https://bugs.webkit.org/show_bug.cgi?id=119961

Reviewed by Mark Hahnenberg.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

9:18 PM Changeset in webkit [154260] by Darin Adler

6 edits in trunk/Source/WebCore

<https://webkit.org/b/119949> Factor Clipboard into drag and non-drag parts

Reviewed by Sam Weinig.

dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard): Move the ClipboardType argument to go after the pasteboard.
Initialize strings more efficiently. Put drag-specific data members inside an if statement.
Replace m_clipboardType with m_forDrag.
(WebCore::Clipboard::createForCopyAndPaste): Moved function up to be close to constructor.
Removed explicit clipboard type since constructor now defaults to copy and paste style.
(WebCore::Clipboard::setAccessPolicy): Tweaked comment.
(WebCore::Clipboard::getData): Put drag-specific code inside #if ENABLE(DRAG_SUPPORT).
(WebCore::Clipboard::setData): Ditto.
(WebCore::Clipboard::files): Ditto.
(WebCore::Clipboard::dropEffect): Added trivial non-drag versions of these functions to
be used when !ENABLE(DRAG_SUPPORT).
(WebCore::Clipboard::setDropEffect): Ditto.
(WebCore::Clipboard::effectAllowed): Ditto.
(WebCore::Clipboard::setEffectAllowed): Ditto.
(WebCore::Clipboard::createForDragAndDrop): Renamed Clipboard::create that takes DragData
to this, and kep the overload that does not as well. Made the DragData argument a const&.
(WebCore::Clipboard::canSetDragImage): Moved down here since it is drag-specific.
(WebCore::Clipboard::updateDragImage): Use m_shouldUpdateDragImage directly insted of
calling a dragStarted function.
(WebCore::dragOpFromIEOp): Moved this function down here to the drag-specific section.
(WebCore::IEOpFromDragOp): Ditto.
(WebCore::Clipboard::sourceOperation): Ditto.
(WebCore::Clipboard::destinationOperation): Ditto.
(WebCore::Clipboard::setSourceOperation): Ditto.
(WebCore::Clipboard::setDestinationOperation): Ditto.

dom/Clipboard.h: Removed unneeded include of "Node.h" and added and removed forward

class declarations as required. Removed non-helpful comment. Made ClipboardType a private
implementation detail. Moved functions that are not part of the DOM API down to a separate
section lower down in the class, and sorted the functions to match the order they appear
in the IDL file. Removed isForCopyAndPaste and isForDragAndDrop. Changed dropEffect and
effectAllowed to not be inlined. Moved the long comment before canSetDragImage into the
implementation since it's an implementation detail. Since this class is no longer polymorphic,
use only private, not protected. Make m_dragImageElement an Element, not a Node.

dom/Clipboard.idl: Removed flags to tell bindings how to deal with null strings, since

these string properties can never return null strings anyway.

page/DragController.cpp:

(WebCore::DragController::dragExited): Updated to call the new createForDragAndDrop function.
(WebCore::DragController::performDrag): Ditto.
(WebCore::DragController::tryDHTMLDrag): Ditto.

platform/mac/ClipboardMac.mm: Added now-needed include of Element.h since Clipboard.h no

longer includes it.

8:05 PM Changeset in webkit [154259] by ddkilzer@apple.com

4 edits in trunk/Source/WebCore

WebCore fails to build with trunk clang: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
<http://webkit.org/b/119932>
<rdar://problem/14764085>

Reviewed by Darin Adler.

Add pragma statements to ignore -Wdeprecated-register warnings
in generated code. Also ignore -Wunknown-pragmas so this
doesn't cause a build failure in older versions of clang.

css/makeprop.pl:

(WebCore::findProperty): Remove register hints from parameters.

css/makevalues.pl:

(WebCore::findValue): Ditto.

platform/ColorData.gperf:

(WebCore::findColor): Ditto.

4:56 PM Changeset in webkit [154258] by Seokju Kwon

2 edits in trunk/LayoutTests

Unreviewed gardening.

platform/efl/TestExpectations: fast/js/array-sort-modifying-tostring.html was removed after r154135.

4:26 PM Changeset in webkit [154257] by Antti Koivisto

26 edits in trunk/Source/WebCore

<https://webkit.org/b/119987> Make Element::attach standalone function

Reviewed by Andreas Kling.

This patch turns Element::attach() and the related functions into standalone functions.

dom/ContainerNode.cpp:

(WebCore::attachChild):
(WebCore::detachChild):

dom/ContainerNode.h:
dom/Document.cpp:

(WebCore::Document::attach):
(WebCore::Document::detach):

dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::lazyReattach):
(WebCore::Element::removeShadowRoot):

Shadow root should be detached by now. Remove the detach call.

(WebCore::Element::updateFocusAppearanceAfterAttachIfNeeded):
(WebCore::Element::updatePseudoElement):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
(WebCore::Element::clearHoverAndActiveStatusBeforeDetachingRenderer):

Factor some parts of former Element::attach/detach() into member functions.

dom/Element.h:
dom/ElementRareData.h:

(WebCore::ElementRareData::releasePseudoElement):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):

dom/NodeRenderingContext.h:
dom/ShadowRoot.cpp:
dom/ShadowRoot.h:
html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::parseAttribute):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::parseAttribute):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderFallbackContent):

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::parseMultipleAttribute):

html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::finishLine):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):

html/parser/HTMLConstructionSite.cpp:

(WebCore::executeTask):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::willAttachRenderers):
(WebCore::InsertionPoint::willDetachRenderers):

loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::attach):

style/StyleResolveTree.cpp:

(WebCore::Style::createRendererIfNeeded):

From Element::createRendererIfNeeded()

(WebCore::Style::attachShadowRoot):

From ShadowRoot::attach()

(WebCore::Style::childAttachedAllowedWhenAttachingChildren):
(WebCore::Style::attachChildren):

From Element::attachChildren()

(WebCore::Style::attachRenderTree):

From Element::attach()

(WebCore::Style::detachShadowRoot):

From ShadowRoot::detach()

(WebCore::Style::detachChildren):

From Element::detachChildren()

(WebCore::Style::detachRenderTree):

From Element::deatach()

(WebCore::Style::reattachRenderTree):

From Element::reattach()

(WebCore::Style::resolveLocal):

style/StyleResolveTree.h:

(WebCore::Style::AttachContext::AttachContext):

From Element::AttachContext

svg/SVGTests.cpp:

(WebCore::SVGTests::handleAttributeChange):

xml/XMLErrors.cpp:

(WebCore::XMLErrors::insertErrorMessageBlock):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

4:06 PM Changeset in webkit [154256] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Fix clean engineering builds after r154251.

WebKit2.xcodeproj/project.pbxproj: Removed references to the OfflineStorage XPC services

from the “Copy XPC services for engineering builds” build phase.

4:05 PM Changeset in webkit [154255] by Antti Koivisto

2 edits in trunk/Source/WebCore

Fix crashing plugin tests caused by a logic error in the previous patch.

Not reviewed.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willDetachRenderers):

1:01 PM Changeset in webkit [154254] by Antti Koivisto

52 edits in trunk/Source/WebCore

<https://webkit.org/b/119982> Make Element::attach non-virtual

Reviewed by Andreas Kling.

This will give us more future refactoring options.

dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

Make non-virtual. Call element type specific custom functions as needed.

(WebCore::Element::styleForRenderer):
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):
(WebCore::Element::willAttachRenderers):
(WebCore::Element::didAttachRenderers):
(WebCore::Element::willDetachRenderers):
(WebCore::Element::didDetachRenderers):

Add virtual custom callbacks.

(WebCore::Element::customStyleForRenderer):

dom/Element.h:
dom/Node.h:

(WebCore::Node::pseudoId):
(WebCore::Node::hasCustomStyleResolveCallbacks):
(WebCore::Node::setHasCustomStyleResolveCallbacks):

Use the existing bit as it largely overlaps. Rename for clarity.

(WebCore::Node::customPseudoId):

dom/PseudoElement.cpp:

(WebCore::PseudoElement::PseudoElement):
(WebCore::PseudoElement::didAttachRenderers):

dom/PseudoElement.h:
html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::willAttachRenderers):

html/HTMLCanvasElement.h:
html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::didAttachRenderers):

html/HTMLFormControlElement.h:
html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::HTMLFrameElement):
(WebCore::HTMLFrameElement::didAttachRenderers):

html/HTMLFrameElement.h:
html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::didAttachRenderers):

html/HTMLFrameElementBase.h:
html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
(WebCore::HTMLFrameSetElement::willAttachRenderers):

html/HTMLFrameSetElement.h:
html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::HTMLIFrameElement):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::didAttachRenderers):

html/HTMLImageElement.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::willAttachRenderers):
(WebCore::HTMLInputElement::didAttachRenderers):
(WebCore::HTMLInputElement::didDetachRenderers):

html/HTMLInputElement.h:
html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::HTMLLIElement):
(WebCore::HTMLLIElement::didAttachRenderers):

html/HTMLLIElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::willAttachRenderers):
(WebCore::HTMLMediaElement::didAttachRenderers):

html/HTMLMediaElement.h:
html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
(WebCore::HTMLOptGroupElement::didAttachRenderers):
(WebCore::HTMLOptGroupElement::willDetachRenderers):

html/HTMLOptGroupElement.h:
html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::HTMLOptionElement):
(WebCore::HTMLOptionElement::didAttachRenderers):
(WebCore::HTMLOptionElement::willDetachRenderers):

html/HTMLOptionElement.h:
html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement):
(WebCore::HTMLPlugInElement::willDetachRenderers):

html/HTMLPlugInElement.h:
html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::didAttachRenderers):
(WebCore::HTMLPlugInImageElement::willDetachRenderers):

html/HTMLPlugInImageElement.h:
html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::didAttachRenderers):

html/HTMLProgressElement.h:
html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
(WebCore::HTMLTextAreaElement::didAttachRenderers):

html/HTMLTextAreaElement.h:
html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::HTMLVideoElement):
(WebCore::HTMLVideoElement::didAttachRenderers):

html/HTMLVideoElement.h:
html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::willAttachRenderers):
(WebCore::InsertionPoint::willDetachRenderers):

html/shadow/InsertionPoint.h:
html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::SliderThumbElement):
(WebCore::SliderThumbElement::willDetachRenderers):

html/shadow/SliderThumbElement.h:
html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::willDetachRenderers):

html/shadow/SpinButtonElement.h:
html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::SearchFieldCancelButtonElement::willDetachRenderers):
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
(WebCore::InputFieldSpeechButtonElement::willAttachRenderers):
(WebCore::InputFieldSpeechButtonElement::willDetachRenderers):

html/shadow/TextControlInnerElements.h:
style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement):

svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::didAttachRenderers):

svg/SVGImageElement.h:
svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement):

12:29 PM Changeset in webkit [154253] by barraclough@apple.com

33 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=119972
Add attributes field to PropertySlot

Reviewed by Geoff Garen.

For all JSC types, this makes getOwnPropertyDescriptor redundant.
There will be a bit more hacking required in WebCore to remove GOPD whilst maintaining current behaviour.
(Current behaviour is in many ways broken, particularly in that GOPD & GOPS are inconsistent, but we should fix incrementally).

Source/JavaScriptCore:

No performance impact.

runtime/PropertySlot.h:

(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setCustom):
(JSC::PropertySlot::setCacheableCustom):
(JSC::PropertySlot::setCustomIndex):
(JSC::PropertySlot::setGetterSlot):
(JSC::PropertySlot::setCacheableGetterSlot):

These mathods now all require 'attributes'.

runtime/JSObject.h:

(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectOffset):
(JSC::JSObject::inlineGetOwnPropertySlot):

Added variants of getDirect, getDirectOffset that return the attributes.

API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):

runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):

runtime/JSActivation.cpp:

(JSC::JSActivation::symbolTableGet):
(JSC::JSActivation::getOwnPropertySlot):

runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlot):

runtime/JSArrayBuffer.cpp:

(JSC::JSArrayBuffer::getOwnPropertySlot):

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::getOwnPropertySlot):

runtime/JSDataView.cpp:

(JSC::JSDataView::getOwnPropertySlot):

runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertySlotByIndex):

runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::fillGetterPropertySlot):

runtime/JSString.h:

(JSC::JSString::getStringPropertySlot):

runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

runtime/Lookup.h:

(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticValueSlot):
(JSC::getStaticValueDescriptor):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):

runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayEntry::get):

Pass attributes to PropertySlot::set* methods.

Source/WebCore:

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::getOwnPropertySlotDelegate):
(WebCore::JSHistory::getOwnPropertyDescriptorDelegate):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):
(WebCore::JSLocation::getOwnPropertyDescriptorDelegate):

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectCustomGetOwnPropertySlot):
(WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):

bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):

bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):

Pass attributes to PropertySlot::set* methods.

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):

Pass attributes to PropertySlot::set* methods.

11:54 AM Changeset in webkit [154252] by rniwa@webkit.org

3 edits
2 adds in trunk

<https://webkit.org/b/119917> Pasting multiple lines into a textarea can introduce extra new lines

Reviewed by Darin Adler.

Source/WebCore:

Inspired by https://chromium.googlesource.com/chromium/blink/+/6152a12f7ace27beea4d284ff8416631e8aa5217.

The bug was caused by createFragmentFromText's falsely assuming that the newline were not preserved
if the first node's renderer didn't exist.

Fixed the bug by obtaining the renderer of the container of the first visible position in the context.

Test: editing/pasteboard/paste-into-textarea-with-new-line.html

editing/markup.cpp:

(WebCore::contextPreservesNewline):
(WebCore::createFragmentFromText):

LayoutTests:

Add a regression test.

editing/pasteboard/paste-into-textarea-with-new-line-expected.txt: Added.
editing/pasteboard/paste-into-textarea-with-new-line.html: Added.

11:44 AM Changeset in webkit [154251] by weinig@apple.com

4 edits
5 deletes in trunk/Source/WebKit2

<https://webkit.org/b/119911> Remove the unused OfflineStorageProcess

Reviewed by Darin Adler.

Configurations/OfflineStorageProcess.xcconfig: Removed.
Configurations/OfflineStorageService.Development.xcconfig: Removed.
Configurations/OfflineStorageService.xcconfig: Removed.
DerivedSources.make:
OfflineStorageProcess: Removed.
OfflineStorageProcess/EntryPoint: Removed.
OfflineStorageProcess/EntryPoint/mac: Removed.
OfflineStorageProcess/EntryPoint/mac/LegacyProcess: Removed.
OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist: Removed.
OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm: Removed.
OfflineStorageProcess/EntryPoint/mac/XPCService: Removed.
OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService: Removed.
OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development: Removed.
OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/Info.plist: Removed.
OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/Info.plist: Removed.
OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageServiceEntryPoint.mm: Removed.
OfflineStorageProcess/OfflineStorageProcess.cpp: Removed.
OfflineStorageProcess/OfflineStorageProcess.h: Removed.
OfflineStorageProcess/OfflineStorageProcess.messages.in: Removed.
OfflineStorageProcess/mac: Removed.
OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: Removed.
OfflineStorageProcess/mac/com.apple.WebKit.OfflineStorage.sb: Removed.
Scripts/webkit2/messages.py:
Shared/OfflineStorage: Removed.
Shared/OfflineStorage/OfflineStorageProcessCreationParameters.cpp: Removed.
Shared/OfflineStorage/OfflineStorageProcessCreationParameters.h: Removed.
WebKit2.xcodeproj/project.pbxproj:

Remove.

10:15 AM Changeset in webkit [154250] by akling@apple.com

2 edits in trunk/Source/WebCore

<https://webkit.org/b/119983> Add two missing RefPtr::release() in HTMLLinkElement.

Reviewed by Antti Koivisto.

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

9:01 AM Changeset in webkit [154249] by akling@apple.com

8 edits
2 adds in trunk/Source/WebCore

<https://webkit.org/b/119981> Move ElementData & co to their own files.

Reviewed by Antti Koivisto.

I like to move it move it.

7:39 AM Changeset in webkit [154248] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r153990): Add UNUSED_PARAM for heightChanged when CSS_SHAPES is disabled

Fixes the following build failure:

WebCore/rendering/RenderBlock.cpp:1529:53: error: unused parameter 'heightChanged' [-Werror,-Wunused-parameter]
void RenderBlock::updateShapesAfterBlockLayout(bool heightChanged)

1 error generated.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateShapesAfterBlockLayout): Add
UNUSED_PARAM(heightChanged) when CSS_SHAPES is disabled.

7:16 AM Changeset in webkit [154247] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL] minor method name fix for the textTrackOffMenuItemText method
https://bugs.webkit.org/show_bug.cgi?id=119978

the method textTrackOffMenuItemText was renamed in
https://bugs.webkit.org/show_bug.cgi?id=113822

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2013-08-18
Reviewed by Christophe Dumez.

platform/efl/LocalizedStringsEfl.cpp:

(WebCore::textTrackOffMenuItemText):

4:06 AM Changeset in webkit [154246] by Antti Koivisto

2 edits in trunk/LayoutTests

<https://webkit.org/b/119963> Use TextNodeTraversal for getting sheet text in StyleElement

Reviewed by Andreas Kling.

As a follow-up, mark as crashing a test that is now expected to crash in controlled manner (CRASH()).

Note that the test only ever passed because the amount of data was huge enough (>4GB) for it to take
the special do-nothing code path. With slightly less data the test would hit CRASH() in fastRealloc() like
it does now.

TestExpectations:

Mark fast/css/giant-stylesheet-crash.html as crashing.

Aug 17, 2013:

8:08 PM Changeset in webkit [154245] by mhahnenberg@apple.com

7 edits in trunk/Source/JavaScriptCore

<https://webkit.org/b/119919> Concurrent JIT crashes in various fast/js/dfg-* tests while the main thread is setting innerHTML

Reviewed by Filip Pizlo.

Added a new mode for DesiredWriteBarrier that allows it to track a position in a
Vector of WriteBarriers rather than the specific address. The fact that we were
arbitrarily storing into a Vector's backing store for constants at the end of
compilation after the Vector could have resized was causing crashes.

bytecode/CodeBlock.h:

(JSC::CodeBlock::constants):
(JSC::CodeBlock::addConstantLazily):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addConstant):

dfg/DFGDesiredWriteBarriers.cpp:

(JSC::DFG::DesiredWriteBarrier::DesiredWriteBarrier):
(JSC::DFG::DesiredWriteBarrier::trigger):
(JSC::DFG::initializeLazyWriteBarrierForConstant):

dfg/DFGDesiredWriteBarriers.h:

(JSC::DFG::DesiredWriteBarriers::add):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::truncateConstantToInt32):

dfg/DFGGraph.h:

(JSC::DFG::Graph::constantRegisterForConstant):

7:55 PM Changeset in webkit [154244] by bshafiei@apple.com

5 edits in branches/safari-537-branch/Source

Versioning.

7:47 PM Changeset in webkit [154243] by bshafiei@apple.com

1 copy in tags/Safari-537.60

New tag.

3:46 PM Changeset in webkit [154242] by Antti Koivisto

2 edits in trunk/Source/WebCore

<https://webkit.org/b/119963> Use TextNodeTraversal for getting sheet text in StyleElement

Reviewed by Andreas Kling.

dom/StyleElement.cpp:

(WebCore::StyleElement::process):

Use TextNodeTraversal::contentsAsString for the sheet text. The overflow check is removed as StringBuilder
(which is used by contentsAsString) does that itself. The behavior in case of overflow changes from empty
sheet to CRASH(). Thats what we do elsewhere in similar situations too (scripts for example). Continuing
with > 4GB of style sheet text nodes is probably not going to go well anyway.

3:05 PM Changeset in webkit [154241] by Antti Koivisto

3 edits in trunk/Source/WebCore

<https://webkit.org/b/119960> Remove some optimizations made obsolete by use of StringBuilder

Reviewed by Andreas Kling.

dom/ScriptElement.cpp:

(WebCore::ScriptElement::scriptContent):

StringBuilder already optimizes for the single string case. If there is only one the original string is returned.

dom/Text.cpp:

(WebCore::Text::wholeText):

No need to traverse twice to compute the capacity. StringBuilder handles this efficiently.
Also in the common case there is only one string and the optimization here is actually hurting by disabling the StringBuilder one.

2:33 PM Changeset in webkit [154240] by Antti Koivisto

18 edits
2 adds in trunk/Source/WebCore

<https://webkit.org/b/119959> Add TextNodeTraversal

Reviewed by Andreas Kling.

Add TextNodeTraversal for cleaner and more compact traversal of Text nodes.

Use it where appropriate.

WebCore.xcodeproj/project.pbxproj:
dom/Attr.cpp:

(WebCore::Attr::childrenChanged):

dom/NodeTraversal.h:

(WebCore::NodeTraversal::next):

dom/ScriptElement.cpp:

(WebCore::ScriptElement::scriptContent):

dom/Text.cpp:

(WebCore::Text::wholeText):

dom/Text.h:

(WebCore::toText):

dom/TextNodeTraversal.cpp: Added.

(WebCore::TextNodeTraversal::appendContents):
(WebCore::TextNodeTraversal::contentsAsString):

Helpers for getting text content of a subtree.

dom/TextNodeTraversal.h: Added.

(WebCore::TextNodeTraversal::firstTextChildTemplate):
(WebCore::TextNodeTraversal::firstChild):
(WebCore::TextNodeTraversal::firstTextWithinTemplate):
(WebCore::TextNodeTraversal::firstWithin):
(WebCore::TextNodeTraversal::traverseNextTextTemplate):
(WebCore::TextNodeTraversal::next):
(WebCore::TextNodeTraversal::nextSibling):

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::joinChildTextNodes):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultValue):
(WebCore::HTMLTextAreaElement::setDefaultValue):

html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::text):

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::determineTextDirection):

page/Frame.cpp:

(WebCore::Frame::searchForLabelsAboveCell):

xml/XPathUtil.cpp:

(WebCore::XPath::stringValue):

12:46 PM Changeset in webkit [154239] by akling@apple.com

15 edits in trunk/Source

<https://webkit.org/b/119957> Page::contextMenuController() should return a reference.

Reviewed by Antti Koivisto.

Page::m_contextMenuController is never null.

page/Page.h:

(WebCore::Page::contextMenuController):

11:05 AM Changeset in webkit [154238] by akling@apple.com

5 edits in trunk/Source/WebCore

<https://webkit.org/b/119954> Page::dragCaretController() should return a reference.

Reviewed by Antti Koivisto.

Page::m_dragCaretController is never null.

dom/Document.cpp:

(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):

page/DragController.cpp:

(WebCore::DragController::cancelDrag):
(WebCore::DragController::dragEnded):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
(WebCore::DragController::placeDragCaret):

page/Page.h:

(WebCore::Page::dragCaretController):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret):

10:29 AM Changeset in webkit [154237] by akling@apple.com

7 edits in trunk/Source/WebCore

<https://webkit.org/b/119952> Simplify Editor's back-pointer to the Frame.

Reviewed by Antti Koivisto.

Remove Editor's inheritance from FrameDestructionObserver. Editor is owned by Frame and
has no interest in observing frame destruction since its own destruction will soon follow.

Editor::m_frame is now a reference instead of a pointer. Removed some null checking.

10:23 AM Changeset in webkit [154236] by zandobersek@gmail.com

2 edits
1 add
8 deletes in trunk/LayoutTests

<https://webkit.org/b/119944> The fast/dom/gc-10.html layout test should dump text instead of render tree

Reviewed by Darin Adler.

The fast/dom/gc-10.html layout test is unnecessarily dumping the render tree and the pixel output.
Dumping the text output is sufficient enough for this test.

fast/dom/gc-10-expected.txt: Added.
fast/dom/gc-10.html:
platform/efl/fast/dom/gc-10-expected.png: Removed.
platform/efl/fast/dom/gc-10-expected.txt: Removed.
platform/gtk/fast/dom/gc-10-expected.txt: Removed.
platform/mac/fast/dom/gc-10-expected.png: Removed.
platform/mac/fast/dom/gc-10-expected.txt: Removed.
platform/qt-5.0-wk2/fast/dom/gc-10-expected.png: Removed.
platform/qt/fast/dom/gc-10-expected.png: Removed.
platform/qt/fast/dom/gc-10-expected.txt: Removed.

9:58 AM Changeset in webkit [154235] by akling@apple.com

13 edits in trunk/Source

<https://webkit.org/b/119950> Remove unused EditorClient::frameWillDetachPage() callback.

Reviewed by Antti Koivisto.

This callback was only used by the Chromium port.

editing/Editor.h:
editing/Editor.cpp:

Remove override of FrameDestructionObserver::willDetachPage().

page/EditorClient.h:

Remove frameWillDetachPage(). This is repeated in every EditorClient subclass.

9:36 AM Changeset in webkit [154234] by akling@apple.com

2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Don't export Frame::settings() as it's an inline method now.

9:12 AM Changeset in webkit [154233] by akling@apple.com

2 edits in trunk/Source/WebKit/win

Windows build fix after r154219.

WebFrame.cpp:

(WebFrame::dispatchDidClearWindowObjectInWorld):

8:43 AM Changeset in webkit [154232] by Antti Koivisto

15 edits in trunk/Source/WebCore

<https://webkit.org/b/119886> PseudoElement is abusing parent node pointer

Reviewed by Darin Adler.

PseudoElement sets its host node as its parent. This is confusing and wrong as it breaks
the basic tree consistency (a node is a child node of its parent node).

This patch adds an explicit host pointer PseudoElement and switches the call sites over. Memory
impact is negligible as there are not that many ::befores and ::afters.

dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseParent):

dom/EventPathWalker.cpp:

(WebCore::EventPathWalker::moveToParent):

dom/EventRetargeter.h:

(WebCore::EventRetargeter::eventTargetRespectingTargetRules):

dom/Node.cpp:

(WebCore::Node::~Node):

Add consistency assertions. Remove unnecessary clearing of sibling pointers. They should be cleared already.

(WebCore::Node::markAncestorsWithChildNeedsStyleRecalc):

dom/PseudoElement.cpp:

(WebCore::PseudoElement::PseudoElement):
(WebCore::PseudoElement::customStyleForRenderer):

dom/PseudoElement.h:

(WebCore::toPseudoElement):

Add casting functions.

inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setInnerNode):
(WebCore::HitTestResult::setInnerNonSharedNode):

8:32 AM Changeset in webkit [154231] by Darin Adler

4 edits in trunk/Source/WebCore

<https://webkit.org/b/119948> Change drag-specific clipboard writing in DragController to go straight to Pasteboard, not forward through Clipboard

Reviewed by Andreas Kling.

dom/Clipboard.cpp: Removed writeRange, writePlainText, and writeURL functions.

All three are just unneeded forwarding to pasteboard.

dom/Clipboard.h: Ditto.

page/DragController.cpp:

(WebCore::DragController::startDrag): Move the logic in here. Later we might
want to straighten this out a bit, perhaps using functions in Editor, but it's
not much code so fine to just have it here for now.

8:21 AM Changeset in webkit [154230] by Darin Adler

3 edits in trunk/Source/WebCore

<https://webkit.org/b/119947> Remove LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS

Reviewed by Andreas Kling.

dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard):
(WebCore::Clipboard::~Clipboard):

dom/Clipboard.h:

Remove LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS, LEGACY_VIRTUAL, and LEGACY_PURE.
Keep only the !USE(LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS) side of all conditionals.

7:56 AM Changeset in webkit [154229] by Darin Adler

4 edits in trunk/Source/WebCore

<https://webkit.org/b/119946> Move some code used only by EventHandler from Clipboard to EventHandler

Reviewed by Andreas Kling.

Later it would be good to move this all to DragController, but there is no reason to have
these functions as member functions of the DOM-exposed Clipboard class.

dom/Clipboard.cpp: Deleted hasFileOfType, hasStringOfType, convertDropZoneOperationToDragOperation,

convertDragOperationToDropZoneOperation.

dom/Clipboard.h: Ditto.

page/EventHandler.cpp:

(WebCore::convertDropZoneOperationToDragOperation): Moved here.
(WebCore::convertDragOperationToDropZoneOperation): Moved here. Also changed to use ASCIILiteral.
(WebCore::hasFileOfType): Moved here and made a free function instead of a member function. Removed
canReadTypes check because Clipboard::files already takes care of that.
(WebCore::hasStringOfType): Moved here and made a free function instead of a member function.
Added a check for the null string because HashSet::contains will not work on a null string.
(WebCore::hasDropZoneType): Moved here and made a free function instead of a member function.
(WebCore::findDropZone): Call the hasDropZoneType function instead of Clipboard::hasDropZoneType.

7:48 AM Changeset in webkit [154228] by Darin Adler

6 edits in trunk/Source/WebCore

<https://webkit.org/b/119943> Clean up the Document class a bit

Reviewed by Antti Koivisto.

dom/Document.cpp:

(WebCore::Document::~Document): Fixed typo in comment.
(WebCore::Document::suggestedMIMEType): Use ASCIILiteral for literals.
Also name local variable just loader rather than documentLoader.
(WebCore::Document::updateTitle): Call loader rather than going indirectly
through frame to get to the loader.
(WebCore::Document::setTitleElement): Fixed formatting (add braces).
(WebCore::Document::removeTitle): Iterate elements instead of nodes.
(WebCore::Document::isPageBoxVisible): Use ensureStyleResolver to call
styleForPage to avoid the need for a simple forwarding function. Also
eliminated local variable to increase clarity.
(WebCore::Document::pageSizeAndMarginsInPixels): Use ensureStyleResolver
to call styleForPage to avoid the need for a simple forwarding function.
(WebCore::Document::setIsViewSource): Renamed a local variable.

dom/Document.h: Removed unneeded childNeedsAndNotInStyleRecalc and

styleForPage functions.

loader/FrameLoader.cpp: Removed unnneeded setTitle function.
loader/FrameLoader.h: Ditto.

page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty): Use ensureStyleResolver to call
styleForPage to avoid the need for a simple forwarding function.

7:41 AM Changeset in webkit [154227] by Darin Adler

12 edits
3 deletes in trunk/Source/WebCore

<https://webkit.org/b/119939> Remove some unused clipboard and pasteboard code

Reviewed by Andreas Kling.

PlatformWinCE.cmake: Removed EditorWin.cpp.
WebCore.vcxproj/WebCore.vcxproj: Removed EditorWin.cpp.
WebCore.vcxproj/WebCore.vcxproj.filters: Removed EditorWin.cpp.
WebCore.xcodeproj/project.pbxproj: Removed ClipboardIOS.h and

ClipboardIOS.mm, and also let Xcode edit/reorder this file.

editing/Editor.cpp:

(WebCore::Editor::dispatchCPPEvent): Removed some LEGACY_STYLE_ABSTRACT_CLIPBOARD
class code. Will remove the rest later.

editing/Editor.h: Removed declaration of newGeneralClipboard.

platform/Pasteboard.h: Removed declaration of writeClipboard. Also updated a

comment to make it clearer.

platform/blackberry/PasteboardBlackBerry.cpp: Removed Pasteboard::writeClipboard.
platform/efl/PasteboardEfl.cpp: Ditto.
platform/ios/PasteboardIOS.mm: Ditto.
platform/win/PasteboardWin.cpp: Ditto.

platform/ios/ClipboardIOS.h: Removed. Was an empty file.
platform/ios/ClipboardIOS.mm: Removed. Was an empty file.
platform/win/EditorWin.cpp: Removed. Had only newGeneralClipboard in the file,

a function that is never called.

7:39 AM Changeset in webkit [154226] by Darin Adler

7 edits in trunk/Source/WebCore

<https://webkit.org/b/119940> Rename Clipboard::m_dragLoc to m_dragLocation

Reviewed by Andreas Kling.

dom/Clipboard.h: Removed unused dragLocation member function.

Renamed m_dragLoc to m_dragLocation.

dom/Clipboard.cpp:

(WebCore::Clipboard::setDragImage):

platform/gtk/ClipboardGtk.cpp:

(WebCore::Clipboard::createDragImage):

platform/mac/ClipboardMac.mm:

(WebCore::Clipboard::createDragImage):

platform/qt/ClipboardQt.cpp:

(WebCore::Clipboard::createDragImage):

platform/win/ClipboardWin.cpp:

(WebCore::Clipboard::createDragImage):
Updated for new name.

7:37 AM Changeset in webkit [154225] by Darin Adler

7 edits in trunk/Source/WebCore

<https://webkit.org/b/119942> Remove unnecessary uses of Element::ownerDocument

Reviewed by Andreas Kling.

The Element::document is a simpler faster alternative to Element::ownerDocument.
The only behavior difference between the two is that ownerDocument returns 0 when
called on a Document.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::supportsFocus): Call document instead of ownerDocument.
(WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Removed null checking of
document and call to ownerDocument, since ownerDocument will never return non-null
if document returns null.
(WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): Call document instead
of ownerDocument.

inspector/DOMEditor.cpp:

(WebCore::DOMEditor::SetOuterHTMLAction::perform): Call document instead of ownerDocument.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode): Call document instead of ownerDocument.
(WebCore::InspectorCSSAgent::forcePseudoState): Call document instead of ownerDocument.
(WebCore::InspectorCSSAgent::resetPseudoStates): Call document instead of ownerDocument.

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML): Call document instead of expression that
does the same thing in a roundabout way.
(WebCore::InspectorDOMAgent::focusNode): Call document instead of ownerDocument.
(WebCore::InspectorDOMAgent::resolveNode): Call document instead of expression that
does the same thing in a roundabout way.

page/DragController.cpp:

(WebCore::DragController::concludeEditDrag): Call document instead of ownerDocument.

svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::ownerDocument): Call document instead of ownerDocument.

7:27 AM Changeset in webkit [154224] by Darin Adler

19 edits in trunk/Source

<https://webkit.org/b/119941> Make Page::dragController return a reference

Reviewed by Andreas Kling.

Source/WebCore:

page/Page.h:

(WebCore::Page::dragController): Return a reference instead of a pointer.

page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateDragSourceActionsAllowed):
(WebCore::EventHandler::handleDrag):

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passSubframeEventToSubframe):
Updated call sites.

Source/WebKit/gtk:

webkit/webkitwebview.cpp:

(dragExitedCallback):
(webkit_web_view_drag_motion):
(webkit_web_view_drag_data_received):
(webkit_web_view_drag_drop):
Updated call sites.

Source/WebKit/mac:

WebView/WebFrameView.mm:

(-[WebFrameView _setDocumentView:]):

WebView/WebHTMLView.mm:

(-[WebHTMLView draggingSourceOperationMaskForLocal:]):
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

WebView/WebView.mm:

(-[WebView _setInitiatedDrag:]):
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):
(-[WebView moveDragCaretToPoint:]):
(-[WebView removeDragCaret]):
Updated call sites.

Source/WebKit/qt:

WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::dragEntered):
(QWebPageAdapter::dragLeaveEvent):
(QWebPageAdapter::dragUpdated):
(QWebPageAdapter::performDrag):
Updated call sites.

Source/WebKit/win:

WebCoreSupport/WebDragClient.cpp:

(WebDragClient::startDrag):

WebView.cpp:

(WebView::keyStateToDragOperation):
(WebView::DragEnter):
(WebView::DragOver):
(WebView::DragLeave):
(WebView::Drop):
Updated call sites.

Source/WebKit2:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::dragEnded):
Updated call sites.

5:38 AM Changeset in webkit [154223] by ddkilzer@apple.com

5 edits in trunk/Source/ThirdParty/ANGLE

ANGLE fails to build with trunk clang: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
<http://webkit.org/b/119931>
<rdar://problem/14763822>

Reviewed by Darin Adler.

src/compiler/glslang.l:
src/compiler/glslang_lex.cpp:
src/compiler/preprocessor/Tokenizer.cpp:
src/compiler/preprocessor/Tokenizer.l:

Add pragma statements to ignore -Wdeprecated-register warnings
in generated code. Also ignore -Wunknown-pragmas so this
doesn't cause a build failure in older versions of clang.

5:37 AM Changeset in webkit [154222] by ddkilzer@apple.com

2 edits in trunk/Source/WebKit2

WebKit2 fails to build with trunk clang: error: 'WebPluginSiteDataManagerh' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard]
<http://webkit.org/b/119935>
<rdar://problem/14764131>

Reviewed by Darin Adler.

UIProcess/Plugins/WebPluginSiteDataManager.h: Fix typo

introduced in r78647.

5:31 AM Changeset in webkit [154221] by commit-queue@webkit.org

7 edits
22 adds in trunk

<https://webkit.org/b/119795> Propagate writing-mode from the first region to the flow thread

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-08-17
Reviewed by Darin Adler.

Source/WebCore:

Since the flow thread is a direct child of RenderView, it doesn't inherit
proper writing-mode automatically. It should be mentioned that if the thread's
contents' writing-mode differs from that of the first region, things are
typically going to look useless (although perhaps that's how it should be),
but as long as writing-mode is only specified on a common parent of the
thread's contents and the regions, things look fine, and also, we're now
following what the spec has to say on the matter:

http://www.w3.org/TR/2013/WD-css3-regions-20130528/#the-flow-into-property

"The first region defines the principal writing mode for the entire flow.

The writing mode on subsequent regions is ignored."

This is a back-port of the fix for Blink bug 257965.
Reviewed by esprehn and mihnea there.
Blink review URL: https://chromiumcodereview.appspot.com/18374008

Tests: fast/regions/changing-writing-mode-2.html

fast/regions/changing-writing-mode-3.html
fast/regions/changing-writing-mode-4.html
fast/regions/changing-writing-mode-5.html
fast/regions/changing-writing-mode.html
fast/regions/invalid-first-region-with-writing-mode-2.html
fast/regions/invalid-first-region-with-writing-mode.html
fast/regions/subtree-with-horiz-bt.html
fast/regions/subtree-with-horiz-tb.html
fast/regions/subtree-with-vert-lr.html
fast/regions/subtree-with-vert-rl.html

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::styleDidChange):

rendering/RenderFlowThread.h:
rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::updateWritingMode):
(WebCore::RenderNamedFlowThread::addRegionToNamedFlowThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::regionChangedWritingMode):