⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 22, 2013:

11:24 PM Changeset in webkit [154474] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Wrong interface version used in WebKitWebPage for loader client
​https://bugs.webkit.org/show_bug.cgi?id=120199

Reviewed by Gustavo Noronha Silva.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkitWebPageCreate): Use kWKBundlePageLoaderClientCurrentVersion
instead of kWKBundlePageResourceLoadClientCurrentVersion in loader
client initialization.

9:39 PM Changeset in webkit [154473] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Need to disable FakeSYSVSHM when sandboxing is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=120182
<rdar://problem/14814461>

Patch by Simon Cooper <​scooper@apple.com> on 2013-08-22
Reviewed by Alexey Proskuryakov.

When not in a sandbox do not enable the FakeSYSVSHIM. This
allows LocalConnection to work when Flash Player is run in
"Unsafe Mode".

  • PluginProcess/mac/PluginProcessShim.mm:

(WebKit::shim_disabled):

8:21 PM Changeset in webkit [154472] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Introduce toSVGLinearGradientElement(), and use it
​https://bugs.webkit.org/show_bug.cgi?id=120154

Reviewed by Andreas Kling.

As a step to clean-up static_cast<SVGXXX>, toSVGLinearGradientElement() is added to clean-up
static_cast<SVGLinearGradientElement*>.

  • rendering/svg/RenderSVGResourceLinearGradient.cpp:

(WebCore::RenderSVGResourceLinearGradient::collectGradientAttributes):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::collectGradientAttributes):

  • svg/SVGLinearGradientElement.h:

(WebCore::toSVGLinearGradientElement):

5:45 PM Changeset in webkit [154471] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

JSObject and JSArray code shouldn't have to tiptoe around garbage collection
​https://bugs.webkit.org/show_bug.cgi?id=120179

Reviewed by Geoffrey Garen.

There are many places in the code for JSObject and JSArray where they are manipulating their
Butterfly/Structure, e.g. after expanding their out-of-line backing storage via allocating. Within
these places there are certain "critical sections" where a GC would be disastrous. Gen GC looks
like it will make this dance even more intricate. To make everybody's lives easier we should use
the DeferGC mechanism in these functions to make these GC critical sections both obvious in the
code and trivially safe. Deferring collections will usually only last marginally longer, thus we
should not incur any additional overhead.

  • heap/Heap.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::unshiftCountSlowCase):

  • runtime/JSObject.cpp:

(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):

5:28 PM Changeset in webkit [154470] by Simon Fraser
  • 10 edits
    2 adds in trunk

compositing/geometry/bounds-ignores-hidden-dynamic.html has incorrect initial rendering
​https://bugs.webkit.org/show_bug.cgi?id=119825

Source/WebCore:

Reviewed by Tim Horton.

r137526 and some earlier commits attempted to avoid unconditionally
repainting layers when their size changes, because this was causing
TiledBacking layers to repaint when the document size changed.

However, the approach required that we have good information about
whether size changes require a repaint, which in some cases is hard
to determine, especially when RenderLayer changes affect our
decisions about which layers are composited.

Fix by pushing the decision about whether to repaint on size change
into GraphicsLayer. The default is to repaint on size change,
but GraphicsLayer provides a function that can be overridden to
modify this behavior; GraphicsLayerCA does so to avoid repaints
when layers with TiledBackings get resized.

Test: compositing/repaint/repaint-on-layer-grouping-change.html

  • WebCore.exp.in: WebKit2 needs GraphicsLayer::setSize, which is no longer inline.
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setOffsetFromRenderer):
(WebCore::GraphicsLayer::setSize):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::shouldRepaintOnSizeChange):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::shouldRepaintOnSizeChange):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.h: No longer need m_boundsConstrainedByClipping
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): setSize takes
care of repainting for us now, so we can remove all the conditional code.

LayoutTests:

Reviewed by Tim Horton.

Test that dumps repaint rects on layers after visibility changes affect
the layer hierarchy.

  • compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
  • compositing/repaint/repaint-on-layer-grouping-change.html: Added.
  • compositing/repaint/resize-repaint-expected.txt: Update result.
5:28 PM Changeset in webkit [154469] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Repaint counters are sometimes not in the corner of the compositing layer
​https://bugs.webkit.org/show_bug.cgi?id=120176

Reviewed by Beth Dakin.

Sometimes the repaint counters are not in the corner of the compositing layer;
they are either inset, or partially or entirely outside the layer.

Fix by making sure that we restore the CGContext before drawing
the counter, since the WebCore code may have translated the CTM.

The counter-painting code saves and restores the context itself,
so this is safe.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

5:19 PM Changeset in webkit [154468] by fpizlo@apple.com
  • 9 edits
    1 add in trunk

Update LLVM binary drops and scripts to the latest version from SVN
​https://bugs.webkit.org/show_bug.cgi?id=120184

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

Tools:

  • ReducedFTL/build.sh:
  • Scripts/configure-llvm: Added.
  • Scripts/copy-webkitlibraries-to-product-directory:
  • Scripts/export-llvm-build:

WebKitLibraries:

Updated binary drops to r189066.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
5:15 PM Changeset in webkit [154467] by aestes@apple.com
  • 5 edits in trunk

<​https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files

Reviewed by David Kilzer.

Source/WebKit2:

Adding ld flags for ASAN overwrote the unexported symbol flags we were
previously specifying. Since the unexported symbol ld flags are only
needed for the framework target, move them to WebKit2.xcconfig where we
can add them to OTHER_LDFLAGS along with the ASAN values inherited from
DebugRelease.xcconfig (and other values).

  • Configurations/Base.xcconfig: Removed the unexported symbol ld flags.
  • Configurations/WebKit2.xcconfig: ... and moved them here.

Tools:

  • TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of

OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.

5:09 PM Changeset in webkit [154466] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Don't leak registers for redeclared variables
​https://bugs.webkit.org/show_bug.cgi?id=120174

Reviewed by Geoff Garen.

We currently always allocate registers for new global variables, but these are wasted when the variable is being redeclared.
Only allocate new registers when necessary.

No performance impact.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

  • Don't allocate the register here.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addGlobalVar):

  • Allocate the register here instead.
3:43 PM Changeset in webkit [154465] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

3:41 PM Changeset in webkit [154464] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unavailable plug-in indicator text is one pixel too low
​https://bugs.webkit.org/show_bug.cgi?id=120177
<rdar://problem/14811951>

Reviewed by Kevin Decker.

Move the unavailable plug-in indicator text up one pixel.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintReplaced):

3:41 PM Changeset in webkit [154463] by Lucas Forschler
  • 1 copy in tags/Safari-537.62

New Tag.

2:58 PM Changeset in webkit [154462] by Christophe Dumez
  • 132 edits
    2 adds
    3 deletes in trunk

[SVG2] Merge SVGStyledElement and SVGElement
​https://bugs.webkit.org/show_bug.cgi?id=107386

Reviewed by Andreas Kling.

Source/WebCore:

Merge SVGStyledElement into SVGElement to simplify the SVG inheritance
model and match the SVG2 specification:
​https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement

Test: svg/dom/svg2-inheritance.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):

  • css/SVGCSSStyleSelector.cpp:
  • rendering/style/SVGRenderStyle.cpp:
  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::RenderSVGContainer):

  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGHiddenContainer.cpp:

(WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer):

  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::RenderSVGModelObject):
(WebCore::getElementCTM):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/RenderSVGResourceMarker.cpp:
  • rendering/svg/RenderSVGResourceMarker.h:
  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):

  • rendering/svg/RenderSVGViewportContainer.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):

  • rendering/svg/SVGRenderTreeAsText.cpp:
  • rendering/svg/SVGResources.cpp:

(WebCore::registerPendingResource):

  • rendering/svg/SVGResourcesCache.cpp:
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::title):

  • svg/SVGAllInOne.cpp:
  • svg/SVGAltGlyphDefElement.h:
  • svg/SVGAltGlyphItemElement.h:
  • svg/SVGAnimateElement.cpp:
  • svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::isTargetAttributeCSSProperty):
(WebCore::SVGAnimationElement::computeCSSPropertyValue):
(WebCore::SVGAnimationElement::adjustForInheritance):
(WebCore::inheritsFromProperty):

  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.h:
  • svg/SVGDescElement.cpp:

(WebCore::SVGDescElement::SVGDescElement):

  • svg/SVGDescElement.h:
  • svg/SVGDescElement.idl:
  • svg/SVGElement.cpp:

(WebCore::mapAttributeToCSSProperty):
(WebCore::cssPropertyToTypeMap):
(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::parseAttribute):
(WebCore::SVGElement::animatedPropertyTypeForAttribute):
(WebCore::collectInstancesForSVGElement):
(WebCore::SVGElement::isAnimatableAttribute):
(WebCore::SVGElement::title):
(WebCore::SVGElement::rendererIsNeeded):
(WebCore::SVGElement::cssPropertyIdForSVGAttributeName):
(WebCore::SVGElement::isAnimatableCSSProperty):
(WebCore::SVGElement::isPresentationAttribute):
(WebCore::SVGElement::collectStyleForPresentationAttribute):
(WebCore::SVGElement::isKnownAttribute):
(WebCore::SVGElement::svgAttributeChanged):
(WebCore::SVGElement::insertedInto):
(WebCore::SVGElement::buildPendingResourcesIfNeeded):
(WebCore::SVGElement::childrenChanged):
(WebCore::SVGElement::getPresentationAttribute):
(WebCore::SVGElement::instanceUpdatesBlocked):
(WebCore::SVGElement::setInstanceUpdatesBlocked):
(WebCore::SVGElement::localCoordinateSpaceTransform):
(WebCore::SVGElement::updateRelativeLengthsInformation):
(WebCore::SVGElement::isMouseFocusable):
(WebCore::SVGElement::isKeyboardFocusable):

  • svg/SVGElement.h:

(WebCore::SVGElement::supportsMarkers):
(WebCore::SVGElement::hasRelativeLengths):
(WebCore::SVGElement::needsPendingResourceHandling):
(WebCore::SVGElement::selfHasRelativeLengths):
(WebCore::SVGElement::updateRelativeLengthsInformation):

  • svg/SVGElement.idl:
  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
(WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker):

  • svg/SVGElementInstance.h:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::SVGFilterElement):
(WebCore::SVGFilterElement::parseAttribute):
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):

  • svg/SVGFilterElement.h:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
(WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute):
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):

  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::SVGFontElement):

  • svg/SVGFontElement.h:
  • svg/SVGFontFaceElement.cpp:
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::rendererIsNeeded):

  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::SVGGlyphElement):
(WebCore::SVGGlyphElement::parseAttribute):
(WebCore::SVGGlyphElement::insertedInto):
(WebCore::SVGGlyphElement::removedFrom):

  • svg/SVGGlyphElement.h:
  • svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::SVGGlyphRefElement):
(WebCore::SVGGlyphRefElement::parseAttribute):

  • svg/SVGGlyphRefElement.h:
  • svg/SVGGlyphRefElement.idl:
  • svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::SVGGradientElement):
(WebCore::SVGGradientElement::parseAttribute):
(WebCore::SVGGradientElement::svgAttributeChanged):
(WebCore::SVGGradientElement::childrenChanged):

  • svg/SVGGradientElement.h:
  • svg/SVGGradientElement.idl:
  • svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):

  • svg/SVGGraphicsElement.h:
  • svg/SVGGraphicsElement.idl:
  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::computeCTM):

  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::parseAttribute):
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):

  • svg/SVGMarkerElement.h:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::SVGMaskElement):
(WebCore::SVGMaskElement::parseAttribute):
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):

  • svg/SVGMaskElement.h:
  • svg/SVGMaskElement.idl:
  • svg/SVGMetadataElement.h:
  • svg/SVGMissingGlyphElement.cpp:

(WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement):

  • svg/SVGMissingGlyphElement.h:
  • svg/SVGMissingGlyphElement.idl:
  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::parseAttribute):
(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::childrenChanged):

  • svg/SVGPatternElement.h:
  • svg/SVGPatternElement.idl:
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::SVGStopElement):
(WebCore::SVGStopElement::parseAttribute):
(WebCore::SVGStopElement::svgAttributeChanged):

  • svg/SVGStopElement.h:
  • svg/SVGStopElement.idl:
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: Removed.
  • svg/SVGStyledElement.h: Removed.
  • svg/SVGStyledElement.idl: Removed.
  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::SVGSymbolElement):
(WebCore::SVGSymbolElement::parseAttribute):
(WebCore::SVGSymbolElement::svgAttributeChanged):

  • svg/SVGSymbolElement.h:
  • svg/SVGSymbolElement.idl:
  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::removedFrom):

  • svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::SVGTitleElement):
(WebCore::SVGTitleElement::insertedInto):

  • svg/SVGTitleElement.h:
  • svg/SVGTitleElement.idl:
  • svg/SVGTransformable.cpp:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::selfHasRelativeLengths):

  • svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::SVGViewElement):
(WebCore::SVGViewElement::parseAttribute):

  • svg/SVGViewElement.h:
  • svg/animation/SVGSMILElement.h:
  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

LayoutTests:

Add layout test to validate the SVG2 inheritance model.

  • svg/dom/svg2-inheritance-expected.txt: Added.
  • svg/dom/svg2-inheritance.html: Added.
2:26 PM Changeset in webkit [154461] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=120128
Remove putDirectVirtual

Unreviewed, checked in commented out code. :-(

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • delete commented out code
2:24 PM Changeset in webkit [154460] by barraclough@apple.com
  • 5 edits in trunk

Error.stack should not be enumerable
​https://bugs.webkit.org/show_bug.cgi?id=120171

Reviewed by Oliver Hunt.

Breaks ECMA tests.

Source/JavaScriptCore:

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::finishCreation):

  • None -> DontEnum

LayoutTests:

  • fast/js/exception-properties-expected.txt:
  • fast/js/script-tests/exception-properties.js:
    • Update test expectations.
1:35 PM Changeset in webkit [154459] by barraclough@apple.com
  • 19 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=120128
Remove putDirectVirtual

Reviewed by Sam Weinig.

This could most generously be described as 'vestigial'.
No performance impact.

  • API/JSObjectRef.cpp:

(JSObjectSetProperty):

  • changed to use defineOwnProperty
  • debugger/DebuggerActivation.cpp:
  • debugger/DebuggerActivation.h:
    • remove putDirectVirtual
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • changed to use defineOwnProperty
  • runtime/ClassInfo.h:
  • runtime/JSActivation.cpp:
  • runtime/JSActivation.h:
  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:
  • runtime/JSObject.h:
  • runtime/JSProxy.cpp:
  • runtime/JSProxy.h:
  • runtime/JSSymbolTableObject.cpp:
  • runtime/JSSymbolTableObject.h:
    • remove putDirectVirtual
  • runtime/PropertyDescriptor.h:

(JSC::PropertyDescriptor::PropertyDescriptor):

  • added constructor for convenience
1:27 PM Changeset in webkit [154458] by akling@apple.com
  • 15 edits in trunk/Source

FrameLoader::history() should return a reference.
<​https://webkit.org/b/120163>

Reviewed by Anders Carlsson.

Rehued by Anders Carlsson.

FrameLoader::m_history is never null, so make history() return a reference.
Also made HistoryController::m_frame a reference, since HistoryController's
lifetime is tied to FrameLoader, which is tied to the Frame.

12:44 PM Changeset in webkit [154457] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

errorDescriptionForValue() should not assume error value is an Object
​https://bugs.webkit.org/show_bug.cgi?id=119812

Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-08-22
Reviewed by Geoffrey Garen.

Added a check to make sure that the JSValue was an object before casting it as an object. Also, in case the parameterized JSValue
has no type, the function now returns the empty string.

  • runtime/ExceptionHelpers.cpp:

(JSC::errorDescriptionForValue):

12:28 PM Changeset in webkit [154456] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebInspectorUI

<​https://webkit.org/b/120165> Web Inspector: Update CodeMirror to 3.16.1

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-08-22
Reviewed by Andy Estes.

  • Tools/PrettyPrinting/codemirror.css:
  • Tools/PrettyPrinting/codemirror.js:
  • Tools/PrettyPrinting/css.js:
  • Tools/PrettyPrinting/javascript.js:
  • UserInterface/External/CodeMirror/codemirror.css:
  • UserInterface/External/CodeMirror/codemirror.js:
  • UserInterface/External/CodeMirror/css.js:
  • UserInterface/External/CodeMirror/javascript.js:
  • UserInterface/External/CodeMirror/xml.js:
11:48 AM Changeset in webkit [154455] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Reloading this video test shows garbage briefly
​https://bugs.webkit.org/show_bug.cgi?id=119377

Reviewed by Anders Carlson.

RenderVideo should not claim that it's foreground is opaque
unless it has a video frame to display.

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect):

9:59 AM Changeset in webkit [154454] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/win

Another Windows build fix.

  • WebDataSource.cpp:

(WebDataSource::subresourceForURL):

9:57 AM Changeset in webkit [154453] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[CSSRegions] Min-width and max-width for a region should support values other than length
​https://bugs.webkit.org/show_bug.cgi?id=115248

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-08-22
Reviewed by Alexandru Chiculita.

  • fast/regions/region-min-max-width-support-expected.txt: Added.
  • fast/regions/region-min-max-width-support.html: Added.
9:44 AM Changeset in webkit [154452] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove accidental cruft from r154449.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::destroy):

9:43 AM Changeset in webkit [154451] by akling@apple.com
  • 6 edits in trunk/Source/WebKit

Source/WebKit/efl: EFL build juice.

  • WebCoreSupport/ChromeClientEfl.cpp:

(kit):

Source/WebKit/win: Windows build juice.

  • WebDataSource.cpp:

(WebDataSource::representation):
(WebDataSource::webFrame):

  • WebElementPropertyBag.cpp:

(WebElementPropertyBag::Read):

  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::receivedPolicyDecision):

9:05 AM Changeset in webkit [154450] by rniwa@webkit.org
  • 5 edits in trunk/Tools

NRWT: Add the ability to upload test results to new test results server
​https://bugs.webkit.org/show_bug.cgi?id=120146

Reviewed by Andreas Kling.

For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
that contains the full summary of the test run including information about passed tests.

Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
--build-slave
--got-revision
--results-server-host

The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
so we should be able to delete --test-results-server in time.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):
(Manager._upload_json_files):
(Manager):
(Manager.upload_results):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:

(summarized_results):
(SummarizedResultsTest.test_summarized_results_wontfix):
(SummarizedResultsTest):
(SummarizedResultsTest.test_summarized_results_include_passes):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

9:01 AM Changeset in webkit [154449] by akling@apple.com
  • 75 edits in trunk/Source

FrameLoader: frame() and client() should return references.
<​https://webkit.org/b/120158>

Reviewed by Anders Carlsson.

These two are never null so change them to return references.

8:34 AM Changeset in webkit [154448] by rniwa@webkit.org
  • 2 edits in trunk/Tools

WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Hi.execute):

8:28 AM Changeset in webkit [154447] by abucur@adobe.com
  • 2 edits in trunk/Source/WebCore

RenderNamedFlowThread should not create NodeRenderingContext objects
​https://bugs.webkit.org/show_bug.cgi?id=119923

Reviewed by Antti Koivisto.

Port of ​https://chromium.googlesource.com/chromium/blink/+/949d7d7e7b8685454742a55cf0ca912bb9a7b177.
Original patch by Elliott Sprehn.

RenderNamedFlowThread should not create NodeRenderingContext objects

RenderNamedFlowThread is using NodeRenderingContext to get the original
parent renderer, but should just be using NodeRenderingTraversal::parent
instead (which is what NodeRenderingContext does internally anyway).

Tests: No change in functionality. No new tests.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::isChildAllowed):

7:01 AM Changeset in webkit [154446] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Actually, this test is failing on Debug builds as well.
Update the test expectation accordingly.

  • platform/mac-wk2/TestExpectations:
6:55 AM Changeset in webkit [154445] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add the failing test expectation to webaudio/codec-tests/mp3/128kbps-44khz.html on Lion Release WK2.
The failure is tracked by the bug 120161.

  • platform/mac-wk2/TestExpectations:
5:46 AM Changeset in webkit [154444] by allan.jensen@digia.com
  • 2 edits in trunk/Tools

[Qt] DRT bug revealed/caused by r154300
​https://bugs.webkit.org/show_bug.cgi?id=120151

Reviewed by Simon Hausmann.

Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
in r154300.

DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
between native Qt methods and JSC bound methods. This patch changes the check to see if the
property is writable since the Qt methods are ReadOnly.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::initJSObjects):

5:38 AM Changeset in webkit [154443] by Christophe Dumez
  • 10 edits
    1 add in trunk/Source/WebCore

Introduce a SVGUnknownElement class for unknown SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=120155

Reviewed by Andreas Kling.

Introduce a SVGUnknownElement class and have it override rendererIsNeeded() to return false.
We now use SVGUnknownElement type (instead of SVGElement) for unknown SVG elements:

As a consequence, SVGElement::rendererIsNeeded() is not longer required to return false and
it will be able to behave as SVGStyledElement::rendererIsNeeded() once we merge
SVGStyledElement into SVGElement.

This is a pre-requirement to merging SVGStyledElement into SVGElement.

No new tests, no behavior change.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElementInternal):

  • dom/make_names.pl:

(defaultParametersHash):
(printJSElementIncludes):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • svg/SVGElement.cpp:
  • svg/SVGElement.h:
  • svg/SVGUnknownElement.h: Added.

(WebCore::SVGUnknownElement::create):
(WebCore::SVGUnknownElement::SVGUnknownElement):

  • svg/svgtags.in:
5:37 AM Changeset in webkit [154442] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix P_DFGOperation_EJS call for MIPS and ARM EABI.
​https://bugs.webkit.org/show_bug.cgi?id=120107

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-08-22
Reviewed by Yong Li.

EncodedJSValue parameters must be aligned to even registers for MIPS and ARM EABI.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

4:50 AM Changeset in webkit [154441] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION: Assertion failure !collection->hasExactlyOneItem() in WebCore::namedItemGetter
​https://bugs.webkit.org/show_bug.cgi?id=118056

Reviewed by Ryosuke Niwa.

Source/WebCore:

The assert is hit in Debug mode because the DocumentOrderedMap in HTMLDocument::m_windowNamedItem
includes matched SVG elements, but the WindowNameCollection used to collect the elements does not.
This means the HTMLCollection stripped of SVG elements could end up hitting the empty or single item
assertion, which the testcase verifies.
To fix this change WindowNameCollection to include both SVG and HTML elements so it matches DocumentOrderedMap.

Tests: svg/custom/document-all-includes-svg.html

svg/custom/window-named-item-lookup.html

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):
(WebCore::HTMLCollection::updateNameCache):

LayoutTests:

Add test to verify that SVG and HTML elements with id's are both found when using document.all or named properties.

  • svg/custom/document-all-includes-svg-expected.txt: Added.
  • svg/custom/document-all-includes-svg.html: Added.
  • svg/custom/window-named-item-lookup-expected.txt: Added.
  • svg/custom/window-named-item-lookup.html: Added.
4:43 AM Changeset in webkit [154440] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Introduce toSVGRadialGradientElement(), and use it
​https://bugs.webkit.org/show_bug.cgi?id=120153

Reviewed by Andreas Kling.

As a step to clean-up static_cast<SVGXXX>, toSVGRadialGradientElement() is added to clean-up
static_cast<SVGRadialGradientElement*>.

  • rendering/svg/RenderSVGResourceRadialGradient.cpp:

(WebCore::RenderSVGResourceRadialGradient::collectGradientAttributes):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::collectGradientAttributes):

  • svg/SVGRadialGradientElement.h:

(WebCore::toSVGRadialGradientElement):

3:14 AM Changeset in webkit [154439] by reni@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement
​https://bugs.webkit.org/show_bug.cgi?id=119672

Reviewed by Darin Adler.

Source/WebCore:

The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set
to default 0. This way we have to check its existence before the usage.

Test: editing/execCommand/extracted_style_assert.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):

LayoutTests:

Test with NULL extractedStyle.

  • editing/execCommand/extracted_style_assert-expected.txt: Added.
  • editing/execCommand/extracted_style_assert.html: Added.
2:28 AM Changeset in webkit [154438] by sergio@webkit.org
  • 7 edits
    1 add in trunk/LayoutTests

[CSS Grid Layout] Refactor testing code
​https://bugs.webkit.org/show_bug.cgi?id=119552

Reviewed by Darin Adler.

Based on Blink r148922 & r149060 by <​jchaffraix@chromium.org>

The old testing code was a huge copy&paste of big testing code
blocks. Refactor it in some new utility functions so that we could
reduce the size of the layout test file and ease the maintenance.

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
  • fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js: Added.

Aug 21, 2013:

10:02 PM Changeset in webkit [154437] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Update Mac test expectations.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
9:40 PM Changeset in webkit [154436] by commit-queue@webkit.org
  • 24 edits in trunk

Unreviewed, rolling out r154416.
​http://trac.webkit.org/changeset/154416
​https://bugs.webkit.org/show_bug.cgi?id=120147

Broke Windows builds (Requested by rniwa on #webkit).

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcxproj/WebCoreGenerated.make:
  • WebCore.vcxproj/WebCoreGeneratedWinCairo.make:
  • WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props:
  • WebCore.vcxproj/build-generated-files.sh:
  • WebCore.vcxproj/copyForwardingHeaders.cmd:
  • WebCore.vcxproj/copyWebCoreResourceFiles.cmd:

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:

Source/WTF:

  • WTF.vcxproj/WTFGenerated.make:
  • WTF.vcxproj/build-generated-files.sh:

WebKitLibraries:

  • win/tools/vsprops/common.props:
7:06 PM Changeset in webkit [154435] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Unreviewed build fix after r154430.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::hasFilters): Added CSS_FILTERS guard.

6:04 PM Changeset in webkit [154434] by barraclough@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Clarify var/const/function declaration
​https://bugs.webkit.org/show_bug.cgi?id=120144

Reviewed by Sam Weinig.

Add methods to JSGlobalObject to declare vars, consts, and functions.

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

  • runtime/Executable.h:
    • Moved declaration code to JSGlobalObject
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addGlobalVar):

  • internal implementation of addVar, addConst, addFunction
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::addVar):
(JSC::JSGlobalObject::addConst):
(JSC::JSGlobalObject::addFunction):

  • Added methods to declare vars, consts, and functions
6:00 PM Changeset in webkit [154433] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Another null-deref under WebDragClient::startDrag
​https://bugs.webkit.org/show_bug.cgi?id=120145
<rdar://problem/14650652>

Reviewed by Simon Fraser.

convertImageToBitmap can legitimately return null, so don't dereference it.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag):

5:58 PM Changeset in webkit [154432] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning

5:48 PM Changeset in webkit [154431] by Lucas Forschler
  • 1 copy in tags/Safari-537.61

New Tag.

5:15 PM Changeset in webkit [154430] by Simon Fraser
  • 5 edits
    2 adds in trunk

Setting -webkit-filter: in :active selector causes failure to redraw
​https://bugs.webkit.org/show_bug.cgi?id=120135

Source/WebCore:

Reviewed by Jer Noble.

When removing a filter on an inline child of a compositing layer,
the inline loses its RenderLayer and compositing layer, but we fail to
repaint the compositing layer that the inline is now painting into.

This worked correctly for opacity, because opacity toggles cause
layouts (which then paint the correct layer), so do the same for filters.

Test: css3/filters/remove-filter-repaint.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout): Return true if we toggled
between having filters and not. Drive-by cleanup, making use of new convenience
function for hasOpacity().

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::hasFilters): Returns true if we have any
filters.

  • rendering/style/StyleRareNonInheritedData.h:

(WebCore::StyleRareNonInheritedData::hasOpacity): Convenience function that
returns true if opacity is < 1.

LayoutTests:

Reviewed by Jer Noble.

Ref test for removing a filter on an inline.

  • css3/filters/remove-filter-repaint-expected.html: Added.
  • css3/filters/remove-filter-repaint.html: Added.
4:34 PM Changeset in webkit [154429] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

​https://bugs.webkit.org/show_bug.cgi?id=119900
Exception in global setter doesn't unwind correctly

Patch by Yi Shen <​max.hong.shen@gmail.com> on 2013-08-21
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Call VM_THROW_EXCEPTION_AT_END in op_put_to_scope if the setter throws exception.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

LayoutTests:

Add test for calling global setter which throws exception.

  • fast/js/script-tests/throw-exception-in-global-setter.js: Added.

(g):

  • fast/js/throw-exception-in-global-setter-expected.txt: Added.
  • fast/js/throw-exception-in-global-setter.html: Added.
4:27 PM Changeset in webkit [154428] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

<​https://webkit.org/b/120140> Clients expect didFirstLayout-related calls to
happen before didLayout

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout):

4:18 PM Changeset in webkit [154427] by Brent Fulgham
  • 3 edits in trunk/Source/WebInspectorUI

[Windows] Clean up project file after %PlatformArchitecture% change landed.

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove hard-coded settings covered

by our configuration files.

  • WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Use the %PlatformArchitecture%

macro to support 32- and 64-bit builds.

4:10 PM Changeset in webkit [154426] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Rename/refactor setButterfly/setStructure
​https://bugs.webkit.org/show_bug.cgi?id=120138

Reviewed by Geoffrey Garen.

setButterfly becomes setStructureAndButterfly.

Also removed the Butterfly* argument from setStructure and just implicitly
used m_butterfly internally since that's what every single client of setStructure
was doing already.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSObject.cpp:

(JSC::JSObject::notifyPresenceOfIndexedAccessors):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::genericConvertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::switchToSlowPutArrayStorage):
(JSC::JSObject::setPrototype):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::reifyStaticFunctionsForDelete):
(JSC::JSObject::removeDirect):

  • runtime/JSObject.h:

(JSC::JSObject::setStructureAndButterfly):
(JSC::JSObject::setStructure):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure):

4:03 PM Changeset in webkit [154425] by ap@apple.com
  • 7 edits in trunk/LayoutTests

http/tests/cookies/simple-cookies-expired.html sometimes fails on Lion Intel Release (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=73694

http/tests/cookies/simple-cookies-max-age.html sometimes fails on Lion Intel Release (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=73695

http/tests/cookies/single-quoted-value.html intermittently fails on Mac
​https://bugs.webkit.org/show_bug.cgi?id=105603

Reviewed by Dan Bernstein.

Woark around a CFNetwork issue by using Max-Age=-1 instead of Max-Age=0. Since it's
WebKit that we are testing and not the lower level networking, this does not change
test coverage.

  • http/tests/cookies/resources/clearCookies.cgi:
  • http/tests/cookies/resources/cookies-test-pre.js:
  • http/tests/cookies/simple-cookies-max-age.html:
  • http/tests/websocket/tests/hybi/httponly-cookie.pl:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
3:45 PM Changeset in webkit [154424] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] Reenable some tests that pass now.

  • platform/win/TestExpectations: Renable some tests
3:34 PM Changeset in webkit [154423] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=120127
Remove JSObject::propertyIsEnumerable

Unreviewed typo fix

  • runtime/JSObject.h:
    • fix typo
3:32 PM Changeset in webkit [154422] by barraclough@apple.com
  • 33 edits in trunk/Source

​https://bugs.webkit.org/show_bug.cgi?id=120139
PropertyDescriptor argument to define methods should be const

Rubber stamped by Sam Weinig.

This should never be modified, and this way we can use rvalues.

Source/JavaScriptCore:

  • debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::defineOwnProperty):

  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

  • runtime/Arguments.h:
  • runtime/ClassInfo.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):

  • runtime/JSArray.h:
  • runtime/JSArrayBuffer.cpp:

(JSC::JSArrayBuffer::defineOwnProperty):

  • runtime/JSArrayBuffer.h:
  • runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::defineOwnProperty):

  • runtime/JSArrayBufferView.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::defineOwnProperty):

  • runtime/JSCell.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

  • runtime/JSFunction.h:
  • runtime/JSGenericTypedArrayView.h:
  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::::defineOwnProperty):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineOwnProperty):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putIndexedDescriptor):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::putDescriptor):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSProxy.cpp:

(JSC::JSProxy::defineOwnProperty):

  • runtime/JSProxy.h:
  • runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::defineOwnProperty):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::defineOwnProperty):

  • runtime/RegExpObject.h:
  • runtime/StringObject.cpp:

(JSC::StringObject::defineOwnProperty):

  • runtime/StringObject.h:
    • make PropertyDescriptor const

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::defineOwnProperty):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::defineOwnProperty):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • make PropertyDescriptor const
3:18 PM Changeset in webkit [154421] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit/win

<​https://webkit.org/b/120125> [Windows] Correct Tooltip Text

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::runOpenPanel): Make sure valid strings are passed to the File Open
API call.

  • WebView.cpp:

(WebView::setToolTip): Correct tooltip text (avoid passing address to temporary
return value.)

2:43 PM Changeset in webkit [154420] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Remove a deleted test from the global TestExpectations

It was freaking lint-test-expectations out.

2:40 PM Changeset in webkit [154419] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

REGRESSION: Crash under JITCompiler::link while loading Gmail
​https://bugs.webkit.org/show_bug.cgi?id=119872

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Apparently, unsigned + signed = unsigned. Work around it with a cast.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/dfg-switch-imm-negative-expected.txt: Added.
  • fast/js/dfg-switch-imm-negative.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-switch-imm-negative.js: Added.

(foo):

2:36 PM Changeset in webkit [154418] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebCore

<​https://webkit.org/b/120123> [BlackBerry] Incorrect origin of indexOfTile in LayerTiler can cause unnecessary texture jobs and waste memory

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-08-21
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

JIRA 481356
The origin of indexOfTile(origin) is incorrect in these two places. For
example, if the maxXMaxYCorner of the rect is (768, 768), there can be
three other redundant indexOfTile (0, 1), (1, 0), (1, 1) which can cause
unnecessary texture jobs and waste memory.
The origin should be the top left of the bottom right pixel of a rect.

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::processTextureJob):

2:32 PM Changeset in webkit [154417] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

<​https://webkit.org/b/116901> ASSERTION FAILED: !m_visibleDescendantStatusDirty on twitter

Reviewed by Beth Dakin.

In order to make decisions about compositing, the m_hasVisibleDescendant bit on RenderLayers
needs to be up-to-date when RenderLayerCompositor::computeCompositingRequirements is recursing
over the RenderLayer tree.

However, was possible for computeCompositingRequirements() to hit a layer whose m_visibleDescendantStatusDirty
bit was set; we only clear this bit from collectLayers() (when updating z-order lists), and from styleChanged()
which requires that style changed on the layer itself.

Fix by always calling updateDescendantDependentFlags() from computeCompositingRequirements().

Wasn't able to easily get a reduced testcase.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

2:24 PM Changeset in webkit [154416] by achristensen@apple.com
  • 24 edits in trunk

<​https://webkit.org/b/120137> Separating Win32 and Win64 builds.

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

Pass PlatformArchitecture as a command line parameter to bash scripts.

Use PlatformArchitecture from command line to determine which object directory to use (obj32 or obj64).

Source/WebCore:

  • WebCore.vcxproj/WebCoreGenerated.make:
  • WebCore.vcxproj/WebCoreGeneratedWinCairo.make:

Pass PlatformArchitecture as a command line parameter to bash scripts
and use PlatformArchitecture to determine which directory to delete
while cleaning (obj32 or obj64).

  • WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props:

Export PlatformArchitecture to be used by make and cmd scripts.

  • WebCore.vcxproj/build-generated-files.sh:

Use PlatformArchitecture from command line to determine which object directory to use (obj32 or obj64).

  • WebCore.vcxproj/copyForwardingHeaders.cmd:
  • WebCore.vcxproj/copyWebCoreResourceFiles.cmd:

Use PlatformArchitecture to determine which directory to copy to (obj32 or obj64).

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:

Use PlatformArchitecture to determine correct object directory (obj32 or obj64).

Source/WTF:

  • WTF.vcxproj/WTFGenerated.make:

Pass PlatformArchitecture as a command line parameter to bash scripts.

  • WTF.vcxproj/build-generated-files.sh:

Use PlatformArchitecture from command line to determine which object directory to use (obj32 or obj64).

WebKitLibraries:

  • win/tools/vsprops/common.props:

Export PlatformArchitecture to be used by make and cmd scripts.
Use PlatformArchitecture to determine correct build directory
(lib32/bin32/obj32 or lib64/bin64/obj64).

2:08 PM Changeset in webkit [154415] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

revalidateTiles and ensureTilesForRect can share a lot of code
​https://bugs.webkit.org/show_bug.cgi?id=119282

Missed the review comments, whoops.

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::prepopulateRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::ensureTilesForRect):

2:07 PM Changeset in webkit [154414] by akling@apple.com
  • 11 edits in trunk/Source/WebCore

<​https://webkit.org/b/120115> SVG elements always have custom style resolve callbacks.

Reviewed by Antti Koivisto.

Simplify SVGElement construction by making them opt in to custom style resolve callbacks
by default, and removing the ability to pass a custom ConstructionType to some subclass
constructors.

  • dom/Node.h:

Add HasCustomStyleResolveCallbacksFlag to the CreateSVGElement mask.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::SVGElement):

  • svg/SVGElement.h:
  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::SVGGElement):

  • svg/SVGGElement.h:
  • svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::SVGGraphicsElement):

  • svg/SVGGraphicsElement.h:
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::SVGImageElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::SVGStyledElement):

  • svg/SVGStyledElement.h:

Remove calls to setHasCustomStyleResolveCallbacks() in SVGElement and subclasses.
Also remove unnecessary ConstructionType argument from subclasses since nobody
overrides it and everyone just uses CreateSVGElement.

2:04 PM Changeset in webkit [154413] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

revalidateTiles and ensureTilesForRect can share a lot of code
​https://bugs.webkit.org/show_bug.cgi?id=119282

Reviewed by Simon Fraser.

No new tests, just a refactoring.

The bodies of ensureTilesForRect and revalidateTiles are nearly equivalent.

  • platform/graphics/ca/mac/TileController.h:

Add an enum, NewTileType, to note whether the tiles created by ensureTilesForRect will
be primary coverage tiles or secondary out-of-view tiles.

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::prepopulateRect):
Move the code to see if we already have the requisite tiles in the
primary coverage rect, as well as our call to updateTileCoverageMap,
out into prepopulateRect, to generalize ensureTilesForRect.

(WebCore::TileController::revalidateTiles):
Make use of ensureTilesForRect. The platformCALayerDidCreateTiles call will happen there, now.

(WebCore::TileController::ensureTilesForRect):
Make ensureTilesForRect return the rect that it created tiles for, and only put
tiles in a cohort if we're creating secondary tiles.

2:03 PM Changeset in webkit [154412] by timothy_horton@apple.com
  • 5 edits in trunk

isReplacementObscured is wrong when the indicator is clipped by an iframe
​https://bugs.webkit.org/show_bug.cgi?id=120031
<rdar://problem/14606819>

Reviewed by Simon Fraser.

Hit-test for plugin obscurity in the root document. To do this, we also need
to convert the indicator rectangle into root view coordinates before
hit testing its edges.

This resolves the case where an iframe which clips its content was reporting
the indicator as not obscured, despite the fact that it was obscured from the
point of view of the user.

Updated test plugins/unavailable-plugin-indicator-obscurity.html

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::isReplacementObscured):

Update the unavailable plugin indicator test to also ensure that plugins are
correctly known to be obscured when contained within and clipped by an <iframe>.

  • plugins/unavailable-plugin-indicator-obscurity-expected.txt:
  • plugins/unavailable-plugin-indicator-obscurity.html:
2:00 PM Changeset in webkit [154411] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

<​https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-08-21
Reviewed by Benjamin Poulain.

WTFString moved the is8bit bit by one in r152201.

  • lldb/lldb_webkit.py:

(WTFStringImplProvider.is_8bit):

1:58 PM Changeset in webkit [154410] by ap@apple.com
  • 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=111650
REGRESSION (r143931): set-cookie-on-redirect.html still breaking subsequent tests

Reviewed by Brady Eidson.

Work around <rdar://problem/10080130> by making the cookie persistent, session
cookies are deleted in a way that confuses some code paths in CFNetwork.

I'll unskip tests later, with another cookie reliability fix.

  • http/tests/cookies/resources/set-cookie-on-redirect.php:
1:54 PM Changeset in webkit [154409] by akling@apple.com
  • 12 edits in trunk/Source

<​https://webkit.org/b/120132> Frame::navigationScheduler() should return a reference.

Reviewed by Anders Carlzon.

Frame::m_navigationScheduler is an inline member, not a pointer.

1:53 PM Changeset in webkit [154408] by fpizlo@apple.com
  • 13 edits
    9 adds in trunk

Assertion failure in JSC::SlotVisitor::copyLater when marking JSDataView
​https://bugs.webkit.org/show_bug.cgi?id=120099

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

JSDataView should not store the ArrayBuffer* in the butterfly indexing header, since
JSDataView may have ordinary JS indexed properties.

  • runtime/ClassInfo.h:
  • runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
(JSC::JSArrayBufferView::finishCreation):

  • runtime/JSArrayBufferView.h:

(JSC::hasArrayBuffer):

  • runtime/JSArrayBufferViewInlines.h:

(JSC::JSArrayBufferView::buffer):
(JSC::JSArrayBufferView::neuter):
(JSC::JSArrayBufferView::byteOffset):

  • runtime/JSCell.cpp:

(JSC::JSCell::slowDownAndWasteMemory):

  • runtime/JSCell.h:
  • runtime/JSDataView.cpp:

(JSC::JSDataView::JSDataView):
(JSC::JSDataView::create):
(JSC::JSDataView::slowDownAndWasteMemory):

  • runtime/JSDataView.h:

(JSC::JSDataView::buffer):

  • runtime/JSGenericTypedArrayView.h:
  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::::visitChildren):
(JSC::::slowDownAndWasteMemory):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/regress/ArrayBuffer-DataView-alloc-large-long-lived-expected.txt: Added.
  • fast/js/regress/ArrayBuffer-DataView-alloc-large-long-lived.html: Added.
  • fast/js/regress/ArrayBuffer-DataView-alloc-long-lived-expected.txt: Added.
  • fast/js/regress/ArrayBuffer-DataView-alloc-long-lived.html: Added.
  • fast/js/regress/DataView-custom-properties-expected.txt: Added.
  • fast/js/regress/DataView-custom-properties.html: Added.
  • fast/js/regress/script-tests/ArrayBuffer-DataView-alloc-large-long-lived.js: Added.
  • fast/js/regress/script-tests/ArrayBuffer-DataView-alloc-long-lived.js: Added.
  • fast/js/regress/script-tests/DataView-custom-properties.js: Added.
  • platform/mac/TestExpectations:
1:31 PM Changeset in webkit [154407] by mhahnenberg@apple.com
  • 3 edits
    3 adds in trunk

Remove incorrect ASSERT from CopyVisitor::visitItem

Rubber stamped by Filip Pizlo.

Source/JavaScriptCore:

  • heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::visitItem):

LayoutTests:

Added a new test that triggered the old ASSERT. It's a useful test to have because we create
TypedArrays with custom properties.

  • fast/js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented-expected.txt: Added.
  • fast/js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.html: Added.
  • fast/js/regress/script-tests/ArrayBuffer-Int8Array-alloc-large-long-lived-fragmented.js: Added.
1:30 PM Changeset in webkit [154406] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Revert ​http://trac.webkit.org/changeset/154022, as it failed to update
a variety of scripts that depended on the old format.

See ​https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.

  • Scripts/prepare-ChangeLog:

(main):
(generateNewChangeLogs):

12:51 PM Changeset in webkit [154405] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=120127
Remove JSObject::propertyIsEnumerable

Reviewed by Sam Weinig.

This method is just a wart - it contains unnecessary const-casting, function call overhead, and LOC.

  • runtime/JSObject.cpp:
  • runtime/JSObject.h:
    • remove propertyIsEnumerable
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncPropertyIsEnumerable):

  • Move implementation here using getOwnPropertyDescriptor directly.
12:50 PM Changeset in webkit [154404] by timothy_horton@apple.com
  • 6 edits
    2 deletes in trunk

REGRESSION(r154399): broke Mac ML debug WK1 tests > 50 crashes (Requested by thorton on #webkit).
​https://bugs.webkit.org/show_bug.cgi?id=120129

Rolling out ​http://trac.webkit.org/changeset/154399.

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

  • rendering/RenderBox.h:
  • fast/block/margin-collapse/self-collapsing-block-with-float-descendant-expected.html: Removed.
  • fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html: Removed.
12:43 PM Changeset in webkit [154403] by fpizlo@apple.com
  • 31 edits
    9 adds in trunk

DFG should inline new typedArray()
​https://bugs.webkit.org/show_bug.cgi?id=120022

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Adds inlining of typed array allocations in the DFG. Any operation of the
form:

new foo(blah)


or:

foo(blah)


where 'foo' is a typed array constructor and 'blah' is exactly one argument,
is turned into the NewTypedArray intrinsic. Later, of child1 (i.e. 'blah')
is predicted integer, we generate inline code for an allocation. Otherwise
it turns into a call to an operation that behaves like the constructor would
if it was passed one argument (i.e. it may wrap a buffer or it may create a
copy or another array, or it may allocate an array of that length).

  • bytecode/SpeculatedType.cpp:

(JSC::speculationFromTypedArrayType):
(JSC::speculationFromClassInfo):

  • bytecode/SpeculatedType.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasTypedArrayType):
(JSC::DFG::Node::typedArrayType):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:

(JSC::DFG::newTypedArrayWithSize):
(JSC::DFG::newTypedArrayWithOneArgument):

  • dfg/DFGOperations.h:

(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_object):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_new_object):

  • runtime/JSArray.h:

(JSC::JSArray::allocationSize):

  • runtime/JSArrayBufferView.h:

(JSC::JSArrayBufferView::allocationSize):

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayView):

  • runtime/JSObject.h:

(JSC::JSFinalObject::allocationSize):

  • runtime/TypedArrayType.cpp:

(JSC::constructorClassInfoForType):

  • runtime/TypedArrayType.h:

(JSC::indexToTypedArrayType):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/regress/Float64Array-alloc-long-lived-expected.txt: Added.
  • fast/js/regress/Float64Array-alloc-long-lived.html: Added.
  • fast/js/regress/Int16Array-alloc-long-lived-expected.txt: Added.
  • fast/js/regress/Int16Array-alloc-long-lived.html: Added.
  • fast/js/regress/Int8Array-alloc-long-lived-expected.txt: Added.
  • fast/js/regress/Int8Array-alloc-long-lived.html: Added.
  • fast/js/regress/script-tests/Float64Array-alloc-long-lived.js: Added.
  • fast/js/regress/script-tests/Int16Array-alloc-long-lived.js: Added.
  • fast/js/regress/script-tests/Int32Array-alloc-long-lived.js:
  • fast/js/regress/script-tests/Int8Array-alloc-long-lived.js: Added.
12:02 PM Changeset in webkit [154402] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

<​https://webkit.org/b/120099> Assertion failure in JSC::SlotVisitor::copyLater when marking DataView

Mark fast/canvas/webgl/array-message-passing.html as crashing on debug, for now.

  • platform/mac/TestExpectations:
11:49 AM Changeset in webkit [154401] by akling@apple.com
  • 18 edits in trunk/Source

<​https://webkit.org/b/120118> Frame::animation() should return a reference.

Reviewed by Anders Carlsson.

Frame::m_animationController is never null.
Also changed RenderObject::animation() to return a reference since it's just a wrapper
around RenderObject::frame()->animation() with no null checking of frame().

11:04 AM Changeset in webkit [154400] by Simon Fraser
  • 9 edits
    2 adds in trunk

Allow opacity to apply to custom scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=120104

Source/WebCore:

Reviewed by David Hyatt.

Opacity was ignored custom scrollbar pseudoelements because custom scrollbar
renderers never create layers, and opacity is normally handled by the RenderLayer code.

Fix by having RenderScrollbarTheme and RenderScrollbarPart do the transparency
layers necessary for opacity. RenderScrollbarPart handles opacity for individual
parts.

Because ScrollbarThemeComposite::paint() renders the parts on after another (with
no nesting), opacity handling for the entire scrollbar needs special-casing.
This is done by willPaintScrollbar()/didPaintScrollbar() on the theme.
RenderScrollbarTheme consults the opacity the scrollbar (which we get from
the ScrollbarBGPart renderer) to decide whether to set up a transparency layer.

Test: scrollbars/scrollbar-parts-opacity.html

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paint):

  • platform/ScrollbarThemeComposite.h:

(WebCore::ScrollbarThemeComposite::willPaintScrollbar):
(WebCore::ScrollbarThemeComposite::didPaintScrollbar):

  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::opacity):

  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::paintIntoRect):

  • rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::willPaintScrollbar):
(WebCore::RenderScrollbarTheme::didPaintScrollbar):

  • rendering/RenderScrollbarTheme.h:

LayoutTests:

Reviewed by David Hyatt.

Ref test for custom scrollbars with opacity on the bar itself,
and on the thumb.

  • scrollbars/scrollbar-parts-opacity-expected.html: Added.
  • scrollbars/scrollbar-parts-opacity.html: Added.
11:03 AM Changeset in webkit [154399] by robert@webkit.org
  • 6 edits
    2 adds in trunk

REGRESSION(r127163): Respect clearance set on ancestors when placing floats
​https://bugs.webkit.org/show_bug.cgi?id=119979

Reviewed by David Hyatt.

Source/WebCore:

If a float has a self-collapsing ancestor with clearance then it needs to respect
that clearance when placing itself on the line.

Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::marginOffsetForSelfCollapsingBlock):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

  • rendering/RenderBox.h:

(WebCore::RenderBox::previousInFlowSiblingBox):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-float-descendant-expected.html: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html: Added.
10:36 AM Changeset in webkit [154398] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.

  • WinLauncher/WinLauncher.cpp:

(setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.

10:33 AM Changeset in webkit [154397] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r154378. <rdar://problem/14765691>

10:25 AM Changeset in webkit [154396] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r145458?): WebProcess doesn't respect UI process localization
​https://bugs.webkit.org/show_bug.cgi?id=120096

Reviewed by Darin Adler.

We used to get into a situation where CFBundle thought that we had no good localization,
and used one passed as default. This is never the case with mixed localizations,
so default is just ignored now.

I think that the previous behavior was a bit of a hack. As WebProcess is not localized,
it's more honest to say that we want mixed localizations, and force the language
to match UI process localization.

  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h: (WebKit::ChildProcessMain): Don't set default localization, it's not taken into consideration unless all other attempts to compute bundle localization fail.
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::createProcess): Pass UI process localization as -AppleLanguages argument, so that Core Foundation uses that instead of actual user languages. We want to match UI process localization.
10:19 AM Changeset in webkit [154395] by Brent Fulgham
  • 5 edits
    5 adds in trunk/Source

../WebInspectorUI: <​http://webkit.org/b/120098> [Windows] Enable the New Web Inspector

Reviewed by Brian Weinstein.

Add a new project to copy files to the appropriate spots in the
Windows port.

  • WebInspectorUI.vcxproj: Added.
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Added.
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Added.
  • WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Added.
  • WebInspectorUI.vcxproj/WebInspectorUIPreBuild.cmd: Added.

../WebKit: <​https://webkit.org/b/120098> [Windows] Enable the new Web Inspector

Reviewed by Brian Weinstein.

  • WebKit.vcxproj/WebKit.sln: Add reference to the new WebInspectorUI

project so that it will be included in new distributions.

../WebKit/win: <​https://webkit.org/b/120098> [Windows] Enable the New Web Inspector

Reviewed by Brian Weinstein.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend): Use the new inspector
if present in the WebKit distribution.
(WebInspectorFrontendClient::localizedStringsURL): Use the new
Web Inspector's localized strings (if present).

10:16 AM Changeset in webkit [154394] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] Unreviewed gardening. One more CSS_IMAGE_SET test can be activated.

  • platform/win/TestExpectations: We can reactivate cssom/cssvalue-comparison.html
10:15 AM Changeset in webkit [154393] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

<​https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp

Reviewed by Andreas Kling.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
(WTR::activateFonts): Ditto.

9:58 AM Changeset in webkit [154392] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

<​https://webkit.org/b/120113> Enable CSS_IMAGE_SET

Reviewed by Anders Carlsson.

  • platform/win/TestExpectations: Turn on two CSS_IMAGE_SET-based tests that

now pass on Windows.

9:56 AM Changeset in webkit [154391] by Brent Fulgham
  • 5 edits in trunk/Source/WebCore

<​https://webkit.org/b/120113> [Windows] Enable CSS_IMAGE_SET

Reviewed by Anders Carlsson.

We can now activate:
fast/css/image-set-parsing.html
fast/css/image-set-parsing-invalid.html

  • WebCore.vcxproj/WebCore.vcxproj: Add missing image set implementation files.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • css/CSSAllInOne.cpp: Add missing CSSImageSetValue.cpp
  • rendering/style/StyleAllInOne.cpp: Add missing StyeCachedImageSet.cpp
9:54 AM Changeset in webkit [154390] by Brent Fulgham
  • 3 edits in trunk/WebKitLibraries

<​https://webkit.org/b/120113> [Windows] Enable CSS_IMAGE_SET

Reviewed by Anders Carlsson.

  • win/tools/vsprops/FeatureDefines.props: Enable CSS_IMAGE_SET feature.
  • win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
9:45 AM Changeset in webkit [154389] by robert@webkit.org
  • 3 edits in trunk/Source/WebCore

In RenderTableCell::paintCollapsedBorders() check surrounding cells using physical rather than logical direction
​https://bugs.webkit.org/show_bug.cgi?id=120074

Reviewed by David Hyatt.

No new tests, covered by existing tests.

The functions cellAbove(), cellBelow() etc. check the logical rather than the physical direction but they're being
used to decide the painting of the physical borders of the cell. As we paint all four sides of every cell, and
the borders of adjoining cells twice over, this has no impact on painting currently but making the check consistent
in its treatment of physical and logical direction will help with webkit.org/b/119759 and make the code less confusing
to the next guy.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::cellAtLeft):
(WebCore::RenderTableCell::cellAtRight):
(WebCore::RenderTableCell::cellAtTop):
(WebCore::RenderTableCell::cellAtBottom):
(WebCore::RenderTableCell::paintCollapsedBorders):

  • rendering/RenderTableCell.h:
9:32 AM Changeset in webkit [154388] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

<​https://webkit.org/b/120106> Fix V_DFGOperation_EJPP signature in DFG.

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-08-21
Reviewed by Geoffrey Garen.

  • dfg/DFGOperations.h:
9:11 AM Changeset in webkit [154387] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

[GTK] Suppress irrelevant or known leaks for Valgrind
​https://bugs.webkit.org/show_bug.cgi?id=119448

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-08-21
Reviewed by Martin Robinson.

Add a suppressions file to suppress known leaks for Valgrind.
Valgrind also takes longer when using suppressions and
times out unless the driver timeout is increased.

  • Scripts/valgrind/suppressions.txt: Added.
  • Scripts/webkitpy/port/gtk.py:

(GtkPort.driver_stop_timeout):
(GtkPort.setup_environ_for_server):

9:00 AM Changeset in webkit [154386] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

<​https://webkit.org/b/120109> [curl] only include WebCoreBundleWin on Windows

Patch by Róbert Sipka <​sipka@inf.u-szeged.hu> on 2013-08-21
Reviewed by Brent Fulgham.

The WebCoreBundleWin is a windows specific file, it is only needed on Windows.

  • platform/network/curl/ResourceHandleManager.cpp:
7:23 AM Changeset in webkit [154385] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Remove unused code path in PluginView
​https://bugs.webkit.org/show_bug.cgi?id=113173

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-08-21
Reviewed by Anders Carlsson.

m_platformLayer in PluginView has been removed in r121710, but there are
still some leftover code path related to m_platformLayer. This patch
removes unused code path.

No new tests, removing unused code paths.

  • plugins/PluginView.h:

(PluginView):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):

6:43 AM Changeset in webkit [154384] by allan.jensen@digia.com
  • 7 edits
    3 adds in trunk

Font’s fast code path doesn’t handle partial runs correctly when kerning or ligatures are enabled
​https://bugs.webkit.org/show_bug.cgi?id=100050

Reviewed by Antti Koivisto.

Source/WebCore:

Always let WidthIterator iterate over an entire TextRun to avoid problems
with pixel rounding or shaping on partial runs.

This fix is necessary for Qt because the complex font-path can not disable
shaping, leading to the complex path painting slighly different from the
fast path, which messes up selection painting.

No change in functionality, no new tests.

  • platform/graphics/Font.cpp:

(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):

  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::add):
(GlyphBuffer):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):

  • platform/graphics/WidthIterator.h:

(WidthIterator): Removed now unused advanceOneCharacter method.

LayoutTests:

  • fast/text/resources/PTS55F-webfont.ttf: Added.
  • fast/text/partial-textruns-expected.html: Added.
  • fast/text/partial-textruns.html: Added.
5:53 AM Changeset in webkit [154383] by tonikitoo@webkit.org
  • 4 edits
    2 adds in trunk

Harden RenderBox::canBeScrolledAndHasScrollableArea logic ​https://bugs.webkit.org/show_bug.cgi?id=104373

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​a1.gomes@sisa.samsung.com>

Source/WebCore:

Previously if a say div has a overflown content on 'y' but is
styled as "overflow-x: auto; overflow-y: hidden", RenderBox::canBeProgramaticallyScrolled
would still return true. It interfers, among other things, with the way
autoscroll works.

Patch fixes it by adding two helper methods to RenderBox class in order to verify a box'
scrollability in a given axis (x or y); They are used when checking if a given box is in
fact programatically scrollable.

Test: fast/events/autoscroll-overflow-hidden-longhands.html

WebKit autoscroll behavior now matches Firefox and Opera12 (pre-blink)
in that sense.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::canBeProgramaticallyScrolled):

  • rendering/RenderBox.h:

(WebCore::RenderBox::hasScrollableOverflowX):
(WebCore::RenderBox::hasScrollableOverflowY):

LayoutTests:

Patch adds a test to ensure autoscrolling only happens on a given
axis if it is scrollable in that direction, according to its style.

  • fast/events/autoscroll-overflow-hidden-longhands-expected.txt: Added.
  • fast/events/autoscroll-overflow-hidden-longhands.html: Added.
5:52 AM Changeset in webkit [154382] by tonikitoo@webkit.org
  • 3 edits
    2 adds in trunk

Text dragging can scroll overflow:hidden boxes ​https://bugs.webkit.org/show_bug.cgi?id=119760

Reviewed by Darin Adler.
Patch by Antonio Gomes <​a1.gomes@sisa.samsung.com>

Source/WebCore:

Consider the case of the following HTML:
<div style="overflow:hidden; width: 100px; height: 100px" >

<input id="input" type="text" size=10 value="any text here!"/>
<button style="position:relative; top: 100px; left: 100px"/>

</div>

If ones starts a text selection by dragging the mouse from within the input
field, and continues to drag beyong the outer div boundary, the latter will
be scrolled no matter its overflow:hidden style.
That happens because when the autoscroll has started, it gets propagated up
to the current layer's parent layer, instead of the to current layer's enclosing
scrollable layer.

Patch fixes the issue by hardening the way scrolling is
propagated upwards when autoscroll is being performed.

RenderLayer::enclosingScrollableLayer method also got rewritten
in terms of RenderLayer tree traversing, instead of RenderObject tree.
The rewrite adds support for cross frame upwards traversal.

Test: fast/events/autoscroll-upwards-propagation.html

  • rendering/RenderLayer.cpp:

(WebCore::parentLayerCrossFrame):
(WebCore::RenderLayer::enclosingScrollableLayer):
(WebCore::RenderLayer::scrollRectToVisible):

LayoutTests:

  • fast/events/autoscroll-upwards-propagation-expected.txt: Added.
  • fast/events/autoscroll-upwards-propagation.html: Added.
2:24 AM Changeset in webkit [154381] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WTF

Disable maybe-uninitialized warning in GCC 4.8
​https://bugs.webkit.org/show_bug.cgi?id=119835

Reviewed by Anders Carlsson.

Disable the maybe-uninitialized warning.

  • wtf/Compiler.h:
12:03 AM Changeset in webkit [154380] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit/gtk

<​https://webkit.org/b/119836> [GTK] ChromeClient::paint is susceptible to system time changes

Reviewed by Martin Robinson.

Instead of using WTF::currentTime() as the value of the last display occurrence,
WTF::monotonicallyIncreasingTime() should be used. The latter is not affected by
the changes is the system's time, which can cause a halt in the display updating.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::paint):

Note: See TracTimeline for information about the timeline view.