Context Navigation

← Previous Period
Next Period →

Timeline

Aug 25, 2013:

11:20 PM Changeset in webkit [154587] by ryuan.choi@samsung.com

2 edits in trunk/Tools

[EFL] EWebLauncher is executed as full screen with device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=120282

Reviewed by Gyuyoung Kim.

EWebLauncher/main.c:

Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.

11:05 PM Changeset in webkit [154586] by rniwa@webkit.org

4 edits in trunk/Source/WebCore

JSHTMLFormElement::canGetItemsForName needlessly allocates a Vector
https://bugs.webkit.org/show_bug.cgi?id=120277

Reviewed by Sam Weinig.

Added HTMLFormElement::hasNamedElement and used it in JSHTMLFormElement::canGetItemsForName.

This required fixing a bug in HTMLFormElement::getNamedElements that the first call to getNamedElements
after replacing an element A with another element B of the same name caused it to erroneously append A
to namedItems via the aliases mapping. Because getNamedElements used to be always called in pairs, this
wrong behavior was never visible to the Web. Fixed the bug by not adding the old element to namedItem
when namedItem's size is 1.

Also renamed m_elementAliases to m_pastNamesMap along with related member functions.

No new tests are added since there should be no Web exposed behavioral change.

bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::canGetItemsForName):

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elementFromPastNamesMap):
(WebCore::HTMLFormElement::addElementToPastNamesMap):
(WebCore::HTMLFormElement::hasNamedElement):
(WebCore::HTMLFormElement::getNamedElements):

html/HTMLFormElement.h:

7:21 PM Changeset in webkit [154585] by akling@apple.com

3 edits in trunk/Source/WebCore

RenderLayerBacking::renderer() should return a reference.
<https://webkit.org/b/120280>

Reviewed by Anders Carlsson.

It's just a forwarding call to RenderLayer::renderer() which already returns a reference.

7:08 PM Changeset in webkit [154584] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebCore

Add toSVGMissingGlyphElement(), and use it.
https://bugs.webkit.org/show_bug.cgi?id=120197

Reviewed by Andreas Kling.

As a step to clean-up static_cast<SVGXXX>, toSVGMissingGlyphElement() is added to clean-up
static_cast<SVGMissingGlyphElement*>.

svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::firstMissingGlyphElement):
(WebCore::SVGFontElement::ensureGlyphCache):

svg/SVGMissingGlyphElement.h:

(WebCore::toSVGMissingGlyphElement):

6:02 PM Changeset in webkit [154583] by akling@apple.com

23 edits in trunk/Source

RenderLayer::renderer() should return a reference.
<https://webkit.org/b/120276>

Reviewed by Anders Carlsson.

RenderLayer is always created with a renderer, so make renderer() (and m_renderer) references.
Nuked an assortment of useless null checks.

2:43 PM Changeset in webkit [154582] by commit-queue@webkit.org

8 edits
19 adds
13 deletes in trunk/LayoutTests

Improve srcset's layout tests
https://bugs.webkit.org/show_bug.cgi?id=120274

Moved srcset's tests to use js-test-pre, and output text with clear PASS/FAILED statements.
Added expected.txt files to the test directory, since there shouldn't be any platform variance in the results.
For some of the tests, added an equivalent 1x/2x test, to make sure the feature behaves on both DPRs.
Added preload tests on the "change-dynamically" tests, to make sure the 'src' resource is not loaded when it shouldn't.

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-08-25
Reviewed by Andreas Kling.

fast/hidpi/image-srcset-change-dynamically-from-js-1x-expected.txt: Added.
fast/hidpi/image-srcset-change-dynamically-from-js-1x.html: Added.
fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt: Added.
fast/hidpi/image-srcset-change-dynamically-from-js-2x.html: Added.
fast/hidpi/image-srcset-change-dynamically-from-js.html: Removed.
fast/hidpi/image-srcset-data-src-expected.txt: Added.
fast/hidpi/image-srcset-data-src.html:
fast/hidpi/image-srcset-data-srcset-expected.txt: Added.
fast/hidpi/image-srcset-data-srcset.html:
fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.txt: Added.
fast/hidpi/image-srcset-invalid-inputs-correct-src.html:
fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt: Added.
fast/hidpi/image-srcset-invalid-inputs-except-one.html:
fast/hidpi/image-srcset-remove-dynamically-from-js-expected.txt: Added.
fast/hidpi/image-srcset-remove-dynamically-from-js.html:
fast/hidpi/image-srcset-same-alternative-for-both-attributes-expected.txt: Added.
fast/hidpi/image-srcset-same-alternative-for-both-attributes.html:
fast/hidpi/image-srcset-simple-1x-expected.txt: Added.
fast/hidpi/image-srcset-simple-1x.html: Added.
fast/hidpi/image-srcset-simple-2x-expected.txt: Added.
fast/hidpi/image-srcset-simple-2x.html: Added.
fast/hidpi/image-srcset-simple.html: Removed.
fast/hidpi/image-srcset-src-selection-1x-expected.txt: Added.
fast/hidpi/image-srcset-src-selection-1x.html: Added.
fast/hidpi/image-srcset-src-selection-2x-expected.txt: Added.
fast/hidpi/image-srcset-src-selection-2x.html: Added.
fast/hidpi/image-srcset-src-selection.html: Removed.
fast/hidpi/image-srcset-viewport-modifiers-expected.txt: Added.
fast/hidpi/image-srcset-viewport-modifiers.html:
platform/mac/fast/hidpi/image-srcset-change-dynamically-from-js-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-data-src-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-data-srcset-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-remove-dynamically-from-js-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-same-alternative-for-both-attributes-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-simple-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-src-selection-expected.txt: Removed.
platform/mac/fast/hidpi/image-srcset-viewport-modifiers-expected.txt: Removed.

2:30 PM Changeset in webkit [154581] by Antti Koivisto

13 edits
2 adds in trunk/Source/WebCore

Element child and descendant iterators
https://bugs.webkit.org/show_bug.cgi?id=120248

Reviewed by Sam Weinig and Andreas Kling.

Add iterators for Element children and descendants.

To iterate over element children:

#include "ChildIterator.h"

for (auto it = elementChildren(this).begin(), end = elementChildren(this).end(); it != end; ++it) {

Element& element = *it;
...

for (auto it = childrenOfType<HTMLAreaElement>(this).begin(), end = childrenOfType<HTMLAreaElement>(this).end(); it != end; ++it) {

HTMLAreaElement& area = *it;
...

To iteratate over element descendants in pre-order:

#include "DescendantIterator.h"

for (auto it = elementDescendants(this).begin(), end = elementDescendants(this).end(); it != end; ++it) {

Element& element = *it;
...

for (auto it = descendantsOfType<HTMLAreaElement>(this).begin(), end = descendantsOfType<HTMLAreaElement>(this).end(); it != end; ++it) {

HTMLAreaElement& area = *it;
...

The iterators assert against DOM mutations and event dispatch while iterating in debug builds.

They are compatible with C++11 range-based for loops. In the future we can use

for (auto& element : elementChildren(this))

...

etc.

The patch all uses the new iterators in a few places.

WebCore.xcodeproj/project.pbxproj:
accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
(WebCore::siblingWithAriaRole):

accessibility/AccessibilityRenderObject.cpp:
accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

dom/ChildIterator.h: Added.

(WebCore::ChildIterator::operator*):
(WebCore::ChildIterator::operator->):
(WebCore::::ChildIterator):
(WebCore::::operator):
(WebCore::=):
(WebCore::::ChildIteratorAdapter):
(WebCore::::begin):
(WebCore::::end):
(WebCore::elementChildren):
(WebCore::childrenOfType):

dom/DescendantIterator.h: Added.

(WebCore::DescendantIterator::operator*):
(WebCore::DescendantIterator::operator->):
(WebCore::::DescendantIterator):
(WebCore::::operator):
(WebCore::=):
(WebCore::::DescendantIteratorAdapter):
(WebCore::::begin):
(WebCore::::end):
(WebCore::elementDescendants):
(WebCore::descendantsOfType):

dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::childrenChanged):
(WebCore::Document::attach):
(WebCore::Document::detach):

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):

editing/markup.cpp:

(WebCore::completeURLs):

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::mapMouseEvent):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::textTrackModeChanged):

2:22 PM Changeset in webkit [154580] by akling@apple.com

87 edits in trunk/Source/WebCore

RenderObject::document() should return a reference.
<https://webkit.org/b/120272>

Reviewed by Antti Koivisto.

There's always a Document. We were allocated in someone's arena, after all.
Various null checks and assertions neutralized.

12:43 PM Changeset in webkit [154579] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r154578): Return Vector<String>() from Pasteboard::types() for iOS

platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::types): Return Vector<String>() instead of
ListHashSet<String>() after r154578.

10:24 AM Changeset in webkit [154578] by Darin Adler

12 edits in trunk/Source/WebCore

Make JavaScript binding for Clipboard::types more normal
https://bugs.webkit.org/show_bug.cgi?id=120271

Reviewed by Anders Carlsson.

bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types): Make a simple custom binding. Only needed because
there is a special value, null, this can return.

dom/Clipboard.cpp:

(WebCore::Clipboard::types): Return Vector<String> instead of ListHashSet<String>.

dom/Clipboard.h: Ditto.
platform/Pasteboard.h: Ditto.
platform/blackberry/PasteboardBlackBerry.cpp: