⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 27, 2013:

9:35 PM Changeset in webkit [154722] by tonikitoo@webkit.org
  • 3 edits
    3 adds in trunk

Scrolling allowed when overflow:hidden (seen on Acid2)
​https://bugs.webkit.org/show_bug.cgi?id=22769

Reviewed by Darin Adler.
Patch by Antonio Gomes <​a1.gomes@sisa.samsung.com>

Source/WebCore:

Autoscroll, as well as other user-driven scroll actions,
has to respect the scrollability styled into the web page.
More specifically, if a html or body tags are styled with
overflow:hidden, autoscroll should not scroll the containing document.

In order to fix this, patch hardens RenderBox::canAutoscroll as
following: previously, ::canAutoscroll was relying solemnly in
::canBeScrolledAndHasScrollableArea to determine the scrollability
of #document node, which was unconditionally returned as 'true'.
Patch extends ::canAutoscroll to handle the #document case for
main and inner frames, and now it asks through ::isScrollable if
the corresponding document's FrameView is actually user-scrollable.

Note, that the patch change ::canAutoscroll to cover the non-mainFrame
now.

Test: fast/events/autoscroll-in-overflow-hidden-html.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::canAutoscroll):

LayoutTests:

Autoscroll'ing the mainframe's document is hard with the current
EventSender machinary. Because of that, patch adds an iframe's document test case.

  • fast/events/autoscroll-in-overflow-hidden-html.html: Added.
  • fast/events/resources/big-page-with-overflow-hidden-and-anchor-scroll.html: Added.
9:00 PM Changeset in webkit [154721] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebCore

Adding "explicit" keyword in forms related classes constructor
​https://bugs.webkit.org/show_bug.cgi?id=120366

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-08-27
Reviewed by Darin Adler.

Adding "explicit" keyword in constructors.

  • html/BaseButtonInputType.h:

(WebCore::BaseButtonInputType::BaseButtonInputType):

  • html/BaseCheckableInputType.h:

(WebCore::BaseCheckableInputType::BaseCheckableInputType):

  • html/BaseChooserOnlyDateAndTimeInputType.h:

(WebCore::BaseChooserOnlyDateAndTimeInputType::BaseChooserOnlyDateAndTimeInputType):

  • html/BaseClickableWithKeyInputType.h:

(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):

  • html/BaseTextInputType.h:

(WebCore::BaseTextInputType::BaseTextInputType):

  • html/ColorInputType.h:

(WebCore::ColorInputType::ColorInputType):

  • html/DateInputType.h:
  • html/DateTimeInputType.h:

(WebCore::DateTimeInputType::DateTimeInputType):

  • html/DateTimeLocalInputType.h:

(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):

  • html/EmailInputType.h:

(WebCore::EmailInputType::EmailInputType):

  • html/FileInputType.h:
  • html/HiddenInputType.h:

(WebCore::HiddenInputType::HiddenInputType):

  • html/ImageData.h:
  • html/ImageInputType.h:
  • html/InputType.h:

(WebCore::InputType::InputType):

  • html/MediaController.h:
  • html/MonthInputType.h:

(WebCore::MonthInputType::MonthInputType):

  • html/RadioInputType.h:

(WebCore::RadioInputType::RadioInputType):

  • html/RangeInputType.h:
  • html/ResetInputType.h:

(WebCore::ResetInputType::ResetInputType):

  • html/SearchInputType.h:
  • html/SubmitInputType.h:

(WebCore::SubmitInputType::SubmitInputType):

  • html/TelephoneInputType.h:

(WebCore::TelephoneInputType::TelephoneInputType):

  • html/TextFieldInputType.h:
  • html/TextInputType.h:

(WebCore::TextInputType::TextInputType):

  • html/TimeInputType.h:
  • html/URLInputType.h:

(WebCore::URLInputType::URLInputType):

  • html/ValidationMessage.h:
  • html/WeekInputType.h:

(WebCore::WeekInputType::WeekInputType):

8:43 PM Changeset in webkit [154720] by ap@apple.com
  • 5 edits in trunk/Tools

[WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
​https://bugs.webkit.org/show_bug.cgi?id=120379

Reviewed by Darin Adler.

All major platforms have implemented UI process eventSender support, keeping old
web process side code only adds confusion.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::EventSendingController):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/TestController.h:
8:10 PM Changeset in webkit [154719] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the indentation of SpaceSplitString
​https://bugs.webkit.org/show_bug.cgi?id=120390

Reviewed by Ryosuke Niwa.

  • dom/SpaceSplitString.h:

(WebCore::SpaceSplitStringData::contains):
(WebCore::SpaceSplitStringData::isUnique):
(WebCore::SpaceSplitStringData::size):
(WebCore::SpaceSplitStringData::operator[]):
(WebCore::SpaceSplitString::SpaceSplitString):
(WebCore::SpaceSplitString::operator!=):
(WebCore::SpaceSplitString::clear):
(WebCore::SpaceSplitString::contains):
(WebCore::SpaceSplitString::containsAll):
(WebCore::SpaceSplitString::size):
(WebCore::SpaceSplitString::isNull):
(WebCore::SpaceSplitString::operator[]):
(WebCore::SpaceSplitString::spaceSplitStringContainsValue):
(WebCore::SpaceSplitString::ensureUnique):

5:57 PM Changeset in webkit [154718] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

5:56 PM Changeset in webkit [154717] by Lucas Forschler
  • 1 copy in tags/Safari-537.65

New Tag.

5:38 PM Changeset in webkit [154716] by dino@apple.com
  • 2 edits in trunk/LayoutTests

svg/animations/svglengthlist-animation-3.html is flakey on Mac
​http://webkit.org/b/120387

Marking this as flakey.

  • platform/mac/TestExpectations:
5:09 PM Changeset in webkit [154715] by akling@apple.com
  • 20 edits in trunk/Source

Make it less awkward to check if a Frame is the main Frame.
<​https://webkit.org/b/120382>

Reviewed by Anders Carlsson.

Added Page::frameIsMainFrame(const Frame*) so code that wants to find out if a given
Frame is a Page's main frame doesn't have to do a manual pointer compare.

  • page/Page.h:

(WebCore::Page::frameIsMainFrame):

Added. Replaces (frame == &page->mainFrame()) idiom.

4:17 PM Changeset in webkit [154714] by commit-queue@webkit.org
  • 6 edits
    1 copy
    2 adds
    8 deletes in trunk

Improve multicol intrinsic width calculation
​https://bugs.webkit.org/show_bug.cgi?id=116677

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-08-27
Reviewed by David Hyatt.

Source/WebCore:

Test: fast/css-intrinsic-dimensions/multicol.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
(WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns):

  • rendering/RenderBlock.h:

LayoutTests:

  • css3/unicode-bidi-isolate-basic.html: The expectation seems to

be that the columns should be as many as necessary and narrow as
possible, and that the multicol container's width should be that
of one column. The previous CSS didn't really ask for this,
although that's how it happened to be rendered without this fix.

  • fast/css-intrinsic-dimensions/multicol-expected.txt: Added.
  • fast/css-intrinsic-dimensions/multicol.html: Added.
  • fast/multicol/positioned-with-constrained-height-expected.html: Copied from LayoutTests/fast/multicol/positioned-with-constrained-height.html.
  • fast/multicol/positioned-with-constrained-height.html: Turn into a reftest.
  • platform/efl/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
  • platform/efl/fast/multicol/positioned-with-constrained-height-expected.txt: Removed.
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt: Removed.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt: Removed.
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Removed.
4:09 PM Changeset in webkit [154713] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

feImage fails if referenced node contains radialGradient declaration
​https://bugs.webkit.org/show_bug.cgi?id=118735

Reviewed by Darin Adler.

Source/WebCore:

Only call parent's updateRelativeLengthsInformation for graphics elements.

Tests: svg/custom/feImage-pserver-with-percentage-expected.svg

svg/custom/feImage-pserver-with-percentage.svg

  • svg/SVGElement.cpp:

(WebCore::SVGElement::updateRelativeLengthsInformation):

LayoutTests:

Add testcase from bug with small adjustments.

  • svg/custom/feImage-pserver-with-percentage-expected.svg: Added.
  • svg/custom/feImage-pserver-with-percentage.svg: Added.
3:25 PM Changeset in webkit [154712] by Darin Adler
  • 2 edits in trunk/Source/WebCore

No need for generalPasteboard (aside from "global selection mode")
​https://bugs.webkit.org/show_bug.cgi?id=120367

Reviewed by Alexey Proskuryakov.

  • editing/Editor.cpp:

(WebCore::Editor::pasteAsPlainTextBypassingDHTML):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::paste):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::copyURL):
(WebCore::Editor::copyImage):
Use Pasteboard::createForCopyAndPaste rather than the single general pasteboard
for editing operations.

3:23 PM Changeset in webkit [154711] by Luciano Miguel Wolf
  • 2 edits in trunk/Source/WebKit2

100% cpu usage for "transition: opacity" animation
​https://bugs.webkit.org/show_bug.cgi?id=120012

Reviewed by Noam Rosenthal.

Schedule animation timer after scheduling a layer flush. This way it
won't overwrite animation timer with "0", thus avoiding 100% cpu usage.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):

2:56 PM Changeset in webkit [154710] by Chris Fleizach
  • 4 edits
    2 adds in trunk

<​https://webkit.org/b/120117> AX: <noscript> contents are exposed as static text

Reviewed by Tim Horton.

Source/WebCore:

If <noscript> is not being used (because there is script) then we need to ignore its contents for AX.

Test: accessibility/noscript-ignored.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addCanvasChildren):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):

LayoutTests:

  • accessibility/noscript-ignored-expected.txt: Added.
  • accessibility/noscript-ignored.html: Added.
2:38 PM Changeset in webkit [154709] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix build.

  • Plugins/Hosted/ProxyInstance.h:
  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):

2:26 PM Changeset in webkit [154708] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Stop using deleteAllValues in CClass
​https://bugs.webkit.org/show_bug.cgi?id=120376

Reviewed by Andreas Kling.

  • bridge/c/c_class.cpp:

(JSC::Bindings::CClass::CClass):
(JSC::Bindings::CClass::~CClass):
(JSC::Bindings::CClass::methodNamed):
(JSC::Bindings::CClass::fieldNamed):

  • bridge/c/c_class.h:
  • bridge/jsc/BridgeJSC.h:
1:49 PM Changeset in webkit [154707] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

Clean ClassList and DOMSettableTokenList
​https://bugs.webkit.org/show_bug.cgi?id=120344

Reviewed by Ryosuke Niwa.

This patch cleans ClassList and DOMSettableTokenList to make it simpler to update
SpaceSplitString:

  • Move the implementation of virtual functions to the cpp file.
  • Clean the #includes.
  • Make the implemented pure virtual methods final.
  • Make the element() accessor const.
  • html/ClassList.cpp:

(WebCore::ClassList::create):
(WebCore::ClassList::element):
(WebCore::ClassList::value):
(WebCore::ClassList::setValue):
(WebCore::ClassList::classNames):

  • html/ClassList.h:
  • html/DOMSettableTokenList.cpp:

(WebCore::DOMSettableTokenList::create):
(WebCore::DOMSettableTokenList::ref):
(WebCore::DOMSettableTokenList::deref):
(WebCore::DOMSettableTokenList::length):
(WebCore::DOMSettableTokenList::value):

  • html/DOMSettableTokenList.h:
  • html/DOMTokenList.h:

(WebCore::DOMTokenList::element):

1:47 PM Changeset in webkit [154706] by commit-queue@webkit.org
  • 31 edits in trunk/Source

Replace currentTime() with monotonicallyIncreasingTime() in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=119958

Patch by Arunprasad Rajkumar <​arurajku@cisco.com> on 2013-08-27
Reviewed by Alexey Proskuryakov.

WTF::currentTime() is prone to NTP and manual adjustments, so use
WTF::monotonicallyIncreasingTime() to measure elapsed time.

It is a continuation of r154201.

Source/WebCore:

  • history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::hasExpired):

  • html/parser/HTMLParserScheduler.h:

(WebCore::HTMLParserScheduler::checkForYieldBeforeToken):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::parse):
(WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setState):

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::incrementProgress):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::restoreParsedStyleSheet):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didDraw):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneLiveResourcesToSize):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::iconDatabaseSyncThread):
(WebCore::IconDatabase::syncThreadMainLoop):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::writeToDatabase):
(WebCore::IconDatabase::cleanupSyncThread):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::freezeAtTime):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimation::computeTotalRunningTime):
(WebCore::GraphicsLayerAnimation::resume):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::createImageForTimeInRect):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::suspendAnimations):

  • platform/graphics/ca/PlatformCALayer.h:

(WebCore::PlatformCALayer::currentTimeToMediaTime):

  • platform/graphics/ca/mac/LayerPool.mm:

(WebCore::LayerPool::addLayer):
(WebCore::LayerPool::decayedCapacity):
(WebCore::LayerPool::pruneTimerFired):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(mediaTimeToCurrentTime):

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::notifyAnimationsStarted):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::printTree):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

  • platform/graphics/texmap/TextureMapperFPSCounter.cpp:

(WebCore::TextureMapperFPSCounter::TextureMapperFPSCounter):
(WebCore::TextureMapperFPSCounter::updateFPSAndDisplay):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addAnimation):

  • platform/network/DNSResolveQueue.cpp:

(WebCore::DNSResolveQueue::isUsingProxy):

  • plugins/win/PluginMessageThrottlerWin.cpp:

(WebCore::PluginMessageThrottlerWin::appendMessage):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::didPaintBacking):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::animationProgress):
(WebCore::RenderProgress::updateAnimationState):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::elapsed):
(WebCore::SMILTimeContainer::begin):
(WebCore::SMILTimeContainer::pause):
(WebCore::SMILTimeContainer::resume):
(WebCore::SMILTimeContainer::setElapsed):

Source/WTF:

  • wtf/CurrentTime.h: Edited comment.
1:28 PM Changeset in webkit [154705] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-537-branch

Merged r154633. <rdar://problem/14836008>

12:41 PM Changeset in webkit [154704] by roger_fong@apple.com
  • 2 edits in trunk/Tools

NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
​https://bugs.webkit.org/show_bug.cgi?id=120370.

Reviewed by Brent Fulgham.

  • Scripts/webkitpy/port/win.py:

(WinPort.delete_sem_locks):
(WinPort.setup_test_run):

12:22 PM Changeset in webkit [154703] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger should have Continue to Here Context Menu
​https://bugs.webkit.org/show_bug.cgi?id=120189

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-08-27
Reviewed by Timothy Hatcher.

When paused in the debugger and presenting a Context Menu in the
gutter, include a "Continue to Here" option. This requires a
script/line/column location combination.

  • UserInterface/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.continueToLocation):

  • UserInterface/Resource.js:

(WebInspector.Resource.prototype.scriptForLocation):

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.continueToLocation):
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):

12:21 PM Changeset in webkit [154702] by robert@webkit.org
  • 10 edits
    2 adds in trunk

cell width / offsetTop incorrect
​https://bugs.webkit.org/show_bug.cgi?id=11582

Reviewed by David Hyatt.

Source/WebCore:

The offsetTop and offsetLeft of sections, rows and cells should include the table's border. There are separate
problems with the offset[Top|Left] of table sections and the offsetLeft of rows which are covered under bugs 119020
and 119021 respectively - here we stick to just fixing the inclusion of the border as it doesn't require rebaselining
a lot of tests.

Test: fast/table/offset-top-includes-border.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests:

  • fast/dom/Element/offsetTop-table-cell-expected.txt:
  • fast/dom/Element/offsetTop-table-cell.html:
  • fast/table/offset-top-includes-border-expected.txt: Added.
  • fast/table/offset-top-includes-border.html: Added.
  • platform/mac/editing/selection/5057506-2-expected.txt:
  • platform/mac/editing/selection/5057506-expected.txt:
  • platform/qt/editing/selection/5057506-2-expected.txt:
  • platform/qt/editing/selection/5057506-expected.txt:
11:32 AM Changeset in webkit [154701] by commit-queue@webkit.org
  • 17 edits in trunk/Source

[BlackBerry] Rotate device from landscape to portrait during youtube streaming will cause device screen flash with video list page
​https://bugs.webkit.org/show_bug.cgi?id=120364

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-08-27
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

Source/WebCore:

JIRA 461232
When rotating device from landscape mode to portrait mode, we updated
texture contents based on landscape mode front visibility and back
visibility on WebKit thread at the very beginning and the landscape mode
tiles wouldn't be able to cover the portrait mode screen which resulted
in the screen flash.
It's hard to compute front visibility information on WebKit thread because
it doesn't know where the layers will be on the screen. Therefore, the
front visibility won't be updated until the first time we draw textures
on compositing thread.
The patch traverses through LayerWebKitThread and LayerCompositingThread
and discards back visibility and front visibility respectively if there
is a pending orientation. In this way, we can pick up layerTilerPrefillRect
as visibleRect instead of the visibleRect from the stale visibilities
and add more tiles for uncovered screen when updating texture contents
on WebKit thread.
The patch also fixes a bug that we prune tiles based on the stale
m_requiredTextureSize in pruneTextures(). We should prune tiles based
on the updated pendingTextureSize instead.

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::discardFrontVisibility):

  • platform/graphics/blackberry/LayerCompositingThread.h:
  • platform/graphics/blackberry/LayerCompositingThreadClient.h:

(WebCore::LayerCompositingThreadClient::discardFrontVisibility):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::discardFrontVisibility):

  • platform/graphics/blackberry/LayerRenderer.h:
  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::discardFrontVisibility):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::discardBackVisibility):

  • platform/graphics/blackberry/LayerTiler.h:
  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::discardBackVisibility):

  • platform/graphics/blackberry/LayerWebKitThread.h:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::discardLayerVisibilities):
(BlackBerry::WebKit::WebPagePrivate::discardFrontVisibilityCompositingThread):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::discardFrontVisibility):

  • Api/WebPageCompositor_p.h:
  • Api/WebPage_p.h:
  • WebKitSupport/FrameLayers.cpp:

(BlackBerry::WebKit::FrameLayers::discardBackVisibility):

  • WebKitSupport/FrameLayers.h:
11:22 AM Changeset in webkit [154700] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Better mutation and event assertions for descendant iterators
​https://bugs.webkit.org/show_bug.cgi?id=120368

Reviewed by Andreas Kling.

Add mutation assertions to all functions.
Drop the no-event-dispatch assertion when the iterator reaches the end. This reduces need for iterator scoping
just to avoid assertions.

  • dom/ChildIterator.h:

(WebCore::::domTreeHasMutated):
(WebCore::::operator):
(WebCore::=):

  • dom/DescendantIterator.h:

(WebCore::::domTreeHasMutated):
(WebCore::::operator):
(WebCore::=):

  • dom/Document.cpp:

(WebCore::Document::childrenChanged):

Make idiomatic.

11:02 AM Changeset in webkit [154699] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebKit2

[WK2][Soup] Add WebFrameNetworkingContext::webFrameLoaderClient() after r154490
​https://bugs.webkit.org/show_bug.cgi?id=120353

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::webFrameLoaderClient):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
10:20 AM Changeset in webkit [154698] by reni@webkit.org
  • 3 edits
    2 adds in trunk

Missing null-check of parent renderer in WebCore::HTMLEmbedElement::rendererIsNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=120343

Reviewed by Darin Adler.

Source/WebCore:

Null-check the parent renderer of HTMLEmbedElement in WebCore::HTMLEmbedElement::rendererIsNeeded()
and early return.

Test: fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

LayoutTests:

Test for the handling of null parent renderer.

  • fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt: Added.
  • fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html: Added.
10:16 AM Changeset in webkit [154697] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

[GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
​https://bugs.webkit.org/show_bug.cgi?id=119883

Tools:

Implemented the notification listener for AccessibilityUIElement. The signal is generated
by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
callback function. The global callback function and callbacks for specific elements are
stored in a HashMap in AccessibilityCallbacksAtk.cpp.

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-08-27
Reviewed by Chris Fleizach.

  • DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
  • DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()

and removeAccessibilityNotificationListener()

  • DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:

(axObjectEventListener): Call JS callback for global notification or for a specific element
(disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
notification handler
(addAccessibilityNotificationHandler): Add notification listener to the list
(removeAccessibilityNotificationHandler): Remove notification listener from the list

  • DumpRenderTree/atk/AccessibilityControllerAtk.cpp:

(AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting

  • DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.

(AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
(AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
Remove handler from the list and disconnect callbacks
(AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
callback and connect callbacks to signals

  • DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.

(AccessibilityNotificationHandler::setPlatformElement): Set platform element
(AccessibilityNotificationHandler::platformElement): Get platform element
(AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::addNotificationListener): Create notification handler, set the
platform element and the notification callback
(AccessibilityUIElement::removeNotificationListener):

  • DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
  • GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h

LayoutTests:

Unskipped the checkbox notification test in a11y and added the expected results.

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-08-27
Reviewed by Chris Fleizach.

  • platform/gtk/TestExpectations: Unskipped the checkbox notification test in a11y.
  • platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
10:04 AM Changeset in webkit [154696] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.1.90

Tagging the WebKitGTK+ 2.1.90 release

9:44 AM Changeset in webkit [154695] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.1.90 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Add release notes.
9:02 AM Changeset in webkit [154694] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Correct method call for characteristic update.

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
[Windows] Correct method call (should have been "characteristicsChanged", not
"player()->characteristicChanged()"

8:55 AM Changeset in webkit [154693] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] some track language tags are not recognized
​https://bugs.webkit.org/show_bug.cgi?id=120335

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Revise implementation

to match logic in platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjc.mm

8:50 AM Changeset in webkit [154692] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Clumsily fix Gtk+ build. Not my proudest moment.

  • rendering/svg/RenderSVGResourceFilter.cpp:
8:45 AM Changeset in webkit [154691] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Qt build.

  • rendering/svg/RenderSVGResourceFilter.cpp:
8:31 AM Changeset in webkit [154690] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r154666 - [GTK] Volume slider shows incorrect track when muted
​https://bugs.webkit.org/show_bug.cgi?id=120253

Reviewed by Philippe Normand.

When painting the volume bar, consider that it could be muted even
then volume is different than zero.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
painted volume as 0 when media is muted.

8:29 AM Changeset in webkit [154689] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderView::availableLogicalHeight() should be self-contained.
<​https://webkit.org/b/120356>

Reviewed by Antti Koivisto.

Instead of checking isRenderView() in RenderBox::availableLogicalHeightUsing()
and doing an early return, do everything needed without leaving RenderView instead.
Document style never has min-/max-height so there's no need to apply constraints.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalHeightUsing):

  • rendering/RenderView.cpp:

(WebCore::RenderView::availableLogicalHeight):

8:26 AM Changeset in webkit [154688] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Simplify some more Settings access where we have a Frame in reach.
<​https://webkit.org/b/120256>

Reviewed by Darin Adler.

RenderObjects can always find Settings through the Frame.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

8:20 AM Changeset in webkit [154687] by kadam@inf.u-szeged.hu
  • 1 edit
    1 delete in trunk/LayoutTests

[Qt] Delete unnecessary empty directory.
Unreviewed gardening.

  • platform/qt-5.0-wk2/tables: Removed.
  • platform/qt-5.0-wk2/tables/layering: Removed.
  • platform/qt-5.0-wk2/tables/mozilla: Removed.
  • platform/qt-5.0-wk2/tables/mozilla/bugs: Removed.
  • platform/qt-5.0-wk2/tables/mozilla/collapsing_borders: Removed.
  • platform/qt-5.0-wk2/tables/mozilla/core: Removed.
  • platform/qt-5.0-wk2/tables/mozilla/dom: Removed.
  • platform/qt-5.0-wk2/tables/mozilla/marvin: Removed.
  • platform/qt-5.0-wk2/tables/mozilla/other: Removed.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures: Removed.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs: Removed.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/collapsing_borders: Removed.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core: Removed.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/dom: Removed.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin: Removed.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/other: Removed.
8:17 AM Changeset in webkit [154686] by akling@apple.com
  • 12 edits in trunk/Source/WebCore

RenderView::flowThreadController() should return a reference.
<​https://webkit.org/b/120363>

Reviewed by Antti Koivisto.

This function does lazy construction and always returns an object.

8:06 AM Changeset in webkit [154685] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

HTMLAppletElement: Use child iterator to walk <param> children.
<​https://webkit.org/b/120361>

Reviewed by Antti Koivisto.

Take Antti's fancy new child iterator for a quick spin.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::updateWidget):

8:04 AM Changeset in webkit [154684] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] Added new accessibility expectations after r154332
​https://bugs.webkit.org/show_bug.cgi?id=120359

Unreviewed EFL gardening.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-08-27

  • platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt: Added.
  • platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Added.
8:00 AM Changeset in webkit [154683] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

[gstreamer] Make sure gstreamer source element is thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115352

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-08-27
Reviewed by Philippe Normand.

Source/WebCore:

GStreamer source element may be created by any gstreamer element on any thread by calling
gst_element_make_from_uri with the URIs handled by the source element.
This patch makes sure the gstreamer source element is thread-safe to avoid issues with it
being created outside the main thread.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(removeTimeoutSources):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::~CachedResourceStreamingClient):
(CachedResourceStreamingClient::loadFailed):
(CachedResourceStreamingClient::setDefersLoading):
(CachedResourceStreamingClient::getOrCreateReadBuffer):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::notifyFinished):
(ResourceHandleStreamingClient::ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::loadFailed):
(ResourceHandleStreamingClient::setDefersLoading):
(ResourceHandleStreamingClient::getOrCreateReadBuffer):
(ResourceHandleStreamingClient::willSendRequest):
(ResourceHandleStreamingClient::didReceiveResponse):
(ResourceHandleStreamingClient::didReceiveData):
(ResourceHandleStreamingClient::didFinishLoading):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):
Make element thread-safe, add support to use the element without a player associated (e.g.
the DASH plugin using the webkitsrc to download fragments), use GMutexLocker to simplify
locks and other general improvements.

Source/WTF:

Add convenience class that simplifies locking and unlocking a GMutex.

  • GNUmakefile.list.am:
  • wtf/gobject/GMutexLocker.h: Added.

(WebCore::GMutexLocker::GMutexLocker):
(WebCore::GMutexLocker::~GMutexLocker):
(WebCore::GMutexLocker::lock):
(WebCore::GMutexLocker::unlock):
(WebCore::GMutexLocker::mutex):

7:39 AM Changeset in webkit [154682] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Remove branch from DescendantIteratorAdapter::begin() when invoking for ContainerNode
​https://bugs.webkit.org/show_bug.cgi?id=120358

Reviewed by Andreas Kling.

  • dom/ContainerNode.h:


Delete isContainerNode() so it can't be called if there is static knowledge that the object is a ContainerNode.

  • dom/DescendantIterator.h:

(WebCore::::DescendantIterator):

Make DescendantIterator use Node* as root instead of ContainerNode*. It is only used for equality comparison.

(WebCore::::begin):

Remove branch. Rely on ElementTraversal specialization for ContainerNodes.

7:13 AM Changeset in webkit [154681] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Web Inspector: Column Breakpoint not working, may be off by 1
​https://bugs.webkit.org/show_bug.cgi?id=120334

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-08-27
Reviewed by David Kilzer.

Source/WebCore:

JavaScriptCore changed to 1-based column numbers at some point. We
need to update the ScriptDebugger assumption that they were 0-based.

Test: inspector-protocol/debugger/column-breakpoint.html

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):

LayoutTests:

Write a protocol test for setting a breakpoint at a line:column.

  • inspector-protocol/debugger/column-breakpoint-expected.txt: Added.
  • inspector-protocol/debugger/column-breakpoint.html: Added.
6:41 AM Changeset in webkit [154680] by commit-queue@webkit.org
  • 4 edits
    7 adds
    2 deletes in trunk/LayoutTests

[EFL] Added new accessibility expectations after r153798.
​https://bugs.webkit.org/show_bug.cgi?id=120354

Unreviewed EFL gardening.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-08-27

  • platform/efl-wk1/accessibility/image-link-expected.txt: Added.
  • platform/efl-wk1/accessibility/image-map2-expected.txt: Added.
  • platform/efl-wk1/accessibility/table-cell-spans-expected.txt: Added.
  • platform/efl-wk1/accessibility/table-cells-expected.txt: Added.
  • platform/efl-wk2/accessibility/image-link-expected.txt: Added.
  • platform/efl-wk2/accessibility/image-map2-expected.txt: Added.
  • platform/efl-wk2/accessibility/table-cell-spans-expected.txt:
  • platform/efl-wk2/accessibility/table-cells-expected.txt:
  • platform/efl/TestExpectations:
  • platform/efl/accessibility/image-link-expected.txt: Removed.
  • platform/efl/accessibility/image-map2-expected.txt: Removed.
6:04 AM Changeset in webkit [154679] by Antti Koivisto
  • 12 edits in trunk/Source/WebCore

Switch some more code to element child/descendant iterators
​https://bugs.webkit.org/show_bug.cgi?id=120355

Reviewed by Andreas Kling.

Move from Traversal<ElementType>::next() and Traversal<ElementType>::nextSibling() to iterators.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • dom/Document.cpp:

(WebCore::Document::removeTitle):
(WebCore::Document::updateBaseURL):
(WebCore::Document::processBaseElement):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::labelElementForId):
(WebCore::TreeScope::findAnchor):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
(WebCore::HTMLFieldSetElement::childrenChanged):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::isSVGFilterPrimitiveStandardAttributes):
(WebCore::SVGFilterPrimitiveStandardAttributes):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):

6:00 AM Changeset in webkit [154678] by akling@apple.com
  • 30 edits in trunk/Source

FocusController::focusedOrMainFrame() should return a reference.
<​https://webkit.org/b/120339>

Reviewed by Antti Koivisto.

Now that Page::mainFrame() returns a reference, we can make this return a reference
too, since there's always either a focused or a main frame.

One hectogram of null checks removed as a result.

5:49 AM Changeset in webkit [154677] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=119986

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2013-08-27
Reviewed by Gustavo Noronha Silva.

  • pl.po: updated.
5:31 AM Changeset in webkit [154676] by akling@apple.com
  • 9 edits in trunk/Source

Document's renderer is always a RenderView.
<​https://webkit.org/b/120304>

Reviewed by Darin Adler.

Let's enforce this better by storing a RenderView* instead of a plain RenderObject*.
We should switch callers that grab at Document::renderer() to calling renderView()
instead, but that's better done separately.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setRenderView):
(WebCore::Document::createRenderTree):
(WebCore::Document::detach):
(WebCore::Document::setInPageCache):

  • dom/Document.h:

(WebCore::Document::renderView):
(WebCore::Document::renderer):

  • html/parser/HTMLResourcePreloader.cpp:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle):

  • rendering/RenderView.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::updateCurrentTranslate):

5:09 AM Changeset in webkit [154675] by g.czajkowski@samsung.com
  • 6 edits
    1 add in trunk/LayoutTests

grammar-markers.html and grammar-markers-hidpi.html pass even if element does not have grammar marker
​https://bugs.webkit.org/show_bug.cgi?id=119797

Reviewed by Ryosuke Niwa.

After tenth attempts of verifying the grammar marker, the tests call'notifyDone'
even if grammar marker was not be found.

Both grammar-marker.html and grammar-marker-hidpi.html call the text checker
asynchronously. Therefore, we need to wait until either the grammar marker
is found or number of attempts is reached.

Dump more information whether the grammar marker was found to be sure that
the tests do not pass when the element does not have the marker.

  • editing/spelling/grammar-markers-expected.txt:
  • editing/spelling/grammar-markers-hidpi-expected.txt:

Update the expectations.

  • editing/spelling/grammar-markers-hidpi.html:
  • editing/spelling/grammar-markers.html:

Dump more information.
Additionally, pass 'document' to hasGrammarMarker instead of
'target' as the method does not work for target/source elements.

  • platform/mac/editing/spelling/grammar-markers-expected.png:
  • platform/mac/editing/spelling/grammar-markers-hidpi-expected.png: Added.

Update the expectations for Mac.

3:22 AM Changeset in webkit [154674] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

Font's fast code path doesn't handle partial runs correctly when kerning or ligatures are enabled
​https://bugs.webkit.org/show_bug.cgi?id=100050

Reviewed by Darin Adler.

Renamed m_characterIndex to m_characterIndexOfGlyph and gave it an inline size of 10,
which covers around 66% of all cases. The rest of the cases are now preallocated to the
upper limit which is length of the original TextRun.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):

  • platform/graphics/WidthIterator.h:
3:09 AM Changeset in webkit [154673] by Christophe Dumez
  • 23 edits
    7 adds in trunk

Implement DOM3 wheel event
​https://bugs.webkit.org/show_bug.cgi?id=94081

Reviewed by Darin Adler.

Source/WebCore:

Add support for DOM Level 3 WheelEvent:
​http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent

Firefox, IE10 and since recently Blink already support it so
it increases our cross-browser compatibility.

The non-standard 'mousewheel' event is still supported for backward
compatibility. Note that the deltas returned by the mousewheel and
the wheel events are not identical:

  • They have opposite signs.
  • The wheel event reports the actual amount of pixels that should be

scrolled while the legacy mousewheel event reports a factor of the
number of mouse wheel ticks (using a constant multiplier).

Tests: fast/events/wheelevent-basic.html

fast/events/wheelevent-constructor.html
fast/events/wheelevent-mousewheel-interaction.html

  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/EventNames.h:
  • dom/EventTarget.cpp:

(WebCore::legacyType):
(WebCore::EventTarget::shouldObserveLegacyType):
(WebCore::EventTarget::setupLegacyTypeObserverIfNeeded):
(WebCore::EventTarget::fireEventListeners):

  • dom/EventTarget.h:
  • dom/Node.cpp:

(WebCore::Node::didMoveToNewDocument):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::defaultEventHandler):

  • dom/WheelEvent.cpp:

(WebCore::WheelEventInit::WheelEventInit):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:

(WebCore::WheelEvent::deltaX):
(WebCore::WheelEvent::deltaY):
(WebCore::WheelEvent::deltaZ):
(WebCore::WheelEvent::wheelDelta):
(WebCore::WheelEvent::wheelDeltaX):
(WebCore::WheelEvent::wheelDeltaY):

  • dom/WheelEvent.idl:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::eventNameForAttributeName):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultWheelEventHandler):

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::handleWheelEvent):

  • svg/SVGElementInstance.cpp:
  • svg/SVGElementInstance.h:
  • svg/SVGElementInstance.idl:

LayoutTests:

Add several layout tests to check support for DOM3 wheel event.

  • fast/events/wheelevent-basic-expected.txt: Added.
  • fast/events/wheelevent-basic.html: Added.
  • fast/events/wheelevent-constructor-expected.txt: Added.
  • fast/events/wheelevent-constructor.html: Added.
  • fast/events/wheelevent-mousewheel-interaction-expected.txt: Added.
  • fast/events/wheelevent-mousewheel-interaction.html: Added.
  • platform/efl/fast/events/wheelevent-basic-expected.txt: Added.
3:00 AM Changeset in webkit [154672] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Assertion while scrolling news.google.com
​https://bugs.webkit.org/show_bug.cgi?id=115303

Reviewed by Anders Carlsson.

Do not relayout when accessing script elements during painting.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):

2:54 AM Changeset in webkit [154671] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Let Page create the main Frame.
​https://bugs.webkit.org/show_bug.cgi?id=120349

Adjust to latest changes in WebCore::Page to create the main frame.

Patch by Arunprasad Rajkumar <​arurajku@cisco.com> on 2013-08-27
Reviewed by Simon Hausmann.

  • WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameData::QWebFrameData):

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::initializeWebCorePage):

1:41 AM Changeset in webkit [154670] by Carlos Garcia Campos
  • 29 edits
    88 deletes in releases/WebKitGTK/webkit-2.2

Revert "Add support for Promises"

This reverts commit bd7606974ee8b78a8c53ccb635ea24234e8575f4.

This is a experimental feature added without a feature define.

1:24 AM Changeset in webkit [154669] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Tools

Merge r154668 - Unreviewed. Fix GTK+ build after r154601.

  • TestWebKitAPI/GNUmakefile.am: Remove mac specific file from

compilation added by mistake in r154601.

1:23 AM Changeset in webkit [154668] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ build after r154601.

  • TestWebKitAPI/GNUmakefile.am: Remove mac specific file from

compilation added by mistake in r154601.

12:43 AM Changeset in webkit [154667] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove DOMSettableTokenList's overload of add() and remove()
​https://bugs.webkit.org/show_bug.cgi?id=120341

Reviewed by Ryosuke Niwa.

Little refactoring to make other cleanups easier. Instead of modifying
SpaceSplitString directly, rely on DOMTokenList ultimately changing
the value, which in turn updates the tokens.

  • html/DOMSettableTokenList.cpp:
  • html/DOMSettableTokenList.h:
  • html/DOMTokenList.h:
12:30 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:28 AM WebKitGTK/2.2.x created by Carlos Garcia Campos
Create page for 2.2 branch
12:26 AM Changeset in webkit [154666] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] Volume slider shows incorrect track when muted
​https://bugs.webkit.org/show_bug.cgi?id=120253

Reviewed by Philippe Normand.

When painting the volume bar, consider that it could be muted even
then volume is different than zero.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
painted volume as 0 when media is muted.

12:19 AM Changeset in webkit [154665] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.2

Branch WebKitGTK+ for 2.2

Aug 26, 2013:

11:01 PM Changeset in webkit [154664] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed GTK build fix.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::FrameLoaderClient): Remove an assertion that was not removed in r154658.

9:09 PM Changeset in webkit [154663] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

EditorInternalCommand should use Frame& where possible
​https://bugs.webkit.org/show_bug.cgi?id=120340

Reviewed by Andreas Kling.

Only isSupportedFromDOM still takes a Frame*, as it still has callers that expect null to work.

  • dom/UserTypingGestureIndicator.cpp:
  • dom/UserTypingGestureIndicator.h:
  • editing/Editor.cpp:
  • editing/EditorCommand.cpp:
  • page/EventHandler.cpp:
8:46 PM Changeset in webkit [154662] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Elements in a node list of the form element's name getter should not be added to the past names map
​https://bugs.webkit.org/show_bug.cgi?id=120279

Reviewed by Darin Adler.

Source/WebCore:

Don't add the element in the named items to the past names map when there are multiple elements.
This matches IE10's behavior and the specified behavior in HTML5:
​http://www.w3.org/TR/2013/WD-html51-20130528/forms.html#dom-form-nameditem

Test: fast/forms/past-names-map-should-not-contain-nodelist-item.html

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getNamedElements):

LayoutTests:

Add a regression test.

  • fast/forms/past-names-map-should-not-contain-nodelist-item-expected.txt: Added.
  • fast/forms/past-names-map-should-not-contain-nodelist-item.html: Added.
8:33 PM Changeset in webkit [154661] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Another Windows build fix after r154658.

  • WebView.cpp:

(WebView::shouldClose):

8:31 PM Changeset in webkit [154660] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fixing compilation warning "unused parameter" in WebPageProxy.cpp
​https://bugs.webkit.org/show_bug.cgi?id=120205

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-08-26
Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Added UNUSED_PARAM to avoid warning.

8:26 PM Changeset in webkit [154659] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix after r154658.

  • page/AutoscrollController.cpp:

(WebCore::getMainFrame):

7:47 PM Changeset in webkit [154658] by akling@apple.com
  • 109 edits in trunk/Source

Page::mainFrame() should return a reference.
<​http://webkit.org/b/119677>

Reviewed by Antti Koivisto.

Page always creates the main Frame by itself now, so it will never be null during the Page's lifetime.

Let Page::mainFrame() return Frame& and remove a sea of null checks.

7:32 PM Changeset in webkit [154657] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

7:28 PM Changeset in webkit [154656] by Lucas Forschler
  • 1 copy in tags/Safari-537.64

New Tag.

6:25 PM Changeset in webkit [154655] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

Don't leak objects in HardAutorelease when OBJC_NO_GC is undefined but
Objective-C GC is disabled at runtime.

Reviewed by Darin Adler.

  • wtf/ObjcRuntimeExtras.h:

(HardAutorelease):

5:50 PM Changeset in webkit [154654] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Remove two unnecessary .get()s.

Reviewed by Anders Carlsson.

  • editing/Editor.h:

(WebCore::Editor::killRing):
(WebCore::Editor::spellChecker):

4:45 PM Changeset in webkit [154653] by ap@apple.com
  • 3 edits in trunk/LayoutTests

[Mac] can-read-in-dragstart-event.html and can-read-in-copy-and-cut-events.html fail
​https://bugs.webkit.org/show_bug.cgi?id=113094

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations: Updated expectations, these tests should be good now.
4:38 PM Changeset in webkit [154652] by ap@apple.com
  • 3 edits
    4 adds in trunk/Tools

WebKitTestRunner needs to protect the user's pasteboard contents while running
​https://bugs.webkit.org/show_bug.cgi?id=81419
<rdar://problem/11066794>

Reviewed by Darin Adler.

Mostly a copy/paste of DRT code.

Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
doesn't interfere with my clipboard while being run in a loop.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/PoseAsClass.h: Added.
  • WebKitTestRunner/mac/PoseAsClass.mm: Added.
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize): (WTR::TestController::platformDestroy):
  • WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
  • WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
4:37 PM Changeset in webkit [154651] by Joseph Pecoraro
  • 9 edits
    3 adds in trunk/Source

Web Inspector: We should regenerate InspectorBackendCommands.js for Legacy Inspector.json versions
​https://bugs.webkit.org/show_bug.cgi?id=120242

Reviewed by NOBODY (OOPS!).

Source/WebCore:

  • Update the Inspector.json CodeGenerator to include an output_js_dir.
  • Cleanup multiple trailing newlines in some of the generated files.
  • Provide a way to not verify runtime casts, needed for Legacy inputs.
  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • inspector/CodeGeneratorInspector.py:

(resolve_all_types):
(SmartOutput.close):

Source/WebInspectorUI:

  • Include the iOS 6.0 Inspector.json which maps to Legacy/6.0/InspectorBackendCommands.js.
  • Provide a helper script to regenerate the backend commands file for trunk and Versions.
  • Regenerated file now includes enums and other minor changes.
  • Scripts/update-InspectorBackendCommands.rb: Added.
  • UserInterface/InspectorBackendCommands.js:
  • UserInterface/Legacy/6.0/InspectorBackendCommands.js:
  • Versions/Inspector-iOS-6.0.json: Added.
4:25 PM Changeset in webkit [154650] by commit-queue@webkit.org
  • 3 edits
    4 deletes in trunk/Tools

Unreviewed, rolling out r154640.
​http://trac.webkit.org/changeset/154640
​https://bugs.webkit.org/show_bug.cgi?id=120329

Caused flaky crashes on a lot of editing tests (Requested by
rniwa on #webkit).

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/PoseAsClass.h: Removed.
  • WebKitTestRunner/mac/PoseAsClass.mm: Removed.
  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitialize):
(WTR::TestController::platformDestroy):

  • WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
  • WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
4:23 PM Changeset in webkit [154649] by mitz@apple.com
  • 2 edits in trunk/Tools

Automatic bug reports case pain
​https://bugs.webkit.org/show_bug.cgi?id=120330

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description

of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
“fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.

3:49 PM Changeset in webkit [154648] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

AlternativeTextController should hold onto Frame as a reference
​https://bugs.webkit.org/show_bug.cgi?id=120327

Reviewed by Andreas Kling.

While in the area I also:

  • Reference-ified Editor::killRing().
  • Const-ified Editor::m_killRing, Editor::m_spellChecker, and Editor::m_alternativeTextController.
  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::stopPendingCorrection):
(WebCore::AlternativeTextController::isSpellingMarkerAllowed):
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
(WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
(WebCore::AlternativeTextController::timerFired):
(WebCore::AlternativeTextController::handleAlternativeTextUIResult):
(WebCore::AlternativeTextController::rootViewRectForRange):
(WebCore::AlternativeTextController::respondToChangedSelection):
(WebCore::AlternativeTextController::respondToAppliedEditing):
(WebCore::AlternativeTextController::respondToUnappliedEditing):
(WebCore::AlternativeTextController::alternativeTextClient):
(WebCore::AlternativeTextController::editorClient):
(WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::insertDictatedText):
(WebCore::AlternativeTextController::applyDictationAlternative):

  • editing/AlternativeTextController.h:

(WebCore::AlternativeTextController::UNLESS_ENABLED):

  • editing/Editor.cpp:

(WebCore::Editor::Editor):
(WebCore::Editor::addToKillRing):

  • editing/Editor.h:

(WebCore::Editor::killRing):

  • editing/EditorCommand.cpp:

(WebCore::executeYank):
(WebCore::executeYankAndSelect):

3:40 PM Changeset in webkit [154647] by aestes@apple.com
  • 35 edits
    1 delete in trunk

Fix issues found by the Clang Static Analyzer
​https://bugs.webkit.org/show_bug.cgi?id=120230

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • API/JSValue.mm:

(valueToString): Don't leak every CFStringRef when in Objective-C GC.

  • API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl): Don't
release m_invocation's target since NSInvocation will do it for us on
-dealloc.
(objCCallbackFunctionForBlock): Tell NSInvocation to retain its target
and -release our reference to the copied block.

  • API/tests/minidom.c:

(createStringWithContentsOfFile): Free buffer before returning.

  • API/tests/testapi.c:

(createStringWithContentsOfFile): Ditto.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Removed FoundationExtras.h.
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed CFAutoreleaseHelper().

(AXTextMarkerRange): Used HardAutorelease() instead of
CFAutoreleaseHelper().
(AXTextMarkerRangeStart): Ditto.
(AXTextMarkerRangeEnd): Ditto.
(textMarkerForVisiblePosition): Ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver initWithCallback:]): Called [super init]
first so that we don't later use ivars from the wrong self.
(-[WebCoreAVFLoaderDelegate initWithCallback:]): Ditto.

  • platform/mac/FoundationExtras.h: Removed.
  • platform/mac/KURLMac.mm:

(WebCore::KURL::operator NSURL *): Used WTF's HardAutorelease().

  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::mapHostNameWithRange): Used HardAutorelease() instead of
WebCoreCFAutorelease().
(WebCore::URLWithData): Ditto.
(WebCore::userVisibleString): Ditto.
(WebCore::URLByRemovingComponentAndSubsequentCharacter): Used Vector<>
with an inline capacity rather than heap-allocating a buffer.

  • platform/mac/WebCoreObjCExtras.h: Used HardAutorelease() instead of

WebCoreCFAutorelease().

  • platform/text/mac/StringImplMac.mm:

(WTF::StringImpl::operator NSString *): Used WTF's HardAutorelease().

Source/WebKit/mac:

  • Misc/WebNSFileManagerExtras.mm:

(-[NSFileManager _webkit_startupVolumeName]): Used HardAutorelease()
instead of WebCFAutorelease().

  • Misc/WebNSObjectExtras.h: Removed definition of WebCFAutorelease().
  • Misc/WebNSURLExtras.mm:

(-[NSURL _web_URLWithLowercasedScheme]): Used HardAutorelease()
instead of WebCFAutorelease().

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPluginLayer]): Stop leaking
CGColors (CALayer retains its backgroundColor property despite the
property attributes claiming otherwise).

  • Plugins/WebBasePluginPackage.mm:

(+[WebBasePluginPackage preferredLocalizationName]): Used
HardAutorelease() instead of WebCFAutorelease().

  • WebView/WebDeviceOrientationProviderMock.mm:

(-[WebDeviceOrientationProviderMockInternal lastOrientation]): Stop
leaking WebDeviceOrientations.

  • WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Used
HardAutorelease() instead of WebCFAutorelease().

  • WebView/WebView.mm:

(+[WebView _setCacheModel:]): Ditto.
(-[WebView _removeObjectForIdentifier:]): Ditto.

Source/WebKit2:

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(autoreleased): Don't leak CFURLs when in Objective-C GC.

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
Don't leak CFStrings when in Objective-C GC.

Source/WTF:

  • wtf/ObjcRuntimeExtras.h:

(HardAutorelease): Added a canonical implementation of HardAutorelease.

Tools:

  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:

(-[LocalPasteboard initWithName:]): Called [super init] first so that we
don't later use ivars from the wrong self.

  • DumpRenderTree/mac/TestRunnerMac.mm:

(-[APITestDelegate initWithCompletionCondition:]): Ditto.

  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:

(TestWebKitAPI::TEST): Don't leak WKProcessGroups,
WKBrowsingContextGroups, and WKViews.

3:34 PM Changeset in webkit [154646] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[WK2] Buildfix for non Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=120294

Reviewed by Darin Adler.

  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):

  • NetworkProcess/NetworkResourceLoader.h:
2:54 PM Changeset in webkit [154645] by psolanki@apple.com
  • 7 edits in trunk/Source/WebCore

Page::console() should return a reference
​https://bugs.webkit.org/show_bug.cgi?id=120320

Reviewed by Darin Adler.

Page::m_console is never NULL so console() can just return a reference.

  • css/CSSParser.cpp:

(WebCore::CSSParser::logError):

  • dom/Document.cpp:

(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::pageConsole):

  • page/Page.h:

(WebCore::Page::console):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc):

2:53 PM Changeset in webkit [154644] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

Lonely stop crashes
​https://bugs.webkit.org/show_bug.cgi?id=87964

Reviewed by Darin Adler.

Source/WebCore:

Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.

Test: svg/custom/stop-crash-hittest.svg

  • rendering/svg/RenderSVGGradientStop.h:

LayoutTests:

Add testcase by taking stop-crash.svg and adding hittest instructions.

  • svg/custom/stop-crash-hittest-expected.txt: Added.
  • svg/custom/stop-crash-hittest.svg: Added.
2:50 PM Changeset in webkit [154643] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Editor::spellChecker() should return a reference
​https://bugs.webkit.org/show_bug.cgi?id=120325

Reviewed by Anders Carlsson.

  • editing/Editor.cpp:

(WebCore::Editor::Editor):

  • editing/Editor.h:

(WebCore::Editor::spellChecker):

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::client):
(WebCore::SpellChecker::isAsynchronousEnabled):
(WebCore::SpellChecker::didCheck):
(WebCore::SpellChecker::didCheckSucceed):

  • editing/SpellChecker.h:
  • page/EditorClient.h:
  • testing/Internals.cpp:

(WebCore::Internals::lastSpellCheckRequestSequence):
(WebCore::Internals::lastSpellCheckProcessedSequence):

2:42 PM Changeset in webkit [154642] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebKit

AppleWin build fix following r154627.

  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
2:35 PM Changeset in webkit [154641] by Bem Jones-Bey
  • 4 edits
    2 adds in trunk

Optimize FloatIntervalSearchAdapter::collectIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=120237

Reviewed by David Hyatt.

Source/WebCore:

This is a port of 3 Blink patches:
​https://codereview.chromium.org/22463002 (By ​shatch@chromium.org)
​https://chromiumcodereview.appspot.com/22909005 (By me)
​https://chromiumcodereview.appspot.com/23084002 (By me)

shatch optimized FloatIntervalSearchAdapter by having it store the
outermost float instead of making a bunch of calls to
logical(Left/Right/Bottom)ForFloat, and then only making that call
once when heightRemaining needs to be computed.

I noticed that now we were storing both the last float encountered and
the outermost float, and that the behavior for shape-outside wasn't
significantly changed by using the outermost float instead of the last
float encountered (and in most cases, using the outermost float gives
more reasonable behavior). Since this isn't covered in the spec yet, I
changed shape-outside to use the outermost float, making it so that we
only need to store one float pointer when walking the placed floats
tree, and keeping the performance win.

Also while changing updateOffsetIfNeeded, removed const, since that is
a lie. Nothing about that method is const.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html

  • rendering/RenderBlock.cpp:

(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::getHeightRemaining):
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlock::logicalRightFloatOffsetForLine):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::outermostFloat):

LayoutTests:

Test shape-outside behavior when there is more than one float on a
given line.

  • fast/shapes/shape-outside-floats/shape-outside-floats-outermost-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html: Added.
2:34 PM Changeset in webkit [154640] by ap@apple.com
  • 3 edits
    4 adds in trunk/Tools

WebKitTestRunner needs to protect the user's pasteboard contents while running
​https://bugs.webkit.org/show_bug.cgi?id=81419
<rdar://problem/11066794>

Reviewed by Darin Adler.

Mostly a copy/paste of DRT code.

Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
doesn't interfere with my clipboard while being run in a loop.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/PoseAsClass.h: Added.
  • WebKitTestRunner/mac/PoseAsClass.mm: Added.
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize): (WTR::TestController::platformDestroy):
  • WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
  • WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
2:11 PM Changeset in webkit [154639] by ap@apple.com
  • 15 edits in trunk/Source

[Mac] can-read-in-dragstart-event.html and can-read-in-copy-and-cut-events.html fail
​https://bugs.webkit.org/show_bug.cgi?id=113094

Reviewed by Darin Adler.

Mac platform implementation has checks for pasteboard change count, but it
didn't use to update the count when writing to pasteboad from JavaScript.

  • platform/PasteboardStrategy.h: Changed changeCount function to return a long instead of an int, as the underlying Mac type is NSInteger. Changed all methods that modify the pasteboard to return a new change count.
  • platform/PlatformPasteboard.h: Changed all methods that modify the pasteboard to return a new change count.
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::clear): Update m_changeCount. (WebCore::Pasteboard::writeSelectionForTypes): Ditto. (WebCore::Pasteboard::writePlainText): Ditto. (WebCore::writeURLForTypes): Ditto. (WebCore::Pasteboard::writeURL): Ditto. (WebCore::writeFileWrapperAsRTFDAttachment): Ditto. (WebCore::Pasteboard::writeImage): Ditto. (WebCore::Pasteboard::writePasteboard): Ditto. (WebCore::addHTMLClipboardTypesForCocoaType): Ditto. (WebCore::Pasteboard::writeString): Ditto.
  • platform/mac/PlatformPasteboardMac.mm: (WebCore::PlatformPasteboard::changeCount): Changed returned type to long to avoid data loss. (WebCore::PlatformPasteboard::copy): Return new change count. (WebCore::PlatformPasteboard::addTypes): Ditto. (WebCore::PlatformPasteboard::setTypes): Ditto. (WebCore::PlatformPasteboard::setBufferForType): Ditto. (WebCore::PlatformPasteboard::setPathnamesForType): Ditto. (WebCore::PlatformPasteboard::setStringForType): Ditto. Replaced -[NSURL writeToPasteboard:] with an equivalent implemnentation that tells use whether writing was successful. There is difference with invalid URL string handling - we used to silently ignore such requets, but set pasteboard content to empty URL now.
2:09 PM Changeset in webkit [154638] by Brent Fulgham
  • 3 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix after r154629.

1:50 PM Changeset in webkit [154637] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Another GTK+ build fix.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
1:45 PM Changeset in webkit [154636] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

GTK+ build fix. Like r154620.

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_new):

1:42 PM Changeset in webkit [154635] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix attempt after r154629.

1:37 PM Changeset in webkit [154634] by roger_fong@apple.com
  • 1 edit
    3 adds in trunk/Source/WebKit/win

Unreviewed. Add missing interface files that were left out in r154627.

  • Interfaces/Accessible2/AccessibleEditableText.idl: Added.
  • Interfaces/Accessible2/AccessibleText.idl: Added.
  • Interfaces/Accessible2/AccessibleText2.idl: Added.
1:29 PM Changeset in webkit [154633] by mhahnenberg@apple.com
  • 3 edits
    3 adds in trunk

JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage does a check on the length of the ArrayStorage after possible reallocing it
​https://bugs.webkit.org/show_bug.cgi?id=120278

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):

LayoutTests:

  • fast/js/put-direct-index-beyond-vector-length-resize-expected.txt: Added.
  • fast/js/put-direct-index-beyond-vector-length-resize.html: Added.
  • fast/js/script-tests/put-direct-index-beyond-vector-length-resize.js: Added.
1:09 PM Changeset in webkit [154632] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indention of Executable.h.

Rubber stamped by Mark Hahnenberg.

  • runtime/Executable.h:
1:08 PM Changeset in webkit [154631] by Brent Fulgham
  • 6 edits in trunk/Source/WebKit/win

[Windows] Let Page create the main Frame.
​https://bugs.webkit.org/show_bug.cgi?id=120323

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::WebFrameLoaderClient): Remove assertion that frame
is passed as construction argument.
(WebFrameLoaderClient::createFrame): Call new 'createSubframeWithOwnerElement'

  • WebCoreSupport/WebFrameLoaderClient.h: Update constructor to

handle case of no default frame argument.
(WebFrameLoaderClient::setWebFrame): Added.

  • WebFrame.cpp:

(WebFrame::createSubframeWithOwnerElement): Renamed from 'init'.
(WebFrame::initWithWebFrameView): Added for new page-driven load path.

  • WebFrame.h: Added new method signatures.
  • WebView.cpp:

(WebView::initWithFrame): Update to match behavior of other ports.

1:01 PM Changeset in webkit [154630] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Object.defineProperty should be able to create a PropertyDescriptor where m_attributes == 0
​https://bugs.webkit.org/show_bug.cgi?id=120314

Reviewed by Darin Adler.

Currently with the way that defineProperty works, we leave a stray low bit set in
PropertyDescriptor::m_attributes in the following code:

var o = {};
Object.defineProperty(o, 100, {writable:true, enumerable:true, configurable:true, value:"foo"});

This is due to the fact that the lowest non-zero attribute (ReadOnly) is represented as 1 << 1
instead of 1 << 0. We then calculate the default attributes as (DontDelete << 1) - 1, which is 0xF,
but only the top three bits mean anything. Even in the case above, the top three bits are set
to 0 but the bottom bit remains set, which causes us to think m_attributes is non-zero.

Since some of these attributes and their corresponding values are exposed in the JavaScriptCore
framework's public C API, it's safer to just change how we calculate the default value, which is
where the weirdness was originating from in the first place.

  • runtime/PropertyDescriptor.cpp:
12:19 PM Changeset in webkit [154629] by weinig@apple.com
  • 29 edits
    88 adds in trunk

Add support for Promises
​https://bugs.webkit.org/show_bug.cgi?id=120260

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add an initial implementation of Promises - ​http://dom.spec.whatwg.org/#promises.

  • Despite Promises being defined in the DOM, the implementation is being put in JSC in preparation for the Promises eventually being defined in ECMAScript.
  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:

Add new files.

  • jsc.cpp:

Update jsc's GlobalObjectMethodTable to stub out the new QueueTaskToEventLoop callback. This mean's
you can't quite use Promises with with the command line tool yet.

  • interpreter/CallFrame.h:

(JSC::ExecState::promisePrototypeTable):
(JSC::ExecState::promiseConstructorTable):
(JSC::ExecState::promiseResolverPrototypeTable):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):

  • runtime/VM.h:

Add supporting code for the new static lookup tables.

  • runtime/CommonIdentifiers.h:

Add 3 new identifiers, "Promise", "PromiseResolver", and "then".

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
Add supporting code Promise and PromiseResolver's constructors and structures.

  • runtime/JSGlobalObject.h:

(JSC::TaskContext::~TaskContext):
Add a new callback to the GlobalObjectMethodTable to post a task on the embedder's runloop.

(JSC::JSGlobalObject::promisePrototype):
(JSC::JSGlobalObject::promiseResolverPrototype):
(JSC::JSGlobalObject::promiseStructure):
(JSC::JSGlobalObject::promiseResolverStructure):
(JSC::JSGlobalObject::promiseCallbackStructure):
(JSC::JSGlobalObject::promiseWrapperCallbackStructure):
Add supporting code Promise and PromiseResolver's constructors and structures.

  • runtime/JSPromise.cpp: Added.
  • runtime/JSPromise.h: Added.
  • runtime/JSPromiseCallback.cpp: Added.
  • runtime/JSPromiseCallback.h: Added.
  • runtime/JSPromiseConstructor.cpp: Added.
  • runtime/JSPromiseConstructor.h: Added.
  • runtime/JSPromisePrototype.cpp: Added.
  • runtime/JSPromisePrototype.h: Added.
  • runtime/JSPromiseResolver.cpp: Added.
  • runtime/JSPromiseResolver.h: Added.
  • runtime/JSPromiseResolverConstructor.cpp: Added.
  • runtime/JSPromiseResolverConstructor.h: Added.
  • runtime/JSPromiseResolverPrototype.cpp: Added.
  • runtime/JSPromiseResolverPrototype.h: Added.

Add Promise implementation.

Source/WebCore:

Add an initial implementation of Promises - ​http://dom.spec.whatwg.org/#promises.

  • Despite Promises being defined in the DOM, the implementation is being put in JSC in preparation for the Promises eventually being defined in ECMAScript.

Tests: fast/js/Promise-already-fulfilled.html

fast/js/Promise-already-rejected.html
fast/js/Promise-already-resolved.html
fast/js/Promise-catch-in-workers.html
fast/js/Promise-catch.html
fast/js/Promise-chain.html
fast/js/Promise-exception.html
fast/js/Promise-fulfill-in-workers.html
fast/js/Promise-fulfill.html
fast/js/Promise-init-in-workers.html
fast/js/Promise-init.html
fast/js/Promise-reject-in-workers.html
fast/js/Promise-reject.html
fast/js/Promise-resolve-chain.html
fast/js/Promise-resolve-in-workers.html
fast/js/Promise-resolve-with-then-exception.html
fast/js/Promise-resolve-with-then-fulfill.html
fast/js/Promise-resolve-with-then-reject.html
fast/js/Promise-resolve.html
fast/js/Promise-simple-fulfill-inside-callback.html
fast/js/Promise-simple-fulfill.html
fast/js/Promise-simple-in-workers.html
fast/js/Promise-simple.html
fast/js/Promise-static-fulfill.html
fast/js/Promise-static-reject.html
fast/js/Promise-static-resolve.html
fast/js/Promise-then-in-workers.html
fast/js/Promise-then-without-callbacks-in-workers.html
fast/js/Promise-then-without-callbacks.html
fast/js/Promise-then.html
fast/js/Promise-types.html
fast/js/Promise.html

  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Add new files.

  • bindings/js/JSDOMGlobalObjectTask.cpp: Added.

(WebCore::JSGlobalObjectCallback::create):
(WebCore::JSGlobalObjectCallback::~JSGlobalObjectCallback):
(WebCore::JSGlobalObjectCallback::call):
(WebCore::JSGlobalObjectCallback::JSGlobalObjectCallback):
(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
(WebCore::JSGlobalObjectTask::~JSGlobalObjectTask):
(WebCore::JSGlobalObjectTask::performTask):

  • bindings/js/JSDOMGlobalObjectTask.h: Added.

(WebCore::JSGlobalObjectTask::create):
Add a new task type to be used with the GlobalObjectMethodTable's new QueueTaskToEventLoop callback.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::queueTaskToEventLoop):

  • bindings/js/JSDOMWindowBase.h:

Implement the GlobalObjectMethodTable callback, QueueTaskToEventLoop.

  • bindings/js/JSMainThreadExecState.h:

All using JSMainThreadExecState as a simple RAII object.

  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
(WebCore::JSWorkerGlobalScopeBase::allowsAccessFrom):
(WebCore::JSWorkerGlobalScopeBase::supportsProfiling):
(WebCore::JSWorkerGlobalScopeBase::supportsRichSourceInfo):
(WebCore::JSWorkerGlobalScopeBase::shouldInterruptScript):
(WebCore::JSWorkerGlobalScopeBase::javaScriptExperimentsEnabled):
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):

  • bindings/js/JSWorkerGlobalScopeBase.h:

Add a GlobalObjectMethodTable and implement QueueTaskToEventLoop. Forward the other callbacks
to JSGlobalObject so they retain their existing behavior.

LayoutTests:

Add tests adapted from the Mozilla and Blink projects.

  • fast/js/Promise-already-fulfilled-expected.txt: Added.
  • fast/js/Promise-already-fulfilled.html: Added.
  • fast/js/Promise-already-rejected-expected.txt: Added.
  • fast/js/Promise-already-rejected.html: Added.
  • fast/js/Promise-already-resolved-expected.txt: Added.
  • fast/js/Promise-already-resolved.html: Added.
  • fast/js/Promise-catch-expected.txt: Added.
  • fast/js/Promise-catch-in-workers-expected.txt: Added.
  • fast/js/Promise-catch-in-workers.html: Added.
  • fast/js/Promise-catch.html: Added.
  • fast/js/Promise-chain-expected.txt: Added.
  • fast/js/Promise-chain.html: Added.
  • fast/js/Promise-exception-expected.txt: Added.
  • fast/js/Promise-exception.html: Added.
  • fast/js/Promise-expected.txt: Added.
  • fast/js/Promise-fulfill-expected.txt: Added.
  • fast/js/Promise-fulfill-in-workers-expected.txt: Added.
  • fast/js/Promise-fulfill-in-workers.html: Added.
  • fast/js/Promise-fulfill.html: Added.
  • fast/js/Promise-init-expected.txt: Added.
  • fast/js/Promise-init-in-workers-expected.txt: Added.
  • fast/js/Promise-init-in-workers.html: Added.
  • fast/js/Promise-init.html: Added.
  • fast/js/Promise-reject-expected.txt: Added.
  • fast/js/Promise-reject-in-workers-expected.txt: Added.
  • fast/js/Promise-reject-in-workers.html: Added.
  • fast/js/Promise-reject.html: Added.
  • fast/js/Promise-resolve-chain-expected.txt: Added.
  • fast/js/Promise-resolve-chain.html: Added.
  • fast/js/Promise-resolve-expected.txt: Added.
  • fast/js/Promise-resolve-in-workers-expected.txt: Added.
  • fast/js/Promise-resolve-in-workers.html: Added.
  • fast/js/Promise-resolve-with-then-exception-expected.txt: Added.
  • fast/js/Promise-resolve-with-then-exception.html: Added.
  • fast/js/Promise-resolve-with-then-fulfill-expected.txt: Added.
  • fast/js/Promise-resolve-with-then-fulfill.html: Added.
  • fast/js/Promise-resolve-with-then-reject-expected.txt: Added.
  • fast/js/Promise-resolve-with-then-reject.html: Added.
  • fast/js/Promise-resolve.html: Added.
  • fast/js/Promise-simple-expected.txt: Added.
  • fast/js/Promise-simple-fulfill-expected.txt: Added.
  • fast/js/Promise-simple-fulfill-inside-callback-expected.txt: Added.
  • fast/js/Promise-simple-fulfill-inside-callback.html: Added.
  • fast/js/Promise-simple-fulfill.html: Added.
  • fast/js/Promise-simple-in-workers-expected.txt: Added.
  • fast/js/Promise-simple-in-workers.html: Added.
  • fast/js/Promise-simple.html: Added.
  • fast/js/Promise-static-fulfill-expected.txt: Added.
  • fast/js/Promise-static-fulfill.html: Added.
  • fast/js/Promise-static-reject-expected.txt: Added.
  • fast/js/Promise-static-reject.html: Added.
  • fast/js/Promise-static-resolve-expected.txt: Added.
  • fast/js/Promise-static-resolve.html: Added.
  • fast/js/Promise-then-expected.txt: Added.
  • fast/js/Promise-then-in-workers-expected.txt: Added.
  • fast/js/Promise-then-in-workers.html: Added.
  • fast/js/Promise-then-without-callbacks-expected.txt: Added.
  • fast/js/Promise-then-without-callbacks-in-workers-expected.txt: Added.
  • fast/js/Promise-then-without-callbacks-in-workers.html: Added.
  • fast/js/Promise-then-without-callbacks.html: Added.
  • fast/js/Promise-then.html: Added.
  • fast/js/Promise-types-expected.txt: Added.
  • fast/js/Promise-types.html: Added.
  • fast/js/Promise.html: Added.
  • fast/js/resources/Promise-catch-in-workers.js: Added.
  • fast/js/resources/Promise-fulfill-in-workers.js: Added.
  • fast/js/resources/Promise-init-in-workers.js: Added.
  • fast/js/resources/Promise-reject-in-workers.js: Added.
  • fast/js/resources/Promise-resolve-in-workers.js: Added.
  • fast/js/resources/Promise-simple-in-workers.js: Added.
  • fast/js/resources/Promise-then-in-workers.js: Added.
  • fast/js/resources/Promise-then-without-callbacks-in-workers.js: Added.
12:03 PM Changeset in webkit [154628] by rwlbuis@webkit.org
  • 7 edits in trunk

Computed style of fill/stroke properties incorrect on references
​https://bugs.webkit.org/show_bug.cgi?id=114761

Reviewed by Darin Adler.

Source/WebCore:

The computed style of the fill and stroke properties did not include
the url() function. Added the url() string to output.

Updated existing tests to cover the issue.

  • css/CSSPrimitiveValue.cpp: Cleanup.

(WebCore::CSSPrimitiveValue::customCssText):

  • svg/SVGPaint.cpp: Added "url("

(WebCore::SVGPaint::customCssText):

LayoutTests:

Add tests to verify that url function is included for references.

  • svg/css/script-tests/svg-attribute-parser-mode.js:
  • svg/css/svg-attribute-parser-mode-expected.txt:
  • transitions/svg-transitions-expected.txt:
12:01 PM Changeset in webkit [154627] by roger_fong@apple.com
  • 10 edits
    2 adds in trunk/Source/WebKit

<​https://bugs.webkit.org/show_bug.cgi?id=119829> Add IAccessibleText and IAccessibleEditableText interfaces and implementation to AppleWin port.

Reviewed by Chris Fleizach.

  • AccessibleBase.cpp:

(AccessibleBase::createInstance): Create an AccessibleText instance when necessary.
(AccessibleBase::QueryService):

  • AccessibleBase.h:
  • AccessibleTextImpl.cpp: Added.

(AccessibleText::AccessibleText):
(AccessibleText::addSelection):
(AccessibleText::get_attributes): Not Implemented
(AccessibleText::get_caretOffset):
(AccessibleText::get_characterExtents):
(AccessibleText::get_nSelections):
(AccessibleText::get_offsetAtPoint):
(AccessibleText::get_selection):
(AccessibleText::get_text):
(AccessibleText::get_textBeforeOffset): Not Implemented
(AccessibleText::get_textAfterOffset): Not Implemented
(AccessibleText::get_textAtOffset): Not Implemented
(AccessibleText::removeSelection):
(AccessibleText::setCaretOffset):
(AccessibleText::setSelection):
(AccessibleText::get_nCharacters):
(AccessibleText::scrollSubstringTo):
(AccessibleText::scrollSubstringToPoint):
(AccessibleText::get_newText): Not Implemented
(AccessibleText::get_oldText): Not Implemented
(AccessibleText::get_attributeRange): Not Implemented
(AccessibleText::copyText):
(AccessibleText::deleteText):
(AccessibleText::insertText):
(AccessibleText::cutText):
(AccessibleText::pasteText):
(AccessibleText::replaceText):
(AccessibleText::setAttributes): Not Implemented
(AccessibleText::QueryInterface):
(AccessibleText::Release):
(AccessibleText::convertSpecialOffset):
(AccessibleText::initialCheck):

  • AccessibleTextImpl.h: Added.

(AccessibleText::~AccessibleText):
(AccessibleText::AddRef):

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
11:45 AM Changeset in webkit [154626] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Plenty of -Wcast-align warnings in KeywordLookup.h
​https://bugs.webkit.org/show_bug.cgi?id=120316

Reviewed by Darin Adler.

  • KeywordLookupGenerator.py: Use reinterpret_cast instead of a C-style cast when casting

the character pointers to types of larger size. This avoids spewing lots of warnings
in the KeywordLookup.h header when compiling with the -Wcast-align option.

11:43 AM Changeset in webkit [154625] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

Undefine STDC_LIMIT_MACROS and STDC_CONSTANT_MACROS before redefining them
​https://bugs.webkit.org/show_bug.cgi?id=120313

Reviewed by Darin Adler.

  • wtf/LLVMHeaders.h: Undefine the two macros before they are defined again.

This way we avoid the compilation-time warnings about the macros being invalidly redefined.

11:42 AM Changeset in webkit [154624] by Lucas Forschler
  • 13 edits in branches/safari-537-branch

Merged r154528. <rdar://problem/14634453>

11:41 AM Changeset in webkit [154623] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Prettify generated build guards in HTMLElementFactory.cpp
​https://bugs.webkit.org/show_bug.cgi?id=120310

Reviewed by Darin Adler.

Build guards should wrap the constructor definitions without empty lines between
the guards and the constructor code. Similarly, build guards for addTag calls
shouldn't put an empty line after the build guard closure.

  • dom/make_names.pl:

(printConstructorInterior):
(printConstructors):
(printFunctionInits):

11:31 AM Changeset in webkit [154622] by robert@webkit.org
  • 3 edits
    8 adds in trunk

Avoid painting every non-edge collapsed border twice over
​https://bugs.webkit.org/show_bug.cgi?id=119759

Reviewed by David Hyatt.

Source/WebCore:

Every collapsed border that isn't on the edge of a table gets painted at least twice, once by each
adjacent cell. The joins are painted four times. This is unnecessary and results in tables with semi-transparent
borders getting rendered incorrectly - each border adjoing two cells is painted twice and ends up darker than it should be.

Fixing the overpainting at joins is another day's work. This patch ensures each collapsed border inside a table is only
painted once. It does this by only allowing cells at the top and left edge of the table to paint their top and left collapsed borders.
All the others can only paint their right and bottom collapsed border. This works because the borders are painted from bottom right to top left.

Tests: fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html

fast/table/border-collapsing/collapsed-borders-adjoining-sections.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorders):

LayoutTests:

  • fast/table/border-collapsing/collapsed-borders-adjoining-sections-expected.html: Added.
  • fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.png: Added.
  • fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt: Added.

The painting here, though still wrong, is a progression on the behaviour prior to bug 11759 where
the left border was painted twice. The painting can be resolved completely when we no longer paint
twice at the border joins.

  • fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html: Added.
  • fast/table/border-collapsing/collapsed-borders-adjoining-sections.html: Added.
  • fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.png: Added.
  • fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt: Added.
  • fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells.html: Added.
11:23 AM Changeset in webkit [154621] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r154529. <rdar://problem/14816232>

11:18 AM Changeset in webkit [154620] by akling@apple.com
  • 6 edits in trunk/Source

Unreviewed build fix.

Source/WebCore:

  • page/Page.cpp:

(WebCore::Page::setNeedsRecalcStyleInAllFrames):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(+[WebFrame _createMainFrameWithPage:frameName:frameView:]):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):

11:06 AM Changeset in webkit [154619] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Unreviewed buid fix.

  • page/Page.cpp:

(WebCore::Page::setNeedsRecalcStyleInAllFrames): Remove extra '{' character.

10:57 AM Changeset in webkit [154618] by psolanki@apple.com
  • 12 edits in trunk/Source

PageGroup::groupSettings() should return a reference
​https://bugs.webkit.org/show_bug.cgi?id=120319

Reviewed by Andreas Kling.

PageGroup::m_groupSettings is never NULL so we can just return a reference from groupSettings().

Source/WebCore:

  • Modules/indexeddb/IDBFactory.cpp:
  • page/PageGroup.h:

(WebCore::PageGroup::groupSettings):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::localStorageNamespace):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::groupSettings):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

Source/WebKit/gtk:

  • webkit/webkitwebdatabase.cpp:

(webkit_set_web_database_directory_path):

Source/WebKit2:

  • WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):

10:55 AM Changeset in webkit [154617] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebCore

Merged r154535. <rdar://problem/14825344>

10:54 AM Changeset in webkit [154616] by akling@apple.com
  • 21 edits in trunk/Source

WebCore: Let Page create the main Frame.
<​https://webkit.org/b/119964>

Source/WebCore:

Reviewed by Anders Carlsson.

Previously, Frame::create() would call Page::setMainFrame() when constructing the
main Frame for a Page. Up until that point, Page had a null mainFrame().

To guarantee that Page::mainFrame() is never null, we re-order things so that
Page is responsible for creating its own main Frame. We do this at the earliest
possible point; in the Page constructor initializer list.

Constructing a Frame requires a FrameLoaderClient*, so I've added such a field to
the PageClients struct.

When creating a WebKit-layer frame, we now wrap the already-instantiated
Page::mainFrame() instead of creating a new Frame.

  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

Add an EmptyFrameLoaderClient to the PageClients constructed here.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Updated to wrap Page::mainFrame() in a FrameView instead of creating their
own Frame manually.

  • page/Frame.cpp:

(WebCore::Frame::create):

  • page/Page.h:

Remove Page::setMainFrame() and the only call site.

  • page/Page.cpp:

(WebCore::Page::Page):

Construct Page::m_mainFrame in the initializer list.

(WebCore::Page::PageClients::PageClients):

Add "FrameLoaderClient* loaderClientForMainFrame" to PageClients.

(WebCore::Page::setNeedsRecalcStyleInAllFrames):

Null-check the Frame::document() before calling through on it. This would
otherwise crash when changing font-related Settings before calling init() on
the Frame (like InspectorOverlay does.)

Source/WebKit/gtk:

Tweak WebKit1/GTK for changes in WebCore.

Patch by Zan Dobersek <​zdobersek@igalia.com>
Reviewed by Gustavo Noronha Silva.

  • WebCoreSupport/FrameLoaderClientGtk.h:

(WebKit::FrameLoaderClient::setWebFrame):

  • webkit/webkitwebframe.cpp:

(webkit_web_frame_new):

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient::setWebFrame):

Make it possible to construct a WebFrameLoaderClient with a null WebFrame*.
A WebFrame* is later hooked up with a call to setWebFrame().

  • WebView/WebFrame.mm:

(+[WebFrame _createMainFrameWithPage:frameName:frameView:]):

Customized this method to wrap the Page::mainFrame() instead of creating a
new Frame.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Add a WebFrameLoaderClient to the PageClients passed to Page().

Source/WebKit2:

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):

This starts out with a null WebFrame* pointer now.

(WebKit::WebFrameLoaderClient::setWebFrame):

WebFrame hooks itself up through this as soon as it's constructed.

(WebKit::WebFrameLoaderClient::frameLoaderDestroyed):

Tweak an out-of-date comment. The ref() we're balancing out comes from
WebFrame::create().

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame):

Rewrote createMainFrame() as createWithCoreMainFrame(). The new method wraps
an existing WebCore::Frame instead of creating a new one.

(WebKit::WebFrame::createSubframe):

Merged WebFrame::init() into here since the logic isn't shared with main
Frame creation anymore.

(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):

Call WebFrameLoaderClient::setWebFrame(this).

  • WebProcess/WebPage/WebFrame.h:

WebFrame::m_frameLoaderClient is now an OwnPtr rather than an inline member.
This way it can be created before the WebFrame.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

Set up a WebFrameLoaderClient and pass it to the Page constructor along with
the other PageClients.

10:51 AM Changeset in webkit [154615] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix.

  • rendering/RenderMediaControls.cpp: Remove references to QuickTime controls

that are no longer part of WKSI.
(wkHitTestMediaUIPart):
(wkMeasureMediaUIPart):
(wkDrawMediaUIPart):
(wkDrawMediaSliderTrack):

10:48 AM Changeset in webkit [154614] by commit-queue@webkit.org
  • 15 edits
    8 adds in trunk

<​https://webkit.org/b/106133> document.body.scrollTop & document.documentElement.scrollTop differ cross-browser

Patch by Gurpreet Kaur <​gur.trio@gmail.com> on 2013-08-26
Reviewed by Darin Adler.

Source/WebCore:

Webkit always uses document.body.scrollTop whether quirks or
standard mode. Similiar behaviour is for document.body.scrollLeft.
As per the specification webkit should return document.body.scrollTop
for quirks mode and document.documentElement.scrollTop for standard mode.
Same for document.body.scrollLeft and document.documentElement.scrollLeft.

Tests: fast/dom/Element/scrollLeft-Quirks.html

fast/dom/Element/scrollLeft.html
fast/dom/Element/scrollTop-Quirks.html
fast/dom/Element/scrollTop.html

  • dom/Element.cpp:

(WebCore::Element::scrollLeft):
(WebCore::Element::scrollTop):
If the element does not have any associated CSS layout box or the element
is the root element and the Document is in quirks mode return zero.
Else If the element is the root element return the value of scrollY
for scrollTop and scrollX for scrollLeft.

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::scrollTop):
If the element is the HTML body element, the Document is in quirks mode,
return the value of scrollY for scrollTop and scrollX for scrollLeft.

LayoutTests:

  • fast/dom/Element/scrollLeft-Quirks-expected.txt: Added.
  • fast/dom/Element/scrollLeft-Quirks.html: Added.
  • fast/dom/Element/scrollLeft-expected.txt: Added.
  • fast/dom/Element/scrollLeft.html: Added.
  • fast/dom/Element/scrollTop-Quirks-expected.txt: Added.
  • fast/dom/Element/scrollTop-Quirks.html: Added.
  • fast/dom/Element/scrollTop-expected.txt: Added.
  • fast/dom/Element/scrollTop.html: Added.

Added new tests for verifying our behavior for document.body.scrollTop/scrollLeft and
document.documentElement.scrollTop/scrollLeft for both Quirks as well as Standard mode.

  • fast/css/zoom-body-scroll-expected.txt:
  • fast/css/zoom-body-scroll.html:
  • fast/events/mouse-cursor.html:
  • http/tests/navigation/anchor-frames-expected.txt:
  • http/tests/navigation/anchor-frames-gbk-expected.txt:
  • http/tests/navigation/resources/frame-with-anchor-gbk.html:
  • http/tests/navigation/resources/frame-with-anchor-same-origin.html:
  • http/tests/navigation/resources/frame-with-anchor.html:
  • platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html:
  • platform/win/fast/css/zoom-body-scroll-expected.txt:

Rebaselining existing tests as per the new behavior. The test cases are changed to use
quirks mode because it uses document.body.scrollTop/scrollLeft and as per the new code
document.body.scrollTop/scrollLeft will return correct value if document is in quirk mode
Also test cases have been modified so that it tests what it used to.

10:45 AM Changeset in webkit [154613] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION (r154581): Some plugin tests failing in debug bots
​https://bugs.webkit.org/show_bug.cgi?id=120315

Reviewed by Darin Adler.

We are hitting the new no-event-dispatch-while-iterating assertion.

Detaching deletes a plugin which modifies DOM while it dies.

  • dom/Document.cpp:

(WebCore::Document::createRenderTree):
(WebCore::Document::detach):

Don't iterate at all. Document never has more than one Element child anyway.

10:43 AM Changeset in webkit [154612] by barraclough@apple.com
  • 5 edits in trunk

RegExpMatchesArray should not call put
​https://bugs.webkit.org/show_bug.cgi?id=120317

Reviewed by Oliver Hunt.

This will call accessors on the JSObject/JSArray prototypes - so adding an accessor or read-only
property called index or input to either of these prototypes will result in broken behavior.

Source/JavaScriptCore:

  • runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::reifyAllProperties):

  • put -> putDirect

LayoutTests:

  • fast/regex/lastIndex-expected.txt:
  • fast/regex/script-tests/lastIndex.js:
    • Added test
10:33 AM Changeset in webkit [154611] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Building is so overrated.

10:21 AM Changeset in webkit [154610] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Disable compression under MSVC for now

9:53 AM Changeset in webkit [154609] by Brent Fulgham
  • 3 edits in trunk/WebKitLibraries

[Windows] Updates to WKSI to get external builders working.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib32/WebKitSystemInterface.lib:
9:28 AM Changeset in webkit [154608] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r154580): RenderObject::document() returns a reference

See: <​https://webkit.org/b/120272>

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
(AXAttributeStringSetHeadingLevel):

9:22 AM Changeset in webkit [154607] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Windows] Build fix after r154541.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Remove reference

to deleted Element::pseudoElement(PseudoID), and add exports for new
beforePseudoElement() and afterPseudoElement().

9:13 AM Changeset in webkit [154606] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Build fix after r154578. Return Vector<String>() instead
of ListHashSet<String>().

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::types):

9:09 AM Changeset in webkit [154605] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Build fix after r154580.

  • rendering/RenderThemeWin.cpp: Mirror changes made for other ports now that

Frame is known to always be valid when in a render tree. This allows us to
get rid of some unneeded null checks.
(WebCore::RenderThemeWin::getThemeData):
(WebCore::RenderThemeWin::paintMenuList):

8:53 AM Changeset in webkit [154604] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Build fix after r154554.

  • page/AutoscrollController.cpp: Correct various places where pointers are now

references.
(WebCore::AutoscrollController::stopAutoscrollTimer):
(WebCore::AutoscrollController::startPanScrolling):
(WebCore::AutoscrollController::autoscrollTimerFired):

8:09 AM Changeset in webkit [154603] by Carlos Garcia Campos
  • 9 edits
    3 adds in trunk/Source/WebKit2

[GTK] Add WebKit2 API for isolated worlds
​https://bugs.webkit.org/show_bug.cgi?id=103377

Reviewed by Anders Carlsson.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebExtensions.cpp:

(testWebExtensionWindowObjectCleared):
(scriptDialogCallback):
(runJavaScriptInIsolatedWorldFinishedCallback):
(testWebExtensionIsolatedWorld):
(beforeAll):

  • UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(echoCallback):
(windowObjectCleared):
(getWebPage):
(methodCallCallback):

  • WebProcess/InjectedBundle/API/gtk/WebKitFrame.cpp:

(webkit_frame_get_javascript_context_for_script_world): New public
method to tget the JavaScript execution context for a given script
world.

  • WebProcess/InjectedBundle/API/gtk/WebKitFrame.h:
  • WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.cpp: Added.

(scriptWorlds): Global WebKitScriptWorld map.
(_WebKitScriptWorldPrivate::~_WebKitScriptWorldPrivate):
(webkitScriptWorldGet): Get the WebKitScriptWorld wrapping the
given injected bundle script world.
(webkitScriptWorldGetInjectedBundleScriptWorld): Get the injected
bundle script world wrapped by the given WebKitScriptWorld.
(webkitScriptWorldWindowObjectCleared): Emit
WebKitScriptWorld::window-object-cleared signal.
(webkitScriptWorldCreate): Create a new WebKitScriptWorld wrapping
the given injected bundle script world.
(createDefaultScriptWorld): Create the default WebKitScriptWorld
wrapping the normal world.
(webkit_script_world_get_default): Return the default WebKitScriptWorld.
(webkit_script_world_new): Create a new isolated WebKitScriptWorld.

  • WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.h: Added.
  • WebProcess/InjectedBundle/API/gtk/WebKitScriptWorldPrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(didClearWindowObjectForFrame): Call webkitScriptWorldWindowObjectCleared().
(webkitWebPageCreate): Add implementation for callback
didClearWindowObjectForFrame in injected bundle loader client.

  • WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Include WebKitScriptWorld.h.

8:02 AM Changeset in webkit [154602] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[WebKit2] Offsets for WKBundlePageLoaderClient in APIClientTraits are wrong
​https://bugs.webkit.org/show_bug.cgi?id=120268

Reviewed by Anders Carlsson.

  • Shared/APIClientTraits.cpp: Use always the first member of every

version as the offset of the version.

6:32 AM Changeset in webkit [154601] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[GTK] Include most of the WebKit2 unit tests into the build and testing
​https://bugs.webkit.org/show_bug.cgi?id=120307

Reviewed by Philippe Normand.

There are still various unit test source files that are not being included into
the build. This patch includes most of these, only leaving out tests that do not
compile or test features that are not supported by the GTK port.

  • Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.

(TestRunner):

  • TestWebKitAPI/GNUmakefile.am:
6:27 AM MemoryCache edited by w.bielawski@samsung.com
(diff)
6:10 AM Changeset in webkit [154600] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Allow to run tests without Xvfb in run-gtk-tests
​https://bugs.webkit.org/show_bug.cgi?id=120298

Reviewed by Philippe Normand.

Add --no-xvfb command line option to run tests in the current
display.

  • Scripts/run-gtk-tests:

(TestRunner._run_xvfb): Return early if option --no-xvfb has been
passed.
(TestRunner._setup_testing_environment): Use helper function
_run_xvfb to start Xvfb if needed.
(TestRunner._tear_down_testing_environment): Check Xvfb is
actually running before trying to terminate it.

6:04 AM MemoryCache.png attached to MemoryCache by w.bielawski@samsung.com
6:02 AM MemoryCache created by w.bielawski@samsung.com
5:51 AM WikiStart edited by w.bielawski@samsung.com
(diff)
5:45 AM Changeset in webkit [154599] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK L10N] Updated Brazilian Portuguese translation for WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=120193

Patch by Enrico Nicoletto <​liverig@gmail.com> on 2013-08-26
Reviewed by Gustavo Noronha Silva.

  • pt_BR.po: Updated.
4:59 AM Changeset in webkit [154598] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Tools

Adding Gabor Abraham to contributors.json.

Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/common/config/contributors.json:
4:13 AM Changeset in webkit [154597] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Move DocumentTiming inside ENABLE(WEB_TIMING) guards.
<​https://webkit.org/b/120281>

Reviewed by Anders Carlsson.

Looks like this struct is only used by other ENABLE(WEB_TIMING) code, so don't bother
filling it in if we're not building like that.

  • dom/Document.cpp:

(WebCore::Document::setReadyState):
(WebCore::Document::finishedParsing):

  • dom/Document.h:
  • dom/DocumentTiming.h:
3:43 AM Changeset in webkit [154596] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. EFL WK1 DRT doesn't support exif-orientation tests

  • platform/efl-wk1/TestExpectations: Add fast/images/exif-orientation-composited.html as failure.
3:36 AM Changeset in webkit [154595] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Add support for passing test directories to run-gtk-tests
​https://bugs.webkit.org/show_bug.cgi?id=120296

Reviewed by Philippe Normand.

  • Scripts/run-gtk-tests:

(TestRunner._get_tests_from_dir): Helper function to return all
unit tests found in a given directory.
(TestRunner._get_tests): Check the given tests passed in the
command line, so that if a directory is found the tests contained
in the directory are added to the list of tests to run.

3:31 AM Changeset in webkit [154594] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Improve the stop/reload button implementation in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=120292

Reviewed by Philippe Normand.

  • Use an instance member of BrowserWindow for the button widget instead of a global variable.
  • Use notify::is-loading to monitor the WebView load instead of the estimated-load-progress property.
  • Use webkit_web_view_is_loading() to check whether the view is loading to change the button icon instead of a string comparison of the gtk stock icon id.
  • Use the right casts to fix compile warning.
  • MiniBrowser/gtk/BrowserWindow.c:

(reloadOrStopCallback):
(webViewLoadProgressChanged):
(webViewIsLoadingChanged):
(browser_window_init):
(browserWindowConstructed):

3:07 AM Changeset in webkit [154593] by commit-queue@webkit.org
  • 4 edits in trunk

[Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
​https://bugs.webkit.org/show_bug.cgi?id=119791

Source/WebKit/qt:

Patch by Arunprasad Rajkumar <​arurajku@cisco.com> on 2013-08-26
Reviewed by Jocelyn Turcotte.

  • WidgetApi/qwebpage.cpp:

(QWebPage::javaScriptConsoleMessage): Removed hack specific to DRT, introduced by
(r61433).

Tools:

Patch by Arunprasad Rajkumar <​arurajku@cisco.com> on 2013-08-26
Reviewed by Jocelyn Turcotte.

Load empty url to send onunload event to currently running page. onunload event is
mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
LayoutTests/plugins/geturlnotify-during-document-teardown.html.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebPage::~WebPage):

1:43 AM Changeset in webkit [154592] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
​https://bugs.webkit.org/show_bug.cgi?id=120290

Reviewed by Philippe Normand.

  • MiniBrowser/gtk/GNUmakefile.am: Add

-DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.

1:04 AM Changeset in webkit [154591] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Add missing initializer for pluginLoadPolicy in WKPageLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=120289

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Add initializer for pluginLoadPolicy
and rename the comment of the previous one as
pluginLoadPolicy_deprecatedForUseWithV2.

12:53 AM Changeset in webkit [154590] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
​https://bugs.webkit.org/show_bug.cgi?id=120288

Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled

into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
These unit tests are at the moment failing in debug configurations, so it would be nice to
have the GTK builds report these failures as well.

12:47 AM Changeset in webkit [154589] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] webkitCredentialGetCredential returns a temporary in g_return_val_if_fail
​https://bugs.webkit.org/show_bug.cgi?id=120287

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/WebKitCredential.cpp:

(webkitCredentialGetCredential): Use ASSERT() instead of
g_return_val_if_fail() since this is a private function.

12:45 AM Changeset in webkit [154588] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Fix compile warning in WebKitDOMCustom
​https://bugs.webkit.org/show_bug.cgi?id=120286

Reviewed by Philippe Normand.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_element_get_item_type): Add return 0.

Note: See TracTimeline for information about the timeline view.