⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 31, 2013:

11:26 PM Changeset in webkit [154939] by Darin Adler
  • 7 edits in trunk/Source/WebCore

Refactor URL and image writing so layer-violating parts are in Editor, not Pasteboard (Mac-only at first)
​https://bugs.webkit.org/show_bug.cgi?id=120573

Reviewed by Andreas Kling.

  • editing/Editor.cpp:

(WebCore::Editor::copy): Use writeImageToPasteboard instead of Pasteboard::writeImage on Mac.
(WebCore::Editor::copyURL): Use writeURLToPasteboard instead of Pasteboard::writeURL on Mac.
(WebCore::innerNonSharedElement): Added. Used in copyImage.
(WebCore::Editor::copyImage): Use innerNonSharedElement instead of innerNonSharedNode.
Use writeImageToPasteboard instead of Pasteboard::writeImage on Mac.

  • editing/Editor.h: Add new functions, writeURLToPasteboard and writeImageToPasteboard,

both Mac-only for now.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::pasteWithPasteboard): Removed unneeded "m_frame.editor()" round trip that
was left behind in this function.
(WebCore::getImage): Added. Helper used by writeImageToPasteboard.
(WebCore::Editor::writeURLToPasteboard): Added. Sets up PasteboardURL and then calls
Pasteboard::write with it.
(WebCore::Editor::writeImageToPasteboard): Added. Sets up PasteboardImage and then calls
Pasteboard::write with it.

  • page/DragController.cpp:

(WebCore::DragController::startDrag): Use Editor::writeURLToPasteboard instead of
Pasteboard::writeURL on Mac.

  • platform/Pasteboard.h: Added PasteboardURL and PasteboardImage structures.

Declare write functions for PasteboardWebContent, PasteboardURL, and PasteboardImage.
Guard writeURL and writeImage with !PLATFORM(MAC).

  • platform/mac/PasteboardMac.mm:

(WebCore::writeURLForTypes): Changed this to take a PasteboardURL.
(WebCore::Pasteboard::write): Renamed writeURL and writeImage to this. Refactor both
to take PasteboardURL and PasteboardImage arguments.
(WebCore::fileWrapper): Renamed from fileWrapperForImage since the fact that this is
for an image is now clear from its argument, a PasteboardImage.
(WebCore::writeFileWrapperAsRTFDAttachment): Changed this function to use early return.

10:30 PM Changeset in webkit [154938] by akling@apple.com
  • 69 edits in trunk/Source/WebCore

EditCommand constructors should take Document&.
<​https://webkit.org/b/120566>

Reviewed by Darin Adler.

Let EditCommand's and all subclass constructors take Document& instead of Document*.
EditCommand::document() now returns a Document&.

Added Editor::document() which returns Editor::frame().document() after asserting
that it's non-null, to make passing a Document& from Editor functions easier.

10:29 PM Changeset in webkit [154937] by akling@apple.com
  • 42 edits in trunk/Source/WebCore

Make more use of toRenderFoo(RenderObject&) cast helpers.
<​https://webkit.org/b/120565>

Reviewed by Darin Adler.

To make amends for putting ugly toRenderFoo(&renderer) casts everywhere,
here's a patch that switches a bunch of code over to using reference-based casts.

I removed pointer-based casts altogether for these renderers:

  • RenderBR
  • RenderCombineText
  • RenderListMarker
  • RenderVideo
  • RenderView
10:04 PM Changeset in webkit [154936] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

warning: unused parameter ‘renderingMode' in ImageBufferCairo.cpp:94
​https://bugs.webkit.org/show_bug.cgi?id=120543

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-08-31
Reviewed by Darin Adler.

Fixing warning by adding ASSERT_UNUSED.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

7:02 PM Changeset in webkit [154935] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

CodeBlock refactoring broke profile dumping
​https://bugs.webkit.org/show_bug.cgi?id=120551

Reviewed by Michael Saboff.

Fix the bug, and did a big clean-up of how Executable returns CodeBlocks. A lot
of the problems we have with code like CodeBlock::baselineVersion() is that we
were trying *way too hard* to side-step the fact that Executable can't return a
CodeBlock*. Previously it could only return CodeBlock&, so if it didn't have a
CodeBlock yet, you were screwed. And if you didn't know, or weren't sure, if it
did have a CodeBlock, you were really going to have a bad time. Also it really
bugs me that the methods were called generatedBytecode(). In all other contexts
if you ask for a CodeBlock, then method to call is codeBlock(). So I made all
of those changes.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::baselineVersion):
(JSC::ProgramCodeBlock::replacement):
(JSC::EvalCodeBlock::replacement):
(JSC::FunctionCodeBlock::replacement):
(JSC::CodeBlock::globalObjectFor):

  • bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::hash):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • jit/JITCode.h:

(JSC::JITCode::isExecutableScript):
(JSC::JITCode::isLowerTier):

  • jit/JITStubs.cpp:

(JSC::lazyLinkFor):
(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

  • runtime/Executable.cpp:

(JSC::ScriptExecutable::installCode):

  • runtime/Executable.h:

(JSC::EvalExecutable::codeBlock):
(JSC::ProgramExecutable::codeBlock):
(JSC::FunctionExecutable::eitherCodeBlock):
(JSC::FunctionExecutable::codeBlockForCall):
(JSC::FunctionExecutable::codeBlockForConstruct):
(JSC::FunctionExecutable::codeBlockFor):

  • runtime/FunctionExecutableDump.cpp:

(JSC::FunctionExecutableDump::dump):

5:21 PM Changeset in webkit [154934] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

warning: unused parameter point and area in EwkView.cpp:1390
​https://bugs.webkit.org/show_bug.cgi?id=120545

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-08-31
Reviewed by Darin Adler.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::didFindZoomableArea): Added UNUSED_PARAM.

2:56 PM Changeset in webkit [154933] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix typo in r154931 that caused assertions in continuation tests.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint):

2:05 PM Changeset in webkit [154932] by rwlbuis@webkit.org
  • 4 edits in trunk

XMLSerializer-attribute-namespace-prefix-conflicts can't produce reliable results
​https://bugs.webkit.org/show_bug.cgi?id=120490

Reviewed by Ryosuke Niwa.

Source/WebCore:

Retain the key of the namespaces map by using AtomicString as key instead of AtomicStringImpl*.

  • editing/MarkupAccumulator.h:

LayoutTests:

Unskip these previously failing tests.

11:34 AM Changeset in webkit [154931] by akling@apple.com
  • 42 edits in trunk/Source/WebCore

InlineBox::renderer() and pals should return references.
<​https://webkit.org/b/120562>

Reviewed by Antti Koivisto.

Make InlineBox::renderer() and its friends return references instead of pointers.
Every box always has a renderer, so this clears up any ambiguity, and a number of
weird assertions in SVG code.

Made InlineBox::m_renderer private so subclasses have to go through renderer().
The next step will be to replace renderer() with tightly-typed accessors where
applicable (e.g InlineTextBox's renderer is always a RenderText.)

Also added reference versions of these RenderObject casts:

  • toRenderBox()
  • toRenderBlock()
  • toRenderInline()
  • toRenderSVGInlineText()
8:18 AM Changeset in webkit [154930] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove unused variable in LayerTreeHost
​https://bugs.webkit.org/show_bug.cgi?id=118950

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-08-31
Reviewed by Anders Carlsson.

m_waitingForUIProcess has been renamed to m_isWaitingForRenderer as of
r152183, and it is a private variable in CoordinatedLayerTreeHost. Thus,
we don't need m_waitingForUIProcess in LayerTreeHost.

  • WebProcess/WebPage/LayerTreeHost.h:
7:14 AM Changeset in webkit [154929] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

PostAttachCallbackDisabler should take a ContainerNode&.
<​https://webkit.org/b/120560>

Reviewed by Antti Koivisto.

Let PostAttachCallbackDisabler take a reference and remove an ugly assertion.

  • dom/ContainerNode.h:

(WebCore::PostAttachCallbackDisabler::PostAttachCallbackDisabler):
(WebCore::PostAttachCallbackDisabler::~PostAttachCallbackDisabler):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachRenderTree):

7:12 AM Changeset in webkit [154928] by Antti Koivisto
  • 28 edits
    2 moves in trunk/Source/WebCore

Rename ChildIterator -> ElementChildIterator, DescendantIterator -> ElementDescendantIterator
​https://bugs.webkit.org/show_bug.cgi?id=120561

Reviewed by Andreas Kling.

New names are more descriptive and consistent. They also put related iterator files close by in file lists.
The types are always used with auto so longer names don't make them any clumsier to use.

For simplicity included all Element iterator types from ElementIterator.h so it is the only file that has
to be included by the clients.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityTable.cpp:
  • css/CSSFontFaceSource.cpp:
  • dom/ChildIterator.h: Removed.
  • dom/DescendantIterator.h: Removed.
  • dom/Document.cpp:
  • dom/ElementChildIterator.h: Copied from Source/WebCore/dom/ChildIterator.h.

(WebCore::::ElementChildIterator):
(WebCore::::operator):
(WebCore::::ElementChildConstIterator):
(WebCore::::ElementChildIteratorAdapter):
(WebCore::::begin):
(WebCore::::end):
(WebCore::::ElementChildConstIteratorAdapter):
(WebCore::elementChildren):
(WebCore::childrenOfType):

  • dom/ElementDescendantIterator.h: Copied from Source/WebCore/dom/DescendantIterator.h.

(WebCore::::ElementDescendantIterator):
(WebCore::::operator):
(WebCore::::ElementDescendantConstIterator):
(WebCore::::ElementDescendantIteratorAdapter):
(WebCore::::begin):
(WebCore::::end):
(WebCore::::ElementDescendantConstIteratorAdapter):
(WebCore::elementDescendants):
(WebCore::descendantsOfType):

  • dom/ElementIterator.h:
  • dom/Node.cpp:
  • dom/TreeScope.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/markup.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLFieldSetElement.cpp:
  • html/HTMLLabelElement.cpp:
  • html/HTMLMapElement.cpp:
  • html/HTMLMediaElement.cpp:
  • html/HTMLObjectElement.cpp:
  • loader/PlaceholderDocument.cpp:
  • rendering/FilterEffectRenderer.cpp:
  • style/StyleResolveTree.cpp:
  • svg/SVGElement.cpp:
  • svg/SVGSVGElement.cpp:
  • svg/animation/SMILTimeContainer.cpp:
  • svg/graphics/SVGImage.cpp:
7:07 AM Changeset in webkit [154927] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Don't do document style recalc unless there's a RenderView.
<​https://webkit.org/b/120558>

Reviewed by Antti Koivisto.

There's no sense in computing style for a Document that has no RenderView.
Checking this before continuing also lets us know that there's a Frame & FrameView
present, simplifying some things later on.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

6:04 AM Changeset in webkit [154926] by Antti Koivisto
  • 7 edits
    1 move
    1 add in trunk/Source/WebCore

Add common base for element iterators
​https://bugs.webkit.org/show_bug.cgi?id=120557

Reviewed by Andreas Kling.

Add ElementIterator and use it as the base for child and descendant iterators. The only difference is the definition of operator++.

Also renamed DescendantIteratorAssertions to ElementIteratorAssertions.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ChildIterator.h:

(WebCore::::ChildIterator):
(WebCore::::operator):
(WebCore::::ChildConstIterator):
(WebCore::::begin):
(WebCore::::end):

  • dom/DescendantIterator.h:

(WebCore::::DescendantIterator):
(WebCore::::operator):
(WebCore::::DescendantConstIterator):

  • dom/DescendantIteratorAssertions.h: Removed.
  • dom/ElementIterator.h: Added.

(WebCore::::ElementIterator):
(WebCore::::traverseNext):
(WebCore::::traversePrevious):
(WebCore::::traverseNextSibling):
(WebCore::::traversePreviousSibling):
(WebCore::::operator):
(WebCore::=):
(WebCore::::ElementConstIterator):

  • dom/ElementIteratorAssertions.h: Copied from Source/WebCore/dom/DescendantIteratorAssertions.h.

(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):
(WebCore::ElementIteratorAssertions::domTreeHasMutated):
(WebCore::ElementIteratorAssertions::dropEventDispatchAssertion):

Aug 30, 2013:

7:16 PM Changeset in webkit [154925] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Fix the Mac results.

  • platform/mac/compositing/video/video-object-fit-expected.txt:
6:10 PM Changeset in webkit [154924] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Build fix after r154921.

AVFoundationCF uses an internal wrapper object around the C-API. The call point
in the original patch was inside the wrapper, which did not (yet) provide
a method implementation.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::updateVideoLayerGravity):
(WebCore::AVFWrapper::updateVideoLayerGravity):

5:24 PM Changeset in webkit [154923] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix.

  • win/AssembleBuildLogs/AssembleLogs.cmd: Make sure WebInspectorUI build output is reported

from the build machines.

5:22 PM Changeset in webkit [154922] by Brent Fulgham
  • 5 edits
    1 delete in trunk/Source

Source/WebInspectorUI: [Windows] Correct windows build. Get rid of unnecessary pre-build step. We don't build anything
in this project, just copy some files into the WebKit resource folder. This was fooling the
build system into thinking something failed, resulting in a build error.

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove reference to WebInspectorUIPreBuild.cmd
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
  • WebInspectorUI.vcxproj/WebInspectorUIPreBuild.cmd: Removed.

Source/WebKit: [Windows] Unreviewed build correction.
Update project dependencies so that build logs on machines will include output from the
WebInspectorUI project.

  • WebKit.vcxproj/WebKit.sln:
5:14 PM Changeset in webkit [154921] by Simon Fraser
  • 23 edits
    9 adds in trunk

Video with object-fit: cover can spill outside the box
​https://bugs.webkit.org/show_bug.cgi?id=52103

Source/WebCore:

Reviewed by Dean Jackson.

object-fit on renderers which use accelerated compositing needs special
treatment.

For directly composited images, and video, GraphicsLayer needs to know
both the size of the content layer, and also a rectangle at which this
should be clipped (because, for the first time, that content layer can be
larger than the renderer's content box).

AVFoundation would always aspect-ratio fit video by default, so plumb
through MediaPlayer a way to override that when object-fit requires it.

Added a LAYER_TREE_INCLUDES_CONTENT_LAYERS enum to the layerTreeAsText()
flags so we can dump content layers for testing.

Tests: compositing/images/direct-image-object-fit.html

compositing/reflections/direct-image-object-fit-reflected.html
compositing/video/video-object-fit.html

  • page/Frame.h: New LayerTreeFlagsIncludeContentLayers flag.
  • platform/graphics/GraphicsLayer.h: New flag.
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::shouldMaintainAspectRatio):
(WebCore::MediaPlayer::setShouldMaintainAspectRatio):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::shouldMaintainAspectRatio):
(WebCore::MediaPlayerPrivateInterface::setShouldMaintainAspectRatio):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::setShouldMaintainAspectRatio):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::updateVideoLayerGravity):
(WebCore::AVFWrapper::platformLayer):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):

  • platform/graphics/ca/GraphicsLayerCA.cpp: We need a new m_contentsClippingLayer to

clip the contents layer, which only gets created when necessary. It has to be cloned
for reflections.
(WebCore::GraphicsLayerCA::willBeDestroyed):
(WebCore::GraphicsLayerCA::setContentsRect):
(WebCore::GraphicsLayerCA::setContentsClippingRect):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsMediaLayer):
(WebCore::GraphicsLayerCA::updateContentsCanvasLayer):
(WebCore::GraphicsLayerCA::updateContentsColorLayer):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):
(WebCore::GraphicsLayerCA::ensureCloneLayers):
(WebCore::GraphicsLayerCA::removeCloneLayers):
(WebCore::GraphicsLayerCA::fetchCloneLayers):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.cpp: Need to push both the contentsRect and

the contentsClippingRect down to the GraphicsLayers. Most of the time they
are the same, unless object-fit makes them different.
(WebCore::RenderLayerBacking::resetContentsRect):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::contentsBox):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer):

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Reviewed by Dean Jackson.

Test cases for directly composited image with object-fit, the same with
reflections, and one with video.

Tests dump content GraphicsLayers, so have platform-specific results.

  • compositing/images/direct-image-object-fit-expected.txt: Added.
  • compositing/images/direct-image-object-fit.html: Added.
  • compositing/reflections/direct-image-object-fit-reflected-expected.txt: Added.
  • compositing/reflections/direct-image-object-fit-reflected.html: Added.
  • compositing/video/video-object-fit-expected.txt: Added.
  • compositing/video/video-object-fit.html: Added.
  • media/video-object-fit-change.html: Fixed
  • platform/mac/TestExpectations: Unskip two tests.
  • platform/mac/compositing/images/direct-image-object-fit-expected.txt: Added.
  • platform/mac/compositing/reflections/direct-image-object-fit-reflected-expected.txt: Added.
  • platform/mac/compositing/video/video-object-fit-expected.txt: Added.
4:57 PM Changeset in webkit [154920] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix expected output

4:45 PM Changeset in webkit [154919] by Brent Fulgham
  • 4 edits in trunk/Source

Source/WebInspectorUI: [Windows] Build correction after dependency change.

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove circular dependency on

WebKit, and control this at the solution level. The prior change broke external
builders.

Source/WebKit: [Windows] Unreviewed build fix after r154917

  • WebKit.vcxproj/WebKit.sln: Establish build dependency from WebInspectorUI against

WebKit. Remove reverse dependency.

4:34 PM Changeset in webkit [154918] by dino@apple.com
  • 2 edits in trunk/LayoutTests

​http://webkit.org/b/120490
Skip some XML namespace serialization tests temporarily.

fast/dom/XMLSerializer-attribute-namespace-prefix-conflicts.html
fast/dom/XMLSerializer-same-prefix-different-namespaces-conflict.html
fast/dom/XMLSerializer-setAttributeNS-namespace-no-prefix.html
svg/custom/xlink-prefix-generation-in-attributes.html

4:13 PM Changeset in webkit [154917] by Brent Fulgham
  • 2 edits in trunk/Source/WebInspectorUI

[Windows] Unreviewed build gardening.

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Adjust build dependencies so

that WebInspectorUI 'builds' after WebKit so that the expected resource directory
structure is always in place.

3:55 PM Changeset in webkit [154916] by oliver@apple.com
  • 11 edits
    12 adds in trunk

Implement ES6 Set class
​https://bugs.webkit.org/show_bug.cgi?id=120549

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

We simply reuse the MapData type from JSMap making the
it much simpler.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::setStructure):

  • runtime/JSSet.cpp: Added.

(JSC::JSSet::visitChildren):
(JSC::JSSet::finishCreation):

  • runtime/JSSet.h: Added.

(JSC::JSSet::createStructure):
(JSC::JSSet::create):
(JSC::JSSet::mapData):
(JSC::JSSet::JSSet):

  • runtime/SetConstructor.cpp: Added.

(JSC::SetConstructor::finishCreation):
(JSC::callSet):
(JSC::constructSet):
(JSC::SetConstructor::getConstructData):
(JSC::SetConstructor::getCallData):

  • runtime/SetConstructor.h: Added.

(JSC::SetConstructor::create):
(JSC::SetConstructor::createStructure):
(JSC::SetConstructor::SetConstructor):

  • runtime/SetPrototype.cpp: Added.

(JSC::SetPrototype::finishCreation):
(JSC::getMapData):
(JSC::setProtoFuncAdd):
(JSC::setProtoFuncClear):
(JSC::setProtoFuncDelete):
(JSC::setProtoFuncForEach):
(JSC::setProtoFuncHas):
(JSC::setProtoFuncSize):

  • runtime/SetPrototype.h: Added.

(JSC::SetPrototype::create):
(JSC::SetPrototype::createStructure):
(JSC::SetPrototype::SetPrototype):

LayoutTests:

Add tests

  • fast/js/basic-set-expected.txt: Added.
  • fast/js/basic-set.html: Added.
  • fast/js/script-tests/basic-set.js: Added.

(set new):
(otherString.string_appeared_here.set add):
(try.set forEach):
(set forEach):
(set gc):

3:51 PM Changeset in webkit [154915] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Windows] Update to incorporate additional suggestions
​https://bugs.webkit.org/show_bug.cgi?id=120448

Reviewed by Darin Adler

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Add

notes as to why AVFoundationCF needs this extra method call.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Use OVERRIDE
  • rendering/RenderVideo.cpp: Replace ternary operator with logical &&.
3:37 PM Changeset in webkit [154914] by Brent Fulgham
  • 9 edits in trunk/Source/WebCore

[Windows] Vide element in page always uses non-hw accelerated mode.
​https://bugs.webkit.org/show_bug.cgi?id=120448

Reviewed by Darin Adler

This patch is unfortunately larger than my original idea, but seems to make the
layout system happier. Instead of switching into composited mode when building
the media player, we now build the original layout tree with compositing active
if the underlying media element requires it. The AVFoundationCF player needs to
have the compositor available at construction time so it can attach to the
rendering device. Otherwise it falls back to CPU-only mode.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::requiresImmediateCompositing): Added

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::requiresImmediateCompositing): Added

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayer): Added

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

(WebCore::MediaPlayerPrivateAVFoundationCF::requiresImmediateCompositing):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForVideo): Uses new
'requiresImmediateCompositing' to short-circuit check for whether a
compositor is required.

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::requiresImmediateCompositing):

  • rendering/RenderVideo.h:
3:12 PM Changeset in webkit [154913] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

3:10 PM Changeset in webkit [154912] by Lucas Forschler
  • 1 copy in tags/Safari-537.66

New Tag.

2:43 PM Changeset in webkit [154911] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Web Inspector: inspector/storage-panel-dom-storage-update.html is flakey on the bots
​https://bugs.webkit.org/show_bug.cgi?id=120544

Take 2, remove some more runAfterPendingDispatches which were somehow
causing WebKit 2 tests to fail. This requires us to be a bit more
careful when running the pending handlers as well.

Unreviewed test fix.

  • inspector/storage-panel-dom-storage-update.html:
2:42 PM Changeset in webkit [154910] by Joseph Pecoraro
  • 18 edits
    1 copy
    2 moves
    9 adds in trunk

Web Inspector: Breakpoints should have Automatically Continue Option
​https://bugs.webkit.org/show_bug.cgi?id=120187

Reviewed by Timothy Hatcher.

Source/WebCore:

Tests: inspector-protocol/debugger/removeBreakpoint.html

inspector-protocol/debugger/setBreakpoint-autoContinue.html
inspector-protocol/debugger/setBreakpoint-column.html
inspector-protocol/debugger/setBreakpoint-condition.html
inspector-protocol/debugger/setBreakpoint.html

  • inspector/Inspector.json:

Convert the "condition" argument of setBreakpoint and setBreakpointByUrl
to a BreakpointOptions object with optional properties. One of which
is "condition" and a new option "autoContinue".

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::pauseIfNeeded):
Automatically continue if the breakpoint was hit and has autoContinue.

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::buildObjectForBreakpointCookie):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/ScriptBreakpoint.h:

(WebCore::ScriptBreakpoint::ScriptBreakpoint):
Handle the new incoming BreakpointOptions type, and set the
autoContinue state on ScriptBreakpoints.

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpointByURL):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
Update old front-end to be compatible with the new API.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Breakpoint.css:

(#edit-breakpoint-popoover-auto-continue):
Misc. changes for UI.

  • UserInterface/Breakpoint.js:

(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get autoContinue):
(WebInspector.Breakpoint.prototype.set autoContinue):
(WebInspector.Breakpoint.prototype.get options):
(WebInspector.Breakpoint.prototype.get info):
General maintenance of the autoContinue state.

(WebInspector.Breakpoint.prototype._popoverToggleEnabledCheckboxChanged):
(WebInspector.Breakpoint.prototype._popoverToggleAutoContinueCheckboxChanged):
(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
Edit Breakpoint UI for setting autoContinue state.

  • UserInterface/InspectorBackend.js:

(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype._supports):
Extension to check if a BackendCommands method supports a particular param.

  • UserInterface/DebuggerManager.js:

(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype._setBreakpoint):

  • UserInterface/InspectorBackendCommands.js:

Change to backend agent calls for the new protocol API.

LayoutTests:

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.checkForError):
Helper for checking for, and logging, protocol error responses.

  • inspector/debugger/set-breakpoint.html:

Update this test for the protocol change.

  • inspector-protocol/debugger/removeBreakpoint-expected.txt: Added.
  • inspector-protocol/debugger/removeBreakpoint.html: Added.
  • inspector-protocol/debugger/resources/breakpoint.js: Added.
  • inspector-protocol/debugger/setBreakpoint-autoContinue-expected.txt: Added.
  • inspector-protocol/debugger/setBreakpoint-autoContinue.html: Added.
  • inspector-protocol/debugger/setBreakpoint-column.html: Renamed from LayoutTests/inspector-protocol/debugger/column-breakpoint.html.
  • inspector-protocol/debugger/setBreakpoint-column.txt: Renamed from LayoutTests/inspector-protocol/debugger/column-breakpoint-expected.txt.
  • inspector-protocol/debugger/setBreakpoint-condition-expected.txt: Added.
  • inspector-protocol/debugger/setBreakpoint-condition.html: Added.
  • inspector-protocol/debugger/setBreakpoint-expected.txt: Added.
  • inspector-protocol/debugger/setBreakpoint.html: Added.

Protocol tests for setting breakpoints. These test different aspects of
the Debugger domain (setBreakpoint variants and removeBreakpoint).

2:32 PM Changeset in webkit [154909] by dino@apple.com
  • 7 edits in trunk/Source/WebCore

Animations should use double for key values, not floats
​https://bugs.webkit.org/show_bug.cgi?id=120547

Reviewed by Simon Fraser.

Merge ​https://chromium.googlesource.com/chromium/blink/+/71de046541c77120874b9bff82958ee9e0e20c7c

Some files have been renamed in the Blink port, and they have made some
improvements, but I took what applied to us.

All our existing tests passed.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::keyframeStylesForAnimation):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::parseKeyString):

  • css/WebKitCSSKeyframeRule.h:

(WebCore::StyleKeyframe::getKeys):

  • platform/graphics/GraphicsLayer.h:

(WebCore::AnimationValue::keyTime):
(WebCore::AnimationValue::AnimationValue):
(WebCore::FloatAnimationValue::create):
(WebCore::FloatAnimationValue::FloatAnimationValue):
(WebCore::TransformAnimationValue::create):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::FilterAnimationValue::create):
(WebCore::FilterAnimationValue::FilterAnimationValue):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):

  • rendering/style/KeyframeList.h:

(WebCore::KeyframeValue::KeyframeValue):
(WebCore::KeyframeValue::key):
(WebCore::KeyframeValue::setKey):

1:17 PM Changeset in webkit [154908] by commit-queue@webkit.org
  • 22 edits
    1 copy
    37 adds in trunk

Source/WebCore: [GStreamer] support in-band text tracks
​https://bugs.webkit.org/show_bug.cgi?id=103771

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-08-30
Reviewed by Eric Carlson.

Tests: New tests added because existing tests were too specific.

media/track/in-band/track-in-band-kate-ogg-cues-added-once.html
media/track/in-band/track-in-band-kate-ogg-kind.html
media/track/in-band/track-in-band-kate-ogg-language.html
media/track/in-band/track-in-band-kate-ogg-mode.html
media/track/in-band/track-in-band-kate-ogg-style.html
media/track/in-band/track-in-band-kate-ogg-track-order.html
media/track/in-band/track-in-band-srt-mkv-cues-added-once.html
media/track/in-band/track-in-band-srt-mkv-kind.html
media/track/in-band/track-in-band-srt-mkv-language.html
media/track/in-band/track-in-band-srt-mkv-mode.html
media/track/in-band/track-in-band-srt-mkv-style.html
media/track/in-band/track-in-band-srt-mkv-track-order.html

  • CMakeLists.txt: Add InbandTextTrackPrivateGStreamer, InbandGenericTextTrack, InbandWebVTTTextTrack, and TextCombinerGStreamer files.
  • GNUmakefile.list.am: Same.
  • PlatformEfl.cmake: Same.
  • Target.pri: Same.
  • WebCore.vcxproj/WebCore.vcxproj: Same.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Same.
  • WebCore.xcodeproj/project.pbxproj: Same.
  • html/track/InbandGenericTextTrack.cpp: Split out code for handling generic cues.

(WebCore::GenericTextTrackCueMap::GenericTextTrackCueMap): Move from InbandTextTrack.
(WebCore::GenericTextTrackCueMap::~GenericTextTrackCueMap): Same.
(WebCore::GenericTextTrackCueMap::add): Same.
(WebCore::GenericTextTrackCueMap::find): Same.
(WebCore::GenericTextTrackCueMap::remove): Same.
(WebCore::InbandGenericTextTrack::create): Same.
(WebCore::InbandGenericTextTrack::updateCueFromCueData): Same.
(WebCore::InbandGenericTextTrack::addGenericCue): Same.
(WebCore::InbandGenericTextTrack::updateGenericCue): Same.
(WebCore::InbandGenericTextTrack::removeGenericCue): Same.
(WebCore::InbandGenericTextTrack::removeCue): Same.
(WebCore::InbandGenericTextTrack::InbandGenericTextTrack): Empty.
(WebCore::InbandGenericTextTrack::~InbandGenericTextTrack): Empty.

  • html/track/InbandGenericTextTrack.h: Copied from Source/WebCore/html/track/InbandTextTrack.h.

The only addition is the ASSERT_NOT_REACHED() for WebVTT cues.

  • html/track/InbandTextTrack.cpp: Add label and language changed callbacks.

(WebCore::InbandTextTrack::create): Return a generic or WebVTT text track based on the private CueFormat.
(WebCore::InbandTextTrack::labelChanged): Added.
(WebCore::InbandTextTrack::languageChanged): Added.

  • html/track/InbandTextTrack.h: Add label and language changed callbacks.
  • html/track/InbandWebVTTTextTrack.cpp: Added, based on InbandTextTrack.

(WebCore::InbandWebVTTTextTrack::create): Same.
(WebCore::InbandWebVTTTextTrack::InbandWebVTTTextTrack): Empty.
(WebCore::InbandWebVTTTextTrack::~InbandWebVTTTextTrack): Empty.
(WebCore::InbandWebVTTTextTrack::parseWebVTTCueData): Sends data to a WebVTTParser.
(WebCore::InbandWebVTTTextTrack::newCuesParsed): Adds cues when WebVTTParser parses them.
(WebCore::InbandWebVTTTextTrack::fileFailedToParse): Prints a warning when WebVTTParser has a problem.

  • html/track/InbandWebVTTTextTrack.h: Added.
  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::cueFormat): For determining if the track will have generic or WebVTT cues.
(WebCore::InbandTextTrackPrivate::InbandTextTrackPrivate): Pass CueFormat in the constructor.

  • platform/graphics/InbandTextTrackPrivateClient.h: Same.
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Pass CueFormat (Generic) to InbandTextTrackPrivate.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Add GRefPtr specializations for GstSample and GstEvent.
  • platform/graphics/gstreamer/GRefPtrGStreamer.h: Same.
  • platform/graphics/gstreamer/GStreamerUtilities.h: Add WARN_MEDIA_MESSAGE.
  • platform/graphics/gstreamer/GStreamerVersioning.h: Add a function to check GStreamer version at runtime.
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp: Added.

(WebCore::textTrackPrivateEventCallback): Watches for tag and stream start events.
(WebCore::textTrackPrivateSampleTimeoutCallback): See notifyTrackOfSample();
(WebCore::textTrackPrivateStreamTimeoutCallback): See notifyTrackOfStreamChanged();
(WebCore::textTrackPrivateTagsChangeTimeoutCallback): See notifyTrackOfTagsChanged();
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer): Initializes tags and stream and sets up event callback.
(WebCore::InbandTextTrackPrivateGStreamer::~InbandTextTrackPrivateGStreamer): Calls disconnect:
(WebCore::InbandTextTrackPrivateGStreamer::disconnect): Removes signal handlers and frees some memory.
(WebCore::InbandTextTrackPrivateGStreamer::handleSample): Adds samples to a list and sets up callback.
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged): Sets up callback.
(WebCore::InbandTextTrackPrivateGStreamer::tagsChanged): Same.
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample): Parses all queued samples with WebVTTParser.
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfStreamChanged): Keeps track of current stream.
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfTagsChanged): Sets label and language from tags.

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h: Added.

(WebCore::InbandTextTrackPrivateGStreamer::create): Basic RefPtr create function.
(WebCore::InbandTextTrackPrivateGStreamer::pad): Returns the pad this track is associated with (used
to determine if a playbin text stream has already been associated with a text track).
(WebCore::InbandTextTrackPrivateGStreamer::setIndex): Sets the track index (used for sorting).
(WebCore::InbandTextTrackPrivateGStreamer::streamId): Returns the stream ID (used to handle new samples).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mediaPlayerPrivateTextChangedCallback): Called for playbin "text-changed" event. See textChanged().
(WebCore::mediaPlayerPrivateTextChangeTimeoutCallback): See notifyPlayerOfText().
(WebCore::mediaPlayerPrivateNewTextSampleCallback): See newTextSample().
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): Initialize m_textTimerHandler.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): Disconnect text tracks (they don't necessarily
get freed here, since a script could hold a reference).
(WebCore::MediaPlayerPrivateGStreamer::textChanged): Setup callback for notifyPlayerOfText.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText): Create text tracks.
(WebCore::MediaPlayerPrivateGStreamer::newTextSample): Handle new samples by giving them to a text track
with a matching stream. This method is syncryonous because we need to get the stream start sticky event
immediately.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp: Added. This element forwards buffers from all

of its input pads, but also converts plain text to WebVTT as needed.
(webkit_text_combiner_init): Setup internal funnel.
(webkitTextCombinerPadEvent): If the caps are plain text make sure we have a webvttenv, otherwise connect
directly to the funnel.
(webkitTextCombinerRequestNewPad): Setup ghostpad and event callback.
(webkitTextCombinerReleasePad): Release pad and optional associated webvttenc.
(webkit_text_combiner_class_init): Setup pad templates and request/release pad functions.
(webkitTextCombinerNew): Returns a new WebKitTextCombiner.

  • platform/graphics/gstreamer/TextCombinerGStreamer.h: Added.
  • platform/graphics/gstreamer/TextSinkGStreamer.cpp: Added.

(webkit_text_sink_init): Set sync=false.
(webkitTextSinkGetProperty): Ignore sync property.
(webkitTextSinkSetProperty): Same.
(webkitTextSinkQuery): Ignore position and duration queries, forward everything else to appsink.
(webkit_text_sink_class_init): Setup property and query functions.
(webkitTextSinkNew): Return a new WebKitTextSink.

  • platform/graphics/gstreamer/TextSinkGStreamer.h: Added.

LayoutTests: <​https://webkit.org/b/103771> [GStreamer] support in-band text tracks

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-08-30
Reviewed by Eric Carlson.

  • media/content/counting-subtitled-kate.ogv: Added.
  • media/content/counting-subtitled-srt.mkv: Added.
  • media/in-band-cues.js: Added.
  • media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt: Added.
  • media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Added.
  • media/track/in-band/track-in-band-kate-ogg-kind-expected.txt: Added.
  • media/track/in-band/track-in-band-kate-ogg-kind.html: Added.
  • media/track/in-band/track-in-band-kate-ogg-language-expected.txt: Added.
  • media/track/in-band/track-in-band-kate-ogg-language.html: Added.
  • media/track/in-band/track-in-band-kate-ogg-mode-expected.txt: Added.
  • media/track/in-band/track-in-band-kate-ogg-mode.html: Added.
  • media/track/in-band/track-in-band-kate-ogg-style-expected.txt: Added.
  • media/track/in-band/track-in-band-kate-ogg-style.html: Added.
  • media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt: Added.
  • media/track/in-band/track-in-band-kate-ogg-track-order.html: Added.
  • media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt: Added.
  • media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Added.
  • media/track/in-band/track-in-band-srt-mkv-kind-expected.txt: Added.
  • media/track/in-band/track-in-band-srt-mkv-kind.html: Added.
  • media/track/in-band/track-in-band-srt-mkv-language-expected.txt: Added.
  • media/track/in-band/track-in-band-srt-mkv-language.html: Added.
  • media/track/in-band/track-in-band-srt-mkv-mode-expected.txt: Added.
  • media/track/in-band/track-in-band-srt-mkv-mode.html: Added.
  • media/track/in-band/track-in-band-srt-mkv-style-expected.txt: Added.
  • media/track/in-band/track-in-band-srt-mkv-style.html: Added.
  • media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt: Added.
  • media/track/in-band/track-in-band-srt-mkv-track-order.html: Added.
  • platform/mac/TestExpectations: Skip MKV and OGG tests.
1:01 PM Changeset in webkit [154907] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Web Inspector: inspector/storage-panel-dom-storage-update.html is flakey on the bots
​https://bugs.webkit.org/show_bug.cgi?id=120544

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-08-30
Reviewed by Dean Jackson.

Explicitly listen for events instead of running callbacks after a delay.

  • inspector/storage-panel-dom-storage-update.html:
12:29 PM Changeset in webkit [154906] by krit@webkit.org
  • 35 edits
    3 adds in trunk

Animate CSS Image filter() function
​https://bugs.webkit.org/show_bug.cgi?id=119938

Reviewed by Simon Fraser.

Source/WebCore:

With this patch, the new introduced CSS Image function filter() can be
animated. According to the spec, just filter functions can be
interpolated.

The patch also prepares StyleImage blending for interpolation of other
generated images like gradients or cross-fade().

​http://dev.w3.org/fxtf/filters/#interpolating-filter-image

Test: fast/filter-image/filter-image-animation.html

  • css/CSSComputedStyleDeclaration.cpp: Reuse the code that creates a

CSSValueList from ComputeStyle logic.

(WebCore::valueForPixel):

For StyleRules we want to have not-adjusted length values.

(WebCore::ComputedStyleExtractor::valueForShadow):

Add argument to switch between adjusted and not-adjusted length.

(WebCore::ComputedStyleExtractor::valueForFilter):

Ditto.

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFilterImageValue.h: Add helper functions

for animating filters. We need to pass the FilterOperations for
the image generation and the CSSValueList for StyleRule.

(WebCore::CSSFilterImageValue::filterOperations):
(WebCore::CSSFilterImageValue::setFilterOperations):
(WebCore::CSSFilterImageValue::cachedImage):

  • page/animation/CSSPropertyAnimation.cpp:

Add animation code to support animations between two filter()
function values.

(WebCore::blendFilterOperations):
(WebCore::blendFunc):
(WebCore::filterBlend):

  • rendering/style/StyleGeneratedImage.h: Add helper functions.

(WebCore::CSSFilterImageValue::imageValue):

LayoutTests:

Add tests to test animation between two filter() function values.
Furthermore, extended animation-test-helpers.js to parse all kind of CSS
image function where we support animations. CSS Image function can be
deeply nested as well now:

-wekit-filter(-webkit-cross-fade(url(a.png), url(b.png), 50%), sepia(0.5))

Even the 50% can now be checked with a tolerance. If we should ever support
animations on nested CSS Images, the new code in animation-test-helpers.js
is prepared for it.

Fixed a bunch of tests that passed by accident or needed an update to the new
infrastructure.

  • animations/resources/animation-test-helpers.js:

(parseCSSImage): For parsing of all kind of supported CSS Image functions.

Currently supported: -webkit-cross-fade, -webkit-filter, url, none
Still missing: linear and radial gradients (can not be animated yet).
CSS Image functions are allowed to be nested as deep JS allows.

(parseCrossFade): Add parsing of input CSS images.
(parseFilterImage): Parse -webkit-filter image function as well as input images.
(parseFilterFunctionList): Parse filter function list. We now parse the

function name as well. Added rudimentary support for drop-shadow and url.

(parseDeprecatedCustomFilterFunction): Special case old syntax of custom

filter function. Shall be removed in the future.

(compareCSSImages): Compares all kind (even deep nested) CSS images.
(compareFilterFunctions): Now compare filter function names as well.
(comparePropertyValue): Use new compareCSSImages function.

  • fast/filter-image/filter-image-animation-expected.txt: Added.
  • fast/filter-image/filter-image-animation.html: Added.
12:21 PM Changeset in webkit [154905] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make sure remove CachedResourceClient when destructing IconLoader
​https://bugs.webkit.org/show_bug.cgi?id=120541

Patch by Leo Yang <​leoyang@blackberry.com> on 2013-08-30
Reviewed by Darin Adler.

It's a good practice to call CachedResource::removeClient(client)
when the client is being destructed. We need to do this for InconLoader
to prevent m_resource from keeping dangling client in case m_resource
is referenced by someone else in the future.

Found by code inspection. Just a defensive enhancement no new tests.

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::~IconLoader):

11:58 AM Changeset in webkit [154904] by hmuller@adobe.com
  • 10 edits
    1 delete in trunk/Source/WebCore

[CSS Shapes] Redefine the ShapeIntervals class as a template
​https://bugs.webkit.org/show_bug.cgi?id=120381

Reviewed by Alexandru Chiculita.

No new tests, this was just an internal refactoring.

The existing ShapeIntervals class has been converted into a template whose
type specifies the type of the interval's x1 and x2 horizontal endpoints
(formerly float). There were several other minor changes, all in the realm
of refactoring:

  • The original type was a struct with public x1 and x2 fields. It's now a class

with x1 and x2 accessors. ASSERTS are now used to maintain the x2 >= x1 invariant.
In the original code the invariant was not checked.

  • The logical comparison operators have been overloaded for ShapeInterval.

This obviates the IntervalX1Comparator class which has been removed.

  • The names of the global ShapeInterval Vector set operation methods have been

changed to reflect the fact that they're now members of the template class,
rather than globals.

PolygonShape.cpp depended on the ShapeInterval class. In the one or two places
where an interval's x1 or x1 fields had been set explicitly, ShapeInterval::set()
is now used to set both fields. This also enables the invariant check mentioned
earlier. The other changes to this class are syntatic, to account for the ShapeInterval
class's changes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/shapes/PolygonShape.cpp:

(WebCore::appendIntervalX):
(WebCore::computeXIntersections):
(WebCore::computeOverlappingEdgeXProjections):
(WebCore::PolygonShape::getExcludedIntervals):
(WebCore::PolygonShape::getIncludedIntervals):

  • rendering/shapes/PolygonShape.h:
  • rendering/shapes/ShapeInterval.cpp: Removed.
  • rendering/shapes/ShapeInterval.h: The entire implementation is now here.

(WebCore::ShapeInterval::ShapeInterval):
(WebCore::ShapeInterval::x1):
(WebCore::ShapeInterval::x2):
(WebCore::ShapeInterval::set):
(WebCore::ShapeInterval::overlaps):
(WebCore::ShapeInterval::intersect):
(WebCore::ShapeInterval::sortVector):
(WebCore::ShapeInterval::uniteVectors):
(WebCore::ShapeInterval::intersectVectors):
(WebCore::ShapeInterval::subtractVectors):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::operator< ):
(WebCore::operator> ):
(WebCore::operator<=):
(WebCore::operator>=):

11:43 AM Changeset in webkit [154903] by Antti Koivisto
  • 20 edits in trunk/Source/WebCore

Use Element& in StyleResolveTree
​https://bugs.webkit.org/show_bug.cgi?id=120540

Reviewed by Andreas Kling.

  • dom/ContainerNode.cpp:

(WebCore::attachChild):
(WebCore::detachChild):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::createRenderTree):
(WebCore::Document::detach):

  • dom/Element.cpp:

(WebCore::Element::lazyReattach):
(WebCore::Element::updateExistingPseudoElement):
(WebCore::Element::createPseudoElementIfNeeded):
(WebCore::disconnectPseudoElement):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setResetStyleInheritance):

  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::parseAttribute):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::parseAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderFallbackContent):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::parseMultipleAttribute):

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::finishLine):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::executeTask):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::willAttachRenderers):
(WebCore::InsertionPoint::willDetachRenderers):

  • loader/PlaceholderDocument.cpp:

(WebCore::PlaceholderDocument::createRenderTree):

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachChildren):
(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):
(WebCore::Style::detachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::updateTextStyle):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):

Documents only ever have one child element. Remove the loop.

(WebCore::Style::detachRenderTreeInReattachMode):
(WebCore::Style::reattachRenderTree):

  • style/StyleResolveTree.h:
  • svg/SVGTests.cpp:

(WebCore::SVGTests::handleAttributeChange):

  • xml/XMLErrors.cpp:

(WebCore::XMLErrors::insertErrorMessageBlock):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

11:30 AM Changeset in webkit [154902] by oliver@apple.com
  • 9 edits in trunk/Source

Make JSValue bool conversion less dangerous
​https://bugs.webkit.org/show_bug.cgi?id=120505

Reviewed by Darin Adler.

Source/JavaScriptCore:

Replaces JSValue::operator bool() with a operator UnspecifiedBoolType* as
we do elsewhere. Then fix the places where terrible type coercion was
happening. All of the changes made had no fundamental behavioural impact
as they were coercion results that were ignored (returning undefined
after an exception).

  • dfg/DFGOperations.cpp:
  • interpreter/CallFrame.h:

(JSC::ExecState::hadException):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::operator UnspecifiedBoolType*):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::equalTo)

Source/WTF:

Make LIKELY and UNLIKELY macros coerce to bool before
passing to expect.

  • wtf/Compiler.h:
11:16 AM Changeset in webkit [154901] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Document style resolve should take Document&.
<​https://webkit.org/b/120534>

Reviewed by Darin Adler.

Tweak Style::resolveTree(Document*) and Style::resolveForDocument(Document*) to take Document& instead.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

  • style/StyleResolveForDocument.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

  • style/StyleResolveTree.h:
11:02 AM Changeset in webkit [154900] by Darin Adler
  • 5 edits in trunk/Source/WebCore

[Mac] No need for Pasteboard::getDataSelection
​https://bugs.webkit.org/show_bug.cgi?id=120536

Reviewed by Anders Carlsson.

  • editing/Editor.h: Added some Mac-only private member functions.
  • editing/mac/EditorMac.mm:

(WebCore::Editor::selectionInWebArchiveFormat): Added.
(WebCore::Editor::adjustedSelectionRange): Added.
(WebCore::attributedStringForRange): Added.
(WebCore::dataInRTFDFormat): Added.
(WebCore::dataInRTFFormat): Added.
(WebCore::Editor::dataSelectionForPasteboard): Moved the implementation
of Pasteboard::getDataSelection here, refactoring to share code with the
writeSelectionToPasteboard function.
(WebCore::Editor::writeSelectionToPasteboard): Refactored to share code
with the new function above.

  • platform/Pasteboard.h: Removed getDataSelection. One less layering violation.
  • platform/mac/PasteboardMac.mm: Ditto.
11:00 AM Changeset in webkit [154899] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] TestWebKitWebView snapshot fails
​https://bugs.webkit.org/show_bug.cgi?id=120404

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-08-30
Reviewed by Darin Adler.

Fixed the snapshot test failure caused by GTK no longer allowing
widgets to resize. Instead, resize the WebView by resizing the
window and waiting for the event to complete asynchronously.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::resizeView):

10:58 AM Changeset in webkit [154898] by timothy@apple.com
  • 1 edit in trunk/Source/WebInspectorUI/ChangeLog

Make incrementing and decrementing numbers by 0.1 require the control key, and not near zero numbers.

​https://bugs.webkit.org/show_bug.cgi?id=120492
<rdar://problem/13738935> Incrementing and decrementing numbers near zero is annoying compared to earlier releases

Reviewed by Joseph Pecoraro.

  • UserInterface/CodeMirrorAdditions.js:

(alterNumber): Remove near zero check.

10:58 AM Changeset in webkit [154897] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Only modify numbers if they are identified by CodeMirror as a number.

​https://bugs.webkit.org/show_bug.cgi?id=120484

<rdar://problem/13877085> REGRESSION: Alt-up and Alt-down don't work when cursor is in unit
<rdar://problem/13058697> PARITY: Option-Up arrow in "translate3d" should not modify number to make" translate4d"

Reviewed by Joseph Pecoraro.

  • UserInterface/CodeMirrorAdditions.js:

(CodeMirror.prototype.alterNumberInRange): Correctly preserve the selection, even if it differs from
the range passed in.
(alterNumber): Find number tokens and pass those to alterNumberInRange.
(alterNumber.findNumberToken): Added. Helper.

10:51 AM Changeset in webkit [154896] by rwlbuis@webkit.org
  • 15 edits in trunk

SVG error parsing empty path
​https://bugs.webkit.org/show_bug.cgi?id=78980

Reviewed by Darin Adler.

Source/WebCore:

According to the spec (​http://www.w3.org/TR/SVG/paths.html#PathData), path 'd' attribute can be empty.
No error should be reported in this case.

  • svg/SVGPathParser.cpp:

(WebCore::SVGPathParser::parsePathDataFromSource):

  • svg/SVGPathUtilities.cpp:

(WebCore::buildPathFromString):
(WebCore::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::buildPathFromByteStream):
(WebCore::buildSVGPathSegListFromByteStream):
(WebCore::buildStringFromByteStream):
(WebCore::buildStringFromSVGPathSegList):
(WebCore::buildSVGPathByteStreamFromString):
(WebCore::buildAnimatedSVGPathByteStream):
(WebCore::addToSVGPathByteStream):

LayoutTests:

Adapt fuzz-path-parser.html and dynamic-empty-path.svg to also test empty paths.
Adjust expectations to not expect an error message for empty paths.

  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/gtk/svg/custom/dynamic-empty-path-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/qt/svg/custom/dynamic-empty-path-expected.txt:
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • svg/custom/dynamic-empty-path-expected.txt:
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/fuzz-path-parser.html: also test empty path
  • svg/dom/path-parser-expected.txt:
  • svg/dom/script-tests/path-parser.js: also test empty path
10:50 AM Changeset in webkit [154895] by Csaba Osztrogonác
  • 6 edits in trunk/Source/WebKit2

Add USE(PROTECTION_SPACE_AUTH_CALLBACK) guards to canAuthenticateAgainstProtectionSpace()
​https://bugs.webkit.org/show_bug.cgi?id=120351

Reviewed by Darin Adler.

  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
  • NetworkProcess/AsynchronousNetworkLoaderClient.h:
  • NetworkProcess/NetworkLoaderClient.h:
  • NetworkProcess/SynchronousNetworkLoaderClient.cpp:
  • NetworkProcess/SynchronousNetworkLoaderClient.h:
10:46 AM Changeset in webkit [154894] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix CSS_VARIABLES and CSS_DEVICE_ADAPTATION builds.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::resolveVariables):

10:43 AM Changeset in webkit [154893] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r154891.
​http://trac.webkit.org/changeset/154891
​https://bugs.webkit.org/show_bug.cgi?id=120539

broke the mac build (Requested by Ossy on #webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2013-08-30

  • platform/network/SynchronousLoaderClient.h:
10:02 AM Changeset in webkit [154892] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Cleaning errorDescriptionForValue after r154839
​https://bugs.webkit.org/show_bug.cgi?id=120531

Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-08-30
Reviewed by Darin Adler.

Changed the assert to ASSERT_NOT_REACHED, now that r154839 has landed. errorDescriptionForValue
can assert again that the parameterized JSValue is !isEmpty().

  • runtime/ExceptionHelpers.cpp:

(JSC::errorDescriptionForValue):

9:45 AM Changeset in webkit [154891] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Add USE(CFNETWORK) guard to SynchronousLoaderClient::didReceiveAuthenticationChallengedidReceiveAuthenticationChallenge()
​https://bugs.webkit.org/show_bug.cgi?id=120532

Reviewed by Darin Adler.

  • platform/network/SynchronousLoaderClient.h:
9:44 AM Changeset in webkit [154890] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Video inside page always uses non-hardware accelerated playback
​https://bugs.webkit.org/show_bug.cgi?id=120448

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::createAVPlayer): Check for
D3D device. If it doesn't exist, switch to compositing mode and try again.

9:40 AM Changeset in webkit [154889] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Possible dangling CachedResourceClient of StyleRuleImport and XSLImportRule
​https://bugs.webkit.org/show_bug.cgi?id=120479

Patch by Leo Yang <​leoyang@blackberry.com> on 2013-08-30
Reviewed by Darin Adler.

In StyleRuleImport::requestStyleSheet() and XSLImportRule::loadSheet() we
didn't call removeClient() for m_cachedSheet before assigning m_cachedSheet
a new value. This could leave the client as a client of the old cached
sheet and dangling after the client is deleted. Fix them by calling removeClient()
before assigning m_cacheSheet a new value.

Found by code inspection. Seems no way to test it automatically.

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

  • xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

9:39 AM Changeset in webkit [154888] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix unused parameter warning in graphics/cairo/GraphicsContextCairo.cpp file.
​https://bugs.webkit.org/show_bug.cgi?id=120524

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-08-30
Reviewed by Darin Adler.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillRectWithRoundedHole):

9:18 AM Changeset in webkit [154887] by akling@apple.com
  • 18 edits in trunk/Source/WebCore

StyleResolver & friends should use Document&.
<​https://webkit.org/b/120527>

Reviewed by Antti Koivisto.

Document&-ify StyleResolver, ElementRuleCollector and SelectorChecker.

9:07 AM Changeset in webkit [154886] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build correction after r154835. Only seen when doing a
full (clean) rebuild.

  • DerivedSources.cpp: Remove reference to deleted JSHTMLDialogElement.cpp
8:28 AM Changeset in webkit [154885] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix, remove unused parameter in UIProcess/WebColorPicker.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=120525

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-08-30
Reviewed by Darin Adler.

  • UIProcess/WebColorPicker.cpp:

(WebKit::WebColorPicker::showColorPicker):

8:25 AM Changeset in webkit [154884] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Resolve unused parameter warning in WebPlatformStrategies.cpp
​https://bugs.webkit.org/show_bug.cgi?id=120515

Patch by Tamas Czene <​tczene@inf.u-szeged.hu> on 2013-08-30
Reviewed by Darin Adler.

  • WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::drawRect):

8:25 AM Changeset in webkit [154883] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Resolve unused parameter warning in FindController.cpp
​https://bugs.webkit.org/show_bug.cgi?id=120516

Patch by Tamas Czene <​tczene@inf.u-szeged.hu> on 2013-08-30
Reviewed by Darin Adler.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::drawRect):

8:24 AM Changeset in webkit [154882] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Resolve unused parameter warning in FindController.cpp
​https://bugs.webkit.org/show_bug.cgi?id=120407

Patch by Tamas Czene <​tczene@inf.u-szeged.hu> on 2013-08-30
Reviewed by Darin Adler.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(wordAtPositionForAtkBoundary):

8:21 AM Changeset in webkit [154881] by a.bah@samsung.com
  • 3 edits
    2 adds in trunk

setAttributeNode() does not set the new value to an existing attribute if specified attribute is in a different case.
​https://bugs.webkit.org/show_bug.cgi?id=120293

Reviewed by Darin Adler.

Source/WebCore:

setAttributeNode() performs a case-insensitive search for an existing
attribute. If an existing attribute is found, it retrieves the index of
such an attribute. For setting the attribute's new value, we call upon
setAttributeInternal() to which both the index as well as the name of
the attribute is passed.
The name passed to this method is the same as the one passed to the
setAttributeNode() API from the webpage and thus can be in any case.

However, setAttributeInternal() uses this name to get the corresponding
existing attribute node. Since this retrieval is not case-insensitive,
the existing node is not returned and thus the new value is not set on
the existing node.
We should instead use the passed index and use that to retrieve the
existing node.

Note that obtaining the attribute's value using getAttributeNode() would
still return the correct value, i.e. the new one.

Also, this change shall make our behavior similar to that of FF and IE.

Test: fast/dom/Element/setAttributeNode-for-existing-attribute.html

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
If the passed index is not equal to attributeNotFound, we use that index
to retrieve the existing attribute.

LayoutTests:

  • fast/dom/Element/setAttributeNode-for-existing-attribute-expected.txt: Added.
  • fast/dom/Element/setAttributeNode-for-existing-attribute.html: Added.

Layout testcase for verifying that the new attribute value is set properly
if an existing attribute with the same name exists.

7:58 AM Changeset in webkit [154880] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/win

Windows build fix for Document& Node::document().

  • DOMCoreClasses.cpp:

(DOMNode::createInstance):

7:57 AM Changeset in webkit [154879] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Skip failing grammar checking test.
Unreviewed gardening.

  • platform/qt/TestExpectations:
7:31 AM Changeset in webkit [154878] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebCore

SimpleClassVectorTraits shall be used for RuleData
​https://bugs.webkit.org/show_bug.cgi?id=120526

Reviewed by Andreas Kling.

Whereas RuleData is POD type and whereas there are quite a lot of Vector<RuleData> occurrences in the code,
it makes sense to use SimpleClassVectorTraits for RuleData and hence to allow using more efficient mem functions
in vectors.

  • css/RuleSet.h:
7:30 AM Changeset in webkit [154877] by akling@apple.com
  • 350 edits in trunk/Source

Node::document() should return a reference.
<​https://webkit.org/b/120496>

Reviewed by Antti Koivisto.

Now that orphan DocumentType nodes also have document pointers, it's no longer
possible to have a null Node::document().

Cement this by making document() return a reference, and remove the various
null checks exposed by this.

6:40 AM Changeset in webkit [154876] by kadam@inf.u-szeged.hu
  • 1 edit
    18 adds in trunk/LayoutTests

[Qt] Added platform specific expected files after r15470 and r154780.
Unreviewed gardening.

  • platform/qt-wk1/compositing/columns/composited-lr-paginated-repaint-expected.txt: Added.
  • platform/qt-wk1/compositing/columns/composited-rl-paginated-repaint-expected.txt: Added.
  • platform/qt-wk1/compositing/repaint/repaint-on-layer-grouping-change-expected.png: Added.
  • platform/qt-wk1/compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/ancestor-clipped-in-paginated-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/clipped-in-paginated-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/composited-columns-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/composited-columns-vertical-rl-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/composited-in-paginated-rl-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/composited-in-paginated-writing-mode-rl-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/composited-lr-paginated-repaint-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/composited-nested-columns-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/composited-rl-paginated-repaint-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/hittest-composited-in-paginated-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/rotated-in-paginated-expected.txt: Added.
  • platform/qt-wk2/compositing/columns/untransformed-composited-in-paginated-expected.txt: Added.
  • platform/qt-wk2/compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
5:58 AM Changeset in webkit [154875] by commit-queue@webkit.org
  • 12 edits
    13 adds in trunk

Source/WebCore: [CSS Masking] -webkit-mask-repeat: space does not work
Added the space option to background-repeat and -webkit-mask-repeat.
With the property value 'space', the background or mask image gets repeated as often as it fits within the background positioning
area. The repeated images are spaced equally to fill the unused area.
​https://bugs.webkit.org/show_bug.cgi?id=119324

Patch by Andrei Parvu <​parvu@adobe.com> on 2013-08-30
Reviewed by Dirk Schulze.

Tests: css3/background/background-repeat-space-border.html

css3/background/background-repeat-space-content.html
css3/background/background-repeat-space-padding.html
css3/masking/mask-repeat-space-border.html
css3/masking/mask-repeat-space-content.html
css3/masking/mask-repeat-space-padding.html

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern): Passed the space values to the image buffer.

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled): Added the space values when computing the location of the tile.

  • platform/graphics/Image.h: Added the space property.

(WebCore::Image::spaceSize):
(WebCore::Image::setSpaceSize):

  • platform/graphics/ImageBuffer.h: Added the space property.

(WebCore::ImageBuffer::spaceSize):
(WebCore::ImageBuffer::setSpaceSize):

  • platform/graphics/cg/ImageBufferCG.cpp: Passed the space values when copying an image.

(WebCore::ImageBuffer::copyImage):

  • platform/graphics/cg/ImageCG.cpp: Added the space values when creating a platform pattern.

(WebCore::Image::drawPattern):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Computed the space values on x and y axis.
(WebCore::getSpace):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Pass the space values to the Image class.

  • rendering/RenderBoxModelObject.h: Added the space property.

(WebCore::RenderBoxModelObject::BackgroundImageGeometry::spaceSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setSpaceSize):

  • svg/graphics/SVGImage.cpp: Passed the space property to the created image.

(WebCore::SVGImage::drawPatternForContainer):

  • svg/graphics/SVGImageForContainer.cpp: Passed the space property to the image property.

(WebCore::SVGImageForContainer::drawPattern):

LayoutTests: [CSS Masking] -webkit-mask-repeat: space does not work
Added tests to verify correct usage of background-repeat: space and mask-repeat: space.
Added one test for each possible mask/background clip: border, padding and content
​https://bugs.webkit.org/show_bug.cgi?id=119324

Patch by Andrei Parvu <​parvu@adobe.com> on 2013-08-30
Reviewed by Dirk Schulze.

  • css3/background/background-repeat-space-border-expected.html: Added.
  • css3/background/background-repeat-space-border.html: Added.
  • css3/background/background-repeat-space-content-expected.html: Added.
  • css3/background/background-repeat-space-content.html: Added.
  • css3/background/background-repeat-space-padding-expected.html: Added.
  • css3/background/background-repeat-space-padding.html: Added.
  • css3/masking/mask-repeat-space-border-expected.html: Added.
  • css3/masking/mask-repeat-space-border.html: Added.
  • css3/masking/mask-repeat-space-content-expected.html: Added.
  • css3/masking/mask-repeat-space-content.html: Added.
  • css3/masking/mask-repeat-space-padding-expected.html: Added.
  • css3/masking/mask-repeat-space-padding.html: Added.
5:56 AM Changeset in webkit [154874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Resolve unused parameter warning in WKBundlePageOverlay.cpp
​https://bugs.webkit.org/show_bug.cgi?id=120521

Patch by Tamas Czene <​tczene@inf.u-szeged.hu> on 2013-08-30
Reviewed by Andreas Kling.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlayFractionFadedIn):

5:33 AM Changeset in webkit [154873] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Remove AttachContext
​https://bugs.webkit.org/show_bug.cgi?id=120518

Reviewed by Andreas Kling.

This type is not useful anymore. Just pass the precomputed style to attachRenderTree and reattach-or-not flag to detachRenderTree.

  • style/StyleResolveTree.cpp:

(WebCore::Style::createRendererIfNeeded):
(WebCore::Style::attachChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):
(WebCore::Style::detachShadowRoot):
(WebCore::Style::detachRenderTree):
(WebCore::Style::reattachRenderTree):
(WebCore::Style::resolveLocal):

  • style/StyleResolveTree.h:
5:13 AM Changeset in webkit [154872] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt] Remove qt-5.0-wk2 from the baseline search paths because the migration of expectations to qt-wk2 is done.
​https://bugs.webkit.org/show_bug.cgi?id=120464

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-08-30
Reviewed by Jocelyn Turcotte.

  • Scripts/webkitpy/port/qt.py:

(QtPort._search_paths):

  • Scripts/webkitpy/port/qt_unittest.py:

(QtPortTest):

2:34 AM Changeset in webkit [154871] by commit-queue@webkit.org
  • 12 edits
    5 deletes in trunk

Unreviewed, rolling out r154826.
​http://trac.webkit.org/changeset/154826
​https://bugs.webkit.org/show_bug.cgi?id=120517

Still breaks icloud.com (Requested by mwenge_ on #webkit).

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::intrinsicSize):

  • rendering/RenderButton.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computePreferredLogicalWidths):
(WebCore::RenderListBox::computeLogicalHeight):

  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):

  • rendering/RenderTextControl.h:

LayoutTests:

  • fast/replaced/intrinsic-button-and-input-height-expected.txt: Removed.
  • fast/replaced/intrinsic-button-and-input-height.html: Removed.
  • fast/replaced/width-and-height-of-positioned-replaced-elements.html: Removed.
  • platform/qt/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Removed.
  • platform/qt/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Removed.
2:29 AM Changeset in webkit [154870] by Antti Koivisto
  • 13 edits in trunk/Source

Remove code behind ENABLE(DIALOG_ELEMENT)
​https://bugs.webkit.org/show_bug.cgi?id=120467

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:
Note: See TracTimeline for information about the timeline view.