⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 12, 2013:

11:42 PM Changeset in webkit [155674] by commit-queue@webkit.org
  • 11 edits
    8 adds in trunk

Source/WebCore: [EFL]Background Style of element not visible because of default theme style
​https://bugs.webkit.org/show_bug.cgi?id=117405

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-09-12
Reviewed by Gyuyoung Kim.

When select element is styled with css background property(color/image) the styling
gets hidden by Combo box non transparent image. This patch handle the
case and transparent images are used when select image is styled. So
now background-color and background-image are visible across the Combo box

The code is added to support css styling of other theme control,
Basically an extra signal is emitted to edje which change the state
of edje object whenever the control is styled.

Covered by existing test case, updated the test expected image.

  • platform/efl/DefaultTheme/CMakeLists.txt:
  • platform/efl/DefaultTheme/widget/combo/combo.edc:
  • platform/efl/DefaultTheme/widget/combo/combo_focus_button_transparent.png: Added.
  • platform/efl/DefaultTheme/widget/combo/combo_focus_transparent.png: Added.
  • platform/efl/DefaultTheme/widget/combo/combo_hover_button_transparent.png: Added.
  • platform/efl/DefaultTheme/widget/combo/combo_hover_transparent.png: Added.
  • platform/efl/DefaultTheme/widget/combo/combo_normal_button_transparent.png: Added.
  • platform/efl/DefaultTheme/widget/combo/combo_normal_transparent.png: Added.
  • platform/efl/DefaultTheme/widget/combo/combo_press_button_transparent.png: Added.
  • platform/efl/DefaultTheme/widget/combo/combo_press_transparent.png: Added.
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::isControlStyled):
(WebCore::RenderThemeEfl::paintThemePart):

  • platform/efl/RenderThemeEfl.h:

LayoutTests: [EFL] Background Style of element not visible because of default theme style
​https://bugs.webkit.org/show_bug.cgi?id=117405

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-09-12
Reviewed by Gyuyoung Kim.

Updating expected image oputput of pixel test reflecting the
background image visible over combo box.

  • platform/efl/fast/forms/menulist-narrow-width-expected.png:
  • platform/efl/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/efl/fast/forms/menulist-style-color-expected.png:
  • platform/efl/fast/forms/select-background-none-expected.png:
  • platform/efl/fast/forms/select-style-expected.png:
11:16 PM Changeset in webkit [155673] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

[CTTE] RenderMenuList always has a HTMLSelectElement.
<​https://webkit.org/b/121276>

Reviewed by Anders Carlsson.

This renderer is never anonymous and always has a corresponding HTMLSelectElement.
Deleted element() in favor of HTMLSelectElement& selectElement().

10:50 PM Changeset in webkit [155672] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/qt

Fix Qt build.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::inputMethodQuery):

10:32 PM Changeset in webkit [155671] by akling@apple.com
  • 13 edits in trunk/Source

[CTTE] Tighten RenderTextControl element typing.
<​https://webkit.org/b/121275>

Reviewed by Anders Carlsson.

Codify these invariants:

  • RenderTextControl always has a HTMLTextFormControl.
  • RenderSearchField always has a HTMLInputElement.
  • RenderTextControlSingleLine always has a HTMLInputElement.

None of these renderers are ever anonymous. Deleted element() and added
strongly typed reference getters instead.

10:13 PM Changeset in webkit [155670] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

[CTTE] RenderListMarker is always anonymous and owned by RenderListItem.
<​https://webkit.org/b/121274>

Reviewed by Anders Carlsson.

Store a RenderListItem& instead of a pointer in RenderListMarker.
Deleted the element() function since list markers are always anonymous.

10:12 PM Changeset in webkit [155669] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

[CTTE] RenderListBox's element is always a HTMLSelectElement.
<​https://webkit.org/b/121273>

Reviewed by Anders Carlsson.

Hide element() on RenderListBox and make selectElement() return a reference
since this renderer cannot be anonymous.

10:11 PM Changeset in webkit [155668] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

[CTTE] RenderHTMLCanvas's element is always a HTMLCanvasElement.
<​https://webkit.org/b/121272>

Reviewed by Anders Carlsson.

Add RenderHTMLCanvas::canvasElement(), hiding element().
This function also returns a reference since this renderer cannot be anonymous.

10:09 PM Changeset in webkit [155667] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

[CTTE] RenderTextControlMultiLine's element is always a HTMLTextAreaElement.
<​https://webkit.org/b/121271>

Reviewed by Anders Carlsson.

Add RenderTextControlMultiLine::textAreaElement(), hiding element().
This function also returns a reference since this renderer cannot be anonymous.

9:49 PM BuildingGtk edited by ChangSeok Oh
Add how to use wayland-dependecies.modules (diff)
7:19 PM Changeset in webkit [155666] by Brent Fulgham
  • 2 edits in trunk/WebKitLibraries

[Windows] Update WKSI library for Open Source builders.

  • win/lib32/WebKitSystemInterface.lib: Recompile with latest WebKit to use newer

WTF.dll symbol exports.

5:37 PM Changeset in webkit [155665] by timothy_horton@apple.com
  • 7 edits
    2 adds in trunk

[mac] Cache rendered image in PDFDocumentImage
​https://bugs.webkit.org/show_bug.cgi?id=121207

Reviewed by Simon Fraser.

Tests: fast/images/pdf-as-image-too-big.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::createImage):
PDFDocumentImage takes a ImageObserver now so that it can report
decoded data size changes to the memory cache.

  • platform/graphics/Image.h:

(WebCore::Image::isPDFDocumentImage): Added.

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::PDFDocumentImage):
PDFDocumentImage takes a ImageObserver now so that it can report
decoded data size changes to the memory cache.

(WebCore::PDFDocumentImage::applyRotationForPainting):
Fix up some comments, and use GraphicsContext instead of CG API.

(WebCore::PDFDocumentImage::cacheParametersMatch):
Determine whether our cached image is still valid, given the new
destination's size, CTM scale, and source rect.

(WebCore::transformContextForPainting): Added.

(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
Cache a rendered bitmap of the PDF. Invalidate the cache if cacheParametersMatch
decides that the parameters don't match, unless we're painting in low quality mode,
in which case we'll scale the existing image (and then fully repaint when the
high-quality repaint timer fires).
Inform the memory cache of our new size.

(WebCore::PDFDocumentImage::draw):
Update the cached image if needed.
Paint the cached image into the context if it's available (which it might not be,
if the image is way too big and the allocation fails). Otherwise, paint straight
into the context as we previously did.

(WebCore::PDFDocumentImage::destroyDecodedData):
Throw away the cached image if requested.

(WebCore::PDFDocumentImage::decodedSize):
(WebCore::PDFDocumentImage::drawPDFPage):
Drive-by use GraphicsContext instead of CG directly.

  • platform/graphics/cg/PDFDocumentImage.h:

(WebCore::PDFDocumentImage::create):
Override isPDFDocumentImage().
Add storage for the cached image buffer and various cache parameters.

  • rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):
PDFDocumentImage is also interested in/capable of low-quality painting now.

Add a test ensuring that very large PDF-in-<img> elements don't crash.

  • fast/images/pdf-as-image-too-big-expected.txt: Added.
  • fast/images/pdf-as-image-too-big.html: Added.
5:33 PM Changeset in webkit [155664] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Image doesn't always repaint at high quality in all tiles after a live resize
​https://bugs.webkit.org/show_bug.cgi?id=121244

Reviewed by Darin Adler.

Currently, ImageQualityController removes an image from its low-quality-images
list from inside shouldPaintAtLowQuality, if this is the first paint outside
of a live resize, but does not force the renderer to repaint in its entirety.

However, there's no guarantee we've invalidated the whole renderer, so this can
leave some parts of the image painted in low-quality.

This just removes a short-circuit, instead using the ordinary high-quality-repaint
timer to ensure that the entire renderer is repainted.

No new test; all attempts have failed, as this depends on tiled drawing
and a live resize occurring.

  • rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

5:23 PM Changeset in webkit [155663] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[EFL] Speculative build fix after r155638.

  • platform/efl/PasteboardEfl.cpp: Add include for PassRefPtr, which

is no longer implicitly included.

4:57 PM Changeset in webkit [155662] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG::Int32Operand and fillInt32() should go away and all uses should be replaced with SpeculateInt32Operand
​https://bugs.webkit.org/show_bug.cgi?id=121268

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):

4:30 PM Changeset in webkit [155661] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Duplicated color swatches changing autocompletes color names
​https://bugs.webkit.org/show_bug.cgi?id=121265

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.

CodeMirror bookmarks at position used to be unique but no longer are.
Define an extension to give us unique bookmarks as we expected, and
update all the old locations using setBookmark.

  • UserInterface/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):

  • UserInterface/CodeMirrorAdditions.js:
4:28 PM Changeset in webkit [155660] by Simon Fraser
  • 6 edits in trunk/Source

Avoid extra scrollbar-related layouts for overlay scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=121267

Source/WebCore:

Reviewed by Beth Dakin.

If ScrollView::updateScrollbars() detected that scrollbars were added
and removed, it would call contentsResized(), which calls setNeedsLayout(),
followed by visibleContentsResized() which would trigger layout. There is no
point doing this with overlay scrollbars, so avoid it by having
setHas*Scrollbar() return true if the addition/removal of a scrollbar changed
the available width.

No tests: we can't test overlay scrollbars in tests.

  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize): Drive-by assertion that
checks that the unsigned m_deferSetNeedsLayouts doesn't wrap when
decremented.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar): Return true if the addition/removal
changed available space.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): Only set sendContentResizedNotification
if available space was changed by addition/removal of scrollbars.

  • platform/ScrollView.h:

Source/WebKit2:

Reviewed by Beth Dakin.

view->resize() will call setNeedsLayout() if necessary, and may already have
done layout, so the extra setNeedsLayout() here was bad.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):

4:27 PM Changeset in webkit [155659] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebInspectorUI

Web Inspector: Update CodeMirror for gutter fix
​https://bugs.webkit.org/show_bug.cgi?id=121262

Update CodeMirror to 757944449 to fix gutter click issue:
<​https://github.com/marijnh/CodeMirror/issues/1807>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.

  • Tools/PrettyPrinting/CodeMirrorFormatters.js:
  • Tools/PrettyPrinting/FormatterContentBuilder.js:

(FormatterContentBuilder.prototype._appendIndent):

  • Tools/PrettyPrinting/codemirror.css:
  • Tools/PrettyPrinting/codemirror.js:
  • Tools/PrettyPrinting/css.js:
  • UserInterface/CodeMirrorAdditions.js:
  • UserInterface/CodeMirrorFormatters.js:
  • UserInterface/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.didRemoveBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint):

  • UserInterface/External/CodeMirror/codemirror.css:
  • UserInterface/External/CodeMirror/codemirror.js:
  • UserInterface/External/CodeMirror/coffeescript.js:
  • UserInterface/External/CodeMirror/css.js:
  • UserInterface/External/CodeMirror/less.js:
  • UserInterface/External/CodeMirror/sql.js:
  • UserInterface/TextEditor.js:

(WebInspector.TextEditor.prototype.hasFormatter):

4:25 PM Changeset in webkit [155658] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update License copyrights in minified JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=121264

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.

  • Scripts/copy-user-interface-resources.sh:
4:07 PM Changeset in webkit [155657] by ggaren@apple.com
  • 7 edits in trunk

Source/JavaScriptCore: Web Inspector shouldn't artificially allocate the arguments object in functions that don't use it
​https://bugs.webkit.org/show_bug.cgi?id=121206
<rdar://problem/6911886>

Reviewed by Joseph Pecoraro.

This is a step toward better tools, and a 23% speedup in a simple
JavaScript benchmark run with the Web Inspector open.

We want the Web Inspector to be fast, and we want it to produce reliable
CPU and memory profiles. We can't do that if just opening the Web Inspector
incurs huge CPU/memory penalties like the arguments object.

Also, since use of the 'arguments' identifier is an API for allocating
an object, I think it's good for the UI to let developers know when
they've invoked that API and when they haven't.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): No need to allocate the
arguments object artificially for the debugger's sake. The activation
object no longer assumes that the stack frame is laid out for one.

(Long-term, this code will move out of the activation object, into a
special object for interfacing with the debugger.)

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::getOwnPropertySlot): Don't advertise or provide an
arguments object if the user function didn't include one. The bytecode
generator will not have laid out the stack frame to support one.

(Eventually, we do want the Web Inspector to see an arguments
object in scope in the console. That's a one-line change in JSActivation,
but it's blocked by ​https://bugs.webkit.org/show_bug.cgi?id=121208.)

(JSC::JSActivation::argumentsGetter):

  • runtime/JSActivation.h: Removed this obsolete performance

work-around. C++ property access to an activation object is no longer
hot.

LayoutTests: Web Inspector shouldn't artificially allocate the arguments object in functions that don't use it
​https://bugs.webkit.org/show_bug.cgi?id=121206

Reviewed by Joseph Pecoraro.
<rdar://problem/6911886>

  • inspector/debugger/debugger-expand-scope-expected.txt: Updated these

results to reflect the fact that it's correct to exclude the 'arguments'
identifier from function scopes that don't use it.

  • inspector/debugger/debugger-expand-scope.html: Edited this test to

include one frame that uses the 'arguments' identifier and one frame
that doesn't, so we test both cases.

4:03 PM Changeset in webkit [155656] by Lucas Forschler
  • 2 edits in trunk/Tools

Create short build logs for errors and warnings.
​https://bugs.webkit.org/show_bug.cgi?id=120614

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

-include StringIO

(CompileWebKit.createSummary):

-add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing

3:55 PM Changeset in webkit [155655] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Rename shapeContainingBlockHeight to shapeContainingBlockLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=121252

Reviewed by Oliver Hunt.

No new tests, no behavior change.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::pushShapeContentOverflowBelowTheContentBox):

  • rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::shapeContainingBlockLogicalHeight):

3:46 PM Changeset in webkit [155654] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Update cygwin downloader to search for packages in the right location.

  • CygwinDownloader/cygwin-downloader.py:
  • CygwinDownloader/cygwin-downloader.zip:
3:41 PM Changeset in webkit [155653] by commit-queue@webkit.org
  • 5 edits in trunk

<meter> element AXValue is listed as a writable value
​https://bugs.webkit.org/show_bug.cgi?id=117650

Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing accessibility/meter-element.html test
to check writability. Changed meter element value to be unwritable.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::canSetValueAttribute):

LayoutTests:

Added writability check to meter element test.

  • accessibility/meter-element.html:
  • platform/mac/accessibility/meter-element-expected.txt:
3:39 PM Changeset in webkit [155652] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Rolling out r155632

Broke some tests.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper):

  • heap/MarkedBlock.h:
3:09 PM Changeset in webkit [155651] by reni@webkit.org
  • 3 edits
    3 adds in trunk

[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange
​https://bugs.webkit.org/show_bug.cgi?id=121148

Reviewed by Kent Tamura.

Source/WebCore:

Non-steppable input types must not rendered as slider even if its webkit-apperance style
property is set to slider-vertical/horizontal.

Test: platform/qt/fast/forms/range/slider-crash-on-input.html

  • platform/qt/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::paintSliderTrack):

LayoutTests:

Trying to render text input as slider-vertical. Expecting to run without crash.

  • platform/qt/fast/forms/range/slider-crash-on-input.html: Added.
  • platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt: Added.
2:40 PM Changeset in webkit [155650] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Canvas fillText and measureText handle ideographic spaces differently
​https://bugs.webkit.org/show_bug.cgi?id=108881

Fixing the test:

  1. Updated paths to js-test scripts.
  2. Removed "meta charcode" - we don't need to specify a charset here, and it's

"charset", not "charcode" anyway.

  • fast/canvas/canvas-measureText-ideographicSpace.html:
2:04 PM Changeset in webkit [155649] by rniwa@webkit.org
  • 4 edits in trunk/Source

Source/JavaScriptCore: Qt build fix. Add a return to make the compiler happy.

  • dfg/DFGGPRInfo.h:

(JSC::DFG::JSValueRegs::gpr):

Source/WebCore: Qt and Windows build fix.

  • page/animation/CSSPropertyAnimation.cpp:
2:02 PM Changeset in webkit [155648] by ap@apple.com
  • 5 edits in trunk/LayoutTests

svg/animations/smil-leak-*.svg tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=114280

Reviewed by Tim Horton.

Moved garbage collection out of the function that touches nodes to be collected,
making sure that they are definitely not on the stack.

I could not reproduce locally, so this is a speculative fix.

  • svg/animations/smil-leak-dynamically-added-element-instances.svg:
  • svg/animations/smil-leak-element-instances-noBaseValRef.svg:
  • svg/animations/smil-leak-element-instances.svg:
  • svg/animations/smil-leak-elements.svg:
1:52 PM Changeset in webkit [155647] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Encapsulate globals in CSSPropertyAnimation.cpp
​https://bugs.webkit.org/show_bug.cgi?id=121205

Reviewed by Antti Koivisto.

Encapsulated the globals inside a newly added CSSPropertyAnimationWrapperMap. Also removed the circular
dependency from ShorthandPropertyWrapper's constructor to CSSPropertyAnimationWrapperMap::instance().
The circular dependency still exists in ensurePropertyMap but I'm going to remove it in the bug 121199.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper): Takes a Vector of longhand wrappers instead of
calling wrapperForProperty in the middle of constructing the very table. This circular dependency is now
encapsulated in CSSPropertyAnimationWrapperMap::ensurePropertyMap.
(WebCore::CSSPropertyAnimationWrapperMap::instance): Added.
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForProperty): Renamed from WebCore::wrapperForProperty.
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForIndex): Added.
(WebCore::CSSPropertyAnimationWrapperMap::size): Added.
(WebCore::CSSPropertyAnimationWrapperMap::addPropertyWrapper): Renamed from WebCore::addPropertyWrapper. Also
cleaned up boolean logics to use early exits instead of nested ifs.
(WebCore::CSSPropertyAnimationWrapperMap::addShorthandProperties): Renamed from WebCore::addShorthandProperties.
(WebCore::CSSPropertyAnimationWrapperMap::ensurePropertyMap): Renamed from WebCore::ensurePropertyMap.
Added an alias gPropertyWrappers for m_propertyWrappers; this aliasing will be removed in the bug 121199.
(WebCore::CSSPropertyAnimation::blendProperties):
(WebCore::CSSPropertyAnimation::animationOfPropertyIsAccelerated):
(WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty):
(WebCore::CSSPropertyAnimation::propertiesEqual):
(WebCore::CSSPropertyAnimation::getPropertyAtIndex):
(WebCore::CSSPropertyAnimation::getNumProperties):

  • page/animation/CSSPropertyAnimation.h:
  • rendering/style/RenderStyle.h:
1:42 PM Changeset in webkit [155646] by ap@apple.com
  • 4 edits
    3 deletes in trunk/LayoutTests

Flaky Test: plugins/mouse-events.html
​https://bugs.webkit.org/show_bug.cgi?id=116665

Reviewed by Anders Carlsson.

  • plugins/mouse-events-expected.txt:
  • plugins/mouse-events.html:

This test used async calls for events, and then usually logged responses while waiting
for a plg.eventLoggingEnabled setter synchronously. Depending on sync/async event
order is not reliable, especially with old WebKit1 plug-in IPC code.

  • platform/mac-wk2/plugins/mouse-events-expected.txt: For some unclear reason,

focus works differently in WebKit2.

  • platform/gtk/plugins/mouse-events-expected.txt: Removed.
  • platform/qt/plugins/mouse-events-expected.txt: Removed.
  • platform/win/plugins/mouse-events-expected.txt: Removed.

These results looked similar to new cross-platform ones, hopefully custom results
won't be needed any more.

1:40 PM Changeset in webkit [155645] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG::GenerationInfo init/fill methods shouldn't duplicate a bunch of logic
​https://bugs.webkit.org/show_bug.cgi?id=121253

Reviewed by Oliver Hunt.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::initGPR):
(JSC::DFG::GenerationInfo::initInt32):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::fillGPR):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillInt32):
(JSC::DFG::GenerationInfo::fillBoolean):
(JSC::DFG::GenerationInfo::fillStorage):

1:13 PM Changeset in webkit [155644] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, fix mispelling (Specualte -> Speculate) that I introduced in an
earlier patch.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):

1:07 PM Changeset in webkit [155643] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

GPRTemporary's reuse constructor should be templatized to reduce code duplication, and the bool to denote tag or payload should be replaced with an enum
​https://bugs.webkit.org/show_bug.cgi?id=121250

Reviewed by Oliver Hunt.

  • dfg/DFGGPRInfo.h:

(JSC::DFG::JSValueRegs::gpr):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::GPRTemporary::GPRTemporary):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSCJSValue.h:
1:00 PM Changeset in webkit [155642] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Web Inspector: Do not try to parse incomplete HTTP requests
​https://bugs.webkit.org/show_bug.cgi?id=121123

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-12
Reviewed by Darin Adler.

When working on a patch for bug #121121 I found an issue with the InspectorServer where it would try
to parse an HTTP message before receiving the full message and thus fail connecting with the
chromedevtools plugin.

What happens is that the WebSocketServerConnection receives buffers on
WebSocketServerConnection::didReceiveSocketStreamData and calls
WebSocketServerConnection::readHTTPMessage which then checks if we have a valid request by calling
HTTPRequest::parseHTTPRequestFromBuffer. If the request is valid it tries to parse the message and
clears the buffer, otherwise it continues adding data to the internal buffer until we have a valid
request.

The problem is that currently HTTPRequest::parseHTTPRequestFromBuffer considers the request as valid
before receiving the full message. To solve this we should make the method check if the request
headers end with a blank line otherwise we consider the request as invalid (see also
​http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html).

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(sendIncompleteRequest):
(beforeAll):
Add GTK specific test to check if the inspector server replies to incomplete requests.

  • UIProcess/InspectorServer/HTTPRequest.cpp:

(WebKit::HTTPRequest::parseHeaders):
Do not consider request valid if headers didn't end with a blank line.

12:52 PM Changeset in webkit [155641] by andersca@apple.com
  • 16 edits in trunk/Source

SharedBuffer::createNSData should return a RetainPtr<NSData>
​https://bugs.webkit.org/show_bug.cgi?id=121237

Reviewed by Darin Adler.

Source/WebCore:

This makes memory management cleared and fixes a leak in PDFDocumentImage::createPDFDocument.
We use a RetainPtr subclass as a stopgap measure to prevent code that does [buffer->createNSData() autorelease]
from compiling and crashing due to the NSData object being overreleased.

  • loader/ResourceBuffer.h:
  • loader/mac/ResourceBuffer.mm:

(WebCore::ResourceBuffer::createNSData):

  • platform/SharedBuffer.h:

(WebCore::SharedBuffer::NSDataRetainPtr::NSDataRetainPtr):

  • platform/graphics/mac/PDFDocumentImageMac.mm:

(WebCore::PDFDocumentImage::createPDFDocument):

  • platform/mac/HTMLConverter.mm:

(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(fileWrapperForURL):

  • platform/mac/PasteboardMac.mm:

(WebCore::fileWrapper):
(WebCore::Pasteboard::read):
(WebCore::documentFragmentWithRTF):
(WebCore::fragmentFromWebArchive):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::setBufferForType):

  • platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createNSData):

Source/WebKit/mac:

Update for WebCore changes. This also fixes a leak where we'd create an NSFileWrapper from NSData but never release the data.

  • WebView/WebDataSource.mm:

(-[WebDataSource data]):

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation documentSource]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

  • WebView/WebResource.mm:

(-[WebResource encodeWithCoder:]):
(-[WebResource data]):

Source/WebKit2:

Update for WebCore changes.

  • UIProcess/API/mac/WKView.mm:

(-[WKView writeSelectionToPasteboard:types:]):
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):

12:48 PM Changeset in webkit [155640] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WTF

Bitmap's WordType should be a template parameter
​https://bugs.webkit.org/show_bug.cgi?id=121238

Reviewed by Darin Adler.

The code is written as if it already is. We just need to lift it out of the class.
This simplifies code that wants to load, for example, a single byte rather than an
entire 32-bit word.

  • wtf/Bitmap.h:

(WTF::Bitmap::Bitmap):
(WTF::Bitmap::get):
(WTF::Bitmap::set):
(WTF::Bitmap::testAndSet):
(WTF::Bitmap::testAndClear):
(WTF::Bitmap::concurrentTestAndSet):
(WTF::Bitmap::concurrentTestAndClear):
(WTF::Bitmap::clear):
(WTF::Bitmap::clearAll):
(WTF::Bitmap::nextPossiblyUnset):
(WTF::Bitmap::findRunOfZeros):
(WTF::Bitmap::count):
(WTF::Bitmap::isEmpty):
(WTF::Bitmap::isFull):

12:48 PM Changeset in webkit [155639] by timothy@apple.com
  • 9 edits in trunk/Source/WebCore

Remove more Timeline stuff we don't use
​https://bugs.webkit.org/show_bug.cgi?id=121246

Reviewed by Joseph Pecoraro.

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

  • inspector/InspectorTimelineAgent.h:
12:23 PM Changeset in webkit [155638] by Darin Adler
  • 7 edits
    2 adds in trunk/Source/WebCore

[EFL] Get rid of layering violations in PasteboardEfl.cpp
​https://bugs.webkit.org/show_bug.cgi?id=121241

Patch by Christophe Dumez <Christophe Dumez> on 2013-09-12
Reviewed by Darin Adler.

Get rid of layering violations in PasteboardEfl.cpp. For now, just mimic
the Mac port to avoid divergences and leave port-specific functions
unimplemented as the EFL port does not support the pasteboard functionality
yet.

No new tests, no behavior change.

  • PlatformEfl.cmake:
  • editing/Editor.cpp:

(WebCore::Editor::pasteAsPlainTextWithPasteboard):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::copyURL):
(WebCore::Editor::copyImage):

  • editing/Editor.h:
  • editing/efl/EditorEfl.cpp: Added.

(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::writeURLToPasteboard):
(WebCore::Editor::writeImageToPasteboard):
(WebCore::Editor::readPlainTextFromPasteboard):
(WebCore::Editor::pasteWithPasteboard):

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

  • platform/Pasteboard.h:
  • platform/efl/PasteboardEfl.cpp:
12:21 PM Changeset in webkit [155637] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] Unreviewed build fix after r155635.

Include DragData.h

  • platform/gtk/PasteboardGtk.cpp:
12:13 PM Changeset in webkit [155636] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Build fix after r155635.

Rubber Stamped by Darin Adler.

  • platform/Pasteboard.h: Add missing compile guards for Windows port.
11:57 AM FTLJIT edited by fpizlo@apple.com
(diff)
11:56 AM FTLJIT edited by fpizlo@apple.com
(diff)
11:52 AM FTLJIT edited by fpizlo@apple.com
(diff)
11:44 AM FTLJIT edited by fpizlo@apple.com
(diff)
11:43 AM FTLJIT edited by fpizlo@apple.com
(diff)
11:43 AM FTLJIT created by fpizlo@apple.com
11:39 AM Changeset in webkit [155635] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Reorganize Pasteboard.h to make it easier to read, and express plan for future work
​https://bugs.webkit.org/show_bug.cgi?id=121234

Reviewed by Anders Carlsson.

  • platform/Pasteboard.h: Move Mac/iOS-specific pasteboard names to the bottom of the

file rather than putting them up with forward declarations before the class. Removed
unneeded forward class declarations. Changed #if statements about migration to the
more modern non-layering-violation API to list platforms not yet migrated, rather than
listing platforms that have migrated (Mac). Move conditional code down below the
uncondiditional code so it's easier to see what the class is doing. Move layering-
violation code down to the bottom too, so it's easier to see the future class without
having the design mistakes mixed in. Sort platform-specific sections in alphabetical
order instead of random order. Did the destructor in a cleaner way so the #if is out
of the way after the class rather than in the class. Removed WebSmartPastePboardType,
WebURLPboardType, and WebURLsWithTitlesPboard declarations, since they are only used
inside the PasteboardMac.mm source file.

  • platform/ios/PasteboardIOS.mm: Aded a FIXME comment.
  • platform/mac/PasteboardMac.mm: Made the constants for pasteboard types be actual

constants, rather than global variables.

11:33 AM JavaScriptCore edited by fpizlo@apple.com
(diff)
11:29 AM Changeset in webkit [155634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl] Use utf8 for headers in CurlDownload.
​https://bugs.webkit.org/show_bug.cgi?id=120413

Patch by Tamas Czene <​tczene@inf.u-szeged.hu> on 2013-09-12
Reviewed by Brent Fulgham.

  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::headerCallback):

11:26 AM Changeset in webkit [155633] by galpeter@inf.u-szeged.hu
  • 7 edits
    2 adds in trunk/Source/WebCore

[curl] Improve multipart response handling
​https://bugs.webkit.org/show_bug.cgi?id=117735

Reviewed by Brent Fulgham.

The multipart/x-mixed-replace mime type in responses are ignored
with the curl network backend. To handle such responses the
MultipartHandle is introduced which will split the content using
the boundary specified by the mime type.

There are already existing tests (http/tests/multipart).

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPHeader):

  • platform/network/HTTPParsers.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/curl/MultipartHandle.cpp: Added.

(WebCore::MultipartHandle::extractBoundary):
(WebCore::MultipartHandle::matchForBoundary):
(WebCore::MultipartHandle::checkForBoundary):
(WebCore::MultipartHandle::parseHeadersIfPossible):
(WebCore::MultipartHandle::contentReceived):
(WebCore::MultipartHandle::processContent):
(WebCore::MultipartHandle::contentEnded):
(WebCore::MultipartHandle::didReceiveData):
(WebCore::MultipartHandle::didReceiveResponse):

  • platform/network/curl/MultipartHandle.h: Added.

(WebCore::MultipartHandle::MultipartHandle):
(WebCore::MultipartHandle::~MultipartHandle):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::writeCallback):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):

11:13 AM Changeset in webkit [155632] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

MarkedBlocks shouldn't be put in Allocated state if they didn't produce a FreeList
​https://bugs.webkit.org/show_bug.cgi?id=121236

Reviewed by Geoffrey Garen.

Right now, after a collection all MarkedBlocks are in the Marked block state. When lazy sweeping
happens, if a block returns an empty free list after being swept, we call didConsumeFreeList(),
which moves the block into the Allocated block state. This happens to both the block that was
just being allocated out of (i.e. m_currentBlock) as well as any blocks who are completely full.
We should distinguish between these two cases: m_currentBlock should transition to
Allocated (because we were just allocating out of it) and any subsequent block that returns an
empty free list should transition back to the Marked state. This will make the block state more
consistent with the actual state the block is in, and it will also allow us to speed up moving
all blocks to the Marked state during generational collection.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::didConsumeEmptyFreeList):

10:54 AM Changeset in webkit [155631] by akling@apple.com
  • 15 edits
    2 deletes in trunk/Source

Remove RenderApplet.
<​https://webkit.org/b/121231>

Reviewed by Darin Adler.

Add a RenderEmbeddedObject::createForApplet(HTMLAppletElement&) and nuke
the RenderApplet class from orbit.

10:46 AM Changeset in webkit [155630] by Brent Fulgham
  • 5 edits in trunk/Source/WebCore

[Windows] Build fix after r155621

Rubber-stamped by Anders Carlsson.

See also ​https://bugs.webkit.org/show_bug.cgi?id=121235 for
why this was necessary.

  • css/MediaQueryEvaluator.cpp: Work around VS compiler bug.
  • dom/make_names.pl: Ditto.
  • loader/archive/ArchiveFactory.cpp: Ditto.
  • rendering/svg/SVGPathData.cpp: Ditto.
10:38 AM Changeset in webkit [155629] by andersca@apple.com
  • 13 edits in trunk/Source

SharedBuffer::createCFData should return RetainPtr<CFDataRef>
​https://bugs.webkit.org/show_bug.cgi?id=121230

Reviewed by Darin Adler.

Source/WebCore:

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::createCFData):

  • loader/ResourceBuffer.h:
  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):

  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::createCFData):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::setData):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::createPDFDocument):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

Source/WebKit2:

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

  • Shared/WebArchiveResource.cpp:

(WebKit::WebArchiveResource::data):

9:57 AM Changeset in webkit [155628] by zoltan@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

Move LineInfo class into LineInfo.h
​https://bugs.webkit.org/show_bug.cgi?id=121191

Reviewed by David Hyatt.

No new tests, no behavior change.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/LineInfo.h: Added.

(WebCore::LineInfo::LineInfo):
(WebCore::LineInfo::isFirstLine):
(WebCore::LineInfo::isLastLine):
(WebCore::LineInfo::isEmpty):
(WebCore::LineInfo::previousLineBrokeCleanly):
(WebCore::LineInfo::floatPaginationStrut):
(WebCore::LineInfo::runsFromLeadingWhitespace):
(WebCore::LineInfo::resetRunsFromLeadingWhitespace):
(WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
(WebCore::LineInfo::setFirstLine):
(WebCore::LineInfo::setLastLine):
(WebCore::LineInfo::setEmpty):
(WebCore::LineInfo::setPreviousLineBrokeCleanly):
(WebCore::LineInfo::setFloatPaginationStrut):

  • rendering/RenderBlockLineLayout.cpp:
9:50 AM Changeset in webkit [155627] by Bem Jones-Bey
  • 7 edits in trunk/Source/WebCore

[CSS Shapes] Remove unnecessarily complex template from ShapeInfo classes
​https://bugs.webkit.org/show_bug.cgi?id=121213

Reviewed by Darin Adler.

These classes were trying to be way too clever, and as a result were
hard to read and hard to debug. Replace the complex templated method
calls with virtual methods to make these classes much easier to
understand and maintain.

No new tests, no behavior change.

  • rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape):
(WebCore::::computeSegmentsForLine):

  • rendering/shapes/ShapeInfo.h:
  • rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::getShapeValue):

  • rendering/shapes/ShapeInsideInfo.h:

(WebCore::ShapeInsideInfo::computeSegmentsForLine):
(WebCore::ShapeInsideInfo::ShapeInsideInfo):

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computeSegmentsForLine):
(WebCore::ShapeOutsideInfo::getShapeValue):

  • rendering/shapes/ShapeOutsideInfo.h:

(WebCore::ShapeOutsideInfo::ShapeOutsideInfo):

9:49 AM Changeset in webkit [155626] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Turn shape's logicalwidth/height into a LayoutSize
​https://bugs.webkit.org/show_bug.cgi?id=121187

Reviewed by David Hyatt.

No new tests, no behavior change.

  • rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape):

  • rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::shapeContainingBlockHeight):

9:47 AM Changeset in webkit [155625] by Darin Adler
  • 7 edits in trunk/Source/WebCore

Move layering-violating code from Pasteboard::plainText into Editor (Mac only at first)
​https://bugs.webkit.org/show_bug.cgi?id=121075

Reviewed by Anders Carlsson.

  • editing/Editor.cpp:

(WebCore::Editor::pasteAsPlainTextBypassingDHTML): Pass pasteboard as a reference.
(WebCore::Editor::pasteAsPlainTextWithPasteboard): Use readPlainTextFromPasteboard
for Mac. Also update to take a reference.
(WebCore::Editor::paste): Pass pasteboard as a reference.
(WebCore::Editor::pasteAsPlainText): Ditto.

  • editing/Editor.h: Ditto.
  • editing/mac/EditorMac.mm:

(WebCore::Editor::readSelectionFromPasteboard): Pass pasteboard as a reference.
(WebCore::Editor::readPlainTextFromPasteboard): Added. The declaration of this
was added (by mistake) in an earlier patch. This has code that used to be inside
Pasteboard::plainText.

  • platform/Pasteboard.h: Added PasteboardPlainText. Reorganized functions in the

Pasteboard class and added some FIXMEs. Sorted platforms alphabetically and grouped
functions together and data members separate from them.

  • platform/mac/DragDataMac.mm:

(WebCore::DragData::asPlainText): Updated to call readPlainTextFromPasteboard.
(WebCore::DragData::asURL): Tweaked style of unused parameter.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::read): Renamed this from plainText, and refactored so that
the data goes out in the PasteboardPlainText structure.

9:44 AM Changeset in webkit [155624] by commit-queue@webkit.org
  • 6 edits
    8 adds in trunk

CSS Unit vw in border-width maps to 0px.
​https://bugs.webkit.org/show_bug.cgi?id=109229

Patch by Gurpreet Kaur <​k.gurpreet@samsung.com> on 2013-09-12
Reviewed by Darin Adler.

Source/WebCore:

Border and outline properties were not applied incase
its values were given in vh/vw units.

Tests: fast/css/viewport-height-border.html

fast/css/viewport-height-outline.html
fast/css/viewport-width-border.html
fast/css/viewport-width-outline.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):
Added case CSS_VH and CSS_VW.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isViewportPercentageWidth):
(WebCore::CSSPrimitiveValue::isViewportPercentageHeight):
Added APIs to check the unit type(CSS_VW and CSS_VH).

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):
Calculating the border values which has been specified
in vh/vw units.The vh/vw units are calcultated as percent
of viewport height and viewport width respectively.

LayoutTests:

  • fast/css/viewport-height-border-expected.txt: Added.
  • fast/css/viewport-height-border.html: Added.
  • fast/css/viewport-height-outline-expected.txt: Added.
  • fast/css/viewport-height-outline.html: Added.
  • fast/css/viewport-width-border-expected.txt: Added.
  • fast/css/viewport-width-border.html: Added.
  • fast/css/viewport-width-outline-expected.txt: Added.
  • fast/css/viewport-width-outline.html: Added.

Added new tests for verifying that border and outline properties are
applied when its values are given in vh/vw units.

  • resources/js-test-pre.js:

(shouldNotBeEqualToString):
Added this API so that can compare two strings.Similiar to
shouldBeEqualToString.

9:42 AM Changeset in webkit [155623] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebCore

[Coordinated Graphics] Fix the build on MacOS 10.9
​https://bugs.webkit.org/show_bug.cgi?id=121225

Reviewed by Darin Adler.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
9:27 AM Changeset in webkit [155622] by mark.lam@apple.com
  • 15 edits in trunk/Source

Change debug hooks to pass sourceID and position info via the DebuggerCallFrame.
​https://bugs.webkit.org/show_bug.cgi?id=121214.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • debugger/Debugger.h:
  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::sourceId):
(JSC::DebuggerCallFrame::clear):

  • debugger/DebuggerCallFrame.h:

(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):

  • interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):

Source/WebCore:

No new tests.

Also changed the Inspector's JavaScriptCallFrame to get the sourceID and
position info from its DebuggerCallFrame instead of caching those values.

  • bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):

  • bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::invalidate):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::update):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::willExecuteProgram):

  • bindings/js/WorkerScriptDebugServer.h:

Source/WebKit/mac:

  • webview/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::exception):
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
(WebScriptDebugger::didReachBreakpoint):

9:13 AM Changeset in webkit [155621] by andersca@apple.com
  • 5 edits in trunk

Add rudimentary support for move-only types as values in HashMap
​https://bugs.webkit.org/show_bug.cgi?id=121226

Reviewed by Andreas Kling.

Source/WTF:

  • wtf/HashMap.h:

Change a bunch of functions to so they can take both rvalue and lvalue references and use std::forward.

  • wtf/HashTraits.h:

(WTF::KeyValuePair::KeyValuePair):
Change constructors to accept both lvalues and rvalues.

Tools:

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):
Add a HashMap<unsigned, MoveOnly> test.

9:07 AM Changeset in webkit [155620] by zandobersek@gmail.com
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r155619 - [GTK][WK1] Block accelerated compositing under non-X11 displays
​https://bugs.webkit.org/show_bug.cgi?id=121165

Reviewed by Martin Robinson.

This is analogous to the changes in r154728 and r154729 that enforce disabling accelerated compositing
under Wayland displays and made the RedirectedXCompositeWindow use in WebKit2 limited only to the X11 displays.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp: Remove two unnecessary header includes that also

introduce symbols that conflict with the symbols defined in the X headers. Include the <gdk/gdkx.h> header
if the GTK+ dependency can provide it.
(WebKit::AcceleratedCompositingContext::initialize): Only set up the RedirectedXCompositeWindow instance
if running under an X11 display.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): The removal of the unnecessary header
inclusions also removed the std::max() injection into the global scope. Using std::max directly instead.
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush): Ditto.

  • webkit/webkitwebview.cpp:

(updateAcceleratedCompositingSetting): A helper function that ensures the accelerated compositing feature
stays disabled under Wayland displays. It also prints out a warning message the first time the user tries
to enable accelerated compositing under Wayland displays, telling that the feature is not supported and
will remain disabled.
(webkit_web_view_update_settings): Call updateAcceleratedCompositingSetting() to enable the feature if possible.
(webkit_web_view_settings_notify): Ditto.

9:02 AM Changeset in webkit [155619] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit/gtk

[GTK][WK1] Block accelerated compositing under non-X11 displays
​https://bugs.webkit.org/show_bug.cgi?id=121165

Reviewed by Martin Robinson.

This is analogous to the changes in r154728 and r154729 that enforce disabling accelerated compositing
under Wayland displays and made the RedirectedXCompositeWindow use in WebKit2 limited only to the X11 displays.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp: Remove two unnecessary header includes that also

introduce symbols that conflict with the symbols defined in the X headers. Include the <gdk/gdkx.h> header
if the GTK+ dependency can provide it.
(WebKit::AcceleratedCompositingContext::initialize): Only set up the RedirectedXCompositeWindow instance
if running under an X11 display.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): The removal of the unnecessary header
inclusions also removed the std::max() injection into the global scope. Using std::max directly instead.
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush): Ditto.

  • webkit/webkitwebview.cpp:

(updateAcceleratedCompositingSetting): A helper function that ensures the accelerated compositing feature
stays disabled under Wayland displays. It also prints out a warning message the first time the user tries
to enable accelerated compositing under Wayland displays, telling that the feature is not supported and
will remain disabled.
(webkit_web_view_update_settings): Call updateAcceleratedCompositingSetting() to enable the feature if possible.
(webkit_web_view_settings_notify): Ditto.

8:55 AM Changeset in webkit [155618] by commit-queue@webkit.org
  • 12 edits in trunk/LayoutTests

[EFL] Changed expected results after turning on WTF_USE_TILED_BACKING_STORE (r133898)
​https://bugs.webkit.org/show_bug.cgi?id=121227

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2013-09-12

  • platform/efl/TestExpectations:
  • platform/efl/editing/selection/caret-ltr-2-expected.png:
  • platform/efl/editing/selection/caret-ltr-2-expected.txt:
  • platform/efl/editing/selection/caret-ltr-2-left-expected.png:
  • platform/efl/editing/selection/caret-ltr-2-left-expected.txt:
  • platform/efl/editing/selection/caret-ltr-expected.png:
  • platform/efl/editing/selection/caret-ltr-expected.txt:
  • platform/efl/editing/selection/caret-rtl-2-expected.png:
  • platform/efl/editing/selection/caret-rtl-2-expected.txt:
  • platform/efl/editing/selection/caret-rtl-expected.png:
  • platform/efl/editing/selection/caret-rtl-expected.txt:
8:55 AM Changeset in webkit [155617] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[Win] TestWebKitAPI fails to link.
​https://bugs.webkit.org/show_bug.cgi?id=121223

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-09-12
Reviewed by Brent Fulgham.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add required symbol.
8:52 AM Changeset in webkit [155616] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCairo] Compile errors, missing include.
​https://bugs.webkit.org/show_bug.cgi?id=121222

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-09-12
Reviewed by Brent Fulgham.

  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: Include required header.
  • platform/win/DragImageCairoWin.cpp: Include required header.
8:46 AM Changeset in webkit [155615] by Alan Bujtas
  • 3 edits
    3 adds in trunk

REGRESSION: Inline PDF that are cached fail to appear in iframe.
​https://bugs.webkit.org/show_bug.cgi?id=75449

Reviewed by Darin Adler.

Make sure 'frame is from page cache' flag is set for subframes too.

WebFrameLoaderClient::m_frameCameFromPageCache == true forces plugins
to be loaded manually. It ensures that the plugin raw data is fetched again
while the containing frame is being restored from the page cache.
(Plugins get destroyed when the frame goes to page cache.)

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
This gets called only on the frame where the actual history navigation happens.
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
This gets called for all the restored frames.

LayoutTests:

  • fast/history/history-back-while-pdf-in-pagecache-expected.html: Added.
  • fast/history/history-back-while-pdf-in-pagecache.html: Added.
  • fast/history/resources/history-back-for-pfd-test.html: Added.
8:30 AM Changeset in webkit [155614] by Csaba Osztrogonác
  • 7 edits
    2 adds in trunk/Tools

Auto GDB backtrace generation for EFL/GTK/Qt bots.
​https://bugs.webkit.org/show_bug.cgi?id=119338

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-09-12
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/port/efl.py:

(EflPort.check_sys_deps):
(EflPort):
(EflPort._get_crash_log):

  • Scripts/webkitpy/port/efl_unittest.py:

(EflPortTest.test_show_results_html_file):
(EflPortTest):
(EflPortTest.test_get_crash_log):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort._get_crash_log):

  • Scripts/webkitpy/port/gtk_unittest.py:

(GtkPortTest.test_get_crash_log):

  • Scripts/webkitpy/port/linux_get_crash_log.py: Added.

(GDBCrashLogGenerator):
(GDBCrashLogGenerator.init):
(GDBCrashLogGenerator._get_gdb_output):
(GDBCrashLogGenerator.generate_crash_log):
(GDBCrashLogGenerator.generate_crash_log.match_filename):

  • Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.

(GDBCrashLogGeneratorTest):
(GDBCrashLogGeneratorTest.test_generate_crash_log):
(_mock_gdb_output):

  • Scripts/webkitpy/port/qt.py:

(QtPort.default_child_processes):
(QtPort):
(QtPort._get_crash_log):

  • Scripts/webkitpy/port/qt_unittest.py:

(QtPortTest.test_check_sys_deps):
(QtPortTest):
(QtPortTest.test_get_crash_log):

8:28 AM Changeset in webkit [155613] by Csaba Osztrogonác
  • 4 edits in trunk/Source/JavaScriptCore

Add back c++11 features removed by buildfixes after all ports did the switch
​https://bugs.webkit.org/show_bug.cgi?id=119266

Reviewed by Anders Carlsson.

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::~Worklist):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::codeType):
(JSC::StackVisitor::Frame::functionName):
(JSC::StackVisitor::Frame::sourceURL):
(JSC::StackVisitor::Frame::print):

8:09 AM Changeset in webkit [155612] by galpeter@inf.u-szeged.hu
  • 2 edits in trunk/Tools

Unreviewed. Moving myself to the commiters list.

  • Scripts/webkitpy/common/config/contributors.json:
7:56 AM Changeset in webkit [155611] by kadam@inf.u-szeged.hu
  • 36 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase after r155253.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-09-12

  • platform/qt-wk2/editing/style/style-boundary-005-expected.png: Added.
  • platform/qt/editing/pasteboard/4989774-expected.png:
  • platform/qt/editing/pasteboard/4989774-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.png:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/selection/caret-ltr-2-expected.png:
  • platform/qt/editing/selection/caret-ltr-2-expected.txt:
  • platform/qt/editing/selection/caret-ltr-2-left-expected.png:
  • platform/qt/editing/selection/caret-ltr-2-left-expected.txt:
  • platform/qt/editing/selection/caret-ltr-expected.png:
  • platform/qt/editing/selection/caret-ltr-expected.txt:
  • platform/qt/editing/selection/caret-ltr-right-expected.png:
  • platform/qt/editing/selection/caret-ltr-right-expected.txt:
  • platform/qt/editing/selection/caret-rtl-2-expected.png:
  • platform/qt/editing/selection/caret-rtl-2-expected.txt:
  • platform/qt/editing/selection/caret-rtl-2-left-expected.png:
  • platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/qt/editing/selection/caret-rtl-expected.png:
  • platform/qt/editing/selection/caret-rtl-expected.txt:
  • platform/qt/editing/selection/caret-rtl-right-expected.png:
  • platform/qt/editing/selection/caret-rtl-right-expected.txt:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/qt/editing/style/style-boundary-005-expected.png:
  • platform/qt/editing/style/style-boundary-005-expected.txt:
  • platform/qt/fast/forms/formmove3-expected.txt:
  • platform/qt/fast/forms/input-align-image-expected.png:
  • platform/qt/fast/forms/input-align-image-expected.txt:
  • platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/qt/fast/invalid/003-expected.png:
  • platform/qt/fast/invalid/003-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug647-expected.png:
  • platform/qt/tables/mozilla/bugs/bug647-expected.txt:
7:51 AM Changeset in webkit [155610] by ChangSeok Oh
  • 1 edit
    1 add in trunk/Tools

[GTK] Add jhbuild-wayland.modules
​https://bugs.webkit.org/show_bug.cgi?id=120455

Reviewed by Gustavo Noronha Silva.

Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
WEBKIT_EXTRA_MODULESETS.

  • gtk/jhbuild-wayland.modules: Added.
7:41 AM Changeset in webkit [155609] by vivek.vg@samsung.com
  • 3 edits
    2 adds in trunk

XMLSerializer.serializeToString() should throw exception for invalid node value.
​https://bugs.webkit.org/show_bug.cgi?id=121209

Reviewed by Darin Adler.

Source/WebCore:

FF and Opera 12 (pre blink/webkit) throw exception in case the node value is invalid.
Blink sends an empty string as the result of serializeToString operation with invalid node.
We should match with other browsers for throwing it as an exception.

Blink review URL: ​https://chromiumcodereview.appspot.com/23532055/

Test: fast/dom/xmlserializer-serialize-to-string-exception.html

  • xml/XMLSerializer.cpp:

(WebCore::XMLSerializer::serializeToString):

LayoutTests:

  • fast/dom/xmlserializer-serialize-to-string-exception-expected.txt: Added.
  • fast/dom/xmlserializer-serialize-to-string-exception.html: Added.
7:27 AM Changeset in webkit [155608] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Crash in ScrollingStateStickyNode::updateConstraints
​https://bugs.webkit.org/show_bug.cgi?id=119638

Reviewed by Simon Fraser.

Ensure when a scrolling state node is removed from the state tree,
we remove both the current node and all its children from the
associated m_stateNodeMap lookup table.

Source/WebCore:

Test: fast/css/sticky/multiple-layers-sticky-crash.html

  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::removeChild):
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree):

  • page/scrolling/ScrollingStateNode.h:

LayoutTests:

  • fast/css/sticky/multiple-layers-sticky-crash-expected.txt: Added.
  • fast/css/sticky/multiple-layers-sticky-crash.html: Added.
7:03 AM Changeset in webkit [155607] by Alan Bujtas
  • 6 edits
    4 adds in trunk

REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing
​https://bugs.webkit.org/show_bug.cgi?id=101047

Reviewed by Simon Fraser.

Compositing layers keep track of ancestors' clipping by constructing the RenderLayerBacking::m_ancestorClippingLayer.
It helps setting up the proper clipping context for the corresponding graphics layer.
When a RenderObject's clipping style changes, it needs to propagate this change not only
to the associated RenderLayer, but also to the descendants', if applicable.
Before r132516, it was mainly covered by initiating full style recalcs, which ensured that
style recalc on the descendant rendering tree took care of creating/destroying
RenderLayerBacking::m_ancestorClippingLayer at every compositing layer node. Without the full
recalc, the clipping of the compositing render layers and the corresponding render subtrees can get out of sync.
This patch updates the clipping context on the descendant subtree, when the clipping behaviour
changes on a render node.

Source/WebCore:

Tests: compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html

compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateDescendantClippingContext):
(WebCore::RenderLayer::styleChanged):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateAncestorClippingLayer):
(WebCore::RenderLayerBacking::updateDescendantClippingLayer):

  • rendering/RenderLayerBacking.h:

LayoutTests:

  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added.
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html: Added.
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added.
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html: Added.
4:15 AM Changeset in webkit [155606] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][WK2] a11y tests unconditionally launching a11y daemons
​https://bugs.webkit.org/show_bug.cgi?id=120299

Patch by Mario Sanchez Prada <​mario.prada@samsung.com> on 2013-09-12
Reviewed by Carlos Garcia Campos.

Use the right variable name to store a reference to the at-spi2
bus launcher process, so we can be sure we are terminating it when
calling _tear_down_testing_environment().

  • Scripts/run-gtk-tests:

(TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
instead of _ally_bus_launcher.

3:54 AM Changeset in webkit [155605] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
​https://bugs.webkit.org/show_bug.cgi?id=121218

Reviewed by Philippe Normand.

Skipping the entire suite was added to skip tests when they can't
be run because of the environment, for example to skip the a11y
tests when the at-spi daemons fail to start. This is no longer
true for all the cases, so we can disable the tests that are
impossible to run instead of skipping them.

  • Scripts/run-gtk-tests:

(TestRunner.init): Initialize the skipped tests list.
(TestRunner._setup_testing_environment): Add
TestWebKitAccessibility path to the list of disabled tests when
at-spi daemon fail to start.
(TestRunner._should_run_test_program): Check first if the test
program is disabled and then whether it's skipped honoring the
skipped command line option.

3:42 AM Changeset in webkit [155604] by mikhail.pozdnyakov@intel.com
  • 20 edits
    2 deletes in trunk/Source

Remove home-brewed nullptr
​https://bugs.webkit.org/show_bug.cgi?id=119624

Reviewed by Anders Carlsson.

The standard C++11 nullptr and std::nullptr_t type should be used now.

Source/JavaScriptCore:

  • heap/PassWeak.h:
  • heap/Weak.h:

Source/WebCore:

  • bindings/js/JSDOMBinding.h:

Source/WebKit/efl:

  • tests/UnitTestUtils/EWKTestView.cpp:

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/NullPtr.cpp: Removed.
  • wtf/NullPtr.h: Removed.
  • wtf/OwnArrayPtr.h:
  • wtf/OwnPtr.h:
  • wtf/PassOwnPtr.h:
  • wtf/PassRefPtr.h:
  • wtf/RetainPtr.h:
  • wtf/win/GDIObject.h:
3:24 AM Changeset in webkit [155603] by commit-queue@webkit.org
  • 14 edits
    1 move in trunk

<meter> element text value exposed as AXTitle; should be exposing AXValueDescription
​https://bugs.webkit.org/show_bug.cgi?id=117651

Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Mario Sanchez Prada.

Source/WebCore:

No new tests, updated accessibility/meter-element to handle platform specific output.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isMeter):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::valueDescription):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::valueDescription):

LayoutTests:

Updated existing meter element test to cover platform specific output.

  • accessibility/meter-element.html:
  • platform/mac/accessibility/aria-valuetext-on-native-slider-expected.txt:
  • platform/mac/accessibility/aria-valuetext-on-native-slider.html:
  • platform/mac/accessibility/aria-valuetext.html:
  • platform/mac/accessibility/meter-element-expected.txt: Renamed from LayoutTests/accessibility/meter-element-expected.txt.
  • platform/mac/accessibility/spinbutton-valuedescription-expected.txt:
  • platform/mac/accessibility/spinbutton-valuedescription.html:
2:54 AM Changeset in webkit [155602] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

class WeekInputType invokes wrong constructor
​https://bugs.webkit.org/show_bug.cgi?id=120768

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-09-12
Reviewed by Andreas Kling.

Correcting wrong constuctor invocation.

  • html/WeekInputType.h:

(WebCore::WeekInputType::WeekInputType):

2:51 AM Changeset in webkit [155601] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

AX: Self-referencing aria-labelledby only uses contents.
​https://bugs.webkit.org/show_bug.cgi?id=120814

Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Implemented additional 'Text Alternative Computation' steps documented at:
​http://www.w3.org/WAI/PF/aria/complete#textalternativecomputation. This allows us to remove
our raw text node iteration that was previously forcing us to do our computation incorrectly.
Element content is now sourced using textUnderElement (step 2C of the computation).

Test: accessibility/self-referencing-aria-labelledby.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):

LayoutTests:

Test to verify that self-referencing aria-labelledby behavior works as expected.

  • accessibility/self-referencing-aria-labelledby-expected.txt: Added.
  • accessibility/self-referencing-aria-labelledby.html: Added.
2:38 AM Changeset in webkit [155600] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r155597.
​http://trac.webkit.org/changeset/155597
​https://bugs.webkit.org/show_bug.cgi?id=121220

broke windows build because there's no ews :( (Requested by
thorton on #webkit).

  • WebCore.exp.in:
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::isBitmapImage):

  • platform/graphics/BitmapImage.h:

(WebCore::BitmapImage::create):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):

  • platform/graphics/CrossfadeGeneratedImage.h:

(WebCore::CrossfadeGeneratedImage::setContainerSize):
(WebCore::CrossfadeGeneratedImage::usesContainerSize):
(WebCore::CrossfadeGeneratedImage::hasRelativeWidth):
(WebCore::CrossfadeGeneratedImage::hasRelativeHeight):
(WebCore::CrossfadeGeneratedImage::size):

  • platform/graphics/GeneratedImage.h:

(WebCore::GeneratedImage::hasSingleSecurityOrigin):
(WebCore::GeneratedImage::setContainerSize):
(WebCore::GeneratedImage::usesContainerSize):
(WebCore::GeneratedImage::hasRelativeWidth):
(WebCore::GeneratedImage::hasRelativeHeight):
(WebCore::GeneratedImage::size):
(WebCore::GeneratedImage::destroyDecodedData):
(WebCore::GeneratedImage::decodedSize):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):

  • platform/graphics/GeneratorGeneratedImage.h:

(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):

  • svg/graphics/SVGImage.h:

(WebCore::SVGImage::isSVGImage):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::destroyDecodedData):
(WebCore::SVGImage::decodedSize):

  • svg/graphics/SVGImageForContainer.h:

(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):

2:31 AM Changeset in webkit [155599] by commit-queue@webkit.org
  • 7 edits in trunk

REGRESSION(r154781): accessibility/notification-listeners.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=120669

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-09-12
Reviewed by Chris Fleizach.

Tools:

Fixed 4 problems that were causing notification-listeners.html to fail.

Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
implemented in axObjectEventListener().

A notification for AXFocusedUIElementChanged was incorrectly sent when
the element lost focus.

Global notification was not dispatched if an element notification was
present in the HashMap.

connectAccessibilityCallbacks() was connecting signals to callbacks
multiple times because it was not checking if
disconnectAccessibilityCallbacks() had an early return if there were
active handlers.

  • DumpRenderTree/atk/AccessibilityCallbacks.h: Modified

disconnectAccessibilityCallbacks() to inform if the callbacks were
successfully disconnected.

  • DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:

(axObjectEventListener): Implemented notifications for
AXFocusedUIElementChanged and AXValueChanged. Fixed the global
notification, which was not dispatched if an element notification
existed. Fixed the notification for AXFocusedUIElementChanged that was
incorrectly sent when the element lost focus. In addition, fixed a typo
where TRUE should be true.
(connectAccessibilityCallbacks): Added early return if
disconnectAccessibilityCallbacks() did not disconnect the callbacks.
(disconnectAccessibilityCallbacks): Added a return value to inform if
callbacks were successfully disconnected.

LayoutTests:

Updated the expectation for notification-listeners.html, which was
failing before this fix.

  • platform/gtk/TestExpectations: Removed notification-listeners.html.
  • platform/gtk/accessibility/notification-listeners-expected.txt:

Updated the expectation for notification-listeners.html. There is one
difference from the results on the Mac port, which was used as
reference. The element role for <select> is AXComboBox while on Mac
is AXPopUpButton.

2:12 AM Changeset in webkit [155598] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

RenderWidget elements are always HTMLFrameOwnerElement subclasses.
<​https://webkit.org/b/121217>

Reviewed by Antti Koivisto.

Make RenderWidget constructor take HTMLFrameOwnerElement* and update subclasses
with even tighter types where possible.

Also added RenderWidget::frameOwnerElement() and deleted element().
Removed a handful of unnecessary type checks that were exposed by this.

2:03 AM Changeset in webkit [155597] by timothy_horton@apple.com
  • 11 edits in trunk/Source/WebCore

Apply OVERRIDE and FINAL to Image subclasses and clean them up
​https://bugs.webkit.org/show_bug.cgi?id=121086

Reviewed by Alexey Proskuryakov.

Everything other than the copious application of OVERRIDE and FINAL
is explicitly called out below.

  • WebCore.exp.in:

Export the correct version of getCGImageRef for use by WebKit2.

  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/BitmapImage.h:

Drive-by inline isBitmapImage.
Move create(HBITMAP) to be near the other create() functions.
Move all of the members and quite a few functions from protected to private.
Devirtualize frameCount().
Move notSolidColor() near the other solid color functions.

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
Use size() and setContainerSize() instead of directly accessing a
superclass' (now private, previously protected) members.

  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/GeneratedImage.h:

Make m_size private, I don't think we do protected members.

  • platform/graphics/GeneratorGeneratedImage.h:

Make all the members private.

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageForContainer.h:
1:32 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)

Sep 11, 2013:

11:21 PM Changeset in webkit [155596] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Canvas fillText and measureText handle ideographic spaces differently
​https://bugs.webkit.org/show_bug.cgi?id=108881

Patch by Rashmi Shyamasundar <​rashmi.s2@samsung.com> on 2013-09-11
Reviewed by Darin Adler.

Source/WebCore:

According to spec for text preparation algorithm
​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#text-preparation-algorithm
all the space characters mentioned in the spec
​http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#space-character
should be replaced by U+0020 space character.
The canvas functions fillText and measureText should run the text preparation algorithm.
This patch modifies the canvas functions drawTextInternal and measureText to conform to the above spec.

Tests: fast/canvas/canvas-measureText-ideographicSpace.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::shouldSpaceBeReplaced):
(WebCore::replaceCharacterInString):
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

According to the text preparation algorithm defined in the spec
​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#text-preparation-algorithm
all the spaces listed in the spec
​http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#space-character
should be replaced by +U0020 space character.
The below listed layout tests verify the conformance to above spec.
These tests are passing on Ubuntu-Firefox 23.0.

  • fast/canvas/canvas-measureText-ideographicSpace-expected.txt: Added.
  • fast/canvas/canvas-measureText-ideographicSpace.html: Added.
10:55 PM Changeset in webkit [155595] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Rename initInteger() to initInt32()

Rubber stamped by Mark Hahnenberg.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::initInt32):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::integerResult):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:52 PM Changeset in webkit [155594] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Rename IntegerOperand to Int32Operand and fillInteger() to fillInt32().

Rubber stamped by Mark Hahnenberg.

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::fillInt32):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::Int32Operand::Int32Operand):
(JSC::DFG::Int32Operand::~Int32Operand):
(JSC::DFG::Int32Operand::gpr):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

10:46 PM Changeset in webkit [155593] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FixupPhase should always call fixEdge() exactly once for every edge
​https://bugs.webkit.org/show_bug.cgi?id=121211

Reviewed by Geoffrey Garen.

Previously we only call fixEdge() on edges that we want to make typed. UntypedUse
edges don't get fixEdge() called. This makes it difficult to add functionality in
fixEdge() that runs for UntypedUses. It's difficult to remember to call fixEdge()
for every edge that we don't want to turn into a typed edge; in an alternative
universe where we did this, it would mean that every case in FixupPhase would
have to make a fixEdge() call for *every* edge even ones that it doesn't want to
modify.

This patch takes a different path. fixEdge() must never be called explicitly with
UntypedUse. fixEdge() should be used to set the UseKind of edges. Consequently,
all that FixupPhase has to do is call fixEdge<UntypedUse>(edge) for every edge
that was still UntypedUse after we are done processing a node.

This is cheap and easy to implement and ought to be easy to maintain. We won't
have a need to call fixEdge<UntypedUse>(edge) explicitly, so depending on that is
only natural.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::observeUntypedEdge):
(JSC::DFG::FixupPhase::observeUseKindOnNode):

10:36 PM Changeset in webkit [155592] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build.

  • rendering/RenderingAllInOne.cpp:
10:21 PM Changeset in webkit [155591] by akling@apple.com
  • 45 edits
    2 deletes in trunk/Source

Merge RenderPart into RenderWidget.
<​https://webkit.org/b/121200>

Reviewed by Anders Carlsson.

Remove the RenderPart class and move its functionality into RenderWidget.
It was acting as a pointless extra layer between RenderWidget and renderers
for embedded objects, frames and iframes.

9:48 PM Changeset in webkit [155590] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FixupPhase's setUseKindAndUnboxBlahbittyblah and fixDoubleEdge methods should be merged and given intuitive names
​https://bugs.webkit.org/show_bug.cgi?id=121202

Reviewed by Geoffrey Garen.

Got rid of a method whose name was so descriptive that I couldn't ever remember
it. And despite the descriptive name, I always had to look at its implementation
to remind myself what it did, anyway.

Now that method is called fixEdge(). This is a good name because we're in a phase
called FixupPhase, and we call this fixEdge() method on pretty much every edge.
For the Int48 work, it makes more sense for this method to be a kind of hook into
which we can place various things: it's just a way of observing edges that need
attention.

As part of this refactoring, I also fold fixDoubleEdge into fixEdge. This makes
sense because previously it was never correct to call fixDoubleEdge with non-
double use kinds; and conversely it was never correct to call fixEdge with double
use kinds.

Also I found that isDouble() in DFGUseKind.h would return true for KnownInt32Use.
That's almost certainly wrong, and removing that behavior doesn't fail any tests.
I'm assuming that was just a bug.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(JSC::DFG::FixupPhase::fixupToString):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):
(JSC::DFG::FixupPhase::convertToGetArrayLength):
(JSC::DFG::FixupPhase::attemptToMakeGetTypedArrayByteOffset):

  • dfg/DFGUseKind.h:

(JSC::DFG::isDouble):

8:08 PM Changeset in webkit [155589] by ggaren@apple.com
  • 17 edits
    2 deletes in trunk

Removed some unused functions from the debugger interface
​https://bugs.webkit.org/show_bug.cgi?id=121194

Reviewed by Joseph Pecoraro.

We plan to use the "evaluate" API and debugger activation property access for all the features we need.

Source/WebCore:

  • inspector/JavaScriptCallFrame.idl: These are the interfaces I removed.
  • bindings/js/JSJavaScriptCallFrameCustom.cpp:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setScriptSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/JavaScriptCallFrame.idl:
  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.):
(WebInspector.RemoteObject.prototype.setPropertyValue): These files are mechanical removals of code that used
or implemented the interfaces I removed.

Source/WebInspectorUI:

  • UserInterface/InspectorBackendCommands.js: Updated by script.

LayoutTests:

  • inspector/debugger/debugger-change-variable-expected.txt: Removed.
  • inspector/debugger/debugger-change-variable.html: Removed. This test was failing

because we don't support this API.

  • platform/mac/inspector/console/command-line-api-expected.txt: This test changed line numbers

because I changed inspector .js files.

7:52 PM Changeset in webkit [155588] by andersca@apple.com
  • 2 edits in trunk/Tools

Try to fix GCC builds.

  • TestWebKitAPI/Tests/WTF/MoveOnly.h:
7:26 PM Changeset in webkit [155587] by andersca@apple.com
  • 5 edits
    1 move in trunk/Tools

Try to fix the build.

Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
file in the Tests/ directory in the first place.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
7:26 PM Changeset in webkit [155586] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fixed indentation in JSC Debugger header files.
​https://bugs.webkit.org/show_bug.cgi?id=121203.

Reviewed by Ryosuke Niwa.

  • debugger/Debugger.h:
  • debugger/DebuggerActivation.h:

(JSC::DebuggerActivation::create):
(JSC::DebuggerActivation::createStructure):

  • debugger/DebuggerCallFrame.h:

(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::callFrame):
(JSC::DebuggerCallFrame::dynamicGlobalObject):
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::exception):

7:16 PM Changeset in webkit [155585] by andersca@apple.com
  • 4 edits in trunk/Source/WTF

Use the new C++11 function declaration syntax throughout our hash collection classes
​https://bugs.webkit.org/show_bug.cgi?id=121195

Reviewed by Andreas Kling.

  • wtf/HashMap.h:
  • wtf/HashSet.h:
  • wtf/HashTable.h:
6:41 PM Changeset in webkit [155584] by vivek.vg@samsung.com
  • 5 edits
    2 adds in trunk

DOMParser.parseFromString() should support creating HTML Document with mime-type text/html
​https://bugs.webkit.org/show_bug.cgi?id=120826

Reviewed by Darin Adler.

Source/WebCore:

The specification ​http://domparsing.spec.whatwg.org/#the-domparser-interface for DOMParser.parseFromString()
allows the document creation if the mimeType is one of the supported types:
["text/html", "text/xml", "application/xml", "application/xhtml+xml", "image/svg+xml"]

Also script elements get marked unexecutable and the contents of noscript get parsed as markup.

blink review URL: ​https://codereview.chromium.org/23903014/

Test: fast/dom/domparser-parsefromstring-mimetype-support.html

  • xml/DOMParser.cpp:

(WebCore::DOMParser::parseFromString):

LayoutTests:

  • fast/dom/domparser-parsefromstring-mimetype-support-expected.txt: Added.
  • fast/dom/domparser-parsefromstring-mimetype-support.html: Added.
6:21 PM Changeset in webkit [155583] by hmuller@adobe.com
  • 5 edits in trunk/Source/WebCore

[CSS Shapes] Improve the performance of image valued shapes
​https://bugs.webkit.org/show_bug.cgi?id=120211

Reviewed by Alexandru Chiculita.

Replaced the implementation of RasterShapeIntervals with one based on the
new ShapeInterval<int> class. This eliminates the dependency the Region class
and delivers a 10X layout speedup for large image valued shapes.

This a just an implementation refactoring, no new tests were needed.

  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShapeIntervals::appendInterval): Renamed this method, it was called addInterval().
(WebCore::shapeIntervalsContain):
(WebCore::RasterShapeIntervals::contains):
(WebCore::RasterShapeIntervals::getIntervalsInLine):
(WebCore::compareX1):
(WebCore::RasterShapeIntervals::firstIncludedIntervalY):
(WebCore::RasterShapeIntervals::getIncludedIntervals):
(WebCore::RasterShapeIntervals::getExcludedIntervals):
(WebCore::RasterShape::getExcludedIntervals):
(WebCore::RasterShape::getIncludedIntervals):

  • rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::RasterShapeIntervals): The constructor now takes a size argument which is used to allocate IntShapeIntervals storage.
(WebCore::RasterShapeIntervals::size):
(WebCore::RasterShapeIntervals::bounds):
(WebCore::RasterShapeIntervals::isEmpty):
(WebCore::RasterShapeIntervals::getIntervals):

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Use appendInterval() instead of addInterval() (see above) and the new RasterShapeIntervals constructor.

5:51 PM Changeset in webkit [155582] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Make sure that layout is up-to-date when moving a WKView into a window, to avoid !needsLayout() assertions in RenderView::paint()
​https://bugs.webkit.org/show_bug.cgi?id=121196

Reviewed by Tim Horton.

When a WKView was moved into a window, it was possible for us to paint
without ensuring that layout is up-to-date. Fix this by having
WebPage::setIsInWindow() update layout if we are moving to a window.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setIsInWindow):

5:40 PM Changeset in webkit [155581] by Brent Fulgham
  • 3 edits in trunk/Tools

[Windows] Build fix for MoveOnly

  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add

Tests to include search path.

  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:

Ditto.

5:30 PM Changeset in webkit [155580] by andersca@apple.com
  • 5 edits in trunk

Add HashSet::take
​https://bugs.webkit.org/show_bug.cgi?id=121192

Reviewed by Darin Adler.

Source/WTF:

This is mostly done to see if we can use the new C++11 function declaration syntax,
and for parity with HashMap::take.

  • wtf/HashMap.h:
  • wtf/HashSet.h:

Tools:

Add a test for HashSet::take.

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

4:46 PM Changeset in webkit [155579] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebCore

[MediaStream API] Updating NavigatorUserMediaError to match the spec
​https://bugs.webkit.org/show_bug.cgi?id=120880

Reviewed by Darin Adler.

Merge ​https://chromium.googlesource.com/chromium/blink/+/f07305e49ddebaa166f5dee514bcc881a8efd341
by Tommy Widenflycht.

The Blink change did not have any test changes because they don't appear to have any tests
for NavigatorUserMediaError. I can't add tests now because the MediaStream feature isn't enabled
yet, so ​https://bugs.webkit.org/show_bug.cgi?id=121182 tracks adding tests.

  • Modules/mediastream/NavigatorUserMediaError.h:

(WebCore::NavigatorUserMediaError::create):
(WebCore::NavigatorUserMediaError::name):
(WebCore::NavigatorUserMediaError::message):
(WebCore::NavigatorUserMediaError::constraintName):
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):

  • Modules/mediastream/NavigatorUserMediaError.idl:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::fail):
(WebCore::UserMediaRequest::failConstraint):

  • Modules/mediastream/UserMediaRequest.h:
4:46 PM Changeset in webkit [155578] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove needsDataFormatConversion because it is unused.

Rubber stamped by Mark Hahnenberg.

  • bytecode/DataFormat.h:
4:36 PM Changeset in webkit [155577] by andersca@apple.com
  • 7 edits
    1 add in trunk

HashSet should work with move only types
​https://bugs.webkit.org/show_bug.cgi?id=121188

Reviewed by Geoffrey Garen.

Source/WTF:

  • wtf/HashSet.h:

(WTF::HashSet::add):
Add a new rvalue reference overload and use std::move when calling HashTable::add.

  • wtf/HashTable.h:

(WTF::IdentityHashTranslator::translate):
Change this to take an rvalue reference for the value so we can invoke the move assignment operator.

(WTF::HashTable::add):
Call the add member function template, using std::move to move the value.

(WTF::HashTable::add):
Add std::forward so we'll potentially move extra.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/MoveOnly.h: Added.

Move the MoveOnly class from Vector out into its own header.

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):
Add aHashSet<MoveOnly> test.

  • TestWebKitAPI/Tests/WTF/Vector.cpp:

Include MoveOnly.h.

4:34 PM Changeset in webkit [155576] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rename fillSpeculateInt to fillSpeculateInt32.

Rubber stamped by Mark Hahnenberg.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculateInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Strict):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32):
(JSC::DFG::SpeculativeJIT::fillSpecualteInt32Strict):

4:28 PM Changeset in webkit [155575] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Rename DataFormatInteger to DataFormatInt32.

Rubber stamped by Mark Hahnenberg.

  • bytecode/DataFormat.h:

(JSC::dataFormatToString):
(JSC::needDataFormatConversion):
(JSC::isJSInt32):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::isJSInt32):
(JSC::DFG::GenerationInfo::fillInteger):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::IntegerOperand::format):
(JSC::DFG::SpeculateInt32Operand::format):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValueSource.h:

(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):

3:58 PM Changeset in webkit [155574] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Flaky Test: http/tests/inspector/inspect-element.html
​https://bugs.webkit.org/show_bug.cgi?id=78869

Reviewed by Alexey Proskuryakov.

Add a check to fix flakiness when multiple inspector tests run. The
issue is with the old frontend, and does not affect the new frontend.

  • http/tests/inspector/inspect-element.html:
3:32 PM Changeset in webkit [155573] by commit-queue@webkit.org
  • 20 edits
    5 deletes in trunk

MediaStream API: Remove LocalMediaStream
​https://bugs.webkit.org/show_bug.cgi?id=120875

blink merge: ​https://chromium.googlesource.com/chromium/blink/+/81643ee3fe048a64fa8931132e1294fa2c8e821a

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-09-11
Reviewed by Eric Carlson.

Source/WebCore:

Existing tests were updated.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Modules/mediastream/LocalMediaStream.cpp: Removed.
  • Modules/mediastream/LocalMediaStream.h: Removed.
  • Modules/mediastream/LocalMediaStream.idl: Removed.
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::stop):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/NavigatorUserMediaSuccessCallback.h:
  • Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::succeed):

  • Modules/mediastream/UserMediaRequest.h:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventTarget.h:
  • dom/EventTargetFactory.in:
  • platform/mediastream/MediaStreamDescriptor.h:

LayoutTests:

  • fast/mediastream/LocalMediaStream-onended-expected.txt: Removed.
  • fast/mediastream/LocalMediaStream-onended.html: Removed.
  • fast/mediastream/MediaStream-onended-expected.txt:
  • fast/mediastream/MediaStream-onended.html:
3:31 PM Changeset in webkit [155572] by timothy@apple.com
  • 16 edits
    2 deletes in trunk/Source/WebCore

Remove PlatformInstrumentation since we don't show decode or resize in the new Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=121181

Reviewed by Joseph Pecoraro.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::clearRecordStack):

  • inspector/InspectorTimelineAgent.h:
  • platform/PlatformInstrumentation.cpp: Removed.
  • platform/PlatformInstrumentation.h: Removed.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::frameBufferAtIndex):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::frameBufferAtIndex):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::frameBufferAtIndex):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::frameBufferAtIndex):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::frameBufferAtIndex):

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::frameBufferAtIndex):

3:27 PM Changeset in webkit [155571] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Avoid copying a hash table bucket when inserting causes a rehash
​https://bugs.webkit.org/show_bug.cgi?id=121185

Reviewed by Darin Adler.

Allow rehashing to track a hash bucket and return the new pointer to it, thus avoiding
having to do a copy of a hash table bucket as well as an extra hash lookup.

  • wtf/HashTable.h:
3:17 PM Changeset in webkit [155570] by Brent Fulgham
  • 13 edits in trunk

Source/WebCore: [Windows] Avoid converting from IntSize->SIZE->IntSize.
​https://bugs.webkit.org/show_bug.cgi?id=121180

Reviewed by Anders Carlsson.

  • platform/graphics/BitmapImage.h: Take const IntSize* as

argument, rather than LPSIZE.

  • platform/graphics/Image.h: Ditto.

(WebCore::Image::getHBITMAPOfSize):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize): Use passed-in
IntSize, rather than converting from SIZE.

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize): Ditto.

Source/WebKit: [Windows] Avoid converting from IntSize->SIZE->IntSize
​https://bugs.webkit.org/show_bug.cgi?id=121180

Reviewed by Anders Carlsson.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Remove unused symbol export.

Source/WebKit/win: [Windows] Avoid converting from IntSize->SIZE->IntSize
​https://bugs.webkit.org/show_bug.cgi?id=121180

Reviewed by Anders Carlsson.

  • WebIconDatabase.cpp:

(WebIconDatabase::iconForURL): Guard against null SIZE argument.
This was dereferenced with checking before! Use IntSize arguments.
(WebIconDatabase::defaultIconWithSize): Used passed-in IntSize.
(createDIB): Take an IntSize argument.
(WebIconDatabase::getOrCreateSharedBitmap): Take IntSize argument.
(WebIconDatabase::getOrCreateDefaultIconBitmap): Ditto.

  • WebIconDatabase.h: Update for IntSize arguments.
  • WebView.cpp:

(WebView::dispatchDidReceiveIconFromWebFrame): Pass address of
IntSize directly, rather than casting to SIZE first.

Tools: [Windows] Avoid converting from IntSize->SIZE->IntSize
​https://bugs.webkit.org/show_bug.cgi?id=121180

Reviewed by Anders Carlsson.

  • TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:

(TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.

3:08 PM Changeset in webkit [155569] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed debug build fix after r155567.

  • rendering/LineWidth.cpp:

(WebCore::LineWidth::LineWidth):

3:07 PM Changeset in webkit [155568] by mitz@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r155561): extract-localizable-strings can miss strings
​https://bugs.webkit.org/show_bug.cgi?id=121184

Reviewed by Darin Adler.

  • Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing

parenthesis or bracket.

2:49 PM Changeset in webkit [155567] by fpizlo@apple.com
  • 6 edits in trunk

Int32ToDouble should be predicted SpecInt48 and predictions should have nothing to do with constant folding
​https://bugs.webkit.org/show_bug.cgi?id=121141

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Just changing Int32ToDouble to be predicted SpecInt48 breaks constant folding on that
node because of soooper old code that prevented constant folding on mismatched
predictions. Kill that code.

  • dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::setConstant):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

LayoutTests:

Reviewed by Oliver Hunt.

Fixing this means that this test no longer recompiles.

  • js/script-tests/dfg-constant-fold-misprediction.js:
2:40 PM Changeset in webkit [155566] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Windows] Unreviewed build fix.

  • wtf/win/GDIObject.h:

(WTF::GDIObject::GDIObject): I forgot to check in as part of
r155557 by using webkit-patch land in a sub-directory!

2:29 PM Changeset in webkit [155565] by zoltan@webkit.org
  • 7 edits
    2 adds in trunk/Source/WebCore

Move LineWidth out of RenderBlockLineLayout
​https://bugs.webkit.org/show_bug.cgi?id=121107

Reviewed by David Hyatt.

Move LineWidth class and related code into LineWidth.{h,cpp}.

No new tests, no behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/LineWidth.cpp: Added.

(WebCore::LineWidth::applyOverhang):
(WebCore::LineWidth::fitBelowFloats):

  • rendering/LineWidth.h: Added.

(WebCore::logicalHeightForLine):
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::uncommittedWidth):
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::LineWidth::shouldIndentText):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/RenderBlockLineLayout.cpp:
2:24 PM Changeset in webkit [155564] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

VariableAccessData::flushFormat() should be the universal way of deciding how to speculate on stores to locals and how locals are formatted
​https://bugs.webkit.org/show_bug.cgi?id=121142

Reviewed by Geoffrey Garen.

Make everyone rely on VariableAccessData::flushFormat() instead of trying to
compute that information from scratch. The FTL already used flushFormat(), now
the DFG does, too.

  • dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::someVariable):
(JSC::DFG::ArgumentPosition::flushFormat):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::forFlushFormat):

  • dfg/DFGVariableAccessDataDump.cpp:

(JSC::DFG::VariableAccessDataDump::dump):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileSetLocal):

2:22 PM Changeset in webkit [155563] by oliver@apple.com
  • 5 edits in trunk/Source

Partial Information Leakage in Hash Table implementations (PrivateName)
​https://bugs.webkit.org/show_bug.cgi?id=120663

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Undo change to the PropertyTable in my last patch, instead lets just
use a random value as the initial hash for unique strings.

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):
(JSC::PropertyTable::rehash):

Source/WTF:

Unique strings now just generate a completely random value as their
hash, rather than using their this pointer.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):

2:19 PM Changeset in webkit [155562] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

Unreviewed build correction.

  • WTF.vcxproj/copy-files.cmd: Touch file to force WTFGenerated

build to copy updated GDIObject.h header file on build machines.

2:02 PM Changeset in webkit [155561] by mitz@apple.com
  • 2 edits in trunk/Tools

update-webkit-localizable-strings is at least 5.8x slower than it should be
​https://bugs.webkit.org/show_bug.cgi?id=121178

Reviewed by Darin Adler.

  • Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.

Note that this does not change functionality, because the script already does not understand
the line continuation sequence (backslash followed by a newline).

1:56 PM Changeset in webkit [155560] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Partial Information Leakage in Hash Table implementations (PrivateName)
​https://bugs.webkit.org/show_bug.cgi?id=120663

Reviewed by Michael Saboff.

These hashtables mix keys that are hashed on pointers or user controlled
data. To prevent any potential information leak we mask the keys with
a per table entropy value.

  • runtime/MapData.cpp:

(JSC::MapData::MapData):
(JSC::MapData::find):
(JSC::MapData::add):
(JSC::MapData::remove):

  • runtime/MapData.h:
  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::findWithString):
(JSC::PropertyTable::rehash):

  • runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

1:47 PM Changeset in webkit [155559] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

HTMLEntityTable could use char to reduce binary size
​https://bugs.webkit.org/show_bug.cgi?id=121176

Reviewed by Anders Carlsson.

Use LChar instead.

  • html/parser/HTMLEntityParser.cpp:

(WebCore::HTMLEntityParser::consumeNamedEntity):

  • html/parser/HTMLEntityTable.h:

(WebCore::HTMLEntityTableEntry::lastCharacter):

  • html/parser/create-html-entity-table:
1:34 PM Changeset in webkit [155558] by commit-queue@webkit.org
  • 16 edits in trunk/Source/JavaScriptCore

MapData and WeakMapData don't need to be objects
​https://bugs.webkit.org/show_bug.cgi?id=121167

Patch by Sam Weinig <​sam@webkit.org> on 2013-09-11
Reviewed by Geoffrey Garen.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::mapStructure):
Remove MapData and WeakMapData structures (they moved to VM with other non-object Structures).

  • runtime/JSMap.cpp:

(JSC::JSMap::finishCreation):

  • runtime/JSMap.h:

(JSC::JSMap::create):

  • runtime/JSSet.cpp:

(JSC::JSSet::finishCreation):

  • runtime/JSSet.h:

(JSC::JSSet::create):

  • runtime/JSWeakMap.cpp:

(JSC::JSWeakMap::finishCreation):

  • runtime/JSWeakMap.h:

(JSC::JSWeakMap::create):
Update to not pass a global object to the MapData or WeakMapData Structure.

  • runtime/MapData.cpp:

(JSC::MapData::MapData):

  • runtime/MapData.h:

(JSC::MapData::create):
(JSC::MapData::createStructure):

  • runtime/WeakMapData.cpp:

(JSC::WeakMapData::WeakMapData):
(JSC::WeakMapData::set): Change to take a VM rather than a CallFrame, as that it all it needs.

  • runtime/WeakMapData.h:

(JSC::WeakMapData::create):
(JSC::WeakMapData::createStructure):
Instead of inheriting from JSDestructibleObject, inherit from JSCell and mark self as needing destruction
and having an immortal structure.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Add MapData and WeakMapData Structures.

  • runtime/WeakMapPrototype.cpp:

(JSC::protoFuncWeakMapSet):
Pass a VM rather than an ExecState.

1:27 PM Changeset in webkit [155557] by Brent Fulgham
  • 15 edits in trunk/Source/WebCore

[Windows] Revise GDI Create Functions to use GDIObject Smart Pointer.
​https://bugs.webkit.org/show_bug.cgi?id=121100

Reviewed by Anders Carlsson.

  • platform/graphics/FontPlatformData.h: Use GDIObject instead of bare pointer.
  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::createGDIFont): No longer need to leak the pointer; use move semantic
to pass ownership to FontPlatformData.
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Use move operation.

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Ditto.

  • platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Ditto.

  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Ditto.

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData): Ditto.

  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:

(WebCore::GlyphPage::fill): Use HWndDC smart pointer instead of bare HDC.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Use move operation.

  • platform/win/DragImageCGWin.cpp:

(WebCore::allocImage): Change to use GDIObject.
(WebCore::scaleDragImage): Use smart pointers to avoid manual deallocs.
(WebCore::createDragImageFromImage): Ditto.

  • platform/win/DragImageCairoWin.cpp:

(WebCore::allocImage): Change to use GDIObject.
(WebCore::scaleDragImage): Use smart pointers to avoid manual deallocs.
(WebCore::createDragImageFromImage): Ditto.

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageForLink): Update for GDIObject.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::PopupMenuWin): Switch to GDIObject.
(WebCore::PopupMenuWin::~PopupMenuWin): Remove uneeded deallocs.
(WebCore::PopupMenuWin::paint): Update for GDIObject.

  • platform/win/PopupMenuWin.h: Use smart pointers instead of bare GDI objects.
1:18 PM Changeset in webkit [155556] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Fix animations with !USE(ACCELERATED_COMPOSITING) after r147792.
​https://bugs.webkit.org/show_bug.cgi?id=121159

Reviewed by Simon Fraser.

CSSPropertyAnimation::blendProperties() is available always
and needs to be called to make the animations work.

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::animate):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate):

12:50 PM Changeset in webkit [155555] by hyatt@apple.com
  • 7 edits in trunk/Source/WebCore

Move all collapsing margin code out of RenderBlock and into RenderBlockFlow.
​https://bugs.webkit.org/show_bug.cgi?id=121049

Reviewed by Dean Jackson.

This patch begins the migration of the rare data struct of RenderBlock into
RenderBlockFlow. During this process we will temporarily have rare data structs
in both places, but ultimately all of the members are going to move down into
RenderBlockFlow, and if any don't, they will get forced into a hash.

For this patch, the margin information is being shifted out of RenderBlock and into
RenderBlockFlow. Any functions that refer to MarginValues or to MarginInfo also got
moved down into RenderBlockFlow. Most of block child layout is now in RenderBlockFlow
after this patch.

Note that in many cases the code didn't simply move. There is some type tightening
that happened as well, i.e., places that look for RenderBlock can now look for
RenderBlockFlow instead and let RenderBlock execute the base RenderBox functions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageLogicalOffset):
(WebCore::RenderBlock::setBreakAtLineToAvoidWidow):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::setLineGridBox):
(WebCore::RenderBlock::setShapeInsideInfo):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::MarginInfo::MarginInfo):
(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustPositionedBlock):
(WebCore::RenderBlockFlow::adjustFloatingBlock):
(WebCore::RenderBlockFlow::marginValuesForChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
(WebCore::RenderBlockFlow::estimateLogicalTopPosition):
(WebCore::RenderBlockFlow::setCollapsedBottomMargin):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::RenderBlockFlow::setMaxMarginBeforeValues):
(WebCore::RenderBlockFlow::setMaxMarginAfterValues):
(WebCore::RenderBlockFlow::setMustDiscardMarginBefore):
(WebCore::RenderBlockFlow::setMustDiscardMarginAfter):
(WebCore::RenderBlockFlow::mustDiscardMarginBefore):
(WebCore::RenderBlockFlow::mustDiscardMarginAfter):
(WebCore::RenderBlockFlow::mustDiscardMarginBeforeForChild):
(WebCore::RenderBlockFlow::mustDiscardMarginAfterForChild):
(WebCore::RenderBlockFlow::mustSeparateMarginBeforeForChild):
(WebCore::RenderBlockFlow::mustSeparateMarginAfterForChild):
(WebCore::inNormalFlow):
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::MarginValues::MarginValues):
(WebCore::RenderBlockFlow::MarginValues::positiveMarginBefore):
(WebCore::RenderBlockFlow::MarginValues::negativeMarginBefore):
(WebCore::RenderBlockFlow::MarginValues::positiveMarginAfter):
(WebCore::RenderBlockFlow::MarginValues::negativeMarginAfter):
(WebCore::RenderBlockFlow::MarginValues::setPositiveMarginBefore):
(WebCore::RenderBlockFlow::MarginValues::setNegativeMarginBefore):
(WebCore::RenderBlockFlow::MarginValues::setPositiveMarginAfter):
(WebCore::RenderBlockFlow::MarginValues::setNegativeMarginAfter):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::positiveMarginAfterDefault):
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::negativeMarginAfterDefault):
(WebCore::RenderBlockFlow::MarginInfo::setAtBeforeSideOfBlock):
(WebCore::RenderBlockFlow::MarginInfo::setAtAfterSideOfBlock):
(WebCore::RenderBlockFlow::MarginInfo::clearMargin):
(WebCore::RenderBlockFlow::MarginInfo::setHasMarginBeforeQuirk):
(WebCore::RenderBlockFlow::MarginInfo::setHasMarginAfterQuirk):
(WebCore::RenderBlockFlow::MarginInfo::setDeterminedMarginBeforeQuirk):
(WebCore::RenderBlockFlow::MarginInfo::setPositiveMargin):
(WebCore::RenderBlockFlow::MarginInfo::setNegativeMargin):
(WebCore::RenderBlockFlow::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlockFlow::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlockFlow::MarginInfo::setMargin):
(WebCore::RenderBlockFlow::MarginInfo::setCanCollapseMarginAfterWithChildren):
(WebCore::RenderBlockFlow::MarginInfo::setDiscardMargin):
(WebCore::RenderBlockFlow::MarginInfo::atBeforeSideOfBlock):
(WebCore::RenderBlockFlow::MarginInfo::canCollapseWithMarginBefore):
(WebCore::RenderBlockFlow::MarginInfo::canCollapseWithMarginAfter):
(WebCore::RenderBlockFlow::MarginInfo::canCollapseMarginBeforeWithChildren):
(WebCore::RenderBlockFlow::MarginInfo::canCollapseMarginAfterWithChildren):
(WebCore::RenderBlockFlow::MarginInfo::quirkContainer):
(WebCore::RenderBlockFlow::MarginInfo::determinedMarginBeforeQuirk):
(WebCore::RenderBlockFlow::MarginInfo::hasMarginBeforeQuirk):
(WebCore::RenderBlockFlow::MarginInfo::hasMarginAfterQuirk):
(WebCore::RenderBlockFlow::MarginInfo::positiveMargin):
(WebCore::RenderBlockFlow::MarginInfo::negativeMargin):
(WebCore::RenderBlockFlow::MarginInfo::discardMargin):
(WebCore::RenderBlockFlow::MarginInfo::margin):
(WebCore::RenderBlockFlow::maxPositiveMarginBefore):
(WebCore::RenderBlockFlow::maxNegativeMarginBefore):
(WebCore::RenderBlockFlow::maxPositiveMarginAfter):
(WebCore::RenderBlockFlow::maxNegativeMarginAfter):
(WebCore::RenderBlockFlow::initMaxMarginValues):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

12:23 PM Changeset in webkit [155554] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Fix nested unicode-bidi: isolate
​https://bugs.webkit.org/show_bug.cgi?id=120504

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-09-11
Reviewed by Darin Adler.

Source/WebCore:

When we have a nested isolate renderer if the outer isolate has a text
and this text is not the first child, the isolated chain is not
rendered correctly. This happens because constructBidiRunsForSegment
uses always the first inner isolated renderer as isolated inline
container. This patch fixes the behavior described changing
containingIsolate to find the right isolated container.

Merged from Blink: ​https://chromium.googlesource.com/chromium/blink/+/840a57050eade39dd04dde0c6603e129b783151c

Tests: fast/text/international/unicode-bidi-isolate-nested-first-child-text.html

fast/text/international/unicode-bidi-isolate-nested-simple.html

  • rendering/InlineIterator.h:

(WebCore::containingIsolate):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForSegment):

LayoutTests:

  • fast/text/international/unicode-bidi-isolate-nested-first-child-text-expected.html: Added.
  • fast/text/international/unicode-bidi-isolate-nested-first-child-text.html: Added.
  • fast/text/international/unicode-bidi-isolate-nested-simple-expected.html: Added.
  • fast/text/international/unicode-bidi-isolate-nested-simple.html: Added.
12:18 PM Changeset in webkit [155553] by ap@apple.com
  • 4 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=121169
media/track/track-cue-rendering-vertical.html is flaky on Mac

Reviewed by Eric Carlson.

Source/WebCore:

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Added a FIXME.

LayoutTests:

  • media/media-reparent.html: Changed to use setTimeout directly.
  • media/video-test.js:

(endTest): Added a zero delay timer to let text track layout do its work.

12:17 PM Changeset in webkit [155552] by andersca@apple.com
  • 2 edits in trunk/Source

Source/WebCore: Stop using deleteAllValues in SVG code
​https://bugs.webkit.org/show_bug.cgi?id=121172

Reviewed by Antti Koivisto.

Use OwnPtr for values instead.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
(WebCore::RenderSVGResourceClipper::removeClientFromCache):
(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::removeAllClientsFromCache):
(WebCore::RenderSVGResourceMasker::removeClientFromCache):
(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/RenderSVGResourceMasker.h:

Source/WTF: Vector::append doesn't work if element type has overloaded operator&
​https://bugs.webkit.org/show_bug.cgi?id=121175

Reviewed by Brent Fulgham.

Use std::addressof to get the address of the given object.

  • wtf/Vector.h:

(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):

12:08 PM Changeset in webkit [155551] by andersca@apple.com
  • 4 edits in trunk

Vector::append doesn't work if element type has overloaded operator&
​https://bugs.webkit.org/show_bug.cgi?id=121175

Reviewed by Brent Fulgham.

Source/WTF:

Use std::addressof to get the address of the given object.

  • wtf/Vector.h:

(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):

Tools:

Add a test case.

  • TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

12:02 PM Changeset in webkit [155550] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Make the table static const.

  • css/makeprop.pl:
11:59 AM Changeset in webkit [155549] by timothy@apple.com
  • 13 edits
    2 deletes in trunk/Source/WebCore

Remove TimelineTraceEventProcessor since no current ports use it
​https://bugs.webkit.org/show_bug.cgi?id=121171

Reviewed by Joseph Pecoraro.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorClient.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineTraceEventProcessor.cpp: Removed.
  • inspector/TimelineTraceEventProcessor.h: Removed.
11:53 AM Changeset in webkit [155548] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r155519.
​http://trac.webkit.org/changeset/155519
​https://bugs.webkit.org/show_bug.cgi?id=121174

Included regression test fails, and an existing test started
to crash (Requested by ap on #webkit).

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::hoveredElementDidDetach):

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::scheduleHoverStateUpdate):
(WebCore::EventHandler::hoverTimerFired):

  • page/EventHandler.h:

LayoutTests:

  • fast/events/mouseenterleave-detached-element-expected.txt: Removed.
  • fast/events/mouseenterleave-detached-element.html: Removed.
11:39 AM Changeset in webkit [155547] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Stop using deleteAllValues in SVG code
​https://bugs.webkit.org/show_bug.cgi?id=121172

Reviewed by Antti Koivisto.

Use OwnPtr for values instead.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
(WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
(WebCore::RenderSVGResourceClipper::removeClientFromCache):
(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
(WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
(WebCore::RenderSVGResourceMasker::removeAllClientsFromCache):
(WebCore::RenderSVGResourceMasker::removeClientFromCache):
(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/svg/RenderSVGResourceMasker.h:
11:33 AM Changeset in webkit [155546] by Simon Fraser
  • 3 edits
    4 adds in trunk

REGRESSION (143483): overflow:hidden doesn't quash big repaints from text-indent: -9999px
​https://bugs.webkit.org/show_bug.cgi?id=121137

Source/WebCore:

Reviewed by Ryosuke Niwa.

The change in r143483 made it so that negative text-indent gets added
to visual oveflow even when we have overflow:hidden, which is really bad
because it causes large repaints (and large layers) for a common-on-the-web
pattern.

Revert the change, and add a new test to make sure it doesn't regress.

I can't reproduce the bug it was trying to fix with the change reverted.

Tests: compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html

fast/repaint/negative-text-indent-with-overflow-hidden.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

LayoutTests:

Reviewed by Ryosuke Niwa.

Text-based repaint test, and test for compositing layer geometry.

  • compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added.
  • compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html: Added.
  • fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: Added.
  • fast/repaint/negative-text-indent-with-overflow-hidden.html: Added.
11:33 AM Changeset in webkit [155545] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Optionally show visual and layout overflow rects in layer tree dumps
​https://bugs.webkit.org/show_bug.cgi?id=121135

Reviewed by Beth Dakin.

When calling showLayerTree() from the debugger, show overflow rects
(visaul and layout) for renderers.

Does not affect test output.

  • rendering/RenderLayer.cpp:

(showLayerTree): Pass the new flag to show overflow rects.

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject): Print the rects.
(WebCore::write): Don't force layout on subframes if the "dont' layout"
flag is set.

  • rendering/RenderTreeAsText.h: New flag.
11:30 AM Changeset in webkit [155544] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Windows] Unreviewed build correction after r155507.

  • WebCoreSupport/WebChromeClient.cpp: Add missing header include

to define isHTMLVideoElement.

11:25 AM Changeset in webkit [155543] by Chris Fleizach
  • 10 edits
    2 adds
    2 deletes in trunk

AX: WebKit exposes AXTitleUIElement incorrectly on checkboxes and radio buttons
​https://bugs.webkit.org/show_bug.cgi?id=121039

Reviewed by Sam Weinig.

Source/WebCore:

Stop hiding <label> elements for radio buttons and checkboxes (and using the text inside them for the AXTitle).
Instead, expose the <label> element as the titleUIElement if appropriate for the input.

This implies:

1) The web will no longer match MacOS behavior exactly (the text and the checkbox control are combined on MacOS into one element)
2) But, the user will now be able to explore the <label> element which may include links or other important controls.

I think sacrificing 1) here is a good tradeoff. The user will likely never know the difference in terms of output.

Test: platform/mac/accessibility/label-elements-exposed-as-title-ui-elements.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::title):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hasTextAlternative):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):

LayoutTests:

  • accessibility/label-for-control-hittest-expected.txt: Removed.
  • accessibility/label-for-control-hittest.html: Removed.

We no longer need this test since we are not combining label + control into one element anymore.

  • accessibility/radio-button-group-members.html:

Rewrite this test to be more modern (don't just dump attributes).
Instead test for what we want to know (whether radio button group members can identify their siblings)

  • accessibility/radio-button-title-label-expected.txt:
  • accessibility/radio-button-title-label.html:

Rewrite this test so that it understands that controls won't hide their <label> elements.

  • platform/mac/accessibility/label-element-with-hidden-control-expected.txt:
  • platform/mac/accessibility/label-element-with-hidden-control.html:

Update test to reflect that title UI elements are exposed for some controls.

  • platform/mac/accessibility/label-elements-exposed-as-title-ui-elements-expected.txt: Added.
  • platform/mac/accessibility/label-elements-exposed-as-title-ui-elements.html: Added.

New test to explicitly confirm that <label> is exposed as a title UI element.

  • platform/mac/accessibility/radio-button-group-members-expected.txt:
11:07 AM Changeset in webkit [155542] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

VectorBuffer::swap doesn't need to use std::swap_ranges
​https://bugs.webkit.org/show_bug.cgi?id=121164

Reviewed by Darin Adler.

There's a std::swap overload for swapping arrays, just use it instead.

  • wtf/Vector.h:

(WTF::VectorBuffer::swap):

10:57 AM Changeset in webkit [155541] by andersca@apple.com
  • 4 edits in trunk

Implement Vector::append for move-only types
​https://bugs.webkit.org/show_bug.cgi?id=120805

Source/WTF:

Reviewed by Andreas Kling.

  • wtf/Vector.h:

(WTF::::expandCapacity):
Remove const from the pointer passed to expandCapacity, it can be non-const if we're moving.

(WTF::::append):
Change append to take U&& and use std::forward when constructing the element and when passing
the element along to appendSlowCase if that's necessary.

(WTF::::appendSlowCase):
Use std::forward.

(WTF::::uncheckedAppend):
Rename val to value.

Tools:

Reviewed by Sam Weinig.

Add a test for Vector<MoveOnly>::append.

  • TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

10:43 AM Changeset in webkit [155540] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Remove unnecessary Document::frame() null checks in rendererIsNeeded().
<​https://webkit.org/b/121166>

Reviewed by Anders Carlsson.

rendererIsNeeded() is only called during style resolve, which only happens
while there's a Frame present.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::rendererIsNeeded):

  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
10:38 AM Changeset in webkit [155539] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

ARM buildfix after r155491
​https://bugs.webkit.org/show_bug.cgi?id=121152

Reviewed by Anders Carlsson.

FELightingNEON.cpp and FELightingNEON.h is inside COMPILER(GCC) guard, so it's safe to use GCC attribute.

  • platform/graphics/cpu/arm/filters/FELightingNEON.cpp: Use aligned GCC attribute directly.
  • platform/graphics/cpu/arm/filters/FELightingNEON.h: Use aligned GCC attribute instead of ugly template magic.

(WebCore::FELighting::platformApplyNeon):

10:28 AM Changeset in webkit [155538] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed. Fix the indentation after r105848. Typo fix after r155523.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start):
(RunAndUploadPerfTests.getText2):

9:50 AM Changeset in webkit [155537] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCairo] Compile errors.
​https://bugs.webkit.org/show_bug.cgi?id=121153

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-09-11
Reviewed by Brent Fulgham.

  • page/win/FrameCairoWin.cpp:

(WebCore::imageFromRect): Return empty GDIObject.

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Get actual handle from GDIObject.

9:48 AM Changeset in webkit [155536] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Rework CSS parser, eliminating "floating" concept and using %destructor
​https://bugs.webkit.org/show_bug.cgi?id=121161

Reviewed by Antti Koivisto.

This is some basic improvement, but there is still room for a lot more
consistent approach and formatting in this file. There is a mix of code that
works by side effects in the CSSParser class and code that works with the
values that bison generates in the union that is more or less random. And
the data structures seem too costly, with too much heap allocation. And the
CSSParser class has grown massive, with a mix of both function for use by
code that wants to trigger parsing, and helper functions called by code in
the grammar file. All of that can benefit from more refinement in the future.

  • css/CSSGrammar.y.in: Made some incremental improvements to the structure

of the grammar file, including:

  • Breaking up the %union so types are declared next to their use
  • Eliminating one shift/reduce conflict caused by two "maybe_space" in a row
  • Breaking the conditional sections out into their own sections instead of scattering them in with the other code.
  • Eliminating unused return values in productions such as charset, ignored_charset, namespace, margin_box, invalid_rule, save_block, invalid_at, and declarations_and_margins.
  • Adding %destructor to productions that return values that need to be deleted or deref'd. This removes the need for CSSParser to separately track these as "floating" to clean up in case of errors.
  • Removing unneeded productions such as media_feature, region_selector, attr_name, and medium.
  • Removing explicit code blocks that just say "$$ = $1" or empty blocks when there is no return type, since those are default.
  • Formatting many productions on single lines since I find them easier to read. Later I think we could make many more CSSParser functions and make even more of the production single lines in the grammar file.
  • Using adoptPtr, adoptRef, delete, deref, leakPtr, and leakRef to put heap allocated values into and out of the union without storage leaks.
  • css/CSSParser.cpp:

(WebCore::CSSParser::~CSSParser): Remove the now-unneeded deleteAllValues for
the various colections of floating things.
(WebCore::CSSParser::createFilterRule): Don't put the rule into m_parsedRules,
just return a PassRefPtr instead.
(WebCore::CSSParser::createImportRule): Ditto.
(WebCore::CSSParser::createMediaRule): Ditto.
(WebCore::CSSParser::createEmptyMediaRule): Ditto.
(WebCore::CSSParser::createSupportsRule): Ditto.
(WebCore::CSSParser::createKeyframesRule): Ditto.
(WebCore::CSSParser::createStyleRule): Ditto.
(WebCore::CSSParser::createFontFaceRule): Ditto.
(WebCore::CSSParser::createHostRule): Ditto.
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded): Got rid of the
unused return value from this function and changed it to to take a reference
instead of a pointer.
(WebCore::CSSParser::rewriteSpecifiersWithElementName): Ditto.
(WebCore::CSSParser::rewriteSpecifiers): Changed this to take and return OwnPtr.
(WebCore::CSSParser::createPageRule): Don't put rule into m_parsedRules, return
PassRefPtr instead.
(WebCore::CSSParser::createSelectorVector): Added. Used to implement the
optimization where we recycle a single selector vector. Not sure we still need
this, or maybe we need more optimizations like it, but for now keep it.
(WebCore::CSSParser::recycleSelectorVector): Ditto.
(WebCore::CSSParser::createRegionRule): Don't put rule into m_parsedRules, return
PassRefPtr instead.
(WebCore::CSSParser::createMarginAtRule): Got rid of unused return value.
When this function is implemented for real, we might add a return value.
(WebCore::CSSParser::createKeyframe): Don't put keyframe into m_parsedKeyframes,
return PassRefPtr instead.
(WebCore::CSSParser::createViewportRule): Don't put rule into m_parsedRules, return
PassRefPtr instead.

  • css/CSSParser.h: Removed many now-needed functions to manage floating items.

Changed rule creation functions to return PassRefPtr. Other changes as mentioned above.

  • css/CSSParserValues.cpp:

(WebCore::destroy): Added.
(WebCore::CSSParserValueList::~CSSParserValueList): Updated to call destroy.

  • css/CSSParserValues.h: Ditto.
9:43 AM Changeset in webkit [155535] by andersca@apple.com
  • 3 edits in trunk/Tools

The style checker shouldn't complain about returning or passing OwnPtr
​https://bugs.webkit.org/show_bug.cgi?id=121163

Reviewed by Antti Koivisto.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition_and_pass_ptr):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(PassPtrTest.test_pass_ref_ptr_return_value):
(PassPtrTest.test_own_ptr_parameter_value):

9:27 AM WebKitGTK/2.2.x edited by berto@igalia.com
(diff)
9:25 AM WebKitGTK/2.0.x edited by berto@igalia.com
(diff)
9:25 AM Changeset in webkit [155534] by mario@webkit.org
  • 16 edits
    1 delete in trunk

[GTK] Remove Gail dependency from build system for GTK3
​https://bugs.webkit.org/show_bug.cgi?id=119673

Reviewed by Gustavo Noronha Silva.

.:

  • Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
  • Source/autotools/Versions.m4: Removed any reference to GAIL.
  • Source/cmake/FindGAIL3.cmake: Removed.
  • Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.

Source/WebCore:

  • GNUmakefile.am: Removed GAIL_CFLAGS.
  • PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.

Source/WebKit/gtk:

  • GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.

Source/WebKit2:

  • GNUmakefile.am: Removed GAIL_LIBS.

Tools:

  • EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.

  • TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
9:15 AM Changeset in webkit [155533] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

[WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
​https://bugs.webkit.org/show_bug.cgi?id=120892

Reviewed by Martin Robinson.

If the GL context cannot be created then m_isValid is set to false
during the initialization of LayerTreeHostGtk.

This is not really necessary since the rest of the code already
deals with that situation, so it doesn't have any effect other
than breaking the assertion in invalidate().

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):

8:55 AM Changeset in webkit [155532] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r154899.
​http://trac.webkit.org/changeset/154899
​https://bugs.webkit.org/show_bug.cgi?id=121162

It didn't fix the problem and broke other unit tests
(Requested by KaL on #webkit).

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::resizeView):

8:34 AM Changeset in webkit [155531] by commit-queue@webkit.org
  • 17 edits in trunk/LayoutTests

[EFL] Changed expected results after r155253
​https://bugs.webkit.org/show_bug.cgi?id=121157

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2013-09-11

  • platform/efl/editing/deleting/delete-br-004-expected.png:
  • platform/efl/editing/deleting/delete-br-004-expected.txt:
  • platform/efl/editing/deleting/delete-br-005-expected.png:
  • platform/efl/editing/deleting/delete-br-005-expected.txt:
  • platform/efl/editing/deleting/delete-br-006-expected.png:
  • platform/efl/editing/deleting/delete-br-006-expected.txt:
  • platform/efl/editing/selection/caret-ltr-right-expected.png:
  • platform/efl/editing/selection/caret-ltr-right-expected.txt:
  • platform/efl/editing/selection/caret-rtl-2-left-expected.png:
  • platform/efl/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/efl/editing/selection/caret-rtl-right-expected.png:
  • platform/efl/editing/selection/caret-rtl-right-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
8:25 AM Changeset in webkit [155530] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Remove Widget::widgetPositionsUpdated().
<​https://webkit.org/b/121160>

Reviewed by Anders Carlsson.

Remove this no-op virtual that was only used by chromium.

8:24 AM Changeset in webkit [155529] by akling@apple.com
  • 16 edits in trunk/Source

Page::backForward() should return a reference.
<​https://webkit.org/b/121151>

Reviewed by Anders Carlsson.

There is always a BackForwardController, so make backForward() return a reference.
Also made it store a Page& internally since it's tied to the lifetime of Page.

8:05 AM Changeset in webkit [155528] by zandobersek@gmail.com
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r154729 - [GTK][WK2] Only set up a RedirectedXCompositeWindow if running under an X11 display
​https://bugs.webkit.org/show_bug.cgi?id=120321

Reviewed by Gustavo Noronha Silva.

Only set up the RedirectedXCompositeWindow member of the WebKitWebViewBasePrivate struct
if we're running under an X11 display. This is now done in the webkitWebViewBaseConstructed
function rather than the constructor, which is removed.

This allows for the UIProcess to run in a Wayland environment even when built with accelerated
compositing enabled. Of course, at the moment there's no support yet for accelerated compositing
under Wayland, so we fall back to rendering the backing store. No changes are introduced to
the behavior under X11 - accelerated compositing will be used where possible, if supported.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseConstructed):

7:43 AM Changeset in webkit [155527] by mikhail.pozdnyakov@intel.com
  • 8 edits in trunk/Source

WTF::OwnPtr should behave similarly with the rest of WTF smart pointers
​https://bugs.webkit.org/show_bug.cgi?id=120773

Reviewed by Anders Carlsson.

Before the change OwnPtr could take either the pointer type or the pointed-to type, which was bad
for the following reasons:

  • It distinguished OwnPtr behaviour from other WTF smart pointer classes behaviour (so it was confusing for the Client).
  • It was potential error-prone as it actually modified the type given by the Client in opaque way.

Source/WebCore:

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):

Source/WebKit2:

  • UIProcess/API/efl/ewk_database_manager.cpp:

(getDatabaseOriginsCallback):

  • UIProcess/API/efl/ewk_storage_manager.cpp:

(getStorageOriginsCallback):

Source/WTF:

  • wtf/OwnPtr.h:
  • wtf/PassOwnPtr.h:
7:33 AM Changeset in webkit [155526] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WTF

OwnPtr: Use copy/move-and-swap for assignment operators
​https://bugs.webkit.org/show_bug.cgi?id=121154

Reviewed by Anders Carlsson.

Rationals:

  • decrease of repeated code
  • consistency with RefPtr
  • wtf/OwnPtr.h:

(WTF::=):

7:26 AM Changeset in webkit [155525] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[Win] Compile error when VIDEO is not enabled.
​https://bugs.webkit.org/show_bug.cgi?id=121156

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-09-11
Reviewed by Andreas Kling.

  • WebView.cpp:

(WebView::enterFullscreenForNode): Protect isHTMLVideoElement() function with ENABLE(VIDEO) guard.

7:16 AM Changeset in webkit [155524] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

FrameView: Tighten widget handling code.
<​https://webkit.org/b/121155>

Reviewed by Antti Koivisto.

Harden typing in this code to work with RenderEmbeddedObject& instead of RenderObject*.
Functions and members renamed to reflect that they only deal with embedded objects.

  • html/HTMLPlugInImageElement.h:

(WebCore::toHTMLPlugInImageElement):

Add a toHTMLPlugInImageElement that takes an Element&.

  • html/HTMLTagNames.in:

Generate type helpers for applet and embed elements.

  • page/FrameView.h:
  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::removeEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObjects):
(WebCore::FrameView::updateEmbeddedObject):

Re-ordered this function in early return style. Change locals into references.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::~RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::layout):

Updated for new FrameView function signatures.

7:07 AM Changeset in webkit [155523] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Performance tester bots should report the number of failing tests
​https://bugs.webkit.org/show_bug.cgi?id=120462

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-09-11
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTests.start.getText):
(RunAndUploadPerfTests.start):
(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start.getText2):

6:53 AM Changeset in webkit [155522] by ChangSeok Oh
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • GNUmakefile.list.am: Duplicated NetscapePluginModuleNone.cpp & NetscapePluginNone.cpp.

They cause build breaks of multiple definitions when targeting wayland build.

6:44 AM Changeset in webkit [155521] by Patrick Gansterer
  • 6 edits
    1 copy
    1 add
    1 delete in trunk

[CMake] Split out generic Windows files into its own file
​https://bugs.webkit.org/show_bug.cgi?id=119514

Reviewed by Gyuyoung Kim.

This allows us to add smaller CMakeLists.txt files when
adding additional Windows ports.

.:

  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

  • PlatformWin.cmake: Copied from Source/WebCore/PlatformWinCE.cmake.
  • PlatformWinCE.cmake:

Source/WTF:

  • wtf/PlatformWin.cmake: Renamed from Source/WTF/wtf/PlatformWinCE.cmake.
5:05 AM Changeset in webkit [155520] by mario@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
​https://bugs.webkit.org/show_bug.cgi?id=114867

Reviewed by Martin Robinson.

Removed all trace of Gail and Pango specific code from the AtkText
implementation, now everything has been reimplemented.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetTextForOffset): Removed fallback code
relying in Gail/Pango, now all the related code has been
removed. Also, replaced the collection of if statements with a
switch, for better readability of the code.

4:44 AM Changeset in webkit [155519] by allan.jensen@digia.com
  • 5 edits
    2 adds in trunk

Mouseenter/-leave not triggered when element under cursor is moved/removed
​https://bugs.webkit.org/show_bug.cgi?id=120786

Reviewed by Antonio Gomes.

Source/WebCore:

When a hovered element is detached it will now emit a fake mousemove event
similar to what happens when a hovered element has CSS display set to none.

Test: fast/events/mouseenterleave-detached-element.html

  • dom/Document.cpp:

(WebCore::Document::hoveredElementDidDetach):

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMouseMoveEvent):

  • page/EventHandler.h:

LayoutTests:

Test of mouseenter/mouseleave events when a hovered element is removed.

  • fast/events/mouseenterleave-detached-element-expected.txt: Added.
  • fast/events/mouseenterleave-detached-element.html: Added.
4:31 AM Changeset in webkit [155518] by commit-queue@webkit.org
  • 8 edits in trunk

[ATK] Adds mapping MenuItemRadioRole to ATK
​https://bugs.webkit.org/show_bug.cgi?id=121149

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-09-11
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Adds mapping MenuItemRadioRole to ATK.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

Tools:

Adds mapping MenuItemRadioRole to ATK.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(roleToString):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::roleToString):

LayoutTests:

Corrected expectations so that they can properly test MenuItemRadioRole.

  • platform/efl/accessibility/aria-menubar-menuitems-expected.txt:
  • platform/gtk/accessibility/aria-menubar-menuitems-expected.txt:
4:15 AM Changeset in webkit [155517] by berto@igalia.com
  • 2 edits in trunk

autogen.sh: fix removal of autom4te.cache
​https://bugs.webkit.org/show_bug.cgi?id=121150

Reviewed by Carlos Garcia Campos.

The removal of autom4te.cache is wrong, it uses 'rm -f' instead of
'rm -rf' and it relies on an undefined variable.

In addition to that, it should be done after running autoreconf,
which is when it's no longer needed.

  • autogen.sh:
3:32 AM Changeset in webkit [155516] by mario@webkit.org
  • 4 edits in trunk/Source

[GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries
​https://bugs.webkit.org/show_bug.cgi?id=114872

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Re-implement these functions without using GailTextUtil nor Pango.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(lineAtPositionForAtkBoundary): New helper function to find the
line at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextLineForBoundary): New function,
implementing atk_text_get_text_*_offset for LINE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
LINE boundaries with webkitAccessibleTextLineForBoundary().

Source/WebKit/gtk:

Fixed wrong unit test.

  • tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithPreformattedText): This test was
reporting a trailing '\n' for some reason for a <pre> block, which
is plainly wrong since, in order to return that, there should be
at least a trailing empty space after that and before the </pre>
closing tag. This is fixed now.
(testWebkitAtkGetTextAtOffsetWithWrappedLines): Uncommented tests
that were previously not passing due to a bug in GailTextUtil.

3:00 AM WebKitGTK/2.2.x edited by sergio@webkit.org
(diff)
2:56 AM WebKitGTK/2.2.x edited by sergio@webkit.org
(diff)
2:55 AM WebKitGTK/2.0.x edited by sergio@webkit.org
(diff)
2:54 AM Changeset in webkit [155515] by berto@igalia.com
  • 2 edits in trunk

Unquoted $ORIGDIR in autogen.sh
​https://bugs.webkit.org/show_bug.cgi?id=19512

Reviewed by Carlos Garcia Campos.

Quote all directory names. This doesn't mean that all possible
directory names are safe for building webkit, but the configure
script already runs a sanity check.

  • autogen.sh:
2:06 AM Changeset in webkit [155514] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Missed one BackForwardListImpl.h in the last commit.

  • history/BackForwardList.cpp:
1:58 AM Changeset in webkit [155513] by zandobersek@gmail.com
  • 2 edits in releases/WebKitGTK/webkit-2.2

Merge r155509 - [GTK] Stop disabling deprecated symbols in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=121145

Reviewed by Carlos Garcia Campos.

Disabling the dependencies' deprecated symbols in debug builds is only causing unnecessary
build failures. Compiler warnings are being thrown whenever a deprecated symbol is being
used, so a build failure is an overreach in this case.

  • Source/autotools/SetupAutoconfHeader.m4:
1:56 AM Changeset in webkit [155512] by akling@apple.com
  • 21 edits
    2 moves in trunk/Source

Rename BackForwardListImpl.{cpp,h} => BackForwardClient.{cpp,h}

Rubber-stamped by Antti Koivisto.

1:43 AM Changeset in webkit [155511] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

CSSProperty::isInheritedProperty is large
​https://bugs.webkit.org/show_bug.cgi?id=121083

Reviewed by Sam Weinig.

Support [Inherited] option in makeprop.pl and generate CSSProperty::isInheritedProperty in CSSPropertyNames.cpp
using a lookup table. We can pack the table better by using bitfield in the future but I think boolean lookup
table is a good first cut.

Updated CSSPropertyNames.in and SVGCSSPropertyNames.in to use the new option and removed the old code from
CSSProperty.cpp.

  • css/CSSProperty.cpp:
  • css/CSSPropertyNames.in:
  • css/SVGCSSPropertyNames.in:
  • css/makeprop.pl:
1:38 AM Changeset in webkit [155510] by akling@apple.com
  • 21 edits in trunk/Source

Rename BackForwardListImpl => BackForwardList.
<​https://webkit.org/b/121146>

Reviewed by Antti Koivisto.

Nuke another old FIXME.

1:15 AM Changeset in webkit [155509] by zandobersek@gmail.com
  • 2 edits in trunk

[GTK] Stop disabling deprecated symbols in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=121145

Reviewed by Carlos Garcia Campos.

Disabling the dependencies' deprecated symbols in debug builds is only causing unnecessary
build failures. Compiler warnings are being thrown whenever a deprecated symbol is being
used, so a build failure is an overreach in this case.

  • Source/autotools/SetupAutoconfHeader.m4:
1:11 AM Changeset in webkit [155508] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.1.91

Tagging the WebKitGTK+ 2.1.91 release

1:02 AM Changeset in webkit [155507] by gyuyoung.kim@samsung.com
  • 42 edits in trunk/Source

Generate more HTML type checks and casting
​https://bugs.webkit.org/show_bug.cgi?id=121080

Reviewed by Andreas Kling.

Clean-up remained functions of HTML elements using auto-generated isFooElement(),
and replace toFooElement() with ELEMENT_TYPE_CASTS() macro.

Besides this patch clean-up unnecessary checks which are being supported by
auto-generated isFooElement().

Source/WebCore:

No new tests, no behavior change.

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • html/HTMLFrameElementBase.h:

(WebCore::toHTMLFrameElementBase):

  • html/HTMLIFrameElement.h:
  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::notifyFinished):

  • html/HTMLObjectElemenaeh:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

  • html/HTMLSelectElement.h:
  • html/HTMLTagNames.in:
  • html/HTMLVideoElement.h:
  • html/shadow/HTMLContentElement.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • page/PageSerializer.cpp:

(WebCore::frameOwnerURLAttributeName):

  • page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):

  • plugins/IFrameShimSupport.cpp:

(WebCore::getPluginOcclusions):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::mediaSupportsFullscreen):
(WebCore::HitTestResult::mediaElement):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaIsVideo):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForVideo):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::RenderListBox):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):

  • testing/Internals.cpp:

(WebCore::Internals::isSelectPopupVisible):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::supportsFullscreenForNode):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isElementTypePlugin):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

Source/WebKit/gtk:

No new tests, no behavior change.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::supportsFullscreenForNode):

Source/WebKit/mac:

No new tests, no behavior change.

  • Plugins/WebPluginController.mm:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::supportsFullscreenForNode):

  • WebView/WebView.mm:

(-[WebView _enterFullscreenForNode:WebCore::]):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::supportsFullscreenForNode):

  • WebView.cpp:

(WebView::enterFullscreenForNode):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormControls):

12:49 AM Changeset in webkit [155506] by akling@apple.com
  • 9 edits
    1 move in trunk/Source

Rename BackForwardList.h => BackForwardClient.h

Rubber-stamped by Antti Koivisto.

12:46 AM WebKitGTK/Releasing edited by Carlos Garcia Campos
Update release instructions (diff)
12:37 AM Changeset in webkit [155505] by Chris Fleizach
  • 3 edits in trunk/Source/WebCore

AX: Mac platform is not using accessibilityTitle from the Base implementation
​https://bugs.webkit.org/show_bug.cgi?id=121109

Reviewed by Sam Weinig.

Remove the Mac platform overrides of accessibilityTitle, Description, HelpText.
The Base implementation has these and we can share them between iOS and Mac

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
12:36 AM Changeset in webkit [155504] by akling@apple.com
  • 16 edits in trunk/Source

Rename BackForwardList => BackForwardClient.
<​https://webkit.org/b/121143>

Reviewed by Antti Koivisto.

Nuke a 3 year old FIXME about renaming this class.

12:21 AM Changeset in webkit [155503] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

AX: AXValue/AXMenuItemMarkChar not defined for menuitemradio (should be false (0) with aria-checked=mixed | undefined)
​https://bugs.webkit.org/show_bug.cgi?id=120372

Unreviewed. Layout test fix for MacOS WK2.

  • platform/mac/accessibility/menu-item-values.html:
12:09 AM Changeset in webkit [155502] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.1.91 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.
  • configure.ac: Remove webkit_patch_version from AC_INIT call.

Source/WebKit/gtk:

  • NEWS: Add release notes.
Note: See TracTimeline for information about the timeline view.