Timeline
Sep 13, 2013:
- 11:45 PM Changeset in webkit [155754] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceClipper always has an SVGClipPathElement.
<https://webkit.org/b/121349>
Reviewed by Darin Adler.
This renderer is never anonymous. Tighten things up with a clipPathElement()
reference getter. Removed some unnecessary null checks and type casts.
- 11:37 PM Changeset in webkit [155753] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceFilter always has an SVGFilterElement.
<https://webkit.org/b/121348>
Reviewed by Darin Adler.
This renderer is never anonymous. Tighten things up with a filterElement()
reference getter. Removed some unnecessary null checks and type casts.
- 11:36 PM Changeset in webkit [155752] by
-
- 17 edits in trunk
Use a better name than m_invertibleCTM
https://bugs.webkit.org/show_bug.cgi?id=121341
Reviewed by Andreas Kling.
Source/WebCore:
Rename isTransformInvertible to hasInvertibleTransform, and
m_invertibleCTM to m_hasInvertibleTransform.
- html/canvas/CanvasPathMethods.cpp:
(WebCore::CanvasPathMethods::moveTo):
(WebCore::CanvasPathMethods::lineTo):
(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):
(WebCore::CanvasPathMethods::arcTo):
(WebCore::CanvasPathMethods::arc):
(WebCore::CanvasPathMethods::rect):
Updated for name change. Not really sure the name is good here,
because DOMPath doesn't have a transform at all; should switch
to a better name some day.
- html/canvas/CanvasPathMethods.h: Renamed, added a new constructor,
and made the virtual function private.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::clip):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::isPointInStroke):
(WebCore::CanvasRenderingContext2D::clearRect):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::didDraw):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
Updated for name change.
- html/canvas/CanvasRenderingContext2D.h: Updated for name change.
Also got rid of unneeded conditional around forward class declaration.
- html/canvas/DOMPath.h: Moved SVG-specific include into a
separate paragraph. Removed unneeded invocation of WTF_MAKE_NONCOPYABLE,
which is already true since we inherit from RefCounted. Changed create
function argument to be a const*. Eliminated extra constructors that were
unneeded. Made the path-parsing create function SVG-only, rather than
compiling a useless empty one when compiling without SVG.
Tools:
- Scripts/do-webcore-rename: Updated to do this replace as we do.
- 11:35 PM Changeset in webkit [155751] by
-
- 10 edits in trunk/Source/WebCore
CTTE: Tighter element types for RenderSVGResourceGradient and subclasses.
<https://webkit.org/b/121346>
Reviewed by Darin Adler
Codify the following:
- RenderSVGResourceGradient always has an SVGGradientElement.
- RenderSVGResourceLinearGradient always has an SVGLinearGradientElement.
- RenderSVGResourceRadialGradient always has an SVGRadialGradientElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
Also made RenderSVGResourceGradient constructor protected since it should
never be instantiated directly.
- 11:31 PM Changeset in webkit [155750] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
<https://webkit.org/b/121345>
Reviewed by Brent Fulgham.
This renderer is never anonymous. Tighten things up with a maskElement()
reference getter. Removed some unnecessary type casts and assertions.
- 11:29 PM Changeset in webkit [155749] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceMasker always has an SVGMaskElement.
<https://webkit.org/b/121344>
Reviewed by Brent Fulgham.
This renderer is never anonymous. Tighten things up with a maskElement()
reference getter. Removed some unnecessary null checks and assertions.
- 11:22 PM Changeset in webkit [155748] by
-
- 4 edits in trunk
Pick the correct overload when a const reference is passed to appendSlowCase.
https://bugs.webkit.org/show_bug.cgi?id=121326
Reviewed by Darin Adler.
Source/WTF:
- wtf/Vector.h:
(WTF::Vector::appendSlowCase):
Make sure that the pointer to the element isn't const so we'll pick the right expandCapacity overload.
Tools:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 10:45 PM Changeset in webkit [155747] by
-
- 5 edits in trunk
[Windows] Enable Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=121340
Reviewed by Anders Carlsson.
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props: Activate feature.
- win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
LayoutTests:
- platform/win/TestExpectations: Enable some Page Visibility tests on Windows.
- 10:02 PM Changeset in webkit [155746] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r155719?): http/tests/inspector/network/network-size-chunked.html and
http/tests/inspector/network/network-size-sync.html fail on bots
https://bugs.webkit.org/show_bug.cgi?id=121343
- platform/mac/TestExpectations: Marking these as failing.
- 9:54 PM Changeset in webkit [155745] by
-
- 5 edits in trunk/Source/JavaScriptCore
Rename SpeculativeJIT::integerResult() to int32Result().
Rubber stamped by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithIMul):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::int32Result):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 9:46 PM Changeset in webkit [155744] by
-
- 12 edits1 add in trunk/Source/WebCore
Unreviewed, rolling out r155738.
http://trac.webkit.org/changeset/155738
https://bugs.webkit.org/show_bug.cgi?id=121342
Broke many tests (Requested by ap on #webkit).
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSConsoleCustom.cpp: Added.
(WebCore::JSConsole::profile):
(WebCore::JSConsole::profileEnd):
- bindings/js/ScriptState.h:
- page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
- page/Console.h:
- page/Console.idl:
- 8:58 PM Changeset in webkit [155743] by
-
- 2 edits in trunk/Source/WebCore
CSSPropertyAnimation::ensurePropertyMap() is large
https://bugs.webkit.org/show_bug.cgi?id=121199
Reviewed by Darin Adler.
The bug was caused by repeated calls to Vector::append. Avoid it by storing pointers in a local array
and then adding them as we traverse them through to fill m_propertyToIdMap. Also reserve the full
initial capacity at once to avoid repeated calls to FastMalloc and FastFree.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::instance):
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForProperty):
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForIndex):
(WebCore::CSSPropertyAnimationWrapperMap::indexFromPropertyID):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Renamed from ensurePropertyMap.
Also merged addShorthandProperties into it since they have to access local variables of the other.
- 8:51 PM Changeset in webkit [155742] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix for EFL port.
- editing/efl/EditorEfl.cpp:
- platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::write):
- 8:24 PM Changeset in webkit [155741] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix attempt for WK2 build.
- WebProcess/Plugins/PluginView.cpp: Changed ScriptState to ExecState.
(WebKit::PluginView::performJavaScriptURLRequest):
- 7:01 PM Changeset in webkit [155740] by
-
- 10 edits in trunk/Source/WebCore
Fix a few lingering ScriptStates.
Reviewed by Andy Estes.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
- bindings/cpp/WebNativeNodeFilterCondition.cpp:
(WebNativeNodeFilterCondition::acceptNode):
- bindings/cpp/WebNativeNodeFilterCondition.h:
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::create):
- dom/CustomElementConstructor.h:
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::registerElement):
- dom/CustomElementRegistry.h:
- plugins/PluginView.cpp:
(WebCore::PluginView::performRequest):
- 6:57 PM Changeset in webkit [155739] by
-
- 10 edits in trunk
Rename confusingly named "runtimeObject" functions
https://bugs.webkit.org/show_bug.cgi?id=121339
Source/WebCore:
Also CTTE: HTMLElement.
Reviewed by Sam Weinig.
- bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::putDelegate): Renamed.
(WebCore::JSHTMLAppletElement::getCallData): Renamed.
- bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::putDelegate): Renamed.
(WebCore::JSHTMLEmbedElement::getCallData): Renamed.
- bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::putDelegate): Renamed.
(WebCore::JSHTMLObjectElement::getCallData): Renamed.
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::isPluginElement): Changed to take HTMLElement&.
(WebCore::pluginInstance): Ditto.
(WebCore::pluginScriptObjectFromPluginViewBase): Updated for name and type change.
(WebCore::pluginScriptObject): Ditto.
(WebCore::pluginElementPropertyGetter): Ditto.
(WebCore::pluginElementCustomGetOwnPropertySlot): Ditto.
(WebCore::pluginElementCustomPut): Ditto.
(WebCore::pluginElementGetCallData): Ditto.
- bindings/js/JSPluginElementFunctions.h: Updated names and types.
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
Updated for type change.
- bridge/runtime_method.cpp:
(JSC::callRuntimeMethod): Ditto.
Tools:
Reviewed by Sam Weinig.
- Scripts/do-webcore-rename: Updated to do this replace as usual.
- 6:50 PM Changeset in webkit [155738] by
-
- 12 edits1 delete in trunk/Source/WebCore
There is no need for any custom bindings for Console
https://bugs.webkit.org/show_bug.cgi?id=121338
Reviewed by Joseph Pecoraro.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
Remove JSConsoleCustom.cpp from project files.
- bindings/js/JSConsoleCustom.cpp:
Removed.
- page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
- page/Console.h:
Swap the order of the arguments to appease the bindings generator.
- page/Console.idl:
Add the [CallWith=ScriptState] attribute to pass the ExecState
and [TreatNullAs=NullString, TreatUndefinedAs=NullString] to get
the right stringification.
- 6:37 PM Changeset in webkit [155737] by
-
- 2 edits in trunk/Source/WebCore
Part 2 of Replace ScriptState with JSC::ExecState
https://bugs.webkit.org/show_bug.cgi?id=121336
- dom/Document.h:
There is no WebCore::JSC namespace!
- 6:30 PM Changeset in webkit [155736] by
-
- 83 edits in trunk/Source/WebCore
Replace ScriptState with JSC::ExecState
https://bugs.webkit.org/show_bug.cgi?id=121336
Reviewed by Darin Adler.
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBObjectStore.h:
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/js/JSInjectedScriptManager.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptDebugServer.cpp:
- bindings/js/ScriptDebugServer.h:
- bindings/js/ScriptEventListener.cpp:
- bindings/js/ScriptEventListener.h:
- bindings/js/ScriptFunctionCall.cpp:
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptObject.cpp:
- bindings/js/ScriptObject.h:
- bindings/js/ScriptProfiler.cpp:
- bindings/js/ScriptProfiler.h:
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptState.h:
- bindings/js/ScriptValue.cpp:
- bindings/js/ScriptValue.h:
- bindings/js/SerializedScriptValue.cpp:
- bindings/js/SerializedScriptValue.h:
- dom/Document.cpp:
- dom/Document.h:
- dom/NodeFilter.cpp:
- dom/NodeFilter.h:
- dom/NodeFilterCondition.cpp:
- dom/NodeFilterCondition.h:
- dom/NodeIterator.cpp:
- dom/NodeIterator.h:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- dom/Traversal.cpp:
- dom/Traversal.h:
- dom/TreeWalker.cpp:
- dom/TreeWalker.h:
- inspector/ConsoleMessage.cpp:
- inspector/ConsoleMessage.h:
- inspector/InjectedScript.h:
- inspector/InjectedScriptBase.cpp:
- inspector/InjectedScriptBase.h:
- inspector/InjectedScriptCanvasModule.cpp:
- inspector/InjectedScriptCanvasModule.h:
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptManager.cpp:
- inspector/InjectedScriptManager.h:
- inspector/InjectedScriptModule.cpp:
- inspector/InjectedScriptModule.h:
- inspector/InspectorAgent.cpp:
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorConsoleInstrumentation.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/PageConsoleAgent.cpp:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
- inspector/ScriptArguments.cpp:
- inspector/ScriptArguments.h:
- inspector/ScriptDebugListener.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerRuntimeAgent.cpp:
- page/Console.cpp:
- page/Console.h:
- page/ContentSecurityPolicy.cpp:
- page/ContentSecurityPolicy.h:
- page/PageConsole.cpp:
- page/PageConsole.h:
- workers/WorkerGlobalScope.cpp:
- workers/WorkerGlobalScope.h:
- 5:28 PM Changeset in webkit [155735] by
-
- 5 edits in trunk/Source/JavaScriptCore
FTL JIT broke after r155711
https://bugs.webkit.org/show_bug.cgi?id=121332
Reviewed by Geoffrey Garen.
Fixed OSR entry to use the local variable's index instead of its VirtualRegister.
Initialized ExitArgumentForOperand::m_operand to InvalidVirtualRegister instead of -1.
Fixed compileCallOrConstruct() to update locals on callframe going down.
Fixed prepareOSREntry() to grow stack down if needed.
- ftl/FTLExitArgumentForOperand.h:
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileExtractOSREntryLocal):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- 5:26 PM Changeset in webkit [155734] by
-
- 5 edits in trunk/Source
Avoid a couple of zero-sized fastMalloc calls
https://bugs.webkit.org/show_bug.cgi?id=121333
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- API/JSStringRefCF.cpp:
(JSStringCopyCFString):
Return an empty constant CFStringRef if the JSStringRef is empty.
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
Don't allocate an empty m_jsStrings array if m_jsStringsSize is 0.
Source/WTF:
- wtf/text/StringBuffer.h:
(WTF::StringBuffer::StringBuffer):
Initialize m_data to null if m_length is null, and use Checked<size_t> to check for
overflow when multiplying m_length with the character size.
- 4:56 PM Changeset in webkit [155733] by
-
- 2 edits in trunk/LayoutTests
svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey
https://bugs.webkit.org/show_bug.cgi?id=25817
Reviewed by Tim Horton.
- svg/dom/SVGScriptElement/script-load-and-error-events.svg: Let test 5 finish
before starting test 6.
- 4:35 PM Changeset in webkit [155732] by
-
- 2 edits in trunk/LayoutTests
http/tests/misc/submit-post-keygen.html is extremely slow on bots, often timing out
https://bugs.webkit.org/show_bug.cgi?id=121331
- platform/mac/TestExpectations: Marked the test as sometimes timing out.
- 4:35 PM Changeset in webkit [155731] by
-
- 13 edits in trunk/Source/WebCore
Chrome, DragController and FocusController should hold onto a Page&
https://bugs.webkit.org/show_bug.cgi?id=121325
Reviewed by Anders Carlsson.
- editing/FrameSelection.cpp:
- editing/FrameSelection.h:
- page/Chrome.cpp:
(WebCore::Chrome::Chrome):
(WebCore::Chrome::scroll):
(WebCore::Chrome::createWindow):
(WebCore::canRunModalIfDuringPageDismissal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::mouseDidMoveOverElement):
(WebCore::Chrome::setToolTip):
(WebCore::Chrome::windowScreenDidChange):
- page/Chrome.h:
- page/DragController.cpp:
- page/DragController.h:
- page/mac/DragControllerMac.mm:
- page/FocusController.cpp:
- page/FocusController.h:
- page/Page.cpp:
(WebCore::Page::Page):
- page/PageGroupLoadDeferrer.cpp:
- page/PageGroupLoadDeferrer.h:
Take references where possible.
- 4:18 PM Changeset in webkit [155730] by
-
- 12 edits3 adds in trunk
DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
https://bugs.webkit.org/show_bug.cgi?id=121330
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg and Oliver Hunt.
Also print whether a function is strict mode in debug dumps.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
- bytecode/CodeOrigin.cpp:
(JSC::InlineCallFrame::dumpInContext):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Tools:
Reviewed by Mark Hahnenberg and Oliver Hunt.
We should run tests even if they don't have expected files yet.
- Scripts/run-layout-jsc:
LayoutTests:
Reviewed by Mark Hahnenberg and Oliver Hunt.
- js/dfg-strict-mode-to-this-expected.txt: Added.
- js/dfg-strict-mode-to-this.html: Added.
- js/jsc-test-list:
- js/script-tests/dfg-strict-mode-to-this.js: Added.
(thingy.bar):
(thingy.foo):
(thingy):
- 4:05 PM Changeset in webkit [155729] by
-
- 30 edits in trunk
Use nullptr instead of 0 in calls to HashMap::add
https://bugs.webkit.org/show_bug.cgi?id=121322
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
Source/WebCore:
- bridge/IdentifierRep.cpp:
(WebCore::IdentifierRep::get):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData):
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::getOrCreate):
- dom/Document.cpp:
(WebCore::Document::getCSSCanvasElement):
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
- page/PageGroup.cpp:
(WebCore::PageGroup::pageGroup):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPlugin):
Source/WebKit2:
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::getOrCreate):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::getOrCreate):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::evaluateScriptInIsolatedWorld):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::evaluateScriptInIsolatedWorld):
- 4:00 PM Changeset in webkit [155728] by
-
- 5 edits in trunk/LayoutTests
svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280
Approved in person by Geoff Garen.
Increased the number of nodes in the test 10x to see what happens with the number
of leaked nodes.
- svg/animations/smil-leak-dynamically-added-element-instances.svg:
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
- svg/animations/smil-leak-element-instances.svg:
- svg/animations/smil-leak-elements.svg:
- 3:27 PM Changeset in webkit [155727] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: svg/dom/SVGScriptElement/script-load-and-error-events.svg
https://bugs.webkit.org/show_bug.cgi?id=25817
Reviewed by Tim Horton.
- svg/dom/SVGScriptElement/script-load-and-error-events.svg: Made test output
a bit more verbose to see what's happening on bots.
- 2:38 PM Changeset in webkit [155726] by
-
- 4 edits in trunk/Source/WebKit/mac
[mac WK1] Introduce WebViewWillCloseNotification
https://bugs.webkit.org/show_bug.cgi?id=121321
Reviewed by Sam Weinig.
- WebKit.exp: Exported WebViewWillCloseNotification.
- WebView/WebView.mm:
(-[WebView _close]): Send WebViewWillCloseNotification before closing the WebView.
- WebView/WebViewPrivate.h: Declared WebViewWillCloseNotification.
- 2:32 PM Changeset in webkit [155725] by
-
- 2 edits2 adds in trunk/LayoutTests
Layout Test fast/dom/Window/window-postmessage-clone.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111898
Reviewed by Oliver Hunt.
- fast/dom/Window/script-tests/postmessage-clone.js: The test was checking
modification times of non-existent files. When you do this, you get current time,
and current time changes over time, making comparisons non-reliable.
- fast/dom/Window/resources/file1.txt: Added.
- fast/dom/Window/resources/file2.txt: Added.
- 2:19 PM Changeset in webkit [155724] by
-
- 15 edits in trunk
Try to kill initialiser expression in for-in statements
https://bugs.webkit.org/show_bug.cgi?id=121311
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
We'd like to get rid of this pointless initialiser expression
in for-in statements. Unfortunately we have to keep the no_in
variant of expression parsing to avoid ambiguity in the grammar.
There's a possibility that this will need to be rolled out, but
we'll need to live on it to see.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createForInLoop):
- parser/NodeConstructors.h:
(JSC::ForInNode::ForInNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::::parseForStatement):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForInLoop):
LayoutTests:
Update test cases to represent the new reality
- js/line-column-numbers-expected.txt:
- js/line-column-numbers.html:
- js/parser-syntax-check-expected.txt:
- js/script-tests/function-declaration-statement.js:
- js/script-tests/line-column-numbers.js:
(try.toFuzz22b):
- js/script-tests/parser-syntax-check.js:
- js/script-tests/toString-for-var-decl.js:
(f1):
- 2:12 PM Changeset in webkit [155723] by
-
- 4 edits in trunk/Source/WebCore
ContextMenuController should hold onto a Page&
https://bugs.webkit.org/show_bug.cgi?id=121320
Reviewed by Anders Carlsson.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController):
(WebCore::ContextMenuController::~ContextMenuController):
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
(WebCore::ContextMenuController::showContextMenuAt):
- page/ContextMenuController.h:
Store the Page and ContextMenuClient as references.
- page/Page.cpp:
(WebCore::Page::Page):
Pass the Page and ContextMenuClient as references and switch to using createOwned<>().
- 2:11 PM Changeset in webkit [155722] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed; part one of build fix for Windows.
Sorry for the noise, I thought I'd fixed it.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 1:52 PM Changeset in webkit [155721] by
-
- 11 edits in trunk/Source/WebCore
Apply OVERRIDE and FINAL to Image subclasses and clean them up
https://bugs.webkit.org/show_bug.cgi?id=121086
Reviewed by Alexey Proskuryakov.
Everything other than the copious application of OVERRIDE and FINAL
is explicitly called out below.
- WebCore.exp.in:
Export the correct version of getCGImageRef for use by WebKit2.
- platform/graphics/BitmapImage.cpp:
- platform/graphics/BitmapImage.h:
Drive-by inline isBitmapImage.
Move create(HBITMAP) to be near the other create() functions.
Move all of the members private.
Devirtualize frameCount().
Move notSolidColor() near the other solid color functions.
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
Use size() and setContainerSize() instead of directly accessing a
superclass' (now private, previously protected) members.
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GeneratedImage.h:
Make m_size private, I don't think we do protected members.
- platform/graphics/GeneratorGeneratedImage.h:
Make all the members private.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.h:
- 1:41 PM Changeset in webkit [155720] by
-
- 4 edits in trunk/LayoutTests
Flaky Test: http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
https://bugs.webkit.org/show_bug.cgi?id=114209
Reviewed by Joseph Pecoraro.
- TestExpectations: Marked the test as WontFix. It is hopelessly broken, and
doesn't test anything specific anyway.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Removed from the lists, as the test is now skipped globally.
- 1:40 PM Changeset in webkit [155719] by
-
- 2 edits in trunk/Source/WebCore
[Mac] WebCore Web Inspector files are only copied as part of clean build
https://bugs.webkit.org/show_bug.cgi?id=121316
Reviewed by Timothy Hatcher.
Removed insufficient dependencies to make the phase run unconditionally.
- WebCore.xcodeproj/project.pbxproj:
- 1:37 PM Changeset in webkit [155718] by
-
- 5 edits in trunk/Source/WebCore
CodeGeneratorJS doesn't generate header includes for sequence<type>
https://bugs.webkit.org/show_bug.cgi?id=121314
Reviewed by Dean Jackson.
- bindings/scripts/CodeGeneratorJS.pm:
(SkipIncludeHeader): Don't return false for sequence and array types.
(AddIncludesForType): Do add includes for sequence and array types.
(GenerateCallbackImplementation):
- bindings/scripts/test/JS/JSTestTypedefs.cpp: Regenerated
- bindings/scripts/test/JS/JSTestTypedefs.h: Ditto.
- bindings/scripts/test/TestTypedefs.idl: Add a method that takes a sequence<TestEventTarget>.
- 12:41 PM Changeset in webkit [155717] by
-
- 2 edits in trunk/Source/WTF
[Windows] Activate FastMalloc hardening
https://bugs.webkit.org/show_bug.cgi?id=121307
Reviewed by Oliver Hunt.
- wtf/FastMalloc.cpp:
(WTF::SLL_Next): Add workaround for MSVC compiler bug.
- 12:31 PM Changeset in webkit [155716] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourcePattern always has an SVGPatternElement.
<https://webkit.org/b/121313>
Reviewed by Anders Carlsson.
This renderer is never anonymous. Tighten things up with a patternElement()
reference getter. Removed some unnecessary null checks and assertions.
- 12:09 PM Changeset in webkit [155715] by
-
- 11 edits in trunk/Source/WebCore
Remove layering-violating Pasteboard::plainText function (for all platforms now)
https://bugs.webkit.org/show_bug.cgi?id=121312
Reviewed by Antti Koivisto.
- editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainTextWithPasteboard): Call readPlainTextFromPasteboard
on all platforms, not just Mac and EFL. Also call canSmartReplaceWithPasteboard with
a reference instead of a pointer.
(WebCore::Editor::readPlainTextFromPasteboard): Added. This is a cross-platform
version of what was previously a Mac-only function.
(WebCore::Editor::plainTextFromPasteboard): Added. This is the simple non-Mac version
of this function.
(WebCore::Editor::pasteWithPasteboard): Updated to call canSmartReplaceWithPasteboard
with a reference.
(WebCore::Editor::canSmartReplaceWithPasteboard): Updated to take a reference.
- editing/Editor.h: Make readPlainTextFromPasteboard cross-platform instead of
Mac-only. Also changed argument to canSmartReplaceWithPasteboard to be a reference.
Also added private plainTextFromPasteboard function.
- editing/mac/EditorMac.mm:
(WebCore::Editor::pasteWithPasteboard): Updated to call canSmartReplaceWithPasteboard
with a reference.
(WebCore::Editor::plainTextFromPasteboard): Added. Contains the Mac-specific parts
of the readPlainTextFromPasteboard function.
- platform/Pasteboard.h: Fixed a conditional in the PasteboardPlainText struct to
omit iOS. Removed the layering-voiolating plainText function.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::read): Renamed from plainText and updated to new calling
convention.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read): Ditto.
- platform/nix/PasteboardNix.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::read): Ditto.
- 12:06 PM Changeset in webkit [155714] by
-
- 30 edits1 add in trunk
[GTK] Move to the new web inspector
https://bugs.webkit.org/show_bug.cgi?id=120647
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-13
Reviewed by Carlos Garcia Campos.
.:
- GNUmakefile.am: include the new WebInspectorUI GNUmakefile.am.
Source/WebCore:
No tests for the new inspector UI as of yet.
- GNUmakefile.am: no longer install the deprecated inspector UI files.
- WebCore.exp.in: add SchemeRegistry symbol that is now used.
Source/WebInspectorUI:
- GNUmakefile.am: Added. Generate the GResource source and link it into libWebCore.
Source/WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend): update paths to the internal resource ones.
(WebKit::InspectorClient::inspectorFilesPath): ditto.
- tests/testwebinspector.c:
(consoleMessageCallback): the new inspector currently emits an error when loading, so add it to
the list of messages which are not considered failures.
- webkit/webkitglobals.cpp:
(webkitInit): register resource as a local scheme; currently used by the inspector.
Source/WebKit2:
- GNUmakefile.am: bundle the remote inspector page list HTML into libwebkit2gtk as a GResource.
- UIProcess/API/gtk/tests/GNUmakefile.am: no need to set WEBKIT_INSPECTOR_PATH anymore.
- UIProcess/API/gtk/tests/InspectorTestServer.cpp:
(main): ditto.
- UIProcess/API/gtk/tests/TestInspector.cpp:
(beforeAll): ditto.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList): update paths to the internal resource ones.
- UIProcess/InspectorServer/WebInspectorServer.h:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath): ditto.
(WebKit::WebInspectorServer::buildPageList): ditto.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::isMainInspectorPage): factor out checking for the inspector main resource, to make
the code more readable.
(WebKit::decidePolicyForNavigationAction): use SchemeRegistry to figure out whether the
request is for a local resource instead of KURL::isLocalFile() to allow using schemes
other than file:// for the inspector resources.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL): use the new internal resource URL; since it's now
static we no longer need to generate and store the string.
(WebKit::WebInspectorProxy::inspectorBaseURL): ditto.
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL): use the new internal resource URL.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): register resource as a local scheme.
Tools:
- GtkLauncher/main.c:
(main): no longer set WEBKIT_INSPECTOR_PATH.
- MiniBrowser/gtk/main.c:
(main): ditto.
- Scripts/old-run-webkit-tests:
(openDumpTool): ditto.
- Scripts/run-gtk-tests: ditto.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): ditto.
LayoutTests:
- platform/gtk/TestExpectations: the new inspector UI does not support the current
inspector testing harness so keep it skipped, a new one will eventually be landed.
- 11:22 AM Changeset in webkit [155713] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Qt build.
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::write): Update variable name at one place I missed.
- 11:10 AM Changeset in webkit [155712] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Scrolling and zooming is slow when Flash plugin visible
https://bugs.webkit.org/show_bug.cgi?id=120618
Reviewed by Anders Carlsson.
Internally reviewed by Jacky Jiang.
JIRA 490823
Compositing Flash plugin content triggered a workaround for a graphics
driver quirk. The workaround was actually related to WebGL, not Flash,
back when we used glCopyTexImage to implement WebGL double buffering
(see PR 148933 and 150228 for more details of the old implementation).
Originally, both WebGL and plugin layers added themselves to the
LayerRenderer::m_layersLockingTextureResources list. Now only plugin
layers use this list.
The glCopyTexImage code was removed long ago, and WebGL now uses the
EGLImage-based double buffering approach implemented in
EGLImageLayerWebKitThread and EGLImageLayerCompositingThreadClient.
Fixed by removing the now obsolete workaround, a call to "glFinish".
This considerably improves the frame rate of zooming and scrolling when
Flash content is visible.
Improvement in frame rate not appropriate to test using layout tests,
could easily result in flaky test.
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
- 11:03 AM Changeset in webkit [155711] by
-
- 57 edits in trunk/Source/JavaScriptCore
fourthTier: Change JSStack to grow from high to low addresses
https://bugs.webkit.org/show_bug.cgi?id=118758
Reviewed by Oliver Hunt.
Changed the JSC stack to grow down. Effectively the JSC stack frame is flipped from
what it was. See JSStack.h for the new offsets. Changed JSStack begin() and end()
to be getBaseOfStack() and getLimitOfStack(). Most of the changes are address or offset
calculation changes. Decoupled a local register ordinal (loop variable or array index)
from the offset into the callFrame using localToOperand() and the inverse operandToLocal().
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::trustedImm32ForShift):
(JSC::MacroAssembler::lshiftPtr): Added to create scaled addresses with a negative index
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::lshift64): Added to create scaled addresses with a negative index
- assembler/X86Assembler.h:
(JSC::X86Assembler::shlq_i8r): Added to create scaled addresses with a negative index
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/CodeBlock.h:
(JSC::unmodifiedArgumentsRegister):
(JSC::CodeBlock::isCaptured):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::stackOffset):
- bytecode/Operands.h:
(JSC::localToOperand):
(JSC::operandIsLocal):
(JSC::operandToLocal):
(JSC::operandIsArgument):
(JSC::operandToArgument):
(JSC::argumentToOperand):
- bytecode/VirtualRegister.h: Made InvalidVirtualRegister a positive value that fits in
31 bits since it can be placed into the 31 bit field "stackOffset" in struct InlineCallFrame.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::newRegister):
(JSC::BytecodeGenerator::emitNewArray):
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::allocate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callFrameSlot):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::callFrameTagSlot):
(JSC::DFG::SpeculativeJIT::callFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::reportValidationContext):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddSpan):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
- interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::argumentOffset):
(JSC::ExecState::argumentOffsetIncludingThis):
(JSC::ExecState::argIndexForRegister):
- interpreter/Interpreter.cpp:
(JSC::loadVarargs):
(JSC::Interpreter::dumpRegisters):
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::~JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::disableErrorStackReserve):
- interpreter/JSStack.h:
(JSC::JSStack::getBaseOfStack):
(JSC::JSStack::getLimitOfStack):
(JSC::JSStack::size):
(JSC::JSStack::end):
(JSC::JSStack::containsAddress):
(JSC::JSStack::lowAddress):
(JSC::JSStack::highAddress):
(JSC::JSStack::reservationEnd):
(JSC::JSStack::shrink):
(JSC::JSStack::grow):
- interpreter/JSStackInlines.h:
(JSC::JSStack::getTopOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
(JSC::JSStack::installTrapsAfterFrame):
- interpreter/StackVisitor.cpp:
(JSC::inlinedFrameOffset):
(JSC::StackVisitor::readInlinedFrame):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITStubs.cpp:
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
- jit/ThunkGenerators.cpp:
(JSC::arityFixup):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::genericCall):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
(JSC::MarkedArgumentBuffer::slowAppend):
- runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::MarkedArgumentBuffer):
(JSC::MarkedArgumentBuffer::slotFor):
(JSC::MarkedArgumentBuffer::mallocBase):
(JSC::ArgList::at):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/JSActivation.h:
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isValidIndex):
- runtime/JSArray.h:
(JSC::constructArrayNegativeIndexed): New method to create an array from registers that grow down.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::globalExec):
- runtime/JSGlobalObject.h:
(JSC::constructArrayNegativeIndexed):
- runtime/JSString.h:
- runtime/Operations.h:
(JSC::jsStringFromRegisterArray):
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::captureCount):
- 10:59 AM Changeset in webkit [155710] by
-
- 6 edits1 add in trunk/Source/WebCore
Move LineLayoutState class to LineLayoutState.h
https://bugs.webkit.org/show_bug.cgi?id=121263
Reviewed by Ryosuke Niwa.
I added bitfields, reordered the members and a functions too.
No new tests, no behavior change.
- rendering/LineLayoutState.h: Added.
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::markForFullLayout):
(WebCore::LineLayoutState::isFullLayout):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::LineLayoutState::endLineMatched):
(WebCore::LineLayoutState::setEndLineMatched):
(WebCore::LineLayoutState::checkForFloatsFromLastLine):
(WebCore::LineLayoutState::setCheckForFloatsFromLastLine):
(WebCore::LineLayoutState::lineInfo):
(WebCore::LineLayoutState::endLineLogicalTop):
(WebCore::LineLayoutState::setEndLineLogicalTop):
(WebCore::LineLayoutState::endLine):
(WebCore::LineLayoutState::setEndLine):
(WebCore::LineLayoutState::lastFloat):
(WebCore::LineLayoutState::setLastFloat):
(WebCore::LineLayoutState::floats):
(WebCore::LineLayoutState::floatIndex):
(WebCore::LineLayoutState::setFloatIndex):
(WebCore::LineLayoutState::adjustedLogicalLineTop):
(WebCore::LineLayoutState::setAdjustedLogicalLineTop):
(WebCore::LineLayoutState::flowThread):
(WebCore::LineLayoutState::setFlowThread):
- rendering/RenderBlockLineLayout.cpp: Remove LineLayoutState.
- 10:46 AM Changeset in webkit [155709] by
-
- 12 edits in trunk/Source/WebCore
Remove layering-violating Pasteboard::writeURL (for all platforms now)
https://bugs.webkit.org/show_bug.cgi?id=121306
Reviewed by Antti Koivisto.
- editing/Editor.cpp:
(WebCore::Editor::copyURL): Move the contents of the writeURLToPasteboard function
in here.
- editing/Editor.h: Removed Mac-specific writeURLToPasteboard, added private
Mac-specific fillInUserVisibleForm function for the one Mac-specific part of writing URLs.
- editing/efl/EditorEfl.cpp: Deleted Editor::writeURLToPasteboard.
- editing/mac/EditorMac.mm: Deleted Editor::writeURLToPasteboard, moving the code
into copyURL.
(WebCore::Editor::fillInUserVisibleForm): Added.
- page/DragController.cpp:
(WebCore::DragController::startDrag): Call copyURL instead of writeURL or
writeURLToPasteboard.
- platform/Pasteboard.h: Fixed up the PasteboardURL struct so it's suitable for
cross-platform use. Removed the writeURL function. Removed the Frame* argument from
the Windows-specific writeURLToDataObject function.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::write): Renamed/refactored from writeURL.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/nix/PasteboardNix.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Removed unused Frame* argument.
(WebCore::Pasteboard::write): Renamed/refactored from writeURL.
- 10:32 AM Changeset in webkit [155708] by
-
- 4 edits2 adds in trunk
AX: AXPress does not work in SVG
https://bugs.webkit.org/show_bug.cgi?id=121248
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Implement accessKeyAction() on SVGElements, which is what accessibility code
uses in order to activate Elements.
Test: accessibility/svg-element-press.html
- svg/SVGElement.cpp:
(WebCore::SVGElement::accessKeyAction):
- svg/SVGElement.h:
LayoutTests:
- accessibility/svg-element-press-expected.txt: Added.
- accessibility/svg-element-press.html: Added.
- 9:54 AM Changeset in webkit [155707] by
-
- 8 edits in trunk/Source/WebCore
[CTTE] RenderSVGTransformableContainer is never anonymous.
<https://webkit.org/b/121304>
Reviewed by Anders Carlsson.
This renderer is never anonymous. Tighten things up with a graphicsElement()
reference getter.
- 8:56 AM Changeset in webkit [155706] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGImage always has a SVGImageElement.
<https://webkit.org/b/121301>
Reviewed by Anders Carlsson.
This renderer is never anonymous, and always has a corresponding SVGImageElement.
- 8:55 AM Changeset in webkit [155705] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM EABI hardfp buildfix after r155675
https://bugs.webkit.org/show_bug.cgi?id=121287
Reviewed by Geoffrey Garen.
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- 8:54 AM Changeset in webkit [155704] by
-
- 16 edits in trunk/Source/WebCore
[CTTE] Tighter element types for RenderSVGShape and subclasses.
<https://webkit.org/b/121302>
Reviewed by Antti Koivisto.
Codify the following:
- RenderSVGPath always has an SVGGraphicsElement.
- RenderSVGEllipse always has an SVGGraphicsElement.
- RenderSVGRect always has an SVGRectElement.
- RenderSVGShape always has an SVGGraphicsElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 8:53 AM Changeset in webkit [155703] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGResourceFilterPrimitive always has an SVGFilterPrimitiveStandardAttributes.
<https://webkit.org/b/121300>
Reviewed by Anders Carlsson.
This renderer is never anonymous, and always has a corresponding SVGFilterPrimitiveStandardAttributes element.
- 8:40 AM Changeset in webkit [155702] by
-
- 2 edits in trunk/Source/WebKit2
Fix build with namespaced Qt.
Unreviewed build fix.
One forward declaration of QUrl was missing proper namespace macros.
- UIProcess/API/qt/qquickurlschemedelegate_p.h:
- 8:25 AM Changeset in webkit [155701] by
-
- 2 edits in trunk/Source/WTF
OwnArrayPtr: Never allow implicit pointer conversion
https://bugs.webkit.org/show_bug.cgi?id=121291
Reviewed by Anders Carlsson.
We should never allow implicit pointer conversion in OwnArrayPtr
and remove its template copy constructor & template assignment operator, as:
- these methods are never used
- these methods are inappropriate to have in OwnArrayPtr as arrays do not interact well with polymorphism.
- wtf/OwnArrayPtr.h:
- 8:25 AM Changeset in webkit [155700] by
-
- 6 edits in trunk/Source/WebCore
Finish removing layer-violating code from Pasteboard (just for Mac during this first step)
https://bugs.webkit.org/show_bug.cgi?id=121279
Reviewed by Anders Carlsson.
- editing/Editor.h: Added webContentFromPasteboard member function, private nested class
WebContentReader, private createFragmentForImageResourceAndAddResource and
createFragmentAndAddResources member functions.
- editing/mac/EditorMac.mm: Re-sorted includes and added some.
(WebCore::Editor::pasteWithPasteboard): Call the new webContentFromPasteboard function.
(WebCore::Editor::insertParagraphSeparatorInQuotedContent): Comment tweak.
(WebCore::styleForSelectionStart): Removed an unneeded call to String::impl.
(WebCore::Editor::readPlainTextFromPasteboard): Updated to use an isURL boolean instead
of a separate string named "url".
(WebCore::Editor::WebContentReader::readWebArchive): Added. Contains reworked code that
was originally in Pasteboard::documentFragment.
(WebCore::Editor::WebContentReader::readFilenames): Ditto.
(WebCore::Editor::WebContentReader::readHTML): Ditto.
(WebCore::Editor::WebContentReader::readRTFD): Ditto.
(WebCore::Editor::WebContentReader::readRTF): Ditto.
(WebCore::Editor::WebContentReader::readImage): Ditto.
(WebCore::Editor::WebContentReader::readURL): Ditto.
(WebCore::Editor::WebContentReader::readPlainText): Ditto.
(WebCore::Editor::webContentFromPasteboard): Added. Uses WebContentReader to read the
content from the pasteboard.
(WebCore::Editor::createFragmentForImageResourceAndAddResource): Added. Helper used
by code above.
(WebCore::Editor::createFragmentAndAddResources): Ditto.
- platform/Pasteboard.h: Added new PasteboardWebContentReader abstract class so
client can get the various types of pasteboard content and stop on the kind it
can handle. Improved comments and formatting a bit. Removed documentFragment
when compiling for PLATFORM(MAC).
- platform/mac/DragDataMac.mm:
(WebCore::DragData::asFragment): Changed to use Editor::webContentFromPasteboard.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::read): Updated the plain text overload of this for changes
to the struct that holds the result. Added a new web content overload of this,
which retains the pasteboard-reading part of Pasteboard::documentFragment, but
omits the document fragment construction part.
- 8:15 AM Changeset in webkit [155699] by
-
- 4 edits in trunk
[Qt] REGRESSION(r154444): xss-DENIED test results changed
https://bugs.webkit.org/show_bug.cgi?id=120595
Reviewed by Jocelyn Turcotte.
Tools:
Avoid overwriting Qt meta properties, which we identify by them being undeletable.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::initJSObjects):
LayoutTests:
- platform/qt/TestExpectations:
- 8:01 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:50 AM Changeset in webkit [155698] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGText always has a SVGTextElement.
<https://webkit.org/b/121299>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless assertions.
- 7:34 AM Changeset in webkit [155697] by
-
- 13 edits1 delete in trunk/Source
Remove support for QXmlStream as the XML parser.
https://bugs.webkit.org/show_bug.cgi?id=121229
Reviewed by Andreas Kling.
Source/WebCore:
Remove the implementation and all the #ifdef related to it.
- Target.pri:
- WebCore.pri:
- dom/TransformSource.h:
- xml/XMLErrors.h:
- xml/XSLStyleSheet.h:
- xml/XSLTProcessor.h:
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::enterText):
(WebCore::toString):
(WebCore::XMLDocumentParser::exitText):
(WebCore::XMLDocumentParser::insertErrorMessageBlock):
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserQt.cpp: Removed.
Source/WebKit/blackberry:
Removed USE flags.
- WebCoreSupport/AboutDataUseFeatures.in:
Source/WTF:
Removed USE flags.
- wtf/Platform.h:
- 7:07 AM Changeset in webkit [155696] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGViewportContainer always has a SVGSVGElement.
<https://webkit.org/b/121297>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless null checks and type checks.
- 6:42 AM Changeset in webkit [155695] by
-
- 5 edits in trunk/LayoutTests
One more Unreviewed fix after r155675.
- js/array-with-double-assign-expected.txt:
- js/array-with-double-assign.html: Path fixed.
- js/array-with-double-push-expected.txt:
- js/array-with-double-push.html: Path fixed.
- 6:09 AM Changeset in webkit [155694] by
-
- 2 edits in trunk
[Qt] Update sync.profile
https://bugs.webkit.org/show_bug.cgi?id=121295
Reviewed by Simon Hausmann.
Ensure we let the dependencies pick the right branch instead of always master
and list all the dependencies we need on all platforms.
- Source/sync.profile:
- 6:06 AM Changeset in webkit [155693] by
-
- 1 edit6 moves in trunk/LayoutTests
Unreviewed fix after r155675. Move new tests from fast/js to js.
- js/array-with-double-assign-expected.txt: Renamed from LayoutTests/fast/js/array-with-double-assign-expected.txt.
- js/array-with-double-assign.html: Renamed from LayoutTests/fast/js/array-with-double-assign.html.
- js/array-with-double-push-expected.txt: Renamed from LayoutTests/fast/js/array-with-double-push-expected.txt.
- js/array-with-double-push.html: Renamed from LayoutTests/fast/js/array-with-double-push.html.
- js/script-tests/array-with-double-assign.js: Renamed from LayoutTests/fast/js/script-tests/array-with-double-assign.js.
(foo):
- js/script-tests/array-with-double-push.js: Renamed from LayoutTests/fast/js/script-tests/array-with-double-push.js.
(foo):
- 5:57 AM Changeset in webkit [155692] by
-
- 5 edits5 deletes in trunk/LayoutTests
[Qt] unreviewed gardening. Rebaseline after r155253.
- platform/qt-wk2/editing/selection/caret-rtl-2-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-2-left-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-right-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-right-expected.txt: Removed.
- platform/qt/editing/selection/caret-rtl-2-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
- platform/qt/editing/selection/caret-rtl-expected.txt:
- platform/qt/editing/selection/caret-rtl-right-expected.txt:
- 5:32 AM Changeset in webkit [155691] by
-
- 15 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaseline tests after r155408.
- platform/qt/fast/forms/control-restrict-line-height-expected.png:
- platform/qt/fast/forms/control-restrict-line-height-expected.txt:
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/qt/fast/forms/placeholder-position-expected.png:
- platform/qt/fast/forms/placeholder-position-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 5:24 AM Changeset in webkit [155690] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGRoot always has a SVGSVGElement.
<https://webkit.org/b/121293>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless null checks and assertions.
- 5:22 AM Changeset in webkit [155689] by
-
- 5 edits in trunk/Source/WebCore
Remove support for anonymous deprecated flexboxes.
<https://webkit.org/b/121288>
Reviewed by Antti Koivisto.
There are no remaining internal clients of RenderDeprecatedFlexibleBox,
Nuke a FIXME from r143643 where the move to basing renderers on new flexbox started.
This was the only user of anonymous deprecated flexbox, so removed the ability to
construct those.
Also removed some Chrome-related feature observation gunk from constructor.
- 5:21 AM Changeset in webkit [155688] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderMultiColumnBlock is never anonymous.
<https://webkit.org/b/121292>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 5:20 AM Changeset in webkit [155687] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderGrid is never anonymous.
<https://webkit.org/b/121290>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 5:18 AM Changeset in webkit [155686] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderTableCaption is never anonymous.
<https://webkit.org/b/121289>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 4:16 AM Changeset in webkit [155685] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderTableCol is never anonymous.
<https://webkit.org/b/121286>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
Removed one bogus null check that was exposed.
- 4:15 AM Changeset in webkit [155684] by
-
- 5 edits in trunk/Source/WebCore
[CTTE] RenderListItem is never anonymous.
<https://webkit.org/b/121285>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
Removed some bogus assertions that were exposed by this.
- 3:08 AM Changeset in webkit [155683] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION (r155615): Lots of reftests fail with single line or single pixel differences
https://bugs.webkit.org/show_bug.cgi?id=121245
Reviewed by Darin Adler.
Similar to https://bugs.webkit.org/show_bug.cgi?id=120963,
we need to manually ensure that some pieces of persistent
CoreGraphics state are restored after PDFKit changes them.
In this case, we bookend our restoration around the various
_recursiveDisplay... functions that we also use in WebHTMLView.
- WebView/WebPDFView.mm:
(-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
(-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
(-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
(-[WebPDFView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
- 2:48 AM Changeset in webkit [155682] by
-
- 18 edits1 delete in trunk/Source/WebCore
[CTTE] Tighter element types for RenderSVGInline and subclasses.
<https://webkit.org/b/121283>
Reviewed by Antti Koivisto.
Codify the following:
- RenderSVGInline always has an SVGGraphicsElement.
- RenderSVGTextPath always has an SVGTextPathElement.
- RenderSVGTSpan always has an SVGTextPositioningElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 2:43 AM Changeset in webkit [155681] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderFileUploadControl always has a HTMLInputElement.
<https://webkit.org/b/121278>
Reviewed by Darin Adler.
RenderFileUploadControl is never anonymous and always has a corresponding HTMLInputElement.
- 2:40 AM Changeset in webkit [155680] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderFieldset always has a HTMLFieldSetElement.
<https://webkit.org/b/121277>
Reviewed by Darin Adler.
RenderFieldset is never anonymous and always has a corresponding HTMLFieldSetElement.
- 2:38 AM Changeset in webkit [155679] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
https://bugs.webkit.org/show_bug.cgi?id=120848.
- platform/qt/TestExpectations:
- 2:00 AM Changeset in webkit [155678] by
-
- 5 edits in trunk/Source/WebCore
[CTTE] RenderButton always has a HTMLFormControlElement.
<https://webkit.org/b/121281>
Reviewed by Antti Koivisto.
RenderButton is never anonymous and has either a <button> or an <input> element,
and their nearest shared ancestor is HTMLFormControlElement.
- 1:16 AM Changeset in webkit [155677] by
-
- 2 edits in trunk/Source/WebKit/gtk
download-requested arg should be WEBKIT_TYPE_DOWNLOAD not G_TYPE_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=57634
Reviewed by Darin Adler.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
- 1:16 AM Changeset in webkit [155676] by
-
- 5 edits in trunk
Give actions in Range class NON_SHOUTING_NAMES
https://bugs.webkit.org/show_bug.cgi?id=121280
Reviewed by Andreas Kling.
Source/WebCore:
- dom/Range.cpp:
(WebCore::Range::deleteContents):
(WebCore::Range::processContents):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::processNodes):
(WebCore::Range::processAncestorsAndTheirSiblings):
(WebCore::Range::extractContents):
(WebCore::Range::cloneContents):
- dom/Range.h:
Just let do-webcore-rename do its thing.
- DELETE_CONTENTS -> Delete
- EXTRACT_CONTENTS -> Extract
- CLONE_CONTENTS -> Clone
Tools:
- Scripts/do-webcore-rename: Updated to do this replace, keeping with
the tradition of checking in the last one we did, along with other
rename ideas for the future.
- 12:34 AM Changeset in webkit [155675] by
-
- 4 edits8 adds in trunk
Fixed crash in V8 benchmark suite in ARM,softp,EABI environment.
https://bugs.webkit.org/show_bug.cgi?id=117281
Patch by Youngho Yoo <youngho33.yoo@lge.com> on 2013-09-13
Reviewed by Michael Saboff.
Fix the missing EABI_32BIT_DUMMY_ARG in FPRReg using callOperation function.
Source/JavaScriptCore:
Test 1 : fast/js/array-with-double-assign.html
Test 2 : fast/js/array-with-double-push.html
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
LayoutTests:
- fast/js/array-with-double-assign-expected.txt: Added.
- fast/js/array-with-double-assign.html: Added.
- fast/js/array-with-double-push-expected.txt: Added.
- fast/js/array-with-double-push.html: Added.
- fast/js/script-tests/array-with-double-assign.js: Added.
(foo):
- fast/js/script-tests/array-with-double-push.js: Added.
(foo):
Sep 12, 2013:
- 11:42 PM Changeset in webkit [155674] by
-
- 11 edits8 adds in trunk
Source/WebCore: [EFL]Background Style of element not visible because of default theme style
https://bugs.webkit.org/show_bug.cgi?id=117405
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Gyuyoung Kim.
When select element is styled with css background property(color/image) the styling
gets hidden by Combo box non transparent image. This patch handle the
case and transparent images are used when select image is styled. So
now background-color and background-image are visible across the Combo box
The code is added to support css styling of other theme control,
Basically an extra signal is emitted to edje which change the state
of edje object whenever the control is styled.
Covered by existing test case, updated the test expected image.
- platform/efl/DefaultTheme/CMakeLists.txt:
- platform/efl/DefaultTheme/widget/combo/combo.edc:
- platform/efl/DefaultTheme/widget/combo/combo_focus_button_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_focus_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_hover_button_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_hover_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_normal_button_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_normal_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_press_button_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_press_transparent.png: Added.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::isControlStyled):
(WebCore::RenderThemeEfl::paintThemePart):
- platform/efl/RenderThemeEfl.h:
LayoutTests: [EFL] Background Style of element not visible because of default theme style
https://bugs.webkit.org/show_bug.cgi?id=117405
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Gyuyoung Kim.
Updating expected image oputput of pixel test reflecting the
background image visible over combo box.
- platform/efl/fast/forms/menulist-narrow-width-expected.png:
- platform/efl/fast/forms/menulist-restrict-line-height-expected.png:
- platform/efl/fast/forms/menulist-style-color-expected.png:
- platform/efl/fast/forms/select-background-none-expected.png:
- platform/efl/fast/forms/select-style-expected.png:
- 11:16 PM Changeset in webkit [155673] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderMenuList always has a HTMLSelectElement.
<https://webkit.org/b/121276>
Reviewed by Anders Carlsson.
This renderer is never anonymous and always has a corresponding HTMLSelectElement.
Deleted element() in favor of HTMLSelectElement& selectElement().
- 10:50 PM Changeset in webkit [155672] by
-
- 2 edits in trunk/Source/WebKit/qt
Fix Qt build.
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::inputMethodQuery):
- 10:32 PM Changeset in webkit [155671] by
-
- 13 edits in trunk/Source
[CTTE] Tighten RenderTextControl element typing.
<https://webkit.org/b/121275>
Reviewed by Anders Carlsson.
Codify these invariants:
- RenderTextControl always has a HTMLTextFormControl.
- RenderSearchField always has a HTMLInputElement.
- RenderTextControlSingleLine always has a HTMLInputElement.
None of these renderers are ever anonymous. Deleted element() and added
strongly typed reference getters instead.
- 10:13 PM Changeset in webkit [155670] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderListMarker is always anonymous and owned by RenderListItem.
<https://webkit.org/b/121274>
Reviewed by Anders Carlsson.
Store a RenderListItem& instead of a pointer in RenderListMarker.
Deleted the element() function since list markers are always anonymous.
- 10:12 PM Changeset in webkit [155669] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderListBox's element is always a HTMLSelectElement.
<https://webkit.org/b/121273>
Reviewed by Anders Carlsson.
Hide element() on RenderListBox and make selectElement() return a reference
since this renderer cannot be anonymous.
- 10:11 PM Changeset in webkit [155668] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderHTMLCanvas's element is always a HTMLCanvasElement.
<https://webkit.org/b/121272>
Reviewed by Anders Carlsson.
Add RenderHTMLCanvas::canvasElement(), hiding element().
This function also returns a reference since this renderer cannot be anonymous.
- 10:09 PM Changeset in webkit [155667] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderTextControlMultiLine's element is always a HTMLTextAreaElement.
<https://webkit.org/b/121271>
Reviewed by Anders Carlsson.
Add RenderTextControlMultiLine::textAreaElement(), hiding element().
This function also returns a reference since this renderer cannot be anonymous.
- 9:49 PM BuildingGtk edited by
- Add how to use wayland-dependecies.modules (diff)
- 7:19 PM Changeset in webkit [155666] by
-
- 2 edits in trunk/WebKitLibraries
[Windows] Update WKSI library for Open Source builders.
- win/lib32/WebKitSystemInterface.lib: Recompile with latest WebKit to use newer
WTF.dll symbol exports.
- 5:37 PM Changeset in webkit [155665] by
-
- 7 edits2 adds in trunk
[mac] Cache rendered image in PDFDocumentImage
https://bugs.webkit.org/show_bug.cgi?id=121207
Reviewed by Simon Fraser.
Tests: fast/images/pdf-as-image-too-big.html
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::createImage):
PDFDocumentImage takes a ImageObserver now so that it can report
decoded data size changes to the memory cache.
- platform/graphics/Image.h:
(WebCore::Image::isPDFDocumentImage): Added.
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::PDFDocumentImage):
PDFDocumentImage takes a ImageObserver now so that it can report
decoded data size changes to the memory cache.
(WebCore::PDFDocumentImage::applyRotationForPainting):
Fix up some comments, and use GraphicsContext instead of CG API.
(WebCore::PDFDocumentImage::cacheParametersMatch):
Determine whether our cached image is still valid, given the new
destination's size, CTM scale, and source rect.
(WebCore::transformContextForPainting): Added.
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
Cache a rendered bitmap of the PDF. Invalidate the cache if cacheParametersMatch
decides that the parameters don't match, unless we're painting in low quality mode,
in which case we'll scale the existing image (and then fully repaint when the
high-quality repaint timer fires).
Inform the memory cache of our new size.
(WebCore::PDFDocumentImage::draw):
Update the cached image if needed.
Paint the cached image into the context if it's available (which it might not be,
if the image is way too big and the allocation fails). Otherwise, paint straight
into the context as we previously did.
(WebCore::PDFDocumentImage::destroyDecodedData):
Throw away the cached image if requested.
(WebCore::PDFDocumentImage::decodedSize):
(WebCore::PDFDocumentImage::drawPDFPage):
Drive-by use GraphicsContext instead of CG directly.
- platform/graphics/cg/PDFDocumentImage.h:
(WebCore::PDFDocumentImage::create):
Override isPDFDocumentImage().
Add storage for the cached image buffer and various cache parameters.
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
PDFDocumentImage is also interested in/capable of low-quality painting now.
Add a test ensuring that very large PDF-in-<img> elements don't crash.
- fast/images/pdf-as-image-too-big-expected.txt: Added.
- fast/images/pdf-as-image-too-big.html: Added.
- 5:33 PM Changeset in webkit [155664] by
-
- 2 edits in trunk/Source/WebCore
Image doesn't always repaint at high quality in all tiles after a live resize
https://bugs.webkit.org/show_bug.cgi?id=121244
Reviewed by Darin Adler.
Currently, ImageQualityController removes an image from its low-quality-images
list from inside shouldPaintAtLowQuality, if this is the first paint outside
of a live resize, but does not force the renderer to repaint in its entirety.
However, there's no guarantee we've invalidated the whole renderer, so this can
leave some parts of the image painted in low-quality.
This just removes a short-circuit, instead using the ordinary high-quality-repaint
timer to ensure that the entire renderer is repainted.
No new test; all attempts have failed, as this depends on tiled drawing
and a live resize occurring.
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- 5:23 PM Changeset in webkit [155663] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Speculative build fix after r155638.
- platform/efl/PasteboardEfl.cpp: Add include for PassRefPtr, which
is no longer implicitly included.
- 4:57 PM Changeset in webkit [155662] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG::Int32Operand and fillInt32() should go away and all uses should be replaced with SpeculateInt32Operand
https://bugs.webkit.org/show_bug.cgi?id=121268
Reviewed by Oliver Hunt.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
- 4:30 PM Changeset in webkit [155661] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Duplicated color swatches changing autocompletes color names
https://bugs.webkit.org/show_bug.cgi?id=121265
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.
CodeMirror bookmarks at position used to be unique but no longer are.
Define an extension to give us unique bookmarks as we expected, and
update all the old locations using setBookmark.
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
- UserInterface/CodeMirrorAdditions.js:
- 4:28 PM Changeset in webkit [155660] by
-
- 6 edits in trunk/Source
Avoid extra scrollbar-related layouts for overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=121267
Source/WebCore:
Reviewed by Beth Dakin.
If ScrollView::updateScrollbars() detected that scrollbars were added
and removed, it would call contentsResized(), which calls setNeedsLayout(),
followed by visibleContentsResized() which would trigger layout. There is no
point doing this with overlay scrollbars, so avoid it by having
setHas*Scrollbar() return true if the addition/removal of a scrollbar changed
the available width.
No tests: we can't test overlay scrollbars in tests.
- page/FrameView.cpp:
(WebCore::FrameView::setContentsSize): Drive-by assertion that
checks that the unsigned m_deferSetNeedsLayouts doesn't wrap when
decremented.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Return true if the addition/removal
changed available space.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): Only set sendContentResizedNotification
if available space was changed by addition/removal of scrollbars.
- platform/ScrollView.h:
Source/WebKit2:
Reviewed by Beth Dakin.
view->resize() will call setNeedsLayout() if necessary, and may already have
done layout, so the extra setNeedsLayout() here was bad.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setSize):
- 4:27 PM Changeset in webkit [155659] by
-
- 16 edits in trunk/Source/WebInspectorUI
Web Inspector: Update CodeMirror for gutter fix
https://bugs.webkit.org/show_bug.cgi?id=121262
Update CodeMirror to 757944449 to fix gutter click issue:
<https://github.com/marijnh/CodeMirror/issues/1807>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.
- Tools/PrettyPrinting/CodeMirrorFormatters.js:
- Tools/PrettyPrinting/FormatterContentBuilder.js:
(FormatterContentBuilder.prototype._appendIndent):
- Tools/PrettyPrinting/codemirror.css:
- Tools/PrettyPrinting/codemirror.js:
- Tools/PrettyPrinting/css.js:
- UserInterface/CodeMirrorAdditions.js:
- UserInterface/CodeMirrorFormatters.js:
- UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.didRemoveBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint):
- UserInterface/External/CodeMirror/codemirror.css:
- UserInterface/External/CodeMirror/codemirror.js:
- UserInterface/External/CodeMirror/coffeescript.js:
- UserInterface/External/CodeMirror/css.js:
- UserInterface/External/CodeMirror/less.js:
- UserInterface/External/CodeMirror/sql.js:
- UserInterface/TextEditor.js:
(WebInspector.TextEditor.prototype.hasFormatter):
- 4:25 PM Changeset in webkit [155658] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Update License copyrights in minified JavaScript
https://bugs.webkit.org/show_bug.cgi?id=121264
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.
- Scripts/copy-user-interface-resources.sh:
- 4:07 PM Changeset in webkit [155657] by
-
- 7 edits in trunk
Source/JavaScriptCore: Web Inspector shouldn't artificially allocate the arguments object in functions that don't use it
https://bugs.webkit.org/show_bug.cgi?id=121206
<rdar://problem/6911886>
Reviewed by Joseph Pecoraro.
This is a step toward better tools, and a 23% speedup in a simple
JavaScript benchmark run with the Web Inspector open.
We want the Web Inspector to be fast, and we want it to produce reliable
CPU and memory profiles. We can't do that if just opening the Web Inspector
incurs huge CPU/memory penalties like the arguments object.
Also, since use of the 'arguments' identifier is an API for allocating
an object, I think it's good for the UI to let developers know when
they've invoked that API and when they haven't.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): No need to allocate the
arguments object artificially for the debugger's sake. The activation
object no longer assumes that the stack frame is laid out for one.
(Long-term, this code will move out of the activation object, into a
special object for interfacing with the debugger.)
- runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::getOwnPropertySlot): Don't advertise or provide an
arguments object if the user function didn't include one. The bytecode
generator will not have laid out the stack frame to support one.
(Eventually, we do want the Web Inspector to see an arguments
object in scope in the console. That's a one-line change in JSActivation,
but it's blocked by https://bugs.webkit.org/show_bug.cgi?id=121208.)
(JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h: Removed this obsolete performance
work-around. C++ property access to an activation object is no longer
hot.
LayoutTests: Web Inspector shouldn't artificially allocate the arguments object in functions that don't use it
https://bugs.webkit.org/show_bug.cgi?id=121206
Reviewed by Joseph Pecoraro.
<rdar://problem/6911886>
- inspector/debugger/debugger-expand-scope-expected.txt: Updated these
results to reflect the fact that it's correct to exclude the 'arguments'
identifier from function scopes that don't use it.
- inspector/debugger/debugger-expand-scope.html: Edited this test to
include one frame that uses the 'arguments' identifier and one frame
that doesn't, so we test both cases.
- 4:03 PM Changeset in webkit [155656] by
-
- 2 edits in trunk/Tools
Create short build logs for errors and warnings.
https://bugs.webkit.org/show_bug.cgi?id=120614
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
-include StringIO
(CompileWebKit.createSummary):
-add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
- 3:55 PM Changeset in webkit [155655] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Rename shapeContainingBlockHeight to shapeContainingBlockLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=121252
Reviewed by Oliver Hunt.
No new tests, no behavior change.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::pushShapeContentOverflowBelowTheContentBox):
- rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::shapeContainingBlockLogicalHeight):
- 3:46 PM Changeset in webkit [155654] by
-
- 3 edits in trunk/Tools
Update cygwin downloader to search for packages in the right location.
- CygwinDownloader/cygwin-downloader.py:
- CygwinDownloader/cygwin-downloader.zip:
- 3:41 PM Changeset in webkit [155653] by
-
- 5 edits in trunk
<meter> element AXValue is listed as a writable value
https://bugs.webkit.org/show_bug.cgi?id=117650
Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Chris Fleizach.
Source/WebCore:
No new tests, updated existing accessibility/meter-element.html test
to check writability. Changed meter element value to be unwritable.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetValueAttribute):
LayoutTests:
Added writability check to meter element test.
- accessibility/meter-element.html:
- platform/mac/accessibility/meter-element-expected.txt:
- 3:39 PM Changeset in webkit [155652] by
-
- 3 edits in trunk/Source/JavaScriptCore
Rolling out r155632
Broke some tests.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
- heap/MarkedBlock.h:
- 3:09 PM Changeset in webkit [155651] by
-
- 3 edits3 adds in trunk
[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange
https://bugs.webkit.org/show_bug.cgi?id=121148
Reviewed by Kent Tamura.
Source/WebCore:
Non-steppable input types must not rendered as slider even if its webkit-apperance style
property is set to slider-vertical/horizontal.
Test: platform/qt/fast/forms/range/slider-crash-on-input.html
- platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::paintSliderTrack):
LayoutTests:
Trying to render text input as slider-vertical. Expecting to run without crash.
- platform/qt/fast/forms/range/slider-crash-on-input.html: Added.
- platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt: Added.
- 2:40 PM Changeset in webkit [155650] by
-
- 2 edits in trunk/LayoutTests
Canvas fillText and measureText handle ideographic spaces differently
https://bugs.webkit.org/show_bug.cgi?id=108881
Fixing the test:
- Updated paths to js-test scripts.
- Removed "meta charcode" - we don't need to specify a charset here, and it's
"charset", not "charcode" anyway.
- fast/canvas/canvas-measureText-ideographicSpace.html:
- 2:04 PM Changeset in webkit [155649] by
-
- 4 edits in trunk/Source
Source/JavaScriptCore: Qt build fix. Add a return to make the compiler happy.
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::gpr):
Source/WebCore: Qt and Windows build fix.
- page/animation/CSSPropertyAnimation.cpp:
- 2:02 PM Changeset in webkit [155648] by
-
- 5 edits in trunk/LayoutTests
svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280
Reviewed by Tim Horton.
Moved garbage collection out of the function that touches nodes to be collected,
making sure that they are definitely not on the stack.
I could not reproduce locally, so this is a speculative fix.
- svg/animations/smil-leak-dynamically-added-element-instances.svg:
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
- svg/animations/smil-leak-element-instances.svg:
- svg/animations/smil-leak-elements.svg:
- 1:52 PM Changeset in webkit [155647] by
-
- 4 edits in trunk/Source/WebCore
Encapsulate globals in CSSPropertyAnimation.cpp
https://bugs.webkit.org/show_bug.cgi?id=121205
Reviewed by Antti Koivisto.
Encapsulated the globals inside a newly added CSSPropertyAnimationWrapperMap. Also removed the circular
dependency from ShorthandPropertyWrapper's constructor to CSSPropertyAnimationWrapperMap::instance().
The circular dependency still exists in ensurePropertyMap but I'm going to remove it in the bug 121199.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper): Takes a Vector of longhand wrappers instead of
calling wrapperForProperty in the middle of constructing the very table. This circular dependency is now
encapsulated in CSSPropertyAnimationWrapperMap::ensurePropertyMap.
(WebCore::CSSPropertyAnimationWrapperMap::instance): Added.
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForProperty): Renamed from WebCore::wrapperForProperty.
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForIndex): Added.
(WebCore::CSSPropertyAnimationWrapperMap::size): Added.
(WebCore::CSSPropertyAnimationWrapperMap::addPropertyWrapper): Renamed from WebCore::addPropertyWrapper. Also
cleaned up boolean logics to use early exits instead of nested ifs.
(WebCore::CSSPropertyAnimationWrapperMap::addShorthandProperties): Renamed from WebCore::addShorthandProperties.
(WebCore::CSSPropertyAnimationWrapperMap::ensurePropertyMap): Renamed from WebCore::ensurePropertyMap.
Added an alias gPropertyWrappers for m_propertyWrappers; this aliasing will be removed in the bug 121199.
(WebCore::CSSPropertyAnimation::blendProperties):
(WebCore::CSSPropertyAnimation::animationOfPropertyIsAccelerated):
(WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty):
(WebCore::CSSPropertyAnimation::propertiesEqual):
(WebCore::CSSPropertyAnimation::getPropertyAtIndex):
(WebCore::CSSPropertyAnimation::getNumProperties):
- page/animation/CSSPropertyAnimation.h:
- rendering/style/RenderStyle.h:
- 1:42 PM Changeset in webkit [155646] by
-
- 4 edits3 deletes in trunk/LayoutTests
Flaky Test: plugins/mouse-events.html
https://bugs.webkit.org/show_bug.cgi?id=116665
Reviewed by Anders Carlsson.
- plugins/mouse-events-expected.txt:
- plugins/mouse-events.html:
This test used async calls for events, and then usually logged responses while waiting
for a plg.eventLoggingEnabled setter synchronously. Depending on sync/async event
order is not reliable, especially with old WebKit1 plug-in IPC code.
- platform/mac-wk2/plugins/mouse-events-expected.txt: For some unclear reason,
focus works differently in WebKit2.
- platform/gtk/plugins/mouse-events-expected.txt: Removed.
- platform/qt/plugins/mouse-events-expected.txt: Removed.
- platform/win/plugins/mouse-events-expected.txt: Removed.
These results looked similar to new cross-platform ones, hopefully custom results
won't be needed any more.
- 1:40 PM Changeset in webkit [155645] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::GenerationInfo init/fill methods shouldn't duplicate a bunch of logic
https://bugs.webkit.org/show_bug.cgi?id=121253
Reviewed by Oliver Hunt.
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::initGPR):
(JSC::DFG::GenerationInfo::initInt32):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::fillGPR):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillInt32):
(JSC::DFG::GenerationInfo::fillBoolean):
(JSC::DFG::GenerationInfo::fillStorage):
- 1:13 PM Changeset in webkit [155644] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, fix mispelling (Specualte -> Speculate) that I introduced in an
earlier patch.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):
- 1:07 PM Changeset in webkit [155643] by
-
- 7 edits in trunk/Source/JavaScriptCore
GPRTemporary's reuse constructor should be templatized to reduce code duplication, and the bool to denote tag or payload should be replaced with an enum
https://bugs.webkit.org/show_bug.cgi?id=121250
Reviewed by Oliver Hunt.
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::gpr):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::GPRTemporary::GPRTemporary):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSCJSValue.h:
- 1:00 PM Changeset in webkit [155642] by
-
- 3 edits in trunk/Source/WebKit2
Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-12
Reviewed by Darin Adler.
When working on a patch for bug #121121 I found an issue with the InspectorServer where it would try
to parse an HTTP message before receiving the full message and thus fail connecting with the
chromedevtools plugin.
What happens is that the WebSocketServerConnection receives buffers on
WebSocketServerConnection::didReceiveSocketStreamData and calls
WebSocketServerConnection::readHTTPMessage which then checks if we have a valid request by calling
HTTPRequest::parseHTTPRequestFromBuffer. If the request is valid it tries to parse the message and
clears the buffer, otherwise it continues adding data to the internal buffer until we have a valid
request.
The problem is that currently HTTPRequest::parseHTTPRequestFromBuffer considers the request as valid
before receiving the full message. To solve this we should make the method check if the request
headers end with a blank line otherwise we consider the request as invalid (see also
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html).
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(sendIncompleteRequest):
(beforeAll):
Add GTK specific test to check if the inspector server replies to incomplete requests.
- UIProcess/InspectorServer/HTTPRequest.cpp:
(WebKit::HTTPRequest::parseHeaders):
Do not consider request valid if headers didn't end with a blank line.
- 12:52 PM Changeset in webkit [155641] by
-
- 16 edits in trunk/Source
SharedBuffer::createNSData should return a RetainPtr<NSData>
https://bugs.webkit.org/show_bug.cgi?id=121237
Reviewed by Darin Adler.
Source/WebCore:
This makes memory management cleared and fixes a leak in PDFDocumentImage::createPDFDocument.
We use a RetainPtr subclass as a stopgap measure to prevent code that does [buffer->createNSData() autorelease]
from compiling and crashing due to the NSData object being overreleased.
- loader/ResourceBuffer.h:
- loader/mac/ResourceBuffer.mm:
(WebCore::ResourceBuffer::createNSData):
- platform/SharedBuffer.h:
(WebCore::SharedBuffer::NSDataRetainPtr::NSDataRetainPtr):
- platform/graphics/mac/PDFDocumentImageMac.mm:
(WebCore::PDFDocumentImage::createPDFDocument):
- platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(fileWrapperForURL):
- platform/mac/PasteboardMac.mm:
(WebCore::fileWrapper):
(WebCore::Pasteboard::read):
(WebCore::documentFragmentWithRTF):
(WebCore::fragmentFromWebArchive):
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::setBufferForType):
- platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createNSData):
Source/WebKit/mac:
Update for WebCore changes. This also fixes a leak where we'd create an NSFileWrapper from NSData but never release the data.
- WebView/WebDataSource.mm:
(-[WebDataSource data]):
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation documentSource]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
- WebView/WebResource.mm:
(-[WebResource encodeWithCoder:]):
(-[WebResource data]):
Source/WebKit2:
Update for WebCore changes.
- UIProcess/API/mac/WKView.mm:
(-[WKView writeSelectionToPasteboard:types:]):
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
- 12:48 PM Changeset in webkit [155640] by
-
- 2 edits in trunk/Source/WTF
Bitmap's WordType should be a template parameter
https://bugs.webkit.org/show_bug.cgi?id=121238
Reviewed by Darin Adler.
The code is written as if it already is. We just need to lift it out of the class.
This simplifies code that wants to load, for example, a single byte rather than an
entire 32-bit word.
- wtf/Bitmap.h:
(WTF::Bitmap::Bitmap):
(WTF::Bitmap::get):
(WTF::Bitmap::set):
(WTF::Bitmap::testAndSet):
(WTF::Bitmap::testAndClear):
(WTF::Bitmap::concurrentTestAndSet):
(WTF::Bitmap::concurrentTestAndClear):
(WTF::Bitmap::clear):
(WTF::Bitmap::clearAll):
(WTF::Bitmap::nextPossiblyUnset):
(WTF::Bitmap::findRunOfZeros):
(WTF::Bitmap::count):
(WTF::Bitmap::isEmpty):
(WTF::Bitmap::isFull):
- 12:48 PM Changeset in webkit [155639] by
-
- 9 edits in trunk/Source/WebCore
Remove more Timeline stuff we don't use
https://bugs.webkit.org/show_bug.cgi?id=121246
Reviewed by Joseph Pecoraro.
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
- inspector/InspectorTimelineAgent.h:
- 12:23 PM Changeset in webkit [155638] by
-
- 7 edits2 adds in trunk/Source/WebCore
[EFL] Get rid of layering violations in PasteboardEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=121241
Patch by Christophe Dumez <Christophe Dumez> on 2013-09-12
Reviewed by Darin Adler.
Get rid of layering violations in PasteboardEfl.cpp. For now, just mimic
the Mac port to avoid divergences and leave port-specific functions
unimplemented as the EFL port does not support the pasteboard functionality
yet.
No new tests, no behavior change.
- PlatformEfl.cmake:
- editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainTextWithPasteboard):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::copyURL):
(WebCore::Editor::copyImage):
- editing/Editor.h:
- editing/efl/EditorEfl.cpp: Added.
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::writeURLToPasteboard):
(WebCore::Editor::writeImageToPasteboard):
(WebCore::Editor::readPlainTextFromPasteboard):
(WebCore::Editor::pasteWithPasteboard):
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- platform/Pasteboard.h:
- platform/efl/PasteboardEfl.cpp:
- 12:21 PM Changeset in webkit [155637] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Unreviewed build fix after r155635.
Include DragData.h
- platform/gtk/PasteboardGtk.cpp:
- 12:13 PM Changeset in webkit [155636] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Build fix after r155635.
Rubber Stamped by Darin Adler.
- platform/Pasteboard.h: Add missing compile guards for Windows port.
- 11:57 AM FTLJIT edited by
- (diff)
- 11:56 AM FTLJIT edited by
- (diff)
- 11:52 AM FTLJIT edited by
- (diff)
- 11:44 AM FTLJIT edited by
- (diff)
- 11:43 AM FTLJIT edited by
- (diff)
- 11:43 AM FTLJIT created by
- 11:39 AM Changeset in webkit [155635] by
-
- 4 edits in trunk/Source/WebCore
Reorganize Pasteboard.h to make it easier to read, and express plan for future work
https://bugs.webkit.org/show_bug.cgi?id=121234
Reviewed by Anders Carlsson.
- platform/Pasteboard.h: Move Mac/iOS-specific pasteboard names to the bottom of the
file rather than putting them up with forward declarations before the class. Removed
unneeded forward class declarations. Changed #if statements about migration to the
more modern non-layering-violation API to list platforms not yet migrated, rather than
listing platforms that have migrated (Mac). Move conditional code down below the
uncondiditional code so it's easier to see what the class is doing. Move layering-
violation code down to the bottom too, so it's easier to see the future class without
having the design mistakes mixed in. Sort platform-specific sections in alphabetical
order instead of random order. Did the destructor in a cleaner way so the #if is out
of the way after the class rather than in the class. Removed WebSmartPastePboardType,
WebURLPboardType, and WebURLsWithTitlesPboard declarations, since they are only used
inside the PasteboardMac.mm source file.
- platform/ios/PasteboardIOS.mm: Aded a FIXME comment.
- platform/mac/PasteboardMac.mm: Made the constants for pasteboard types be actual
constants, rather than global variables.
- 11:33 AM JavaScriptCore edited by
- (diff)
- 11:29 AM Changeset in webkit [155634] by
-
- 2 edits in trunk/Source/WebCore
[curl] Use utf8 for headers in CurlDownload.
https://bugs.webkit.org/show_bug.cgi?id=120413
Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-09-12
Reviewed by Brent Fulgham.
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::headerCallback):
- 11:26 AM Changeset in webkit [155633] by
-
- 7 edits2 adds in trunk/Source/WebCore
[curl] Improve multipart response handling
https://bugs.webkit.org/show_bug.cgi?id=117735
Reviewed by Brent Fulgham.
The multipart/x-mixed-replace mime type in responses are ignored
with the curl network backend. To handle such responses the
MultipartHandle is introduced which will split the content using
the boundary specified by the mime type.
There are already existing tests (http/tests/multipart).
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPHeader):
- platform/network/HTTPParsers.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/curl/MultipartHandle.cpp: Added.
(WebCore::MultipartHandle::extractBoundary):
(WebCore::MultipartHandle::matchForBoundary):
(WebCore::MultipartHandle::checkForBoundary):
(WebCore::MultipartHandle::parseHeadersIfPossible):
(WebCore::MultipartHandle::contentReceived):
(WebCore::MultipartHandle::processContent):
(WebCore::MultipartHandle::contentEnded):
(WebCore::MultipartHandle::didReceiveData):
(WebCore::MultipartHandle::didReceiveResponse):
- platform/network/curl/MultipartHandle.h: Added.
(WebCore::MultipartHandle::MultipartHandle):
(WebCore::MultipartHandle::~MultipartHandle):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::writeCallback):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
- 11:13 AM Changeset in webkit [155632] by
-
- 3 edits in trunk/Source/JavaScriptCore
MarkedBlocks shouldn't be put in Allocated state if they didn't produce a FreeList
https://bugs.webkit.org/show_bug.cgi?id=121236
Reviewed by Geoffrey Garen.
Right now, after a collection all MarkedBlocks are in the Marked block state. When lazy sweeping
happens, if a block returns an empty free list after being swept, we call didConsumeFreeList(),
which moves the block into the Allocated block state. This happens to both the block that was
just being allocated out of (i.e. m_currentBlock) as well as any blocks who are completely full.
We should distinguish between these two cases: m_currentBlock should transition to
Allocated (because we were just allocating out of it) and any subsequent block that returns an
empty free list should transition back to the Marked state. This will make the block state more
consistent with the actual state the block is in, and it will also allow us to speed up moving
all blocks to the Marked state during generational collection.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::didConsumeEmptyFreeList):
- 10:54 AM Changeset in webkit [155631] by
-
- 15 edits2 deletes in trunk/Source
Remove RenderApplet.
<https://webkit.org/b/121231>
Reviewed by Darin Adler.
Add a RenderEmbeddedObject::createForApplet(HTMLAppletElement&) and nuke
the RenderApplet class from orbit.
- 10:46 AM Changeset in webkit [155630] by
-
- 5 edits in trunk/Source/WebCore
[Windows] Build fix after r155621
Rubber-stamped by Anders Carlsson.
See also https://bugs.webkit.org/show_bug.cgi?id=121235 for
why this was necessary.
- css/MediaQueryEvaluator.cpp: Work around VS compiler bug.
- dom/make_names.pl: Ditto.
- loader/archive/ArchiveFactory.cpp: Ditto.
- rendering/svg/SVGPathData.cpp: Ditto.
- 10:38 AM Changeset in webkit [155629] by
-
- 13 edits in trunk/Source
SharedBuffer::createCFData should return RetainPtr<CFDataRef>
https://bugs.webkit.org/show_bug.cgi?id=121230
Reviewed by Darin Adler.
Source/WebCore:
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::createCFData):
- loader/ResourceBuffer.h:
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::createCFData):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::setData):
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::createPDFDocument):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createCFData):
Source/WebKit2:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
- Shared/WebArchiveResource.cpp:
(WebKit::WebArchiveResource::data):
- 9:57 AM Changeset in webkit [155628] by
-
- 6 edits1 add in trunk/Source/WebCore
Move LineInfo class into LineInfo.h
https://bugs.webkit.org/show_bug.cgi?id=121191
Reviewed by David Hyatt.
No new tests, no behavior change.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/LineInfo.h: Added.
(WebCore::LineInfo::LineInfo):
(WebCore::LineInfo::isFirstLine):
(WebCore::LineInfo::isLastLine):
(WebCore::LineInfo::isEmpty):
(WebCore::LineInfo::previousLineBrokeCleanly):
(WebCore::LineInfo::floatPaginationStrut):
(WebCore::LineInfo::runsFromLeadingWhitespace):
(WebCore::LineInfo::resetRunsFromLeadingWhitespace):
(WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
(WebCore::LineInfo::setFirstLine):
(WebCore::LineInfo::setLastLine):
(WebCore::LineInfo::setEmpty):
(WebCore::LineInfo::setPreviousLineBrokeCleanly):
(WebCore::LineInfo::setFloatPaginationStrut):
- rendering/RenderBlockLineLayout.cpp:
- 9:50 AM Changeset in webkit [155627] by
-
- 7 edits in trunk/Source/WebCore
[CSS Shapes] Remove unnecessarily complex template from ShapeInfo classes
https://bugs.webkit.org/show_bug.cgi?id=121213
Reviewed by Darin Adler.
These classes were trying to be way too clever, and as a result were
hard to read and hard to debug. Replace the complex templated method
calls with virtual methods to make these classes much easier to
understand and maintain.
No new tests, no behavior change.
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape):
(WebCore::::computeSegmentsForLine):
- rendering/shapes/ShapeInfo.h:
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::getShapeValue):
- rendering/shapes/ShapeInsideInfo.h:
(WebCore::ShapeInsideInfo::computeSegmentsForLine):
(WebCore::ShapeInsideInfo::ShapeInsideInfo):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForLine):
(WebCore::ShapeOutsideInfo::getShapeValue):
- rendering/shapes/ShapeOutsideInfo.h:
(WebCore::ShapeOutsideInfo::ShapeOutsideInfo):
- 9:49 AM Changeset in webkit [155626] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Turn shape's logicalwidth/height into a LayoutSize
https://bugs.webkit.org/show_bug.cgi?id=121187
Reviewed by David Hyatt.
No new tests, no behavior change.
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape):
- rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::shapeContainingBlockHeight):
- 9:47 AM Changeset in webkit [155625] by
-
- 7 edits in trunk/Source/WebCore
Move layering-violating code from Pasteboard::plainText into Editor (Mac only at first)
https://bugs.webkit.org/show_bug.cgi?id=121075
Reviewed by Anders Carlsson.
- editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainTextBypassingDHTML): Pass pasteboard as a reference.
(WebCore::Editor::pasteAsPlainTextWithPasteboard): Use readPlainTextFromPasteboard
for Mac. Also update to take a reference.
(WebCore::Editor::paste): Pass pasteboard as a reference.
(WebCore::Editor::pasteAsPlainText): Ditto.
- editing/Editor.h: Ditto.
- editing/mac/EditorMac.mm:
(WebCore::Editor::readSelectionFromPasteboard): Pass pasteboard as a reference.
(WebCore::Editor::readPlainTextFromPasteboard): Added. The declaration of this
was added (by mistake) in an earlier patch. This has code that used to be inside
Pasteboard::plainText.
- platform/Pasteboard.h: Added PasteboardPlainText. Reorganized functions in the
Pasteboard class and added some FIXMEs. Sorted platforms alphabetically and grouped
functions together and data members separate from them.
- platform/mac/DragDataMac.mm:
(WebCore::DragData::asPlainText): Updated to call readPlainTextFromPasteboard.
(WebCore::DragData::asURL): Tweaked style of unused parameter.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::read): Renamed this from plainText, and refactored so that
the data goes out in the PasteboardPlainText structure.
- 9:44 AM Changeset in webkit [155624] by
-
- 6 edits8 adds in trunk
CSS Unit vw in border-width maps to 0px.
https://bugs.webkit.org/show_bug.cgi?id=109229
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-12
Reviewed by Darin Adler.
Source/WebCore:
Border and outline properties were not applied incase
its values were given in vh/vw units.
Tests: fast/css/viewport-height-border.html
fast/css/viewport-height-outline.html
fast/css/viewport-width-border.html
fast/css/viewport-width-outline.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
Added case CSS_VH and CSS_VW.
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportPercentageWidth):
(WebCore::CSSPrimitiveValue::isViewportPercentageHeight):
Added APIs to check the unit type(CSS_VW and CSS_VH).
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
Calculating the border values which has been specified
in vh/vw units.The vh/vw units are calcultated as percent
of viewport height and viewport width respectively.
LayoutTests:
- fast/css/viewport-height-border-expected.txt: Added.
- fast/css/viewport-height-border.html: Added.
- fast/css/viewport-height-outline-expected.txt: Added.
- fast/css/viewport-height-outline.html: Added.
- fast/css/viewport-width-border-expected.txt: Added.
- fast/css/viewport-width-border.html: Added.
- fast/css/viewport-width-outline-expected.txt: Added.
- fast/css/viewport-width-outline.html: Added.
Added new tests for verifying that border and outline properties are
applied when its values are given in vh/vw units.
- resources/js-test-pre.js:
(shouldNotBeEqualToString):
Added this API so that can compare two strings.Similiar to
shouldBeEqualToString.
- 9:42 AM Changeset in webkit [155623] by
-
- 2 edits in trunk/Source/WebCore
[Coordinated Graphics] Fix the build on MacOS 10.9
https://bugs.webkit.org/show_bug.cgi?id=121225
Reviewed by Darin Adler.
- platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
- 9:27 AM Changeset in webkit [155622] by
-
- 15 edits in trunk/Source
Change debug hooks to pass sourceID and position info via the DebuggerCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121214.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::sourceId):
(JSC::DebuggerCallFrame::clear):
- debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):
Source/WebCore:
No new tests.
Also changed the Inspector's JavaScriptCallFrame to get the sourceID and
position info from its DebuggerCallFrame instead of caching those values.
- bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
- bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::invalidate):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::update):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::willExecuteProgram):
- bindings/js/WorkerScriptDebugServer.h:
Source/WebKit/mac:
- webview/WebScriptDebugger.h:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::exception):
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
(WebScriptDebugger::didReachBreakpoint):
- 9:13 AM Changeset in webkit [155621] by
-
- 5 edits in trunk
Add rudimentary support for move-only types as values in HashMap
https://bugs.webkit.org/show_bug.cgi?id=121226
Reviewed by Andreas Kling.
Source/WTF:
- wtf/HashMap.h:
Change a bunch of functions to so they can take both rvalue and lvalue references and use std::forward.
- wtf/HashTraits.h:
(WTF::KeyValuePair::KeyValuePair):
Change constructors to accept both lvalues and rvalues.
Tools:
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
Add a HashMap<unsigned, MoveOnly> test.
- 9:07 AM Changeset in webkit [155620] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Merge r155619 - [GTK][WK1] Block accelerated compositing under non-X11 displays
https://bugs.webkit.org/show_bug.cgi?id=121165
Reviewed by Martin Robinson.
This is analogous to the changes in r154728 and r154729 that enforce disabling accelerated compositing
under Wayland displays and made the RedirectedXCompositeWindow use in WebKit2 limited only to the X11 displays.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp: Remove two unnecessary header includes that also
introduce symbols that conflict with the symbols defined in the X headers. Include the <gdk/gdkx.h> header
if the GTK+ dependency can provide it.
(WebKit::AcceleratedCompositingContext::initialize): Only set up the RedirectedXCompositeWindow instance
if running under an X11 display.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): The removal of the unnecessary header
inclusions also removed the std::max() injection into the global scope. Using std::max directly instead.
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush): Ditto.
- webkit/webkitwebview.cpp:
(updateAcceleratedCompositingSetting): A helper function that ensures the accelerated compositing feature
stays disabled under Wayland displays. It also prints out a warning message the first time the user tries
to enable accelerated compositing under Wayland displays, telling that the feature is not supported and
will remain disabled.
(webkit_web_view_update_settings): Call updateAcceleratedCompositingSetting() to enable the feature if possible.
(webkit_web_view_settings_notify): Ditto.
- 9:02 AM Changeset in webkit [155619] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK][WK1] Block accelerated compositing under non-X11 displays
https://bugs.webkit.org/show_bug.cgi?id=121165
Reviewed by Martin Robinson.
This is analogous to the changes in r154728 and r154729 that enforce disabling accelerated compositing
under Wayland displays and made the RedirectedXCompositeWindow use in WebKit2 limited only to the X11 displays.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp: Remove two unnecessary header includes that also
introduce symbols that conflict with the symbols defined in the X headers. Include the <gdk/gdkx.h> header
if the GTK+ dependency can provide it.
(WebKit::AcceleratedCompositingContext::initialize): Only set up the RedirectedXCompositeWindow instance
if running under an X11 display.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): The removal of the unnecessary header
inclusions also removed the std::max() injection into the global scope. Using std::max directly instead.
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush): Ditto.
- webkit/webkitwebview.cpp:
(updateAcceleratedCompositingSetting): A helper function that ensures the accelerated compositing feature
stays disabled under Wayland displays. It also prints out a warning message the first time the user tries
to enable accelerated compositing under Wayland displays, telling that the feature is not supported and
will remain disabled.
(webkit_web_view_update_settings): Call updateAcceleratedCompositingSetting() to enable the feature if possible.
(webkit_web_view_settings_notify): Ditto.
- 8:55 AM Changeset in webkit [155618] by
-
- 12 edits in trunk/LayoutTests
[EFL] Changed expected results after turning on WTF_USE_TILED_BACKING_STORE (r133898)
https://bugs.webkit.org/show_bug.cgi?id=121227
Unreviewed EFL gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-12
- platform/efl/TestExpectations:
- platform/efl/editing/selection/caret-ltr-2-expected.png:
- platform/efl/editing/selection/caret-ltr-2-expected.txt:
- platform/efl/editing/selection/caret-ltr-2-left-expected.png:
- platform/efl/editing/selection/caret-ltr-2-left-expected.txt:
- platform/efl/editing/selection/caret-ltr-expected.png:
- platform/efl/editing/selection/caret-ltr-expected.txt:
- platform/efl/editing/selection/caret-rtl-2-expected.png:
- platform/efl/editing/selection/caret-rtl-2-expected.txt:
- platform/efl/editing/selection/caret-rtl-expected.png:
- platform/efl/editing/selection/caret-rtl-expected.txt:
- 8:55 AM Changeset in webkit [155617] by
-
- 2 edits in trunk/Source/WebKit
[Win] TestWebKitAPI fails to link.
https://bugs.webkit.org/show_bug.cgi?id=121223
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-12
Reviewed by Brent Fulgham.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add required symbol.
- 8:52 AM Changeset in webkit [155616] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Compile errors, missing include.
https://bugs.webkit.org/show_bug.cgi?id=121222
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-12
Reviewed by Brent Fulgham.
- platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: Include required header.
- platform/win/DragImageCairoWin.cpp: Include required header.
- 8:46 AM Changeset in webkit [155615] by
-
- 3 edits3 adds in trunk
REGRESSION: Inline PDF that are cached fail to appear in iframe.
https://bugs.webkit.org/show_bug.cgi?id=75449
Reviewed by Darin Adler.
Make sure 'frame is from page cache' flag is set for subframes too.
WebFrameLoaderClient::m_frameCameFromPageCache == true forces plugins
to be loaded manually. It ensures that the plugin raw data is fetched again
while the containing frame is being restored from the page cache.
(Plugins get destroyed when the frame goes to page cache.)
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
This gets called only on the frame where the actual history navigation happens.
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
This gets called for all the restored frames.
LayoutTests:
- fast/history/history-back-while-pdf-in-pagecache-expected.html: Added.
- fast/history/history-back-while-pdf-in-pagecache.html: Added.
- fast/history/resources/history-back-for-pfd-test.html: Added.
- 8:30 AM Changeset in webkit [155614] by
-
- 7 edits2 adds in trunk/Tools
Auto GDB backtrace generation for EFL/GTK/Qt bots.
https://bugs.webkit.org/show_bug.cgi?id=119338
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-12
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/port/efl.py:
(EflPort.check_sys_deps):
(EflPort):
(EflPort._get_crash_log):
- Scripts/webkitpy/port/efl_unittest.py:
(EflPortTest.test_show_results_html_file):
(EflPortTest):
(EflPortTest.test_get_crash_log):
- Scripts/webkitpy/port/gtk.py:
(GtkPort._get_crash_log):
- Scripts/webkitpy/port/gtk_unittest.py:
(GtkPortTest.test_get_crash_log):
- Scripts/webkitpy/port/linux_get_crash_log.py: Added.
(GDBCrashLogGenerator):
(GDBCrashLogGenerator.init):
(GDBCrashLogGenerator._get_gdb_output):
(GDBCrashLogGenerator.generate_crash_log):
(GDBCrashLogGenerator.generate_crash_log.match_filename):
- Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
(GDBCrashLogGeneratorTest):
(GDBCrashLogGeneratorTest.test_generate_crash_log):
(_mock_gdb_output):
- Scripts/webkitpy/port/qt.py:
(QtPort.default_child_processes):
(QtPort):
(QtPort._get_crash_log):
- Scripts/webkitpy/port/qt_unittest.py:
(QtPortTest.test_check_sys_deps):
(QtPortTest):
(QtPortTest.test_get_crash_log):
- 8:28 AM Changeset in webkit [155613] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add back c++11 features removed by buildfixes after all ports did the switch
https://bugs.webkit.org/show_bug.cgi?id=119266
Reviewed by Anders Carlsson.
- bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::~Worklist):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::codeType):
(JSC::StackVisitor::Frame::functionName):
(JSC::StackVisitor::Frame::sourceURL):
(JSC::StackVisitor::Frame::print):
- 8:09 AM Changeset in webkit [155612] by
-
- 2 edits in trunk/Tools
Unreviewed. Moving myself to the commiters list.
- Scripts/webkitpy/common/config/contributors.json:
- 7:56 AM Changeset in webkit [155611] by
-
- 36 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase after r155253.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-12
- platform/qt-wk2/editing/style/style-boundary-005-expected.png: Added.
- platform/qt/editing/pasteboard/4989774-expected.png:
- platform/qt/editing/pasteboard/4989774-expected.txt:
- platform/qt/editing/pasteboard/paste-match-style-001-expected.png:
- platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/qt/editing/selection/caret-ltr-2-expected.png:
- platform/qt/editing/selection/caret-ltr-2-expected.txt:
- platform/qt/editing/selection/caret-ltr-2-left-expected.png:
- platform/qt/editing/selection/caret-ltr-2-left-expected.txt:
- platform/qt/editing/selection/caret-ltr-expected.png:
- platform/qt/editing/selection/caret-ltr-expected.txt:
- platform/qt/editing/selection/caret-ltr-right-expected.png:
- platform/qt/editing/selection/caret-ltr-right-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-expected.png:
- platform/qt/editing/selection/caret-rtl-2-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-left-expected.png:
- platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
- platform/qt/editing/selection/caret-rtl-expected.png:
- platform/qt/editing/selection/caret-rtl-expected.txt:
- platform/qt/editing/selection/caret-rtl-right-expected.png:
- platform/qt/editing/selection/caret-rtl-right-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/qt/editing/style/style-boundary-005-expected.png:
- platform/qt/editing/style/style-boundary-005-expected.txt:
- platform/qt/fast/forms/formmove3-expected.txt:
- platform/qt/fast/forms/input-align-image-expected.png:
- platform/qt/fast/forms/input-align-image-expected.txt:
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.png:
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/qt/fast/invalid/003-expected.png:
- platform/qt/fast/invalid/003-expected.txt:
- platform/qt/tables/mozilla/bugs/bug647-expected.png:
- platform/qt/tables/mozilla/bugs/bug647-expected.txt:
- 7:51 AM Changeset in webkit [155610] by
-
- 1 edit1 add in trunk/Tools
[GTK] Add jhbuild-wayland.modules
https://bugs.webkit.org/show_bug.cgi?id=120455
Reviewed by Gustavo Noronha Silva.
Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
WEBKIT_EXTRA_MODULESETS.
- gtk/jhbuild-wayland.modules: Added.
- 7:41 AM Changeset in webkit [155609] by
-
- 3 edits2 adds in trunk
XMLSerializer.serializeToString() should throw exception for invalid node value.
https://bugs.webkit.org/show_bug.cgi?id=121209
Reviewed by Darin Adler.
Source/WebCore:
FF and Opera 12 (pre blink/webkit) throw exception in case the node value is invalid.
Blink sends an empty string as the result of serializeToString operation with invalid node.
We should match with other browsers for throwing it as an exception.
Blink review URL: https://chromiumcodereview.appspot.com/23532055/
Test: fast/dom/xmlserializer-serialize-to-string-exception.html
- xml/XMLSerializer.cpp:
(WebCore::XMLSerializer::serializeToString):
LayoutTests:
- fast/dom/xmlserializer-serialize-to-string-exception-expected.txt: Added.
- fast/dom/xmlserializer-serialize-to-string-exception.html: Added.
- 7:27 AM Changeset in webkit [155608] by
-
- 4 edits2 adds in trunk
Crash in ScrollingStateStickyNode::updateConstraints
https://bugs.webkit.org/show_bug.cgi?id=119638
Reviewed by Simon Fraser.
Ensure when a scrolling state node is removed from the state tree,
we remove both the current node and all its children from the
associated m_stateNodeMap lookup table.
Source/WebCore:
Test: fast/css/sticky/multiple-layers-sticky-crash.html
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::removeChild):
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree):
- page/scrolling/ScrollingStateNode.h:
LayoutTests:
- fast/css/sticky/multiple-layers-sticky-crash-expected.txt: Added.
- fast/css/sticky/multiple-layers-sticky-crash.html: Added.
- 7:03 AM Changeset in webkit [155607] by
-
- 6 edits4 adds in trunk
REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing
https://bugs.webkit.org/show_bug.cgi?id=101047
Reviewed by Simon Fraser.
Compositing layers keep track of ancestors' clipping by constructing the RenderLayerBacking::m_ancestorClippingLayer.
It helps setting up the proper clipping context for the corresponding graphics layer.
When a RenderObject's clipping style changes, it needs to propagate this change not only
to the associated RenderLayer, but also to the descendants', if applicable.
Before r132516, it was mainly covered by initiating full style recalcs, which ensured that
style recalc on the descendant rendering tree took care of creating/destroying
RenderLayerBacking::m_ancestorClippingLayer at every compositing layer node. Without the full
recalc, the clipping of the compositing render layers and the corresponding render subtrees can get out of sync.
This patch updates the clipping context on the descendant subtree, when the clipping behaviour
changes on a render node.
Source/WebCore:
Tests: compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateDescendantClippingContext):
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateAncestorClippingLayer):
(WebCore::RenderLayerBacking::updateDescendantClippingLayer):
- rendering/RenderLayerBacking.h:
LayoutTests:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html: Added.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html: Added.
- 4:15 AM Changeset in webkit [155606] by
-
- 2 edits in trunk/Tools
[GTK][WK2] a11y tests unconditionally launching a11y daemons
https://bugs.webkit.org/show_bug.cgi?id=120299
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-12
Reviewed by Carlos Garcia Campos.
Use the right variable name to store a reference to the at-spi2
bus launcher process, so we can be sure we are terminating it when
calling _tear_down_testing_environment().
- Scripts/run-gtk-tests:
(TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
instead of _ally_bus_launcher.
- 3:54 AM Changeset in webkit [155605] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
https://bugs.webkit.org/show_bug.cgi?id=121218
Reviewed by Philippe Normand.
Skipping the entire suite was added to skip tests when they can't
be run because of the environment, for example to skip the a11y
tests when the at-spi daemons fail to start. This is no longer
true for all the cases, so we can disable the tests that are
impossible to run instead of skipping them.
- Scripts/run-gtk-tests:
(TestRunner.init): Initialize the skipped tests list.
(TestRunner._setup_testing_environment): Add
TestWebKitAccessibility path to the list of disabled tests when
at-spi daemon fail to start.
(TestRunner._should_run_test_program): Check first if the test
program is disabled and then whether it's skipped honoring the
skipped command line option.
- 3:42 AM Changeset in webkit [155604] by
-
- 20 edits2 deletes in trunk/Source
Remove home-brewed nullptr
https://bugs.webkit.org/show_bug.cgi?id=119624
Reviewed by Anders Carlsson.
The standard C++11 nullptr and std::nullptr_t type should be used now.
Source/JavaScriptCore:
- heap/PassWeak.h:
- heap/Weak.h:
Source/WebCore:
- bindings/js/JSDOMBinding.h:
Source/WebKit/efl:
- tests/UnitTestUtils/EWKTestView.cpp:
Source/WTF:
- GNUmakefile.list.am:
- WTF.pro:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/NullPtr.cpp: Removed.
- wtf/NullPtr.h: Removed.
- wtf/OwnArrayPtr.h:
- wtf/OwnPtr.h:
- wtf/PassOwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/RetainPtr.h:
- wtf/win/GDIObject.h:
- 3:24 AM Changeset in webkit [155603] by
-
- 14 edits1 move in trunk
<meter> element text value exposed as AXTitle; should be exposing AXValueDescription
https://bugs.webkit.org/show_bug.cgi?id=117651
Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Mario Sanchez Prada.
Source/WebCore:
No new tests, updated accessibility/meter-element to handle platform specific output.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isMeter):
- accessibility/AccessibilityObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::valueDescription):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::valueDescription):
LayoutTests:
Updated existing meter element test to cover platform specific output.
- accessibility/meter-element.html:
- platform/mac/accessibility/aria-valuetext-on-native-slider-expected.txt:
- platform/mac/accessibility/aria-valuetext-on-native-slider.html:
- platform/mac/accessibility/aria-valuetext.html:
- platform/mac/accessibility/meter-element-expected.txt: Renamed from LayoutTests/accessibility/meter-element-expected.txt.
- platform/mac/accessibility/spinbutton-valuedescription-expected.txt:
- platform/mac/accessibility/spinbutton-valuedescription.html:
- 2:54 AM Changeset in webkit [155602] by
-
- 2 edits in trunk/Source/WebCore
class WeekInputType invokes wrong constructor
https://bugs.webkit.org/show_bug.cgi?id=120768
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Andreas Kling.
Correcting wrong constuctor invocation.
- html/WeekInputType.h:
(WebCore::WeekInputType::WeekInputType):
- 2:51 AM Changeset in webkit [155601] by
-
- 3 edits2 adds in trunk
AX: Self-referencing aria-labelledby only uses contents.
https://bugs.webkit.org/show_bug.cgi?id=120814
Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Implemented additional 'Text Alternative Computation' steps documented at:
http://www.w3.org/WAI/PF/aria/complete#textalternativecomputation. This allows us to remove
our raw text node iteration that was previously forcing us to do our computation incorrectly.
Element content is now sourced using textUnderElement (step 2C of the computation).
Test: accessibility/self-referencing-aria-labelledby.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):
LayoutTests:
Test to verify that self-referencing aria-labelledby behavior works as expected.
- accessibility/self-referencing-aria-labelledby-expected.txt: Added.
- accessibility/self-referencing-aria-labelledby.html: Added.
- 2:38 AM Changeset in webkit [155600] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r155597.
http://trac.webkit.org/changeset/155597
https://bugs.webkit.org/show_bug.cgi?id=121220
broke windows build because there's no ews :( (Requested by
thorton on #webkit).
- WebCore.exp.in:
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::isBitmapImage):
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/CrossfadeGeneratedImage.h:
(WebCore::CrossfadeGeneratedImage::setContainerSize):
(WebCore::CrossfadeGeneratedImage::usesContainerSize):
(WebCore::CrossfadeGeneratedImage::hasRelativeWidth):
(WebCore::CrossfadeGeneratedImage::hasRelativeHeight):
(WebCore::CrossfadeGeneratedImage::size):
- platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::hasSingleSecurityOrigin):
(WebCore::GeneratedImage::setContainerSize):
(WebCore::GeneratedImage::usesContainerSize):
(WebCore::GeneratedImage::hasRelativeWidth):
(WebCore::GeneratedImage::hasRelativeHeight):
(WebCore::GeneratedImage::size):
(WebCore::GeneratedImage::destroyDecodedData):
(WebCore::GeneratedImage::decodedSize):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.h:
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
- svg/graphics/SVGImage.h:
(WebCore::SVGImage::isSVGImage):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::destroyDecodedData):
(WebCore::SVGImage::decodedSize):
- svg/graphics/SVGImageForContainer.h:
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):
- 2:31 AM Changeset in webkit [155599] by
-
- 7 edits in trunk
REGRESSION(r154781): accessibility/notification-listeners.html is failing
https://bugs.webkit.org/show_bug.cgi?id=120669
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-12
Reviewed by Chris Fleizach.
Tools:
Fixed 4 problems that were causing notification-listeners.html to fail.
Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
implemented in axObjectEventListener().
A notification for AXFocusedUIElementChanged was incorrectly sent when
the element lost focus.
Global notification was not dispatched if an element notification was
present in the HashMap.
connectAccessibilityCallbacks() was connecting signals to callbacks
multiple times because it was not checking if
disconnectAccessibilityCallbacks() had an early return if there were
active handlers.
- DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
disconnectAccessibilityCallbacks() to inform if the callbacks were
successfully disconnected.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener): Implemented notifications for
AXFocusedUIElementChanged and AXValueChanged. Fixed the global
notification, which was not dispatched if an element notification
existed. Fixed the notification for AXFocusedUIElementChanged that was
incorrectly sent when the element lost focus. In addition, fixed a typo
where TRUE should be true.
(connectAccessibilityCallbacks): Added early return if
disconnectAccessibilityCallbacks() did not disconnect the callbacks.
(disconnectAccessibilityCallbacks): Added a return value to inform if
callbacks were successfully disconnected.
LayoutTests:
Updated the expectation for notification-listeners.html, which was
failing before this fix.
- platform/gtk/TestExpectations: Removed notification-listeners.html.
- platform/gtk/accessibility/notification-listeners-expected.txt:
Updated the expectation for notification-listeners.html. There is one
difference from the results on the Mac port, which was used as
reference. The element role for <select> is AXComboBox while on Mac
is AXPopUpButton.
- 2:12 AM Changeset in webkit [155598] by
-
- 14 edits in trunk/Source/WebCore
RenderWidget elements are always HTMLFrameOwnerElement subclasses.
<https://webkit.org/b/121217>
Reviewed by Antti Koivisto.
Make RenderWidget constructor take HTMLFrameOwnerElement* and update subclasses
with even tighter types where possible.
Also added RenderWidget::frameOwnerElement() and deleted element().
Removed a handful of unnecessary type checks that were exposed by this.
- 2:03 AM Changeset in webkit [155597] by
-
- 11 edits in trunk/Source/WebCore
Apply OVERRIDE and FINAL to Image subclasses and clean them up
https://bugs.webkit.org/show_bug.cgi?id=121086
Reviewed by Alexey Proskuryakov.
Everything other than the copious application of OVERRIDE and FINAL
is explicitly called out below.
- WebCore.exp.in:
Export the correct version of getCGImageRef for use by WebKit2.
- platform/graphics/BitmapImage.cpp:
- platform/graphics/BitmapImage.h:
Drive-by inline isBitmapImage.
Move create(HBITMAP) to be near the other create() functions.
Move all of the members and quite a few functions from protected to private.
Devirtualize frameCount().
Move notSolidColor() near the other solid color functions.
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
Use size() and setContainerSize() instead of directly accessing a
superclass' (now private, previously protected) members.
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GeneratedImage.h:
Make m_size private, I don't think we do protected members.
- platform/graphics/GeneratorGeneratedImage.h:
Make all the members private.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.h:
- 1:32 AM WebKitGTK/2.2.x edited by
- (diff)
