Timeline
Sep 14, 2013:
- 10:23 PM Changeset in webkit [155795] by
-
- 81 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 5)
https://bugs.webkit.org/show_bug.cgi?id=121375
Reviewed by Andreas Kling.
- dom/make_names.pl:
Add support for a top level 'constructorTakesDocumentReference' property to
force using a Document reference for the whole factory.
- html/HTMLTagNames.in:
Replace per-tag 'constructorTakesDocumentReference' with a top level declaration
now that all of the HTML tag names are supported.
Converts the following to take a Document reference:
- HTMLContentElement
- HTMLElement
- HTMLFrameElementBase
- HTMLFrameOwnerElement
- HTMLPlugInElement
- HTMLPlugInImageElement
- HTMLUnknownElement
- InsertionPoint
- StyledElement
- TextTrackCueBox
- TextTrackCueGenericBoxElement
- 7:25 PM Changeset in webkit [155794] by
-
- 8 edits in trunk
MediaStream API: Update RTCDataChannel
https://bugs.webkit.org/show_bug.cgi?id=121102
Reviewed by Sam Weinig.
Source/WebCore:
Based on https://chromium.googlesource.com/chromium/blink/+/c6975c41956acded7cf0363012d7d6b69d0c6d96,
and https://chromium.googlesource.com/chromium/blink/+/214dab0bd6385f573c918ba5ce58a5aa206ce186.
No new tests, existing tests updated.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::create): Take an options Dictionary.
(WebCore::RTCDataChannel::didChangeReadyState): String -> AtomicString. Early return if the
state hasn't changed.
(WebCore::RTCDataChannel::binaryType): String -> AtomicString.
(WebCore::RTCDataChannel::setBinaryType): String -> AtomicString.
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createDataChannel): Take an options struct.
- platform/mediastream/RTCDataChannelHandler.h:
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore::RTCDataChannelInit::RTCDataChannelInit): Take an options struct.
LayoutTests:
- fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- 5:57 PM Changeset in webkit [155793] by
-
- 5 edits in trunk/Source/JavaScriptCore
It should be easy to add new nodes that do OSR forward rewiring in both DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=121371
Reviewed by Sam Weinig.
Forward rewiring is a tricky part of OSR that handles the following:
a: Something(...)
SetLocal(@a, locX)
b: Int32ToDouble(@a)
c: SomethingThatExits(@b)
<no further uses of @a or @b>
Note that at @c, OSR will think that locX->@a, but @a will be dead. So it must be
smart enough to find @b, which contains an equivalent value. It must do this for
any identity functions we support. Currently we support four such functions.
Currently the code for doing this is basically duplicated between the DFG and the
FTL. Also both versions of the code have some really weirdly written logic for
picking the "best" identity function to use.
We should fix this by simply having a way to ask "is this node an identity
function, and if so, then how good is it?" Then both the DFG and FTL could use
this and have no hard-wired knowledge of those identity functions.
While we're at it, this also changes some terminology because I found the use of
the word "needs" confusing. Note that this retains the somewhat confusing behavior
that we don't search all possible forward/backward uses. We only search one step
in each direction. This is because we only need to handle cases that FixupPhase
and the parser insert. All other code that tries to insert intermediate conversion
nodes should ensure to Phantom the original node. For example, the following
transformation is illegal:
Before:
x: SomethingThatExits(@a)
After:
w: Conversion(@a)
x: SomethingThatExits(@w)
The correct form of that transformation is one of these:
Correct #1:
v: DoAllChecks(@a) exit here
w: Conversion(@a)
x: Something(@w) no exit
Correct #2:
w: Conversion(@a)
x: SomethingThatExits(@w)
y: Phantom(@a)
Correct #3:
w: Conversion(@a)
x: SomethingThatExits(@w, @a)
Note that we use #3 for some heap accesses, but of course it requires that the
node you're using has an extra slot for a "dummy" use child.
Broadly speaking though, such transformations should be relegated to something
below DFG IR, like LLVM IR.
- dfg/DFGNodeType.h:
(JSC::DFG::forwardRewiringSelectionScore):
(JSC::DFG::needsOSRForwardRewiring):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- 5:50 PM Changeset in webkit [155792] by
-
- 5 edits in trunk/Source/WebCore
MediaStream API: Update RTCDataChannel to match the specification
https://bugs.webkit.org/show_bug.cgi?id=120889
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-14
Reviewed by Eric Carlson
Merged from https://chromium.googlesource.com/chromium/blink/+/c3862b0a83e20fc8b1f770c7e4a886a7cceb80d2
by Tommy Widenflycht.
According to WebRTC specification, RTCDataChannel must have the following new attributes:
boolean ordered
unsigned short maxRetransmitTime
unsigned short maxRetransmits
DOMString protocol
boolean negotiated
unsigned short id
and the following one was deprecated:
boolean reliable
Test updates will be landed with https://webkit.org/b/121102.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::ordered):
(WebCore::RTCDataChannel::maxRetransmitTime):
(WebCore::RTCDataChannel::maxRetransmits):
(WebCore::RTCDataChannel::protocol):
(WebCore::RTCDataChannel::negotiated):
(WebCore::RTCDataChannel::id):
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCDataChannel.idl:
- platform/mediastream/RTCDataChannelHandler.h:
- 5:39 PM Changeset in webkit [155791] by
-
- 96 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=121372
Reviewed by Eric Carlson.
Converts the following to take a Document reference:
- HTMLFormControlElement
- HTMLFormControlElementWithState
- HTMLMapElement
- HTMLMarqueeElement
- HTMLMediaElement
- HTMLMenuElement
- HTMLMetaElement
- HTMLMeterElement
- HTMLOListElement
- HTMLObjectElement
- HTMLOptGroupElement
- HTMLOptionElement
- HTMLOutputElement
- HTMLParagraphElement
- HTMLParamElement
- HTMLProgressElement
- HTMLScriptElement
- HTMLSelectElement
- HTMLSourceElement
- HTMLSpanElement
- HTMLStyleElement
- HTMLSummaryElement
- HTMLTableCellElement
- HTMLTableElement
- HTMLTableRowElement
- HTMLTableSectionElement
- HTMLTemplateElement
- HTMLTextAreaElement
- HTMLTextFormControlElement
- HTMLTitleElement
- HTMLTrackElement
- HTMLUListElement
- InlineStyleSheetOwner
- LabelableElement
- All the MediaControl elements
- 5:27 PM Changeset in webkit [155790] by
-
- 7 edits in trunk/Source/WebCore
XMLViewer_js and XMLViewer_css should be minified
https://bugs.webkit.org/show_bug.cgi?id=121334
Reviewed by Timothy Hatcher.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- xml/XMLViewer.css:
- xml/XMLViewer.js:
- 5:16 PM Changeset in webkit [155789] by
-
- 3 edits in trunk/Source/WebCore
[MediaStream] remove MediaStream.label
https://bugs.webkit.org/show_bug.cgi?id=121337
Reviewed by Sam Weinig.
No new tests or modified tests, this attribute was apparently never tested.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
- 2:35 PM Changeset in webkit [155788] by
-
- 2 edits in trunk/Tools
[mac] Check For Framework Include Consistency build phase checks the wrong framework
https://bugs.webkit.org/show_bug.cgi?id=121215
Reviewed by Mark Rowe.
- Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
public and private headers folder paths. Also tweaked the error messages’ format to make
Xcode recognize them as errors.
- 2:33 PM Changeset in webkit [155787] by
-
- 3 edits in trunk/Source/WebKit2
Remove non-Apple cruft from the installed WKBase.h
https://bugs.webkit.org/show_bug.cgi?id=121370
Reviewed by Darin Adler.
- Configurations/WebKit2.xcconfig: Set INSTALLHDRS_SCRIPT_PHASE to YES.
- WebKit2.xcodeproj/project.pbxproj: Added a script build phase that runs unifdef on
the installed WKBase.h with APPLE defined and various BUILDING_* and WTF_USE_* symbols
undefined.
- 2:33 PM Changeset in webkit [155786] by
-
- 99 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=121368
Reviewed by Darin Adler.
Converts the following to take a Document reference:
- DeleteButton
- DetailsContentElement
- DetailsMarkerControl
- DetailsSummaryElement
- HTMLBDIElement
- HTMLBRElement
- HTMLBaseElement
- HTMLBaseFontElement
- HTMLButtonElement
- HTMLCanvasElement
- HTMLDListElement
- HTMLDataListElement
- HTMLDetailsElement
- HTMLDirectoryElement
- HTMLDivElement
- HTMLEmbedElement
- HTMLFieldSetElement
- HTMLFontElement
- HTMLFormElement
- HTMLFrameElement
- HTMLFrameSetElement
- HTMLHRElement
- HTMLHeadElement
- HTMLHeadingElement
- HTMLHtmlElement
- HTMLIFrameElement
- HTMLImageElement
- HTMLInputElement
- HTMLKeygenElement
- HTMLLIElement
- HTMLLabelElement
- HTMLLegendElement
- HTMLLinkElement
- HTMLModElement
- HTMLPreElement
- HTMLQuoteElement
- HTMLTableCaptionElement
- HTMLTableColElement
- ImageDocumentElement
- KeygenSelectElement
- SummaryContentElement
- UploadButtonElement
- 2:11 PM Changeset in webkit [155785] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r155228): Call to DragData::asFragment() nullifies PassRefPtr<Range> in documentFragmentFromDragData
https://bugs.webkit.org/show_bug.cgi?id=121359
Reviewed by Darin Adler.
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData): Pass the naked pointer as the PassRefPtr<Range> argument to the DragData::asFragment()
call. The naked pointer will get wrapped and protected by a new PassRefPtr. Passing the original PassRefPtr will also create
a new PassRefPtr, but will leak the reference of the original one, leaving its pointer nullified.
- 1:59 PM Changeset in webkit [155784] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed GTK build fix after r155774.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Temporarily skip generation of bindings for the Console::profile() and Console::profileEnd() methods
as they're not correctly generated for the moment.
- 1:21 PM Changeset in webkit [155783] by
-
- 5 edits in trunk/Source/JavaScriptCore
Rename IntegerBranch/IntegerCompare to Int32Branch/Int32Compare.
Rubber stamped by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleInt32Branch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileInt32Compare):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileInt32Compare):
- 1:15 PM Changeset in webkit [155782] by
-
- 2 edits in trunk/Source/WebCore
Shrink the nameToPseudoTypeMap function
https://bugs.webkit.org/show_bug.cgi?id=121367
Reviewed by Andreas Kling.
- css/CSSSelector.cpp:
(WebCore::populatePseudoTypeByNameMap): Replaces the old nameToPseudoTypeMap
function. Use a table instead of lots of globals and unrolled code to set up
the map.
(WebCore::CSSSelector::parsePseudoType): Updated to use the code above, and
also use a different style that's tighter.
- 1:11 PM Changeset in webkit [155781] by
-
- 2 edits in trunk/Source/WebCore
Shrink the listMarkerText function
https://bugs.webkit.org/show_bug.cgi?id=121364
Reviewed by Andreas Kling.
Changed code to use StringBuilder, which is a better fit for what we are
doing here. But mainly, inlining was out of hand, so hit that with the
NEVER_INLINE stick. Might be worth revisiting this to optimize further for
speed by making StringBuilder better at this.
- rendering/RenderListMarker.cpp:
(WebCore::toRoman): NEVER_INLINE and use StringBuilder.
(WebCore::toAlphabeticOrNumeric): Use StringBuilder.
(WebCore::toSymbolic): NEVER_INLINE and use StringBuilder.
(WebCore::toAlphabetic): Ditto.
(WebCore::toNumeric): Ditto.
(WebCore::toHebrewUnder1000): NEVER_INLINE.
(WebCore::toHebrew): NEVER_INLINE and use StringBuilder.
(WebCore::toArmenianUnder10000): NEVER_INLINE.
(WebCore::toArmenian): NEVER_INLINE and use StringBuilder.
(WebCore::toGeorgian): NEVER_INLINE and use StringBuilder.
(WebCore::toCJKIdeographic): NEVER_INLINE and use StringBuilder.
(WebCore::listMarkerText): Use StringBuilder.
- 12:51 PM Changeset in webkit [155780] by
-
- 14 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their
constructor (HTMLAnchorElement, HTMLAppletElement, HTMLAreaElement, HTMLAudioElement)
https://bugs.webkit.org/show_bug.cgi?id=121365
Reviewed by Andreas Kling.
- editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply):
- editing/UnlinkCommand.cpp:
(WebCore::UnlinkCommand::doApply):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::create):
- html/HTMLAnchorElement.h:
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::create):
- html/HTMLAppletElement.h:
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::HTMLAreaElement):
(WebCore::HTMLAreaElement::create):
- html/HTMLAreaElement.h:
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::HTMLAudioElement):
(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):
- html/HTMLAudioElement.h:
- html/HTMLTagNames.in:
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addLink):
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
- 12:48 PM Changeset in webkit [155779] by
-
- 5 edits in trunk/Source/WebCore
Get INPUT_SPEECH compiling for Nix, EFL and GTK
https://bugs.webkit.org/show_bug.cgi?id=121362
r154257 was not applied completely in HTMLInputElement.cpp and there was a wrong method signature
in TextControlInnerElements.
Also adding the files needed to build INPUT_SPEECH to each build system files.
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-14
Reviewed by Andreas Kling.
No new tests needed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- html/shadow/TextControlInnerElements.h:
- 12:21 PM Changeset in webkit [155778] by
-
- 2 edits in trunk/Source/WebCore
Missing allow-none introspection annotation for DomDocument.evaluate method
https://bugs.webkit.org/show_bug.cgi?id=118310
Reviewed by Martin Robinson.
Add (allow-none) introspection annotation to parameters that can
be NULL.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
- 12:16 PM Changeset in webkit [155777] by
-
- 7 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (HTMLBodyElement)
https://bugs.webkit.org/show_bug.cgi?id=121363
Reviewed by Andreas Kling.
- dom/make_names.pl:
(defaultTagPropertyHash):
(printConstructorInterior):
Add a new property, 'constructorTakesDocumentReference', to indicate that the class
has been converted to take a Document by reference. Once all classes are converted, this
will go away.
- html/HTMLTagNames.in:
Add the 'constructorTakesDocumentReference' property to the <body> tag as an initial
step.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::HTMLBodyElement):
(WebCore::HTMLBodyElement::create):
- html/HTMLBodyElement.h:
Modify the constructor and create functions of HTMLBodyElement to take a Document reference.
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
(WebCore::createFragmentForTransformToFragment):
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createContainingTable):
Update callers of HTMLBodyElement::create() to pass a Document reference.
- 12:14 PM Changeset in webkit [155776] by
-
- 2 edits in trunk/Source/WebCore
stage
- 12:03 PM Changeset in webkit [155775] by
-
- 5 edits in trunk/Source
Add NeverDestroyed::get
https://bugs.webkit.org/show_bug.cgi?id=121358
Reviewed by Anders Carlsson.
Source/WebCore:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute): Use auto and the new get
function to make this code less repetitive.
Source/WTF:
- wtf/NeverDestroyed.h: Removed code to make this non-copyable, since we also
use a macro to accomplish that.
(WTF::NeverDestroyed::get): Added. Useful in conjuction with auto to avoid
having to repeat the type when we want to put one of these into a reference.
- 11:54 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:52 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:29 AM Changeset in webkit [155774] by
-
- 11 edits1 delete in trunk/Source/WebCore
There is no need for any custom bindings for Console
https://bugs.webkit.org/show_bug.cgi?id=121338
Reviewed by Timothy Hatcher.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
Remove JSConsoleCustom.cpp from project files.
- bindings/js/JSConsoleCustom.cpp:
Removed.
- page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
- page/Console.h:
Swap the order of the arguments to appease the bindings generator.
- page/Console.idl:
Add the [CallWith=ScriptState] attribute to pass the ExecState
and [TreatNullAs=NullString, TreatUndefinedAs=NullString] to get
the right stringification.
- 11:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:07 AM Changeset in webkit [155773] by
-
- 2 edits in trunk/Source/WebKit2
Build fix after r155770.
- UIProcess/API/mac/WKViewPrivate.h: Added WKBase.h import.
- 11:03 AM Changeset in webkit [155772] by
-
- 2 edits in trunk/Tools
[GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296
Reviewed by Martin Robinson.
Instead of using os.symlink() to install the gtk-doc templates,
use os.link() first and fall back to os.symlink() if it fails.
- gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
- 10:26 AM Changeset in webkit [155771] by
-
- 8 edits in trunk/Source/WebCore
AnimationBase::m_animation is never null
https://bugs.webkit.org/show_bug.cgi?id=121360
Reviewed by Darin Adler.
Enforce this by using references instead of pointers.
- page/animation/AnimationBase.cpp:
- page/animation/AnimationBase.h:
- page/animation/CompositeAnimation.cpp:
- page/animation/ImplicitAnimation.cpp:
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h:
- 10:06 AM Changeset in webkit [155770] by
-
- 23 edits3 copies in trunk/Source/WebKit2
[mac] Public header WKBase.h imports a private header, WKBaseMac.h
https://bugs.webkit.org/show_bug.cgi?id=121216
Reviewed by Darin Adler.
- Shared/API/c/WKBase.h: Moved definitions of enums and WK_EXPORT and WK_INLINE macros
out of this files.
- Shared/API/c/WKDeclarationSpecifiers.h: Copied from Source/WebKit2/Shared/API/c/WKBase.h.
Contains definitions of WK_EXPORT and WK_INLINE.
- Shared/API/c/WKSharedAPICast.h: Added #includes.
- Shared/API/c/WKUserContentInjectedFrames.h: Copied from Source/WebKit2/Shared/API/c/WKBase.h.
Contains enum definition.
- Shared/API/c/WKUserScriptInjectionTime.h: Copied from Source/WebKit2/Shared/API/c/WKBase.h.
Contains enum definition.
- UIProcess/API/C/WKPageGroup.h: Added #includes.
- UIProcess/API/mac/WKBrowsingContextController.h: Removed WKBase.h import from this public
header, replacing it with WKDeclarationSpecifiers.h import.
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Added WKBase.h import.
- UIProcess/API/mac/WKBrowsingContextGroup.h: Removed WKBase.h import from this public
header, added necessary public imports.
- UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Added WKBase.h import.
- UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed WKBase.h import from public
header.
- UIProcess/API/mac/WKConnection.h: Ditto. Added WKDeclarationSpecifiers.h import.
- UIProcess/API/mac/WKConnectionInternal.h: Added WKBase.h import.
- UIProcess/API/mac/WKProcessGroup.h: Removed WKBase.h import from public header, added
WKDeclarationSpecifiers.h import.
- UIProcess/API/mac/WKProcessGroupPrivate.h: Added WKBase.h import.
- UIProcess/API/mac/WKView.h: Removed WKBase.h import from public header, added
WKDeclarationSpecifiers.h import.
- WebKit2.xcodeproj/project.pbxproj: Added new public header files, made WKBase.h private.
- WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Removed WKBase.h import from public header,
added WKDeclarationSpecifiers.h import.
- WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h: Added WKBase.h import.
- WebProcess/InjectedBundle/API/mac/WKDOMRange.h: Removed WKBase.h import from public
header, added WKDeclarationSpecifiers.h import.
- WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h: Added WKBase.h import.
- WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Removed WKBase.h import from public
header, added WKDeclarationSpecifiers.h import.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h: Ditto.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
Added WKBase.h import.
- 9:19 AM Changeset in webkit [155769] by
-
- 3 edits in trunk/Source/WebCore
Shrink the function that builds the event listener attribute name map
https://bugs.webkit.org/show_bug.cgi?id=121354
Reviewed by Andreas Kling.
- html/HTMLElement.cpp:
(WebCore::populateEventNameForAttributeLocalNameMap): Added. Uses a
table to populate the map.
(WebCore::eventNameForAttributeLocalNameMap): Added. Uses NeverDestroyed
to allocate a map, but does not initialize it.
(WebCore::HTMLElement::parseAttribute): Put code to use map in here.
- html/HTMLElement.h: Removed eventNameForAttributeName, no longer
a member function.
- 9:12 AM Changeset in webkit [155768] by
-
- 10 edits in trunk
[GTK] WebKitGTK+ is linking against libxslt in too many places
https://bugs.webkit.org/show_bug.cgi?id=121356
Reviewed by Martin Robinson.
Source/WebCore:
Don't use LIBXSLT_CFLAGS when compiling libWebCorePlatform and
libWebCoreGtk, no source files use libxslt there.
- GNUmakefile.am:
Source/WebKit/gtk:
Don't use LIBXSLT_CFLAGS when compiling libwebkitgtk, no source
files use libxslt there.
The webkit tests don't use libxslt, so we shouldn't link against
it.
- GNUmakefile.am:
Source/WebKit2:
Don't use LIBXSLT_CFLAGS when compiling libWebCoreGtk2, no source
files use libxslt there.
- GNUmakefile.am:
Tools:
TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
so we don't need to link against it.
- MiniBrowser/gtk/GNUmakefile.am:
- TestWebKitAPI/GNUmakefile.am:
- WebKitTestRunner/GNUmakefile.am:
- 3:22 AM Changeset in webkit [155767] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r155324.
- platform/gtk/fast/forms/placeholder-position-expected.png:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- 3:20 AM Changeset in webkit [155766] by
-
- 6 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r155408.
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 3:11 AM Changeset in webkit [155765] by
-
- 19 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r155253.
- platform/gtk/editing/pasteboard/4989774-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/gtk/editing/selection/caret-ltr-2-expected.txt:
- platform/gtk/editing/selection/caret-ltr-2-left-expected.txt:
- platform/gtk/editing/selection/caret-ltr-expected.txt:
- platform/gtk/editing/selection/caret-ltr-right-expected.txt:
- platform/gtk/editing/selection/caret-rtl-2-expected.txt:
- platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
- platform/gtk/editing/selection/caret-rtl-expected.txt:
- platform/gtk/editing/selection/caret-rtl-right-expected.txt:
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/gtk/editing/style/style-boundary-005-expected.txt:
- platform/gtk/fast/forms/formmove3-expected.txt:
- platform/gtk/fast/forms/input-align-image-expected.txt:
- platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/gtk/fast/invalid/003-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug647-expected.txt:
- 2:47 AM Changeset in webkit [155764] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Skip additional inspector tests that are failing after switching to the new Web Inspector.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 2:28 AM Changeset in webkit [155763] by
-
- 11 edits1 copy5 adds in trunk
Web Inspector: InjectedScriptSource_js and InjectedScriptCanvasModuleSource_js should be minified
https://bugs.webkit.org/show_bug.cgi?id=121183
Reviewed by Timothy Hatcher.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
Minify files at build time before running xxd.pl.
- WebCore.xcodeproj/project.pbxproj:
- inspector/InjectedScriptCanvasModuleSource.js:
- inspector/InjectedScriptSource.js:
Strip trailing whitespace (touching the files so the derived sources are regenerated).
- inspector/InspectorOverlayPage.css: Added.
- inspector/InspectorOverlayPage.html:
- inspector/InspectorOverlayPage.js: Copied from Source/WebCore/inspector/InspectorOverlayPage.html.
Move JS and CSS to external files. They are inlined and minified at build time.
- inspector/Scripts/cssmin.py: Added.
- inspector/Scripts/jsmin.py: Added.
Copied from WebInspectorUI/Scripts.
- inspector/Scripts/inline-and-minify-stylesheets-and-scripts.py: Added.
Add a script that can inline stylesheets and scripts. For minifying InspectorOverlayPage.html.
LayoutTests:
Now that the file is minified, a line number changed.
- platform/mac/inspector/console/command-line-api-expected.txt:
- 2:26 AM Changeset in webkit [155762] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fixing debug GTK builds after r155709.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::write): Assert that the PasteboardURL's URL is not empty.
- 2:15 AM Changeset in webkit [155761] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderDetailsMarker is never anonymous.
<https://webkit.org/b/121355>
Reviewed by Darin Adler.
This renderer is never anonymous, and always has a corresponding DetailsMarkerControl.
Couldn't resist cleaning up the class a little bit, adding OVERRIDE and making
toRenderDetailsMarker() into a reference version.
- 2:13 AM Changeset in webkit [155760] by
-
- 4 edits in trunk/Source/WebCore
CTTE: RenderRubyAs{Block,Inline} are never anonymous.
<https://webkit.org/b/121353>
Reviewed by Darin Adler.
Replace element() with existingElement() and spam class with OVERRIDE.
Removed bogus removeLeftoverAnonymousBlock() override in RenderRubyAsInline
since it didn't override anything from a parent class.
- 2:11 AM Changeset in webkit [155759] by
-
- 4 edits in trunk/Source/WebCore
CTTE: RenderRubyText is never anonymous.
<https://webkit.org/b/121352>
Reviewed by Darin Adler.
Replace element() with existingElement() and spam class with OVERRIDE.
- 1:38 AM Changeset in webkit [155758] by
-
- 2 edits in trunk/Tools
Uses gtk-doc tools even when --disable-gtk-doc passed
https://bugs.webkit.org/show_bug.cgi?id=91239
Patch by Ross Burton <ross.burton@intel.com> on 2013-09-14
Reviewed by Martin Robinson.
Don't run generate-gtkdoc on install if gtk-doc is disabled.
- GNUmakefile.am:
- 1:36 AM Changeset in webkit [155757] by
-
- 2 edits in trunk/Tools
[GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296
Reviewed by Carlos Garcia Campos.
Use symlinks instead of hard links to support building on a
different file system.
- gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
- 12:46 AM Changeset in webkit [155756] by
-
- 8 edits in trunk/Source/WebCore
CTTE: RenderSVGBlock renderers are never anonymous.
<https://webkit.org/b/121351>
Reviewed by Antti Koivisto.
RenderSVGBlock inherits from RenderBlockFlow, so needs separate treatment
from RenderSVGModelObject.
But like RSMO, these renderers are never anonymous, so add strongly typed
reference getters and do away with some magical type casts.
- 12:28 AM Changeset in webkit [155755] by
-
- 34 edits in trunk/Source/WebCore
CTTE: RenderSVGModelObject renderers are never anonymous.
<https://webkit.org/b/121350>
Reviewed by Darin Adler.
Flip the switch, turning RenderSVGModelObject::element() into a reference.
Sep 13, 2013:
- 11:45 PM Changeset in webkit [155754] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceClipper always has an SVGClipPathElement.
<https://webkit.org/b/121349>
Reviewed by Darin Adler.
This renderer is never anonymous. Tighten things up with a clipPathElement()
reference getter. Removed some unnecessary null checks and type casts.
- 11:37 PM Changeset in webkit [155753] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceFilter always has an SVGFilterElement.
<https://webkit.org/b/121348>
Reviewed by Darin Adler.
This renderer is never anonymous. Tighten things up with a filterElement()
reference getter. Removed some unnecessary null checks and type casts.
- 11:36 PM Changeset in webkit [155752] by
-
- 17 edits in trunk
Use a better name than m_invertibleCTM
https://bugs.webkit.org/show_bug.cgi?id=121341
Reviewed by Andreas Kling.
Source/WebCore:
Rename isTransformInvertible to hasInvertibleTransform, and
m_invertibleCTM to m_hasInvertibleTransform.
- html/canvas/CanvasPathMethods.cpp:
(WebCore::CanvasPathMethods::moveTo):
(WebCore::CanvasPathMethods::lineTo):
(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):
(WebCore::CanvasPathMethods::arcTo):
(WebCore::CanvasPathMethods::arc):
(WebCore::CanvasPathMethods::rect):
Updated for name change. Not really sure the name is good here,
because DOMPath doesn't have a transform at all; should switch
to a better name some day.
- html/canvas/CanvasPathMethods.h: Renamed, added a new constructor,
and made the virtual function private.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::clip):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::isPointInStroke):
(WebCore::CanvasRenderingContext2D::clearRect):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::didDraw):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
Updated for name change.
- html/canvas/CanvasRenderingContext2D.h: Updated for name change.
Also got rid of unneeded conditional around forward class declaration.
- html/canvas/DOMPath.h: Moved SVG-specific include into a
separate paragraph. Removed unneeded invocation of WTF_MAKE_NONCOPYABLE,
which is already true since we inherit from RefCounted. Changed create
function argument to be a const*. Eliminated extra constructors that were
unneeded. Made the path-parsing create function SVG-only, rather than
compiling a useless empty one when compiling without SVG.
Tools:
- Scripts/do-webcore-rename: Updated to do this replace as we do.
- 11:35 PM Changeset in webkit [155751] by
-
- 10 edits in trunk/Source/WebCore
CTTE: Tighter element types for RenderSVGResourceGradient and subclasses.
<https://webkit.org/b/121346>
Reviewed by Darin Adler
Codify the following:
- RenderSVGResourceGradient always has an SVGGradientElement.
- RenderSVGResourceLinearGradient always has an SVGLinearGradientElement.
- RenderSVGResourceRadialGradient always has an SVGRadialGradientElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
Also made RenderSVGResourceGradient constructor protected since it should
never be instantiated directly.
- 11:31 PM Changeset in webkit [155750] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
<https://webkit.org/b/121345>
Reviewed by Brent Fulgham.
This renderer is never anonymous. Tighten things up with a maskElement()
reference getter. Removed some unnecessary type casts and assertions.
- 11:29 PM Changeset in webkit [155749] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceMasker always has an SVGMaskElement.
<https://webkit.org/b/121344>
Reviewed by Brent Fulgham.
This renderer is never anonymous. Tighten things up with a maskElement()
reference getter. Removed some unnecessary null checks and assertions.
- 11:22 PM Changeset in webkit [155748] by
-
- 4 edits in trunk
Pick the correct overload when a const reference is passed to appendSlowCase.
https://bugs.webkit.org/show_bug.cgi?id=121326
Reviewed by Darin Adler.
Source/WTF:
- wtf/Vector.h:
(WTF::Vector::appendSlowCase):
Make sure that the pointer to the element isn't const so we'll pick the right expandCapacity overload.
Tools:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 10:45 PM Changeset in webkit [155747] by
-
- 5 edits in trunk
[Windows] Enable Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=121340
Reviewed by Anders Carlsson.
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props: Activate feature.
- win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
LayoutTests:
- platform/win/TestExpectations: Enable some Page Visibility tests on Windows.
- 10:02 PM Changeset in webkit [155746] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r155719?): http/tests/inspector/network/network-size-chunked.html and
http/tests/inspector/network/network-size-sync.html fail on bots
https://bugs.webkit.org/show_bug.cgi?id=121343
- platform/mac/TestExpectations: Marking these as failing.
- 9:54 PM Changeset in webkit [155745] by
-
- 5 edits in trunk/Source/JavaScriptCore
Rename SpeculativeJIT::integerResult() to int32Result().
Rubber stamped by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithIMul):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::int32Result):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 9:46 PM Changeset in webkit [155744] by
-
- 12 edits1 add in trunk/Source/WebCore
Unreviewed, rolling out r155738.
http://trac.webkit.org/changeset/155738
https://bugs.webkit.org/show_bug.cgi?id=121342
Broke many tests (Requested by ap on #webkit).
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSConsoleCustom.cpp: Added.
(WebCore::JSConsole::profile):
(WebCore::JSConsole::profileEnd):
- bindings/js/ScriptState.h:
- page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
- page/Console.h:
- page/Console.idl:
- 8:58 PM Changeset in webkit [155743] by
-
- 2 edits in trunk/Source/WebCore
CSSPropertyAnimation::ensurePropertyMap() is large
https://bugs.webkit.org/show_bug.cgi?id=121199
Reviewed by Darin Adler.
The bug was caused by repeated calls to Vector::append. Avoid it by storing pointers in a local array
and then adding them as we traverse them through to fill m_propertyToIdMap. Also reserve the full
initial capacity at once to avoid repeated calls to FastMalloc and FastFree.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::instance):
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForProperty):
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForIndex):
(WebCore::CSSPropertyAnimationWrapperMap::indexFromPropertyID):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Renamed from ensurePropertyMap.
Also merged addShorthandProperties into it since they have to access local variables of the other.
- 8:51 PM Changeset in webkit [155742] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix for EFL port.
- editing/efl/EditorEfl.cpp:
- platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::write):
- 8:24 PM Changeset in webkit [155741] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix attempt for WK2 build.
- WebProcess/Plugins/PluginView.cpp: Changed ScriptState to ExecState.
(WebKit::PluginView::performJavaScriptURLRequest):
- 7:01 PM Changeset in webkit [155740] by
-
- 10 edits in trunk/Source/WebCore
Fix a few lingering ScriptStates.
Reviewed by Andy Estes.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
- bindings/cpp/WebNativeNodeFilterCondition.cpp:
(WebNativeNodeFilterCondition::acceptNode):
- bindings/cpp/WebNativeNodeFilterCondition.h:
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::create):
- dom/CustomElementConstructor.h:
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::registerElement):
- dom/CustomElementRegistry.h:
- plugins/PluginView.cpp:
(WebCore::PluginView::performRequest):
- 6:57 PM Changeset in webkit [155739] by
-
- 10 edits in trunk
Rename confusingly named "runtimeObject" functions
https://bugs.webkit.org/show_bug.cgi?id=121339
Source/WebCore:
Also CTTE: HTMLElement.
Reviewed by Sam Weinig.
- bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::putDelegate): Renamed.
(WebCore::JSHTMLAppletElement::getCallData): Renamed.
- bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::putDelegate): Renamed.
(WebCore::JSHTMLEmbedElement::getCallData): Renamed.
- bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::putDelegate): Renamed.
(WebCore::JSHTMLObjectElement::getCallData): Renamed.
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::isPluginElement): Changed to take HTMLElement&.
(WebCore::pluginInstance): Ditto.
(WebCore::pluginScriptObjectFromPluginViewBase): Updated for name and type change.
(WebCore::pluginScriptObject): Ditto.
(WebCore::pluginElementPropertyGetter): Ditto.
(WebCore::pluginElementCustomGetOwnPropertySlot): Ditto.
(WebCore::pluginElementCustomPut): Ditto.
(WebCore::pluginElementGetCallData): Ditto.
- bindings/js/JSPluginElementFunctions.h: Updated names and types.
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
Updated for type change.
- bridge/runtime_method.cpp:
(JSC::callRuntimeMethod): Ditto.
Tools:
Reviewed by Sam Weinig.
- Scripts/do-webcore-rename: Updated to do this replace as usual.
- 6:50 PM Changeset in webkit [155738] by
-
- 12 edits1 delete in trunk/Source/WebCore
There is no need for any custom bindings for Console
https://bugs.webkit.org/show_bug.cgi?id=121338
Reviewed by Joseph Pecoraro.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
Remove JSConsoleCustom.cpp from project files.
- bindings/js/JSConsoleCustom.cpp:
Removed.
- page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
- page/Console.h:
Swap the order of the arguments to appease the bindings generator.
- page/Console.idl:
Add the [CallWith=ScriptState] attribute to pass the ExecState
and [TreatNullAs=NullString, TreatUndefinedAs=NullString] to get
the right stringification.
- 6:37 PM Changeset in webkit [155737] by
-
- 2 edits in trunk/Source/WebCore
Part 2 of Replace ScriptState with JSC::ExecState
https://bugs.webkit.org/show_bug.cgi?id=121336
- dom/Document.h:
There is no WebCore::JSC namespace!
- 6:30 PM Changeset in webkit [155736] by
-
- 83 edits in trunk/Source/WebCore
Replace ScriptState with JSC::ExecState
https://bugs.webkit.org/show_bug.cgi?id=121336
Reviewed by Darin Adler.
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBObjectStore.h:
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/js/JSInjectedScriptManager.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptDebugServer.cpp:
- bindings/js/ScriptDebugServer.h:
- bindings/js/ScriptEventListener.cpp:
- bindings/js/ScriptEventListener.h:
- bindings/js/ScriptFunctionCall.cpp:
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptObject.cpp:
- bindings/js/ScriptObject.h:
- bindings/js/ScriptProfiler.cpp:
- bindings/js/ScriptProfiler.h:
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptState.h:
- bindings/js/ScriptValue.cpp:
- bindings/js/ScriptValue.h:
- bindings/js/SerializedScriptValue.cpp:
- bindings/js/SerializedScriptValue.h:
- dom/Document.cpp:
- dom/Document.h:
- dom/NodeFilter.cpp:
- dom/NodeFilter.h:
- dom/NodeFilterCondition.cpp:
- dom/NodeFilterCondition.h:
- dom/NodeIterator.cpp:
- dom/NodeIterator.h:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- dom/Traversal.cpp:
- dom/Traversal.h:
- dom/TreeWalker.cpp:
- dom/TreeWalker.h:
- inspector/ConsoleMessage.cpp:
- inspector/ConsoleMessage.h:
- inspector/InjectedScript.h:
- inspector/InjectedScriptBase.cpp:
- inspector/InjectedScriptBase.h:
- inspector/InjectedScriptCanvasModule.cpp:
- inspector/InjectedScriptCanvasModule.h:
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptManager.cpp:
- inspector/InjectedScriptManager.h:
- inspector/InjectedScriptModule.cpp:
- inspector/InjectedScriptModule.h:
- inspector/InspectorAgent.cpp:
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorConsoleInstrumentation.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/PageConsoleAgent.cpp:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
- inspector/ScriptArguments.cpp:
- inspector/ScriptArguments.h:
- inspector/ScriptDebugListener.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerRuntimeAgent.cpp:
- page/Console.cpp:
- page/Console.h:
- page/ContentSecurityPolicy.cpp:
- page/ContentSecurityPolicy.h:
- page/PageConsole.cpp:
- page/PageConsole.h:
- workers/WorkerGlobalScope.cpp:
- workers/WorkerGlobalScope.h:
- 5:28 PM Changeset in webkit [155735] by
-
- 5 edits in trunk/Source/JavaScriptCore
FTL JIT broke after r155711
https://bugs.webkit.org/show_bug.cgi?id=121332
Reviewed by Geoffrey Garen.
Fixed OSR entry to use the local variable's index instead of its VirtualRegister.
Initialized ExitArgumentForOperand::m_operand to InvalidVirtualRegister instead of -1.
Fixed compileCallOrConstruct() to update locals on callframe going down.
Fixed prepareOSREntry() to grow stack down if needed.
- ftl/FTLExitArgumentForOperand.h:
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileExtractOSREntryLocal):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- 5:26 PM Changeset in webkit [155734] by
-
- 5 edits in trunk/Source
Avoid a couple of zero-sized fastMalloc calls
https://bugs.webkit.org/show_bug.cgi?id=121333
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- API/JSStringRefCF.cpp:
(JSStringCopyCFString):
Return an empty constant CFStringRef if the JSStringRef is empty.
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
Don't allocate an empty m_jsStrings array if m_jsStringsSize is 0.
Source/WTF:
- wtf/text/StringBuffer.h:
(WTF::StringBuffer::StringBuffer):
Initialize m_data to null if m_length is null, and use Checked<size_t> to check for
overflow when multiplying m_length with the character size.
- 4:56 PM Changeset in webkit [155733] by
-
- 2 edits in trunk/LayoutTests
svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey
https://bugs.webkit.org/show_bug.cgi?id=25817
Reviewed by Tim Horton.
- svg/dom/SVGScriptElement/script-load-and-error-events.svg: Let test 5 finish
before starting test 6.
- 4:35 PM Changeset in webkit [155732] by
-
- 2 edits in trunk/LayoutTests
http/tests/misc/submit-post-keygen.html is extremely slow on bots, often timing out
https://bugs.webkit.org/show_bug.cgi?id=121331
- platform/mac/TestExpectations: Marked the test as sometimes timing out.
- 4:35 PM Changeset in webkit [155731] by
-
- 13 edits in trunk/Source/WebCore
Chrome, DragController and FocusController should hold onto a Page&
https://bugs.webkit.org/show_bug.cgi?id=121325
Reviewed by Anders Carlsson.
- editing/FrameSelection.cpp:
- editing/FrameSelection.h:
- page/Chrome.cpp:
(WebCore::Chrome::Chrome):
(WebCore::Chrome::scroll):
(WebCore::Chrome::createWindow):
(WebCore::canRunModalIfDuringPageDismissal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::mouseDidMoveOverElement):
(WebCore::Chrome::setToolTip):
(WebCore::Chrome::windowScreenDidChange):
- page/Chrome.h:
- page/DragController.cpp:
- page/DragController.h:
- page/mac/DragControllerMac.mm:
- page/FocusController.cpp:
- page/FocusController.h:
- page/Page.cpp:
(WebCore::Page::Page):
- page/PageGroupLoadDeferrer.cpp:
- page/PageGroupLoadDeferrer.h:
Take references where possible.
- 4:18 PM Changeset in webkit [155730] by
-
- 12 edits3 adds in trunk
DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
https://bugs.webkit.org/show_bug.cgi?id=121330
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg and Oliver Hunt.
Also print whether a function is strict mode in debug dumps.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
- bytecode/CodeOrigin.cpp:
(JSC::InlineCallFrame::dumpInContext):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Tools:
Reviewed by Mark Hahnenberg and Oliver Hunt.
We should run tests even if they don't have expected files yet.
- Scripts/run-layout-jsc:
LayoutTests:
Reviewed by Mark Hahnenberg and Oliver Hunt.
- js/dfg-strict-mode-to-this-expected.txt: Added.
- js/dfg-strict-mode-to-this.html: Added.
- js/jsc-test-list:
- js/script-tests/dfg-strict-mode-to-this.js: Added.
(thingy.bar):
(thingy.foo):
(thingy):
- 4:05 PM Changeset in webkit [155729] by
-
- 30 edits in trunk
Use nullptr instead of 0 in calls to HashMap::add
https://bugs.webkit.org/show_bug.cgi?id=121322
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
Source/WebCore:
- bridge/IdentifierRep.cpp:
(WebCore::IdentifierRep::get):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData):
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::getOrCreate):
- dom/Document.cpp:
(WebCore::Document::getCSSCanvasElement):
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
- page/PageGroup.cpp:
(WebCore::PageGroup::pageGroup):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPlugin):
Source/WebKit2:
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::getOrCreate):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::getOrCreate):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::evaluateScriptInIsolatedWorld):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::evaluateScriptInIsolatedWorld):
- 4:00 PM Changeset in webkit [155728] by
-
- 5 edits in trunk/LayoutTests
svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280
Approved in person by Geoff Garen.
Increased the number of nodes in the test 10x to see what happens with the number
of leaked nodes.
- svg/animations/smil-leak-dynamically-added-element-instances.svg:
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
- svg/animations/smil-leak-element-instances.svg:
- svg/animations/smil-leak-elements.svg:
- 3:27 PM Changeset in webkit [155727] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: svg/dom/SVGScriptElement/script-load-and-error-events.svg
https://bugs.webkit.org/show_bug.cgi?id=25817
Reviewed by Tim Horton.
- svg/dom/SVGScriptElement/script-load-and-error-events.svg: Made test output
a bit more verbose to see what's happening on bots.
- 2:38 PM Changeset in webkit [155726] by
-
- 4 edits in trunk/Source/WebKit/mac
[mac WK1] Introduce WebViewWillCloseNotification
https://bugs.webkit.org/show_bug.cgi?id=121321
Reviewed by Sam Weinig.
- WebKit.exp: Exported WebViewWillCloseNotification.
- WebView/WebView.mm:
(-[WebView _close]): Send WebViewWillCloseNotification before closing the WebView.
- WebView/WebViewPrivate.h: Declared WebViewWillCloseNotification.
- 2:32 PM Changeset in webkit [155725] by
-
- 2 edits2 adds in trunk/LayoutTests
Layout Test fast/dom/Window/window-postmessage-clone.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111898
Reviewed by Oliver Hunt.
- fast/dom/Window/script-tests/postmessage-clone.js: The test was checking
modification times of non-existent files. When you do this, you get current time,
and current time changes over time, making comparisons non-reliable.
- fast/dom/Window/resources/file1.txt: Added.
- fast/dom/Window/resources/file2.txt: Added.
- 2:19 PM Changeset in webkit [155724] by
-
- 15 edits in trunk
Try to kill initialiser expression in for-in statements
https://bugs.webkit.org/show_bug.cgi?id=121311
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
We'd like to get rid of this pointless initialiser expression
in for-in statements. Unfortunately we have to keep the no_in
variant of expression parsing to avoid ambiguity in the grammar.
There's a possibility that this will need to be rolled out, but
we'll need to live on it to see.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createForInLoop):
- parser/NodeConstructors.h:
(JSC::ForInNode::ForInNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::::parseForStatement):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForInLoop):
LayoutTests:
Update test cases to represent the new reality
- js/line-column-numbers-expected.txt:
- js/line-column-numbers.html:
- js/parser-syntax-check-expected.txt:
- js/script-tests/function-declaration-statement.js:
- js/script-tests/line-column-numbers.js:
(try.toFuzz22b):
- js/script-tests/parser-syntax-check.js:
- js/script-tests/toString-for-var-decl.js:
(f1):
- 2:12 PM Changeset in webkit [155723] by
-
- 4 edits in trunk/Source/WebCore
ContextMenuController should hold onto a Page&
https://bugs.webkit.org/show_bug.cgi?id=121320
Reviewed by Anders Carlsson.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController):
(WebCore::ContextMenuController::~ContextMenuController):
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
(WebCore::ContextMenuController::showContextMenuAt):
- page/ContextMenuController.h:
Store the Page and ContextMenuClient as references.
- page/Page.cpp:
(WebCore::Page::Page):
Pass the Page and ContextMenuClient as references and switch to using createOwned<>().
- 2:11 PM Changeset in webkit [155722] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed; part one of build fix for Windows.
Sorry for the noise, I thought I'd fixed it.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 1:52 PM Changeset in webkit [155721] by
-
- 11 edits in trunk/Source/WebCore
Apply OVERRIDE and FINAL to Image subclasses and clean them up
https://bugs.webkit.org/show_bug.cgi?id=121086
Reviewed by Alexey Proskuryakov.
Everything other than the copious application of OVERRIDE and FINAL
is explicitly called out below.
- WebCore.exp.in:
Export the correct version of getCGImageRef for use by WebKit2.
- platform/graphics/BitmapImage.cpp:
- platform/graphics/BitmapImage.h:
Drive-by inline isBitmapImage.
Move create(HBITMAP) to be near the other create() functions.
Move all of the members private.
Devirtualize frameCount().
Move notSolidColor() near the other solid color functions.
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
Use size() and setContainerSize() instead of directly accessing a
superclass' (now private, previously protected) members.
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GeneratedImage.h:
Make m_size private, I don't think we do protected members.
- platform/graphics/GeneratorGeneratedImage.h:
Make all the members private.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.h:
- 1:41 PM Changeset in webkit [155720] by
-
- 4 edits in trunk/LayoutTests
Flaky Test: http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
https://bugs.webkit.org/show_bug.cgi?id=114209
Reviewed by Joseph Pecoraro.
- TestExpectations: Marked the test as WontFix. It is hopelessly broken, and
doesn't test anything specific anyway.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Removed from the lists, as the test is now skipped globally.
- 1:40 PM Changeset in webkit [155719] by
-
- 2 edits in trunk/Source/WebCore
[Mac] WebCore Web Inspector files are only copied as part of clean build
https://bugs.webkit.org/show_bug.cgi?id=121316
Reviewed by Timothy Hatcher.
Removed insufficient dependencies to make the phase run unconditionally.
- WebCore.xcodeproj/project.pbxproj:
- 1:37 PM Changeset in webkit [155718] by
-
- 5 edits in trunk/Source/WebCore
CodeGeneratorJS doesn't generate header includes for sequence<type>
https://bugs.webkit.org/show_bug.cgi?id=121314
Reviewed by Dean Jackson.
- bindings/scripts/CodeGeneratorJS.pm:
(SkipIncludeHeader): Don't return false for sequence and array types.
(AddIncludesForType): Do add includes for sequence and array types.
(GenerateCallbackImplementation):
- bindings/scripts/test/JS/JSTestTypedefs.cpp: Regenerated
- bindings/scripts/test/JS/JSTestTypedefs.h: Ditto.
- bindings/scripts/test/TestTypedefs.idl: Add a method that takes a sequence<TestEventTarget>.
- 12:41 PM Changeset in webkit [155717] by
-
- 2 edits in trunk/Source/WTF
[Windows] Activate FastMalloc hardening
https://bugs.webkit.org/show_bug.cgi?id=121307
Reviewed by Oliver Hunt.
- wtf/FastMalloc.cpp:
(WTF::SLL_Next): Add workaround for MSVC compiler bug.
- 12:31 PM Changeset in webkit [155716] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourcePattern always has an SVGPatternElement.
<https://webkit.org/b/121313>
Reviewed by Anders Carlsson.
This renderer is never anonymous. Tighten things up with a patternElement()
reference getter. Removed some unnecessary null checks and assertions.
- 12:09 PM Changeset in webkit [155715] by
-
- 11 edits in trunk/Source/WebCore
Remove layering-violating Pasteboard::plainText function (for all platforms now)
https://bugs.webkit.org/show_bug.cgi?id=121312
Reviewed by Antti Koivisto.
- editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainTextWithPasteboard): Call readPlainTextFromPasteboard
on all platforms, not just Mac and EFL. Also call canSmartReplaceWithPasteboard with
a reference instead of a pointer.
(WebCore::Editor::readPlainTextFromPasteboard): Added. This is a cross-platform
version of what was previously a Mac-only function.
(WebCore::Editor::plainTextFromPasteboard): Added. This is the simple non-Mac version
of this function.
(WebCore::Editor::pasteWithPasteboard): Updated to call canSmartReplaceWithPasteboard
with a reference.
(WebCore::Editor::canSmartReplaceWithPasteboard): Updated to take a reference.
- editing/Editor.h: Make readPlainTextFromPasteboard cross-platform instead of
Mac-only. Also changed argument to canSmartReplaceWithPasteboard to be a reference.
Also added private plainTextFromPasteboard function.
- editing/mac/EditorMac.mm:
(WebCore::Editor::pasteWithPasteboard): Updated to call canSmartReplaceWithPasteboard
with a reference.
(WebCore::Editor::plainTextFromPasteboard): Added. Contains the Mac-specific parts
of the readPlainTextFromPasteboard function.
- platform/Pasteboard.h: Fixed a conditional in the PasteboardPlainText struct to
omit iOS. Removed the layering-voiolating plainText function.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::read): Renamed from plainText and updated to new calling
convention.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read): Ditto.
- platform/nix/PasteboardNix.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::read): Ditto.
- 12:06 PM Changeset in webkit [155714] by
-
- 30 edits1 add in trunk
[GTK] Move to the new web inspector
https://bugs.webkit.org/show_bug.cgi?id=120647
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-13
Reviewed by Carlos Garcia Campos.
.:
- GNUmakefile.am: include the new WebInspectorUI GNUmakefile.am.
Source/WebCore:
No tests for the new inspector UI as of yet.
- GNUmakefile.am: no longer install the deprecated inspector UI files.
- WebCore.exp.in: add SchemeRegistry symbol that is now used.
Source/WebInspectorUI:
- GNUmakefile.am: Added. Generate the GResource source and link it into libWebCore.
Source/WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend): update paths to the internal resource ones.
(WebKit::InspectorClient::inspectorFilesPath): ditto.
- tests/testwebinspector.c:
(consoleMessageCallback): the new inspector currently emits an error when loading, so add it to
the list of messages which are not considered failures.
- webkit/webkitglobals.cpp:
(webkitInit): register resource as a local scheme; currently used by the inspector.
Source/WebKit2:
- GNUmakefile.am: bundle the remote inspector page list HTML into libwebkit2gtk as a GResource.
- UIProcess/API/gtk/tests/GNUmakefile.am: no need to set WEBKIT_INSPECTOR_PATH anymore.
- UIProcess/API/gtk/tests/InspectorTestServer.cpp:
(main): ditto.
- UIProcess/API/gtk/tests/TestInspector.cpp:
(beforeAll): ditto.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList): update paths to the internal resource ones.
- UIProcess/InspectorServer/WebInspectorServer.h:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath): ditto.
(WebKit::WebInspectorServer::buildPageList): ditto.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::isMainInspectorPage): factor out checking for the inspector main resource, to make
the code more readable.
(WebKit::decidePolicyForNavigationAction): use SchemeRegistry to figure out whether the
request is for a local resource instead of KURL::isLocalFile() to allow using schemes
other than file:// for the inspector resources.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL): use the new internal resource URL; since it's now
static we no longer need to generate and store the string.
(WebKit::WebInspectorProxy::inspectorBaseURL): ditto.
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL): use the new internal resource URL.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): register resource as a local scheme.
Tools:
- GtkLauncher/main.c:
(main): no longer set WEBKIT_INSPECTOR_PATH.
- MiniBrowser/gtk/main.c:
(main): ditto.
- Scripts/old-run-webkit-tests:
(openDumpTool): ditto.
- Scripts/run-gtk-tests: ditto.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): ditto.
LayoutTests:
- platform/gtk/TestExpectations: the new inspector UI does not support the current
inspector testing harness so keep it skipped, a new one will eventually be landed.
- 11:22 AM Changeset in webkit [155713] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Qt build.
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::write): Update variable name at one place I missed.
- 11:10 AM Changeset in webkit [155712] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Scrolling and zooming is slow when Flash plugin visible
https://bugs.webkit.org/show_bug.cgi?id=120618
Reviewed by Anders Carlsson.
Internally reviewed by Jacky Jiang.
JIRA 490823
Compositing Flash plugin content triggered a workaround for a graphics
driver quirk. The workaround was actually related to WebGL, not Flash,
back when we used glCopyTexImage to implement WebGL double buffering
(see PR 148933 and 150228 for more details of the old implementation).
Originally, both WebGL and plugin layers added themselves to the
LayerRenderer::m_layersLockingTextureResources list. Now only plugin
layers use this list.
The glCopyTexImage code was removed long ago, and WebGL now uses the
EGLImage-based double buffering approach implemented in
EGLImageLayerWebKitThread and EGLImageLayerCompositingThreadClient.
Fixed by removing the now obsolete workaround, a call to "glFinish".
This considerably improves the frame rate of zooming and scrolling when
Flash content is visible.
Improvement in frame rate not appropriate to test using layout tests,
could easily result in flaky test.
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
- 11:03 AM Changeset in webkit [155711] by
-
- 57 edits in trunk/Source/JavaScriptCore
fourthTier: Change JSStack to grow from high to low addresses
https://bugs.webkit.org/show_bug.cgi?id=118758
Reviewed by Oliver Hunt.
Changed the JSC stack to grow down. Effectively the JSC stack frame is flipped from
what it was. See JSStack.h for the new offsets. Changed JSStack begin() and end()
to be getBaseOfStack() and getLimitOfStack(). Most of the changes are address or offset
calculation changes. Decoupled a local register ordinal (loop variable or array index)
from the offset into the callFrame using localToOperand() and the inverse operandToLocal().
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::trustedImm32ForShift):
(JSC::MacroAssembler::lshiftPtr): Added to create scaled addresses with a negative index
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::lshift64): Added to create scaled addresses with a negative index
- assembler/X86Assembler.h:
(JSC::X86Assembler::shlq_i8r): Added to create scaled addresses with a negative index
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/CodeBlock.h:
(JSC::unmodifiedArgumentsRegister):
(JSC::CodeBlock::isCaptured):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::stackOffset):
- bytecode/Operands.h:
(JSC::localToOperand):
(JSC::operandIsLocal):
(JSC::operandToLocal):
(JSC::operandIsArgument):
(JSC::operandToArgument):
(JSC::argumentToOperand):
- bytecode/VirtualRegister.h: Made InvalidVirtualRegister a positive value that fits in
31 bits since it can be placed into the 31 bit field "stackOffset" in struct InlineCallFrame.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::newRegister):
(JSC::BytecodeGenerator::emitNewArray):
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::allocate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callFrameSlot):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::callFrameTagSlot):
(JSC::DFG::SpeculativeJIT::callFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::reportValidationContext):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddSpan):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
- interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::argumentOffset):
(JSC::ExecState::argumentOffsetIncludingThis):
(JSC::ExecState::argIndexForRegister):
- interpreter/Interpreter.cpp:
(JSC::loadVarargs):
(JSC::Interpreter::dumpRegisters):
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::~JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::disableErrorStackReserve):
- interpreter/JSStack.h:
(JSC::JSStack::getBaseOfStack):
(JSC::JSStack::getLimitOfStack):
(JSC::JSStack::size):
(JSC::JSStack::end):
(JSC::JSStack::containsAddress):
(JSC::JSStack::lowAddress):
(JSC::JSStack::highAddress):
(JSC::JSStack::reservationEnd):
(JSC::JSStack::shrink):
(JSC::JSStack::grow):
- interpreter/JSStackInlines.h:
(JSC::JSStack::getTopOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
(JSC::JSStack::installTrapsAfterFrame):
- interpreter/StackVisitor.cpp:
(JSC::inlinedFrameOffset):
(JSC::StackVisitor::readInlinedFrame):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITStubs.cpp:
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
- jit/ThunkGenerators.cpp:
(JSC::arityFixup):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::genericCall):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
(JSC::MarkedArgumentBuffer::slowAppend):
- runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::MarkedArgumentBuffer):
(JSC::MarkedArgumentBuffer::slotFor):
(JSC::MarkedArgumentBuffer::mallocBase):
(JSC::ArgList::at):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/JSActivation.h:
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isValidIndex):
- runtime/JSArray.h:
(JSC::constructArrayNegativeIndexed): New method to create an array from registers that grow down.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::globalExec):
- runtime/JSGlobalObject.h:
(JSC::constructArrayNegativeIndexed):
- runtime/JSString.h:
- runtime/Operations.h:
(JSC::jsStringFromRegisterArray):
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::captureCount):
- 10:59 AM Changeset in webkit [155710] by
-
- 6 edits1 add in trunk/Source/WebCore
Move LineLayoutState class to LineLayoutState.h
https://bugs.webkit.org/show_bug.cgi?id=121263
Reviewed by Ryosuke Niwa.
I added bitfields, reordered the members and a functions too.
No new tests, no behavior change.
- rendering/LineLayoutState.h: Added.
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::markForFullLayout):
(WebCore::LineLayoutState::isFullLayout):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::LineLayoutState::endLineMatched):
(WebCore::LineLayoutState::setEndLineMatched):
(WebCore::LineLayoutState::checkForFloatsFromLastLine):
(WebCore::LineLayoutState::setCheckForFloatsFromLastLine):
(WebCore::LineLayoutState::lineInfo):
(WebCore::LineLayoutState::endLineLogicalTop):
(WebCore::LineLayoutState::setEndLineLogicalTop):
(WebCore::LineLayoutState::endLine):
(WebCore::LineLayoutState::setEndLine):
(WebCore::LineLayoutState::lastFloat):
(WebCore::LineLayoutState::setLastFloat):
(WebCore::LineLayoutState::floats):
(WebCore::LineLayoutState::floatIndex):
(WebCore::LineLayoutState::setFloatIndex):
(WebCore::LineLayoutState::adjustedLogicalLineTop):
(WebCore::LineLayoutState::setAdjustedLogicalLineTop):
(WebCore::LineLayoutState::flowThread):
(WebCore::LineLayoutState::setFlowThread):
- rendering/RenderBlockLineLayout.cpp: Remove LineLayoutState.
- 10:46 AM Changeset in webkit [155709] by
-
- 12 edits in trunk/Source/WebCore
Remove layering-violating Pasteboard::writeURL (for all platforms now)
https://bugs.webkit.org/show_bug.cgi?id=121306
Reviewed by Antti Koivisto.
- editing/Editor.cpp:
(WebCore::Editor::copyURL): Move the contents of the writeURLToPasteboard function
in here.
- editing/Editor.h: Removed Mac-specific writeURLToPasteboard, added private
Mac-specific fillInUserVisibleForm function for the one Mac-specific part of writing URLs.
- editing/efl/EditorEfl.cpp: Deleted Editor::writeURLToPasteboard.
- editing/mac/EditorMac.mm: Deleted Editor::writeURLToPasteboard, moving the code
into copyURL.
(WebCore::Editor::fillInUserVisibleForm): Added.
- page/DragController.cpp:
(WebCore::DragController::startDrag): Call copyURL instead of writeURL or
writeURLToPasteboard.
- platform/Pasteboard.h: Fixed up the PasteboardURL struct so it's suitable for
cross-platform use. Removed the writeURL function. Removed the Frame* argument from
the Windows-specific writeURLToDataObject function.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::write): Renamed/refactored from writeURL.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/nix/PasteboardNix.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Removed unused Frame* argument.
(WebCore::Pasteboard::write): Renamed/refactored from writeURL.
- 10:32 AM Changeset in webkit [155708] by
-
- 4 edits2 adds in trunk
AX: AXPress does not work in SVG
https://bugs.webkit.org/show_bug.cgi?id=121248
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Implement accessKeyAction() on SVGElements, which is what accessibility code
uses in order to activate Elements.
Test: accessibility/svg-element-press.html
- svg/SVGElement.cpp:
(WebCore::SVGElement::accessKeyAction):
- svg/SVGElement.h:
LayoutTests:
- accessibility/svg-element-press-expected.txt: Added.
- accessibility/svg-element-press.html: Added.
- 9:54 AM Changeset in webkit [155707] by
-
- 8 edits in trunk/Source/WebCore
[CTTE] RenderSVGTransformableContainer is never anonymous.
<https://webkit.org/b/121304>
Reviewed by Anders Carlsson.
This renderer is never anonymous. Tighten things up with a graphicsElement()
reference getter.
- 8:56 AM Changeset in webkit [155706] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGImage always has a SVGImageElement.
<https://webkit.org/b/121301>
Reviewed by Anders Carlsson.
This renderer is never anonymous, and always has a corresponding SVGImageElement.
- 8:55 AM Changeset in webkit [155705] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM EABI hardfp buildfix after r155675
https://bugs.webkit.org/show_bug.cgi?id=121287
Reviewed by Geoffrey Garen.
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- 8:54 AM Changeset in webkit [155704] by
-
- 16 edits in trunk/Source/WebCore
[CTTE] Tighter element types for RenderSVGShape and subclasses.
<https://webkit.org/b/121302>
Reviewed by Antti Koivisto.
Codify the following:
- RenderSVGPath always has an SVGGraphicsElement.
- RenderSVGEllipse always has an SVGGraphicsElement.
- RenderSVGRect always has an SVGRectElement.
- RenderSVGShape always has an SVGGraphicsElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 8:53 AM Changeset in webkit [155703] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGResourceFilterPrimitive always has an SVGFilterPrimitiveStandardAttributes.
<https://webkit.org/b/121300>
Reviewed by Anders Carlsson.
This renderer is never anonymous, and always has a corresponding SVGFilterPrimitiveStandardAttributes element.
- 8:40 AM Changeset in webkit [155702] by
-
- 2 edits in trunk/Source/WebKit2
Fix build with namespaced Qt.
Unreviewed build fix.
One forward declaration of QUrl was missing proper namespace macros.
- UIProcess/API/qt/qquickurlschemedelegate_p.h:
- 8:25 AM Changeset in webkit [155701] by
-
- 2 edits in trunk/Source/WTF
OwnArrayPtr: Never allow implicit pointer conversion
https://bugs.webkit.org/show_bug.cgi?id=121291
Reviewed by Anders Carlsson.
We should never allow implicit pointer conversion in OwnArrayPtr
and remove its template copy constructor & template assignment operator, as:
- these methods are never used
- these methods are inappropriate to have in OwnArrayPtr as arrays do not interact well with polymorphism.
- wtf/OwnArrayPtr.h:
- 8:25 AM Changeset in webkit [155700] by
-
- 6 edits in trunk/Source/WebCore
Finish removing layer-violating code from Pasteboard (just for Mac during this first step)
https://bugs.webkit.org/show_bug.cgi?id=121279
Reviewed by Anders Carlsson.
- editing/Editor.h: Added webContentFromPasteboard member function, private nested class
WebContentReader, private createFragmentForImageResourceAndAddResource and
createFragmentAndAddResources member functions.
- editing/mac/EditorMac.mm: Re-sorted includes and added some.
(WebCore::Editor::pasteWithPasteboard): Call the new webContentFromPasteboard function.
(WebCore::Editor::insertParagraphSeparatorInQuotedContent): Comment tweak.
(WebCore::styleForSelectionStart): Removed an unneeded call to String::impl.
(WebCore::Editor::readPlainTextFromPasteboard): Updated to use an isURL boolean instead
of a separate string named "url".
(WebCore::Editor::WebContentReader::readWebArchive): Added. Contains reworked code that
was originally in Pasteboard::documentFragment.
(WebCore::Editor::WebContentReader::readFilenames): Ditto.
(WebCore::Editor::WebContentReader::readHTML): Ditto.
(WebCore::Editor::WebContentReader::readRTFD): Ditto.
(WebCore::Editor::WebContentReader::readRTF): Ditto.
(WebCore::Editor::WebContentReader::readImage): Ditto.
(WebCore::Editor::WebContentReader::readURL): Ditto.
(WebCore::Editor::WebContentReader::readPlainText): Ditto.
(WebCore::Editor::webContentFromPasteboard): Added. Uses WebContentReader to read the
content from the pasteboard.
(WebCore::Editor::createFragmentForImageResourceAndAddResource): Added. Helper used
by code above.
(WebCore::Editor::createFragmentAndAddResources): Ditto.
- platform/Pasteboard.h: Added new PasteboardWebContentReader abstract class so
client can get the various types of pasteboard content and stop on the kind it
can handle. Improved comments and formatting a bit. Removed documentFragment
when compiling for PLATFORM(MAC).
- platform/mac/DragDataMac.mm:
(WebCore::DragData::asFragment): Changed to use Editor::webContentFromPasteboard.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::read): Updated the plain text overload of this for changes
to the struct that holds the result. Added a new web content overload of this,
which retains the pasteboard-reading part of Pasteboard::documentFragment, but
omits the document fragment construction part.
- 8:15 AM Changeset in webkit [155699] by
-
- 4 edits in trunk
[Qt] REGRESSION(r154444): xss-DENIED test results changed
https://bugs.webkit.org/show_bug.cgi?id=120595
Reviewed by Jocelyn Turcotte.
Tools:
Avoid overwriting Qt meta properties, which we identify by them being undeletable.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::initJSObjects):
LayoutTests:
- platform/qt/TestExpectations:
- 8:01 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:50 AM Changeset in webkit [155698] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGText always has a SVGTextElement.
<https://webkit.org/b/121299>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless assertions.
- 7:34 AM Changeset in webkit [155697] by
-
- 13 edits1 delete in trunk/Source
Remove support for QXmlStream as the XML parser.
https://bugs.webkit.org/show_bug.cgi?id=121229
Reviewed by Andreas Kling.
Source/WebCore:
Remove the implementation and all the #ifdef related to it.
- Target.pri:
- WebCore.pri:
- dom/TransformSource.h:
- xml/XMLErrors.h:
- xml/XSLStyleSheet.h:
- xml/XSLTProcessor.h:
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::enterText):
(WebCore::toString):
(WebCore::XMLDocumentParser::exitText):
(WebCore::XMLDocumentParser::insertErrorMessageBlock):
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserQt.cpp: Removed.
Source/WebKit/blackberry:
Removed USE flags.
- WebCoreSupport/AboutDataUseFeatures.in:
Source/WTF:
Removed USE flags.
- wtf/Platform.h:
- 7:07 AM Changeset in webkit [155696] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGViewportContainer always has a SVGSVGElement.
<https://webkit.org/b/121297>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless null checks and type checks.
- 6:42 AM Changeset in webkit [155695] by
-
- 5 edits in trunk/LayoutTests
One more Unreviewed fix after r155675.
- js/array-with-double-assign-expected.txt:
- js/array-with-double-assign.html: Path fixed.
- js/array-with-double-push-expected.txt:
- js/array-with-double-push.html: Path fixed.
- 6:09 AM Changeset in webkit [155694] by
-
- 2 edits in trunk
[Qt] Update sync.profile
https://bugs.webkit.org/show_bug.cgi?id=121295
Reviewed by Simon Hausmann.
Ensure we let the dependencies pick the right branch instead of always master
and list all the dependencies we need on all platforms.
- Source/sync.profile:
- 6:06 AM Changeset in webkit [155693] by
-
- 1 edit6 moves in trunk/LayoutTests
Unreviewed fix after r155675. Move new tests from fast/js to js.
- js/array-with-double-assign-expected.txt: Renamed from LayoutTests/fast/js/array-with-double-assign-expected.txt.
- js/array-with-double-assign.html: Renamed from LayoutTests/fast/js/array-with-double-assign.html.
- js/array-with-double-push-expected.txt: Renamed from LayoutTests/fast/js/array-with-double-push-expected.txt.
- js/array-with-double-push.html: Renamed from LayoutTests/fast/js/array-with-double-push.html.
- js/script-tests/array-with-double-assign.js: Renamed from LayoutTests/fast/js/script-tests/array-with-double-assign.js.
(foo):
- js/script-tests/array-with-double-push.js: Renamed from LayoutTests/fast/js/script-tests/array-with-double-push.js.
(foo):
- 5:57 AM Changeset in webkit [155692] by
-
- 5 edits5 deletes in trunk/LayoutTests
[Qt] unreviewed gardening. Rebaseline after r155253.
- platform/qt-wk2/editing/selection/caret-rtl-2-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-2-left-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-right-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-right-expected.txt: Removed.
- platform/qt/editing/selection/caret-rtl-2-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
- platform/qt/editing/selection/caret-rtl-expected.txt:
- platform/qt/editing/selection/caret-rtl-right-expected.txt:
- 5:32 AM Changeset in webkit [155691] by
-
- 15 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaseline tests after r155408.
- platform/qt/fast/forms/control-restrict-line-height-expected.png:
- platform/qt/fast/forms/control-restrict-line-height-expected.txt:
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/qt/fast/forms/placeholder-position-expected.png:
- platform/qt/fast/forms/placeholder-position-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 5:24 AM Changeset in webkit [155690] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGRoot always has a SVGSVGElement.
<https://webkit.org/b/121293>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless null checks and assertions.
- 5:22 AM Changeset in webkit [155689] by
-
- 5 edits in trunk/Source/WebCore
Remove support for anonymous deprecated flexboxes.
<https://webkit.org/b/121288>
Reviewed by Antti Koivisto.
There are no remaining internal clients of RenderDeprecatedFlexibleBox,
Nuke a FIXME from r143643 where the move to basing renderers on new flexbox started.
This was the only user of anonymous deprecated flexbox, so removed the ability to
construct those.
Also removed some Chrome-related feature observation gunk from constructor.
- 5:21 AM Changeset in webkit [155688] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderMultiColumnBlock is never anonymous.
<https://webkit.org/b/121292>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 5:20 AM Changeset in webkit [155687] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderGrid is never anonymous.
<https://webkit.org/b/121290>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 5:18 AM Changeset in webkit [155686] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderTableCaption is never anonymous.
<https://webkit.org/b/121289>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 4:16 AM Changeset in webkit [155685] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderTableCol is never anonymous.
<https://webkit.org/b/121286>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
Removed one bogus null check that was exposed.
- 4:15 AM Changeset in webkit [155684] by
-
- 5 edits in trunk/Source/WebCore
[CTTE] RenderListItem is never anonymous.
<https://webkit.org/b/121285>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
Removed some bogus assertions that were exposed by this.
- 3:08 AM Changeset in webkit [155683] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION (r155615): Lots of reftests fail with single line or single pixel differences
https://bugs.webkit.org/show_bug.cgi?id=121245
Reviewed by Darin Adler.
Similar to https://bugs.webkit.org/show_bug.cgi?id=120963,
we need to manually ensure that some pieces of persistent
CoreGraphics state are restored after PDFKit changes them.
In this case, we bookend our restoration around the various
_recursiveDisplay... functions that we also use in WebHTMLView.
- WebView/WebPDFView.mm:
(-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
(-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
(-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
(-[WebPDFView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
- 2:48 AM Changeset in webkit [155682] by
-
- 18 edits1 delete in trunk/Source/WebCore
[CTTE] Tighter element types for RenderSVGInline and subclasses.
<https://webkit.org/b/121283>
Reviewed by Antti Koivisto.
Codify the following:
- RenderSVGInline always has an SVGGraphicsElement.
- RenderSVGTextPath always has an SVGTextPathElement.
- RenderSVGTSpan always has an SVGTextPositioningElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 2:43 AM Changeset in webkit [155681] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderFileUploadControl always has a HTMLInputElement.
<https://webkit.org/b/121278>
Reviewed by Darin Adler.
RenderFileUploadControl is never anonymous and always has a corresponding HTMLInputElement.
- 2:40 AM Changeset in webkit [155680] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderFieldset always has a HTMLFieldSetElement.
<https://webkit.org/b/121277>
Reviewed by Darin Adler.
RenderFieldset is never anonymous and always has a corresponding HTMLFieldSetElement.
- 2:38 AM Changeset in webkit [155679] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
https://bugs.webkit.org/show_bug.cgi?id=120848.
- platform/qt/TestExpectations:
- 2:00 AM Changeset in webkit [155678] by
-
- 5 edits in trunk/Source/WebCore
[CTTE] RenderButton always has a HTMLFormControlElement.
<https://webkit.org/b/121281>
Reviewed by Antti Koivisto.
RenderButton is never anonymous and has either a <button> or an <input> element,
and their nearest shared ancestor is HTMLFormControlElement.
- 1:16 AM Changeset in webkit [155677] by
-
- 2 edits in trunk/Source/WebKit/gtk
download-requested arg should be WEBKIT_TYPE_DOWNLOAD not G_TYPE_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=57634
Reviewed by Darin Adler.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
- 1:16 AM Changeset in webkit [155676] by
-
- 5 edits in trunk
Give actions in Range class NON_SHOUTING_NAMES
https://bugs.webkit.org/show_bug.cgi?id=121280
Reviewed by Andreas Kling.
Source/WebCore:
- dom/Range.cpp:
(WebCore::Range::deleteContents):
(WebCore::Range::processContents):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::processNodes):
(WebCore::Range::processAncestorsAndTheirSiblings):
(WebCore::Range::extractContents):
(WebCore::Range::cloneContents):
- dom/Range.h:
Just let do-webcore-rename do its thing.
- DELETE_CONTENTS -> Delete
- EXTRACT_CONTENTS -> Extract
- CLONE_CONTENTS -> Clone
Tools:
- Scripts/do-webcore-rename: Updated to do this replace, keeping with
the tradition of checking in the last one we did, along with other
rename ideas for the future.
- 12:34 AM Changeset in webkit [155675] by
-
- 4 edits8 adds in trunk
Fixed crash in V8 benchmark suite in ARM,softp,EABI environment.
https://bugs.webkit.org/show_bug.cgi?id=117281
Patch by Youngho Yoo <youngho33.yoo@lge.com> on 2013-09-13
Reviewed by Michael Saboff.
Fix the missing EABI_32BIT_DUMMY_ARG in FPRReg using callOperation function.
Source/JavaScriptCore:
Test 1 : fast/js/array-with-double-assign.html
Test 2 : fast/js/array-with-double-push.html
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
LayoutTests:
- fast/js/array-with-double-assign-expected.txt: Added.
- fast/js/array-with-double-assign.html: Added.
- fast/js/array-with-double-push-expected.txt: Added.
- fast/js/array-with-double-push.html: Added.
- fast/js/script-tests/array-with-double-assign.js: Added.
(foo):
- fast/js/script-tests/array-with-double-push.js: Added.
(foo):
