Context Navigation

← Previous Period
Next Period →

Timeline

Sep 17, 2013:

11:51 PM Changeset in webkit [156027] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

[GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml
https://bugs.webkit.org/show_bug.cgi?id=121405

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-09-17
Reviewed by Carlos Garcia Campos.

GNUmakefile.am: if srcdir == builddir the WebInspectorUI variable that is used both to list

the dependencies of the GResourceBundle and to normalize the paths added to the XML through sed
replacement will end up starting with ./, which would be fine if automake did not remove that
from the paths in the target's dependency. We deal with that by normalizing the path we use to
take that quirk into account.

11:39 PM Changeset in webkit [156026] by ryumiel@company100.net

2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

11:30 PM Changeset in webkit [156025] by Antti Koivisto

9 edits in trunk/Source/WebCore

Rename InlineBox::isText()
<https://webkit.org/b/121525>

Reviewed by Andreas Kling.

The flag sounds like RenderObject::isText() yet it can be set for some inline boxes generated
for non-text renderers too (br, list markers). This is pretty confusing.

Rename to InlineBox::behavesLikeText().

rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

rendering/InlineBox.h:

(WebCore::InlineBox::behavesLikeText):
(WebCore::InlineBox::setBehavesLikeText):
(WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields):

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):

rendering/RenderBlockLineLayout.cpp:

(WebCore::createInlineBoxForRenderer):
(WebCore::setLogicalWidthForTextRun):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::createInlineBox):

rendering/RenderText.cpp:

(WebCore::RenderText::createInlineTextBox):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):

Switch tests from isText() to isTextOrBR(). This matches the behavior before r155957.
I don't know if there is a case where this actually makes any difference in behavior.

11:05 PM Changeset in webkit [156024] by weinig@apple.com

3 edits in trunk/Source/WebCore

Shrink SVGPathStringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121536

Reviewed by Anders Carlsson.

Use StringBuilder everywhere to avoid unnecessary temporary String objects and code size bloat.
Also did a drive by FINAL / OVERRIDE pass.

As an example of the win, the function SVGPathStringBuilder::arcTo
went from being 6120 bytes down to just 378 bytes.

svg/SVGPathStringBuilder.cpp:

(WebCore::SVGPathStringBuilder::SVGPathStringBuilder):
(WebCore::SVGPathStringBuilder::~SVGPathStringBuilder):
(WebCore::SVGPathStringBuilder::cleanup):
(WebCore::SVGPathStringBuilder::incrementPathSegmentCount):
(WebCore::SVGPathStringBuilder::continueConsuming):
It wasn't helpful for these to be inlined, so move them to
the implementation file.

(WebCore::appendFlag):
(WebCore::appendNumber):
(WebCore::appendPoint):
Added helpers.

(WebCore::SVGPathStringBuilder::moveTo):
(WebCore::SVGPathStringBuilder::lineTo):
(WebCore::SVGPathStringBuilder::lineToHorizontal):
(WebCore::SVGPathStringBuilder::lineToVertical):
(WebCore::SVGPathStringBuilder::curveToCubic):
(WebCore::SVGPathStringBuilder::curveToCubicSmooth):
(WebCore::SVGPathStringBuilder::curveToQuadratic):
(WebCore::SVGPathStringBuilder::curveToQuadraticSmooth):
(WebCore::SVGPathStringBuilder::arcTo):
(WebCore::SVGPathStringBuilder::closePath):

svg/SVGPathStringBuilder.h:

Stopped using operator+ and removed duplicate string building logic in each build
type (e.g. both sides of the PathCoordinateMode condition were doing almost identical
work).

10:00 PM Changeset in webkit [156023] by weinig@apple.com

14 edits in trunk/Source/WebCore

CTTE: Convert some straggling Element subclasses constructors to take a Document&
https://bugs.webkit.org/show_bug.cgi?id=121533

Reviewed by Anders Carlsson.

html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::didAddUserAgentShadowRoot):

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::didAddUserAgentShadowRoot):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot):

html/SearchInputType.cpp:

(WebCore::SearchInputType::createShadowSubtree):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::MeterShadowElement):
(WebCore::MeterInnerElement::MeterInnerElement):

html/shadow/MeterShadowElement.h:

(WebCore::MeterInnerElement::create):
(WebCore::MeterBarElement::create):
(WebCore::MeterValueElement::create):

html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressShadowElement::ProgressShadowElement):
(WebCore::ProgressInnerElement::ProgressInnerElement):
(WebCore::ProgressBarElement::ProgressBarElement):
(WebCore::ProgressValueElement::ProgressValueElement):

html/shadow/ProgressShadowElement.h:

(WebCore::ProgressInnerElement::create):
(WebCore::ProgressBarElement::create):
(WebCore::ProgressValueElement::create):

html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::create):

html/shadow/SpinButtonElement.h:
html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerContainer::TextControlInnerContainer):
(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::create):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::create):
(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
(WebCore::SearchFieldResultsButtonElement::create):
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::SearchFieldCancelButtonElement::create):
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
(WebCore::InputFieldSpeechButtonElement::create):

html/shadow/TextControlInnerElements.h:

8:27 PM Changeset in webkit [156022] by zoltan@webkit.org

12 edits
8 adds in trunk

[CSS Shapes] Use the float height to determine position in shape-inside
https://bugs.webkit.org/show_bug.cgi?id=102846

Reviewed by Darin Adler.

Float positioning inside shape-inside has been working only for simple cases when the float boundaries didn't overlap with the shape.
This patch fixes the behavior for left floats and shapes with inline content. I want to add this work step by step, therefore the next
step would be to add support for block content with inline content (e.g. paragraphs) then cover cases with right floats.

Source/WebCore:

Tests: fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html

fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html

rendering/LineWidth.cpp:

(WebCore::LineWidth::LineWidth): Use the new updateCurrentShapeSegment member function.
(WebCore::LineWidth::updateCurrentShapeSegment): We need a function to update the current line segment's reference, since we use it multiple places.

rendering/LineWidth.h: Add new member function.
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat): Fix positioning of a floating element.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Use updateSegmentsForLine instead of computeSegmentsForLine.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Use updateSegmentsForLine instead of computeSegmentsForLine.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::updateSegmentsForShapes): After our float is positioned, we need to adjust the current lineTop and update the logical height to be able to wrap around the float.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): If we have a float in our line we might need to adjust our lineTop and logicalHeight.

rendering/shapes/ShapeInfo.cpp:

(WebCore::::computeSegmentsForLine): Add new const function to compute the segments. I'd like make this function static later if possible.
(WebCore::::updateSegmentsForLine): Old computeSegmentsForLine, change name to indicate that it is actually changing things.

rendering/shapes/ShapeInfo.h: Update function names, add declaration.

(WebCore::ShapeInfo::clearSegments):
(WebCore::ShapeInfo::logicalLineBottom):
(WebCore::ShapeInfo::lineOverlapsShapeBounds):

rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::computeFirstFitPositionForFloat): Compute the first fit position below the current line position inside shapes. I called this function
this way, because currently we use it only for shapes.

rendering/shapes/ShapeInsideInfo.h: Update function names.
rendering/shapes/ShapeOutsideInfo.cpp: Update function names.

(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):
(WebCore::ShapeOutsideInfo::updateSegmentsForLine):

rendering/shapes/ShapeOutsideInfo.h: Update function names.

LayoutTests:

fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html: Added.

6:59 PM Changeset in webkit [156021] by jae.park@company100.net

2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

Scripts/webkitpy/common/config/contributors.json:

6:48 PM Changeset in webkit [156020] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix 32-bit build.

runtime/JSCJSValue.h:

6:31 PM Changeset in webkit [156019] by fpizlo@apple.com

69 edits
12 adds in trunk

DFG should support Int52 for local variables
https://bugs.webkit.org/show_bug.cgi?id=121064

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds Int52 support for local variables to the DFG and FTL. It's a speed-up on
programs that have local int32 overflows but where a larger int representation can
prevent us from having to convert all the way up to double.

It's a small speed-up for now. But we're just supporting Int52 for a handful of
operations (add, sub, mul, neg, compare, bitops, typed array access) and this lays
the groundwork for adding Int52 to JSValue, which will probably be a bigger
speed-up.

The basic approach is:

We have a notion of Int52 in our typesystem. Int52 doesn't belong to BytecodeTop or HeapTop - i.e. it doesn't arise from JSValues.

DFG treats Int52 as being part of its FullTop and will treat it as being a subtype of double unless instructed otherwise.

Prediction propagator creates Int52s whenever we have a node going doubly but due to large values rather than fractional values, and that node is known to be able to produce Int52 natively in the DFG backend.

Fixup phase converts edges to MachineIntUses in nodes that are known to be able to deal with Int52, and where we have a subtype of Int32|Int52 as the predicted input.

The DFG backend and FTL LLVM IR lowering have two notions of Int52s - ones that are left-shifted by 16 (great for overflow checks) and ones that are sign-extended. Both backends know how to convert between Int52s and the other representations.

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::rshift64):
(JSC::MacroAssemblerX86_64::mul64):
(JSC::MacroAssemblerX86_64::branchMul64):
(JSC::MacroAssemblerX86_64::branchNeg64):
(JSC::MacroAssemblerX86_64::convertInt64ToDouble):

assembler/X86Assembler.h:

(JSC::X86Assembler::imulq_rr):
(JSC::X86Assembler::cvtsi2sdq_rr):

bytecode/DataFormat.h:

(JSC::dataFormatToString):

bytecode/OperandsInlines.h:

(JSC::::dumpInContext):

bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):

bytecode/SpeculatedType.h:

(JSC::isInt32SpeculationForArithmetic):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isBytecodeRealNumberSpeculation):
(JSC::isFullRealNumberSpeculation):
(JSC::isBytecodeNumberSpeculation):
(JSC::isFullNumberSpeculation):
(JSC::isBytecodeNumberSpeculationExpectingDefined):
(JSC::isFullNumberSpeculationExpectingDefined):

bytecode/ValueRecovery.h:

(JSC::ValueRecovery::alreadyInJSStackAsUnboxedInt52):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):

dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::needsTypeCheck):
(JSC::DFG::AbstractInterpreter::filterByType):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::checkConsistency):

dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::couldBeType):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::validateType):

dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::boxInt52):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGCommon.h:

(JSC::DFG::enableInt52):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixupUntypedSetLocalsInBlock):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

dfg/DFGFlushFormat.cpp:

(WTF::printInternal):

dfg/DFGFlushFormat.h:

(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):

dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::initInt52):
(JSC::DFG::GenerationInfo::initStrictInt52):
(JSC::DFG::GenerationInfo::isFormat):
(JSC::DFG::GenerationInfo::isInt52):
(JSC::DFG::GenerationInfo::isStrictInt52):
(JSC::DFG::GenerationInfo::fillInt52):
(JSC::DFG::GenerationInfo::fillStrictInt52):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateMachineInt):
(JSC::DFG::Graph::mulShouldSpeculateMachineInt):
(JSC::DFG::Graph::negateShouldSpeculateMachineInt):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):

dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):

dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasChild):

dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):

dfg/DFGNodeFlags.h:
dfg/DFGNodeType.h:

(JSC::DFG::forwardRewiringSelectionScore):

dfg/DFGOSRExitCompiler.cpp:
dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):

dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

dfg/DFGSilentRegisterSavePlan.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateMachineInt):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculate):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::int52Result):
(JSC::DFG::SpeculativeJIT::strictInt52Result):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::betterUseStrictInt52):
(JSC::DFG::SpeculativeJIT::generationInfo):
(JSC::DFG::SpeculateInt52Operand::SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::~SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::edge):
(JSC::DFG::SpeculateInt52Operand::node):
(JSC::DFG::SpeculateInt52Operand::gpr):
(JSC::DFG::SpeculateInt52Operand::use):
(JSC::DFG::SpeculateStrictInt52Operand::SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::~SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::edge):
(JSC::DFG::SpeculateStrictInt52Operand::node):
(JSC::DFG::SpeculateStrictInt52Operand::gpr):
(JSC::DFG::SpeculateStrictInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::~SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::edge):
(JSC::DFG::SpeculateWhicheverInt52Operand::node):
(JSC::DFG::SpeculateWhicheverInt52Operand::gpr):
(JSC::DFG::SpeculateWhicheverInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::format):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::boxInt52):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileInt52Compare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleInt52Branch):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGUseKind.cpp:

(WTF::printInternal):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):

dfg/DFGValueSource.cpp:

(JSC::DFG::ValueSource::dump):

dfg/DFGValueSource.h:

(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::valueRecovery):

dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::flushFormat):

ftl/FTLCArgumentGetter.cpp:

(JSC::FTL::CArgumentGetter::loadNextAndBox):

ftl/FTLCArgumentGetter.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::dumpInContext):

ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::inJSStackAsInt52):

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowInt52):
(JSC::FTL::LowerDFGToLLVM::lowStrictInt52):
(JSC::FTL::LowerDFGToLLVM::betterUseStrictInt52):
(JSC::FTL::LowerDFGToLLVM::bestInt52Kind):
(JSC::FTL::LowerDFGToLLVM::opposite):
(JSC::FTL::LowerDFGToLLVM::Int52s::operator[]):
(JSC::FTL::LowerDFGToLLVM::lowWhicheverInt52):
(JSC::FTL::LowerDFGToLLVM::lowWhicheverInt52s):
(JSC::FTL::LowerDFGToLLVM::lowOpposingInt52s):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt32):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToDouble):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToJSValue):
(JSC::FTL::LowerDFGToLLVM::setInt52WithStrictValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt52):
(JSC::FTL::LowerDFGToLLVM::int52ToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::setInt52):
(JSC::FTL::LowerDFGToLLVM::setStrictInt52):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

ftl/FTLOutput.h:

(JSC::FTL::Output::addWithOverflow64):
(JSC::FTL::Output::subWithOverflow64):
(JSC::FTL::Output::mulWithOverflow64):

ftl/FTLValueFormat.cpp:

(WTF::printInternal):

ftl/FTLValueFormat.h:
ftl/FTLValueSource.cpp:

(JSC::FTL::ValueSource::dump):

ftl/FTLValueSource.h:
interpreter/Register.h:

(JSC::Register::unboxedInt52):

runtime/Arguments.cpp:

(JSC::Arguments::tearOffForInlineCallFrame):

runtime/IndexingType.cpp:

(JSC::leastUpperBoundOfIndexingTypeAndType):

runtime/JSCJSValue.h:
runtime/JSCJSValueInlines.h:

(JSC::JSValue::isMachineInt):
(JSC::JSValue::asMachineInt):

Source/WTF:

Reviewed by Oliver Hunt.

wtf/PrintStream.h:

(WTF::ValueIgnoringContext::ValueIgnoringContext):
(WTF::ValueIgnoringContext::dump):
(WTF::ignoringContext):

Tools:

Reviewed by Oliver Hunt.

Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Oliver Hunt.

js/regress/large-int-captured-expected.txt: Added.
js/regress/large-int-captured.html: Added.
js/regress/large-int-expected.txt: Added.
js/regress/large-int-neg-expected.txt: Added.
js/regress/large-int-neg.html: Added.
js/regress/large-int.html: Added.
js/regress/marsaglia-larger-ints-expected.txt: Added.
js/regress/marsaglia-larger-ints.html: Added.
js/regress/script-tests/large-int-captured.js: Added.

(.bar):
(foo):

js/regress/script-tests/large-int-neg.js: Added.

(foo):

js/regress/script-tests/large-int.js: Added.

(foo):

js/regress/script-tests/marsaglia-larger-ints.js: Added.

(uint):
(marsaglia):

6:10 PM Changeset in webkit [156018] by alex.christensen@flexsim.com

2 edits in trunk/Tools

Added back and forward buttons to WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=121212

Reviewed by Brent Fulgham.

WinLauncher/WinLauncher.cpp:

(resizeSubViews):
Move new back and forward buttons to correct positions before URL bar.
(dllLauncherEntryPoint):
Store the default button window procedure and replace with my button procedures.
(EditProc): Updated style and renamed from MyEditProc.
(BackButtonProc): Added.
(ForwardButtonProc): Added.

6:06 PM Changeset in webkit [156017] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

Use CheckStructure for checking the types of typed arrays whenever possible
https://bugs.webkit.org/show_bug.cgi?id=121514

Reviewed by Oliver Hunt.

bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):
(JSC::DFG::ArrayMode::originalArrayStructure):
(JSC::DFG::arrayClassToString):

dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::ArrayMode):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::isOriginalTypedArrayStructure):

6:04 PM Changeset in webkit [156016] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG should use the (x & 0x7fffffff) trick for doing overflow and neg-zero checks on negation in one go
https://bugs.webkit.org/show_bug.cgi?id=121520

Reviewed by Oliver Hunt.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithNegate):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileArithNegate):

5:15 PM Changeset in webkit [156015] by weinig@apple.com

40 edits in trunk/Source/WebCore

Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebCore
https://bugs.webkit.org/show_bug.cgi?id=121527

Reviewed by Anders Carlsson.

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::setBuffer):

Modules/webaudio/AudioBufferSourceNode.h:
Modules/webaudio/OscillatorNode.h:
css/CSSParser.cpp:

(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::currentCharacter16):

css/CSSParser.h:
html/HTMLAreaElement.h:
html/HTMLFrameSetElement.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::simulateVertexAttrib0):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):

html/canvas/WebGLRenderingContext.h:
platform/ScrollAnimatorNone.cpp:
platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::setNumberOfChannels):

platform/audio/DynamicsCompressor.h:
platform/audio/FFTFrame.h:
platform/audio/gstreamer/FFTFrameGStreamer.cpp:

(WebCore::FFTFrame::FFTFrame):

platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::updateThumbPositionAndProportion):

platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::compileShaderSource):

platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::texImage2DResourceSafe):

platform/graphics/GraphicsContext3D.h:
platform/graphics/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

platform/graphics/blackberry/LayerTexture.cpp:
platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::getDirtyRects):

platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

platform/graphics/cg/GraphicsContextCG.cpp:
platform/graphics/cg/ImageBufferCG.cpp:
platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::updateSubRect):

platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setNormalizedBuffer):

platform/graphics/harfbuzz/HarfBuzzShaper.h:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):

platform/graphics/opentype/OpenTypeSanitizer.cpp:
platform/graphics/texmap/TextureMapperGL.cpp:
platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::SharedBitmap):
(WebCore::SharedBitmap::to16bit):

platform/graphics/wince/SharedBitmap.h:
platform/image-decoders/blackberry/JPEGImageDecoder.cpp:

(WebCore::ImageReader::decode):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::createRowBuffer):

platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::getContextMenuItems):

platform/win/LoggingWin.cpp:

(WebCore::logLevelString):

plugins/PluginPackage.cpp:
plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::handleTouchEvent):

plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::fetchInfo):

5:10 PM Changeset in webkit [156014] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r156001.
http://trac.webkit.org/changeset/156001
https://bugs.webkit.org/show_bug.cgi?id=121529

Broke API tests (Requested by ap on #webkit).

platform/mac/HTMLConverter.h:
platform/mac/HTMLConverter.mm:

(WebDefaultFont):
(_fontForNameAndSize):
(+[WebHTMLConverter defaultParagraphStyle]):
(-[WebHTMLConverter _computedStyleForElement:]):
(-[WebHTMLConverter _specifiedStyleForElement:]):
(-[WebHTMLConverter _computedStringForNode:property:]):
(-[WebHTMLConverter _stringForNode:property:]):
(-[WebHTMLConverter _getComputedFloat:forNode:property:]):
(-[WebHTMLConverter _getFloat:forNode:property:]):
(_colorForRGBColor):
(_shadowForShadowStyle):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
(-[WebHTMLConverter _computedColorForNode:property:]):
(-[WebHTMLConverter _colorForNode:property:]):
(-[WebHTMLConverter _computedAttributesForElement:]):
(-[WebHTMLConverter _attributesForElement:]):
(-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
(-[WebHTMLConverter _newLineForElement:]):
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[WebHTMLConverter _addQuoteForElement:opening:level:]):
(-[WebHTMLConverter _addValue:forElement:]):
(-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
(_dateForString):
(_colCompare):
(-[WebHTMLConverter _enterElement:tag:display:]):
(-[WebHTMLConverter _addTableForElement:]):
(-[WebHTMLConverter _addTableCellForElement:]):
(-[WebHTMLConverter _processElement:tag:display:depth:]):
(-[WebHTMLConverter _addMarkersToList:range:]):
(-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
(-[WebHTMLConverter _processText:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter _traverseFooterNode:depth:]):
(-[WebHTMLConverter _loadFromDOMRange]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
(-[WebHTMLConverter initWithDOMRange:]):
(-[WebHTMLConverter attributedString]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):
(fileWrapperForElement):

4:24 PM Changeset in webkit [156013] by ap@apple.com

1 edit
4 deletes in trunk/LayoutTests

Removed some Lion specific results - these tests are failing on Lion bots despite these,
and it looks like Lion now matches cross-platform results.

platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Removed.
platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Removed.
platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Removed.
platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Removed.

4:12 PM Changeset in webkit [156012] by ap@apple.com

2 edits in trunk/LayoutTests

compositing/images/positioned-image-content-rect.html is failing on some bots
https://bugs.webkit.org/show_bug.cgi?id=121526

platform/mac/TestExpectations: Marked as failing or passing for now, should

be fixed with upcoming color management improvements.

4:08 PM Changeset in webkit [156011] by commit-queue@webkit.org

24 edits in trunk

AX: Mac AXARIABusy should be AXElementBusy (not ARIA specific)
https://bugs.webkit.org/show_bug.cgi?id=121442

Patch by Samuel White <Samuel White> on 2013-09-17
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, changed AXARIABusy attribute to AXElementBusy to uncouple the concept of busy with
the aria-busy attribute. This will allow us to expand on the definition of busy moving forward.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

Mac platform attribute name change only (AXARIABusy => AXElementBusy). Updated existing tests using this attribute.

accessibility/transformed-element-expected.txt:
platform/mac/accessibility/aria-columnrowheaders-expected.txt:
platform/mac/accessibility/aria-liveregions-attributes-expected.txt:
platform/mac/accessibility/aria-liveregions-attributes.html:
platform/mac/accessibility/bounds-for-range-expected.txt:
platform/mac/accessibility/document-attributes-expected.txt:
platform/mac/accessibility/document-links-expected.txt:
platform/mac/accessibility/image-link-expected.txt:
platform/mac/accessibility/image-map2-expected.txt:
platform/mac/accessibility/internal-link-anchors-expected.txt:
platform/mac/accessibility/internal-link-anchors2-expected.txt:
platform/mac/accessibility/lists-expected.txt:
platform/mac/accessibility/plugin-expected.txt:
platform/mac/accessibility/table-attributes-expected.txt:
platform/mac/accessibility/table-cell-spans-expected.txt:
platform/mac/accessibility/table-cells-expected.txt:
platform/mac/accessibility/table-detection-expected.txt:
platform/mac/accessibility/table-one-cell-expected.txt:
platform/mac/accessibility/table-sections-expected.txt:
platform/mac/accessibility/table-with-aria-role-expected.txt:
platform/mac/accessibility/table-with-rules-expected.txt:

3:48 PM Changeset in webkit [156010] by msaboff@apple.com

2 edits in trunk/Tools

Unreviewed typo fix after r155999

Changed en_US.UTB-8 to en_US.UTF-8

Scripts/run-javascriptcore-tests:

3:32 PM Changeset in webkit [156009] by akling@apple.com

18 edits in trunk/Source

Pack create_hash_table tables better.
<https://webkit.org/b/121517>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Reduces JavaScriptCore binary size by 4648 bytes.

create_hash_table:
runtime/Lookup.h:

Reorder HashTableValue members to avoid unnecessary padding.

Source/WebCore:

Reduces WebCore binary size by 72744 bytes.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

Updated for new HashTableValue member order.

bindings/scripts/test/JS/*:

Rebaselined bindings tests.

3:27 PM Changeset in webkit [156008] by Simon Fraser

2 edits
1 copy in trunk/LayoutTests

Rebaseline a test.

platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt.
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:

3:27 PM Changeset in webkit [156007] by Brent Fulgham

2 edits in trunk/LayoutTests

[Windows] Adjust test list further to make the bots green.

platform/win/TestExpectations:

3:07 PM Changeset in webkit [156006] by zoltan@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Add FlowThreadController.h to Target.pri
https://bugs.webkit.org/show_bug.cgi?id=121516

Reviewed by Dirk Schulze.

No new tests, no behavior change.

Target.pri:

3:03 PM Changeset in webkit [156005] by ap@apple.com

2 edits in trunk/LayoutTests

ScriptProcessorNode is garbage collected while still active if unreachable (breaks
webaudio/javascriptaudionode.html test)
https://bugs.webkit.org/show_bug.cgi?id=112521

TestExpectations: Marking test as failing/asserting.

2:58 PM Changeset in webkit [156004] by andersca@apple.com

115 edits in trunk/Source

Stop explicitly using PassOwnPtr in WebCore/html
https://bugs.webkit.org/show_bug.cgi?id=121511

Reviewed by Andreas Kling.

Source/WebCore:

dom/ElementRareData.h:

(WebCore::ElementRareData::setClassList):

html/ButtonInputType.cpp:

(WebCore::ButtonInputType::create):

html/ButtonInputType.h:
html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::create):
(WebCore::CheckboxInputType::willDispatchClick):

html/CheckboxInputType.h:
html/ClassList.cpp:

(WebCore::ClassList::create):

html/ClassList.h:
html/ColorInputType.cpp:

(WebCore::ColorInputType::create):

html/ColorInputType.h:
html/DateInputType.cpp:

(WebCore::DateInputType::create):

html/DateInputType.h:
html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::create):

html/DateTimeInputType.h:
html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::create):

html/DateTimeLocalInputType.h:
html/EmailInputType.cpp:

(WebCore::EmailInputType::create):

html/EmailInputType.h:
html/FileInputType.cpp:

(WebCore::FileInputType::create):

html/FileInputType.h:
html/FormAssociatedElement.cpp:

(WebCore::FormAttributeTargetObserver::create):

html/FormController.cpp:

(WebCore::SavedFormState::create):
(WebCore::SavedFormState::deserialize):
(WebCore::FormKeyGenerator::create):
(WebCore::FormController::createSavedFormStateMap):

html/FormController.h:

(WebCore::FormController::create):

html/HTMLInputElement.cpp:

(WebCore::ListAttributeTargetObserver::create):

html/HiddenInputType.cpp:

(WebCore::HiddenInputType::create):

html/HiddenInputType.h:
html/ImageInputType.cpp:

(WebCore::ImageInputType::create):

html/ImageInputType.h:
html/InputType.cpp:

(WebCore::InputType::create):
(WebCore::InputType::createText):
(WebCore::InputType::willDispatchClick):

html/InputType.h:
html/MonthInputType.cpp:

(WebCore::MonthInputType::create):

html/MonthInputType.h:
html/NumberInputType.cpp:

(WebCore::NumberInputType::create):

html/NumberInputType.h:
html/PasswordInputType.cpp:

(WebCore::PasswordInputType::create):

html/PasswordInputType.h:
html/PublicURLManager.h:

(WebCore::PublicURLManager::create):

html/RadioInputType.cpp:

(WebCore::RadioInputType::create):
(WebCore::RadioInputType::willDispatchClick):

html/RadioInputType.h:
html/RangeInputType.cpp:

(WebCore::RangeInputType::create):

html/RangeInputType.h:
html/ResetInputType.cpp:

(WebCore::ResetInputType::create):

html/ResetInputType.h:
html/SearchInputType.cpp:

(WebCore::SearchInputType::create):

html/SearchInputType.h:
html/SubmitInputType.cpp:

(WebCore::SubmitInputType::create):

html/SubmitInputType.h:
html/TelephoneInputType.cpp:

(WebCore::TelephoneInputType::create):

html/TelephoneInputType.h:
html/TextInputType.cpp:

(WebCore::TextInputType::create):

html/TextInputType.h:
html/TimeInputType.cpp:

(WebCore::TimeInputType::create):

html/TimeInputType.h:
html/URLInputType.cpp:

(WebCore::URLInputType::create):

html/URLInputType.h:
html/ValidationMessage.cpp:

(WebCore::ValidationMessage::create):

html/ValidationMessage.h:
html/ValidityState.h:

(WebCore::ValidityState::create):

html/WeekInputType.cpp:

(WebCore::WeekInputType::create):

html/WeekInputType.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createCompositingBuffer):

html/canvas/CanvasRenderingContext2D.h:

(WebCore::CanvasRenderingContext2D::create):

html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::create):

html/canvas/EXTDrawBuffers.h:
html/canvas/EXTTextureFilterAnisotropic.cpp:

(WebCore::EXTTextureFilterAnisotropic::create):

html/canvas/EXTTextureFilterAnisotropic.h:
html/canvas/OESElementIndexUint.cpp:

(WebCore::OESElementIndexUint::create):

html/canvas/OESElementIndexUint.h:
html/canvas/OESStandardDerivatives.cpp:

(WebCore::OESStandardDerivatives::create):

html/canvas/OESStandardDerivatives.h:
html/canvas/OESTextureFloat.cpp:

(WebCore::OESTextureFloat::create):

html/canvas/OESTextureFloat.h:
html/canvas/OESTextureHalfFloat.cpp:

(WebCore::OESTextureHalfFloat::create):

html/canvas/OESTextureHalfFloat.h:
html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::create):

html/canvas/OESVertexArrayObject.h:
html/canvas/WebGLCompressedTextureATC.cpp:

(WebCore::WebGLCompressedTextureATC::create):

html/canvas/WebGLCompressedTextureATC.h:
html/canvas/WebGLCompressedTexturePVRTC.cpp:

(WebCore::WebGLCompressedTexturePVRTC::create):

html/canvas/WebGLCompressedTexturePVRTC.h:
html/canvas/WebGLCompressedTextureS3TC.cpp:

(WebCore::WebGLCompressedTextureS3TC::create):

html/canvas/WebGLCompressedTextureS3TC.h:
html/canvas/WebGLDebugRendererInfo.cpp:

(WebCore::WebGLDebugRendererInfo::create):

html/canvas/WebGLDebugRendererInfo.h:
html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::create):

html/canvas/WebGLDebugShaders.h:
html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::create):

html/canvas/WebGLDepthTexture.h:
html/canvas/WebGLLoseContext.cpp:

(WebCore::WebGLLoseContext::create):

html/canvas/WebGLLoseContext.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

html/canvas/WebGLRenderingContext.h:
html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::resumeFrom):

html/parser/BackgroundHTMLParser.h:

(WebCore::BackgroundHTMLParser::create):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::discardSpeculationsAndResumeFrom):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):

html/parser/HTMLDocumentParser.h:
html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord):

html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::ElementRecord::releaseNext):
(WebCore::HTMLElementStack::ElementRecord::setNext):

html/parser/HTMLMetaCharsetParser.h:

(WebCore::HTMLMetaCharsetParser::create):

html/parser/HTMLParserScheduler.h:

(WebCore::HTMLParserScheduler::create):

html/parser/HTMLParserThread.h:

(WebCore::HTMLParserThread::create):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):

html/parser/HTMLResourcePreloader.cpp:

(WebCore::HTMLResourcePreloader::preload):

html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::create):

html/parser/HTMLScriptRunner.h:

(WebCore::HTMLScriptRunner::create):

html/parser/HTMLToken.h:

(WebCore::HTMLToken::releaseDoctypeData):

html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::create):

html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::create):

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

html/parser/XSSAuditor.h:
html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::create):

html/track/WebVTTParser.h:

(WebCore::WebVTTParser::create):

html/track/WebVTTTokenizer.h:

(WebCore::WebVTTTokenizer::create):

Source/WTF:

Make operator= work work for different types of OwnPtrs.

wtf/OwnPtr.h:

2:57 PM Changeset in webkit [156003] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG doesn't properly keep scope alive for op_put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=121519

Reviewed by Michael Saboff.

This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

2:48 PM Changeset in webkit [156002] by ap@apple.com

3 edits in trunk/LayoutTests

Web Inspector: inspector/storage-panel-dom-storage-update.html is flakey on the bots
https://bugs.webkit.org/show_bug.cgi?id=120544

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

Marking as such again.

2:48 PM Changeset in webkit [156001] by enrica@apple.com

3 edits in trunk/Source/WebCore

Upstream changes to WebHTMLConverter to support HTML
to NSAttributedString conversion on both iOS and OS X.

Reviewed by Benjamin Poulain.

platform/mac/HTMLConverter.h:
platform/mac/HTMLConverter.mm:

(WebDefaultFont):
(_fontForNameAndSize):
(+[WebHTMLConverter defaultParagraphStyle]):
(-[WebHTMLConverter _computedStyleForElement:]):
(-[WebHTMLConverter _specifiedStyleForElement:]):
(-[WebHTMLConverter _computedStringForNode:property:]):
(-[WebHTMLConverter _stringForNode:property:]):
(-[WebHTMLConverter _getComputedFloat:forNode:property:]):
(-[WebHTMLConverter _getFloat:forNode:property:]):
(_NSFirstPathForDirectoriesInDomains):
(_NSSystemLibraryPath):
(-[WebHTMLConverter _webKitBundle]):
(_colorForRGBColor):
(_shadowForShadowStyle):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
(-[WebHTMLConverter _computedColorForNode:property:]):
(-[WebHTMLConverter _colorForNode:property:]):
(-[WebHTMLConverter _computedAttributesForElement:]):
(-[WebHTMLConverter _attributesForElement:]):
(-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
(-[WebHTMLConverter _newLineForElement:]):
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _WebMessageDocumentClass]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[WebHTMLConverter _addQuoteForElement:opening:level:]):
(-[WebHTMLConverter _addValue:forElement:]):
(-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
(_dateForString):
(_colCompare):
(-[WebHTMLConverter _processMetaElementWithName:content:]):
(-[WebHTMLConverter _processHeadElement:]):
(-[WebHTMLConverter _enterElement:tag:display:embedded:]):
(-[WebHTMLConverter _addTableForElement:]):
(-[WebHTMLConverter _addTableCellForElement:]):
(-[WebHTMLConverter _processElement:tag:display:depth:]):
(-[WebHTMLConverter _addMarkersToList:range:]):
(-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
(-[WebHTMLConverter _processText:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter _traverseFooterNode:depth:]):
(-[WebHTMLConverter _loadFromDOMRange]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
(-[WebHTMLConverter initWithDOMRange:]):
(-[WebHTMLConverter attributedString]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):

2:46 PM Changeset in webkit [156000] by weinig@apple.com

7 edits in trunk/Source

Add make_unique and start using it
https://bugs.webkit.org/show_bug.cgi?id=121523

Reviewed by Anders Carlsson.

../WebCore:

html/HTMLAreaElement.h:
html/HTMLFrameSetElement.h:
platform/Length.cpp:

(WebCore::newCoordsArray):
(WebCore::newLengthArray):

platform/Length.h:

Switch off OwnArrayPtr to std::unique_ptr<T[]> and make use of make_unique.

../WTF:

wtf/StdLibExtras.h:

(std::make_unique):
Add temporary implementation of std::make_unique that we can use until our standard
libraries have support for it.

2:44 PM Changeset in webkit [155999] by msaboff@apple.com

2 edits in trunk/Tools

run-jsc-stress-tests fails with ruby version 2
https://bugs.webkit.org/show_bug.cgi?id=121521

Reviewed by Jessie Berlin.

Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.

Scripts/run-javascriptcore-tests:

2:33 PM Changeset in webkit [155998] by Simon Fraser

33 edits
13 copies
9 adds
1 delete in trunk

Hardware accelerated CSS transitions appear pixelated when scaled up using transform
https://bugs.webkit.org/show_bug.cgi?id=27684
<rdar://problem/6134606>

Source/WebCore:

Reviewed by Dean Jackson.

Take transforms and animations into account when computing the contentsScale
for a layer, so that scaled-up layers remain sharp most of the time.

In its recursiveCommitChanges() tree walk, GraphicsLayerCA now tracks
a root-relative transform, and extracts from that transform the X and Y
scales which it uses to scale the backing store.

If the layer has transform animations on it, we keep around
a transformation matrix for the animation endpoints (or keyframes),
pick up the state that has the larger impact on the root-relative scale,
and use that as the layer's transform, and the transform when recursing
over descendants.

Tests: compositing/contents-scale/animating.html

compositing/contents-scale/scaled-ancestor.html
compositing/contents-scale/simple-scale.html
compositing/contents-scale/z-translate.html

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::maxScaleFromTransform): Decompose the transform if necesssary
to extract the X and Y scale components.
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::flushCompositingState): Supply a TransformationMatrix
for the root of the recursion.
(WebCore::GraphicsLayerCA::layerTransform): This code was factored out of
computeVisibleRect(), and optionally takes a custom transform.
(WebCore::GraphicsLayerCA::computeVisibleRect): Use the layerTransform() function.
(WebCore::GraphicsLayerCA::updateRootRelativeScale): Given a transform from the root,
find the max scale factor by multiplying the various animation endpoint matrices and picking
the one with the biggest impact on scale. Use this to set m_rootRelativeScaleFactor, and
set the flag to say that we need to update contentsScale.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): After updating
animations, call updateRootRelativeScale() to update m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::updateAnimations): We have a side table of animation name to
TransformationMatrix, so figure out which entries can be removed from that side table,
and remove them.
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations): Store the matrices for
animation endpoints/keyframes in the m_animationTransforms side table. We don't store
them directly in LayerPropertyAnimation because we just want the final matrix for
a transform list, and using a side table makes ownership easier to manage.
(WebCore::GraphicsLayerCA::getTransformFromAnimationsWithMaxScaleImpact):
goes through the matrices for the running animation endpoints/keyframes, and
multiplies each with the transform up to this layer to find the matrix with the
larger impact on scale.
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints): Returns a vector
of TransformationMatrix for the from and to states.
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes): Returns a vector
of TransformationMatrix for the keyframes.
(WebCore::GraphicsLayerCA::updateContentsScale): Include m_rootRelativeScaleFactor in the
scale factor computation.
(WebCore::GraphicsLayerCA::dumpAdditionalProperties): If we're dumping visible rects,
also dump the contentsScale. Convenient at these are useful to look at together, and I didn't
want to pollute Internals with yet more flags.

platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): Formatting.

LayoutTests:

Reviewed by Dean Jackson.

New tests that dump contentsScale under various scaling scenarios:

compositing/contents-scale/animating-expected.txt: Added.
compositing/contents-scale/animating.html: Added.
compositing/contents-scale/scaled-ancestor-expected.txt: Added.
compositing/contents-scale/scaled-ancestor.html: Added.
compositing/contents-scale/simple-scale-expected.txt: Added.
compositing/contents-scale/simple-scale.html: Added.
compositing/contents-scale/z-translate-expected.txt: Added.
compositing/contents-scale/z-translate.html: Added.

These tests had Mac-specific results (which include visible rects and now
contents scale) in the cross-platform directory, so cleaned up the cross-platform
results and moved the Mac results to platform-mac.

compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
compositing/visible-rect/2d-transformed-expected.txt:
compositing/visible-rect/3d-transform-style-expected.txt:
compositing/visible-rect/3d-transformed-expected.txt:
compositing/visible-rect/animated-expected.txt:
compositing/visible-rect/animated-from-none-expected.txt:
compositing/visible-rect/clipped-by-viewport-expected.txt:
compositing/visible-rect/clipped-visible-rect-expected.txt:
compositing/visible-rect/flipped-preserve-3d-expected.txt:
compositing/visible-rect/iframe-and-layers-expected.txt:
compositing/visible-rect/nested-transform-expected.txt:
compositing/visible-rect/scrolled-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/2d-transformed-expected.txt.
platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transform-style-expected.txt.
platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transformed-expected.txt.
platform/mac/compositing/visible-rect/animated-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-expected.txt.
platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-from-none-expected.txt.
platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-by-viewport-expected.txt.
platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-visible-rect-expected.txt.
platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Copied from LayoutTests/compositing/visible-rect/flipped-preserve-3d-expected.txt.
platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Copied from LayoutTests/compositing/visible-rect/iframe-and-layers-expected.txt.
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/mac/compositing/visible-rect/nested-transform-expected.txt: Copied from LayoutTests/compositing/visible-rect/nested-transform-expected.txt.
platform/mac/compositing/visible-rect/scrolled-expected.txt: Copied from LayoutTests/compositing/visible-rect/scrolled-expected.txt.

2:07 PM Changeset in webkit [155997] by Lucas Forschler

5 edits in branches/safari-537.60-branch/Source/WebCore

Merge 154391.

2:02 PM Changeset in webkit [155996] by Lucas Forschler

3 edits in branches/safari-537.60-branch/WebKitLibraries

Merge 154390.

1:56 PM Changeset in webkit [155995] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Don't GC while OSR compiling
https://bugs.webkit.org/show_bug.cgi?id=121513

Reviewed by Mark Hahnenberg.

Fixes some rare crashes that I see in ConservativeRoots, while in a GC from OSR exit
compilation.

dfg/DFGOSRExitCompiler.cpp:
ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

1:54 PM Changeset in webkit [155994] by commit-queue@webkit.org

21 edits
14 deletes in trunk

Unreviewed, rolling out r155977.
http://trac.webkit.org/changeset/155977
https://bugs.webkit.org/show_bug.cgi?id=121515

Broke over a dozen tests on Mac WK2 (Requested by ap on
#webkit).

Source/WebCore:

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):

LayoutTests:

compositing/contents-scale/animating-expected.txt: Removed.
compositing/contents-scale/animating.html: Removed.
compositing/contents-scale/scaled-ancestor-expected.txt: Removed.
compositing/contents-scale/scaled-ancestor.html: Removed.
compositing/contents-scale/simple-scale-expected.txt: Removed.
compositing/contents-scale/simple-scale.html: Removed.
compositing/contents-scale/z-translate-expected.txt: Removed.
compositing/contents-scale/z-translate.html: Removed.
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
compositing/visible-rect/2d-transformed-expected.txt:
compositing/visible-rect/3d-transform-style-expected.txt:
compositing/visible-rect/3d-transformed-expected.txt:
compositing/visible-rect/animated-expected.txt:
compositing/visible-rect/animated-from-none-expected.txt:
compositing/visible-rect/clipped-by-viewport-expected.txt:
compositing/visible-rect/clipped-visible-rect-expected.txt:
compositing/visible-rect/flipped-preserve-3d-expected.txt:
compositing/visible-rect/iframe-and-layers-expected.txt:
compositing/visible-rect/nested-transform-expected.txt:
compositing/visible-rect/scrolled-expected.txt:
platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Removed.
platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Removed.
platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Removed.
platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Removed.
platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Removed.
platform/mac/compositing/visible-rect/animated-expected.txt: Removed.
platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Removed.
platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Removed.
platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Removed.
platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Removed.
platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Removed.
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/mac/compositing/visible-rect/nested-transform-expected.txt: Removed.
platform/mac/compositing/visible-rect/scrolled-expected.txt: Removed.

1:53 PM Changeset in webkit [155993] by Lucas Forschler

3 edits in branches/safari-537-branch/WebKitLibraries

Rollout r155990

1:36 PM Changeset in webkit [155992] by eric.carlson@apple.com

17 edits
10 adds in trunk

MediaStream API: Changing the device enumeration to be async
https://bugs.webkit.org/show_bug.cgi?id=120883

Reviewed by Darin Adler.

Source/WebCore:

Parts merged from https://chromium.googlesource.com/chromium/blink/+/40a96080a1531e50de4eb84571c7dc9fb321ece5
and https://chromium.googlesource.com/chromium/blink/+/ff783a23bb1add588971a8187048a305cf485121
by Tommy Widenflycht.

Test: fast/mediastream/MediaStreamTrack-getSources.html

CMakeLists.txt: Added new files.
DerivedSources.make: Ditto.
GNUmakefile.list.am: Ditto.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::kind): ASCIILiteral -> NeverDestroyed<AtomicString>.
(WebCore::MediaStreamTrack::readyState): Ditto.
(WebCore::MediaStreamTrack::getSources): New.

Modules/mediastream/MediaStreamTrack.h:
Modules/mediastream/MediaStreamTrack.idl:

Modules/mediastream/MediaStreamTrackSourcesCallback.h: Added.
Modules/mediastream/MediaStreamTrackSourcesCallback.idl: Added.
Modules/mediastream/MediaStreamTrackSourcesRequest.cpp: Added.
Modules/mediastream/MediaStreamTrackSourcesRequest.h: Added.

Modules/mediastream/SourceInfo.cpp: Added.
Modules/mediastream/SourceInfo.h: Added.
Modules/mediastream/SourceInfo.idl: Added.

WebCore.xcodeproj/project.pbxproj: Add new files.

bindings/js/JSDOMBinding.h: Add toJS templates for Vector<T> and Vector<RefPtr<T>>.

platform/mediastream/MediaStreamCenter.h: Add prototype for getMediaStreamTrackSources.

platform/mediastream/MediaStreamTrackSourcesRequestClient.h: Added.

platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:

(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added.

platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:

platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:

(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added

platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

platform/mediastream/mac/MediaStreamCenterMac.cpp:

(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added.

platform/mediastream/mac/MediaStreamCenterMac.h:

LayoutTests:

fast/mediastream/MediaStreamTrack-getSources-expected.txt: Added.
fast/mediastream/MediaStreamTrack-getSources.html: Added.

1:30 PM Changeset in webkit [155991] by Brent Fulgham

2 edits in trunk/LayoutTests

lUnreviewed, rolling out r155976.
http://trac.webkit.org/changeset/155976
https://bugs.webkit.org/show_bug.cgi?id=121512

Broke a test, needs cleanup (Requested by ap_ on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-09-17

platform/mac/accessibility/element-busy-changed-expected.txt: Removed.
platform/mac/accessibility/element-busy-changed.html: Removed.

1:23 PM Changeset in webkit [155990] by Lucas Forschler

3 edits in branches/safari-537-branch/WebKitLibraries

Windows build fix after r154914.

1:10 PM Changeset in webkit [155989] by commit-queue@webkit.org

5 edits
2 deletes in trunk

Unreviewed, rolling out r155976.
http://trac.webkit.org/changeset/155976
https://bugs.webkit.org/show_bug.cgi?id=121512

Broke a test, needs cleanup (Requested by ap_ on #webkit).

Source/WebCore:

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChanged):

accessibility/AXObjectCache.h:
accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

platform/mac/accessibility/element-busy-changed-expected.txt: Removed.
platform/mac/accessibility/element-busy-changed.html: Removed.

1:06 PM Changeset in webkit [155988] by commit-queue@webkit.org

8 edits
15 adds
1 delete in trunk

Improve srcset parser
https://bugs.webkit.org/show_bug.cgi?id=119423

Patch by Romain Perier <Romain Perier> on 2013-09-17
Reviewed by Benjamin Poulain.

Source/WebCore:

Added new tests and covered by existing ones.

html/parser/HTMLParserIdioms.cpp:

(WebCore::isHTMLSpaceOrComma): Add a new predicate function used by String::find()
to get the first space or comma character from the input string.
(WebCore::parseImagesWithScaleFromSrcSetAttribute): Add a new static function to parse
and extract images with scale from the srcset attribute. All valid candidates are
returned to the caller through a list. This parsing function also adds support
for data URI schemes as described by the specification.
(WebCore::bestFitSourceForImageAttributes): Remove intermediate arrays of string
when parsing. That is more efficient and avoids trashing the data cache
(varying between 20 and 65% faster depending of the amount of data)
The parser now walks along the attribute value and extracts the candidates directly.

LayoutTests:

fast/hidpi/image-srcset-data-srcset-invalid-inputs.html: Ensures that a various invalid form of data uri schemes are supported by the srcset attribute.
fast/hidpi/image-srcset-data-srcset-valid-inputs.html: Ensures that a various valid form of data uri schemes are supported by the srcset attribute.
fast/hidpi/image-srcset-data-srcset.html: Use comma instead of %.
fast/hidpi/image-srcset-fraction-1.5x.html: Added.
fast/hidpi/image-srcset-invalid-inputs-except-one.html: Missing srcset-helper.js. Adding more invalid cases.
fast/hidpi/image-srcset-invalid-inputs.html: Adding more invalid cases.
fast/hidpi/image-srcset-nomodifier.html: Updated output as behaviour changed for this case.
fast/hidpi/image-srcset-space-suffix-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if a space is left at the end.
fast/hidpi/image-srcset-space-prefix-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if a space is left at the beginning.
fast/hidpi/image-srcset-space-surrounded-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if it is surrounded by spaces.
fast/hidpi/image-srcset-data-escaped-srcset.html: Ensures that data uri schemes with escaped characters are supported by the srcset attribute.

1:00 PM Changeset in webkit [155987] by Csaba Osztrogonác

7 edits in trunk/Source/WebKit2

Buildfix for !ENABLE(CUSTOM_PROTOCOLS) platforms
https://bugs.webkit.org/show_bug.cgi?id=121417

Reviewed by Alexey Proskuryakov.

Original patch by Balazs Kelemen <kbalazs@webkit.org>.

CMakeLists.txt: Add CustomProtocolManagerProxy.messages.in.
DerivedSources.pri: Add CustomProtocolManagerProxy.messages.in.
GNUmakefile.am: Add CustomProtocolManagerProxy.messages.in.
GNUmakefile.list.am: Add CustomProtocolManagerProxyMessages.h and CustomProtocolManagerProxyMessageReceiver.cpp.
NetworkProcess/NetworkProcess.cpp: Add the missing ENABLE(CUSTOM_PROTOCOLS) guard.

(WebKit::NetworkProcess::NetworkProcess):

UIProcess/WebProcessProxy.cpp: Remove the unnecessary conditional include.

12:41 PM Changeset in webkit [155986] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge 155985 - [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
https://bugs.webkit.org/show_bug.cgi?id=121383

Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(openRemoteDebuggingSession): use the page contents' to check the remote debugging of the page
has been successfuly opened, as the title is no longer the same after the switch to the new
frontend.

12:27 PM Changeset in webkit [155985] by kov@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
https://bugs.webkit.org/show_bug.cgi?id=121383

Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(openRemoteDebuggingSession): use the page contents' to check the remote debugging of the page
has been successfuly opened, as the title is no longer the same after the switch to the new
frontend.

12:16 PM Changeset in webkit [155984] by kov@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed build fix after 155963.

platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getStyleContext): use nullptr instead of 0.

12:06 PM Changeset in webkit [155983] by Brent Fulgham

2 edits in trunk/LayoutTests

[Windows] Disable a number of crashing tests to help the EWS system run more rapidly.
https://bugs.webkit.org/show_bug.cgi?id=121509

platform/win/TestExpectations:

12:05 PM Changeset in webkit [155982] by ap@apple.com

2 edits in trunk/Source/WebCore

Make SVGTransform::valueAsString use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121498

Unreviewed typo fix, should address a regression on svg/dom/SVGViewSpec.html.

svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString): "e" is totally

not the same as "f".

11:57 AM Changeset in webkit [155981] by Brent Fulgham

2 edits in trunk/LayoutTests

[Windows] Disable a number of failing tests to help the EWS system run more rapidly.

platform/win/TestExpectations:

11:39 AM Changeset in webkit [155980] by kov@webkit.org

3 edits in releases/WebKitGTK/webkit-2.2/Source/WebInspectorUI

Merge 155966 - Clean up the Inspector's WebSocket code and prevent it from dropping messages.

https://bugs.webkit.org/show_bug.cgi?id=121391

Reviewed by Joseph Pecoraro.

UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.initializeWebSocket): Added. Create the socket
and call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend): Store messages as pending
if the socket isn't ready yet. Call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype._sendPendingMessagesToBackendIfNeeded): Added.

UserInterface/Main.js:

(WebInspector._initializeWebSocketIfNeeded): Move socket creation to initializeWebSocket.

11:22 AM Changeset in webkit [155979] by Brent Fulgham

2 edits in trunk/Tools

[Windows] Unreviewed build fix after r155963.

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.

11:15 AM Changeset in webkit [155978] by Brent Fulgham

2 edits in trunk/Source/WebKit/win

[Windows] Speculative build fix after r155963

WebKitCOMAPI.cpp:

(classFactory): Use nullptr rather than 0 for HashMap.

11:12 AM Changeset in webkit [155977] by Simon Fraser

21 edits
13 copies
9 adds in trunk

Hardware accelerated CSS transitions appear pixelated when scaled up using transform
https://bugs.webkit.org/show_bug.cgi?id=27684
<rdar://problem/6134606>

Source/WebCore:

Reviewed by Dean Jackson.

Take transforms and animations into account when computing the contentsScale
for a layer, so that scaled-up layers remain sharp most of the time.

In its recursiveCommitChanges() tree walk, GraphicsLayerCA now tracks
a root-relative transform, and extracts from that transform the X and Y
scales which it uses to scale the backing store.

Tests: compositing/contents-scale/animating.html

compositing/contents-scale/scaled-ancestor.html
compositing/contents-scale/simple-scale.html
compositing/contents-scale/z-translate.html

platform/graphics/ca/GraphicsLayerCA.cpp:

platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): Formatting.

LayoutTests:

Reviewed by Dean Jackson.

New tests that dump contentsScale under various scaling scenarios:

compositing/contents-scale/animating-expected.txt: Added.
compositing/contents-scale/animating.html: Added.
compositing/contents-scale/scaled-ancestor-expected.txt: Added.
compositing/contents-scale/scaled-ancestor.html: Added.
compositing/contents-scale/simple-scale-expected.txt: Added.
compositing/contents-scale/simple-scale.html: Added.
compositing/contents-scale/z-translate-expected.txt: Added.
compositing/contents-scale/z-translate.html: Added.

compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
compositing/visible-rect/2d-transformed-expected.txt:
compositing/visible-rect/3d-transform-style-expected.txt:
compositing/visible-rect/3d-transformed-expected.txt:
compositing/visible-rect/animated-expected.txt:
compositing/visible-rect/animated-from-none-expected.txt:
compositing/visible-rect/clipped-by-viewport-expected.txt:
compositing/visible-rect/clipped-visible-rect-expected.txt:
compositing/visible-rect/flipped-preserve-3d-expected.txt:
compositing/visible-rect/iframe-and-layers-expected.txt:
compositing/visible-rect/nested-transform-expected.txt:
compositing/visible-rect/scrolled-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/2d-transformed-expected.txt.
platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transform-style-expected.txt.
platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transformed-expected.txt.
platform/mac/compositing/visible-rect/animated-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-expected.txt.
platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-from-none-expected.txt.
platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-by-viewport-expected.txt.
platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-visible-rect-expected.txt.
platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Copied from LayoutTests/compositing/visible-rect/flipped-preserve-3d-expected.txt.
platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Copied from LayoutTests/compositing/visible-rect/iframe-and-layers-expected.txt.
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/mac/compositing/visible-rect/nested-transform-expected.txt: Copied from LayoutTests/compositing/visible-rect/nested-transform-expected.txt.
platform/mac/compositing/visible-rect/scrolled-expected.txt: Copied from LayoutTests/compositing/visible-rect/scrolled-expected.txt.

11:10 AM Changeset in webkit [155976] by commit-queue@webkit.org

5 edits
2 adds in trunk

AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451

Patch by Samuel White <Samuel White> on 2013-09-17
Reviewed by Darin Adler.

Source/WebCore:

Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.

Test: platform/mac/accessibility/element-busy-changed.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChanged):

accessibility/AXObjectCache.h:
accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.

platform/mac/accessibility/element-busy-changed-expected.txt: Added.
platform/mac/accessibility/element-busy-changed.html: Added.

11:10 AM Changeset in webkit [155975] by Antti Koivisto

12 edits in trunk/Source/WebCore

Add isTextOrBR() and use it
https://bugs.webkit.org/show_bug.cgi?id=121506

Reviewed by Darin Adler.

It is a popular test.

dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

editing/Editor.cpp:

(WebCore::findFirstMarkable):

editing/TextIterator.cpp:

(WebCore::ignoresContainerClip):

rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):

rendering/InlineIterator.h:

(WebCore::isIteratorTarget):

rendering/RenderBlock.cpp:

(WebCore::InlineMinMaxIterator::next):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutInlineChildren):

rendering/RenderCounter.cpp:

(WebCore::planCounter):

rendering/RenderObject.h:

(WebCore::RenderObject::isTextOrBR):

rendering/RenderTreeAsText.cpp:

(WebCore::write):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):

11:04 AM Changeset in webkit [155974] by Manuel Rego Casasnovas

1 edit
2 adds in trunk/LayoutTests

[CSS Regions] Layout Test for selection direction
https://bugs.webkit.org/show_bug.cgi?id=121501

Reviewed by Darin Adler.

Selection follows DOM tree, so the highlighted text in this test case is
the opposite to what the user is actually selecting. This was not
working properly from r139197 to r155058, so adding a Layout Test to
prevent future breaks. It is a reftest comparing regions and absolute
positions behavior.

fast/regions/selection-direction-expected.html: Added.
fast/regions/selection-direction.html: Added.

10:56 AM Changeset in webkit [155973] by andersca@apple.com

2 edits in trunk/Tools

Fix a typo.

TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

10:40 AM Changeset in webkit [155972] by Antti Koivisto

2 edits in trunk/Source/WebCore

RenderBR should not be RenderText
https://bugs.webkit.org/show_bug.cgi?id=121221

Rubber-stamped by Andreas Kling.

Fix assertion in these tests:

fast/repaint/selection-rl.html
fast/writing-mode/horizontal-bt-replaced-selection.html
fast/writing-mode/vertical-rl-replaced-selection.html

rendering/InlineBox.cpp:

(WebCore::InlineBox::nodeAtPoint):

10:20 AM Changeset in webkit [155971] by enrica@apple.com

31 edits in trunk/Source

Remove unused function didSetSelectionTypesForPasteboard from EditorClient.
https://bugs.webkit.org/show_bug.cgi?id=121464

Reviewed by Darin Adler.

Source/WebCore:

This method was only implemented in WebEditorClient.mm for Mac where it was
calling a private delegate that is no longer in use.
This patch removes it for all the platforms.
I've also removed setTypes and writeAfterSettingTypes from the implementation
of the Pasteboard class for Mac.

editing/mac/EditorMac.mm:

(WebCore::Editor::writeSelectionToPasteboard): Now calls write instead of
setTypes and writeAfterSettingTypes.

loader/EmptyClients.h: Removed didSetSelectionTypesForPasteboard.
page/EditorClient.h: Ditto.
platform/Pasteboard.h: Removed setTypes and writeAfterSettingTypes.
platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::writeSelection): Removed call to didSetSelectionTypesForPasteboard.

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::write): Added to replace setTypes and writeAfterSettingTypes.

Source/WebKit/efl:

WebCoreSupport/EditorClientEfl.cpp:
WebCoreSupport/EditorClientEfl.h:

Source/WebKit/gtk:

WebCoreSupport/EditorClientGtk.cpp:
WebCoreSupport/EditorClientGtk.h:

Source/WebKit/mac:

This method was only implemented in WebEditorClient.mm for Mac where it was
calling a private delegate that is no longer in use.

DefaultDelegates/WebDefaultEditingDelegate.m:
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:
WebView/WebEditingDelegatePrivate.h:

Source/WebKit/qt:

WebCoreSupport/EditorClientQt.cpp:
WebCoreSupport/EditorClientQt.h:

Source/WebKit/win:

WebCoreSupport/WebEditorClient.cpp:
WebCoreSupport/WebEditorClient.h:

Source/WebKit/wince:

WebCoreSupport/EditorClientWinCE.cpp:
WebCoreSupport/EditorClientWinCE.h:

Source/WebKit2:

WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebCoreSupport/WebEditorClient.h:

10:17 AM Changeset in webkit [155970] by Darin Adler

6 edits in trunk/Source/WebCore

Further shrink table-populating code by making the tables read-only data and preventing inlining
https://bugs.webkit.org/show_bug.cgi?id=121468

Reviewed by Sam Weinig.

bindings/scripts/StaticString.pm:

(GenerateStrings): Eliminated the xxxImpl globals. We definitely did not need
globals for these, much less read-write data. Instead, write the expression at
each site where we need them.
(GenerateStringAsserts): This is one such site (see above).

css/CSSSelector.cpp:

(WebCore::populatePseudoTypeByNameMap): Mark this function NEVER_INLINE and
add static to make sure the table ends up in read-only data.

dom/make_names.pl:

(printDefinitions): Write the xxxImpl expression (see above).
(printFactoryCppFile): Ditto. Also mark the populate function NEVER_INLINE and
add static to make sure the table ends up in read-only data.
(printWrapperFactoryCppFile): Ditto.

html/HTMLElement.cpp:

(WebCore::populateEventNameForAttributeLocalNameMap): Mark this function
NEVER_INLINE and add static to makes sure the table ends up in read-only data.

platform/text/UnicodeRange.cpp: Added a const to make this read-only data.

10:13 AM Changeset in webkit [155969] by Darin Adler

2 edits in trunk/Source/WebCore

Shrink SVGElement::cssPropertyIdForSVGAttributeName and cssPropertyToTypeMap
https://bugs.webkit.org/show_bug.cgi?id=121499

Reviewed by Andreas Kling.

svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap): Added. Code that used to
be in SVGElement::cssPropertyIdForSVGAttributeName to build a map that maps
attribute names to CSS property IDs, but without the multiple unrolled calls
to HashMap functions.
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap): Added. Code that
used to be in cssPropertyToTypeMap, but without the multiple unrolled calls
to HashMap functions.
(WebCore::attributeNameToAnimatedPropertyTypeMap): Renamed from
cssPropertyToTypeMap, a confusingly inaccurate and imprecise name, and
reimplemented using the populate function.
(WebCore::SVGElement::animatedPropertyTypeForAttribute): Updated to call
attributeNameToAnimatedPropertyTypeMap, and also removed the double hashing
that was done by calling contains followed by get.
(WebCore::SVGElement::cssPropertyIdForSVGAttributeName): Rewrote to use
populateAttributeNameToCSSPropertyIDMap.
(WebCore::SVGElement::isAnimatableCSSProperty): Updated to call the new
attributeNameToAnimatedPropertyTypeMap.

10:09 AM Changeset in webkit [155968] by Darin Adler

5 edits in trunk/Source

Make SVGTransform::valueAsString use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121498

Reviewed by Andreas Kling.

Source/WebCore:

svg/SVGTransform.cpp:

(WebCore::SVGTransform::valueAsString): Use StringBuilder constently to
avoid creating temporary String objects that cause additional, slow
memory allocation.

Source/WTF:

wtf/text/StringBuilder.cpp: Added appendNumber functions corresponding to all remaining

String::number functions. If we find we don't need all of these we can delete them later,
but I don't want to give clients a reason to prefer less-efficient API to StringBuilder.

wtf/text/StringBuilder.h: Ditto.

10:07 AM Changeset in webkit [155967] by Darin Adler

3 edits in trunk/Source/WebCore

Get rid of a couple unneeded NeverDestroyed::get() calls
https://bugs.webkit.org/show_bug.cgi?id=121500

Reviewed by Andreas Kling.

css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoType): No need to call get() here.

dom/make_names.pl:

(printFactoryCppFile): Ditto.
(printWrapperFactoryCppFile): Ditto.

10:04 AM Changeset in webkit [155966] by timothy@apple.com

3 edits in trunk/Source/WebInspectorUI

Clean up the Inspector's WebSocket code and prevent it from dropping messages.

https://bugs.webkit.org/show_bug.cgi?id=121391

Reviewed by Joseph Pecoraro.

UserInterface/InspectorFrontendHostStub.js:

UserInterface/Main.js:

(WebInspector._initializeWebSocketIfNeeded): Move socket creation to initializeWebSocket.

9:46 AM Changeset in webkit [155965] by hmuller@adobe.com

3 edits
2 adds in trunk

Bad ASSERT() in RasterShapeIntervals::firstIncludedIntervalY()
https://bugs.webkit.org/show_bug.cgi?id=121455

Reviewed by Darin Adler.

Source/WebCore:

Corrected a bad ASSERT() introduced in https://bugs.webkit.org/show_bug.cgi?id=120211.

Test: fast/shapes/shape-inside/shape-inside-first-fit-crash.html

rendering/shapes/RasterShape.cpp:

(WebCore::RasterShapeIntervals::firstIncludedIntervalY):

LayoutTests:

Simple regression test, it crashes in the bad ASSERT().

fast/shapes/shape-inside/shape-inside-first-fit-crash-expected.txt: Added.
fast/shapes/shape-inside/shape-inside-first-fit-crash.html: Added.

9:41 AM Changeset in webkit [155964] by hyatt@apple.com

7 edits in trunk/Source/WebCore

Move the line widow functions out of RenderBlock and into RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=121456

Reviewed by Dean Jackson.

rendering/RenderBlock.cpp:
rendering/RenderBlock.h:

(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::relayoutToAvoidWidows):

rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::lineBreakToAvoidWidow):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):

rendering/RenderObject.h:

9:26 AM Changeset in webkit [155963] by andersca@apple.com

14 edits in trunk

HashMap should work with move-only keys
https://bugs.webkit.org/show_bug.cgi?id=121310

Reviewed by Darin Adler.

Source/WebCore:

Update the call sites now that HashMap::take doesn't return a PassOwnPtr.

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::takeRenderBoxRegionInfo):

rendering/RenderRegion.h:
rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removePendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):

svg/SVGDocumentExtensions.h:

Source/WTF:

Add extra overloads for add and set where the key is an rvalue reference, but not a
template parameter rvalue reference. This way we'll coerce the key parameter to have the expected
type instead of the passed in type, causing map.add(StringImpl::create("Hello"), 123) work when the
type of map is HashMap<String, unsigned>.

Also, sprinkle && and std::forward where appropriate.

wtf/HashMap.h:
wtf/HashTable.h:

Tools:

TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):
Add test.

9:00 AM Changeset in webkit [155962] by Antti Koivisto

4 edits in trunk/Source/WebCore

Add RenderObject bit for isBR().
https://bugs.webkit.org/show_bug.cgi?id=121494

Reviewed by Andreas Kling.

It is no longer piggybacking on isText() flag and is now hot in inline layout.

rendering/RenderBR.cpp:

(WebCore::RenderBR::RenderBR):

rendering/RenderBR.h:
rendering/RenderObject.h:

(WebCore::RenderObject::isBR):
(WebCore::RenderObject::setIsBR):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

8:54 AM Changeset in webkit [155961] by akling@apple.com

2 edits in trunk/Source/WebCore

Export some missing symbols for Internals after RenderArena& change.

WebCore.exp.in:

8:38 AM Changeset in webkit [155960] by kadam@inf.u-szeged.hu

3 edits
4 adds
1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip and rebase tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-17

platform/qt-wk2/TestExpectations:
platform/qt-wk2/compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added r155546.
platform/qt-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added r155607.
platform/qt-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added r155607.
platform/qt-wk2/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: Added r155546.
platform/qt-wk2/fast/replaced/border-radius-clip-expected.txt: Removed.
platform/qt/TestExpectations:

8:25 AM Changeset in webkit [155959] by Christophe Dumez

12 edits
3 adds in trunk

Set MessageEvent.source to the newly created port for shared workers' connect events
https://bugs.webkit.org/show_bug.cgi?id=121390

Reviewed by Darin Adler.

Source/WebCore:

Set MessageEvent.source to the newly created port for shared workers' connect events
instead of previously null, as per the latest specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#dom-messageevent-source
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dom-sharedworker

This behavior is consisent with Blink.

Test: fast/workers/shared-worker-messageevent-source.html

dom/EventTarget.cpp:

(WebCore::EventTarget::isMessagePort):

dom/EventTarget.h:
dom/MessageEvent.cpp:

(WebCore::isValidSource):
(WebCore::MessageEvent::MessageEvent):

dom/MessageEvent.h:

Use null String instead of an empty String as default value for origin and lastEventId.
This is more efficient and has no impact on the behavior on the JavaScript since a
null String is exposed as an empty one on JS side.
This change is covered by fast/events/constructors/message-event-constructor.html

dom/MessageEvent.idl:
dom/MessagePort.h:
page/DOMWindow.cpp:

(WebCore::PostMessageTimer::event):

workers/SharedWorkerGlobalScope.cpp:

(WebCore::createConnectEvent):

LayoutTests:

Add layout test to check that MessageEvent.source is set to the newly created port
for shared workers' connect events.

fast/events/constructors/message-event-constructor-expected.txt:
fast/events/constructors/message-event-constructor.html:
fast/workers/resources/messageevent-source.js: Added.

(onconnect):

fast/workers/shared-worker-messageevent-source-expected.txt: Added.
fast/workers/shared-worker-messageevent-source.html: Added.

8:18 AM Changeset in webkit [155958] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Fix Windows CE build on ARM.
https://bugs.webkit.org/show_bug.cgi?id=121490

Patch by Sergio Martins <sergio.martins@kdab.com> on 2013-09-17
Reviewed by Darin Adler.

wtf/dtoa/utils.h:

8:13 AM Changeset in webkit [155957] by Antti Koivisto

36 edits in trunk

RenderBR should not be RenderText
https://bugs.webkit.org/show_bug.cgi?id=121221

Reviewed by Darin Adler.

Source/WebCore:

Stop inheriting RenderBR from RenderText and make it be a RenderBoxModelObject instead. RenderBR was one
of the few cases where Element renderer was a RenderText. This will enable future cleanups.

RenderBR used little of RenderText mechanisms and was already heavily specialized everywhere. Layout code
didn't care about its text content at all. The new RenderText is also significatly more lightweight
than the old. As a line box it uses plain InlineBox instead of InlineTextBox.

The patch tries to avoid changing test results though there are a few changed render tree dumps without
visual effect. There are also two rendering progressions.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

dom/ContainerNode.cpp:

(WebCore::ContainerNode::getUpperLeftCorner):

dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

dom/Position.cpp:

(WebCore::hasInlineBoxWrapper):
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::getInlineBoxAndOffset):

dom/Range.cpp:

(WebCore::Range::textRects):
(WebCore::Range::textQuads):

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):

editing/Editor.cpp:

(WebCore::findFirstMarkable):

editing/TextIterator.cpp:

(WebCore::ignoresContainerClip):

editing/VisibleUnits.cpp:

(WebCore::CachedLogicallyOrderedLeafBoxes::previousTextOrLineBreakBox):
(WebCore::CachedLogicallyOrderedLeafBoxes::nextTextOrLineBreakBox):
(WebCore::logicallyPreviousBox):
(WebCore::logicallyNextBox):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):

rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
(WebCore::InlineBox::deleteLine):
(WebCore::InlineBox::extractLine):
(WebCore::InlineBox::attachLine):
(WebCore::InlineBox::paint):

rendering/InlineBox.h:

(WebCore::InlineBox::isLineBreak):

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeOverflow):

rendering/InlineIterator.h:

(WebCore::isIteratorTarget):

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::lineHeight):
(WebCore::InlineTextBox::isLineBreak):

rendering/RenderBR.cpp:

(WebCore::RenderBR::RenderBR):
(WebCore::RenderBR::~RenderBR):
(WebCore::RenderBR::createAnonymous):
(WebCore::RenderBR::lineHeight):
(WebCore::RenderBR::baselinePosition):
(WebCore::RenderBR::createInlineBox):
(WebCore::RenderBR::setInlineBoxWrapper):
(WebCore::RenderBR::replaceInlineBoxWrapper):
(WebCore::RenderBR::deleteInlineBoxWrapper):
(WebCore::RenderBR::dirtyLineBoxes):
(WebCore::RenderBR::caretMinOffset):
(WebCore::RenderBR::caretMaxOffset):
(WebCore::RenderBR::canBeSelectionLeaf):
(WebCore::RenderBR::setSelectionState):
(WebCore::RenderBR::localCaretRect):
(WebCore::RenderBR::linesBoundingBox):
(WebCore::RenderBR::absoluteRects):
(WebCore::RenderBR::absoluteQuads):
(WebCore::RenderBR::updateFromStyle):
(WebCore::RenderBR::borderBoundingBox):

rendering/RenderBR.h:

(WebCore::toRenderBR):

rendering/RenderBlock.cpp:

(WebCore::InlineMinMaxIterator::next):
(WebCore::RenderBlock::updateFirstLetter):

rendering/RenderBlockLineLayout.cpp:

(WebCore::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::requiresLineBox):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::canBreakAtThisPosition):

rendering/RenderInline.cpp:

(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
(WebCore::RenderInline::dirtyLineBoxes):

rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::styleDidChange):
(WebCore::RenderMenuList::setText):
(WebCore::RenderMenuList::text):

rendering/RenderMenuList.h:
rendering/RenderObject.h:

(WebCore::RenderObject::isBeforeContent):
(WebCore::RenderObject::isAfterContent):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

rendering/RenderText.cpp:

(WebCore::RenderText::removeAndDestroyTextBoxes):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::setTextInternal):

rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):

LayoutTests:

editing/selection/move-by-word-visually-mac-expected.txt:

This is a progression. A previously failing subtest passes.

platform/mac/css3/selectors3/html/css3-modsel-179a-expected.txt:
platform/mac/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
platform/mac/css3/selectors3/xml/css3-modsel-179a-expected.txt:

Changes in render tree dump that don't affect rendering.

platform/mac/fast/css/pseudo-first-line-border-width-expected.txt:

This is a progression. The new rendering matches Firefox.

platform/mac/fast/css/word-space-extra-expected.txt:
platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:

Changes in render tree dump that don't affect rendering.

8:10 AM Changeset in webkit [155956] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Buildfix for !(ENABLE(WEB_ARCHIVE)

ENABLE(MHTML)) platforms

https://bugs.webkit.org/show_bug.cgi?id=121491

Reviewed by Darin Adler.

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

7:57 AM Changeset in webkit [155955] by akling@apple.com

12 edits in trunk/Source/WebCore

Dodge more work during render tree teardown.
<https://webkit.org/b/121487>

Reviewed by Antti Koivisto.

Add a Document::hasLivingRenderTree() method that returns true if
there's a render tree attached to the document and it's not in the
process of being torn down.

Deploy this check in a number of places that were only checking
for the presence of a RenderView.

7:52 AM Changeset in webkit [155954] by eric.carlson@apple.com

9 edits in trunk

MediaStream API: Adding an async RTCPeerConnection::addIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=121403

Source/WebCore:

Merged from https://chromium.googlesource.com/chromium/blink/+/5bd81fda88d48dd2780832246e7d1ab973ee7a1d

Reviewed by Darin Adler.

No new tests, updated RTCPeerConnection-ice.html.

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addIceCandidate): Add success and error callbacks.

Modules/mediastream/RTCPeerConnection.h:
Modules/mediastream/RTCPeerConnection.idl:

platform/mediastream/RTCPeerConnectionHandler.h: Changed addIceCandidate signature.

platform/mediastream/RTCVoidRequest.h: Removed ExtraData, it is unnecessary.

LayoutTests:

Reviewed by Darin Adler.

fast/mediastream/RTCPeerConnection-ice-expected.txt:
fast/mediastream/RTCPeerConnection-ice.html:

6:44 AM Changeset in webkit [155953] by berto@igalia.com

2 edits in trunk/Source/WebKit2

[GTK] Unreviewed make distcheck fix.

GNUmakefile.am: include WebProcess/Network/*.in in the tarball,

it's needed for generating WebResourceLoaderMessage*.{cpp,h}.

6:38 AM Changeset in webkit [155952] by Carlos Garcia Campos

8 edits in trunk/Source/WebCore

[GTK] Do not include Returns tag in api doc for methods returning void
https://bugs.webkit.org/show_bug.cgi?id=121488

Reviewed by Philippe Normand.

bindings/gobject/WebKitDOMCustom.h:
bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction): Only add Returns tag for methods not returning
void.

bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:

6:24 AM Changeset in webkit [155951] by michael.bruning@digia.com

2 edits in trunk/Source/WebCore

Correct range used for Emoji checks.
https://bugs.webkit.org/show_bug.cgi?id=121486

Reviewed by Allan Sandfeld Jensen.

Found and reported by David Binderman via Qt bug tracker.

The check if a character was in the Emoji range always evaluated to
false due to the upper range limit being lower than the lower limit.

Changed the upper limit to the highest assigned character from the
"Transport and Map Symbols" (0x1F6C5) as that seems to have been the
intended upper range limit of this check.

platform/graphics/Font.cpp:

(WebCore::Font::isCJKIdeographOrSymbol):

5:40 AM Changeset in webkit [155950] by mihnea@adobe.com

2 edits in trunk/Source/WTF

REGRESSION(r155910): WebKit nightly builds don't load any page
https://bugs.webkit.org/show_bug.cgi?id=121482

Reviewed by Andreas Kling.

Replaced C++ style comments with C style comments.

wtf/Platform.h:

5:33 AM Changeset in webkit [155949] by Antti Koivisto

4 edits in trunk/Source/WebCore

Move text caret rect computation to root inline box
https://bugs.webkit.org/show_bug.cgi?id=121479

Reviewed by Andreas Kling.

For future code sharing.

rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::computeCaretRect):

rendering/RootInlineBox.h:

5:17 AM Changeset in webkit [155948] by berto@igalia.com

2 edits in trunk/Source/WebCore

[GTK] Don't make the GObject DOM bindings API break test fatal
https://bugs.webkit.org/show_bug.cgi?id=121484

Reviewed by Carlos Garcia Campos.

The API varies depending on the compilation options, so this can
easily produce false positives.

Until we figure out a way to handle this situation we shouldn't
make this test fatal.

bindings/scripts/gobject-run-api-break-test:

(check_api):

5:05 AM Changeset in webkit [155947] by mihnea@adobe.com

1 edit
2 adds in trunk/LayoutTests

[CSSRegions] Flowed fixed element without its transformed parent positioned relative to viewport
https://bugs.webkit.org/show_bug.cgi?id=121478

Reviewed by Antti Koivisto.

A fixed positioned element collected into a named flow without its transformed parent should be positioned relative to the viewport instead of the transformed parent. Add a test for this behavior.

fast/regions/flow-fixed-element-transformed-parent-expected.txt: Added.
fast/regions/flow-fixed-element-transformed-parent.html: Added.

5:02 AM Changeset in webkit [155946] by mihnea@adobe.com

2 edits in trunk/Source/WebCore

[CSSRegions] Replace generatingNode() with generatingElement() for RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=121469

Reviewed by Antti Koivisto.

The fix for https://bugs.webkit.org/show_bug.cgi?id=120397 replaced node() with generatingElement() for regions, but i forgot about replacing generatingNode() with generatingElement() in RenderNamedFlowThread::compareRenderRegions. This is needed in preparation for regions as anonymous blocks refactoring in https://bugs.webkit.org/show_bug.cgi?id=119135.

No new functionality introduced, therefore no new tests.

rendering/RenderNamedFlowThread.cpp:

(WebCore::compareRenderRegions):

4:58 AM Changeset in webkit [155945] by berto@igalia.com

2 edits in trunk/Tools

BrowserMarshal.h build fail
https://bugs.webkit.org/show_bug.cgi?id=102938

Patch by YuTeh Shen <shenyute@hotmail.com> on 2013-09-17
Reviewed by Carlos Garcia Campos.

Fix variable name.

MiniBrowser/gtk/GNUmakefile.am:

4:05 AM Changeset in webkit [155944] by akling@apple.com

35 edits in trunk/Source/WebCore

CTTE: Pass RenderArena around by reference.
<https://webkit.org/b/121470>

Reviewed by Antti Koivisto.

Pass the RenderArena around by reference in all render tree code.
This code will never be running without an arena.

3:24 AM Changeset in webkit [155943] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

[GTK] GObject DOM symbols file is not generated for video related classes
https://bugs.webkit.org/show_bug.cgi?id=121476

Reviewed by Philippe Normand.

The problem is that we are using a different path for video
related header files in the Makefile, it's the same path in
practice, because we are just prepending ./ to the path, but the
rules that parse those paths don't expect the ./ at the beginning.

bindings/gobject/GNUmakefile.am: Use the same path for video

related header files as the other paths in
webkitgtk_gdom_built_h_api.

bindings/gobject/webkitdom.symbols: Updated to include the

symbols of the video related clases.

2:47 AM Changeset in webkit [155942] by Csaba Osztrogonác

3 edits in trunk/Source/WebKit2

[GTK][EFL] Add ResourceError::internalError() after r138387
https://bugs.webkit.org/show_bug.cgi?id=121433

Reviewed by Christophe Dumez.

Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>

WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:

(WebKit::internalError):

WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

(WebKit::internalError):

2:44 AM Changeset in webkit [155941] by berto@igalia.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed make distcheck fix.

GNUmakefile.list.am:

2:38 AM Changeset in webkit [155940] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests.

platform/qt-wk1/TestExpectations:

2:32 AM Changeset in webkit [155939] by akling@apple.com

2 edits in trunk/Source/WebKit

Some build juice for Windows.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

2:27 AM Changeset in webkit [155938] by akling@apple.com

16 edits
2 deletes in trunk/Source/WebCore

Remove ContextFeatures.
<https://webkit.org/b/121473>

Reviewed by Antti Koivisto.

This was only used by the chromium port, nobody implements ContextFeaturesClient.

1:53 AM Changeset in webkit [155937] by akling@apple.com

2 edits in trunk/Source/WebCore

Un-dork the build. :|

1:44 AM Changeset in webkit [155936] by akling@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, fix clang warning when building without ENABLE(STYLE_SCOPED).

1:39 AM Changeset in webkit [155935] by Csaba Osztrogonác

7 edits in trunk/Source/WebKit2

Fix Qt WK2 build after r155888
https://bugs.webkit.org/show_bug.cgi?id=121471

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-17
Reviewed by Csaba Osztrogonác.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::createDrawingAreaProxy):

UIProcess/API/qt/qquickwebview_p_p.h:
UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebViewPrivate::createDrawingAreaProxy):

UIProcess/API/qt/raw/qrawwebview_p_p.h:
UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::createDrawingAreaProxy):

UIProcess/qt/QtPageClient.h:

1:22 AM Changeset in webkit [155934] by Csaba Osztrogonác

6 edits in trunk/Source/WebKit2

[GTK][EFL] Add NetworkProcess support for ProcessLauncher
https://bugs.webkit.org/show_bug.cgi?id=121434

Reviewed by Sam Weinig.

Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>

Shared/ProcessExecutablePath.h:
Shared/efl/ProcessExecutablePathEfl.cpp:

(WebKit::executablePathOfNetworkProcess):

Shared/gtk/ProcessExecutablePathGtk.cpp:

(WebKit::executablePathOfNetworkProcess):

UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

1:20 AM Changeset in webkit [155933] by Csaba Osztrogonác

5 edits in trunk/Source/WebKit2

Buildfix for !USE(PROTECTION_SPACE_AUTH_CALLBACK) platforms
https://bugs.webkit.org/show_bug.cgi?id=121431

Reviewed by Alexey Proskuryakov.

Mising guards added.

Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>

NetworkProcess/NetworkResourceLoader.messages.in:
WebProcess/Network/WebResourceLoader.cpp:
WebProcess/Network/WebResourceLoader.h:
WebProcess/Network/WebResourceLoader.messages.in:

1:18 AM Changeset in webkit [155932] by Csaba Osztrogonác

6 edits in trunk/Source/WebKit2

WebResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=121424

Reviewed by Alexey Proskuryakov.

Original patch by Balazs Kelemen <kbalazs@webkit.org>.

CMakeLists.txt:
DerivedSources.pri:
GNUmakefile.am:
GNUmakefile.list.am:
WebProcess/Network/WebResourceLoader.messages.in: ENABLE(NETWORK_PROCESS) guard added.

1:13 AM Changeset in webkit [155931] by akling@apple.com

9 edits in trunk/Source/WebCore

Move <style scoped> code behind ENABLE(STYLE_SCOPED)
<https://webkit.org/b/121018>

Reviewed by Darin Adler.

Move all the code for <style scoped> behind ENABLE(STYLE_SCOPED) guards.
It's not nice to clutter common codepaths with code that always executes
even though the feature is disabled at compile-time.

12:01 AM Changeset in webkit [155930] by Manuel Rego Casasnovas

2 edits in trunk/Source/WebKit2

Unreviewed, fixing the GTK WK2 debug build after r155911.

UIProcess/API/gtk/WebKitFaviconDatabase.cpp: Add missing using

namespace WebCore.

Sep 16, 2013:

9:23 PM Changeset in webkit [155929] by Brent Fulgham

3 edits in trunk/Tools

[Windows] Clean up WinLauncher by using smart pointers
https://bugs.webkit.org/show_bug.cgi?id=121467

Reviewed by Anders Carlsson.

WinLauncher/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.

WinLauncher/WinLauncher.cpp:

(WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
(WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
(showLastVisitedSites): Smart pointer updates.
(WinLauncherWebHost::didFinishLoadForFrame): Ditto.
(setToDefaultPreferences): Ditto.
(dllLauncherEntryPoint): Ditto.
(PrintView): Ditto.
(LaunchInspector): Ditto.
(NavigateToHistory): Ditto.
(MyEditProc): Ditto.
(loadURL): Ditto.

9:22 PM Changeset in webkit [155928] by weinig@apple.com

69 edits in trunk/Source/WebCore

CTTE: InputType should store its HTMLInputElement back pointer as a reference
https://bugs.webkit.org/show_bug.cgi?id=121466

Reviewed by Anders Carlsson.

Converts InputType::create() and InputType::createText() to take a HTMLInputElement& (as well as all the subclasses).
Change InputType::element() to return an HTMLInputElement& and update all the callers.

9:15 PM Changeset in webkit [155927] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

Fix EFL build after r155888
https://bugs.webkit.org/show_bug.cgi?id=121465

Patch by Sergio Correia <Sergio Correia> on 2013-09-16
Reviewed by Gyuyoung Kim.

Update WebView to follow the changes in PageClient in r155888.

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::createDrawingAreaProxy): Use createOwned (addded in
r155407) to return the DrawingAreaProxy from DrawingAreaProxyImpl.

UIProcess/CoordinatedGraphics/WebView.h: Update createDrawingAreaProxy()

signature to match PageClient.h.

6:49 PM Changeset in webkit [155926] by commit-queue@webkit.org

4 edits in trunk/Source/WTF

USE(WEB_THREAD): More explicit WebThread initialization
https://bugs.webkit.org/show_bug.cgi?id=121454

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-16
Reviewed by Benjamin Poulain.

Be more explicit when initializing WebThread only data.

wtf/MainThread.h:
wtf/MainThread.cpp:

(WTF::initializeWebThreadOnce):
(WTF::initializeWebThread):
Ensure one time initialization.

wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeWebThreadPlatform):
Move WebThread value initialization to its own function.

(WTF::isMainThread):
Remove no longer invalid assert if WebThread was not initialized.

6:39 PM Changeset in webkit [155925] by Lucas Forschler

5 edits
2 copies in branches/safari-537.60-branch/Source/WebCore

Merged r155226. <rdar://problem/14949946>

6:31 PM Changeset in webkit [155924] by timothy@apple.com

9 edits in trunk/Source

Make InspectorTimelineAgent use an enum for the record type instead of a string.

https://bugs.webkit.org/show_bug.cgi?id=121461

Reviewed by Joseph Pecoraro.

Source/WebCore:

inspector/Inspector.json:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):

Source/WebInspectorUI:

UserInterface/InspectorBackendCommands.js:
UserInterface/Legacy/6.0/InspectorBackendCommands.js:
UserInterface/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):

Versions/Inspector-iOS-6.0.json:

6:26 PM Changeset in webkit [155923] by Lucas Forschler

4 edits
1 copy
1 delete in branches/safari-537.60-branch/Source/WebCore

Merged r155215. <rdar://problem/14949946>

6:26 PM Changeset in webkit [155922] by Brent Fulgham

6 edits in trunk/Tools

[Windows] Add rudimentary history to WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=121463

Reviewed by Anders Carlsson.

WinLauncher/WinLauncher.cpp:

(updateMenuItemForHistoryItem): Added
(showLastVisitedSites): Added
(WinLauncherWebHost::didFinishLoadForFrame): Add history item once
a new page has been visited.
(dllLauncherEntryPoint): Deallocate history on exit.
(NavigateToHistory): Added
(WndProc): Add handler for history entries

WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold

up to 10 history slots.

WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against

Windows utility library to allow use of _bstr_t type.

WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items

to hold up to 10 history slots.

WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.

6:21 PM Changeset in webkit [155921] by Lucas Forschler

3 edits in branches/safari-537.60-branch/Source/WebKit/win

Merged r155212. <rdar://problem/14949951>

6:18 PM Changeset in webkit [155920] by Lucas Forschler

5 edits in branches/safari-537.60-branch/Source/WebCore

Merged r155130. <rdar://problem/14932481>

6:16 PM Changeset in webkit [155919] by Lucas Forschler

2 edits in branches/safari-537.60-branch/Source/WebCore

Merged r155127. <rdar://problem/14932481>

6:08 PM Changeset in webkit [155918] by kov@webkit.org

13 edits
3 adds in trunk

[GTK] Make symbol export filter more strict, and disable for dev/test builds
https://bugs.webkit.org/show_bug.cgi?id=120586

Reviewed by Martin Robinson.

GNUmakefile.am: only include test-related automake files when developer

mode is on.

Source/autotools/ReadCommandLineArguments.m4: add --enable-developer-mode,

defaults to no, and to yes for debug builds.

Source/autotools/SetupAutomake.m4: add ENABLE_DEVELOPER_MODE conditional.
Source/autotools/symbols.filter: make the exported symbols list much shorter,

covering only the public ABI and a few symbols required by WebKit2 processes.

Source/WebKit/gtk:

GNUmakefile.am: only use the version script when in developer mode..

Source/WebKit2:

GNUmakefile.am: only use the version script if developer mode is disabled.

Tools:

GNUmakefile.am: moved GtkLauncher and documentation builds to their own

makefiles, so they can be included unconditionally.

GtkLauncher/GNUmakefile.am: added.
Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
to configure, since we consider builds done through build-webkit to be development
and test builds.

gtk/GNUmakefile.am: added.
gtk/common.py: do not use the Scripts directory as a reference to the top path;

it's not necessary and it will not work now that the Scripts directory is not
shipped in the tarball.

6:07 PM Changeset in webkit [155917] by Lucas Forschler

4 edits in branches/safari-537.60-branch/Source/WebCore

Merged r154915. <rdar://problem/14932478>

6:04 PM Changeset in webkit [155916] by Lucas Forschler

9 edits in branches/safari-537.60-branch/Source/WebCore

Merged r154914. <rdar://problem/14932478>

6:01 PM Changeset in webkit [155915] by benjamin@webkit.org

2 edits in trunk/Source/WTF

Fix WebKit1 build after r155910

Reviewed by Anders Carlsson.

wtf/Platform.h: Some files in WebKit include system headers before

WTF headers, causing the macro to be defined twice. #undef the macro
to support that case.

6:00 PM Changeset in webkit [155914] by Lucas Forschler

2 edits in branches/safari-537.60-branch/Source/WebCore

Merged r154890. <rdar://problem/14932478>

5:31 PM Changeset in webkit [155913] by kov@webkit.org

2 edits in trunk/Source/WebKit2

Unreviewed build fix after 155905.

Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::sendOutgoingMessage): use OwnPtr instead of PassOwnPtr.

4:39 PM Changeset in webkit [155912] by benjamin@webkit.org

2 edits in trunk/Source/WTF

Disable OS X's unprefixed debug macro
https://bugs.webkit.org/show_bug.cgi?id=121460

Reviewed by Anders Carlsson.

wtf/Platform.h: OS X defines a series of platform macros for debugging.

Some of them are really annoying because they use common names (e.g. check()).

Disable those macros so that we are not limited in how we name methods and functions.

4:32 PM Changeset in webkit [155911] by Joseph Pecoraro

8 edits in trunk/Source

Add RunLoop::isMain and use it in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121459

Reviewed by Anders Carlsson.

Source/WebCore:

WebCore.exp.in:
platform/RunLoop.cpp:

(WebCore::RunLoop::isMain):

platform/RunLoop.h:

Source/WebKit2:

UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously):
(iconDataReadyForPageURLCallback):
(webkit_favicon_database_get_favicon_uri):

UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
(-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]):
(pageDidDrawToImage):
(pageDidDrawToPDF):
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(pageDidComputePageRects):
(-[WKPrintingView _askPageToComputePageRects]):
(prepareDataForPrintingOnSecondaryThread):
(-[WKPrintingView knowsPageRange:]):
(-[WKPrintingView _drawPreview:]):
(-[WKPrintingView drawRect:]):
(-[WKPrintingView _drawPageBorderWithSizeOnMainThread:]):
(-[WKPrintingView drawPageBorderWithSize:]):

UIProcess/WebProcessProxy.cpp:

(WebKit::globalPageMap):

4:30 PM Changeset in webkit [155910] by benjamin@webkit.org

2 edits in trunk/Source/WTF

Disable OS X's unprefixed debug macro
https://bugs.webkit.org/show_bug.cgi?id=121460

Reviewed by Anders Carlsson.

wtf/Platform.h: OS X defines a serie of platform macros for debugging.

Some of them are really annoying because they use common names (e.g. check()).

Disable those macros so that we are not limited how we name methods and functions.

3:57 PM Changeset in webkit [155909] by Chris Fleizach

3 edits
2 adds in trunk

AX: ARIA tablist is disabled, but VoiceOver does not speak the tabs as dimmed
https://bugs.webkit.org/show_bug.cgi?id=121408

Reviewed by Darin Adler.

Source/WebCore:

ARIA says that aria-disabled should propagate to children nodes.

Test: accessibility/aria-disabled-propagated-to-children.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isEnabled):

LayoutTests:

accessibility/aria-disabled-propagated-to-children-expected.txt: Added.
accessibility/aria-disabled-propagated-to-children.html: Added.

3:20 PM Changeset in webkit [155908] by weinig@apple.com

167 edits in trunk/Source/WebCore

CTTE: Element::createRenderer() should take references
https://bugs.webkit.org/show_bug.cgi?id=121449

Reviewed by Anders Carlsson.

*Many file elided*

3:16 PM Changeset in webkit [155907] by enrica@apple.com

2 edits in trunk/Source/WebCore

iOS build fix after r155638.

Unreviewed.

editing/Editor.cpp:

3:01 PM Changeset in webkit [155906] by Bem Jones-Bey

5 edits in trunk/Source/WebCore

Make FloatingObjects own it's FloatingObject instances
https://bugs.webkit.org/show_bug.cgi?id=121323

Reviewed by Alexandru Chiculita.

As part of decoupling FloatingObjects from RenderBlock, change
FloatingObjects to properly manage the FloatingObject instances it
contains.

No new tests, no behavior change.

rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::FloatingObject): Make the constructors
private so that FloatingObjects can only be created with an OwnPtr.
Also make a RenderBox required to create a FloatingObject.
(WebCore::FloatingObject::create): Factory method to create a vanilla
FloatingObject.
(WebCore::FloatingObject::copyToNewContainer): Factory method to copy
an existing FloatingObject in the case it is overhanging or intruding
and needs to be copied to the block that it overhangs or intrudes
into.
(WebCore::FloatingObject::unsafeClone): Rename this method so it is
more obvious that it really shouldn't be used, and to make it more
obvious that one should use the copyToNewContainer method for all
normal FloatingObject copies.
(WebCore::FloatingObjects::clear): Delete all the FloatingObjects in
the set before clearing it.
(WebCore::FloatingObjects::moveAllToFloatInfoMap): Move all of the
FloatingObjects in the set to a RendererToFloatInfoMap. This is used
in RenderBlockFlow::clearFloats to when it is readding floats after
clearing the set.
(WebCore::FloatingObjects::add): Take an OwnPtr.
(WebCore::FloatingObjects::remove): Delete the removed FloatingObject.

rendering/FloatingObjects.h: Remove FloatingObject::setRenderer(),

since the RenderBox must be set in the constructor.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo): Rename clone
to unsafeClone.
(WebCore::RenderBlock::removeFloatingObjects): Don't delete anymore,
since clear does it.
(WebCore::RenderBlock::insertFloatingObject): Handle OwnPtr properly.
(WebCore::RenderBlock::removeFloatingObject): Don't delete anymore,
since remove does it.
(WebCore::RenderBlock::removeFloatingObjectsBelow): Ditto.
(WebCore::RenderBlock::addOverhangingFloats): Use copyToNewContainer
and OwnPtr.
(WebCore::RenderBlock::addIntrudingFloats): Ditto.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats): Use exportToFloatInfoMap.

3:00 PM Changeset in webkit [155905] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Replace more uses of PassOwnPtr with OwnPtr in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121453

Reviewed by Sam Weinig.

Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SecondaryThreadPendingSyncReply::SecondaryThreadPendingSyncReply):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::enqueueIncomingMessage):
(CoreIPC::Connection::dispatchMessage):

Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::PendingSyncReply::PendingSyncReply):

Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

2:59 PM Changeset in webkit [155904] by ap@apple.com

2 edits in trunk/LayoutTests

Flaky Test: svg/batik/masking/maskRegions.svg
https://bugs.webkit.org/show_bug.cgi?id=114120

Fails in the same way as many other batik tests.

platform/mac/TestExpectations: Marking as flaky.

2:46 PM Changeset in webkit [155903] by Hugo Parente Lima

2 edits in trunk/Source/WebCore

Fix creation of embedded JS and CSS files on cmake based ports.
https://bugs.webkit.org/show_bug.cgi?id=121448

Reviewed by Joseph Pecoraro.

Just a build fix, layout tests already test this issue.

CMakeLists.txt:

2:35 PM Changeset in webkit [155902] by ap@apple.com

2 edits in trunk/LayoutTests

Marked a few tests that are too slow in debug builds, and frequently fail.

platform/mac/TestExpectations:

2:30 PM Changeset in webkit [155901] by Brent Fulgham

3 edits in trunk/Source/WebKit/win

[Windows] Rendering stops when mouse is moving for some types of animations.
https://bugs.webkit.org/show_bug.cgi?id=121329

Reviewed by Anders Carlsson.

WebView.cpp:

(WebView::WebView): Add new display flag.
(WebView::repaint): Mark view as needing a display operation.
(WebView::addToDirtyRegion): Ditto
(WebView::scrollBackingStore): Ditto
(WebView::sizeChanged): Ditto
(WebView::updateBackingStore): Ditto
(WebView::performLayeredWindowUpdate): Mark the WebView as having been
moved to screen.
(WebView::paintIntoWindow): Ditto
(WebView::WebViewWndProc): If the view needs display, and it was not done during
this message loop iteration, draw the screen.

WebView.h:

(WebView::needsDisplay): Added

2:09 PM Changeset in webkit [155900] by andersca@apple.com

7 edits in trunk/Source

MessageQueue should use a Deque of OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=121450

Reviewed by Andreas Kling.

Source/WebCore:

Modules/webdatabase/DatabaseThread.cpp:

(WebCore::SameDatabasePredicate::operator()):

dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):

fileapi/FileThread.cpp:

(WebCore::SameInstancePredicate::operator()):

workers/WorkerRunLoop.cpp:

(WebCore::ModePredicate::operator()):

Source/WTF:

wtf/MessageQueue.h:

2:01 PM Changeset in webkit [155899] by zandobersek@gmail.com

5 edits in releases/WebKitGTK/webkit-2.2

[GTK][2.2] Enable the Wayland target by default if the GTK+ Wayland dependency is available
https://bugs.webkit.org/show_bug.cgi?id=121414

Reviewed by Martin Robinson.

Source/autotools/FindDependencies.m4: If the Wayland target is not strictly disabled, also check that the GTK+ Wayland

package (gtk+-wayland-3.0) has a recent-enough version. If the dependency could not be satisfied, either a warning or an
error is printed out, depending if the Wayland target was required or just optional.

Source/autotools/PrintBuildConfiguration.m4: Add a new macro, AM_APPEND_TO_DESRIPTION, that's helpful when producing

a description string that can contain multiple items that should be nicely formatted when listed in that string. This is
then used when creating the description for all the enabled targets, so for instance 'x11, wayland' string would be displayed
if both the X11 and Wayland targets are enabled.

Source/autotools/ReadCommandLineArguments.m4: The --with-target configuration options should default to 'x11,wayland' if

not given, with the Wayland target in that case not being a hard requirement (i.e. it should be disabled if the dependencies
for the Wayland target could not be found).

Source/autotools/Versions.m4: The GTK+ Wayland dependency should be of version 3.9.14 or greater (the 3.10 release series).

1:39 PM Changeset in webkit [155898] by andersca@apple.com

4 edits in trunk

WTF::Deque should work with move only types
https://bugs.webkit.org/show_bug.cgi?id=121446

Reviewed by Andreas Kling.

Source/WTF:

wtf/Deque.h:

Use std::move and std::forward where appropriate and get rid of the PassTraits include.

Tools:

TestWebKitAPI/Tests/WTF/Deque.cpp:

(TestWebKitAPI::TEST):
Add a test.

1:34 PM Changeset in webkit [155897] by ap@apple.com

2 edits in trunk/LayoutTests

svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280

The tests are still flaky. Ran out of ideas, so marking them as such and leaving them there.

platform/mac/TestExpectations:

1:24 PM Changeset in webkit [155896] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: TypeError when updating ResourceTreeElement created in strange order
https://bugs.webkit.org/show_bug.cgi?id=121382

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-16
Reviewed by Timothy Hatcher.

Patch by Brian Burg. Fix an uncaught exception that can happen on navigations.

UserInterface/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype._updateStatus):

1:14 PM Changeset in webkit [155895] by zandobersek@gmail.com

3 edits in trunk/Source/WebKit2

Unreviewed, fixing the GTK WK2 build after r155888.

UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createDrawingAreaProxy):

UIProcess/API/gtk/PageClientImpl.h:

1:09 PM Changeset in webkit [155894] by akling@apple.com

10 edits in trunk/Source/WebCore

CTTE: FrameTree::top() should return a reference.
<https://webkit.org/b/121445>

Reviewed by Anders Carlsson.

There's always a top frame in the tree.

1:01 PM Changeset in webkit [155893] by zandobersek@gmail.com

1 edit
14 adds in trunk/Source/WebCore

Unreviewed, fixing GObject bindings tests after r155850 by adding the *.symbols files that are now also generated.

bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestCallback.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestEventTarget.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestException.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestInterface.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestNode.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestObj.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.symbols: Added.
bindings/scripts/test/GObject/WebKitDOMTestTypedefs.symbols: Added.

12:56 PM Changeset in webkit [155892] by dbates@webkit.org

3 edits in trunk/Source/WebCore

Fix the build following <http://trac.webkit.org/changeset/155591>
(https://bugs.webkit.org/show_bug.cgi?id=121200)

Fix the build for ports that enable PLUGIN_PROXY_FOR_VIDEO, such as iOS WebKit.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Substitute isWidget() for isRenderWidget()
as the latter is undefined.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForVideo): Ditto.

12:48 PM Changeset in webkit [155891] by mhahnenberg@apple.com

14 edits
1 add in trunk/Source/JavaScriptCore

MarkedBlocks shouldn't be put in Allocated state if they didn't produce a FreeList
https://bugs.webkit.org/show_bug.cgi?id=121236

Reviewed by Geoffrey Garen.

Right now, after a collection all MarkedBlocks are in the Marked block state. When lazy sweeping
happens, if a block returns an empty free list after being swept, we call didConsumeFreeList(),
which moves the block into the Allocated block state. This happens to both the block that was
just being allocated out of (i.e. m_currentBlock) as well as any blocks who are completely full.
We should distinguish between these two cases: m_currentBlock should transition to
Allocated (because we were just allocating out of it) and any subsequent block that returns an
empty free list should transition back to the Marked state. This will make the block state more
consistent with the actual state the block is in, and it will also allow us to speed up moving
all blocks the the Marked state during generational collection.

Added new RAII-style HeapIterationScope class that notifies the Heap when it is about to be
iterated and when iteration has finished. Any clients that need accurate liveness data when
iterating over the Heap now need to use a HeapIterationScope so that the state of Heap can
be properly restored after they are done iterating. No new GC-allocated objects can be created
until this object goes out of scope.

JavaScriptCore.xcodeproj/project.pbxproj:
debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions): Added HeapIterationScope for the Recompiler iteration.

heap/Heap.cpp:

(JSC::Heap::willStartIterating): Callback used by HeapIterationScope to indicate that iteration of
the Heap is about to begin. This will cause cell liveness data to be canonicalized by calling stopAllocating.
(JSC::Heap::didFinishIterating): Same, but indicates that iteration has finished.
(JSC::Heap::globalObjectCount): Used HeapIterationScope.
(JSC::Heap::objectTypeCounts): Ditto.
(JSC::Heap::markDeadObjects): Ditto.
(JSC::Heap::zombifyDeadObjects): Ditto.

heap/Heap.h:
heap/HeapIterationScope.h: Added. New RAII-style object for indicating to the Heap that it's about

to be iterated or that iteration has finished.
(JSC::HeapIterationScope::HeapIterationScope):
(JSC::HeapIterationScope::~HeapIterationScope):

heap/HeapStatistics.cpp:

(JSC::HeapStatistics::showObjectStatistics): Used new HeapIterationScope.

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): We now treat the case where we have just finished
allocating out of the current block differently from the case where we sweep a block and it
returns an empty free list. This was the primary point of this patch.
(JSC::MarkedAllocator::allocateSlowCase): ASSERT that nobody is currently iterating the Heap
when allocating.

heap/MarkedAllocator.h:

(JSC::MarkedAllocator::reset): All allocators are reset after every collection. We need to make
sure that the m_lastActiveBlock gets cleared, which it might not always because we don't call
takeCanonicalizedBlock on blocks in the large allocators.
(JSC::MarkedAllocator::stopAllocating): We shouldn't already have a last active block,
so ASSERT as much.
(JSC::MarkedAllocator::resumeAllocating): Do the opposite of what stopAllocating
does. So, if we don't have a m_lastActiveBlock then we don't have to worry about undoing anything
done by stopAllocating. If we do, then we call resumeAllocating on the block, which returns the FreeList
as it was prior to stopping allocation. We then set the current block to the last active block and
clear the last active block.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::resumeAllocating): Any block resuming allocation should be in
the Marked state, so ASSERT as much. We always allocate a m_newlyAllocated Bitmap if we're
FreeListed, so if we didn't allocate one then we know we were Marked when allocation was stopped,
so just return early with an empty FreeList. If we do have a non-null m_newlyAllocated Bitmap
then we need to be swept in order to rebuild our FreeList.

heap/MarkedBlock.h:

(JSC::MarkedBlock::didConsumeEmptyFreeList): This is called if we ever sweep a block and get back
an empty free list. Instead of transitioning to the Allocated state, we now go straight back to the
Marked state. This makes sense because we weren't actually allocated out of, so we shouldn't be in
the allocated state. Also added some ASSERTs to make sure that we're in the state that we expect: all of
our mark bits should be set and we should not have a m_newlyAllocated Bitmap.

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::forEachAllocator): Added a new functor-style iteration method so that we can
easily iterate over each allocator for, e.g., stopping and resuming allocators without
duplicating code.
(JSC::StopAllocatingFunctor::operator()): New functors for use with forEachAllocator.
(JSC::MarkedSpace::stopAllocating): Ditto.
(JSC::ResumeAllocatingFunctor::operator()): Ditto.
(JSC::MarkedSpace::resumeAllocating): Ditto.
(JSC::MarkedSpace::willStartIterating): Callback that notifies MarkedSpace that it is being iterated.
Does some ASSERTs, sets a flag, canonicalizes cell liveness data by calling stopAllocating.
(JSC::MarkedSpace::didFinishIterating): Ditto, but to signal that iteration has completed.

heap/MarkedSpace.h:

(JSC::MarkedSpace::iterationInProgress): Returns true if a HeapIterationScope is currently active.
(JSC::MarkedSpace::forEachLiveCell): Accepts a HeapIterationScope to enforce the rule that you have to
create one prior to iterating over the Heap.
(JSC::MarkedSpace::forEachDeadCell): Ditto.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::haveABadTime): Changed to use new HeapIterationScope.

runtime/VM.cpp:

(JSC::VM::releaseExecutableMemory): Ditto.

12:47 PM WebKitGTK/2.2.x edited by kov@webkit.org

(diff)

12:36 PM Changeset in webkit [155890] by ap@apple.com

5 edits in trunk/LayoutTests

svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280

The tests were still flaky. Changed retry timeout from 0 to 100 ms as previously
suggested by Geoff.

svg/animations/smil-leak-dynamically-added-element-instances.svg:
svg/animations/smil-leak-element-instances-noBaseValRef.svg:
svg/animations/smil-leak-element-instances.svg:
svg/animations/smil-leak-elements.svg:

12:06 PM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org

(diff)

11:58 AM Changeset in webkit [155889] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Inlining should work in debug mode (i.e. Executable::newCodeBlock() should call recordParse())
https://bugs.webkit.org/show_bug.cgi?id=121444

Reviewed by Mark Hahnenberg.

dfg/DFGArgumentPosition.h: Fix a bug discovered by reenabling inlining. ArgumentPosition may point to the non-canonical VariableAccessData but users of someVariable() want the canonical one.

(JSC::DFG::ArgumentPosition::someVariable):

runtime/Executable.cpp: Call recordParse() so that the Executable knows things about itself (like if it has captured variables). Otherwise those fields are uninitialized.

(JSC::ScriptExecutable::newCodeBlockFor):

11:57 AM Changeset in webkit [155888] by andersca@apple.com

17 edits in trunk/Source/WebKit2

Remove some uses of PassOwnPtr in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121443

Reviewed by Andreas Kling.

Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(generate_message_handler):

Scripts/webkit2/messages_unittest.py:
UIProcess/API/mac/FindIndicatorWindow.h:
UIProcess/API/mac/FindIndicatorWindow.mm:
UIProcess/API/mac/PageClientImpl.h:
UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createDrawingAreaProxy):

UIProcess/API/mac/WKView.mm:

(-[WKView WebKit::]):
(-[WKView _setFindIndicator:fadeOut:animate:]):

UIProcess/API/mac/WKViewInternal.h:
UIProcess/DrawingAreaProxyImpl.cpp:
UIProcess/DrawingAreaProxyImpl.h:
UIProcess/PageClient.h:
UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(PageOverlayClientImpl::PageOverlayClientImpl):
(WKBundlePageOverlayCreate):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::createWebEvent):

WebProcess/Plugins/PluginView.h:

11:26 AM Changeset in webkit [155887] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Build fix following <https://trac.webkit.org/r154358>
(https://bugs.webkit.org/show_bug.cgi?id=120078)

Fix the build for ports that enable PLUGIN_PROXY_FOR_VIDEO, such as iOS WebKit.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::rendererIsNeeded): Substitute "style" for "context".

11:21 AM Changeset in webkit [155886] by timothy@apple.com

9 edits in trunk/Source

Make InspectorTypeBuilder generate better enums in C++.

https://bugs.webkit.org/show_bug.cgi?id=121440

Reviewed by Joseph Pecoraro.

Source/WebCore:

inspector/CodeGeneratorInspector.py:

(fix_camel_case): Add more abbrivations.
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder): Use fix_camel_case

inspector/ConsoleMessage.cpp:

(WebCore::messageSourceValue):
(WebCore::messageTypeValue):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::detectOrigin):

inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::parse):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::resourceStyleSheetText):

inspector/InspectorStyleSheet.h:

(WebCore::InspectorStyleSheet::canBind):

Source/WebInspectorUI:

UserInterface/InspectorBackendCommands.js: Updated to make Css be CSS.

11:09 AM Changeset in webkit [155885] by ap@apple.com

2 edits in trunk/LayoutTests

Flaky Test: svg/batik/filters/feTile.svg
https://bugs.webkit.org/show_bug.cgi?id=114375

platform/mac/TestExpectations: Marking as flaky. We already have a lot of these

batik tests marked as flaky, with similar symptoms.

10:56 AM Changeset in webkit [155884] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Aligned argument signatures of setupArgumentsWithExecState are missing on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=121439

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-09-16
Reviewed by Geoffrey Garen.

Missing implementations of setupArgumentsWithExecState added.

dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

10:50 AM Changeset in webkit [155883] by andersca@apple.com

8 edits in trunk/Source/WTF

Change a couple of COMPILE_ASSERTs to static_assert
https://bugs.webkit.org/show_bug.cgi?id=121441

Reviewed by Andreas Kling.

wtf/BloomFilter.h:
wtf/PackedIntVector.h:

(WTF::PackedIntVector::PackedIntVector):

wtf/StdLibExtras.h:

(WTF::bitwise_cast):
(WTF::safeCast):
(WTF::roundUpToMultipleOf):

wtf/StringHasher.h:

(WTF::StringHasher::hashMemory):

wtf/Vector.h:
wtf/text/AtomicString.cpp:
wtf/unicode/Unicode.h:

10:40 AM Changeset in webkit [155882] by ap@apple.com

5 edits in trunk/LayoutTests

svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280

Reviewed by Geoffrey Garen.

Try garbage collection multiple times, who knows which queues the deleted nodes
could still be in. Also, removed last week's experimental change to make 10x more
nodes to see how that affects the number of leaks (it didn't).

svg/animations/smil-leak-dynamically-added-element-instances.svg:
svg/animations/smil-leak-element-instances-noBaseValRef.svg:
svg/animations/smil-leak-element-instances.svg:
svg/animations/smil-leak-elements.svg:

10:21 AM Changeset in webkit [155881] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

MediaStream API: Storing the constraints in MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=120882

based on: https://chromium.googlesource.com/chromium/blink/+/04ac7655b54ae98f55774afde3f8e92b6c6302e6

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-16
Reviewed by Eric Carlson.

No new tests needed.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::succeed):

platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::setConstraints):
(WebCore::MediaStreamSource::constraints):

10:21 AM Changeset in webkit [155880] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155867 - Add new Galician translations
https://bugs.webkit.org/show_bug.cgi?id=105079

Patch by Fran Dieguez <frandieguez@gnome.org> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

gl.po: updated

10:21 AM Changeset in webkit [155879] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155866 - L10n - en_GB PO file for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100255

Patch by Chris Leonard <cjlhomeaddress@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

en_GB.po: updated.

10:20 AM Changeset in webkit [155878] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155869 - Updated spanish Translation
https://bugs.webkit.org/show_bug.cgi?id=100677

Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

es.po: updated.

10:16 AM Changeset in webkit [155877] by ap@apple.com

2 edits in trunk/LayoutTests

http/tests/misc/submit-post-keygen.html is extremely slow on bots, often timing out
https://bugs.webkit.org/show_bug.cgi?id=121331

Marking as possibly failing too, because when DRT detects a timeout, run-webkit-tests
thinks that it's a failure.

platform/mac/TestExpectations:

10:13 AM Changeset in webkit [155876] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[sh4] Fix typo in subp implementation in LLINT.
https://bugs.webkit.org/show_bug.cgi?id=121438

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-16
Reviewed by Andreas Kling.

offlineasm/sh4.rb:

10:12 AM Changeset in webkit [155875] by akling@apple.com

2 edits in trunk/Source/WebCore

Rebaseline bindings tests after Sam's Document& changes.

10:07 AM Changeset in webkit [155874] by akling@apple.com

5 edits in trunk/Source/WebCore

Destroying a Document's render tree shouldn't make it impossible to recreate.
<https://webkit.org/b/121437>

Reviewed by Antti Koivisto.

Rename Document::detach() to destroyRenderTree() and stop automatically
disconnecting Document from its Frame after the deforestation.

Added Document::disconnectFromFrame() and do that after every call to
destroyRenderTree() that we currently have.

This change doesn't alter any behavior on its own, but is a step towards
being able to destroy and rebuild the render tree.

9:35 AM Changeset in webkit [155873] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r155861 - Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-16
Reviewed by Carlos Garcia Campos.

Update to incorporate additional review suggestions.

UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(sendIncompleteRequest):
Fix memory leaks, change test timeout from 2 seconds to 1 second,
use "0" instead of "NULL" and use g_assert_no_error when checking
for GError.

9:32 AM Changeset in webkit [155872] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r155642 - Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-12
Reviewed by Darin Adler.

When working on a patch for bug #121121 I found an issue with the InspectorServer where it would try
to parse an HTTP message before receiving the full message and thus fail connecting with the
chromedevtools plugin.

What happens is that the WebSocketServerConnection receives buffers on
WebSocketServerConnection::didReceiveSocketStreamData and calls
WebSocketServerConnection::readHTTPMessage which then checks if we have a valid request by calling
HTTPRequest::parseHTTPRequestFromBuffer. If the request is valid it tries to parse the message and
clears the buffer, otherwise it continues adding data to the internal buffer until we have a valid
request.

The problem is that currently HTTPRequest::parseHTTPRequestFromBuffer considers the request as valid
before receiving the full message. To solve this we should make the method check if the request
headers end with a blank line otherwise we consider the request as invalid (see also
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html).

UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(sendIncompleteRequest):
(beforeAll):
Add GTK specific test to check if the inspector server replies to incomplete requests.

UIProcess/InspectorServer/HTTPRequest.cpp:

(WebKit::HTTPRequest::parseHeaders):
Do not consider request valid if headers didn't end with a blank line.

9:29 AM Changeset in webkit [155871] by Brent Fulgham

2 edits in trunk/Source/WebCore

Unreviewed warning correction. Avoid uninitialized renderer.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Renderer can be uninitialized.

9:24 AM Changeset in webkit [155870] by Brent Fulgham

2 edits in trunk/Source/WebCore

Unreviewed warning correction.

css/CSSParser.cpp:

(WebCore::CSSParser::parseFilter): Don't use 'value' as the input argument
to the method, and the internal loop variable for the parser.

9:21 AM Changeset in webkit [155869] by berto@igalia.com

2 edits in trunk/Source/WebCore/platform/gtk/po

Updated spanish Translation
https://bugs.webkit.org/show_bug.cgi?id=100677

Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

es.po: updated.

9:19 AM Changeset in webkit [155868] by Brent Fulgham

2 edits in trunk/Source/WebCore

[Win] Compile errors in WebCore derived sources.
https://bugs.webkit.org/show_bug.cgi?id=121420

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-16
Reviewed by Brent Fulgham.

dom/make_names.pl:

(printNamesCppFile): Added const modifier.
(printDefinitions): Use C style cast.

9:18 AM Changeset in webkit [155867] by berto@igalia.com

2 edits in trunk/Source/WebCore/platform/gtk/po

Add new Galician translations
https://bugs.webkit.org/show_bug.cgi?id=105079

Patch by Fran Dieguez <frandieguez@gnome.org> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

gl.po: updated

9:16 AM Changeset in webkit [155866] by berto@igalia.com

2 edits in trunk/Source/WebCore/platform/gtk/po

L10n - en_GB PO file for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100255

Patch by Chris Leonard <cjlhomeaddress@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

en_GB.po: updated.

9:16 AM Changeset in webkit [155865] by hmuller@adobe.com

5 edits
8 adds in trunk

[CSS Shapes] Winding rule polygon issues
https://bugs.webkit.org/show_bug.cgi?id=120236

Reviewed by Dirk Schulze.

Source/WebCore:

This patch corrects some of the problems with shape-inside and
self-intersecting polygons and eliminates the layout flashing behavior
that prompted the original bug report. The FloatPolygon::contains()
method now respoects the polygon's fillRule and the PolygonShape code
used to find shape-inside intervals for the top and bottom of a line
now also handles fillRule correctly.

Tests: fast/shapes/shape-inside/shape-inside-complex-polygon-001.html

fast/shapes/shape-inside/shape-inside-complex-polygon-002.html
fast/shapes/shape-inside/shape-inside-complex-polygon-003.html
fast/shapes/shape-inside/shape-inside-complex-polygon-004.html

platform/graphics/FloatPolygon.cpp:

(WebCore::FloatPolygon::containsEvenOdd):
(WebCore::FloatPolygon::containsNonZero):
(WebCore::FloatPolygon::contains):

platform/graphics/FloatPolygon.h:
rendering/shapes/PolygonShape.cpp:

(WebCore::computeXIntersections):

LayoutTests:

Verify that self-intersecting rectilinear shape-inside polygons work
correctly for the evenodd and nonzero fill rules.

The shape for tests 001 and 002 contains a loop (the vertices are
numbered in the figure):

0----4----1----5
| | | |
| 3----2 |
7--------------6

When the fillRule is nonzero the entire rectangle is filled because
edges 7-0 and 3-4 wind in same direction. When fillRule is evenodd the
1-2-3-4 rectangle is not filled, leaving a U shape.

The shape for tests 003 and 004 is similar, but the adjacent vertical edges
wind in opposite directions. As a result both nonzero and evenodd fills
produce the same U shaped result.

0----2---1,5---6
| | | |
| 3----4 |
8--------------7

fast/shapes/shape-inside/shape-inside-complex-polygon-001-expected.html: Added.
fast/shapes/shape-inside/shape-inside-complex-polygon-001.html: Added.
fast/shapes/shape-inside/shape-inside-complex-polygon-002-expected.html: Added.
fast/shapes/shape-inside/shape-inside-complex-polygon-002.html: Added.
fast/shapes/shape-inside/shape-inside-complex-polygon-003-expected.html: Added.
fast/shapes/shape-inside/shape-inside-complex-polygon-003.html: Added.
fast/shapes/shape-inside/shape-inside-complex-polygon-004-expected.html: Added.
fast/shapes/shape-inside/shape-inside-complex-polygon-004.html: Added.

9:01 AM Changeset in webkit [155864] by Carlos Garcia Campos

16 edits
1 delete in releases/WebKitGTK/webkit-2.2

Merge r155534 - [GTK] Remove Gail dependency from build system for GTK3
https://bugs.webkit.org/show_bug.cgi?id=119673

Reviewed by Gustavo Noronha Silva.

Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
Source/autotools/Versions.m4: Removed any reference to GAIL.
Source/cmake/FindGAIL3.cmake: Removed.
Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.

Source/WebCore:

GNUmakefile.am: Removed GAIL_CFLAGS.
PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.

Source/WebKit/gtk:

GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.

Source/WebKit2:

GNUmakefile.am: Removed GAIL_LIBS.

Tools:

EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.

TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.

9:00 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

8:56 AM Changeset in webkit [155863] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r155520 - [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
https://bugs.webkit.org/show_bug.cgi?id=114867

Reviewed by Martin Robinson.

Removed all trace of Gail and Pango specific code from the AtkText
implementation, now everything has been reimplemented.

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetTextForOffset): Removed fallback code
relying in Gail/Pango, now all the related code has been
removed. Also, replaced the collection of if statements with a
switch, for better readability of the code.

8:55 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

8:53 AM Changeset in webkit [155862] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.2/Source

Merge r155516 - [GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114872

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Re-implement these functions without using GailTextUtil nor Pango.

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(lineAtPositionForAtkBoundary): New helper function to find the
line at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextLineForBoundary): New function,
implementing atk_text_get_text_*_offset for LINE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
LINE boundaries with webkitAccessibleTextLineForBoundary().

Source/WebKit/gtk:

Fixed wrong unit test.

tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithPreformattedText): This test was
reporting a trailing '\n' for some reason for a <pre> block, which
is plainly wrong since, in order to return that, there should be
at least a trailing empty space after that and before the </pre>
closing tag. This is fixed now.
(testWebkitAtkGetTextAtOffsetWithWrappedLines): Uncommented tests
that were previously not passing due to a bug in GailTextUtil.

8:52 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

8:49 AM Changeset in webkit [155861] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-16
Reviewed by Carlos Garcia Campos.

Update to incorporate additional review suggestions.

UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(sendIncompleteRequest):
Fix memory leaks, change test timeout from 2 seconds to 1 second,
use "0" instead of "NULL" and use g_assert_no_error when checking
for GError.

8:49 AM Changeset in webkit [155860] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r155031 - [GTK] Reimplement atk_text_get_text_*_offset for SENTENCE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114873

Reviewed by Chris Fleizach.

Re-implement these functions without using GailTextUtil nor Pango.

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextWordForBoundary): Renamed from webkitAccessibleTextGetWordForBoundary,
to keep it consistent with names for new functions.
(isSentenceBoundary): Helper function to know when we are either
at the beginning or the end of a sentence.
(isWhiteSpaceBetweenSentences): It returns true if we are in the
middle of a white space between sentences. Useful for implementing
the SENTENCE_END boundary type.
(sentenceAtPositionForAtkBoundary): New helper function to find the
sentence at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextSentenceForBoundary): New function,
implementing atk_text_get_text_*_offset for SENTENCE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
SENTENCE boundaries with webkitAccessibleTextSentenceForBoundary().

8:48 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

8:17 AM Changeset in webkit [155859] by akling@apple.com

5 edits in trunk/Source/WebCore

AXObjectCache::m_document should be a reference.
<https://webkit.org/b/121425>

Reviewed by Antti Koivisto.

AXObjectCache is always owned by a Document so remove the uncertainty
by turning its m_document into a Document&.

8:17 AM Changeset in webkit [155858] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155855 - [l10n] [pt_BR] Updated Brazilian Portuguese translation of WebKitGTK+ - 12/09/2013
https://bugs.webkit.org/show_bug.cgi?id=121255

Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha.

pt_BR.po: updated.

8:16 AM Changeset in webkit [155857] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155831 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=121392

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-09-15
Reviewed by Gustavo Noronha Silva.

pl.po: updated.

8:16 AM Changeset in webkit [155856] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 154677 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=119986

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-08-27
Reviewed by Gustavo Noronha Silva.

pl.po: updated.

8:16 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

8:03 AM Changeset in webkit [155855] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [pt_BR] Updated Brazilian Portuguese translation of WebKitGTK+ - 12/09/2013
https://bugs.webkit.org/show_bug.cgi?id=121255

Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha.

pt_BR.po: updated.

7:00 AM Changeset in webkit [155854] by commit-queue@webkit.org

4 edits
4 moves in trunk

Unreviewed, rolling out r155851.
http://trac.webkit.org/changeset/155851
https://bugs.webkit.org/show_bug.cgi?id=121429

checkbox states should be exposed through AtkState, not
AtkValue (Requested by msanchez on #webkit).

Source/WebCore:

accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetCurrentValue):

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getInterfaceMaskFromObject):

LayoutTests:

platform/mac/accessibility/mixed-checkbox-expected.txt: Renamed from LayoutTests/accessibility/mixed-checkbox-expected.txt.
platform/mac/accessibility/mixed-checkbox.html: Renamed from LayoutTests/accessibility/mixed-checkbox.html.
platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Renamed from LayoutTests/accessibility/native-vs-nonnative-checkboxes-expected.txt.
platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Renamed from LayoutTests/accessibility/native-vs-nonnative-checkboxes.html.

6:54 AM Changeset in webkit [155853] by kadam@inf.u-szeged.hu

4 edits
4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping and rebase failing tests on Qt bots.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-16

platform/qt-wk1/TestExpectations:
platform/qt-wk1/fast/events/before-unload-returnValue-expected.txt: Added r155367.
platform/qt-wk1/inspector/console/command-line-api-expected.txt:
platform/qt/TestExpectations:
platform/qt/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added r155607.
platform/qt/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added r155607.

6:38 AM WebKitGTK/2.2.x edited by mario@webkit.org

(diff)

6:25 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org

(diff)

5:51 AM Changeset in webkit [155852] by commit-queue@webkit.org

5 edits
2 adds in trunk/Source/WebKit2

[EFL][WK2] Implement pan and flick gesture.
https://bugs.webkit.org/show_bug.cgi?id=107101

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-09-16
Reviewed by Gyuyoung Kim.

Implement pan gesture to scroll page by movement of point and stop
scrolling smoothly using ease-in-out-quad algorithm after touched
point is removed from the screen.

Use Ecore_Animator in order to process movement once per each framing
time slot instead of processing all movement.

PlatformEfl.cmake:
UIProcess/API/efl/EwkView.cpp:

(EwkView::scrollBy):

UIProcess/API/efl/EwkView.h:
UIProcess/API/efl/GestureRecognizer.cpp:

(WebKit::GestureHandler::view):
(WebKit::GestureHandler::GestureHandler):
(WebKit::GestureHandler::~GestureHandler):
(WebKit::GestureHandler::reset):
(WebKit::GestureHandler::panAnimatorCallback):
(WebKit::GestureHandler::handlePanStarted):
(WebKit::GestureHandler::handlePan):
(WebKit::GestureHandler::handlePanFinished):
(WebKit::GestureHandler::flickAnimatorCallback):
(WebKit::GestureHandler::handleFlick):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::reset):

UIProcess/efl/EasingCurves.cpp: Added.

(WebKit::easeInOutQuad):

UIProcess/efl/EasingCurves.h: Added.

5:38 AM Changeset in webkit [155851] by commit-queue@webkit.org

4 edits
4 moves in trunk

[ATK] Extends atk value interface to return proper checkbox states
https://bugs.webkit.org/show_bug.cgi?id=121413

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-16
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Tests: accessibility/mixed-checkbox.html

accessibility/native-vs-nonnative-checkboxes.html

accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueValueForAccessibilityObject):
(webkitAccessibleValueGetCurrentValue):

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getInterfaceMaskFromObject):

LayoutTests:

Sharing mac tests with other ports (GTK/EFL).

accessibility/mixed-checkbox-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox-expected.txt.
accessibility/mixed-checkbox.html: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox.html.
accessibility/native-vs-nonnative-checkboxes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt.
accessibility/native-vs-nonnative-checkboxes.html: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes.html.

5:28 AM Changeset in webkit [155850] by Carlos Garcia Campos

4 edits
5 adds in trunk/Source/WebCore

[GTK] Check DOM bindings API compatibility while building
https://bugs.webkit.org/show_bug.cgi?id=101224

Reviewed by Gustavo Noronha Silva.

A .symbols file is now generated for every DOM binding public API
object. It contains the signature of all public methods. We keep a
single file with the signature of all public methods in the source
tree. When DOM bindings are generated, a new symbols file is
created concatenating all .symbols files generated and it's
compared with the symbols file in the source tree using a script
that checks if the changes are API compatible or not. In case of
API break the build finishes showing the differences found in the
symbol files. If API compatible changes are found, the diff is
shown in stdout, suggesting to run the gobject-run-api-break-test
with the --reset-results option to update the symbols file, and
the build continues. If there aren't API changes the build
continues silently.

GNUmakefile.am:
bindings/gobject/GNUmakefile.am:
bindings/gobject/WebKitDOMCustom.symbols: Added.
bindings/gobject/WebKitDOMEventTarget.symbols: Added.
bindings/gobject/WebKitDOMObject.symbols: Added.
bindings/gobject/webkitdom.symbols: Added.
bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):
(WriteData):

bindings/scripts/gobject-run-api-break-test: Added.

(check_api):

4:44 AM Changeset in webkit [155849] by akling@apple.com

5 edits in trunk/Source/WebCore

Devirtualize Document::detach().
<https://webkit.org/b/121418>

Reviewed by Antti Koivisto.

The only override was in PluginDocument which needs to decouple itself
from the plugin element at the start of detach.

Added PluginDocument::detachFromPluginElement() and call it from detach().

3:49 AM Changeset in webkit [155848] by mario@webkit.org

3 edits in trunk/LayoutTests

Unreviewed gardening. Removed fail expectations for test in
the GTK & EFL ports, consistently passing after r155374.

platform/efl/TestExpectations: Removed test.
platform/gtk/TestExpectations: Ditto.

2:27 AM Changeset in webkit [155847] by commit-queue@webkit.org

8 edits in trunk

Source/WebKit2: [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
https://bugs.webkit.org/show_bug.cgi?id=98410

Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.

Add API required to implement click() method for context menu entry, used by WebkitTestRunner::EventSender.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageClickMenuItem):
(WKBundlePageCopyContextMenuItemTitle):
(WKBundlePageGetContextMenuItems):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools: [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
https://bugs.webkit.org/show_bug.cgi?id=98410

Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.

Add implementation of click() method of objects returned by eventSender.contextClick().

WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(MenuItemPrivateData):
(WTR::menuItemClickCallback):
(WTR::getMenuItemTitleCallback):
(WTR::staticMenuItemFinalize):
(WTR::getMenuItemClass):
(WTR::EventSendingController::contextClick):

LayoutTests: [WKTR] Add implementation of click() method of objects returned by eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=98410

Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.

Unskipping tests related with click() method.

platform/efl-wk2/TestExpectations: Corrected bug number for tests: editing/pasteboard/can-read-in-copy-and-cut-events.html editing/pasteboard/can-read-in-dragstart-event.html
platform/gtk-wk2/TestExpectations:

2:05 AM Changeset in webkit [155846] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[sh4] Handle subp opcode with 3 operands and bpbeq opcode in LLINT.
https://bugs.webkit.org/show_bug.cgi?id=121412

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-16
Reviewed by Andreas Kling.

offlineasm/sh4.rb:

1:42 AM Changeset in webkit [155845] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: RenderCombineText always has a Text node.
<https://webkit.org/b/121411>

Reviewed by Antti Koivisto.

This renderer is never anonymous and always has a corresponding Text node.
Replaced node() with a textNode() reference getter.

1:00 AM Changeset in webkit [155844] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r155778 - Missing allow-none introspection annotation for DomDocument.evaluate method
https://bugs.webkit.org/show_bug.cgi?id=118310

Reviewed by Martin Robinson.

Add (allow-none) introspection annotation to parameters that can
be NULL.

bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

12:59 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:48 AM Changeset in webkit [155843] by Carlos Garcia Campos

10 edits in releases/WebKitGTK/webkit-2.2

Merge r155768 - [GTK] WebKitGTK+ is linking against libxslt in too many places
https://bugs.webkit.org/show_bug.cgi?id=121356

Reviewed by Martin Robinson.

Source/WebCore:

Don't use LIBXSLT_CFLAGS when compiling libWebCorePlatform and
libWebCoreGtk, no source files use libxslt there.

GNUmakefile.am:

Source/WebKit/gtk:

Don't use LIBXSLT_CFLAGS when compiling libwebkitgtk, no source
files use libxslt there.

The webkit tests don't use libxslt, so we shouldn't link against
it.

GNUmakefile.am:

Source/WebKit2:

Don't use LIBXSLT_CFLAGS when compiling libWebCoreGtk2, no source
files use libxslt there.

GNUmakefile.am:

Tools:

TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
so we don't need to link against it.

MiniBrowser/gtk/GNUmakefile.am:
TestWebKitAPI/GNUmakefile.am:
WebKitTestRunner/GNUmakefile.am:

12:14 AM Changeset in webkit [155842] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Tools

Merge r155758 - Uses gtk-doc tools even when --disable-gtk-doc passed
https://bugs.webkit.org/show_bug.cgi?id=91239

Patch by Ross Burton <ross.burton@intel.com> on 2013-09-14
Reviewed by Martin Robinson.

Don't run generate-gtkdoc on install if gtk-doc is disabled.

GNUmakefile.am:

12:13 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:09 AM Changeset in webkit [155841] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Tools

Merge r155772 - [GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296

Reviewed by Martin Robinson.

Instead of using os.symlink() to install the gtk-doc templates,
use os.link() first and fall back to os.symlink() if it fails.

gtk/gtkdoc.py:

(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):

12:08 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:07 AM Changeset in webkit [155840] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Tools

Merge r155757 - [GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296

Reviewed by Carlos Garcia Campos.

Use symlinks instead of hard links to support building on a
different file system.

gtk/gtkdoc.py:

(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):

12:05 AM Changeset in webkit [155839] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r155677 - download-requested arg should be WEBKIT_TYPE_DOWNLOAD not G_TYPE_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=57634

Reviewed by Darin Adler.

webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

12:04 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:04 AM Changeset in webkit [155838] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r155533 - [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
https://bugs.webkit.org/show_bug.cgi?id=120892

Reviewed by Martin Robinson.

If the GL context cannot be created then m_isValid is set to false
during the initialization of LayerTreeHostGtk.

This is not really necessary since the rest of the code already
deals with that situation, so it doesn't have any effect other
than breaking the assertion in invalidate().

WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):

12:03 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed