Context Navigation

The issue was that we would cast to CSSValueList without checking
the type of the CSSValue. After this change, we use the ASSERT'ing
cast and explicitly check the type of the CSSValue before the cast.

Test: fast/css/crash-inherit-value-font-family.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

LayoutTests:

Reviewed by Beth Dakin.

Add a regression test. This is not a merge since the test in the Blink change involves
superfluous execCommand calls.

fast/css/crash-inherit-value-font-family-expected.txt: Added.
fast/css/crash-inherit-value-font-family.html: Added.

9:11 PM Changeset in webkit [156221] by Lucas Forschler

5 edits in branches/safari-537.60-branch/Source

Merged r156219. <rdar://problem/12712495>

8:36 PM Changeset in webkit [156220] by zoltan@webkit.org

3 edits in trunk/Source/WebCore

Remove includes from LineWidth.h
https://bugs.webkit.org/show_bug.cgi?id=121716

Reviewed by Darin Adler.

In r156197 I removed logicalLineHeight from LineWidth.h, so we don't need to include RenderBlock.h
and RenderRubyRun.h anymore in LineWidth.h.

No new tests, no behavior change.

rendering/LineWidth.cpp:
rendering/LineWidth.h:

8:23 PM Changeset in webkit [156219] by roger_fong@apple.com

5 edits in trunk/Source

Handle panning gestures messages properly on Windows.
https://bugs.webkit.org/show_bug.cgi?id=121711.

Reviewed by Brent Fulgham.

This fixes a number of issues with panning gestures on Windows.

Two finger panning in one direction can sometimes cause some unexpected scrolling

in the other direction when the gesture first begins (directions meaning horizontal and vertical)

Single finger horizontal panning should only be disabled when attempting to select text.
Scrolling via panning should be clamped, other wise we can scroll contents completely out of the scrollview.
Horizontal overpan should work.
Overpan should occur whenever we scroll to the extents of whichever scroll view we're currently scrolling.

WebView.cpp:

(WebView::gestureNotify):
(WebView::gesture):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):

rendering/RenderLayer.h:

Added an argument to keep track of which scrollview was actually scrolled
This is needed by the Windows port to keep track to determine whether or not
we need to overpan.

6:25 PM Changeset in webkit [156218] by mrowe@apple.com

3 edits in trunk/WebKitLibraries

Fix link errors for external users when building WebKit with Xcode 5.

Reviewed by Oliver Hunt.

libWebKitSystemInterfaceLion.a:
libWebKitSystemInterfaceMountainLion.a:

5:57 PM Changeset in webkit [156217] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix after r156216.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: I accidentally exposed the symbol of the calling function, not the missing symbol!

5:51 PM Changeset in webkit [156216] by Brent Fulgham

2 edits in trunk/Source/WebKit

[WINDOWS] Unreviewed build fix after r156215.

WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing symbols needed by DumpRenderTree.dll.

5:35 PM Changeset in webkit [156215] by Alexandru Chiculita

12 edits
2 adds in trunk

Web Inspector: [CSS Regions] Display CSS Regions chain when highlighting a CSS Region node
https://bugs.webkit.org/show_bug.cgi?id=121719

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/elements/highlight-node-regions.html

When a CSS Region node is highlighted through the WebInspector, it will also lookup all the regions
that are part of the same flow and inject enough information into InspectorOverlayPage.js to get the other
CSS Regions highlighted as well. A chain will also link the regions and a number will display the ordering
of the content.

WebCore.exp.in:
inspector/InspectorController.cpp:

(WebCore::InspectorController::buildObjectForHighlightedNode):

inspector/InspectorController.h:
inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForRegionHighlight):
(WebCore::buildObjectForCSSRegionsHighlight):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawNodeHighlight): Separated the InspectorObject building part out of this function,
so that we can call buildObjectForHighlightedNode from the Internals APIs for testing.

inspector/InspectorOverlay.h:
inspector/InspectorOverlayPage.js:

(_drawRegionNumber):
(_quadMidPoint):
(_drawRegionLink):
(_fixQuadScrollPosition):
(_drawRegionsHighlight):
(drawNodeHighlight):

testing/Internals.cpp: Exposed the generated InspectorObject to the layout test.

(WebCore::Internals::inspectorHighlightObject):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

Added test to check the position of the CSS Regions part of the same flow thread with
the highlighted CSS Region node.

http/tests/inspector/elements-test.js:
inspector/elements/highlight-node-regions-expected.txt: Added.
inspector/elements/highlight-node-regions.html: Added.

5:24 PM Changeset in webkit [156214] by mhahnenberg@apple.com

3 edits
3 adds in trunk

(un)shiftCountWithAnyIndexingType will start over in the middle of copying if it sees a hole
https://bugs.webkit.org/show_bug.cgi?id=121717

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This bug caused the array to become corrupted. We now check for holes before we start moving things,
and start moving things only once we've determined that there are none.

runtime/JSArray.cpp:

(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):

LayoutTests:

Added test to make sure that splicing an array with holes works correctly.

js/array-splice-with-holes-expected.txt: Added.
js/array-splice-with-holes.html: Added.
js/script-tests/array-splice-with-holes.js: Added.

5:07 PM Changeset in webkit [156213] by ap@apple.com

2 edits in trunk/LayoutTests

Fix test after <http://trac.webkit.org/changeset/156203>

platform/mac/accessibility/aria-help.html: Correct paths to JS tests.

5:07 PM Changeset in webkit [156212] by fpizlo@apple.com

3 edits
3 adds in trunk

REGRESSION(r156047): WebCore hangs inside JSC::toInt32(double)
https://bugs.webkit.org/show_bug.cgi?id=121648

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

The Int52<->StrictInt52 conversion did the opposite fill() than what it was
supposed to. For example when converting a Int52 to a StrictInt52 it would fill
as Int52, and vice-versa.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):

LayoutTests:

Reviewed by Mark Hahnenberg.

js/dfg-int52-change-format-expected.txt: Added.
js/dfg-int52-change-format.html: Added.
js/script-tests/dfg-int52-change-format.js: Added.

(foo):

5:00 PM Changeset in webkit [156211] by oliver@apple.com

3 edits
3 adds in trunk

REGRESSION(r153215): New iCloud site crashes
https://bugs.webkit.org/show_bug.cgi?id=121710

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Don't claim to be able to rely on the arguments structure, use the Arguments
speculation type

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

LayoutTests:

New test case

js/dfg-arguments-mutated-structure-expected.txt: Added.
js/dfg-arguments-mutated-structure.html: Added.
js/script-tests/dfg-arguments-mutated-structure.js: Added.

(foo):

4:59 PM Changeset in webkit [156210] by commit-queue@webkit.org

4 edits
2 deletes in trunk

Unreviewed, rolling out r156185.
http://trac.webkit.org/changeset/156185
https://bugs.webkit.org/show_bug.cgi?id=121727

Caused a lot of crashes in tests (Requested by ap on #webkit).

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayout):

dom/Document.h:

LayoutTests:

fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Removed.
fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Removed.

4:45 PM Changeset in webkit [156209] by timothy@apple.com

9 edits in trunk/Source/WebInspectorUI

Parse MIME-types and strip them down to the base type when needed.

The use of charset in a MIME-type interferes with our type maps,
preventing the right syntax highlighting mode and pretty printing.

https://bugs.webkit.org/show_bug.cgi?id=121723

Reviewed by Joseph Pecoraro.

UserInterface/ConsolePrompt.js:

(WebInspector.ConsolePrompt):

UserInterface/FontResourceContentView.js:
UserInterface/Resource.js:

(WebInspector.Resource.Type.fromMIMEType):
(WebInspector.Resource.prototype.get mimeTypeComponents):
(WebInspector.Resource.prototype.get syntheticMIMEType):
(WebInspector.Resource.prototype.get contentURL):
(WebInspector.Resource.prototype.updateForResponse):

UserInterface/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):

UserInterface/SourceMapResource.js:

(WebInspector.SourceMapResource.prototype.requestContentFromBackend):

UserInterface/SyntaxHighlightingSupport.js:

(WebInspector.syntaxHighlightStringAsDocumentFragment):

UserInterface/TextEditor.js:

(WebInspector.TextEditor.prototype.set mimeType):

UserInterface/Utilities.js:

(parseMIMEType): Added.

4:01 PM Changeset in webkit [156208] by mrowe@apple.com

5 edits in trunk

<https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date

Tools:

Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.

Reviewed by David Kilzer.

Scripts/webkitdirs.pm:

(checkRequiredSystemConfig):

Websites/webkit.org:

Update references on webkit.org to mention Xcode 4.6 as the minimum version.

Reviewed by David Kilzer.

building/debug-mac-uiprocess.html:
building/tools.html:

3:52 PM Changeset in webkit [156207] by Lucas Forschler

5 edits in branches/safari-537.60-branch/Source

Versioning.

3:48 PM Changeset in webkit [156206] by Lucas Forschler

1 copy in tags/Safari-537.60.2

New Tag.

3:17 PM Changeset in webkit [156205] by dino@apple.com

3 edits in trunk/Source/WebCore

Shaders that fail to compile should be marked as such
https://bugs.webkit.org/show_bug.cgi?id=121721

Reviewed by Simon Fraser.

Add a new logging channel for WebGL.

If a translated shader fails to compile (technically

this should never happen), mark it as invalid.

Test: https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shader-with-non-reserved-words.html

platform/Logging.h: New WebGL channel.
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader): Log the raw and translated
input to glCompileShader, but mark the entry as invalid.

2:58 PM Changeset in webkit [156204] by andersca@apple.com

2 edits in trunk/Source/WTF

Add an implementation of std::index_sequence from C++14
https://bugs.webkit.org/show_bug.cgi?id=121718

Reviewed by Ryosuke Niwa.

This will make it easier to do things like pack expansion of tuple elements.

wtf/StdLibExtras.h:

2:56 PM Changeset in webkit [156203] by mario@webkit.org

18 edits
2 moves
2 deletes in trunk

[ATK] Do not expose aria-help in ATK based platforms
https://bugs.webkit.org/show_bug.cgi?id=121675

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

Stop exposing the value for the 'aria-help' attribute as an
AtkObject attribute, based in AccessibilityObject::helpText().

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Remove the mapping.

Source/WebKit/efl:

Removed accessibilityHelpText() helper method from
DumpRenderSupportEfl's API, since it's not longer needed.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Removed method.
WebCoreSupport/DumpRenderTreeSupportEfl.h: Ditto.

Source/WebKit/gtk:

Removed accessibilityHelpText() helper method from
DumpRenderSupportGtk's API, since it's not longer needed.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Removed method.
WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.

Tools:

Remove the implementations for AccessibilityUIElement::helpText()
from DRT and WKTR for GTK and EFL, since they are based on the
AccessibilityObject::helpText() method and the 'aria-help'
attributes, which is wrong since they should not depend on that
but in ATK specific API (see also http://webkit.org/b/121684).

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::helpText): Added a new and empty
implementation, now that we are no longer using this in ATK.

DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file

as the only function provided here was helpText().

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp

removed from the list of sources to compile.

GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::helpText): Replaced old implementation
based in DumpRenderTreeSupportGtk with an empty one.

LayoutTests:

Moved test based in helpText() into the Mac directory, and update
expectations for platforms as needed.

platform/mac/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/aria-help-expected.txt.
platform/mac/accessibility/aria-help.html: Renamed from LayoutTests/accessibility/aria-help.html.
platform/gtk-wk2/TestExpectations: Removed failure expectation

for aria-help, now moved to Mac, and for aria-describedby-on-input,
which is now moved to the generic TestExpectations file for GTK.

platform/gtk/TestExpectations: Added aria-describedby-on-input,

linking it to the newly filed bug 121684.

platform/gtk-wk2/TestExpectations: Removed failure expectation.
platform/win/TestExpectations: Removed failure expectation.
platform/wincairo/TestExpectations: Ditto.

2:54 PM Changeset in webkit [156202] by Lucas Forschler

3 edits in branches/safari-537.60-branch/Source/WebCore

Correct build by activating Microsoft Assembler support in
project file. I have no idea why this would be missing in
the branch.

Patch by Brent Fulgham <Brent Fulgham> on 2013-09-20

WebCore.vcxproj/WebCore.vcxproj: Activate MASM support.
WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

2:47 PM Changeset in webkit [156201] by Simon Fraser

7 edits in trunk/Source/WebCore

Scrollbars don't appear on long pages after r155660
https://bugs.webkit.org/show_bug.cgi?id=121714
<rdar://problem/15042478>

Reviewed by Beth Dakin.

After r155660, we don't do any additional layouts when scrollbars are
added or removed. That caused us to not enter the code that creates or
destroys composting layers for scrollbars in RenderLayerCompositor, resulting
in missing scrollbars.

Fix by having ScrollView::updateScrollbars() call addedOrRemovedScrollbar()
when a scrollbar was added or removed, which is overridden in FrameView
to call through to RenderLayerCompositor::frameViewDidAddOrRemoveScrollbars().

Not testable since scrollbar layers aren't contained in layer tree dumps
(to reduce diffs between platforms).

page/FrameView.cpp:

(WebCore::FrameView::addedOrRemovedScrollbar): New function to tell the compositor
that scrollbars changed.

page/FrameView.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar): Change the meaning of the return
value to say if the scrollbar was added or removed. Add an out param that indicates
whether the scrollbar change affects content size (not true for overlay scrollbars).
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): Keep track of whether scrollbars were
added or removed, and call addedOrRemovedScrollbar() if true.

platform/ScrollView.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidAddOrRemoveScrollbars): Call updateOverflowControlsLayers().
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

rendering/RenderLayerCompositor.h:

2:47 PM Changeset in webkit [156200] by Simon Fraser

2 edits in trunk/Source/WebCore

Ensure that TileController tile coverage is updated on scrolling even when we don't have scrollbars
https://bugs.webkit.org/show_bug.cgi?id=121700
<rdar://problem/15030589>

Reviewed by Dean Jackson.

r155660 introduced a bug where we wouldn't make scrollbars on long pages. However,
that revealed a fundamental flaw in the TiledBacking update logic; it relied on the
GraphicsLayer flushes triggered by scrollbars updates in order to update the main
TileController's tile coverage. No scrollbars meant no tile coverage updates.

Fix by explicitly triggering a flush when the FrameView is scrolled (we get
notified about this on the main thread after the scrolling thread has moved
layers around).

No test since this will only be exposed for a short time while scrollbars are
broken.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):

2:17 PM Changeset in webkit [156199] by zoltan@webkit.org

3 edits in trunk/Source/WebCore

Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h
https://bugs.webkit.org/show_bug.cgi?id=121707

Reviewed by David Hyatt.

LineBreaker and RenderTextInfo are defined in RenderBlock.h, but only used in RenderBlockLineLayout.cpp.
Moving them there (LineBreaker needs to be a friend class of RenderBlock) in the first step in the process
of refactoring LineBreaker::NextSegmentBreak into more manageable chunks.

This change was reviewed and landed in Blink:
https://src.chromium.org/viewvc/blink?revision=157402&view=revision

No new tests.

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::LineBreaker):
(WebCore::LineBreaker::lineWasHyphenated):
(WebCore::LineBreaker::positionedObjects):
(WebCore::LineBreaker::clear):
(WebCore::RenderTextInfo::RenderTextInfo):
(WebCore::RenderTextInfo::~RenderTextInfo):
(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):
(WebCore::LineBreaker::reset):
(WebCore::LineBreaker::nextLineBreak):
(WebCore::LineBreaker::nextSegmentBreak):

2:17 PM Changeset in webkit [156198] by timothy@apple.com

10 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix keyboard shortcuts for other platforms
https://bugs.webkit.org/show_bug.cgi?id=120657

Patch by Marcelo Morais <m.morais@samsung.com> on 2013-09-20
Reviewed by Timothy Hatcher.

Handling keyboard shortcuts according to the current platform.

UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
(.WebInspector.InspectorFrontendHostStub.prototype.platform): Added. Return the
current platform.

UserInterface/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.Modifier.get CommandOrControl): Added. Created keyboard
modifier to return Control or Command key according to current platform.

UserInterface/ContentBrowser.js:

(WebInspector.ContentBrowser): Returning Control or Command key for keyboard
shortcuts according to current platform.

UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel): Ditto.

UserInterface/FindBanner.js:

(WebInspector.FindBanner): Ditto.

UserInterface/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController): Ditto.

UserInterface/LogContentView.js:

(WebInspector.LogContentView): Ditto.

UserInterface/Main.js:

(WebInspector.contentLoaded): Ditto.

UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel): Ditto.

1:53 PM Changeset in webkit [156197] by zoltan@webkit.org

6 edits in trunk/Source/WebCore

Move logicalHeightForLine out of LineWidth.h
https://bugs.webkit.org/show_bug.cgi?id=121575

Reviewed by David Hyatt.

In bug #121107 (r155565), I moved logicalHeightForLine into LineWidth.h as part of LineWidth
refactoring. LogicalHeightForLine without passing the second parameter uses RenderBlock::lineHeight
anyway, except it doesn't take -line-box-contain CSS property into account. For Shapes we don't
have implementation for variable-height lines (https://bugs.webkit.org/show_bug.cgi?id=95361) yet, so
so I modified the affected functions to call lineHeight directly. I renamed logicalHeightForLine
to minLineHeightForReplacedRenderer, and I made the second parameter a mandatory for that function.

No new tests, no behavior change.

rendering/LineWidth.cpp:

(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

rendering/LineWidth.h:
rendering/RenderBlock.cpp: Move the definition here.

(WebCore::RenderBlock::minLineHeightForReplacedRenderer):

rendering/RenderBlock.h: Move the function here and rename it.
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutShapeInsideInfo):
(WebCore::updateLogicalInlinePositions):
(WebCore::updateSegmentsForShapes):

1:40 PM Changeset in webkit [156196] by ap@apple.com

2 edits in trunk/Source/WebCore

-[WebHTMLConveter _getFloat:forNode:property:] leaks
https://bugs.webkit.org/show_bug.cgi?id=121709

Reviewed by Enrica Casucci.

platform/mac/HTMLConverter.mm:

(-[WebHTMLConverter _getFloat:forNode:property:]): Don't leak.

1:35 PM Changeset in webkit [156195] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect a scaled image.
https://bugs.webkit.org/show_bug.cgi?id=121696

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-20
Reviewed by Antti Koivisto.

Add an argument to ImageSource::createFrameAtIndex. A platform image decoder can decide the optimal
scale based on the hint and pass the real scale it used for decoding.

No new tests, no behavior change.

platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::createFrameAtIndex):

platform/graphics/ImageSource.h:
platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::createFrameAtIndex):

1:27 PM Changeset in webkit [156194] by Bem Jones-Bey

1 edit
57 copies
8 adds
1 delete in trunk/LayoutTests

Move tests to new import location
https://bugs.webkit.org/show_bug.cgi?id=121701

Reviewed by Dirk Schulze.

The import script was previously importing the tests into an incorrect
path. This change uses the latest import script to import all of the
shapes tests to the right location.

There are also some small changes in the tests since they had some
more metadata added upstream, but there are no functional changes in
the tests with this change.

csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js.

(ellipseXIntercept):
(scanConvertRoundedRectangleOutside):
(genLeftRightRoundedRectFloatShapeOutsideRefTest):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(genRightRoundedRectFloatShapeOutsideRefTest):

csswg/contributors/adobe/submitted/shapes/shape-outside/resources/subpixel-utils.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js.

(SubPixelLayout):
(SubPixelLayout.):

csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log: Added.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Copied from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html.
csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log: Added.
csswg/submitted/shapes/shape-outside/w3c-import.log: Removed.

1:26 PM Changeset in webkit [156193] by akling@apple.com

2 edits in trunk/Source/WebCore

Make JSMainThreadNullState noncopyable.

Blindly rubber-stamped by Antti Koivisto.

bindings/js/JSMainThreadExecState.h:

1:23 PM Changeset in webkit [156192] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Clobberize phase forgets to indicate that it writes GCState for several node types
https://bugs.webkit.org/show_bug.cgi?id=121702

Reviewed by Oliver Hunt.

Added read and write for GCState to the nodes that could end up allocating (and thereby
cause a garbage collection).

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

1:13 PM Changeset in webkit [156191] by mitz@apple.com

5 edits
1 copy in trunk

Make extract-localizable-strings available to WebCore clients
https://bugs.webkit.org/show_bug.cgi?id=121699

Reviewed by Darin Adler.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj: Added a Scripts group with a reference to

extract-localizable-strings.pl. Added a Copy Scripts build phase to the WebCore target that
copies the script into PrivateHeaders/Scripts in the framework.

extract-localizable-strings.pl: Copied from Tools/Scripts/extract-localizable-strings.

Tools:

Scripts/extract-localizable-strings: Copied to

Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
executes the script from its new location. This is a temporary measure until certain code
that is external to WebKit is adapted to the new location.

Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl

from its new location.

12:56 PM Changeset in webkit [156190] by Antti Koivisto

6 edits in trunk/Source/WebCore

Move layer hierarchy functions from RenderObject to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121692

Reviewed by Andreas Kling.

rendering/RenderElement.cpp:

(WebCore::RenderElement::addLayers):
(WebCore::RenderElement::removeLayers):
(WebCore::RenderElement::moveLayers):
(WebCore::RenderElement::findNextLayer):
(WebCore::RenderElement::layerCreationAllowedForSubtree):

Move these from RenderObject.

(WebCore::RenderElement::insertedIntoTree):
(WebCore::RenderElement::willBeRemovedFromTree):

Factor the layer related portion of these virtuals here.

12:29 PM Changeset in webkit [156189] by benjamin@webkit.org

6 edits in trunk/Source/WebCore

Start cleaning the API of SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121654

Reviewed by Antti Koivisto.

Make the matching mode internal.
Remove unused accessors.
Make isFrameFocused() internal.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
(WebCore::isFrameFocused):

css/SelectorChecker.h:

(WebCore::SelectorChecker::match):

css/StyleResolver.h:

(WebCore::checkRegionSelector):

dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):

12:28 PM Changeset in webkit [156188] by benjamin@webkit.org

3 edits in trunk/Source/WebCore

Remove SelectorChecker's CrossesBoundary boundary mode
https://bugs.webkit.org/show_bug.cgi?id=121653

Reviewed by Antti Koivisto.

This mode is an ancient vestige of shadow dom.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):

css/SelectorChecker.h:

12:27 PM Changeset in webkit [156187] by benjamin@webkit.org

3 edits in trunk/Source/WebCore

Move the SharingRules mode outside of SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121652

Reviewed by Antti Koivisto.

The SharingRules handling inside SelectorChecker is a weird hack
to hit a specific branch of ElementRuleCollector.

This patch moves the exception to ElementRuleCollector, where it is easier
to understand what it is for.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):

12:09 PM Changeset in webkit [156186] by commit-queue@webkit.org

3 edits
3 adds in trunk

Fixed img src URLS with multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=121592

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/loader/image-src-multiple-space.html

I've removed the simplifyWhiteSpace step from HTMLImageElement's src attribute during the srcset selection algorithm.
That step prevented URLs with multiple spaces from being loaded as images, minimizing the multiple spaces into a single one.

html/parser/HTMLParserIdioms.cpp:

(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

This test verifies that URLs with multiple spaces can be loaded as an image resource.

fast/loader/image-src-multiple-space-expected.txt: Added.
fast/loader/image-src-multiple-space.html: Added.

12:06 PM Changeset in webkit [156185] by commit-queue@webkit.org

4 edits
2 adds in trunk

Hiding a focused element should unfocus it and fire a blur event
https://bugs.webkit.org/show_bug.cgi?id=29241

Patch by Arunprasad Rajkumar <ararunprasad@gmail.com> on 2013-09-20
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLDocument/active-element-gets-unfocusable.html

We check whether the current focus element is really focusable after
the style recalculation and layout change. If it is not focusable then schedule a
timer to reset it asynchronously.

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle): Check isFocusable() on the focus element after
style recalculation.
(WebCore::Document::updateLayout): Check isFocusable() on the focus element after
layout.
(WebCore::Document::resetHiddenFocusElementSoon):
(WebCore::Document::resetHiddenFocusElementTimer):

dom/Document.h:

LayoutTests:

fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Added.
fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Added.

LayoutTest reused from https://chromium.googlesource.com/chromium/blink/+/c58f636fd18fc27944c42e27d6a92a36867c57e1
with little modification.

11:42 AM Changeset in webkit [156184] by fpizlo@apple.com

39 edits
5 adds
5 deletes in trunk/Source/JavaScriptCore

Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637

Rubber stamped by Michael Saboff.

Also moved GPRInfo/FPRInfo into jit/. Rolling back in after fixing JIT-only build
and tests.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/ValueRecovery.h:

(JSC::ValueRecovery::dumpInContext):

dfg/DFGAssemblyHelpers.cpp: Removed.
dfg/DFGAssemblyHelpers.h: Removed.
dfg/DFGBinarySwitch.h:
dfg/DFGByteCodeParser.cpp:
dfg/DFGCCallHelpers.h: Removed.
dfg/DFGDisassembler.cpp:
dfg/DFGFPRInfo.h: Removed.
dfg/DFGGPRInfo.h: Removed.
dfg/DFGGraph.cpp:
dfg/DFGGraph.h:
dfg/DFGJITCompiler.h:
dfg/DFGOSRExit.cpp:
dfg/DFGOSRExit.h:
dfg/DFGOSRExitCompiler.h:
dfg/DFGOSRExitCompilerCommon.h:
dfg/DFGRegisterBank.h:
dfg/DFGRegisterSet.h:
dfg/DFGRepatch.cpp:
dfg/DFGSilentRegisterSavePlan.h:
dfg/DFGThunks.cpp:
dfg/DFGVariableEvent.cpp:
ftl/FTLCArgumentGetter.h:

(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):

ftl/FTLCompile.cpp:
ftl/FTLExitThunkGenerator.h:
ftl/FTLLink.cpp:
ftl/FTLThunks.cpp:
jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.

(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):

jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.

(WTF::printInternal):

jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.

(WTF::printInternal):

jit/JIT.cpp:

(JSC::JIT::JIT):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::JSInterfaceJIT):

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):

jit/ThunkGenerators.cpp:

(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):

llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

runtime/JSCJSValue.h:

11:31 AM Changeset in webkit [156183] by ap@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r156140): Srcset tests are frequently crashing
https://bugs.webkit.org/show_bug.cgi?id=121695

Reviewed by Dean Jackson.

Returning a string created without copying bytes is not safe. It used to be OK
because a new string was immediately created by decodeURLEscapeSequences().
But even that was not great, because decodeURLEscapeSequences() could potentially
return the same string, not a deep copy, if we decided to optimize it like that.

Also made a number of drive-by style fixes.

It's URL, not Url.
It's srcset, not srcSet.
We don't add ".0" in floating point value initializers. It's particularly misleading

to initialize a float with 1.0, which is a double value.

Renamed srcSetLength to srcsetAttributeLength to match srcsetAttribute variable

whose length it caches.

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

11:12 AM Changeset in webkit [156182] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] Clean up the Skip* functions in the GObject DOM bindings code generator
https://bugs.webkit.org/show_bug.cgi?id=121633

Reviewed by Gustavo Noronha Silva.

bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute): Fold in some skipping checks that are used by all callers.
(SkipFunction): Ditto.
(GenerateProperties): Rely on SkipAttribute more thoroughly.
(GenerateFunction): Rely on SkipFunction more thoroughly.
(GenerateFunctions): Rely on SkipAttribute more thoroughly.

10:44 AM Changeset in webkit [156181] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Fix the build after r156144

html/canvas/CanvasRenderingContext2D.cpp: Added missing include.

10:32 AM Changeset in webkit [156180] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

renderStyleOfEnclosingTextNode should update style before using a renderer
https://bugs.webkit.org/show_bug.cgi?id=121690

Reviewed by Enrica Casucci.

Merge https://chromium.googlesource.com/chromium/blink/+/65f089545e8c18cb268dfcbe56cba1cd8045527a

When accessing a renderer editing should always make sure that the style has been updated for the node.
Editing calls splitTextNode in a number of places and then accesses the renderer later. This patch is
the first of many to make sure editing always updates the style before attempting to access the renderer
(or style) of a node after calling a mutation method.

editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::renderStyleOfEnclosingTextNode):

editing/ApplyBlockElementCommand.h:

10:28 AM Changeset in webkit [156179] by ap@apple.com

1 edit
1 move in trunk/LayoutTests

Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609

Followup to <http://trac.webkit.org/changeset/156161> - that change renamed expected
results, but the new test wasn't landed.

fast/loader/image-src-encoded.html: Copied from LayoutTests/fast/loader/image-src-question-mark.html.
fast/loader/image-src-question-mark.html: Removed.

10:18 AM Changeset in webkit [156178] by Darin Adler

3 edits in trunk/Source/WebCore

Fix a couple more CSS leaks
https://bugs.webkit.org/show_bug.cgi?id=121683

Reviewed by Alexey Proskuryakov.

css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::viewSourceStyle): Put the result of the
parseUASheet into a global variable so it doesn't show up as a storage leak.

css/CSSGrammar.y.in: Added a missing adoptRef. This was leaking any rule

we parsed individually.

10:16 AM Changeset in webkit [156177] by Patrick Gansterer

1 edit
4 deletes in trunk/Tools

Nuke remaining VS2005 tools from the tree.
https://bugs.webkit.org/show_bug.cgi?id=121691

Reviewed by Brent Fulgham.

CLWrapper/CLWrapper.cpp: Removed.
CLWrapper/CLWrapper.sln: Removed.
CLWrapper/CLWrapper.vcproj: Removed.
MIDLWrapper/MIDLWrapper.cpp: Removed.
MIDLWrapper/MIDLWrapper.sln: Removed.
MIDLWrapper/MIDLWrapper.vcproj: Removed.
Scripts/parallelcl: Removed.
vcbin/cl.exe: Removed.
vcbin/midl.exe: Removed.

10:16 AM Changeset in webkit [156176] by Bem Jones-Bey

8 edits in trunk/Source/WebCore

Simplify the ShapeOutsideInfo and ShapeInfo interfaces
https://bugs.webkit.org/show_bug.cgi?id=121685

Reviewed by Darin Adler.

With the creation ShapeInfo::computeSegmentsForLine, it became possible to
simplify the ShapeInfo classes. ShapeOutsideInfo has no need to save the
segments, and now that segment creation is in its own method, it doesn't have
to save the segments anymore. This also simplifies the public interface of
ShapeOutsideInfo, as it only has one method to do the computation.

Also, the methods in ShapeOutsideInfo have been renamed to reflect the fact
that ShapeOutsideInfo isn't really interested in segments.

No new tests, no new behavior.

rendering/FloatingObjects.cpp:

(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

rendering/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

rendering/shapes/ShapeInfo.cpp:
rendering/shapes/ShapeInfo.h:
rendering/shapes/ShapeInsideInfo.h:
rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

rendering/shapes/ShapeOutsideInfo.h:

10:10 AM Changeset in webkit [156175] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Making tests added in r156157 JS-only, given that other
code generators are still broken.

Original bug 121305 (StrictTypeChecking extended attribute fails for methods with sequence<T>).
https://bugs.webkit.org/show_bug.cgi?id=121305

Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> on 2013-09-20
Rubber stamped by Alexey Proskuryakov.

bindings/scripts/test/TestObj.idl:

10:07 AM Changeset in webkit [156174] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] Poor rendering opening a Google map short link
https://bugs.webkit.org/show_bug.cgi?id=121687

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-09-20
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

JIRA 495023
Route lines on google map were shown even they were on a hidden canvas.
Include visibility on LayerWebKitThread if it's a canvas layer and respect
the visibility when compositing layers in LayerRenderer.

platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::isCanvasLayer):
(WebCore::LayerData::isVisible):
(WebCore::LayerData::includeVisibility):

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeLayersRecursive):

9:57 AM Changeset in webkit [156173] by Brent Fulgham

2 edits in trunk/Source/WebInspectorUI

[Windows] Unreviewed gardening. Teach WebInspectorUI.vcxproj folder to
ignore Visual Studio's local user settings file.

WebInspectorUI.vcxproj: Added property svn:ignore.

9:48 AM Changeset in webkit [156172] by commit-queue@webkit.org

2 edits in trunk

[CMAKE] FindHarfBuzz: Handle harfbuzz / harfbuzz-icu split
https://bugs.webkit.org/show_bug.cgi?id=121688

Patch by Sergio Correia <Sergio Correia> on 2013-09-20
Reviewed by Martin Robinson.

HarfBuzz 0.9.18 split ICU support into a separate harfbuzz-icu library.
To be able to build with earlier and newer versions of HarfBuzz, we should
check for harfbuzz-icu as well, if version >= 0.9.18.

Source/cmake/FindHarfBuzz.cmake: Check for harfbuzz-icu, if version

0.9.18.

9:45 AM Changeset in webkit [156171] by Patrick Gansterer

2 edits in trunk/Source/WebKit/win

Fix MIDL files for Visual Studio 2012
https://bugs.webkit.org/show_bug.cgi?id=121552

Reviewed by Brent Fulgham.

The MIDL compiler shipped with Visual Studio 2012 does not accept forward declarations
with typedefs. Use the struct keyword in the function signature to fix this problem.

Interfaces/DOMPrivate.idl:

9:45 AM Changeset in webkit [156170] by allan.jensen@digia.com

2 edits in trunk/Source/WTF

Atomics.h does not build on MinGW
https://bugs.webkit.org/show_bug.cgi?id=121663

Reviewed by Darin Adler.

MinGW does not have _ReadWriteBarrier() intrinsic, but does have GCC
inline assembler, so use the GCC definitions instead of MSVC ones.

wtf/Atomics.h:

(WTF::compilerFence):

9:40 AM WebInspector edited by timothy@apple.com

(diff)

9:39 AM WebInspector edited by timothy@apple.com

(diff)

9:35 AM Changeset in webkit [156169] by allan.jensen@digia.com

2 edits in trunk/Source/JavaScriptCore

Inline method exported
https://bugs.webkit.org/show_bug.cgi?id=121664

Reviewed by Darin Adler.

WatchDog::didFire() is marked as an exported symbol eventhough it is
defined inline. This breaks the build on MinGW since it results in dllimport
being declared on a definition.

runtime/Watchdog.h:

(JSC::Watchdog::didFire):

9:18 AM Changeset in webkit [156168] by commit-queue@webkit.org

4 edits in trunk

AX: WebArea claims to have a subrole, but always returns nil.
https://bugs.webkit.org/show_bug.cgi?id=121658

Patch by Sam White <Samuel White> on 2013-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing AXWebArea related test to reflect unused attribute removal.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

Updated test output to reflect removal of unused NSAccessibilitySubroleAttribute in AXWebArea.

platform/mac/accessibility/document-attributes-expected.txt:

8:47 AM Changeset in webkit [156167] by commit-queue@webkit.org

2 edits
1 add in trunk/Tools

[GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
https://bugs.webkit.org/show_bug.cgi?id=121294

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
Reviewed by Martin Robinson.

Provide a new patch to deal with the issue in the GTK+ module from
the internal jhbuild environment. This issue has been reported
upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).

gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.

8:34 AM Changeset in webkit [156166] by akling@apple.com

14 edits in trunk/Source/WebCore

Add valueForLength/minimumValueForLength wrappers to RenderElement.
<https://webkit.org/b/121676>

Reviewed by Antti Koivisto.

Add two inline wrappers for these functions so we don't have to pass
the RenderView everywhere.

8:20 AM Changeset in webkit [156165] by commit-queue@webkit.org

4 edits in trunk

[ATK][WTR] accessibility/aria-invalid.html times out
https://bugs.webkit.org/show_bug.cgi?id=121668

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
false in case of aria-invalid event with empty value.

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
case of aria-invalid event with empty value.

LayoutTests:

Updated the expectation of aria-invalid.html test, which was timing out
before bug 120421 and this fix.

platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because

it now passes with this fix and the patch from bug 120421.

8:15 AM Changeset in webkit [156164] by commit-queue@webkit.org

9 edits
2 adds in trunk/Tools

[ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
https://bugs.webkit.org/show_bug.cgi?id=120421

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Implemented the notification listener for AccessibilityUIElement for
WebKitTestRunner. The signal is generated by
AXObjectCache::postPlatformNotification() and received by
axObjectEventListener(). axObjectEventListener() will then invoke
JSObjectCallAsFunction() with the respective callback function. The
notification handlers are stored in HashMap in
AccessibilityNotificationHandlerAtk.cpp.

Moved ATK signal handling (printAccessibilityEvent and
axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.

WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the

include path.

WebKitTestRunner/GNUmakefile.am:

Added AccessibilityNotificationHandlerAtk.cpp/h.

WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved

listener IDs to AccessibilityNotificationHandlerAtk.cpp.

WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved

listener IDs to AccessibilityNotificationHandlerAtk.cpp.

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a

notification handler for GTK+ and EFL.

WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

Moved printAccessibilityEvent and axObjectEventListener to
AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::logAccessibilityEvents): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::resetToConsistentState): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.

WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.

(WTR::printAccessibilityEvent): Prints accessibility events. This
function was moved from AccessibilityControllerAtk.cpp.
(WTR::axObjectEventListener): Callback for signals. This function was
moved from AccessibilityControllerAtk.cpp.
(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
Initialize element and function callback.
(WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
Removes handler from HashMap and disconnects callbacks if necessary.
(WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
logging mode and connects callbacks.
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
Sets the notification callback and connects callback to signals.
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
Removes the notification callback from HashMap.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connects axObjectEventListener to ATK signals.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnects callback.

WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.

(WTR::AccessibilityNotificationHandler::create): Creates a new instance
of AccessibilityNotificationHandler.
(WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
element.
(WTR::AccessibilityNotificationHandler::platformElement): Gets the
element.
(WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
Gets the notification callback.

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::addNotificationListener): Creates
notification handler, set the platform element and the notification
callback.
(WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
notification handler.

WebKitTestRunner/PlatformEfl.cmake:

Added AccessibilityNotificationHandlerAtk.cpp.

8:04 AM Changeset in webkit [156163] by Martin Robinson

44 edits in trunk/Source/WebCore

[GTK] Fix some small style issues in the bindings
https://bugs.webkit.org/show_bug.cgi?id=121613

Reviewed by Carlos Garcia Campos.

bindings/scripts/CodeGeneratorGObject.pm: When printing the license

header use the more common comment style within the WebKit project.
(GenerateProperty): Indent property definitions according to WebKit style, improve
the nick and blurb properties, and improve the various parameter spec argument layout.
(GenerateFunction): Remove the newline from function signatures to match WebKit style.

bindings/scripts/test/GObject: Update bindings test results.

7:58 AM Changeset in webkit [156162] by zarvai@inf.u-szeged.hu

4 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

platform/qt-wk1/TestExpectations:
platform/qt-wk2/TestExpectations:
platform/qt-wk2/fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
platform/qt/TestExpectations:

7:43 AM Changeset in webkit [156161] by commit-queue@webkit.org

1 edit
5 moves in trunk/LayoutTests

Modified img src and srcset encoded URL tests
https://bugs.webkit.org/show_bug.cgi?id=121677

Previous tests have broken the Windows builds, since '?' is not a valid char.
Moved to using '@'

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Anders Carlsson.

fast/hidpi/image-srcset-encoded-expected.txt: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark-expected.txt.
fast/hidpi/image-srcset-encoded.html: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark.html.
fast/hidpi/resources/image@test.png: Renamed from LayoutTests/fast/hidpi/resources/image?test.png.
fast/loader/image-src-encoded-expected.txt: Renamed from LayoutTests/fast/loader/image-src-question-mark-expected.txt.
fast/loader/resources/image@test.png: Renamed from LayoutTests/fast/loader/resources/image?test.png.

7:12 AM Changeset in webkit [156160] by zarvai@inf.u-szeged.hu

1 edit
16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update tests after r156066 and r156083.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.png: Added r156083.
platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.txt: Added r156083.
platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.png: Added r156083.
platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.txt: Added r156083.
platform/qt-wk1/fast/forms/form-element-geometry-expected.png: Added r156083.
platform/qt-wk1/fast/forms/form-element-geometry-expected.txt: Added r156083.
platform/qt-wk1/fast/forms/menulist-separator-painting-expected.txt: Added r156083.
platform/qt-wk1/fast/forms/select-baseline-expected.png: Added r156083.
platform/qt-wk1/fast/forms/select-baseline-expected.txt: Added r156083.
platform/qt-wk1/fast/forms/selectlist-minsize-expected.txt: Added r156083.
platform/qt-wk1/fast/replaced/three-selects-break-expected.txt: Added r156083.
platform/qt-wk1/js/dom/switch-behaviour-expected.txt: Added r156066.

6:23 AM Changeset in webkit [156159] by Patrick Gansterer

8 edits in trunk/Source

[CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
https://bugs.webkit.org/show_bug.cgi?id=121672

Reviewed by Gyuyoung Kim.

Since the scope of add_definitions() is always a whole file, we need to use
target properties instead to set definitions only for specific targets.

Source/JavaScriptCore:

CMakeLists.txt:

Source/WebCore:

CMakeLists.txt:

Source/WebKit:

CMakeLists.txt:

Source/WTF:

wtf/CMakeLists.txt:

6:17 AM Changeset in webkit [156158] by tonikitoo@webkit.org

9 edits in trunk

Source/WebCore: Make "autoscroll for drag'n drop" a setting
https://bugs.webkit.org/show_bug.cgi?id=121559

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

Currently, there is a ChromeClient hook to make the
feature opt'ed-in or out. That makes it harder to test the
feature on ports that do not enable it, e.g. Mac/WebKit2 port.
However, Mac/WebKit2 is the port that has the best drag'n drop
WTR implementation.

Patch changes the toggle on/off mechanism to be a setting,
and exposes it through InternalSetting interface for testing.

page/AutoscrollController.cpp:

(WebCore::AutoscrollController::updateDragAndDrop):

page/ChromeClient.h:
page/Settings.in:
testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAutoscrollForDragAndDropEnabled):

testing/InternalSettings.h:
testing/InternalSettings.idl:

LayoutTests: Make "autoscroll" for drag'n drop a setting
https://bugs.webkit.org/show_bug.cgi?id=121559

fast/events/drag-and-drop-autoscroll.html:

Adapts the test so that is toggles the feature on
via InternalSettings interface.

6:16 AM Changeset in webkit [156157] by tonikitoo@webkit.org

6 edits in trunk/Source/WebCore

StrictTypeChecking extended attribute fails for methods with sequence<T> https://bugs.webkit.org/show_bug.cgi?id=121305

Reviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

The extended attribute StrictTypeChecking can not be set to methods if
one of the parameters is a "sequence".
Basically, since "sequence" is not considered a native type
(see function IsNativeType) the Perl code generator tries to
include its supposedly associated header, in this case "JSsequence.h"
Compilation then fails.

It is a problem for bindings including WebGL, where all methods
are supposed to be set as StrictTypeChecking (see bug 44202 [1]). Due to this restriction,
it relaxed, but I would like to bring it back.

Patch fixes the issue by hardening the way includes are auto-added
for methods where StrictTypeChecking extended attribute is present.
Now, only wrapper types (see IsWrapperType) trigger header inclusion,
excluding arrays, sequences, basic types, etc.

[1] https://bugs.webkit.org/show_bug.cgi?id=44202

bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):

bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/TestObj.idl:

5:28 AM Changeset in webkit [156156] by zarvai@inf.u-szeged.hu

17 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Update tests after change to Qt 5.1.1

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

platform/qt/css1/text_properties/letter_spacing-expected.png:
platform/qt/css1/text_properties/letter_spacing-expected.txt:
platform/qt/fast/css/first-line-text-decoration-expected.png:
platform/qt/fast/css/first-line-text-decoration-expected.txt:
platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
platform/qt/fast/css/word-space-extra-expected.png:
platform/qt/fast/css/word-space-extra-expected.txt:
platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
platform/qt/fast/text/basic/003-expected.png:
platform/qt/fast/text/basic/003-expected.txt:
platform/qt/fast/text/basic/013-expected.png:
platform/qt/fast/text/basic/013-expected.txt:
platform/qt/fast/text/text-letter-spacing-expected.png:
platform/qt/fast/text/text-letter-spacing-expected.txt:

5:16 AM Changeset in webkit [156155] by akling@apple.com

38 edits in trunk/Source/WebCore

Optimize fetching the Node for never-anonymous renderers.
<https://webkit.org/b/121627>

Reviewed by Antti Koivisto.

Add a RenderObject::nodeForNonAnonymous() that can be used instead
of node() when a renderer is guaranteed non-anonymous.

Use this to implement reference element getters for the various
renderers that are known at compile-time to correspond to a DOM node.

Also renamed existingElement() => element() since using an alternate
name for a reference overload isn't actually necessary.

4:56 AM Changeset in webkit [156154] by Patrick Gansterer

7 edits in trunk/Source

Remove duplicated secondsPerDay variables
https://bugs.webkit.org/show_bug.cgi?id=121601

Reviewed by Andreas Kling.

Source/WebCore:

Use secondsPerDay from DateMath.h instead of defining it again.

history/HistoryItem.cpp:

(WebCore::timeToDay):

Source/WebKit/win:

Use secondsPerDay from DateMath.h instead of defining it again.

MarshallingHelpers.cpp:

Source/WTF:

Move secondsPerDay from the source into the header file
to make it accessible by other code too.

wtf/DateMath.cpp:
wtf/DateMath.h:

4:54 AM Changeset in webkit [156153] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Fix duplicated loop variable names after r155743
https://bugs.webkit.org/show_bug.cgi?id=121667

Reviewed by Andreas Kling.

Do not use the same name for variables in nested loops to fix a compiler warning.

page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

4:51 AM Changeset in webkit [156152] by allan.jensen@digia.com

2 edits in trunk/Tools

Update features.pri
https://bugs.webkit.org/show_bug.cgi?id=121670

Reviewed by Jocelyn Turcotte.

Remove feature flags that no longer exists and new ones added to FeatureList.pm

qmake/mkspecs/features/features.pri:

4:44 AM Changeset in webkit [156151] by Antti Koivisto

27 edits in trunk/Source/WebCore

Make RenderObject::parent() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121671

Reviewed by Andreas Kling.

Make RenderObject::parent() return RenderElement and adopt everywhere.
Moved addChild/removeChild from RenderObject to RenderElement.
Uninlined a few big RenderObject functions.
Renamed RenderObject::remove() -> RenderObject::removeFromParent()

4:32 AM Changeset in webkit [156150] by Csaba Osztrogonác

3 edits in trunk/Source/WebCore

Buildfix after r156133 for !ENABLE(WORKERS) platforms
https://bugs.webkit.org/show_bug.cgi?id=121669

Reviewed by Antti Koivisto.

platform/ThreadGlobalData.cpp:
platform/ThreadGlobalData.h:

4:18 AM Changeset in webkit [156149] by commit-queue@webkit.org

4 edits in trunk

[GTK][WK2] accessibility/selection-states.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116972

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

isSelectable() was not exposed in Accessibility.

WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

LayoutTests:

Unskipping accessibility/selection-states.html test.

platform/gtk-wk2/TestExpectations:

3:58 AM Changeset in webkit [156148] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit/win

Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Unreviewed buildfix after r156144.

DOMCoreClasses.cpp:

(DOMElement::boundingBox):
(DOMElement::font):

2:59 AM Changeset in webkit [156147] by Antti Koivisto

135 edits in trunk/Source/WebCore

Make createRenderer() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121666

Rubber-stamped by Andreas Kling.

Tighter typing.

2:52 AM Changeset in webkit [156146] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Buildfix for ENABLE(CSS_FILTERS) && !ENABLE(ACCELERATED_COMPOSITING) after r155131.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::enclosingFilterRepaintLayer):

2:51 AM Changeset in webkit [156145] by Patrick Gansterer

2 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header after r154146.

platform/win/WebCoreBundleWin.cpp:

2:48 AM BadContent edited by zandobersek@gmail.com

Block a spamming account. (diff)

1:59 AM Changeset in webkit [156144] by Antti Koivisto

22 edits in trunk/Source/WebCore

Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Reviewed by Andreas Kling.

Also add isRenderElement() test and casting functions.

12:34 AM Changeset in webkit [156143] by zarvai@inf.u-szeged.hu

5 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

platform/qt-wk2/fast/css/word-space-extra-expected.png: Added r155957.
platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Rebase after r155957.
platform/qt/fast/css/pseudo-first-line-border-width-expected.txt: Rebase after r155957.
platform/qt/fast/css/word-space-extra-expected.txt: Rebase after r155957.
platform/qt/fast/forms/select-empty-option-height-expected.txt: Rebase after rr156040.

Sep 19, 2013:

11:08 PM Changeset in webkit [156142] by andersca@apple.com

2 edits in trunk/Source/WebCore

Handle null font families.

Reviewed by Darin Adler.

platform/graphics/Font.cpp:

(WebCore::computeFontGlyphsCacheHash):
Don't crash when trying to hash null strings.

10:57 PM Changeset in webkit [156141] by Darin Adler

2 edits in trunk/Source/WebCore

Fix a couple mistakes in my recent CSS grammar leak patch
https://bugs.webkit.org/show_bug.cgi?id=121659

Reviewed by Alexey Proskuryakov.

css/CSSGrammar.y.in: Added initialization to nullptr for some error cases

that were otherwise leaving a bad value for the result of the production.
Also fixed a reversed logical expression.

10:02 PM Changeset in webkit [156140] by commit-queue@webkit.org

3 edits
6 adds in trunk

Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-19
Reviewed by Benjamin Poulain.

Source/WebCore:

Tests: fast/hidpi/image-srcset-question-mark.html

fast/loader/image-src-question-mark.html

Removed URL decoding from src and srcset's handling algorithm, since they break encoded URLS.

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseImagesWithScaleFromSrcSetAttribute):
(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

These tests make sure that encoded URLs are properly handled, and especially URLs
with a question mark in them.

fast/hidpi/image-srcset-question-mark-expected.txt: Added.
fast/hidpi/image-srcset-question-mark.html: Added.
fast/hidpi/resources/image?test.png: Added.
fast/loader/image-src-question-mark-expected.txt: Added.
fast/loader/image-src-question-mark.html: Added.
fast/loader/resources/image?test.png: Added.

9:46 PM Changeset in webkit [156139] by andersca@apple.com

2 edits in trunk/Source/WebCore

Avoid calling AtomicString::lower() in makeFontGlyphsCacheKey
https://bugs.webkit.org/show_bug.cgi?id=121656

Reviewed by Darin Adler.

Instead of lower casing AtomicStrings, store the strings as is and use the case folding
hash and case insensitive compare to determine equality.

platform/graphics/Font.cpp:

(WebCore::operator==):
(WebCore::makeFontGlyphsCacheKey):
(WebCore::computeFontGlyphsCacheHash):

9:29 PM Changeset in webkit [156138] by Darin Adler

2 edits in trunk/Source/WebCore

Fix leaks in CSS parser caused by overwriting owned raw pointers with 0
https://bugs.webkit.org/show_bug.cgi?id=121655

Reviewed by Anders Carlsson.

css/CSSGrammar.y.in: Use nullptr instead of 0. Use unique_ptr instead

of a raw pointer in cases where we might or might not actually keep
the allocated memory. This can still be cleaned up further, but this
should fix the memory leaks we have been seeing.

9:07 PM Changeset in webkit [156137] by g.czajkowski@samsung.com

18 edits in trunk/LayoutTests

Use shouldBecomeEqual in asynchronous spellchecking tests.
https://bugs.webkit.org/show_bug.cgi?id=121483

Reviewed by Darin Adler.

Every asynchronous spellchecking layout test waits for spelling or grammar
markers using setTimeout. It duplicates the code, moreover the implementation
differs in every test.

Use shouldBecomeEqual helper (introduced in r143860) to test spellchecking
asynchronously.

editing/spelling/grammar-markers-expected.txt:
editing/spelling/grammar-markers-hidpi-expected.txt:
editing/spelling/grammar-markers-hidpi.html:
editing/spelling/grammar-markers.html:

editing/spelling/grammar-paste-expected.txt:
editing/spelling/grammar-paste.html:

Dump text of destination element instead of source one to show what is
really tested. It stops outputting that the input and textarea elements
can store html tags, for example,
PASS INPUT has a marker on 'I have a<b>n ki</b>wi'.

editing/spelling/script-tests/spellcheck-paste.js:

(verifyMarker):
(pasteAndVerify):

editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
editing/spelling/spellcheck-paste-continuous-disabled.html:
editing/spelling/spellcheck-paste-disabled-expected.txt:
editing/spelling/spellcheck-paste-disabled.html:

At the beginning, those tests check whether spelling marker appears
synchronously. Then, spell checking is disabled to check whether
the markers have disappeared properly.
There is no need to check spelling asynchronously in the second part
of the tests. Use synchronous spellchecking path instead.

editing/spelling/spellcheck-paste-expected.txt:
editing/spelling/spelling-marker-description-expected.txt:
editing/spelling/spelling-marker-description.html:
platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
platform/mac/editing/spelling/grammar-markers-expected.png:
platform/mac/editing/spelling/grammar-markers-hidpi-expected.png:

7:05 PM Changeset in webkit [156136] by Brent Fulgham

37 edits
5 adds
5 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r156120.
http://trac.webkit.org/changeset/156120
https://bugs.webkit.org/show_bug.cgi?id=121651

Broke windows runtime and all tests (Requested by bfulgham on
#webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-09-19

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/ValueRecovery.h:

(JSC::ValueRecovery::dumpInContext):

dfg/DFGAssemblyHelpers.cpp: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.cpp.

(JSC::DFG::AssemblyHelpers::executableFor):
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):

dfg/DFGAssemblyHelpers.h: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.h.

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::codeBlock):
(JSC::DFG::AssemblyHelpers::vm):
(JSC::DFG::AssemblyHelpers::assembler):
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::branchIfNotCell):
(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):
(JSC::DFG::AssemblyHelpers::branchIfNotObject):
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
(JSC::DFG::AssemblyHelpers::boxInt52):
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::globalObjectFor):
(JSC::DFG::AssemblyHelpers::strictModeFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(JSC::DFG::AssemblyHelpers::symbolTableFor):
(JSC::DFG::AssemblyHelpers::offsetOfLocals):
(JSC::DFG::AssemblyHelpers::offsetOfArgumentsIncludingThis):

dfg/DFGBinarySwitch.h:
dfg/DFGByteCodeParser.cpp:
dfg/DFGCCallHelpers.h: Renamed from Source/JavaScriptCore/jit/CCallHelpers.h.

(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):
(JSC::DFG::CCallHelpers::setupResults):

dfg/DFGDisassembler.cpp:
dfg/DFGFPRInfo.h: Renamed from Source/JavaScriptCore/jit/FPRInfo.h.

(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::toArgumentRegister):
(JSC::DFG::FPRInfo::debugName):

dfg/DFGGPRInfo.h: Renamed from Source/JavaScriptCore/jit/GPRInfo.h.

(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::payloadOnly):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
(JSC::DFG::GPRInfo::toArgumentRegister):

dfg/DFGGraph.cpp:
dfg/DFGGraph.h:
dfg/DFGJITCompiler.h:
dfg/DFGOSRExit.cpp:
dfg/DFGOSRExit.h:
dfg/DFGOSRExitCompiler.h:
dfg/DFGOSRExitCompilerCommon.h:
dfg/DFGRegisterBank.h:
dfg/DFGRegisterSet.h:
dfg/DFGRepatch.cpp:
dfg/DFGSilentRegisterSavePlan.h:
dfg/DFGThunks.cpp:
dfg/DFGVariableEvent.cpp:
ftl/FTLCArgumentGetter.h:

ftl/FTLCompile.cpp:
ftl/FTLExitThunkGenerator.h:
ftl/FTLLink.cpp:
ftl/FTLThunks.cpp:
jit/JIT.cpp:

(JSC::JIT::JIT):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::preserveReturnAddressAfterCall):
(JSC::JSInterfaceJIT::restoreReturnAddressBeforeReturn):

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):

jit/ThunkGenerators.cpp:

llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

runtime/JSCJSValue.h:

6:51 PM Changeset in webkit [156135] by eric.carlson@apple.com

8 edits
2 adds in trunk

MediaStream API: update MediaStreamTrackEvent object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121624

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/mediastream/MediaStreamTrackEvent-constructor.html

Modules/mediastream/MediaStreamTrack.idl: Remove NoInterfaceObject.

Modules/mediastream/MediaStreamTrackEvent.cpp:

(WebCore::MediaStreamTrackEventInit::MediaStreamTrackEventInit): New.
(WebCore::MediaStreamTrackEvent::create): New form that takes an initialize.
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent): Ditto.

Modules/mediastream/MediaStreamTrackEvent.h:
Modules/mediastream/MediaStreamTrackEvent.idl:

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): New.

bindings/js/JSDictionary.h:

LayoutTests:

fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt: Added.
fast/mediastream/MediaStreamTrackEvent-constructor.html: Added.

6:41 PM Changeset in webkit [156134] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

ASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes
https://bugs.webkit.org/show_bug.cgi?id=121650

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-19
Reviewed by Benjamin Poulain.

wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):

6:10 PM Changeset in webkit [156133] by andersca@apple.com

4 edits in trunk/Source/WebCore

Remove #if !ENABLE(WORKERS) code in ThreadGlobalData
https://bugs.webkit.org/show_bug.cgi?id=121649

Reviewed by Sam Weinig.

This lets us remove a FIXME. Also, move threadGlobalData out of line; there's no need for it to be inline.

WebCore.exp.in:
platform/ThreadGlobalData.cpp:

(WebCore::threadGlobalData):

platform/ThreadGlobalData.h:

6:00 PM Changeset in webkit [156132] by andersca@apple.com

19 edits in trunk/Source/WebCore

Modernize Length setters/getters
https://bugs.webkit.org/show_bug.cgi?id=121647

Reviewed by Andreas Kling.

Add a move constructor and move assignment operator to Length and fixup some of the getters and setters.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):

css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyLineHeight::createHandler):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::LengthPropertyWrapper::LengthPropertyWrapper):
(WebCore::LengthPropertyWrapper::blend):
(WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper):
(WebCore::FillLayerPropertyWrapper::blend):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

platform/CalculationValue.h:

(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):

platform/Length.cpp:

(WebCore::CalculationValueHandleMap::remove):
(WebCore::CalculationValueHandleMap::find):
(WebCore::Length::decrementCalculatedRef):

platform/Length.h:

(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::moveFromLength):

platform/LengthBox.cpp:

(WebCore::LengthBox::logicalLeft):
(WebCore::LengthBox::logicalRight):
(WebCore::LengthBox::before):
(WebCore::LengthBox::after):
(WebCore::LengthBox::start):
(WebCore::LengthBox::end):

platform/LengthBox.h:

(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::left):
(WebCore::LengthBox::right):
(WebCore::LengthBox::top):
(WebCore::LengthBox::bottom):

platform/LengthSize.h:

(WebCore::LengthSize::LengthSize):
(WebCore::LengthSize::setWidth):
(WebCore::LengthSize::width):
(WebCore::LengthSize::setHeight):
(WebCore::LengthSize::height):

platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::BlurFilterOperation::create):
(WebCore::FilterOperation::BlurFilterOperation::stdDeviation):
(WebCore::FilterOperation::BlurFilterOperation::BlurFilterOperation):

rendering/style/BasicShapes.h:

(WebCore::BasicShapeRectangle::x):
(WebCore::BasicShapeRectangle::y):
(WebCore::BasicShapeRectangle::width):
(WebCore::BasicShapeRectangle::height):
(WebCore::BasicShapeRectangle::cornerRadiusX):
(WebCore::BasicShapeRectangle::cornerRadiusY):
(WebCore::BasicShapeRectangle::setX):
(WebCore::BasicShapeRectangle::setY):
(WebCore::BasicShapeRectangle::setWidth):
(WebCore::BasicShapeRectangle::setHeight):
(WebCore::BasicShapeRectangle::setCornerRadiusX):
(WebCore::BasicShapeRectangle::setCornerRadiusY):
(WebCore::BasicShapeCircle::centerX):
(WebCore::BasicShapeCircle::centerY):
(WebCore::BasicShapeCircle::radius):
(WebCore::BasicShapeCircle::setCenterX):
(WebCore::BasicShapeCircle::setCenterY):
(WebCore::BasicShapeCircle::setRadius):
(WebCore::BasicShapeEllipse::centerX):
(WebCore::BasicShapeEllipse::centerY):
(WebCore::BasicShapeEllipse::radiusX):
(WebCore::BasicShapeEllipse::radiusY):
(WebCore::BasicShapeEllipse::setCenterX):
(WebCore::BasicShapeEllipse::setCenterY):
(WebCore::BasicShapeEllipse::setRadiusX):
(WebCore::BasicShapeEllipse::setRadiusY):
(WebCore::BasicShapePolygon::getXAt):
(WebCore::BasicShapePolygon::getYAt):
(WebCore::BasicShapePolygon::appendPoint):
(WebCore::BasicShapeInsetRectangle::top):
(WebCore::BasicShapeInsetRectangle::right):
(WebCore::BasicShapeInsetRectangle::bottom):
(WebCore::BasicShapeInsetRectangle::left):
(WebCore::BasicShapeInsetRectangle::cornerRadiusX):
(WebCore::BasicShapeInsetRectangle::cornerRadiusY):
(WebCore::BasicShapeInsetRectangle::setTop):
(WebCore::BasicShapeInsetRectangle::setRight):
(WebCore::BasicShapeInsetRectangle::setBottom):
(WebCore::BasicShapeInsetRectangle::setLeft):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY):

rendering/style/FillLayer.h:

(WebCore::FillSize::FillSize):
(WebCore::FillLayer::xPosition):
(WebCore::FillLayer::yPosition):
(WebCore::FillLayer::sizeLength):
(WebCore::FillLayer::setXPosition):
(WebCore::FillLayer::setYPosition):

rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::NinePieceImage):

rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::computeOutset):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::specifiedLineHeight):

rendering/style/RenderStyle.h:
rendering/style/StyleBoxData.h:

(WebCore::StyleBoxData::width):
(WebCore::StyleBoxData::height):
(WebCore::StyleBoxData::minWidth):
(WebCore::StyleBoxData::minHeight):
(WebCore::StyleBoxData::maxWidth):
(WebCore::StyleBoxData::maxHeight):
(WebCore::StyleBoxData::verticalAlign):

rendering/style/StyleReflection.h:

(WebCore::StyleReflection::offset):
(WebCore::StyleReflection::setOffset):

5:22 PM Changeset in webkit [156131] by akling@apple.com

3 edits in trunk/Source/WebCore

Out-of-line InspectorValues create() methods.
<https://webkit.org/b/121639>

Reviewed by Joseph Pecoraro.

These functions are hardly performance-critical and are taking up
quite a lot of space.

Shrinks the WebCore binary by 70500 bytes.

4:19 PM Changeset in webkit [156130] by ap@apple.com

23 edits in trunk

Layout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121458

Reviewed by Sam Weinig.

Source/WebCore:

The code to automagically produce line numbers is quite fragile. Added some FIXMEs,
and added an issue that was making reporting flaky for code is JS event handlers
executed while parsing was paused.

page/PageConsole.cpp: (WebCore::PageConsole::addMessage): Use actual "script is

running" check instead of "parsing a script element" one.

LayoutTests:

fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt:
fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt:
fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt:
fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt:
fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt:
fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt:
fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt:
fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt:
fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt:
fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
fast/frames/sandboxed-iframe-scripting-04-expected.txt:
http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
media/video-controls-no-scripting-expected.txt:

We now get a line number for blocked inline scripts, which is a progression.
It is the line number for the closing </script>, which is not ideal, but better
than nothing.

http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:

Also a progression - we now get a line number for offending <script>.

4:15 PM Changeset in webkit [156129] by dbates@webkit.org

2 edits in trunk/Source/WTF

[iOS] Define mainThreadEstablishedAsPthreadMain to be true in WTF::initializeMainThreadPlatform()

Reviewed by Joseph Pecoraro.

This change was inadvertently left out of <http://trac.webkit.org/changeset/155926>.

wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):

4:03 PM Changeset in webkit [156128] by weinig@apple.com

12 edits
1 delete in trunk/Source/WTF

Remove OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=121612

Reviewed by Anders Carlsson.

GNUmakefile.list.am:
WTF.pro:
WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/Assertions.cpp:
wtf/CMakeLists.txt:
wtf/DateMath.h:
wtf/FastBitVector.h:
wtf/Forward.h:
wtf/OwnArrayPtr.h: Removed.
wtf/VectorTraits.h:

4:02 PM Changeset in webkit [156127] by dbates@webkit.org

2 edits in trunk/Source/WTF

Substitute return type void for bool in function declaration for WTF::initializeWebThread()

Reviewed by Joseph Pecoraro.

Make the declaration of WTF::initializeWebThread() match the function prototype
of its definition.

wtf/MainThread.h:

3:42 PM Changeset in webkit [156126] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows build part 2. m_jitCodeMap should always be there.

bytecode/CodeBlock.h:

(JSC::CodeBlock::jitCodeMap):

3:38 PM Changeset in webkit [156125] by rniwa@webkit.org

8 edits in trunk/Source/WebCore

Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places
https://bugs.webkit.org/show_bug.cgi?id=121589

Reviewed by Dean Jackson.

Replaced CSSLinearTimingFunctionValue by the identifier "linear" and used switch statements on
TimingFunction::type() in more places where we were branching on every type.

Merge https://chromium.googlesource.com/chromium/blink/+/5454f20c71090c35bdd1053e5cc572d5c0bdede7
Merge https://chromium.googlesource.com/chromium/blink/+/104ad42c523d32b67d108c6e59f4f27488fe38a5

css/CSSComputedStyleDeclaration.cpp:

(WebCore::createTimingFunctionValue):

css/CSSTimingFunctionValue.cpp:
css/CSSTimingFunctionValue.h:
css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:

(WebCore::CSSValue::isCubicBezierTimingFunctionValue):

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::progress):

3:27 PM Changeset in webkit [156124] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

Remove some of the tautologies in DFGRepatch function naming.

Rubber stamped by Mark Hahnenberg.

For example change DFG::dfgLinkFor() to be DFG::linkFor().

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):

dfg/DFGOperations.cpp:
dfg/DFGRepatch.cpp:

(JSC::DFG::repatchCall):
(JSC::DFG::repatchByIdSelfAccess):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::repatchGetByID):
(JSC::DFG::buildGetByIDList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::repatchPutByID):
(JSC::DFG::buildPutByIdList):
(JSC::DFG::repatchIn):
(JSC::DFG::linkFor):
(JSC::DFG::linkSlowFor):
(JSC::DFG::linkClosureCall):
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):

dfg/DFGRepatch.h:

(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):

3:23 PM Changeset in webkit [156123] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows build. ScratchBuffer should always be available regardless of
ENABLE_DFG_JIT.

runtime/VM.h:

3:16 PM Changeset in webkit [156122] by dbates@webkit.org

5 edits in trunk/Source/JavaScriptCore

[iOS] Add more iOS logic to the JavaScriptCore build configuration files
https://bugs.webkit.org/show_bug.cgi?id=121635

Reviewed by Geoffrey Garen.

Towards building JavaScriptCore for both OS X and iOS using the same
set of configuration files, add more iOS logic.

Configurations/Base.xcconfig:
Configurations/JSC.xcconfig:
Configurations/JavaScriptCore.xcconfig:
Configurations/ToolExecutable.xcconfig:

3:12 PM Changeset in webkit [156121] by commit-queue@webkit.org

17 edits in trunk/Source/WebCore

Unreviewed, rolling out r156119.
http://trac.webkit.org/changeset/156119
https://bugs.webkit.org/show_bug.cgi?id=121640

broke builds in various ways (Requested by anttik on #webkit).

accessibility/AccessibilitySpinButton.cpp:
bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

css/SelectorChecker.cpp:
dom/ContainerNode.h:
dom/Element.h:
dom/PseudoElement.cpp:

(WebCore::PseudoElement::didAttachRenderers):

editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

editing/TypingCommand.cpp:
html/ImageDocument.cpp:
page/PageSerializer.cpp:
rendering/RenderElement.h:
rendering/RenderObject.h:
svg/SVGAnimatedColor.cpp:

(WebCore::adjustForCurrentColor):

svg/SVGLocatable.cpp:
svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):

svg/graphics/filters/SVGFEImage.h:

3:10 PM Changeset in webkit [156120] by fpizlo@apple.com

37 edits
5 moves in trunk/Source/JavaScriptCore

Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637

Rubber stamped by Michael Saboff.

Also moved GPRInfo/FPRInfo into jit/.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/ValueRecovery.h:

(JSC::ValueRecovery::dumpInContext):

dfg/DFGAssemblyHelpers.cpp: Removed.
dfg/DFGAssemblyHelpers.h: Removed.
dfg/DFGBinarySwitch.h:
dfg/DFGByteCodeParser.cpp:
dfg/DFGCCallHelpers.h: Removed.
dfg/DFGDisassembler.cpp:
dfg/DFGFPRInfo.h: Removed.
dfg/DFGGPRInfo.h: Removed.
dfg/DFGGraph.cpp:
dfg/DFGGraph.h:
dfg/DFGJITCompiler.h:
dfg/DFGOSRExit.cpp:
dfg/DFGOSRExit.h:
dfg/DFGOSRExitCompiler.h:
dfg/DFGOSRExitCompilerCommon.h:
dfg/DFGRegisterBank.h:
dfg/DFGRegisterSet.h:
dfg/DFGRepatch.cpp:
dfg/DFGSilentRegisterSavePlan.h:
dfg/DFGThunks.cpp:
dfg/DFGVariableEvent.cpp:
ftl/FTLCArgumentGetter.h:

ftl/FTLCompile.cpp:
ftl/FTLExitThunkGenerator.h:
ftl/FTLLink.cpp:
ftl/FTLThunks.cpp:
jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.

(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):

jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.

(WTF::printInternal):

jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.

(WTF::printInternal):

jit/JIT.cpp:

(JSC::JIT::JIT):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::JSInterfaceJIT):

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):

jit/ThunkGenerators.cpp:

llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

runtime/JSCJSValue.h:

3:03 PM Changeset in webkit [156119] by Antti Koivisto

17 edits in trunk/Source/WebCore

Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Reviewed by Andreas Kling.

Also add isRenderElement() test and casting functions.

2:42 PM Changeset in webkit [156118] by akling@apple.com

2 edits in trunk/Source/WebCore

Streamline JSMainThreadNullState.
<https://webkit.org/b/121636>

Reviewed by Anders Carlsson.

JSMainThreadNullState is only used by non-JavaScript bindings and
thus won't ever call didLeaveScriptContext() on destruction.
Specialize the class for its use-case instead of sharing code
with JSMainThreadExecState.

Shrinks the WebCore binary by 82848 bytes.

2:40 PM Changeset in webkit [156117] by akling@apple.com

2 edits in trunk/Source/WTF

Assume allocator success in Vector unless using try* functions.
<https://webkit.org/b/121629>

Reviewed by Anders Carlsson.

Turn some Vector::begin() null checking into assertions instead.

We have try* style functions for when an allocation request is so
large that it might actually fail. fastMalloc() will never return
null (it will just CRASH() instead.)

2:27 PM Changeset in webkit [156116] by betravis@adobe.com

12 edits in trunk

CSS_SHAPES not supported on AppleWin port
https://bugs.webkit.org/show_bug.cgi?id=118810

Enabling CSS Shapes on Windows port

Reviewed by Brent Fulgham.

LayoutTests/Changelog
LayoutTEsts/platform/win/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
Source/WebCore/WebCore.vcxproj/WebCoreCommon.props
Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd
Source/WebCore/css/CSSPropertyNames.in
Source/WebKit/ChangeLog
Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/FeatureDefines.props
WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props

2:06 PM Changeset in webkit [156115] by mitz@apple.com

2 edits in trunk/Tools

Attempted build fix after r156114.

Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.

1:46 PM Changeset in webkit [156114] by mitz@apple.com

1 edit
2 deletes in trunk/WebKitLibraries

Removed WebCoreSQLite3. It has been unused for years.

Rubber-stamped by Mark Rowe.

WebCoreSQLite3: Removed.
WebCoreSQLite3/sqlite3.h: Removed.
WebCoreSQLite3/sqlite3ext.h: Removed.
libWebCoreSQLite3.a: Removed.

1:29 PM Changeset in webkit [156113] by dbates@webkit.org

1 edit in trunk/Source/JavaScriptCore/ChangeLog

[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()

Rubber-stamped by Joseph Pecoraro.

Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.

jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_mod):

1:27 PM Changeset in webkit [156112] by dbates@webkit.org

2 edits in trunk/Source/JavaScriptCore

[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()

Rubber-stamped by Joseph Pecoraro.

jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_mod):

1:07 PM Changeset in webkit [156111] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
https://bugs.webkit.org/show_bug.cgi?id=121625

Rubber-stamped by Filip Pizlo.

Chenged 16, 32 and 64 bit offsets to be signed. Kept the original tab indented
spacing to match the rest of the file.

disassembler/udis86/udis86_syn-att.c:

(gen_operand):

12:54 PM Changeset in webkit [156110] by akling@apple.com

8 edits
1 add in trunk/Source/WebCore

Add SVGPropertyInfo.cpp
<https://webkit.org/b/121622>

Reviewed by Anders Carlsson.

Add a cpp file for this class to make it more hackable.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
svg/properties/SVGPropertyInfo.cpp: Added.

(WebCore::SVGPropertyInfo::SVGPropertyInfo):

svg/properties/SVGPropertyInfo.h:

12:22 PM Changeset in webkit [156109] by ap@apple.com

2 edits in trunk/Tools

REGRESSION (r129451): run-safari --no-saved-state is broken
https://bugs.webkit.org/show_bug.cgi?id=121566

Undo a last minute change that doesn't actually work.

Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed

via command line, <rdar://problem/15032886>.

12:06 PM Changeset in webkit [156108] by eric.carlson@apple.com

13 edits
1 add in trunk

MediaStream API: update NavigatorUserMediaError object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121584

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, updated getusermedia.html.

CMakeLists.txt: Add NavigatorUserMediaError.cpp.
GNUmakefile.list.am: Ditto.

Modules/mediastream/NavigatorUserMediaError.cpp: Added.
Modules/mediastream/NavigatorUserMediaError.h: Derive from DOMError, get rid of "message" attribute.
Modules/mediastream/NavigatorUserMediaError.idl: Ditto.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create): ASCIILiteral -> AtomicString. Rename constraint parameters.
(WebCore::UserMediaRequest::UserMediaRequest): Rename constraint parameters.
(WebCore::UserMediaRequest::audioConstraints): Return PassRefPtr<> instead of raw ptr.
(WebCore::UserMediaRequest::videoConstraints): Ditto.
(WebCore::UserMediaRequest::ownerDocument): Clean up style.
(WebCore::UserMediaRequest::succeed):
(WebCore::UserMediaRequest::permissionFailure): Renamed from fail.
(WebCore::UserMediaRequest::constraintFailure): Renamed from failConstraint.
(WebCore::UserMediaRequest::callSuccessHandler): New.
(WebCore::UserMediaRequest::callErrorHandler): New.

Modules/mediastream/UserMediaRequest.h:

WebCore.xcodeproj/project.pbxproj: Add NavigatorUserMediaError.cpp

dom/DOMError.h: Make constructor protected.

platform/mediastream/MediaStreamSourcesQueryClient.h: Make constraints available.

LayoutTests:

fast/mediastream/getusermedia-expected.txt:
fast/mediastream/getusermedia.html:

11:49 AM Changeset in webkit [156107] by zoltan@webkit.org

8 edits in trunk/LayoutTests

[CSS Shapes] Fix starting html tag and doctype for shape-inside floats tests
https://bugs.webkit.org/show_bug.cgi?id=121621

Reviewed by Andreas Kling.

fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html:
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html:
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html:
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html:
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html:
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html:
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html:

11:18 AM Changeset in webkit [156106] by Bem Jones-Bey

8 edits
4 adds in trunk

Fix handling of top margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121614

Reviewed by Alexandru Chiculita.

Source/WebCore:

When a float has shape outside, the top margin should be treated as if
there is no shape there, so inline content should be allowed to flow
into that space. This patch fixes two issues:

1) If the top margin is the same as the line height, a line should be
able to fit into the margin. Before this patch, that line was being
treated as if it intersected with the shape.

2) The shape should be positioned (x, y) relative to the box sizing
box of the float. While the x coordinate was being treated properly,
the y coordinate was relative to the top of the margin box. This patch
fixes this behavior.

This patch also includes a simple test for right and left margins, as
I wrote that test and then discovered the problems listed above.

This patch also removes an unused override of the
lineOverlapsShapeBounds method.

Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html

csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html

rendering/FloatingObjects.cpp:

(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

rendering/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

rendering/shapes/ShapeInfo.h:
rendering/shapes/ShapeInsideInfo.h:
rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):

rendering/shapes/ShapeOutsideInfo.h:

LayoutTests:

csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Added.
csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Added.

Test for a positive left/right margin.

csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Added.
csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Added.

Test for a positive top margin.

11:13 AM Changeset in webkit [156105] by mitz@apple.com

5 edits in trunk

Add a style guideline regarding spacing in range-based for loops
https://bugs.webkit.org/show_bug.cgi?id=121620

Reviewed by Anders Carlsson.

Tools:

Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing): Added checking that there are spaces around the colon in a range-based for
loop.
(CppChecker): Added whitespace/colon to the categories set.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_spacing): Added two tests for the new check.

Websites/webkit.org:

coding/coding-style.html: Added the guideline that spaces should be placed

around the colon in a range-based for loop.

10:57 AM Changeset in webkit [156104] by rniwa@webkit.org

3 edits in trunk/PerformanceTests

DoYouEvenBench: Indentations in benchmark.js and benchmark.html are all messed up
https://bugs.webkit.org/show_bug.cgi?id=121597

Reviewed by Anders Carlsson.

Fixed indentations.

DoYouEvenBench/benchmark.html:
DoYouEvenBench/benchmark.js:

(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._finalize):

10:57 AM Changeset in webkit [156103] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add XHR tests checking readyState transition when abort() is invoked in various states
https://bugs.webkit.org/show_bug.cgi?id=121585

Reviewed by Alexey Proskuryakov.

Merge https://chromium.googlesource.com/chromium/blink/+/2d854757576db590745cfb78e11ca428a1aac342

http/tests/xmlhttprequest/readystatechange-and-abort-expected.txt: Added.
http/tests/xmlhttprequest/readystatechange-and-abort.html: Added.

10:52 AM Changeset in webkit [156102] by Antti Koivisto

26 edits
2 adds in trunk/Source/WebCore

Add RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121608

Reviewed by Dave Hyatt.

Add a common base class for all Element renderers. The class hierarchy will now look like this

RenderObject

RenderText
RenderElement

RenderLayerModelObject

...

RenderSVGModelObject

...

RenderSVGGradientStop

This will allow tighter typing in both render and DOM trees.

The patch also moves renderer factory function to RenderElement::createFor().

10:36 AM Changeset in webkit [156101] by allan.jensen@digia.com

2 edits in trunk/Source/WebKit/qt

Keep chasing the definition of QAccessibleWidget
https://bugs.webkit.org/show_bug.cgi?id=121611

Reviewed by Jocelyn Turcotte.

WidgetApi/qwebviewaccessible_p.h:

9:06 AM Changeset in webkit [156100] by weinig@apple.com

12 edits in trunk/Tools

Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
https://bugs.webkit.org/show_bug.cgi?id=121588

Reviewed by Anders Carlsson.

DumpRenderTree/TestRunner.cpp:
ImageDiff/efl/ImageDiff.cpp:
TestWebKitAPI/JavaScriptTest.cpp:
TestWebKitAPI/PlatformUtilities.cpp:
TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/StringFunctions.h:
WebKitTestRunner/TestInvocation.cpp:
WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

9:00 AM Changeset in webkit [156099] by ap@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r149928): CanvasStyle::operator= leaks everything
https://bugs.webkit.org/show_bug.cgi?id=121591

Reviewed by Andreas Kling.

html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::operator=): Don't leak.

8:11 AM Changeset in webkit [156098] by Manuel Rego Casasnovas

3 edits in trunk/LayoutTests

Unreviewed. Fix typo in layout test description introduced in r155974.

fast/regions/selection-direction-expected.html:
fast/regions/selection-direction.html:

7:41 AM Changeset in webkit [156097] by commit-queue@webkit.org

4 edits
2 copies in trunk

[CSS Masking/Background] Position property should be ignored when using repeat: space
https://bugs.webkit.org/show_bug.cgi?id=120623

Source/WebCore:

The background/mask-position should be ignored when using repeat: space,
unless there is not enough space for two copies of the image. In that case,
only one image is placed and background/mask-position determines its position.

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.

Test: css3/masking/mask-repeat-one-copy.html

rendering/RenderBoxModelObject.cpp: Ignored position property if space value is positive, set no-repeat otherwise.

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.

css3/masking/mask-repeat-one-copy-expected.html:
css3/masking/mask-repeat-one-copy.html: Only one copy of the mask should be drawn, and background position should determine its position.
css3/masking/mask-repeat-space-padding.html: Added a mask-position which should be ignored.

7:39 AM Changeset in webkit [156096] by Michał Pakuła vel Rutka

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip tests added to platform/efl/Skipped, which now are passing.

platform/efl/TestExpectations:

6:51 AM Changeset in webkit [156095] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: EllipsisBox::renderer() should return RenderBlock&.
<https://webkit.org/b/121604>

Reviewed by Antti Koivisto.

I missed adding a renderer() overload when fixing up EllipsisBox.
Flushed out one unnecessary type check.

6:48 AM Changeset in webkit [156094] by akling@apple.com

13 edits in trunk/Source/WebCore

CTTE: Tighten renderer types for InlineTextBox and SVGInlineTextBox.
<https://webkit.org/b/121605>

Reviewed by Antti Koivisto.

Codify the following:

InlineTextBox always has a RenderText.
SVGInlineTextBox always has a RenderSVGInlineText.

Removed InlineTextBox::textRenderer() and make renderer() simply
return a RenderText&/RenderSVGInlineText& instead.

This turns some node() accessors into textNode() and removes a host
of casts and assertions.

6:36 AM Changeset in webkit [156093] by Antti Koivisto

5 edits in trunk/Source/WebCore

[CTTE] Hide nonPseudoNode and generatingNode, replace with Element versions
https://bugs.webkit.org/show_bug.cgi?id=121606

Reviewed by Andreas Kling.

5:33 AM Changeset in webkit [156092] by akling@apple.com

5 edits in trunk/Source/WebCore

CTTE: Tighten renderer types for InlineFlowBox and SVGInlineFlowBox.
<https://webkit.org/b/121603>

Reviewed by Antti Koivisto.

Codify the following:

InlineFlowBox always has a RenderBoxModelObject.
SVGInlineFlowBox always has a RenderSVGInline.

This turns some node() accessors into element(). Neato!

4:03 AM Changeset in webkit [156091] by commit-queue@webkit.org

5 edits
4 adds in trunk

CSS Unit vmax and vmin in border-width not handled.
https://bugs.webkit.org/show_bug.cgi?id=121421

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-19
Reviewed by Darin Adler.

Source/WebCore:

Border properties were not applied incase its values
were given in vmax/vmin units.

Tests: fast/css/viewport-vmax-border.html

fast/css/viewport-vmin-border.html

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isViewportPercentageMax):
(WebCore::CSSPrimitiveValue::isViewportPercentageMin):

css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):
Calculating the border values which has been specified in
vmax/vmin units. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest. The vh/vw units are
calcultated as percent of viewport height and viewport width respectively.

LayoutTests:

fast/css/viewport-vmax-border-expected.txt: Added.
fast/css/viewport-vmax-border.html: Added.
fast/css/viewport-vmin-border-expected.txt: Added.
fast/css/viewport-vmin-border.html: Added.

Added new tests for verifying that border properties are
applied when its values are given in vmax/vmin units.

3:37 AM Changeset in webkit [156090] by Antti Koivisto

22 edits in trunk

[CTTE] RenderText is always anonymous or associated with Text node
https://bugs.webkit.org/show_bug.cgi?id=121596

Source/WebCore:

Reviewed by Andreas Kling.

Tighten the node type of RenderText and its subclasses to Text.
Switch to createAnonymous pattern.
Switch a bunch of unnecessary StringImpl* use to Strings.

LayoutTests:

Reviewed by Andreas Kling.

Update some MathML render tree dumps. RenderTexts for these are now anonymous.

platform/mac/mathml/presentation/mo-expected.txt:
platform/mac/mathml/presentation/row-expected.txt:

1:42 AM Changeset in webkit [156089] by zarvai@inf.u-szeged.hu

4 edits
10 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase after r155957 and 155998.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-19

platform/qt-wk1/compositing/contents-scale/animating-expected.txt: Added r155998.
platform/qt-wk1/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
platform/qt-wk1/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
platform/qt-wk1/compositing/contents-scale/z-translate-expected.txt: Added r155998.
platform/qt-wk2/compositing/contents-scale/animating-expected.txt: Added r155998.
platform/qt-wk2/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
platform/qt-wk2/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
platform/qt-wk2/compositing/contents-scale/z-translate-expected.txt: Added r155998.
platform/qt/css3/selectors3/html/css3-modsel-179a-expected.txt: Rebase after r155957.
platform/qt/css3/selectors3/xhtml/css3-modsel-179a-expected.txt: Rebase after r155957.
platform/qt/css3/selectors3/xml/css3-modsel-179a-expected.txt: Rebase after r155957.

1:07 AM Changeset in webkit [156088] by rniwa@webkit.org

2 edits
31 adds in trunk/PerformanceTests

Add an AngularJS test to DoYouEvenBench
https://bugs.webkit.org/show_bug.cgi?id=121595

Reviewed by Antti Koivisto.

DoYouEvenBench/benchmark.html:
DoYouEvenBench/todomvc/architecture-examples/angularjs: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower.json: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/index.html: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/app.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/readme.md: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/test: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/test/package.json: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/test/readme.md: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Added.
DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Added.

12:54 AM Changeset in webkit [156087] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding failure expectations for failing HiDPI and a11y tests.

12:07 AM Changeset in webkit [156086] by mihnea@adobe.com

2 edits in trunk/Source/WebCore

Unreviewed build fix after 156082. Guard SVG code with defines.

12:07 AM Changeset in webkit [156085] by dbates@webkit.org

2 edits in trunk/Source/JavaScriptCore

Remove names of unused arguments from the x86/x86-64 function prototype
for JIT::emitSlow_op_mod()

Rubber-stamped by Ryosuke Niwa.

jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_mod):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed