Timeline

Sep 21, 2013:

10:00 PM Changeset in webkit [156242] by fpizlo@apple.com

• 15 edits in trunk/Source/JavaScriptCore

Interpreter::unwind() has no need for the bytecodeOffset
​https://bugs.webkit.org/show_bug.cgi?id=121755

Reviewed by Oliver Hunt.

It was only using the bytecodeOffset for some debugger stuff, but the debugger could
just get the bytecodeOffset the same way the rest of the machinery does: by using the
CallFrame's location.

It turns out that a lot of really ugly code was in place just to supply this
bytecodeOffset. This patch kills most of that code, and allows us to kill even more
code in a future patch - though most likely that killage will involve further
refactorings as well, see ​https://bugs.webkit.org/show_bug.cgi?id=121734.

• dfg/DFGOperations.cpp:
• interpreter/CallFrame.cpp:

(JSC::CallFrame::bytecodeOffset):
(JSC::CallFrame::codeOrigin):

• interpreter/CallFrame.h:
• interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):

• interpreter/Interpreter.h:
• jit/JITExceptions.cpp:

(JSC::genericUnwind):

• jit/JITExceptions.h:
• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::cti_vm_handle_exception):

• llint/LLIntExceptions.cpp:

(JSC::LLInt::doThrow):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

• llint/LLIntExceptions.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPathsExceptions.cpp:

(JSC::CommonSlowPaths::interpreterThrowInCaller):

• runtime/CommonSlowPathsExceptions.h:

9:15 PM Changeset in webkit [156241] by weinig@apple.com

• 202 edits in trunk/Source/WebCore

Event and EventTarget interfaces don't need to be store as AtomicStrings
​https://bugs.webkit.org/show_bug.cgi?id=121751

Reviewed by Andreas Kling.

Convert the Event and EventTarget interface identifiers from AtomicStrings to enums. They
are not extensible and not exposed as Strings anywhere.

• Files elided *

9:02 PM Changeset in webkit [156240] by Darin Adler

• 46 edits in trunk/Source

Add ExecState::uncheckedArgument and use where possible to shrink a bit
​https://bugs.webkit.org/show_bug.cgi?id=121750

Reviewed by Andreas Kling.

Source/JavaScriptCore:

• interpreter/CallFrame.h:

(JSC::ExecState::uncheckedArgument): Added. Like argument, but with an
assertion rather than a runtime check.

• API/APICallbackFunction.h:

(JSC::APICallbackFunction::call): Use uncheckedArgument because we are
already in a loop over arguments, so don't need a range check.

• API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback): Ditto.

• API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject::construct): Ditto.
(JSC::JSCallbackObject::call): Ditto.

• jsc.cpp:

(functionPrint): Ditto.
(functionRun): Ditto.
(functionSetSamplingFlags): Ditto.
(functionClearSamplingFlags): Ditto.

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncConcat): Ditto.
(JSC::arrayProtoFuncPush): Use uncheckedArgument because there is already
code that explicitly checks argumentCount.
(JSC::arrayProtoFuncSplice): Ditto.
(JSC::arrayProtoFuncUnShift): Ditto.
(JSC::arrayProtoFuncReduce): Ditto.
(JSC::arrayProtoFuncReduceRight): Ditto.
(JSC::arrayProtoFuncLastIndexOf): Ditto.

• runtime/DatePrototype.cpp:

(JSC::fillStructuresUsingTimeArgs): Ditto.
(JSC::fillStructuresUsingDateArgs): Ditto.

• runtime/JSArrayBufferConstructor.cpp:

(JSC::constructArrayBuffer): Ditto.

• runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoFuncSlice): Ditto.

• runtime/JSBoundFunction.cpp:

(JSC::boundFunctionCall): Ditto.
(JSC::boundFunctionConstruct): Ditto.

• runtime/JSDataViewPrototype.cpp:

(JSC::getData): Ditto.
(JSC::setData): Ditto.

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayView): Ditto.

• runtime/JSGenericTypedArrayViewPrototypeInlines.h:

(JSC::genericTypedArrayViewProtoFuncSet): Ditto.
(JSC::genericTypedArrayViewProtoFuncSubarray): Ditto.

• runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse): Ditto.
(JSC::JSONProtoFuncStringify): Ditto.

• runtime/JSPromiseConstructor.cpp:

(JSC::constructPromise): Ditto.
(JSC::JSPromiseConstructorFuncFulfill): Ditto.
(JSC::JSPromiseConstructorFuncResolve): Ditto.
(JSC::JSPromiseConstructorFuncReject): Ditto.

• runtime/MathObject.cpp:

(JSC::mathProtoFuncMax): Ditto.
(JSC::mathProtoFuncMin): Ditto.

• runtime/NameConstructor.cpp:

(JSC::constructPrivateName): Removed unneeded check of argumentCout
that simply repeats what argument already does.

• runtime/NativeErrorConstructor.cpp:

(JSC::Interpreter::constructWithNativeErrorConstructor): Ditto.
(JSC::Interpreter::callNativeErrorConstructor): Ditto.

• runtime/NumberConstructor.cpp:

(JSC::constructWithNumberConstructor): Use uncheckedArgument since
there is already code that explicitly checks argument count.
(JSC::callNumberConstructor): Ditto.

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorCreate): Small refactoring to not call argument(0)
three times.

• runtime/SetConstructor.cpp:

(JSC::constructSet): Use uncheckedArgument since we are already in a loop
over arguments.

• runtime/StringConstructor.cpp:

(JSC::stringFromCharCodeSlowCase): In a loop.
(JSC::stringFromCharCode): Already checked count.
(JSC::constructWithStringConstructor): Ditto.
(JSC::callStringConstructor): Ditto.

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncConcat): Already checked count.

• runtime/TestRunnerUtils.cpp:

(JSC::numberOfDFGCompiles): Ditto.
(JSC::setNeverInline): Ditto.

Source/WebCore:

• bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::probablySupportsContext): Already checked count.
(WebCore::JSHTMLCanvasElement::toDataURL): Ditto.

• bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::documentWrite): In a loop.

• bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::inspectedObject): Already checked count.
(WebCore::JSInjectedScriptHost::internalConstructorName): Ditto.
(WebCore::JSInjectedScriptHost::isHTMLAllCollection): Ditto.
(WebCore::JSInjectedScriptHost::type): Ditto.
(WebCore::JSInjectedScriptHost::functionDetails): Ditto.
(WebCore::JSInjectedScriptHost::getEventListeners): Ditto.
(WebCore::JSInjectedScriptHost::inspect): Ditto.
(WebCore::JSInjectedScriptHost::databaseId): Ditto.
(WebCore::JSInjectedScriptHost::storageId): Ditto.

• bindings/js/JSSQLTransactionSyncCustom.cpp:

(WebCore::JSSQLTransactionSync::executeSql): Ditto.

• bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits): Ditto.

• bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Ditto.

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::getObjectParameter): Already checked count.
(WebCore::JSWebGLRenderingContext::getAttachedShaders): Removed tortured code
to triply do the checking that the toWebGLProgram function already does, including
spurious exception checking in code that can't create an exception. Also count is
already checked.
(WebCore::JSWebGLRenderingContext::getExtension): More of the same.
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getProgramParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getShaderParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getUniform): Ditto.
(WebCore::dataFunctionf): Ditto.
(WebCore::dataFunctioni): Ditto.
(WebCore::dataFunctionMatrix): Ditto.

• bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::importScripts): In a loop.

• bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open): Already checked. Also removed some unneeded
argument count checks.
(WebCore::JSXMLHttpRequest::send): Removed unneeded special case for 0 argument
count that does the same thing as the undefined case, since asking for an
argument past the count yields undefined.

• bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter): Already checked.
(WebCore::JSXSLTProcessor::getParameter): Already checked.
(WebCore::JSXSLTProcessor::removeParameter): Already checked.

• bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction): In a loop.

• bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptArguments): Ditto.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck): Removed some excess argumentCount checks.
Used uncheckedArgument in a few places. More needs to be done, especially for
overloaded functions.

• bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::invokeMethod): In a loop.
(JSC::Bindings::CInstance::invokeDefaultMethod): Ditto.

• bridge/objc/objc_instance.mm:

(ObjcInstance::invokeObjcMethod): Ditto.
(ObjcInstance::invokeDefaultMethod): Ditto.

• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:

Updated.

Source/WebKit2:

• WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::callMethod): In a loop.
(WebKit::JSNPObject::callObject): Ditto.
(WebKit::JSNPObject::callConstructor): Ditto.

8:48 PM Changeset in webkit [156239] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Remove the notion that a CallFrame can have a pointer to an InlineCallFrame, since that doesn't happen anymore
​https://bugs.webkit.org/show_bug.cgi?id=121753

Reviewed by Darin Adler.

• interpreter/CallFrame.cpp:

(JSC::CallFrame::bytecodeOffsetFromCodeOriginIndex):

• interpreter/CallFrame.h:
• interpreter/Register.h:

5:31 PM Changeset in webkit [156238] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix the revert.

• dfg/DFGRepatch.cpp:

5:24 PM Changeset in webkit [156237] by fpizlo@apple.com

• 29 edits
  4 adds
  7 deletes in trunk/Source/JavaScriptCore

Unreviewed, revert ​http://trac.webkit.org/changeset/156235. It won't work on Windows.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):

• bytecode/StructureStubInfo.h:
• dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):

• dfg/DFGJITCompiler.h:
• dfg/DFGOSRExitCompiler.h:
• dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

• dfg/DFGOperations.h:

(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):

• dfg/DFGRegisterSet.h: Added.

(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):

• dfg/DFGRepatch.cpp: Added.

(JSC::DFG::repatchCall):
(JSC::DFG::repatchByIdSelfAccess):
(JSC::DFG::addStructureTransitionCheck):
(JSC::DFG::replaceWithJump):
(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::repatchGetByID):
(JSC::DFG::getPolymorphicStructureList):
(JSC::DFG::patchJumpToGetByIdStub):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::buildGetByIDList):
(JSC::DFG::appropriateGenericPutByIdFunction):
(JSC::DFG::appropriateListBuildingPutByIdFunction):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::repatchPutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::buildPutByIdList):
(JSC::DFG::tryRepatchIn):
(JSC::DFG::repatchIn):
(JSC::DFG::linkSlowFor):
(JSC::DFG::linkFor):
(JSC::DFG::linkClosureCall):
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):

• dfg/DFGRepatch.h: Added.

(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):

• dfg/DFGScratchRegisterAllocator.h: Added.

(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGThunks.cpp:

(JSC::DFG::emitPointerValidation):
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::linkForThunkGenerator):
(JSC::DFG::linkCallThunkGenerator):
(JSC::DFG::linkConstructThunkGenerator):
(JSC::DFG::linkClosureCallThunkGenerator):
(JSC::DFG::virtualForThunkGenerator):
(JSC::DFG::virtualCallThunkGenerator):
(JSC::DFG::virtualConstructThunkGenerator):

• dfg/DFGThunks.h:
• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):

• ftl/FTLOSRExitCompiler.h:
• jit/AssemblyHelpers.h:
• jit/JIT.cpp:

(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):

• jit/JITCall.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):

• jit/JITOperationWrappers.h: Removed.
• jit/JITOperations.cpp: Removed.
• jit/JITOperations.h: Removed.
• jit/RegisterSet.h: Removed.
• jit/Repatch.cpp: Removed.
• jit/Repatch.h: Removed.
• jit/ScratchRegisterAllocator.h: Removed.
• jit/ThunkGenerators.cpp:

(JSC::generateSlowCaseFor):
(JSC::linkForGenerator):
(JSC::linkCallGenerator):
(JSC::linkConstructGenerator):
(JSC::linkClosureCallGenerator):
(JSC::virtualForGenerator):
(JSC::virtualCallGenerator):
(JSC::virtualConstructGenerator):

• jit/ThunkGenerators.h:

5:11 PM Changeset in webkit [156236] by jonlee@apple.com

• 2 edits in trunk/Source/WebCore

Fix Obj-C bindings test expectations.
Unreviewed.

Bindings tests failed with r156232, from ​https://bugs.webkit.org/show_bug.cgi?id=121745.

• bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj reflectedStringAttr]): Update test expectations.

4:10 PM Changeset in webkit [156235] by fpizlo@apple.com

• 29 edits
  7 adds
  4 deletes in trunk/Source/JavaScriptCore

Move DFG inline caching logic into jit/
​https://bugs.webkit.org/show_bug.cgi?id=121749

Rubber stamped by Sam Weinig.

We want to get rid of the baseline JIT's inline caching machinery and have it use the
DFG's instead. But before we do that we need to move the DFG's inline caching machine
out from behind its ENABLE(DFG_JIT) guards and make it available to the whole system.
This patch does that:

• dfg/DFGRepatch becomes jit/Repatch.

• The thunks used by the DFG IC go into jit/ThunkGenerators, instead of dfg/DFGThunks.

• The operations used by the DFG IC go into jit/JITOperations, instead of dfg/DFGOperations.

• The old JIT's thunk generators for calls are renamed to reduce confusion. Previously it was easy to know which generators belong to which JIT because the old JIT used JSC::virtualCallBlah and the DFG used JSC::DFG::virtualCallBlah, but that's not the case anymore. Note that the old JIT's thunk generators will die in a future patch.

No functional changes beyond those moves.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):

• bytecode/StructureStubInfo.h:
• dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):

• dfg/DFGJITCompiler.h:
• dfg/DFGOSRExitCompiler.h:
• dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

• dfg/DFGOperations.h:

(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):

• dfg/DFGRegisterSet.h: Removed.
• dfg/DFGRepatch.cpp: Removed.
• dfg/DFGRepatch.h: Removed.
• dfg/DFGScratchRegisterAllocator.h: Removed.
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGThunks.cpp:
• dfg/DFGThunks.h:
• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::writeBarrier):

• jit/JIT.cpp:

(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):

• jit/JITCall.cpp:

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):

• jit/JITOperationWrappers.h: Added.
• jit/JITOperations.cpp: Added.
• jit/JITOperations.h: Added.
• jit/RegisterSet.h: Added.

(JSC::RegisterSet::RegisterSet):
(JSC::RegisterSet::asPOD):
(JSC::RegisterSet::copyInfo):
(JSC::RegisterSet::set):
(JSC::RegisterSet::setGPRByIndex):
(JSC::RegisterSet::clear):
(JSC::RegisterSet::get):
(JSC::RegisterSet::getGPRByIndex):
(JSC::RegisterSet::getFreeGPR):
(JSC::RegisterSet::setFPRByIndex):
(JSC::RegisterSet::getFPRByIndex):
(JSC::RegisterSet::setByIndex):
(JSC::RegisterSet::getByIndex):
(JSC::RegisterSet::numberOfSetGPRs):
(JSC::RegisterSet::numberOfSetFPRs):
(JSC::RegisterSet::numberOfSetRegisters):
(JSC::RegisterSet::setBit):
(JSC::RegisterSet::clearBit):
(JSC::RegisterSet::getBit):

• jit/Repatch.cpp: Added.

(JSC::repatchCall):
(JSC::repatchByIdSelfAccess):
(JSC::addStructureTransitionCheck):
(JSC::replaceWithJump):
(JSC::emitRestoreScratch):
(JSC::linkRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::getPolymorphicStructureList):
(JSC::patchJumpToGetByIdStub):
(JSC::tryBuildGetByIDList):
(JSC::buildGetByIDList):
(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryBuildPutByIdList):
(JSC::buildPutByIdList):
(JSC::tryRepatchIn):
(JSC::repatchIn):
(JSC::linkSlowFor):
(JSC::linkFor):
(JSC::linkClosureCall):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):

• jit/Repatch.h: Added.

(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):

• jit/ScratchRegisterAllocator.h: Added.

(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::ScratchRegisterAllocator::lock):
(JSC::ScratchRegisterAllocator::allocateScratch):
(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::didReuseRegisters):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):

• jit/ThunkGenerators.cpp:

(JSC::oldStyleGenerateSlowCaseFor):
(JSC::oldStyleLinkForGenerator):
(JSC::oldStyleLinkCallGenerator):
(JSC::oldStyleLinkConstructGenerator):
(JSC::oldStyleLinkClosureCallGenerator):
(JSC::oldStyleVirtualForGenerator):
(JSC::oldStyleVirtualCallGenerator):
(JSC::oldStyleVirtualConstructGenerator):
(JSC::emitPointerValidation):
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::linkForThunkGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkConstructThunkGenerator):
(JSC::linkClosureCallThunkGenerator):
(JSC::virtualForThunkGenerator):
(JSC::virtualCallThunkGenerator):
(JSC::virtualConstructThunkGenerator):

• jit/ThunkGenerators.h:

1:02 PM Changeset in webkit [156234] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Node: FINAL-ize EventTarget overrides.
<​https://webkit.org/b/121748>

Reviewed by Darin Adler.

Mark the following Node functions FINAL:

• scriptExecutionContext()
• eventTargetData()
• ensureEventTargetData()

This devirtualizes a myriad of generated calls in the JSC bindings.

12:05 PM Changeset in webkit [156233] by andersca@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Fix the non-DFG build.

• interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::r):

11:46 AM Changeset in webkit [156232] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Don't bloat Obj-C bindings with inlined attribute retrieval.
<​https://webkit.org/b/121745>

Reviewed by Anders Carlsson.

Hack bindings generator to always use getAttribute() for Objective-C.
Reduces WebCore binary size by 25120 bytes.

11:25 AM Changeset in webkit [156231] by Darin Adler

• 38 edits
  2 deletes in trunk/Source/WebCore

Shink attribute event listener code
​https://bugs.webkit.org/show_bug.cgi?id=121735

Reviewed by Antti Koivisto.

• GNUmakefile.list.am: Eliminate ScriptEventListener source files.
• Target.pri: Ditto.
• UseJSC.cmake: Ditto.
• WebCore.vcxproj/WebCore.vcxproj: Ditto.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• bindings/js/JSBindingsAllInOne.cpp: Ditto.

• bindings/js/JSDOMGlobalObject.h: Removed unneeded forward declarations

of JSEventListener and JSLazyEventListener.

• bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::JSLazyEventListener): Changed type to
ContainerNode because the node pointer is only ever used for elements
and documents.
(WebCore::eventParameterName): Moved this function here from
ScriptEventListener.cpp, but also rewrote to use NeverDestroyed.
(WebCore::JSLazyEventListener::createForNode): Moved this function
here from ScriptEventListener.cpp, cleaned up a bit.
(WebCore::JSLazyEventListener::createForDOMWindow): Ditto.

• bindings/js/JSLazyEventListener.h: Replaced the old create function

with two new create functions we can use directly. Also used some
OVERRIDE, some FINAL, and a bit of WTF_DELETED_FUNCTION so we don't
accidentally call create and create a non-lazy listener.

• bindings/js/ScriptEventListener.cpp: Removed.
• bindings/js/ScriptEventListener.h: Removed.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::setAttributeEventListener): Added.
Calls JSLazyEventListener::createForNode and then calls the other
overload of setAttributeEventListener, to obviate having more code
at the call site.

• dom/ContainerNode.h: Added overload of setAttributeEventListener

for convenient use in Document and Element implementations.

• dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Use m_domWindow instead
of the domWindow() function.
(WebCore::Document::removeAllEventListeners): Ditto.
(WebCore::Document::errorEventTarget): Ditto.
(WebCore::Document::takeDOMWindowFrom): Ditto.
(WebCore::Document::setWindowAttributeEventListener): Ditto. Also
added an overload that calls JSLazyEventListener::createForDOMWindow.
(WebCore::Document::getWindowAttributeEventListener): Use m_domWindow.
(WebCore::Document::dispatchWindowEvent): Ditto.
(WebCore::Document::dispatchWindowLoadEvent): Ditto.
(WebCore::Document::enqueueWindowEvent): Ditto.
(WebCore::Document::enqueuePopstateEvent): Ditto.

• dom/Document.h: Added overload of setWindowAttributeEventListener.

• html/HTMLBodyElement.cpp: Removed unnneded include.

(WebCore::HTMLBodyElement::parseAttribute): Removed all the calls to
createAttributeEventListener, and use the setAttributeEventListener
overloads instead.

• html/HTMLButtonElement.cpp: Ditto.
• html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute): Ditto.

• html/HTMLFormControlElement.cpp: Ditto.
• html/HTMLFormElement.cpp: Ditto.
• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute): Ditto.

• html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseAttribute): Ditto.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Ditto.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute): Ditto.

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute): Ditto.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Ditto.

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseAttribute): Ditto.

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseAttribute): Ditto.

• html/HTMLSelectElement.cpp: Ditto.
• html/HTMLStyleElement.cpp: Ditto.
• html/HTMLTextFormControlElement.cpp: Ditto.
• html/HTMLTrackElement.cpp: Ditto.
• html/track/LoadableTextTrack.cpp: Ditto.
• svg/SVGElement.cpp:

(WebCore::SVGElement::parseAttribute): Ditto.

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseAttribute): Ditto.

• svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::parseAttribute): Ditto.

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):
Moved the code here to dig inside a JSEventListener for things like
the source location. This used to be spread across multiple function
calls in ScriptEventListener.h, which were doing and redoing the same
things, so better to just get it all at once.

• html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init): Fixed "minium" typo.

10:47 AM Changeset in webkit [156230] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

Don't store the "processing-instruction" string for PI tokens in the XPath parser
​https://bugs.webkit.org/show_bug.cgi?id=121746

Reviewed by Antti Koivisto.

For PI tokens, the string is always going to be "processing-instruction", and it's never used so we don't need to save it.

• xml/XPathGrammar.y:
• xml/XPathParser.cpp:

(Parser::nextTokenInternal):
(Parser::lex):

10:40 AM Changeset in webkit [156229] by fpizlo@apple.com

• 8 edits
  3 adds in trunk

Get rid of IsInlinedCodeTag and its associated methods since it's unused
​https://bugs.webkit.org/show_bug.cgi?id=121737

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This was meant to be easy, but I kept wondering if it was safe to remove the
inline call frame check in Arguments::tearOff(). The check was clearly dead
since the bit wasn't being set anywhere.

It turns out that the unwindCallFrame() function was relying on tearOff()
doing the right thing for inlined code, but it wasn't even passing it an
inline call frame. I fixed this by having unwindCallFrame() inlining check,
while also making sure that the code uses the right operand index for the
arguments register.

• interpreter/CallFrame.h:
• interpreter/CallFrameInlines.h:
• interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::r):

• interpreter/StackVisitor.h:
• runtime/Arguments.cpp:

(JSC::Arguments::tearOff):

LayoutTests:

Reviewed by Sam Weinig.

• js/dfg-inline-arguments-capture-throw-exception-expected.txt: Added.
• js/dfg-inline-arguments-capture-throw-exception.html: Added.
• js/script-tests/dfg-inline-arguments-capture-throw-exception.js: Added.

(foo):
(bar):
(makeF):
(recurse):

6:45 AM Changeset in webkit [156228] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Handle windows lineendings in makeprop.pl after r155511
​https://bugs.webkit.org/show_bug.cgi?id=121740

Reviewed by Ryosuke Niwa.

Check for an optinal \r at the end of a line in regular expressions
to make it work again on native windows machines which use CRLF.

• css/makeprop.pl:

6:05 AM Changeset in webkit [156227] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Re-inline some hot ElementData functions.
<​https://webkit.org/b/121743>

Reviewed by Antti Koivisto.

Make the following functions inline again:

• deref()
• addAttribute()
• removeAttribute()
• attributeAt()

They were out-of-lined in r154249 and perf.webkit.org reports a 1.4%
regression on the html5 spec for that revision. This'll hopefully steer
the graph back in the right direction.

3:52 AM Changeset in webkit [156226] by timothy_horton@apple.com

• 13 edits
  2 moves in trunk/Source/WebCore

GeneratorGeneratedImage should be called GradientImage
​https://bugs.webkit.org/show_bug.cgi?id=121085

Reviewed by Simon Fraser.

No new tests, just a refactor.

r150053 removed the concept of a Generator, making GeneratorGeneratedImage
take a Gradient. This leaves GeneratorGeneratedImage's name not making a
whole lot of sense, so let's rename it to GradientImage.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):

• platform/graphics/BitmapImage.h:
• platform/graphics/GradientImage.cpp: Renamed from Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp.

(WebCore::GradientImage::draw):
(WebCore::GradientImage::drawPattern):

• platform/graphics/GradientImage.h: Renamed from Source/WebCore/platform/graphics/GeneratorGeneratedImage.h.
• platform/graphics/Image.h:
• platform/graphics/ImageBuffer.h:

Rename.

• css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::cachedImageForSize):
(WebCore::CSSImageGeneratorValue::saveCachedImageForSize):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):

• css/CSSImageGeneratorValue.h:

(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::image):
Drive-by, the CSSImageGeneratorValue generated image cache should be
in terms of GeneratedImage, not a random subclass, regardless
of the fact that it's only used for GradientImage as of yet.

1:03 AM Changeset in webkit [156225] by Darin Adler

• 2 edits in trunk/Source/WebCore

Shrink valueForBasicShape by removing repeated calls to cssValuePool()
​https://bugs.webkit.org/show_bug.cgi?id=121736

Reviewed by Sam Weinig.

• css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape): Put the pool into a local variable and use that.

Sep 20, 2013:

10:35 PM Changeset in webkit [156224] by Darin Adler

• 2 edits in trunk/Source/WebCore

Another CSS parser leak fix
​https://bugs.webkit.org/show_bug.cgi?id=121730

Reviewed by Alexey Proskuryakov.

• css/CSSGrammar.y.in: Added a missing adoptPtr.

10:35 PM Changeset in webkit [156223] by ap@apple.com

• 2 edits in trunk/Source/WebCore

Handle panning gestures messages properly on Windows
​https://bugs.webkit.org/show_bug.cgi?id=121711

Follow-up fix: five regression tests started to crash on Mac.

Reviewed by Anders Carlsson.

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively):

Added null checks, not all callers are interested in scrolled view pointer.

9:13 PM Changeset in webkit [156222] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Bad cast from CSSInitialValue to CSSValueList
​https://bugs.webkit.org/show_bug.cgi?id=121729

Source/WebCore:

Reviewed by Beth Dakin.

Merge ​https://chromium.googlesource.com/chromium/blink/+/fcfaa51f9207b32cffe751c1a1380a921e464cbb

The issue was that we would cast to CSSValueList without checking
the type of the CSSValue. After this change, we use the ASSERT'ing
cast and explicitly check the type of the CSSValue before the cast.

Test: fast/css/crash-inherit-value-font-family.html

• css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

LayoutTests:

Reviewed by Beth Dakin.

Add a regression test. This is not a merge since the test in the Blink change involves
superfluous execCommand calls.

• fast/css/crash-inherit-value-font-family-expected.txt: Added.
• fast/css/crash-inherit-value-font-family.html: Added.

9:11 PM Changeset in webkit [156221] by Lucas Forschler

• 5 edits in branches/safari-537.60-branch/Source

Merged r156219. <rdar://problem/12712495>

8:36 PM Changeset in webkit [156220] by zoltan@webkit.org

• 3 edits in trunk/Source/WebCore

Remove includes from LineWidth.h
​https://bugs.webkit.org/show_bug.cgi?id=121716

Reviewed by Darin Adler.

In r156197 I removed logicalLineHeight from LineWidth.h, so we don't need to include RenderBlock.h
and RenderRubyRun.h anymore in LineWidth.h.

No new tests, no behavior change.

• rendering/LineWidth.cpp:
• rendering/LineWidth.h:

8:23 PM Changeset in webkit [156219] by roger_fong@apple.com

• 5 edits in trunk/Source

Handle panning gestures messages properly on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=121711.

Reviewed by Brent Fulgham.

This fixes a number of issues with panning gestures on Windows.

1. Two finger panning in one direction can sometimes cause some unexpected scrolling

in the other direction when the gesture first begins (directions meaning horizontal and vertical)

2. Single finger horizontal panning should only be disabled when attempting to select text.
3. Scrolling via panning should be clamped, other wise we can scroll contents completely out of the scrollview.
4. Horizontal overpan should work.
5. Overpan should occur whenever we scroll to the extents of whichever scroll view we're currently scrolling.

• WebView.cpp:

(WebView::gestureNotify):
(WebView::gesture):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):

• rendering/RenderLayer.h:

Added an argument to keep track of which scrollview was actually scrolled
This is needed by the Windows port to keep track to determine whether or not
we need to overpan.

6:25 PM Changeset in webkit [156218] by mrowe@apple.com

• 3 edits in trunk/WebKitLibraries

Fix link errors for external users when building WebKit with Xcode 5.

Reviewed by Oliver Hunt.

• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceMountainLion.a:

5:57 PM Changeset in webkit [156217] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix after r156216.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: I accidentally exposed the symbol of the calling function, not the missing symbol!

5:51 PM Changeset in webkit [156216] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

[WINDOWS] Unreviewed build fix after r156215.

• WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing symbols needed by DumpRenderTree.dll.

5:35 PM Changeset in webkit [156215] by Alexandru Chiculita

• 12 edits
  2 adds in trunk

Web Inspector: [CSS Regions] Display CSS Regions chain when highlighting a CSS Region node
​https://bugs.webkit.org/show_bug.cgi?id=121719

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/elements/highlight-node-regions.html

When a CSS Region node is highlighted through the WebInspector, it will also lookup all the regions
that are part of the same flow and inject enough information into InspectorOverlayPage.js to get the other
CSS Regions highlighted as well. A chain will also link the regions and a number will display the ordering
of the content.

• WebCore.exp.in:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::buildObjectForHighlightedNode):

• inspector/InspectorController.h:
• inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForRegionHighlight):
(WebCore::buildObjectForCSSRegionsHighlight):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawNodeHighlight): Separated the InspectorObject building part out of this function,
so that we can call buildObjectForHighlightedNode from the Internals APIs for testing.

• inspector/InspectorOverlay.h:
• inspector/InspectorOverlayPage.js:

(_drawRegionNumber):
(_quadMidPoint):
(_drawRegionLink):
(_fixQuadScrollPosition):
(_drawRegionsHighlight):
(drawNodeHighlight):

• testing/Internals.cpp: Exposed the generated InspectorObject to the layout test.

(WebCore::Internals::inspectorHighlightObject):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Added test to check the position of the CSS Regions part of the same flow thread with
the highlighted CSS Region node.

• http/tests/inspector/elements-test.js:
• inspector/elements/highlight-node-regions-expected.txt: Added.
• inspector/elements/highlight-node-regions.html: Added.

5:24 PM Changeset in webkit [156214] by mhahnenberg@apple.com

• 3 edits
  3 adds in trunk

(un)shiftCountWithAnyIndexingType will start over in the middle of copying if it sees a hole
​https://bugs.webkit.org/show_bug.cgi?id=121717

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This bug caused the array to become corrupted. We now check for holes before we start moving things,
and start moving things only once we've determined that there are none.

• runtime/JSArray.cpp:

(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):

LayoutTests:

Added test to make sure that splicing an array with holes works correctly.

• js/array-splice-with-holes-expected.txt: Added.
• js/array-splice-with-holes.html: Added.
• js/script-tests/array-splice-with-holes.js: Added.

5:07 PM Changeset in webkit [156213] by ap@apple.com

• 2 edits in trunk/LayoutTests

Fix test after <​http://trac.webkit.org/changeset/156203>

• platform/mac/accessibility/aria-help.html: Correct paths to JS tests.

5:07 PM Changeset in webkit [156212] by fpizlo@apple.com

• 3 edits
  3 adds in trunk

REGRESSION(r156047): WebCore hangs inside JSC::toInt32(double)
​https://bugs.webkit.org/show_bug.cgi?id=121648

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

The Int52<->StrictInt52 conversion did the opposite fill() than what it was
supposed to. For example when converting a Int52 to a StrictInt52 it would fill
as Int52, and vice-versa.

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):

LayoutTests:

Reviewed by Mark Hahnenberg.

• js/dfg-int52-change-format-expected.txt: Added.
• js/dfg-int52-change-format.html: Added.
• js/script-tests/dfg-int52-change-format.js: Added.

(foo):

5:00 PM Changeset in webkit [156211] by oliver@apple.com

• 3 edits
  3 adds in trunk

REGRESSION(r153215): New iCloud site crashes
​https://bugs.webkit.org/show_bug.cgi?id=121710

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Don't claim to be able to rely on the arguments structure, use the Arguments
speculation type

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

LayoutTests:

New test case

• js/dfg-arguments-mutated-structure-expected.txt: Added.
• js/dfg-arguments-mutated-structure.html: Added.
• js/script-tests/dfg-arguments-mutated-structure.js: Added.

(foo):

4:59 PM Changeset in webkit [156210] by commit-queue@webkit.org

• 4 edits
  2 deletes in trunk

Unreviewed, rolling out r156185.
​http://trac.webkit.org/changeset/156185
​https://bugs.webkit.org/show_bug.cgi?id=121727

Caused a lot of crashes in tests (Requested by ap on #webkit).

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayout):

• dom/Document.h:

LayoutTests:

• fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Removed.
• fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Removed.

4:45 PM Changeset in webkit [156209] by timothy@apple.com

• 9 edits in trunk/Source/WebInspectorUI

Parse MIME-types and strip them down to the base type when needed.

The use of charset in a MIME-type interferes with our type maps,
preventing the right syntax highlighting mode and pretty printing.

​https://bugs.webkit.org/show_bug.cgi?id=121723

Reviewed by Joseph Pecoraro.

• UserInterface/ConsolePrompt.js:

(WebInspector.ConsolePrompt):

• UserInterface/FontResourceContentView.js:
• UserInterface/Resource.js:

(WebInspector.Resource.Type.fromMIMEType):
(WebInspector.Resource.prototype.get mimeTypeComponents):
(WebInspector.Resource.prototype.get syntheticMIMEType):
(WebInspector.Resource.prototype.get contentURL):
(WebInspector.Resource.prototype.updateForResponse):

• UserInterface/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):

• UserInterface/SourceMapResource.js:

(WebInspector.SourceMapResource.prototype.requestContentFromBackend):

• UserInterface/SyntaxHighlightingSupport.js:

(WebInspector.syntaxHighlightStringAsDocumentFragment):

• UserInterface/TextEditor.js:

(WebInspector.TextEditor.prototype.set mimeType):

• UserInterface/Utilities.js:

(parseMIMEType): Added.

4:01 PM Changeset in webkit [156208] by mrowe@apple.com

• 5 edits in trunk

<​https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date

Tools:

Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.

Reviewed by David Kilzer.

• Scripts/webkitdirs.pm:

(checkRequiredSystemConfig):

Websites/webkit.org:

Update references on webkit.org to mention Xcode 4.6 as the minimum version.

Reviewed by David Kilzer.

• building/debug-mac-uiprocess.html:
• building/tools.html:

3:52 PM Changeset in webkit [156207] by Lucas Forschler

• 5 edits in branches/safari-537.60-branch/Source

Versioning.

3:48 PM Changeset in webkit [156206] by Lucas Forschler

• 1 copy in tags/Safari-537.60.2

New Tag.

3:17 PM Changeset in webkit [156205] by dino@apple.com

• 3 edits in trunk/Source/WebCore

Shaders that fail to compile should be marked as such
​https://bugs.webkit.org/show_bug.cgi?id=121721

Reviewed by Simon Fraser.

1. Add a new logging channel for WebGL.

2. If a translated shader fails to compile (technically

this should never happen), mark it as invalid.

Test: ​https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shader-with-non-reserved-words.html

• platform/Logging.h: New WebGL channel.
• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader): Log the raw and translated
input to glCompileShader, but mark the entry as invalid.

2:58 PM Changeset in webkit [156204] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Add an implementation of std::index_sequence from C++14
​https://bugs.webkit.org/show_bug.cgi?id=121718

Reviewed by Ryosuke Niwa.

This will make it easier to do things like pack expansion of tuple elements.

• wtf/StdLibExtras.h:

2:56 PM Changeset in webkit [156203] by mario@webkit.org

• 18 edits
  2 moves
  2 deletes in trunk

[ATK] Do not expose aria-help in ATK based platforms
​https://bugs.webkit.org/show_bug.cgi?id=121675

Patch by Mario Sanchez Prada <​mario.prada@samsung.com> on 2013-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

Stop exposing the value for the 'aria-help' attribute as an
AtkObject attribute, based in AccessibilityObject::helpText().

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Remove the mapping.

Source/WebKit/efl:

Removed accessibilityHelpText() helper method from
DumpRenderSupportEfl's API, since it's not longer needed.

• WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Removed method.
• WebCoreSupport/DumpRenderTreeSupportEfl.h: Ditto.

Source/WebKit/gtk:

Removed accessibilityHelpText() helper method from
DumpRenderSupportGtk's API, since it's not longer needed.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Removed method.
• WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.

Tools:

Remove the implementations for AccessibilityUIElement::helpText()
from DRT and WKTR for GTK and EFL, since they are based on the
AccessibilityObject::helpText() method and the 'aria-help'
attributes, which is wrong since they should not depend on that
but in ATK specific API (see also ​http://webkit.org/b/121684).

• DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::helpText): Added a new and empty
implementation, now that we are no longer using this in ATK.

• DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file

as the only function provided here was helpText().

• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
• DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp

removed from the list of sources to compile.

• GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::helpText): Replaced old implementation
based in DumpRenderTreeSupportGtk with an empty one.

LayoutTests:

Moved test based in helpText() into the Mac directory, and update
expectations for platforms as needed.

• platform/mac/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/aria-help-expected.txt.
• platform/mac/accessibility/aria-help.html: Renamed from LayoutTests/accessibility/aria-help.html.
• platform/gtk-wk2/TestExpectations: Removed failure expectation

for aria-help, now moved to Mac, and for aria-describedby-on-input,
which is now moved to the generic TestExpectations file for GTK.

• platform/gtk/TestExpectations: Added aria-describedby-on-input,

linking it to the newly filed bug 121684.

• platform/gtk-wk2/TestExpectations: Removed failure expectation.
• platform/win/TestExpectations: Removed failure expectation.
• platform/wincairo/TestExpectations: Ditto.

2:54 PM Changeset in webkit [156202] by Lucas Forschler

• 3 edits in branches/safari-537.60-branch/Source/WebCore

Correct build by activating Microsoft Assembler support in
project file. I have no idea why this would be missing in
the branch.

Patch by Brent Fulgham <Brent Fulgham> on 2013-09-20

• WebCore.vcxproj/WebCore.vcxproj: Activate MASM support.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

2:47 PM Changeset in webkit [156201] by Simon Fraser

• 7 edits in trunk/Source/WebCore

Scrollbars don't appear on long pages after r155660
​https://bugs.webkit.org/show_bug.cgi?id=121714
<rdar://problem/15042478>

Reviewed by Beth Dakin.

After r155660, we don't do any additional layouts when scrollbars are
added or removed. That caused us to not enter the code that creates or
destroys composting layers for scrollbars in RenderLayerCompositor, resulting
in missing scrollbars.

Fix by having ScrollView::updateScrollbars() call addedOrRemovedScrollbar()
when a scrollbar was added or removed, which is overridden in FrameView
to call through to RenderLayerCompositor::frameViewDidAddOrRemoveScrollbars().

Not testable since scrollbar layers aren't contained in layer tree dumps
(to reduce diffs between platforms).

• page/FrameView.cpp:

(WebCore::FrameView::addedOrRemovedScrollbar): New function to tell the compositor
that scrollbars changed.

• page/FrameView.h:
• platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar): Change the meaning of the return
value to say if the scrollbar was added or removed. Add an out param that indicates
whether the scrollbar change affects content size (not true for overlay scrollbars).
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): Keep track of whether scrollbars were
added or removed, and call addedOrRemovedScrollbar() if true.

• platform/ScrollView.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidAddOrRemoveScrollbars): Call updateOverflowControlsLayers().
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

• rendering/RenderLayerCompositor.h:

2:47 PM Changeset in webkit [156200] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Ensure that TileController tile coverage is updated on scrolling even when we don't have scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=121700
<rdar://problem/15030589>

Reviewed by Dean Jackson.

r155660 introduced a bug where we wouldn't make scrollbars on long pages. However,
that revealed a fundamental flaw in the TiledBacking update logic; it relied on the
GraphicsLayer flushes triggered by scrollbars updates in order to update the main
TileController's tile coverage. No scrollbars meant no tile coverage updates.

Fix by explicitly triggering a flush when the FrameView is scrolled (we get
notified about this on the main thread after the scrolling thread has moved
layers around).

No test since this will only be exposed for a short time while scrollbars are
broken.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):

2:17 PM Changeset in webkit [156199] by zoltan@webkit.org

• 3 edits in trunk/Source/WebCore

Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h
​https://bugs.webkit.org/show_bug.cgi?id=121707

Reviewed by David Hyatt.

LineBreaker and RenderTextInfo are defined in RenderBlock.h, but only used in RenderBlockLineLayout.cpp.
Moving them there (LineBreaker needs to be a friend class of RenderBlock) in the first step in the process
of refactoring LineBreaker::NextSegmentBreak into more manageable chunks.

This change was reviewed and landed in Blink:
​https://src.chromium.org/viewvc/blink?revision=157402&view=revision

No new tests.

• rendering/RenderBlock.h:
• rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::LineBreaker):
(WebCore::LineBreaker::lineWasHyphenated):
(WebCore::LineBreaker::positionedObjects):
(WebCore::LineBreaker::clear):
(WebCore::RenderTextInfo::RenderTextInfo):
(WebCore::RenderTextInfo::~RenderTextInfo):
(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):
(WebCore::LineBreaker::reset):
(WebCore::LineBreaker::nextLineBreak):
(WebCore::LineBreaker::nextSegmentBreak):

2:17 PM Changeset in webkit [156198] by timothy@apple.com

• 10 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix keyboard shortcuts for other platforms
​https://bugs.webkit.org/show_bug.cgi?id=120657

Patch by Marcelo Morais <​m.morais@samsung.com> on 2013-09-20
Reviewed by Timothy Hatcher.

Handling keyboard shortcuts according to the current platform.

• UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
(.WebInspector.InspectorFrontendHostStub.prototype.platform): Added. Return the
current platform.

• UserInterface/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.Modifier.get CommandOrControl): Added. Created keyboard
modifier to return Control or Command key according to current platform.

• UserInterface/ContentBrowser.js:

(WebInspector.ContentBrowser): Returning Control or Command key for keyboard
shortcuts according to current platform.

• UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel): Ditto.

• UserInterface/FindBanner.js:

(WebInspector.FindBanner): Ditto.

• UserInterface/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController): Ditto.

• UserInterface/LogContentView.js:

(WebInspector.LogContentView): Ditto.

• UserInterface/Main.js:

(WebInspector.contentLoaded): Ditto.

• UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel): Ditto.

1:53 PM Changeset in webkit [156197] by zoltan@webkit.org

• 6 edits in trunk/Source/WebCore

Move logicalHeightForLine out of LineWidth.h
​https://bugs.webkit.org/show_bug.cgi?id=121575

Reviewed by David Hyatt.

In bug #121107 (r155565), I moved logicalHeightForLine into LineWidth.h as part of LineWidth
refactoring. LogicalHeightForLine without passing the second parameter uses RenderBlock::lineHeight
anyway, except it doesn't take -line-box-contain CSS property into account. For Shapes we don't
have implementation for variable-height lines (​https://bugs.webkit.org/show_bug.cgi?id=95361) yet, so
so I modified the affected functions to call lineHeight directly. I renamed logicalHeightForLine
to minLineHeightForReplacedRenderer, and I made the second parameter a mandatory for that function.

No new tests, no behavior change.

• rendering/LineWidth.cpp:

(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

• rendering/LineWidth.h:
• rendering/RenderBlock.cpp: Move the definition here.

(WebCore::RenderBlock::minLineHeightForReplacedRenderer):

• rendering/RenderBlock.h: Move the function here and rename it.
• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutShapeInsideInfo):
(WebCore::updateLogicalInlinePositions):
(WebCore::updateSegmentsForShapes):

1:40 PM Changeset in webkit [156196] by ap@apple.com

• 2 edits in trunk/Source/WebCore

-[WebHTMLConveter _getFloat:forNode:property:] leaks
​https://bugs.webkit.org/show_bug.cgi?id=121709

Reviewed by Enrica Casucci.

• platform/mac/HTMLConverter.mm:

(-[WebHTMLConverter _getFloat:forNode:property:]): Don't leak.

1:35 PM Changeset in webkit [156195] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect a scaled image.
​https://bugs.webkit.org/show_bug.cgi?id=121696

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2013-09-20
Reviewed by Antti Koivisto.

Add an argument to ImageSource::createFrameAtIndex. A platform image decoder can decide the optimal
scale based on the hint and pass the real scale it used for decoding.

No new tests, no behavior change.

• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::createFrameAtIndex):

• platform/graphics/ImageSource.h:
• platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::createFrameAtIndex):

1:27 PM Changeset in webkit [156194] by Bem Jones-Bey

• 1 edit
  57 copies
  8 adds
  1 delete in trunk/LayoutTests

Move tests to new import location
​https://bugs.webkit.org/show_bug.cgi?id=121701

Reviewed by Dirk Schulze.

The import script was previously importing the tests into an incorrect
path. This change uses the latest import script to import all of the
shapes tests to the right location.

There are also some small changes in the tests since they had some
more metadata added upstream, but there are no functional changes in
the tests with this change.

• csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js.

(ellipseXIntercept):
(scanConvertRoundedRectangleOutside):
(genLeftRightRoundedRectFloatShapeOutsideRefTest):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(genRightRoundedRectFloatShapeOutsideRefTest):

• csswg/contributors/adobe/submitted/shapes/shape-outside/resources/subpixel-utils.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js.

(SubPixelLayout):
(SubPixelLayout.):

• csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log: Added.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Copied from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html.
• csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log: Added.
• csswg/submitted/shapes/shape-outside/w3c-import.log: Removed.

1:26 PM Changeset in webkit [156193] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Make JSMainThreadNullState noncopyable.

Blindly rubber-stamped by Antti Koivisto.

• bindings/js/JSMainThreadExecState.h:

1:23 PM Changeset in webkit [156192] by mhahnenberg@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Clobberize phase forgets to indicate that it writes GCState for several node types
​https://bugs.webkit.org/show_bug.cgi?id=121702

Reviewed by Oliver Hunt.

Added read and write for GCState to the nodes that could end up allocating (and thereby
cause a garbage collection).

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

1:13 PM Changeset in webkit [156191] by mitz@apple.com

• 5 edits
  1 copy in trunk

Make extract-localizable-strings available to WebCore clients
​https://bugs.webkit.org/show_bug.cgi?id=121699

Reviewed by Darin Adler.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj: Added a Scripts group with a reference to

extract-localizable-strings.pl. Added a Copy Scripts build phase to the WebCore target that
copies the script into PrivateHeaders/Scripts in the framework.

• extract-localizable-strings.pl: Copied from Tools/Scripts/extract-localizable-strings.

Tools:

• Scripts/extract-localizable-strings: Copied to

Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
executes the script from its new location. This is a temporary measure until certain code
that is external to WebKit is adapted to the new location.

• Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl

from its new location.

12:56 PM Changeset in webkit [156190] by Antti Koivisto

• 6 edits in trunk/Source/WebCore

Move layer hierarchy functions from RenderObject to RenderElement
​https://bugs.webkit.org/show_bug.cgi?id=121692

Reviewed by Andreas Kling.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::addLayers):
(WebCore::RenderElement::removeLayers):
(WebCore::RenderElement::moveLayers):
(WebCore::RenderElement::findNextLayer):
(WebCore::RenderElement::layerCreationAllowedForSubtree):

Move these from RenderObject.

(WebCore::RenderElement::insertedIntoTree):
(WebCore::RenderElement::willBeRemovedFromTree):

Factor the layer related portion of these virtuals here.

12:29 PM Changeset in webkit [156189] by benjamin@webkit.org

• 6 edits in trunk/Source/WebCore

Start cleaning the API of SelectorChecker
​https://bugs.webkit.org/show_bug.cgi?id=121654

Reviewed by Antti Koivisto.

Make the matching mode internal.
Remove unused accessors.
Make isFrameFocused() internal.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
(WebCore::isFrameFocused):

• css/SelectorChecker.h:

(WebCore::SelectorChecker::match):

• css/StyleResolver.h:

(WebCore::checkRegionSelector):

• dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):

12:28 PM Changeset in webkit [156188] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Remove SelectorChecker's CrossesBoundary boundary mode
​https://bugs.webkit.org/show_bug.cgi?id=121653

Reviewed by Antti Koivisto.

This mode is an ancient vestige of shadow dom.

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):

• css/SelectorChecker.h:

12:27 PM Changeset in webkit [156187] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Move the SharingRules mode outside of SelectorChecker
​https://bugs.webkit.org/show_bug.cgi?id=121652

Reviewed by Antti Koivisto.

The SharingRules handling inside SelectorChecker is a weird hack
to hit a specific branch of ElementRuleCollector.

This patch moves the exception to ElementRuleCollector, where it is easier
to understand what it is for.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):

12:09 PM Changeset in webkit [156186] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

Fixed img src URLS with multiple spaces
​https://bugs.webkit.org/show_bug.cgi?id=121592

Patch by Yoav Weiss <​yoav@yoav.ws> on 2013-09-20
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/loader/image-src-multiple-space.html

I've removed the simplifyWhiteSpace step from HTMLImageElement's src attribute during the srcset selection algorithm.
That step prevented URLs with multiple spaces from being loaded as images, minimizing the multiple spaces into a single one.

• html/parser/HTMLParserIdioms.cpp:

(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

This test verifies that URLs with multiple spaces can be loaded as an image resource.

• fast/loader/image-src-multiple-space-expected.txt: Added.
• fast/loader/image-src-multiple-space.html: Added.

12:06 PM Changeset in webkit [156185] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Hiding a focused element should unfocus it and fire a blur event
​https://bugs.webkit.org/show_bug.cgi?id=29241

Patch by Arunprasad Rajkumar <​ararunprasad@gmail.com> on 2013-09-20
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLDocument/active-element-gets-unfocusable.html

We check whether the current focus element is really focusable after
the style recalculation and layout change. If it is not focusable then schedule a
timer to reset it asynchronously.

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle): Check isFocusable() on the focus element after
style recalculation.
(WebCore::Document::updateLayout): Check isFocusable() on the focus element after
layout.
(WebCore::Document::resetHiddenFocusElementSoon):
(WebCore::Document::resetHiddenFocusElementTimer):

• dom/Document.h:

LayoutTests:

• fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Added.
• fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Added.

LayoutTest reused from ​https://chromium.googlesource.com/chromium/blink/+/c58f636fd18fc27944c42e27d6a92a36867c57e1
with little modification.

11:42 AM Changeset in webkit [156184] by fpizlo@apple.com

• 39 edits
  5 adds
  5 deletes in trunk/Source/JavaScriptCore

Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
​https://bugs.webkit.org/show_bug.cgi?id=121637

Rubber stamped by Michael Saboff.

Also moved GPRInfo/FPRInfo into jit/. Rolling back in after fixing JIT-only build
and tests.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• bytecode/ValueRecovery.h:

(JSC::ValueRecovery::dumpInContext):

• dfg/DFGAssemblyHelpers.cpp: Removed.
• dfg/DFGAssemblyHelpers.h: Removed.
• dfg/DFGBinarySwitch.h:
• dfg/DFGByteCodeParser.cpp:
• dfg/DFGCCallHelpers.h: Removed.
• dfg/DFGDisassembler.cpp:
• dfg/DFGFPRInfo.h: Removed.
• dfg/DFGGPRInfo.h: Removed.
• dfg/DFGGraph.cpp:
• dfg/DFGGraph.h:
• dfg/DFGJITCompiler.h:
• dfg/DFGOSRExit.cpp:
• dfg/DFGOSRExit.h:
• dfg/DFGOSRExitCompiler.h:
• dfg/DFGOSRExitCompilerCommon.h:
• dfg/DFGRegisterBank.h:
• dfg/DFGRegisterSet.h:
• dfg/DFGRepatch.cpp:
• dfg/DFGSilentRegisterSavePlan.h:
• dfg/DFGThunks.cpp:
• dfg/DFGVariableEvent.cpp:
• ftl/FTLCArgumentGetter.h:

(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):

• ftl/FTLCompile.cpp:
• ftl/FTLExitThunkGenerator.h:
• ftl/FTLLink.cpp:
• ftl/FTLThunks.cpp:
• jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
• jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.

(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):

• jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
• jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.

(WTF::printInternal):

• jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.

(WTF::printInternal):

• jit/JIT.cpp:

(JSC::JIT::JIT):

• jit/JIT.h:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

• jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::JSInterfaceJIT):

• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):

• jit/ThunkGenerators.cpp:

(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):

• llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

• runtime/JSCJSValue.h:

11:31 AM Changeset in webkit [156183] by ap@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r156140): Srcset tests are frequently crashing
​https://bugs.webkit.org/show_bug.cgi?id=121695

Reviewed by Dean Jackson.

Returning a string created without copying bytes is not safe. It used to be OK
because a new string was immediately created by decodeURLEscapeSequences().
But even that was not great, because decodeURLEscapeSequences() could potentially
return the same string, not a deep copy, if we decided to optimize it like that.

Also made a number of drive-by style fixes.

• It's URL, not Url.
• It's srcset, not srcSet.
• We don't add ".0" in floating point value initializers. It's particularly misleading

to initialize a float with 1.0, which is a double value.

• Renamed srcSetLength to srcsetAttributeLength to match srcsetAttribute variable

whose length it caches.

• html/parser/HTMLParserIdioms.cpp:

(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

11:12 AM Changeset in webkit [156182] by Martin Robinson

• 2 edits in trunk/Source/WebCore

[GTK] Clean up the Skip* functions in the GObject DOM bindings code generator
​https://bugs.webkit.org/show_bug.cgi?id=121633

Reviewed by Gustavo Noronha Silva.

• bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute): Fold in some skipping checks that are used by all callers.
(SkipFunction): Ditto.
(GenerateProperties): Rely on SkipAttribute more thoroughly.
(GenerateFunction): Rely on SkipFunction more thoroughly.
(GenerateFunctions): Rely on SkipAttribute more thoroughly.

10:44 AM Changeset in webkit [156181] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Fix the build after r156144

• html/canvas/CanvasRenderingContext2D.cpp: Added missing include.

10:32 AM Changeset in webkit [156180] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

renderStyleOfEnclosingTextNode should update style before using a renderer
​https://bugs.webkit.org/show_bug.cgi?id=121690

Reviewed by Enrica Casucci.

Merge ​https://chromium.googlesource.com/chromium/blink/+/65f089545e8c18cb268dfcbe56cba1cd8045527a

When accessing a renderer editing should always make sure that the style has been updated for the node.
Editing calls splitTextNode in a number of places and then accesses the renderer later. This patch is
the first of many to make sure editing always updates the style before attempting to access the renderer
(or style) of a node after calling a mutation method.

• editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::renderStyleOfEnclosingTextNode):

• editing/ApplyBlockElementCommand.h:

10:28 AM Changeset in webkit [156179] by ap@apple.com

• 1 edit
  1 move in trunk/LayoutTests

Remove URL decoding in srcset handling
​https://bugs.webkit.org/show_bug.cgi?id=121609

Followup to <​http://trac.webkit.org/changeset/156161> - that change renamed expected
results, but the new test wasn't landed.

• fast/loader/image-src-encoded.html: Copied from LayoutTests/fast/loader/image-src-question-mark.html.
• fast/loader/image-src-question-mark.html: Removed.

10:18 AM Changeset in webkit [156178] by Darin Adler

• 3 edits in trunk/Source/WebCore

Fix a couple more CSS leaks
​https://bugs.webkit.org/show_bug.cgi?id=121683

Reviewed by Alexey Proskuryakov.

• css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::viewSourceStyle): Put the result of the
parseUASheet into a global variable so it doesn't show up as a storage leak.

• css/CSSGrammar.y.in: Added a missing adoptRef. This was leaking any rule

we parsed individually.

10:16 AM Changeset in webkit [156177] by Patrick Gansterer

• 1 edit
  4 deletes in trunk/Tools

Nuke remaining VS2005 tools from the tree.
​https://bugs.webkit.org/show_bug.cgi?id=121691

Reviewed by Brent Fulgham.

• CLWrapper/CLWrapper.cpp: Removed.
• CLWrapper/CLWrapper.sln: Removed.
• CLWrapper/CLWrapper.vcproj: Removed.
• MIDLWrapper/MIDLWrapper.cpp: Removed.
• MIDLWrapper/MIDLWrapper.sln: Removed.
• MIDLWrapper/MIDLWrapper.vcproj: Removed.
• Scripts/parallelcl: Removed.
• vcbin/cl.exe: Removed.
• vcbin/midl.exe: Removed.

10:16 AM Changeset in webkit [156176] by Bem Jones-Bey

• 8 edits in trunk/Source/WebCore

Simplify the ShapeOutsideInfo and ShapeInfo interfaces
​https://bugs.webkit.org/show_bug.cgi?id=121685

Reviewed by Darin Adler.

With the creation ShapeInfo::computeSegmentsForLine, it became possible to
simplify the ShapeInfo classes. ShapeOutsideInfo has no need to save the
segments, and now that segment creation is in its own method, it doesn't have
to save the segments anymore. This also simplifies the public interface of
ShapeOutsideInfo, as it only has one method to do the computation.

Also, the methods in ShapeOutsideInfo have been renamed to reflect the fact
that ShapeOutsideInfo isn't really interested in segments.

No new tests, no new behavior.

• rendering/FloatingObjects.cpp:

(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

• rendering/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

• rendering/shapes/ShapeInfo.cpp:
• rendering/shapes/ShapeInfo.h:
• rendering/shapes/ShapeInsideInfo.h:
• rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

• rendering/shapes/ShapeOutsideInfo.h:

10:10 AM Changeset in webkit [156175] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Making tests added in r156157 JS-only, given that other
code generators are still broken.

Original bug 121305 (StrictTypeChecking extended attribute fails for methods with sequence<T>).
​https://bugs.webkit.org/show_bug.cgi?id=121305

Patch by Antonio Gomes <​a1.gomes@sisa.samsung.com> on 2013-09-20
Rubber stamped by Alexey Proskuryakov.

• bindings/scripts/test/TestObj.idl:

10:07 AM Changeset in webkit [156174] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[BlackBerry] Poor rendering opening a Google map short link
​https://bugs.webkit.org/show_bug.cgi?id=121687

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-09-20
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

JIRA 495023
Route lines on google map were shown even they were on a hidden canvas.
Include visibility on LayerWebKitThread if it's a canvas layer and respect
the visibility when compositing layers in LayerRenderer.

• platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::isCanvasLayer):
(WebCore::LayerData::isVisible):
(WebCore::LayerData::includeVisibility):

• platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeLayersRecursive):

9:57 AM Changeset in webkit [156173] by Brent Fulgham

• 2 edits in trunk/Source/WebInspectorUI

[Windows] Unreviewed gardening. Teach WebInspectorUI.vcxproj folder to
ignore Visual Studio's local user settings file.

• WebInspectorUI.vcxproj: Added property svn:ignore.

9:48 AM Changeset in webkit [156172] by commit-queue@webkit.org

• 2 edits in trunk

[CMAKE] FindHarfBuzz: Handle harfbuzz / harfbuzz-icu split
​https://bugs.webkit.org/show_bug.cgi?id=121688

Patch by Sergio Correia <Sergio Correia> on 2013-09-20
Reviewed by Martin Robinson.

HarfBuzz 0.9.18 split ICU support into a separate harfbuzz-icu library.
To be able to build with earlier and newer versions of HarfBuzz, we should
check for harfbuzz-icu as well, if version >= 0.9.18.

• Source/cmake/FindHarfBuzz.cmake: Check for harfbuzz-icu, if version

  0.9.18.

9:45 AM Changeset in webkit [156171] by Patrick Gansterer

• 2 edits in trunk/Source/WebKit/win

Fix MIDL files for Visual Studio 2012
​https://bugs.webkit.org/show_bug.cgi?id=121552

Reviewed by Brent Fulgham.

The MIDL compiler shipped with Visual Studio 2012 does not accept forward declarations
with typedefs. Use the struct keyword in the function signature to fix this problem.

• Interfaces/DOMPrivate.idl:

9:45 AM Changeset in webkit [156170] by allan.jensen@digia.com

• 2 edits in trunk/Source/WTF

Atomics.h does not build on MinGW
​https://bugs.webkit.org/show_bug.cgi?id=121663

Reviewed by Darin Adler.

MinGW does not have _ReadWriteBarrier() intrinsic, but does have GCC
inline assembler, so use the GCC definitions instead of MSVC ones.

• wtf/Atomics.h:

(WTF::compilerFence):

9:40 AM WebInspector edited by timothy@apple.com

(diff)

9:39 AM WebInspector edited by timothy@apple.com

(diff)

9:35 AM Changeset in webkit [156169] by allan.jensen@digia.com

• 2 edits in trunk/Source/JavaScriptCore

Inline method exported
​https://bugs.webkit.org/show_bug.cgi?id=121664

Reviewed by Darin Adler.

WatchDog::didFire() is marked as an exported symbol eventhough it is
defined inline. This breaks the build on MinGW since it results in dllimport
being declared on a definition.

• runtime/Watchdog.h:

(JSC::Watchdog::didFire):

9:18 AM Changeset in webkit [156168] by commit-queue@webkit.org

• 4 edits in trunk

AX: WebArea claims to have a subrole, but always returns nil.
​https://bugs.webkit.org/show_bug.cgi?id=121658

Patch by Sam White <Samuel White> on 2013-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing AXWebArea related test to reflect unused attribute removal.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

Updated test output to reflect removal of unused NSAccessibilitySubroleAttribute in AXWebArea.

• platform/mac/accessibility/document-attributes-expected.txt:

8:47 AM Changeset in webkit [156167] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/Tools

[GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
​https://bugs.webkit.org/show_bug.cgi?id=121294

Patch by Mario Sanchez Prada <​mario.prada@samsung.com> on 2013-09-20
Reviewed by Martin Robinson.

Provide a new patch to deal with the issue in the GTK+ module from
the internal jhbuild environment. This issue has been reported
upstream (see ​https://bugzilla.gnome.org/show_bug.cgi?id=708024).

• gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
• gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.

8:34 AM Changeset in webkit [156166] by akling@apple.com

• 14 edits in trunk/Source/WebCore

Add valueForLength/minimumValueForLength wrappers to RenderElement.
<​https://webkit.org/b/121676>

Reviewed by Antti Koivisto.

Add two inline wrappers for these functions so we don't have to pass
the RenderView everywhere.

8:20 AM Changeset in webkit [156165] by commit-queue@webkit.org

• 4 edits in trunk

[ATK][WTR] accessibility/aria-invalid.html times out
​https://bugs.webkit.org/show_bug.cgi?id=121668

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
false in case of aria-invalid event with empty value.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
case of aria-invalid event with empty value.

LayoutTests:

Updated the expectation of aria-invalid.html test, which was timing out
before bug 120421 and this fix.

• platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because

it now passes with this fix and the patch from bug 120421.

8:15 AM Changeset in webkit [156164] by commit-queue@webkit.org

• 9 edits
  2 adds in trunk/Tools

[ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
​https://bugs.webkit.org/show_bug.cgi?id=120421

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Implemented the notification listener for AccessibilityUIElement for
WebKitTestRunner. The signal is generated by
AXObjectCache::postPlatformNotification() and received by
axObjectEventListener(). axObjectEventListener() will then invoke
JSObjectCallAsFunction() with the respective callback function. The
notification handlers are stored in HashMap in
AccessibilityNotificationHandlerAtk.cpp.

Moved ATK signal handling (printAccessibilityEvent and
axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.

• WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the

include path.

• WebKitTestRunner/GNUmakefile.am:

Added AccessibilityNotificationHandlerAtk.cpp/h.

• WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved

listener IDs to AccessibilityNotificationHandlerAtk.cpp.

• WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved

listener IDs to AccessibilityNotificationHandlerAtk.cpp.

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a

notification handler for GTK+ and EFL.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

Moved printAccessibilityEvent and axObjectEventListener to
AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::logAccessibilityEvents): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::resetToConsistentState): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.

(WTR::printAccessibilityEvent): Prints accessibility events. This
function was moved from AccessibilityControllerAtk.cpp.
(WTR::axObjectEventListener): Callback for signals. This function was
moved from AccessibilityControllerAtk.cpp.
(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
Initialize element and function callback.
(WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
Removes handler from HashMap and disconnects callbacks if necessary.
(WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
logging mode and connects callbacks.
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
Sets the notification callback and connects callback to signals.
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
Removes the notification callback from HashMap.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connects axObjectEventListener to ATK signals.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnects callback.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.

(WTR::AccessibilityNotificationHandler::create): Creates a new instance
of AccessibilityNotificationHandler.
(WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
element.
(WTR::AccessibilityNotificationHandler::platformElement): Gets the
element.
(WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
Gets the notification callback.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::addNotificationListener): Creates
notification handler, set the platform element and the notification
callback.
(WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
notification handler.

• WebKitTestRunner/PlatformEfl.cmake:

Added AccessibilityNotificationHandlerAtk.cpp.

8:04 AM Changeset in webkit [156163] by Martin Robinson

• 44 edits in trunk/Source/WebCore

[GTK] Fix some small style issues in the bindings
​https://bugs.webkit.org/show_bug.cgi?id=121613

Reviewed by Carlos Garcia Campos.

• bindings/scripts/CodeGeneratorGObject.pm: When printing the license

header use the more common comment style within the WebKit project.
(GenerateProperty): Indent property definitions according to WebKit style, improve
the nick and blurb properties, and improve the various parameter spec argument layout.
(GenerateFunction): Remove the newline from function signatures to match WebKit style.

• bindings/scripts/test/GObject: Update bindings test results.

7:58 AM Changeset in webkit [156162] by zarvai@inf.u-szeged.hu

• 4 edits
  1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-09-20

• platform/qt-wk1/TestExpectations:
• platform/qt-wk2/TestExpectations:
• platform/qt-wk2/fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
• platform/qt/TestExpectations:

7:43 AM Changeset in webkit [156161] by commit-queue@webkit.org

• 1 edit
  5 moves in trunk/LayoutTests

Modified img src and srcset encoded URL tests
​https://bugs.webkit.org/show_bug.cgi?id=121677

Previous tests have broken the Windows builds, since '?' is not a valid char.
Moved to using '@'

Patch by Yoav Weiss <​yoav@yoav.ws> on 2013-09-20
Reviewed by Anders Carlsson.

• fast/hidpi/image-srcset-encoded-expected.txt: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark-expected.txt.
• fast/hidpi/image-srcset-encoded.html: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark.html.
• fast/hidpi/resources/​image@test.png: Renamed from LayoutTests/fast/hidpi/resources/image?test.png.
• fast/loader/image-src-encoded-expected.txt: Renamed from LayoutTests/fast/loader/image-src-question-mark-expected.txt.
• fast/loader/resources/​image@test.png: Renamed from LayoutTests/fast/loader/resources/image?test.png.

7:12 AM Changeset in webkit [156160] by zarvai@inf.u-szeged.hu

• 1 edit
  16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update tests after r156066 and r156083.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-09-20

• platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.png: Added r156083.
• platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.txt: Added r156083.
• platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.png: Added r156083.
• platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.txt: Added r156083.
• platform/qt-wk1/fast/forms/form-element-geometry-expected.png: Added r156083.
• platform/qt-wk1/fast/forms/form-element-geometry-expected.txt: Added r156083.
• platform/qt-wk1/fast/forms/menulist-separator-painting-expected.txt: Added r156083.
• platform/qt-wk1/fast/forms/select-baseline-expected.png: Added r156083.
• platform/qt-wk1/fast/forms/select-baseline-expected.txt: Added r156083.
• platform/qt-wk1/fast/forms/selectlist-minsize-expected.txt: Added r156083.
• platform/qt-wk1/fast/replaced/three-selects-break-expected.txt: Added r156083.
• platform/qt-wk1/js/dom/switch-behaviour-expected.txt: Added r156066.

6:23 AM Changeset in webkit [156159] by Patrick Gansterer

• 8 edits in trunk/Source

[CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
​https://bugs.webkit.org/show_bug.cgi?id=121672

Reviewed by Gyuyoung Kim.

Since the scope of add_definitions() is always a whole file, we need to use
target properties instead to set definitions only for specific targets.

Source/JavaScriptCore:

• CMakeLists.txt:

Source/WebCore:

• CMakeLists.txt:

Source/WebKit:

• CMakeLists.txt:

Source/WTF:

• wtf/CMakeLists.txt:

6:17 AM Changeset in webkit [156158] by tonikitoo@webkit.org

• 9 edits in trunk

Source/WebCore: Make "autoscroll for drag'n drop" a setting
​https://bugs.webkit.org/show_bug.cgi?id=121559

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <​a1.gomes@sisa.samsung.com>

Currently, there is a ChromeClient hook to make the
feature opt'ed-in or out. That makes it harder to test the
feature on ports that do not enable it, e.g. Mac/WebKit2 port.
However, Mac/WebKit2 is the port that has the best drag'n drop
WTR implementation.

Patch changes the toggle on/off mechanism to be a setting,
and exposes it through InternalSetting interface for testing.

• page/AutoscrollController.cpp:

(WebCore::AutoscrollController::updateDragAndDrop):

• page/ChromeClient.h:
• page/Settings.in:
• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAutoscrollForDragAndDropEnabled):

• testing/InternalSettings.h:
• testing/InternalSettings.idl:

LayoutTests: Make "autoscroll" for drag'n drop a setting
​https://bugs.webkit.org/show_bug.cgi?id=121559

• fast/events/drag-and-drop-autoscroll.html:

Adapts the test so that is toggles the feature on
via InternalSettings interface.

6:16 AM Changeset in webkit [156157] by tonikitoo@webkit.org

• 6 edits in trunk/Source/WebCore

StrictTypeChecking extended attribute fails for methods with sequence<T> ​https://bugs.webkit.org/show_bug.cgi?id=121305

Reviewed by Darin Adler.
Patch by Antonio Gomes <​a1.gomes@sisa.samsung.com>

The extended attribute StrictTypeChecking can not be set to methods if
one of the parameters is a "sequence".
Basically, since "sequence" is not considered a native type
(see function IsNativeType) the Perl code generator tries to
include its supposedly associated header, in this case "JSsequence.h"
Compilation then fails.

It is a problem for bindings including WebGL, where all methods
are supposed to be set as StrictTypeChecking (see bug 44202 [1]). Due to this restriction,
it relaxed, but I would like to bring it back.

Patch fixes the issue by hardening the way includes are auto-added
for methods where StrictTypeChecking extended attribute is present.
Now, only wrapper types (see IsWrapperType) trigger header inclusion,
excluding arrays, sequences, basic types, etc.

[1] ​https://bugs.webkit.org/show_bug.cgi?id=44202

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):

• bindings/scripts/test/JS/JSTestObj.h:
• bindings/scripts/test/TestObj.idl:

5:28 AM Changeset in webkit [156156] by zarvai@inf.u-szeged.hu

• 17 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Update tests after change to Qt 5.1.1

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-09-20

• platform/qt/css1/text_properties/letter_spacing-expected.png:
• platform/qt/css1/text_properties/letter_spacing-expected.txt:
• platform/qt/fast/css/first-line-text-decoration-expected.png:
• platform/qt/fast/css/first-line-text-decoration-expected.txt:
• platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
• platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
• platform/qt/fast/css/word-space-extra-expected.png:
• platform/qt/fast/css/word-space-extra-expected.txt:
• platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
• platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
• platform/qt/fast/text/basic/003-expected.png:
• platform/qt/fast/text/basic/003-expected.txt:
• platform/qt/fast/text/basic/013-expected.png:
• platform/qt/fast/text/basic/013-expected.txt:
• platform/qt/fast/text/text-letter-spacing-expected.png:
• platform/qt/fast/text/text-letter-spacing-expected.txt:

5:16 AM Changeset in webkit [156155] by akling@apple.com

• 38 edits in trunk/Source/WebCore

Optimize fetching the Node for never-anonymous renderers.
<​https://webkit.org/b/121627>

Reviewed by Antti Koivisto.

Add a RenderObject::nodeForNonAnonymous() that can be used instead
of node() when a renderer is guaranteed non-anonymous.

Use this to implement reference element getters for the various
renderers that are known at compile-time to correspond to a DOM node.

Also renamed existingElement() => element() since using an alternate
name for a reference overload isn't actually necessary.

4:56 AM Changeset in webkit [156154] by Patrick Gansterer

• 7 edits in trunk/Source

Remove duplicated secondsPerDay variables
​https://bugs.webkit.org/show_bug.cgi?id=121601

Reviewed by Andreas Kling.

Source/WebCore:

Use secondsPerDay from DateMath.h instead of defining it again.

• history/HistoryItem.cpp:

(WebCore::timeToDay):

Source/WebKit/win:

Use secondsPerDay from DateMath.h instead of defining it again.

• MarshallingHelpers.cpp:

Source/WTF:

Move secondsPerDay from the source into the header file
to make it accessible by other code too.

• wtf/DateMath.cpp:
• wtf/DateMath.h:

4:54 AM Changeset in webkit [156153] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Fix duplicated loop variable names after r155743
​https://bugs.webkit.org/show_bug.cgi?id=121667

Reviewed by Andreas Kling.

Do not use the same name for variables in nested loops to fix a compiler warning.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

4:51 AM Changeset in webkit [156152] by allan.jensen@digia.com

• 2 edits in trunk/Tools

Update features.pri
​https://bugs.webkit.org/show_bug.cgi?id=121670

Reviewed by Jocelyn Turcotte.

Remove feature flags that no longer exists and new ones added to FeatureList.pm

• qmake/mkspecs/features/features.pri:

4:44 AM Changeset in webkit [156151] by Antti Koivisto

• 27 edits in trunk/Source/WebCore

Make RenderObject::parent() return RenderElement
​https://bugs.webkit.org/show_bug.cgi?id=121671

Reviewed by Andreas Kling.

Make RenderObject::parent() return RenderElement and adopt everywhere.
Moved addChild/removeChild from RenderObject to RenderElement.
Uninlined a few big RenderObject functions.
Renamed RenderObject::remove() -> RenderObject::removeFromParent()

4:32 AM Changeset in webkit [156150] by Csaba Osztrogonác

• 3 edits in trunk/Source/WebCore

Buildfix after r156133 for !ENABLE(WORKERS) platforms
​https://bugs.webkit.org/show_bug.cgi?id=121669

Reviewed by Antti Koivisto.

• platform/ThreadGlobalData.cpp:
• platform/ThreadGlobalData.h:

4:18 AM Changeset in webkit [156149] by commit-queue@webkit.org

• 4 edits in trunk

[GTK][WK2] accessibility/selection-states.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=116972

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

isSelectable() was not exposed in Accessibility.

• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

LayoutTests:

Unskipping accessibility/selection-states.html test.

• platform/gtk-wk2/TestExpectations:

3:58 AM Changeset in webkit [156148] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebKit/win

Add covariant RenderElement* Element::renderer()
​https://bugs.webkit.org/show_bug.cgi?id=121638

Unreviewed buildfix after r156144.

• DOMCoreClasses.cpp:

(DOMElement::boundingBox):
(DOMElement::font):

2:59 AM Changeset in webkit [156147] by Antti Koivisto

• 135 edits in trunk/Source/WebCore

Make createRenderer() return RenderElement
​https://bugs.webkit.org/show_bug.cgi?id=121666

Rubber-stamped by Andreas Kling.

Tighter typing.

2:52 AM Changeset in webkit [156146] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

Buildfix for ENABLE(CSS_FILTERS) && !ENABLE(ACCELERATED_COMPOSITING) after r155131.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::enclosingFilterRepaintLayer):

2:51 AM Changeset in webkit [156145] by Patrick Gansterer

• 2 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header after r154146.

• platform/win/WebCoreBundleWin.cpp:

2:48 AM BadContent edited by zandobersek@gmail.com

Block a spamming account. (diff)

1:59 AM Changeset in webkit [156144] by Antti Koivisto

• 22 edits in trunk/Source/WebCore

Add covariant RenderElement* Element::renderer()
​https://bugs.webkit.org/show_bug.cgi?id=121638

Reviewed by Andreas Kling.

Also add isRenderElement() test and casting functions.

12:34 AM Changeset in webkit [156143] by zarvai@inf.u-szeged.hu

• 5 edits
  1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase tests.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-09-20

• platform/qt-wk2/fast/css/word-space-extra-expected.png: Added r155957.
• platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Rebase after r155957.
• platform/qt/fast/css/pseudo-first-line-border-width-expected.txt: Rebase after r155957.
• platform/qt/fast/css/word-space-extra-expected.txt: Rebase after r155957.
• platform/qt/fast/forms/select-empty-option-height-expected.txt: Rebase after rr156040.