Context Navigation

← Previous Period
Next Period →

Timeline

Sep 26, 2013:

8:26 PM Changeset in webkit [156528] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebCore

Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue()
https://bugs.webkit.org/show_bug.cgi?id=121886

Reviewed by Darin Adler.

toWebKitCSSShaderValue() behavior is different from other to CSSFooValue().
It shouldn't return null. The type checking should be done before doing type cast.

css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

css/WebKitCSSShaderValue.h:

(WebCore::toWebKitCSSShaderValue):

7:02 PM Changeset in webkit [156527] by Antti Koivisto

32 edits in trunk

Move m_style to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121936

Source/WebCore:

Reviewed by Andreas Kling.

Text renderers always have the same style as their parent. They can get their style via the parent pointer
rather than having a member of their own.

This shrinks RenderText by a pointer.

dom/PseudoElement.cpp:

(WebCore::PseudoElement::didRecalcStyle):

Text renderers have no independent style. No need to set it.

editing/ApplyBlockElementCommand.cpp:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):

Avoid getting style from text child before it is added to tree.

(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):

rendering/RenderButton.cpp:

(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::setText):

rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

Don't set text style anymore.

rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::setStyle):

Notify child text renderers of style change.

(WebCore::RenderElement::setAnimatableStyle):
(WebCore::RenderElement::setPseudoStyle):

Push down to RenderElement, remove text branches.

(WebCore::RenderElement::addChild):

Notify text renderers of style change when added to tree.

(WebCore::RenderElement::propagateStyleToAnonymousChildren):

rendering/RenderElement.h:

(WebCore::RenderElement::style):
(WebCore::RenderElement::setStyleInternal):

Move m_style from RenderObject.

(WebCore::RenderObject::style):

Inline this in RenderElement.h instead of making it virtual.

rendering/RenderInline.cpp:

(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::styleDidChange):

Tighten typing to call RenderElement::setStyle.

(WebCore::RenderInline::clippedOverflowRectForRepaint):

Change assert. This can get legitimately called during layout for the first letter renderers.
This was previously avoided by luck.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::styleDidChange):
(WebCore::RenderMenuList::setText):

Don't set text style anymore.

rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::hasEntirelyFixedBackground):
(WebCore::RenderObject::container):
(WebCore::RenderObject::cachedFirstLineStyle):

Switch to style(), avoid unnecessary repetition.
Move code out.

rendering/RenderObject.h:

Move functions to RenderElement.

(WebCore::RenderObject::isBeforeContent):
(WebCore::RenderObject::isAfterContent):

Avoid accessing style for text renderers as these are called before the renderer
is added to tree.

(WebCore::RenderObject::setNeedsPositionedMovementLayout):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::setObjectStyleInRegion):

rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::updateCancelButtonVisibility):

rendering/RenderText.cpp:
rendering/RenderText.h:

Remove setStyle.

(WebCore::RenderText::style):

Get style from parent.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):

rendering/style/ContentData.cpp:

(WebCore::TextContentData::createRenderer):
(WebCore::CounterContentData::createRenderer):
(WebCore::QuoteContentData::createRenderer):

Pseudo style for RenderText subclasses comes from parent without any explicit setting.

style/StyleResolveTree.cpp:

(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::resolveLocal):
(WebCore::Style::updateTextStyle):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):

No need to set or update text renderer style separately.

LayoutTests:

Reviewed by Andreas Kling.

Progressions from text style updating correctly in all cases.

compositing/contents-opaque/hidden-with-visible-text-expected.txt:
compositing/contents-opaque/visibility-hidden-expected.txt:

Can't figure out why these progress but they do. The new rendering (showing nothing)
is correct and matches Firefox.

platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
platform/mac/svg/custom/getTransformToElement-expected.txt:
platform/mac/svg/custom/text-ctm-expected.txt:
platform/mac/svg/custom/text-hit-test-expected.txt:
platform/mac/svg/text/append-text-node-to-tspan-expected.txt:

6:58 PM Changeset in webkit [156526] by andersca@apple.com

2 edits in trunk/Source/WTF

"Build fix".

We can't use std::move. Explicitly destroy the old value and then construct the new in place.

wtf/HashTable.h:

6:56 PM Changeset in webkit [156525] by ggaren@apple.com

5 edits in trunk

Fixed a version number string in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122004

Reviewed by Gavin Barraclough.

PerformanceTests/SunSpider:

resources/driver-TEMPLATE.html:
resources/results-TEMPLATE.html: 1.0.2!

Websites/webkit.org:

perf/sunspider-1.0.2/sunspider-1.0.2/results.html: 1.0.2!

6:51 PM Changeset in webkit [156524] by andersca@apple.com

2 edits in trunk/Source/WTF

Use the move assignment operator when reinserting values in the hash map
https://bugs.webkit.org/show_bug.cgi?id=122003

Reviewed by Alexey Proskuryakov.

Using the move assignment operator ensures that the existing values will be destroyed correctly.

wtf/HashTable.h:

6:46 PM Changeset in webkit [156523] by ggaren@apple.com

4 edits
39 adds in trunk

Tentative SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122002

Reviewed by Gavin Barraclough.

PerformanceTests/SunSpider:

Be even more aggressive about asking for zero delay between tests by
setting a timeout at the beginning of a test instead of the end. This is
another step toward reducing noise -- particularly noise caused by
power management -- just like the step down from 10ms to 0ms.

Browsers typically put a 4ms floor on timers. The sooner we set
our timer, the sooner it will fire.

make-hosted:
resources/driver-TEMPLATE.html: Changed the driver to set the timeout

earlier.

tests/sunspider-1.0.2: Added. These tests are unchanged from 1.0.1.

Websites/webkit.org:

See comments in PerformanceTests/SunSpider.

perf/sunspider-1.0.2: Added.

6:08 PM Changeset in webkit [156522] by eric.carlson@apple.com

29 edits
4 adds in trunk

[MediaStream] make MediaStream testable
https://bugs.webkit.org/show_bug.cgi?id=121967

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing tests updated.

CMakeLists.txt: Add MockMediaStreamCenter.
GNUmakefile.list.am: Ditto.

Modules/mediastream/MediaStreamTrack.idl: Add SkipVTableValidation.
Modules/mediastream/NavigatorUserMediaError.idl: Add JSGenerateToJSObject.
WebCore.exp.in: Export MockMediaStreamCenter::registerMockMediaStreamCenter.

WebCore.xcodeproj/project.pbxproj: Add MockMediaStreamCenter.
dom/DOMError.h: Make the destructor virtual because it has a derived class.
dom/DOMError.idl:

platform/mock/MockMediaStreamCenter.cpp: Added.
platform/mock/MockMediaStreamCenter.h: Added.

testing/Internals.cpp: Register the mock stream center.

Source/WebKit:

WebKit.xcodeproj/project.pbxproj: Add WebUserMediaClient.

Source/WebKit/mac:

WebCoreSupport/WebUserMediaClient.h: Added.
WebCoreSupport/WebUserMediaClient.mm: Added.

WebView/WebUIDelegatePrivate.h: Declare decidePolicyForUserMediaRequestFromOrigin:listener:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]): Register WebUserMediaClient.
(-[WebView _setUserMediaClient:]): New.
(-[WebView _userMediaClient]): New.

WebView/WebViewData.h:
WebView/WebViewPrivate.h:

Tools:

DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive

user media request policy delegate.

LayoutTests:

fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
fast/mediastream/MediaStream-add-remove-tracks.html: Make the test results more understandable

to simplify debugging failures.

fast/mediastream/MediaStream-onended-expected.txt:
fast/mediastream/MediaStream-onended.html: Ditto. Fix a test error: stopping stream A should

not stop stream B even when it was created from stream A.

fast/mediastream/MediaStreamConstructor-expected.txt:
fast/mediastream/MediaStreamConstructor.html: Make the test results more understandable. Fix a

logic errors: webkitMediaStream is an object, not a function. JSC does not support
object.constructor.name, use object.constructor.toString() instead.

fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
fast/mediastream/MediaStreamTrackEvent-constructor.html: Update now that getUserMedia() works.
fast/mediastream/argument-types-expected.txt: Updated with "Failing" results because the correct

behavior is unknown. The spec says "the syntax for getUserMedia() is still under discussion".

5:39 PM Changeset in webkit [156521] by akling@apple.com

8 edits in trunk/Source/JavaScriptCore

GetterSetter construction should take a VM instead of ExecState.
<https://webkit.org/b/121993>

Reviewed by Sam Weinig.

Pass VM& instead of ExecState* to GetterSetter. Updated surrounding
code at touched sites to cache VM in a local for fewer loads.

JSC release binary size -= 4120 bytes.

5:27 PM Changeset in webkit [156520] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: dissociate old content views that are spliced from back/forward list
https://bugs.webkit.org/show_bug.cgi?id=121987

Patch by Brian J. Burg <Brian Burg> on 2013-09-26
Reviewed by Timothy Hatcher.

There was a bug where old back/forward list entries were not being dissociated when
the newly-shown content view was already in the list. Instead, dissociation should be
skipped if the old list entry is not already in the list.

UserInterface/ContentViewContainer.js:

(WebInspector.ContentViewContainer.prototype.showContentView):

5:27 PM Changeset in webkit [156519] by ap@apple.com

2 edits in trunk/LayoutTests

Layout Test http/tests/inspector/network/network-iframe-load-and-delete.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121998

platform/mac/TestExpectations: Marking as such.

5:23 PM Changeset in webkit [156518] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Make GCC happy

4:51 PM Changeset in webkit [156517] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Windows] Unreviewed Build fix.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing

symbol export to support tests.

4:37 PM Changeset in webkit [156516] by Brent Fulgham

2 edits in trunk/Source/WTF

[Windows] Work around missing C++11 features of MSVC by providing an implementation for
std::is_trivially_destructible based on the existing std::has_trivial_destructor.

Rubber-stamped by Anders Carlsson.

wtf/StdLibExtras.h: Add implementation for is_trivially_destructable for MSVC 2010 and prior.

4:36 PM Changeset in webkit [156515] by benjamin@webkit.org

5 edits in trunk/Source/WebCore

Move CSS MatchRequest from StyleResolver to a private definition in ElementRuleCollector
https://bugs.webkit.org/show_bug.cgi?id=121986

Reviewed by Andreas Kling.

MatchRequest is an internal type of ElementRuleCollector now, move the definition
to ElementRuleCollector.

css/DocumentRuleSets.h:
css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::MatchRequest::MatchRequest):

css/StyleResolver.h:

4:32 PM Changeset in webkit [156514] by oliver@apple.com

19 edits
12 adds in trunk

2013-09-25 Oliver Hunt <oliver@apple.com>

Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930

Reviewed by Mark Hahnenberg.

Relanding with fix after rollout

4:16 PM Changeset in webkit [156513] by Brent Fulgham

4 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix after r156487.

Add explicit casting needed by MSVC to compile this code. Much
of this could probably be removed when we move to VS2012 or newer.

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::createRuntimeObject):

4:00 PM Changeset in webkit [156512] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Unreviewed, rolling out r156510.
http://trac.webkit.org/changeset/156510
https://bugs.webkit.org/show_bug.cgi?id=121989

Landed in-progress code along with build fix. (Requested by
bfulgham on #webkit).

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::createRuntimeObject):

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):

platform/graphics/win/DIBPixelData.cpp:

(WebCore::DIBPixelData::writeToFile):

platform/graphics/win/DIBPixelData.h:

3:53 PM Changeset in webkit [156511] by msaboff@apple.com

68 edits in trunk/Source/JavaScriptCore

VirtualRegister should be a class
https://bugs.webkit.org/show_bug.cgi?id=121732

Reviewed by Geoffrey Garen.

This is a refactoring change. Changed VirtualRegister from an enum to a class.
Moved Operands::operandIsArgument(), operandToArgument(), argumentToOperand()
and the similar functions for locals to VirtualRegister class.

This is in preparation for changing the offset for the first local register from
0 to -1. This is needed since most native calling conventions have the architected
frame pointer (e.g. %rbp for X86) point at the slot that stores the previous frame
pointer. Local values start below that address.

bytecode/CodeBlock.cpp:
bytecode/CodeBlock.h:
bytecode/Instruction.h:
bytecode/LazyOperandValueProfile.h:
bytecode/MethodOfGettingAValueProfile.cpp:
bytecode/Operands.h:
bytecode/UnlinkedCodeBlock.cpp:
bytecode/UnlinkedCodeBlock.h:
bytecode/ValueRecovery.h:
bytecode/VirtualRegister.h:
bytecompiler/BytecodeGenerator.cpp:
bytecompiler/BytecodeGenerator.h:
bytecompiler/RegisterID.h:
debugger/DebuggerCallFrame.cpp:
dfg/DFGAbstractHeap.h:
dfg/DFGAbstractInterpreterInlines.h:
dfg/DFGArgumentPosition.h:
dfg/DFGArgumentsSimplificationPhase.cpp:
dfg/DFGByteCodeParser.cpp:
dfg/DFGCFGSimplificationPhase.cpp:
dfg/DFGCPSRethreadingPhase.cpp:
dfg/DFGCapabilities.cpp:
dfg/DFGConstantFoldingPhase.cpp:
dfg/DFGFlushLivenessAnalysisPhase.cpp:
dfg/DFGGraph.cpp:
dfg/DFGGraph.h:
dfg/DFGJITCode.cpp:
dfg/DFGNode.h:
dfg/DFGOSREntry.cpp:
dfg/DFGOSREntrypointCreationPhase.cpp:
dfg/DFGOSRExit.h:
dfg/DFGOSRExitCompiler32_64.cpp:
dfg/DFGOSRExitCompiler64.cpp:
dfg/DFGRegisterBank.h:
dfg/DFGScoreBoard.h:
dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:
dfg/DFGSpeculativeJIT64.cpp:
dfg/DFGValidate.cpp:
dfg/DFGValueRecoveryOverride.h:
dfg/DFGVariableAccessData.h:
dfg/DFGVariableEvent.h:
dfg/DFGVariableEventStream.cpp:
dfg/DFGVirtualRegisterAllocationPhase.cpp:
ftl/FTLExitArgumentForOperand.h:
ftl/FTLLink.cpp:
ftl/FTLLowerDFGToLLVM.cpp:
ftl/FTLOSREntry.cpp:
ftl/FTLOSRExit.cpp:
ftl/FTLOSRExit.h:
ftl/FTLOSRExitCompiler.cpp:
interpreter/CallFrame.h:
interpreter/Interpreter.cpp:
jit/AssemblyHelpers.h:
jit/JIT.h:
jit/JITCall.cpp:
jit/JITCall32_64.cpp:
jit/JITInlines.h:
jit/JITOpcodes.cpp:
jit/JITOpcodes32_64.cpp:
jit/JITPropertyAccess32_64.cpp:
jit/JITStubs.cpp:
llint/LLIntSlowPaths.cpp:
profiler/ProfilerBytecodeSequence.cpp:
runtime/CommonSlowPaths.cpp:
runtime/JSActivation.cpp:

3:49 PM Changeset in webkit [156510] by Brent Fulgham

7 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix after r156487.

Add explicit casting needed by MSVC to compile this code. Much
of this could probably be removed when we move to VS2012 or newer.

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::createRuntimeObject):

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):

platform/graphics/win/DIBPixelData.cpp:

(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::writeToFile):

platform/graphics/win/DIBPixelData.h:

3:47 PM Changeset in webkit [156509] by ap@apple.com

2 edits in trunk/LayoutTests

Flaky Test: transitions/cancel-transition.html
https://bugs.webkit.org/show_bug.cgi?id=114193

platform/mac/TestExpectations: Marking as flaky. Dean says that such tests are

currently broken by design.

3:45 PM Changeset in webkit [156508] by andersca@apple.com

8 edits
2 deletes in trunk/Source/WebKit2

Remove Windows code
https://bugs.webkit.org/show_bug.cgi?id=121988

Reviewed by Antti Koivisto.

Platform/CoreIPC/Connection.h:
Platform/CoreIPC/win/ConnectionWin.cpp: Removed.
Platform/SharedMemory.h:
Platform/WorkQueue.h:
Platform/win/SharedMemoryWin.cpp: Removed.
Platform/win/WorkQueueWin.cpp: Removed.
Shared/ChildProcess.cpp:
Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPluginsIfNecessary):

WebProcess/WebProcess.cpp:

3:37 PM Changeset in webkit [156507] by andersca@apple.com

5 edits in trunk/Source/WTF

Remove needsDestruction from vector and hash traits
https://bugs.webkit.org/show_bug.cgi?id=121983

Reviewed by Sam Weinig.

For Vector, use std::is_trivially_destructible to determine whether to call the destructor.
For HashTable, always call the destructor; if it is trivial then no code will be generated for it and the loops will be folded away.

Removing this does break the ability to store objects with non-trivial destructors in vectors and hash maps
and have their destructors not be called when removed, but we've never used this feature in WebKit so the extra
code complexity is not worth it.

wtf/HashTable.h:

(WTF::::deallocateTable):

wtf/HashTraits.h:
wtf/Vector.h:

(WTF::VectorTypeOperations::destruct):

wtf/VectorTraits.h:

3:29 PM Changeset in webkit [156506] by dino@apple.com

6 edits
2 adds in trunk

Expose a setting to disable hardware accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=121978
<rdar://problem/15091284>

Reviewed by Eric Carlson.

Source/WebCore:

Expose acceleratedCompositedAnimationsEnabled
to disable CoreAnimation animations.

Test: LayoutTests/animations/transform-non-accelerated.html

WebCore.exp.in: Export new method.
page/Settings.in: Add new setting.
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation): Don't go
to GraphicsLayer if the setting is false.

LayoutTests:

animations/resources/animation-test-helpers.js: Add a callback

for when the tests finish. Minor cleanup.
(endTest):
(.else):
(runAnimationTest):

animations/transform-non-accelerated.html: New test.
animations/transform-non-accelerated-expected.txt: Result.

3:25 PM Changeset in webkit [156505] by andersca@apple.com

4 edits in trunk/Source

Source/JavaScriptCore: Work around another MSVC bug.

runtime/PrototypeMap.cpp:

(JSC::PrototypeMap::emptyObjectStructureForPrototype):

Source/WTF: Build fixes.

Fix a paste-o.

wtf/StdLibExtras.h:

(std::make_unique):

3:20 PM Changeset in webkit [156504] by andersca@apple.com

2 edits in trunk/Source/JavaScriptCore

Attempt to fix the FTL build.

ftl/FTLAbstractHeap.cpp:

(JSC::FTL::IndexedAbstractHeap::atSlow):

3:19 PM Changeset in webkit [156503] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Fix build after r156487.
https://bugs.webkit.org/show_bug.cgi?id=121984

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Anders Carlsson.

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::jsObjectRef):

3:15 PM Changeset in webkit [156502] by Lucas Forschler

2 edits in branches/safari-537.60-branch/Source/WebKit/win

Merged r156433. <rdar://problem/15092137>

3:13 PM Changeset in webkit [156501] by Lucas Forschler

5 edits in branches/safari-537.60-branch/Source

Merged r156416. <rdar://problem/15092135>

3:01 PM Changeset in webkit [156500] by Antti Koivisto

4 edits in trunk/Source/WebCore

Don't mutate style in RenderCombineText
https://bugs.webkit.org/show_bug.cgi?id=121979

Reviewed by Andreas Kling.

Text renderers should always have the same style as the parent.

rendering/InlineTextBox.cpp:

(WebCore::fontToUse):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

Select the modified font for text-combine.

rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):
(WebCore::RenderCombineText::combineText):

rendering/RenderCombineText.h:

Move the text-combine specific font style to a member of its own.

2:45 PM Changeset in webkit [156499] by timothy@apple.com

26 edits in trunk/Source/WebCore/bindings/scripts/test/JS

Update expected binding test results after r156498.

2:43 PM Changeset in webkit [156498] by akling@apple.com

56 edits in trunk/Source/JavaScriptCore

Pass VM instead of ExecState to many finishCreation() functions.
<https://webkit.org/b/121975>

Reviewed by Sam Weinig.

Reduce unnecessary loads by passing the VM to object creation
functions that don't need the ExecState.

There are tons of opportunities in this area, I'm just scratching
the surface.

2:27 PM Changeset in webkit [156497] by commit-queue@webkit.org

19 edits
12 deletes in trunk

Unreviewed, rolling out r156464 and r156480.
http://trac.webkit.org/changeset/156464
http://trac.webkit.org/changeset/156480
https://bugs.webkit.org/show_bug.cgi?id=121981

Leaking too much and killi
ng buildbot. (Requested by xenon on
#webkit).

Source/JavaScriptCore:

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::paramString):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitExpressionInfo):

bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitBytecode):
(JSC::FuncExprNode::emitBytecode):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):

parser/NodeConstructors.h:

(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):

parser/Nodes.cpp:

(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):

parser/Nodes.h:

(JSC::CommaNode::append):
(JSC::ParameterNode::ident):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):

parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):

parser/Parser.h:

(JSC::Scope::declareParameter):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::operatorStackPop):

runtime/JSONObject.cpp:
runtime/JSONObject.h:

LayoutTests:

js/destructuring-assignment-expected.txt: Removed.
js/destructuring-assignment.html: Removed.
js/mozilla/strict/13.1-expected.txt:
js/mozilla/strict/regress-532254-expected.txt:
js/mozilla/strict/script-tests/13.1.js:
js/regress/destructuring-arguments-expected.txt: Removed.
js/regress/destructuring-arguments-length-expected.txt: Removed.
js/regress/destructuring-arguments-length.html: Removed.
js/regress/destructuring-arguments.html: Removed.
js/regress/destructuring-swap-expected.txt: Removed.
js/regress/destructuring-swap.html: Removed.
js/regress/script-tests/destructuring-arguments-length.js: Removed.
js/regress/script-tests/destructuring-arguments.js: Removed.
js/regress/script-tests/destructuring-swap.js: Removed.
js/script-tests/destructuring-assignment.js: Removed.
sputnik/Conformance/13_Function_Definition/S13_A5.html:

2:25 PM Changeset in webkit [156496] by andersca@apple.com

2 edits in trunk/Source/WTF

Remove the hash table mover
https://bugs.webkit.org/show_bug.cgi?id=121980

Reviewed by Andreas Kling.

Use std::move instead.

wtf/HashTable.h:

2:07 PM Changeset in webkit [156495] by ap@apple.com

3 edits
1 copy
1 add in trunk/LayoutTests

Layout Test plugins/access-after-page-destroyed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121976

Reviewed by Anders Carlsson.

Clean up the test.

plugins/access-after-page-destroyed-2-expected.txt: Added.
plugins/access-after-page-destroyed-2.html: Copied from LayoutTests/plugins/access-after-page-destroyed.html.

This was testing two distinct issues, the second one unfittingly piled onto the first.
Split the test in two.

plugins/access-after-page-destroyed-expected.txt:
plugins/access-after-page-destroyed.html:

Modernized the test with js-test scripts, added a gc() call for predictability,
changed the test to fail quickly in the flaky case.

1:59 PM Changeset in webkit [156494] by andersca@apple.com

3 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

jit/JITThunks.cpp:

(JSC::JITThunks::hostFunctionStub):

jit/JITThunks.h:

1:54 PM Changeset in webkit [156493] by commit-queue@webkit.org

2 edits in trunk/Tools

build-webkit --inspector-frontend should copy WebInspectorUI files
https://bugs.webkit.org/show_bug.cgi?id=117851

Patch by Brian J. Burg <Brian Burg> on 2013-09-26
Reviewed by Joseph Pecoraro.

Change the --inspector-frontend build option to additionally build/copy
WebInspectorUI by setting it as the only project that needs to be built.

Scripts/build-webkit:

1:44 PM Changeset in webkit [156492] by andersca@apple.com

15 edits in trunk/Source

Change a couple of HashMap value types from OwnPtr to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=121973

Reviewed by Andreas Kling.

Source/JavaScriptCore:

API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):

API/JSClassRef.h:
bytecode/SamplingTool.h:
ftl/FTLAbstractHeap.h:
parser/Parser.cpp:

(JSC::::parseFunctionInfo):

parser/SourceProviderCache.cpp:

(JSC::SourceProviderCache::add):

parser/SourceProviderCache.h:
parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::create):

profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::executionCounterFor):
(JSC::Profiler::Compilation::toJS):

profiler/ProfilerCompilation.h:
runtime/JSGlobalObject.h:

Source/WTF:

wtf/RefPtrHashMap.h:

Add a missing std::forward.

wtf/StdLibExtras.h:

(std::make_unique):
Add more overloads.

1:32 PM Changeset in webkit [156491] by Lucas Forschler

4 edits
2 copies in tags/Safari-538.1

Merged r156404. <rdar://problem/15081686>

1:27 PM Changeset in webkit [156490] by mark.lam@apple.com

29 edits
7 copies
4 deletes in trunk/Source/JavaScriptCore

Move DFG inline caching logic into jit/.
https://bugs.webkit.org/show_bug.cgi?id=121749.

Reviewed by Geoffrey Garen.

Relanding http://trac.webkit.org/changeset/156235 after rebasing to latest
revision and fixing build breakages on Windows.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):

bytecode/StructureStubInfo.h:
dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):

dfg/DFGJITCompiler.h:
dfg/DFGOSRExitCompiler.h:
dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

dfg/DFGOperations.h:

(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):

dfg/DFGRegisterSet.h: Removed.
dfg/DFGRepatch.cpp: Removed.
dfg/DFGRepatch.h: Removed.
dfg/DFGScratchRegisterAllocator.h: Removed.
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

dfg/DFGThunks.cpp:
dfg/DFGThunks.h:
ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):

ftl/FTLOSRExitCompiler.h:
jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::writeBarrier):

jit/JIT.cpp:

(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):

jit/JITCall.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):

jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):

jit/JITOperationWrappers.h: Copied from Source/JavaScriptCore/jit/JITOperationWrappers.h.
jit/JITOperations.cpp: Copied from Source/JavaScriptCore/jit/JITOperations.cpp.

(JSC::getHostCallReturnValueWithExecState):

jit/JITOperations.h: Copied from Source/JavaScriptCore/jit/JITOperations.h.
jit/RegisterSet.h: Copied from Source/JavaScriptCore/jit/RegisterSet.h.
jit/Repatch.cpp: Copied from Source/JavaScriptCore/jit/Repatch.cpp.

(JSC::tryBuildGetByIDList):

jit/Repatch.h: Copied from Source/JavaScriptCore/jit/Repatch.h.
jit/ScratchRegisterAllocator.h: Copied from Source/JavaScriptCore/jit/ScratchRegisterAllocator.h.
jit/ThunkGenerators.cpp:

(JSC::oldStyleGenerateSlowCaseFor):
(JSC::oldStyleLinkForGenerator):
(JSC::oldStyleLinkCallGenerator):
(JSC::oldStyleLinkConstructGenerator):
(JSC::oldStyleLinkClosureCallGenerator):
(JSC::oldStyleVirtualForGenerator):
(JSC::oldStyleVirtualCallGenerator):
(JSC::oldStyleVirtualConstructGenerator):
(JSC::emitPointerValidation):
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::linkForThunkGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkConstructThunkGenerator):
(JSC::linkClosureCallThunkGenerator):
(JSC::virtualForThunkGenerator):
(JSC::virtualCallThunkGenerator):
(JSC::virtualConstructThunkGenerator):

jit/ThunkGenerators.h:

12:48 PM Changeset in webkit [156489] by andersca@apple.com

7 edits
2 deletes in trunk/Source

Remove PassWeak.h
https://bugs.webkit.org/show_bug.cgi?id=121971

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/PassWeak.h: Removed.
heap/WeakInlines.h:

Source/WebCore:

ForwardingHeaders/heap/PassWeak.h: Removed.

12:37 PM Changeset in webkit [156488] by eric.carlson@apple.com

8 edits
6 adds in trunk/Source/WebCore

[MediaStream API] implement VideoStreamTrack and AudioStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=121950

Reviewed by Dean Jackson.

No new tests, blocked by https://bugs.webkit.org/show_bug.cgi?id=121967

CMakeLists.txt: Add new files.
DerivedSources.make: Ditto.
GNUmakefile.list.am: Ditto.

Modules/mediastream/AudioStreamTrack.cpp: Added.
Modules/mediastream/AudioStreamTrack.h: Added.
Modules/mediastream/AudioStreamTrack.idl: Added.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream): Create an AudioStreamTrack or a VideoStreamTrack.
(WebCore::MediaStream::addRemoteSource): Ditto.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create): Removed.

Modules/mediastream/MediaStreamTrack.h:

Modules/mediastream/VideoStreamTrack.cpp: Added.
Modules/mediastream/VideoStreamTrack.h: Added.
Modules/mediastream/VideoStreamTrack.idl: Added.

WebCore.xcodeproj/project.pbxproj: Add new files.

12:23 PM Changeset in webkit [156487] by andersca@apple.com

19 edits in trunk/Source

Stop using PassWeak
https://bugs.webkit.org/show_bug.cgi?id=121968

Reviewed by Sam Weinig.

Source/JavaScriptCore:

heap/Weak.h:

Remove all knowledge of PassWeak.

(JSC::Weak::Weak):
These constructors don't need to be explicit.

heap/WeakInlines.h:

(JSC::weakAdd):
Change Value to be an rvalue reference and use std::forward.

jit/JITThunks.cpp:

(JSC::JITThunks::hostFunctionStub):
Remove PassWeak.

runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
Use Weak instead of PassWeak.

runtime/SimpleTypedArrayController.cpp:

Change add and set to take Weak by value and std::move into place.

runtime/WeakGCMap.h:

(JSC::WeakGCMap::get):
(JSC::WeakGCMap::set):
(JSC::WeakGCMap::add):

Source/WebCore:

Update for JavaScriptCore changes.

bindings/js/JSDOMBinding.h:

(WebCore::setInlineCachedWrapper):
(WebCore::cacheWrapper):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

bindings/js/JSEventListener.h:

(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):

bindings/js/JSMutationCallback.cpp:

(WebCore::JSMutationCallback::JSMutationCallback):

bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):

bindings/js/ScriptWrappableInlines.h:

(WebCore::ScriptWrappable::setWrapper):

bindings/js/WebCoreTypedArrayController.cpp:
bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::createRuntimeObject):

bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::addRuntimeObject):

Source/WebKit2:

Update for JavaScriptCore changes.

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):

12:14 PM Changeset in webkit [156486] by ap@apple.com

2 edits in trunk/LayoutTests

fast/css/font-face-data-uri.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82744

Reviewed by Dan Bernstein.

fast/css/font-face-data-uri.html: There is no need to keep retrying, we can just

wait for onload - as long as the font load starts early enough.

12:09 PM Changeset in webkit [156485] by weinig@apple.com

28 edits in trunk/Source

Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState*
https://bugs.webkit.org/show_bug.cgi?id=121934

Reviewed by Geoffrey Garen.

../WebCore:

Reduce unnecessary loads by passing the JSC::VM to object creation/access functions
that don't need the ExecState.

WebCore.exp.in:
bindings/js/JSDOMBinding.h:

(WebCore::getDOMStructure):
(WebCore::deprecatedGetDOMStructure):
(WebCore::getDOMPrototype):
(WebCore::setInlineCachedWrapper):
(WebCore::createWrapper):

bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::image):

bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::location):

bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::finishCreation):

bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::create):

bindings/js/ScriptWrappable.h:
bindings/js/ScriptWrappableInlines.h:

(WebCore::ScriptWrappable::setWrapper):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):

bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):
(JSC::Bindings::CRuntimeObject::finishCreation):

bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::newRuntimeObject):

bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Instance::newRuntimeObject):

bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
(JSC::Bindings::ObjCRuntimeObject::finishCreation):

bridge/objc/objc_instance.mm:

(ObjcInstance::newRuntimeObject):

bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::createPrototype):

bridge/runtime_array.h:

(JSC::RuntimeArray::createPrototype):

bridge/runtime_method.h:

(JSC::RuntimeMethod::createPrototype):

bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):

bridge/runtime_object.h:

(JSC::Bindings::RuntimeObject::create):
(JSC::Bindings::RuntimeObject::createPrototype):

../WebKit/mac:

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::newRuntimeObject):

Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
(WebKit::ProxyRuntimeObject::finishCreation):

11:59 AM Changeset in webkit [156484] by Lucas Forschler

1 copy in tags/Safari-538.1

New Tag.

11:40 AM Changeset in webkit [156483] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Activity viewer not properly reset when reloading
https://bugs.webkit.org/show_bug.cgi?id=121958

Reviewed by Darin Adler.

Reset the resources count and accumulated size when we detect the main frame
has changed, which will work with documents where there are no resources besides
frames in which case WebInspector.Frame.Event.AllResourcesRemoved was not fired
and our counts wouldn't be reset correctly.

UserInterface/DashboardManager.js:

(WebInspector.DashboardManager):
(WebInspector.DashboardManager.prototype._mainResourceDidChange):

11:31 AM Changeset in webkit [156482] by commit-queue@webkit.org

65 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r156474.
http://trac.webkit.org/changeset/156474
https://bugs.webkit.org/show_bug.cgi?id=121966

Broke the builds. (Requested by xenon on #webkit).

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::registerName):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::createActivation):
(JSC::CodeBlock::nameForRegister):

bytecode/CodeBlock.h:

(JSC::unmodifiedArgumentsRegister):
(JSC::CodeBlock::isKnownNotImmediate):
(JSC::CodeBlock::setThisRegister):
(JSC::CodeBlock::thisRegister):
(JSC::CodeBlock::setArgumentsRegister):
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::uncheckedArgumentsRegister):
(JSC::CodeBlock::setActivationRegister):
(JSC::CodeBlock::activationRegister):
(JSC::CodeBlock::uncheckedActivationRegister):
(JSC::CodeBlock::usesArguments):
(JSC::CodeBlock::isCaptured):

bytecode/Instruction.h:
bytecode/LazyOperandValueProfile.h:

(JSC::LazyOperandValueProfileKey::LazyOperandValueProfileKey):
(JSC::LazyOperandValueProfileKey::operator!):
(JSC::LazyOperandValueProfileKey::hash):
(JSC::LazyOperandValueProfileKey::operand):
(JSC::LazyOperandValueProfileKey::isHashTableDeletedValue):
(JSC::LazyOperandValueProfile::LazyOperandValueProfile):

bytecode/MethodOfGettingAValueProfile.cpp:

(JSC::MethodOfGettingAValueProfile::fromLazyOperand):
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket):

bytecode/Operands.h:

(JSC::localToOperand):
(JSC::operandIsLocal):
(JSC::operandToLocal):
(JSC::operandIsArgument):
(JSC::operandToArgument):
(JSC::argumentToOperand):
(JSC::Operands::operand):
(JSC::Operands::hasOperand):
(JSC::Operands::setOperand):
(JSC::Operands::operandForIndex):
(JSC::Operands::setOperandFirstTime):

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::setThisRegister):
(JSC::UnlinkedCodeBlock::setActivationRegister):
(JSC::UnlinkedCodeBlock::setArgumentsRegister):
(JSC::UnlinkedCodeBlock::usesArguments):
(JSC::UnlinkedCodeBlock::argumentsRegister):
(JSC::UnlinkedCodeBlock::usesGlobalObject):
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister):
(JSC::UnlinkedCodeBlock::globalObjectRegister):
(JSC::UnlinkedCodeBlock::thisRegister):
(JSC::UnlinkedCodeBlock::activationRegister):

bytecode/ValueRecovery.h:

(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):

bytecode/VirtualRegister.h:

(WTF::printInternal):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::newRegister):
(JSC::BytecodeGenerator::emitLoadGlobalObject):
(JSC::BytecodeGenerator::emitGetArgumentsLength):
(JSC::BytecodeGenerator::emitGetArgumentByVal):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):
(JSC::BytecodeGenerator::emitReturn):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::registerFor):

bytecompiler/RegisterID.h:

(JSC::RegisterID::RegisterID):
(JSC::RegisterID::setIndex):
(JSC::RegisterID::index):

debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::thisObject):

dfg/DFGAbstractHeap.h:

(JSC::DFG::AbstractHeap::Payload::Payload):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):
(JSC::DFG::::clobberCapturedVars):

dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::dump):

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::findArgumentPosition):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGCFGSimplificationPhase.cpp:
dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::isCapturedAtOrAfter):

dfg/DFGFlushLivenessAnalysisPhase.cpp:

(JSC::DFG::FlushLivenessAnalysisPhase::setForNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGGraph.h:

(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::uncheckedActivationRegisterFor):
(JSC::DFG::Graph::valueProfileFor):

dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):

dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

dfg/DFGOSRExit.h:
dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::tryAllocate):
(JSC::DFG::RegisterBank::allocateSpecific):
(JSC::DFG::RegisterBank::retain):
(JSC::DFG::RegisterBank::isInUse):
(JSC::DFG::RegisterBank::dump):
(JSC::DFG::RegisterBank::releaseAtIndex):
(JSC::DFG::RegisterBank::allocateInternal):
(JSC::DFG::RegisterBank::MapEntry::MapEntry):

dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
(JSC::DFG::SpeculativeJIT::valueSourceForOperand):
(JSC::DFG::SpeculativeJIT::setNodeForOperand):
(JSC::DFG::SpeculativeJIT::valueSourceReferenceForOperand):
(JSC::DFG::SpeculativeJIT::recordSetLocal):
(JSC::DFG::SpeculativeJIT::generationInfoFromVirtualRegister):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::validateCPS):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):

dfg/DFGValueRecoveryOverride.h:

(JSC::DFG::ValueRecoveryOverride::ValueRecoveryOverride):

dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::operand):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::flushFormat):

dfg/DFGVariableEvent.h:

(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::setLocal):

dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

ftl/FTLExitArgumentForOperand.h:

(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::operand):

ftl/FTLLink.cpp:

(JSC::FTL::link):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileExtractOSREntryLocal):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):

ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExit::convertToForward):

ftl/FTLOSRExit.h:
ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

interpreter/CallFrame.h:
interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::addressFor):
(JSC::AssemblyHelpers::tagFor):
(JSC::AssemblyHelpers::payloadFor):
(JSC::AssemblyHelpers::argumentsRegisterFor):

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

jit/JITInlines.h:

(JSC::JIT::emitGetVirtualRegister):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_enter):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::BytecodeSequence):

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/JSActivation.cpp:

(JSC::JSActivation::argumentsGetter):

11:29 AM Changeset in webkit [156481] by Antoine Quint

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Keep DOM tree expanded on page reload
https://bugs.webkit.org/show_bug.cgi?id=121665

Reviewed by Darin Adler.

Allow the node that was selected before reloading the page to be selected
at the page is reloaded. Credit goes to Joseph Pecoraro for the fix.

UserInterface/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView.prototype._rootDOMNodeAvailable.selectNode):

11:13 AM Changeset in webkit [156480] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

Attempt to fix MSVC build

11:13 AM Changeset in webkit [156479] by jer.noble@apple.com

4 edits in trunk/Source/WebKit2

[WK2] Crash at at com.apple.WebKit2: WebKit::VoidCallback::invalidate + 46
https://bugs.webkit.org/show_bug.cgi?id=121910

Reviewed by Darin Adler.

Store a copy of the VoidCallback passed to WKPage, and invalidate the callback
during dealloc. The VoidCallback class assumes that it will only ever be
invalidated or invoked once, so change the ASSERTs into an early return.

UIProcess/GenericCallback.h:

(WebKit::VoidCallback::performCallback): Exit early if previously invalidated.
(WebKit::VoidCallback::invalidate): Ditto.

UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController dealloc]): Invalidate the repaint callback if present.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Ditto & create a new callback.
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]): Clear the callback.

11:13 AM Changeset in webkit [156478] by commit-queue@webkit.org

20 edits
1 delete in trunk

Unreviewed, rolling out r156451.
http://trac.webkit.org/changeset/156451
https://bugs.webkit.org/show_bug.cgi?id=121965

Broke two fast/multicol tests. (Requested by kling on
#webkit).

Source/WebCore:

rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):

rendering/RenderElement.cpp:

(WebCore::RenderElement::propagateStyleToAnonymousChildren):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::updateRegionForRenderLayer):
(WebCore::RenderFlowThread::updateLayerToRegionMappings):

rendering/RenderFlowThread.h:
rendering/RenderGeometryMap.cpp:
rendering/RenderGeometryMap.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateLayerBounds):

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):

rendering/RenderLayerCompositor.h:
rendering/RenderMultiColumnSet.cpp:
rendering/RenderMultiColumnSet.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRequiresLayerForCompositing):

rendering/RenderRegion.h:
rendering/RenderRegionSet.h:
rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

LayoutTests:

fast/regions/layers/accelerated-compositing/crash-transform-inside-region-expected.html: Removed.
fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html: Removed.
fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child-expected.html: Removed.
fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html: Removed.
fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another-expected.html: Removed.
fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html: Removed.
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-expected.html: Removed.
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video-expected.html: Removed.
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html: Removed.
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html: Removed.
fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread-expected.html: Removed.
fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html: Removed.
fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region-expected.html: Removed.
fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html: Removed.
fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer-expected.html: Removed.
fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html: Removed.
fast/regions/layers/accelerated-compositing/z-index-expected.html: Removed.
fast/regions/layers/accelerated-compositing/z-index-update-expected.html: Removed.
fast/regions/layers/accelerated-compositing/z-index-update.html: Removed.
fast/regions/layers/accelerated-compositing/z-index.html: Removed.

11:09 AM Changeset in webkit [156477] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[sh4] JSValue* exception is unused since r70703 in JITStackFrame.
https://bugs.webkit.org/show_bug.cgi?id=121962

This is a cosmetic change, but it could avoid people reading sh4 part to
waste time to understand why there is a JSValue* here.

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Darin Adler.

jit/JITStubs.h:

11:00 AM Changeset in webkit [156476] by andersca@apple.com

2 edits in trunk/Source/JavaScriptCore

WeakGCMap should not inherit from HashMap
https://bugs.webkit.org/show_bug.cgi?id=121964

Reviewed by Geoffrey Garen.

Add the HashMap as a member variable instead and implement the missing member functions.

runtime/WeakGCMap.h:

10:57 AM Changeset in webkit [156475] by zandobersek@gmail.com

3 edits in trunk/Tools

XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
https://bugs.webkit.org/show_bug.cgi?id=121951

Reviewed by Carlos Garcia Campos.

Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
500 layout tests that trigger accelerated compositing to be used.

Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._start):

Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.

(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):

10:50 AM Changeset in webkit [156474] by msaboff@apple.com

65 edits in trunk/Source/JavaScriptCore

VirtualRegister should be a class
https://bugs.webkit.org/show_bug.cgi?id=121732

Reviewed by Geoffrey Garen.

bytecode/CodeBlock.cpp:
bytecode/CodeBlock.h:
bytecode/Instruction.h:
bytecode/LazyOperandValueProfile.h:
bytecode/MethodOfGettingAValueProfile.cpp:
bytecode/Operands.h:
bytecode/UnlinkedCodeBlock.cpp:
bytecode/UnlinkedCodeBlock.h:
bytecode/ValueRecovery.h:
bytecode/VirtualRegister.h:
bytecompiler/BytecodeGenerator.cpp:
bytecompiler/BytecodeGenerator.h:
bytecompiler/RegisterID.h:
debugger/DebuggerCallFrame.cpp:
dfg/DFGAbstractHeap.h:
dfg/DFGAbstractInterpreterInlines.h:
dfg/DFGArgumentPosition.h:
dfg/DFGArgumentsSimplificationPhase.cpp:
dfg/DFGByteCodeParser.cpp:
dfg/DFGCFGSimplificationPhase.cpp:
dfg/DFGCPSRethreadingPhase.cpp:
dfg/DFGCapabilities.cpp:
dfg/DFGConstantFoldingPhase.cpp:
dfg/DFGFlushLivenessAnalysisPhase.cpp:
dfg/DFGGraph.cpp:
dfg/DFGGraph.h:
dfg/DFGJITCode.cpp:
dfg/DFGNode.h:
dfg/DFGOSREntry.cpp:
dfg/DFGOSREntrypointCreationPhase.cpp:
dfg/DFGOSRExit.h:
dfg/DFGOSRExitCompiler32_64.cpp:
dfg/DFGOSRExitCompiler64.cpp:
dfg/DFGRegisterBank.h:
dfg/DFGScoreBoard.h:
dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT64.cpp:
dfg/DFGValidate.cpp:
dfg/DFGValueRecoveryOverride.h:
dfg/DFGVariableAccessData.h:
dfg/DFGVariableEvent.h:
dfg/DFGVariableEventStream.cpp:
dfg/DFGVirtualRegisterAllocationPhase.cpp:
ftl/FTLExitArgumentForOperand.h:
ftl/FTLLink.cpp:
ftl/FTLLowerDFGToLLVM.cpp:
ftl/FTLOSREntry.cpp:
ftl/FTLOSRExit.cpp:
ftl/FTLOSRExit.h:
ftl/FTLOSRExitCompiler.cpp:
interpreter/CallFrame.h:
interpreter/Interpreter.cpp:
jit/AssemblyHelpers.h:
jit/JIT.h:
jit/JITCall.cpp:
jit/JITInlines.h:
jit/JITOpcodes.cpp:
jit/JITOpcodes32_64.cpp:
jit/JITStubs.cpp:
llint/LLIntSlowPaths.cpp:
profiler/ProfilerBytecodeSequence.cpp:
runtime/CommonSlowPaths.cpp:
runtime/JSActivation.cpp:

10:43 AM Changeset in webkit [156473] by eric.carlson@apple.com

34 edits
2 adds
3 deletes in trunk/Source/WebCore

[MediaStream] Cleanup platform interface
https://bugs.webkit.org/show_bug.cgi?id=121935

Reviewed by Jer Noble.

No new tests, tests will be updated in the next patch.

CMakeLists.txt: Remove MediaStreamComponent.cpp.
GNUmakefile.list.am: Remove MediaStreamComponent.h|cpp and MediaStreamSourcesQueryClient.h.

Add MediaStreamConstraintsValidationClient.h and MediaStreamCreationClient.h.

Modules/mediastream/MediaStream.cpp:

(WebCore::processTrack): Duplicate MediaStreamSource when necessary to work around bug 121954.
(WebCore::createFromSourceVectors): MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
(WebCore::MediaStream::MediaStream): *Components -> *Streams.
(WebCore::MediaStream::setEnded): New.
(WebCore::MediaStream::stop): MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
(WebCore::MediaStream::addTrack): Append the track parameter rather than duplicating it, as per spec.
(WebCore::MediaStream::removeTrack): *Components -> *Streams.
(WebCore::MediaStream::trackDidEnd): Renamed from trackEnded.
(WebCore::MediaStream::streamDidEnd): Renamed from streamEnded.
(WebCore::MediaStream::addRemoteSource): Renamed from addRemoteTrack. *Components -> *Streams.
(WebCore::MediaStream::removeRemoteSource): Renamed from removeRemoteTrack. *Components -> *Streams.

Modules/mediastream/MediaStream.h:

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create): *Component -> *Stream.
(WebCore::MediaStreamTrack::MediaStreamTrack): Don't assume source is valid.
(WebCore::MediaStreamTrack::~MediaStreamTrack): Ditto.
(WebCore::MediaStreamTrack::kind): Ditto. AtomicString -> const AtomicString&.
(WebCore::MediaStreamTrack::setSource): Moved from .h file.
(WebCore::MediaStreamTrack::id): Don't assume source is valid. Create ID when the source doesn't have one.
(WebCore::MediaStreamTrack::label): Don't assume source is valid.
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled): *Component -> *Stream. MediaStreamCenter::instance -> MediaStreamCenter::shared.
(WebCore::MediaStreamTrack::readyState): "muted" is not a readyState, but "new" is.
(WebCore::MediaStreamTrack::getSources): MediaStreamCenter::instance -> MediaStreamCenter::shared.
(WebCore::MediaStreamTrack::ended): *Component -> *Stream.
(WebCore::MediaStreamTrack::sourceChangedState): Dispatch "started" and "unmuted" events.
(WebCore::MediaStreamTrack::trackDidEnd): Renamed from didEndTrack. m_component -> m_source.

Modules/mediastream/MediaStreamTrack.h:

Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::create): track->component() -> track->source();

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::didRemoveRemoteStream): Ditto.

Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl): Ditto.
(WebCore::RTCStatsRequestImpl::component): Removed, it was unused.

Modules/mediastream/RTCStatsRequestImpl.h:

Modules/mediastream/UserMediaClient.h:
Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::requestPermission): Renamed from requestUserMedia, get rid of source

vector parameters.

(WebCore::UserMediaController::cancelRequest): Renamed from cancelUserMediaRequest.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::parseOptions): MediaConstraintsImpl -> MediaConstraints.
(WebCore::UserMediaRequest::create): Ditto.
(WebCore::UserMediaRequest::UserMediaRequest): Ditto.
(WebCore::UserMediaRequest::securityOrigin): New.
(WebCore::UserMediaRequest::start): Request constraint validation.
(WebCore::UserMediaRequest::constraintsValidated): New. Callback from media engine when constraints

can be supported.

(WebCore::UserMediaRequest::requestPermission): New. Ask user media client for permission to access media.
(WebCore::UserMediaRequest::userMediaAccessGranted): New. Access has been granted.
(WebCore::UserMediaRequest::createMediaStream): New. Allowed to access media, ask media engine

to create stream sources.

(WebCore::UserMediaRequest::userMediaAccessDenied): New. User media client has denied access request.
(WebCore::UserMediaRequest::constraintsInvalid): New. Media engine can not support constraints.
(WebCore::UserMediaRequest::didCreateStream): New. Media engine has created stream sources.
(WebCore::UserMediaRequest::callSuccessHandler): New. Create stream from sources and call success handler.
(WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError): Renamed from constraintFailure.
(WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError): Renamed from permissionFailure.
(WebCore::UserMediaRequest::callErrorHandler):
(WebCore::UserMediaRequest::contextDestroyed): cancelUserMediaRequest -> cancelRequest.

Modules/mediastream/UserMediaRequest.h:

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource): localAudio->component()->source() -> localAudio->source().

Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): MediaStreamSource::TypeAudio ->

MediaStreamSource::Audio, MediaStreamSource::ReadyStateLive -> MediaStreamSource::Live.
MediaStreamCenter::instance -> MediaStreamCenter::shared.

WebCore.exp.in: Export new symbols.

WebCore.xcodeproj/project.pbxproj: Add new files and remove deleted files.

dom/EventNames.h: Define "started" event.

platform/mediastream/MediaStreamCenter.cpp:

(WebCore::mediaStreamCenterOverride): Make it possible to override the shared stream center. Will

be used for testing in a later patch.

(WebCore::MediaStreamCenter::shared): Renamed from instance. Return current stream center.
(WebCore::MediaStreamCenter::setSharedStreamCenter): Override current stream center.
(WebCore::MediaStreamCenter::endLocalMediaStream): Never call the descriptor client, always call

the descriptor and let it deal with the client.

platform/mediastream/MediaStreamCenter.h:

platform/mediastream/MediaStreamComponent.cpp: Removed.
platform/mediastream/MediaStreamComponent.h: Removed.

platform/mediastream/MediaStreamConstraintsValidationClient.h: Added.
platform/mediastream/MediaStreamCreationClient.h: Added.

platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::addSource): *Component -> *Source.
(WebCore::MediaStreamDescriptor::removeSource): Ditto.
(WebCore::MediaStreamDescriptor::addRemoteSource): Ditto.
(WebCore::MediaStreamDescriptor::removeRemoteSource): Ditto.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Ditto.
(WebCore::MediaStreamDescriptor::setEnded): Ditto. Set source readyStates to Ended.

platform/mediastream/MediaStreamDescriptor.h:

platform/mediastream/MediaStreamSource.cpp:

(WebCore::MediaStreamSource::MediaStreamSource): Initialize new member variables.
(WebCore::MediaStreamSource::setReadyState): Early return when the state hasn't changed.
(WebCore::MediaStreamSource::setStream): New.
(WebCore::MediaStreamSource::setMuted): New.

platform/mediastream/MediaStreamSource.h:

platform/mediastream/MediaStreamSourcesQueryClient.h: Removed.

platform/mediastream/RTCPeerConnectionHandler.h:
platform/mediastream/RTCStatsRequest.h:

platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp: Update for new MediaStreamCenter API.
platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:

platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp: Ditto.
platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

platform/mediastream/mac/MediaStreamCenterMac.cpp: Ditto.
platform/mediastream/mac/MediaStreamCenterMac.h:

10:34 AM Changeset in webkit [156472] by timothy_horton@apple.com

25 edits in trunk

Tiled drawing should not imply threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=121874
<rdar://problem/15071494>

Reviewed by Sam Weinig.

Shared/DrawingAreaInfo.h:

We can have DrawingAreaTypeTiledCoreAnimation without threaded scrolling.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetThreadedScrollingEnabled):
(WKPreferencesGetThreadedScrollingEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:

Add a preference for threaded scrolling.

UIProcess/API/mac/WKView.mm:

(-[WKView WebKit::]):

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

WebProcess/WebPage/DrawingArea.h:

Make it so we can use TiledCoreAnimationDrawingArea without ENABLE(THREADED_SCROLLING).

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldUseTiledBackingForFrame):

WebProcess/WebCoreSupport/WebChromeClient.h:

Override shouldUseTiledBackingForFrame; ask the drawing area if we want a tiled backing for the given frame.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):

WebProcess/WebPage/WebPage.h:

Move attaching and detaching the scrolling tree into WebPage.
Store whether or not this page is going to use threaded scrolling once, as this
cannot change through the life of a page.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
Move attaching and detaching the scrolling tree into WebPage.

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
Only do scrolling coordinator work if we have a scrolling coordinator.

(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrame):
TiledCoreAnimationDrawingArea always wants a tiled backing for the main frame.

No new tests; a near-future patch is going to put the majority of layout
tests into the tiled-drawing-without-threaded-scrolling mode.

page/ChromeClient.h:

(WebCore::ChromeClient::shouldUseTiledBackingForFrame):
Add a ChromeClient callback to determine whether a given frame wants a TiledBacking for its contents.

page/FrameView.h:
WebCore.exp.in:

Make isMainFrameView public and export it for use in WebKit2.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
Make use of shouldUseTiledBackingForFrame instead of predicating the
main frame using a tile cache on whether we have a scrolling coordinator.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::mainFrameBackingIsTiled): Added.

(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
All of these checks for existence of a scrollingCoordinator should actually
key off whether we're using tiled drawing at the root; they have nothing
to do with threaded scrolling.

rendering/RenderLayerCompositor.h:

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
The existing tiled-drawing layout tests require threaded scrolling to be enabled.

10:33 AM Changeset in webkit [156471] by beidson@apple.com

2 edits in trunk/Source/WebCore

Mark IDBDatabase "FINAL" now that http://webkit.org/b/121747 is fixed.

Rubberstamped by Andreas Kling

Modules/indexeddb/IDBDatabase.h: Mark this class FINAL.

10:24 AM Changeset in webkit [156470] by akling@apple.com

2 edits in trunk/LayoutTests

One more IndexedDB rebaseline.

js/dom/global-constructors-attributes-expected.txt:

10:19 AM Changeset in webkit [156469] by andersca@apple.com

5 edits in trunk/Source/JavaScriptCore

Weak should have a move constructor and move assignment operator
https://bugs.webkit.org/show_bug.cgi?id=121963

Reviewed by Oliver Hunt.

This is the first step towards getting rid of PassWeak.

API/JSClassRef.cpp:

(OpaqueJSClass::prototype):

heap/Weak.h:
heap/WeakInlines.h:

(JSC::::Weak):
(JSC::::leakImpl):

runtime/SimpleTypedArrayController.cpp:

(JSC::SimpleTypedArrayController::toJS):

10:16 AM Changeset in webkit [156468] by mhahnenberg@apple.com

16 edits in trunk

op_to_this shouldn't use value profiling
https://bugs.webkit.org/show_bug.cgi?id=121920

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Currently it's the only opcode that uses m_singletonValue, which is unnecessary. Our current plan is
to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables
during nursery collections.

This patch adds an inline cache for the Structure of to_this so it no longer depends on the ValueProfile's
m_singletonValue. Since nobody uses m_singletonValue now, this patch also removes m_singletonValue from
ValueProfile.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNow):

bytecode/CodeBlock.h:

(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):

bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):

bytecode/LazyOperandValueProfile.h:
bytecode/ValueProfile.h:

(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::briefDescription):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

LayoutTests:

Updated a couple tests that waited for two DFG compiles, but with this patch we
don't do two compiles any more, so we don't want to wait forever.

js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-other.js:
js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-string.js:

10:06 AM Changeset in webkit [156467] by akling@apple.com

3 edits in trunk/LayoutTests

Rebaseline some tests after IndexedDB was enabled.

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
js/dom/global-constructors-attributes-shared-worker-expected.txt:

9:57 AM Changeset in webkit [156466] by commit-queue@webkit.org

4 edits
8 adds in trunk

Inset box-shadows fail to round around corners when border-radius is set in vh/vw units.
https://bugs.webkit.org/show_bug.cgi?id=119187

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-26
Reviewed by Darin Adler.

Source/WebCore:

Border-radius properties were not applied incase its values
were given in vh, vw, vmax, vmin units.

Tests: fast/css/border-radius-inset-box-shadow-viewportlength.html

fast/css/border-radius-viewport-height.html
fast/css/border-radius-viewport-vmax.html
fast/css/border-radius-viewport-vmin.html

css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):

css/StyleResolver.h:

Calculating the border-radius values which has been specified
in viewport units.The vh/vw units are calcultated as percent of
viewport height and viewport width respectively. 1vmax: 1vw or 1vh,
whatever is largest.1vmin: 1vw or 1vh, whatever is smallest.

LayoutTests:

fast/css/border-radius-inset-box-shadow-viewportlength-expected-mismatch.html: Added.
fast/css/border-radius-inset-box-shadow-viewportlength.html: Added.
fast/css/border-radius-viewport-height-expected-mismatch.html: Added.
fast/css/border-radius-viewport-height.html: Added.
fast/css/border-radius-viewport-vmax-expected-mismatch.html: Added.
fast/css/border-radius-viewport-vmax.html: Added.
fast/css/border-radius-viewport-vmin-expected-mismatch.html: Added.
fast/css/border-radius-viewport-vmin.html: Added.

Added new tests for verifying that box-shadow and border-radius properties
are applied when its values are viewport units.

9:53 AM Changeset in webkit [156465] by Seokju Kwon

2 edits in trunk/Source/WebCore

Fix ordered comparison warnings in BitmapImage::drawPattern
https://bugs.webkit.org/show_bug.cgi?id=121945

Reviewed by Darin Adler.

No new tests, no behavior change.

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):

9:52 AM Changeset in webkit [156464] by oliver@apple.com

19 edits
12 adds in trunk

Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

This is mostly simple - the semantics of deconstruction are already
present in the language, so most of the complexity (if you call it
that) is addition of new AST nodes, and parsing the syntax.

In order to get correct semantics for the parameter lists, FunctionParameters
now needs to store refcounted references to the parameter patterns.
There's also a little work to ensure that variable creation and assignment
occurs in the correct order while the BytecodeGenerator is being constructed.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::paramString):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitExpressionInfo):

bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitBytecode):
(JSC::DeconstructingAssignmentNode::emitBytecode):
(JSC::DeconstructionPatternNode::~DeconstructionPatternNode):
(JSC::ArrayPatternNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):
(JSC::ArrayPatternNode::toString):
(JSC::ArrayPatternNode::collectBoundIdentifiers):
(JSC::ObjectPatternNode::toString):
(JSC::ObjectPatternNode::emitBytecode):
(JSC::ObjectPatternNode::collectBoundIdentifiers):
(JSC::BindingNode::emitBytecode):
(JSC::BindingNode::toString):
(JSC::BindingNode::collectBoundIdentifiers):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::createDeconstructingAssignment):
(JSC::ASTBuilder::createArrayPattern):
(JSC::ASTBuilder::appendArrayPatternSkipEntry):
(JSC::ASTBuilder::appendArrayPatternEntry):
(JSC::ASTBuilder::createObjectPattern):
(JSC::ASTBuilder::appendObjectPatternEntry):
(JSC::ASTBuilder::createBindingLocation):

parser/NodeConstructors.h:

(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):
(JSC::DeconstructionPatternNode::DeconstructionPatternNode):
(JSC::ArrayPatternNode::ArrayPatternNode):
(JSC::ArrayPatternNode::create):
(JSC::ObjectPatternNode::ObjectPatternNode):
(JSC::ObjectPatternNode::create):
(JSC::BindingNode::create):
(JSC::BindingNode::BindingNode):
(JSC::DeconstructingAssignmentNode::DeconstructingAssignmentNode):

parser/Nodes.cpp:

(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):

parser/Nodes.h:

(JSC::ExpressionNode::isDeconstructionNode):
(JSC::ArrayNode::elements):
(JSC::CommaNode::append):
(JSC::ParameterNode::pattern):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::patterns):
(JSC::DeconstructionPatternNode::isBindingNode):
(JSC::DeconstructionPatternNode::emitDirectBinding):
(JSC::ArrayPatternNode::appendIndex):
(JSC::ObjectPatternNode::appendEntry):
(JSC::ObjectPatternNode::Entry::Entry):
(JSC::BindingNode::boundProperty):
(JSC::BindingNode::isBindingNode):
(JSC::DeconstructingAssignmentNode::bindings):
(JSC::DeconstructingAssignmentNode::isLocation):
(JSC::DeconstructingAssignmentNode::isDeconstructionNode):

parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::parseDeconstructionPattern):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):

parser/Parser.h:

(JSC::Scope::declareBoundParameter):
(JSC::Parser::declareBoundParameter):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::addVar):
(JSC::SyntaxChecker::operatorStackPop):

runtime/JSONObject.cpp:

(JSC::escapeStringToBuilder):

runtime/JSONObject.h:

LayoutTests:

Add enw tests, and update old ones.

js/destructuring-assignment-expected.txt: Added.
js/destructuring-assignment.html: Added.
js/mozilla/strict/13.1-expected.txt:
js/mozilla/strict/regress-532254-expected.txt:
js/mozilla/strict/script-tests/13.1.js:
js/regress/destructuring-arguments-expected.txt: Added.
js/regress/destructuring-arguments-length-expected.txt: Added.
js/regress/destructuring-arguments-length.html: Added.
js/regress/destructuring-arguments.html: Added.
js/regress/destructuring-swap-expected.txt: Added.
js/regress/destructuring-swap.html: Added.
js/regress/script-tests/destructuring-arguments-length.js: Added.

(foo):

js/regress/script-tests/destructuring-arguments.js: Added.

(foo):

js/regress/script-tests/destructuring-swap.js: Added.

(foo):

js/script-tests/destructuring-assignment.js: Added.

(testDestructuring):
(testDeconstructArgs):
(testDeconstructArgLength):

9:46 AM Changeset in webkit [156463] by berto@igalia.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Unskip media/context-menu-actions.html which is passing now.

platform/gtk-wk2/TestExpectations:

9:36 AM Changeset in webkit [156462] by kov@webkit.org

2 edits in trunk

[GTK] Tons of warnings caused by using FORTIFY_SOURCE in an unoptimized build
https://bugs.webkit.org/show_bug.cgi?id=121836

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-26
Reviewed by Martin Robinson.

Source/autotools/SetupCompilerFlags.m4: only consider enabling FORTIFY_SOURCE if optimizations have

been enabled, since they are required for FORTIFY_SOURCE to work, and enabling FORTIFY_SOURCE unconditionally
generates warnings in newer glibc.

9:18 AM Changeset in webkit [156461] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r156457.
http://trac.webkit.org/changeset/156457
https://bugs.webkit.org/show_bug.cgi?id=121960

Broke webkitpy tests. (Requested by kling on #webkit).

Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._start):

8:16 AM Changeset in webkit [156460] by mario@webkit.org

3 edits in trunk/LayoutTests

[GTK][WK2] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957

Unreviewed gardening again. Now moving the expected flakiness to
the WebKit2GTK+ port, where it actually belongs to.

platform/gtk-wk2/TestExpectations: Added expectations.
platform/gtk/TestExpectations: Removed expectations.

8:02 AM Changeset in webkit [156459] by mario@webkit.org

2 edits in trunk/LayoutTests

[GTK] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957

Unreviewed gardening. Marking accessibility tests as flaky while
an issue with the logging of accessibility events is investigated.

platform/gtk/TestExpectations: Added flaky expectations.

7:24 AM Changeset in webkit [156458] by akling@apple.com

8 edits
14 deletes in trunk/Source/WebCore

Remove empty JSFooCustom.cpp files.
<https://webkit.org/b/121955>

Reviewed by Anders Carlsson.

There's no sense in slowing down build times with empty files that
still include a bunch of headers.

bindings/js/JSAudioBufferCustom.cpp: Removed.
bindings/js/JSCSSFontFaceRuleCustom.cpp: Removed.
bindings/js/JSCSSImportRuleCustom.cpp: Removed.
bindings/js/JSCSSMediaRuleCustom.cpp: Removed.
bindings/js/JSCSSPageRuleCustom.cpp: Removed.
bindings/js/JSCSSStyleRuleCustom.cpp: Removed.
bindings/js/JSDOMImplementationCustom.cpp: Removed.
bindings/js/JSDOMTokenListCustom.cpp: Removed.
bindings/js/JSHTMLStyleElementCustom.cpp: Removed.
bindings/js/JSMediaListCustom.cpp: Removed.
bindings/js/JSProcessingInstructionCustom.cpp: Removed.
bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp: Removed.
bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp: Removed.
bindings/js/JSXMLHttpRequestUploadCustom.cpp: Removed.

6:30 AM Changeset in webkit [156457] by zandobersek@gmail.com

2 edits in trunk/Tools

XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
https://bugs.webkit.org/show_bug.cgi?id=121951

Reviewed by Carlos Garcia Campos.

Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._start):

4:50 AM Changeset in webkit [156456] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

[Qt] Remove PassTraits.h from WTF.pro.
https://bugs.webkit.org/show_bug.cgi?id=121946

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Andreas Kling.

WTF.pro: Remove PassTraits.h as this file disappeared in r156298.

4:18 AM Changeset in webkit [156455] by mario@webkit.org

2 edits in trunk/LayoutTests

REGRESSION(r144831-r144846):Crashes in accessibility/aria-hidden-with-elements.html, accessibility/table-with-hidden-head-section.html
https://bugs.webkit.org/show_bug.cgi?id=112152

Unreviewed GTK gardening. Removed crash expectations now passing.

platform/gtk/TestExpectations: Removed crashing expectations

that are now passing after r156141-r156209.

4:13 AM Changeset in webkit [156454] by mario@webkit.org

2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Remove failure expectation for test passing after r156209.

platform/gtk-wk2/TestExpectations: Removed failure expectation.

1:58 AM Changeset in webkit [156453] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] Remove inappropriate expectations for tests that are now passing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=121897

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-26

platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

1:41 AM Changeset in webkit [156452] by commit-queue@webkit.org

2 edits
1 add in trunk/LayoutTests

[EFL] Add baselines for editing/selection/paragraph-granularity.html
https://bugs.webkit.org/show_bug.cgi?id=121842

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-26

platform/efl/TestExpectations: Removing the corresponding entry.
platform/efl/editing/selection/paragraph-granularity-expected.txt: Added.

1:20 AM Changeset in webkit [156451] by commit-queue@webkit.org

20 edits
21 adds in trunk

[CSS Regions] The layers from the flow thread should be collected under the regions' layers.
https://bugs.webkit.org/show_bug.cgi?id=120457

Patch by Mihai Maerean <Mihai Maerean> on 2013-09-26
Reviewed by David Hyatt.

Source/WebCore:

This patch is based on the work of Alexandru Chiculita at https://bugs.webkit.org/attachment.cgi?id=203872&action=review

The composited layers inside the named flow threads are collected as part of the regions.
When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
that region too (inside RenderFlowThread::updateAllLayerToRegionMappings).

Tests: fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html

fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html
fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html
fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html
fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html
fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html
fast/regions/layers/accelerated-compositing/z-index.html: Added.
fast/regions/layers/accelerated-compositing/z-index-update.html: Added.

rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
we update all the mappings between the layers inside the flow thread and the regions where those layers will be
painted.
(WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
from a region to another since the last update.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):

rendering/RenderFlowThread.h:
rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::pushRenderFlowThread):

rendering/RenderGeometryMap.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateLayerBounds): The RenderNamedFlowThread is ignored when we calculate the bounds
of the RenderView.

rendering/RenderLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's inside an out of flow Flow Thread.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
(WebCore::enclosingFlowThreadAncestor):
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
its borders, paddings, outlines or box-shadows to layers inside it.

rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly. We
are going to collect composited layers as part of regions.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
use composited RenderRegions to render the background of the RenderFlowThread.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a region.

rendering/RenderLayerCompositor.h:
rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):

rendering/RenderMultiColumnSet.h:
rendering/RenderElement.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
through the RenderView::styleDidChange function.

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRequiresLayerForCompositing):
(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):

rendering/RenderRegion.h:

(WebCore::toRenderRegion):

rendering/RenderRegionSet.h:

(WebCore::RenderRegionSet::requiresLayer): Never.

rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

LayoutTests:

fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html: Added.
fast/regions/layers/accelerated-compositing/crash-transform-inside-region-expected.html: Added.
fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html: Added.
fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child-expected.html: Added.
fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html: Added.
fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another-expected.html: Added.
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html: Added.
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-expected.html: Added.
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html: Added.
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html: Added.
fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread-expected.html: Added.
fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html: Added.
fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer-expected.html: Added.
fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html: Added.
fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region-expected.html: Added.
fast/regions/layers/accelerated-compositing/z-index.html: Added.
fast/regions/layers/accelerated-compositing/z-index-expected.html: Added.
fast/regions/layers/accelerated-compositing/z-index-update-expected.html: Added.
fast/regions/layers/accelerated-compositing/z-index-update.html: Added.

12:58 AM Changeset in webkit [156450] by mihnea@adobe.com

3 edits
4 adds in trunk

[CSSRegions] Unable to collect html element in a named flow
https://bugs.webkit.org/show_bug.cgi?id=121878

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/regions/collect-html-in-named-flow.html

fast/regions/iframe-html-collected.html

It should be possible to collect the html element in a named flow.
However, before we check whether adding a child is not restricted
by its original parent, we have to make sure that the original parent
is an element to safely perform the check.

rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::isChildAllowed):

LayoutTests:

Use an iframe with a html element collected in a named flow
to test that is does not crash or assert.

fast/regions/collect-html-in-named-flow-expected.txt: Added.
fast/regions/collect-html-in-named-flow.html: Added.
fast/regions/iframe-html-collected-expected.txt: Added.
fast/regions/iframe-html-collected.html: Added.

Sep 25, 2013:

11:33 PM Changeset in webkit [156449] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized
https://bugs.webkit.org/show_bug.cgi?id=118515

Patch by Minju Kim <pmuarteo@gmail.com> on 2013-09-25
Reviewed by Christophe Dumez.

WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::initializeProxy): Handled EnvHttpProxyFactory by using OwnPtr
to avoid memory leak when it isn't handled by NetworkProxyFactory

9:50 PM Changeset in webkit [156448] by beidson@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, blind attempt at a build fix.

inspector/InspectorIndexedDBAgent.cpp: Don’t include the keyPathFromIDBKeyPath method for PLATFORM(MAC) as it is unused.

9:15 PM Changeset in webkit [156447] by beidson@apple.com

11 edits in trunk/Source

Enable the IndexedDB build on Mac, but leave the feature non-functional
https://bugs.webkit.org/show_bug.cgi?id=121918

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

(WebCore::IDBFactory::create): If the IDBFactoryBackend is null (which it is for on-levelDB platforms),

don't create an IDBFactory. This hides the feature from javascript even though upport code is in the build.

inspector/InspectorIndexedDBAgent.cpp: Empty out DatabaseLoader::execute on Mac until the inspector build gurus can figure out a 32bit-vs-64bit issue that there is no obvious solution for.

WebCore.xcodeproj/project.pbxproj: Remove the Modules/indexedDB/leveldb directory now that Mac has no further use for it.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

8:54 PM Changeset in webkit [156446] by ryuan.choi@samsung.com

4 edits in trunk/Source/WebCore

Unreviewed build fix for EFL port.

IDBCursorBackendImpl and IDBDatabaseBackendImpl are renamed after r156406.

Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:

(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::registerOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::unregisterOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::closeOpenCursors):

Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

(WebCore::IDBTransactionBackendLevelDB::database):

8:51 PM Changeset in webkit [156445] by ap@apple.com

3 edits in trunk/LayoutTests

fast/css/font-face-data-uri.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82744

Reviewed by Darin Adler.

This test used to wait for one font to load, but not for another, which made no sense.

fast/css/font-face-data-uri.html: Wait for both fonts. Increased the number of tries,

it's not that long. Use an async test idiom that doesn't conflict with js-test-post.js.

fast/css/font-face-data-uri-expected.txt: Updated the results for proper async

test usage.

7:30 PM Changeset in webkit [156444] by benjamin@webkit.org

5 edits in trunk/Source/WebCore

Do not reenter Document from its destructor
https://bugs.webkit.org/show_bug.cgi?id=121933

Reviewed by Darin Adler.

Following r156422, there are cases where we would reenter Document
during its destruction.

The flow was the following:
-Document's destructor is executed.
-DocumentStyleSheetCollection being part of Document, its destructor

is executed.

-DocumentStyleSheetCollection's destructor detach the owner node of all

its stylesheets avoid keeping stale references to a dead Document.

-CSSStyleSheet::clearOwnerNode() would fetch the dying document

and invoke Document::styleResolverChanged().

This would not fail because the document is detached and Document::styleResolverChanged()
would fail early. This is complicated and error prone so this patch attempt to clear
the process a bit.

With the patch, Document detach all the stylesheets early in the destruction.
Clearing the stylesheet is also changed to avoid re-entering the document.

css/CSSStyleSheet.h:
dom/Document.cpp:

(WebCore::Document::~Document):

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::detachFromDocument):

dom/DocumentStyleSheetCollection.h:

7:03 PM Changeset in webkit [156443] by Patrick Gansterer

3 edits in trunk/Source/WTF

Fix compilation with new MSVC compiler for Windows CE
https://bugs.webkit.org/show_bug.cgi?id=121914

Reviewed by Darin Adler.

Remove code to support older Windows CE versions, since those old
versions do not support C+11, which is required in the meantime.

wtf/Atomics.h:
wtf/Platform.h:

7:01 PM Changeset in webkit [156442] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

htmlediting.cpp: unnecessary local variable cleanup
https://bugs.webkit.org/show_bug.cgi?id=121903

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-25
Reviewed by Darin Adler.

Code cleanup.

editing/htmlediting.cpp:

(WebCore::lowestEditableAncestor):

6:49 PM Changeset in webkit [156441] by roger_fong@apple.com

2 edits in trunk/Source/WebKit

[Windows] Unreviewed Build fix.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

6:05 PM Changeset in webkit [156440] by commit-queue@webkit.org

5 edits
1 add in trunk/Tools

Removed check for Apple Application Support directory in WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=121869

Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-25
Reviewed by Brent Fulgham.

DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:

Use DLLLauncherWinCairo.props for WinCairo ports.

win/DLLLauncher/DLLLauncherMain.cpp:

(wWinMain):
Don't call modifyPath to check for AAS in the WinCairo port.

win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.

6:03 PM Changeset in webkit [156439] by commit-queue@webkit.org

10 edits in trunk/Source

Unreviewed, rolling out r156432.
http://trac.webkit.org/changeset/156432
https://bugs.webkit.org/show_bug.cgi?id=121932

some integer conversion things that need brady to fix
(Requested by thorton on #webkit).

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
Modules/indexeddb/IDBFactory.h:

(WebCore::IDBFactory::create):

WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

5:53 PM Changeset in webkit [156438] by andersca@apple.com

4 edits in trunk/Source

Move KeyValuePairTraits inside HashMap
https://bugs.webkit.org/show_bug.cgi?id=121931

Reviewed by Sam Weinig.

Source/JavaScriptCore:

tools/ProfileTreeNode.h:

Source/WTF:

Also rename the ValueType typedef to KeyValuePairType since it's always a key value pair.

wtf/HashMap.h:

(WTF::HashMap::KeyValuePairTraits::isEmptyValue):
(WTF::HashMap::find):
(WTF::HashMap::contains):

5:48 PM Changeset in webkit [156437] by commit-queue@webkit.org

7 edits in trunk

Enabled AssembleBuildLogs on WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=121923

Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-25
Reviewed by Brent Fulgham.

Source/WebKit:

WebKit.vcxproj/WebKit.sln:

Build AssembleBuildLogs in WinCairo port.

Tools:

win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:

Fixed reference to README, added WinCairo configurations.

win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:

Fixed reference to README.

win/AssembleBuildLogs/AssembleLogs.cmd:

Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.

win/AssembleBuildLogs/README: Fixed spelling.

5:41 PM Changeset in webkit [156436] by alex.christensen@flexsim.com

2 edits in trunk/Source/WebCore

Win64 compile fix after r155226.
https://bugs.webkit.org/show_bug.cgi?id=120969

Reviewed by Brent Fulgham.

WebCore.vcxproj/WebCore.vcxproj:

Disable building StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm on Win64.

4:51 PM Changeset in webkit [156435] by ap@apple.com

4 edits in trunk/Source/WebCore

Flaky Test: platform/mac/fonts/han-disunification.html
https://bugs.webkit.org/show_bug.cgi?id=114207

Reviewed by Anders Carlsson.

This test was affected by preceding tests changing font settings.

Save original font if it's changed, and restore it in Backup::restoreTo().

WebCore.exp.in:
testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setStandardFontFamily):
(WebCore::InternalSettings::setSerifFontFamily):
(WebCore::InternalSettings::setSansSerifFontFamily):
(WebCore::InternalSettings::setFixedFontFamily):
(WebCore::InternalSettings::setCursiveFontFamily):
(WebCore::InternalSettings::setFantasyFontFamily):
(WebCore::InternalSettings::setPictographFontFamily):

testing/InternalSettings.h:

4:26 PM Changeset in webkit [156434] by andersca@apple.com

2 edits in trunk/Source/WTF

Un-indent HashMap.h.

Rubber-stamped by Andreas Kling.

wtf/HashMap.h:

4:24 PM Changeset in webkit [156433] by roger_fong@apple.com

2 edits in trunk/Source/WebKit/win

[Windows] Attempting to scroll from a non-scrollable layer results the main document getting scrolled.
https://bugs.webkit.org/show_bug.cgi?id=121889.
<rdar://problem/15072441>

WebView.cpp:

(WebView::gesture):
Call scrollByRecursively on the current RenderLayer's enclosingScrollableLayer to make sure that the method
doesn't bail early and end up just scrolling the main document instead of the next scrollable layer in the RenderLayer tree.

4:21 PM Changeset in webkit [156432] by beidson@apple.com

10 edits in trunk/Source

Enable the IndexedDB build on Mac, but leave the feature non-functional
https://bugs.webkit.org/show_bug.cgi?id=121918

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig: Enable the feature.

Modules/indexeddb/IDBFactory.h:

(WebCore::IDBFactory::create): If the IDBFactoryBackend is null (which it is for on-levelDB platforms),

don't create an IDBFactory. This hides the feature from javascript even though upport code is in the build.

WebCore.xcodeproj/project.pbxproj: Remove the Modules/indexedDB/leveldb directory now that Mac has no further use for it.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

4:18 PM Changeset in webkit [156431] by ap@apple.com

3 edits in trunk/LayoutTests

Flaky Test: fast/history/history-subframe-with-name.html
https://bugs.webkit.org/show_bug.cgi?id=51039

Reviewed by Brady Eidson.

fast/history/history-subframe-with-name.html: In state 3, there was a race between

history.forward() and navigating to a new URL. Not sure how this resulted in an
extra load, but let's get rid of that. Also, extended failure logging.

fast/history/resources/history-subframe-with-name-2.html: No longer do the

navigation unconditionally. We need it in state 1, but not in state 3.

4:18 PM Changeset in webkit [156430] by Patrick Gansterer

3 edits in trunk/Source/WebKit/win

[WIN] Replace CF time functions with Windows API functions in WebHistory
https://bugs.webkit.org/show_bug.cgi?id=121599

Reviewed by Brent Fulgham.

This reduces the dependencies on the CoreFoundation library.

WebHistory.cpp:

(addDayToSystemTime):
(getDayBoundaries):
(beginningOfDay):
(dateKey):
(WebHistory::orderedLastVisitedDays):

WebHistory.h:

3:54 PM Changeset in webkit [156429] by andersca@apple.com

2 edits in trunk/Source/WTF

Un-indent HashTraits.h.

Rubber-stamped by Andreas Kling.

wtf/HashTraits.h:

3:51 PM Changeset in webkit [156428] by timothy@apple.com

1 edit in trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

Fix the build.

3:42 PM Changeset in webkit [156427] by akling@apple.com

2 edits in trunk/Source/WebCore

Make EventTarget::hasEventListeners() a const method.

This class needs a lot of love in the const correctness department
but for now let's limit ourselves to fixing the IndexedDB build.

dom/EventTarget.h:

(WebCore::EventTarget::hasEventListeners):

3:35 PM Changeset in webkit [156426] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Disable more CSS_SHAPES tests on AppleWin port.

platform/win/TestExpectations:

3:18 PM Changeset in webkit [156425] by rniwa@webkit.org

3 edits
99 adds in trunk/PerformanceTests

DoYouEvenBench: Add a test case for FlightJS
https://bugs.webkit.org/show_bug.cgi?id=121926

Reviewed by Antti Koivisto.

Add a FlightJS test case.

DoYouEvenBench/benchmark.html:
DoYouEvenBench/benchmark.js:
DoYouEvenBench/flightjs-example-app: Added.
DoYouEvenBench/flightjs-example-app/LICENSE.md: Added.
DoYouEvenBench/flightjs-example-app/README.md: Added.
DoYouEvenBench/flightjs-example-app/app: Added.
DoYouEvenBench/flightjs-example-app/app/boot: Added.
DoYouEvenBench/flightjs-example-app/app/boot/page.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_data: Added.
DoYouEvenBench/flightjs-example-app/app/component_data/compose_box.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_data/mail_items.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_data/move_to.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_ui: Added.
DoYouEvenBench/flightjs-example-app/app/component_ui/compose_box.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_ui/folders.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_ui/mail_controls.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_ui/mail_items.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_ui/move_to_selector.js: Added.
DoYouEvenBench/flightjs-example-app/app/component_ui/with_select.js: Added.
DoYouEvenBench/flightjs-example-app/app/css: Added.
DoYouEvenBench/flightjs-example-app/app/css/custom.css: Added.
DoYouEvenBench/flightjs-example-app/app/data.js: Added.
DoYouEvenBench/flightjs-example-app/app/templates.js: Added.
DoYouEvenBench/flightjs-example-app/components: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/css: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.css: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/img: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/js: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.js: Added.
DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/.gitignore: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/CHANGES: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/LICENSE: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/README.md: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/component.json: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.min.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.min.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/package.json: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/index.html: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Added.
DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Added.
DoYouEvenBench/flightjs-example-app/components/flight: Added.
DoYouEvenBench/flightjs-example-app/components/flight/.travis.yml: Added.
DoYouEvenBench/flightjs-example-app/components/flight/lib: Added.
DoYouEvenBench/flightjs-example-app/components/flight/lib/advice.js: Added.
DoYouEvenBench/flightjs-example-app/components/flight/lib/component.js: Added.
DoYouEvenBench/flightjs-example-app/components/flight/lib/compose.js: Added.
DoYouEvenBench/flightjs-example-app/components/flight/lib/index.js: Added.
DoYouEvenBench/flightjs-example-app/components/flight/lib/logger.js: Added.
DoYouEvenBench/flightjs-example-app/components/flight/lib/registry.js: Added.
DoYouEvenBench/flightjs-example-app/components/flight/lib/utils.js: Added.
DoYouEvenBench/flightjs-example-app/components/flight/tools: Added.
DoYouEvenBench/flightjs-example-app/components/flight/tools/debug: Added.
DoYouEvenBench/flightjs-example-app/components/flight/tools/debug/debug.js: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-flight: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-flight/LICENSE.md: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-flight/README.md: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-flight/bower.json: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-jquery: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib: Added.
DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Added.
DoYouEvenBench/flightjs-example-app/components/jquery: Added.
DoYouEvenBench/flightjs-example-app/components/jquery/component.json: Added.
DoYouEvenBench/flightjs-example-app/components/jquery/composer.json: Added.
DoYouEvenBench/flightjs-example-app/components/jquery/jquery.js: Added.
DoYouEvenBench/flightjs-example-app/components/jquery/jquery.min.js: Added.
DoYouEvenBench/flightjs-example-app/components/mustache: Added.
DoYouEvenBench/flightjs-example-app/components/mustache/mustache.js: Added.
DoYouEvenBench/flightjs-example-app/components/requirejs: Added.
DoYouEvenBench/flightjs-example-app/components/requirejs/require.js: Added.
DoYouEvenBench/flightjs-example-app/index.html: Added.
DoYouEvenBench/flightjs-example-app/karma.conf.js: Added.
DoYouEvenBench/flightjs-example-app/package.json: Added.
DoYouEvenBench/flightjs-example-app/requireMain.js: Added.

3:18 PM Changeset in webkit [156424] by Brent Fulgham

47 edits in trunk/Source

../WebCore: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
https://bugs.webkit.org/show_bug.cgi?id=121883

Windows is experiencing crashes when client programs (such as
DumpRenderTree) attemp to change settings on the RuntimeEnabledFeatures
object. The inlined static accessor methods are not accessing
memory safely (when compiled by Visual Studio) resulting in
crashes.

Reviewed by Jer Noble.

WebCore.exp.in: Remove static accessors for RuntimeEnabledFeatures.
bindings/generic/RuntimeEnabledFeatures.cpp: Switch methods to

conform to a singleton pattern.
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::sharedRuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::fileSystemEnabled):
(WebCore::RuntimeEnabledFeatures::javaScriptI18NAPIEnabled):
(WebCore::RuntimeEnabledFeatures::audioEnabled):
(WebCore::RuntimeEnabledFeatures::htmlMediaElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlAudioElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlVideoElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
(WebCore::RuntimeEnabledFeatures::mediaControllerEnabled):
(WebCore::RuntimeEnabledFeatures::mediaErrorEnabled):
(WebCore::RuntimeEnabledFeatures::timeRangesEnabled):
(WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled):
(WebCore::RuntimeEnabledFeatures::webSocketEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

bindings/generic/RuntimeEnabledFeatures.h: Ditto.

(WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
(WebCore::RuntimeEnabledFeatures::localStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::setGeolocationEnabled):
(WebCore::RuntimeEnabledFeatures::geolocationEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSShapesEnabled):
(WebCore::RuntimeEnabledFeatures::cssShapesEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::cssCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::touchEnabled):
(WebCore::RuntimeEnabledFeatures::setTouchEnabled):
(WebCore::RuntimeEnabledFeatures::setDeviceMotionEnabled):
(WebCore::RuntimeEnabledFeatures::deviceMotionEnabled):
(WebCore::RuntimeEnabledFeatures::deviceMotionEventEnabled):
(WebCore::RuntimeEnabledFeatures::ondevicemotionEnabled):
(WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled):
(WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled):
(WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled):
(WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
(WebCore::RuntimeEnabledFeatures::setSpeechInputEnabled):
(WebCore::RuntimeEnabledFeatures::speechInputEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):
(WebCore::RuntimeEnabledFeatures::setFileSystemEnabled):
(WebCore::RuntimeEnabledFeatures::setJavaScriptI18NAPIEnabled):
(WebCore::RuntimeEnabledFeatures::mediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::quotaEnabled):
(WebCore::RuntimeEnabledFeatures::setQuotaEnabled):
(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::encryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::customDOMElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomDOMElements):
(WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeLocalEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeLocalEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeMonthEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeMonthEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeTimeEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeTimeEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeWeekEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeWeekEnabled):
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::seamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::setSeamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getCSSPropertyNamePrefix): Use singleton accessors.
(WebCore::cssPropertyIDForJSCSSPropertyName): Ditto.

bindings/scripts/CodeGeneratorJS.pm:

(GetRuntimeEnableFunctionName): Generate singleton version of
accessors.

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::fontLoaded): Use singleton accessors.
(WebCore::CSSFontFace::getFontData): Ditto.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Ditto.

css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID): Ditto.
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::rewriteSpecifiers):

css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::fontLoaded): Ditto.

css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver): Ditto.

dom/Document.cpp:

(WebCore::Document::cssRegionsEnabled): Ditto.
(WebCore::Document::cssCompositingEnabled):
(WebCore::Document::shouldDisplaySeamlesslyWithParent):
(WebCore::Document::getCachedLocale):

dom/Element.cpp:

(WebCore::Element::createShadowRoot): Ditto.

dom/Position.cpp:

(WebCore::Position::Position): Ditto.
(WebCore::Position::findParent):

dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection): Ditto.

dom/make_names.pl:

(printConstructorInterior): Generate singleton version of accessors.
(printWrapperFunctions): Ditto.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isSpeechEnabled): Use singleton accessors.
(WebCore::HTMLInputElement::setupDateTimeChooserParameters): Ditto.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::finishParsingChildren): Ditto.
(WebCore::HTMLMediaElement::scheduleDelayedAction):
(WebCore::HTMLMediaElement::loadTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack):
(WebCore::HTMLMediaElement::addAudioTrack):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::addVideoTrack):
(WebCore::HTMLMediaElement::removeAudioTrack):
(WebCore::HTMLMediaElement::removeTextTrack):
(WebCore::HTMLMediaElement::removeVideoTrack):
(WebCore::HTMLMediaElement::audioTracks):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::videoTracks):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::didRemoveTextTrack):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):

html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute): Ditto.
(WebCore::HTMLStyleElement::scopedAttributeChanged):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::scoped):

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute): Ditto.
(WebCore::HTMLTrackElement::scheduleLoad):
(WebCore::HTMLTrackElement::canLoadUrl):

html/InputType.cpp:

(WebCore::createInputTypeFactoryMap): Ditto.

page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled): Ditto.

page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener): Ditto.

page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks): Ditto.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Ditto.
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShadowDOMEnabled):
(WebCore::InternalSettings::setAuthorShadowDOMForAnyElementEnabled):
(WebCore::InternalSettings::setStyleScopedEnabled):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore::InternalSettings::setCSSShapesEnabled):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):

../WebKit: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
https://bugs.webkit.org/show_bug.cgi?id=121883

Reviewed by Jer Noble.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Expose singleton accessor for DLL clients.

../WebKit/blackberry: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

WebKitSupport/DumpRenderTreeSupport.cpp:

(DumpRenderTreeSupport::setStyleScopedEnabled): use
singleton accessor.

../WebKit/efl: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setCSSRegionsEnabled): Use singleton.
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled): Ditto.

ewk/ewk_settings.cpp:

(ewk_settings_shadow_dom_enable_get): Ditto.
(ewk_settings_shadow_dom_enable_set):

ewk/ewk_view.cpp:

(_ewk_view_priv_new): Ditto.

../WebKit/gtk: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setCSSRegionsEnabled): Use singleton.
(DumpRenderTreeSupportGtk::setExperimentalContentSecurityPolicyFeaturesEnabled):
(DumpRenderTreeSupportGtk::setSeamlessIFramesEnabled):
(DumpRenderTreeSupportGtk::setShadowDOMEnabled):
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):

webkit/webkitwebview.cpp:

(webkit_web_view_update_settings): Ditto.

../WebKit/mac: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Use singleton accessor.
(-[WebView _setDashboardBehavior:to:]): Ditto.

../WebKit/qt: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply): Use singleton accessor.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setSeamlessIFramesEnabled): Ditto.

../WebKit/win: [Windows] Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883

Reviewed by Jer Noble.

WebView.cpp:

(WebView::notifyPreferencesChanged): Use singleton accessor

../WebKit2: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.

Reviewed by Jer Noble.

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Use
Singleton accessor.
(WebKit::InjectedBundle::setShadowDOMEnabled):
(WebKit::InjectedBundle::setCSSRegionsEnabled):
(WebKit::InjectedBundle::setCSSCompositingEnabled):
(WebKit::InjectedBundle::setSeamlessIFramesEnabled):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Ditto.

WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess): Ditto.

3:08 PM Changeset in webkit [156423] by akling@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix for IDBDatabase.

Turns out there was a much cleaner way to express this.

2:13 PM Changeset in webkit [156422] by benjamin@webkit.org

34 edits in trunk/Source/WebCore

Tie the life of DocumentStyleSheetCollection and Document together
https://bugs.webkit.org/show_bug.cgi?id=121892

Reviewed by Andreas Kling.

DocumentStyleSheetCollection had an odd destruction pattern for no apparent reason.

The two objects strictly depend on eachother, this patch make that explicit by making
DocumentStyleSheetCollection a plain object in Document's memory space.

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::didMutateRules):

css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::initUserStyle):

css/DocumentRuleSets.h:
css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):

css/InspectorCSSOMWrappers.h:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):

css/StyleSheetList.cpp:

(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleResolver):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::haveStylesheetsLoaded):

dom/Document.h:

(WebCore::Document::styleSheetCollection):

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

dom/DocumentStyleSheetCollection.h:
dom/Element.cpp:

(WebCore::Element::createPseudoElementIfNeeded):

dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto):

html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::willMatchRule):

inspector/InspectorCSSAgent.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willMatchRuleImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willMatchRule):

mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedInto):

page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

page/PageGroup.cpp:

(WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):

rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::lineHeight):

rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::lineHeight):

rendering/RenderObject.cpp:

(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::cachedFirstLineStyle):

rendering/RenderObject.h:

(WebCore::RenderObject::firstLineStyle):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

style/StyleResolveTree.cpp:

(WebCore::Style::resolveLocal):

testing/Internals.cpp:

(WebCore::Internals::insertAuthorCSS):
(WebCore::Internals::insertUserCSS):

1:58 PM Changeset in webkit [156421] by beidson@apple.com

8 edits in trunk/Source

FeatureDefine.xcconfig cleanup (They should all be identical).
https://bugs.webkit.org/show_bug.cgi?id=121921

Reviewed by Mark Rowe.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

1:57 PM Changeset in webkit [156420] by andersca@apple.com

7 edits in trunk/Source/WebKit2

Use tuples for encoding IPC messages
https://bugs.webkit.org/show_bug.cgi?id=121924

Reviewed by Andreas Kling.

Yet another step towards getting rid of the Arguments hierarchy.

Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
(CoreIPC::handleMessageVariadic):
(CoreIPC::handleMessageDelayed):

Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::send):

Scripts/webkit2/messages.py:

(arguments_type_old):
(arguments_type):
(reply_type):
(decode_type):
(delayed_reply_type):
(message_to_struct_declaration):

Scripts/webkit2/messages_unittest.py:

(LoadURL):
(std):
(TouchEvent):
(DidReceivePolicyDecision):
(Close):
(PreferencesDidChange):
(SendDoubleAndFloat):
(SendInts):
(CreatePlugin):
(RunJavaScriptAlert):
(GetPlugins):
(GetPluginProcessConnection):
(TestMultipleAttributes):
(TestParameterAttributes):
(TemplateTest):
(DidCreateWebProcessConnection):
(InterpretKeyEvent):
(DeprecatedOperation):
(ExperimentalOperation):

Shared/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::send):

1:01 PM Changeset in webkit [156419] by akling@apple.com

45 edits in trunk/Source/WebCore

JS wrappers should have strongly typed impl() functions.
<https://webkit.org/b/121919>

Reviewed by Geoffrey Garen.

Generate strongly typed JSFoo::impl() functions for all wrappers,
not just those marked with JSGenerateToNativeObject.

Removed 8.8 million static_casts that are no longer needed.

12:22 PM Changeset in webkit [156418] by Patrick Gansterer

3 edits in trunk/Tools

[WIN] Fix MSVC C4146 compiler warning
https://bugs.webkit.org/show_bug.cgi?id=121838

Reviewed by Brent Fulgham.

Fix some variables from unsinged to int to fix the compiler warning
"unary minus operator applied to unsigned type, result still unsigned".

DumpRenderTree/WorkQueueItem.h:

(BackItem::BackItem):
(ForwardItem::ForwardItem):

DumpRenderTree/win/DumpRenderTree.cpp:

(createWebViewAndOffscreenWindow):

12:13 PM Changeset in webkit [156417] by zandobersek@gmail.com

2 edits in trunk/Tools

[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
https://bugs.webkit.org/show_bug.cgi?id=121256

Reviewed by Martin Robinson.

Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.

BuildSlaveSupport/build.webkit.org-config/config.json:

12:04 PM Changeset in webkit [156416] by roger_fong@apple.com

5 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=121885.
<rdar://problem/15072332>.

Reviewed by Brent Fulgham.

No new functionality added.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):

rendering/RenderLayer.h:
WebView.cpp:

(WebView::gestureNotify):
(WebView::gesture):

12:02 PM Changeset in webkit [156415] by zandobersek@gmail.com

4 edits in trunk/LayoutTests

Unreviewed GTK gardening. Moving WK1-specific failure expectations into the WK1-specific TestExpectations.
Also adding expectations for the currently failing tests on WK2.

platform/gtk-wk1/TestExpectations:
platform/gtk-wk2/TestExpectations:
platform/gtk/TestExpectations:

11:56 AM Changeset in webkit [156414] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix: Add new syntax of function declaration to
Windows export definition file.

11:52 AM Changeset in webkit [156413] by akling@apple.com

69 edits in trunk/Source/WebCore

Reduce repetitive EventTarget subclassing.
<https://webkit.org/b/121915>

Reviewed by Antti Koivisto.

Add a EventTargetWithInlineData helper class to EventTarget.h.
It's a simple subclass with an EventTargetData member and FINAL
eventTargetData()/ensureEventTargetData() overrides.

Turns out that this fits almost every use case except Node and
SVGElementInstance.

Inlined most of the FINAL EventTarget overrides since they will
be called on tight pointers by generated bindings code and this
removes the need for virtual dispatch.

Spammed OVERRIDE FINAL as appropriate, we can't make the whole
classes FINAL until bug 121747 is fixed, so added FIXMEs.

11:51 AM Changeset in webkit [156412] by zandobersek@gmail.com

1 edit
42 adds
12 deletes in trunk/LayoutTests

Unreviewed GTK gardening. Moving around and updating the GTK baselines that are
either specific to WK1 or WK2 or can be shared by both.

platform/gtk-wk1/http: Added.
platform/gtk-wk1/http/tests: Added.
platform/gtk-wk1/http/tests/cache: Added.
platform/gtk-wk1/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added.
platform/gtk-wk1/http/tests/security: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
platform/gtk-wk2/http: Added.
platform/gtk-wk2/http/tests: Added.
platform/gtk-wk2/http/tests/loading: Added.
platform/gtk-wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
platform/gtk-wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
platform/gtk-wk2/http/tests/misc: Added.
platform/gtk-wk2/http/tests/misc/401-alternative-content-expected.txt: Added.
platform/gtk-wk2/http/tests/misc/authentication-redirect-1: Added.
platform/gtk-wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Added.
platform/gtk-wk2/http/tests/misc/authentication-redirect-2: Added.
platform/gtk-wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
platform/gtk-wk2/http/tests/misc/authentication-redirect-4: Added.
platform/gtk-wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Added.
platform/gtk-wk2/http/tests/security: Added.
platform/gtk-wk2/http/tests/security/401-logout: Added.
platform/gtk-wk2/http/tests/security/401-logout/401-logout-expected.txt: Added.
platform/gtk-wk2/http/tests/xmlhttprequest: Added.
platform/gtk-wk2/http/tests/xmlhttprequest/failed-auth-expected.txt: Added.
platform/gtk-wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Added.
platform/gtk-wk2/js: Added.
platform/gtk-wk2/js/dom: Added.
platform/gtk-wk2/js/dom/constructor-length-expected.txt: Added.
platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Added.
platform/gtk/http/tests/cache: Removed.
platform/gtk/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Removed.
platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Removed.
platform/gtk/userscripts: Added.
platform/gtk/userscripts/script-run-at-end-expected.txt: Added.

11:43 AM Changeset in webkit [156411] by Brent Fulgham

2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix after r156408.

11:29 AM Changeset in webkit [156410] by ap@apple.com

2 edits in trunk/LayoutTests

loader/go-back-to-different-window-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=96642

platform/mac/TestExpectations: Marking it as flaky on Mac. I think that it's

a general issue with the tools that window resizing doesn't work well.

11:21 AM Changeset in webkit [156409] by commit-queue@webkit.org

6 edits in trunk

AX: WebKit doesn't map aria-sort=other on OS X
https://bugs.webkit.org/show_bug.cgi?id=118511

Patch by Sam White <Samuel White> on 2013-09-25
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing aria-sort test to validate addition of "other"
sort order per http://www.w3.org/TR/wai-aria/complete#aria-sort.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::sortDirection):

accessibility/AccessibilityObject.h:

LayoutTests:

Updated test to check "other" aria-sort order. Also added additional checks to
determine which elements expose aria-sort so our "none" case is more clear.

accessibility/aria-sort-expected.txt:
accessibility/aria-sort.html:

11:09 AM Changeset in webkit [156408] by weinig@apple.com

65 edits in trunk/Source/WebCore

CTTE: More Document references please
https://bugs.webkit.org/show_bug.cgi?id=121893

Reviewed by Anders Carlsson.

Thread even more Document&s around. *

11:07 AM Changeset in webkit [156407] by andersca@apple.com

2 edits in trunk/Source/WebCore

HasMemoryCostMemberFunction should work for final classes
https://bugs.webkit.org/show_bug.cgi?id=121747

Reviewed by Sam Weinig.

Use decltype to check for the memoryCost() member function. This doesn't check that the return type is size_t, but
the build will fail anyway if that's the case (or if the return type is not convertible to size_t).

bindings/js/JSDOMBinding.h:

11:02 AM Changeset in webkit [156406] by beidson@apple.com

11 edits
13 moves
1 delete in trunk/Source/WebCore

More refactoring to make the LevelDB dependencies of IDB more obvious.
https://bugs.webkit.org/show_bug.cgi?id=121880

Reviewed by Alexey Proskuryakov.

This patch does three things:
1 - Moves some files to the indexeddb/leveldb subdirectory, renaming them in the process.
2 - Renames some classes.
3 - Adds "USE(LEVELDB)" guards in addition to the ENABLE(INDEXED_DATABASE) guard for those files.

Project file updates:

GNUmakefile.am:
GNUmakefile.list.am:
Target.pri:
WebCore.xcodeproj/project.pbxproj:
WebCore.vcxproj/WebCore.vcxproj:

File renames, class renames, and USE(LEVELDB) guards:

Modules/indexeddb/IDBBackingStore.cpp: Removed.
Modules/indexeddb/IDBFactoryBackendInterface.cpp:

(WebCore::IDBFactoryBackendInterface::create): Add a null return if USE(LEVELDB) is disabled as a stop gap measure until

there is a non-LevelDB impl.

Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBBackingStore.h.
Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp.
Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h.
Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp.
Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.h.
Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
Modules/indexeddb/leveldb/IDBLevelDBCoding.h:
Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp.
Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h.
Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.cpp.
Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.h.

11:00 AM Changeset in webkit [156405] by Patrick Gansterer

3 edits in trunk/Tools

Add style checker for CMake lists
https://bugs.webkit.org/show_bug.cgi?id=121764

Reviewed by Ryosuke Niwa.

Add an additional check to make sure that list of files are sorted.
Exclude lists of include directories for now, since the order
can be importent for compilation of some files.

Scripts/webkitpy/style/checkers/cmake.py:

(CMakeChecker.check):
(CMakeChecker._check_indent):
(CMakeChecker):
(CMakeChecker._check_list_order):
(CMakeChecker._list_item_path):

Scripts/webkitpy/style/checkers/cmake_unittest.py:

(CMakeCheckerTest.test_check):

10:45 AM Changeset in webkit [156404] by Antti Koivisto

4 edits
2 adds in trunk

REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
https://bugs.webkit.org/show_bug.cgi?id=121904

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/table/hittest-self-painting.html

Original reduction by Philippe Wittenbergh.

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

Tighten a bit.

(WebCore::RenderTableRow::nodeAtPoint):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

These flipped accidentally in r156355.

LayoutTests:

fast/table/hittest-self-painting-expected.txt: Added.
fast/table/hittest-self-painting.html: Added.

10:40 AM Changeset in webkit [156403] by Patrick Gansterer

5 edits in trunk/Tools

CMakeChecker takes unusually long time to run
https://bugs.webkit.org/show_bug.cgi?id=105662

Reviewed by Ryosuke Niwa.

Move the caching mechanism for regular expression of the C++ checker into
a common file and use it for the CMake and ChangeLog checkers too.

Scripts/webkitpy/style/checkers/changelog.py:

(ChangeLogChecker.check_entry):

Scripts/webkitpy/style/checkers/cmake.py:

(CMakeChecker._process_line):
(CMakeChecker._check_no_space_cmds):
(CMakeChecker._check_one_space_cmds):
(CMakeChecker._check_non_lowercase_cmd):

Scripts/webkitpy/style/checkers/common.py:

(match):
(search):
(searchIgnorecase):
(sub):
(subn):

Scripts/webkitpy/style/checkers/cpp.py:

9:33 AM Changeset in webkit [156402] by Patrick Gansterer

2 edits in trunk/Source/JavaScriptCore

Build fix for WinCE after r155098.

Windows CE does not support getenv().

jsc.cpp:

(main):

9:32 AM Changeset in webkit [156401] by Patrick Gansterer

2 edits in trunk/Source/WTF

Fix template deduction for CollatorDefault

wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::userDefault): Use nullptr instead of 0.

9:08 AM Changeset in webkit [156400] by berto@igalia.com

2 edits in trunk/Source/WebCore

Fix warning in makeprop.pl
https://bugs.webkit.org/show_bug.cgi?id=121900

Reviewed by Ryosuke Niwa.

%nameIsInherited and %nameToId were incorrectly initialized using
references instead of lists.

Anyway there's no need to initialize those variables explicitly,
they're already empty by default.

css/makeprop.pl:

9:02 AM Changeset in webkit [156399] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

REGRESSION(r156393): Build with !ENABLE(SVG_FONTS) broken

Unreviewed build-fix.

Protect SVG font code with #ifdef ENABLE(SVG_FONTS).

platform/graphics/WidthIterator.cpp:

(WebCore::applyFontTransforms):

8:41 AM Changeset in webkit [156398] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r156272.
http://trac.webkit.org/changeset/156272
https://bugs.webkit.org/show_bug.cgi?id=121909

Has no real effect (Requested by carewolf on #webkit).

platform/graphics/qt/TileQt.cpp:

(WebCore::TileQt::updateBackBuffer):

8:40 AM Changeset in webkit [156397] by akling@apple.com

16 edits in trunk/Source/WebCore

Move wheel event dispatch from Node to Element.
<https://webkit.org/b/121908>

Reviewed by Anders Carlsson.

Wheel events are only ever dispatched on Elements, so move the logic out of Node.

Had to make RenderBox::scroll() and friends return a stopElement instead of a
stopNode (out argument) to make this work, though it was only ever returning
Elements there anyway.

8:06 AM Changeset in webkit [156396] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. Unskip passing fast/text/font-kerning.html
https://bugs.webkit.org/show_bug.cgi?id=121907

Unreviewed EFL gardening. Passes after r152411.

Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-09-25

platform/efl/TestExpectations:

7:57 AM Changeset in webkit [156395] by allan.jensen@digia.com

13 edits in trunk

[Qt] Fix build with Qt 5.2 QtPosition module
https://bugs.webkit.org/show_bug.cgi?id=121089

Reviewed by Simon Hausmann.

QtLocation -> QtPositioning

Source/sync.profile:

Source/WebKit:

QtLocation -> QtPositioning

WebKit1.pri:

Source/WebKit/qt:

QtLocation -> QtPositioning

WebCoreSupport/GeolocationClientQt.cpp:

Source/WebKit2:

QtLocation -> QtPositioning

Target.pri:
UIProcess/qt/WebGeolocationProviderQt.cpp:
WebKit2.pri:

Tools:

QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
that might depend on them.

qmake/mkspecs/features/default_pre.prf:
qmake/mkspecs/features/features.prf:

7:50 AM Changeset in webkit [156394] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[Qt] Fix build with !ENABLE(BLOB) after r156330

Unreviewed build-fix.

platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

7:19 AM Changeset in webkit [156393] by allan.jensen@digia.com

13 edits
3 adds in trunk

Support kerning with SVG web fonts
https://bugs.webkit.org/show_bug.cgi?id=117540

Source/WebCore:

Reviewed by Stephen Chenney.

Adds the glue to WidthIterator to take advantage of kerning in SVG web fonts.
To supply SVG font kerning with its required text input, the signature of
applyFontTransforms has been extended.

Since SVG font kerning was extremely slow, it has been sped up by replacing
the iteration over all possible kerning definitions with a hash-map based
lookup of the leading symbol to be kerned. The new algorithm provides a
roughly 100x speed-up in SVG font kerning.

Test: fast/text/svg-font-face-with-kerning.html

platform/graphics/TextRun.h:

(WebCore::TextRun::string):

platform/graphics/WidthIterator.cpp:

(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):

rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::applySVGKerning):

rendering/svg/SVGTextRunRenderingContext.h:
svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::invalidateGlyphCache):
(WebCore::SVGFontElement::ensureGlyphCache):
(WebCore::SVGKerningMap::clear):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):
(WebCore::stringMatchesGlyphName):
(WebCore::stringMatchesUnicodeName):
(WebCore::matches):
(WebCore::kerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):

svg/SVGFontElement.h:

(WebCore::SVGKerning::SVGKerning):
(WebCore::SVGKerningMap::isEmpty):

svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::buildHorizontalKerningPair):

svg/SVGHKernElement.h:
svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::buildVerticalKerningPair):

svg/SVGVKernElement.h:

LayoutTests:

Added test of SVG web font kerning.

Reviewed by Stephen Chenney.

fast/text/svg-font-face-with-kerning-expected.png: Added.
fast/text/svg-font-face-with-kerning-expected.txt: Added.
fast/text/svg-font-face-with-kerning.html: Added.

7:16 AM Changeset in webkit [156392] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Update test expectations. Mark fast/images/exif-orientation.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=121906

Unreviewed GTK gardening.

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-09-25

platform/gtk/TestExpectations: Mark fast/images/exif-orientation.html as failing,

as reported in webkit.org/b/121905.

6:53 AM Changeset in webkit [156391] by commit-queue@webkit.org

10 edits
9 adds in trunk

<https://webkit.org/b/120476> [CSS Masking] Implement luminance masking

Source/WebCore:

Added implementation for luminance masking. A luminance mask is applied by transforming its RGB values into
an alpha value, using luminance-to-alpha coefficients. Because this conversion is already implemented in
the ImageBuffer class, we used it in our implementation.

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-25
Reviewed by Dirk Schulze.

Tests: css3/masking/mask-luminance-gradient.html

css3/masking/mask-luminance-png.html
css3/masking/mask-luminance-svg.html

platform/graphics/BitmapImage.cpp: Add a drawPattern method, in which an ImageBuffer is created and converted from alpha to luminance, if there is a luminance mask.

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::drawPattern):

platform/graphics/BitmapImage.h:
platform/graphics/GeneratorGeneratedImage.cpp: Convert the ImageBuffer to luminance, if necessary.

(WebCore::GeneratorGeneratedImage::drawPattern):

platform/graphics/GraphicsContext.cpp: Add methods which set and check if a luminance mask is drawn.

(WebCore::GraphicsContext::setDrawLuminanceMask):
(WebCore::GraphicsContext::drawLuminanceMask):

platform/graphics/GraphicsContext.h: Add property to ContextState for luminance drawing.

(WebCore::GraphicsContextState::GraphicsContextState):

rendering/RenderBoxModelObject.cpp: Set the luminance property of the mask, if the layer has a mask source type of luminance.

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

svg/graphics/SVGImage.cpp: Convert the ImageBuffer to luminance, if necessary.

(WebCore::SVGImage::drawPatternForContainer):

svg/graphics/SVGImageForContainer.cpp: Pass the luminance property to the SVG image.

(WebCore::SVGImageForContainer::drawPattern):

LayoutTests:

Added tests to verify the implementation of luminance masking.

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-25
Reviewed by Dirk Schulze.

css3/masking/mask-luminance-gradient-expected.html: Added.
css3/masking/mask-luminance-gradient.html: Added.
css3/masking/mask-luminance-png.html: Added.
css3/masking/mask-luminance-svg-expected.html: Added.
css3/masking/mask-luminance-svg.html: Added.
css3/masking/resources/circle-alpha.svg: Added.
css3/masking/resources/circle2.svg: Added.
css3/masking/resources/dice.png: Added.
platform/mac/css3/masking/mask-luminance-png-expected.txt: Added.

6:02 AM Changeset in webkit [156390] by akling@apple.com

10 edits
2 deletes in trunk/Source/WebCore

Remove EventPathWalker.
<https://webkit.org/b/121890>

Reviewed by Antti Koivisto.

Purge some more leftover Shadow DOM code.

dom/EventPathWalker.cpp:
dom/EventPathWalker.h:

Removed.

dom/EventRetargeter.cpp:

(WebCore::nodeOrHostIfPseudoElement):
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):

If starting at a pseudo element, e.g for events originating from
a transition on :before/:after, retarget to the pseudo element's
host as appropriate. This was the only real "feature" we were
using in EventPathWalker.

page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleTouchEvent):

Replace use of EventPathWalker with parentOrShadowHostElement()
parent chain climbing.

5:50 AM Changeset in webkit [156389] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] Updated accessibility expectations after r154781 and r155599
https://bugs.webkit.org/show_bug.cgi?id=121901

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25

platform/efl/accessibility/menu-list-sends-change-notification-expected.txt:
platform/efl/accessibility/notification-listeners-expected.txt:

5:33 AM Changeset in webkit [156388] by mario@webkit.org

3 edits in trunk/Tools

[ATK] Fix style issues in AccessibilityUIElementAtk
https://bugs.webkit.org/show_bug.cgi?id=121898

Reviewed by Chris Fleizach.

Avoid the '.f' suffix for float literals and use G_VALUE_INIT
instead of { 0, { { 0 } } } to initialize a GValue.

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::clickPointX): Remove suffix.
(AccessibilityUIElement::clickPointY): Ditto.
(AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(AccessibilityUIElement::numberAttributeValue): Remove suffix.

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::clickPointX): Ditto.
(WTR::AccessibilityUIElement::clickPointY): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.

5:21 AM Changeset in webkit [156387] by commit-queue@webkit.org

4 edits
2 adds in trunk

:read-write pseudo-class should not be applied on <input type="text" disabled>
https://bugs.webkit.org/show_bug.cgi?id=118236

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-25
Reviewed by Darin Adler.

Source/WebCore:

The :read-write pseudo-class must match any element falling into one
of the following categories i.e
input elements to which the readonly attribute applies, and that are mutable
(i.e. that do not have the readonly attribute specified and that are not disabled)
textarea elements that do not have a readonly attribute, and that are not disabled
elements that are editing hosts or editable and are neither input elements nor
textarea elements.

Test: fast/css/readwrite-pseudoclass-input.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::matchesReadWritePseudoClass):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):
Checking for both readonly and disabled attribute on input ane textarea element.

LayoutTests:

fast/css/readwrite-pseudoclass-input-expected.txt: Added.
fast/css/readwrite-pseudoclass-input.html: Added.

Added test case to verify that :read-write pseudo-class properties are
are not applied to disabled input and textarea elements.

4:02 AM Changeset in webkit [156386] by commit-queue@webkit.org

9 edits in trunk

[EFL] accessibility/loading-iframe-sends-notification.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112003

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Enabled AXLayoutComplete on EFL platform.

dom/Document.cpp:

(WebCore::Document::implicitClose):

page/FrameView.cpp:

(WebCore::FrameView::layout):

Tools:

Enabled addNotificationListener and removeNotificationListener for EFL port.

WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

(WTR::AccessibilityController::removeNotificationListener):

LayoutTests:

platform/efl-wk1/TestExpectations: Removed loading-iframe-sends-notification.html.
platform/efl-wk2/TestExpectations: Removed loading-iframe-sends-notification.html.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed