⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 28, 2013:

11:02 PM Changeset in webkit [156615] by weinig@apple.com
  • 9 edits
    2 deletes in trunk/Source/WebCore

Merge ScriptControllerBase into ScriptController
​https://bugs.webkit.org/show_bug.cgi?id=122071

Reviewed by Antti Koivisto.

There is no need for ScriptControllerBase. Remove it.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: Removed.
  • bindings/ScriptControllerBase.h: Removed.
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canExecuteScripts):
(WebCore::ScriptController::executeScript):
(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/js/ScriptController.h:
10:42 PM Changeset in webkit [156614] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r156613 for ports enabling CSS3_TEXT.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::requiresIndent): Use the RenderStyle reference.

9:34 PM Changeset in webkit [156613] by Antti Koivisto
  • 21 edits in trunk/Source/WebCore

Switch inline boxes to use const RenderStyle&
​https://bugs.webkit.org/show_bug.cgi?id=122068

Reviewed by Sam Weinig.

1:20 PM Changeset in webkit [156612] by Antti Koivisto
  • 12 edits in trunk/Source/WebCore

Add first()/last() to ElementIteratorAdapters
​https://bugs.webkit.org/show_bug.cgi?id=122067

Reviewed by Darin Adler.

Add a convenient way for getting the first and last element if it exists.

Use it in some places.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • dom/Document.cpp:

(WebCore::Document::childrenChanged):
(WebCore::Document::removeTitle):

  • dom/ElementChildIterator.h:

(WebCore::::first):
(WebCore::::last):

  • dom/ElementDescendantIterator.h:

(WebCore::::first):
(WebCore::::last):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::legend):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::associatedControl):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::selectMediaResource):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::title):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):

1:01 PM Changeset in webkit [156611] by mrowe@apple.com
  • 18 edits
    2 copies in trunk

Fix some failures with newer versions of clang.

Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.

Reviewed by Dan Bernstein.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:
  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
  • DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
12:15 PM Changeset in webkit [156610] by mrowe@apple.com
  • 17 edits in trunk/Source

Take Xcode's advice and enable some extra warnings.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

  • Configurations/Base.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItemNS): Use the correct constant.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

  • Configurations/Base.xcconfig:
  • WTF.xcodeproj/project.pbxproj:
12:10 PM Changeset in webkit [156609] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE: VisitedLinkState should hold a Document&
​https://bugs.webkit.org/show_bug.cgi?id=122066

Reviewed by Antti Koivisto.

The Document can never be null, so use a reference.

11:30 AM Changeset in webkit [156608] by Antti Koivisto
  • 23 edits in trunk/Source/WebCore

Clean up code for getting first line style
​https://bugs.webkit.org/show_bug.cgi?id=122037

Reviewed by Andreas Kling.

We have confusing RenderObject::style(bool firstLine). Get rid of it in favour of
just using RenderObject::firstLineStyle() where appropriate.

Also switch to RenderStyle references in many places and move first line style caching
code down to RenderElement.

10:19 AM Changeset in webkit [156607] by Darin Adler
  • 44 edits in trunk/Source

Add Frame::mainFrame and Frame::isMainFrame
​https://bugs.webkit.org/show_bug.cgi?id=122064

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in: Removed exports of FrameView::isMainFrameView and

Page::frameIsMainFrame. Since the new isMainFrame function is inline, it
does not need to be exported.

  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
These two were the only functions I found that really wanted the equivalent
of Page::frameIsMainFrame, so wrote it out here instead of using a function
call.

  • inspector/InspectorAgent.cpp: Removed the unused isMainResourceLoader function.
  • inspector/InspectorAgent.h: Removed declarations of a few nonexistent or

unused private member functions. Also removed the InjectedScriptForOriginMap
typedef: It's mor readable to use the type directly

  • loader/FrameLoader.h: Removed isLoadingMainFrame. It's not better than

calling frame().isMainFrame() directly.

  • page/Frame.cpp:

(WebCore::Frame::Frame): Initialize m_mainFrame and call selfOnlyRef, keeping
the MainFrame alive as long as any of its subframes is alive.
(WebCore::Frame::~Frame): Call selfOnlyDeref.
(WebCore::Frame::createView): Use isMainFrame.
(WebCore::Frame::setPageAndTextZoomFactors): Ditto.

  • page/Frame.h: Added Frame::mainFrame, Frame::isMainFrame, and Frame::m_mainFrame.
  • page/FrameView.h: Removed the isMainFrameView function. It's not better than

calling frame().isMainFrame() directly.

  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame): Initialize m_selfOnlyRefCount to 0.
(WebCore::MainFrame::selfOnlyRef): Added.
(WebCore::MainFrame::selfOnlyDeref): Added.
(WebCore::MainFrame::dropChildren): Added. Called when the self-only reference
count reaches 0 to avoid a reference cycle with subframes.

  • page/MainFrame.h: Added new data members as mentioned above. Also, the

definition of the Frame::isMainFrame inline function goes here, since it can't
compile without the MainFrame class definition. This means that callers of
isMainFrame need to include MainFrame.h, which seems reasonable and is easy
to do.

  • page/Page.cpp:
  • page/Page.h: Added assertion to Page::mainFrame since it returns a reference.

Removed Page::frameIsMainFrame since it's not better than calling isMainFrame
on the frame.

  • dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):
(WebCore::Document::ensurePlugInsInjectedScript):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::shouldShrinkToFit):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::didClearWindowObjectInWorld):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::prepareForCachedPageRestore):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::didLayout):
(WebCore::FrameLoader::checkLoadComplete):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::loadProgressingStatusChanged):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateForSameDocumentNavigation):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):

  • loader/icon/IconController.cpp:

(WebCore::IconController::startLoader):

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::stopAutoscrollTimer):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • page/DOMWindow.cpp:

(WebCore::allowsBeforeUnloadListeners):
(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::blur):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::allowedToChangeWindowGeometry):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent):

  • page/FrameTree.cpp:

(WebCore::FrameTree::find):
(WebCore::FrameTree::traverseNextWithWrap):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::createScrollbar):
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
(WebCore::FrameView::shouldUpdateFixedElementsAfterScrolling):
(WebCore::FrameView::beginDeferredRepaints):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEventIfNeeded):
(WebCore::FrameView::pagination):
(WebCore::FrameView::visibleContentScaleFactor):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintScrollbar):
(WebCore::FrameView::paintOverhangAreas):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
Use the new functions where possible instead of Page::frameIsMainFrame,
Page::mainFrame, FrameLoader::isLoadingMainFrame, and FrameView::isMainFrameView.

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Call isMainFrame.

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::updateGlobalHistory):
Call isMainFrame.

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
Call isMainFrame.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canHandleRequest):
(WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebView/WebFrameView.mm:

(-[WebFrameView _install]):
Call isMainFrame.

Source/WebKit2:

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView):
Call isMainFrame.

9:14 AM Changeset in webkit [156606] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

filter: drop-shadow doesnot support viewport units
​https://bugs.webkit.org/show_bug.cgi?id=122053

Patch by Gurpreet Kaur <​k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.

Source/WebCore:

drop-shadow properties were not applied incase its values
were given in vh, vw, vmax, vmin units.

Tests: fast/css/drop-shadow-viewport-height.html

fast/css/drop-shadow-viewport-vmax.html
fast/css/drop-shadow-viewport-vmin.html
fast/css/drop-shadow-viewport-width.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):
Calculating the drop-shadow values which has been specified in viewport
units.The vh/vw units are calcultated as percent of viewport height and
viewport width respectively. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest.

LayoutTests:

  • fast/css/drop-shadow-viewport-height-expected-mismatch.html: Added.
  • fast/css/drop-shadow-viewport-height.html: Added.
  • fast/css/drop-shadow-viewport-vmax-expected-mismatch.html: Added.
  • fast/css/drop-shadow-viewport-vmax.html: Added.
  • fast/css/drop-shadow-viewport-vmin-expected-mismatch.html: Added.
  • fast/css/drop-shadow-viewport-vmin.html: Added.
  • fast/css/drop-shadow-viewport-width-expected-mismatch.html: Added.
  • fast/css/drop-shadow-viewport-width.html: Added.

Added new tests for verifying that drop-shadow properties are applied
when its values are viewport units.

9:10 AM Changeset in webkit [156605] by commit-queue@webkit.org
  • 5 edits
    16 adds in trunk

REGRESSION (r154614): Setting the document scroll position isn't symmetric; can successfully set document.body.scrollTop, but can only read from document.documentElement.scrollTop
​https://bugs.webkit.org/show_bug.cgi?id=121876

Patch by Gurpreet Kaur <​k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.

Source/WebCore:

Non-Quirks mode should set/get scrolltop/scrollleft through
document.documentElement.scrollTop/document.documentElement.scrollLeft
Quirks mode should set/get scrolltop/scrollleft through
document.body.scrollTop/document.body.scrollLeft.

Tests: fast/dom/Element/body-scrollLeft-Quirks.html

fast/dom/Element/body-scrollLeft.html
fast/dom/Element/body-scrollTop-Quirks.html
fast/dom/Element/body-scrollTop.html
fast/dom/Element/documentElement-scrollLeft-Quirks.html
fast/dom/Element/documentElement-scrollLeft.html
fast/dom/Element/documentElement-scrollTop-Quirks.html
fast/dom/Element/documentElement-scrollTop.html

  • dom/Element.cpp:

(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
Need to set the scrollTop and scrollLeft after checking if document
is in quirks or non-quirks mode. Incase it is body.scrollLeft/
body.scrollTop set only if document is in quirks mode. If document is
non-quirks mode set documentElement.scrollLeft/documentElement.scrollTop.

LayoutTests:

  • fast/dom/Element/body-scrollLeft-Quirks-expected.txt: Added.
  • fast/dom/Element/body-scrollLeft-Quirks.html: Added.
  • fast/dom/Element/body-scrollLeft-expected.txt: Added.
  • fast/dom/Element/body-scrollLeft.html: Added.
  • fast/dom/Element/body-scrollTop-Quirks-expected.txt: Added.
  • fast/dom/Element/body-scrollTop-Quirks.html: Added.
  • fast/dom/Element/body-scrollTop-expected.txt: Added.
  • fast/dom/Element/body-scrollTop.html: Added.
  • fast/dom/Element/documentElement-scrollLeft-Quirks-expected.txt: Added.
  • fast/dom/Element/documentElement-scrollLeft-Quirks.html: Added.
  • fast/dom/Element/documentElement-scrollLeft-expected.txt: Added.
  • fast/dom/Element/documentElement-scrollLeft.html: Added.
  • fast/dom/Element/documentElement-scrollTop-Quirks-expected.txt: Added.
  • fast/dom/Element/documentElement-scrollTop-Quirks.html: Added.
  • fast/dom/Element/documentElement-scrollTop-expected.txt: Added.
  • fast/dom/Element/documentElement-scrollTop.html: Added.

Added test cases for verifying that Non-Quirks mode should set
scrolltop/scrollleft through document.documentElement.scrollTop/
document.documentElement.scrollLeft and Quirks mode should set/get
scrolltop/scrollleft through document.body.scrollTop/document.body.scrollLeft.

  • fast/multicol/scrolling-overflow.html:

Rebaselining existing tests as per the new behavior. To set
document.body.scrollLeft document to be in Quirks mode.

8:05 AM Changeset in webkit [156604] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Message sending functions should only accept rvalues
​https://bugs.webkit.org/show_bug.cgi?id=122041

Reviewed by Andreas Kling.

In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::sendAbortingOnFailure):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::sendSync):

  • Shared/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):

  • UIProcess/WebContext.h:

(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

8:02 AM Changeset in webkit [156603] by Philippe Normand
  • 5 edits in trunk/Source

Unreviewed GTK build fix after r156560.

Source/WebKit/gtk:

  • WebCoreSupport/AcceleratedCompositingContext.h:

Source/WebKit2:

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::paintContents):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
7:15 AM Changeset in webkit [156602] by akling@apple.com
  • 25 edits in trunk/Source

Pass VM instead of ExecState to JSFunction constructors.
<​https://webkit.org/b/122014>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

JSFunction doesn't need the ExecState for anything during its
construction, so reduce the amount of loads by just passing the
VM around instead.

Factored out putDirectNonIndexAccessor() from the existing
putDirectAccessor() to avoid snowballing the patch (and because
it's kinda neat to avoid the extra branch.)

JSC release binary size -= 9680 bytes.

Source/WebCore:

Updated for new JSFunction::create() signature.

6:27 AM Changeset in webkit [156601] by gyuyoung.kim@samsung.com
  • 10 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSImageValue
​https://bugs.webkit.org/show_bug.cgi?id=122051

Reviewed by Andreas Kling.

Clean up static_cast<CSSImageValue*> type casts. It will help to
detect bad cast as well as improve code readability.

Removed unnecessary local variables as well.

No new tests, no behavior changes.

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::isSVGCursor):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

  • css/CSSImageValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForProperties):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):

3:26 AM Changeset in webkit [156600] by mrowe@apple.com
  • 21 edits in trunk/Source/WebCore

WebCore fails to build with newer versions of clang.

Reviewed by Sam Weinig.

  • Modules/indexeddb/IDBIndex.cpp: Remove an unused constant.
  • Modules/indexeddb/IDBObjectStore.cpp: Ditto.
  • Modules/webaudio/AudioContext.cpp: Ditto.
  • Modules/webaudio/ScriptProcessorNode.cpp: Ditto.
  • Modules/webdatabase/SQLResultSet.cpp: Ditto.
  • Modules/webdatabase/SQLTransactionBackend.cpp: Ditto.
  • Modules/websockets/WebSocketHandshake.cpp: Ditto.
  • bindings/objc/DOM.mm: Disable a warning about overriding a protocol method in a cateogry around the one

place we do it. I don't understand why this generates a warning, nor can I see a different approach that
would not result in the warning being emitted.

  • css/CSSGrammar.y.in: #if a function that's only used inside an #if.
  • html/track/TextTrackCue.cpp: Remove an unused constant.
  • loader/TextResourceDecoder.cpp: Remove two unused functions.
  • page/ContentSecurityPolicy.cpp: Add #if's around constants and functions that are only used when CSP_NEXT is enabled.

(WebCore::CSPDirectiveList::checkSourceAndReportViolation): Reorder the ifs slightly to make the #if'ing easier.

  • page/ContentSecurityPolicy.h: Add #if's around functions that are only used when CSP_NEXT is enabled.
  • page/DOMSecurityPolicy.cpp: Ditto.
  • page/DOMSecurityPolicy.h: Ditto.
  • page/animation/CSSPropertyAnimation.cpp: Remove an unused function.
  • platform/mac/DisplaySleepDisabler.cpp: Add an #if around a constant that's only used on iOS.
  • platform/mac/WebCoreFullScreenWarningView.mm: Remove three unused constants.
  • rendering/RenderLayer.cpp: Remove two unused constants.
  • rendering/RenderLayerCompositor.cpp:

(WebCore::compositingLogEnabled): Move the #if around the function definition.

  • svg/SVGAnimatedAngle.cpp: Remove an unused function.
  • svg/SVGUseElement.cpp: #if a function that's only used inside an ASSERT.
  • xml/XPathStep.cpp: Ditto.
3:25 AM Changeset in webkit [156599] by mrowe@apple.com
  • 6 edits in trunk/Source/WebKit/mac

WebKit fails to build with newer versions of clang.

Reviewed by Sam Weinig.

  • Carbon/HIWebView.mm: Remove an unused function.
  • History/BinaryPropertyList.cpp: #if a constant that's only used in 64-bit.
  • Misc/WebIconDatabase.mm: Remove two unused constants.
  • Plugins/WebBaseNetscapePluginView.mm: Remove an unused constant.
  • WebCoreSupport/WebEditorClient.mm: Ditto.
3:23 AM Changeset in webkit [156598] by mrowe@apple.com
  • 7 edits in trunk/Source/WebKit2

WebKit2 fails to build with newer versions of clang.

Reviewed by Anders Carlsson.

  • Shared/VisitedLinkTable.cpp: #if a function that's only used inside an ASSERT.
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Remove an unused constant.
  • UIProcess/mac/WKFullScreenWindowController.mm: Ditto.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Ditto.
  • WebProcess/WebPage/FindController.cpp: Ditto.
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: Remove two unused constants.
3:22 AM Changeset in webkit [156597] by mrowe@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JavaScriptCore fails to build with newer versions of clang.

Reviewed by Sam Weinig.

  • interpreter/Interpreter.cpp: Remove an unused function.
  • parser/SourceProvider.cpp: Ditto.
  • runtime/GCActivityCallback.cpp: #if a constant that's only used on non-CF platforms.
  • runtime/JSCJSValue.cpp: Remove an unused constant.
  • runtime/JSString.cpp: Ditto.
3:19 AM Changeset in webkit [156596] by mrowe@apple.com
  • 5 edits in trunk/Source/WTF

<rdar://problem/15079224> WTF fails to build with newer versions of clang.

Reviewed by Sam Weinig.

  • wtf/DateMath.cpp: Remove some unused constants.
  • wtf/FastMalloc.cpp: #if some constants and functions that are unused in some configurations.

Remove a function that's unused on all platforms.

  • wtf/TCSystemAlloc.cpp: Remove some unused constants.

(TCMalloc_SystemRelease): Remove an if whose body is never executed.

  • wtf/dtoa.cpp: #if things such that storeInc is only defined when USE_LONG_LONG is undefined.

Remove an unused constant.

Sep 27, 2013:

10:35 PM Changeset in webkit [156595] by ap@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Restore accidentally removed ChangeLog lines.

9:08 PM Changeset in webkit [156594] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Get rid of SetMyScope/SetCallee; use normal variables for the scope and callee of inlined call frames of closures
​https://bugs.webkit.org/show_bug.cgi?id=122047

Reviewed by Oliver Hunt.

Currently we have the DFG reserve space for inline call frames at exactly the same stack
offsets that you would have gotten if the baseline interpreter/JIT had made the calls.
We need to get rid of that. One of the weirder parts of this is that we have special DFG
operations for accessing these inlined call frame headers. It's really hard for any
analysis of DFG IR to see what the liveness of any of those frame header "variables" is;
the liveness behaves like flushed arguments (it's all live until end of the inlinee) but
we don't have anything like a Flush node for those special variables.

This patch gets rid of the special operations for accessing inline call frame headers.
GetMyScope and GetCallee still remain, and are only for accessing the machine call
frame's scope/callee entries. The inline call frame's scope/callee now behave like
normal variables, and have Flush behavior just like inline arguments.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::getScope):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:32 PM Changeset in webkit [156593] by Bem Jones-Bey
  • 3 edits
    10 adds in trunk/LayoutTests

[CSS Shapes] New positioning model: Positive margins
​https://bugs.webkit.org/show_bug.cgi?id=118089

Reviewed by Alexandru Chiculita.

The remaining tests for shape-outside with positive margins. These
have all been imported from the CSSWG's repo.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
5:11 PM Changeset in webkit [156592] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/media-controller-playback.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=122042

  • platform/mac/TestExpectations: Marked as such.
5:03 PM Changeset in webkit [156591] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

4:45 PM Changeset in webkit [156590] by beidson@apple.com
  • 32 edits in trunk/Source/WebCore

IndexedDB IDL Refactoring.
​https://bugs.webkit.org/show_bug.cgi?id=121996

Reviewed by Alexey Proskuryakov.

This includes:
1 - Leveraging EventTarget.idl inheritance
2 - Removing comments
3 - Reordering to match the spec's IDLs
4 - Removing nonstandard, WebKit-specific methods
5 - Updating interfaces to match the spec (versions are only uint64_t's now...)
6 - Updating implementation code as needed (versions are only uint64_t's now...)

IDL changes:

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • Modules/indexeddb/IndexedDB.h: Add new enum to represent version nullness.

Adapt to new IDLs, and also refactor representation of initial, null versioning:

  • Modules/indexeddb/IDBCallbacks.h:

(WebCore::IDBCallbacks::onBlocked):
(WebCore::IDBCallbacks::onUpgradeNeeded):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version):
(WebCore::IDBDatabase::onVersionChange):

  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBDatabaseCallbacks.h:
  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBFactory.h:
  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):

  • Modules/indexeddb/IDBOpenDBRequest.h:
  • Modules/indexeddb/IDBRequest.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IDBVersionChangeEvent.cpp:

(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):

  • Modules/indexeddb/IDBVersionChangeEvent.h:

(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::oldVersion):
(WebCore::IDBVersionChangeEvent::newVersion):

Keep leveldb building with minimal adaptations to the new IDLs,
but note that the LevelDB implementation is now incompatible with the spec:

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::openInternal):
(WebCore::IDBDatabaseBackendLevelDB::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendLevelDB::processPendingCalls):
(WebCore::IDBDatabaseBackendLevelDB::openConnection):
(WebCore::IDBDatabaseBackendLevelDB::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendLevelDB::deleteDatabase):
(WebCore::IDBDatabaseBackendLevelDB::deleteDatabaseFinal):
(WebCore::IDBDatabaseBackendLevelDB::VersionChangeAbortOperation::perform):

  • Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):

  • inspector/InspectorIndexedDBAgent.cpp: Update for metadata change.
4:40 PM Changeset in webkit [156589] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

CookieStorageShim should be PLATFORM(MAC) guarded
​https://bugs.webkit.org/show_bug.cgi?id=121423

Reviewed by Darin Adler.

Original patch by Kwang Yul Seo <​skyul@company100.com>.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

4:29 PM Changeset in webkit [156588] by enrica@apple.com
  • 22 edits in trunk/Source

Upstream changes to Pasteboard implementation for iOS.
​https://bugs.webkit.org/show_bug.cgi?id=121818

Reviewed by Benjamin Poulain.

Source/WebCore:

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::dispatchCPPEvent):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::addFragment):
(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readFilenames):
(WebCore::Editor::WebContentReader::readHTML):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::uniqueURLWithRelativePart):
(WebCore::Editor::WebContentReader::readImage):
(WebCore::Editor::WebContentReader::readURL):
(WebCore::Editor::WebContentReader::readPlainText):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::createFragmentAndAddResources):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):

  • platform/Pasteboard.h:
  • platform/PasteboardStrategy.h:
  • platform/PlatformPasteboard.h:
  • platform/ios/PasteboardIOS.mm:

(WebCore::PasteboardWebContent::PasteboardWebContent):
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::types):

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::changeCount):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::count):
(WebCore::PlatformPasteboard::readBuffer):
(WebCore::PlatformPasteboard::readString):
(WebCore::PlatformPasteboard::readURL):

  • platform/mac/PasteboardMac.mm:

(WebCore::PasteboardWebContent::PasteboardWebContent):
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):

  • platform/mac/PlatformPasteboardMac.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::writeToPasteboard):
(WebPlatformStrategies::getPasteboardItemsCount):
(WebPlatformStrategies::readBufferFromPasteboard):
(WebPlatformStrategies::readURLFromPasteboard):
(WebPlatformStrategies::readStringFromPasteboard):
(WebPlatformStrategies::changeCount):

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::decodeSharedBuffer):

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::writeWebContentToPasteboard):
(WebKit::WebContext::writeImageToPasteboard):
(WebKit::WebContext::writeStringToPasteboard):
(WebKit::WebContext::readStringFromPasteboard):
(WebKit::WebContext::readURLFromPasteboard):
(WebKit::WebContext::readBufferFromPasteboard):
(WebKit::WebContext::getPasteboardItemsCount):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::writeToPasteboard):
(WebKit::WebPlatformStrategies::getPasteboardItemsCount):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
(WebKit::WebPlatformStrategies::readURLFromPasteboard):
(WebKit::WebPlatformStrategies::readStringFromPasteboard):
(WebKit::WebPlatformStrategies::changeCount):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
4:19 PM Changeset in webkit [156587] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/win

[Windows] Unreviewed build fix following r156560.

  • WebView.h:
4:17 PM Changeset in webkit [156586] by hmuller@adobe.com
  • 12 edits
    4 adds in trunk

Crash on shape-outside when using calc()
​https://bugs.webkit.org/show_bug.cgi?id=121020

Reviewed by Dirk Schulze.

Source/WebCore:

This change prevents a crash caused by specifying a CSS Shape geometry
Length attribute with a calc() expression. It adds support for converting
Lengths to CSSPrimitive Values, in large part by migrating Blink changes
made to the calc classes since the split. Doing so required a few supporting
changes in some related classes, notably CSSPrimitiveValue.

Tests: fast/shapes/shape-inside/shape-inside-calc-crash.html

css3/calc/simplification.html

  • css/BasicShapeFunctions.cpp:

(WebCore::convertToCSSPrimitiveValue): Effectively use the new CSSPrimtiveValue(length,style) constructor to convert Lengths to CSSValues.
(WebCore::valueForBasicShape): Use the convertToCSSPrimitiveValue() function.
(WebCore::convertToLength): Added the CalculatedConversion convertToLength() flag to enable support for calc() valued Length Shape attributes.

  • css/BasicShapeFunctions.h:
  • css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):
(WebCore::buildCssText):
(WebCore::CSSCalcValue::clampToPermittedRange):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcExpressionNode::~CSSCalcExpressionNode):
(WebCore::CSSCalcPrimitiveValue::create):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::primitiveType):
(WebCore::CSSCalcPrimitiveValue::CSSCalcPrimitiveValue):
(WebCore::determineCategory):
(WebCore::isIntegerResult):
(WebCore::CSSCalcBinaryOperation::create):
(WebCore::CSSCalcBinaryOperation::createSimplified):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(WebCore::CSSCalcBinaryOperation::buildCssText):
(WebCore::CSSCalcBinaryOperation::primitiveType):
(WebCore::CSSCalcBinaryOperation::CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::getNumberSide):
(WebCore::CSSCalcBinaryOperation::evaluate):
(WebCore::CSSCalcBinaryOperation::evaluateOperator):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
(WebCore::CSSCalcExpressionNodeParser::parseValueTerm):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
(WebCore::CSSCalcValue::createExpressionNode):
(WebCore::CSSCalcValue::create):

  • css/CSSCalculationValue.h:

(WebCore::CSSCalcExpressionNode::category):
(WebCore::CSSCalcValue::create):
(WebCore::CSSCalcValue::isInt):
(WebCore::CSSCalcValue::permittedValueRange):
(WebCore::CSSCalcValue::expressionNode):
(WebCore::CSSCalcValue::CSSCalcValue):
(WebCore::toCSSCalcValue):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Pass the style along to the new valueForBasicShape() function.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::unitCategory): Made this function public so that CSSCalculationValue could use it.
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor): Ditto.
(WebCore::CSSPrimitiveValue::primitiveType): Cleared trailing whitespace.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
(WebCore::CSSPrimitiveValue::init): The common part of the two Length CSSPrimitiveValue constructors.
(WebCore::CSSPrimitiveValue::computeLengthDouble): Moved the case labels to the left per check-webkit-style.
(WebCore::CSSPrimitiveValue::getStringValue): Ditto.
(WebCore::CSSPrimitiveValue::getDoubleValue): Removed trailing whitespace.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::create): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
(WebCore::toCSSPrimitiveValue): Check the CSSValue*'s validity with ASSERT_WITH_SECURITY_IMPLICATION before casting to CSSPrimitiveValue*.

  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createValue): A new overload that delegates to the new CSSPrimitiveValue(length,style) constructor.

  • platform/CalculationValue.h:

(WebCore::CalculationValue::operator==):
(WebCore::CalculationValue::isNonNegative):
(WebCore::CalculationValue::expression):
(WebCore::CalcExpressionNumber::value):
(WebCore::toCalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::length):
(WebCore::toCalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::leftSide):
(WebCore::CalcExpressionBinaryOperation::rightSide):
(WebCore::CalcExpressionBinaryOperation::getOperator):
(WebCore::toCalcExpressionBinaryOperation):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::from):
(WebCore::CalcExpressionBlendLength::to):
(WebCore::CalcExpressionBlendLength::progress):
(WebCore::toCalcExpressionBlendLength):

LayoutTests:

Specifying a CSS Shape geometry Length attribute with a calc() expression
or looking up the value with getComputedStyle(), caused crashes.

  • fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt: Added.
  • fast/shapes/shape-inside/shape-inside-calc-crash.html: Added.
  • css3/calc/simplification-expected.txt: Added
  • css3/calc/simplification.html: Added
  • LayoutTests/css3/calc/cssom-expected.txt:
4:09 PM Changeset in webkit [156585] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test animations/combo-transform-translate+scale.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=122040

  • platform/mac/TestExpectations: Marking as such.
4:05 PM Changeset in webkit [156584] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/track/track-cue-overlap-snap-to-lines-not-set.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=122039

  • platform/mac/TestExpectations: Marking as such.
4:01 PM Changeset in webkit [156583] by ap@apple.com
  • 2 edits in trunk/LayoutTests

animations/transform-non-accelerated.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=122038

  • platform/mac/TestExpectations: Marking as such.
3:34 PM Changeset in webkit [156582] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r154219): 30% more malloc memory used on html5-full-render.
<​https://webkit.org/b/122034>

Reviewed by Antti Koivisto.

canExecuteScripts() used to rely on Frame::settings() returning null
when the Frame was disconnected from its Page, and giving Frame its
own handle on the Settings broke this mechanism.

This caused us to hold on for some objects for a bit longer than we
needed to in the run-perf-tests harness, showing up as a massive 30%
regression in malloc memory use.

Fixed it by added an explicit null check of Frame::page().

3:24 PM Changeset in webkit [156581] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Fixed linker symbols I broke last time.

3:14 PM Changeset in webkit [156580] by ap@apple.com
  • 22 edits in trunk/Source/WebCore

Updating bindings test results after KURL->URL rename.

Includes were now in the wrong order.

  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
  • bindings/scripts/test/CPP/WebDOMTestException.cpp:
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObject.mm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm:
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm:
  • bindings/scripts/test/ObjC/DOMTestEventConstructor.mm:
  • bindings/scripts/test/ObjC/DOMTestEventTarget.mm:
  • bindings/scripts/test/ObjC/DOMTestException.mm:
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
3:05 PM Changeset in webkit [156579] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

Add supporting logic for r156570.

3:01 PM Changeset in webkit [156578] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r156569.
​http://trac.webkit.org/changeset/156569
​https://bugs.webkit.org/show_bug.cgi?id=122035

broke a lot of mismatch tests (Requested by thorton on
#webkit).

Tools:

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.
2:54 PM Changeset in webkit [156577] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix for Win64.

Patch by Alex Christensen <​alex.christensen@flexsim.com> on 2013-09-27

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Added and fixed 64-bit linker symbols.

2:52 PM Changeset in webkit [156576] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/video-duration-known-after-eos.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=122033

  • platform/mac/TestExpectations: Marked as such.
2:29 PM Changeset in webkit [156575] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Get MediaStreamCenterGStreamer compiling again
​https://bugs.webkit.org/show_bug.cgi?id=122029

After MediaStream cleanup commit, it was not building anymore.

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Eric Carlson.

No new tests needed.

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
2:18 PM Changeset in webkit [156574] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Storing a reference to MediaStreamTrack in RTCStatsRequest
​https://bugs.webkit.org/show_bug.cgi?id=122030

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Eric Carlson.

The spec[1] says that the stats is related to a MediaStreamTrack object.
It also says: "Evaluate the need for other selectors than MediaStreamTrack".
So a MediaStreamTrack object is more suitable in this case.

[1]​http://dev.w3.org/2011/webrtc/editor/webrtc.html#stats-selector

No new tests needed.

  • Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::hasSelector):
(WebCore::RTCStatsRequestImpl::track):

  • Modules/mediastream/RTCStatsRequestImpl.h:
  • platform/mediastream/RTCStatsRequest.h:
2:15 PM Changeset in webkit [156573] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r156546): 18 media tests broken
​https://bugs.webkit.org/show_bug.cgi?id=122021

  • platform/mac/TestExpectations: Adding one more test, media/track/track-cue-rendering-vertical.html
2:11 PM Changeset in webkit [156572] by ap@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Intermittent crash on media/video-controls-captions-trackmenu.html
​https://bugs.webkit.org/show_bug.cgi?id=110173

This code got rewritten, and the test now just fails. Fixing and re-enabling it
is tracked in a different bug.

  • platform/mac/TestExpectations: Removing superfluous entry which was confusing the parser.
1:48 PM Changeset in webkit [156571] by ap@apple.com
  • 2 edits in trunk/Tools

Don't retry failures on Apple MountainLion Release WK1 tester
​https://bugs.webkit.org/show_bug.cgi?id=122026

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures

on this bot.

1:47 PM Changeset in webkit [156570] by ap@apple.com
  • 3 edits in trunk/Tools

Don't hardcode builder specific configuration in buildbot master.cfg
​https://bugs.webkit.org/show_bug.cgi?id=122023

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments

property to Qt Mountain Lion Release, making it run pixel tests.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start): Use additionalArguments.
(RunWebKit2Tests.start): Don't hardcode individual bot behavior here.

1:47 PM Changeset in webkit [156569] by timothy_horton@apple.com
  • 3 edits
    2 adds in trunk

[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
​https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>

Reviewed by Dean Jackson.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.

Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.

  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
1:44 PM Changeset in webkit [156568] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test fast/animation/request-animation-frame-time-unit.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=122031

  • platform/mac/TestExpectations: Marking as such. Dean is going to look into

related issues soon.

1:25 PM Changeset in webkit [156567] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[Nix] Updating Nix trunk files
​https://bugs.webkit.org/show_bug.cgi?id=121752

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Benjamin Poulain.

Source/WebCore:

No new tests needed.

  • page/nix/EventHandlerNix.cpp:

(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):

  • platform/DragImage.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/nix/DragImageNix.cpp:

(WebCore::createDragImageFromImage):

  • platform/nix/GamepadsNix.cpp:

(WebCore::sampleGamepads):

  • platform/nix/LanguageNix.cpp:

(WebCore::platformLanguage):

  • platform/nix/LocalizedStringsNix.cpp:

(WebCore::unacceptableTLSCertificate):

  • platform/nix/PasteboardNix.cpp:

(WebCore::Pasteboard::types):

  • platform/nix/RenderThemeNix.cpp:

(WebCore::toColor):
(WebCore::themeEngine):
(WebCore::webCanvas):
(WebCore::getWebThemeState):
(WebCore::RenderThemeNix::paintButton):
(WebCore::RenderThemeNix::paintTextField):
(WebCore::RenderThemeNix::paintCheckbox):
(WebCore::RenderThemeNix::paintRadio):
(WebCore::RenderThemeNix::paintMenuList):
(WebCore::RenderThemeNix::paintProgressBar):
(WebCore::RenderThemeNix::paintInnerSpinButton):
(WebCore::RenderThemeNix::paintMeter):

Source/WTF:

  • wtf/nix/FeatureDefinesNix.h:
1:06 PM Changeset in webkit [156566] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics] fix build after r156560
​https://bugs.webkit.org/show_bug.cgi?id=122028

Fixing build.

Patch by Ralph Thomas <​ralpht@gmail.com> on 2013-09-27
Reviewed by Anders Carlsson.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::paintLayerContents):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
12:22 PM Changeset in webkit [156565] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit/win

Attempt to fix Windows build.

11:49 AM Changeset in webkit [156564] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Deoptimize 32-bit deoptimization
​https://bugs.webkit.org/show_bug.cgi?id=122025

Reviewed by Oliver Hunt.

Just simplifying a bunch of code. I don't want the old, super-complicated,
deoptimization code to get in the way of changes I'll be making to DFG stack layout.

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::dumpInContext):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

11:48 AM Changeset in webkit [156563] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

11:46 AM Changeset in webkit [156562] by Lucas Forschler
  • 1 copy in tags/Safari-537.60.3

New Tag.

11:41 AM Changeset in webkit [156561] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r156546): 17 media tests broken
​https://bugs.webkit.org/show_bug.cgi?id=122021

Unreviewed gardening; add failing tests to TestExpectations while triaging new failures.

  • platform/mac/TestExpectations:
11:38 AM Changeset in webkit [156560] by andersca@apple.com
  • 27 edits in trunk/Source

Use std::unique_ptr for GraphicsLayer creation
​https://bugs.webkit.org/show_bug.cgi?id=122020

Reviewed by Antti Koivisto.

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayerFactory.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::create):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::createGraphicsLayer):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::hasScrollingLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):

  • rendering/RenderLayerCompositor.h:

Source/WebKit2:

  • UIProcess/mac/RemoteLayerTreeHost.h:
  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::getOrCreateLayer):

  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):

  • WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
  • WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::createGraphicsLayer):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):

11:36 AM Changeset in webkit [156559] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed Win64 build after r156184.
​https://bugs.webkit.org/show_bug.cgi?id=121994

Reviewed by Oliver Hunt.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupTwoStubArgsGPR):
(JSC::CCallHelpers::setupTwoStubArgsFPR):
Renamed from setupTwoStubArgs.
Visual Studio x64 compiler fails to see that this is an overloaded template function.
(JSC::CCallHelpers::setupStubArguments):
(JSC::CCallHelpers::setupArguments):
(JSC::CCallHelpers::setupArgumentsWithExecState):
Use setupTwoStubArgsGPR or setupTwoStubArgsFPR instead of setupTwoStubArgs.

11:34 AM Changeset in webkit [156558] by Beth Dakin
  • 23 edits in trunk/Source

ScrollbarPainterController should adopt the api to lock overlay scrollbar state
​https://bugs.webkit.org/show_bug.cgi?id=121928

Reviewed by Sam Weinig.

Source/WebCore:

ScrollbarPainterController should adopt the api to lock overlay scrollbar state.
This will allow the ScrollbarPainterController and ScrollAnimatorMac to have
control over knowing whether or not the scrollbars are currently active, which
will allow us to remove a bunch of functions previously implemented in
ScrollableArea subclasses to answer that question.

ScrollableArea::scrollbarsCanBeActive() is not longer virtual. It used to
implemented on ScrollableArea subclasses, but now ScrollableArea can just get the
information from the ScrollAnimator.

  • WebCore.exp.in:

When ScrollableArea subclasses implemented scrollbarsCanBeActive(), they would
check to see if the document was in the page cache. Instead of that model, this
patch adopts a model where ScrollbarPainterController is told directly whether or
not it is active via shouldLockOverlayScrollbarsToHidden(bool).

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):

setAnimatorsAreActive() is no longer necessary. The functionality can be bundled
into shouldLockOverlayScrollbarsToHidden(bool).
(WebCore::Document::documentDidResumeFromPageCache):

Remove implementations of scrollbarsCanBeActive(), setAnimatorsAreActive(), and
scrollbarAnimationsAreSuppressed().

  • page/FrameView.cpp:

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

  • page/FrameView.h:

setShouldSuppressScrollbarAnimations(bool) now calls
setShouldLockOverlayScrollbars(bool).

  • page/Page.cpp:

(WebCore::Page::setShouldSuppressScrollbarAnimations):
(WebCore::Page::setShouldLockOverlayScrollbars):

  • page/Page.h:

setIsActive() is now implemented in the ScrollAnimator instead of ScrollableArea
subclasses. finishCurrentScrollAnimations() is replaced by
lockOverlayScrollbarStateToHidden(bool).

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimator::scrollbarsCanBeActive):

New enum ScrollbarOverlayState.

  • platform/ScrollTypes.h:

Go to the animator for both of these functions.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollableArea::scrollbarsCanBeActive):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::setVisibleScrollerThumbRect):

Three new pieces of ScrollbarPainterController api.

  • platform/mac/NSScrollerImpDetails.h:

Instead of asking the ScrollableArea if scrollbars can be active, just find out if
the ScrollbarPaintController has been locked.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimatorMac::scrollbarsCanBeActive):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Remove implementations of scrollbarsCanBeActive() and
scrollbarAnimationsAreSuppressed().

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:

Source/WebKit2:

This function no longer needs to be implemented by ScrollablArea subclasses.

  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
11:22 AM Changeset in webkit [156557] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

Move line grid functionality from RenderBlock into RenderBlockFlow.
​https://bugs.webkit.org/show_bug.cgi?id=121502

Reviewed by Dean Jackson.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::establishLineGrid):

  • rendering/LayoutState.h:

(WebCore::LayoutState::lineGrid):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::layoutLineGridBox):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::lineGridBox):
(WebCore::RenderBlockFlow::setLineGridBox):

  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineSnapAdjustment):

10:52 AM Changeset in webkit [156556] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Re-indent Settings.h

Rubber-stamped by Anders Carlsson.

10:42 AM Changeset in webkit [156555] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Web Inspector: Make WebKitGTK+ port work with Eclipse chromedevtools plugin
​https://bugs.webkit.org/show_bug.cgi?id=121121

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-27
Reviewed by Gustavo Noronha Silva.

The chromedevtools plugin (​http://code.google.com/p/chromedevtools/) requires a specific
json format to connect to the webkit inspector.

The current format is missing some required fields that make the connection with the plugin
fail.

The format expected by the plugin is as follows:

{

"title": "Foo",
"url": "​http://foo",
"devtoolsFrontendUrl": "/Main.html?ws=localhost:9222/devtools/page/1",
"webSocketDebuggerUrl": "ws://localhost:9222/devtools/page/1"

}

The current format is missing the entries for "devtoolsFrontendUrl" and
"webSocketDebuggerUrl".

The plugin also sends an HTTP GET request to ​http://host:port/json instead of
​http://host:port/pagelist.json when retrieving the pages list.

This patch fixes the issues by adding support for the missing fields and accepting requests
for "/json" alongside "/pagelist.json".

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):
Also accept requests for "/json" alongside "pagelist.json".
(WebKit::WebInspectorServer::buildPageList):
Add fields required by chromedevtools plugin.

10:40 AM Changeset in webkit [156554] by eric.carlson@apple.com
  • 9 edits in trunk

[MediaStream API] update SourceInfo object to match spec
​https://bugs.webkit.org/show_bug.cgi?id=121941

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing test updated.

  • Modules/mediastream/SourceInfo.cpp:

(WebCore::SourceInfo::kind): Get rid of "none".

  • Modules/mediastream/SourceInfo.h:

(WebCore::SourceInfo::sourceId): Renamed from "id".

  • Modules/mediastream/SourceInfo.idl:
  • platform/mediastream/MediaStreamTrackSourcesRequestClient.h:

(WebCore::TrackSourceInfo::create):
(WebCore::TrackSourceInfo::kind):
(WebCore::TrackSourceInfo::TrackSourceInfo):

  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): "facing" isn't a part of sourceInfo.

Return a non-NULL ID because a source must always have one.

LayoutTests:

  • fast/mediastream/MediaStreamTrack-getSources-expected.txt:
  • fast/mediastream/MediaStreamTrack-getSources.html:
10:26 AM Changeset in webkit [156553] by dino@apple.com
  • 9 edits in trunk

Provide 2D Matrix decomposition for animation
​https://bugs.webkit.org/show_bug.cgi?id=112824
<rdar://problem/15091882>

Reviewed by Eric Carlson (and Ian Henderson offline).

Source/WebCore:

Implement a new 2d matrix blend, which is triggered
when animating between two affine 3d matrices. This
is intended to be the official algorithm that gets
put into the W3C Transforms specification.

The old code is renamed with a 4 prefix (indicating
it is a blend between 3d matrices using quaternions),
and new methods and structures for 2d blending were added.

I also took the opportunity to clean up a lot of
bad WebKit style.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::maxScaleFromTransform): Use 3d decomposition.

  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:

(WebCore::PerspectiveTransformOperation::blend): Ditto.

  • platform/graphics/transforms/RotateTransformOperation.cpp:

(WebCore::RotateTransformOperation::blend): Ditto.

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::decompose2): New method to decompose an affine 3d matrix
into X/Y scale + translate, a rotation angle, plus some extracted
a,b,c,d fields from the affine section.
(WebCore::decompose4): New name for the old function.
(WebCore::TransformationMatrix::blend2): Perform linear interpolation
between two 2d decompositions.
(WebCore::TransformationMatrix::blend4): New name for the old function.
(WebCore::TransformationMatrix::blend): Call blend2 or blend4 depending
on the type of matrix.
(WebCore::TransformationMatrix::decompose2): Calls into the decompose2
method above.
(WebCore::TransformationMatrix::decompose4): New name.
(WebCore::TransformationMatrix::recompose2): Recomposes a 3d matrix from
a 2d decomposition.
(WebCore::TransformationMatrix::recompose4): New name.

  • platform/graphics/transforms/TransformationMatrix.h: All the changes

for the new methods above.

LayoutTests:

This test was only exercising the fact that our
software decomposition did not match our hardware
decomposition (although that required visual inspection).
Now that our 2d decomposition is correct, update the
test and its expected result.

  • animations/transform-non-accelerated-expected.txt:
  • animations/transform-non-accelerated.html:
10:24 AM Changeset in webkit [156552] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in

Attempt to fix windows build.

9:59 AM Changeset in webkit [156551] by mario@webkit.org
  • 5 edits in trunk

[GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=106924

Reviewed by Chris Fleizach.

Tools:

Consider headings levels as values to be returned in intValue()
both in DRT and WKTR, so we can share more tests with other ports.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::intValue): Consider headings too.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::intValue): Ditto.

LayoutTests:

Removed accesibility/heading-level.html from failure expectations.

  • platform/gtk/TestExpectations: Removed test now passing.
9:39 AM Changeset in webkit [156550] by Darin Adler
  • 840 edits
    7 moves in trunk

rename KURL to URL
​https://bugs.webkit.org/show_bug.cgi?id=16214

Reviewed by Andreas Kling.

Source/WebCore:

  • many files: Renamed, using script.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Let the script to try to rename here.

Source/WebKit/blackberry:

  • many files: Renamed, using script.

Source/WebKit/efl:

  • many files: Renamed, using script.

Source/WebKit/gtk:

  • many files: Renamed, using script.

Source/WebKit/mac:

  • many files: Renamed, using script.

Source/WebKit/qt:

  • many files: Renamed, using script.

Source/WebKit/win:

  • many files: Renamed, using script.

Source/WebKit/wince:

  • many files: Renamed, using script.

Source/WebKit2:

  • many files: Renamed, using script.

Tools:

  • many files: Renamed, using script.
9:37 AM Changeset in webkit [156549] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

LLInt alignment problem on ARM in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=122012

Reviewed by Michael Saboff.

Force GCC to put the LLInt code to .text section.

  • llint/LowLevelInterpreter.cpp:
9:34 AM Changeset in webkit [156548] by Darin Adler
  • 2 edits in trunk/Tools

Fix Python scripts test failures.

  • Scripts/webkitpy/style/checkers/cpp.py: (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests now, not by the checker itself.
9:12 AM Changeset in webkit [156547] by galpeter@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebKit2

Remove unused method parameters from TupleCoder.
​https://bugs.webkit.org/show_bug.cgi?id=122009

Reviewed by Anders Carlsson.

In case of TupleCoder<0, Elements...> the parameter
names for encoder, decoder and tuple are not used.
By removing the paramter names the unusued paramter
warning will disappear.

  • Platform/CoreIPC/Arguments.h:
9:05 AM Changeset in webkit [156546] by jer.noble@apple.com
  • 45 edits
    8 adds
    2 deletes in trunk

[Mac] Implement the media controls in JavaScript.
​https://bugs.webkit.org/show_bug.cgi?id=120895

Reviewed by Dean Jackson.

Source/JavaScriptCore:

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Re-implement the existing MediaControls constellation of classes in JavaScript
and CSS. This will allow different ports to configure their controls without
dependencies on the layout requirements of any other port's controls.

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT:

  • Configurations/FeatureDefines.xcconfig:

Add new source files to the project:

  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Add a new class MediaControlsHost which the script controls can use to
communicate with the HTMLMediaElement without exposing private interfaces
to web facing scripts:

  • Modules/mediacontrols/MediaControlsHost.cpp: Added.

(WebCore::MediaControlsHost::automaticKeyword): Static method.
(WebCore::MediaControlsHost::forcedOnlyKeyword): Ditto.
(WebCore::MediaControlsHost::alwaysOnKeyword): Ditto.
(WebCore::MediaControlsHost::create): Simple factory.
(WebCore::MediaControlsHost::MediaControlsHost): Simple constructor.
(WebCore::MediaControlsHost::~MediaControlsHost): Simple destructor.
(WebCore::MediaControlsHost::sortedTrackListForMenu): Pass through to CaptionUserPreferences.
(WebCore::MediaControlsHost::displayNameForTrack): Ditto.
(WebCore::MediaControlsHost::captionMenuOffItem): Pass through to TextTrack.
(WebCore::MediaControlsHost::captionMenuAutomaticItem): Ditto.
(WebCore::MediaControlsHost::captionDisplayMode): Pass through to CaptionUserPreferences.
(WebCore::MediaControlsHost::setSelectedTextTrack): Pass through to HTMLMediaElement.
(WebCore::MediaControlsHost::textTrackContainer): Lazily create a MediaControlTextTrackContainerElement.
(WebCore::MediaControlsHost::updateTextTrackContainer): Pass through to MediaControlTextTrackContainerElement.

  • Modules/mediacontrols/MediaControlsHost.h: Added.
  • Modules/mediacontrols/MediaControlsHost.idl: Added.
  • Modules/mediacontrols/mediaControlsApple.css: Added.

Add convenience methods for adding a MediaControlsHost to a VM.

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::set):

  • bindings/js/ScriptObject.h:

Add the new controller .js implementation:

  • Modules/mediacontrols/mediaControlsApple.js: Added.

(createControls): Global method to create a new Controller object.
(Controller): Constructor. Create and configure the default set of controls.
(Controller.prototype.addListeners): Adds event listeners to the this.video object.
(Controller.prototype.removeListeners): Removes listeners from same.
(Controller.prototype.handleEvent): Makes Controller an EventHandler, making registration and

deregistration simpler.

(Controller.prototype.createBase): Creates the base controls object and the text track container.
(Controller.prototype.createControls): Creates the controls panel object and controller UI.
(Controller.prototype.setControlsType): Switches between Full Screen and Inline style of controller.
(Controller.prototype.disconnectControls): Disconnects all UI elements from the DOM.
(Controller.prototype.configureInlineControls): Configures existing controls for Inline mode.
(Controller.prototype.configureFullScreenControls): Ditto, for Full Screen Mode.

Add listeners for HTMLMediaElement events:
(Controller.prototype.onloadstart): Update the status display.
(Controller.prototype.onerror): Ditto.
(Controller.prototype.onabort): Ditto.
(Controller.prototype.onsuspend): Ditto.
(Controller.prototype.onprogress): Ditto.
(Controller.prototype.onstalled): Ditto.
(Controller.prototype.onwaiting): Ditto.
(Controller.prototype.onreadystatechange): Ditto.
(Controller.prototype.ontimeupdate): Update the timeline and time displays.
(Controller.prototype.ondurationchange): Ditto.
(Controller.prototype.onplaying): Update the play button.
(Controller.prototype.onplay): Ditto.
(Controller.prototype.onpause): Ditto.
(Controller.prototype.onratechange): Ditto.
(Controller.prototype.onvolumechange): Update the volume and mute UI.
(Controller.prototype.ontexttrackchange): Update the text track container and captions button.
(Controller.prototype.ontexttrackadd): Ditto.
(Controller.prototype.ontexttrackremove): Ditto.
(Controller.prototype.ontexttrackcuechange): Ditto.
(Controller.prototype.onfullscreenchange): Reconfigure the controls.

Add listeners for UI element events:
(Controller.prototype.onwrappermousemove): Show the controls and start the hide timer.
(Controller.prototype.onwrappermouseout): Hide the controls and stop the hide timer.
(Controller.prototype.onrewindbuttonclicked): Rewind.
(Controller.prototype.onplaybuttonclicked): Toggle pause.
(Controller.prototype.ontimelinechange): Update the currentTime.
(Controller.prototype.ontimelinedown):
(Controller.prototype.ontimelineup):
(Controller.prototype.ontimelinemouseover): Show the thumbnail view if available.
(Controller.prototype.ontimelinemouseout): Hide same.
(Controller.prototype.ontimelinemousemove): Move the thumbnail view.
(Controller.prototype.onmutebuttonclicked): Mute audio.
(Controller.prototype.onminbuttonclicked): Increase volume to max.
(Controller.prototype.onmaxbuttonclicked): Decrease volume to min.
(Controller.prototype.onvolumesliderchange): Update the current volume.
(Controller.prototype.oncaptionbuttonclicked): Show or hide the track menu.
(Controller.prototype.onfullscreenbuttonclicked): Enter or exit fullscreen.
(Controller.prototype.oncontrolschange): Show or hide the controls panel.
(Controller.prototype.onseekbackmousedown): Start seeking and enable the seek timer.
(Controller.prototype.onseekbackmouseup): Stop seeking and disable the seek timer.
(Controller.prototype.onseekforwardmousedown): Start seekind and enable the seek timer.
(Controller.prototype.onseekforwardmouseup): Stop seekind and disable the seek timer.

Add action methods (which are mostly self explanatory):
(Controller.prototype.updateDuration):
(Controller.prototype.updatePlaying):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
(Controller.prototype.removeControls):
(Controller.prototype.addControls):
(Controller.prototype.updateTime):
(Controller.prototype.updateReadyState):
(Controller.prototype.setStatusHidden):
(Controller.prototype.updateThumbnailTrack):
(Controller.prototype.updateCaptionButton):
(Controller.prototype.updateCaptionContainer):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.captionItemSelected):
(Controller.prototype.destroyCaptionMenu):
(Controller.prototype.updateVolume):

Add utility methods:
(Controller.prototype.isFullScreen):
(Controller.prototype.canPlay):
(Controller.prototype.nextRate):
(Controller.prototype.seekBackFaster):
(Controller.prototype.seekForwardFaster):
(Controller.prototype.formatTime):
(Controller.prototype.trackHasThumbnails):

Add the stylesheet for the javascript controls (which are mostly) copied from
the (deleted) mediaControlsQuickTime.css and fullscreenQuickTime.css files:

  • Modules/mediacontrols/mediaControlsApple.css: Added.
  • css/fullscreenQuickTime.css: Removed.
  • css/mediaControlsQuickTime.css: Removed.

Inject new stylesheets into UA sheets:

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

Use the new javascript controls rather than MediaControls:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer): Use the javascript controls if available.
(WebCore::HTMLMediaElement::updateTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::mediaControls): Ditto.
(WebCore::HTMLMediaElement::hasMediaControls): Ditto.
(WebCore::HTMLMediaElement::createMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::ensureIsolatedWorld): Create a new VM for the controls script.
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): Inject the media controls script into the VM.
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Inject the MediaControlsHost into the VM and call

the scripts global factory function.

  • html/HTMLMediaElement.h:

Remove most of the drawing code from RenderThemeMac and RenderThemeWin and
add accessors for the new .js and .css file data:

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::mediaControlsStyleSheet): Empty virtual method.
(WebCore::RenderTheme::mediaControlsScript): Ditto.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsStyleSheet): Add accessor for mediaControlsApple.css.
(WebCore::RenderThemeMac::mediaControlsScript): Add accessor for mediaControlsApple.js.
(WebCore::RenderThemeMac::adjustSliderThumbSize): Remove the call to adjustMediaSliderThumbSize.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::mediaControlsStyleSheet):
(WebCore::RenderThemeWin::mediaControlsScript):

  • rendering/RenderThemeWin.h:

Source/WebKit/mac:

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

  • wtf/FeatureDefines.h:

LayoutTests:

Rebaseline changed tests and add new (failing) tests to
TestExpectations.

  • media/audio-delete-while-slider-thumb-clicked.html:
  • platform/mac/TestExpectations:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/mac/fast/layers/video-layer-expected.png:
  • platform/mac/fast/layers/video-layer-expected.txt:
  • platform/mac/fullscreen/video-controls-override-expected.txt: Added.
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/controls-styling-strict-expected.png:
  • platform/mac/media/controls-styling-strict-expected.txt:
  • platform/mac/media/controls-without-preload-expected.png:
  • platform/mac/media/controls-without-preload-expected.txt:
  • platform/mac/media/media-controls-clone-expected.png:
  • platform/mac/media/media-controls-clone-expected.txt:
  • webarchive/loading/video-in-webarchive-expected.txt:
8:55 AM Changeset in webkit [156545] by Bem Jones-Bey
  • 7 edits
    2 adds in trunk

[css-shapes] Shapes are not resolved the same way in shape-inside and clip-path
​https://bugs.webkit.org/show_bug.cgi?id=121922

Reviewed by Andreas Kling.

Source/WebCore:

Fix computation of a percentage radius for circle shape-outside to
match the CSS Shapes spec.

Test: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

LayoutTests:

Add new test for circular shape-outside with percentage radius.

Update the nested container with unresolved height test because with a
circle it isn't really testing just for unresolved height behavior.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
  • fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html:
  • fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:
8:34 AM Changeset in webkit [156544] by akling@apple.com
  • 2 edits in trunk/LayoutTests

Unrehued mac-lion rebaseline.

  • platform/mac-lion/js/dom/global-constructors-attributes-expected.txt:
8:09 AM Changeset in webkit [156543] by Darin Adler
  • 119 edits
    2 adds in trunk

Add empty MainFrame class
​https://bugs.webkit.org/show_bug.cgi?id=121770

Reviewed by Andreas Kling.

Source/WebCore:

For now, MainFrame simply derives from Frame and adds nothing.
Next, we will make each Frame point back to its MainFrame.

  • CMakeLists.txt: Added MainFrame.cpp/h.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.exp.in: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/Frame.cpp:

(WebCore::Frame::Frame): Use references instead of pointers for constructor.
(WebCore::Frame::create): Pass references instead of pointers to constructor.

  • page/Frame.h: Made constructor protected instead of private, and marked

destructor virtual explicitly. Also marked virtual functions OVERRIDE and FINAL.

  • page/MainFrame.cpp: Added.
  • page/MainFrame.h: Added.
  • page/Page.cpp:

(WebCore::Page::Page): Use MainFrame::create instead of Frame::create.
(WebCore::Page::frameIsMainFrame): Moved here, no longer inline.
(WebCore::Page::renderTreeSize): Use const Frame* instead of Frame*.
(WebCore::Page::checkSubframeCountConsistency): Ditto.

  • page/Page.h: Changed mainFrame() to return MainFrame& and m_mainFrame to

be a RefPtr<MainFrame>.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
  • bindings/js/PageScriptDebugServer.cpp:
  • bindings/js/ScriptProfiler.cpp:
  • bindings/js/ScriptState.cpp:
  • css/MediaQueryEvaluator.cpp:
  • dom/Document.cpp:
  • history/CachedFrame.cpp:
  • history/CachedPage.cpp:
  • history/PageCache.cpp:
  • html/HTMLPlugInImageElement.cpp:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorCanvasAgent.cpp:
  • inspector/InspectorClient.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInputAgent.cpp:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorOverlay.cpp:
  • inspector/InspectorPageAgent.cpp:
  • inspector/PageRuntimeAgent.cpp:
  • loader/FrameLoader.cpp:
  • loader/HistoryController.cpp:
  • loader/archive/mhtml/MHTMLArchive.cpp:
  • page/AutoscrollController.cpp:
  • page/Chrome.cpp:
  • page/ContextMenuController.cpp:
  • page/DOMWindow.cpp:
  • page/DragController.cpp:
  • page/EventHandler.cpp:
  • page/FocusController.cpp:
  • page/FrameTree.cpp:
  • page/FrameView.cpp:
  • page/GestureTapHighlighter.cpp:
  • page/PageGroup.cpp:
  • page/PageGroupLoadDeferrer.cpp:
  • page/PageSerializer.cpp:
  • page/PageThrottler.cpp:
  • page/Settings.cpp:
  • page/SpatialNavigation.cpp:
  • page/mac/DragControllerMac.mm:
  • page/mac/PageMac.cpp:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
  • plugins/DOMMimeType.cpp:
  • storage/StorageEventDispatcher.cpp:
  • svg/graphics/SVGImage.cpp:
  • testing/InternalSettings.cpp:
  • testing/Internals.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
  • WebCoreSupport/InspectorClientEfl.cpp:
  • ewk/ewk_view.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/gtk:

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:
  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/GtkAdjustmentWatcher.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebview.cpp:
  • webkit/webkitviewportattributes.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.mm:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebCoreSupport/WebPlatformStrategies.mm:
  • WebView/WebFrame.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebView.mm:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/qt:

  • Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:
  • Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:
  • Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:
  • Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:
  • Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/win:

  • win/WebCoreSupport/WebDragClient.cpp:
  • win/WebCoreSupport/WebContextMenuClient.cpp:
  • win/WebDropSource.cpp:
  • win/WebFrame.cpp:
  • win/WebView.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit2:

  • WebProcess/FullScreen/WebFullScreenManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Storage/StorageAreaMap.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/PageOverlay.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:

Include MainFrame.h instead of Frame.h as needed.

7:31 AM Changeset in webkit [156542] by gyuyoung.kim@samsung.com
  • 10 edits in trunk/Source/WebCore

Add toWebKitCSS*Value functions to cast from CSSValue
​https://bugs.webkit.org/show_bug.cgi?id=121776

Reviewed by Andreas Kling.

CSS_VALUE_TYPE_CASTS can't cover WebKitCSS*Value classes. So, this patch adds toWebKitCSS*Value manually.

No new tests, no behavior change.

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):

  • css/TransformFunctions.cpp:

(WebCore::transformsForValue):

  • css/WebKitCSSArrayFunctionValue.h:

(WebCore::toWebKitCSSArrayFunctionValue):

  • css/WebKitCSSFilterValue.h:

(WebCore::toWebKitCSSFilterValue):

  • css/WebKitCSSMatFunctionValue.h:

(WebCore::toWebKitCSSMatFunctionValue):

  • css/WebKitCSSMixFunctionValue.h:

(WebCore::toWebKitCSSMixFunctionValue):

  • css/WebKitCSSSVGDocumentValue.h:

(WebCore::toWebKitCSSSVGDocumentValue):

  • css/WebKitCSSShaderValue.h:

(WebCore::toWebKitCSSShaderValue):

  • css/WebKitCSSTransformValue.h:

(WebCore::toWebKitCSSTransformValue):

6:48 AM Changeset in webkit [156541] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK][WK2] Logging of accessibility events is not disabled between tests
​https://bugs.webkit.org/show_bug.cgi?id=121957

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-09-27
Reviewed by Mario Sanchez Prada.

Tools:

Fixed an issue in AccessibilityNotificationHandler where the destructor
was not disconnecting accessibility event callbacks if logging was on.
The decision of disconnecting events can solely rely on the existence of
notification handlers because logging uses the global notification
handler.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
disconnection when logging is on.

LayoutTests:

Removed some accessibility tests from the expectations file that were
failing before this fix.

  • platform/gtk-wk2/TestExpectations:
6:40 AM Changeset in webkit [156540] by akling@apple.com
  • 7 edits in trunk/Source

Pass VM instead of ExecState to JSDateMath functions.
<​https://webkit.org/b/121997>

Reviewed by Geoffrey Garen.

The JSC date math functions only need the VM, so pass that from
callers instead of the whole ExecState.

6:31 AM Changeset in webkit [156539] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
​https://bugs.webkit.org/show_bug.cgi?id=121831

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2013-09-27

  • platform/efl-wk2/TestExpectations:
  • platform/efl/editing/selection/fake-doubleclick-expected.txt:
6:01 AM Changeset in webkit [156538] by Patrick Gansterer
  • 2 edits
    2 adds
    1 delete in trunk/Tools

Add general CMakeLists.txt for DRT
​https://bugs.webkit.org/show_bug.cgi?id=119268

Reviewed by Gyuyoung Kim.

The new file allows better sharing between ports.

  • CMakeLists.txt:
  • DumpRenderTree/CMakeLists.txt: Added.
  • DumpRenderTree/PlatformEfl.cmake: Added.
  • DumpRenderTree/efl/CMakeLists.txt: Removed.
5:58 AM Changeset in webkit [156537] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.2.0

Tagging the WebKitGTK+ 2.2.0 release

5:47 AM Changeset in webkit [156536] by Alan Bujtas
  • 5 edits
    2 adds in trunk

Unexpected word wrapping for wrapped content then raw content.
​https://bugs.webkit.org/show_bug.cgi?id=121130

Reviewed by Darin Adler.

When deciding whether a line is considered empty, we need to check if the current
object is fully responsible for the currently uncommitted width. It helps differentiating
<span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
case when we hit the second <span> the line is still considered empty, as opposed to the
second example.
This patch introduces a map to keep track of the uncommitted widths.

Source/WebCore:

Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html

  • rendering/LineWidth.cpp:

(WebCore::LineWidth::uncommittedWidthForObject):
(WebCore::LineWidth::addUncommittedWidth):

  • rendering/LineWidth.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
  • fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
5:16 AM Changeset in webkit [156535] by allan.jensen@digia.com
  • 6 edits in trunk

[Qt] Fix force_static_libs_as_shared in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=121961

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • WebCoreSupport/QWebFrameAdapter.h:

Source/WebKit2:

Do not add strict ordering for webkit2qml. It is not needed and causes
Target.pri to be built out of order.

  • WebKit2.pro:

Tools:

Reenable force_static_libs_as_shared when building WebKit2.

  • qmake/mkspecs/features/default_post.prf:
4:57 AM Changeset in webkit [156534] by allan.jensen@digia.com
  • 3 edits in trunk/Tools

[Qt] Mock implementations of positioning and orientation not used
​https://bugs.webkit.org/show_bug.cgi?id=121956

Reviewed by Csaba Osztrogonác.

Move production_build checks to sanitizeFeatures where its value is actually known.

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/features.pri:
3:40 AM Changeset in webkit [156533] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.0 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Add release notes.
2:44 AM Changeset in webkit [156532] by mario@webkit.org
  • 23 edits
    2 adds in trunk

[ATK] Protect entry points in the ATK wrapper against outdated render trees
​https://bugs.webkit.org/show_bug.cgi?id=121558

Reviewed by Chris Fleizach.

Source/WebCore:

Make sure that we protect every entry point in the ATK wrapper
against outdated render trees, before using the WebCore's
accessibility API, since that might lead to problems (and crashes)
if the render and accessibility trees are not stable.

Thus, call AccessibilityObject::updateBackingStore() in those
entry points and check whether the ATK wrapper is detached or not
after that, to decide whether to continue or not.

Besides providing a new test to check that it WebKit does not
crash in a given scenario (which actually triggered the
investigation here), solving this situation also fixes other tests
that were previously failing (aria-used-on-image-maps.html) or
that were printing wrong results, not detected until now due to
wrong platform specific expectations (file-upload-button-stringvalue
and deleting-iframe-destroys-axcache).

Test: accessibility/heading-crash-after-hidden.html

  • accessibility/atk/WebKitAccessibleUtil.h: Added two new macros

to inject the needed code at the beginning of each entry point to
allow gracefully exit those functions when the render tree is
unstable. Inspired by g_return_if_fail and g_return_val_if_fail, we
called them returnIfWebKitAccessibleIsInvalid and returnValIfWebKitAccessibleIsInvalid.

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(webkitAccessibleHyperlinkActionDoAction): Protect entry point.
(webkitAccessibleHyperlinkActionGetNActions): Ditto.
(webkitAccessibleHyperlinkActionGetDescription): Ditto.
(webkitAccessibleHyperlinkActionGetKeybinding): Ditto.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Ditto.
(webkitAccessibleHyperlinkGetObject): Ditto.
(webkitAccessibleHyperlinkGetStartIndex): Ditto.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.
(webkitAccessibleHyperlinkIsValid): Ditto.
(webkitAccessibleHyperlinkGetNAnchors): Ditto.
(webkitAccessibleHyperlinkIsSelectedLink): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceAction.cpp:

(webkitAccessibleActionDoAction): Ditto.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:

(webkitAccessibleComponentRefAccessibleAtPoint): Ditto.
(webkitAccessibleComponentGetExtents): Ditto.
(webkitAccessibleComponentGrabFocus): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:

(webkitAccessibleDocumentGetAttributeValue): Ditto.
(webkitAccessibleDocumentGetAttributes): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp:

(webkitAccessibleEditableTextSetRunAttributes): Ditto.
(webkitAccessibleEditableTextSetTextContents): Ditto.
(webkitAccessibleEditableTextInsertText): Ditto.
(webkitAccessibleEditableTextCopyText): Ditto.
(webkitAccessibleEditableTextCutText): Ditto.
(webkitAccessibleEditableTextDeleteText): Ditto.
(webkitAccessibleEditableTextPasteText): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:

(webkitAccessibleHypertextGetLink): Ditto.
(webkitAccessibleHypertextGetNLinks): Ditto.
(webkitAccessibleHypertextGetLinkIndex): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImagePosition): Ditto.
(webkitAccessibleImageGetImageDescription): Ditto.
(webkitAccessibleImageGetImageSize): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(webkitAccessibleSelectionAddSelection): Ditto.
(webkitAccessibleSelectionClearSelection): Ditto.
(webkitAccessibleSelectionRefSelection): Ditto.
(webkitAccessibleSelectionGetSelectionCount): Ditto.
(webkitAccessibleSelectionIsChildSelected): Ditto.
(webkitAccessibleSelectionRemoveSelection): Ditto.
(webkitAccessibleSelectionSelectAllSelection): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableRefAt): Ditto.
(webkitAccessibleTableGetIndexAt): Ditto.
(webkitAccessibleTableGetColumnAtIndex): Ditto.
(webkitAccessibleTableGetRowAtIndex): Ditto.
(webkitAccessibleTableGetNColumns): Ditto.
(webkitAccessibleTableGetNRows): Ditto.
(webkitAccessibleTableGetColumnExtentAt): Ditto.
(webkitAccessibleTableGetRowExtentAt): Ditto.
(webkitAccessibleTableGetColumnHeader): Ditto.
(webkitAccessibleTableGetRowHeader): Ditto.
(webkitAccessibleTableGetCaption): Ditto.
(webkitAccessibleTableGetColumnDescription): Ditto.
(webkitAccessibleTableGetRowDescription): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetText): Ditto.
(webkitAccessibleTextGetTextAfterOffset): Ditto.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
(webkitAccessibleTextGetCharacterAtOffset): Ditto.
(webkitAccessibleTextGetCaretOffset): Ditto.
(webkitAccessibleTextGetRunAttributes): Ditto.
(webkitAccessibleTextGetDefaultAttributes): Ditto.
(webkitAccessibleTextGetCharacterExtents): Ditto.
(webkitAccessibleTextGetRangeExtents): Ditto.
(webkitAccessibleTextGetCharacterCount): Ditto.
(webkitAccessibleTextGetOffsetAtPoint): Ditto.
(webkitAccessibleTextGetNSelections): Ditto.
(webkitAccessibleTextGetSelection): Ditto.
(webkitAccessibleTextAddSelection): Ditto.
(webkitAccessibleTextSetSelection): Ditto.
(webkitAccessibleTextRemoveSelection): Ditto.
(webkitAccessibleTextSetCaretOffset): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetCurrentValue): Ditto.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(core): Removed, as it's not actually needed.
(webkitAccessibleGetName): Protect entry point.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleGetParent): Ditto.
(webkitAccessibleGetNChildren): Ditto.
(webkitAccessibleRefChild): Ditto.
(webkitAccessibleGetIndexInParent): Ditto.
(webkitAccessibleGetAttributes): Ditto.
(webkitAccessibleGetRole): Ditto.
(webkitAccessibleRefStateSet): Ditto.
(webkitAccessibleRefRelationSet): Ditto.
(webkitAccessibleGetObjectLocale): Ditto.
(webkitAccessibleDetach): Ditto.
(webkitAccessibleIsDetached): New helper function, to be used from
the newly added macros. We need to check whether the wrapper is
detached and not just the wrapper AccessibilityObject since once
the detachment happens we can't trust anything but the AtkObject
from the wrapper (the AccessibilityObject might be invalid).

  • accessibility/atk/WebKitAccessibleWrapperAtk.h:

Assert that the render tree is neither being updated nor in need
of being updated before trying to compute the text under a given
element, since that might lead to crashes due to the constructor
of TextIterator calling updateLayoutIgnorePendingStylesheets().

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement): Assert that
the render tree is neither being updated nor needing updating.

LayoutTests:

Added a new test to check that we do not crash in certain
scenarios when hiding objects and retriving accessibility
information about it.

  • accessibility/heading-crash-after-hidden-expected.txt: Added.
  • accessibility/heading-crash-after-hidden.html: Added.

Rebaselined expectations that were wrong before, since they were
not returning the actual value that they should be returning when
called AccessibilityUIElement::stringValue().

  • platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt:

Updated, since the actual text being returned should be the actual
value of the file chooser (e.g. "(None)") and not the text in the
upload botton (e.g. "Choose files").

  • platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Ditto.
  • platform/gtk-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Ditto..
  • platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Ditto.
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt:

Updated, since the iframe should be exposed at all after deleting it.

Removed accesibility test now passing after fixing this issue.

  • platform/gtk/TestExpectations: Removed accessibility/aria-used-on-image-maps.html.
2:07 AM Changeset in webkit [156531] by mario@webkit.org
  • 3 edits in trunk/Tools

[ATK] Normalize checks in entry points for DRT and WKTR
​https://bugs.webkit.org/show_bug.cgi?id=121959

Reviewed by Chris Fleizach.

Always check if we have a proper instance of AtkObject,
implementing the interfaces that we might need for each case, at
the entry point of every method of AccessibilityUIElement for ATK,
and do those checks in an uniform way across DRT and WKTR, to
avoid confusion and issues when modifying these files in the future.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::getChildren): Use normalized checks.
(AccessibilityUIElement::getChildrenWithRange): Ditto.
(AccessibilityUIElement::rowCount): Ditto.
(AccessibilityUIElement::columnCount): Ditto.
(AccessibilityUIElement::childrenCount): Ditto.
(AccessibilityUIElement::elementAtPoint): Ditto.
(AccessibilityUIElement::getChildAtIndex): Ditto.
(AccessibilityUIElement::allAttributes): Ditto.
(AccessibilityUIElement::titleUIElement): Ditto.
(AccessibilityUIElement::parentElement): Ditto.
(AccessibilityUIElement::attributesOfChildren): Ditto.
(AccessibilityUIElement::role): Ditto.
(AccessibilityUIElement::title): Ditto.
(AccessibilityUIElement::description): Ditto.
(AccessibilityUIElement::stringValue): Ditto.
(AccessibilityUIElement::language): Ditto.
(AccessibilityUIElement::x): Ditto.
(AccessibilityUIElement::y): Ditto.
(AccessibilityUIElement::width): Ditto.
(AccessibilityUIElement::height): Ditto.
(AccessibilityUIElement::orientation): Ditto.
(AccessibilityUIElement::intValue): Ditto.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(indexRangeInTable): Ditto.
(AccessibilityUIElement::cellForColumnAndRow): Ditto.
(AccessibilityUIElement::stringAttributeValue): Ditto.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::press): Ditto.
(AccessibilityUIElement::documentEncoding): Ditto.
(AccessibilityUIElement::documentURI): Ditto.
(AccessibilityUIElement::hasPopup): Ditto.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::indexRangeInTable): Use normalized checks.
(WTR::alterCurrentValue): Ditto.
(WTR::AccessibilityUIElement::getChildren): Ditto.
(WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
(WTR::AccessibilityUIElement::childrenCount): Ditto.
(WTR::AccessibilityUIElement::elementAtPoint): Ditto.
(WTR::AccessibilityUIElement::indexOfChild): Ditto.
(WTR::AccessibilityUIElement::childAtIndex): Ditto.
(WTR::AccessibilityUIElement::titleUIElement): Ditto.
(WTR::AccessibilityUIElement::parentElement): Ditto.
(WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
(WTR::AccessibilityUIElement::allAttributes): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::role): Ditto.
(WTR::AccessibilityUIElement::title): Ditto.
(WTR::AccessibilityUIElement::description): Ditto.
(WTR::AccessibilityUIElement::orientation): Ditto.
(WTR::AccessibilityUIElement::stringValue): Ditto.
(WTR::AccessibilityUIElement::language): Ditto.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.
(WTR::AccessibilityUIElement::rowCount): Ditto.
(WTR::AccessibilityUIElement::columnCount): Ditto.
(WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
(WTR::AccessibilityUIElement::press): Ditto.
(WTR::AccessibilityUIElement::documentEncoding): Ditto.
(WTR::AccessibilityUIElement::documentURI): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.

1:58 AM Changeset in webkit [156530] by mario@webkit.org
  • 5 edits in trunk

[ATK] accessibility/aria-sort.html is failing after r156409
​https://bugs.webkit.org/show_bug.cgi?id=121947

Reviewed by Chris Fleizach.

Source/WebCore:

The WAI-ARIA spec says to translate the value as is from the
attribute, so do just that instead of mapping values from the
AccessibilitySortDirection enumeration into strings.
​http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Do the right mapping for aria-sort.

Tools:

Implement AccessibilityUIElement::isSupported for the ATK
platforms, just by checking whether we have an associated object
attribute exposed for the wrapper object matching the required
attribute in the layout test (e.g "AXSortDirection" -> "sort").

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isAttributeSupported): Implemented.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isAttributeSupported): Implemented.

1:47 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:48 AM Changeset in webkit [156529] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WTF

[GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible
​https://bugs.webkit.org/show_bug.cgi?id=121999

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-09-27
Reviewed by Benjamin Poulain.

  • wtf/StdLibExtras.h:
Note: See TracTimeline for information about the timeline view.