⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 30, 2013:

11:37 PM Changeset in webkit [156700] by ryuan.choi@samsung.com
  • 18 edits in trunk/Source

Build fix for EFL, Qt, Gtk port after r156688
https://bugs.webkit.org/show_bug.cgi?id=122139

Reviewed by Anders Carlsson.

Get rid of more uses of OwnPtr and PassOwnPtr.

Source/WebCore:

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::beginPaint):

  • platform/graphics/surfaces/GraphicsSurface.h:
  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

Source/WebKit2:

  • Shared/API/c/cairo/WKImageCairo.cpp:

(WKImageCreateFromCairoSurface):

  • Shared/API/c/qt/WKImageQt.cpp:

(WKImageCreateFromQImage):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::paintToSurface):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

  • Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::encodeImage):

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createDrawingAreaProxy):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::createDrawingAreaProxy):

  • UIProcess/CoordinatedGraphics/WebView.h:
  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::convertCairoSurfaceToShareableBitmap):

11:12 PM Changeset in webkit [156699] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126

Reviewed by Darin Adler.

Speculative partial fix.

I'm not sure if it's possible to make this test completely controlled without
DOMFrameContentLoaded support - we need to do work when the <video> element is
already present, but playback hasn't started yet. As media documents use autoplay,
there is a race between load and playing events.

  • media/click-volume-bar-not-pausing-expected.txt:
  • media/click-volume-bar-not-pausing.html:
    • Add video URL after initial content fully loads to avoid races with that.
    • Added some state logging for clarity.
    • Only listen for "playing" event once. If playback already started, we have a playing event already queued, and would add another one with pause()/play().
10:58 PM Changeset in webkit [156698] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451

Patch by Sam White <Samuel White> on 2013-09-30
Reviewed by Chris Fleizach.

Source/WebCore:

Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.

Test: platform/mac/accessibility/element-busy-changed.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.

  • platform/mac/accessibility/element-busy-changed-expected.txt: Added.
  • platform/mac/accessibility/element-busy-changed.html: Added.
10:16 PM Changeset in webkit [156697] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/efl

Fix the build.

  • ewk/ewk_settings.cpp:
10:10 PM Changeset in webkit [156696] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fixing the build.

  • GNUmakefile.list.am:
9:59 PM Changeset in webkit [156695] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

More build fixing.

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InstrumentingAgents.h:
9:57 PM Changeset in webkit [156694] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style should not warn about use of C++11 “>>” instead of “> >"
https://bugs.webkit.org/show_bug.cgi?id=116474

Patch by Sam Weinig <sam@webkit.org> on 2013-09-30
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
9:47 PM Changeset in webkit [156693] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Fix the Efl and Gtk builds.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
9:33 PM Changeset in webkit [156692] by weinig@apple.com
  • 75 edits
    51 deletes in trunk

Remove support for DOMFileSystem
https://bugs.webkit.org/show_bug.cgi?id=122137

Reviewed by Anders Carlsson.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Files elided *

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::clearWebFileSystem):

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/efl:

  • ewk/ewk_settings.cpp:

(ewk_settings_file_system_path_set):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_spacing_for_binary_ops):

  • qmake/mkspecs/features/features.pri:

LayoutTests:

  • fast/dom/MutationObserver/filesystem-callback-delivery-expected.txt: Removed.
  • fast/dom/MutationObserver/filesystem-callback-delivery.html: Removed.
  • fast/filesystem: Removed.
  • fast/filesystem/async-operations-expected.txt: Removed.
  • fast/filesystem/async-operations.html: Removed.
  • fast/filesystem/cross-filesystem-op-expected.txt: Removed.
  • fast/filesystem/cross-filesystem-op.html: Removed.
  • fast/filesystem/directory-entry-to-uri-expected.txt: Removed.
  • fast/filesystem/directory-entry-to-uri.html: Removed.
  • fast/filesystem/entry-points-missing-arguments-expected.txt: Removed.
  • fast/filesystem/entry-points-missing-arguments.html: Removed.
  • fast/filesystem/file-after-reload-crash-expected.txt: Removed.
  • fast/filesystem/file-after-reload-crash.html: Removed.
  • fast/filesystem/file-entry-to-uri-expected.txt: Removed.
  • fast/filesystem/file-entry-to-uri.html: Removed.
  • fast/filesystem/file-from-file-entry-expected.txt: Removed.
  • fast/filesystem/file-from-file-entry.html: Removed.
  • fast/filesystem/file-metadata-after-write-expected.txt: Removed.
  • fast/filesystem/file-metadata-after-write.html: Removed.
  • fast/filesystem/file-writer-abort-continue-expected.txt: Removed.
  • fast/filesystem/file-writer-abort-continue.html: Removed.
  • fast/filesystem/file-writer-abort-depth-expected.txt: Removed.
  • fast/filesystem/file-writer-abort-depth.html: Removed.
  • fast/filesystem/file-writer-abort-expected.txt: Removed.
  • fast/filesystem/file-writer-abort.html: Removed.
  • fast/filesystem/file-writer-empty-blob-expected.txt: Removed.
  • fast/filesystem/file-writer-empty-blob.html: Removed.
  • fast/filesystem/file-writer-events-expected.txt: Removed.
  • fast/filesystem/file-writer-events.html: Removed.
  • fast/filesystem/file-writer-gc-blob-expected.txt: Removed.
  • fast/filesystem/file-writer-gc-blob.html: Removed.
  • fast/filesystem/file-writer-truncate-extend-expected.txt: Removed.
  • fast/filesystem/file-writer-truncate-extend.html: Removed.
  • fast/filesystem/file-writer-write-overlapped-expected.txt: Removed.
  • fast/filesystem/file-writer-write-overlapped.html: Removed.
  • fast/filesystem/filesystem-missing-arguments-expected.txt: Removed.
  • fast/filesystem/filesystem-missing-arguments.html: Removed.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Removed.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Removed.
  • fast/filesystem/filesystem-reference-expected.txt: Removed.
  • fast/filesystem/filesystem-reference.html: Removed.
  • fast/filesystem/filesystem-unserializable-expected.txt: Removed.
  • fast/filesystem/filesystem-unserializable.html: Removed.
  • fast/filesystem/filesystem-uri-origin-expected.txt: Removed.
  • fast/filesystem/filesystem-uri-origin.html: Removed.
  • fast/filesystem/flags-passing-expected.txt: Removed.
  • fast/filesystem/flags-passing.html: Removed.
  • fast/filesystem/input-access-entries-expected.txt: Removed.
  • fast/filesystem/input-access-entries.html: Removed.
  • fast/filesystem/not-enough-arguments-expected.txt: Removed.
  • fast/filesystem/not-enough-arguments.html: Removed.
  • fast/filesystem/op-copy-expected.txt: Removed.
  • fast/filesystem/op-copy.html: Removed.
  • fast/filesystem/op-get-entry-expected.txt: Removed.
  • fast/filesystem/op-get-entry.html: Removed.
  • fast/filesystem/op-get-metadata-expected.txt: Removed.
  • fast/filesystem/op-get-metadata.html: Removed.
  • fast/filesystem/op-get-parent-expected.txt: Removed.
  • fast/filesystem/op-get-parent.html: Removed.
  • fast/filesystem/op-move-expected.txt: Removed.
  • fast/filesystem/op-move.html: Removed.
  • fast/filesystem/op-read-directory-expected.txt: Removed.
  • fast/filesystem/op-read-directory.html: Removed.
  • fast/filesystem/op-remove-expected.txt: Removed.
  • fast/filesystem/op-remove.html: Removed.
  • fast/filesystem/op-restricted-chars-expected.txt: Removed.
  • fast/filesystem/op-restricted-chars.html: Removed.
  • fast/filesystem/op-restricted-names-expected.txt: Removed.
  • fast/filesystem/op-restricted-names.html: Removed.
  • fast/filesystem/op-restricted-unicode-expected.txt: Removed.
  • fast/filesystem/op-restricted-unicode.html: Removed.
  • fast/filesystem/read-directory-expected.txt: Removed.
  • fast/filesystem/read-directory.html: Removed.
  • fast/filesystem/resources: Removed.
  • fast/filesystem/resources/async-operations.js: Removed.
  • fast/filesystem/resources/directory-entry-to-uri.js: Removed.
  • fast/filesystem/resources/file-entry-to-uri-sync.js: Removed.
  • fast/filesystem/resources/file-entry-to-uri.js: Removed.
  • fast/filesystem/resources/file-from-file-entry-sync.js: Removed.
  • fast/filesystem/resources/file-from-file-entry.js: Removed.
  • fast/filesystem/resources/file-writer-abort-continue.js: Removed.
  • fast/filesystem/resources/file-writer-abort-depth.js: Removed.
  • fast/filesystem/resources/file-writer-abort.js: Removed.
  • fast/filesystem/resources/file-writer-empty-blob.js: Removed.
  • fast/filesystem/resources/file-writer-events.js: Removed.
  • fast/filesystem/resources/file-writer-gc-blob.js: Removed.
  • fast/filesystem/resources/file-writer-sync-truncate-extend.js: Removed.
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js: Removed.
  • fast/filesystem/resources/file-writer-truncate-extend.js: Removed.
  • fast/filesystem/resources/file-writer-utils.js: Removed.
  • fast/filesystem/resources/file-writer-write-overlapped.js: Removed.
  • fast/filesystem/resources/fs-test-util.js: Removed.
  • fast/filesystem/resources/fs-worker-common.js: Removed.
  • fast/filesystem/resources/op-copy.js: Removed.
  • fast/filesystem/resources/op-get-entry.js: Removed.
  • fast/filesystem/resources/op-get-metadata.js: Removed.
  • fast/filesystem/resources/op-get-parent.js: Removed.
  • fast/filesystem/resources/op-move.js: Removed.
  • fast/filesystem/resources/op-read-directory.js: Removed.
  • fast/filesystem/resources/op-remove.js: Removed.
  • fast/filesystem/resources/op-restricted-chars.js: Removed.
  • fast/filesystem/resources/op-restricted-names.js: Removed.
  • fast/filesystem/resources/op-restricted-unicode.js: Removed.
  • fast/filesystem/resources/op-tests-helper.js: Removed.
  • fast/filesystem/resources/shared-worker-stub.js: Removed.
  • fast/filesystem/resources/simple-persistent-sync.js: Removed.
  • fast/filesystem/resources/simple-persistent.js: Removed.
  • fast/filesystem/resources/simple-readonly.js: Removed.
  • fast/filesystem/resources/simple-required-arguments-getdirectory.js: Removed.
  • fast/filesystem/resources/simple-required-arguments-getfile.js: Removed.
  • fast/filesystem/resources/simple-required-arguments-getmetadata.js: Removed.
  • fast/filesystem/resources/simple-required-arguments-remove.js: Removed.
  • fast/filesystem/resources/simple-temporary-sync.js: Removed.
  • fast/filesystem/resources/simple-temporary.js: Removed.
  • fast/filesystem/resources/sync-operations.js: Removed.
  • fast/filesystem/script-tests: Removed.
  • fast/filesystem/script-tests/TEMPLATE.html: Removed.
  • fast/filesystem/script-tests/filesystem-reference.js: Removed.
  • fast/filesystem/script-tests/filesystem-unserializable.js: Removed.
  • fast/filesystem/script-tests/flags-passing.js: Removed.
  • fast/filesystem/script-tests/read-directory.js: Removed.
  • fast/filesystem/simple-persistent-expected.txt: Removed.
  • fast/filesystem/simple-persistent.html: Removed.
  • fast/filesystem/simple-readonly-expected.txt: Removed.
  • fast/filesystem/simple-readonly-file-object-expected.txt: Removed.
  • fast/filesystem/simple-readonly-file-object.html: Removed.
  • fast/filesystem/simple-readonly.html: Removed.
  • fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Removed.
  • fast/filesystem/simple-required-arguments-getdirectory.html: Removed.
  • fast/filesystem/simple-required-arguments-getfile-expected.txt: Removed.
  • fast/filesystem/simple-required-arguments-getfile.html: Removed.
  • fast/filesystem/simple-required-arguments-getmetadata-expected.txt: Removed.
  • fast/filesystem/simple-required-arguments-getmetadata.html: Removed.
  • fast/filesystem/simple-required-arguments-remove-expected.txt: Removed.
  • fast/filesystem/simple-required-arguments-remove.html: Removed.
  • fast/filesystem/simple-temporary-expected.txt: Removed.
  • fast/filesystem/simple-temporary.html: Removed.
  • fast/filesystem/workers: Removed.
  • fast/filesystem/workers/async-operations-expected.txt: Removed.
  • fast/filesystem/workers/async-operations.html: Removed.
  • fast/filesystem/workers/detached-frame-crash-expected.txt: Removed.
  • fast/filesystem/workers/detached-frame-crash.html: Removed.
  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Removed.
  • fast/filesystem/workers/file-entry-to-uri-sync.html: Removed.
  • fast/filesystem/workers/file-from-file-entry-expected.txt: Removed.
  • fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Removed.
  • fast/filesystem/workers/file-from-file-entry-sync.html: Removed.
  • fast/filesystem/workers/file-from-file-entry.html: Removed.
  • fast/filesystem/workers/file-writer-empty-blob-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-empty-blob.html: Removed.
  • fast/filesystem/workers/file-writer-events-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-events-shared-worker.html: Removed.
  • fast/filesystem/workers/file-writer-events.html: Removed.
  • fast/filesystem/workers/file-writer-gc-blob-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-gc-blob.html: Removed.
  • fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-sync-truncate-extend.html: Removed.
  • fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-sync-write-overlapped.html: Removed.
  • fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-truncate-extend.html: Removed.
  • fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-write-overlapped.html: Removed.
  • fast/filesystem/workers/resources: Removed.
  • fast/filesystem/workers/resources/detached-frame-crash-frame.html: Removed.
  • fast/filesystem/workers/resources/detached-frame-crash-worker.js: Removed.
  • fast/filesystem/workers/simple-persistent-expected.txt: Removed.
  • fast/filesystem/workers/simple-persistent-sync-expected.txt: Removed.
  • fast/filesystem/workers/simple-persistent-sync.html: Removed.
  • fast/filesystem/workers/simple-persistent.html: Removed.
  • fast/filesystem/workers/simple-temporary-expected.txt: Removed.
  • fast/filesystem/workers/simple-temporary-sync-expected.txt: Removed.
  • fast/filesystem/workers/simple-temporary-sync.html: Removed.
  • fast/filesystem/workers/simple-temporary.html: Removed.
  • fast/filesystem/workers/sync-operations-expected.txt: Removed.
  • fast/filesystem/workers/sync-operations.html: Removed.
  • fast/forms/file/input-file-entries-expected.txt: Removed.
  • fast/forms/file/input-file-entries.html: Removed.
  • http/tests/filesystem: Removed.
  • http/tests/filesystem/no-cache-filesystem-url-expected.txt: Removed.
  • http/tests/filesystem/no-cache-filesystem-url.html: Removed.
  • http/tests/filesystem/resolve-uri-expected.txt: Removed.
  • http/tests/filesystem/resolve-uri.html: Removed.
  • http/tests/filesystem/resources: Removed.
  • http/tests/filesystem/resources/fs-test-util.js: Removed.
  • http/tests/filesystem/resources/fs-worker-common.js: Removed.
  • http/tests/filesystem/resources/fs-worker-test-util.js: Removed.
  • http/tests/filesystem/script-tests: Removed.
  • http/tests/filesystem/script-tests/TEMPLATE.html: Removed.
  • http/tests/filesystem/script-tests/resolve-uri.js: Removed.
  • http/tests/filesystem/workers: Removed.
  • http/tests/filesystem/workers/resolve-url-expected.txt: Removed.
  • http/tests/filesystem/workers/resolve-url-sync-expected.txt: Removed.
  • http/tests/filesystem/workers/resolve-url-sync.html: Removed.
  • http/tests/filesystem/workers/resolve-url.html: Removed.
  • http/tests/filesystem/workers/script-tests: Removed.
  • http/tests/filesystem/workers/script-tests/TEMPLATE.html: Removed.
  • http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Removed.
  • http/tests/inspector/filesystem: Removed.
  • http/tests/inspector/filesystem/delete-entry-expected.txt: Removed.
  • http/tests/inspector/filesystem/delete-entry.html: Removed.
  • http/tests/inspector/filesystem/directory-tree-expected.txt: Removed.
  • http/tests/inspector/filesystem/directory-tree.html: Removed.
  • http/tests/inspector/filesystem/filesystem-test.js: Removed.
  • http/tests/inspector/filesystem/request-directory-content-expected.txt: Removed.
  • http/tests/inspector/filesystem/request-directory-content.html: Removed.
  • http/tests/inspector/filesystem/request-file-content-expected.txt: Removed.
  • http/tests/inspector/filesystem/request-file-content.html: Removed.
  • http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Removed.
  • http/tests/inspector/filesystem/request-filesystem-root.html: Removed.
  • http/tests/inspector/filesystem/request-metadata-expected.txt: Removed.
  • http/tests/inspector/filesystem/request-metadata.html: Removed.
  • http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Removed.
  • http/tests/security/filesystem-iframe-from-remote-expected.txt: Removed.
  • http/tests/security/filesystem-iframe-from-remote.html: Removed.
  • http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Removed.
  • http/tests/security/mixedContent/filesystem-url-in-iframe.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
  • http/tests/workers/resources/sync-operations.js:

(onmessage):

  • http/tests/workers/terminate-during-sync-operation-expected.txt: Removed.
  • http/tests/workers/terminate-during-sync-operation.html: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
6:47 PM Changeset in webkit [156691] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Build fix afer r156688.

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::ThreadableBlobRegistry::registerBlobURL): Switch to std::unique_ptr in
method implementation.

6:37 PM Changeset in webkit [156690] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • NetworkProcess/mac/RemoteNetworkingContext.mm:
6:24 PM Changeset in webkit [156689] by mrowe@apple.com
  • 3 edits in trunk/Tools

More build fixage for builds with SDKs.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/BaseTarget.xcconfig:
5:59 PM Changeset in webkit [156688] by andersca@apple.com
  • 93 edits in trunk/Source

Get rid of more uses of OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122136

Reviewed by Antti Koivisto.

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

  • WebCore.exp.in:
  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::slice):

  • fileapi/Blob.h:

(WebCore::Blob::create):

  • fileapi/File.cpp:

(WebCore::createBlobDataForFileWithType):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):
(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):

  • fileapi/ThreadableBlobRegistry.h:
  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::getBlob):

  • platform/network/BlobData.cpp:

(WebCore::BlobDataHandle::BlobDataHandle):

  • platform/network/BlobData.h:

(WebCore::BlobData::BlobData):
(WebCore::BlobDataHandle::create):

  • platform/network/BlobRegistry.h:
  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):

  • platform/network/BlobRegistryImpl.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseBlob):

Source/WebKit2:

  • NetworkProcess/AsynchronousNetworkLoaderClient.h:
  • NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):

  • NetworkProcess/FileAPI/NetworkBlobRegistry.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/SynchronousNetworkLoaderClient.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/ArgumentEncoder.h:
  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::setImportanceAssertion):

  • Platform/CoreIPC/MessageDecoder.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::receiveSourceEventHandler):

  • Platform/CoreIPC/mac/ImportanceAssertion.h:

(CoreIPC::ImportanceAssertion::ImportanceAssertion):

  • Platform/mac/LayerHostingContext.h:
  • Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::createPluginInternal):

  • PluginProcess/WebProcessConnection.h:
  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage):

  • Shared/BlockingResponseMap.h:

(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):

  • Shared/Downloads/Download.cpp:
  • Shared/Downloads/Download.h:
  • Shared/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):

  • Shared/FileAPI/BlobRegistrationData.cpp:

(WebKit::BlobRegistrationData::BlobRegistrationData):
(WebKit::BlobRegistrationData::releaseData):
(WebKit::BlobRegistrationData::decode):

  • Shared/FileAPI/BlobRegistrationData.h:
  • Shared/Plugins/NPObjectMessageReceiver.cpp:
  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::registerNPObject):

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/ShareableBitmap.h:
  • Shared/WebURL.h:

(WebKit::WebURL::create):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::parseURLIfNecessary):

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):

  • Shared/mac/SecItemShim.cpp:

(WebKit::sendSecItemRequest):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDelete):
(WebKit::SecItemShim::secItemResponse):

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createDrawingAreaProxy):

  • UIProcess/API/mac/WKView.mm:

(-[WKView std::WebKit::]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/BackingStore.cpp:
  • UIProcess/BackingStore.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerBlobURL):

  • WebProcess/FileAPI/BlobRegistryProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
  • WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:

(WKBundlePageBannerCreateBannerWithCALayer):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::scheduleTimer):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::snapshot):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::snapshot):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):

  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::getFindIndicatorBitmapAndRect):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit::WebPage::drawRectToImage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
5:48 PM Changeset in webkit [156687] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041

Reviewed by Andreas Kling.

In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::sendAbortingOnFailure):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::sendSync):

  • Shared/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):

  • UIProcess/WebContext.h:

(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

4:42 PM Changeset in webkit [156686] by Lucas Forschler
  • 1 copy in branches/safari-537.73-branch

New Branch.

4:13 PM Changeset in webkit [156685] by timothy@apple.com
  • 1 edit
    36 adds in trunk/Tools

Add initial version of a new Buildbot dashboard view.

https://bugs.webkit.org/show_bug.cgi?id=122131

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
3:52 PM Changeset in webkit [156684] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/15114974> Assertion failure under -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] if no classes conform to JSExport
https://bugs.webkit.org/show_bug.cgi?id=122124

Reviewed by Darin Adler.

  • API/JSWrapperMap.mm: Defined an empty class that conforms to the JSExport protocol, to

ensure that the protocol is always registered with the runtime by the time
getJSExportProtocol() is called.

3:43 PM Changeset in webkit [156683] by benjamin@webkit.org
  • 46 edits in trunk

Remove the code guarded by STYLE_SCOPED
https://bugs.webkit.org/show_bug.cgi?id=122123

Reviewed by Anders Carlsson.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Start cleaning the code related to <style scoped>. This patch
only removes the code with #ifdef guards.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

  • bindings/generic/RuntimeEnabledFeatures.h:
  • css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::appendAuthorStyleSheets):

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchScopedAuthorRules):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):

  • css/StyleScopeResolver.cpp:
  • css/StyleScopeResolver.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

  • dom/ShadowRoot.h:
  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):

  • html/HTMLStyleElement.h:
  • html/HTMLStyleElement.idl:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
2:56 PM Changeset in webkit [156682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=122032

Patch by Drew Yao <ayao@apple.com> on 2013-09-30
Reviewed by Andreas Kling.

Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.

No new tests needed.

  • rendering/InlineBox.h:

(WebCore::InlineBox::parent):

2:54 PM Changeset in webkit [156681] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.
https://bugs.webkit.org/show_bug.cgi?id=122115

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-30
Reviewed by Daniel Bates.

With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by
passing a native image. If this image is added to memory cache, we shouldn't attempt to destroy
its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again.

No new tests for now. Currently there isn't a code path to add to the memory cache a BitmapImage
that was created by adopting a native image. We'll add such a code path in a subsequent patch.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedDataIfNecessary):

2:42 PM Changeset in webkit [156680] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Pass VM instead of ExecState to ObjectPrototype constructor.
<https://webkit.org/b/122116>

Reviewed by Geoffrey Garen.

The ObjectPrototype constructor was only using the ExecState to get
to the VM.

2:41 PM Changeset in webkit [156679] by akling@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Pass VM instead of JSGlobalObject to MathObject constructor.
<https://webkit.org/b/122119>

Reviewed by Geoffrey Garen.

The MathObject constructor was only using the global object to get
to the VM. finishCreation() still uses it to set up functions.

1:47 PM Changeset in webkit [156678] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Remove timeout from shouldBecome* functions in js-test-pre
https://bugs.webkit.org/show_bug.cgi?id=122121

Reviewed by Ryosuke Niwa.

Removed timeout. A 0.5 sec timeout never makes sense, and if something is stuck,
a test should just time out normally.

  • resources/js-test-pre.js:

(_waitForCondition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):

1:38 PM Changeset in webkit [156677] by fpizlo@apple.com
  • 21 edits
    1 add in trunk/Source/JavaScriptCore

Get rid of the AlreadyInJSStack recoveries since they are totally redundant with the DisplacedInJSStack recoveries
https://bugs.webkit.org/show_bug.cgi?id=122065

Reviewed by Mark Hahnenberg.

This mostly just kills a bunch of code.

But incidentaly while killing that code, I uncovered a bug in our FTL OSR entrypoint
creation phase. The phase inserts a sequence of SetLocal(ExtractOSREntryLocal) nodes.
If we hoist some type check into the local, then we might inject a conversion node
between the ExtractOSREntryLocal and the SetLocal - for example we might put in a
Int32ToDouble node. But currently the FixupPhase will make all conversion nodes placed
on an edge of a SetLocal use forward exit. This then confuses the OSR exit machinery.
When OSR exit sees a forward exit, it tries to "roll forward" execution from the exiting
node to the first node that has a different CodeOrigin. This only works if the nodes
after the forward exit are MovHints or other tnings that the OSR exit compiler can
forward-execute. But here, it will see a bunch of SetLocal and ExtractOSREntryLocal
nodes for the same bytecode index. Two possible solutions exist. We could teach the
forward-execution logic how to deal with multiple SetLocals and ExtractOSREntryLocals.
This would be a lot of complexity; right now it just needs to deal with exactly one
SetLocal-like operation. The alternative is to make sure that the conversion node that
we inject ends up exiting *backward* rather than forward.

But making the conversion nodes exit backward is somewhat tricky. Before this patch,
conversion nodes always exit forward for SetLocals and backwards otherwise. It turns out
that the solution is to rationalize how we choose the speculation direciton for a
conversion node. The conversion node's speculation direction should be the same as the
speculation direction of the node for which it is doing a conversion. Since SetLocal's
already exit forward by default, this policy preserves our previous behavior. But it
also allows the OSR entrypoint creation phase to make its SetLocals exit backward
instead.

Of course, if the SetLocal(ExtractOSREntryLocal) sequences exit backward, then we need
to make sure that the OSR exit machine knows that the local variables are indeed live.
Consider that if we have:

a: ExtractOSREntryLocal(loc1)
b: SetLocal(@a, loc1)
c: ExtractOSRentryLocal(loc2)
d: SetLocal(@c, loc2)


Without additional magic, the exit at @b will think that loc2 is dead and the OSR exit
compiler will clobber loc2 with Undefined. So we need to make sure that we actually
emit code like:

a: ExtractOSREntryLocal(loc1)
b: ExtractOSREntryLocal(loc2)
c: SetLocal(@a, loc1)
d: SetLocal(@b, loc2)
e: SetLocal(@a, loc1)
f: SetLocal(@b, loc2)

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeOrigin.h:
  • bytecode/ValueRecovery.cpp: Added.

(JSC::ValueRecovery::recover):
(JSC::ValueRecovery::dumpInContext):
(JSC::ValueRecovery::dump):

  • bytecode/ValueRecovery.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):

  • dfg/DFGNode.h:

(JSC::DFG::Node::speculationDirection):
(JSC::DFG::Node::setSpeculationDirection):

  • dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::valueRecovery):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMachineInt):

  • interpreter/Register.h:

(JSC::Register::unboxedStrictInt52):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff):

  • runtime/Arguments.h:
1:32 PM Changeset in webkit [156676] by beidson@apple.com
  • 19 edits
    1 delete in trunk/Source/WebCore

Remove IDBTracing.h.
https://bugs.webkit.org/show_bug.cgi?id=122118

Reviewed by Alexey Proskuryakov.

Global replace of "IDB_TRACE" with "LOG(StorageAPI)", and remove all notions of this header.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBCursor.cpp:
  • Modules/indexeddb/IDBDatabase.cpp:
  • Modules/indexeddb/IDBDatabaseBackendInterface.h:
  • Modules/indexeddb/IDBFactory.cpp:
  • Modules/indexeddb/IDBIndex.cpp:
  • Modules/indexeddb/IDBObjectStore.cpp:
  • Modules/indexeddb/IDBOpenDBRequest.cpp:
  • Modules/indexeddb/IDBRequest.cpp:
  • Modules/indexeddb/IDBTracing.h: Removed.
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/IDBBindingUtilities.cpp:
1:10 PM Changeset in webkit [156675] by Antoine Quint
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: rows in the Layer sidebar panel may have the incorrect background color
https://bugs.webkit.org/show_bug.cgi?id=122108

Reviewed by Darin Adler.

The LayerTreeDataGrid is a custom DataGrid subclass which exposes a .setChildren() method
used to sort chidren without DOM order manipulation, for performance reason. However, since
the way the alternating background color is usually implemented is based on the built-in
CSS pseudo-classes working with DOM order, the background colors of nodes in the LayerTreeDataGrid
can be incorrect depending on the sort order and the number of nodes. To fix this, we now manually
set "even" and "odd" CSS classes on those nodes when they're sorted such that we have a chance
to style them as intended.

  • UserInterface/LayerTreeDataGrid.js:

(WebInspector.LayerTreeDataGrid.prototype._updateChildren):
Check if the data grid node index is even or odd and reflect this via an exclusive "even"
or "odd" CSS class name.

  • UserInterface/LayerTreeSidebarPanel.css:

(.layer-tree.panel .data-container tbody > tr.even):
(.layer-tree.panel .data-container tbody > tr.odd):
Apply alternating colors based on the exclusive "even" and "odd" CSS class names as applied in
WebInspector.LayerTreeDataGrid.prototype._updateChildren().

1:07 PM Changeset in webkit [156674] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix for Win64.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Added correct 64-bit BitmapImage::create symbol.

1:07 PM Changeset in webkit [156673] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Popover displaying "reasons for compositing" may remain on screen after selected layer is removed
https://bugs.webkit.org/show_bug.cgi?id=117575

Ensure the popover attached to the selected data grid node is updated when the
content or sort order of the Layer sidebar panel is updated.

Reviewed by Darin Adler.

  • UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):

1:06 PM Changeset in webkit [156672] by Antoine Quint
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: nodes can be dragged from the console log
https://bugs.webkit.org/show_bug.cgi?id=122105

Reviewed by Darin Adler.

Catch "dragstart" events targeting nodes hosted in a DOMTreeOutline within the console
log view and prevent the default logic to trigger so that these nodes can't be dragged
off the console as it wouldn't make sense to.

  • UserInterface/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline):
Create a class property to allow the CSS class name to be used in WebInspector.LogContentView.

  • UserInterface/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._ondragstart):
Track the "dragstart" events in their capture phase such that, if the event target is
a DOM node hosted in a DOMTreeOutline, we can prevent the event from propagating and
cancel its default behavior such that no dragging at all is performed.

12:51 PM Changeset in webkit [156671] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/JavaScriptCore

Win64 compile fix after r1256490.
https://bugs.webkit.org/show_bug.cgi?id=122117

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-30
Reviewed by Michael Saboff.

  • jit/JITStubsMSVC64.asm:

Implemented getHostCallReturnValue for Windows x86_64 processors.

12:44 PM Changeset in webkit [156670] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

NetworkResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=122110

Reviewed by Darin Adler.

  • NetworkProcess/NetworkResourceLoader.messages.in:
12:35 PM Changeset in webkit [156669] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Windows] Build fix after r156622. Build RenderLayerModelObject.cpp in a separate compilation unit
from the RenderLayerAllnOne file so that the scalar and vector destructors are visible to other
elements of WebCore during the build.

  • WebCore.vcxproj/WebCore.vcxproj: Compile RenderLayerModelObject outside of the all-in-one file.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • rendering/RenderingAllInOne.cpp: Remove RenderLayerModelObject.cpp.
11:58 AM Changeset in webkit [156668] by akling@apple.com
  • 11 edits in trunk/Source

Pass VM instead of JSGlobalObject to RegExp constructor.
<https://webkit.org/b/122113>

Reviewed by Darin Adler.

RegExps don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.

JSC release binary size -= 120 bytes(!)

11:13 AM Changeset in webkit [156667] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Compile errors in WebKit (via peavo@outlook.com).
https://bugs.webkit.org/show_bug.cgi?id=122106

Reviewed by Darin Adler.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add link

declarations missed in r156655.

11:09 AM Changeset in webkit [156666] by mrowe@apple.com
  • 9 edits in trunk

Fix the build when building against an SDK.

Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
the compiler command lines. It can't know to do this for the system framework search paths
we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
  • WebKitTestRunner/Configurations/BaseTarget.xcconfig:
10:58 AM Changeset in webkit [156665] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Correct malformed XML in project files.
10:56 AM Changeset in webkit [156664] by jer.noble@apple.com
  • 11 edits in trunk

Unreviewed, roll back in r156546 with rebaselined tests.
https://bugs.webkit.org/show_bug.cgi?id=122111

Source/WebCore:

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.updateHasAudio):

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/mac/fast/layers/video-layer-expected.png:
  • platform/mac/fast/layers/video-layer-expected.txt:
  • platform/mac/media/media-controls-clone-expected.png:
  • platform/mac/media/media-controls-clone-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
10:38 AM Changeset in webkit [156663] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk/LayoutTests

editing/execCommand/findString-diacriticals.html expects to fail
https://bugs.webkit.org/show_bug.cgi?id=122100

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
Reviewed by Alexey Proskuryakov.

Since all major platforms pass editing/execCommand/findString-diacriticals.html,
the test now globally expects "PASS" instead of "FAIL" rendering the individual
platform expectation files obsolete.

  • editing/execCommand/findString-diacriticals-expected.txt: "PASS" -> "FAIL"
  • platform/efl/TestExpectations: EFL passes editing/execCommand/findString-diacriticals.
  • platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Removed.
  • platform/mac/editing/execCommand/findString-diacriticals-expected.txt: Removed.
  • platform/qt/editing/execCommand/findString-diacriticals-expected.txt: Removed.
10:36 AM Changeset in webkit [156662] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.

A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
it to be double-freed.

  • WinLauncher/WinLauncher.cpp:

(EditProc): Be explicit about type passed to loadURL.
(loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
that reallocating the BSTR is done with the knowledge of the smart pointer.

9:59 AM Changeset in webkit [156661] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r156656.
http://trac.webkit.org/changeset/156656
https://bugs.webkit.org/show_bug.cgi?id=122111

Broke several media tests (Requested by ap on #webkit).

Source/WebCore:

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac/media/video-no-audio-expected.txt:
9:50 AM Changeset in webkit [156660] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Convert a bunch of OwnPtrs on Page to std::unique_ptrs
https://bugs.webkit.org/show_bug.cgi?id=122086

Reviewed by Darin Adler.

  • loader/ProgressTracker.cpp:
  • loader/ProgressTracker.h:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::setGroupName):
(WebCore::Page::initGroup):

  • page/Page.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):

  • page/PageGroup.h:
9:32 AM Changeset in webkit [156659] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Changed expectation for accessibility/file-upload-button-stringvalue.html after r156532
https://bugs.webkit.org/show_bug.cgi?id=122103

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30

  • platform/efl-wk1/TestExpectations: file-upload-button-stringvalue.html fails on efl-wk1.

Unskipped accessibility/heading-level.html. It passes after r156551.

  • platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt:
9:30 AM Changeset in webkit [156658] by allan.jensen@digia.com
  • 7 edits
    2 deletes in trunk

[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961

Reviewed by Csaba Osztrogonác.

Get rid of the unused WebKit2QML library

.:

  • Source/api.pri:

Source/WebKit2:

  • Target.pri:
  • WebKit2.pro:
  • WebKit2QML.pri: Removed.

Tools:

  • qmake/mkspecs/features/webkit_modules.prf:
  • qmake/mkspecs/modules/webkit2qml.prf: Removed.
9:21 AM Changeset in webkit [156657] by Antti Koivisto
  • 14 edits
    1 delete in trunk/Source/WebCore

Remove FontTranscoder
https://bugs.webkit.org/show_bug.cgi?id=122088

Reviewed by Andreas Kling.

This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.cpp:

(WebCore::useBackslashAsYenSignForFamily):

Move the family set to Font.cpp.

(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update):

Keep the cached boolean up to date.

  • platform/graphics/Font.h:

(WebCore::Font::useBackslashAsYenSymbol):

Use descriptive name instead of talking about "transcoding".

  • platform/text/transcoder: Removed.
  • platform/text/transcoder/FontTranscoder.cpp: Removed.
  • platform/text/transcoder/FontTranscoder.h: Removed.
  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):
(WebCore::RenderText::computeUseBackslashAsYenSymbol):

Rename for clarity.
Avoid unnecessary hash lookup, just check the cached bit in Font.

(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::setTextInternal):

"Transcoding" here was just a simple character replacement.

(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol):

Renamed.

  • rendering/RenderText.h:
9:09 AM Changeset in webkit [156656] by jer.noble@apple.com
  • 5 edits in trunk

REGRESSION(r156546): media/video-no-audio.html broken
https://bugs.webkit.org/show_bug.cgi?id=122049

Reviewed by Eric Carlson.

Source/WebCore:

Now that our video elements have audio tracks, use their presence or
absense to show or hide the volume controls.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.addVideoListeners): Listen for audioTrack changes.
(Controller.prototype.removeVideoListeners): Stop listening to same.
(Controller.prototype.handleAudioTrackChange): Call this.updateHasAudio()
(Controller.prototype.handleAudioTrackAdd): Ditto.
(Controller.prototype.handleAudioTrackRemove): Ditto.
(Controller.prototype.updateHasAudio): Hide the volume controls if no

audioTracks are present, and vice versa.

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac/media/video-no-audio-expected.txt:
8:43 AM Changeset in webkit [156655] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/win

Try to fix the Windows build.

  • WebFrame.cpp:

(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):

8:42 AM Changeset in webkit [156654] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Fix compilation for COMPILER(MSVC) && !CPU(X86) after r156490.
https://bugs.webkit.org/show_bug.cgi?id=122102

Reviewed by Geoffrey Garen.

_AddressOfReturnAddress() is supported for all platforms of
ths Microsoft compiler, so we can use it for !CPU(X86) too.

  • jit/JITOperationWrappers.h:
8:39 AM Changeset in webkit [156653] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Mac-Lion build fix.

Use metadataItemsFromArray:withLocale: instead of
metadataItemsFromArray:filteredAndSortedAccordingToPreferredLanguages:
on Lion and earlier.

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):

8:17 AM Changeset in webkit [156652] by jer.noble@apple.com
  • 6 edits
    5 adds in trunk

[Mac] Add AudioTrack support to MediaPlayerPrivateAVFObC.
https://bugs.webkit.org/show_bug.cgi?id=122043

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/audio-track.html

Add a new class AudioTrackPrivateAVF and subclass AudioTrackPrivateAVFObjC
which are backed by a AVPlayerItemTrack. Create one of these tracks when
we are notified that the list of available tracks has changed.

  • WebCore.xcodeproj/project.pbxproj:
  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::setEnabled): Pass through to the AudioTrackPrivate

so that the underlying media track can be (dis|en)abled.

  • platform/graphics/avfoundation/AudioTrackPrivateAVF.h: Added.

(WebCore::AudioTrackPrivateAVF::kind): Simple getter.
(WebCore::AudioTrackPrivateAVF::id): Ditto.
(WebCore::AudioTrackPrivateAVF::label): Ditto.
(WebCore::AudioTrackPrivateAVF::language): Ditto.
(WebCore::AudioTrackPrivateAVF::setKind): Simple Setter.
(WebCore::AudioTrackPrivateAVF::setId): Ditto.
(WebCore::AudioTrackPrivateAVF::setLabel): Ditto.
(WebCore::AudioTrackPrivateAVF::setLanguage): Ditto.
(WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF): Simple constructor.

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h: Added.

(WebCore::AudioTrackPrivateAVFObjC::create): Simple factory.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Simple getter.

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm: Added.

(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Fill out the values from

the associated AVPlayerItemTrack and its AVAssetTrack.

(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): (En|Dis)able the AVPlayerItemTrack.
(WebCore::AudioTrackPrivateAVFObjC::languageForAVAssetTrack): Refactored from

MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Determine which tracks

have been added or removed and notify the clients accordingly.

(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Refactor into

AudioTrackPrivateAVFObjC::languageForAVAssetTrack.

LayoutTests:

  • media/track/audio-track-expected.txt: Added.
  • media/track/audio-track.html: Added.
7:57 AM Changeset in webkit [156651] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Added passing expectation for fast/forms/textarea-metrics.html
https://bugs.webkit.org/show_bug.cgi?id=122107

Unreviewed EFL gardening.

fast/forms/textarea-metrics.html fails in WebKitTestRunner but returns expected
results in MiniBrowser. Since GTK uses platform dependent expectation file to
migitate this identical discrepancy, the same solution has been applied to EFL.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30

  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/textarea-metrics-expected.txt: Added.
7:05 AM Changeset in webkit [156650] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r153927.

  • WebView.cpp:

(WebView::WebView):

6:58 AM Changeset in webkit [156649] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r155289.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):

6:57 AM Changeset in webkit [156648] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r154178.

  • WebView.cpp:

(WebView::wndProc):

6:15 AM Changeset in webkit [156647] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Fix incorrect click counting in EventSenderProxy
https://bugs.webkit.org/show_bug.cgi?id=122098

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-30
Reviewed by Gyuyoung Kim.

Tools:

Previously used two types of recording time, which conflicted with each other.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::EventSenderProxy::mouseUp):

LayoutTests:

After fixing EventSenderProxy extend-selection-after-double-click.html runs correctly.

  • platform/efl/TestExpectations:
4:49 AM Changeset in webkit [156646] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening after the resolution of bug 84835
https://bugs.webkit.org/show_bug.cgi?id=122096

Unreviewed EFL gardening.

Removed expected failures for bug 84835.
editing/pasteboard/copy-inside-h1-preserves-h1 and
editing/pasteboard/copy-without-selection are still failing due to bug 86623
and have been marked accordingly.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
3:56 AM Changeset in webkit [156645] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Two tests are passing in WK2 after r156541.

  • platform/gtk-wk2/TestExpectations: Removed passing tests.
3:46 AM Changeset in webkit [156644] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Accessibility tests pass after r156532 and r156551
https://bugs.webkit.org/show_bug.cgi?id=122090

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30

  • platform/efl-wk2/TestExpectations:
3:44 AM Changeset in webkit [156643] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] New test accessibility/table-with-hidden-head-section.html failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=111850

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
Reviewed by Mario Sanchez Prada.

Test passes after r156532.

  • platform/efl/TestExpectations:
3:39 AM Changeset in webkit [156642] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Generate toCSSCalcValue instead of using manual cast function
https://bugs.webkit.org/show_bug.cgi?id=122055

Reviewed by Antti Koivisto.

Generated type cast function supports more plenty functions rather than manual functions.
To use CSS_VALUE_TYPE_CAST, isCalculationValue() needs to be changed with isCalcValue().

No new tests, no behavior changes.

  • css/CSSCalculationValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isCalcValue):

  • css/StyleResolver.cpp:

(WebCore::hasVariableReference):

2:33 AM Changeset in webkit [156641] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

1:26 AM Changeset in webkit [156640] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[webkitpy] Make the Xvfb screen depth overridable
https://bugs.webkit.org/show_bug.cgi?id=122089

Reviewed by Gyuyoung Kim.

Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
was set. The default value that's used if the variable wasn't set is 24.

  • Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._xvfb_screen_depth):
(XvfbDriver._start):

  • Scripts/webkitpy/port/xvfbdriver_unittest.py:

(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):

1:21 AM Changeset in webkit [156639] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Get rid of static map for marking ancestor line boxes dirty
https://bugs.webkit.org/show_bug.cgi?id=122080

Reviewed by Andreas Kling.

This is ugly and shows up in profiles too. Use a bit in RenderElement instead.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:


Move dirtyLinesFromChangedChild down to RenderBlockFlow. It wouldn't do anything on other RenderBlocks.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

  • rendering/RenderElement.h:


Add m_ancestorLineBoxDirty bit. We have 32 unused bits here on 64bit systems.

(WebCore::RenderElement::dirtyLinesFromChangedChild):
(WebCore::RenderElement::ancestorLineBoxDirty):
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):

  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

Tighten the interface.

  • rendering/RenderLineBoxList.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderObject.h:


Remove the static map.

1:14 AM Changeset in webkit [156638] by svillar@igalia.com
  • 9 edits
    2 adds in trunk

[CSS Grid Layout] Implement the grid-area shorthand
https://bugs.webkit.org/show_bug.cgi?id=103334

Reviewed by Andreas Kling.

Source/WebCore:

Based on Blink r151684 by <jchaffraix@chromium.org>

Test: fast/css-grid-layout/grid-item-area-get-set.html

Added support to specify grid positions using the
'-webkit-grid-area' shorthand. Named grid areas are still not
allowed, to be done in a follow up patch as it likely requires
'-webkit-grid-template' support.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):

  • css/CSSPropertyNames.in:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitGridAreaShorthand):
(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

From Blink r151684 by <jchaffraix@chromium.org>

  • fast/css-grid-layout/grid-item-area-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-item-area-get-set.html: Added.
1:10 AM Changeset in webkit [156637] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::fmodAsDFGOperation):

12:35 AM Changeset in webkit [156636] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/Source/WebCore

Generate toCSSFooValue for CSSGradientValue, CSSLinearGradientValue and CSSRadialGradient
https://bugs.webkit.org/show_bug.cgi?id=122060

Reviewed by Antti Koivisto.

As a step to generate toCSSFooValue, toCSSGradientValuem toCSSLinearGradientValue and
toCSSRadialGradient are generated. isLinearGradient() and isRadialGradient() are moved
from each class to CSSValue in order to generate toCSSFooValue.

No new tests, no behavior change.

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::gradientWithStylesResolved):

  • css/CSSGradientValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseDeprecatedGradient):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isLinearGradient):
(WebCore::CSSValue::isRadialGradient):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):

12:12 AM Changeset in webkit [156635] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

user-select: none cursor turns to I-beam on mouse dragging
https://bugs.webkit.org/show_bug.cgi?id=90159

Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-09-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

When tried to select some text in an area that has style
cursor:default set, cursor type changes to text cursor ignoring
the cursor style that is explicitly set.

When the cursor style is explicitly set as default (or something else),
we should not change it to text cursor no matter what we are over
or what operation we are performing (be it hovering over the text
or selecting the text).

During text selection, changing the cursor type to text only when
there is no explicit cursor type set fixes the issue.

Test: editing/caret/selection-with-caret-type-progress.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):
During selection, set the cursor style to text only if there is no
explicit cursor style set.

LayoutTests:

Test case added to verify that explicitly set cursor style
is retained on performing text selection.

  • editing/caret/selection-with-caret-type-progress-expected.txt: Added.
  • editing/caret/selection-with-caret-type-progress.html: Added.

Sep 29, 2013:

11:32 PM Changeset in webkit [156634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

FTL: refactor compileAdd and compileArithSub into one function.
https://bugs.webkit.org/show_bug.cgi?id=122081

Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):

10:40 PM Changeset in webkit [156633] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSCanvasValue
https://bugs.webkit.org/show_bug.cgi?id=122058

Reviewed by Antti Koivisto.

Generate toCSSFooValue() for CSSCanvasValue, and use it.
This type cast function will help to detect bad-casts.
isCanvasValue() is added in order to generate toCSSCanvasValue.

No new tests, no behavior change.

  • css/CSSCanvasValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isCanvasValue):

10:38 PM Changeset in webkit [156632] by Darin Adler
  • 5 edits in trunk/Source/ThirdParty

Take some Xcode advice about turning on additional warnings in ANGLE and gtest
https://bugs.webkit.org/show_bug.cgi?id=122087

Reviewed by Mark Rowe.

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
  • src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile

an unused function and get a warning.

10:30 PM Changeset in webkit [156631] by mrowe@apple.com
  • 9 edits in trunk

Fix the Lion build.

Ensure that C++ and Objective-C++ files build with the right compiler flags.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
  • WebKitTestRunner/Configurations/BaseTarget.xcconfig:
10:28 PM Changeset in webkit [156630] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSLineBoxContainValue
https://bugs.webkit.org/show_bug.cgi?id=122054

Reviewed by Darin Adler.

As a step to use toCSSFooValue, toCSSLineBoxContainValue is generated by using
CSS_VALUE_TYPE_CASTS. To use it, isCSSLineBoxContainValue() is changed to
isLineBoxContatinValue(). Unnecessary local variable is removed by this patch.

No new tests, no behavior changes.

  • css/CSSLineBoxContainValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isLineBoxContainValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

10:26 PM Changeset in webkit [156629] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebCore

Generate toCSSCrossfadeValue() instead of using manual function
https://bugs.webkit.org/show_bug.cgi?id=122057

Reviewed by Antti Koivisto.

Generated toCSSFooValue() supports more plenty functions rather than
to use manual cast function.

No new tests, no behavior changes.

  • css/CSSCrossfadeValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

10:22 PM Changeset in webkit [156628] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue
https://bugs.webkit.org/show_bug.cgi?id=122056

Reviewed by Antti Koivisto.

Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue, and use it.
This type cast function will help to detect bad-casts.

No new tests, no behavior changes.

  • css/CSSFilterImageValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSInitialValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::generatedOrPendingFromValue):

9:57 PM Changeset in webkit [156627] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix crashes caused by my recent attempt at a Windows build fix.

  • bindings/js/WebCoreTypedArrayController.cpp: (WebCore::WebCoreTypedArrayController::toJS): Added back the prefix for the call to WebCore::toJS, otherwise this function just calls itself infinitely recursively.
9:56 PM Changeset in webkit [156626] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

9:36 PM Changeset in webkit [156625] by weinig@apple.com
  • 14 edits in trunk/Source/WebCore

Cleanup PageThrottler and PageConsole a bit
https://bugs.webkit.org/show_bug.cgi?id=122085

Reviewed by Anders Carlsson.

  • html/HTMLMediaElement.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::completed):

  • loader/FrameLoader.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):

  • loader/SubresourceLoader.h:

Store the PageActivityAssertionToken as a std::unique_ptr.

  • page/Page.cpp:

(WebCore::Page::Page):
Use createOwned and pass this by reference for the PageThrottler and PageConsole.
(WebCore::Page::~Page):
Remove unnecessary clearing of an OwnPtr that is about to be destroyed.

  • page/Page.h:

Make m_pageThrottler const and return it as a reference.

  • page/PageActivityAssertionToken.cpp:

(WebCore::PageActivityAssertionToken::PageActivityAssertionToken):
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken):

  • page/PageActivityAssertionToken.h:

Take the PageThrottler by reference in the constructor. It is never null.

  • page/PageConsole.cpp:

(WebCore::PageConsole::PageConsole):
(WebCore::PageConsole::~PageConsole):
(WebCore::PageConsole::addMessage):

  • page/PageConsole.h:

Pass and store the Page as a reference and remove an extraneous null check. Remove
the create function.

  • page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):
(WebCore::PageThrottler::~PageThrottler):
(WebCore::PageThrottler::createActivityToken):
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
(WebCore::PageThrottler::addActivityToken):
(WebCore::PageThrottler::removeActivityToken):

  • page/PageThrottler.h:

Pass and store the Page as a reference. Move the creation of PageActivityAssertionToken here
to aid encapsulation.

8:45 PM Changeset in webkit [156624] by akling@apple.com
  • 52 edits in trunk/Source

Pass VM instead of JSGlobalObject to function constructors.
<https://webkit.org/b/122082>

Reviewed by Darin Adler.

Functions don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.

This patch is mostly mechanical, I just changed the signature of
InternalFunction and worked my way from there until it built.

JSC release binary size -= 4840 bytes.

7:54 PM Changeset in webkit [156623] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix Windows build.

  • bindings/js/WebCoreTypedArrayController.cpp: Windows has a symbol named Handle, so we need to call JSC::Handle out by name. To fix that, I removed "using namespace JSC" entirely. And just for fun, sort of "rewrote" this file. (WebCore::WebCoreTypedArrayController::WebCoreTypedArrayController): Removed unneeded explicit initialization of m_owner. (WebCore::WebCoreTypedArrayController::~WebCoreTypedArrayController): Fixed formatting. (WebCore::WebCoreTypedArrayController::toJS): Added lots of explicit JSC and got rid of local. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots): Cut down on locals, used auto& for type, and called it "wrapper" since that's what JSArrayBuffer is. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize): More of the same.
7:40 PM Changeset in webkit [156622] by Darin Adler
  • 138 edits in trunk/Source

Use RenderElement instead of RenderObject in many places
https://bugs.webkit.org/show_bug.cgi?id=122078

Reviewed by Andreas Kling.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj: Let Xcode do its thing to this file.

Source/WebCore:

  • WebCore.exp.in: Updated for name changes.
  • dom/ContainerNode.h: Moved renderer() here from Element.
  • dom/Element.h: Moved renderer() from here to ContainerNode.
  • render/RenderElement.h: Moved renderer() from Element to ContainerNode.
  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore::AccessibilityImageMapLink::detachFromParent):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):

  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • bindings/objc/DOM.mm:

(-[DOMElement image]):
(-[DOMElement _font]):
(-[DOMElement _imageTIFFRepresentation]):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):
(WebCore::CSSCanvasValue::canvasDestroyed):
(WebCore::CSSCanvasValue::fixedSize):
(WebCore::CSSCanvasValue::image):

  • css/CSSCanvasValue.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty):

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSCrossfadeValue.h:
  • css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::fixedSize):
(WebCore::CSSFilterImageValue::knownToBeOpaque):
(WebCore::CSSFilterImageValue::image):
(WebCore::CSSFilterImageValue::filterImageChanged):

  • css/CSSFilterImageValue.h:
  • css/CSSFontSelector.cpp:
  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::knownToBeOpaque):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::fixedSize):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):

  • css/CSSImageGeneratorValue.h:

(WebCore::CSSImageGeneratorValue::clients):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::knownToBeOpaque):

  • css/CSSImageValue.h:
  • css/DeprecatedStyleBuilder.cpp:
  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::removeMarkersFromList):
(WebCore::DocumentMarkerController::repaintMarkers):

  • dom/Element.cpp:

(WebCore::localZoomForRenderer):
(WebCore::adjustForLocalZoom):
(WebCore::Element::offsetParent):
(WebCore::Element::updateExistingPseudoElement):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::create):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::ensureRareData):

  • editing/DeleteButtonController.cpp:

(WebCore::isDeletableElement):

  • editing/Editor.cpp:

(WebCore::Editor::hasBidiSelection):
(WebCore::Editor::baseWritingDirectionForSelectionStart):

  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance):

  • editing/htmlediting.cpp:

(WebCore::directionOfEnclosingBlock):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::fontForSelection):
(WebCore::getImage):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):
(WebCore::getImage):

  • editing/markup.cpp:
  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::setFocus):

  • html/HTMLAreaElement.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

  • html/HTMLFormControlElement.cpp:

(WebCore::updateFromElementCallback):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::rendererIsNeeded):

  • html/HTMLFrameOwnerElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::x):
(WebCore::HTMLImageElement::y):
(WebCore::HTMLImageElement::willRespondToMouseClickEvents):

  • html/HTMLMapElement.cpp:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::defaultEventHandler):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::renderMeter):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::didRecalcStyle):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
(WebCore::HTMLPlugInElement::defaultEventHandler):
(WebCore::HTMLPlugInElement::isKeyboardFocusable):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::defaultEventHandler):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::renderProgress):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::selectOption):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::cellAbove):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::setSelectionRange):

  • html/InputType.h:
  • html/parser/HTMLResourcePreloader.cpp:
  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlElement::setDisplayType):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterInnerElement::rendererIsNeeded):

  • inspector/InspectorOverlay.cpp:
  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorTimelineAgent.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::renderImageResource):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::currentFrameKnownToBeOpaque):

  • loader/cache/CachedImage.h:
  • mathml/MathMLElement.cpp:
  • page/ContextMenuController.cpp:
  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::startPanScrolling):
(WebCore::EventHandler::autoscrollRenderer):
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::selectCursor):
(WebCore::layerForNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::clearGestureScrollNodes):

  • page/EventHandler.h:
  • page/FocusController.cpp:
  • page/Frame.cpp:

(WebCore::Frame::ownerRenderer):
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::nodeImage):

  • page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::applyPaginationToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::isEnclosedInCompositingLayer):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintSlowRepaintObjects):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):

  • page/FrameView.h:
  • page/PageSerializer.cpp:

(WebCore::PageSerializer::addImageToResources):

  • page/PageSerializer.h:
  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::AnimationBase):
(WebCore::AnimationBase::updateStateMachine):

  • page/animation/AnimationBase.h:

(WebCore::AnimationBase::renderer):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::clear):
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::getAnimatedStyleForRenderer):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::pauseAnimationAtTime):
(WebCore::AnimationController::pauseTransitionAtTime):
(WebCore::AnimationController::isRunningAnimationOnRenderer):
(WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):

  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::crossfadeBlend):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):

  • page/animation/CompositeAnimation.h:
  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):

  • page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::create):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):

  • page/animation/KeyframeAnimation.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):

  • page/mac/FrameSnapshottingMac.mm:

(WebCore::snapshotDragImage):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::paint):

  • rendering/CounterNode.cpp:

(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):

  • rendering/CounterNode.h:

(WebCore::CounterNode::owner):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
(WebCore::FilterEffectRenderer::build):

  • rendering/FilterEffectRenderer.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::title):
(WebCore::HitTestResult::innerTextIfTruncated):
(WebCore::HitTestResult::image):

  • rendering/LayoutRepainter.cpp:

(WebCore::LayoutRepainter::LayoutRepainter):

  • rendering/LayoutRepainter.h:
  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):

  • rendering/LineWidth.h:
  • rendering/LogicalSelectionOffsetCaches.h:

(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject):
(WebCore::isNonRenderBlockInline):
(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):

  • rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):
(WebCore::PaintInfo::updateSubtreePaintRootForChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderCounter.cpp:

(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::rendererForRootBackground):

  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::initialize):

  • rendering/RenderImageResource.h:
  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::initialize):

  • rendering/RenderImageResourceStyleImage.h:

(WebCore::RenderImageResourceStyleImage::create):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::canBeComposited):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):
(WebCore::RenderLayerCompositor::requiresCompositingForBlending):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):
(WebCore::mustRepaintFillLayers):
(WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::rendererOwningScrollbar):

  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

  • rendering/RenderTableCell.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):

  • rendering/style/FillLayer.h:
  • rendering/style/KeyframeList.h:

(WebCore::KeyframeList::KeyframeList):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::imageSize):
(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):
(WebCore::StyleCachedImage::image):
(WebCore::StyleCachedImage::knownToBeOpaque):

  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::imageSize):
(WebCore::StyleCachedImageSet::computeIntrinsicDimensions):
(WebCore::StyleCachedImageSet::setContainerSizeForRenderer):
(WebCore::StyleCachedImageSet::addClient):
(WebCore::StyleCachedImageSet::removeClient):
(WebCore::StyleCachedImageSet::image):
(WebCore::StyleCachedImageSet::knownToBeOpaque):

  • rendering/style/StyleCachedImageSet.h:
  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):
(WebCore::StyleGeneratedImage::knownToBeOpaque):

  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:

(WebCore::StyleImage::imagesEquivalent):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
(WebCore::StylePendingImage::computeIntrinsicDimensions):

  • testing/Internals.cpp:

(WebCore::Internals::boundingBox):
(WebCore::Internals::isSelectPopupVisible):
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
Use RenderElement instead of RenderObject where it was easy to do so.
For local variables holding the return value of renderer() functions,
use auto instead, so the most-specific possible type will be used,
without having to figure out what that is in each case. Also use some
more OVERRIDE and FINAL and use nullptr instead of 0. And replace some
cryptic short local variable names with words.

5:57 PM Changeset in webkit [156621] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Pass VM instead of JSGlobalObject to ArrayPrototype constructor.
<https://webkit.org/b/122079>

Reviewed by Geoffrey Garen.

ArrayPrototype doesn't need the global object for anything during
construction, so reduce the amount of loads by just passing the VM.

3:20 PM Changeset in webkit [156620] by akling@apple.com
  • 31 edits in trunk/Source

Pass VM instead of ExecState to simple builtin constructors.
<https://webkit.org/b/122077>

Reviewed by Sam Weinig.

None of the simple builtins need the ExecState for anything during
their construction, so reduce the amount of loads by just passing
the VM around instead.

3:16 PM Changeset in webkit [156619] by pdr@google.com
  • 8 edits
    3 adds in trunk

Repaint borders and outlines on pseudo content changes
https://bugs.webkit.org/show_bug.cgi?id=122070

Reviewed by Andreas Kling.

Source/WebCore:

This patch fixes a regression from wkrev.com/150259 where pseudo content with
borders or outlines would fail to repaint if the color property changed.
The root bug is that border-color and outline-color properties use 'color' if
no explicit border-color or outline-color are given, and changing color should
repaint borders and outlines even if the text content is empty.

Relevant spec sections:
border: http://www.w3.org/TR/CSS1/#border-color
outline: http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color

This patch also renames StyleDifferenceRepaintIfText to
StyleDifferenceRepaintIfTextOrBorderOrOutline and updates the relevant functions.

Test: fast/repaint/hover-pseudo-borders.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::hasImmediateNonWhitespaceTextChildOrBorderOrOutline):

This function has been renamed to reflect that it returns true for borders
or outlines as well.

(WebCore::RenderElement::shouldRepaintForStyleDifference):

  • rendering/RenderElement.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientStyleChanged):

These have also been renamed to reflect the new borders and outlines check.

LayoutTests:

  • fast/repaint/hover-pseudo-borders.html: Added.
  • platform/mac/fast/repaint/hover-pseudo-borders-expected.png: Added.
  • platform/mac/fast/repaint/hover-pseudo-borders-expected.txt: Added.
1:50 PM Changeset in webkit [156618] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Tighten typing in inline rendering
https://bugs.webkit.org/show_bug.cgi?id=122076

Reviewed by Andreas Kling.

More RenderElement, const, &, etc.

  • dom/Position.cpp:

(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::isLastChildForRenderer):
(WebCore::isAncestorAndWithinBlock):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::root):
(WebCore::isEmptyInline):
(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineLogicalWidth):
(WebCore::alwaysRequiresLineBox):
(WebCore::requiresLineBox):
(WebCore::canBreakAtThisPosition):
(WebCore::LineBreaker::nextSegmentBreak):

  • rendering/shapes/ShapeInsideInfo.h:

(WebCore::LineSegmentIterator::LineSegmentIterator):

12:31 PM Changeset in webkit [156617] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Refactor code for finding x86 scratch register.
https://bugs.webkit.org/show_bug.cgi?id=122072

Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::getUnusedRegister):
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::store16):

11:04 AM Changeset in webkit [156616] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening. Skip the IndexedDB tests for now as the feature is going
through substantial changes that don't ensure constant proper functionality.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
Note: See TracTimeline for information about the timeline view.