Timeline
Oct 3, 2013:
- 11:05 PM Changeset in webkit [156880] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself to some watchlists.
- Scripts/webkitpy/common/config/watchlist:
- 9:42 PM Changeset in webkit [156879] by
-
- 2 edits in trunk/Source/WebCore
Assert that we don't try to index past the end of the m_coreTextIndices array
https://bugs.webkit.org/show_bug.cgi?id=122308
Reviewed by Dan Bernstein.
Because an assertion failure is better than a random crash.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::indexAt):
- 9:38 PM Changeset in webkit [156878] by
-
- 4 edits2 deletes in trunk/Source/WebKit
Remove WebNSNotificationCenterExtras
https://bugs.webkit.org/show_bug.cgi?id=122316
Reviewed by Dan Bernstein.
Source/WebKit:
Update Xcode project.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Use dispatch_async to ensure that notifications are posted on the main thread.
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase _sendNotificationForURL:]):
(-[WebIconDatabase _sendDidRemoveAllIconsNotification]):
- Misc/WebNSNotificationCenterExtras.h: Removed.
- Misc/WebNSNotificationCenterExtras.m: Removed.
- 9:11 PM Changeset in webkit [156877] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r155787): WebKitTestRunner rebuilds from scratch when doing an incremental build
Reviewed by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination. This avoids updating the modification date of the file when it has not changed.
- 9:04 PM Changeset in webkit [156876] by
-
- 69 edits in trunk/Source/WebCore
Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256
Reviewed by Andreas Kling.
These bits never apply to RenderText nodes:
normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout
The code for setting them can be moved to RenderElement.
Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.
- 8:42 PM Changeset in webkit [156875] by
-
- 2 edits in tags/Safari-538.1.2/Source/ThirdParty/ANGLE
Merged r156870. <rdar://problem/15116673>
- 8:21 PM Changeset in webkit [156874] by
-
- 5 edits in tags/Safari-538.1.2/Source
Versioning.
- 8:19 PM Changeset in webkit [156873] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build
The change in r156811 resulted in several public headers in the JavaScriptCore framework having their modification
date touched on every build, even if their contents had not changed. This resulted in a large portion of WebCore
needing to rebuilt after an incremental build of JavaScriptCore.
Reviewed by Dan Bernstein.
- JavaScriptCore.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination.
- 8:19 PM Changeset in webkit [156872] by
-
- 1 copy in tags/Safari-538.1.2
New Tag.
- 8:08 PM Changeset in webkit [156871] by
-
- 23 edits in trunk/Source
Remove shouldRubberBandInDirection from the WKBundlePageUIClient
https://bugs.webkit.org/show_bug.cgi?id=122309
Reviewed by Andreas Kling.
../WebCore:
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/FrameView.cpp:
- page/FrameView.h:
- platform/ScrollableArea.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):
../WebKit/efl:
- WebCoreSupport/ChromeClientEfl.h:
../WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h:
../WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
../WebKit/win:
- WebCoreSupport/WebChromeClient.h:
../WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.h:
../WebKit2:
WKBundlePageUIClient's shouldRubberBandInDirection has never worked with
threaded scrolling, so remove it.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 5:43 PM Changeset in webkit [156870] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
<rdar://problem/15116673> [mac] Build failure when the source directory is not named ANGLE
https://bugs.webkit.org/show_bug.cgi?id=122307
Reviewed by Mark Rowe.
- ANGLE.xcodeproj/project.pbxproj: Ensure that the symlink to SRCROOT in
DerivedSources/ANGLE is named ANGLE.
- 4:38 PM Changeset in webkit [156869] by
-
- 11 edits in trunk
Fix the HTMLSelectElement.prototype.remove() method
https://bugs.webkit.org/show_bug.cgi?id=121586
Reviewed by Darin Adler.
Source/WebCore:
Fix the HTMLSelectElement.prototype.remove() method so that it behaves like
Element.remove() if no argument is passed (from ChildNode). This behavior
is consistent with Firefox and Blink.
See https://www.w3.org/Bugs/Public/show_bug.cgi?id=20720 for more
information.
Tests: js/dom/select-options-remove.html
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::remove):
Stop calling JSHTMLSelectElement::remove() blindly as it is dangerous, especially
now that calling it without argument now detaches the element. Instead, have the
bindings call the corresponding methods on the HTMLOptionsCollection implementation
object, as it should.
- bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove):
Call Element::remove() if no argument is given.
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::remove):
- html/HTMLOptionsCollection.h:
- html/HTMLSelectElement.cpp:
- html/HTMLSelectElement.h:
Rename remove(int) to removeByIndex(int) to avoid conflict with
Node::remove(ExceptionCode&).
LayoutTests:
Add test to make sure calling HTMLSelectElement.prototype.remove() detaches the
select element from its parent, as Element::remove() would.
- js/dom/select-options-remove-expected.txt:
- js/resources/select-options-remove.js:
- 4:31 PM Changeset in webkit [156868] by
-
- 1 edit1 delete in trunk/LayoutTests
Re-remove Qt TestExpectations re-added in r156841 after r156866.
- platform/qt: Removed.
- platform/qt/TestExpectations: Removed.
- 4:29 PM Changeset in webkit [156867] by
-
- 8 edits2 adds in trunk
Regression: AX: <table><caption> no longer exposed as AXTitle.
https://bugs.webkit.org/show_bug.cgi?id=121977
Patch by Samuel White <Samuel White> on 2013-10-03
Reviewed by Darin Adler.
Source/WebCore:
Some cleanup of accessibilityText. Notably, subclasses were unnecessarily redeclaring this method as both private and
protected. Added OVERRIDE keyword to these subclasses as needed. Moved titleElementText to virtual so we can do subclass
overrides in cases like this bug. That is, AccessibilityTable can leverage the existing machinery for alternativeText,
visibleText, and helpText, but we do some custom work ONLY in titleElementText.
Test: accessibility/table-title.html
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityMediaControls.h:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::titleElementText):
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::titleElementText):
- accessibility/AccessibilityTable.h:
LayoutTests:
Added test to verify that table elements correctly derive their AXTitle from their associated caption element.
- accessibility/table-title-expected.txt: Added.
- accessibility/table-title.html: Added.
- 4:24 PM Changeset in webkit [156866] by
-
- 5 edits in trunk/Tools
Remove Qt builders from the flakiness dashboard.
- TestResultServer/static-dashboards/builders.jsonp:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/loader_unittests.js:
- 4:18 PM Changeset in webkit [156865] by
-
- 1 edit3 adds in trunk/LayoutTests
Add a testcase for a bug that I had during the development. This code uses the asm.js style.
https://bugs.webkit.org/show_bug.cgi?id=122286
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Filip Pizlo.
- js/regress/asmjs_bool_bug-expected.txt: Added.
- js/regress/asmjs_bool_bug.html: Added.
- js/regress/script-tests/asmjs_bool_bug.js: Added.
(strlen):
- 4:10 PM Changeset in webkit [156864] by
-
- 4 edits in trunk/Tools
[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299
Reviewed by Beth Dakin.
- TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
Disable threaded scrolling.
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
- TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
- 4:03 PM Changeset in webkit [156863] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Unreviewed gardening.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Clean up the
paths for various files added outside of Visual Studio. They are all
displayed in the root of the project, rather than the proper sub-folder.
- 3:54 PM Changeset in webkit [156862] by
-
- 6 edits in trunk/Source
../JavaScriptCore: [Win] Update solutions and projects to support 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=122225
Reviewed by Anders Carlsson.
Revise ordering of CPU(X86) and CPU(X86_64) tests, because MSVC always defines
both when targeting a 64-bit build.
- JavaScriptCore.vcxproj/JavaScriptCore.submit.sln: Add an x64 target
for 64-bit builds.
../WTF: [Win] Update solutions and projects to support 64-bit build.
https://bugs.webkit.org/show_bug.cgi?id=122225
Reviewed by Anders Carlsson.
- WTF.vcxproj/WTF.submit.sln: Add x64 architecture targets.
- WTF.vcxproj/WTF.vcxproj: Correct path to config.h file.
- WTF.vcxproj/WTF.vcxproj.filters: Correct path to config.h file.
- 3:52 PM Changeset in webkit [156861] by
-
- 10 edits4 copies in trunk/Source/WebKit2
Create CoordinatedDrawingArea / CoordinatedDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=122207
Patch by Sergio Correia <Sergio Correia> on 2013-10-03
Reviewed by Anders Carlsson.
Since Apple are moving away from DrawingAreaImpl, Coordinated Graphics
should have its own drawing area.
- CMakeLists.txt: Use CoordinatedDrawingArea and
CoordinatedDrawingAreaProxy instead of the DrawingAreaImpl /
DrawingAreaProxyImpl.
- Shared/DrawingAreaInfo.h: Add DrawingAreaTypeCoordinated.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
Added, copied from DrawingAreaProxyImpl.cpp.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Added,
copied from DrawingAreaProxyImpl.h.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy): Use CoordinatedDrawingAreaProxy.
- UIProcess/DrawingAreaProxyImpl.cpp: Remove Coordinated Graphics
bits.
- UIProcess/DrawingAreaProxyImpl.h: Ditto.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
Added, copied from DrawingAreaImpl.cpp.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
Added, copied from DrawingAreaImpl.h.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush): Use
CoordinatedDrawingArea.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Handle the DrawingAreaTypeCoordinated
in the DrawingArea creation code.
- WebProcess/WebPage/DrawingAreaImpl.cpp: Remove Coordinated Graphics
bits.
- WebProcess/WebPage/DrawingAreaImpl.h: Ditto.
- 3:15 PM Changeset in webkit [156860] by
-
- 30 edits in trunk/Source
Ignore deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=122302
Reviewed by Mark Rowe.
Source/WebCore:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _rectOnScreen]):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
- page/mac/FrameSnapshottingMac.mm:
(WebCore::imageFromRect):
- platform/graphics/mac/IconMac.mm:
(WebCore::Icon::Icon):
- platform/mac/DragImageMac.mm:
(WebCore::scaleDragImage):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::globalPoint):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsToScreen):
(WebCore::ScrollView::platformScreenToContents):
Source/WebKit/mac:
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase _scaleIcon:toSize:]):
(webGetNSImage):
- Misc/WebNSImageExtras.m:
(-[NSImage _web_scaleToMaxSize:]):
(-[NSImage _web_dissolveToFraction:]):
- Misc/WebNSViewExtras.m:
(-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]):
(-[NSView _web_convertRect:toView:]):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::mouseEvent):
- Plugins/Hosted/WebTextInputWindowController.m:
(-[WebTextInputPanel _interpretKeyEvent:string:]):
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
- WebInspector/WebNodeHighlight.mm:
(-[WebNodeHighlight _computeHighlightWindowFrame]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
- WebView/WebHTMLView.mm:
(+[WebHTMLView _postFlagsChangedEvent:]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _autoscroll]):
(-[WebHTMLView mouseDown:]):
(-[WebHTMLView mouseDragged:]):
(-[WebHTMLView mouseUp:]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _executeSavedKeypressCommands]):
(-[WebHTMLView attachRootLayer:]):
(-[WebHTMLView textStorage]):
(-[WebHTMLView _updateSelectionForInputManager]):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _buildUI]):
(-[WebTextCompletionController _placePopupWindow:]):
Source/WebKit2:
- Shared/mac/WebEventFactory.mm:
(WebKit::globalPoint):
- UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::windowToScreen):
- UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):
- UIProcess/API/mac/WKView.mm:
(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:actualRange:]):
(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):
(-[WKView _setDragImage:at:linkDrag:]):
(-[WKView performDictionaryLookupAtCurrentMouseLocation]):
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- 2:46 PM Changeset in webkit [156859] by
-
- 2 edits in trunk/Tools
Use numeric strings in the OS version dictionary
https://bugs.webkit.org/show_bug.cgi?id=122300
Reviewed by Mark Rowe.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):
- 2:14 PM Changeset in webkit [156858] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eliminate unused JITStub function declarations
https://bugs.webkit.org/show_bug.cgi?id=122288
Reviewed by Geoffrey Garen.
Removed unused JITStub declarations.
- jit/JITStubs.h:
- 2:07 PM Changeset in webkit [156857] by
-
- 3 edits2 adds in trunk/LayoutTests
[CSS Regions] Layout Test for selecting text in 2 regions
https://bugs.webkit.org/show_bug.cgi?id=121841
Reviewed by Alexandru Chiculita.
Add new reftest for selecting text in 2 regions. It compares the
behavior (highlighted text and selected content) in regions and absolute
positions.
- fast/regions/resources/helper.js: Add new function to set selected
content in an element onmouseup.
(onMouseUpLogSelection.document.onmouseup):
(onMouseUpLogSelection):
- fast/regions/resources/region-style.css: Define some styles that could
be reused in other tests.
- fast/regions/selection/selecting-text-in-2-regions-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions.html: Added.
- 1:49 PM Changeset in webkit [156856] by
-
- 5 edits in tags/Safari-538.1.1/Source
Versioning.
- 1:44 PM Changeset in webkit [156855] by
-
- 1 copy in tags/Safari-538.1.1
New Tag.
- 1:44 PM Changeset in webkit [156854] by
-
- 2 edits in trunk/Tools
Fix LeaksViewer to load leaks results from MountainLion, not Lion.
Rubber-stamped by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._displayURLPrompt):
- 1:36 PM Changeset in webkit [156853] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: fast/history/history-back-while-pdf-in-pagecache.html
https://bugs.webkit.org/show_bug.cgi?id=121628
- platform/mac/TestExpectations: Marking as such.
- 1:04 PM Changeset in webkit [156852] by
-
- 3 edits4 adds in trunk
[CSS Shapes] Support the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122254
Reviewed by Andreas Kling.
Source/WebCore:
Replace the hardwired 0 Shape::createShape() threshold parameter with the style's
shapeImageThreshold() value (which has been clamped to [0,1]).
Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape):
LayoutTests:
Verify that a shape-outside image whose pixels' alpha channels are all above shape-image-threshold causes
layout to skirt the shape, and similarly that an image whose pixels' alpha channels are all below the threshold
has no effect on the layout.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html: Added.
- 1:00 PM Changeset in webkit [156851] by
-
- 7 edits1 copy1 delete in trunk/LayoutTests
[CSS Shapes] Revise the CSS property parsing tests
https://bugs.webkit.org/show_bug.cgi?id=122251
Reviewed by Andreas Kling.
Flattened the shapes CSS property parsing tests by inserting the code from
the fast/shapes/parsing/script-tests subdirectory into the test HTML source
files. The subdirectory is now empty and the tests are easier to read.
- fast/shapes/parsing/parsing-shape-image-threshold.html: Inserted parsing-shape-image-threshold.js instead of referring to it with script src.
- fast/shapes/parsing/parsing-shape-inside.html: Likewise
- fast/shapes/parsing/parsing-shape-lengths.html: Likewise
- fast/shapes/parsing/parsing-shape-margin.html: Likewise
- fast/shapes/parsing/parsing-shape-outside.html: Likewise
- fast/shapes/parsing/parsing-shape-padding.html: Likewise
- fast/shapes/parsing/parsing-test-utils.js: Renamed from LayoutTests/fast/shapes/parsing/script-tests/parsing-test-utils.js.
(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
(property):
- fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-inside.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-lengths.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-margin.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-outside.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-padding.js: Removed.
- 12:53 PM Changeset in webkit [156850] by
-
- 5 edits in trunk/Source/WebCore
[CSS Regions] Follow-up code style change after bug #121828 All regions have layers
https://bugs.webkit.org/show_bug.cgi?id=122265
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-03
Reviewed by Darin Adler.
Comments moved to the cpp file, as requested in the review of bug #121828 All regions have layers.
No new tests, no behavior change.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::requiresLayer):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::requiresLayer):
- rendering/RenderRegion.h:
- 12:52 PM Changeset in webkit [156849] by
-
- 2 edits in trunk/LayoutTests
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803
I'm not quite sure what's going on, but [ Pass Failure ] expectations didn't cut it.
Trying [ Pass ImageOnlyFailure ], as the failures are always image only anyway.
- platform/mac/TestExpectations:
- 12:48 PM Changeset in webkit [156848] by
-
- 3 edits in trunk/Source/WebCore
[cairo] Initialize the m_compositorTexture in GraphicsContext3DCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=122285
Patch by Alejandro G. Castro <alex@igalia.com> on 2013-10-03
Reviewed by Noam Rosenthal.
Initialize to the default texture to avoid the random texture name
and generate the texture name.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize
m_compositorTexture.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Delete the
generated textures names.
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs): Generate the texture
names for m_compositorTexture and m_texture.
- 11:38 AM Changeset in webkit [156847] by
-
- 41 edits in trunk/Source/WebKit2
Remove the last remnants of Qt from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122290
Reviewed by Andreas Kling.
- Platform/PlatformProcessIdentifier.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- Shared/Downloads/Download.cpp:
(WebKit::Download::Download):
- Shared/Downloads/Download.h:
- Shared/Downloads/DownloadManager.cpp:
- Shared/Downloads/DownloadManager.h:
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- Shared/LayerTreeContext.h:
- Shared/NativeWebKeyboardEvent.h:
- Shared/NativeWebMouseEvent.h:
- Shared/NativeWebWheelEvent.h:
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h:
- Shared/ShareableBitmap.h:
- Shared/WebPreferencesStore.h:
- UIProcess/Downloads/DownloadProxy.cpp:
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/PageClient.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::showPopupMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPopupMenuProxy.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::willSetInputMethodState):
(WebKit::WebEditorClient::supportsGlobalSelection):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldFallBack):
- WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::didChangeSelectedIndex):
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::editorState):
(WebKit::WebPage::performDragControllerAction):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- config.h:
- 11:24 AM Changeset in webkit [156846] by
-
- 7 edits10 adds in trunk
[CSS Shapes] Support block content with inline content around floats in shape-inside
https://bugs.webkit.org/show_bug.cgi?id=121616
Reviewed by David Hyatt.
In r156022 and r156364, I added support for floats inside shape-inside with inline content. This change extends
the existing implementation to support block content with inline content (paragraphs). I added an extra text for
positioning a float inside shape-inside without text content around it.
Source/WebCore:
Tests: fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html
- rendering/FloatingObjects.h:
(WebCore::FloatingObject::logicalSize): Add new function to return the FloatingObject logical size.
- rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats): When the lineBreaker code pushes down the content below the floating object,
we need to update the segments if we are in a shape-inside.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Do the positioning based on the float actual size, and use the
recent shapeInsideInfo. (Calling layoutShapeInsideInfo which deals with the layoutStates also instead of shapeInsideInfo.)
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): If we don't have inline content we still need to positionize
our float content in a shape-inside.
(WebCore::updateSegmentsForShapes): Use the right coordinates for block content with inline content.
LayoutTests:
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html: Added.
- 11:06 AM Changeset in webkit [156845] by
-
- 1 edit247 deletes in trunk/Source/WebKit2
Remove Qt files from WebKit2.
Rubber-stomped by Andreas Kling.
- DerivedSources.pri: Removed.
- PluginProcess.pro: Removed.
- PluginProcess/qt/PluginControllerProxyQt.cpp: Removed.
- PluginProcess/qt/PluginProcessMainQt.cpp: Removed.
- PluginProcess/qt/PluginProcessQt.cpp: Removed.
- SandboxProcess.pro: Removed.
- Shared/API/c/qt/WKImageQt.cpp: Removed.
- Shared/API/c/qt/WKImageQt.h: Removed.
- Shared/Downloads/qt/DownloadQt.cpp: Removed.
- Shared/Downloads/qt/QtFileDownloader.cpp: Removed.
- Shared/Downloads/qt/QtFileDownloader.h: Removed.
- Shared/qt/ArgumentCodersQt.cpp: Removed.
- Shared/qt/ArgumentCodersQt.h: Removed.
- Shared/qt/LayerTreeContextQt.cpp: Removed.
- Shared/qt/NativeWebKeyboardEventQt.cpp: Removed.
- Shared/qt/NativeWebMouseEventQt.cpp: Removed.
- Shared/qt/NativeWebTouchEventQt.cpp: Removed.
- Shared/qt/NativeWebWheelEventQt.cpp: Removed.
- Shared/qt/PlatformCertificateInfo.h: Removed.
- Shared/qt/ProcessExecutablePathQt.cpp: Removed.
- Shared/qt/QtNetworkReplyData.cpp: Removed.
- Shared/qt/QtNetworkReplyData.h: Removed.
- Shared/qt/QtNetworkRequestData.cpp: Removed.
- Shared/qt/QtNetworkRequestData.h: Removed.
- Shared/qt/ShareableBitmapQt.cpp: Removed.
- Shared/qt/WebCoreArgumentCodersQt.cpp: Removed.
- Shared/qt/WebEventFactoryQt.cpp: Removed.
- Shared/qt/WebEventFactoryQt.h: Removed.
- Shared/qt/WebURLRequestQt.cpp: Removed.
- Shared/qt/WebURLResponseQt.cpp: Removed.
- Target.pri: Removed.
- UIProcess/API/C/qt/WKIconDatabaseQt.cpp: Removed.
- UIProcess/API/C/qt/WKIconDatabaseQt.h: Removed.
- UIProcess/API/C/qt/WKNativeEvent.h: Removed.
- UIProcess/API/cpp/qt/WKStringQt.cpp: Removed.
- UIProcess/API/cpp/qt/WKStringQt.h: Removed.
- UIProcess/API/cpp/qt/WKURLQt.cpp: Removed.
- UIProcess/API/cpp/qt/WKURLQt.h: Removed.
- UIProcess/API/qt/qquicknetworkreply.cpp: Removed.
- UIProcess/API/qt/qquicknetworkreply_p.h: Removed.
- UIProcess/API/qt/qquicknetworkrequest.cpp: Removed.
- UIProcess/API/qt/qquicknetworkrequest_p.h: Removed.
- UIProcess/API/qt/qquickurlschemedelegate.cpp: Removed.
- UIProcess/API/qt/qquickurlschemedelegate_p.h: Removed.
- UIProcess/API/qt/qquickwebpage.cpp: Removed.
- UIProcess/API/qt/qquickwebpage_p.h: Removed.
- UIProcess/API/qt/qquickwebpage_p_p.h: Removed.
- UIProcess/API/qt/qquickwebview.cpp: Removed.
- UIProcess/API/qt/qquickwebview_p.h: Removed.
- UIProcess/API/qt/qquickwebview_p_p.h: Removed.
- UIProcess/API/qt/qtwebsecurityorigin.cpp: Removed.
- UIProcess/API/qt/qtwebsecurityorigin_p.h: Removed.
- UIProcess/API/qt/qwebdownloaditem.cpp: Removed.
- UIProcess/API/qt/qwebdownloaditem_p.h: Removed.
- UIProcess/API/qt/qwebdownloaditem_p_p.h: Removed.
- UIProcess/API/qt/qwebiconimageprovider.cpp: Removed.
- UIProcess/API/qt/qwebiconimageprovider_p.h: Removed.
- UIProcess/API/qt/qwebkittest.cpp: Removed.
- UIProcess/API/qt/qwebkittest_p.h: Removed.
- UIProcess/API/qt/qwebloadrequest.cpp: Removed.
- UIProcess/API/qt/qwebloadrequest_p.h: Removed.
- UIProcess/API/qt/qwebnavigationhistory.cpp: Removed.
- UIProcess/API/qt/qwebnavigationhistory_p.h: Removed.
- UIProcess/API/qt/qwebnavigationhistory_p_p.h: Removed.
- UIProcess/API/qt/qwebnavigationrequest.cpp: Removed.
- UIProcess/API/qt/qwebnavigationrequest_p.h: Removed.
- UIProcess/API/qt/qwebpermissionrequest.cpp: Removed.
- UIProcess/API/qt/qwebpermissionrequest_p.h: Removed.
- UIProcess/API/qt/qwebpreferences.cpp: Removed.
- UIProcess/API/qt/qwebpreferences_p.h: Removed.
- UIProcess/API/qt/qwebpreferences_p_p.h: Removed.
- UIProcess/API/qt/raw/qrawwebview.cpp: Removed.
- UIProcess/API/qt/raw/qrawwebview_p.h: Removed.
- UIProcess/API/qt/raw/qrawwebview_p_p.h: Removed.
- UIProcess/API/qt/tests/bytearraytestdata.cpp: Removed.
- UIProcess/API/qt/tests/bytearraytestdata.h: Removed.
- UIProcess/API/qt/tests/html/basic_page.html: Removed.
- UIProcess/API/qt/tests/html/basic_page2.html: Removed.
- UIProcess/API/qt/tests/html/bluesquare.html: Removed.
- UIProcess/API/qt/tests/html/direct-image-compositing.html: Removed.
- UIProcess/API/qt/tests/html/inputmethod.html: Removed.
- UIProcess/API/qt/tests/html/redsquare.html: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_noBackground1.png: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_noBackground3.png: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_paint.png: Removed.
- UIProcess/API/qt/tests/html/resources/simple_image.png: Removed.
- UIProcess/API/qt/tests/html/scroll.html: Removed.
- UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Removed.
- UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Removed.
- UIProcess/API/qt/tests/publicapi/publicapi.pro: Removed.
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView.pro: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_findText.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_messaging.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml: Removed.
- UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Removed.
- UIProcess/API/qt/tests/qmltests/common/alert.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/colorChooser.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/confirm.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/download.zip: Removed.
- UIProcess/API/qt/tests/qmltests/common/evaluatejavascript.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon.png: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon2.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/geolocation.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/javascript.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/link.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/localStorage.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/messaging.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/multifileupload.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/notification.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/prompt.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/qrctest.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/redirect.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/select.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/selectwithsize.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/small-favicon.png: Removed.
- UIProcess/API/qt/tests/qmltests/common/test1.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test2.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test3.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test4.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test5.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/titleupdate.js: Removed.
- UIProcess/API/qt/tests/qmltests/qmltests.pro: Removed.
- UIProcess/API/qt/tests/qmltests/resources.qrc: Removed.
- UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Removed.
- UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Removed.
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Removed.
- UIProcess/API/qt/tests/qrawwebview/qrawwebview.pro: Removed.
- UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp: Removed.
- UIProcess/API/qt/tests/tests.pri: Removed.
- UIProcess/API/qt/tests/testwindow.h: Removed.
- UIProcess/API/qt/tests/util.cpp: Removed.
- UIProcess/API/qt/tests/util.h: Removed.
- UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Removed.
- UIProcess/InspectorServer/qt/WebSocketServerQt.cpp: Removed.
- UIProcess/InspectorServer/qt/WebSocketServerQt.h: Removed.
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Removed.
- UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Removed.
- UIProcess/qt/BackingStoreQt.cpp: Removed.
- UIProcess/qt/PageViewportControllerClientQt.cpp: Removed.
- UIProcess/qt/PageViewportControllerClientQt.h: Removed.
- UIProcess/qt/QtDialogRunner.cpp: Removed.
- UIProcess/qt/QtDialogRunner.h: Removed.
- UIProcess/qt/QtDownloadManager.cpp: Removed.
- UIProcess/qt/QtDownloadManager.h: Removed.
- UIProcess/qt/QtGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtGestureRecognizer.h: Removed.
- UIProcess/qt/QtPageClient.cpp: Removed.
- UIProcess/qt/QtPageClient.h: Removed.
- UIProcess/qt/QtPanGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtPanGestureRecognizer.h: Removed.
- UIProcess/qt/QtPinchGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtPinchGestureRecognizer.h: Removed.
- UIProcess/qt/QtTapGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtTapGestureRecognizer.h: Removed.
- UIProcess/qt/QtWebContext.cpp: Removed.
- UIProcess/qt/QtWebContext.h: Removed.
- UIProcess/qt/QtWebError.cpp: Removed.
- UIProcess/qt/QtWebError.h: Removed.
- UIProcess/qt/QtWebIconDatabaseClient.cpp: Removed.
- UIProcess/qt/QtWebIconDatabaseClient.h: Removed.
- UIProcess/qt/QtWebPageEventHandler.cpp: Removed.
- UIProcess/qt/QtWebPageEventHandler.h: Removed.
- UIProcess/qt/QtWebPagePolicyClient.cpp: Removed.
- UIProcess/qt/QtWebPagePolicyClient.h: Removed.
- UIProcess/qt/QtWebPageSGNode.cpp: Removed.
- UIProcess/qt/QtWebPageSGNode.h: Removed.
- UIProcess/qt/QtWebPageUIClient.cpp: Removed.
- UIProcess/qt/QtWebPageUIClient.h: Removed.
- UIProcess/qt/TextCheckerQt.cpp: Removed.
- UIProcess/qt/WebColorPickerQt.cpp: Removed.
- UIProcess/qt/WebColorPickerQt.h: Removed.
- UIProcess/qt/WebContextMenuProxyQt.cpp: Removed.
- UIProcess/qt/WebContextMenuProxyQt.h: Removed.
- UIProcess/qt/WebContextQt.cpp: Removed.
- UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Removed.
- UIProcess/qt/WebGeolocationProviderQt.cpp: Removed.
- UIProcess/qt/WebGeolocationProviderQt.h: Removed.
- UIProcess/qt/WebInspectorProxyQt.cpp: Removed.
- UIProcess/qt/WebPageProxyQt.cpp: Removed.
- UIProcess/qt/WebPopupMenuProxyQt.cpp: Removed.
- UIProcess/qt/WebPopupMenuProxyQt.h: Removed.
- UIProcess/qt/WebPreferencesQt.cpp: Removed.
- UIProcess/qt/WebProcessProxyQt.cpp: Removed.
- WebKit2.pri: Removed.
- WebKit2.pro: Removed.
- WebProcess.pro: Removed.
- WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Removed.
- WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
- WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: Removed.
- WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp: Removed.
- WebProcess/WebPage/qt/WebInspectorQt.cpp: Removed.
- WebProcess/WebPage/qt/WebPageQt.cpp: Removed.
- WebProcess/qt/QtBuiltinBundle.cpp: Removed.
- WebProcess/qt/QtBuiltinBundle.h: Removed.
- WebProcess/qt/QtBuiltinBundlePage.cpp: Removed.
- WebProcess/qt/QtBuiltinBundlePage.h: Removed.
- WebProcess/qt/QtNetworkAccessManager.cpp: Removed.
- WebProcess/qt/QtNetworkAccessManager.h: Removed.
- WebProcess/qt/QtNetworkReply.cpp: Removed.
- WebProcess/qt/QtNetworkReply.h: Removed.
- WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Removed.
- WebProcess/qt/SeccompFiltersWebProcessQt.h: Removed.
- WebProcess/qt/WebProcessMainQt.cpp: Removed.
- WebProcess/qt/WebProcessQt.cpp: Removed.
- qt/MainQt.cpp: Removed.
- qt/PluginMainQt.cpp: Removed.
- 11:05 AM Changeset in webkit [156844] by
-
- 2 edits in trunk/LayoutTests
Add test expectation for one more test having color space issues after r156793.
(css3/filters/custom/custom-filter-composite-fractional-source-alpha.html)
- platform/mac-wk2/TestExpectations:
- 10:58 AM Changeset in webkit [156843] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126
- platform/mac/TestExpectations: Marked it as such.
- 10:55 AM Changeset in webkit [156842] by
-
- 10 edits in trunk/Source
Move IDBFactoryBackend creation to DatabaseStrategy.
https://bugs.webkit.org/show_bug.cgi?id=122284
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
- platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::createIDBFactoryBackend): Implement a default.
- platform/DatabaseStrategy.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Fallback to the default for now.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 10:45 AM Changeset in webkit [156841] by
-
- 1 edit2 adds in trunk/LayoutTests
Re-add Qt TestExpectations. Without it, the flakiness dashboard page loads as blank.
- platform/qt: Added.
- platform/qt/TestExpectations: Added.
- 10:29 AM Changeset in webkit [156840] by
-
- 2 edits in trunk/Tools
REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260
Reviewed by Alexey Proskuryakov.
For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.
- TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
- 10:24 AM Changeset in webkit [156839] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error with VIDEO disabled.
https://bugs.webkit.org/show_bug.cgi?id=122266
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-03
Reviewed by Brent Fulgham.
- dom/Document.cpp:
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Protect with ENABLE(VIDEO) guard.
- 10:20 AM Changeset in webkit [156838] by
-
- 6 edits6 adds in trunk
[CSS Shapes] add shape-margin support for image valued shapes
https://bugs.webkit.org/show_bug.cgi?id=121619
Reviewed by Alexandru Chiculita.
Source/WebCore:
Add support for computing the shape-margin boundary for a shape-outside whose
value is an image.
Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html
- rendering/shapes/RasterShape.cpp:
(WebCore::MarginIntervalGenerator::MarginIntervalGenerator): Internal utility that generates the margin intervals for the image interval specified with set().
(WebCore::MarginIntervalGenerator::set):
(WebCore::MarginIntervalGenerator::intervalAt):
(WebCore::findInsertionPoint): Find the insertion point index for the the specified X value, within a vector of intervals sorted by X1.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Destructively unite one interval with an existing one, or append it.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals):
(WebCore::RasterShape::marginIntervals): Return the lazily computed value, or create it with computeShapeMarginIntervals().
- rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::getIntervals):
(WebCore::RasterShape::RasterShape):
(WebCore::RasterShapeIntervals::uniteMarginInterval):
- WTF/wtf/MathExtras.h: Added clampToUnsigned() inline.
LayoutTests:
Verify that the shape-outside margin-boundary is computed correctly for image valued shapes.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html: Added.
- 10:12 AM Changeset in webkit [156837] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] [DEBUG] JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122267
Patch by Sergio Correia <Sergio Correia> on 2013-10-03
Reviewed by Michael Saboff.
Build fails due to an expression containing comparison between signed
and unsigned integer.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Add cast to avoid signed vs.
unsigned comparison warning.
- 9:02 AM Changeset in webkit [156836] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] Remove unused RenderLayerModelObject::updateLayerIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=122262
Reviewed by Alexandru Chiculita.
All regions have layers by default therefore there is no need for this function.
No tests needed, just a minor cleanup.
- rendering/RenderLayerModelObject.cpp:
- rendering/RenderLayerModelObject.h:
- 8:21 AM Changeset in webkit [156835] by
-
- 10 edits in trunk
[ATK] Expose aria-invalid as a text attribute (not object attribute)
https://bugs.webkit.org/show_bug.cgi?id=122015
Reviewed by Chris Fleizach.
Source/WebCore:
Expose the aria-invalid attribute correctly through a text
attribute (through the AtkText interface) instead of using an
object, according to what the WAI-ARIA specs says.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property
This will be tested by accesibility/aria-invalid.html, which should
keep passing after thanks to the changes done in the DRT and WKTR.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::invalidStatus): Update this method
to only return values recognized by the WAI-ARIA specification.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject): Expose aria-invalid as a
custom text attribute 'invalid', following the lead of Firefox.
Also register that custom attribute as a AtkTextAttribute.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Remove exposure of aria-invalid
as an object attribute from here.
Tools:
Adapted DRT and WKTR to check the exposure of the aria-invalid
attribute as a text attribute, instead of an object attribute.
Also, done some refactoring of the code to try to keep things
simpler and more coherent, by defining new helper functions,
simplifying code, moving static variables and functions into
unnammed namespaces and so on, without altering the logic other
than for checking the text attribute for aria-invalid.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(coreAttributeToAtkAttribute): Consider 'invalid' as the name of
the attribute exposed by the ATK wrapper, not 'aria-invalid'.
Also, never return an empty string if not falling through any of
the cases checked here, and return the original attribute instead.
(atkAttributeValueToCoreAttributeValue): New helper function to
match the attributes values returned by the ATK wrapper with the
values expected by the layout tests. Moved the mappings for the
values of AXSortDirection here as well.
(getAttributeSet): New helper function to retrieve a list of
attributes (an AtkAttributeSet) from an AtkObject using the right
API depending on whether we want the object attributes or the text
attributes (in case the object implements AtkText).
(getAttributeSetValueForId): Simplified by using getAttributeSet
and atkAttributeValueToCoreAttributeValue. Also, added a new
parameter to indicater whether we are interested in object
attributes or text attributes.
(getAtkAttributeSetAsString): Ditto.
(attributesOfElement): Updated to pass the new required parameter
to getAtkAttributeSetAsString, indicating that we want the object
attributes in this case, for backwards compatibility.
(indexRangeInTable): Moved up in the file into the unnammed namespace.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::stringAttributeValue): After moving most
of the code here to the new helper functions, simplified it by
just checking whether the required attribute is provided as an
object attribute or, if that's not the case, as a text attribute.
(AccessibilityUIElement::isAttributeSupported): Ditto.
(AccessibilityUIElement::intValue): Updated to pass the new
required parameter to getAttributeSetValueForId, indicating that
we want the object attributes in this case.
(AccessibilityUIElement::hasPopup): Ditto.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
(WTR::atkAttributeValueToCoreAttributeValue): Ditto.
(WTR::getAttributeSet): Ditto.
(WTR::getAttributeSetValueForId): Ditto.
(WTR::getAtkAttributeSetAsString): Ditto.
(WTR::attributesOfElement): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.
LayoutTests:
Updated the aria-invalid.html layout test to make sure that it
behaves as defined by the WAI-ARIA specification for values other
than 'false', 'true', 'grammar' and 'spelling'.
- accessibility/aria-invalid.html: Updated test.
- accessibility/aria-invalid-expected.txt: Updated expectations.
- 8:05 AM Changeset in webkit [156834] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 8:03 AM Changeset in webkit [156833] by
-
- 1 copy in tags/Safari-537.73.1
New Tag.
- 3:19 AM Changeset in webkit [156832] by
-
- 1 edit2 copies in trunk/LayoutTests
Add back .htaccess files erroneously removed in r156827.
- http/tests/appcache/resources/intercept: Copied from LayoutTests/http/tests/appcache/resources/intercept.
- http/tests/uri/intercept: Copied from LayoutTests/http/tests/uri/intercept.
- 2:30 AM Changeset in webkit [156831] by
-
- 2 edits in trunk/Source/WebCore
Add the NotDeletable, OperationsNotDeletable IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=122217
Reviewed by Darin Adler.
Before adjusting the JSC bindings generator to enforce configurable operations and thus conform to the
WebIDL specification in this regard, two no-op attributes are introduced that will preserve the current
behavior of operations being non-configurable.
All the relevant interfaces will be annotated with the OperationsNotDeletable attribute first. After the
generator is properly modified, this attribute will be removed from the interfaces after checking that
the operations' configurability also matches the configurability of operations in other browser engines
and that the change introduces no regressions in tests.
The NotDeletable attribute will be used as required to annotate operations that should stay
non-configurable for backwards compatibility or cross-browser compatibility.
- bindings/scripts/IDLAttributes.txt:
- 1:43 AM Changeset in webkit [156830] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG: ConstProp the pattern ValueToInt32(Bool(x)) -> Int32(x)
https://bugs.webkit.org/show_bug.cgi?id=122263
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Geoffrey Garen.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- 1:35 AM Changeset in webkit [156829] by
-
- 8 deletes in trunk/LayoutTests/platform
Remove Qt specific expected files and directories.
Reviewed by Csaba Osztrogonác.
- 12:58 AM Changeset in webkit [156828] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed fix of DrawingArea creation on non-Mac platforms after r156793.
std::make_unique<DrawingAreaImpl>() should be used, as before that revision.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
- 12:35 AM Changeset in webkit [156827] by
-
- 138 deletes in trunk
Unreviewed. Remove empty directories.
- 12:33 AM Changeset in webkit [156826] by
-
- 2 edits in trunk/Source/WebCore
Remove preDispatchEventHandler and postDispatchEventHandler,
functions that are supposed to be removed in the previous commit (r156825).
- dom/Node.h:
Oct 2, 2013:
- 11:50 PM Changeset in webkit [156825] by
-
- 16 edits in trunk/Source/WebCore
Get rid of Node::preDispatchEventHandler and Node::postDispatchEventHandler
https://bugs.webkit.org/show_bug.cgi?id=122144
Reviewed by Darin Adler.
Get rid of pre/post event dispatch callbacks preDispatchEventHandler and postDispatchEventHandler since
the former was only called by HTMLMediaElement and HTMLInputElement and the latter was only called by
HTMLInputElement.
Explicitly call HTMLMediaElement's willDispatchFullScreenChangeEvent in fullScreenChangeDelayTimerFired
of Document since this is the only place that fires the fullscreenchange event.
Also add an explicit call to willDispatchEvent and didDispatchClickEvent in EventDispatcher::dispatch.
This also allows us to stack-allocate InputElementClickHandlingState instead of having willDispatchEvent
heap-allocate it and pass it around as void*.
- WebCore.order:
- dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
- dom/Document.h:
- dom/EventContext.cpp:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::callWillDispatchEventOnInputElement):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
- html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick):
- html/CheckboxInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willDispatchEvent):
(WebCore::HTMLInputElement::didDispatchClickEvent):
- html/HTMLInputElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::willDispatchFullScreenChangeEvent): Renamed from preDispatchEventHandler.
- html/HTMLTextFormControlElement.h:
- html/InputType.cpp:
(WebCore::InputType::willDispatchClick):
- html/InputType.h:
- html/RadioInputType.cpp:
(WebCore::RadioInputType::willDispatchClick):
- html/RadioInputType.h:
- 11:41 PM Changeset in webkit [156824] by
-
- 5 edits in trunk/Source/WebCore
Update binding test results after r156808 for r156769.
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeOwner::finalize):
- bindings/scripts/test/JS/JSattribute.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyOwner::finalize):
- bindings/scripts/test/JS/JSreadonly.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- 11:30 PM Changeset in webkit [156823] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260
Reviewed by Mark Rowe.
For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.
- API/tests/testapi.mm:
- 10:59 PM Changeset in webkit [156822] by
-
- 69 edits in trunk/Source/WebCore
Unreviewed, rolling out r156816.
http://trac.webkit.org/changeset/156816
https://bugs.webkit.org/show_bug.cgi?id=122259
broke 8 tests (Requested by kling on #webkit).
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::willRecalcStyle):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::listAttributeTargetChanged):
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::setPositionFromValue):
(WebCore::SliderThumbElement::setPositionFromPoint):
(WebCore::SliderThumbElement::stopDragging):
- page/FrameView.cpp:
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
(WebCore::FrameView::layout):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::setNeedsLayout):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
- rendering/FlowThreadController.h:
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutShapeDescendantIfMoved):
(WebCore::RenderBlock::markShapeInsideDescendantsForLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
(WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markPositionedObjectsForLayout):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustPositionedBlock):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlock::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::layout):
(WebCore::RenderBox::positionLineBox):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
- rendering/RenderElement.h:
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::styleDidChange):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFrames):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::continueResizing):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::layout):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::updateMarqueeStyle):
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::relayoutForPagination):
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::layout):
- rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNormalChildNeedsLayout):
(WebCore::RenderObject::setPosChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setChildNeedsLayout):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::layout):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutSpecialExcludedChild):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarParts):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::layout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
(WebCore::RenderTable::setNeedsSectionRecalc):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
(WebCore::RenderTableCell::setCellLogicalWidth):
(WebCore::RenderTableCell::layout):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::layout):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::recalcCells):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutSpecialExcludedChild):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::setNeedsLayoutOnAncestors):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::styleDidChange):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::layout):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layout):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
- rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::layout):
- rendering/svg/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::layout):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::setFilterRes):
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::svgAttributeChanged):
(WebCore::SVGGradientElement::childrenChanged):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::svgAttributeChanged):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::childrenChanged):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::svgAttributeChanged):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::updateCurrentTranslate):
- 9:31 PM Changeset in webkit [156821] by
-
- 3 edits in trunk/Websites/webkit.org
2013-10-02 Geoffrey Garen <ggaren@apple.com>
Sync'd sunspider-1.0.2 to PerformanceTests/SunSpider/hosted/sunspider-1.0.2.
- perf/sunspider-1.0.2/sunspider-1.0.2/driver.html:
- perf/sunspider-1.0.2/sunspider-1.0.2/sunspider-test-contents.js:
- 9:25 PM Changeset in webkit [156820] by
-
- 3 edits in trunk/PerformanceTests/SunSpider
Improved painting behavior in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122257
Reviewed by Oliver Hunt.
Individual test names with times was a good painting strategy years
back, when each benchmark took hundreds of milliseconds to run. Now,
the whole suite can finish in a a few hundres milliseconds, and things
look pretty flashy.
Instead, display a countdown that indicates which iteration of the
test we're on.
- resources/TEMPLATE.html: Work around a bug in Firefox by specifying
our style inside the .html file instead of in an external stylesheet.
Under heavy JavaScript load, Firefox neglects to apply external
stylesheets -- probably due to a starved timer.
- resources/driver-TEMPLATE.html: Delay a little between runs to ensure
that our countdown has enough time to paint.
- 8:21 PM Changeset in webkit [156819] by
-
- 5 edits in trunk/Source/WebCore
Keep SVGElementRareData in an SVGElement member instead of a hashmap.
<https://webkit.org/b/122253>
Reviewed by Antti Koivisto.
Free up another Node flag by moving SVGElement's SVG-specific rare data
to a member variable instead of tracking them in a hashmap on the side.
This grows SVGElement by one pointer, but I will make up for this in
subsequent patches.
- 7:44 PM Changeset in webkit [156818] by
-
- 7 edits in trunk/Source/JavaScriptCore
Make LLINT exception stack unwinding consistent with the JIT.
https://bugs.webkit.org/show_bug.cgi?id=122255.
Reviewed by Filip Pizlo.
Previously, the CommonSlowPaths code is expected to behave in an
inconsistent way in terms of whether to unwind the stack when handling
exceptions or not. For the LLINT, the slow path should unwind the stack
before returning. For the JIT, the slow path should not unwind the stack.
This can result in the stack being unwound twice when the exception
being handled is a TerminationException.
This patch fixes the LLINT's expectation so that it expects the same
slow path behavior as the JIT does.
- llint/LLIntExceptions.cpp:
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):
- 7:27 PM Changeset in webkit [156817] by
-
- 9 edits in trunk/Source/JavaScriptCore
The DFG should use always DFG::Graph methods for determining where special registers are
https://bugs.webkit.org/show_bug.cgi?id=122248
Reviewed by Michael Saboff.
This makes it possible to have the DFG use different registers than the other engines
for things like activation and arguments.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setLocalStoreElimination):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::activationRegister):
(JSC::DFG::Graph::uncheckedActivationRegister):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::baselineArgumentsRegisterFor):
- 7:26 PM Changeset in webkit [156816] by
-
- 69 edits in trunk/Source/WebCore
Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256
Reviewed by Andreas Kling.
These bits never apply to RenderText nodes:
normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout
The code for setting them can be moved to RenderElement.
Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.
- 6:32 PM Changeset in webkit [156815] by
-
- 3 edits in trunk/Source/WebCore
CTTE: Drag events are only dispatched on Elements.
<https://webkit.org/b/122250>
Reviewed by Antti Koivisto.
We never dispatch drag events on non-Element nodes so tighten up the
code to operate on Elements instead.
- 5:54 PM Changeset in webkit [156814] by
-
- 10 edits3 adds in trunk
[CSS Shapes] Implement the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122216
Reviewed by Andreas Kling.
Source/WebCore:
Added support for the CSS shape-image-threshold property. This change
just enables parsing the property, it's not connected to the
Shapes code yet.
The number valued shape-image-threshold property is defined here:
http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
Its computed value is clamped to the range [0, 1].
Test: fast/shapes/parsing/parsing-shape-image-threshold.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
Check parsing of the non-inherited CSS shape-image-threshold number property.
The property is defined here:
http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
- fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: Added.
- fast/shapes/parsing/parsing-shape-image-threshold.html: Added.
- fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Added.
- 5:10 PM Changeset in webkit [156813] by
-
- 10 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/plugins.
<https://webkit.org/b/122247>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and Qt-specific files.
- 5:04 PM Changeset in webkit [156812] by
-
- 1 edit7 deletes in trunk
Remove Qt related files from the root directories
https://bugs.webkit.org/show_bug.cgi?id=122249
Reviewed by Andreas Kling.
- Source/QtWebKit.pro: Removed.
- Source/api.pri: Removed.
- Source/qtwebkit.qdocconf: Removed.
- Source/sync.profile: Removed.
- Source/tests.pri: Removed.
- Source/widgetsapi.pri: Removed.
- WebKit.pro: Removed.
- 4:47 PM Changeset in webkit [156811] by
-
- 8 edits in trunk/Source/JavaScriptCore
The Objective-C API should be available in 10.8 builds
https://bugs.webkit.org/show_bug.cgi?id=122245
Reviewed by Mark Rowe.
Enabled the Objective-C API when building on OS X 10.8 with the modern Objective-C runtime,
but kept the availability attributes in API headers for 10.9 and later as they were.
- API/JSBase.h: When JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 is defined, made
JSC_OBJC_API_ENABLED true on 10.8 and above.
- API/JSContext.h: When JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 is defined, marked the class
as available on all OS X versions.
- API/JSManagedValue.h: Ditto.
- API/JSValue.h: Ditto.
- API/JSVirtualMachine.h: Ditto.
- Configurations/Base.xcconfig: Added JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 to
GCC_PREPROCESSOR_DEFINITIONS.
- JavaScriptCore.xcodeproj/project.pbxproj: Added a script build phase to unifdef the
above header files with JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 either defined or not based on
the OS X version we are targeting.
- 4:33 PM Changeset in webkit [156810] by
-
- 3 edits in trunk/Source/JavaScriptCore
Make Baseline JIT exception handling work like the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=122244
Reviewed by Filip Pizlo.
Added a jump list (m_exceptionChecks) to JIT as a common place for exception processing within
generated code. Added exceptionCheck() helpers that check for an exception which add a branch
to the list.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JIT.h:
(JSC::JIT::exceptionCheck):
- 4:33 PM Changeset in webkit [156809] by
-
- 6 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: save and restore source positions in back/forward history
https://bugs.webkit.org/show_bug.cgi?id=122062
Patch by Brian J. Burg <Brian Burg> on 2013-10-02
Reviewed by Timothy Hatcher.
Previously, the back/forward entries comprised of only the content
views, but not their positions if navigated via hyperlink (i.e.,
handling script.js:42). When multiple instances of the same
content view appeared in the back/forward list, the most recent
navigation was displayed rather than the linked position.
We now store context necessary to re-navigate such hyperlinks by
storing view- specific data inside a cookie object, and invoke a
supplied callback to take any position initialization actions,
such as calling TextEditor.revealPosition. This state is
encapsulated into BackForwardEntry instances.
Functions that save and restore scroll positions inside content
views have been changed to store state in BackForwardEntry
instances, so multiple scroll positions can be saved for a content
view appearing in the navigation history more than once.
- UserInterface/BackForwardEntry.js: Added.
(WebInspector.BackForwardEntry):
(WebInspector.BackForwardEntry.prototype.get contentView):
(WebInspector.BackForwardEntry.prototype.get cookie):
(WebInspector.BackForwardEntry.prototype.prepareToShow):
(WebInspector.BackForwardEntry.prototype.prepareToHide):
(WebInspector.BackForwardEntry.prototype._restoreFromCookie):
(WebInspector.BackForwardEntry.prototype._restoreScrollPositions):
(WebInspector.BackForwardEntry.prototype._saveScrollPositions):
- UserInterface/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype.showContentView):
(WebInspector.ContentBrowser.prototype._updateContentViewNavigationItems):
(WebInspector.ContentBrowser.prototype._updateFindBanner):
- UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.get currentContentView):
(WebInspector.ContentViewContainer.prototype.get currentBackForwardEntry):
(WebInspector.ContentViewContainer.prototype.showContentView):
(WebInspector.ContentViewContainer.prototype.showBackForwardEntryForIndex):
(WebInspector.ContentViewContainer.prototype.replaceContentView):
(WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
(WebInspector.ContentViewContainer.prototype.closeAllContentViews):
(WebInspector.ContentViewContainer.prototype.goBack):
(WebInspector.ContentViewContainer.prototype.goForward):
(WebInspector.ContentViewContainer.prototype.shown):
(WebInspector.ContentViewContainer.prototype.hidden):
(WebInspector.ContentViewContainer.prototype._showEntry):
(WebInspector.ContentViewContainer.prototype._hideEntry):
- UserInterface/Main.html:
- UserInterface/Main.js:
(WebInspector.openURL):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.restoreCallback):
(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
- 4:32 PM Changeset in webkit [156808] by
-
- 14 edits22 adds in trunk/Source/WebCore
IDL parser should remove a leading "_" from identifier names
https://bugs.webkit.org/show_bug.cgi?id=122239
Reviewed by Jer Noble.
No new tests, updated bindings tests and results.
- bindings/scripts/IDLParser.pm:
(identifierRemoveNullablePrefix): Remove leading "_".
(parseInterface): Call identifierRemoveNullablePrefix.
(parseException): Ditto.
(parseEnum): Ditto.
(parseConst): Ditto.
(parseAttributeRest): Ditto.
(parseOperationRest): Ditto.
(parseOptionalOrRequiredArgument): Ditto.
(parseExceptionField): Ditto.
(parseNonAnyType): Ditto.
Update tests and results.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/CPP/WebDOMattribute.cpp: Added.
- bindings/scripts/test/CPP/WebDOMattribute.h: Added.
- bindings/scripts/test/CPP/WebDOMreadonly.cpp: Added.
- bindings/scripts/test/CPP/WebDOMreadonly.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.symbols:
- bindings/scripts/test/GObject/WebKitDOMattribute.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMattribute.h: Added.
- bindings/scripts/test/GObject/WebKitDOMattribute.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMattributePrivate.h: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.h: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonlyPrivate.h: Added.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSattribute.cpp: Added.
- bindings/scripts/test/JS/JSattribute.h: Added.
- bindings/scripts/test/JS/JSreadonly.cpp: Added.
- bindings/scripts/test/JS/JSreadonly.h: Added.
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/ObjC/DOMattribute.h: Added.
- bindings/scripts/test/ObjC/DOMattribute.mm: Added.
- bindings/scripts/test/ObjC/DOMattributeInternal.h: Added.
- bindings/scripts/test/ObjC/DOMreadonly.h: Added.
- bindings/scripts/test/ObjC/DOMreadonly.mm: Added.
- bindings/scripts/test/ObjC/DOMreadonlyInternal.h: Added.
- bindings/scripts/test/TestException.idl:
- bindings/scripts/test/TestInterface.idl:
- bindings/scripts/test/TestObj.idl:
- 4:29 PM Changeset in webkit [156807] by
-
- 8 edits in trunk/LayoutTests
[CSS Regions] Helper functions for selection layout tests
https://bugs.webkit.org/show_bug.cgi?id=122128
Reviewed by Alexandru Chiculita.
Create new common JavaScript methods for CSS Regions layout tests
related to selection. Refactored tests in order to use them.
- fast/regions/resources/helper.js: Added new functions.
(selectContentByRange): Select from start to end position.
(selectContentByIds): Select from the beginning of the first element to the end
of the second one.
(selectBaseAndExtent): Select from start to end with given offsets using
Selection.setBaseAndExtent() method.
(mouseClick): Clicks in a given position.
- fast/regions/selection/selecting-text-in-empty-region.html: Refactored
test in order to use the new functions.
- fast/regions/selection/selecting-text-through-different-region-flows-2-expected.html:
Ditto.
- fast/regions/selection/selecting-text-through-different-region-flows-2.html:
Ditto.
- fast/regions/selection/selecting-text-through-different-region-flows.html:
Ditto.
- fast/regions/selection/selection-direction-expected.html: Ditto.
- fast/regions/selection/selection-direction.html: Ditto.
- 4:27 PM Changeset in webkit [156806] by
-
- 3 edits2 adds in trunk
[css-shapes] shape-outside does not properly handle the container and the float having different writing modes
https://bugs.webkit.org/show_bug.cgi?id=122243
Reviewed by Alexandru Chiculita.
Source/WebCore:
The margin box offset needs to be computed based on the writing mode
of the container, not the writihg mode of the float itself. This
patch makes that happen.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
LayoutTests:
Test that the margins and width are properly computed in the case of
different writing modes.
- fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html: Added.
- 4:11 PM Changeset in webkit [156805] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC build
- 3:37 PM Changeset in webkit [156804] by
-
- 10 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{bindings,bridge,loader,icon,testing}.
<https://webkit.org/b/122242>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and Qt-specific files.
- 3:21 PM Changeset in webkit [156803] by
-
- 2 edits in trunk/Tools
EWS build fix after the Qt EWS removal.
- QueueStatusServer/model/attachment.py:
(Attachment._calculate_queue_positions):
- 3:14 PM Changeset in webkit [156802] by
-
- 2 edits in trunk/Source/JavaScriptCore
Optimized VM access from C++ code
https://bugs.webkit.org/show_bug.cgi?id=122241
Reviewed by Filip Pizlo.
- runtime/JSScope.h:
(JSC::JSScope::vm): Use MarkedBlock instead of Heap, since both have a
pointer to the VM, and Heap is one extra load.
- 2:58 PM Changeset in webkit [156801] by
-
- 11 edits in trunk/LayoutTests
Unreviewed rebaseline, try to add newlines back that keep disappearing on me.
- platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
- platform/mac-wk2/compositing/contents-opaque/body-background-skipped-expected.txt:
- platform/mac-wk2/compositing/repaint/fixed-background-scroll-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac-wk2/compositing/tiling/tiled-layer-resize-expected.txt:
- 2:57 PM Changeset in webkit [156800] by
-
- 3 edits2 deletes in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{page,accessibility}.
<https://webkit.org/b/122222>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 2:45 PM Changeset in webkit [156799] by
-
- 8 edits1 delete in trunk/Source/WebKit2
Remove Qt code from Platform/
https://bugs.webkit.org/show_bug.cgi?id=122240
Reviewed by Andreas Kling.
- Platform/CoreIPC/Connection.h:
- Platform/Logging.cpp:
- Platform/Logging.h:
- Platform/Module.h:
- Platform/PlatformProcessIdentifier.h:
- Platform/SharedMemory.h:
- Platform/WorkQueue.h:
- Platform/qt/LoggingQt.cpp: Removed.
- Platform/qt/ModuleQt.cpp: Removed.
- Platform/qt/WorkQueueQt.cpp: Removed.
- 2:44 PM Changeset in webkit [156798] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Move ShapeInsideInfo::updateSegmentsForLine implementations into the cpp
https://bugs.webkit.org/show_bug.cgi?id=122236
Reviewed by Oliver Hunt.
There is no reason for updateSegmentsForLine methods to be inline. I moved them to the cpp.
No new tests, no behavior change.
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::updateSegmentsForLine):
- rendering/shapes/ShapeInsideInfo.h:
- 2:27 PM Changeset in webkit [156797] by
-
- 10 edits25 deletes in trunk/Tools
Remove Qt code from Tools/
https://bugs.webkit.org/show_bug.cgi?id=122227
Reviewed by Andreas Kling.
- DumpRenderTree/WorkQueue.cpp:
- DumpRenderTree/blackberry/src.pro: Removed.
- DumpRenderTree/qt/DumpRenderTree.pro: Removed.
- DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
- DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
- DumpRenderTree/qt/EventSenderQt.cpp: Removed.
- DumpRenderTree/qt/EventSenderQt.h: Removed.
- DumpRenderTree/qt/GCControllerQt.cpp: Removed.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
- DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
- DumpRenderTree/qt/TestRunnerQt.h: Removed.
- DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
- DumpRenderTree/qt/TextInputControllerQt.h: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
- DumpRenderTree/qt/fonts/AHEM.TTF: Removed.
- DumpRenderTree/qt/resources/user.css: Removed.
- DumpRenderTree/qt/testplugin.cpp: Removed.
- DumpRenderTree/qt/testplugin.h: Removed.
- ImageDiff/ImageDiff.pro: Removed.
- ImageDiff/qt/ImageDiff.cpp: Removed.
- MiniBrowser/qt/BrowserWindow.cpp: Removed.
- MiniBrowser/qt/BrowserWindow.h: Removed.
- MiniBrowser/qt/MiniBrowser.pro: Removed.
- MiniBrowser/qt/MiniBrowser.qrc: Removed.
- MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
- MiniBrowser/qt/MiniBrowserApplication.h: Removed.
- MiniBrowser/qt/UrlLoader.cpp: Removed.
- MiniBrowser/qt/UrlLoader.h: Removed.
- MiniBrowser/qt/icons/checkbox_checked.png: Removed.
- MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
- MiniBrowser/qt/icons/contents_width.png: Removed.
- MiniBrowser/qt/icons/favicon.png: Removed.
- MiniBrowser/qt/icons/find.png: Removed.
- MiniBrowser/qt/icons/folder.png: Removed.
- MiniBrowser/qt/icons/info.png: Removed.
- MiniBrowser/qt/icons/next.png: Removed.
- MiniBrowser/qt/icons/plus.png: Removed.
- MiniBrowser/qt/icons/previous.png: Removed.
- MiniBrowser/qt/icons/refresh.png: Removed.
- MiniBrowser/qt/icons/stop.png: Removed.
- MiniBrowser/qt/icons/titlebar.png: Removed.
- MiniBrowser/qt/icons/touch.png: Removed.
- MiniBrowser/qt/icons/touchpoint.png: Removed.
- MiniBrowser/qt/icons/up.png: Removed.
- MiniBrowser/qt/js/MultiSelect.js: Removed.
- MiniBrowser/qt/main.cpp: Removed.
- MiniBrowser/qt/qml/AlertDialog.qml: Removed.
- MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
- MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
- MiniBrowser/qt/qml/CheckBox.qml: Removed.
- MiniBrowser/qt/qml/ColorChooser.qml: Removed.
- MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
- MiniBrowser/qt/qml/Dialog.qml: Removed.
- MiniBrowser/qt/qml/DialogButton.qml: Removed.
- MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
- MiniBrowser/qt/qml/FilePicker.qml: Removed.
- MiniBrowser/qt/qml/ItemSelector.qml: Removed.
- MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
- MiniBrowser/qt/qml/PromptDialog.qml: Removed.
- MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
- MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
- MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
- MiniBrowser/qt/raw/DerivedSources.pri: Removed.
- MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
- MiniBrowser/qt/raw/Target.pri: Removed.
- MiniBrowser/qt/raw/View.cpp: Removed.
- MiniBrowser/qt/raw/View.h: Removed.
- MiniBrowser/qt/utils.cpp: Removed.
- MiniBrowser/qt/utils.h: Removed.
- QtTestBrowser/QtTestBrowser.pro: Removed.
- QtTestBrowser/QtTestBrowser.qrc: Removed.
- QtTestBrowser/cookiejar.cpp: Removed.
- QtTestBrowser/cookiejar.h: Removed.
- QtTestBrowser/favicon.png: Removed.
- QtTestBrowser/fpstimer.cpp: Removed.
- QtTestBrowser/fpstimer.h: Removed.
- QtTestBrowser/launcherwindow.cpp: Removed.
- QtTestBrowser/launcherwindow.h: Removed.
- QtTestBrowser/locationedit.cpp: Removed.
- QtTestBrowser/locationedit.h: Removed.
- QtTestBrowser/mainwindow.cpp: Removed.
- QtTestBrowser/mainwindow.h: Removed.
- QtTestBrowser/qttestbrowser.cpp: Removed.
- QtTestBrowser/urlloader.cpp: Removed.
- QtTestBrowser/urlloader.h: Removed.
- QtTestBrowser/useragentlist.txt: Removed.
- QtTestBrowser/utils.cpp: Removed.
- QtTestBrowser/utils.h: Removed.
- QtTestBrowser/webinspector.h: Removed.
- QtTestBrowser/webpage.cpp: Removed.
- QtTestBrowser/webpage.h: Removed.
- QtTestBrowser/webview.cpp: Removed.
- QtTestBrowser/webview.h: Removed.
- TestWebKitAPI/DerivedSources.pri: Removed.
- TestWebKitAPI/InjectedBundle.pri: Removed.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/TestWebKitAPI.pri: Removed.
- TestWebKitAPI/TestWebKitAPI.pro: Removed.
- TestWebKitAPI/Tests.pri: Removed.
- TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
- TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
- TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
- TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
- TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
- TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
- TestWebKitAPI/qt/main.cpp: Removed.
- Tools.pro: Removed.
- WebKitTestRunner/DerivedSources.pri: Removed.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
(WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/Target.pri: Removed.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/Target.pri: Removed.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/WebKitTestRunner.pro: Removed.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
- WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
- WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
- WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
- WebKitTestRunner/qt/main.cpp: Removed.
- WebKitTestRunner/qt/resources/user.css: Removed.
- qmake/.qmake.cache: Removed.
- qmake/.qmake.conf: Removed.
- qmake/README: Removed.
- qmake/config.tests/README: Removed.
- qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
- qmake/config.tests/fontconfig/fontconfig.pro: Removed.
- qmake/config.tests/gccdepends/empty.cpp: Removed.
- qmake/config.tests/gccdepends/gccdepends.pro: Removed.
- qmake/config.tests/glx/glx.cpp: Removed.
- qmake/config.tests/glx/glx.pro: Removed.
- qmake/config.tests/gnuld/gnuld.pro: Removed.
- qmake/config.tests/gnuld/main.cpp: Removed.
- qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
- qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
- qmake/config.tests/libXrender/libXrender.cpp: Removed.
- qmake/config.tests/libXrender/libXrender.pro: Removed.
- qmake/config.tests/libwebp/libwebp.cpp: Removed.
- qmake/config.tests/libwebp/libwebp.pro: Removed.
- qmake/config.tests/libxml2/libxml2.cpp: Removed.
- qmake/config.tests/libxml2/libxml2.pro: Removed.
- qmake/config.tests/libxslt/libxslt.cpp: Removed.
- qmake/config.tests/libxslt/libxslt.pro: Removed.
- qmake/config.tests/libzlib/libzlib.cpp: Removed.
- qmake/config.tests/libzlib/libzlib.pro: Removed.
- qmake/dump-features.pl: Removed.
- qmake/mkspecs/features/configure.prf: Removed.
- qmake/mkspecs/features/default_post.prf: Removed.
- qmake/mkspecs/features/default_pre.prf: Removed.
- qmake/mkspecs/features/features.prf: Removed.
- qmake/mkspecs/features/features.pri: Removed.
- qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
- qmake/mkspecs/features/functions.prf: Removed.
- qmake/mkspecs/features/gprof.prf: Removed.
- qmake/mkspecs/features/mac/default_post.prf: Removed.
- qmake/mkspecs/features/mac/default_pre.prf: Removed.
- qmake/mkspecs/features/minimal_qt.prf: Removed.
- qmake/mkspecs/features/production_build.prf: Removed.
- qmake/mkspecs/features/rpath.prf: Removed.
- qmake/mkspecs/features/unix/default_post.prf: Removed.
- qmake/mkspecs/features/unix/default_pre.prf: Removed.
- qmake/mkspecs/features/unix/icc.prf: Removed.
- qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
- qmake/mkspecs/features/valgrind.prf: Removed.
- qmake/mkspecs/features/webkit_modules.prf: Removed.
- qmake/mkspecs/features/win32/default_post.prf: Removed.
- qmake/mkspecs/features/win32/default_pre.prf: Removed.
- qmake/mkspecs/modules/angle.prf: Removed.
- qmake/mkspecs/modules/javascriptcore.prf: Removed.
- qmake/mkspecs/modules/webcore.prf: Removed.
- qmake/mkspecs/modules/webkit1.prf: Removed.
- qmake/mkspecs/modules/webkit2.prf: Removed.
- qmake/mkspecs/modules/wtf.prf: Removed.
- 2:24 PM Changeset in webkit [156796] by
-
- 3 edits8 moves1 add in trunk/LayoutTests
[CSS Regions] Selection layout tests moved to specific folder
https://bugs.webkit.org/show_bug.cgi?id=122099
Reviewed by Alexandru Chiculita.
Moved CSS Regions layout tests related to selection to
"fast/regions/selection/".
- fast/regions/selection/selecting-text-in-empty-region-expected.txt: Renamed from LayoutTests/fast/regions/selecting-text-in-empty-region-expected.txt.
- fast/regions/selection/selecting-text-in-empty-region.html: Renamed from LayoutTests/fast/regions/selecting-text-in-empty-region.html.
- fast/regions/selection/selecting-text-through-different-region-flows-2-expected.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-2-expected.html.
- fast/regions/selection/selecting-text-through-different-region-flows-2.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-2.html.
- fast/regions/selection/selecting-text-through-different-region-flows-expected.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-expected.html.
- fast/regions/selection/selecting-text-through-different-region-flows.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows.html.
- fast/regions/selection/selection-direction-expected.html: Renamed from LayoutTests/fast/regions/selection-direction-expected.html.
- fast/regions/selection/selection-direction.html: Renamed from LayoutTests/fast/regions/selection-direction.html.
- platform/gtk-wk2/TestExpectations: Update path in skipped tests.
- platform/qt-wk2/TestExpectations: Ditto.
- 2:24 PM WebKitGTK/2.2.x edited by
- (diff)
- 2:23 PM Changeset in webkit [156795] by
-
- 79 edits11 deletes in trunk/Source/WebCore
Remove Qt from WebCore/platform.
<https://webkit.org/b/122228>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 2:22 PM Changeset in webkit [156794] by
-
- 8 edits in trunk
The LLInt should not use JITStackFrame
https://bugs.webkit.org/show_bug.cgi?id=122231
Reviewed by Filip Pizlo.
Replaced uses of JITStackFrame::vm with code to either access the vm via the CodeBlock from
known JavaScript call frames or via the JSScope* for host call frames. This eliminates
all uses of JITStackFrame from the LLInt.
- heap/MarkedBlock.h: Made LLIntOffsetsExtractor a friend to access member offsets.
- heap/WeakSet.h: Made LLIntOffsetsExtractor a friend to access member offsets.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Added an ASSERT for the newly added MarkedBlockMask
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 2:14 PM Changeset in webkit [156793] by
-
- 22 edits31 adds3 deletes in trunk
[mac] Stop using DrawingAreaImpl on PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=121859
<rdar://problem/15069359>
Reviewed by Anders Carlsson.
The Mac port will now use tiled drawing for all WebKit2 views.
- Shared/DrawingAreaInfo.h:
Don't include DrawingAreaTypeImpl as a valid DrawingAreaType on Mac.
- UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
Remove our implementation of drawRect that paints from DrawingAreaImpl's backing store.
(-[WKView _shouldUseTiledDrawingArea]):
Removed. Always treated as if it were true, now.
(-[WKView _createDrawingAreaProxy]):
Always create a TiledCoreAnimationDrawingAreaProxy now.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView wantsUpdateLayer]):
WKView always wants a layer, etc.
- UIProcess/BackingStore.h:
Remove Mac-specific BackingStore code, only used for DrawingAreaImpl on Mac.
- UIProcess/DrawingAreaProxy.h:
Remove an unneeded include.
- UIProcess/mac/BackingStoreMac.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj:
Remove a bunch of files we don't need to build anymore.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
Never create a DrawingAreaImpl on Mac.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
(WebKit::DrawingAreaImpl::resumePainting):
- WebProcess/WebPage/DrawingAreaImpl.h:
Remove Mac-specific DrawingAreaImpl code.
- WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
- WebProcess/WebPage/mac/LayerTreeHostMac.h: Removed.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: Removed.
- page/FrameView.cpp:
(WebCore::FrameView::addTrackedRepaintRect):
(WebCore::FrameView::repaintContentRectangle):
- page/FrameView.h:
Factor out the coordinate conversion and appending of new repaint rects on FrameView.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
Don't dump repaint rects on the root tile cache, they'll be included at the top,
where FrameView's repaints are normally included.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
Push the root tile cache's tracked repaint rects to FrameView instead.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::shouldUseThreadedScrolling):
(WTR::updateThreadedScrollingForCurrentTest):
(WTR::TestInvocation::invoke):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
Rename the tiled drawing switch to threaded scrolling, since that's really
all it switches now that we use tiled drawing everywhere.
Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
and to more closely match the case we're interested in testing.
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt: Added.
- platform/mac-wk2/compositing/contents-opaque/body-background-skipped-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
Add WebKit2 results, because we dump non-white background color on the root layer now.
- platform/mac-wk2/compositing/repaint/fixed-background-scroll-expected.txt: Added.
New WebKit2 result; repaint rects are showing up now.
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
Slightly adjusted results.
- platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/tiled-layer-resize-expected.txt: Added.
New WebKit2 results; we show the root tile cache if layerTreeAsText is asked to dump tile caches.
- platform/mac-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- platform/mac-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
- platform/mac-wk2/fast/block/basic/020-expected.txt: Added.
- platform/mac-wk2/fast/dynamic/012-expected.txt: Added.
- platform/mac-wk2/fast/dynamic/layer-hit-test-crash-expected.txt: Added.
- platform/mac-wk2/fast/repaint/layer-hide-when-needs-layout-expected.txt: Added.
- platform/mac-wk2/fast/text/whitespace/028-expected.txt: Added.
- platform/mac-wk2/fast/layers/layer-visibility-expected.txt: Added.
- platform/mac-wk2/fast/layers/layer-visibility-sublayer-expected.txt: Added.
- platform/mac-wk2/fast/repaint/invisible-objects-expected.txt: Added.
New WebKit2 results; additional compositing layers.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
New test to ensure that window-server snapshots work with tiled drawing.
- 1:34 PM Changeset in webkit [156792] by
-
- 2 edits in trunk/Source/WTF
Eliminate a branch in FastBitVector setAndCheck, make it vectorizable.
https://bugs.webkit.org/show_bug.cgi?id=122229
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-02
Reviewed by Geoffrey Garen.
The CPU is unlikely to predict the branch in setAndCheck. I changed the code to use conditional instructions.
- wtf/FastBitVector.h:
(WTF::FastBitVector::setAndCheck):
- 1:34 PM Changeset in webkit [156791] by
-
- 13 edits9 adds in trunk
Implement Array key, value and entries iterators
https://bugs.webkit.org/show_bug.cgi?id=122195
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Add implementation of ES6 Array iterators for keys(), values() and entries()
Fairly self explanatory as we just need a simple implementation so that we can
implement and test other features.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/ArrayIteratorConstructor.cpp: Added.
(JSC::ArrayIteratorConstructor::finishCreation):
- runtime/ArrayIteratorConstructor.h: Added.
(JSC::ArrayIteratorConstructor::create):
(JSC::ArrayIteratorConstructor::createStructure):
(JSC::ArrayIteratorConstructor::ArrayIteratorConstructor):
- runtime/ArrayIteratorPrototype.cpp: Added.
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorPrototypeNext):
- runtime/ArrayIteratorPrototype.h: Added.
(JSC::ArrayIteratorPrototype::create):
(JSC::ArrayIteratorPrototype::createStructure):
(JSC::ArrayIteratorPrototype::ArrayIteratorPrototype):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncValues):
(JSC::arrayProtoFuncEntries):
(JSC::arrayProtoFuncKeys):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.h:
(JSC::Identifier::createEmptyUnique):
- runtime/JSArrayIterator.cpp: Added.
(JSC::JSArrayIterator::finishCreation):
- runtime/JSArrayIterator.h: Added.
(JSC::JSArrayIterator::createStructure):
(JSC::JSArrayIterator::create):
(JSC::JSArrayIterator::iterationKind):
(JSC::JSArrayIterator::iteratedObject):
(JSC::JSArrayIterator::nextIndex):
(JSC::JSArrayIterator::setNextIndex):
(JSC::JSArrayIterator::finish):
(JSC::JSArrayIterator::JSArrayIterator):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::iteratorResultStructure):
LayoutTests:
Add tests
- js/Object-getOwnPropertyNames-expected.txt:
- js/array-iterators-expected.txt: Added.
- js/array-iterators.html: Added.
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/array-iterators.js: Added.
- 1:31 PM Changeset in webkit [156790] by
-
- 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-wk2/TestExpectations
Merge 156783.
- 1:16 PM Changeset in webkit [156789] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed build fix.
- WebScriptWorld.cpp:
(WebScriptWorld::findOrCreateWorld):
- 12:55 PM Changeset in webkit [156788] by
-
- 6 edits in trunk/Source/WebCore
Clean up more <style scoped> from style resolution
https://bugs.webkit.org/show_bug.cgi?id=122188
Reviewed by Darin Adler.
- css/ElementRuleCollector.cpp:
(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):
- css/ElementRuleCollector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
- 12:38 PM Changeset in webkit [156787] by
-
- 2 edits in trunk/Source/JavaScriptCore
get_callee and to_this aren't properly cleared during finalizeUnconditionally
https://bugs.webkit.org/show_bug.cgi?id=122224
Reviewed by Geoffrey Garen.
Even though there is code to clear unmarked inline cache objects in finalizeUnconditionally,
it will never run because get_callee and to_this weren't added to the proper Vector in the
UnlinkedCodeBlock that is iterated during finalizeUnconditionally.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCreateThis):
- 12:16 PM Changeset in webkit [156786] by
-
- 2 edits1 move in trunk/Tools
Move AHEM.TTF from qt/fonts/ to fonts/.
Rubber-stamped by Andreas Kling.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/fonts/AHEM.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM.TTF.
- 12:11 PM Changeset in webkit [156785] by
-
- 19 edits12 adds in trunk
Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
Relanding with fix after rollout - it helps to not completely destroy
optimisations for no reason.
LayoutTests:
Relanding with fix after rollout - it helps to not completely destroy
optimisations for no reason.
- 11:52 AM Changeset in webkit [156784] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: Refactor compileArithDiv and compileArithMod into one function.
https://bugs.webkit.org/show_bug.cgi?id=122205
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-02
Reviewed by Filip Pizlo.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithDivMod):
- 11:34 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:29 AM Changeset in webkit [156783] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-wk2/TestExpectations
Update Test Expectations.
- 11:23 AM Changeset in webkit [156782] by
-
- 25 edits in trunk/Source/WebCore
Update bindings test results.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectOwner::finalize):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterOwner::finalize):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorOwner::finalize):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetOwner::finalize):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionOwner::finalize):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::finalize):
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorOwner::finalize):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjOwner::finalize):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsOwner::finalize):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsOwner::finalize):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- 11:20 AM Changeset in webkit [156781] by
-
- 1 edit263 deletes in trunk/Source/WebKit
Remove WebKit/qt.
Rubber-stamped by Andreas Kling.
- qt/Api/qhttpheader.cpp: Removed.
- qt/Api/qhttpheader_p.h: Removed.
- qt/Api/qwebdatabase.cpp: Removed.
- qt/Api/qwebdatabase.h: Removed.
- qt/Api/qwebdatabase_p.h: Removed.
- qt/Api/qwebelement.cpp: Removed.
- qt/Api/qwebelement.h: Removed.
- qt/Api/qwebelement_p.h: Removed.
- qt/Api/qwebhistory.cpp: Removed.
- qt/Api/qwebhistory.h: Removed.
- qt/Api/qwebhistory_p.h: Removed.
- qt/Api/qwebhistoryinterface.cpp: Removed.
- qt/Api/qwebhistoryinterface.h: Removed.
- qt/Api/qwebkitglobal.cpp: Removed.
- qt/Api/qwebkitglobal.h: Removed.
- qt/Api/qwebkitplatformplugin.h: Removed.
- qt/Api/qwebplugindatabase.cpp: Removed.
- qt/Api/qwebplugindatabase_p.h: Removed.
- qt/Api/qwebpluginfactory.cpp: Removed.
- qt/Api/qwebpluginfactory.h: Removed.
- qt/Api/qwebscriptworld.cpp: Removed.
- qt/Api/qwebscriptworld.h: Removed.
- qt/Api/qwebscriptworld_p.h: Removed.
- qt/Api/qwebsecurityorigin.cpp: Removed.
- qt/Api/qwebsecurityorigin.h: Removed.
- qt/Api/qwebsecurityorigin_p.h: Removed.
- qt/Api/qwebsettings.cpp: Removed.
- qt/Api/qwebsettings.h: Removed.
- qt/ChangeLog-2011-02-16: Removed.
- qt/WebCoreSupport/ChromeClientQt.cpp: Removed.
- qt/WebCoreSupport/ChromeClientQt.h: Removed.
- qt/WebCoreSupport/ContextMenuClientQt.cpp: Removed.
- qt/WebCoreSupport/ContextMenuClientQt.h: Removed.
- qt/WebCoreSupport/DragClientQt.cpp: Removed.
- qt/WebCoreSupport/DragClientQt.h: Removed.
- qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp: Removed.
- qt/WebCoreSupport/DumpRenderTreeSupportQt.h: Removed.
- qt/WebCoreSupport/EditorClientQt.cpp: Removed.
- qt/WebCoreSupport/EditorClientQt.h: Removed.
- qt/WebCoreSupport/FrameLoaderClientQt.cpp: Removed.
- qt/WebCoreSupport/FrameLoaderClientQt.h: Removed.
- qt/WebCoreSupport/FrameNetworkingContextQt.cpp: Removed.
- qt/WebCoreSupport/FrameNetworkingContextQt.h: Removed.
- qt/WebCoreSupport/FullScreenVideoQt.cpp: Removed.
- qt/WebCoreSupport/FullScreenVideoQt.h: Removed.
- qt/WebCoreSupport/GeolocationClientQt.cpp: Removed.
- qt/WebCoreSupport/GeolocationClientQt.h: Removed.
- qt/WebCoreSupport/GeolocationPermissionClientQt.cpp: Removed.
- qt/WebCoreSupport/GeolocationPermissionClientQt.h: Removed.
- qt/WebCoreSupport/IconDatabaseClientQt.cpp: Removed.
- qt/WebCoreSupport/IconDatabaseClientQt.h: Removed.
- qt/WebCoreSupport/InitWebCoreQt.cpp: Removed.
- qt/WebCoreSupport/InitWebCoreQt.h: Removed.
- qt/WebCoreSupport/InspectorClientQt.cpp: Removed.
- qt/WebCoreSupport/InspectorClientQt.h: Removed.
- qt/WebCoreSupport/InspectorServerQt.cpp: Removed.
- qt/WebCoreSupport/InspectorServerQt.h: Removed.
- qt/WebCoreSupport/NotificationPresenterClientQt.cpp: Removed.
- qt/WebCoreSupport/NotificationPresenterClientQt.h: Removed.
- qt/WebCoreSupport/PlatformStrategiesQt.cpp: Removed.
- qt/WebCoreSupport/PlatformStrategiesQt.h: Removed.
- qt/WebCoreSupport/PopupMenuQt.cpp: Removed.
- qt/WebCoreSupport/PopupMenuQt.h: Removed.
- qt/WebCoreSupport/QWebFrameAdapter.cpp: Removed.
- qt/WebCoreSupport/QWebFrameAdapter.h: Removed.
- qt/WebCoreSupport/QWebPageAdapter.cpp: Removed.
- qt/WebCoreSupport/QWebPageAdapter.h: Removed.
- qt/WebCoreSupport/QtPlatformPlugin.cpp: Removed.
- qt/WebCoreSupport/QtPlatformPlugin.h: Removed.
- qt/WebCoreSupport/QtPluginWidgetAdapter.cpp: Removed.
- qt/WebCoreSupport/QtPluginWidgetAdapter.h: Removed.
- qt/WebCoreSupport/QtPrintContext.cpp: Removed.
- qt/WebCoreSupport/QtPrintContext.h: Removed.
- qt/WebCoreSupport/SearchPopupMenuQt.cpp: Removed.
- qt/WebCoreSupport/SearchPopupMenuQt.h: Removed.
- qt/WebCoreSupport/TextCheckerClientQt.cpp: Removed.
- qt/WebCoreSupport/TextCheckerClientQt.h: Removed.
- qt/WebCoreSupport/TextureMapperLayerClientQt.cpp: Removed.
- qt/WebCoreSupport/TextureMapperLayerClientQt.h: Removed.
- qt/WebCoreSupport/UndoStepQt.cpp: Removed.
- qt/WebCoreSupport/UndoStepQt.h: Removed.
- qt/WebCoreSupport/WebEventConversion.cpp: Removed.
- qt/WebCoreSupport/WebEventConversion.h: Removed.
- qt/WidgetApi/qgraphicswebview.cpp: Removed.
- qt/WidgetApi/qgraphicswebview.h: Removed.
- qt/WidgetApi/qwebframe.cpp: Removed.
- qt/WidgetApi/qwebframe.h: Removed.
- qt/WidgetApi/qwebframe_p.h: Removed.
- qt/WidgetApi/qwebinspector.cpp: Removed.
- qt/WidgetApi/qwebinspector.h: Removed.
- qt/WidgetApi/qwebinspector_p.h: Removed.
- qt/WidgetApi/qwebpage.cpp: Removed.
- qt/WidgetApi/qwebpage.h: Removed.
- qt/WidgetApi/qwebpage_p.h: Removed.
- qt/WidgetApi/qwebview.cpp: Removed.
- qt/WidgetApi/qwebview.h: Removed.
- qt/WidgetApi/qwebviewaccessible.cpp: Removed.
- qt/WidgetApi/qwebviewaccessible_p.h: Removed.
- qt/WidgetSupport/DefaultFullScreenVideoHandler.cpp: Removed.
- qt/WidgetSupport/DefaultFullScreenVideoHandler.h: Removed.
- qt/WidgetSupport/FullScreenVideoWidget.cpp: Removed.
- qt/WidgetSupport/FullScreenVideoWidget.h: Removed.
- qt/WidgetSupport/InitWebKitQt.cpp: Removed.
- qt/WidgetSupport/InitWebKitQt.h: Removed.
- qt/WidgetSupport/InspectorClientWebPage.cpp: Removed.
- qt/WidgetSupport/InspectorClientWebPage.h: Removed.
- qt/WidgetSupport/PageClientQt.cpp: Removed.
- qt/WidgetSupport/PageClientQt.h: Removed.
- qt/WidgetSupport/QGraphicsWidgetPluginImpl.cpp: Removed.
- qt/WidgetSupport/QGraphicsWidgetPluginImpl.h: Removed.
- qt/WidgetSupport/QStyleFacadeImp.cpp: Removed.
- qt/WidgetSupport/QStyleFacadeImp.h: Removed.
- qt/WidgetSupport/QWebUndoCommand.cpp: Removed.
- qt/WidgetSupport/QWebUndoCommand.h: Removed.
- qt/WidgetSupport/QWidgetPluginImpl.cpp: Removed.
- qt/WidgetSupport/QWidgetPluginImpl.h: Removed.
- qt/WidgetSupport/QtFallbackWebPopup.cpp: Removed.
- qt/WidgetSupport/QtFallbackWebPopup.h: Removed.
- qt/WidgetSupport/QtWebComboBox.cpp: Removed.
- qt/WidgetSupport/QtWebComboBox.h: Removed.
- qt/declarative/declarative.pro: Removed.
- qt/declarative/experimental/experimental.pri: Removed.
- qt/declarative/experimental/plugin.cpp: Removed.
- qt/declarative/experimental/plugin.json: Removed.
- qt/declarative/experimental/qmldir: Removed.
- qt/declarative/plugin.cpp: Removed.
- qt/declarative/plugin.json: Removed.
- qt/declarative/plugins.qmltypes: Removed.
- qt/declarative/public.pri: Removed.
- qt/declarative/qmldir: Removed.
- qt/docs/qtwebkit-bridge.qdoc: Removed.
- qt/docs/qtwebkit-goes-mobile.qdoc: Removed.
- qt/docs/qtwebkit.qdoc: Removed.
- qt/docs/qwebview-diagram.png: Removed.
- qt/docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_build_snippet.qdoc: Removed.
- qt/docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_qwebview_snippet.cpp: Removed.
- qt/docs/webkitsnippets/simple/main.cpp: Removed.
- qt/docs/webkitsnippets/simple/simple.pro: Removed.
- qt/docs/webkitsnippets/webelement/main.cpp: Removed.
- qt/docs/webkitsnippets/webelement/webelement.pro: Removed.
- qt/docs/webkitsnippets/webpage/main.cpp: Removed.
- qt/docs/webkitsnippets/webpage/webpage.pro: Removed.
- qt/examples/examples.pro: Removed.
- qt/examples/platformplugin/README: Removed.
- qt/examples/platformplugin/WebNotificationPresenter.cpp: Removed.
- qt/examples/platformplugin/WebNotificationPresenter.h: Removed.
- qt/examples/platformplugin/WebPlugin.cpp: Removed.
- qt/examples/platformplugin/WebPlugin.h: Removed.
- qt/examples/platformplugin/platformplugin.pro: Removed.
- qt/examples/platformplugin/qwebkitplatformplugin.h: Removed.
- qt/tests/MIMESniffing/MIMESniffing.pro: Removed.
- qt/tests/MIMESniffing/TestData.h: Removed.
- qt/tests/MIMESniffing/resources.qrc: Removed.
- qt/tests/MIMESniffing/resources/application_atom+xml: Removed.
- qt/tests/MIMESniffing/resources/application_ogg: Removed.
- qt/tests/MIMESniffing/resources/application_pdf: Removed.
- qt/tests/MIMESniffing/resources/application_postscript: Removed.
- qt/tests/MIMESniffing/resources/application_rdf+xml: Removed.
- qt/tests/MIMESniffing/resources/application_rss+xml: Removed.
- qt/tests/MIMESniffing/resources/application_x-gzip: Removed.
- qt/tests/MIMESniffing/resources/application_x-rar-compressed: Removed.
- qt/tests/MIMESniffing/resources/application_zip: Removed.
- qt/tests/MIMESniffing/resources/audio_x-wave: Removed.
- qt/tests/MIMESniffing/resources/image_bmp: Removed.
- qt/tests/MIMESniffing/resources/image_gif: Removed.
- qt/tests/MIMESniffing/resources/image_jpeg: Removed.
- qt/tests/MIMESniffing/resources/image_png: Removed.
- qt/tests/MIMESniffing/resources/image_vnd.microsoft.icon: Removed.
- qt/tests/MIMESniffing/resources/image_webp: Removed.
- qt/tests/MIMESniffing/resources/text_html: Removed.
- qt/tests/MIMESniffing/resources/text_xml: Removed.
- qt/tests/MIMESniffing/resources/video_webm: Removed.
- qt/tests/MIMESniffing/tst_MIMESniffing.cpp: Removed.
- qt/tests/benchmarks/loading/loading.pro: Removed.
- qt/tests/benchmarks/loading/tst_loading.cpp: Removed.
- qt/tests/benchmarks/painting/painting.pro: Removed.
- qt/tests/benchmarks/painting/tst_painting.cpp: Removed.
- qt/tests/benchmarks/webgl/10000_triangles.html: Removed.
- qt/tests/benchmarks/webgl/tst_webgl.cpp: Removed.
- qt/tests/benchmarks/webgl/tst_webgl.qrc: Removed.
- qt/tests/benchmarks/webgl/webgl.pro: Removed.
- qt/tests/cmake/CMakeLists.txt: Removed.
- qt/tests/cmake/cmake.pro: Removed.
- qt/tests/hybridPixmap/hybridPixmap.pro: Removed.
- qt/tests/hybridPixmap/resources.qrc: Removed.
- qt/tests/hybridPixmap/test.html: Removed.
- qt/tests/hybridPixmap/tst_hybridPixmap.cpp: Removed.
- qt/tests/hybridPixmap/widget.cpp: Removed.
- qt/tests/hybridPixmap/widget.h: Removed.
- qt/tests/hybridPixmap/widget.ui: Removed.
- qt/tests/qgraphicswebview/qgraphicswebview.pro: Removed.
- qt/tests/qgraphicswebview/resources/greendiv.html: Removed.
- qt/tests/qgraphicswebview/resources/input_types.html: Removed.
- qt/tests/qgraphicswebview/resources/pointing_right.html: Removed.
- qt/tests/qgraphicswebview/resources/pointing_up.html: Removed.
- qt/tests/qgraphicswebview/resources/scrolltest_page.html: Removed.
- qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp: Removed.
- qt/tests/qgraphicswebview/tst_qgraphicswebview.qrc: Removed.
- qt/tests/qobjectbridge/qobjectbridge.pro: Removed.
- qt/tests/qobjectbridge/tst_qobjectbridge.cpp: Removed.
- qt/tests/qwebelement/qwebelement.pro: Removed.
- qt/tests/qwebelement/resources/image.png: Removed.
- qt/tests/qwebelement/resources/style.css: Removed.
- qt/tests/qwebelement/resources/style2.css: Removed.
- qt/tests/qwebelement/tst_qwebelement.cpp: Removed.
- qt/tests/qwebelement/tst_qwebelement.qrc: Removed.
- qt/tests/qwebframe/qwebframe.pro: Removed.
- qt/tests/qwebframe/resources/image.png: Removed.
- qt/tests/qwebframe/resources/style.css: Removed.
- qt/tests/qwebframe/resources/test1.html: Removed.
- qt/tests/qwebframe/resources/test2.html: Removed.
- qt/tests/qwebframe/resources/testiframe.html: Removed.
- qt/tests/qwebframe/resources/testiframe2.html: Removed.
- qt/tests/qwebframe/tst_qwebframe.cpp: Removed.
- qt/tests/qwebframe/tst_qwebframe.qrc: Removed.
- qt/tests/qwebhistory/qwebhistory.pro: Removed.
- qt/tests/qwebhistory/resources/page1.html: Removed.
- qt/tests/qwebhistory/resources/page2.html: Removed.
- qt/tests/qwebhistory/resources/page3.html: Removed.
- qt/tests/qwebhistory/resources/page4.html: Removed.
- qt/tests/qwebhistory/resources/page5.html: Removed.
- qt/tests/qwebhistory/resources/page6.html: Removed.
- qt/tests/qwebhistory/tst_qwebhistory.cpp: Removed.
- qt/tests/qwebhistory/tst_qwebhistory.qrc: Removed.
- qt/tests/qwebhistoryinterface/qwebhistoryinterface.pro: Removed.
- qt/tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp: Removed.
- qt/tests/qwebinspector/qwebinspector.pro: Removed.
- qt/tests/qwebinspector/tst_qwebinspector.cpp: Removed.
- qt/tests/qwebpage/qwebpage.pro: Removed.
- qt/tests/qwebpage/resources/content.html: Removed.
- qt/tests/qwebpage/resources/frame_a.html: Removed.
- qt/tests/qwebpage/resources/frame_c.html: Removed.
- qt/tests/qwebpage/resources/framedindex.html: Removed.
- qt/tests/qwebpage/resources/iframe.html: Removed.
- qt/tests/qwebpage/resources/iframe2.html: Removed.
- qt/tests/qwebpage/resources/iframe3.html: Removed.
- qt/tests/qwebpage/resources/index.html: Removed.
- qt/tests/qwebpage/resources/script.html: Removed.
- qt/tests/qwebpage/resources/user.css: Removed.
- qt/tests/qwebpage/tst_qwebpage.cpp: Removed.
- qt/tests/qwebpage/tst_qwebpage.qrc: Removed.
- qt/tests/qwebplugindatabase/qwebplugindatabase.pro: Removed.
- qt/tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Removed.
- qt/tests/qwebsecurityorigin/qwebsecurityorigin.pro: Removed.
- qt/tests/qwebsecurityorigin/resources/test.html: Removed.
- qt/tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp: Removed.
- qt/tests/qwebsecurityorigin/tst_qwebsecurityorigin.qrc: Removed.
- qt/tests/qwebview/.gitignore: Removed.
- qt/tests/qwebview/qwebview.pro: Removed.
- qt/tests/qwebview/resources/frame_a.html: Removed.
- qt/tests/qwebview/resources/index.html: Removed.
- qt/tests/qwebview/resources/input_types.html: Removed.
- qt/tests/qwebview/resources/scrolltest_page.html: Removed.
- qt/tests/qwebview/tst_qwebview.cpp: Removed.
- qt/tests/qwebview/tst_qwebview.qrc: Removed.
- qt/tests/resources/image2.png: Removed.
- qt/tests/resources/test.swf: Removed.
- qt/tests/tests.pri: Removed.
- qt/tests/util.h: Removed.
- 11:17 AM Changeset in webkit [156780] by
-
- 17 edits9 deletes in trunk/Source/JavaScriptCore
Get rid of Qt code from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=122223
Reviewed by Oliver Hunt.
- API/JSStringRefQt.cpp: Removed.
- API/JSStringRefQt.h: Removed.
- API/OpaqueJSString.h:
- DerivedSources.pri: Removed.
- JavaScriptCore.pri: Removed.
- JavaScriptCore.pro: Removed.
- LLIntOffsetsExtractor.pro: Removed.
- Target.pri: Removed.
- assembler/AbstractMacroAssembler.h:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::urshift32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::shouldBlindForSpecificArch):
- assembler/MacroAssemblerX86Common.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithSub):
- heap/HeapTimer.cpp:
(JSC::HeapTimer::timerEvent):
- heap/HeapTimer.h:
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::scheduleTimer):
- heap/IncrementalSweeper.h:
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSub32Constant):
- jsc.cpp:
(main):
- jsc.pro: Removed.
- runtime/DateConstructor.cpp:
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::cancelTimer):
- runtime/GCActivityCallback.h:
- testRegExp.cpp:
(main):
- yarr/yarr.pri: Removed.
- 11:08 AM Changeset in webkit [156779] by
-
- 5 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{rendering,editing,history}.
<https://webkit.org/b/122220>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 11:07 AM Changeset in webkit [156778] by
-
- 12 edits in trunk/Source/WebCore
Remove Qt-specific code in common WebCore/{html,dom} files.
<https://webkit.org/b/122219>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks.
- 11:06 AM Changeset in webkit [156777] by
-
- 2 edits in trunk/LayoutTests
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803
- platform/mac/TestExpectations: Marking as such.
- 11:06 AM Changeset in webkit [156776] by
-
- 2 edits in trunk/Source/WebKit2
Fix the Mac WebKit2 build following <http://trac.webkit.org/changeset/139241>
(https://bugs.webkit.org/show_bug.cgi?id=104197)
WebContextMac.mm fails to compile when building with network process disabled.
The constants WebKit2HTTPProxyDefaultsKey and WebKit2HTTPSProxyDefaultsKey,
defined in WebContextMac.mm, should only be defined when building with the
network process enabled as these constants are only referenced from
ENABLE(NETWORK_PROCESS)-guard code.
- UIProcess/mac/WebContextMac.mm:
- 11:03 AM Changeset in webkit [156775] by
-
- 11 edits3 deletes in trunk/Source/WTF
Remove Qt code from WTF
https://bugs.webkit.org/show_bug.cgi?id=122221
Reviewed by Antti Koivisto.
I'm keeping the PLATFORM(QT) defines in Platform.h for now so we can assess if there are any
Qt only features that we can remove later.
- WTF.pri: Removed.
- WTF.pro: Removed.
- wtf/Assertions.cpp:
- wtf/CurrentTime.cpp:
- wtf/DisallowCType.h:
- wtf/FastMalloc.cpp:
- wtf/FeatureDefines.h:
- wtf/qt/MainThreadQt.cpp: Removed.
- wtf/qt/StringQt.cpp: Removed.
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
- wtf/text/StringImpl.h:
- wtf/text/WTFString.cpp:
(WTF::String::format):
- wtf/text/WTFString.h:
- 11:02 AM Changeset in webkit [156774] by
-
- 2 edits in trunk/LayoutTests
Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602
- platform/mac/TestExpectations: Correcting Mac expectations too, now that we have results.
- 11:00 AM Changeset in webkit [156773] by
-
- 3 edits2 adds in trunk/LayoutTests
Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602
- platform/mac/fast/css/first-letter-block-change-expected.png: Added.
- platform/mac/fast/css/first-letter-block-change-expected.txt: Added.
Added expected results for Mac.
- platform/efl/TestExpectations: Corrected the expectation. This test is not
failing, it has no results.
- 10:26 AM Changeset in webkit [156772] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/templates/root.html
remove Qt from the main buildbot page.
- 10:16 AM Changeset in webkit [156771] by
-
- 4 edits in trunk/Tools
Remove Qt bots and EWS from trunk.
https://bugs.webkit.org/show_bug.cgi?id=122210.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-10-02
Reviewed by Allan Sandfeld Jensen.
Remove Qt buil dbots.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
(RunGtkAPITests.getText2):
(Factory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 10:13 AM Changeset in webkit [156770] by
-
- 3 edits in trunk/Tools
Remove Qt bots and EWS from trunk.
https://bugs.webkit.org/show_bug.cgi?id=122210.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-10-02
Reviewed by Allan Sandfeld Jensen.
Remove Qt EWS bots.
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ews.json:
- 10:03 AM Changeset in webkit [156769] by
-
- 94 edits in trunk/Source
CTTE: DOMWrapperWorlds should be passed around by reference
https://bugs.webkit.org/show_bug.cgi?id=122206
Reviewed by Andreas Kling.
../WebCore:
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):
(WebCore::normalWorld):
(WebCore::mainThreadNormalWorld):
- bindings/js/DOMWrapperWorld.h:
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
(WebCore::currentWorld):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::finalize):
- bindings/js/JSDOMBinding.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::getInlineCachedWrapper):
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::uncacheWrapper):
(WebCore::jsStringWithCache):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::toJSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::world):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::toJSDOMWindowShell):
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::create):
(WebCore::JSDOMWindowShell::world):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::JSErrorHandler):
- bindings/js/JSErrorHandler.h:
(WebCore::JSErrorHandler::create):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::getJSListenerFunctions):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
- bindings/js/JSLazyEventListener.h:
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::JSMutationCallback):
(WebCore::JSMutationCallback::call):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::finalize):
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
- bindings/js/ScriptCachedFrameData.h:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::destroyWindowShell):
(WebCore::ScriptController::createWindowShell):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::getAllWorlds):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptController.h:
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::globalObject):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::isContentScript):
- bindings/js/ScriptState.cpp:
(WebCore::execStateFromNode):
(WebCore::execStateFromPage):
- bindings/js/ScriptState.h:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
- bindings/js/WebCoreJSClientData.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::getAllWorlds):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
- bindings/js/WebCoreTypedArrayController.cpp:
(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- dom/Document.cpp:
(WebCore::Document::ensurePlugInsInjectedScript):
- dom/Document.h:
- dom/DocumentStyleSheetCollection.cpp:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::ensureIsolatedWorld):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
- html/HTMLMediaElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::plugInImageElementIsolatedWorld):
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didClearWindowObjectInWorld):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
- inspector/InspectorPageAgent.h:
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchGlobalObjectAvailable):
- page/CaptionUserPreferencesMediaAF.cpp:
- page/DOMWindowExtension.cpp:
(WebCore::DOMWindowExtension::DOMWindowExtension):
- page/DOMWindowExtension.h:
(WebCore::DOMWindowExtension::create):
(WebCore::DOMWindowExtension::world):
- page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):
- page/Frame.h:
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
- page/PageGroup.h:
../WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientEfl.h:
../WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientGtk.h:
../WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
(-[WebFrame _globalContextForScriptWorld:]):
(-[WebFrame jsWrapperForNode:inScriptWorld:]):
- WebView/WebScriptWorld.mm:
(+[WebScriptWorld standardWorld]):
(+[WebScriptWorld findOrCreateWorld:]):
- WebView/WebScriptWorldInternal.h:
- WebView/WebView.mm:
(-[WebView _injectOutlookQuirksScript]):
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
../WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebScriptWorld.cpp:
(WebScriptWorld::standardWorld):
(WebScriptWorld::findOrCreateWorld):
- WebScriptWorld.h:
(WebScriptWorld::world):
../WebKit/wince:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientWinCE.h:
../WebKit2:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
(WebKit::InjectedBundleScriptWorld::getOrCreate):
(WebKit::InjectedBundleScriptWorld::normalWorld):
(WebKit::InjectedBundleScriptWorld::coreWorld):
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 9:43 AM Changeset in webkit [156768] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, removing references to the recently removed Modules/filesystem directory.
- GNUmakefile.am:
- 8:10 AM WebKitGTK/2.2.x edited by
- propose r156003 for 2.2.1 (diff)
- 6:07 AM Changeset in webkit [156767] by
-
- 47 edits5 copies103 deletes in trunk
[CSS Regions] Activate all regions to have layers, as CSS Regions create a new stacking context
https://bugs.webkit.org/show_bug.cgi?id=121828
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-02
Reviewed by Darin Adler.
Source/WebCore:
The CSS Regions specification says "CSS Regions create a new stacking context." (http://dev.w3.org/csswg/css-regions/).
Divs that create stacking contexts are painted after the divs that don't create stacking contexts.
Test: fast/regions/layers/stacking-context-paint-order.html: While the existing region-sibling-paint-order.html
test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
verifies that regions paint correctly when the next sibling doesn't create a stacking context.
- rendering/RenderBlock.cpp: Remove code that is not needed now that all regions have layers.
- rendering/RenderBlock.h: Remove code that is not needed now that all regions have layers.
- rendering/RenderBox.cpp: Remove code that is not needed now that all regions have layers.
- rendering/RenderBox.h: Remove code that is not needed now that all regions have layers.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Remove code that is not needed now that all regions have layers.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::requiresLayer): Always. CSS Regions create Stacking Contexts. RenderMultiColumnSet
implements its own behaviour so the behaviour of each class is contained within its own files.
- rendering/RenderMultiColumnSet.h:
(WebCore::RenderMultiColumnSet::requiresLayer): RenderMultiColumnSet derives from RenderRegion, but unlike the
CSS Regions specification, the Multi-Columns CSS specification states that the column boxes do not establish new
Stacking Contexts.
- rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderRegionList): There's no need to output " hasLayer" since all regions now have layers.
LayoutTests:
For the ref tests, the divs in the expected results coresponding to the regions now have a CSS style causing
them to also create Stacking Contexts.
Most of the tests in fast/regions/layers/ have been deleted because they aren't relevant anymore.
The change in most of the *-expected.txt files is that the " hasLayer" part has been removed (since all regions
now have layers).
Platform (efl, efl-wk2, gtk, mac-lion, mac-wk2, qt, qt-wk2) specific expectated results need to be generated again.
- fast/regions/autoheight-regions-mark-expected.txt:
- fast/regions/flow-content-basic-expected.html: Added. The test is now a ref test.
- fast/regions/flow-content-basic-vertical-expected.html: Added. The test is now a ref test.
- fast/regions/flow-content-basic-vertical-rl-expected.html: Added.The test is now a ref test.
- fast/regions/flow-content-basic-vertical-rl.html:
- fast/regions/flow-content-basic-vertical.html:
- fast/regions/flow-content-basic.html:
- fast/regions/flows-dependency-dynamic-remove-expected.txt:
- fast/regions/flows-dependency-same-flow-expected.txt:
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.png: Removed.
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
- fast/regions/layers/dynamic-layer-added-with-no-layout.html: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.png: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl.html: Removed.
- fast/regions/layers/regions-promoted-to-layers.html: Removed.
- fast/regions/layers/stacking-context-paint-order-expected.html: Added.
- fast/regions/layers/stacking-context-paint-order.html: Added. While the existing region-sibling-paint-order.html
test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
verifies that regions paint correctly when the next sibling doesn't create a stacking context.
- fast/regions/region-sibling-paint-order-expected.html:
- fast/regions/region-sibling-paint-order.html:
- fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- fast/repaint/region-painting-composited-element-expected.html:
- fast/repaint/region-painting-in-composited-view-expected.html:
- fast/repaint/region-painting-in-composited-view.html:
- fast/repaint/region-painting-via-layout-expected.txt:
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-expected.png: Removed. The test is now a ref test.
- platform/efl/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/region-dynamic-after-before-expected.txt:
- platform/efl/fast/regions/region-generated-content-before-after-expected.txt:
- platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/efl/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/efl/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/efl/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/gtk/TestExpectations:
- platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/gtk/fast/regions/region-dynamic-after-before-expected.txt:
- platform/gtk/fast/regions/region-generated-content-before-after-expected.txt:
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- platform/gtk/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/gtk/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/gtk/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/gtk/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/mac-lion/TestExpectations:
- platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- platform/mac/fast/regions/flow-content-basic-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/mac/fast/regions/region-dynamic-after-before-expected.txt:
- platform/mac/fast/regions/region-generated-content-before-after-expected.txt:
- platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
- platform/qt-wk2/TestExpectations:
- platform/qt-wk2/fast/regions/flow-content-basic-expected.png: Removed.
- platform/qt-wk2/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/qt-wk2/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/qt-wk2/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/qt-wk2/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/qt-wk2/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/qt-wk2/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/qt/TestExpectations:
- platform/qt/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- platform/qt/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/qt/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/qt/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/qt/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- 3:14 AM Changeset in webkit [156766] by
-
- 4 edits2 adds in trunk
HTML listbox is not resized horizontally when zooming
https://bugs.webkit.org/show_bug.cgi?id=20445
Reviewed by Darin Adler.
Source/WebCore:
If any style changes happens on a HTMLSelectElement, we need to set the m_optionsChanged property
of its renderer (RenderListBox) otherwise its size won't follow the changed content.
Test: fast/transforms/listbox-zoom.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::didRecalcStyle):
- html/HTMLSelectElement.h:
LayoutTests:
A test with a zoomed listbox is added to check whether the styleChange is catched.
- fast/transforms/listbox-zoom.html: Added.
- fast/transforms/listbox-zoom-expected.txt: Added.
- 2:32 AM Changeset in webkit [156765] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: highlight newly added console messages in the Activity Viewer
https://bugs.webkit.org/show_bug.cgi?id=122093
Reviewed by Joseph Pecoraro.
Fade the appropriate console log button in the Activity Viewer for a short duration
to call attention to it when its count is incremented. The animation may be restarted
in-flight if the count is incremented as we were pulsing the opacity.
- UserInterface/DashboardView.css:
(.toolbar .dashboard > .item.pulsing):
(@-webkit-keyframes console-item-pulse):
New pulse animation for a console item in the Activity Viewer, the new "pulsing" CSS
class is applied in WebInspector.DashboardView.prototype._setConsoleItemValue().
- UserInterface/DashboardView.js:
(WebInspector.DashboardView.prototype.set logs):
(WebInspector.DashboardView.prototype.set issues):
(WebInspector.DashboardView.prototype.set errors):
Refactor setters to use the new WebInspector.DashboardView.prototype._setConsoleItemValue()
method.
(WebInspector.DashboardView.prototype._setConsoleItemValue):
We now set the ivar backing console item values in this new refactored method and additionally
apply an animation to the DOM element for the given item if its value is incremented such that
it pulses, subtly calling out the developer's attention to it.
- UserInterface/Utilities.js:
New Element.prototype.recalculateStyles() method to abstract the hack required to force
a style recalc on a given element.
