Context Navigation

← Previous Period
Next Period →

Timeline

Oct 4, 2013:

11:54 PM Changeset in webkit [156950] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Fix an assertion failure introduced in r156925.

Add HTMLImageElement to the document-wide map only if it's in the document.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

11:40 PM Changeset in webkit [156949] by ap@apple.com

2 edits in trunk/Source/WebKit/mac

Don't preflight spell checker when calling -setContinuousSpellCheckingEnabled repeatedly
https://bugs.webkit.org/show_bug.cgi?id=122329

Reviewed by Darin Adler.

WebView/WebView.mm: (-[WebView setContinuousSpellCheckingEnabled:]): Don't do any

work if preference didn't change (continuousSpellCheckingEnabled is a static that
starts with false).

11:38 PM Changeset in webkit [156948] by Darin Adler

18 edits
2 adds in trunk

text-transform: lowercase is not lang-dependent (Turkish languages : tr,az)
https://bugs.webkit.org/show_bug.cgi?id=21312

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/text/text-transform-turkish-and-azeri.html

This patch covers text-transform: uppercase and text-transform: lowercase.
More changes will be needed to cover text-transform: capitalize.

inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchNode): Use String::upper instead of String::makeUpper.

page/EventHandler.cpp:

(WebCore::findDropZone): Use String::lower instead of String::makeLower.

platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Use String::upper instead of String::makeUpper.

platform/network/blackberry/rss/RSS10Parser.cpp: [Seriously, how is an RSS parser

part of WebKit's networking layer? Where are the tests that cover this? Seems wrong
to have this code in the project.]
(WebCore::RSS10Parser::parseXmlDoc): Use lower instead of makeLower.
(WebCore::RSS10Parser::parseItem): Ditto.
(WebCore::RSS10Parser::parseFeed): Ditto.

platform/network/blackberry/rss/RSS20Parser.cpp:

(WebCore::RSS20Parser::parseXmlDoc): Ditto.
(WebCore::RSS20Parser::parseItem): Ditto.
(WebCore::RSS20Parser::parseFeed): Ditto.
(WebCore::RSS20Parser::parseEnclosure): Ditto.

platform/network/blackberry/rss/RSSAtomParser.cpp:

(WebCore::RSSAtomParser::parseXmlDoc): Ditto.
(WebCore::RSSAtomParser::parseItem): Ditto.
(WebCore::RSSAtomParser::parseFeed): Ditto.
(WebCore::RSSAtomParser::parseLink): Ditto.
(WebCore::RSSAtomParser::parseContent): Ditto.
(WebCore::RSSAtomParser::parseAuthor): Ditto.
(WebCore::RSSAtomParser::parseCategory): Ditto.

platform/text/win/LocaleWin.cpp:

(WebCore::convertLocaleNameToLCID): Use String::lower instead of String::makeLower.

rendering/RenderText.cpp:

(WebCore::applyTextTransform): Use String::upper and String::lower instead of
String::makeUpper and String::makeLower, and also pass in the locale to each.

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod): Changed this so it doesn't call
upper just to return an already known string constant.

Source/WebKit/gtk:

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::doCommand): Use StringImpl::upper instead of
StringImpl::makeUpper.

Source/WTF:

wtf/text/StringImpl.cpp:

(WTF::StringImpl::upper): Removed an extra call that would unnecessarily reallocate
a StringImpl in the general non-ASCII case. Added an overload that takes a locale identifier.
(WTF::StringImpl::lower): Ditto.

wtf/text/StringImpl.h: Ditto.
wtf/text/WTFString.cpp:

(WTF::String::lower): Ditto.
(WTF::String::upper): Ditto.

wtf/text/WTFString.h: Ditto. Also deleted the makeLower and makeUpper functions since they

offer no advantages over the lower and upper functions. Also added a constructor that takes
a RefPtr<StringImpl> with move construction to help.

LayoutTests:

fast/text/text-transform-turkish-and-azeri-expected.html: Added.
fast/text/text-transform-turkish-and-azeri.html: Added.

11:32 PM Changeset in webkit [156947] by ap@apple.com

19 edits
8 deletes in trunk

Roll out r156930 and r156937, they caused 34 assertion failures on bots.

9:52 PM Changeset in webkit [156946] by andersca@apple.com

23 edits in trunk/Source

FramePolicyFunction should be an std::function
https://bugs.webkit.org/show_bug.cgi?id=122362

Reviewed by Darin Adler.

Source/WebCore:

This makes policy callback handling simpler inside WebKit.

loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchWillSubmitForm):

loader/EmptyClients.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

loader/FrameLoaderClient.h:
loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::checkContentPolicy):

Source/WebKit/efl:

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::callPolicyFunction):
(WebCore::FrameLoaderClientEfl::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchWillSubmitForm):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):

WebCoreSupport/FrameLoaderClientGtk.h:
webkit/webkitwebpolicydecision.cpp:

(webkit_web_policy_decision_use):
(webkit_web_policy_decision_ignore):
(webkit_web_policy_decision_download):

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):

Source/WebKit/win:

WebCoreSupport/WebFrameLoaderClient.cpp:

Source/WebKit2:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::didReceivePolicyDecision):

9:48 PM Changeset in webkit [156945] by akling@apple.com

6 edits in trunk/Source/WebCore

CTTE: IconController and IconLoader should have Frame& backpointer.
<https://webkit.org/b/122372>

Reviewed by Anders Carlsson.

Also slap IconLoader with FINAL glove.

9:30 PM Changeset in webkit [156944] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix after r156924

UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::platformInitialize):

9:24 PM Changeset in webkit [156943] by fpizlo@apple.com

2 edits in trunk/Tools

It should be even easier to run and debug a failing JSC stress test
https://bugs.webkit.org/show_bug.cgi?id=122337

Reviewed by Oliver Hunt.

If a test fails, you can now just say:

sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit

and get the reproduction. You don't have to set any environment variables like before.
Also if you want to debug the failing test you can now just say:

sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --

Broadly, any arguments passed to the reproduction script are prepended to the command to
run the test. This is sort of quirky and won't work for some tests (for example the
profiler tests run a ruby script that runs some other stuff) but it'll work for most of
them and that's good enough for now.

Scripts/run-jsc-stress-tests:

8:50 PM Changeset in webkit [156942] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: RenderScrollbar DOM owner is always an Element.
<https://webkit.org/b/122348>

Reviewed by Antti Koivisto.

When RenderScrollbar is owned by a DOM node, it's always Element.
Tighten the code a bit with this knowledge.

Also marked the class FINAL and beat it with the OVERRIDE stick.

8:34 PM Changeset in webkit [156941] by akling@apple.com

7 edits in trunk/Source/WebCore

TypingCommand helpers should take Document&.
<https://webkit.org/b/122370>

Reviewed by Anders Carlsson.

Instead of taking a Document* and immediately asserting that it's
non-null, just take Document&.

7:59 PM Changeset in webkit [156940] by rniwa@webkit.org

18 edits in trunk/Source/WebCore

Use more references instead of pointers in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=122368

Reviewed by Andreas Kling.

Use AtomicStringImpl& instead of AtomicString* or AtomicString& to eliminate
assertions and nullity checks.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):

dom/Document.cpp:

(WebCore::Document::addImageElementByLowercasedUsemap):
(WebCore::Document::removeImageElementByLowercasedUsemap):
(WebCore::Document::imageElementByLowercasedUsemap):

dom/Document.h:
dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesId):
(WebCore::keyMatchesName):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):
(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByName):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
(WebCore::DocumentOrderedMap::getAllElementsById):

dom/DocumentOrderedMap.h:

(WebCore::DocumentOrderedMap::containsSingle):
(WebCore::DocumentOrderedMap::contains):
(WebCore::DocumentOrderedMap::containsMultiple):

dom/Element.cpp:

(WebCore::Element::updateNameForTreeScope):
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForTreeScope):
(WebCore::Element::updateIdForDocument):
(WebCore::Element::updateLabel):

dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::notifyObserversInternal):

dom/IdTargetObserverRegistry.h:

(WebCore::IdTargetObserverRegistry::notifyObservers):

dom/TreeScope.cpp:

(WebCore::TreeScope::getElementById):
(WebCore::TreeScope::getAllElementsById):
(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::removeElementById):
(WebCore::TreeScope::getElementByName):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::removeElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::removeImageMap):
(WebCore::TreeScope::getImageMap):
(WebCore::TreeScope::addLabel):
(WebCore::TreeScope::removeLabel):
(WebCore::TreeScope::labelElementForId):

dom/TreeScope.h:

(WebCore::TreeScope::hasElementWithId):
(WebCore::TreeScope::containsMultipleElementsWithId):
(WebCore::TreeScope::hasElementWithName):
(WebCore::TreeScope::containsMultipleElementsWithName):

html/HTMLCollection.cpp:

(WebCore::HTMLCollection::namedItem):

html/HTMLDocument.cpp:

(WebCore::HTMLDocument::addDocumentNamedItem):
(WebCore::HTMLDocument::removeDocumentNamedItem):
(WebCore::HTMLDocument::addWindowNamedItem):
(WebCore::HTMLDocument::removeWindowNamedItem):

html/HTMLDocument.h:

(WebCore::HTMLDocument::documentNamedItem):
(WebCore::HTMLDocument::hasDocumentNamedItem):
(WebCore::HTMLDocument::documentNamedItemContainsMultipleElements):
(WebCore::HTMLDocument::windowNamedItem):
(WebCore::HTMLDocument::hasWindowNamedItem):
(WebCore::HTMLDocument::windowNamedItemContainsMultipleElements):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::parseAttribute):
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

7:06 PM Changeset in webkit [156939] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: PolicyChecker backpointer to Frame should be a reference.
<https://webkit.org/b/122354>

Reviewed by Anders Carlsson.

PolicyChecker is tied to the lifetime of FrameLoader, which in turn
is tied to the lifetime of Frame.

6:06 PM Changeset in webkit [156938] by akling@apple.com

3 edits in trunk/Source/WebCore

Editor should use reference-getting document() internally.
<https://webkit.org/b/122364>

Reviewed by Darin Adler.

Instead of grabbing at Editor::m_frame.document(), use the nice
Editor::document() helper that always returns a Document&.

Calling Editor methods on a Frame's editor() while there is no
Document in the Frame is a programming error and this is covered
by an assertion in document().

This removes a bunch of null checks and enables further cleanup.

6:03 PM Changeset in webkit [156937] by Martin Robinson

2 edits in trunk/Source/WebCore

Try to fix the Windows build after r156930.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::paintCharacter): Use ceilf and floorf to avoid issues
with overload collisions and implicit casts of LayoutUnits.

5:51 PM Changeset in webkit [156936] by mark.lam@apple.com

19 edits
8 adds in trunk

Change ScriptDebugServer to use DebuggerCallFrame instead of JavaScriptCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121969.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
DebuggerCallFrame's line() and column() now returns a base-zero int.
WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
Also removed evaluateInGlobalCallFrame() which is not used anywhere.

debugger/Debugger.cpp:
debugger/Debugger.h:
debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::callerFrame):
(JSC::DebuggerCallFrame::dynamicGlobalObject):
(JSC::DebuggerCallFrame::sourceId):
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::type):
(JSC::DebuggerCallFrame::thisValue):
(JSC::DebuggerCallFrame::evaluate):
(JSC::DebuggerCallFrame::evaluateWithCallFrame):
(JSC::DebuggerCallFrame::invalidate):
(JSC::DebuggerCallFrame::positionForCallFrame):
(JSC::DebuggerCallFrame::sourceIdForCallFrame):
(JSC::DebuggerCallFrame::thisValueForCallFrame):

debugger/DebuggerCallFrame.h:

(JSC::DebuggerCallFrame::create):
(JSC::DebuggerCallFrame::exec):
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
(JSC::DebuggerCallFrame::position):
(JSC::DebuggerCallFrame::isValid):

interpreter/StackVisitor.cpp:

Source/WebCore:

Tests: inspector-protocol/debugger/call-frame-function-name.html

inspector-protocol/debugger/call-frame-this-host.html
inspector-protocol/debugger/call-frame-this-nonstrict.html
inspector-protocol/debugger/call-frame-this-strict.html

Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
DebuggerCallFrame's line() and column() now returns a base-zero int.
WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
Also removed evaluateInGlobalCallFrame() which is not used anywhere.

bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::thisObject):

bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
(WebCore::JavaScriptCallFrame::caller):

bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::type):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::dynamicGlobalObject):
(WebCore::JavaScriptCallFrame::thisValue):
(WebCore::JavaScriptCallFrame::evaluate):

bindings/js/ScriptDebugServer.cpp:

(WebCore::DebuggerCallFrameScope::DebuggerCallFrameScope):
(WebCore::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::evaluateBreakpointAction):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::currentDebuggerCallFrame):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::updateCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):

bindings/js/ScriptDebugServer.h:
bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::willExecuteProgram):

Source/WebKit/mac:

Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
DebuggerCallFrame's line() and column() now returns a base-zero int.
WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
Also removed evaluateInGlobalCallFrame() which is not used anywhere.

WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFramePrivate dealloc]):
(-[WebScriptCallFrame _initWithGlobalObject:functionName:exceptionValue:JSC::]):
(-[WebScriptCallFrame functionName]):
(-[WebScriptCallFrame exception]):

WebView/WebScriptDebugger.mm:

(WebScriptDebugger::exception):

LayoutTests:

http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

inspector-protocol/debugger/call-frame-function-name-expected.txt: Added.
inspector-protocol/debugger/call-frame-function-name.html: Added.
inspector-protocol/debugger/call-frame-this-host-expected.txt: Added.
inspector-protocol/debugger/call-frame-this-host.html: Added.
inspector-protocol/debugger/call-frame-this-nonstrict-expected.txt: Added.
inspector-protocol/debugger/call-frame-this-nonstrict.html: Added.
inspector-protocol/debugger/call-frame-this-strict-expected.txt: Added.
inspector-protocol/debugger/call-frame-this-strict.html: Added.
inspector/debugger/pause-in-internal-script-expected.txt:

5:40 PM Changeset in webkit [156935] by Brent Fulgham

2 edits in trunk/Source/WTF

Remove Qt definitions from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=122349

Reviewed by Anders Carlsson.

wtf/Platform.h: Remove unused PLATFORM(QT) stanzas from file.

5:40 PM Changeset in webkit [156934] by Brent Fulgham

2 edits in trunk/Source/JavaScriptCore

Silence compiler warning when building 64-bit (on Windows)

Reviewed by Geoffrey Garen.

jit/JSInterfaceJIT.h: Add a static cast for assignment.

5:35 PM Changeset in webkit [156933] by Brent Fulgham

2 edits in trunk/Source/WTF

[Win] Turn off FastMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=122352

Reviewed by Darin Adler.

wtf/Platform.h: Enable USE_SYSTEM_MALLOC when building on

Windows to stick to the MSVCRT allocator/deallocator.

5:35 PM Changeset in webkit [156932] by akling@apple.com

18 edits in trunk/Source

Ref-ify more stack guards.
<https://webkit.org/b/122360>

Reviewed by Anders Carlsson.

Make another pass turning RefPtr<T> into Ref<T> where possible.

5:26 PM Changeset in webkit [156931] by mikhail.pozdnyakov@intel.com

4 edits in trunk/Source/WTF

Remove WTF smart pointers 'const_pointer_cast'
https://bugs.webkit.org/show_bug.cgi?id=122325

Reviewed by Darin Adler.

Removed WTF smart pointers 'const_pointer_cast' functions as:

they were not used
their implementation was wrong as they tried to cast to a different pointer type

wtf/PassOwnPtr.h:
wtf/PassRefPtr.h:
wtf/RefPtr.h:

5:08 PM Changeset in webkit [156930] by Martin Robinson

19 edits
8 adds in trunk

[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416

Source/WebCore:

Reviewed by David Hyatt.

Tests: mathml/presentation/mo-minus.html

mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html

MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.

Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.

With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.

css/mathml.css:

Not sure what this line-height:0 was here for, but it caused bugs with the new code

mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.

mathml/MathMLTextElement.h:

(MathMLTextElement):

rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):

rendering/mathml/RenderMathMLBlock.h:

Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.

rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.

(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout

(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.

rendering/mathml/RenderMathMLOperator.h: Update method declarations.

LayoutTests:

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.

Add some reftests for stretchy operators.

TestExpectations: The remaining MathML pixel tests are broken by this patch.
LayoutTests/platform/gtk/TestExpectations:
LayoutTests/platform/mac/TestExpectations:
LayoutTests/platform/win/TestExpectations:
mathml/presentation/mo-minus.html: Added.
mathml/presentation/mo-stacked-glyphs-expected.html: Added.
mathml/presentation/mo-stacked-glyphs.html: Added.
mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
mathml/presentation/mo-stretchy-vertical-bar.html: Added.
mathml/very-large-stretchy-operators-expected.txt: Added.
mathml/very-large-stretchy-operators.html: Added.

5:00 PM Changeset in webkit [156929] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Build fix after r156925. It collided with r156903.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):

4:58 PM Changeset in webkit [156928] by Brent Fulgham

2 edits in trunk/Tools

[Windows] Correct run-path when using 64-bit binaries.

Reviewed by David Kilzer.

Scripts/webkitdirs.pm:

(determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
directory. Otherwise use the existing 'bin32' directory.

4:47 PM Changeset in webkit [156927] by akling@apple.com

8 edits in trunk/Source/WebCore

Clean out some FrameLoaderClient hooks that no ports were using.
<https://webkit.org/b/122356>

Reviewed by Anders Carlsson.

Removed the following hooks that were leftovers from dead ports:

didExhaustMemoryAvailableForScript
didNotAllowScript
didNotAllowPlugins
willCheckAndDispatchMessageEvent
didChangeName
dispatchWillInsertBody
dispatchDidChangeResourcePriority

4:34 PM Changeset in webkit [156926] by Brent Fulgham

2 edits in trunk/Tools

Teach webkitdirs.pm to honor the --64-bit flag
https://bugs.webkit.org/show_bug.cgi?id=122357

Reviewed by David Kilzer.

Scripts/webkitdirs.pm:

(argumentsForConfiguration): Modify to check if --64-bit is supplied
by the user.
(findMatchingArguments): Added.
(hasArgument): Added.
(checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
findMatchingArguments subroutine.

4:33 PM Changeset in webkit [156925] by rniwa@webkit.org

8 edits in trunk/Source/WebCore

FocusController::advanceFocus spends a lot of time in HTMLMapElement::imageElement
https://bugs.webkit.org/show_bug.cgi?id=122313

Reviewed by Andreas Kling.

The bug was caused by HTMLMapElement::imageElement traversing the entire document to look for
the image element associated with a given map element. Because HTMLCollection used to find the
image element is not cached, it traversed the entire document on every area element we visit,
resulting in O(n^{2) behavior.}

Fixed the bug by adding the name-to-image-element map on document to avoid the traversal in
HTMLMapElement::imageElement.

dom/Document.cpp:

(WebCore::Document::addImageElementByLowercasedUsemap): Added.
(WebCore::Document::removeImageElementByLowercasedUsemap): Added.
(WebCore::Document::imageElementByLowercasedUsemap): Added.

dom/Document.h: Added m_imagesByUsemap.

dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesLowercasedUsemap): Added.
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap): Added.

dom/DocumentOrderedMap.h:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Update the name-to-usemap map. The code to parse
the usemap attribute and strip # was moved from HTMLMapElement::imageElement.
(WebCore::HTMLImageElement::insertedInto): Ditto.
(WebCore::HTMLImageElement::removedFrom): Ditto.
(WebCore::HTMLImageElement::matchesLowercasedUsemap): Added; called by DocumentOrderedMap.

html/HTMLImageElement.h:

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement): Call Document::imageElementByUsemap instead of
looking through all image elements in the document.

4:25 PM Changeset in webkit [156924] by weinig@apple.com

22 edits in trunk/Source

../WebCore: Unify rubberband control
https://bugs.webkit.org/show_bug.cgi?id=122341

Reviewed by Tim Horton.

Consolidates the two ways we were passing state about whether to rubber-band on a particular edge down to one.

WebCore.exp.in:
page/Page.cpp:
page/Page.h:
page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::isRubberBandInProgress):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::setCanRubberBandState):
(WebCore::ScrollingTree::rubberBandsAtLeft):
(WebCore::ScrollingTree::rubberBandsAtRight):
(WebCore::ScrollingTree::rubberBandsAtBottom):
(WebCore::ScrollingTree::rubberBandsAtTop):
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):

page/scrolling/ScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm:
page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::shouldRubberBandInDirection):

../WebKit2: Unify rubber-band control
https://bugs.webkit.org/show_bug.cgi?id=122341

Reviewed by Tim Horton.

Consolidates the two ways we were passing state about whether to rubber-band on a particular edge down to one.
Adds SPI to control whether you can rubber band on the left or right edge.
Add a linked-on-or-after check to control whether we use the legacy implicit rubber band control based on back/forward.

UIProcess/API/C/WKPage.cpp:

(WKPageRubberBandsAtLeft):
(WKPageSetRubberBandsAtLeft):
(WKPageRubberBandsAtRight):
(WKPageSetRubberBandsAtRight):
(WKPageRubberBandsAtBottom):
(WKPageSetRubberBandsAtBottom):

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::rubberBandsAtLeft):
(WebKit::WebPageProxy::setRubberBandsAtLeft):
(WebKit::WebPageProxy::rubberBandsAtRight):
(WebKit::WebPageProxy::setRubberBandsAtRight):
(WebKit::WebPageProxy::rubberBandsAtTop):
(WebKit::WebPageProxy::setRubberBandsAtTop):
(WebKit::WebPageProxy::rubberBandsAtBottom):
(WebKit::WebPageProxy::setRubberBandsAtBottom):

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::shouldUseLegacyImplicitRubberBandControl):
(WebKit::WebPageProxy::platformInitialize):

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

WebProcess/WebPage/EventDispatcher.h:
WebProcess/WebPage/EventDispatcher.messages.in:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

4:01 PM Changeset in webkit [156923] by Antoine Quint

5 edits in trunk/Source/WebInspectorUI

Web Inspector: pressing the Cmd key over a CSS property should underline it immediately (jump to definition mode)
https://bugs.webkit.org/show_bug.cgi?id=119012

Reviewed by Joseph Pecoraro.

We add an "enabled" state to the tokenTrackingController to indicate that we're interested
in tracking hovered tokens. The tokenTrackingController is now only enabled in the
CSSStyleDeclarationTextEditor when the Cmd key is pressed and in the SourceCodeTextEditor
when either the Cmd key is pressed (NonSymbolTokens mode) or when the debugger is paused
(JavaScriptExpression mode).

The tokenTrackingController is now smarter about how it tracks mouse events when it's enabled,
tracking "mouseenter" and "mouseleave" events to enable tracking allowing immediate detection of
tokens being hovered or no longer being hovered even with quick mouse movements. Additioanlly,
using the new top-level mouse coordinates tracking, we can detect a hovered token as soon as
it's being enabled to provide instant feedback to the user.

This new top-level mouse coordinates tracking couple with tracking of modifier keys also fixes
http://webkit.org/b/119011.

UserInterface/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateJumpToSymbolTrackingMode):
Highlight the last known hovered candidate's range as soon as the Cmd key is pressed and enable
the tokenTrackingController if we're dealing with a non-read-only editor. When the Cmd key is
released, disable the tokenTrackingController.

UserInterface/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController):
(WebInspector.CodeMirrorTokenTrackingController.prototype.get enabled):
(WebInspector.CodeMirrorTokenTrackingController.prototype.set enabled):
New enabled state for the tokenTrackingController which indicates whether it should be tracking
mouse events to track hovered tokens in the editor. Upon being enabled, the tokenTrackingController
looks up the mouse coordinates continuously tracked at the window level to check for a token
at the last known mouse coordinates in case we're already over a token that may be highlighted.

(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightLastHoveredRange):
New public method allowing to highlight the last know candidate range, if any. This is used from
editor code when the Cmd key is pressed and we want to force the last know candidate to be
highlighted.

(WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
(WebInspector.CodeMirrorTokenTrackingController.prototype._stopTracking):
Make these two methods private now that they're automatically called by the "mouseenter" and
"mouseleave" event handling when we're in the "enabled" state. Additionally, the public
"tracking" property has been removed since it is no longer useful to the developer.

(WebInspector.CodeMirrorTokenTrackingController.prototype.handleEvent):
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseLeft):
New handlers for the "mouseenter" and "mouseleave" events enabling tracking of hovered tokens.

(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseMovedOverEditor):
(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
Refactor _mouseMovedOverEditor() into two methods with the new _updateHoveredTokenInfo()
allowing to customize the mouse coordinates to be used since we may call
_updateHoveredTokenInfo() outside of the context of a mouse event (ie. a keypress event).

(WebInspector.CodeMirrorTokenTrackingController.prototype._windowLostFocus):
(WebInspector.CodeMirrorTokenTrackingController.prototype._resetTrackingStates):
New private method combining all the various states that need to be reset when tracking
is turned off, including the removal of the highlighted range if any. This is now called
when the window loses focus.

UserInterface/Main.js:

(WebInspector.loaded):
(WebInspector._mouseMoved):
Add a new window-level "mousemove" event handler to always track mouse coordinates and key modifier
states. This ensures that we may have the most accurate information possible for key modifiers and
allow code to query the last recorded mouse position in situations where it wouldn't be possible
to have dealt with a mouse event, as is the case when the tokenTrackingController just started tracking.

UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerEnabled):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._enableJumpToSymbolTrackingModeSettings):
(WebInspector.SourceCodeTextEditor.prototype._disableJumpToSymbolTrackingModeSettings):
Update the "enabled" state on the tokenTrackingController when it may have changed based
on those two conditions: we should have either an active debugger call frame or the
Cmd key should have been pressed. This ensures we only track hovered tokens as needed.

(WebInspector.SourceCodeTextEditor.prototype._updateJumpToSymbolTrackingMode):
Highlight the last known hovered candidate's range as soon as the Cmd key is pressed.

3:49 PM Changeset in webkit [156922] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: SubframeLoader backpointer to Frame should be a reference.
<https://webkit.org/b/122350>

Reviewed by Anders Carlsson.

SubframeLoader is tied to the lifetime of FrameLoader, which in turn
is tied to the lifetime of Frame.

3:46 PM Changeset in webkit [156921] by andersca@apple.com

7 edits in trunk/Source

Remove some unneeded code from WidgetMac
https://bugs.webkit.org/show_bug.cgi?id=122355

Reviewed by Dan Bernstein.

Source/WebCore:

Remove code to manage the visible rect, it's not needed anymore.

platform/Widget.h:
platform/mac/WidgetMac.mm:

(WebCore::Widget::~Widget):
(WebCore::Widget::setFrameRect):
(WebCore::Widget::setPlatformWidget):

Source/WebKit/mac:

Remove code to handle the visible rect changing, it's not needed anymore since we always put Netscape plug-ins into their own layers now.

Plugins/Hosted/WebHostedNetscapePluginView.mm:
Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm:

3:45 PM Changeset in webkit [156920] by oliver@apple.com

5 edits
1 add in trunk/LayoutTests

Update all the tests, and include new file.

3:45 PM Changeset in webkit [156919] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

FTL: Add support for ValueToInt32(bool(x))
https://bugs.webkit.org/show_bug.cgi?id=122346

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-04
Reviewed by Geoffrey Garen.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):

3:41 PM Changeset in webkit [156918] by dbates@webkit.org

24 edits
8 adds in trunk/Source

[iOS] Upstream disk image cache
https://bugs.webkit.org/show_bug.cgi?id=121985

Reviewed by Joseph Pecoraro.

Source/WebCore:

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::isUsingDiskImageCache):

loader/ResourceBuffer.h:
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::canUseDiskImageCache): Added.
(WebCore::CachedImage::useDiskImageCache): Added.

loader/cache/CachedImage.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::isSafeToMakePurgeable):
(WebCore::CachedResource::isUsingDiskImageCache): Added.

loader/cache/CachedResource.h:

(WebCore::CachedResource::canUseDiskImageCache): Added.
(WebCore::CachedResource::useDiskImageCache): Added.

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::flushCachedImagesToDisk): Added.
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):

loader/cache/MemoryCache.h:

(WebCore::MemoryCache::TypeStatistic::TypeStatistic):

loader/ios/DiskImageCacheClientIOS.h: Added.
loader/ios/DiskImageCacheIOS.h: Added.
loader/ios/DiskImageCacheIOS.mm: Added.
platform/Logging.h:
platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::~SharedBuffer):
(WebCore::SharedBuffer::isAllowedToBeMemoryMapped): Added.
(WebCore::SharedBuffer::allowToBeMemoryMapped): Added.
(WebCore::SharedBuffer::failedMemoryMap): Added.
(WebCore::SharedBuffer::markAsMemoryMapped): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallbackData): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::setMemoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::buffer):
(WebCore::SharedBuffer::getSomeData):

platform/SharedBuffer.h:

(WebCore::SharedBuffer::isMemoryMapped): Added.

platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::SharedBuffer):

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:
ios/WebCoreSupport/WebDiskImageCacheClientIOS.h: Added.
ios/WebCoreSupport/WebDiskImageCacheClientIOS.mm: Added.

Source/WebKit/mac:

Misc/WebCache.mm:

(+[WebCache statistics]):

WebView/WebDataSource.mm:

(BufferMemoryMapped): Added.
(-[WebDataSource _setAllowToBeMemoryMapped]): Added.
(-[WebDataSource setDataSourceDelegate:]): Added.
(-[WebDataSource dataSourceDelegate]): Added.
(-[WebDataSource dealloc]):

WebView/WebDataSourcePrivate.h: Declared private delegate

protocol, WebDataSourcePrivateDelegate.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences diskImageCacheEnabled]): Added.
(-[WebPreferences setDiskImageCacheEnabled:]): Added.
(-[WebPreferences diskImageCacheMinimumImageSize]): Added.
(-[WebPreferences setDiskImageCacheMinimumImageSize:]): Added.
(-[WebPreferences diskImageCacheMaximumCacheSize]): Added.
(-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Added.
(-[WebPreferences _diskImageCacheSavedCacheDirectory]): Added.
(-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Added.

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):

3:25 PM Changeset in webkit [156917] by ap@apple.com

2 edits in trunk/Tools

Update svn-config for new Visual Studio extensions
https://bugs.webkit.org/show_bug.cgi?id=122344

Reviewed by Brent Fulgham.

svn-config: Add new Visual Studio extensions.

3:25 PM Changeset in webkit [156916] by betravis@adobe.com

4 edits
2 adds in trunk

[CSS Shapes] Basic shapes should be animatable for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=122343

Reviewed by Dirk Schulze.

Source/WebCore:

Test: fast/shapes/shape-outside-floats/shape-outside-animation.html

Add shape outside to the list of animatable properties. The infrastructure
is already in place for animating basic shapes on shape-inside and clipping
paths. See https://bugs.webkit.org/show_bug.cgi?id=101854.

page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

LayoutTests:

Add tests checking that shape-outside basic shape values correctly tween
between values.

animations/resources/animation-test-helpers.js:

(getPropertyValue): Add shape-outside to list of properties that do not parse
with the default behavior.
(comparePropertyValue): Compare shape-outsides after parsing their shape notation.

fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-animation.html: Added.

3:22 PM Changeset in webkit [156915] by akling@apple.com

4 edits in trunk/Source/WebCore

Tighten typing in some RenderLayer code.
<https://webkit.org/b/122342>

Reviewed by Antti Koivisto.

Use tighter types instead of Node and RenderObject inside RenderLayer
where applicable.

2:59 PM Changeset in webkit [156914] by Manuel Rego Casasnovas

3 edits
6 adds in trunk/LayoutTests

[CSS Regions] Layout Tests for selecting text in 2 regions for other writing modes
https://bugs.webkit.org/show_bug.cgi?id=122327

Reviewed by Alexandru Chiculita.

Add versions for other writing modes (horizontal-bt, vertical-lr and
vertical-rl) for test
fast/regions/selection/selecting-text-in-2-regions.html.

fast/regions/resources/helper.js:

(selectContentByIdsVert): Add new method when selecting context in a
vertical writing mode.

fast/regions/resources/region-style.css: Add some new CSS classes for

vertical writing mode.

fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:

Added.

2:52 PM Changeset in webkit [156913] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Build fix.

1:46 PM Changeset in webkit [156912] by commit-queue@webkit.org

3 edits
2 adds in trunk

Inserting a JS generated keyframe animation shouldn't trigger a whole document style recalc
https://bugs.webkit.org/show_bug.cgi?id=119479

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-10-04
Reviewed by Antti Koivisto.

Change CSSStyleSheet::didMutateRules to not invalidate all node's styles when inserting a
@-webkit-keyframes rule, and to instead insert the rule directly into the StyleResolver.

Test: animation/keyframes-dynamic.html: adds and removes keyframe rules using JavaScript and
validates that the correct elements are animated.

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):

css/CSSStyleSheet.h:

1:37 PM Changeset in webkit [156911] by commit-queue@webkit.org

5 edits
1 add in trunk/Tools

Made WinLauncher have better error handling, crash reporting, and modifiability.
https://bugs.webkit.org/show_bug.cgi?id=122319

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-04
Reviewed by Brent Fulgham.

WinLauncher/WinLauncher.cpp:

(WinLauncherWebHost::didFailProvisionalLoadWithError):
Don't display the numerous "Cancelled" messages that are obviously from the user.
(createCrashReport): Added.
(dllLauncherEntryPoint):
Made main loop back into while loop and write a crash report if it crashes.

WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:

Added WinLauncherReplace.h.

WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:

Added linking to DbgHelp.lib.

WinLauncher/WinLauncherReplace.h:

Added to make modifying WinLauncher behaviour and appearance easy.
(processCrashDump): Added.

1:35 PM Changeset in webkit [156910] by oliver@apple.com

29 edits
11 adds in trunk

Support for-of syntax
https://bugs.webkit.org/show_bug.cgi?id=122339

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add support for for-of syntax to JSC. As part of doing this I had to make
us support unique empty strings as identifiers. In a follow on patch i'm
going to remove the distinction entirely as it's purely a complicating
separation.

Otherwise the logic here is fairly self-explanatory.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitCall):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::ForOfNode::emitBytecode):

jit/JITOperations.cpp:
parser/ASTBuilder.h:

(JSC::ASTBuilder::createForOfLoop):

parser/NodeConstructors.h:

(JSC::EnumerationNode::EnumerationNode):
(JSC::ForInNode::ForInNode):
(JSC::ForOfNode::ForOfNode):

parser/Nodes.h:
parser/Parser.cpp:

(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):

parser/Parser.h:

(JSC::Parser::isofToken):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createForOfLoop):

runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::arrayIteratorPrototypeIterate):

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::finishCreation):

runtime/ArrayPrototype.h:
runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

runtime/CommonIdentifiers.h:
runtime/Identifier.h:

(JSC::Identifier::from):

runtime/JSCJSValue.cpp:

(JSC::JSValue::dumpInContext):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunction):

runtime/PrivateName.h:

(JSC::PrivateName::PrivateName):

runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):

Source/WTF:

Update assertions and add a helper function to StringImpl
to save repeated unique or identifier calls.

wtf/text/StringImpl.h:

(WTF::StringImpl::isIdentifierOrUnique):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::setIsAtomic):

LayoutTests:

Add test cases for the one type that supports for-of so far

js/basic-for-of-expected.txt: Added.
js/basic-for-of.html: Added.
js/regress/for-of-iterate-array-entries.html: Added.
js/regress/for-of-iterate-array-keys.html: Added.
js/regress/for-of-iterate-array-values.html: Added.
js/regress/script-tests/for-of-iterate-array-entries.js: Added.

(foo):

js/regress/script-tests/for-of-iterate-array-keys.js: Added.

(foo):

js/regress/script-tests/for-of-iterate-array-values.js: Added.

(foo):

1:33 PM Changeset in webkit [156909] by zandobersek@gmail.com

6 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122275

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/fileapi/.

fileapi/Blob.idl:
fileapi/FileException.idl:
fileapi/FileList.idl:
fileapi/FileReader.idl:
fileapi/FileReaderSync.idl:

1:31 PM Changeset in webkit [156908] by zandobersek@gmail.com

47 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122271

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/dom/.

dom/CharacterData.idl:
dom/ChildNode.idl:
dom/ClientRectList.idl:
dom/Clipboard.idl:
dom/CompositionEvent.idl:
dom/CustomEvent.idl:
dom/DOMCoreException.idl:
dom/DOMImplementation.idl:
dom/DOMNamedFlowCollection.idl:
dom/DOMStringList.idl:
dom/DOMStringMap.idl:
dom/DataTransferItem.idl:
dom/DataTransferItemList.idl:
dom/DeviceMotionEvent.idl:
dom/DeviceOrientationEvent.idl:
dom/Document.idl:
dom/DocumentFragment.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Event.idl:
dom/EventException.idl:
dom/EventListener.idl:
dom/EventTarget.idl:
dom/KeyboardEvent.idl:
dom/MessageEvent.idl:
dom/MessagePort.idl:
dom/MouseEvent.idl:
dom/MutationEvent.idl:
dom/MutationObserver.idl:
dom/NamedNodeMap.idl:
dom/Node.idl:
dom/NodeFilter.idl:
dom/NodeIterator.idl:
dom/NodeList.idl:
dom/Range.idl:
dom/RangeException.idl:
dom/ShadowRoot.idl:
dom/Text.idl:
dom/TextEvent.idl:
dom/TouchEvent.idl:
dom/TouchList.idl:
dom/TreeWalker.idl:
dom/UIEvent.idl:
dom/WebKitNamedFlow.idl:
dom/WheelEvent.idl:

1:22 PM Changeset in webkit [156907] by zandobersek@gmail.com

12 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122269

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/xml/.

xml/DOMParser.idl:
xml/XMLHttpRequest.idl:
xml/XMLHttpRequestException.idl:
xml/XMLHttpRequestUpload.idl:
xml/XMLSerializer.idl:
xml/XPathEvaluator.idl:
xml/XPathException.idl:
xml/XPathExpression.idl:
xml/XPathNSResolver.idl:
xml/XPathResult.idl:
xml/XSLTProcessor.idl:

12:36 PM Changeset in webkit [156906] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

FTL::OSRExit::convertToForward() shouldn't misuse Operands<>::operator[]
https://bugs.webkit.org/show_bug.cgi?id=122336

Reviewed by Geoffrey Garen.

Changed code in change set r156900 to use the operand() accessor instead of operator[].

ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExit::convertToForward):

12:31 PM Changeset in webkit [156905] by betravis@adobe.com

4 edits
4 adds in trunk

[CSS Shapes] Shape Outside should relayout when set dynamically
https://bugs.webkit.org/show_bug.cgi?id=122197

Reviewed by Alexandru Chiculita.

Source/WebCore:

Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html

fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html

When shape outside is modified, dependent content needs to relayout. This patch
removes the float from the float lists and marks dependents for layout using
RenderBox::removeFloatingOrPositionedChildFromBlockLists(). This is the same
method used when switching from float: left to float: right and vice versa
(see RenderElement::styleWillChange).

rendering/RenderBox.cpp:

(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Mark shape-outside dependents
for layout.

rendering/RenderBox.h:

(WebCore::RenderBox::markShapeOutsideDependentsForLayout): Mark all the items that may be
affected by this shape-outside for relayout.

LayoutTests:

Test that a shape can be dynamically added, modified, or removed and that
content does a proper relayout.

fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html: Added.
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html: Added.

12:22 PM Changeset in webkit [156904] by Antti Koivisto

5 edits in trunk/Source/WebCore

Tighten markContainingBlocksForLayout
https://bugs.webkit.org/show_bug.cgi?id=122326

Reviewed by Anders Carlsson.

11:51 AM Changeset in webkit [156903] by akling@apple.com

98 edits in trunk/Source/WebCore

Node: removedFrom() and insertedInto() should use references.
<https://webkit.org/b/122315>

Reviewed by Anders Carlsson.

ContainerNode* -> ContainerNode&

11:41 AM Changeset in webkit [156902] by ap@apple.com

2 edits in trunk/Source/WebCore

Optimize strings copies in srcset parser
https://bugs.webkit.org/show_bug.cgi?id=121899

Patch by Romain Perier <Romain Perier> on 2013-10-04
Reviewed by Alexey Proskuryakov.

No new tests, covered by existing ones.

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseImagesWithScaleFromSrcsetAttribute): Don't copy
image.imageURL at each loop iteration, save indexes instead.
(WebCore::bestFitSourceForImageAttributes): Make a String for
the URL only when the corresponding candidate is chosen
by the selection algorithm. It reduces the number of copies
significantly and improves performance
(around 30% with the "Release" profile and 60% with the "Debug" one).

11:40 AM Changeset in webkit [156901] by g.czajkowski@samsung.com

14 edits
4 moves in trunk/LayoutTests

Tests added in r141354 erroneously assume correction suggestion to be in the context menu
https://bugs.webkit.org/show_bug.cgi?id=113742

Reviewed by Ryosuke Niwa.

Tests from r141354 erroneously assume that all WebKit ports populate
spell checking suggestion in the context menu.

Remove verification of spell checking suggestion and all context menu stuff from tests
that do that unnecessarily. Instead of that check whether spelling markers behave correctly,
for example, after deleting a text, double click or selecting a misspellings.

However, two tests are adapted to verify spell checking suggestions (their availability
rather than correctness, similarly to context-menu-suggestions.html).
Those are useful for ports which populate spelling suggestion in the context menu.

editing/spelling/resources/util.js:

(initSpellTest):
Do not assume that the tests are running with "Windows" editing behavior.
Unix ports do not make a selection for the misspelled word and they don't
require selection to get spell checking suggestions.

editing/spelling/spelling-changed-text-expected.txt:
editing/spelling/spelling-changed-text.html:
editing/spelling/spelling-double-clicked-word-expected.txt:
editing/spelling/spelling-double-clicked-word.html:
editing/spelling/spelling-exactly-selected-word-expected.txt:
editing/spelling/spelling-exactly-selected-word.html:

Remove verification of correction suggestion.
Instead of that check whether the spelling markers behave correctly.

editing/spelling/context-menu-suggestions-multiword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection-expected.txt.
editing/spelling/context-menu-suggestions-multiword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection.html.
editing/spelling/context-menu-suggestions-subword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-subword-selection-expected.txt.
editing/spelling/context-menu-suggestions-subword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-subword-selection.html.

Adapt those tests for platforms which populate spell check suggestion
in the context menu.

platform/efl-wk2/TestExpectations:

Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for EFL.

platform/gtk-wk2/TestExpectations:
platform/gtk/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

Update tests path due to rename.

11:38 AM Changeset in webkit [156900] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

FTL: Crash in OSRExit::convertToForward() using VirtualRegister.offset() as array index
https://bugs.webkit.org/show_bug.cgi?id=122332

Reviewed by Oliver Hunt.

Changed the uses of .offset(), which returns a negative number for locals, to be
toLocal() which returns a local's ordinal number.

ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExit::convertToForward):

11:34 AM Changeset in webkit [156899] by dpranke@chromium.org

2 edits in trunk/Tools

remove dpranke from webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=122331

Reviewed by Brent Fulgham.

Scripts/webkitpy/common/config/watchlist:

11:30 AM Changeset in webkit [156898] by timothy_horton@apple.com

3 edits in trunk/Tools

[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299

Reviewed by Beth Dakin.

TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:

The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.

11:26 AM Changeset in webkit [156897] by ap@apple.com

2 edits in trunk/Tools

Watchlist is broken after <http://trac.webkit.org/r156880>

Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.

11:20 AM Changeset in webkit [156896] by msaboff@apple.com

11 edits in trunk/Source/JavaScriptCore

Add callOperation to Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122306

Reviewed by Geoffrey Garen.

Created baseline JIT compatible versions for a few flavors of callOperation().
Migrated cti_op_new_regexp() and its caller to callOperation(operationNewRegexp()).

dfg/DFGOperations.cpp: Moved operationNewRegexp() to JITOperations
dfg/DFGOperations.h:
jit/JIT.h:

(JSC::JIT::appendCall):

jit/JITInlines.h:

(JSC::JIT::appendCallWithExceptionCheck):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::callOperation):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_regexp):

jit/JITOperations.cpp:
jit/JITOperations.h:
jit/JITStubs.cpp:
jit/JITStubs.h:
jit/JSInterfaceJIT.h:

11:20 AM Changeset in webkit [156895] by Brent Fulgham

29 edits
3 deletes in trunk/Tools

Remove Qt features from build and test tools
https://bugs.webkit.org/show_bug.cgi?id=122312

Reviewed by Anders Carlsson.

Scripts/build-dumprendertree:
Scripts/build-jsc:
Scripts/build-webkit:
Scripts/build-webkittestrunner:
Scripts/old-run-webkit-tests:

(openDumpTool):
(buildPlatformResultHierarchy):
(buildPlatformTestHierarchy):
(readSkippedFiles):

Scripts/run-launcher:
Scripts/run-qtwebkit-tests: Removed.
Scripts/run-webkit-tests:

(useNewRunWebKitTests):

Scripts/update-webkit:
Scripts/webkit-build-directory:
Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(setupCygwinEnv):
(copyInspectorFrontendFiles):
(setPathForRunningWebKitApp):

Scripts/webkitpy/common/checkout/baselineoptimizer.py:
Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_virtual_ports_filtered):

Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_reviewer_text):

Scripts/webkitpy/common/config/watchlist:
Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):

Scripts/webkitpy/port/base.py:

(Port.init):
(Port._port_flag_for_scripts):
(Port._wk2_port_name):

Scripts/webkitpy/port/builders.py:
Scripts/webkitpy/port/factory.py:

(platform_options):
(PortFactory):
(PortFactory._default_port):

Scripts/webkitpy/port/factory_unittest.py:

(FactoryTest.test_gtk):

Scripts/webkitpy/port/qt.py: Removed.
Scripts/webkitpy/port/qt_unittest.py: Removed.
Scripts/webkitpy/style/checker.py:
Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

Scripts/webkitpy/style/checkers/cmake.py:

(CMakeChecker):

Scripts/webkitpy/style/checkers/cpp.py:

(_classify_include):
(check_include_line):
(check_identifier_name_in_declaration):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_classify_include):
(WebKitStyleTest.test_names):

Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_determine_port_from_expectations_path):

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):

Scripts/webkitpy/tool/main.py:

(WebKitPatch):

10:00 AM Changeset in webkit [156894] by ap@apple.com

2 edits in trunk/Source/WebCore

Add svn:ignore to *.pyc files in inspector/Scripts directory, so that they don't
show up as unversioned all the time.

inspector/Scripts: Added property svn:ignore.

9:15 AM Changeset in webkit [156893] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Win][WebGL] Crash on exit
https://bugs.webkit.org/show_bug.cgi?id=120764

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-04
Reviewed by Martin Robinson.

On exit, libGLESv2.dll is detached from the process and relevant memory is released
before the atexit GL context cleanup handler is called, causing a NULL pointer crash.
The GL context cleanup code was originally written to avoid a X server crash on exit,
so it's only needed for PLATFORM(X11).

platform/graphics/GLContext.cpp: Only clean up active GL contexts on exit for PLATFORM(X11).

(WebCore::GLContext::cleanupSharedX11Display):
(WebCore::GLContext::cleanupActiveContextsAtExit):
(WebCore::GLContext::GLContext):
(WebCore::GLContext::~GLContext):

9:14 AM Changeset in webkit [156892] by commit-queue@webkit.org

6 edits in trunk

[GTK] Enable text edition UndoOperations support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122305

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.

GNUmakefile.list.am:
UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):

UIProcess/API/gtk/PageClientImpl.h:

LayoutTests:

platform/gtk-wk2/TestExpectations: Corrected the expectations

with the new results.

9:02 AM Changeset in webkit [156891] by mihnea@adobe.com

6 edits
2 adds in trunk

[CSSRegions] Regions as stacking contexts should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122321

Reviewed by Alexandru Chiculita.

Source/WebCore:

Test: fast/regions/layers/region-normalflow-stacking-context.html

Since regions are stacking contexts, they should not be in normal flow list of layers.
More clean-up after https://bugs.webkit.org/show_bug.cgi?id=117365 and https://bugs.webkit.org/show_bug.cgi?id=121828
which enabled the layers.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

LayoutTests:

Add a new test and modify existing tests to take into account the stacking context behavior
for non-positioned regions.

fast/regions/autoheight-regions-mark-expected.txt:
fast/regions/layers/region-normalflow-stacking-context-expected.html: Added.
fast/regions/layers/region-normalflow-stacking-context.html: Added.
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:

8:26 AM Changeset in webkit [156890] by andersca@apple.com

3 edits
1 delete in trunk/Source/WebKit

Remove WebAssertions.h
https://bugs.webkit.org/show_bug.cgi?id=122328

Reviewed by Jessie Berlin.

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Misc/WebAssertions.h: Removed.

8:22 AM Changeset in webkit [156889] by Michał Pakuła vel Rutka

3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Remove failure expectations from tests that are passing.

platform/efl-wk2/TestExpectations: update js/dom/create-lots-of-workers.html path.
platform/efl/TestExpectations:

7:22 AM Changeset in webkit [156888] by commit-queue@webkit.org

4 edits in trunk

[EFL] Enable correct behaviour for deleting regional indicator symbols
https://bugs.webkit.org/show_bug.cgi?id=122209

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-04
Reviewed by Gyuyoung Kim.

Source/WebCore:

Regional indicator symbols that are combined should behave as a single character when deleting.
Removed unused variable initialState.

rendering/RenderText.cpp:

(WebCore::RenderText::previousOffsetForBackwardDeletion):

LayoutTests:

Now editing/deleting/regional-indicators.html is passing on EFL port.

platform/efl/TestExpectations:

7:16 AM Changeset in webkit [156887] by commit-queue@webkit.org

12 edits in trunk/Source/WebKit2

Remove Qt leftovers from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122317

Patch by Sergio Correia <Sergio Correia> on 2013-10-04
Reviewed by Anders Carlsson.

Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):

Shared/API/c/WKBase.h:
Shared/NativeWebTouchEvent.h:
UIProcess/API/C/WebKit2_C.h:
UIProcess/BackingStore.h:
UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::inspectorUrlForPageID):

UIProcess/InspectorServer/WebInspectorServer.h:
UIProcess/InspectorServer/WebSocketServer.cpp:
UIProcess/InspectorServer/WebSocketServer.h:
UIProcess/WebPageProxy.cpp:
WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitializeWindowless):
(WebKit::NetscapePlugin::platformPaint):

5:23 AM Changeset in webkit [156886] by zandobersek@gmail.com

21 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122276

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/css/.

css/CSSHostRule.idl:
css/CSSMediaRule.idl:
css/CSSPrimitiveValue.idl:
css/CSSRuleList.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleSheet.idl:
css/CSSSupportsRule.idl:
css/CSSValueList.idl:
css/DOMWindowCSS.idl:
css/FontLoader.idl:
css/MediaList.idl:
css/MediaQueryList.idl:
css/MediaQueryListListener.idl:
css/StyleMedia.idl:
css/StyleSheet.idl:
css/StyleSheetList.idl:
css/WebKitCSSFilterValue.idl:
css/WebKitCSSKeyframesRule.idl:
css/WebKitCSSMatrix.idl:
css/WebKitCSSTransformValue.idl:

4:59 AM Changeset in webkit [156885] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122274

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/loader/appcache/.

loader/appcache/DOMApplicationCache.idl:

4:55 AM Changeset in webkit [156884] by zandobersek@gmail.com

4 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/plugins/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122273

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/plugins/.

plugins/DOMMimeTypeArray.idl:
plugins/DOMPlugin.idl:
plugins/DOMPluginArray.idl:

4:51 AM Changeset in webkit [156883] by zandobersek@gmail.com

3 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122272

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/storage/.

storage/Storage.idl:
storage/StorageEvent.idl:

4:41 AM Changeset in webkit [156882] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122270

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/workers/.

workers/DedicatedWorkerGlobalScope.idl:
workers/Worker.idl:
workers/WorkerGlobalScope.idl:
workers/WorkerLocation.idl:

1:49 AM Changeset in webkit [156881] by abucur@adobe.com

5 edits
2 adds in trunk

[CSS Regions] Infinite loop when computing widows
https://bugs.webkit.org/show_bug.cgi?id=122215

Reviewed by David Hyatt.

Source/WebCore:

The patch ensures it's not possible to relayout a block indefinitely because of widows contraints. You can't
break a block more than once to account for widows. This can happen if, for example, some lines are moved
to the next container and there the content breaks in another container again without respecting the widows property.
This is in line with the idea of not leaving empty fragmentation containers during layout.

Test: fast/regions/regions-widows-stack-overflow.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):

rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData): Rename the m_shouldBreakAtLineToAvoidWidow
flag to m_didBreakAtLineToAvoidWidow.

(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow): Use the line index to determine if it should break or not.
(WebCore::RenderBlockFlow::didBreakAtLineToAvoidWidow): Use to determine if a break already happened because of widows.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

LayoutTests:

Test there is no stack overflow when trying to break for widows that are caused by other widows.

fast/regions/regions-widows-stack-overflow-expected.html: Added.
fast/regions/regions-widows-stack-overflow.html: Added.

Oct 3, 2013:

11:05 PM Changeset in webkit [156880] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

Unreviewed. Add myself to some watchlists.

Scripts/webkitpy/common/config/watchlist:

9:42 PM Changeset in webkit [156879] by andersca@apple.com

2 edits in trunk/Source/WebCore

Assert that we don't try to index past the end of the m_coreTextIndices array
https://bugs.webkit.org/show_bug.cgi?id=122308

Reviewed by Dan Bernstein.

Because an assertion failure is better than a random crash.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextRun::indexAt):

9:38 PM Changeset in webkit [156878] by andersca@apple.com

4 edits
2 deletes in trunk/Source/WebKit

Remove WebNSNotificationCenterExtras
https://bugs.webkit.org/show_bug.cgi?id=122316

Reviewed by Dan Bernstein.

Source/WebKit:

Update Xcode project.

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Use dispatch_async to ensure that notifications are posted on the main thread.

Misc/WebIconDatabase.mm:

(-[WebIconDatabase _sendNotificationForURL:]):
(-[WebIconDatabase _sendDidRemoveAllIconsNotification]):

Misc/WebNSNotificationCenterExtras.h: Removed.
Misc/WebNSNotificationCenterExtras.m: Removed.

9:11 PM Changeset in webkit [156877] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r155787): WebKitTestRunner rebuilds from scratch when doing an incremental build

Reviewed by Dan Bernstein.

WebKit2.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status

indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination. This avoids updating the modification date of the file when it has not changed.

9:04 PM Changeset in webkit [156876] by Antti Koivisto

69 edits in trunk/Source/WebCore

Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256

Reviewed by Andreas Kling.

These bits never apply to RenderText nodes:

normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout

The code for setting them can be moved to RenderElement.

Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.

8:42 PM Changeset in webkit [156875] by Lucas Forschler

2 edits in tags/Safari-538.1.2/Source/ThirdParty/ANGLE

Merged r156870. <rdar://problem/15116673>

8:21 PM Changeset in webkit [156874] by Lucas Forschler

5 edits in tags/Safari-538.1.2/Source

Versioning.

8:19 PM Changeset in webkit [156873] by mrowe@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build

The change in r156811 resulted in several public headers in the JavaScriptCore framework having their modification
date touched on every build, even if their contents had not changed. This resulted in a large portion of WebCore
needing to rebuilt after an incremental build of JavaScriptCore.

Reviewed by Dan Bernstein.

JavaScriptCore.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status

indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination.

8:19 PM Changeset in webkit [156872] by Lucas Forschler

1 copy in tags/Safari-538.1.2

New Tag.

8:08 PM Changeset in webkit [156871] by weinig@apple.com

23 edits in trunk/Source

Remove shouldRubberBandInDirection from the WKBundlePageUIClient
https://bugs.webkit.org/show_bug.cgi?id=122309

Reviewed by Andreas Kling.

../WebCore:

loader/EmptyClients.h:
page/ChromeClient.h:
page/FrameView.cpp:
page/FrameView.h:
platform/ScrollableArea.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):

../WebKit/efl:

WebCoreSupport/ChromeClientEfl.h:

../WebKit/gtk:

WebCoreSupport/ChromeClientGtk.h:

../WebKit/mac:

WebCoreSupport/WebChromeClient.h:

../WebKit/win:

WebCoreSupport/WebChromeClient.h:

../WebKit/wince:

WebCoreSupport/ChromeClientWinCE.h:

../WebKit2:

WKBundlePageUIClient's shouldRubberBandInDirection has never worked with
threaded scrolling, so remove it.

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:
WebProcess/WebCoreSupport/WebChromeClient.h:

5:43 PM Changeset in webkit [156870] by mitz@apple.com

2 edits in trunk/Source/ThirdParty/ANGLE

<rdar://problem/15116673> [mac] Build failure when the source directory is not named ANGLE
https://bugs.webkit.org/show_bug.cgi?id=122307

Reviewed by Mark Rowe.

ANGLE.xcodeproj/project.pbxproj: Ensure that the symlink to SRCROOT in

DerivedSources/ANGLE is named ANGLE.

4:38 PM Changeset in webkit [156869] by Christophe Dumez

11 edits in trunk

Fix the HTMLSelectElement.prototype.remove() method
https://bugs.webkit.org/show_bug.cgi?id=121586

Reviewed by Darin Adler.

Source/WebCore:

Fix the HTMLSelectElement.prototype.remove() method so that it behaves like
Element.remove() if no argument is passed (from ChildNode). This behavior
is consistent with Firefox and Blink.

See https://www.w3.org/Bugs/Public/show_bug.cgi?id=20720 for more
information.

Tests: js/dom/select-options-remove.html

bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::remove):
Stop calling JSHTMLSelectElement::remove() blindly as it is dangerous, especially
now that calling it without argument now detaches the element. Instead, have the
bindings call the corresponding methods on the HTMLOptionsCollection implementation
object, as it should.

bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::remove):
Call Element::remove() if no argument is given.

html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::remove):

html/HTMLOptionsCollection.h:
html/HTMLSelectElement.cpp:
html/HTMLSelectElement.h:

Rename remove(int) to removeByIndex(int) to avoid conflict with
Node::remove(ExceptionCode&).

LayoutTests:

Add test to make sure calling HTMLSelectElement.prototype.remove() detaches the
select element from its parent, as Element::remove() would.

js/dom/select-options-remove-expected.txt:
js/resources/select-options-remove.js:

4:31 PM Changeset in webkit [156868] by rniwa@webkit.org

1 edit
1 delete in trunk/LayoutTests

Re-remove Qt TestExpectations re-added in r156841 after r156866.

platform/qt: Removed.
platform/qt/TestExpectations: Removed.

4:29 PM Changeset in webkit [156867] by commit-queue@webkit.org

8 edits
2 adds in trunk

Regression: AX: <table><caption> no longer exposed as AXTitle.
https://bugs.webkit.org/show_bug.cgi?id=121977

Patch by Samuel White <Samuel White> on 2013-10-03
Reviewed by Darin Adler.

Source/WebCore:

Some cleanup of accessibilityText. Notably, subclasses were unnecessarily redeclaring this method as both private and
protected. Added OVERRIDE keyword to these subclasses as needed. Moved titleElementText to virtual so we can do subclass
overrides in cases like this bug. That is, AccessibilityTable can leverage the existing machinery for alternativeText,
visibleText, and helpText, but we do some custom work ONLY in titleElementText.

Test: accessibility/table-title.html

accessibility/AccessibilityImageMapLink.h:
accessibility/AccessibilityMediaControls.h:
accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::titleElementText):

accessibility/AccessibilityNodeObject.h:
accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::titleElementText):

accessibility/AccessibilityTable.h:

LayoutTests:

Added test to verify that table elements correctly derive their AXTitle from their associated caption element.

accessibility/table-title-expected.txt: Added.
accessibility/table-title.html: Added.

4:24 PM Changeset in webkit [156866] by rniwa@webkit.org

5 edits in trunk/Tools

Remove Qt builders from the flakiness dashboard.

TestResultServer/static-dashboards/builders.jsonp:
TestResultServer/static-dashboards/flakiness_dashboard.js:
TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
TestResultServer/static-dashboards/loader_unittests.js:

4:18 PM Changeset in webkit [156865] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

Add a testcase for a bug that I had during the development. This code uses the asm.js style.
https://bugs.webkit.org/show_bug.cgi?id=122286

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Filip Pizlo.

js/regress/asmjs_bool_bug-expected.txt: Added.
js/regress/asmjs_bool_bug.html: Added.
js/regress/script-tests/asmjs_bool_bug.js: Added.

(strlen):

4:10 PM Changeset in webkit [156864] by timothy_horton@apple.com

4 edits in trunk/Tools

[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299

Reviewed by Beth Dakin.

TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:

Disable threaded scrolling.

TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:

Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.

4:03 PM Changeset in webkit [156863] by Brent Fulgham

2 edits in trunk/Source/JavaScriptCore

[Win] Unreviewed gardening.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Clean up the

paths for various files added outside of Visual Studio. They are all
displayed in the root of the project, rather than the proper sub-folder.

3:54 PM Changeset in webkit [156862] by Brent Fulgham

6 edits in trunk/Source

../JavaScriptCore: [Win] Update solutions and projects to support 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=122225

Reviewed by Anders Carlsson.

Revise ordering of CPU(X86) and CPU(X86_64) tests, because MSVC always defines
both when targeting a 64-bit build.

JavaScriptCore.vcxproj/JavaScriptCore.submit.sln: Add an x64 target

for 64-bit builds.

../WTF: [Win] Update solutions and projects to support 64-bit build.
https://bugs.webkit.org/show_bug.cgi?id=122225

Reviewed by Anders Carlsson.

WTF.vcxproj/WTF.submit.sln: Add x64 architecture targets.
WTF.vcxproj/WTF.vcxproj: Correct path to config.h file.
WTF.vcxproj/WTF.vcxproj.filters: Correct path to config.h file.

3:52 PM Changeset in webkit [156861] by commit-queue@webkit.org

10 edits
4 copies in trunk/Source/WebKit2

Create CoordinatedDrawingArea / CoordinatedDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=122207

Patch by Sergio Correia <Sergio Correia> on 2013-10-03
Reviewed by Anders Carlsson.

Since Apple are moving away from DrawingAreaImpl, Coordinated Graphics
should have its own drawing area.

CMakeLists.txt: Use CoordinatedDrawingArea and

CoordinatedDrawingAreaProxy instead of the DrawingAreaImpl /
DrawingAreaProxyImpl.

Shared/DrawingAreaInfo.h: Add DrawingAreaTypeCoordinated.
UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

Added, copied from DrawingAreaProxyImpl.cpp.

UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Added,

copied from DrawingAreaProxyImpl.h.

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::createDrawingAreaProxy): Use CoordinatedDrawingAreaProxy.

UIProcess/DrawingAreaProxyImpl.cpp: Remove Coordinated Graphics

bits.

UIProcess/DrawingAreaProxyImpl.h: Ditto.
WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

Added, copied from DrawingAreaImpl.cpp.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:

Added, copied from DrawingAreaImpl.h.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush): Use
CoordinatedDrawingArea.

WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create): Handle the DrawingAreaTypeCoordinated
in the DrawingArea creation code.

WebProcess/WebPage/DrawingAreaImpl.cpp: Remove Coordinated Graphics

bits.

WebProcess/WebPage/DrawingAreaImpl.h: Ditto.

3:15 PM Changeset in webkit [156860] by andersca@apple.com

30 edits in trunk/Source

Ignore deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=122302

Reviewed by Mark Rowe.

Source/WebCore:

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):

bindings/objc/DOMHTML.mm:

(-[DOMHTMLInputElement _rectOnScreen]):

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):

page/mac/FrameSnapshottingMac.mm:

(WebCore::imageFromRect):

platform/graphics/mac/IconMac.mm:

(WebCore::Icon::Icon):

platform/mac/DragImageMac.mm:

(WebCore::scaleDragImage):

platform/mac/PlatformEventFactoryMac.mm:

(WebCore::globalPoint):

platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformContentsToScreen):
(WebCore::ScrollView::platformScreenToContents):

Source/WebKit/mac:

Misc/WebIconDatabase.mm:

(-[WebIconDatabase _scaleIcon:toSize:]):
(webGetNSImage):

Misc/WebNSImageExtras.m:

(-[NSImage _web_scaleToMaxSize:]):
(-[NSImage _web_dissolveToFraction:]):

Misc/WebNSViewExtras.m:

(-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]):
(-[NSView _web_convertRect:toView:]):

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::mouseEvent):

Plugins/Hosted/WebTextInputWindowController.m:

(-[WebTextInputPanel _interpretKeyEvent:string:]):

Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):

WebCoreSupport/WebDragClient.mm:

(WebDragClient::startDrag):

WebInspector/WebNodeHighlight.mm:

(-[WebNodeHighlight _computeHighlightWindowFrame]):

WebView/WebFullScreenController.mm:

(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

WebView/WebHTMLView.mm:

(+[WebHTMLView _postFlagsChangedEvent:]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _autoscroll]):
(-[WebHTMLView mouseDown:]):
(-[WebHTMLView mouseDragged:]):
(-[WebHTMLView mouseUp:]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _executeSavedKeypressCommands]):
(-[WebHTMLView attachRootLayer:]):
(-[WebHTMLView textStorage]):
(-[WebHTMLView _updateSelectionForInputManager]):

WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController _buildUI]):
(-[WebTextCompletionController _placePopupWindow:]):

Source/WebKit2:

Shared/mac/WebEventFactory.mm:

(WebKit::globalPoint):

UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::setFindIndicator):

UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::windowToScreen):

UIProcess/API/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):

UIProcess/API/mac/WKView.mm:

(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:actualRange:]):
(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):
(-[WKView _setDragImage:at:linkDrag:]):
(-[WKView performDictionaryLookupAtCurrentMouseLocation]):

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):

UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu):

UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu):

2:46 PM Changeset in webkit [156859] by andersca@apple.com

2 edits in trunk/Tools

Use numeric strings in the OS version dictionary
https://bugs.webkit.org/show_bug.cgi?id=122300

Reviewed by Mark Rowe.

Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._determine_mac_version):

2:14 PM Changeset in webkit [156858] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Eliminate unused JITStub function declarations
https://bugs.webkit.org/show_bug.cgi?id=122288

Reviewed by Geoffrey Garen.

Removed unused JITStub declarations.

jit/JITStubs.h:

2:07 PM Changeset in webkit [156857] by Manuel Rego Casasnovas

3 edits
2 adds in trunk/LayoutTests

[CSS Regions] Layout Test for selecting text in 2 regions
https://bugs.webkit.org/show_bug.cgi?id=121841

Reviewed by Alexandru Chiculita.

Add new reftest for selecting text in 2 regions. It compares the
behavior (highlighted text and selected content) in regions and absolute
positions.

fast/regions/resources/helper.js: Add new function to set selected

content in an element onmouseup.
(onMouseUpLogSelection.document.onmouseup):
(onMouseUpLogSelection):

fast/regions/resources/region-style.css: Define some styles that could

be reused in other tests.

fast/regions/selection/selecting-text-in-2-regions-expected.html:

Added.

fast/regions/selection/selecting-text-in-2-regions.html: Added.

1:49 PM Changeset in webkit [156856] by Lucas Forschler

5 edits in tags/Safari-538.1.1/Source

Versioning.

1:44 PM Changeset in webkit [156855] by Lucas Forschler

1 copy in tags/Safari-538.1.1

New Tag.

1:44 PM Changeset in webkit [156854] by ap@apple.com

2 edits in trunk/Tools

Fix LeaksViewer to load leaks results from MountainLion, not Lion.

Rubber-stamped by Tim Horton.

BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer._displayURLPrompt):

1:36 PM Changeset in webkit [156853] by ap@apple.com

2 edits in trunk/LayoutTests

Flaky Test: fast/history/history-back-while-pdf-in-pagecache.html
https://bugs.webkit.org/show_bug.cgi?id=121628

platform/mac/TestExpectations: Marking as such.

1:04 PM Changeset in webkit [156852] by hmuller@adobe.com

3 edits
4 adds in trunk

[CSS Shapes] Support the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122254

Reviewed by Andreas Kling.

Source/WebCore:

Replace the hardwired 0 Shape::createShape() threshold parameter with the style's
shapeImageThreshold() value (which has been clamped to [0,1]).

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html

fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html

rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape):

LayoutTests:

Verify that a shape-outside image whose pixels' alpha channels are all above shape-image-threshold causes
layout to skirt the shape, and similarly that an image whose pixels' alpha channels are all below the threshold
has no effect on the layout.

fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html: Added.

1:00 PM Changeset in webkit [156851] by hmuller@adobe.com

7 edits
1 copy
1 delete in trunk/LayoutTests

[CSS Shapes] Revise the CSS property parsing tests
https://bugs.webkit.org/show_bug.cgi?id=122251

Reviewed by Andreas Kling.

Flattened the shapes CSS property parsing tests by inserting the code from
the fast/shapes/parsing/script-tests subdirectory into the test HTML source
files. The subdirectory is now empty and the tests are easier to read.

fast/shapes/parsing/parsing-shape-image-threshold.html: Inserted parsing-shape-image-threshold.js instead of referring to it with script src.
fast/shapes/parsing/parsing-shape-inside.html: Likewise
fast/shapes/parsing/parsing-shape-lengths.html: Likewise
fast/shapes/parsing/parsing-shape-margin.html: Likewise
fast/shapes/parsing/parsing-shape-outside.html: Likewise
fast/shapes/parsing/parsing-shape-padding.html: Likewise
fast/shapes/parsing/parsing-test-utils.js: Renamed from LayoutTests/fast/shapes/parsing/script-tests/parsing-test-utils.js.

(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
(property):

fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Removed.
fast/shapes/parsing/script-tests/parsing-shape-inside.js: Removed.
fast/shapes/parsing/script-tests/parsing-shape-lengths.js: Removed.
fast/shapes/parsing/script-tests/parsing-shape-margin.js: Removed.
fast/shapes/parsing/script-tests/parsing-shape-outside.js: Removed.
fast/shapes/parsing/script-tests/parsing-shape-padding.js: Removed.

12:53 PM Changeset in webkit [156850] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

[CSS Regions] Follow-up code style change after bug #121828 All regions have layers
https://bugs.webkit.org/show_bug.cgi?id=122265

Patch by Mihai Maerean <Mihai Maerean> on 2013-10-03
Reviewed by Darin Adler.

Comments moved to the cpp file, as requested in the review of bug #121828 All regions have layers.

No new tests, no behavior change.

rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::requiresLayer):

rendering/RenderMultiColumnSet.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::requiresLayer):

rendering/RenderRegion.h:

12:52 PM Changeset in webkit [156849] by ap@apple.com

2 edits in trunk/LayoutTests

video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803

I'm not quite sure what's going on, but [ Pass Failure ] expectations didn't cut it.
Trying [ Pass ImageOnlyFailure ], as the failures are always image only anyway.

platform/mac/TestExpectations:

12:48 PM Changeset in webkit [156848] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[cairo] Initialize the m_compositorTexture in GraphicsContext3DCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=122285

Patch by Alejandro G. Castro <alex@igalia.com> on 2013-10-03
Reviewed by Noam Rosenthal.

Initialize to the default texture to avoid the random texture name
and generate the texture name.

platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize
m_compositorTexture.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Delete the
generated textures names.

platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Generate the texture
names for m_compositorTexture and m_texture.

11:38 AM Changeset in webkit [156847] by andersca@apple.com

41 edits in trunk/Source/WebKit2

Remove the last remnants of Qt from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122290

Reviewed by Andreas Kling.

Platform/PlatformProcessIdentifier.h:
Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

Shared/Downloads/Download.cpp:

(WebKit::Download::Download):

Shared/Downloads/Download.h:
Shared/Downloads/DownloadManager.cpp:
Shared/Downloads/DownloadManager.h:
Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

Shared/EditorState.h:

(WebKit::EditorState::EditorState):

Shared/LayerTreeContext.h:
Shared/NativeWebKeyboardEvent.h:
Shared/NativeWebMouseEvent.h:
Shared/NativeWebWheelEvent.h:
Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):

Shared/PlatformPopupMenuData.h:
Shared/ShareableBitmap.h:
Shared/WebPreferencesStore.h:
UIProcess/Downloads/DownloadProxy.cpp:
UIProcess/Downloads/DownloadProxy.h:
UIProcess/PageClient.h:
UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):

UIProcess/WebContext.cpp:

(WebKit::WebContext::download):

UIProcess/WebFullScreenManagerProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::showPopupMenu):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebPopupMenuProxy.h:
WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/WebCoreSupport/WebDragClient.cpp:
WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::willSetInputMethodState):
(WebKit::WebEditorClient::supportsGlobalSelection):

WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldFallBack):

WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::didChangeSelectedIndex):

WebProcess/WebCoreSupport/WebPopupMenu.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::editorState):
(WebKit::WebPage::performDragControllerAction):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:
config.h:

11:24 AM Changeset in webkit [156846] by zoltan@webkit.org

7 edits
10 adds in trunk

[CSS Shapes] Support block content with inline content around floats in shape-inside
https://bugs.webkit.org/show_bug.cgi?id=121616

Reviewed by David Hyatt.

In r156022 and r156364, I added support for floats inside shape-inside with inline content. This change extends
the existing implementation to support block content with inline content (paragraphs). I added an extra text for
positioning a float inside shape-inside without text content around it.

Source/WebCore:

Tests: fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html

fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html

rendering/FloatingObjects.h:

(WebCore::FloatingObject::logicalSize): Add new function to return the FloatingObject logical size.

rendering/LineWidth.cpp:

(WebCore::LineWidth::fitBelowFloats): When the lineBreaker code pushes down the content below the floating object,
we need to update the segments if we are in a shape-inside.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat): Do the positioning based on the float actual size, and use the
recent shapeInsideInfo. (Calling layoutShapeInsideInfo which deals with the layoutStates also instead of shapeInsideInfo.)

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): If we don't have inline content we still need to positionize
our float content in a shape-inside.
(WebCore::updateSegmentsForShapes): Use the right coordinates for block content with inline content.

LayoutTests:

fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Added.
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html: Added.

11:06 AM Changeset in webkit [156845] by andersca@apple.com

1 edit
247 deletes in trunk/Source/WebKit2

Remove Qt files from WebKit2.

Rubber-stomped by Andreas Kling.

DerivedSources.pri: Removed.
PluginProcess.pro: Removed.
PluginProcess/qt/PluginControllerProxyQt.cpp: Removed.
PluginProcess/qt/PluginProcessMainQt.cpp: Removed.
PluginProcess/qt/PluginProcessQt.cpp: Removed.
SandboxProcess.pro: Removed.
Shared/API/c/qt/WKImageQt.cpp: Removed.
Shared/API/c/qt/WKImageQt.h: Removed.
Shared/Downloads/qt/DownloadQt.cpp: Removed.
Shared/Downloads/qt/QtFileDownloader.cpp: Removed.
Shared/Downloads/qt/QtFileDownloader.h: Removed.
Shared/qt/ArgumentCodersQt.cpp: Removed.
Shared/qt/ArgumentCodersQt.h: Removed.
Shared/qt/LayerTreeContextQt.cpp: Removed.
Shared/qt/NativeWebKeyboardEventQt.cpp: Removed.
Shared/qt/NativeWebMouseEventQt.cpp: Removed.
Shared/qt/NativeWebTouchEventQt.cpp: Removed.
Shared/qt/NativeWebWheelEventQt.cpp: Removed.
Shared/qt/PlatformCertificateInfo.h: Removed.
Shared/qt/ProcessExecutablePathQt.cpp: Removed.
Shared/qt/QtNetworkReplyData.cpp: Removed.
Shared/qt/QtNetworkReplyData.h: Removed.
Shared/qt/QtNetworkRequestData.cpp: Removed.
Shared/qt/QtNetworkRequestData.h: Removed.
Shared/qt/ShareableBitmapQt.cpp: Removed.
Shared/qt/WebCoreArgumentCodersQt.cpp: Removed.
Shared/qt/WebEventFactoryQt.cpp: Removed.
Shared/qt/WebEventFactoryQt.h: Removed.
Shared/qt/WebURLRequestQt.cpp: Removed.
Shared/qt/WebURLResponseQt.cpp: Removed.
Target.pri: Removed.
UIProcess/API/C/qt/WKIconDatabaseQt.cpp: Removed.
UIProcess/API/C/qt/WKIconDatabaseQt.h: Removed.
UIProcess/API/C/qt/WKNativeEvent.h: Removed.
UIProcess/API/cpp/qt/WKStringQt.cpp: Removed.
UIProcess/API/cpp/qt/WKStringQt.h: Removed.
UIProcess/API/cpp/qt/WKURLQt.cpp: Removed.
UIProcess/API/cpp/qt/WKURLQt.h: Removed.
UIProcess/API/qt/qquicknetworkreply.cpp: Removed.
UIProcess/API/qt/qquicknetworkreply_p.h: Removed.
UIProcess/API/qt/qquicknetworkrequest.cpp: Removed.
UIProcess/API/qt/qquicknetworkrequest_p.h: Removed.
UIProcess/API/qt/qquickurlschemedelegate.cpp: Removed.
UIProcess/API/qt/qquickurlschemedelegate_p.h: Removed.
UIProcess/API/qt/qquickwebpage.cpp: Removed.
UIProcess/API/qt/qquickwebpage_p.h: Removed.
UIProcess/API/qt/qquickwebpage_p_p.h: Removed.
UIProcess/API/qt/qquickwebview.cpp: Removed.
UIProcess/API/qt/qquickwebview_p.h: Removed.
UIProcess/API/qt/qquickwebview_p_p.h: Removed.
UIProcess/API/qt/qtwebsecurityorigin.cpp: Removed.
UIProcess/API/qt/qtwebsecurityorigin_p.h: Removed.
UIProcess/API/qt/qwebdownloaditem.cpp: Removed.
UIProcess/API/qt/qwebdownloaditem_p.h: Removed.
UIProcess/API/qt/qwebdownloaditem_p_p.h: Removed.
UIProcess/API/qt/qwebiconimageprovider.cpp: Removed.
UIProcess/API/qt/qwebiconimageprovider_p.h: Removed.
UIProcess/API/qt/qwebkittest.cpp: Removed.
UIProcess/API/qt/qwebkittest_p.h: Removed.
UIProcess/API/qt/qwebloadrequest.cpp: Removed.
UIProcess/API/qt/qwebloadrequest_p.h: Removed.
UIProcess/API/qt/qwebnavigationhistory.cpp: Removed.
UIProcess/API/qt/qwebnavigationhistory_p.h: Removed.
UIProcess/API/qt/qwebnavigationhistory_p_p.h: Removed.
UIProcess/API/qt/qwebnavigationrequest.cpp: Removed.
UIProcess/API/qt/qwebnavigationrequest_p.h: Removed.
UIProcess/API/qt/qwebpermissionrequest.cpp: Removed.
UIProcess/API/qt/qwebpermissionrequest_p.h: Removed.
UIProcess/API/qt/qwebpreferences.cpp: Removed.
UIProcess/API/qt/qwebpreferences_p.h: Removed.
UIProcess/API/qt/qwebpreferences_p_p.h: Removed.
UIProcess/API/qt/raw/qrawwebview.cpp: Removed.
UIProcess/API/qt/raw/qrawwebview_p.h: Removed.
UIProcess/API/qt/raw/qrawwebview_p_p.h: Removed.
UIProcess/API/qt/tests/bytearraytestdata.cpp: Removed.
UIProcess/API/qt/tests/bytearraytestdata.h: Removed.
UIProcess/API/qt/tests/html/basic_page.html: Removed.
UIProcess/API/qt/tests/html/basic_page2.html: Removed.
UIProcess/API/qt/tests/html/bluesquare.html: Removed.
UIProcess/API/qt/tests/html/direct-image-compositing.html: Removed.
UIProcess/API/qt/tests/html/inputmethod.html: Removed.
UIProcess/API/qt/tests/html/redsquare.html: Removed.
UIProcess/API/qt/tests/html/resources/qwkview_noBackground1.png: Removed.
UIProcess/API/qt/tests/html/resources/qwkview_noBackground3.png: Removed.
UIProcess/API/qt/tests/html/resources/qwkview_paint.png: Removed.
UIProcess/API/qt/tests/html/resources/simple_image.png: Removed.
UIProcess/API/qt/tests/html/scroll.html: Removed.
UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Removed.
UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Removed.
UIProcess/API/qt/tests/publicapi/publicapi.pro: Removed.
UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp: Removed.
UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Removed.
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Removed.
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Removed.
UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView.pro: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_findText.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_messaging.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Removed.
UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml: Removed.
UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Removed.
UIProcess/API/qt/tests/qmltests/common/alert.html: Removed.
UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Removed.
UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Removed.
UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Removed.
UIProcess/API/qt/tests/qmltests/common/colorChooser.html: Removed.
UIProcess/API/qt/tests/qmltests/common/confirm.html: Removed.
UIProcess/API/qt/tests/qmltests/common/download.zip: Removed.
UIProcess/API/qt/tests/qmltests/common/evaluatejavascript.html: Removed.
UIProcess/API/qt/tests/qmltests/common/favicon.html: Removed.
UIProcess/API/qt/tests/qmltests/common/favicon.png: Removed.
UIProcess/API/qt/tests/qmltests/common/favicon2.html: Removed.
UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Removed.
UIProcess/API/qt/tests/qmltests/common/geolocation.html: Removed.
UIProcess/API/qt/tests/qmltests/common/javascript.html: Removed.
UIProcess/API/qt/tests/qmltests/common/link.html: Removed.
UIProcess/API/qt/tests/qmltests/common/localStorage.html: Removed.
UIProcess/API/qt/tests/qmltests/common/messaging.html: Removed.
UIProcess/API/qt/tests/qmltests/common/multifileupload.html: Removed.
UIProcess/API/qt/tests/qmltests/common/notification.html: Removed.
UIProcess/API/qt/tests/qmltests/common/prompt.html: Removed.
UIProcess/API/qt/tests/qmltests/common/qrctest.html: Removed.
UIProcess/API/qt/tests/qmltests/common/redirect.html: Removed.
UIProcess/API/qt/tests/qmltests/common/select.html: Removed.
UIProcess/API/qt/tests/qmltests/common/selectwithsize.html: Removed.
UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Removed.
UIProcess/API/qt/tests/qmltests/common/small-favicon.png: Removed.
UIProcess/API/qt/tests/qmltests/common/test1.html: Removed.
UIProcess/API/qt/tests/qmltests/common/test2.html: Removed.
UIProcess/API/qt/tests/qmltests/common/test3.html: Removed.
UIProcess/API/qt/tests/qmltests/common/test4.html: Removed.
UIProcess/API/qt/tests/qmltests/common/test5.html: Removed.
UIProcess/API/qt/tests/qmltests/common/titleupdate.js: Removed.
UIProcess/API/qt/tests/qmltests/qmltests.pro: Removed.
UIProcess/API/qt/tests/qmltests/resources.qrc: Removed.
UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Removed.
UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Removed.
UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Removed.
UIProcess/API/qt/tests/qrawwebview/qrawwebview.pro: Removed.
UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp: Removed.
UIProcess/API/qt/tests/tests.pri: Removed.
UIProcess/API/qt/tests/testwindow.h: Removed.
UIProcess/API/qt/tests/util.cpp: Removed.
UIProcess/API/qt/tests/util.h: Removed.
UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Removed.
UIProcess/InspectorServer/qt/WebSocketServerQt.cpp: Removed.
UIProcess/InspectorServer/qt/WebSocketServerQt.h: Removed.
UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Removed.
UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Removed.
UIProcess/qt/BackingStoreQt.cpp: Removed.
UIProcess/qt/PageViewportControllerClientQt.cpp: Removed.
UIProcess/qt/PageViewportControllerClientQt.h: Removed.
UIProcess/qt/QtDialogRunner.cpp: Removed.
UIProcess/qt/QtDialogRunner.h: Removed.
UIProcess/qt/QtDownloadManager.cpp: Removed.
UIProcess/qt/QtDownloadManager.h: Removed.
UIProcess/qt/QtGestureRecognizer.cpp: Removed.
UIProcess/qt/QtGestureRecognizer.h: Removed.
UIProcess/qt/QtPageClient.cpp: Removed.
UIProcess/qt/QtPageClient.h: Removed.
UIProcess/qt/QtPanGestureRecognizer.cpp: Removed.
UIProcess/qt/QtPanGestureRecognizer.h: Removed.
UIProcess/qt/QtPinchGestureRecognizer.cpp: Removed.
UIProcess/qt/QtPinchGestureRecognizer.h: Removed.
UIProcess/qt/QtTapGestureRecognizer.cpp: Removed.
UIProcess/qt/QtTapGestureRecognizer.h: Removed.
UIProcess/qt/QtWebContext.cpp: Removed.
UIProcess/qt/QtWebContext.h: Removed.
UIProcess/qt/QtWebError.cpp: Removed.
UIProcess/qt/QtWebError.h: Removed.
UIProcess/qt/QtWebIconDatabaseClient.cpp: Removed.
UIProcess/qt/QtWebIconDatabaseClient.h: Removed.
UIProcess/qt/QtWebPageEventHandler.cpp: Removed.
UIProcess/qt/QtWebPageEventHandler.h: Removed.
UIProcess/qt/QtWebPagePolicyClient.cpp: Removed.
UIProcess/qt/QtWebPagePolicyClient.h: Removed.
UIProcess/qt/QtWebPageSGNode.cpp: Removed.
UIProcess/qt/QtWebPageSGNode.h: Removed.
UIProcess/qt/QtWebPageUIClient.cpp: Removed.
UIProcess/qt/QtWebPageUIClient.h: Removed.
UIProcess/qt/TextCheckerQt.cpp: Removed.
UIProcess/qt/WebColorPickerQt.cpp: Removed.
UIProcess/qt/WebColorPickerQt.h: Removed.
UIProcess/qt/WebContextMenuProxyQt.cpp: Removed.
UIProcess/qt/WebContextMenuProxyQt.h: Removed.
UIProcess/qt/WebContextQt.cpp: Removed.
UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Removed.
UIProcess/qt/WebGeolocationProviderQt.cpp: Removed.
UIProcess/qt/WebGeolocationProviderQt.h: Removed.
UIProcess/qt/WebInspectorProxyQt.cpp: Removed.
UIProcess/qt/WebPageProxyQt.cpp: Removed.
UIProcess/qt/WebPopupMenuProxyQt.cpp: Removed.
UIProcess/qt/WebPopupMenuProxyQt.h: Removed.
UIProcess/qt/WebPreferencesQt.cpp: Removed.
UIProcess/qt/WebProcessProxyQt.cpp: Removed.
WebKit2.pri: Removed.
WebKit2.pro: Removed.
WebProcess.pro: Removed.
WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Removed.
WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Removed.
WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Removed.
WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: Removed.
WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Removed.
WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: Removed.
WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: Removed.
WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp: Removed.
WebProcess/WebPage/qt/WebInspectorQt.cpp: Removed.
WebProcess/WebPage/qt/WebPageQt.cpp: Removed.
WebProcess/qt/QtBuiltinBundle.cpp: Removed.
WebProcess/qt/QtBuiltinBundle.h: Removed.
WebProcess/qt/QtBuiltinBundlePage.cpp: Removed.
WebProcess/qt/QtBuiltinBundlePage.h: Removed.
WebProcess/qt/QtNetworkAccessManager.cpp: Removed.
WebProcess/qt/QtNetworkAccessManager.h: Removed.
WebProcess/qt/QtNetworkReply.cpp: Removed.
WebProcess/qt/QtNetworkReply.h: Removed.
WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Removed.
WebProcess/qt/SeccompFiltersWebProcessQt.h: Removed.
WebProcess/qt/WebProcessMainQt.cpp: Removed.
WebProcess/qt/WebProcessQt.cpp: Removed.
qt/MainQt.cpp: Removed.
qt/PluginMainQt.cpp: Removed.

11:05 AM Changeset in webkit [156844] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Add test expectation for one more test having color space issues after r156793.
(css3/filters/custom/custom-filter-composite-fractional-source-alpha.html)

platform/mac-wk2/TestExpectations:

10:58 AM Changeset in webkit [156843] by ap@apple.com

2 edits in trunk/LayoutTests

Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126

platform/mac/TestExpectations: Marked it as such.

10:55 AM Changeset in webkit [156842] by beidson@apple.com

10 edits in trunk/Source

Move IDBFactoryBackend creation to DatabaseStrategy.
https://bugs.webkit.org/show_bug.cgi?id=122284

Reviewed by Alexey Proskuryakov.

Source/WebCore:

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:

Modules/indexeddb/IDBFactory.h:
Modules/indexeddb/IDBFactoryBackendInterface.cpp:

(WebCore::IDBFactoryBackendInterface::create):

platform/DatabaseStrategy.cpp:

(WebCore::DatabaseStrategy::createIDBFactoryBackend): Implement a default.

platform/DatabaseStrategy.h:

Source/WebKit2:

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Fallback to the default for now.

WebProcess/WebCoreSupport/WebPlatformStrategies.h:

10:45 AM Changeset in webkit [156841] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

Re-add Qt TestExpectations. Without it, the flakiness dashboard page loads as blank.

platform/qt: Added.
platform/qt/TestExpectations: Added.

10:29 AM Changeset in webkit [156840] by mitz@apple.com

2 edits in trunk/Tools

REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260

Reviewed by Alexey Proskuryakov.

For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.

TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:

10:24 AM Changeset in webkit [156839] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile error with VIDEO disabled.
https://bugs.webkit.org/show_bug.cgi?id=122266

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-03
Reviewed by Brent Fulgham.

dom/Document.cpp:

(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Protect with ENABLE(VIDEO) guard.

10:20 AM Changeset in webkit [156838] by hmuller@adobe.com

6 edits
6 adds in trunk

[CSS Shapes] add shape-margin support for image valued shapes
https://bugs.webkit.org/show_bug.cgi?id=121619

Reviewed by Alexandru Chiculita.

Source/WebCore:

Add support for computing the shape-margin boundary for a shape-outside whose
value is an image.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html

fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html

rendering/shapes/RasterShape.cpp:

(WebCore::MarginIntervalGenerator::MarginIntervalGenerator): Internal utility that generates the margin intervals for the image interval specified with set().
(WebCore::MarginIntervalGenerator::set):
(WebCore::MarginIntervalGenerator::intervalAt):
(WebCore::findInsertionPoint): Find the insertion point index for the the specified X value, within a vector of intervals sorted by X1.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Destructively unite one interval with an existing one, or append it.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals):
(WebCore::RasterShape::marginIntervals): Return the lazily computed value, or create it with computeShapeMarginIntervals().

rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::getIntervals):
(WebCore::RasterShape::RasterShape):
(WebCore::RasterShapeIntervals::uniteMarginInterval):

WTF/wtf/MathExtras.h: Added clampToUnsigned() inline.

LayoutTests:

Verify that the shape-outside margin-boundary is computed correctly for image valued shapes.

fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html: Added.

10:12 AM Changeset in webkit [156837] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[EFL] [DEBUG] JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122267

Patch by Sergio Correia <Sergio Correia> on 2013-10-03
Reviewed by Michael Saboff.

Build fails due to an expression containing comparison between signed
and unsigned integer.

llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions): Add cast to avoid signed vs.
unsigned comparison warning.

9:02 AM Changeset in webkit [156836] by mihnea@adobe.com

3 edits in trunk/Source/WebCore

[CSSRegions] Remove unused RenderLayerModelObject::updateLayerIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=122262

Reviewed by Alexandru Chiculita.

All regions have layers by default therefore there is no need for this function.
No tests needed, just a minor cleanup.

rendering/RenderLayerModelObject.cpp:
rendering/RenderLayerModelObject.h:

8:21 AM Changeset in webkit [156835] by mario@webkit.org

10 edits in trunk

[ATK] Expose aria-invalid as a text attribute (not object attribute)
https://bugs.webkit.org/show_bug.cgi?id=122015

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the aria-invalid attribute correctly through a text
attribute (through the AtkText interface) instead of using an
object, according to what the WAI-ARIA specs says.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property

This will be tested by accesibility/aria-invalid.html, which should
keep passing after thanks to the changes done in the DRT and WKTR.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::invalidStatus): Update this method
to only return values recognized by the WAI-ARIA specification.

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject): Expose aria-invalid as a
custom text attribute 'invalid', following the lead of Firefox.
Also register that custom attribute as a AtkTextAttribute.

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Remove exposure of aria-invalid
as an object attribute from here.

Tools:

Adapted DRT and WKTR to check the exposure of the aria-invalid
attribute as a text attribute, instead of an object attribute.

Also, done some refactoring of the code to try to keep things
simpler and more coherent, by defining new helper functions,
simplifying code, moving static variables and functions into
unnammed namespaces and so on, without altering the logic other
than for checking the text attribute for aria-invalid.

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(coreAttributeToAtkAttribute): Consider 'invalid' as the name of
the attribute exposed by the ATK wrapper, not 'aria-invalid'.
Also, never return an empty string if not falling through any of
the cases checked here, and return the original attribute instead.
(atkAttributeValueToCoreAttributeValue): New helper function to
match the attributes values returned by the ATK wrapper with the
values expected by the layout tests. Moved the mappings for the
values of AXSortDirection here as well.
(getAttributeSet): New helper function to retrieve a list of
attributes (an AtkAttributeSet) from an AtkObject using the right
API depending on whether we want the object attributes or the text
attributes (in case the object implements AtkText).
(getAttributeSetValueForId): Simplified by using getAttributeSet
and atkAttributeValueToCoreAttributeValue. Also, added a new
parameter to indicater whether we are interested in object
attributes or text attributes.
(getAtkAttributeSetAsString): Ditto.
(attributesOfElement): Updated to pass the new required parameter
to getAtkAttributeSetAsString, indicating that we want the object
attributes in this case, for backwards compatibility.
(indexRangeInTable): Moved up in the file into the unnammed namespace.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::stringAttributeValue): After moving most
of the code here to the new helper functions, simplified it by
just checking whether the required attribute is provided as an
object attribute or, if that's not the case, as a text attribute.
(AccessibilityUIElement::isAttributeSupported): Ditto.
(AccessibilityUIElement::intValue): Updated to pass the new
required parameter to getAttributeSetValueForId, indicating that
we want the object attributes in this case.
(AccessibilityUIElement::hasPopup): Ditto.

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
(WTR::atkAttributeValueToCoreAttributeValue): Ditto.
(WTR::getAttributeSet): Ditto.
(WTR::getAttributeSetValueForId): Ditto.
(WTR::getAtkAttributeSetAsString): Ditto.
(WTR::attributesOfElement): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.

LayoutTests:

Updated the aria-invalid.html layout test to make sure that it
behaves as defined by the WAI-ARIA specification for values other
than 'false', 'true', 'grammar' and 'spelling'.

accessibility/aria-invalid.html: Updated test.
accessibility/aria-invalid-expected.txt: Updated expectations.

8:05 AM Changeset in webkit [156834] by Lucas Forschler

5 edits in branches/safari-537.73-branch/Source

Versioning.

8:03 AM Changeset in webkit [156833] by Lucas Forschler

1 copy in tags/Safari-537.73.1

New Tag.

3:19 AM Changeset in webkit [156832] by rniwa@webkit.org

1 edit
2 copies in trunk/LayoutTests

Add back .htaccess files erroneously removed in r156827.

http/tests/appcache/resources/intercept: Copied from LayoutTests/http/tests/appcache/resources/intercept.
http/tests/uri/intercept: Copied from LayoutTests/http/tests/uri/intercept.

2:30 AM Changeset in webkit [156831] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Add the NotDeletable, OperationsNotDeletable IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=122217

Reviewed by Darin Adler.

Before adjusting the JSC bindings generator to enforce configurable operations and thus conform to the
WebIDL specification in this regard, two no-op attributes are introduced that will preserve the current
behavior of operations being non-configurable.

All the relevant interfaces will be annotated with the OperationsNotDeletable attribute first. After the
generator is properly modified, this attribute will be removed from the interfaces after checking that
the operations' configurability also matches the configurability of operations in other browser engines
and that the change introduces no regressions in tests.

The NotDeletable attribute will be used as required to annotate operations that should stay
non-configurable for backwards compatibility or cross-browser compatibility.

bindings/scripts/IDLAttributes.txt:

1:43 AM Changeset in webkit [156830] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

DFG: ConstProp the pattern ValueToInt32(Bool(x)) -> Int32(x)
https://bugs.webkit.org/show_bug.cgi?id=122263

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Geoffrey Garen.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

1:35 AM Changeset in webkit [156829] by kadam@inf.u-szeged.hu

8 deletes in trunk/LayoutTests/platform

Remove Qt specific expected files and directories.
Reviewed by Csaba Osztrogonác.

12:58 AM Changeset in webkit [156828] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

Unreviewed fix of DrawingArea creation on non-Mac platforms after r156793.
std::make_unique<DrawingAreaImpl>() should be used, as before that revision.

WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

12:35 AM Changeset in webkit [156827] by Csaba Osztrogonác

138 deletes in trunk

Unreviewed. Remove empty directories.

12:33 AM Changeset in webkit [156826] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Remove preDispatchEventHandler and postDispatchEventHandler,
functions that are supposed to be removed in the previous commit (r156825).

dom/Node.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed