Context Navigation

← Previous Period
Next Period →

Timeline

Oct 5, 2013:

9:22 PM Changeset in webkit [156984] by fpizlo@apple.com

51 edits
4 adds in trunk/Source/JavaScriptCore

Compress DFG stack layout
https://bugs.webkit.org/show_bug.cgi?id=122024

Reviewed by Oliver Hunt.

The DFG needs to be able to store things at a known offset from frame pointer so that
the runtime can read those things. Prior to this patch, the DFG would use the exact
offsets that the bytecode asked for, even in the case of inlining, where it would use
the callsite stack offset to shift all of the inlined function's variables over just as
they would have been if a bytecode interpreter had really made the call.

But this won't work once WebKit-LLVM integration is complete. LLVM has no notion of
storing things at a fixed offset from the frame pointer. We could try to hack LLVM to do
that, but it would seriously complicate LLVM's stack layout. But what we might be able
to do is have LLVM tell us (via an addressof intrinsic and a side-channel) where some
alloca landed relative to the frame pointer. Hence if the DFG can put all of its flushed
variables in a contiguous range that can be expressed to LLVM as a struct that we
alloca, then all of this can still work just fine.

Previously the flushed variables didn't fit in a contiguous range, but this patch makes
them contiguous by allowing the stack layout to be compressed.

What this really means is that there is now a distinction between where the DFG saw a
variable stored in bytecode and where it will actually store it in the resulting machine
code. Henceforth when the DFG says "local" or "virtual register" it means the variable
according to bytecode (with the stack offsetting for inlined code as before), but when
it says "machine local" or "machine virtual register" it means the actual place where it
will store things in the resulting machine code. All of the OSR exit, inlined arguments,
captured variables, and various stack unwinding machine now knows about all of this.

Note that the DFG's abstract interpretation still uses bytecode variables rather than
machine variables. Same for CSE and abstract heaps. This makes sense since it means that
we don't have to decide on machine variable allocation just to do those optimizations.

The decision of what a local's machine location becomes is deferred to very late in
compilation. We only need to assign machine locations to variables that must be stored
to the stack. It's now mandatory to run some kind of "stack layout phase" that makes the
decision and updates all data structures.

So far the way that this is being used is just to compress the DFG stack layout, which
is something that we should have done anyway, a long time ago. And the compression isn't
even that good - the current StackLayoutPhase just identifies local indices that are
unused in machine code and slides all other variables towards zero. This doesn't achieve
particularly good compression but it is better than nothing. Note that this phase makes
it seem like the bytecode-machine mapping is based on bytecode local indices; for
example if bytecode local 4 is mapped to machine local 3 then it always will be. That's
true for the current StackLayoutPhase but it _will not_ be true for all possible stack
layout phases and it would be incorrect to assume that it should be true. This is why
the current data structures have each VariableAccessData hold its own copy of the
machine virtual register, and also have each InlineCallFrame report their own machine
virtual registers for the various things. The DFG backend is likely to always use the
dumb StackLayoutPhase since it is very cheap to run, but the FTL backend is likely to
eventually get a better one, where we do some kind of constraint-based coloring: we
institute constraints where some VariableAccessData's must have the same indices as some
other ones, and also must be right next to some other ones; then we process all
VariableAccessData's and attempt to assign them machine locals while preserving those
constraints. This could lead to two VariableAccessDatas for the same bytecode local
ending up with different machine locals.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::framePointerOffsetToGetActivationRegisters):
(JSC::CodeBlock::machineSlowArguments):

bytecode/CodeBlock.h:

(JSC::CodeBlock::hasSlowArguments):

bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::dump):
(JSC::InlineCallFrame::calleeForCallFrame):
(JSC::InlineCallFrame::dumpInContext):

bytecode/CodeOrigin.h:

(JSC::InlineCallFrame::InlineCallFrame):
(JSC::InlineCallFrame::calleeConstant):

bytecode/Operands.h:

(JSC::Operands::indexForOperand):

dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::SSAData::SSAData):

dfg/DFGBasicBlock.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGCommon.h:
dfg/DFGCommonData.h:

(JSC::DFG::CommonData::CommonData):

dfg/DFGDesiredWriteBarriers.cpp:

(JSC::DFG::DesiredWriteBarrier::trigger):

dfg/DFGDesiredWriteBarriers.h:
dfg/DFGFlushLivenessAnalysisPhase.cpp:

(JSC::DFG::FlushLivenessAnalysisPhase::run):
(JSC::DFG::FlushLivenessAnalysisPhase::process):
(JSC::DFG::FlushLivenessAnalysisPhase::reportError):

dfg/DFGFlushedAt.cpp: Added.

(JSC::DFG::FlushedAt::dump):
(JSC::DFG::FlushedAt::dumpInContext):

dfg/DFGFlushedAt.h: Added.

(JSC::DFG::FlushedAt::FlushedAt):
(JSC::DFG::FlushedAt::operator!):
(JSC::DFG::FlushedAt::format):
(JSC::DFG::FlushedAt::virtualRegister):
(JSC::DFG::FlushedAt::operator==):
(JSC::DFG::FlushedAt::operator!=):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):

dfg/DFGGraph.h:

(JSC::DFG::Graph::bytecodeRegisterForArgument):
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::machineArgumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::activationRegister):
(JSC::DFG::Graph::uncheckedActivationRegister):
(JSC::DFG::Graph::machineActivationRegister):
(JSC::DFG::Graph::uncheckedMachineActivationRegister):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

dfg/DFGNode.h:

(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::machineLocal):
(JSC::DFG::Node::hasUnlinkedMachineLocal):
(JSC::DFG::Node::setUnlinkedMachineLocal):
(JSC::DFG::Node::unlinkedMachineLocal):
(JSC::DFG::Node::hasInlineStartData):
(JSC::DFG::Node::inlineStartData):

dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGOSREntry.h:

(JSC::DFG::OSREntryReshuffling::OSREntryReshuffling):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::ScoreBoard):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::calleeFrameOffset):
(JSC::DFG::SpeculativeJIT::callFrameSlot):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::callFrameTagSlot):
(JSC::DFG::SpeculativeJIT::callFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
(JSC::DFG::SpeculativeJIT::framePointerOffsetToGetActivationRegisters):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::recordSetLocal):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStackLayoutPhase.cpp: Added.

(JSC::DFG::StackLayoutPhase::StackLayoutPhase):
(JSC::DFG::StackLayoutPhase::run):
(JSC::DFG::performStackLayout):

dfg/DFGStackLayoutPhase.h: Added.
dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::machineLocal):
(JSC::DFG::VariableAccessData::flushedAt):

dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsInt52):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::virtualRegister):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

ftl/FTLValueSource.cpp:

(JSC::FTL::ValueSource::dump):

ftl/FTLValueSource.h:

(JSC::FTL::ValueSource::ValueSource):
(JSC::FTL::ValueSource::kind):
(JSC::FTL::ValueSource::operator!):
(JSC::FTL::ValueSource::node):
(JSC::FTL::ValueSource::virtualRegister):

interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):

interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::createArguments):
(JSC::StackVisitor::Frame::existingArguments):

interpreter/StackVisitor.h:
jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::addressFor):
(JSC::AssemblyHelpers::tagFor):
(JSC::AssemblyHelpers::payloadFor):
(JSC::AssemblyHelpers::offsetOfArgumentsIncludingThis):

runtime/Arguments.cpp:

(JSC::Arguments::tearOff):

runtime/Arguments.h:

(JSC::Arguments::allocateSlowArguments):
(JSC::Arguments::tryDeleteArgument):
(JSC::Arguments::isDeletedArgument):
(JSC::Arguments::isArgument):
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):

runtime/JSActivation.h:

(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):

runtime/JSFunction.cpp:

(JSC::RetrieveArgumentsFunctor::operator()):

8:16 PM Changeset in webkit [156983] by fpizlo@apple.com

2 edits in trunk/Tools

run-jsc-stress-tests should be less verbose
https://bugs.webkit.org/show_bug.cgi?id=122397

Reviewed by Sam Weinig.

It now just prints something like:

965/1831 ....

Where the first number is the number of tests that completed, the second number is the
number of tests total, and the dots are the number of tests running right now - which is
useful towards the end when you're waiting for the last slow tests to finish.

It will also print out the output from failing tests and it will print a line for skipped
tests (to annoy you into getting them into a shape where they can be unskipped). For
example, for LayoutTests, it will print just the diff, if the test fails. It's cool.

Scripts/run-jsc-stress-tests:

7:32 PM Changeset in webkit [156982] by akling@apple.com

3 edits in trunk/Source/WebCore

FrameSelection: Remove two unused member functions.

Rubber-stamped by Anders Carlsson.

rootEditableElementOrTreeScopeRootNode()
rootEditableElementRespectingShadowTree()

7:30 PM Changeset in webkit [156981] by akling@apple.com

45 edits in trunk/Source/WebCore

CTTE: Node::treeScope() should return a reference.
<https://webkit.org/b/122399>

Reviewed by Superlative Sam.

Every Node belongs to a TreeScope. To enforce this, I've made
treeScope() return a TreeScope&, and setTreeScope() now takes a
TreeScope& so there is no way to clear it.

6:08 PM Changeset in webkit [156980] by weinig@apple.com

45 edits in trunk/Source/WebCore

CTTE: Use references more for the Document parser
https://bugs.webkit.org/show_bug.cgi?id=122398

Reviewed by Andreas Kling.

Clarify the construction semantics of Document parsers.

5:34 PM Changeset in webkit [156979] by dbates@webkit.org

3 edits in trunk/Source/WebCore

[iOS] Default initialize Settings::setFixedPositionCreatesStackingContext() to true
https://bugs.webkit.org/show_bug.cgi?id=122338
<rdar://problem/14908151>

Reviewed by Darin Adler.

On iOS we always want an element with a fixed position to create a stacking context.
See <rdar://problem/9813262> for more details.

page/Settings.cpp: Define constant defaultFixedPositionCreatesStackingContext to

be true when building for iOS and false otherwise.

page/Settings.in: Initialize the setting fixedPositionCreatesStackingContext with

the value of the constant defaultFixedPositionCreatesStackingContext.

4:59 PM Changeset in webkit [156978] by weinig@apple.com

17 edits in trunk/Source

CTTE: Pass DocumentWriter around as a reference
https://bugs.webkit.org/show_bug.cgi?id=122396

Reviewed by Andreas Kling.

../WebCore:

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

dom/DecodedDataDocumentParser.cpp:

(WebCore::DecodedDataDocumentParser::appendBytes):
(WebCore::DecodedDataDocumentParser::flush):

dom/DecodedDataDocumentParser.h:
dom/DocumentParser.h:
dom/RawDataDocumentParser.h:

(WebCore::RawDataDocumentParser::flush):

html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::appendBytes):

html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::appendBytes):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):
(WebCore::PluginDocumentParser::appendBytes):

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

loader/DocumentLoader.h:

(WebCore::DocumentLoader::writer):

loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::addData):
(WebCore::DocumentWriter::end):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):

loader/SinkDocument.cpp:

(WebCore::SinkDocumentParser::appendBytes):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

../WebKit/mac:

WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]):

4:56 PM Changeset in webkit [156977] by akling@apple.com

4 edits in trunk/Source/WebCore

FrameView: Remove code for disabling repaints.
<https://webkit.org/b/122393>

Reviewed by Sam Weinig.

Nobody uses this mode for anything so let's just remove it.

It was added back in r110469 to fix an issue with SVGImageCache
and its only user disappeard in the cache overhaul in r142765.

4:53 PM Changeset in webkit [156976] by fpizlo@apple.com

6 edits in trunk

Allow skipping of run-jsc-stress-tests that are configured using yaml files
https://bugs.webkit.org/show_bug.cgi?id=122385

Tools:

Reviewed by Sam Wieinig.

Make tests run via YAML be able to do the parse-for-commands trick that allows
us to skip tests and do other custom per-test stuff.

Scripts/jsc-stress-test-helpers/layout-test-helper:
Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Sam Weinig.

The way that we "skip" tests is by having a custom command at the top using @ notation,
and then use "@ skip". But the machinery to do that also allows us to do things like
run tests in a no-concurrent-JIT mode - so I've also implemented that in this patch.

Use the skip machinery to skip large-expressions.js.

js/script-tests/large-expressions.js:
jsc-layout-tests.yaml:

4:02 PM Changeset in webkit [156975] by akling@apple.com

1 edit
2 deletes in trunk/Source/WebCore

Remove IFrameShimSupport, it was only used by dead ports.

Rubber-stamped by Anders Carlsson.

plugins/IFrameShimSupport.cpp: Removed.
plugins/IFrameShimSupport.h: Removed.

3:57 PM Changeset in webkit [156974] by akling@apple.com

34 deletes in trunk

Remove remaining Qt files.

Rubber-stamped by Anders Carlsson.

2:57 PM Changeset in webkit [156973] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Try to fix the GTK+ build.

UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::platformInitialize):

2:53 PM Changeset in webkit [156972] by andersca@apple.com

19 edits in trunk/Source

Clean up MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=122392

Reviewed by Andreas Kling.

Source/WebCore:

Update for changes to MessageQueue, mostly changing create functions to return std::unique_ptr.
I intentionally avoided using std::make_unique in a couple of places because I didn't want to make nested classes
public, and I believe that we can change some of this code to use std::function.

Modules/webaudio/AsyncAudioDecoder.cpp:

(WebCore::AsyncAudioDecoder::decodeAsync):
(WebCore::AsyncAudioDecoder::runLoop):
(WebCore::AsyncAudioDecoder::DecodingTask::create):

Modules/webaudio/AsyncAudioDecoder.h:
Modules/webdatabase/Database.cpp:

(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::tableNames):

Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::openAndVerifyVersion):
(WebCore::DatabaseBackend::scheduleTransaction):
(WebCore::DatabaseBackend::scheduleTransactionStep):

Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseBackend::DatabaseOpenTask::create):
(WebCore::DatabaseBackend::DatabaseCloseTask::create):
(WebCore::DatabaseBackend::DatabaseTransactionTask::create):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::create):

Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):

Modules/webdatabase/DatabaseThread.h:
dom/default/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::EventData::create):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):

dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):

fileapi/FileThread.cpp:

(WebCore::FileThread::postTask):
(WebCore::SameInstancePredicate::operator()):
(WebCore::FileThread::runLoop):

fileapi/FileThread.h:
fileapi/FileThreadTask.h:

(WebCore::createFileThreadTask):

storage/StorageThread.cpp:

(WebCore::StorageThread::threadEntryPoint):
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):

workers/WorkerRunLoop.cpp:

(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::create):

workers/WorkerRunLoop.h:

Source/WTF:

Make MessageQueue use std::unique_ptr and change findIf and removeIf to take const references.

wtf/Deque.h:

Change findIf to take an rvalue reference.

wtf/MessageQueue.h:

(WTF::::append):
(WTF::::appendAndKill):
(WTF::::appendAndCheckEmpty):
(WTF::::prepend):
(WTF::::removeIf):

12:27 PM Changeset in webkit [156971] by dino@apple.com

4 edits in trunk/Source/WebCore

[WebGL] program should not be able to link if a bad shader is attached
https://bugs.webkit.org/show_bug.cgi?id=94036

Reviewed by Darin Adler.

If you attempt to link a program when bad shaders are attached, the
link should fail. WebGL also requires that the previously linked
program should remain intact. We were doing the former, but not
the latter.

Fix this by not calling glLinkProgram if we know we have bad
shaders, and synthesize a bad link status instead.

Test: WebGL conformance test conformance/programs/program-test.html
(found in LayoutTests/webgl)

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::compileShader): Mark a shader as valid
if it compiled ok.
(WebCore::WebGLRenderingContext::linkProgram): Don't call into GraphicsContext3D::linkProgram
if we know that we don't have valid shaders.

html/canvas/WebGLShader.cpp:

(WebCore::WebGLShader::WebGLShader): Initialize m_isValid.

html/canvas/WebGLShader.h:

(WebCore::WebGLShader::isValid): New member variable getter and setter.
(WebCore::WebGLShader::setValid):

12:21 PM Changeset in webkit [156970] by dino@apple.com

3 edits in trunk/Source/WebCore

Undo texture unit code refactoring - it is ok to bind a texture to multiple locations
https://bugs.webkit.org/show_bug.cgi?id=122369
<rdar://problem/15158465>

Reviewed by Darin Adler.

The optimisation in r152351 (http://webkit.org/b/117868) incorrectly
assumes that a texture cannot be bound to more than one location.
That's true only within the same program object. It's legal to
address TEXTURE_BINDING_2D and TEXTURE_BINDING_CUBE_MAP with the
same texture in different programs.

See https://github.com/KhronosGroup/WebGL/pull/391 for more information.

This change reverts the optimisation, but also does some minor
cleanup (0 -> nullptr, class -> struct).

Covered by the following Khronos WebGL 1.0.1 tests, which
now pass:

conformance/more/functions/texImage2DHTML.html
conformance/more/functions/texSubImage2D.html
conformance/more/functions/texSubImage2DHTML.html

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):

html/canvas/WebGLRenderingContext.h:

12:02 PM Changeset in webkit [156969] by andersca@apple.com

2 edits in trunk/Source/WTF

Try to #define final to sealed when building with MSVC
https://bugs.webkit.org/show_bug.cgi?id=122386

Reviewed by Darin Adler.

wtf/Compiler.h:

11:59 AM Changeset in webkit [156968] by andersca@apple.com

34 edits in trunk/Source

Remove createOwned
https://bugs.webkit.org/show_bug.cgi?id=122388

Reviewed by Darin Adler.

Source/JavaScriptCore:

profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::save):

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::createRenderTree):
(WebCore::Document::destroyRenderTree):

dom/Document.h:
page/Frame.cpp:

(WebCore::Frame::Frame):

page/Frame.h:
page/animation/AnimationController.cpp:

(WebCore::AnimationController::AnimationController):

page/animation/AnimationController.h:
platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:
platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC):
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack):

platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:

(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC):
(WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack):

platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

rendering/svg/RenderSVGResourceClipper.h:
rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

rendering/svg/RenderSVGResourceFilter.h:
rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

rendering/svg/RenderSVGResourceMasker.h:

Source/WebKit2:

UIProcess/API/mac/WKView.mm:

(-[WKView _setFindIndicator:fadeOut:animate:]):

WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlayCreate):

Source/WTF:

Since we're going with std::unique_ptr instead of OwnPtr, there's no need for makeOwned to exist.
Get rid of it and replace it with calls to std::make_unique.

wtf/FilePrintStream.cpp:

(WTF::FilePrintStream::open):

wtf/FilePrintStream.h:
wtf/HashTable.h:

(WTF::::HashTable):

wtf/ListHashSet.h:

(WTF::::ListHashSet):

wtf/OwnPtr.h:
wtf/Threading.cpp:

(WTF::compatEntryPoint):
(WTF::createThread):

wtf/ThreadingPthreads.cpp:

(WTF::wtfThreadEntryPoint):
(WTF::createThreadInternal):

wtf/unicode/Collator.h:
wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::userDefault):

wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

11:32 AM Changeset in webkit [156967] by Darin Adler

10 edits in trunk/Source

Remove COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES) since it's required now
https://bugs.webkit.org/show_bug.cgi?id=122387

Reviewed by Anders Carlsson.

Source/WebCore:

html/canvas/CanvasStyle.h: Take out conditionals.

Source/WebKit2:

UIProcess/API/cpp/WKRetainPtr.h: Take out conditionals.

Source/WTF:

wtf/RefPtr.h:
wtf/RetainPtr.h:
wtf/Vector.h:
wtf/text/AtomicString.h:
wtf/text/WTFString.h:

Take out conditionals.

11:31 AM Changeset in webkit [156966] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit/gtk

Unreviewed GTK build fix after r156946. The framePolicyFunction is an attribute
on the WebKitWebPolicyDecisionPrivate object.

webkit/webkitwebpolicydecision.cpp:

(webkit_web_policy_decision_use):
(webkit_web_policy_decision_ignore):
(webkit_web_policy_decision_download):

11:22 AM Changeset in webkit [156965] by Darin Adler

22 edits in trunk/Source

Add AtomicString::number and use it
https://bugs.webkit.org/show_bug.cgi?id=122384

Reviewed by Anders Carlsson.

Source/WebCore:

css/CSSGrammar.y.in: Use AtomicString::number instead of String::number since

we are creating an AtomicString. This can save a memory allocation if the string
happens to already be in the atomic string table.

dom/Element.cpp:

(WebCore::Element::setIntegralAttribute): Ditto.
(WebCore::Element::setUnsignedIntegralAttribute): Ditto.

editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply): Ditto.

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto): Use setIntegralAttribute instead of
a local homegrown equivalent.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::setHeight): Ditto.
(WebCore::HTMLCanvasElement::setWidth): Ditto.

html/HTMLElement.cpp:

(WebCore::HTMLElement::setTabIndex): Ditto.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::setHeight): Ditto.
(WebCore::HTMLImageElement::setWidth): Ditto.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setMaxLength): Ditto.
(WebCore::HTMLInputElement::setSize): Same, but setUnsignedIntegralAttribute.
(WebCore::HTMLInputElement::setHeight): Ditto.
(WebCore::HTMLInputElement::setWidth): Ditto.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerSetSize): Ditto.

html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::setMin): More of the same.
(WebCore::HTMLMeterElement::setMax): Ditto.
(WebCore::HTMLMeterElement::setValue): Ditto.
(WebCore::HTMLMeterElement::setLow): Ditto.
(WebCore::HTMLMeterElement::setHigh): Ditto.
(WebCore::HTMLMeterElement::setOptimum): Ditto.

html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::setStart): Ditto.

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::setValue): Ditto.
(WebCore::HTMLProgressElement::setMax): Ditto.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute): Ditto.
(WebCore::HTMLSelectElement::setSize): Ditto.

html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::setColSpan): Ditto.
(WebCore::HTMLTableCellElement::setRowSpan): Ditto.

html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::setSpan): Ditto.

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setMaxLength): Ditto.
(WebCore::HTMLTextAreaElement::setCols): Ditto.
(WebCore::HTMLTextAreaElement::setRows): Ditto.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTimelineElement::setDuration): Ditto.

Source/WTF:

wtf/text/AtomicString.cpp:

(WTF::AtomicString::number): Added.

wtf/text/AtomicString.h: Ditto.

wtf/text/IntegerToStringConversion.h: Simplify includes, renamed ConversionTrait to

IntegerToStringConversionTrait. Changed String version to use String since we no longer
need to use PassRefPtr to efficiently handle return values. Replaced UnsignedIntegerTrait
with std::make_unsigned. Added AtomicString support. Use nullptr instead of 0.

11:04 AM Changeset in webkit [156964] by Darin Adler

16 edits in trunk/Source

Cut down on use of String::number
https://bugs.webkit.org/show_bug.cgi?id=122382

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject::putByIndex): Use Identifier::from instead of calling
String::number and creating an identifier from that. Can save creating and then
destroying a string if an identifier already exists.

runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlotByIndex): Ditto.
(JSC::Arguments::getOwnPropertyNames): Ditto.
(JSC::Arguments::putByIndex): Ditto.

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::::getOwnPropertyNames): Ditto.

runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertyNames): Ditto.

Source/WebCore:

css/CSSGradientValue.cpp:

(WebCore::CSSLinearGradientValue::customCSSText): Use StringBuilder::appendNumber,
instead of creating a string and then appending it.
(WebCore::CSSRadialGradientValue::customCSSText): Ditto.

css/CSSParser.cpp:

(WebCore::CSSParser::createKeyframe): Ditto.

editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI): Use ASCII literals instead of
converting numeric constants to strings at runtime with String::number.
(WebCore::DeleteButtonController::show): Ditto.

svg/SVGNumberList.cpp:

(WebCore::SVGNumberList::valueAsString): Use StringBuilder::appendNumber.

svg/SVGPointList.cpp:

(WebCore::SVGPointList::valueAsString): Ditto.

svg/SVGRect.h: Ditto.

Source/WebKit2:

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::dumpChangedLayers): Use StringBuilder::appendNumber.

Source/WTF:

wtf/DateMath.cpp:

(WTF::appendTwoDigitNumber): Added. Replaces twoDigitStringFromNumber, which returned a
String and also allocated a temporary string for any number 10 or higher.
(WTF::makeRFC2822DateString): Updated to use the new function.

10:45 AM Changeset in webkit [156963] by andersca@apple.com

6 edits in trunk/Source

Test the waters and begin using lambdas
https://bugs.webkit.org/show_bug.cgi?id=121809

Reviewed by Andreas Kling.

Source/WebCore:

Use lambdas instead of static functions and function objects.

css/MediaQuery.cpp:

(WebCore::MediaQuery::MediaQuery):

dom/MutationObserver.cpp:

(WebCore::MutationObserver::deliverAllMutations):

page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::sortedTrackListForMenu):

Source/WTF:

wtf/ListDump.h:

(WTF::sortedListDump):
Use std::less instead of a custom lessThan function.

10:07 AM Changeset in webkit [156962] by Manuel Rego Casasnovas

2 edits
8 adds in trunk/LayoutTests

[CSS Regions] Layout Test for selecting text ignoring region content
https://bugs.webkit.org/show_bug.cgi?id=122353

Reviewed by Darin Adler.

Add new reftests for selecting text in texts wrapping a region, where
the region content is ignored. It compares the behavior (highlighted
text and selected content) in regions and absolute positions.

Absolute positioned elements do not fill the gaps on the right during
the selection, unlike regular elements. This is the reason why some
regular elements are floated in order to avoid such problems in the
reftests.

Provided layout tests for different writing models.

fast/regions/resources/region-style.css: New CSS classes required for these tests.
fast/regions/selection/selecting-text-ignoring-region-expected.html: Added.
fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.html: Added.
fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html: Added.
fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html: Added.
fast/regions/selection/selecting-text-ignoring-region-vert-lr.html: Added.
fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html: Added.
fast/regions/selection/selecting-text-ignoring-region-vert-rl.html: Added.
fast/regions/selection/selecting-text-ignoring-region.html: Added.

10:06 AM Changeset in webkit [156961] by gyuyoung.kim@samsung.com

11 edits
2 moves in trunk/Source/WebCore

Add *CSS* prefix to FontValue to generate toCSSFontValue()
https://bugs.webkit.org/show_bug.cgi?id=122201

Reviewed by Darin Adler.

*CSS* prefix needs to be added to FontValue class in order to generate toCSSFontValue().
static_cast<FontValue*> is changed with toCSSFontValue() by this change.

No new tests, no behavior changes.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSFontValue.cpp: Renamed from Source/WebCore/css/FontValue.cpp.

(WebCore::CSSFontValue::customCSSText):
(WebCore::CSSFontValue::equals):

css/CSSFontValue.h: Renamed from Source/WebCore/css/FontValue.h.

(WebCore::CSSFontValue::create):
(WebCore::CSSFontValue::CSSFontValue):

css/CSSParser.cpp:
css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

10:02 AM Changeset in webkit [156960] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix cut and paste errors.

Configurations/WebKit2.xcconfig:

9:55 AM Changeset in webkit [156959] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Add the rest of the std::function weak symbols in an attempt to fix the Lion build.

Configurations/WebKit2.xcconfig:

9:48 AM Changeset in webkit [156958] by fpizlo@apple.com

2 edits in trunk/Tools

Unreviewed, fix tests on older Rubies.

Scripts/run-jsc-stress-tests:

9:46 AM Changeset in webkit [156957] by andersca@apple.com

4 edits in trunk

Source/WebKit2: Another attempt at fixing the Lion build.

Configurations/WebKit2.xcconfig:

Tools: Don't filter the weak symbols.

Scripts/check-for-weak-vtables-and-externals:

9:32 AM Changeset in webkit [156956] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Attempt to fix the Lion build.

Configurations/WebKit2.xcconfig:

Try unexporting one of the weak symbols for now. If this succeeds, I'll add the rest.

9:27 AM Changeset in webkit [156955] by fpizlo@apple.com

4 edits
2 adds in trunk

Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
https://bugs.webkit.org/show_bug.cgi?id=122376

Tools:

Reviewed by Mark Hahnenberg.

Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
Scripts/run-javascriptcore-tests:

(printThingsFound):

Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Mark Hahnenberg.

Add a yaml file describing which directories contain JS LayoutTests. run-jsc-stress-tests
will use this file.

jsc-layout-tests.yaml: Added.

8:55 AM Changeset in webkit [156954] by commit-queue@webkit.org

34 edits in trunk/Source/WebCore

Unreviewed, rolling out r156952.
http://trac.webkit.org/changeset/156952
https://bugs.webkit.org/show_bug.cgi?id=122381

Made svg/custom/large-image-pattern-crash.html assert
(Requested by ap on #webkit).

rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

rendering/InlineBox.h:
rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

rendering/PaintInfo.h:

(WebCore::PaintInfo::shouldPaintWithinRoot):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):

rendering/RenderBox.cpp:

(WebCore::RenderBox::paint):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):

rendering/RenderBox.h:
rendering/RenderElement.h:
rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paint):

rendering/RenderLineBreak.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::paint):

rendering/RenderObject.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):
(WebCore::RenderReplaced::shouldPaint):

rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::paintBoxDecorations):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):

rendering/RenderTableCol.h:
rendering/RenderText.h:
rendering/RenderView.cpp:

(WebCore::RenderView::paint):
(WebCore::RenderView::paintBoxDecorations):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::paintCustomHighlight):

rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

rendering/svg/RenderSVGGradientStop.h:
rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):

rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):

rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):

rendering/svg/SVGRenderingContext.h:
svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::rendererClipChild):

svg/SVGUseElement.h:
svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

8:01 AM Changeset in webkit [156953] by Darin Adler

5 edits
2 adds in trunk

Need to check if some HTML child elements are HTMLUnknownElement
https://bugs.webkit.org/show_bug.cgi?id=120297

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/media/media-disable-crash.html

dom/make_names.pl:

(printConstructorInterior): Added additional comments about the
wrapperOnlyIfMediaIsAvailable feature.
(printTypeHelpers): Added an isHTMLUnknownElement check to the check helper
functions for tags with the wrapperOnlyIfMediaIsAvailable feature.
(printWrapperFunctions): Instead of redoing the media player check and the
settings check, and possibly making a wrapper of the wrong type, call
isHTMUnknownElement, guaranteeing that the wrapper will match the element
it is wrapping.

html/HTMLElement.h: Move HTMLElementTypeHelpers.h to the bottom of the

file so that functions from that file can be use the HTMLElement class and
other things defined in this file.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::paused): Added an assertion that made the regression
test reliably assert, rather than intermittently (for me, non-reproducibly) crash.

LayoutTests:

Based on a test written by Zan Dobersek <zdobersek@igalia.com>.

fast/media/media-disable-crash-expected.txt: Added.
fast/media/media-disable-crash.html: Added.

4:58 AM Changeset in webkit [156952] by Antti Koivisto

34 edits in trunk/Source/WebCore

Move paint() to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122371

Reviewed by Darin Adler.

RenderText does not paint itself (text is painted by line boxes). We can move paint() down
to RenderElement.

This also requires some type tightening elsewhere in the code.

2:41 AM Changeset in webkit [156951] by rniwa@webkit.org

2 edits
28 adds in trunk/PerformanceTests

DoYouEvenBench: Add Facebook's React TodoMVC test case
https://bugs.webkit.org/show_bug.cgi?id=122379

Reviewed by Andreas Kling.

Add React/TodoMVC as a new test case. Somehow we beat Firefox on this one as well.

DoYouEvenBench/benchmark.html:
DoYouEvenBench/todomvc/labs: Added.
DoYouEvenBench/todomvc/labs/architecture-examples: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower.json: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/README.md: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.js: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.min.js: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/ender.js: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/JSXTransformer.js: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/bower.json: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.js: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.min.js: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/bg.png: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/index.html: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/js: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/js/app.jsx: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/js/footer.jsx: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/js/todoItem.jsx: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/js/utils.jsx: Added.
DoYouEvenBench/todomvc/labs/architecture-examples/react/readme.md: Added.

Oct 4, 2013:

11:54 PM Changeset in webkit [156950] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Fix an assertion failure introduced in r156925.

Add HTMLImageElement to the document-wide map only if it's in the document.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

11:40 PM Changeset in webkit [156949] by ap@apple.com

2 edits in trunk/Source/WebKit/mac

Don't preflight spell checker when calling -setContinuousSpellCheckingEnabled repeatedly
https://bugs.webkit.org/show_bug.cgi?id=122329

Reviewed by Darin Adler.

WebView/WebView.mm: (-[WebView setContinuousSpellCheckingEnabled:]): Don't do any

work if preference didn't change (continuousSpellCheckingEnabled is a static that
starts with false).

11:38 PM Changeset in webkit [156948] by Darin Adler

18 edits
2 adds in trunk

text-transform: lowercase is not lang-dependent (Turkish languages : tr,az)
https://bugs.webkit.org/show_bug.cgi?id=21312

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/text/text-transform-turkish-and-azeri.html

This patch covers text-transform: uppercase and text-transform: lowercase.
More changes will be needed to cover text-transform: capitalize.

inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchNode): Use String::upper instead of String::makeUpper.

page/EventHandler.cpp:

(WebCore::findDropZone): Use String::lower instead of String::makeLower.

platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Use String::upper instead of String::makeUpper.

platform/network/blackberry/rss/RSS10Parser.cpp: [Seriously, how is an RSS parser

part of WebKit's networking layer? Where are the tests that cover this? Seems wrong
to have this code in the project.]
(WebCore::RSS10Parser::parseXmlDoc): Use lower instead of makeLower.
(WebCore::RSS10Parser::parseItem): Ditto.
(WebCore::RSS10Parser::parseFeed): Ditto.

platform/network/blackberry/rss/RSS20Parser.cpp:

(WebCore::RSS20Parser::parseXmlDoc): Ditto.
(WebCore::RSS20Parser::parseItem): Ditto.
(WebCore::RSS20Parser::parseFeed): Ditto.
(WebCore::RSS20Parser::parseEnclosure): Ditto.

platform/network/blackberry/rss/RSSAtomParser.cpp:

(WebCore::RSSAtomParser::parseXmlDoc): Ditto.
(WebCore::RSSAtomParser::parseItem): Ditto.
(WebCore::RSSAtomParser::parseFeed): Ditto.
(WebCore::RSSAtomParser::parseLink): Ditto.
(WebCore::RSSAtomParser::parseContent): Ditto.
(WebCore::RSSAtomParser::parseAuthor): Ditto.
(WebCore::RSSAtomParser::parseCategory): Ditto.

platform/text/win/LocaleWin.cpp:

(WebCore::convertLocaleNameToLCID): Use String::lower instead of String::makeLower.

rendering/RenderText.cpp:

(WebCore::applyTextTransform): Use String::upper and String::lower instead of
String::makeUpper and String::makeLower, and also pass in the locale to each.

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod): Changed this so it doesn't call
upper just to return an already known string constant.

Source/WebKit/gtk:

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::doCommand): Use StringImpl::upper instead of
StringImpl::makeUpper.

Source/WTF:

wtf/text/StringImpl.cpp:

(WTF::StringImpl::upper): Removed an extra call that would unnecessarily reallocate
a StringImpl in the general non-ASCII case. Added an overload that takes a locale identifier.
(WTF::StringImpl::lower): Ditto.

wtf/text/StringImpl.h: Ditto.
wtf/text/WTFString.cpp:

(WTF::String::lower): Ditto.
(WTF::String::upper): Ditto.

wtf/text/WTFString.h: Ditto. Also deleted the makeLower and makeUpper functions since they

offer no advantages over the lower and upper functions. Also added a constructor that takes
a RefPtr<StringImpl> with move construction to help.

LayoutTests:

fast/text/text-transform-turkish-and-azeri-expected.html: Added.
fast/text/text-transform-turkish-and-azeri.html: Added.

11:32 PM Changeset in webkit [156947] by ap@apple.com

19 edits
8 deletes in trunk

Roll out r156930 and r156937, they caused 34 assertion failures on bots.

9:52 PM Changeset in webkit [156946] by andersca@apple.com

23 edits in trunk/Source

FramePolicyFunction should be an std::function
https://bugs.webkit.org/show_bug.cgi?id=122362

Reviewed by Darin Adler.

Source/WebCore:

This makes policy callback handling simpler inside WebKit.

loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchWillSubmitForm):

loader/EmptyClients.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

loader/FrameLoaderClient.h:
loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::checkContentPolicy):

Source/WebKit/efl:

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::callPolicyFunction):
(WebCore::FrameLoaderClientEfl::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):

WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchWillSubmitForm):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):

WebCoreSupport/FrameLoaderClientGtk.h:
webkit/webkitwebpolicydecision.cpp:

(webkit_web_policy_decision_use):
(webkit_web_policy_decision_ignore):
(webkit_web_policy_decision_download):

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):

Source/WebKit/win:

WebCoreSupport/WebFrameLoaderClient.cpp:

Source/WebKit2:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::didReceivePolicyDecision):

9:48 PM Changeset in webkit [156945] by akling@apple.com

6 edits in trunk/Source/WebCore

CTTE: IconController and IconLoader should have Frame& backpointer.
<https://webkit.org/b/122372>

Reviewed by Anders Carlsson.

Also slap IconLoader with FINAL glove.

9:30 PM Changeset in webkit [156944] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix after r156924

UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::platformInitialize):

9:24 PM Changeset in webkit [156943] by fpizlo@apple.com

2 edits in trunk/Tools

It should be even easier to run and debug a failing JSC stress test
https://bugs.webkit.org/show_bug.cgi?id=122337

Reviewed by Oliver Hunt.

If a test fails, you can now just say:

sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit

and get the reproduction. You don't have to set any environment variables like before.
Also if you want to debug the failing test you can now just say:

sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --

Broadly, any arguments passed to the reproduction script are prepended to the command to
run the test. This is sort of quirky and won't work for some tests (for example the
profiler tests run a ruby script that runs some other stuff) but it'll work for most of
them and that's good enough for now.

Scripts/run-jsc-stress-tests:

8:50 PM Changeset in webkit [156942] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: RenderScrollbar DOM owner is always an Element.
<https://webkit.org/b/122348>

Reviewed by Antti Koivisto.

When RenderScrollbar is owned by a DOM node, it's always Element.
Tighten the code a bit with this knowledge.

Also marked the class FINAL and beat it with the OVERRIDE stick.

8:34 PM Changeset in webkit [156941] by akling@apple.com

7 edits in trunk/Source/WebCore

TypingCommand helpers should take Document&.
<https://webkit.org/b/122370>

Reviewed by Anders Carlsson.

Instead of taking a Document* and immediately asserting that it's
non-null, just take Document&.

7:59 PM Changeset in webkit [156940] by rniwa@webkit.org

18 edits in trunk/Source/WebCore

Use more references instead of pointers in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=122368

Reviewed by Andreas Kling.

Use AtomicStringImpl& instead of AtomicString* or AtomicString& to eliminate
assertions and nullity checks.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):

dom/Document.cpp:

(WebCore::Document::addImageElementByLowercasedUsemap):
(WebCore::Document::removeImageElementByLowercasedUsemap):
(WebCore::Document::imageElementByLowercasedUsemap):

dom/Document.h:
dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesId):
(WebCore::keyMatchesName):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):
(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByName):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
(WebCore::DocumentOrderedMap::getAllElementsById):

dom/DocumentOrderedMap.h:

(WebCore::DocumentOrderedMap::containsSingle):
(WebCore::DocumentOrderedMap::contains):
(WebCore::DocumentOrderedMap::containsMultiple):

dom/Element.cpp:

(WebCore::Element::updateNameForTreeScope):
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForTreeScope):
(WebCore::Element::updateIdForDocument):
(WebCore::Element::updateLabel):

dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::notifyObserversInternal):

dom/IdTargetObserverRegistry.h:

(WebCore::IdTargetObserverRegistry::notifyObservers):

dom/TreeScope.cpp:

(WebCore::TreeScope::getElementById):
(WebCore::TreeScope::getAllElementsById):
(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::removeElementById):
(WebCore::TreeScope::getElementByName):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::removeElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::removeImageMap):
(WebCore::TreeScope::getImageMap):
(WebCore::TreeScope::addLabel):
(WebCore::TreeScope::removeLabel):
(WebCore::TreeScope::labelElementForId):

dom/TreeScope.h:

(WebCore::TreeScope::hasElementWithId):
(WebCore::TreeScope::containsMultipleElementsWithId):
(WebCore::TreeScope::hasElementWithName):
(WebCore::TreeScope::containsMultipleElementsWithName):

html/HTMLCollection.cpp:

(WebCore::HTMLCollection::namedItem):

html/HTMLDocument.cpp:

(WebCore::HTMLDocument::addDocumentNamedItem):
(WebCore::HTMLDocument::removeDocumentNamedItem):
(WebCore::HTMLDocument::addWindowNamedItem):
(WebCore::HTMLDocument::removeWindowNamedItem):

html/HTMLDocument.h:

(WebCore::HTMLDocument::documentNamedItem):
(WebCore::HTMLDocument::hasDocumentNamedItem):
(WebCore::HTMLDocument::documentNamedItemContainsMultipleElements):
(WebCore::HTMLDocument::windowNamedItem):
(WebCore::HTMLDocument::hasWindowNamedItem):
(WebCore::HTMLDocument::windowNamedItemContainsMultipleElements):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::parseAttribute):
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

7:06 PM Changeset in webkit [156939] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: PolicyChecker backpointer to Frame should be a reference.
<https://webkit.org/b/122354>

Reviewed by Anders Carlsson.

PolicyChecker is tied to the lifetime of FrameLoader, which in turn
is tied to the lifetime of Frame.

6:06 PM Changeset in webkit [156938] by akling@apple.com

3 edits in trunk/Source/WebCore

Editor should use reference-getting document() internally.
<https://webkit.org/b/122364>

Reviewed by Darin Adler.

Instead of grabbing at Editor::m_frame.document(), use the nice
Editor::document() helper that always returns a Document&.

Calling Editor methods on a Frame's editor() while there is no
Document in the Frame is a programming error and this is covered
by an assertion in document().

This removes a bunch of null checks and enables further cleanup.

6:03 PM Changeset in webkit [156937] by Martin Robinson

2 edits in trunk/Source/WebCore

Try to fix the Windows build after r156930.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::paintCharacter): Use ceilf and floorf to avoid issues
with overload collisions and implicit casts of LayoutUnits.

5:51 PM Changeset in webkit [156936] by mark.lam@apple.com

19 edits
8 adds in trunk

Change ScriptDebugServer to use DebuggerCallFrame instead of JavaScriptCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121969.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
DebuggerCallFrame's line() and column() now returns a base-zero int.
WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
Also removed evaluateInGlobalCallFrame() which is not used anywhere.

debugger/Debugger.cpp:
debugger/Debugger.h:
debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::callerFrame):
(JSC::DebuggerCallFrame::dynamicGlobalObject):
(JSC::DebuggerCallFrame::sourceId):
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::type):
(JSC::DebuggerCallFrame::thisValue):
(JSC::DebuggerCallFrame::evaluate):
(JSC::DebuggerCallFrame::evaluateWithCallFrame):
(JSC::DebuggerCallFrame::invalidate):
(JSC::DebuggerCallFrame::positionForCallFrame):
(JSC::DebuggerCallFrame::sourceIdForCallFrame):
(JSC::DebuggerCallFrame::thisValueForCallFrame):

debugger/DebuggerCallFrame.h:

(JSC::DebuggerCallFrame::create):
(JSC::DebuggerCallFrame::exec):
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
(JSC::DebuggerCallFrame::position):
(JSC::DebuggerCallFrame::isValid):

interpreter/StackVisitor.cpp:

Source/WebCore:

Tests: inspector-protocol/debugger/call-frame-function-name.html

inspector-protocol/debugger/call-frame-this-host.html
inspector-protocol/debugger/call-frame-this-nonstrict.html
inspector-protocol/debugger/call-frame-this-strict.html

Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
DebuggerCallFrame's line() and column() now returns a base-zero int.
WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
Also removed evaluateInGlobalCallFrame() which is not used anywhere.

bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::thisObject):

bindings/js/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
(WebCore::JavaScriptCallFrame::caller):

bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::type):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::dynamicGlobalObject):
(WebCore::JavaScriptCallFrame::thisValue):
(WebCore::JavaScriptCallFrame::evaluate):

bindings/js/ScriptDebugServer.cpp:

(WebCore::DebuggerCallFrameScope::DebuggerCallFrameScope):
(WebCore::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::evaluateBreakpointAction):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::currentDebuggerCallFrame):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::updateCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):

bindings/js/ScriptDebugServer.h:
bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::willExecuteProgram):

Source/WebKit/mac:

Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
DebuggerCallFrame's line() and column() now returns a base-zero int.
WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
Also removed evaluateInGlobalCallFrame() which is not used anywhere.

WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFramePrivate dealloc]):
(-[WebScriptCallFrame _initWithGlobalObject:functionName:exceptionValue:JSC::]):
(-[WebScriptCallFrame functionName]):
(-[WebScriptCallFrame exception]):

WebView/WebScriptDebugger.mm:

(WebScriptDebugger::exception):

LayoutTests:

http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

inspector-protocol/debugger/call-frame-function-name-expected.txt: Added.
inspector-protocol/debugger/call-frame-function-name.html: Added.
inspector-protocol/debugger/call-frame-this-host-expected.txt: Added.
inspector-protocol/debugger/call-frame-this-host.html: Added.
inspector-protocol/debugger/call-frame-this-nonstrict-expected.txt: Added.
inspector-protocol/debugger/call-frame-this-nonstrict.html: Added.
inspector-protocol/debugger/call-frame-this-strict-expected.txt: Added.
inspector-protocol/debugger/call-frame-this-strict.html: Added.
inspector/debugger/pause-in-internal-script-expected.txt:

5:40 PM Changeset in webkit [156935] by Brent Fulgham

2 edits in trunk/Source/WTF

Remove Qt definitions from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=122349

Reviewed by Anders Carlsson.

wtf/Platform.h: Remove unused PLATFORM(QT) stanzas from file.

5:40 PM Changeset in webkit [156934] by Brent Fulgham

2 edits in trunk/Source/JavaScriptCore

Silence compiler warning when building 64-bit (on Windows)

Reviewed by Geoffrey Garen.

jit/JSInterfaceJIT.h: Add a static cast for assignment.

5:35 PM Changeset in webkit [156933] by Brent Fulgham

2 edits in trunk/Source/WTF

[Win] Turn off FastMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=122352

Reviewed by Darin Adler.

wtf/Platform.h: Enable USE_SYSTEM_MALLOC when building on

Windows to stick to the MSVCRT allocator/deallocator.

5:35 PM Changeset in webkit [156932] by akling@apple.com

18 edits in trunk/Source

Ref-ify more stack guards.
<https://webkit.org/b/122360>

Reviewed by Anders Carlsson.

Make another pass turning RefPtr<T> into Ref<T> where possible.

5:26 PM Changeset in webkit [156931] by mikhail.pozdnyakov@intel.com

4 edits in trunk/Source/WTF

Remove WTF smart pointers 'const_pointer_cast'
https://bugs.webkit.org/show_bug.cgi?id=122325

Reviewed by Darin Adler.

Removed WTF smart pointers 'const_pointer_cast' functions as:

they were not used
their implementation was wrong as they tried to cast to a different pointer type

wtf/PassOwnPtr.h:
wtf/PassRefPtr.h:
wtf/RefPtr.h:

5:08 PM Changeset in webkit [156930] by Martin Robinson

19 edits
8 adds in trunk

[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416

Source/WebCore:

Reviewed by David Hyatt.

Tests: mathml/presentation/mo-minus.html

mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html

MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.

Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.

With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.

css/mathml.css:

Not sure what this line-height:0 was here for, but it caused bugs with the new code

mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.

mathml/MathMLTextElement.h:

(MathMLTextElement):

rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):

rendering/mathml/RenderMathMLBlock.h:

Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.

rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.

(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout

(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.

rendering/mathml/RenderMathMLOperator.h: Update method declarations.

LayoutTests:

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.

Add some reftests for stretchy operators.

TestExpectations: The remaining MathML pixel tests are broken by this patch.
LayoutTests/platform/gtk/TestExpectations:
LayoutTests/platform/mac/TestExpectations:
LayoutTests/platform/win/TestExpectations:
mathml/presentation/mo-minus.html: Added.
mathml/presentation/mo-stacked-glyphs-expected.html: Added.
mathml/presentation/mo-stacked-glyphs.html: Added.
mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
mathml/presentation/mo-stretchy-vertical-bar.html: Added.
mathml/very-large-stretchy-operators-expected.txt: Added.
mathml/very-large-stretchy-operators.html: Added.

5:00 PM Changeset in webkit [156929] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Build fix after r156925. It collided with r156903.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):

4:58 PM Changeset in webkit [156928] by Brent Fulgham

2 edits in trunk/Tools

[Windows] Correct run-path when using 64-bit binaries.

Reviewed by David Kilzer.

Scripts/webkitdirs.pm:

(determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
directory. Otherwise use the existing 'bin32' directory.

4:47 PM Changeset in webkit [156927] by akling@apple.com

8 edits in trunk/Source/WebCore

Clean out some FrameLoaderClient hooks that no ports were using.
<https://webkit.org/b/122356>

Reviewed by Anders Carlsson.

Removed the following hooks that were leftovers from dead ports:

didExhaustMemoryAvailableForScript
didNotAllowScript
didNotAllowPlugins
willCheckAndDispatchMessageEvent
didChangeName
dispatchWillInsertBody
dispatchDidChangeResourcePriority

4:34 PM Changeset in webkit [156926] by Brent Fulgham

2 edits in trunk/Tools

Teach webkitdirs.pm to honor the --64-bit flag
https://bugs.webkit.org/show_bug.cgi?id=122357

Reviewed by David Kilzer.

Scripts/webkitdirs.pm:

(argumentsForConfiguration): Modify to check if --64-bit is supplied
by the user.
(findMatchingArguments): Added.
(hasArgument): Added.
(checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
findMatchingArguments subroutine.

4:33 PM Changeset in webkit [156925] by rniwa@webkit.org

8 edits in trunk/Source/WebCore

FocusController::advanceFocus spends a lot of time in HTMLMapElement::imageElement
https://bugs.webkit.org/show_bug.cgi?id=122313

Reviewed by Andreas Kling.

The bug was caused by HTMLMapElement::imageElement traversing the entire document to look for
the image element associated with a given map element. Because HTMLCollection used to find the
image element is not cached, it traversed the entire document on every area element we visit,
resulting in O(n^{2) behavior.}

Fixed the bug by adding the name-to-image-element map on document to avoid the traversal in
HTMLMapElement::imageElement.

dom/Document.cpp:

(WebCore::Document::addImageElementByLowercasedUsemap): Added.
(WebCore::Document::removeImageElementByLowercasedUsemap): Added.
(WebCore::Document::imageElementByLowercasedUsemap): Added.

dom/Document.h: Added m_imagesByUsemap.

dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesLowercasedUsemap): Added.
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap): Added.

dom/DocumentOrderedMap.h:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Update the name-to-usemap map. The code to parse
the usemap attribute and strip # was moved from HTMLMapElement::imageElement.
(WebCore::HTMLImageElement::insertedInto): Ditto.
(WebCore::HTMLImageElement::removedFrom): Ditto.
(WebCore::HTMLImageElement::matchesLowercasedUsemap): Added; called by DocumentOrderedMap.

html/HTMLImageElement.h:

html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement): Call Document::imageElementByUsemap instead of
looking through all image elements in the document.

4:25 PM Changeset in webkit [156924] by weinig@apple.com

22 edits in trunk/Source

../WebCore: Unify rubberband control
https://bugs.webkit.org/show_bug.cgi?id=122341

Reviewed by Tim Horton.

Consolidates the two ways we were passing state about whether to rubber-band on a particular edge down to one.

WebCore.exp.in:
page/Page.cpp:
page/Page.h:
page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::isRubberBandInProgress):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::setCanRubberBandState):
(WebCore::ScrollingTree::rubberBandsAtLeft):
(WebCore::ScrollingTree::rubberBandsAtRight):
(WebCore::ScrollingTree::rubberBandsAtBottom):
(WebCore::ScrollingTree::rubberBandsAtTop):
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):

page/scrolling/ScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm:
page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::shouldRubberBandInDirection):

../WebKit2: Unify rubber-band control
https://bugs.webkit.org/show_bug.cgi?id=122341

Reviewed by Tim Horton.

Consolidates the two ways we were passing state about whether to rubber-band on a particular edge down to one.
Adds SPI to control whether you can rubber band on the left or right edge.
Add a linked-on-or-after check to control whether we use the legacy implicit rubber band control based on back/forward.

UIProcess/API/C/WKPage.cpp:

(WKPageRubberBandsAtLeft):
(WKPageSetRubberBandsAtLeft):
(WKPageRubberBandsAtRight):
(WKPageSetRubberBandsAtRight):
(WKPageRubberBandsAtBottom):
(WKPageSetRubberBandsAtBottom):

UIProcess/API/C/WKPage.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::rubberBandsAtLeft):
(WebKit::WebPageProxy::setRubberBandsAtLeft):
(WebKit::WebPageProxy::rubberBandsAtRight):
(WebKit::WebPageProxy::setRubberBandsAtRight):
(WebKit::WebPageProxy::rubberBandsAtTop):
(WebKit::WebPageProxy::setRubberBandsAtTop):
(WebKit::WebPageProxy::rubberBandsAtBottom):
(WebKit::WebPageProxy::setRubberBandsAtBottom):

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::shouldUseLegacyImplicitRubberBandControl):
(WebKit::WebPageProxy::platformInitialize):

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

WebProcess/WebPage/EventDispatcher.h:
WebProcess/WebPage/EventDispatcher.messages.in:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

4:01 PM Changeset in webkit [156923] by Antoine Quint

5 edits in trunk/Source/WebInspectorUI

Web Inspector: pressing the Cmd key over a CSS property should underline it immediately (jump to definition mode)
https://bugs.webkit.org/show_bug.cgi?id=119012

Reviewed by Joseph Pecoraro.

We add an "enabled" state to the tokenTrackingController to indicate that we're interested
in tracking hovered tokens. The tokenTrackingController is now only enabled in the
CSSStyleDeclarationTextEditor when the Cmd key is pressed and in the SourceCodeTextEditor
when either the Cmd key is pressed (NonSymbolTokens mode) or when the debugger is paused
(JavaScriptExpression mode).

The tokenTrackingController is now smarter about how it tracks mouse events when it's enabled,
tracking "mouseenter" and "mouseleave" events to enable tracking allowing immediate detection of
tokens being hovered or no longer being hovered even with quick mouse movements. Additioanlly,
using the new top-level mouse coordinates tracking, we can detect a hovered token as soon as
it's being enabled to provide instant feedback to the user.

This new top-level mouse coordinates tracking couple with tracking of modifier keys also fixes
http://webkit.org/b/119011.

UserInterface/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateJumpToSymbolTrackingMode):
Highlight the last known hovered candidate's range as soon as the Cmd key is pressed and enable
the tokenTrackingController if we're dealing with a non-read-only editor. When the Cmd key is
released, disable the tokenTrackingController.

UserInterface/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController):
(WebInspector.CodeMirrorTokenTrackingController.prototype.get enabled):
(WebInspector.CodeMirrorTokenTrackingController.prototype.set enabled):
New enabled state for the tokenTrackingController which indicates whether it should be tracking
mouse events to track hovered tokens in the editor. Upon being enabled, the tokenTrackingController
looks up the mouse coordinates continuously tracked at the window level to check for a token
at the last known mouse coordinates in case we're already over a token that may be highlighted.

(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightLastHoveredRange):
New public method allowing to highlight the last know candidate range, if any. This is used from
editor code when the Cmd key is pressed and we want to force the last know candidate to be
highlighted.

(WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
(WebInspector.CodeMirrorTokenTrackingController.prototype._stopTracking):
Make these two methods private now that they're automatically called by the "mouseenter" and
"mouseleave" event handling when we're in the "enabled" state. Additionally, the public
"tracking" property has been removed since it is no longer useful to the developer.

(WebInspector.CodeMirrorTokenTrackingController.prototype.handleEvent):
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseLeft):
New handlers for the "mouseenter" and "mouseleave" events enabling tracking of hovered tokens.

(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseMovedOverEditor):
(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
Refactor _mouseMovedOverEditor() into two methods with the new _updateHoveredTokenInfo()
allowing to customize the mouse coordinates to be used since we may call
_updateHoveredTokenInfo() outside of the context of a mouse event (ie. a keypress event).

(WebInspector.CodeMirrorTokenTrackingController.prototype._windowLostFocus):
(WebInspector.CodeMirrorTokenTrackingController.prototype._resetTrackingStates):
New private method combining all the various states that need to be reset when tracking
is turned off, including the removal of the highlighted range if any. This is now called
when the window loses focus.

UserInterface/Main.js:

(WebInspector.loaded):
(WebInspector._mouseMoved):
Add a new window-level "mousemove" event handler to always track mouse coordinates and key modifier
states. This ensures that we may have the most accurate information possible for key modifiers and
allow code to query the last recorded mouse position in situations where it wouldn't be possible
to have dealt with a mouse event, as is the case when the tokenTrackingController just started tracking.

UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerEnabled):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._enableJumpToSymbolTrackingModeSettings):
(WebInspector.SourceCodeTextEditor.prototype._disableJumpToSymbolTrackingModeSettings):
Update the "enabled" state on the tokenTrackingController when it may have changed based
on those two conditions: we should have either an active debugger call frame or the
Cmd key should have been pressed. This ensures we only track hovered tokens as needed.

(WebInspector.SourceCodeTextEditor.prototype._updateJumpToSymbolTrackingMode):
Highlight the last known hovered candidate's range as soon as the Cmd key is pressed.

3:49 PM Changeset in webkit [156922] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: SubframeLoader backpointer to Frame should be a reference.
<https://webkit.org/b/122350>

Reviewed by Anders Carlsson.

SubframeLoader is tied to the lifetime of FrameLoader, which in turn
is tied to the lifetime of Frame.

3:46 PM Changeset in webkit [156921] by andersca@apple.com

7 edits in trunk/Source

Remove some unneeded code from WidgetMac
https://bugs.webkit.org/show_bug.cgi?id=122355

Reviewed by Dan Bernstein.

Source/WebCore:

Remove code to manage the visible rect, it's not needed anymore.

platform/Widget.h:
platform/mac/WidgetMac.mm:

(WebCore::Widget::~Widget):
(WebCore::Widget::setFrameRect):
(WebCore::Widget::setPlatformWidget):

Source/WebKit/mac:

Remove code to handle the visible rect changing, it's not needed anymore since we always put Netscape plug-ins into their own layers now.

Plugins/Hosted/WebHostedNetscapePluginView.mm:
Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm:

3:45 PM Changeset in webkit [156920] by oliver@apple.com

5 edits
1 add in trunk/LayoutTests

Update all the tests, and include new file.

3:45 PM Changeset in webkit [156919] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

FTL: Add support for ValueToInt32(bool(x))
https://bugs.webkit.org/show_bug.cgi?id=122346

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-04
Reviewed by Geoffrey Garen.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):

3:41 PM Changeset in webkit [156918] by dbates@webkit.org

24 edits
8 adds in trunk/Source

[iOS] Upstream disk image cache
https://bugs.webkit.org/show_bug.cgi?id=121985

Reviewed by Joseph Pecoraro.

Source/WebCore:

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::isUsingDiskImageCache):

loader/ResourceBuffer.h:
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::canUseDiskImageCache): Added.
(WebCore::CachedImage::useDiskImageCache): Added.

loader/cache/CachedImage.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::isSafeToMakePurgeable):
(WebCore::CachedResource::isUsingDiskImageCache): Added.

loader/cache/CachedResource.h:

(WebCore::CachedResource::canUseDiskImageCache): Added.
(WebCore::CachedResource::useDiskImageCache): Added.

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::flushCachedImagesToDisk): Added.
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):

loader/cache/MemoryCache.h:

(WebCore::MemoryCache::TypeStatistic::TypeStatistic):

loader/ios/DiskImageCacheClientIOS.h: Added.
loader/ios/DiskImageCacheIOS.h: Added.
loader/ios/DiskImageCacheIOS.mm: Added.
platform/Logging.h:
platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::~SharedBuffer):
(WebCore::SharedBuffer::isAllowedToBeMemoryMapped): Added.
(WebCore::SharedBuffer::allowToBeMemoryMapped): Added.
(WebCore::SharedBuffer::failedMemoryMap): Added.
(WebCore::SharedBuffer::markAsMemoryMapped): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallbackData): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::setMemoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::buffer):
(WebCore::SharedBuffer::getSomeData):

platform/SharedBuffer.h:

(WebCore::SharedBuffer::isMemoryMapped): Added.

platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::SharedBuffer):

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:
ios/WebCoreSupport/WebDiskImageCacheClientIOS.h: Added.
ios/WebCoreSupport/WebDiskImageCacheClientIOS.mm: Added.

Source/WebKit/mac:

Misc/WebCache.mm:

(+[WebCache statistics]):

WebView/WebDataSource.mm:

(BufferMemoryMapped): Added.
(-[WebDataSource _setAllowToBeMemoryMapped]): Added.
(-[WebDataSource setDataSourceDelegate:]): Added.
(-[WebDataSource dataSourceDelegate]): Added.
(-[WebDataSource dealloc]):

WebView/WebDataSourcePrivate.h: Declared private delegate

protocol, WebDataSourcePrivateDelegate.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences diskImageCacheEnabled]): Added.
(-[WebPreferences setDiskImageCacheEnabled:]): Added.
(-[WebPreferences diskImageCacheMinimumImageSize]): Added.
(-[WebPreferences setDiskImageCacheMinimumImageSize:]): Added.
(-[WebPreferences diskImageCacheMaximumCacheSize]): Added.
(-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Added.
(-[WebPreferences _diskImageCacheSavedCacheDirectory]): Added.
(-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Added.

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):

3:25 PM Changeset in webkit [156917] by ap@apple.com

2 edits in trunk/Tools

Update svn-config for new Visual Studio extensions
https://bugs.webkit.org/show_bug.cgi?id=122344

Reviewed by Brent Fulgham.

svn-config: Add new Visual Studio extensions.

3:25 PM Changeset in webkit [156916] by betravis@adobe.com

4 edits
2 adds in trunk

[CSS Shapes] Basic shapes should be animatable for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=122343

Reviewed by Dirk Schulze.

Source/WebCore:

Test: fast/shapes/shape-outside-floats/shape-outside-animation.html

Add shape outside to the list of animatable properties. The infrastructure
is already in place for animating basic shapes on shape-inside and clipping
paths. See https://bugs.webkit.org/show_bug.cgi?id=101854.

page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

LayoutTests:

Add tests checking that shape-outside basic shape values correctly tween
between values.

animations/resources/animation-test-helpers.js:

(getPropertyValue): Add shape-outside to list of properties that do not parse
with the default behavior.
(comparePropertyValue): Compare shape-outsides after parsing their shape notation.

fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: Added.
fast/shapes/shape-outside-floats/shape-outside-animation.html: Added.

3:22 PM Changeset in webkit [156915] by akling@apple.com

4 edits in trunk/Source/WebCore

Tighten typing in some RenderLayer code.
<https://webkit.org/b/122342>

Reviewed by Antti Koivisto.

Use tighter types instead of Node and RenderObject inside RenderLayer
where applicable.

2:59 PM Changeset in webkit [156914] by Manuel Rego Casasnovas

3 edits
6 adds in trunk/LayoutTests

[CSS Regions] Layout Tests for selecting text in 2 regions for other writing modes
https://bugs.webkit.org/show_bug.cgi?id=122327

Reviewed by Alexandru Chiculita.

Add versions for other writing modes (horizontal-bt, vertical-lr and
vertical-rl) for test
fast/regions/selection/selecting-text-in-2-regions.html.

fast/regions/resources/helper.js:

(selectContentByIdsVert): Add new method when selecting context in a
vertical writing mode.

fast/regions/resources/region-style.css: Add some new CSS classes for

vertical writing mode.

fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:

Added.

fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:

Added.

2:52 PM Changeset in webkit [156913] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Build fix.

1:46 PM Changeset in webkit [156912] by commit-queue@webkit.org

3 edits
2 adds in trunk

Inserting a JS generated keyframe animation shouldn't trigger a whole document style recalc
https://bugs.webkit.org/show_bug.cgi?id=119479

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-10-04
Reviewed by Antti Koivisto.

Change CSSStyleSheet::didMutateRules to not invalidate all node's styles when inserting a
@-webkit-keyframes rule, and to instead insert the rule directly into the StyleResolver.

Test: animation/keyframes-dynamic.html: adds and removes keyframe rules using JavaScript and
validates that the correct elements are animated.

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):

css/CSSStyleSheet.h:

1:37 PM Changeset in webkit [156911] by commit-queue@webkit.org

5 edits
1 add in trunk/Tools

Made WinLauncher have better error handling, crash reporting, and modifiability.
https://bugs.webkit.org/show_bug.cgi?id=122319

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-04
Reviewed by Brent Fulgham.

WinLauncher/WinLauncher.cpp:

(WinLauncherWebHost::didFailProvisionalLoadWithError):
Don't display the numerous "Cancelled" messages that are obviously from the user.
(createCrashReport): Added.
(dllLauncherEntryPoint):
Made main loop back into while loop and write a crash report if it crashes.

WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:

Added WinLauncherReplace.h.

WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:

Added linking to DbgHelp.lib.

WinLauncher/WinLauncherReplace.h:

Added to make modifying WinLauncher behaviour and appearance easy.
(processCrashDump): Added.

1:35 PM Changeset in webkit [156910] by oliver@apple.com

29 edits
11 adds in trunk

Support for-of syntax
https://bugs.webkit.org/show_bug.cgi?id=122339

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add support for for-of syntax to JSC. As part of doing this I had to make
us support unique empty strings as identifiers. In a follow on patch i'm
going to remove the distinction entirely as it's purely a complicating
separation.

Otherwise the logic here is fairly self-explanatory.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitCall):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::ForOfNode::emitBytecode):

jit/JITOperations.cpp:
parser/ASTBuilder.h:

(JSC::ASTBuilder::createForOfLoop):

parser/NodeConstructors.h:

(JSC::EnumerationNode::EnumerationNode):
(JSC::ForInNode::ForInNode):
(JSC::ForOfNode::ForOfNode):

parser/Nodes.h:
parser/Parser.cpp:

(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):

parser/Parser.h:

(JSC::Parser::isofToken):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createForOfLoop):

runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::arrayIteratorPrototypeIterate):

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::finishCreation):

runtime/ArrayPrototype.h:
runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

runtime/CommonIdentifiers.h:
runtime/Identifier.h:

(JSC::Identifier::from):

runtime/JSCJSValue.cpp:

(JSC::JSValue::dumpInContext):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunction):

runtime/PrivateName.h:

(JSC::PrivateName::PrivateName):

runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):

Source/WTF:

Update assertions and add a helper function to StringImpl
to save repeated unique or identifier calls.

wtf/text/StringImpl.h:

(WTF::StringImpl::isIdentifierOrUnique):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::setIsAtomic):

LayoutTests:

Add test cases for the one type that supports for-of so far

js/basic-for-of-expected.txt: Added.
js/basic-for-of.html: Added.
js/regress/for-of-iterate-array-entries.html: Added.
js/regress/for-of-iterate-array-keys.html: Added.
js/regress/for-of-iterate-array-values.html: Added.
js/regress/script-tests/for-of-iterate-array-entries.js: Added.

(foo):

js/regress/script-tests/for-of-iterate-array-keys.js: Added.

(foo):

js/regress/script-tests/for-of-iterate-array-values.js: Added.

(foo):

1:33 PM Changeset in webkit [156909] by zandobersek@gmail.com

6 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122275

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/fileapi/.

fileapi/Blob.idl:
fileapi/FileException.idl:
fileapi/FileList.idl:
fileapi/FileReader.idl:
fileapi/FileReaderSync.idl:

1:31 PM Changeset in webkit [156908] by zandobersek@gmail.com

47 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122271

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/dom/.

dom/CharacterData.idl:
dom/ChildNode.idl:
dom/ClientRectList.idl:
dom/Clipboard.idl:
dom/CompositionEvent.idl:
dom/CustomEvent.idl:
dom/DOMCoreException.idl:
dom/DOMImplementation.idl:
dom/DOMNamedFlowCollection.idl:
dom/DOMStringList.idl:
dom/DOMStringMap.idl:
dom/DataTransferItem.idl:
dom/DataTransferItemList.idl:
dom/DeviceMotionEvent.idl:
dom/DeviceOrientationEvent.idl:
dom/Document.idl:
dom/DocumentFragment.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Event.idl:
dom/EventException.idl:
dom/EventListener.idl:
dom/EventTarget.idl:
dom/KeyboardEvent.idl:
dom/MessageEvent.idl:
dom/MessagePort.idl:
dom/MouseEvent.idl:
dom/MutationEvent.idl:
dom/MutationObserver.idl:
dom/NamedNodeMap.idl:
dom/Node.idl:
dom/NodeFilter.idl:
dom/NodeIterator.idl:
dom/NodeList.idl:
dom/Range.idl:
dom/RangeException.idl:
dom/ShadowRoot.idl:
dom/Text.idl:
dom/TextEvent.idl:
dom/TouchEvent.idl:
dom/TouchList.idl:
dom/TreeWalker.idl:
dom/UIEvent.idl:
dom/WebKitNamedFlow.idl:
dom/WheelEvent.idl:

1:22 PM Changeset in webkit [156907] by zandobersek@gmail.com

12 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122269

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/xml/.

xml/DOMParser.idl:
xml/XMLHttpRequest.idl:
xml/XMLHttpRequestException.idl:
xml/XMLHttpRequestUpload.idl:
xml/XMLSerializer.idl:
xml/XPathEvaluator.idl:
xml/XPathException.idl:
xml/XPathExpression.idl:
xml/XPathNSResolver.idl:
xml/XPathResult.idl:
xml/XSLTProcessor.idl:

12:36 PM Changeset in webkit [156906] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

FTL::OSRExit::convertToForward() shouldn't misuse Operands<>::operator[]
https://bugs.webkit.org/show_bug.cgi?id=122336

Reviewed by Geoffrey Garen.

Changed code in change set r156900 to use the operand() accessor instead of operator[].

ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExit::convertToForward):

12:31 PM Changeset in webkit [156905] by betravis@adobe.com

4 edits
4 adds in trunk

[CSS Shapes] Shape Outside should relayout when set dynamically
https://bugs.webkit.org/show_bug.cgi?id=122197

Reviewed by Alexandru Chiculita.

Source/WebCore:

Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html

fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html

When shape outside is modified, dependent content needs to relayout. This patch
removes the float from the float lists and marks dependents for layout using
RenderBox::removeFloatingOrPositionedChildFromBlockLists(). This is the same
method used when switching from float: left to float: right and vice versa
(see RenderElement::styleWillChange).

rendering/RenderBox.cpp:

(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Mark shape-outside dependents
for layout.

rendering/RenderBox.h:

(WebCore::RenderBox::markShapeOutsideDependentsForLayout): Mark all the items that may be
affected by this shape-outside for relayout.

LayoutTests:

Test that a shape can be dynamically added, modified, or removed and that
content does a proper relayout.

fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html: Added.
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html: Added.

12:22 PM Changeset in webkit [156904] by Antti Koivisto

5 edits in trunk/Source/WebCore

Tighten markContainingBlocksForLayout
https://bugs.webkit.org/show_bug.cgi?id=122326

Reviewed by Anders Carlsson.

11:51 AM Changeset in webkit [156903] by akling@apple.com

98 edits in trunk/Source/WebCore

Node: removedFrom() and insertedInto() should use references.
<https://webkit.org/b/122315>

Reviewed by Anders Carlsson.

ContainerNode* -> ContainerNode&

11:41 AM Changeset in webkit [156902] by ap@apple.com

2 edits in trunk/Source/WebCore

Optimize strings copies in srcset parser
https://bugs.webkit.org/show_bug.cgi?id=121899

Patch by Romain Perier <Romain Perier> on 2013-10-04
Reviewed by Alexey Proskuryakov.

No new tests, covered by existing ones.

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseImagesWithScaleFromSrcsetAttribute): Don't copy
image.imageURL at each loop iteration, save indexes instead.
(WebCore::bestFitSourceForImageAttributes): Make a String for
the URL only when the corresponding candidate is chosen
by the selection algorithm. It reduces the number of copies
significantly and improves performance
(around 30% with the "Release" profile and 60% with the "Debug" one).

11:40 AM Changeset in webkit [156901] by g.czajkowski@samsung.com

14 edits
4 moves in trunk/LayoutTests

Tests added in r141354 erroneously assume correction suggestion to be in the context menu
https://bugs.webkit.org/show_bug.cgi?id=113742

Reviewed by Ryosuke Niwa.

Tests from r141354 erroneously assume that all WebKit ports populate
spell checking suggestion in the context menu.

Remove verification of spell checking suggestion and all context menu stuff from tests
that do that unnecessarily. Instead of that check whether spelling markers behave correctly,
for example, after deleting a text, double click or selecting a misspellings.

However, two tests are adapted to verify spell checking suggestions (their availability
rather than correctness, similarly to context-menu-suggestions.html).
Those are useful for ports which populate spelling suggestion in the context menu.

editing/spelling/resources/util.js:

(initSpellTest):
Do not assume that the tests are running with "Windows" editing behavior.
Unix ports do not make a selection for the misspelled word and they don't
require selection to get spell checking suggestions.

editing/spelling/spelling-changed-text-expected.txt:
editing/spelling/spelling-changed-text.html:
editing/spelling/spelling-double-clicked-word-expected.txt:
editing/spelling/spelling-double-clicked-word.html:
editing/spelling/spelling-exactly-selected-word-expected.txt:
editing/spelling/spelling-exactly-selected-word.html:

Remove verification of correction suggestion.
Instead of that check whether the spelling markers behave correctly.

editing/spelling/context-menu-suggestions-multiword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection-expected.txt.
editing/spelling/context-menu-suggestions-multiword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection.html.
editing/spelling/context-menu-suggestions-subword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-subword-selection-expected.txt.
editing/spelling/context-menu-suggestions-subword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-subword-selection.html.

Adapt those tests for platforms which populate spell check suggestion
in the context menu.

platform/efl-wk2/TestExpectations:

Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for EFL.

platform/gtk-wk2/TestExpectations:
platform/gtk/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

Update tests path due to rename.

11:38 AM Changeset in webkit [156900] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

FTL: Crash in OSRExit::convertToForward() using VirtualRegister.offset() as array index
https://bugs.webkit.org/show_bug.cgi?id=122332

Reviewed by Oliver Hunt.

Changed the uses of .offset(), which returns a negative number for locals, to be
toLocal() which returns a local's ordinal number.

ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExit::convertToForward):

11:34 AM Changeset in webkit [156899] by dpranke@chromium.org

2 edits in trunk/Tools

remove dpranke from webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=122331

Reviewed by Brent Fulgham.

Scripts/webkitpy/common/config/watchlist:

11:30 AM Changeset in webkit [156898] by timothy_horton@apple.com

3 edits in trunk/Tools

[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299

Reviewed by Beth Dakin.

TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:

The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.

11:26 AM Changeset in webkit [156897] by ap@apple.com

2 edits in trunk/Tools

Watchlist is broken after <http://trac.webkit.org/r156880>

Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.

11:20 AM Changeset in webkit [156896] by msaboff@apple.com

11 edits in trunk/Source/JavaScriptCore

Add callOperation to Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122306

Reviewed by Geoffrey Garen.

Created baseline JIT compatible versions for a few flavors of callOperation().
Migrated cti_op_new_regexp() and its caller to callOperation(operationNewRegexp()).

dfg/DFGOperations.cpp: Moved operationNewRegexp() to JITOperations
dfg/DFGOperations.h:
jit/JIT.h:

(JSC::JIT::appendCall):

jit/JITInlines.h:

(JSC::JIT::appendCallWithExceptionCheck):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::callOperation):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_regexp):

jit/JITOperations.cpp:
jit/JITOperations.h:
jit/JITStubs.cpp:
jit/JITStubs.h:
jit/JSInterfaceJIT.h:

11:20 AM Changeset in webkit [156895] by Brent Fulgham

29 edits
3 deletes in trunk/Tools

Remove Qt features from build and test tools
https://bugs.webkit.org/show_bug.cgi?id=122312

Reviewed by Anders Carlsson.

Scripts/build-dumprendertree:
Scripts/build-jsc:
Scripts/build-webkit:
Scripts/build-webkittestrunner:
Scripts/old-run-webkit-tests:

(openDumpTool):
(buildPlatformResultHierarchy):
(buildPlatformTestHierarchy):
(readSkippedFiles):

Scripts/run-launcher:
Scripts/run-qtwebkit-tests: Removed.
Scripts/run-webkit-tests:

(useNewRunWebKitTests):

Scripts/update-webkit:
Scripts/webkit-build-directory:
Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(setupCygwinEnv):
(copyInspectorFrontendFiles):
(setPathForRunningWebKitApp):

Scripts/webkitpy/common/checkout/baselineoptimizer.py:
Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_virtual_ports_filtered):

Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_reviewer_text):

Scripts/webkitpy/common/config/watchlist:
Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):

Scripts/webkitpy/port/base.py:

(Port.init):
(Port._port_flag_for_scripts):
(Port._wk2_port_name):

Scripts/webkitpy/port/builders.py:
Scripts/webkitpy/port/factory.py:

(platform_options):
(PortFactory):
(PortFactory._default_port):

Scripts/webkitpy/port/factory_unittest.py:

(FactoryTest.test_gtk):

Scripts/webkitpy/port/qt.py: Removed.
Scripts/webkitpy/port/qt_unittest.py: Removed.
Scripts/webkitpy/style/checker.py:
Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

Scripts/webkitpy/style/checkers/cmake.py:

(CMakeChecker):

Scripts/webkitpy/style/checkers/cpp.py:

(_classify_include):
(check_include_line):
(check_identifier_name_in_declaration):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_classify_include):
(WebKitStyleTest.test_names):

Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_determine_port_from_expectations_path):

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):

Scripts/webkitpy/tool/main.py:

(WebKitPatch):

10:00 AM Changeset in webkit [156894] by ap@apple.com

2 edits in trunk/Source/WebCore

Add svn:ignore to *.pyc files in inspector/Scripts directory, so that they don't
show up as unversioned all the time.

inspector/Scripts: Added property svn:ignore.

9:15 AM Changeset in webkit [156893] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Win][WebGL] Crash on exit
https://bugs.webkit.org/show_bug.cgi?id=120764

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-04
Reviewed by Martin Robinson.

On exit, libGLESv2.dll is detached from the process and relevant memory is released
before the atexit GL context cleanup handler is called, causing a NULL pointer crash.
The GL context cleanup code was originally written to avoid a X server crash on exit,
so it's only needed for PLATFORM(X11).

platform/graphics/GLContext.cpp: Only clean up active GL contexts on exit for PLATFORM(X11).

(WebCore::GLContext::cleanupSharedX11Display):
(WebCore::GLContext::cleanupActiveContextsAtExit):
(WebCore::GLContext::GLContext):
(WebCore::GLContext::~GLContext):

9:14 AM Changeset in webkit [156892] by commit-queue@webkit.org

6 edits in trunk

[GTK] Enable text edition UndoOperations support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122305

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.

GNUmakefile.list.am:
UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):

UIProcess/API/gtk/PageClientImpl.h:

LayoutTests:

platform/gtk-wk2/TestExpectations: Corrected the expectations

with the new results.

9:02 AM Changeset in webkit [156891] by mihnea@adobe.com

6 edits
2 adds in trunk

[CSSRegions] Regions as stacking contexts should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122321

Reviewed by Alexandru Chiculita.

Source/WebCore:

Test: fast/regions/layers/region-normalflow-stacking-context.html

Since regions are stacking contexts, they should not be in normal flow list of layers.
More clean-up after https://bugs.webkit.org/show_bug.cgi?id=117365 and https://bugs.webkit.org/show_bug.cgi?id=121828
which enabled the layers.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

LayoutTests:

Add a new test and modify existing tests to take into account the stacking context behavior
for non-positioned regions.

fast/regions/autoheight-regions-mark-expected.txt:
fast/regions/layers/region-normalflow-stacking-context-expected.html: Added.
fast/regions/layers/region-normalflow-stacking-context.html: Added.
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:

8:26 AM Changeset in webkit [156890] by andersca@apple.com

3 edits
1 delete in trunk/Source/WebKit

Remove WebAssertions.h
https://bugs.webkit.org/show_bug.cgi?id=122328

Reviewed by Jessie Berlin.

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Misc/WebAssertions.h: Removed.

8:22 AM Changeset in webkit [156889] by Michał Pakuła vel Rutka

3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Remove failure expectations from tests that are passing.

platform/efl-wk2/TestExpectations: update js/dom/create-lots-of-workers.html path.
platform/efl/TestExpectations:

7:22 AM Changeset in webkit [156888] by commit-queue@webkit.org

4 edits in trunk

[EFL] Enable correct behaviour for deleting regional indicator symbols
https://bugs.webkit.org/show_bug.cgi?id=122209

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-04
Reviewed by Gyuyoung Kim.

Source/WebCore:

Regional indicator symbols that are combined should behave as a single character when deleting.
Removed unused variable initialState.

rendering/RenderText.cpp:

(WebCore::RenderText::previousOffsetForBackwardDeletion):

LayoutTests:

Now editing/deleting/regional-indicators.html is passing on EFL port.

platform/efl/TestExpectations:

7:16 AM Changeset in webkit [156887] by commit-queue@webkit.org

12 edits in trunk/Source/WebKit2

Remove Qt leftovers from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122317

Patch by Sergio Correia <Sergio Correia> on 2013-10-04
Reviewed by Anders Carlsson.

Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):

Shared/API/c/WKBase.h:
Shared/NativeWebTouchEvent.h:
UIProcess/API/C/WebKit2_C.h:
UIProcess/BackingStore.h:
UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::inspectorUrlForPageID):

UIProcess/InspectorServer/WebInspectorServer.h:
UIProcess/InspectorServer/WebSocketServer.cpp:
UIProcess/InspectorServer/WebSocketServer.h:
UIProcess/WebPageProxy.cpp:
WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitializeWindowless):
(WebKit::NetscapePlugin::platformPaint):

5:23 AM Changeset in webkit [156886] by zandobersek@gmail.com

21 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122276

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/css/.

css/CSSHostRule.idl:
css/CSSMediaRule.idl:
css/CSSPrimitiveValue.idl:
css/CSSRuleList.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleSheet.idl:
css/CSSSupportsRule.idl:
css/CSSValueList.idl:
css/DOMWindowCSS.idl:
css/FontLoader.idl:
css/MediaList.idl:
css/MediaQueryList.idl:
css/MediaQueryListListener.idl:
css/StyleMedia.idl:
css/StyleSheet.idl:
css/StyleSheetList.idl:
css/WebKitCSSFilterValue.idl:
css/WebKitCSSKeyframesRule.idl:
css/WebKitCSSMatrix.idl:
css/WebKitCSSTransformValue.idl:

4:59 AM Changeset in webkit [156885] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122274

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/loader/appcache/.

loader/appcache/DOMApplicationCache.idl:

4:55 AM Changeset in webkit [156884] by zandobersek@gmail.com

4 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/plugins/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122273

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/plugins/.

plugins/DOMMimeTypeArray.idl:
plugins/DOMPlugin.idl:
plugins/DOMPluginArray.idl:

4:51 AM Changeset in webkit [156883] by zandobersek@gmail.com

3 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122272

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/storage/.

storage/Storage.idl:
storage/StorageEvent.idl:

4:41 AM Changeset in webkit [156882] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122270

Reviewed by Darin Adler.

This patch covers IDL interfaces under Source/WebCore/workers/.

workers/DedicatedWorkerGlobalScope.idl:
workers/Worker.idl:
workers/WorkerGlobalScope.idl:
workers/WorkerLocation.idl:

1:49 AM Changeset in webkit [156881] by abucur@adobe.com

5 edits
2 adds in trunk

[CSS Regions] Infinite loop when computing widows
https://bugs.webkit.org/show_bug.cgi?id=122215

Reviewed by David Hyatt.

Source/WebCore:

The patch ensures it's not possible to relayout a block indefinitely because of widows contraints. You can't
break a block more than once to account for widows. This can happen if, for example, some lines are moved
to the next container and there the content breaks in another container again without respecting the widows property.
This is in line with the idea of not leaving empty fragmentation containers during layout.

Test: fast/regions/regions-widows-stack-overflow.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):

rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData): Rename the m_shouldBreakAtLineToAvoidWidow
flag to m_didBreakAtLineToAvoidWidow.

(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow): Use the line index to determine if it should break or not.
(WebCore::RenderBlockFlow::didBreakAtLineToAvoidWidow): Use to determine if a break already happened because of widows.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

LayoutTests:

Test there is no stack overflow when trying to break for widows that are caused by other widows.

fast/regions/regions-widows-stack-overflow-expected.html: Added.
fast/regions/regions-widows-stack-overflow.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed