Timeline

Oct 7, 2013:

11:14 PM Changeset in webkit [157088] by ap@apple.com

• 2 edits in trunk/LayoutTests

webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
​https://bugs.webkit.org/show_bug.cgi?id=120148

• platform/mac-wk2/TestExpectations: Removed a duplicate expectation that I overlooked

at first. Note that having separate expectations for Debug and Release doesn't
appear to work.

11:09 PM Changeset in webkit [157087] by ap@apple.com

• 2 edits in trunk/LayoutTests

webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
​https://bugs.webkit.org/show_bug.cgi?id=120148

• platform/mac-wk2/TestExpectations: Updated expectations to cover debug assertions,

and that this is not limited to Lion.

11:03 PM Changeset in webkit [157086] by ap@apple.com

• 2 edits in trunk/LayoutTests

Layout Test mathml/very-large-stretchy-operators.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=122490

• platform/mac/TestExpectations: Skipped the test. It's faiing with a timeout and

taking up to 80 seconds.

9:44 PM Changeset in webkit [157085] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

EventDispatchBehavior is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=122483

Reviewed by Andreas Kling.

Removed EventDispatchBehavior and changed the return type of determineDispatchBehavior to bool.
Also renamed it to shouldEventCrossShadowBoundary to reflect the semantics more clear.

• dom/EventRetargeter.cpp:

(WebCore::shouldEventCrossShadowBoundary):
(WebCore::EventRetargeter::calculateEventPath):

• dom/EventRetargeter.h:

8:43 PM Changeset in webkit [157084] by fpizlo@apple.com

• 2 edits in trunk/Tools

run-jsc-stress-tests progress meter should update more quickly on older Rubies
​https://bugs.webkit.org/show_bug.cgi?id=122459

Reviewed by Darin Adler.

• Scripts/run-jsc-stress-tests:

8:38 PM Changeset in webkit [157083] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

Make buildRelatedNodeMap and findRelatedNode static to EventRetargeter.cpp
​https://bugs.webkit.org/show_bug.cgi?id=122477

Reviewed by Antti Koivisto.

Make EventRetargeter::buildRelatedNodeMap and EventRetargeter::findRelatedNode static local functions
in EventRetargeter.cpp since they're only called in EventRetargeter::calculateAdjustedNodes and don't
depend on any oher member function or variable (EventRetarger doesn't have any member variables).

Also get rid of Vector local variables in both functions as they're redundant.

• dom/EventRetargeter.cpp:

(WebCore::buildRelatedNodeMap): Moved. Replaced Vector<Node*, 32> relatedNodeStack by a single pointer
since the only time we add an item to this Vector is when it's empty, and we always use or remove the
last item.
(WebCore::addRelatedNodeForUnmapedTreeScopes): Renamed from EventRetargeter::findRelatedNode. Removed
Vector<TreeScope*, 32> parentTreeScopes since it only contains the ancestor tree scopes of scope up to
a tree scope already in relatedNodeMap. We could simply remember this tree scope and re-traverse the
ancestor tree scopes in the second loop.
(WebCore::EventRetargeter::calculateAdjustedNodes):

• dom/EventRetargeter.h:

8:29 PM Changeset in webkit [157082] by akling@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Pass VM instead of ExecState to JSNotAnObject constructor.
<​https://webkit.org/b/122474>

Reviewed by Sam Weinig.

JSNotAnObject was only using the ExecState to find the VM.

8:28 PM Changeset in webkit [157081] by akling@apple.com

• 5 edits in trunk/Source/WebCore

CTTE: EditCommand always has a Document.
<​https://webkit.org/b/122473>

Reviewed by Anders Carlsson.

Store a Ref<Document> in EditComment since it's never null.

Since Ref enforces more const consistency than RefPtr, I had to make
document() and frame() non-const here. Only a single method depended
on the old half-const behavior.

8:26 PM Changeset in webkit [157080] by kov@webkit.org

• 1 edit
  5 adds in trunk/LayoutTests

Gardening: add baselines for new tests.

• platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Added.
• platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Added.
• platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Added.
• platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Added.

7:49 PM Changeset in webkit [157079] by kov@webkit.org

• 2 edits in trunk/LayoutTests

Gardening: skip audio/video track tests, since those are not yet supported by our
media player.

• platform/gtk/TestExpectations:

7:40 PM Changeset in webkit [157078] by kov@webkit.org

• 2 edits in trunk/LayoutTests

Unreviewed. Marking svg/animations/svglengthlist-animation-3.html as flaky.

• platform/gtk/TestExpectations:

6:59 PM Changeset in webkit [157077] by Darin Adler

• 4 edits in trunk/Source/WTF

Improve HashMap::add comment and other similar comments
​https://bugs.webkit.org/show_bug.cgi?id=122432

Reviewed by Andreas Kling.

• wtf/HashCountedSet.h:
• wtf/HashMap.h:
• wtf/HashSet.h:

Updated comment wording. They were a bit old and out of date.
They also featured the word "interator".

6:37 PM Changeset in webkit [157076] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Update test again.

• bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::~JSTestCallback):

6:34 PM Changeset in webkit [157075] by commit-queue@webkit.org

• 29 edits in trunk/Source/WebCore

Unreviewed, rolling out r157061.
​http://trac.webkit.org/changeset/157061
​https://bugs.webkit.org/show_bug.cgi?id=122479

Broke worker tests (Requested by andersca on #webkit).

• Modules/webdatabase/Database.cpp:

(WebCore::DerefContextTask::create):
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::create):
(WebCore::DeliverPendingCallbackTask::performTask):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):

• Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):

• Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):

• Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):

• Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
• Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):

• bindings/js/JSCallbackData.h:

(WebCore::DeleteCallbackDataTask::create):
(WebCore::DeleteCallbackDataTask::performTask):
(WebCore::DeleteCallbackDataTask::isCleanupTask):
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):

• bindings/js/JSDOMGlobalObjectTask.h:
• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::queueTaskToEventLoop):

• bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

• dom/CrossThreadTask.h:

(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::performTask):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::performTask):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::performTask):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::performTask):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::performTask):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::performTask):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::performTask):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::performTask):
(WebCore::createCallbackTask):

• dom/Document.cpp:

(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):

• dom/Document.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ProcessMessagesSoonTask::create):
(WebCore::ProcessMessagesSoonTask::performTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):

• dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):

• dom/StringCallback.cpp:

(WebCore::StringCallback::scheduleCallback):

• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::create):
(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):

• workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):

• workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):

• workers/WorkerGlobalScope.h:
• workers/WorkerLoaderProxy.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerExceptionTask::performTask):
(WebCore::WorkerGlobalScopeDestroyedTask::create):
(WebCore::WorkerGlobalScopeDestroyedTask::performTask):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerTerminateTask::WorkerTerminateTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerThreadActivityReportTask::performTask):
(WebCore::PostMessageToPageInspectorTask::create):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::NotifyNetworkStateChangeTask::create):
(WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask):
(WebCore::NotifyNetworkStateChangeTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):

• workers/WorkerMessagingProxy.h:
• workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::Task):

• workers/WorkerRunLoop.h:
• workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownFinishTask::isCleanupTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):

6:28 PM Changeset in webkit [157074] by Darin Adler

• 4 edits in trunk/Source

Make Vector::insert work for move-only types
​https://bugs.webkit.org/show_bug.cgi?id=122429

Reviewed by Anders Carlsson.

Source/WebCore:

• history/HistoryItem.cpp:

(WebCore::HistoryItem::padDailyCountsForNewVisit): Call insertVector.
Also added some inline capacity, which should make this faster.

Source/WTF:

• wtf/Vector.h:

(WTF::Vector::insert): Take an rvalue reference instead of a const reference.
(WTF::Vector::insertVector): Renamed to avoid overloading troubles, analogous
to what we did for appendVector.

6:24 PM Changeset in webkit [157073] by kov@webkit.org

• 2 edits in trunk/Tools

[buildbot] parse tests that are reported as crashed correctly for GTK+
​https://bugs.webkit.org/show_bug.cgi?id=122476

Reviewed by Martin Robinson.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
as a failure of the API tests.

6:21 PM Changeset in webkit [157072] by kov@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Skipping API test that is causing the next one to crash,
see ​https://bugs.webkit.org/show_bug.cgi?id=121970.

• Scripts/run-gtk-tests:

(TestRunner):

6:04 PM Changeset in webkit [157071] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Update test results.

• bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::~JSTestCallback):

5:36 PM Changeset in webkit [157070] by Martin Robinson

• 19 edits
  8 adds in trunk

[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
​https://bugs.webkit.org/show_bug.cgi?id=121416

Source/WebCore:

Reviewed by David Hyatt.

Tests: mathml/presentation/mo-minus.html

mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html

MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.

Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.

With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.

• css/mathml.css:

Not sure what this line-height:0 was here for, but it caused bugs with the new code

• mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.

• mathml/MathMLTextElement.h:

(MathMLTextElement):

• rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):

• rendering/mathml/RenderMathMLBlock.h:

Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.

• rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.

• rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.

(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout

(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Return the stretched operator height, if appropriate.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.

• rendering/mathml/RenderMathMLOperator.h: Update method declarations.

LayoutTests:

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.

Add some reftests for stretchy operators.

• TestExpectations: The remaining MathML pixel tests are broken by this patch.
• LayoutTests/platform/gtk/TestExpectations:
• LayoutTests/platform/mac/TestExpectations:
• LayoutTests/platform/win/TestExpectations:
• mathml/presentation/mo-minus.html: Added.
• mathml/presentation/mo-stacked-glyphs-expected.html: Added.
• mathml/presentation/mo-stacked-glyphs.html: Added.
• mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
• mathml/presentation/mo-stretchy-vertical-bar.html: Added.
• mathml/very-large-stretchy-operators-expected.txt: Added.
• mathml/very-large-stretchy-operators.html: Added.

4:56 PM Changeset in webkit [157069] by kov@webkit.org

• 2 edits in trunk/Tools

[GTK] run-gtk-tests does not distinguish between failure and crashes
​https://bugs.webkit.org/show_bug.cgi?id=122135

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.

The GTK+ API test runner does not distinguish between failures and crashes. This change
makes it do that, so it's easier for us to spot the more important/higher priority crash
case.

• Scripts/run-gtk-tests:

(TestRunner._run_test_command): return the exit code instead of a boolean true/false,
so we have more information on how the process ended.
(TestRunner._run_test): check the exit code to distinguish between crashes and failures.
(TestRunner.run_tests): report crashes.

4:48 PM Changeset in webkit [157068] by eric.carlson@apple.com

• 38 edits
  27 adds in trunk

[MediaStream API] update MediaStreamTrack object to match spec
​https://bugs.webkit.org/show_bug.cgi?id=121940

Reviewed by Jer Noble.

Source/WebCore:

No new tests, existing test updated.

Add new source files to the project:

• CMakeLists.txt:
• DerivedSources.make:
• GNUmakefile.list.am:
• WebCore.xcodeproj/project.pbxproj:

New capability dictionary objects:

• Modules/mediastream/AllAudioCapabilities.h: Added.
• Modules/mediastream/AllAudioCapabilities.idl: Added.
• Modules/mediastream/AllVideoCapabilities.h: Added.
• Modules/mediastream/AllVideoCapabilities.idl: Added.

• Modules/mediastream/AudioStreamTrack.cpp:

(WebCore::AudioStreamTrack::create): New version that takes a MediaStreamTrack*.

• Modules/mediastream/AudioStreamTrack.h:

New object for a capability range:

• Modules/mediastream/CapabilityRange.cpp: Added.
• Modules/mediastream/CapabilityRange.h: Added.
• Modules/mediastream/CapabilityRange.idl: Added.

• Modules/mediastream/MediaConstraintsImpl.h: Make initialize() public.

New object for the current states for a media source.

• Modules/mediastream/MediaSourceStates.cpp: Added.
• Modules/mediastream/MediaSourceStates.h: Added.
• Modules/mediastream/MediaSourceStates.idl: Added.

Don't call the media stream center to notify it when the state of other
objects change.

• Modules/mediastream/MediaStream.cpp:

(WebCore::processTrack): Remove the stream source duplication hack.
(WebCore::createFromSourceVectors):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):

• Modules/mediastream/MediaStream.h:

New object for the capabilities of a source.

• Modules/mediastream/MediaStreamCapabilities.cpp: Added.
• Modules/mediastream/MediaStreamCapabilities.h: Added.
• Modules/mediastream/MediaStreamCapabilities.idl: Added.

Update interface to match spec.

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack): Define a copy constructor to use in clone().
(WebCore::MediaStreamTrack::setSource): Call removeObserver if the track already has a source.

Initialize m_muted from new source's muted state.

(WebCore::MediaStreamTrack::id): Allow source to provide ID as the spec suggests.
(WebCore::MediaStreamTrack::setEnabled): Add some spec text to clarify logic. Always call

source->setEnabled, it can figure out if nothing needs to be done.

(WebCore::MediaStreamTrack::muted): Don't call the stream center when muted changes, the

source can take care of notifying interested parties.

(WebCore::MediaStreamTrack::readonly): New.
(WebCore::MediaStreamTrack::remote): New.
(WebCore::MediaStreamTrack::constraints): New.
(WebCore::MediaStreamTrack::states): New.
(WebCore::MediaStreamTrack::capabilities): New.
(WebCore::MediaStreamTrack::applyConstraints): New.
(WebCore::MediaStreamTrack::clone): New.
(WebCore::MediaStreamTrack::stopProducingData): New.
(WebCore::MediaStreamTrack::sourceStateChanged): Renamed from sourceChangedState.
(WebCore::MediaStreamTrack::sourceMutedChanged): New.
(WebCore::MediaStreamTrack::sourceEnabledChanged): New.
(WebCore::MediaStreamTrack::configureTrackRendering): New.
(WebCore::MediaStreamTrack::stopped): New.
(WebCore::MediaStreamTrack::stop): Call stopProducingData.
(WebCore::MediaStreamTrack::scheduleEventDispatch): New.
(WebCore::MediaStreamTrack::dispatchQueuedEvents): New.

• Modules/mediastream/MediaStreamTrack.h:
• Modules/mediastream/MediaStreamTrack.idl:

• Modules/mediastream/MediaTrackConstraint.cpp: Added.
• Modules/mediastream/MediaTrackConstraint.h: Added.
• Modules/mediastream/MediaTrackConstraint.idl: Added.

Add empty classes/IDL for track constraint objects.

• Modules/mediastream/MediaTrackConstraintSet.cpp: Added.
• Modules/mediastream/MediaTrackConstraintSet.h: Added.
• Modules/mediastream/MediaTrackConstraintSet.idl: Added.
• Modules/mediastream/MediaTrackConstraints.cpp: Added.
• Modules/mediastream/MediaTrackConstraints.h: Added.
• Modules/mediastream/MediaTrackConstraints.idl: Added.

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::callSuccessHandler): Don't call the stream center, the

stream can take care of notifying interested parties.

Add a constructor and create() that take a MediaStreamTrack*.

• Modules/mediastream/VideoStreamTrack.cpp:

(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack):

• Modules/mediastream/VideoStreamTrack.h:

Create a MediaStreamSource subclass for WebAudio

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource): Call isAudioStreamSource instead

of checking deviceID.

• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): Create a

MediaStreamAudioSource instead of a MediaStreamSource.

• Modules/webaudio/MediaStreamAudioDestinationNode.h:
• Modules/webaudio/MediaStreamAudioSource.cpp: Added.
• Modules/webaudio/MediaStreamAudioSource.h: Added.

(WebCore::MediaStreamAudioSource::~MediaStreamAudioSource):

Add new generated files.

• bindings/js/JSMediaSourceStatesCustom.cpp: Added.
• bindings/js/JSMediaStreamCapabilitiesCustom.cpp: Added.

• dom/EventNames.h: Defined 'overconstrained' event.

• platform/mediastream/MediaStreamCenter.h: Get rid of all of the methods nobody uses.

It isn't clear that they are necessary, and we can add them back if/when we need them.

• platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::~MediaStreamDescriptor): Clear the all source streams.
(WebCore::MediaStreamDescriptor::removeSource): Clear the source stream.

• platform/mediastream/MediaStreamDescriptor.h:

Make MediaStreamSource an abstract base class, and remove everyting WebAudio-specific
to MediaStreamAudioSource.

• platform/mediastream/MediaStreamSource.cpp:

(WebCore::MediaStreamSource::MediaStreamSource): Remove readyState and requiresConsumer

parameters. Create new UUID for id if non was passed.

(WebCore::MediaStreamSource::reset): Reset internal state to just-constructed. Used for testing.
(WebCore::MediaStreamSource::setReadyState): sourceChangedState -> sourceStateChanged.
(WebCore::MediaStreamSource::setStream): Remove the ASSERT that check for a source being

added to a new stream. This is still a problem, but it is required for testing and will
be fixed as a part of bug 121954.

(WebCore::MediaStreamSource::setConstraints): Added.
(WebCore::MediaStreamSource::setMuted): Notify observers when muted changes.
(WebCore::MediaStreamSource::setEnabled): Notify observers when enabled changes.
(WebCore::MediaStreamSource::readonly): New.
(WebCore::MediaStreamSource::stop): New. Set state to Ended when all of the observers has

stopped.

• platform/mediastream/MediaStreamSource.h:

Define platform versions of the Capabilities classes.

• platform/mediastream/MediaStreamSourceCapabilities.h: Added.

Update the non-functional platform stream centers for the API changes.

• platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
• platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
• platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
• platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
• platform/mediastream/mac/MediaStreamCenterMac.cpp:
• platform/mediastream/mac/MediaStreamCenterMac.h:

Update the Mock stream center for the API changes. Add a concrete mock MediaStreamSource
subclass.

• platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockSource::MockSource): New, the mock media stream source.
(WebCore::MockSource::~MockSource):
(WebCore::MockSource::capabilities):
(WebCore::MockSource::states):
(WebCore::mockSourceMap):
(WebCore::mockAudioSourceID):
(WebCore::mockVideoSourceID):
(WebCore::initializeMockSources): Create one audio and one video mock source.
(WebCore::MockMediaStreamCenter::registerMockMediaStreamCenter): Call initializeMockSources.
(WebCore::MockMediaStreamCenter::createMediaStream): Use the already allocated mock media

sources.

(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): Ditto.

• platform/mock/MockMediaStreamCenter.h:

LayoutTests:

• fast/mediastream/MediaStreamTrack-expected.txt:
• fast/mediastream/MediaStreamTrack.html:
• fast/mediastream/MediaStreamTrack-getSources-expected.txt:
• fast/mediastream/MediaStreamTrack-getSources.html:

4:43 PM Changeset in webkit [157067] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Missing packages for APT on install-dependencies
​https://bugs.webkit.org/show_bug.cgi?id=121555

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-10-07
Reviewed by Martin Robinson.

• gtk/install-dependencies: add packages that are needed for

building WebKit itself and the jhbuild dependencies.

4:33 PM Changeset in webkit [157066] by andersca@apple.com

• 2 edits in trunk/Source/WTF

Fix Windows build.

• wtf/StdLibExtras.h:

(std::make_unique):

4:05 PM Changeset in webkit [157065] by akling@apple.com

• 35 edits in trunk/Source/WebCore

CTTE: Live node lists always have an owner Node.
<​https://webkit.org/b/122470>

Reviewed by Anders Carlsson.

Make LiveNodeListBase::m_ownerNode a Ref<Node> instead of a RefPtr
and have all constructors take Node&.

4:01 PM Changeset in webkit [157064] by kov@webkit.org

• 3 edits in trunk/Source/WebKit2

Reduce duplicated code in WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=122230

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk> on 2013-10-07
Reviewed by Darin Adler.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): move duplicate code to resetState and call it.
(WebKit::WebPageProxy::resetState): new private method for code that is shared between
close and resetStateAfterProcessExited.
(WebKit::WebPageProxy::resetStateAfterProcessExited): move duplicate code to resetState
and call it.

• UIProcess/WebPageProxy.h:

3:58 PM Changeset in webkit [157063] by andersca@apple.com

• 3 edits in trunk/Tools

Fix test failures.

• Scripts/webkitpy/port/base.py:

(Port.to.start_helper):

• Scripts/webkitpy/port/mock_drt.py:

(MockDRTPort.start_helper):

3:46 PM Changeset in webkit [157062] by fpizlo@apple.com

• 4 edits in trunk/Source/JavaScriptCore

FTL memory allocator should be able to allocate data sections in non-executable memory
​https://bugs.webkit.org/show_bug.cgi?id=116189

Reviewed by Sam Weinig.

Use a RefCountedArray<int64_t> for data sections. This works out great because
RefCountedArray<> knows its own size and because the reference counting makes passing
it around very easy (you don't have to stress out about ownership).

• ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::compile):

• ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::addDataSection):

• ftl/FTLJITCode.h:

(JSC::FTL::JITCode::dataSections):

3:37 PM Changeset in webkit [157061] by andersca@apple.com

• 29 edits in trunk/Source/WebCore

Clean up ScriptExecutionContext::Task and subclasses
​https://bugs.webkit.org/show_bug.cgi?id=122469

Reviewed by Andreas Kling.

• Modules/webdatabase/Database.cpp:

(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):

• Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):

• Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):

• Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):

• Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
• Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):

• bindings/js/JSCallbackData.h:

(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):

• bindings/js/JSDOMGlobalObjectTask.h:
• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::queueTaskToEventLoop):

• bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

• dom/CrossThreadTask.h:

(WebCore::createCallbackTask):

• dom/Document.cpp:

(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):

• dom/Document.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ProcessMessagesSoonTask::ProcessMessagesSoonTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):

• dom/ScriptExecutionContext.h:
• dom/StringCallback.cpp:

(WebCore::StringCallback::scheduleCallback):

• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):

• workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):

• workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):

• workers/WorkerGlobalScope.h:
• workers/WorkerLoaderProxy.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):

• workers/WorkerMessagingProxy.h:
• workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):

• workers/WorkerRunLoop.h:
• workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::WorkerThreadShutdownFinishTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):

3:25 PM Changeset in webkit [157060] by roger_fong@apple.com

• 4 edits in trunk/Source

Modify WTF and JavaScriptCore makefiles for x64 build.
​https://bugs.webkit.org/show_bug.cgi?id=122467.
<rdar://problem/15169174>.

Reviewed by Brent Fulgham.

• WTF.vcxproj/WTF.make:
• JavaScriptCore.vcxproj/JavaScriptCore.make:

3:08 PM Changeset in webkit [157059] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom()
​https://bugs.webkit.org/show_bug.cgi?id=122363

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-07
Reviewed by Filip Pizlo.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

1:34 PM Changeset in webkit [157058] by commit-queue@webkit.org

• 61 edits in trunk/Source

CTTE: Use references in and around DragController
​https://bugs.webkit.org/show_bug.cgi?id=122427

Patch by Sam Weinig <​sam@webkit.org> on 2013-10-07
Reviewed by Andreas Kling.

Source/WebCore:

Use references to indicate non-nullness of DragController related
objects.

Source/WebKit/efl:

• WebCoreSupport/DragClientEfl.cpp:

(WebCore::DragClientEfl::willPerformDragDestinationAction):
(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::actionMaskForDrag):
(WebCore::DragClientEfl::startDrag):

• WebCoreSupport/DragClientEfl.h:

Source/WebKit/gtk:

• WebCoreSupport/DragClientGtk.cpp:

(WebKit::DragClient::willPerformDragDestinationAction):
(WebKit::DragClient::willPerformDragSourceAction):
(WebKit::DragClient::actionMaskForDrag):
(WebKit::DragClient::startDrag):

• WebCoreSupport/DragClientGtk.h:
• webkit/webkitwebview.cpp:

(dragExitedCallback):
(webkit_web_view_drag_motion):
(webkit_web_view_drag_data_received):
(webkit_web_view_drag_drop):

Source/WebKit/mac:

• WebCoreSupport/WebDragClient.h:
• WebCoreSupport/WebDragClient.mm:

(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):

• WebView/WebFrame.mm:

(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):

• WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

• WebView/WebView.mm:

(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):

Source/WebKit/win:

• WebCoreSupport/WebDragClient.cpp:

(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):

• WebCoreSupport/WebDragClient.h:

Source/WebKit2:

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):
(dragExitedCallback):
(webkitWebViewBaseDragDrop):

• UIProcess/API/mac/WKView.mm:

(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction):

• UIProcess/WebPageProxy.h:
• WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):

• WebProcess/WebCoreSupport/WebDragClient.h:
• WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::WebDragClient::startDrag):

• WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag):
(WebKit::cachedImage):
(WebKit::WebDragClient::declareAndWriteDragImage):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

1:28 PM Changeset in webkit [157057] by andersca@apple.com

• 5 edits in trunk/Tools

Always force discrete mode when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=122465

Reviewed by Tim Horton.

This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Link with IOKit.

• DumpRenderTree/mac/LayoutTestHelper.m:

(installLayoutTestColorProfile):
Check installColorProfile.

(restoreUserColorProfile):
Check installColorProfile.

(lockDownDiscreteGraphics):
New function to force discrete graphics.

(main):
Add '--install-color-profile' option.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._set_up_run):
Always start the helper, but pass self._options.pixel_tests to it.

• Scripts/webkitpy/port/mac.py:

(MacPort.start_helper):
Pass --install-color-profile' to the helper if pixel_tests is true.

1:27 PM Changeset in webkit [157056] by timothy_horton@apple.com

• 9 edits in trunk/Source

Animated images are not restarted when page visibility changes
​https://bugs.webkit.org/show_bug.cgi?id=122464
<rdar://problem/14293474>

Reviewed by Simon Fraser.

Always kickstart animated images when the page visibility changes,
which can occur via window occlusion, and which is independent of in-window
state, which we were previously using to advance animation.

No new tests; attempts to make a test have resulted only in a flaky, timing-dependent test.

• page/Frame.cpp:

(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
Move this call to resumeAnimatingImages() up to Page.

• page/FrameView.cpp:

(WebCore::FrameView::setIsInWindow):
Move this call to resumeAnimatingImages() up to Page.

• WebCore.exp.in
• page/FrameView.h:
• page/Page.h:

Move resumeAnimatingImages() itself up to Page.

• page/Page.cpp:

(WebCore::Page::setIsInWindow):
Resume animated images when we move in-window.

(WebCore::Page::setVisibilityState):
Resume animated images when we become visible.
This is the one we were previously missing.

(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
Resume animated images when we're told to.

(WebCore::Page::resumeAnimatingImages):
Kickstart any animated images in all frames.

1:04 PM Changeset in webkit [157055] by dino@apple.com

• 4 edits
  3 adds in trunk

[Mac] Drawing video into canvas doesn't work on the first attempt
​https://bugs.webkit.org/show_bug.cgi?id=122404

Patch by Jer Noble <​jer.noble@apple.com> on 2013-10-07
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-canvas-drawing.html

If creating and painting from an AVPlayerItemVideoOutput fails, fall back
to the (much slower) AVAssetImageGenerator path. Make sure to revert to the
AVPlayerItemVideoOutput path when that object begins to have available
images, however.

To do so, remove the "MAC_OS_X_VERSION_MIN_REQUIRED < 1080" check around
the AVAssetImageGenerator code, and allow both the image generator and video
output to exist simultaneously.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationObjC::videoOutputHasAvailableFrame):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

LayoutTests:

• media/video-canvas-drawing-expected.png: Added.
• media/video-canvas-drawing-expected.txt: Added.
• media/video-canvas-drawing.html: Added.

12:12 PM Changeset in webkit [157054] by jer.noble@apple.com

• 5 edits
  6 moves in trunk/Source/WebCore

URLMediaSource.idl and URLMediaStream.idl are wrong
​https://bugs.webkit.org/show_bug.cgi?id=122301

Reviewed by Philippe Normand.

Rename URLMediaSource and URLMediaStream to DOMURLMediaSource and DOMURLMediaStream,
respectively.

Update the build files:

• CMakeLists.txt: Rename URL -> DOMURL.
• DerivedSources.make: Ditto.
• GNUmakefile.list.am: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.

Rename the .idl and implementation files:

• Modules/mediasource/DOMURLMediaSource.cpp: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.cpp.

(WebCore::DOMURLMediaSource::createObjectURL):

• Modules/mediasource/DOMURLMediaSource.h: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.h.
• Modules/mediasource/DOMURLMediaSource.idl: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.idl.
• Modules/mediastream/DOMURLMediaStream.cpp: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.cpp.

(WebCore::DOMURLMediaStream::createObjectURL):

• Modules/mediastream/DOMURLMediaStream.h: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.h.
• Modules/mediastream/DOMURLMediaStream.idl: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.idl.

11:58 AM Changeset in webkit [157053] by timothy_horton@apple.com

• 2 edits in trunk/LayoutTests

css3/images/cross-fade-svg-with-opacity.html fails with colorspace mismatch on Mountain Lion
​https://bugs.webkit.org/show_bug.cgi?id=122456

• platform/mac-wk2/TestExpectations:

Mark the test as failing for now.

11:52 AM Changeset in webkit [157052] by timothy@apple.com

• 3 edits in trunk/Tools

Properly count binding test failures as failures.

Fix the total for multiple failures in different steps too by avoiding undefined.

​https://bugs.webkit.org/show_bug.cgi?id=122232

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

(BuildbotTestResults):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

11:50 AM Changeset in webkit [157051] by mihnea@adobe.com

• 1 edit
  36 moves
  1 add in trunk/LayoutTests

[CSSRegions] Move region styling tests into fast/regions/region-styling
​https://bugs.webkit.org/show_bug.cgi?id=122451

Reviewed by Sam Weinig.

Create region-styling folder under fast/regions and move related region styling tests.

• fast/regions/region-styling/parse-incomplete-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule-expected.txt.
• fast/regions/region-styling/parse-incomplete-region-rule.html: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule.html.
• fast/regions/region-styling/parsing-region-style-rule-expected.txt: Renamed from LayoutTests/fast/regions/parsing-region-style-rule-expected.txt.
• fast/regions/region-styling/parsing-region-style-rule.html: Renamed from LayoutTests/fast/regions/parsing-region-style-rule.html.
• fast/regions/region-styling/region-rule-nested-region-rule-expected.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule-expected.html.
• fast/regions/region-styling/region-rule-nested-region-rule.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule.html.
• fast/regions/region-styling/region-style-block-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color-expected.html.
• fast/regions/region-styling/region-style-block-background-color.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color.html.
• fast/regions/region-styling/region-style-block-background-color2-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2-expected.html.
• fast/regions/region-styling/region-style-block-background-color2.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2.html.
• fast/regions/region-styling/region-style-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-color-expected.html.
• fast/regions/region-styling/region-style-color.html: Renamed from LayoutTests/fast/regions/region-style-color.html.
• fast/regions/region-styling/region-style-image-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color-expected.html.
• fast/regions/region-styling/region-style-image-background-color.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color.html.
• fast/regions/region-styling/region-style-in-columns-expected.html: Renamed from LayoutTests/fast/regions/region-style-in-columns-expected.html.
• fast/regions/region-styling/region-style-in-columns.html: Renamed from LayoutTests/fast/regions/region-style-in-columns.html.
• fast/regions/region-styling/region-style-inline-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color-expected.html.
• fast/regions/region-styling/region-style-inline-background-color.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color.html.
• fast/regions/region-styling/region-style-not-supported-properties-expected.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties-expected.html.
• fast/regions/region-styling/region-style-not-supported-properties.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties.html.
• fast/regions/region-styling/region-style-rule-position-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-position-expected.html.
• fast/regions/region-styling/region-style-rule-position.html: Renamed from LayoutTests/fast/regions/region-style-rule-position.html.
• fast/regions/region-styling/region-style-rule-specificity-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity-expected.html.
• fast/regions/region-styling/region-style-rule-specificity.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity.html.
• fast/regions/region-styling/region-styling-mediaquery-expected.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery-expected.html.
• fast/regions/region-styling/region-styling-mediaquery.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery.html.
• fast/regions/region-styling/remove-leftover-anon-block-crash-expected.txt: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash-expected.txt.
• fast/regions/region-styling/remove-leftover-anon-block-crash.html: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash.html.
• fast/regions/region-styling/removed-element-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash-expected.txt.
• fast/regions/region-styling/removed-element-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash.html.
• fast/regions/region-styling/render-region-custom-style-mark-expected.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark-expected.html.
• fast/regions/region-styling/render-region-custom-style-mark.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark.html.
• fast/regions/region-styling/set-box-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash-expected.txt.
• fast/regions/region-styling/set-box-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash.html.
• fast/regions/region-styling/webkit-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/webkit-region-rule-expected.txt.
• fast/regions/region-styling/webkit-region-rule.html: Renamed from LayoutTests/fast/regions/webkit-region-rule.html.

11:20 AM Changeset in webkit [157050] by msaboff@apple.com

• 17 edits in trunk/Source/JavaScriptCore

Transition stack check JITStubs to CCallHelper functions
​https://bugs.webkit.org/show_bug.cgi?id=122289

Reviewed by Filip Pizlo.

Replaced jit stubs cti_stack_check, cti_op_call_arityCheck and cti_op_construct_arityCheck with
jit operations operationStackCheck, operationCallArityCheck & operationConstructArityCheck.
Added new callOperationWithCallFrameRollbackOnException() in baseline and DFG JITs to call
these new functions. Added code to unwind one frame in JIT::privateCompileExceptionHandlers()
and JITCompiler::compileExceptionHandlers() for these cases that need to throw exceptions in
their caller frame when the stack is exhausted.

• assembler/MacroAssembler.h:

(JSC::MacroAssembler::andPtr): Added to handle masking a pointer with a literal.

• assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::and64): Added to handle masking a pointer with a literal.

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::exceptionCheckWithCallFrameRollback):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperationWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnExceptionSetResult):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• interpreter/CallFrame.h:

(JSC::ExecState::hostCallFrameFlag):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::jitAssertIsNull):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::jitAssertIsNull):

• jit/JIT.cpp:

(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):

• jit/JIT.h:

(JSC::JIT::exceptionCheckWithCallFrameRollback):

• jit/JITInlines.h:

(JSC::JIT::appendCallWithCallFrameRollbackOnException):
(JSC::JIT::callOperationWithCallFrameRollbackOnException):

• jit/JITOperations.cpp:
• jit/JITOperations.h:
• jit/JITStubs.cpp:
• jit/JITStubs.h:

11:07 AM Changeset in webkit [157049] by andersca@apple.com

• 3 edits in trunk/Source/WTF

Remove passIn and passOut from HashTraits
​https://bugs.webkit.org/show_bug.cgi?id=122452

Reviewed by Sam Weinig.

Change RefPtrHashMap to not use passOut (just like the regular HashMap) and get rid of the
passIn and passOut functions and related typedefs.

• wtf/HashTraits.h:
• wtf/RefPtrHashMap.h:

10:45 AM Changeset in webkit [157048] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Conditional support in bindings code generator for overloaded functions
​https://bugs.webkit.org/show_bug.cgi?id=122443

Patch by Philippe Normand <​pnormand@igalia.com> on 2013-10-07
Reviewed by Darin Adler.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateOverloadedFunction): Generate conditional for overloaded
function, if it's present in the idl.
(GenerateImplementation): Close the last overloaded function
conditional before generating the distpatch function.

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
Rebaseline overloaded function tests.

10:42 AM Changeset in webkit [157047] by fpizlo@apple.com

• 4 edits in trunk

ASSERTION FAILED: isUInt32() in jsc-layout-tests.yaml/js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js.layout-dfg-eager-no-cjit
​https://bugs.webkit.org/show_bug.cgi?id=122419

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

AI was using JSValue::asUInt32() incorrectly. That method presumes that the input is
both a int32 and a uint32 (it's in the range [0, 2^{31)). The UInt32ToNumber node is
instead dealing with an input that is always represented as a int32 but that has the
meaning of a uint32 - so AI should use JSValue::asInt32() and then do the cast.}

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

LayoutTests:

Reviewed by Oliver Hunt.

• js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:

9:59 AM Changeset in webkit [157046] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[sh4] Jump over maxJumpReplacementSize in revertJumpToMove.
​https://bugs.webkit.org/show_bug.cgi?id=120007

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-07
Reviewed by Oliver Hunt.

Jump over maxJumpReplacementSize in revertJumpToMove, even if there is no constant
value within the area. This patch fixes debug ASSERTs failures for sh4 architecture.

• assembler/SH4Assembler.h:

(JSC::SH4Assembler::revertJumpToMove):

9:48 AM Changeset in webkit [157045] by timothy_horton@apple.com

• 3 edits
  2 adds in trunk

-webkit-cross-fade paints SVGs at full opacity during cross-fade
​https://bugs.webkit.org/show_bug.cgi?id=122441
<rdar://problem/13973162>

Reviewed by Simon Fraser.

Test: css3/images/cross-fade-svg-with-opacity.html

• platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
Factor the image painting out into a function.
Conditionally use a transparency layer around painting if the image
we're drawing is an SVG (SVGImage is the only Image subclass that will
not respect the context's opacity).

Add a test that ensures that -cross-fade with SVG images draws correctly.

• css3/images/cross-fade-svg-with-opacity-expected.html: Added.
• css3/images/cross-fade-svg-with-opacity.html: Added.

9:26 AM Changeset in webkit [157044] by andersca@apple.com

• 251 edits in trunk/Source

Add OVERRIDE and virtual where appropriate
​https://bugs.webkit.org/show_bug.cgi?id=122439

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

• API/JSAPIWrapperObject.mm:
• API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::~JSCallbackObjectData):

• API/JSManagedValue.mm:
• API/JSScriptRef.cpp:

(OpaqueJSScript::~OpaqueJSScript):

• bytecode/CodeBlock.h:
• bytecode/StructureStubClearingWatchpoint.h:
• dfg/DFGArrayifySlowPathGenerator.h:
• dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
• dfg/DFGFailedFinalizer.h:
• dfg/DFGJITCode.h:
• dfg/DFGJITFinalizer.h:
• dfg/DFGSaneStringGetByValSlowPathGenerator.h:
• dfg/DFGSlowPathGenerator.h:
• dfg/DFGSpeculativeJIT64.cpp:
• heap/Heap.h:
• heap/IncrementalSweeper.h:
• heap/SuperRegion.h:
• jit/ClosureCallStubRoutine.h:
• jit/ExecutableAllocatorFixedVMPool.cpp:
• jit/GCAwareJITStubRoutine.h:
• jit/JITCode.h:
• jit/JITStubs.cpp:
• jit/JITToDFGDeferredCompilationCallback.h:
• jit/JumpReplacementWatchpoint.h:
• parser/Nodes.h:
• runtime/DataView.h:
• runtime/GCActivityCallback.h:
• runtime/GenericTypedArrayView.h:
• runtime/RegExpCache.h:
• runtime/SimpleTypedArrayController.h:
• runtime/WeakMapData.h:

Source/WebCore:

• Modules/encryptedmedia/MediaKeys.h:
• Modules/webaudio/AnalyserNode.h:
• Modules/webaudio/AudioBasicInspectorNode.h:
• Modules/webaudio/AudioBasicProcessorNode.h:
• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/AudioContext.h:
• Modules/webaudio/AudioDestinationNode.h:
• Modules/webaudio/AudioProcessingEvent.h:
• Modules/webaudio/BiquadDSPKernel.h:
• Modules/webaudio/BiquadProcessor.h:
• Modules/webaudio/ChannelMergerNode.h:
• Modules/webaudio/ChannelSplitterNode.h:
• Modules/webaudio/ConvolverNode.h:
• Modules/webaudio/DelayDSPKernel.h:
• Modules/webaudio/DelayProcessor.h:
• Modules/webaudio/DynamicsCompressorNode.h:
• Modules/webaudio/GainNode.h:
• Modules/webaudio/MediaElementAudioSourceNode.h:
• Modules/webaudio/OfflineAudioCompletionEvent.h:
• Modules/webaudio/OfflineAudioDestinationNode.h:
• Modules/webaudio/OscillatorNode.h:
• Modules/webaudio/PannerNode.h:
• Modules/webaudio/ScriptProcessorNode.h:
• Modules/webaudio/WaveShaperProcessor.h:
• accessibility/AccessibilityARIAGrid.h:
• accessibility/AccessibilityARIAGridCell.h:
• accessibility/AccessibilityARIAGridRow.h:
• accessibility/AccessibilityImageMapLink.h:
• accessibility/AccessibilityList.h:
• accessibility/AccessibilityListBox.h:
• accessibility/AccessibilityListBoxOption.h:
• accessibility/AccessibilityMediaControls.h:
• accessibility/AccessibilityMenuList.h:
• accessibility/AccessibilityMenuListOption.h:
• accessibility/AccessibilityMenuListPopup.h:
• accessibility/AccessibilityMockObject.h:
• accessibility/AccessibilityNodeObject.h:
• accessibility/AccessibilityProgressIndicator.h:
• accessibility/AccessibilityRenderObject.h:
• accessibility/AccessibilitySVGRoot.h:
• accessibility/AccessibilityScrollView.h:
• accessibility/AccessibilityScrollbar.h:
• accessibility/AccessibilitySlider.h:
• accessibility/AccessibilitySpinButton.h:
• accessibility/AccessibilityTable.h:
• accessibility/AccessibilityTableCell.h:
• accessibility/AccessibilityTableColumn.h:
• accessibility/AccessibilityTableHeaderContainer.h:
• accessibility/AccessibilityTableRow.h:
• bindings/js/JSEventListener.h:
• bindings/js/WebCoreTypedArrayController.h:
• bridge/c/c_class.h:
• bridge/c/c_instance.h:
• bridge/c/c_runtime.h:
• bridge/runtime_root.h:
• css/CSSBasicShapes.h:
• css/CSSComputedStyleDeclaration.h:
• css/CSSStyleSheet.h:
• dom/Attr.h:
• dom/BeforeTextInsertedEvent.h:
• dom/CDATASection.h:
• dom/ChildNodeList.h:
• dom/DatasetDOMStringMap.h:
• dom/Document.h:
• dom/DocumentEventQueue.h:
• dom/DocumentFragment.h:
• dom/Element.h:
• dom/ErrorEvent.h:
• dom/KeyboardEvent.h:
• dom/Node.h:
• dom/PageTransitionEvent.h:
• dom/ProgressEvent.h:
• dom/PseudoElement.h:
• dom/ScriptExecutionContext.h:
• dom/ShadowRoot.h:
• dom/StyledElement.h:
• dom/TagNodeList.h:
• dom/Text.h:
• dom/TextEvent.h:
• dom/TransitionEvent.h:
• dom/UIEvent.h:
• dom/WebKitAnimationEvent.h:
• dom/WebKitTransitionEvent.h:
• editing/ApplyBlockElementCommand.h:
• editing/ApplyStyleCommand.h:
• editing/BreakBlockquoteCommand.h:
• editing/CompositeEditCommand.h:
• editing/SpellingCorrectionCommand.h:
• fileapi/File.h:
• fileapi/FileThreadTask.h:
• history/BackForwardList.h:
• html/BaseCheckableInputType.h:
• html/HTMLAnchorElement.h:
• html/HTMLAreaElement.h:
• html/HTMLCanvasElement.h:
• html/HTMLCollection.h:
• html/HTMLElement.h:
• html/HTMLFieldSetElement.h:
• html/HTMLFormControlElement.h:
• html/HTMLFormControlElementWithState.h:
• html/HTMLFormElement.h:
• html/HTMLFrameElementBase.h:
• html/HTMLImageElement.h:
• html/HTMLImageLoader.h:
• html/HTMLInputElement.h:
• html/HTMLLabelElement.h:
• html/HTMLLegendElement.h:
• html/HTMLMediaElement.h:
• html/HTMLMeterElement.h:
• html/HTMLOptGroupElement.h:
• html/HTMLOptionElement.h:
• html/HTMLPlugInElement.h:
• html/HTMLPlugInImageElement.h:
• html/HTMLProgressElement.h:
• html/HTMLSelectElement.h:
• html/HTMLTableElement.h:
• html/HTMLTextAreaElement.h:
• html/HTMLTextFormControlElement.h:
• html/HTMLVideoElement.h:
• html/canvas/CanvasRenderingContext2D.cpp:
• html/shadow/MediaControlElementTypes.h:
• html/shadow/MediaControlElements.h:
• html/shadow/SpinButtonElement.h:
• html/shadow/TextControlInnerElements.h:
• html/track/AudioTrackList.h:
• html/track/TextTrackList.h:
• html/track/TrackListBase.h:
• inspector/InspectorValues.h:
• loader/EmptyClients.h:
• loader/ImageLoader.h:
• loader/ResourceLoader.h:
• loader/SubresourceLoader.h:
• loader/appcache/ApplicationCacheGroup.cpp:
• loader/appcache/ApplicationCacheGroup.h:
• loader/appcache/DOMApplicationCache.h:
• loader/archive/cf/LegacyWebArchive.h:
• loader/cache/CachedCSSStyleSheet.h:
• loader/cache/CachedFont.h:
• loader/cache/CachedFontClient.h:
• loader/cache/CachedImageClient.h:
• loader/cache/CachedSVGDocumentClient.h:
• loader/cache/CachedStyleSheetClient.h:
• loader/cache/CachedXSLStyleSheet.h:
• page/Chrome.h:
• page/DOMWindow.h:
• page/FrameView.h:
• page/animation/ImplicitAnimation.h:
• platform/PODIntervalTree.h:
• platform/PODRedBlackTree.h:
• platform/ScrollView.h:
• platform/Scrollbar.h:
• platform/Timer.h:
• platform/animation/TimingFunction.h:

(WebCore::LinearTimingFunction::~LinearTimingFunction):
(WebCore::CubicBezierTimingFunction::~CubicBezierTimingFunction):
(WebCore::StepsTimingFunction::~StepsTimingFunction):

• platform/audio/AudioDSPKernelProcessor.h:
• platform/audio/HRTFPanner.h:
• platform/audio/mac/AudioDestinationMac.h:
• platform/graphics/SimpleFontData.h:
• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/filters/FilterOperation.h:
• platform/network/ResourceHandle.h:
• rendering/AutoTableLayout.h:
• rendering/ClipPathOperation.h:
• rendering/InlineFlowBox.h:
• rendering/RenderBlock.h:
• rendering/RenderBox.h:
• rendering/RenderBoxModelObject.h:
• rendering/RenderButton.h:
• rendering/RenderFieldset.h:
• rendering/RenderFileUploadControl.h:
• rendering/RenderFlexibleBox.h:
• rendering/RenderFlowThread.h:
• rendering/RenderFullScreen.h:
• rendering/RenderImage.h:
• rendering/RenderLayer.h:
• rendering/RenderLineBreak.h:
• rendering/RenderListBox.h:
• rendering/RenderListItem.h:
• rendering/RenderListMarker.h:
• rendering/RenderMenuList.h:
• rendering/RenderMeter.h:
• rendering/RenderObject.h:
• rendering/RenderReplaced.h:
• rendering/RenderSlider.h:
• rendering/RenderTable.h:
• rendering/RenderTableCell.h:
• rendering/RenderText.h:
• rendering/RenderTextControl.h:
• rendering/RenderTextControlSingleLine.h:
• rendering/RenderTextFragment.h:
• rendering/RenderView.h:
• rendering/RootInlineBox.h:
• rendering/mathml/RenderMathMLBlock.h:
• rendering/mathml/RenderMathMLFraction.h:
• rendering/mathml/RenderMathMLOperator.h:
• rendering/style/BasicShapes.h:
• rendering/svg/RenderSVGModelObject.h:
• rendering/svg/RenderSVGShape.h:
• svg/SVGAnimatedBoolean.h:
• svg/SVGAnimatedString.h:
• svg/SVGAnimatedTransformList.h:
• svg/SVGDocument.h:
• svg/SVGElement.h:
• svg/SVGElementInstance.h:
• svg/SVGFontElement.h:
• svg/SVGGElement.h:
• svg/SVGGraphicsElement.h:
• svg/SVGTransformable.h:
• svg/properties/SVGAnimatedListPropertyTearOff.h:
• svg/properties/SVGAnimatedPropertyMacros.h:
• svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
• svg/properties/SVGListPropertyTearOff.h:
• svg/properties/SVGPropertyTearOff.h:
• workers/WorkerGlobalScope.h:

Source/WTF:

• wtf/Compiler.h:
• wtf/FilePrintStream.h:
• wtf/StringPrintStream.h:

8:50 AM Changeset in webkit [157043] by fpizlo@apple.com

• 4 edits in trunk

Trap 5 (most likely int $3) in jsc-layout-tests.yaml/js/script-tests/integer-division-neg2tothe32-by-neg1.js.layout-dfg-eager-no-cjit
​https://bugs.webkit.org/show_bug.cgi?id=122420

Source/JavaScriptCore:

Reviewed by Michael Saboff.

For the (-2^{31/-1)|0 case, we were returning the left operand (i.e. -2}31) but we were
failing to account for the possibility that this operand has high-bit garbage and
int32Result() requires that the high bits are zero.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithDiv):

LayoutTests:

Reviewed by Michael Saboff.

• js/script-tests/integer-division-neg2tothe32-by-neg1.js:

8:47 AM Changeset in webkit [157042] by Philippe Normand

• 3 edits in trunk/Source/WebKit/gtk

[GTK] UserMediaClientGtk needs API update
​https://bugs.webkit.org/show_bug.cgi?id=122324

Reviewed by Martin Robinson.

Update UserMediaClientGtk API after changes made in the parent
class in r156473.

• WebCoreSupport/UserMediaClientGtk.cpp:

(WebKit::UserMediaClientGtk::requestPermission):
(WebKit::UserMediaClientGtk::cancelRequest):

• WebCoreSupport/UserMediaClientGtk.h:

8:32 AM Changeset in webkit [157041] by Philippe Normand

• 3 edits in trunk/Source/WebCore

URLMediaStream is unguarded by ENABLE(MEDIA_STREAM)
​https://bugs.webkit.org/show_bug.cgi?id=122444

Reviewed by Martin Robinson.

• Modules/mediastream/URLMediaStream.cpp: Added missing

conditional guards.

• Modules/mediastream/URLMediaStream.h: Ditto.

8:29 AM Changeset in webkit [157040] by Philippe Normand

• 4 edits in trunk/Source/WebCore

[GTK] webkit_dom_html_style_element_{s,g}et_scoped was removed
​https://bugs.webkit.org/show_bug.cgi?id=122446

Reviewed by Martin Robinson.

Added skeleton functions warning of removed functionality for
the <style scoped> GObject DOM binding.

• bindings/gobject/WebKitDOMCustom.cpp:
• bindings/gobject/WebKitDOMCustom.h:
• bindings/gobject/WebKitDOMCustom.symbols:

8:24 AM Changeset in webkit [157039] by Csaba Osztrogonác

• 5 edits in trunk/Source/WebCore

Unreviewed buildfix for GCC 4.6.

Changed override to OVERRIDE and final to FINAL.

• page/PageSerializer.cpp:
• workers/AbstractWorker.h:
• workers/SharedWorker.h:
• workers/Worker.h:

8:10 AM Changeset in webkit [157038] by Chris Fleizach

• 3 edits
  2 adds in trunk

AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.
​https://bugs.webkit.org/show_bug.cgi?id=122252

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When an author uses a control-type ARIA role (like button), but then hides a native control-type inside,
AXPress needs to operate on the inside node if possible.

Test: accessibility/axpress-on-aria-button.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::isNodeActionElement):
(WebCore::nativeActionElement):
(WebCore::AccessibilityNodeObject::actionElement):

LayoutTests:

• accessibility/axpress-on-aria-button-expected.txt: Added.
• accessibility/axpress-on-aria-button.html: Added.

7:51 AM Changeset in webkit [157037] by kov@webkit.org

• 2 edits in trunk/Tools

[GTK] Fails to build with jhbuild with newer system glib
​https://bugs.webkit.org/show_bug.cgi?id=122132

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.

Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
started relying on. glib is not a dependency that should change test results, and is provided in
jhbuild with the intention of supporting the other bits that do, so using a newer stable release
should not be an issue.

• gtk/jhbuild.modules:

7:44 AM Changeset in webkit [157036] by fpizlo@apple.com

• 2 edits in trunk/Tools

run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
​https://bugs.webkit.org/show_bug.cgi?id=122437

Reviewed by Antoine Quint.

• Scripts/run-jsc-stress-tests:

7:36 AM Changeset in webkit [157035] by fpizlo@apple.com

• 12 edits in trunk

ASSERTION FAILED: bitwise_cast<WriteBarrier<Unknown>*>(callFrame) == m_registers in jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-capture-throw-exception.js.layout-dfg-eager-no-cjit
​https://bugs.webkit.org/show_bug.cgi?id=122418

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is pretty awesome. With stack compression, Arguments created in the DFG will point
their m_registers pointers into a different slab of stack than they would have in byte
code.

Hence OSR exit must repoint any Arguments objects' m_registers pointers. It previously
neglected to do so. This patch fixes that.

Fixing this unveiled another bug: the stack reversal broke the reification of inlined
phantom arguments.

• dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

• dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• runtime/Arguments.h:

(JSC::Arguments::offsetOfNumArguments):
(JSC::Arguments::offsetOfRegisters):
(JSC::Arguments::offsetOfSlowArgumentData):
(JSC::Arguments::offsetOfOverrodeLength):

LayoutTests:

• js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
• js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
• js/script-tests/dfg-arguments-osr-exit.js:
• js/script-tests/dfg-inline-arguments-capture-throw-exception.js:

4:37 AM Changeset in webkit [157034] by g.czajkowski@samsung.com

• 2 edits in trunk/LayoutTests

context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901.
​https://bugs.webkit.org/show_bug.cgi?id=122414

Unreviewed gardening.

• platform/mac/TestExpectations:

Similarly to r156990, mark context-menu-suggestions-subword-selection.html as flaky.

Change-Id: I787b1d5a5a328f747799434fd7b984eec6947cd1

2:01 AM Changeset in webkit [157033] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed debug build fix for ports enabling the <template> element support.

• html/HTMLTagNames.in: Generate type helpers for the <template> element as they're required

by the assertions in the Element type casts for HTMLTemplateElement.

1:26 AM WebKitGTK/2.2.x edited by ltilve@igalia.com

(diff)

12:48 AM Changeset in webkit [157032] by ryuan.choi@samsung.com

• 2 edits in trunk/Source/WebCore

[EFL] Build fix after r157002
​https://bugs.webkit.org/show_bug.cgi?id=122434

Reviewed by Sam Weinig.

• editing/markup.cpp: Changed override to OVERRIDE.

12:29 AM Changeset in webkit [157031] by Carlos Garcia Campos

• 9 edits in releases/WebKitGTK/webkit-2.2/Source

Merge r156345 - [GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
​https://bugs.webkit.org/show_bug.cgi?id=121782

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2013-09-24
Reviewed by Martin Robinson.

Disabled drag functions.

Source/WebCore:

• page/gtk/EventHandlerGtk.cpp:
• platform/gtk/PasteboardGtk.cpp:

Source/WebKit/gtk:

• WebCoreSupport/DragClientGtk.cpp:
• WebCoreSupport/DragClientGtk.h:

Source/WebKit2:

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init):

• WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

12:29 AM Changeset in webkit [157030] by Philippe Normand

• 4 edits in trunk/Source/WebCore

MediaStreamTrack can't be FINAL
​https://bugs.webkit.org/show_bug.cgi?id=122322

Reviewed by Darin Adler.

Marked the MediaStreamTrack subclasses as final.

• Modules/mediastream/AudioStreamTrack.h:
• Modules/mediastream/MediaStreamTrack.h:
• Modules/mediastream/VideoStreamTrack.h:

12:27 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:25 AM Changeset in webkit [157029] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r156287 - [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
​https://bugs.webkit.org/show_bug.cgi?id=121600

Reviewed by Gustavo Noronha Silva.

Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.

• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformDestroy):

12:24 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:02 AM Changeset in webkit [157028] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r156003 - DFG doesn't properly keep scope alive for op_put_to_scope
​https://bugs.webkit.org/show_bug.cgi?id=121519

Reviewed by Michael Saboff.

This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

12:01 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos

(diff)

12:01 AM Changeset in webkit [157027] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r155495 - WebKit crashes when trying to send a msg via 'today's birthdays' dialogue box on Facebook
​https://bugs.webkit.org/show_bug.cgi?id=120612#add_comment
Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-09-10
Reviewed by Geoffrey Garen.

The codeBlock was assumed to exist when appendSourceToMessage was set.
This was an invalid assumption. I added a check to ensure that there is a
valid codeBlock before accessing it.

• API/tests/testapi.c:

(valueToObjectExceptionCallAsFunction):
(valueToObjectExceptionTest):
(main):

• runtime/VM.cpp:

(JSC::VM::throwException):

12:00 AM Changeset in webkit [157026] by Carlos Garcia Campos

• 35 edits
  4 copies
  2 deletes in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r154824 - CodeBlock compilation and installation should be simplified and rationalized
​https://bugs.webkit.org/show_bug.cgi?id=120326

Reviewed by Oliver Hunt.

Rolling r154804 back in after fixing no-LLInt build.

Previously Executable owned the code for generating JIT code; you always had
to go through Executable. But often you also had to go through CodeBlock,
because ScriptExecutable couldn't have virtual methods, but CodeBlock could.
So you'd ask CodeBlock to do something, which would dispatch through a
virtual method that would select the appropriate Executable subtype's method.
This all meant that the same code would often be duplicated, because most of
the work needed to compile something was identical regardless of code type.
But then we tried to fix this, by having templatized helpers in
ExecutionHarness.h and JITDriver.h. The result was that if you wanted to find
out what happened when you asked for something to be compiled, you'd go on a
wild ride that started with CodeBlock, touched upon Executable, and then
ricocheted into either ExecutionHarness or JITDriver (likely both).

Another awkwardness was that for concurrent compiles, the DFG::Worklist had
super-special inside knowledge of what JITStubs.cpp's cti_optimize would have
done once the compilation finished.

Also, most of the DFG JIT drivers assumed that they couldn't install the
JITCode into the CodeBlock directly - instead they would return it via a
reference, which happened to be a reference to the JITCode pointer in
Executable. This was super weird.

Finally, there was no notion of compiling code into a special CodeBlock that
wasn't used for handling calls into an Executable. I'd like this for FTL OSR
entry.

This patch solves these problems by reducing all of that complexity into just
three primitives:

• Executable::newCodeBlock(). This gives you a new code block, either for call or for construct, and either to serve as the baseline code or the optimized code. The new code block is then owned by the caller; Executable doesn't register it anywhere. The new code block has no JITCode and isn't callable, but it has all of the bytecode.

• CodeBlock::prepareForExecution(). This takes the CodeBlock's bytecode and produces a JITCode, and then installs the JITCode into the CodeBlock. This method takes a JITType, and always compiles with that JIT. If you ask for JITCode::InterpreterThunk then you'll get JITCode that just points to the LLInt entrypoints. Once this returns, it is possible to call into the CodeBlock if you do so manually - but the Executable still won't know about it so JS calls to that Executable will still be routed to whatever CodeBlock is associated with the Executable.

• Executable::installCode(). This takes a CodeBlock and makes it the code-for- entry for that Executable. This involves unlinking the Executable's last CodeBlock, if there was one. This also tells the GC about any effect on memory usage and does a bunch of weird data structure rewiring, since Executable caches some of CodeBlock's fields for the benefit of virtual call fast paths.

This functionality is then wrapped around three convenience methods:

• Executable::prepareForExecution(). If there is no code block for that Executable, then one is created (newCodeBlock()), compiled (CodeBlock::prepareForExecution()) and installed (installCode()).

• CodeBlock::newReplacement(). Asks the Executable for a new CodeBlock that can serve as an optimized replacement of the current one.

• CodeBlock::install(). Asks the Executable to install this code block.

This patch allows me to kill *a lot* of code and to remove a lot of
specializations for functions vs. not-functions, and a lot of places where we
pass around JITCode references and such. ExecutionHarness and JITDriver are
both gone. Overall this patch has more red than green.

It also allows me to work on FTL OSR entry and tier-up:

• FTL tier-up: this will involve DFGOperations.cpp asking the DFG::Worklist to do some compilation, but it will require the DFG::Worklist to do something different than what JITStubs.cpp would want, once the compilation finishes. This patch introduces a callback mechanism for that purpose.

• FTL OSR entry: this will involve creating a special auto-jettisoned CodeBlock that is used only for FTL OSR entry. The new set of primitives allows for this: Executable can vend you a fresh new CodeBlock, and you can ask that CodeBlock to compile itself with any JIT of your choosing. Or you can take that CodeBlock and compile it yourself. Previously the act of producing a CodeBlock-for-optimization and the act of compiling code for it were tightly coupled; now you can separate them and you can create such auto-jettisoned CodeBlocks that are used for a one-shot OSR entry.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::prepareForExecutionImpl):
(JSC::CodeBlock::prepareForExecution):
(JSC::CodeBlock::prepareForExecutionAsynchronously):
(JSC::CodeBlock::install):
(JSC::CodeBlock::newReplacement):
(JSC::FunctionCodeBlock::jettisonImpl):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::hasBaselineJITProfiling):

• bytecode/DeferredCompilationCallback.cpp: Added.

(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):

• bytecode/DeferredCompilationCallback.h: Added.
• dfg/DFGDriver.cpp:

(JSC::DFG::tryCompile):

• dfg/DFGDriver.h:

(JSC::DFG::tryCompile):

• dfg/DFGFailedFinalizer.cpp:

(JSC::DFG::FailedFinalizer::finalize):
(JSC::DFG::FailedFinalizer::finalizeFunction):

• dfg/DFGFailedFinalizer.h:
• dfg/DFGFinalizer.h:
• dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):

• dfg/DFGJITFinalizer.h:
• dfg/DFGOSRExitPreparation.cpp:

(JSC::DFG::prepareCodeOriginForOSRExit):

• dfg/DFGOperations.cpp:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):

• dfg/DFGPlan.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::runThread):

• ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):

• ftl/FTLJITFinalizer.h:
• heap/Heap.h:

(JSC::Heap::isDeferred):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

• jit/JITDriver.h: Removed.
• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):

• jit/JITToDFGDeferredCompilationCallback.cpp: Added.

(JSC::JITToDFGDeferredCompilationCallback::JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::~JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):

• jit/JITToDFGDeferredCompilationCallback.h: Added.
• llint/LLIntEntrypoints.cpp:

(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):

• llint/LLIntEntrypoints.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::setUpCall):

• runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

• runtime/CommonSlowPaths.cpp:
• runtime/CompilationResult.cpp:

(WTF::printInternal):

• runtime/CompilationResult.h:
• runtime/Executable.cpp:

(JSC::ScriptExecutable::installCode):
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):

• runtime/Executable.h:

(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor):
(JSC::ExecutableBase::offsetOfNumParametersFor):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):

• runtime/ExecutionHarness.h: Removed.

Oct 6, 2013:

11:56 PM Changeset in webkit [157025] by Carlos Garcia Campos

• 90 edits in releases/WebKitGTK/webkit-2.2

Merge r154797 - Source/JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Gardening of exception throws. The act of throwing an exception was being handled in
different ways depending on whether the code was running in the LLint, Baseline JIT,
or the DFG Jit. This made development in the vm exception and error objects difficult.

• runtime/VM.cpp:

(JSC::appendSourceToError):
This function moved from the interpreter into the VM. It views the developers code
(if there is a codeBlock) to extract what was trying to be evaluated when the error
occurred.

(JSC::VM::throwException):
This function takes in the error object and sets the following:

1: The VM's exception stack
2: The VM's exception
3: Appends extra information on the error message(via appendSourceToError)
4: The error object's line number
5: The error object's column number
6: The error object's sourceURL
7: The error object's stack trace (unless it already exists because the developer

created the error object).

(JSC::VM::getExceptionInfo):
(JSC::VM::setExceptionInfo):
(JSC::VM::clearException):
(JSC::clearExceptionStack):

• runtime/VM.h:

(JSC::VM::exceptionOffset):
(JSC::VM::exception):
(JSC::VM::addressOfException):
(JSC::VM::exceptionStack):
VM exception and exceptionStack are now private data members.

• interpreter/Interpreter.h:

(JSC::ClearExceptionScope::ClearExceptionScope):
Created this structure to temporarily clear the exception within the VM. This
needed to see if addition errors occur when setting the debugger as we are
unwinding the stack.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):
Removed the code that would try to add error information if it did not exist.
All of this functionality has moved into the VM and all error information is set
at the time the error occurs.

The rest of these functions reference the new calling convention to throw an error.

• API/APICallbackFunction.h:

(JSC::APICallbackFunction::call):

• API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

• API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):
(JSC::::defaultValue):
(JSC::::put):
(JSC::::putByIndex):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::customHasInstance):
(JSC::::call):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

• debugger/Debugger.cpp:

(JSC::evaluateInGlobalCallFrame):

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

• dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::emitExceptionCheck):

• dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::callCheck):

• heap/Heap.cpp:

(JSC::Heap::markRoots):

• interpreter/CallFrame.h:

(JSC::ExecState::clearException):
(JSC::ExecState::exception):
(JSC::ExecState::hadException):

• interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::loadVarargs):
(JSC::stackTraceAsString):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

• interpreter/Interpreter.h:

(JSC::ClearExceptionScope::ClearExceptionScope):

• jit/JITCode.cpp:

(JSC::JITCode::execute):

• jit/JITExceptions.cpp:

(JSC::genericThrow):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_catch):

• jit/JITStubs.cpp:

(JSC::returnToThrowTrampoline):
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
(JSC::putByVal):
(JSC::cti_vm_handle_exception):

• jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

• jsc.cpp:

(functionRun):
(functionLoad):
(functionCheckSyntax):

• llint/LLIntExceptions.cpp:

(JSC::LLInt::doThrow):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::opIn):

• runtime/CommonSlowPathsExceptions.cpp:

(JSC::CommonSlowPaths::interpreterThrowInCaller):

• runtime/Completion.cpp:

(JSC::evaluate):

• runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::throwTypeError):
(JSC::throwSyntaxError):

• runtime/Error.h:

(JSC::throwVMError):

• runtime/ExceptionHelpers.cpp:

(JSC::throwOutOfMemoryError):
(JSC::throwStackOverflowError):
(JSC::throwTerminatedExecutionException):

• runtime/Executable.cpp:

(JSC::EvalExecutable::create):
(JSC::FunctionExecutable::produceCodeBlockFor):

• runtime/FunctionConstructor.cpp:

(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):

• runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):
(JSC::JSArray::push):

• runtime/JSCJSValue.cpp:

(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizePrototype):
(JSC::JSValue::putToPrimitive):

• runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::::create):
(JSC::::createUninitialized):
(JSC::::validateRange):
(JSC::::setWithSpecificType):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncProtoSetter):

• runtime/JSNameScope.cpp:

(JSC::JSNameScope::put):

• runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):

• runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defaultHasInstance):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::throwTypeError):

• runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

• runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

• runtime/StringObject.cpp:

(JSC::StringObject::defineOwnProperty):

• runtime/StringRecursionChecker.cpp:

(JSC::StringRecursionChecker::throwStackOverflowError):

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Gets column information from the error object for reporting exceptions.

• bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

• bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackFromException):

Moved setting an exception into the vm, These functions changed to use the new functionality.

• bindings/js/JSAudioBufferSourceNodeCustom.cpp:

(WebCore::JSAudioBufferSourceNode::setBuffer):

• bindings/js/JSBiquadFilterNodeCustom.cpp:

(WebCore::JSBiquadFilterNode::setType):

• bindings/js/JSCryptoCustom.cpp:

(WebCore::JSCrypto::getRandomValues):

• bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

• bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::setFunctionVariableValue):

• bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::evaluate):
(WebCore::JSJavaScriptCallFrame::setVariableValue):

• bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

• bindings/js/JSOscillatorNodeCustom.cpp:

(WebCore::JSOscillatorNode::setType):

• bindings/js/JSPannerNodeCustom.cpp:

(WebCore::JSPannerNode::setPanningModel):
(WebCore::JSPannerNode::setDistanceModel):

• bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

• bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::getObjectParameter):
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getExtension):
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGLRenderingContext::getParameter):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):

• bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneBase::throwStackOverflow):
(WebCore::CloneDeserializer::throwValidationError):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):

• bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):

• bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::toJSPrimitive):

• bridge/objc/objc_instance.mm:

(ObjcInstance::invokeMethod):

• bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcArray::setValueAt):
(JSC::Bindings::ObjcArray::valueAt):

• bridge/objc/objc_utility.mm:

(JSC::Bindings::throwError):

• bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtField::valueFromInstance):
(JSC::Bindings::QtField::setValueToInstance):

• bridge/runtime_array.cpp:

(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):

• bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::throwInvalidAccessError):

Source/WebKit/mac: ​https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Moved setting an exception into the vm, These functions changed to use the new functionality.

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

• Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invokeMethod):

Source/WebKit2: ​https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Moved setting an exception into the vm, These functions changed to use the new functionality.

• WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::throwInvalidAccessError):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::moveGlobalExceptionToExecState):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <​chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Column/line information was added into these results.

• fast/events/window-onerror4-expected.txt:
• fast/js/global-recursion-on-full-stack-expected.txt:

fixed a variable name in a case when shouldThrowType failed.

• fast/js/mozilla/resources/js-test-pre.js:

(shouldThrowType):

Sorted the properties to allow the results always show in the same order.

• fast/js/script-tests/exception-properties.js:
• fast/js/exception-properties-expected.txt:

This test needed to be modified to have the line numbers match on the output across
wk and wk2. This test is inherently flaky because is relies on size of the available
native stack. To account for the flakiness an additional call was made to force the
results to match.
This patch now records and outputs the line number where the errors were occurring.
This was causing the test results to no longer match because of the line numbers.
By changing how to account for the flakiness, the results match again.

• fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
• fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:

11:39 PM Changeset in webkit [157024] by gyuyoung.kim@samsung.com

• 10 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue
​https://bugs.webkit.org/show_bug.cgi?id=122408

Reviewed by Andreas Kling.

As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue,
CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue.
This will help to detect bad type cast.

No new tests, no behavior changes.

• css/CSSCursorImageValue.h:
• css/CSSTimingFunctionValue.h:
• css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

• css/CSSUnicodeRangeValue.h:
• css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

• css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):

• rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssCursorImageValue):

9:48 PM Changeset in webkit [157023] by akling@apple.com

• 2 edits in trunk/Source/WebKit

No? Okay, let's try that again..

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

9:35 PM Changeset in webkit [157022] by akling@apple.com

• 2 edits in trunk/Source/WebKit

Attempt to fix the Windows build.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

9:34 PM Changeset in webkit [157021] by timothy_horton@apple.com

• 2 edits in trunk/LayoutTests

Remove an unnecessary test expectation, as the test was removed
along with the code it tested.

• platform/mac/TestExpectations:

9:00 PM Changeset in webkit [157020] by timothy_horton@apple.com

• 3 edits in trunk/LayoutTests

results.html doesn't support non-HTML reference tests or references with external resources
​https://bugs.webkit.org/show_bug.cgi?id=122426

Reviewed by Ryosuke Niwa.

• fast/harness/results.html:

Factor splitExtension() out of stripExtension(), so we can retrieve
the extension as well as strip it.

Factor layoutTestsBasePath() out of testLink(), so we can use it for
ref test expectation files as well.

Use layoutTestsBasePath() to link to ref test expectation files, and
use the extension of the test for the expectation, instead of hardcoding
HTML reference files.

This will work on the bots because we already use the same mechanism for
the link to the test itself.

• fast/harness/resources/results-test.js:

Update the harness result viewer test results.

8:46 PM Changeset in webkit [157019] by mitz@apple.com

• 2 edits in trunk/Source/ThirdParty

Build against the Xcode default toolchain when targeting OS X 10.8.

This fixes the build after r156632 in configurations that use another toolchain
by default.

• gtest/xcode/Config/General.xcconfig:

8:39 PM Changeset in webkit [157018] by akling@apple.com

• 38 edits in trunk/Source

Range constructors should take a Document&.
<​https://webkit.org/b/122435>

Reviewed by Sam Weinig.

Source/WebCore:

Make all Range constructors take Document& instead of a PassRefPtr.
This removes one null check at every call site.

Also use a Ref<Document> for storage in Range.

Source/WTF:

Give Ref an assignment operator.

8:37 PM Changeset in webkit [157017] by fpizlo@apple.com

• 4 edits in trunk/LayoutTests

jsc-layout-tests.yaml/js/script-tests/dfg-arguments-osr-exit.js.layout-dfg-eager-no-cjit fails in release mode on the bots
​https://bugs.webkit.org/show_bug.cgi?id=122436

Unreviewed, green the bots by not running the eager variants of these tests.

Will unskip when I land the fix for ​https://bugs.webkit.org/show_bug.cgi?id=122418.

• js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
• js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
• js/script-tests/dfg-arguments-osr-exit.js:

7:37 PM Changeset in webkit [157016] by fpizlo@apple.com

• 2 edits in trunk/Tools

Unreviewed, fix build on old Rubies.

• Scripts/run-jsc-stress-tests:

7:17 PM Changeset in webkit [157015] by Antti Koivisto

• 7 edits
  2 adds in trunk/Source/WebCore

Factor text paint style computation out from InlineTextBox
​https://bugs.webkit.org/show_bug.cgi?id=122433

Reviewed by Andreas Kling.

Move it to TextPaintStyle.h/cpp. Other parts of the code may use it in the future.

7:14 PM Changeset in webkit [157014] by fpizlo@apple.com

• 11 edits
  3 adds
  1 delete in trunk

Unified test infrastructure via the jsc shell
​https://bugs.webkit.org/show_bug.cgi?id=120696

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Add a mozilla-tests.yaml list. This is autogenerated by create-mozilla-js-test-list.
I think it's better to leave this checked in; we may even just edit it directly in
the future. Also generating it is not cheap.

Fix some low-hanging fruit bugs that I caught by introducing more test coverage.

• We were not emitting labels for CFA-unreachable blocks, which caused link errors. It's possible for a CFA-unreachable block to be jumped to, if the thing that causes it to be unreachable is a speculation in a Branch or peephole compare.

• The register allocation assertions didn't handle peephole branches correctly. Since the peephole branch handling returns early from compile(), the clearBlahbittyBlah() method wasn't being called.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• tests/mozilla/mozilla-tests.yaml: Added.

Tools:

Reviewed by Oliver Hunt.

Make run-jsc-stress-tests smart enough to be able to handle different styles of test
output (silent or noisy) and different styles of test failure (just bad exit code,
text diff, filtering for some magical text, etc.). This allows me to get rid of the
layout-test-helper. It also allows me to switch all of the old Mozilla tests to
running in run-jsc-stress-tests.

Also removes all of the code paths that defended against not having shellwords. Just
install the shellwords gem if you want to run tests.

Also removes the non-parallel test running code. No reason for it to exist anymore.

This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
as part of this patch, and left three more as new bugzillas.

• Scripts/create-mozilla-js-test-list: Added.
• Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
• Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
• Scripts/run-javascriptcore-tests:
• Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Oliver Hunt.

Suppress running the no-cjit and dfg-eager variants of these tests because there are
still some hard bugs to fix; they were revealed by the increase in test coverage.

• js/script-tests/dfg-inline-arguments-capture-throw-exception.js:
• js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:
• js/script-tests/integer-division-neg2tothe32-by-neg1.js:

5:43 PM Changeset in webkit [157013] by Darin Adler

• 3 edits in trunk/Source/WebCore

[GTK] Get rid of use of deleteAllValues in GtkDragAndDropHelper
​https://bugs.webkit.org/show_bug.cgi?id=122417

Reviewed by Andreas Kling.

• platform/gtk/GtkDragAndDropHelper.cpp: Removed unneeded typedefs.

(WebCore::GtkDragAndDropHelper::~GtkDragAndDropHelper): Removed call to
deleteAllValues.
(WebCore::GtkDragAndDropHelper::handleDragEnd): Use remove directly instead
of using find then remove. I believe this fixes a storage leak.
(WebCore::GtkDragAndDropHelper::handleGetDragData): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragLeaveLater): Remove the explicit
delete since remove will automatically delete.
(WebCore::GtkDragAndDropHelper::handleDragLeave): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragMotion): Use add instead of a
combination of find and set. Also user nullptr instead of 0.
(WebCore::GtkDragAndDropHelper::handleDragDataReceived): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragDrop): Use get instead of find.

• platform/gtk/GtkDragAndDropHelper.h: Use nullptr instead of 0. Change value

type of m_droppingContexts to be a std::unique_ptr.

4:26 PM Changeset in webkit [157012] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Windows build fix attempt.

• page/win/DragControllerWin.cpp:

(WebCore::DragController::declareAndWriteDragImage):

3:55 PM Changeset in webkit [157011] by Antti Koivisto

• 34 edits in trunk/Source/WebCore

Move paint() to RenderElement
​https://bugs.webkit.org/show_bug.cgi?id=122371

Reviewed by Darin Adler.

RenderText does not paint itself (text is painted by line boxes). We can move paint() down
to RenderElement.

This also requires some type tightening elsewhere in the code.

3:28 PM Changeset in webkit [157010] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Don't try to dispatch resize events for SVG images
​https://bugs.webkit.org/show_bug.cgi?id=122410

Reviewed by Darin Adler.

Tested by avoiding assertion in svg/custom/large-image-pattern-crash.html

• page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

Bail out for SVG images. They have scripting disabled so the event wouldn't do anything anyway.
Use of FrameView mechanisms is just an implementation detail for SVG images, they are not
meant to act like real frames.

• rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

Switch to Element iterator. This will take NoEventDispatchAssertion verifying the change.

3:07 PM Changeset in webkit [157009] by rniwa@webkit.org

• 2 edits in trunk/PerformanceTests

DoYouEvenBench: Make it work on Internet Explorer 11 Release Preview
​https://bugs.webkit.org/show_bug.cgi?id=122406

Reviewed by Darin Adler.

On Internet Explorer 11, $(elem).closest('li').data('id') fails to find the containig li of elem once
the first item is marked complete or deleted until we get back to the event loop in the jQuery/TodoMVC.
Worked around this limitation by overriding app.getTodo to use each item's id computed in advance.

Also use $.text instead of execCommand('InsertText') in FlightJS/MailClient since Internet Explorer
doesn't support execCommand('InsertText'). Also select the recipient to avoid exceptions.

• DoYouEvenBench/benchmark.html:

2:29 PM Changeset in webkit [157008] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Element ancestor iterator should have a first() for convenience.
<​https://webkit.org/b/122425>

Reviewed by Antti Koivisto.

Added an easy way to get the first element ancestor of a certain type
and put it to use in a few places.

2:07 PM Changeset in webkit [157007] by akling@apple.com

• 8 edits in trunk/Source/WebCore

CTTE: FrameLoader::notifier() should return a reference.
<​https://webkit.org/b/122424>

Reviewed by Anders Carlsson.

It was just returning the address of an inline member, so we should
use a reference instead. Also made the backpointer to Frame in
ResourceLoadNotifier a reference.

1:53 PM Changeset in webkit [157006] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Avoid layout in window.scroll{Y,X} when at topmost/leftmost position.
<​https://webkit.org/b/122423>

Reviewed by Antti Koivisto.

Add a fast path for these properties to skip synchronous layout when
we are just going to return 0 anyway.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):

1:11 PM Changeset in webkit [157005] by andersca@apple.com

• 7 edits in trunk/Source/WebCore

Clean up ContentData
​https://bugs.webkit.org/show_bug.cgi?id=122421

Reviewed by Andreas Kling.

Replace uses of OwnPtr with std::unique_ptr and get rid of the ContentData::create overloads.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

• rendering/style/ContentData.cpp:

(WebCore::ContentData::clone):

• rendering/style/ContentData.h:

(WebCore::ContentData::setNext):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::appendContent):
(WebCore::RenderStyle::setContent):

• rendering/style/RenderStyle.h:
• rendering/style/StyleRareNonInheritedData.h:

12:48 PM Changeset in webkit [157004] by weinig@apple.com

• 7 edits in trunk/Source/WebCore

Be a bit shouty about final classes while we look into why the bots don't like it.

• dom/Comment.h:
• dom/ProcessingInstruction.h:
• editing/markup.cpp:
• page/PageSerializer.cpp:
• workers/SharedWorker.h:
• workers/Worker.h:

12:35 PM Changeset in webkit [157003] by weinig@apple.com

• 3 edits in trunk/Source/WebCore

Fix windows build.

• platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):

• platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writeSelection):

12:18 PM Changeset in webkit [157002] by weinig@apple.com

• 47 edits in trunk/Source

CTTE: Thread references through markup.h
​https://bugs.webkit.org/show_bug.cgi?id=122403

Reviewed by Darin Adler and Andreas Kling.

Source/WebCore:

Highlights:

• Removed createFragmentFromMarkupWithContext(), it was unused.
• Moved createFragmentFromNodes() into its one caller (in WebKit/mac)
• Add a bunch more toFoo() overloads.

Source/WebKit/mac:

• DOM/WebDOMOperations.mm:

(-[DOMNode markupString]):
(-[DOMRange markupString]):

• WebView/WebFrame.mm:

(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):

12:01 PM Changeset in webkit [157001] by zandobersek@gmail.com

• 55 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/Modules/ with the OperationsNotDeletable attribute
​https://bugs.webkit.org/show_bug.cgi?id=122281

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/Modules/.

• Modules/battery/BatteryManager.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/gamepad/GamepadList.idl:
• Modules/geolocation/Geolocation.idl:
• Modules/indexeddb/IDBCursor.idl:
• Modules/indexeddb/IDBDatabase.idl:
• Modules/indexeddb/IDBFactory.idl:
• Modules/indexeddb/IDBIndex.idl:
• Modules/indexeddb/IDBKeyRange.idl:
• Modules/indexeddb/IDBObjectStore.idl:
• Modules/indexeddb/IDBTransaction.idl:
• Modules/indexeddb/IDBVersionChangeEvent.idl:
• Modules/mediacontrols/MediaControlsHost.idl:
• Modules/mediasource/MediaSource.idl:
• Modules/mediasource/SourceBuffer.idl:
• Modules/mediasource/SourceBufferList.idl:
• Modules/mediasource/WebKitMediaSource.idl:
• Modules/mediasource/WebKitSourceBuffer.idl:
• Modules/mediasource/WebKitSourceBufferList.idl:
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/MediaStreamTrack.idl:
• Modules/mediastream/RTCDTMFSender.idl:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCStatsReport.idl:
• Modules/mediastream/RTCStatsResponse.idl:
• Modules/networkinfo/NetworkInfoConnection.idl:
• Modules/notifications/Notification.idl:
• Modules/notifications/NotificationCenter.idl:
• Modules/proximity/DeviceProximityEvent.idl:
• Modules/quota/StorageInfo.idl:
• Modules/quota/StorageQuota.idl:
• Modules/speech/SpeechGrammarList.idl:
• Modules/speech/SpeechRecognition.idl:
• Modules/speech/SpeechRecognitionResult.idl:
• Modules/speech/SpeechRecognitionResultList.idl:
• Modules/speech/SpeechSynthesis.idl:
• Modules/webaudio/AnalyserNode.idl:
• Modules/webaudio/AudioBuffer.idl:
• Modules/webaudio/AudioBufferSourceNode.idl:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioListener.idl:
• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/PannerNode.idl:
• Modules/webdatabase/Database.idl:
• Modules/webdatabase/DatabaseSync.idl:
• Modules/webdatabase/SQLResultSetRowList.idl:
• Modules/webdatabase/SQLTransaction.idl:
• Modules/webdatabase/SQLTransactionSync.idl:
• Modules/websockets/WebSocket.idl:

11:47 AM Changeset in webkit [157000] by akling@apple.com

• 9 edits in trunk/Source/WebCore

Tighten AbstractWorker and subclasses a bit.
<​https://webkit.org/b/122402>

Reviewed by Darin Adler.

• Make the Worker and SharedWorker classes final.
• Have constructors take ScriptExecutionContext by reference.
• Remove unnecessary AbstractWorker::contextDestroyed() override.
• Make eventTargetInterface() inline.

Inlining eventTargetInterface() is quite neat - since we only ever
call this on tightly typed pointers from generated code, combining
final and inline turns the virtual call into a compile-time constant.

11:18 AM Changeset in webkit [156999] by zandobersek@gmail.com

• 49 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/html/ with the OperationsNotDeletable attribute
​https://bugs.webkit.org/show_bug.cgi?id=122280

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/html/.

• html/DOMFormData.idl:
• html/DOMSettableTokenList.idl:
• html/DOMTokenList.idl:
• html/DOMURL.idl:
• html/HTMLAllCollection.idl:
• html/HTMLAnchorElement.idl:
• html/HTMLButtonElement.idl:
• html/HTMLCanvasElement.idl:
• html/HTMLCollection.idl:
• html/HTMLDocument.idl:
• html/HTMLElement.idl:
• html/HTMLEmbedElement.idl:
• html/HTMLFieldSetElement.idl:
• html/HTMLFormControlsCollection.idl:
• html/HTMLFormElement.idl:
• html/HTMLFrameElement.idl:
• html/HTMLIFrameElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLKeygenElement.idl:
• html/HTMLMarqueeElement.idl:
• html/HTMLMediaElement.idl:
• html/HTMLObjectElement.idl:
• html/HTMLOptionsCollection.idl:
• html/HTMLOutputElement.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTableElement.idl:
• html/HTMLTableRowElement.idl:
• html/HTMLTableSectionElement.idl:
• html/HTMLTextAreaElement.idl:
• html/HTMLVideoElement.idl:
• html/MediaController.idl:
• html/RadioNodeList.idl:
• html/TimeRanges.idl:
• html/canvas/CanvasGradient.idl:
• html/canvas/CanvasRenderingContext2D.idl:
• html/canvas/DOMPath.idl:
• html/canvas/EXTDrawBuffers.idl:
• html/canvas/OESVertexArrayObject.idl:
• html/canvas/WebGLDebugShaders.idl:
• html/canvas/WebGLLoseContext.idl:
• html/canvas/WebGLRenderingContext.idl:
• html/track/AudioTrackList.idl:
• html/track/TextTrack.idl:
• html/track/TextTrackCue.idl:
• html/track/TextTrackCueList.idl:
• html/track/TextTrackList.idl:
• html/track/TextTrackRegionList.idl:
• html/track/VideoTrackList.idl:

11:16 AM Changeset in webkit [156998] by akling@apple.com

• 7 edits in trunk/Source

Pass VM instead of ExecState to StringObject constructor.
<​https://webkit.org/b/122395>

Reviewed by Sam Weinig.

StringObject() only uses the ExecState to find the VM.

11:10 AM Changeset in webkit [156997] by zandobersek@gmail.com

• 32 edits in trunk/Source/WebCore

[WebIIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
​https://bugs.webkit.org/show_bug.cgi?id=122279

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/svg/.

• svg/SVGAngle.idl:
• svg/SVGAnimationElement.idl:
• svg/SVGColor.idl:
• svg/SVGCursorElement.idl:
• svg/SVGDocument.idl:
• svg/SVGElement.idl:
• svg/SVGElementInstanceList.idl:
• svg/SVGException.idl:
• svg/SVGFEDropShadowElement.idl:
• svg/SVGFEGaussianBlurElement.idl:
• svg/SVGFEMorphologyElement.idl:
• svg/SVGFilterElement.idl:
• svg/SVGGraphicsElement.idl:
• svg/SVGLength.idl:
• svg/SVGLengthList.idl:
• svg/SVGMarkerElement.idl:
• svg/SVGMaskElement.idl:
• svg/SVGMatrix.idl:
• svg/SVGNumberList.idl:
• svg/SVGPaint.idl:
• svg/SVGPathElement.idl:
• svg/SVGPathSegList.idl:
• svg/SVGPatternElement.idl:
• svg/SVGPoint.idl:
• svg/SVGPointList.idl:
• svg/SVGSVGElement.idl:
• svg/SVGStringList.idl:
• svg/SVGTests.idl:
• svg/SVGTextContentElement.idl:
• svg/SVGTransform.idl:
• svg/SVGTransformList.idl:

11:07 AM Changeset in webkit [156996] by zandobersek@gmail.com

• 15 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/page/ with the OperationsNotDeletable attribute
​https://bugs.webkit.org/show_bug.cgi?id=122278

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/page/.

• page/Console.idl:
• page/Crypto.idl:
• page/DOMSecurityPolicy.idl:
• page/DOMSelection.idl:
• page/DOMWindow.idl:
• page/EventSource.idl:
• page/History.idl:
• page/Location.idl:
• page/Navigator.idl:
• page/Performance.idl:
• page/PerformanceEntryList.idl:
• page/SpeechInputResultList.idl:
• page/WindowBase64.idl:
• page/WindowTimers.idl:

10:58 AM Changeset in webkit [156995] by mihnea@adobe.com

• 1 edit
  6 moves in trunk/LayoutTests

[CSSRegions] Rename parsing tests to match current css properties
​https://bugs.webkit.org/show_bug.cgi?id=122413

Reviewed by Sam Weinig.

Simple renaming of files, inline with the current stable version of properties.

• fast/regions/script-tests/webkit-flow-from-parsing.js: Renamed from LayoutTests/fast/regions/script-tests/content-webkit-from-flow-parsing.js.
• fast/regions/script-tests/webkit-flow-into-parsing.js: Renamed from LayoutTests/fast/regions/script-tests/webkit-flow-parsing.js.
• fast/regions/webkit-flow-from-parsing-expected.txt: Renamed from LayoutTests/fast/regions/content-webkit-from-flow-parsing-expected.txt.
• fast/regions/webkit-flow-from-parsing.html: Renamed from LayoutTests/fast/regions/content-webkit-from-flow-parsing.html.
• fast/regions/webkit-flow-into-parsing-expected.txt: Renamed from LayoutTests/fast/regions/webkit-flow-parsing-expected.txt.
• fast/regions/webkit-flow-into-parsing.html: Renamed from LayoutTests/fast/regions/webkit-flow-parsing.html.

10:52 AM Changeset in webkit [156994] by Darin Adler

• 2 edits in trunk/Source/WebCore

• rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle): Added a comment possibly relevant
to current failures seen on Windows bot.

10:44 AM Changeset in webkit [156993] by commit-queue@webkit.org

• 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r156988.
​http://trac.webkit.org/changeset/156988
​https://bugs.webkit.org/show_bug.cgi?id=122415

Broke debug build (Requested by ap on #webkit).

• css/CSSCursorImageValue.h:
• css/CSSTimingFunctionValue.h:
• css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

• css/CSSUnicodeRangeValue.h:
• css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

• css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):

• rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssCursorImageValue):

10:41 AM Changeset in webkit [156992] by Darin Adler

• 2 edits in trunk/Source/WebKit

Try to fix the Windows build.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Removed export of non-existent Node::treeScope function returning
a TreeScope*. Probably will have to add an export to fix the next failure.

10:37 AM Changeset in webkit [156991] by gyuyoung.kim@samsung.com

• 11 edits
  2 moves in trunk/Source/WebCore

Add *CSS* prefix to ShadowValue to generate toCSSShadowValue
​https://bugs.webkit.org/show_bug.cgi?id=122409

Reviewed by Darin Adler.

To generate toCSSShadowValue(), we need to add *CSS* prefix to ShadowValue.
It is also to be sync with a naming rule of CSS child value.

No new tests, no behavior changes.

• CMakeLists.txt:
• GNUmakefile.list.am:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForShadow):

• css/CSSParser.cpp:

(WebCore::ShadowParseContext::commitValue):

• css/CSSShadowValue.cpp: Renamed from Source/WebCore/css/ShadowValue.cpp.

(WebCore::CSSShadowValue::CSSShadowValue):
(WebCore::CSSShadowValue::customCSSText):
(WebCore::CSSShadowValue::equals):

• css/CSSShadowValue.h: Renamed from Source/WebCore/css/ShadowValue.h.

(WebCore::CSSShadowValue::create):

• css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

• css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createFilterOperations):

10:29 AM Changeset in webkit [156990] by ap@apple.com

• 2 edits in trunk/LayoutTests

Layout Test editing/spelling/context-menu-suggestions-multiword-selection.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=122414

• platform/mac/TestExpectations: Marked as such.

10:15 AM Changeset in webkit [156989] by Darin Adler

• 16 edits
  3 deletes in trunk/Source

Remove unneeded ScriptGCEvent class
​https://bugs.webkit.org/show_bug.cgi?id=122390

Reviewed by Anders Carlsson.

Source/ThirdParty:

• gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update this file.

Not really part of this bug fix, but good to land anyway.

Source/WebCore:

• GNUmakefile.list.am: Removed ScriptGCEvent files.
• Target.pri: Ditto.
• UseJSC.cmake: Ditto.
• WebCore.exp.in: Ditto.
• WebCore.vcxproj/WebCore.vcxproj: Ditto.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• bindings/js/JSBindingsAllInOne.cpp: Ditto.
• bindings/js/ScriptGCEvent.cpp: Removed.
• bindings/js/ScriptGCEvent.h: Removed.

• inspector/InspectorMemoryAgent.cpp: Removed include.

• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start): Removed GC event listening.
Some day we might add it back, but for now it is dead code.
(WebCore::InspectorTimelineAgent::stop): Ditto.
(WebCore::usedHeapSize): Renamed from getUsedHeapSize and put the
implementation here instead of indirecting through ScriptGCEvent.
(WebCore::InspectorTimelineAgent::setDOMCounters): Updated for above changes.
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): Ditto.
(WebCore::InspectorTimelineAgent::pushCurrentRecord): Ditto.

• inspector/InspectorTimelineAgent.h: Removed include.

• inspector/ScriptGCEventListener.h: Removed.

• testing/MemoryInfo.h: Updated to get heap capacity and size directly

instead of going through ScriptGCEvent.

Source/WebKit:

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Replaced symbol from ScriptGCEvent with symbol from JSDOMWindowBase.

10:03 AM Changeset in webkit [156988] by gyuyoung.kim@samsung.com

• 9 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue
​https://bugs.webkit.org/show_bug.cgi?id=122408

Reviewed by Darin Adler.

As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue,
CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue.
This will help to detect bad type cast.

No new tests, no behavior changes.

• css/CSSCursorImageValue.h:
• css/CSSTimingFunctionValue.h:
• css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

• css/CSSUnicodeRangeValue.h:
• css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

• css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):

• rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssCursorImageValue):

1:37 AM Changeset in webkit [156987] by akling@apple.com

• 5 edits in trunk/Source/WebCore

CTTE: Teach CompositeEditCommand that link Nodes are always Elements.
<​https://webkit.org/b/122400>

Reviewed by Sam Weinig.

Make pushAnchorElementDown() take an Element& instead of a Node* and
tweak the surrounding code a tiny bit.

1:37 AM Changeset in webkit [156986] by akling@apple.com

• 4 edits in trunk/Source/WebCore

CTTE: Node::enclosingLinkEventParentOrSelf() should return an Element.
<​https://webkit.org/b/122401>

Reviewed by Sam Weinig.

Only Elements are ever linked, so make enclosingLinkEventParentOrSelf()
return an Element* instead of a Node*. The only call site was already
doing toElement() on the return value without checking, so this makes
things look a bit nicer.

12:33 AM Changeset in webkit [156985] by gyuyoung.kim@samsung.com

• 10 edits
  2 moves in trunk/Source/WebCore

Add *CSS* prefix to FontFeatureValue to generate toCSSFontFeatureValue(), and use it
​https://bugs.webkit.org/show_bug.cgi?id=122204

Reviewed by Darin Adler.

*CSS* prefix needs to be added to FontFeatureValue class in order to generate toCSSFontFeatureValue().
static_cast<FontFeatureValue*> is changed with toCSSFontFeatureValue() by using this change.

No new tests, no behavior changes.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSFontFeatureValue.cpp: Renamed from Source/WebCore/css/FontFeatureValue.cpp.

(WebCore::CSSFontFeatureValue::CSSFontFeatureValue):
(WebCore::CSSFontFeatureValue::customCSSText):
(WebCore::CSSFontFeatureValue::equals):

• css/CSSFontFeatureValue.h: Renamed from Source/WebCore/css/FontFeatureValue.h.

(WebCore::CSSFontFeatureValue::create):
(WebCore::CSSFontFeatureValue::tag):
(WebCore::CSSFontFeatureValue::value):

• css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFeatureTag):

• css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):