Timeline
Oct 8, 2013:
- 11:23 PM Changeset in webkit [157158] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix EFL buildbreak since r157152.
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::adjustForTouchEvent):
- 10:26 PM Changeset in webkit [157157] by
-
- 3 edits in trunk/Source/WebKit2
Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496
Reviewed by Andreas Kling.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when puttin objects
into the map.
(WebKit::NPRemoteObjectMap::pluginDestroyed): Instead of making an array of receivers
and deleting them all, remove all of the receivers from the map, which will take care
of deleting them. Also change the other loop to use a similar coding style.
- Shared/Plugins/NPRemoteObjectMap.h: Change the value type of m_registeredNPObjects
to be unique_ptr instead of a raw pointer.
- 7:36 PM Changeset in webkit [157156] by
-
- 2 edits in trunk/LayoutTests
Fix expectation for geolocation test that has been timing out.
- platform/gtk-wk2/TestExpectations:
- 7:07 PM Changeset in webkit [157155] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Move http/tests/loading/307-after-303-after-post.html failure
expectation to the global gtk expectations file, since it's also true for gtk-wk2.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 6:16 PM Changeset in webkit [157154] by
-
- 8 edits1 delete in trunk
Improved WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122536
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
Source/WebCore:
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::cookieJarPath):
Put cookies.dat into the AppData directory on Windows.
Tools:
- WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
- WinLauncher/PrintWebUIDelegate.h: Removed stubs.
- WinLauncher/WinLauncher.cpp:
(createCrashReport): Use the executable name instead of "WinLauncher".
- WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
- win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
- 5:45 PM Changeset in webkit [157153] by
-
- 2 edits in trunk/Source/WebCore
Remove the code erroneously in the previous commit.
- dom/EventDispatcher.h:
(WebCore::EventPath::contextAt):
- 5:41 PM Changeset in webkit [157152] by
-
- 8 edits in trunk/Source/WebCore
Turn EventPath into a real class
https://bugs.webkit.org/show_bug.cgi?id=122533
Reviewed by Antti Koivisto.
Turned EventPath into a real class and made EventRetargeter::calculateEventPath its constructor.
We can turn a lot of functions in EventRetargeter.cpp member functions of EventPath since many
of them manipulate EventPath in one way or another.
- dom/EventContext.h:
(WebCore::toMouseOrFocusEventContext):
(WebCore::toTouchEventContext):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):
(WebCore::EventPath::hasEventListeners):
- dom/EventDispatcher.h:
(WebCore::EventPath::isEmpty):
(WebCore::EventPath::size):
(WebCore::EventPath::item):
(WebCore::EventPath::targetRespectingTargetRules):
(WebCore::EventPath::shrink):
(WebCore::EventPath::lastContextIfExists):
- dom/EventRetargeter.cpp:
(WebCore::EventPath::EventPath):
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes):
- dom/EventRetargeter.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::eventHasListeners):
- inspector/InspectorInstrumentation.h:
- 5:38 PM Changeset in webkit [157151] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. The 64 bits release bot has been made to use 8 bpp depth, so
fast/dom/Window/window-screen-properties.html won't pass there.
- platform/gtk/TestExpectations:
- 5:24 PM Changeset in webkit [157150] by
-
- 12 edits in trunk
Convert for-of iteration to in-band signalling so we can trivially avoid unnecessary object allocation
https://bugs.webkit.org/show_bug.cgi?id=122532
Reviewed by Michael Saboff.
Source/JavaScriptCore:
Switch for-of enumeration to use in band signalling to determine the end
of iteration. This allows us to trivially remove an otherwise unnecessary
object allocation, and paves the way for optimised thunks in future.
We can re-add explicit .next() functions in future that would marshall
the true iteration functions, but for now we'll ignore them.
This results in a huge improvement in the performance of for-of (in the order
of 2x) but there's still a long way to go in order to get the performance to
a satisfactory level.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForOfNode::emitBytecode):
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
- runtime/JSObject.h:
(JSC::JSFinalObject::create):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
LayoutTests:
Update tests to reflect our non-exposure of .next()
- js/array-iterators-expected.txt:
- js/script-tests/array-iterators.js:
- 5:21 PM Changeset in webkit [157149] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Unreviewed gardening. Make platform-specific expectation file apply only to gtk-wk1, since
gtk-wk2 gets the output right.
- platform/gtk-wk1/fast/loader/show-only-one-beforeunload-dialog-expected.txt: Renamed from LayoutTests/platform/gtk/fast/loader/show-only-one-beforeunload-dialog-expected.txt.
- 5:08 PM Changeset in webkit [157148] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Update gtk-wk2-specific expectations for a couple of
fast/dom/Window tests:
- fast/dom/Window/window-postmessage-clone.html (times out)
- fast/dom/Window/open-window-min-size.html (fails)
- platform/gtk-wk2/TestExpectations:
- 5:05 PM Changeset in webkit [157147] by
-
- 9 edits in trunk/Source
Source/JavaScriptCore: Fixed compile errors while compiling without the JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- jit/JITOperations.cpp:
Protected with #if ENABLE(JIT) like the rest of the JIT source.
Source/ThirdParty/ANGLE: Generate pdb files for debugging ANGLE DLLs.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- ANGLE.vcxproj/libEGLCommon.props:
- ANGLE.vcxproj/libGLESv2Common.props:
Generate debug information.
Source/WebCore: Enabled all necessary files for Win64 build.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj:
Enabled MediaPlayerPrivateFullscreenWindow and
RenderLayerModelObject to be built in Win64 build.
Source/WebKit: Fixed Win64 linking.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added 64-bit linker symbols.
- 4:49 PM Changeset in webkit [157146] by
-
- 14 edits in trunk/Source
Consolidate findString functions
https://bugs.webkit.org/show_bug.cgi?id=122480
Reviewed by Darin Adler.
../WebCore:
- editing/Editor.cpp:
- editing/Editor.h:
- editing/EditorCommand.cpp:
(WebCore::executeFindString):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::find):
- page/Page.cpp:
- page/Page.h:
Fix a long standing FIXME.
../WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_text_search):
- ewk/ewk_view.cpp:
(ewk_view_text_search):
../WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_search_text):
../WebKit/win:
- WebView.cpp:
(WebView::searchFor):
- 4:25 PM Changeset in webkit [157145] by
-
- 2 edits in trunk/LayoutTests
Upgrade accessibility/title-ui-element-correctness.html from crash (wk2-specific)
to fail (gtk-wide) expectation.
- platform/gtk-wk2/TestExpectations:
- 4:20 PM Changeset in webkit [157144] by
-
- 13 edits in trunk/Source/WebCore
Move m_floatingObjects to RenderBlockFlow from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=122512
Reviewed by David Hyatt.
Floats are part of block flow, not every RenderBlock can contain
floars. This change makes it so that RenderBlock no longer can contain
floats, only RenderBlockFlow can.
This also moves a bunch of line layout stuff over to RenderBlockFlow,
but makes no effort to move all of line layout, as all of that is
destined to move out of both RenderBlockFlow and RenderBlock into its
own class.
No new tests, no behavior change.
- rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun):
- rendering/LineWidth.cpp:
(WebCore::LineWidth::LineWidth):
- rendering/LineWidth.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::adjustForBorderFit):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::containsFloats):
(WebCore::RenderBlock::shouldSkipCreatingRunsForObject):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::logicalRightFloatOffsetForLine):
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlock::moveAllChildrenOnRemovalTo):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::clipOutFloatingObjects):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::containsFloat):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::styleWillChange):
(WebCore::RenderBlockFlow::deleteLineBoxTree):
(WebCore::RenderBlockFlow::moveAllChildrenOnRemovalTo):
(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::repaintOverhangingFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
(WebCore::RenderBlockFlow::createFloatingObjects):
(WebCore::RenderBlockFlow::removeFloatingObjects):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObjectsBelow):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::newLine):
(WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlockFlow::logicalRightFloatOffsetForLine):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::addIntrudingFloats):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlockFlow::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::hitTestFloats):
(WebCore::RenderBlockFlow::adjustForBorderFit):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::hasOverhangingFloats):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::LineBreaker):
(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::RenderBlockFlow::createLineBoxes):
(WebCore::RenderBlockFlow::constructLine):
(WebCore::RenderBlockFlow::setMarginsForRubyRun):
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlockFlow::handleTrailingSpaces):
(WebCore::RenderBlockFlow::appendFloatingObjectToLastLine):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::restartLayoutRunsAndFloatsInRange):
(WebCore::pushShapeContentOverflowBelowTheContentBox):
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLine):
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
(WebCore::RenderBlockFlow::repaintDirtyFloats):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::determineEndPosition):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::updateSegmentsForShapes):
(WebCore::RenderBlockFlow::deleteEllipsisLineBoxes):
(WebCore::RenderBlockFlow::checkLinesForTextOverflow):
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::outermostBlockContainingFloatingObject):
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildrenTo):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitFlow):
- 4:05 PM Changeset in webkit [157143] by
-
- 2 edits in trunk/Source/WTF
Turn threaded scrolling on for all Mac ports.
Rubber-stamped by Simon Fraser and Sam Weinig.
- wtf/FeatureDefines.h:
- 4:01 PM Changeset in webkit [157142] by
-
- 3 edits130 moves in trunk/LayoutTests
[CSSRegions] Move autoheight* tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=122514
Reviewed by Sam Weinig.
Move tests, fix include paths, change TestExpectations when necessary.
- fast/regions/auto-size/abspos-autoheight-nested-region-expected.txt: Renamed from LayoutTests/fast/regions/abspos-autoheight-nested-region-expected.txt.
- fast/regions/auto-size/abspos-autoheight-nested-region.html: Renamed from LayoutTests/fast/regions/abspos-autoheight-nested-region.html.
- fast/regions/auto-size/autoheight-abspos-bottom-align-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-abspos-bottom-align-expected.txt.
- fast/regions/auto-size/autoheight-abspos-bottom-align.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-bottom-align.html.
- fast/regions/auto-size/autoheight-abspos-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-region-expected.html.
- fast/regions/auto-size/autoheight-abspos-region.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-region.html.
- fast/regions/auto-size/autoheight-allregions-expected.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-expected.html.
- fast/regions/auto-size/autoheight-allregions-nobreaks-expected.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-nobreaks-expected.html.
- fast/regions/auto-size/autoheight-allregions-nobreaks.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-nobreaks.html.
- fast/regions/auto-size/autoheight-allregions.html: Renamed from LayoutTests/fast/regions/autoheight-allregions.html.
- fast/regions/auto-size/autoheight-break-after-expected.html: Renamed from LayoutTests/fast/regions/autoheight-break-after-expected.html.
- fast/regions/auto-size/autoheight-break-after.html: Renamed from LayoutTests/fast/regions/autoheight-break-after.html.
- fast/regions/auto-size/autoheight-breakafteralways-maxheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-breakafteralways-maxheight-expected.html.
- fast/regions/auto-size/autoheight-breakafteralways-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-breakafteralways-maxheight.html.
- fast/regions/auto-size/autoheight-breakbefore-wrongheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-breakbefore-wrongheight-expected.txt.
- fast/regions/auto-size/autoheight-breakbefore-wrongheight.html: Renamed from LayoutTests/fast/regions/autoheight-breakbefore-wrongheight.html.
- fast/regions/auto-size/autoheight-breakbeforealways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-breakbeforealways-expected.html.
- fast/regions/auto-size/autoheight-breakbeforealways.html: Renamed from LayoutTests/fast/regions/autoheight-breakbeforealways.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-2-expected.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-2-expected.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-2.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-2.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-expected.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-expected.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines.html.
- fast/regions/auto-size/autoheight-definedheight-changenotdetected-expected.html: Renamed from LayoutTests/fast/regions/autoheight-definedheight-changenotdetected-expected.html.
- fast/regions/auto-size/autoheight-definedheight-changenotdetected.html: Renamed from LayoutTests/fast/regions/autoheight-definedheight-changenotdetected.html.
- fast/regions/auto-size/autoheight-dynamic-update-expected.html: Renamed from LayoutTests/fast/regions/autoheight-dynamic-update-expected.html.
- fast/regions/auto-size/autoheight-dynamic-update.html: Renamed from LayoutTests/fast/regions/autoheight-dynamic-update.html.
- fast/regions/auto-size/autoheight-firstregion-breakalways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-firstregion-breakalways-expected.html.
- fast/regions/auto-size/autoheight-firstregion-breakalways.html: Renamed from LayoutTests/fast/regions/autoheight-firstregion-breakalways.html.
- fast/regions/auto-size/autoheight-flexbox-expected.html: Renamed from LayoutTests/fast/regions/autoheight-flexbox-expected.html.
- fast/regions/auto-size/autoheight-flexbox.html: Renamed from LayoutTests/fast/regions/autoheight-flexbox.html.
- fast/regions/auto-size/autoheight-floatright-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-floatright-region-expected.html.
- fast/regions/auto-size/autoheight-floatright-region.html: Renamed from LayoutTests/fast/regions/autoheight-floatright-region.html.
- fast/regions/auto-size/autoheight-horizontal-bt-expected.html: Renamed from LayoutTests/fast/regions/autoheight-horizontal-bt-expected.html.
- fast/regions/auto-size/autoheight-horizontal-bt.html: Renamed from LayoutTests/fast/regions/autoheight-horizontal-bt.html.
- fast/regions/auto-size/autoheight-inlineblock-normalflow-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-inlineblock-normalflow-region-expected.html.
- fast/regions/auto-size/autoheight-inlineblock-normalflow-region.html: Renamed from LayoutTests/fast/regions/autoheight-inlineblock-normalflow-region.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored-expected.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-breaksignored.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-expected.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-expected.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto.html.
- fast/regions/auto-size/autoheight-maxheight-mixed-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-mixed-break-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-mixed-break.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-mixed-break.html.
- fast/regions/auto-size/autoheight-maxheight-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-region-expected.html.
- fast/regions/auto-size/autoheight-maxheight-region.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-region.html.
- fast/regions/auto-size/autoheight-maxheight-simple-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-break-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-simple-break.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-break.html.
- fast/regions/auto-size/autoheight-maxheight-simple-nobreak-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-nobreak-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-simple-nobreak.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-nobreak.html.
- fast/regions/auto-size/autoheight-middleregion-expected.html: Renamed from LayoutTests/fast/regions/autoheight-middleregion-expected.html.
- fast/regions/auto-size/autoheight-middleregion.html: Renamed from LayoutTests/fast/regions/autoheight-middleregion.html.
- fast/regions/auto-size/autoheight-minheight-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-minheight-region-expected.html.
- fast/regions/auto-size/autoheight-minheight-region.html: Renamed from LayoutTests/fast/regions/autoheight-minheight-region.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-hbt-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-hbt.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vlr-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vlr.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vrl-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vrl.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break.html.
- fast/regions/auto-size/autoheight-minmaxheight-simple-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-break-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-simple-break.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-break.html.
- fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-nobreak-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-nobreak.html.
- fast/regions/auto-size/autoheight-mixed-nested-complex-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-complex-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-nested-complex-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-complex-regions.html.
- fast/regions/auto-size/autoheight-mixed-nested-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-nested-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-regions.html.
- fast/regions/auto-size/autoheight-mixed-parallel-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-parallel-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-parallel-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-parallel-regions.html.
- fast/regions/auto-size/autoheight-nested-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-nested-regions-expected.txt.
- fast/regions/auto-size/autoheight-nested-regions.html: Renamed from LayoutTests/fast/regions/autoheight-nested-regions.html.
- fast/regions/auto-size/autoheight-normalflow-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-normalflow-region-expected.html.
- fast/regions/auto-size/autoheight-normalflow-region.html: Renamed from LayoutTests/fast/regions/autoheight-normalflow-region.html.
- fast/regions/auto-size/autoheight-region-decrease-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-maxheight.html.
- fast/regions/auto-size/autoheight-region-decrease-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-minheight.html.
- fast/regions/auto-size/autoheight-region-decrease-width-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-width-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-width.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-width.html.
- fast/regions/auto-size/autoheight-region-increase-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-maxheight.html.
- fast/regions/auto-size/autoheight-region-increase-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-minheight.html.
- fast/regions/auto-size/autoheight-region-increase-width-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-width-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-width.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-width.html.
- fast/regions/auto-size/autoheight-region-new-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-new-maxheight-vrl-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-vrl-expected.txt.
- fast/regions/auto-size/autoheight-region-new-maxheight-vrl.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-vrl.html.
- fast/regions/auto-size/autoheight-region-new-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight.html.
- fast/regions/auto-size/autoheight-region-new-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-new-minheight-vlr-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-vlr-expected.txt.
- fast/regions/auto-size/autoheight-region-new-minheight-vlr.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-vlr.html.
- fast/regions/auto-size/autoheight-region-new-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight.html.
- fast/regions/auto-size/autoheight-region-remove-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-remove-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-remove-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-remove-maxheight.html.
- fast/regions/auto-size/autoheight-region-remove-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-remove-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-remove-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-remove-minheight.html.
- fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-regionlayoutupdate-multipletimes-expected.txt.
- fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html: Renamed from LayoutTests/fast/regions/autoheight-regionlayoutupdate-multipletimes.html.
- fast/regions/auto-size/autoheight-regions-mark-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-regions-mark-expected.txt.
- fast/regions/auto-size/autoheight-regions-mark.html: Renamed from LayoutTests/fast/regions/autoheight-regions-mark.html.
- fast/regions/auto-size/autoheight-secondregion-breakoutside-expected.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-breakoutside-expected.html.
- fast/regions/auto-size/autoheight-secondregion-breakoutside.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-breakoutside.html.
- fast/regions/auto-size/autoheight-secondregion-expected.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-expected.html.
- fast/regions/auto-size/autoheight-secondregion.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways.html.
- fast/regions/auto-size/autoheight-singleregion-breakaftermargin-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakaftermargin.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways.html.
- fast/regions/auto-size/autoheight-singleregion-multiplebreaks-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks-expected.html.
- fast/regions/auto-size/autoheight-singleregion-multiplebreaks.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-breaksignored.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-expected.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto.html.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-001-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-001-expected.txt.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-001.html: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-001.html.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-002-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-002-expected.txt.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-002.html.
- fast/regions/auto-size/autoheight-vertical-lr-expected.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-lr-expected.html.
- fast/regions/auto-size/autoheight-vertical-lr.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-lr.html.
- fast/regions/auto-size/autoheight-vertical-rl-expected.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-rl-expected.html.
- fast/regions/auto-size/autoheight-vertical-rl.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-rl.html.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 3:40 PM Changeset in webkit [157141] by
-
- 4 edits in trunk/Websites/webkit.org
Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525
Reviewed by Gavin Barraclough.
Sync'd sunspider-1.0.2 to PerformanceTests/SunSpider/hosted/sunspider-1.0.2.
- perf/sunspider-1.0.2/sunspider-1.0.2/driver.html:
- perf/sunspider-1.0.2/sunspider-1.0.2/sunspider-test-contents.js:
- perf/sunspider-1.0.2/sunspider.css:
(#frameparent):
(#countdown):
- 3:40 PM Changeset in webkit [157140] by
-
- 4 edits in trunk/PerformanceTests/SunSpider
Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525
Reviewed by Gavin Barraclough.
- hosted/sunspider.css:
(#frameparent):
(#countdown):
- resources/TEMPLATE.html: Provide an explicit countdown element in the
parent, instead of hacking it into each child frame.
- resources/driver-TEMPLATE.html: Be more explicit about how we respond
to power management. Just moving setTimeout(0) inside the loop is a
little too subtle, and may not work across browsers.
Also, leave a little extra time after changing the countdown graphic,
to give the browser some time to paint.
- 2:57 PM Changeset in webkit [157139] by
-
- 2 edits in trunk/LayoutTests
Unreviewed followup to https://bugs.webkit.org/show_bug.cgi?id=122523
This test now passes, so updating expected file.
- fast/canvas/webgl/webgl-unprefixed-context-id-expected.txt:
- 2:17 PM Changeset in webkit [157138] by
-
- 4 edits2 adds in trunk
Support unprefixed WebGL context creation
https://bugs.webkit.org/show_bug.cgi?id=122523
<rdar://problem/15179463>
Reviewed by Simon Fraser.
Source/WebCore:
Add support for the unprefixed "webgl" canvas context type.
Test: fast/canvas/webgl/unprefixed-context.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::is3dType):
- inspector/InjectedScriptCanvasModuleSource.js:
LayoutTests:
Tests that we can create a context without the
"experimental-" prefix. Meanwhile, most of the other
WebGL tests should start to use the unprefixed
form automatically (the helper script attempts
"webgl" first).
- fast/canvas/webgl/unprefixed-context-expected.txt: Added.
- fast/canvas/webgl/unprefixed-context.html: Added.
- 2:05 PM Changeset in webkit [157137] by
-
- 15 edits in trunk/Source/WebKit2
WebProcess crash on SAP WebCycle web app
https://bugs.webkit.org/show_bug.cgi?id=122520
<rdar://problem/15030605>
Reviewed by Darin Adler.
Stop trying to use RunLoop to manage the top-level run loop and just have the child process and their
delegate subclasses start and stop the run loops. This fixes a bug with showModalDialog where we would
unintentionally call -[NSApp stop] when closing a modal dialog.
This also lets us move all knowledge of NSApplication from RunLoop. (Both the web process and plug-in process
need to use -[NSApp run] and -[NSApp stop:]).
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::doPreInitializationWork):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop. Add a startRunLoop override that calls
-[NSApp run].
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(PluginServiceInitializer):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
- PluginProcess/PluginProcess.h:
Add stopRunLoop() override on Mac.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::stopRunLoop):
Call -[NSApp stop:] and tickle the event system.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::stopRunLoop):
Add default implementation that just calls RunLoop::main()->stop().
(WebKit::ChildProcess::terminate):
Call stopRunLoop().
- Shared/ChildProcess.h:
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
Add startRunLoop member function and call it instead of RunLoop::run().
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
(WebKit::ChildProcessMainDelegate::startRunLoop):
Call RunLoop::run().
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
Add startRunLoop override that calls -[NSApp run].
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
Call stopRunLoop().
- WebProcess/WebProcess.h:
Add stopRunLoop override.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::stopRunLoop):
Call -[NSApp stop:] and tickle the event system.
- 1:58 PM Changeset in webkit [157136] by
-
- 18 edits in trunk/Source/WebCore
Rename EventDispatchMediator::dispatchEvent to mediateAndDispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=122522
Reviewed by Darin Adler.
Renamed EventDispatchMediator::dispatchEvent to EventDispatchMediator::mediateAndDispatchEvent
to make the future refactoring easier.
- Modules/indieui/UIRequestEvent.cpp:
(WebCore::UIRequestEventDispatchMediator::mediateAndDispatchEvent):
- Modules/indieui/UIRequestEvent.h:
- dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::mediateAndDispatchEvent):
- dom/EventDispatchMediator.h:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::BlurEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::FocusInEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::FocusOutEventDispatchMediator::mediateAndDispatchEvent):
- dom/FocusEvent.h:
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::mediateAndDispatchEvent):
- dom/GestureEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::mediateAndDispatchEvent):
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::mediateAndDispatchEvent):
- dom/MouseEvent.h:
- dom/TouchEvent.cpp:
(WebCore::TouchEventDispatchMediator::mediateAndDispatchEvent):
- dom/TouchEvent.h:
- dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::mediateAndDispatchEvent):
- dom/WheelEvent.h:
- 1:42 PM Changeset in webkit [157135] by
-
- 2 edits in trunk/Source/WebCore
[MathML] Use of floating point floor/ceil on LayoutUnits seems wrong
https://bugs.webkit.org/show_bug.cgi?id=122367
Reviewed by Darin Adler.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::paintCharacter): Use member methods to compute
correct floor/ceil values for LayoutUnits.
- 1:38 PM Changeset in webkit [157134] by
-
- 2 edits in trunk/LayoutTests
Skip a new WebGL test along with the others.
- platform/gtk/TestExpectations:
- 1:34 PM Changeset in webkit [157133] by
-
- 3 edits2 adds in trunk
Video -> pixel buffer output should not manage color spaces
https://bugs.webkit.org/show_bug.cgi?id=122486
Reviewed by Tim Horton.
Source/WebCore:
On Mac, when we draw a video into a canvas or WebGL, the
output of the video should not be color managed. Instead, leave it
as DeviceRGB so that it matches other colors in those elements.
We'll hopefully solve this properly soon - making everything sRGB.
Test: media/video-canvas-drawing-output.html
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect): Pass on
a CGImageRef via CGImageCreateCopyWithColorSpace rather than the raw data.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Tell CoreImage
to allocate a pixel buffer that is unmanaged.
LayoutTests:
- media/video-canvas-drawing-output-expected.txt: Added.
- media/video-canvas-drawing-output.html: Added.
- 1:30 PM Changeset in webkit [157132] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream] Fix segfault in initializeMockSources()
https://bugs.webkit.org/show_bug.cgi?id=122517
Reviewed by Darin Adler.
Calling release() and a member function on the same RefPtr
as arguments to a function can lead to segfaults if the release
call is evaluated first.
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::initializeMockSources):
- 1:26 PM Changeset in webkit [157131] by
-
- 3 edits in trunk/Tools
Fix ruby LoadError when running run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=122519.
Reviewed by Mark Hahnenberg.
The scripts needed to explicitly require 'rubygems' for older versions of ruby
(versions before 1.9).
- Scripts/jsc-stress-test-helpers/profiler-test-helper:
- Scripts/run-jsc-stress-tests:
- 1:25 PM Changeset in webkit [157130] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/gtk/TestExpectations: fast/backgrounds/background-opaque-images-over-color.html
failing.
- 1:03 PM Changeset in webkit [157129] by
-
- 4 edits in trunk
[CSSRegions] Regions with overflow: hidden should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122389
Reviewed by Alexandru Chiculita.
Source/WebCore:
As a follow-up from https://bugs.webkit.org/show_bug.cgi?id=122321, a region should not
be a normal flow layer when it has overflow clip. Change existing test by adding overflow:hidden
to the region element.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
LayoutTests:
Add overflow: hidden to the region to test that it does not move to the normal flow layers.
- fast/regions/layers/region-normalflow-stacking-context.html:
- 12:58 PM Changeset in webkit [157128] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening, these tests had a couple pixels shift at some point,
needing a new baseline.
- platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
- platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
- 12:44 PM Changeset in webkit [157127] by
-
- 2 edits in trunk/Source/WebCore
Simplify the loop in EventRetargeter::calculateEventPath
https://bugs.webkit.org/show_bug.cgi?id=122500
Reviewed by Antti Koivisto.
Replaced the convoluted loop by two nested loops to make semantics clear.
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
- 12:27 PM Changeset in webkit [157126] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unskip editing/spelling/spelling-changed-text.html
https://bugs.webkit.org/show_bug.cgi?id=122502
Unreviewed gardening.
- platform/mac/TestExpectations:
spelling-changed.html is passing after r156901.
- 12:13 PM Changeset in webkit [157125] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. A couple of media-query tests rely on 3d transforms,
so skip them along with the 3d transforms tests.
- platform/gtk/TestExpectations:
- 11:25 AM Changeset in webkit [157124] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Leak: GdkEvent retured by gtk_get_current_event is not freed.
https://bugs.webkit.org/show_bug.cgi?id=122506
Reviewed by Gustavo Noronha Silva.
Gdk event returned by gtk_get_current_event should be freed after using it.
No functionality changed.
- platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::show):
- 11:03 AM Changeset in webkit [157123] by
-
- 6 edits in trunk/Source/WebCore
Use references in EventRetargeter::calculateEventPath and EventRetargeter::eventTargetRespectingTargetRules
https://bugs.webkit.org/show_bug.cgi?id=122494
Reviewed by Antti Koivisto.
Use referenecs instead of pointers in ventRetargeter's calculateEventPath and eventTargetRespectingTargetRules.
Also replace Vector<EventTarget*, 32> targetStack by a single pointer since we only append an item to
the vector when it's empty and we always use the last item.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
- dom/EventRetargeter.h:
(WebCore::EventRetargeter::eventTargetRespectingTargetRules):
- dom/Node.cpp:
(WebCore::Node::dispatchScopedEventDispatchMediator):
- 10:59 AM Changeset in webkit [157122] by
-
- 2 edits in trunk/Tools
Unreviewed, add my new email to contributors.json.
Patch by Christophe Dumez <Christophe Dumez> on 2013-10-08
- Scripts/webkitpy/common/config/contributors.json:
- 10:33 AM Changeset in webkit [157121] by
-
- 8 edits2 adds in trunk
[CSSRegions] Computed z-Index should return 0 instead of auto for a region
https://bugs.webkit.org/show_bug.cgi?id=122405
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/layers/region-zIndex-computedStyle.html
Adjust the z-index value for a region. Also, since a box with a z-Index
that is non-auto receives a layer, i removed the requiresLayer override
in RenderRegion and RenderMultiColumnSet.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- rendering/RenderMultiColumnSet.cpp:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/regions/layers/region-zIndex-computedStyle-expected.txt: Added.
- fast/regions/layers/region-zIndex-computedStyle.html: Added.
- 10:33 AM Changeset in webkit [157120] by
-
- 5 edits2 adds in trunk
[CSS Regions] Widows don't work if the first line in a region is aligned with the top of the region
https://bugs.webkit.org/show_bug.cgi?id=122450
Reviewed by David Hyatt.
Source/WebCore:
The patch adds a new function updateRegionForLine that updates the containing region for a line and the
flag used to determine if it's the first line in that region. This is necessary because the code in
adjustLinePositionForPagination is not sufficient to determine when an unforced break occurs and the line
being positioned is the first one in the fragmentation container or not.
Test: fast/regions/regions-widows-float-top-aligned.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination): Added FIXME comment.
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlockFlow::updateRegionForLine): New function used to update the containing region and
the first line flag.
LayoutTests:
Simple test veryfing that widows are correctly computed when there is a float affecting the lines
and when they are vertically aligned with the regions height.
- fast/regions/regions-widows-float-top-aligned-expected.html: Added.
- fast/regions/regions-widows-float-top-aligned.html: Added.
- 10:25 AM Changeset in webkit [157119] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSManagedValue should be able to store non-object JSValues
https://bugs.webkit.org/show_bug.cgi?id=122351
Reviewed by Oliver Hunt.
We decided not to support this because we thought it didn't make sense to have a
"weak" JSValue that wasn't an object.
Our general thought process was if you have a JSObject-ObjC object pair (i.e. an
Obj-C object that you exported to JavaScript-land), it makes more sense to store
a non-object JSValue on the JavaScript-land version of the object rather than as
an ivar in the Objective-C object.
In retrospect, this may not have been a good decision at least w.r.t. consistency
in client code. If you're storing a bag of JSValues off an Obj-C object, you'd
like to store all of them either in ObjC-land or JavaScript-land, but doing some
in one and some in the other doesn't sound too good. Also, what if the object you
want to hang these values off of doesn't have a corresponding object in JavaScript-
land in which to store them?
The solution is to fix JSManagedValue to be able to reference non-object JSValues.
Right now, all JSManagedValues contain a Weak<JSObject>. We'll change this so that
they can contain either a non-cell JSValue or a JSObject*, along with a weak
reference to the JSGlobalObject for reconstructing a JSValue later on.
- API/JSManagedValue.mm:
(PrimitiveOrObject::PrimitiveOrObject):
(PrimitiveOrObject::~PrimitiveOrObject):
(PrimitiveOrObject::clear):
(PrimitiveOrObject::isClear):
(PrimitiveOrObject::isSet):
(PrimitiveOrObject::isPrimitive):
(PrimitiveOrObject::isObject):
(PrimitiveOrObject::setPrimitive):
(PrimitiveOrObject::setObject):
(PrimitiveOrObject::object):
(PrimitiveOrObject::primitive):
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue value]):
(-[JSManagedValue disconnectValue]):
- 10:16 AM Changeset in webkit [157118] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Adding ImageOnlyFailure expectations to:
- fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html
- fast/regions/selection/selecting-text-ignoring-region-vert-lr.html
- fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html
- fast/regions/selection/selecting-text-in-2-regions-vert-lr.html
- platform/gtk/TestExpectations:
- 10:12 AM Changeset in webkit [157117] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/styles/add-new-rule-with-style-after-body.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122510
- platform/mac/TestExpectations: Marking as such.
- 10:05 AM Changeset in webkit [157116] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/debugger/debugger-activation-crash2.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122509
- platform/mac/TestExpectations: Marking as such.
- 9:52 AM Changeset in webkit [157115] by
-
- 2 edits in trunk/LayoutTests
Layout Test compositing/video/video-reflection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122508
- platform/mac/TestExpectations: Marking as such.
- 9:47 AM Changeset in webkit [157114] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/track/track-cue-rendering.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122507
- platform/mac/TestExpectations: Marking as such.
- 9:43 AM Changeset in webkit [157113] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, rolling out r157080.
http://trac.webkit.org/changeset/157080
Not a proper baseline
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Removed.
- 9:42 AM Changeset in webkit [157112] by
-
- 2 edits in trunk/Tools
Unreviewed build correction.
- Scripts/webkitpy/port/win.py:
(WinPort.write_registry_value): Use string representation of error message to avoid
format conversion problem.
- 9:38 AM Changeset in webkit [157111] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/video-layer-crash.html
https://bugs.webkit.org/show_bug.cgi?id=114744
- platform/mac/TestExpectations: Marking as such.
- 9:36 AM Changeset in webkit [157110] by
-
- 3 edits in trunk/Source/WebCore
Get EFL and GTK compiling with media stream enabled
https://bugs.webkit.org/show_bug.cgi?id=122505
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-08
Reviewed by Philippe Normand.
After r157068
No new tests needed.
- GNUmakefile.list.am:
- UseJSC.cmake:
- 9:31 AM Changeset in webkit [157109] by
-
- 3 edits in trunk/Source/WebKit/mac
WebNetscapePluginView should no longer use deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122495
Reviewed by Anders Carlsson.
- Plugins/WebNetscapePluginView.h: Use unique_ptr for both the pointer to
the timers hash table, and for the values in the hash table.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView stopTimers]): Rewrote loop so it works with unique_ptr.
(-[WebNetscapePluginView startTimers]): Ditto.
(-[WebNetscapePluginView fini]): Removed unneeded code to delete timers.
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): Make
the timers hash table with make-unique. Fixed the loop that chooses the timer
ID so it won't ever try to use a deleted value, although that never happens
in practice. Use HashMap::add instead of using both contains and set.
Rearranged code so we don't need to make a raw pointer for the timer.
(-[WebNetscapePluginView unscheduleTimer:]): Use remove instead of take/delete,
since remove takes care of the deletion automatically since we are using the
unique_ptr class.
- 8:56 AM Changeset in webkit [157108] by
-
- 3 edits2 adds in trunk
Composited layer that painted into composited ancestor is not repainted after moving
https://bugs.webkit.org/show_bug.cgi?id=114655
Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-10-08
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/repaint/absolute-painted-into-composited-ancestor.html
Composited layers are currently skipping repainting after layout,
if the repaint status is not NeedsFullRepaint. However, in case layers
were painted into composited ancestor, they need to repaint.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldRepaintAfterLayout):
LayoutTests:
Add a text repaint test to check the repainting of composited layer
that painted into composited ancestor.
- compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt: Added.
- compositing/repaint/absolute-painted-into-composited-ancestor.html: Added.
- 8:51 AM Changeset in webkit [157107] by
-
- 3 edits in trunk/Tools
[Win] Add checks for proper build and test environment
https://bugs.webkit.org/show_bug.cgi?id=122466
Reviewed by Darin Adler.
This patch makes two changes:
- Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or error messages so that people know what to fix to get things working.
- Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure the various environment settings are properly configured for our test environment.
- Scripts/webkitdirs.pm:
(checkInstalledTools): Add checks for some common Cygwin configuration problems that have
caused problems in the past.
(setupAppleWinEnv):
- Scripts/webkitpy/port/win.py:
(WinPort):
(WinPort.read_registry_string): Parameterize for run architecture and registry root.
(WinPort.write_registry_value): Parameterize registry writing by data type (string versus
DWORD, etc.)
(WinPort.write_registry_string): Revise to call new generic registry write function.
(WinPort.setup_crash_log_saving): Revise for new API
(WinPort.restore_crash_log_saving): Ditto
(WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
servers from running.
(WinPort.allow_error_dialogs): Ditto.
(WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
(WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
- 8:45 AM Changeset in webkit [157106] by
-
- 2 edits in trunk/Tools
[GStreamer] enable v4l2 plugin
https://bugs.webkit.org/show_bug.cgi?id=122503
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Enable the plugin, it now builds fine since
we updated our GStreamer version to 1.0.8.
- 8:28 AM Changeset in webkit [157105] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r157090.
http://trac.webkit.org/changeset/157090
https://bugs.webkit.org/show_bug.cgi?id=122504
Caused crashes in many plug-in tests (Requested by ap on
#webkit).
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
(WebKit::NPRemoteObjectMap::pluginDestroyed):
- Shared/Plugins/NPRemoteObjectMap.h:
- 8:15 AM Changeset in webkit [157104] by
-
- 2 edits in trunk
[GTK] Re-enable MathML for release builds
https://bugs.webkit.org/show_bug.cgi?id=122361
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-10-08
Reviewed by Darin Adler.
- Source/autotools/SetupWebKitFeatures.m4: Enable MathML for release builds.
- 8:12 AM Changeset in webkit [157103] by
-
- 5 edits in tags/Safari-538.1.3/Source
Versioning.
- 8:10 AM Changeset in webkit [157102] by
-
- 1 copy in tags/Safari-538.1.3
New Tag.
- 7:56 AM Changeset in webkit [157101] by
-
- 3 edits in trunk/Source/WebKit/mac
Eliminate use of deleteAllValues in ProxyInstance
https://bugs.webkit.org/show_bug.cgi?id=122499
Reviewed by Anders Carlsson.
- Plugins/Hosted/ProxyInstance.h: Use unique_ptr for map values in m_fields and m_methods.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::~ProxyInstance): Removed calls to deleteAllValues.
(WebKit::ProxyInstance::methodNamed): Use make_unique and get to deal with map entries
that are unique_ptr. Also fixed a bug where this would do an expensive no-op if the map
already had an entry with a null in it. We would call the plug-in, but eventually
isNewEntry would be false so we would return null.
(WebKit::ProxyInstance::fieldNamed): Use make_unique and get to deal with map entries
that are unique_ptr.
- 7:39 AM Changeset in webkit [157100] by
-
- 5 edits2 deletes in trunk
Unreviewed. Rollout of r156536. ~5% regression in inline layout performance.
Source/WebCore:
- rendering/LineWidth.cpp:
- rendering/LineWidth.h:
(WebCore::LineWidth::addUncommittedWidth):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Removed.
- fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Removed.
- 5:57 AM Changeset in webkit [157099] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Unskip tests that are already passing.
- platform/efl-wk1/TestExpectations: Mark unskipped test as failing for WK1.
- platform/efl/TestExpectations:
- 5:07 AM Changeset in webkit [157098] by
-
- 12 edits in trunk/Source/WebCore
Use toCSSFooValue() instead of using static_cast<const CSSFooValue*>
https://bugs.webkit.org/show_bug.cgi?id=122491
Reviewed by Andreas Kling.
static_cast<const CSSFooValue*> wasn't cleanup. So, we need to use toCSSFooValue() for it.
To use toCSSValue() will help to detect bad type-cast.
Besides static_cast<const WebKitCSSFooValue*> helper functions need to be added to support this use.
No new tests, no behavior change.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyMatches):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
- css/CSSValue.cpp:
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::serializeResolvingVariables):
(WebCore::CSSValue::cloneForCSSOM):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::PropertyReference::cssName):
- css/WebKitCSSSVGDocumentValue.h:
(WebCore::toWebKitCSSSVGDocumentValue):
- css/WebKitCSSTransformValue.h:
(WebCore::toWebKitCSSTransformValue):
- 4:39 AM Changeset in webkit [157097] by
-
- 2 edits in trunk/Source/WebCore
Get MediaStreamCenterGStreamer compiling again
https://bugs.webkit.org/show_bug.cgi?id=122482
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-08
Reviewed by Eric Carlson.
r157068 was including a nonexistent header
No new tests needed.
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- 3:55 AM Changeset in webkit [157096] by
-
- 5 edits in trunk
[ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
https://bugs.webkit.org/show_bug.cgi?id=122104
Reviewed by Chris Fleizach.
Source/WebCore:
Map invalid state of an AccessibilityObject to the proper AtkState.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject): Add the mapping.
Tools:
Updated stringAttributeValue to double check that the exposure of
aria-invalid as a state is consistent with its exposure as a text
attribute as well, when it applies (implementations of AtkText).
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringAttributeValue): Add double check.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
- 3:45 AM Changeset in webkit [157095] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Name for tables are now properly showing
up when exposing information for the parent of a table's cell.
- platform/gtk/accessibility/table-cells-expected.txt: Updated.
- 2:56 AM Changeset in webkit [157094] by
-
- 12 edits in trunk/LayoutTests
context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901
https://bugs.webkit.org/show_bug.cgi?id=122414
Reviewed by Ryosuke Niwa.
On Mac, first call of 'initSpellTest' from spelling/resources/util.js
often fails while checking spelling marker.
Use shouldBecomeDifferent instead of calling timers in the tests.
It should have been done at r156137 when shouldBecomeEqual/Different
was used in asynchronous spell checking tests.
- editing/spelling/resources/util.js:
Use shouldBecomeDifferent instead of timers.
- editing/spelling/context-menu-suggestions-multiword-selection-expected.txt:
- editing/spelling/context-menu-suggestions-subword-selection-expected.txt:
- editing/spelling/spelling-changed-text-expected.txt:
- editing/spelling/spelling-double-clicked-word-expected.txt:
- editing/spelling/spelling-exactly-selected-multiple-words-expected.txt:
- editing/spelling/spelling-exactly-selected-word-expected.txt:
- editing/spelling/spelling-should-select-multiple-words-expected.txt:
- editing/spelling/spelling-with-punctuation-selection-expected.txt:
- editing/spelling/spelling-with-whitespace-selection-expected.txt:
Rebaseline the tests which include util.js due to
shouldBecomeDifferent outputs more logs.
- platform/mac/TestExpectations:
Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for Mac.
- 2:41 AM Changeset in webkit [157093] by
-
- 2 edits in trunk/Source/JavaScriptCore
JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122440
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-08
Reviewed by Darin Adler.
Compilation fails in debug due to 'comparison of unsigned expression >= 0 is
always true'.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::positionForCallFrame): Removed the offending ASSERTS.
- 2:01 AM Changeset in webkit [157092] by
-
- 1 edit32 moves1 add in trunk/LayoutTests
[CSSRegions] Move autosize and autowidth tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=122493
Reviewed by Andreas Kling.
Simple move, changed paths in 2 tests.
- fast/regions/auto-size/autosize-abspos-anchoredregion-expected.txt: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-expected.txt.
- fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr-expected.txt: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-vertlr-expected.txt.
- fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr.html: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-vertlr.html.
- fast/regions/auto-size/autosize-abspos-anchoredregion.html: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion.html.
- fast/regions/auto-size/autosize-region-container-resize-expected.html: Renamed from LayoutTests/fast/regions/autosize-region-container-resize-expected.html.
- fast/regions/auto-size/autosize-region-container-resize.html: Renamed from LayoutTests/fast/regions/autosize-region-container-resize.html.
- fast/regions/auto-size/autosize-region-window-resize-expected.html: Renamed from LayoutTests/fast/regions/autosize-region-window-resize-expected.html.
- fast/regions/auto-size/autosize-region-window-resize.html: Renamed from LayoutTests/fast/regions/autosize-region-window-resize.html.
- fast/regions/auto-size/autowidth-abspos-expected.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-expected.html.
- fast/regions/auto-size/autowidth-abspos-regionchain-expected.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-regionchain-expected.html.
- fast/regions/auto-size/autowidth-abspos-regionchain.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-regionchain.html.
- fast/regions/auto-size/autowidth-abspos.html: Renamed from LayoutTests/fast/regions/autowidth-abspos.html.
- fast/regions/auto-size/autowidth-attachedinvalidregion-expected.txt: Renamed from LayoutTests/fast/regions/autowidth-attachedinvalidregion-expected.txt.
- fast/regions/auto-size/autowidth-attachedinvalidregion.html: Renamed from LayoutTests/fast/regions/autowidth-attachedinvalidregion.html.
- fast/regions/auto-size/autowidth-float-expected.html: Renamed from LayoutTests/fast/regions/autowidth-float-expected.html.
- fast/regions/auto-size/autowidth-float.html: Renamed from LayoutTests/fast/regions/autowidth-float.html.
- fast/regions/auto-size/autowidth-inlineblock-expected.html: Renamed from LayoutTests/fast/regions/autowidth-inlineblock-expected.html.
- fast/regions/auto-size/autowidth-inlineblock.html: Renamed from LayoutTests/fast/regions/autowidth-inlineblock.html.
- fast/regions/auto-size/autowidth-nonreplaced-abspos-expected.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplaced-abspos-expected.html.
- fast/regions/auto-size/autowidth-nonreplaced-abspos.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplaced-abspos.html.
- fast/regions/auto-size/autowidth-nonreplacedblock-normalflow-expected.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplacedblock-normalflow-expected.html.
- fast/regions/auto-size/autowidth-nonreplacedblock-normalflow.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplacedblock-normalflow.html.
- fast/regions/auto-size/autowidth-normalflow-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-expected.html.
- fast/regions/auto-size/autowidth-normalflow-maxwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-maxwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-maxwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-maxwidth.html.
- fast/regions/auto-size/autowidth-normalflow-minmaxwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minmaxwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-minmaxwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minmaxwidth.html.
- fast/regions/auto-size/autowidth-normalflow-minwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-minwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minwidth.html.
- fast/regions/auto-size/autowidth-normalflow-vertrl-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-vertrl-expected.html.
- fast/regions/auto-size/autowidth-normalflow-vertrl.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-vertrl.html.
- fast/regions/auto-size/autowidth-normalflow.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow.html.
- 1:07 AM Changeset in webkit [157091] by
-
- 4 edits in trunk
[GTK] media/video-src-blob.html
https://bugs.webkit.org/show_bug.cgi?id=102586
Reviewed by Martin Robinson.
Source/WebCore:
Add support for loading videos using blob URLs.
Fixes media/video-src-blob.html.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart): Use BufferData buffering policy for blob
URLs.
(webKitWebSrcGetProtocols): Add blob to the list of supported
protocols.
(webKitWebSrcSetUri): Consider blob URLs as valid.
LayoutTests:
- platform/gtk/TestExpectations: Unskip
media/video-src-blob.html.
- 12:58 AM Changeset in webkit [157090] by
-
- 3 edits in trunk/Source/WebKit2
Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496
Reviewed by Andreas Kling.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when putting objects
into the map.
(WebKit::NPRemoteObjectMap::pluginDestroyed): Instead of making an array of receivers
and deleting them all, remove all of the receivers from the map, which will take care
of deleting them. Also change the other loop to use a similar coding style.
- Shared/Plugins/NPRemoteObjectMap.h: Change the value type of m_registeredNPObjects
to be unique_ptr instead of a raw pointer.
- 12:45 AM Changeset in webkit [157089] by
-
- 7 edits in trunk/Source/WebKit/mac
Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122492
Reviewed by Andreas Kling.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin): Use auto so this works with
unique_ptr instead of auto_ptr.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCGetScriptableNPObjectReply): Use make_unique instead of using new directly.
(WKPCBooleanReply): Ditto.
(WKPCBooleanAndDataReply): Ditto.
(WKPCInstantiatePluginReply): Ditto.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Changed m_replies to map to unique_ptr
instead of to a raw pointer.
(WebKit::NetscapePluginInstanceProxy::setCurrentReply): Changed to take a unique_ptr
instead of a raw pointer since this takes ownership of the pointer.
(WebKit::NetscapePluginInstanceProxy::waitForReply): Changed to return a unique_ptr
instead of a auto_ptr because that's better. Use unique_ptr inside the function
too to avoid the need for an explicit delete.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy): Removed the call to
deleteAllValues.
(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Removed unneeded initialization
of a local variable that was already set in all code paths.
(WebKit::NetscapePluginInstanceProxy::wheelEvent): Use auto so this works with unique_ptr
instead of auto_ptr.
(WebKit::NetscapePluginInstanceProxy::print): Ditto.
(WebKit::NetscapePluginInstanceProxy::snapshot): Ditto. Ditto.
(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Changed to return
a unique_ptr. Also removed an unneeded assertion.
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Use auto so this works
with unique_ptr instead of auto_ptr.
- Plugins/Hosted/ProxyInstance.h: Changed return type of waitForReply to unique_ptr.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke): Use auto so this works with unique_ptr instead of auto_ptr.
(WebKit::ProxyInstance::supportsInvokeDefaultMethod): Ditto.
(WebKit::ProxyInstance::supportsConstruct): Ditto.
(WebKit::ProxyInstance::getPropertyNames): Ditto.
(WebKit::ProxyInstance::methodNamed): Ditto.
(WebKit::ProxyInstance::fieldNamed): Ditto.
(WebKit::ProxyInstance::fieldValue): Ditto.
(WebKit::ProxyInstance::setFieldValue): Ditto.
Oct 7, 2013:
- 11:14 PM Changeset in webkit [157088] by
-
- 2 edits in trunk/LayoutTests
webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=120148
- platform/mac-wk2/TestExpectations: Removed a duplicate expectation that I overlooked
at first. Note that having separate expectations for Debug and Release doesn't
appear to work.
- 11:09 PM Changeset in webkit [157087] by
-
- 2 edits in trunk/LayoutTests
webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=120148
- platform/mac-wk2/TestExpectations: Updated expectations to cover debug assertions,
and that this is not limited to Lion.
- 11:03 PM Changeset in webkit [157086] by
-
- 2 edits in trunk/LayoutTests
Layout Test mathml/very-large-stretchy-operators.html is failing
https://bugs.webkit.org/show_bug.cgi?id=122490
- platform/mac/TestExpectations: Skipped the test. It's faiing with a timeout and
taking up to 80 seconds.
- 9:44 PM Changeset in webkit [157085] by
-
- 3 edits in trunk/Source/WebCore
EventDispatchBehavior is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=122483
Reviewed by Andreas Kling.
Removed EventDispatchBehavior and changed the return type of determineDispatchBehavior to bool.
Also renamed it to shouldEventCrossShadowBoundary to reflect the semantics more clear.
- dom/EventRetargeter.cpp:
(WebCore::shouldEventCrossShadowBoundary):
(WebCore::EventRetargeter::calculateEventPath):
- dom/EventRetargeter.h:
- 8:43 PM Changeset in webkit [157084] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests progress meter should update more quickly on older Rubies
https://bugs.webkit.org/show_bug.cgi?id=122459
Reviewed by Darin Adler.
- Scripts/run-jsc-stress-tests:
- 8:38 PM Changeset in webkit [157083] by
-
- 3 edits in trunk/Source/WebCore
Make buildRelatedNodeMap and findRelatedNode static to EventRetargeter.cpp
https://bugs.webkit.org/show_bug.cgi?id=122477
Reviewed by Antti Koivisto.
Make EventRetargeter::buildRelatedNodeMap and EventRetargeter::findRelatedNode static local functions
in EventRetargeter.cpp since they're only called in EventRetargeter::calculateAdjustedNodes and don't
depend on any oher member function or variable (EventRetarger doesn't have any member variables).
Also get rid of Vector local variables in both functions as they're redundant.
- dom/EventRetargeter.cpp:
(WebCore::buildRelatedNodeMap): Moved. Replaced Vector<Node*, 32> relatedNodeStack by a single pointer
since the only time we add an item to this Vector is when it's empty, and we always use or remove the
last item.
(WebCore::addRelatedNodeForUnmapedTreeScopes): Renamed from EventRetargeter::findRelatedNode. Removed
Vector<TreeScope*, 32> parentTreeScopes since it only contains the ancestor tree scopes of scope up to
a tree scope already in relatedNodeMap. We could simply remember this tree scope and re-traverse the
ancestor tree scopes in the second loop.
(WebCore::EventRetargeter::calculateAdjustedNodes):
- dom/EventRetargeter.h:
- 8:29 PM Changeset in webkit [157082] by
-
- 3 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to JSNotAnObject constructor.
<https://webkit.org/b/122474>
Reviewed by Sam Weinig.
JSNotAnObject was only using the ExecState to find the VM.
- 8:28 PM Changeset in webkit [157081] by
-
- 5 edits in trunk/Source/WebCore
CTTE: EditCommand always has a Document.
<https://webkit.org/b/122473>
Reviewed by Anders Carlsson.
Store a Ref<Document> in EditComment since it's never null.
Since Ref enforces more const consistency than RefPtr, I had to make
document() and frame() non-const here. Only a single method depended
on the old half-const behavior.
- 8:26 PM Changeset in webkit [157080] by
-
- 1 edit5 adds in trunk/LayoutTests
Gardening: add baselines for new tests.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Added.
- 7:49 PM Changeset in webkit [157079] by
-
- 2 edits in trunk/LayoutTests
Gardening: skip audio/video track tests, since those are not yet supported by our
media player.
- platform/gtk/TestExpectations:
- 7:40 PM Changeset in webkit [157078] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marking svg/animations/svglengthlist-animation-3.html as flaky.
- platform/gtk/TestExpectations:
- 6:59 PM Changeset in webkit [157077] by
-
- 4 edits in trunk/Source/WTF
Improve HashMap::add comment and other similar comments
https://bugs.webkit.org/show_bug.cgi?id=122432
Reviewed by Andreas Kling.
- wtf/HashCountedSet.h:
- wtf/HashMap.h:
- wtf/HashSet.h:
Updated comment wording. They were a bit old and out of date.
They also featured the word "interator".
- 6:37 PM Changeset in webkit [157076] by
-
- 2 edits in trunk/Source/WebCore
Update test again.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- 6:34 PM Changeset in webkit [157075] by
-
- 29 edits in trunk/Source/WebCore
Unreviewed, rolling out r157061.
http://trac.webkit.org/changeset/157061
https://bugs.webkit.org/show_bug.cgi?id=122479
Broke worker tests (Requested by andersca on #webkit).
- Modules/webdatabase/Database.cpp:
(WebCore::DerefContextTask::create):
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::create):
(WebCore::DeliverPendingCallbackTask::performTask):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::create):
(WebCore::DeleteCallbackDataTask::performTask):
(WebCore::DeleteCallbackDataTask::isCleanupTask):
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::performTask):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::performTask):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::performTask):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::performTask):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::performTask):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::performTask):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::performTask):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::performTask):
(WebCore::createCallbackTask):
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::create):
(WebCore::ProcessMessagesSoonTask::performTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::CallCacheListenerTask::create):
(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerExceptionTask::performTask):
(WebCore::WorkerGlobalScopeDestroyedTask::create):
(WebCore::WorkerGlobalScopeDestroyedTask::performTask):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerTerminateTask::WorkerTerminateTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerThreadActivityReportTask::performTask):
(WebCore::PostMessageToPageInspectorTask::create):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::NotifyNetworkStateChangeTask::create):
(WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask):
(WebCore::NotifyNetworkStateChangeTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownFinishTask::isCleanupTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
- 6:28 PM Changeset in webkit [157074] by
-
- 4 edits in trunk/Source
Make Vector::insert work for move-only types
https://bugs.webkit.org/show_bug.cgi?id=122429
Reviewed by Anders Carlsson.
Source/WebCore:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::padDailyCountsForNewVisit): Call insertVector.
Also added some inline capacity, which should make this faster.
Source/WTF:
- wtf/Vector.h:
(WTF::Vector::insert): Take an rvalue reference instead of a const reference.
(WTF::Vector::insertVector): Renamed to avoid overloading troubles, analogous
to what we did for appendVector.
- 6:24 PM Changeset in webkit [157073] by
-
- 2 edits in trunk/Tools
[buildbot] parse tests that are reported as crashed correctly for GTK+
https://bugs.webkit.org/show_bug.cgi?id=122476
Reviewed by Martin Robinson.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
as a failure of the API tests.
- 6:21 PM Changeset in webkit [157072] by
-
- 2 edits in trunk/Tools
Unreviewed. Skipping API test that is causing the next one to crash,
see https://bugs.webkit.org/show_bug.cgi?id=121970.
- Scripts/run-gtk-tests:
(TestRunner):
- 6:04 PM Changeset in webkit [157071] by
-
- 2 edits in trunk/Source/WebCore
Update test results.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- 5:36 PM Changeset in webkit [157070] by
-
- 19 edits8 adds in trunk
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Source/WebCore:
Reviewed by David Hyatt.
Tests: mathml/presentation/mo-minus.html
mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html
MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.
Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.
With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.
- css/mathml.css:
Not sure what this line-height:0 was here for, but it caused bugs with the new code
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.
- mathml/MathMLTextElement.h:
(MathMLTextElement):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.
(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout
(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Return the stretched operator height, if appropriate.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.
- rendering/mathml/RenderMathMLOperator.h: Update method declarations.
LayoutTests:
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.
Add some reftests for stretchy operators.
- TestExpectations: The remaining MathML pixel tests are broken by this patch.
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
- mathml/presentation/mo-minus.html: Added.
- mathml/presentation/mo-stacked-glyphs-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar.html: Added.
- mathml/very-large-stretchy-operators-expected.txt: Added.
- mathml/very-large-stretchy-operators.html: Added.
- 4:56 PM Changeset in webkit [157069] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests does not distinguish between failure and crashes
https://bugs.webkit.org/show_bug.cgi?id=122135
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.
The GTK+ API test runner does not distinguish between failures and crashes. This change
makes it do that, so it's easier for us to spot the more important/higher priority crash
case.
- Scripts/run-gtk-tests:
(TestRunner._run_test_command): return the exit code instead of a boolean true/false,
so we have more information on how the process ended.
(TestRunner._run_test): check the exit code to distinguish between crashes and failures.
(TestRunner.run_tests): report crashes.
- 4:48 PM Changeset in webkit [157068] by
-
- 38 edits27 adds in trunk
[MediaStream API] update MediaStreamTrack object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121940
Reviewed by Jer Noble.
Source/WebCore:
No new tests, existing test updated.
Add new source files to the project:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
New capability dictionary objects:
- Modules/mediastream/AllAudioCapabilities.h: Added.
- Modules/mediastream/AllAudioCapabilities.idl: Added.
- Modules/mediastream/AllVideoCapabilities.h: Added.
- Modules/mediastream/AllVideoCapabilities.idl: Added.
- Modules/mediastream/AudioStreamTrack.cpp:
(WebCore::AudioStreamTrack::create): New version that takes a MediaStreamTrack*.
- Modules/mediastream/AudioStreamTrack.h:
New object for a capability range:
- Modules/mediastream/CapabilityRange.cpp: Added.
- Modules/mediastream/CapabilityRange.h: Added.
- Modules/mediastream/CapabilityRange.idl: Added.
- Modules/mediastream/MediaConstraintsImpl.h: Make initialize() public.
New object for the current states for a media source.
- Modules/mediastream/MediaSourceStates.cpp: Added.
- Modules/mediastream/MediaSourceStates.h: Added.
- Modules/mediastream/MediaSourceStates.idl: Added.
Don't call the media stream center to notify it when the state of other
objects change.
- Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack): Remove the stream source duplication hack.
(WebCore::createFromSourceVectors):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
- Modules/mediastream/MediaStream.h:
New object for the capabilities of a source.
- Modules/mediastream/MediaStreamCapabilities.cpp: Added.
- Modules/mediastream/MediaStreamCapabilities.h: Added.
- Modules/mediastream/MediaStreamCapabilities.idl: Added.
Update interface to match spec.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack): Define a copy constructor to use in clone().
(WebCore::MediaStreamTrack::setSource): Call removeObserver if the track already has a source.
Initialize m_muted from new source's muted state.
(WebCore::MediaStreamTrack::id): Allow source to provide ID as the spec suggests.
(WebCore::MediaStreamTrack::setEnabled): Add some spec text to clarify logic. Always call
source->setEnabled, it can figure out if nothing needs to be done.
(WebCore::MediaStreamTrack::muted): Don't call the stream center when muted changes, the
source can take care of notifying interested parties.
(WebCore::MediaStreamTrack::readonly): New.
(WebCore::MediaStreamTrack::remote): New.
(WebCore::MediaStreamTrack::constraints): New.
(WebCore::MediaStreamTrack::states): New.
(WebCore::MediaStreamTrack::capabilities): New.
(WebCore::MediaStreamTrack::applyConstraints): New.
(WebCore::MediaStreamTrack::clone): New.
(WebCore::MediaStreamTrack::stopProducingData): New.
(WebCore::MediaStreamTrack::sourceStateChanged): Renamed from sourceChangedState.
(WebCore::MediaStreamTrack::sourceMutedChanged): New.
(WebCore::MediaStreamTrack::sourceEnabledChanged): New.
(WebCore::MediaStreamTrack::configureTrackRendering): New.
(WebCore::MediaStreamTrack::stopped): New.
(WebCore::MediaStreamTrack::stop): Call stopProducingData.
(WebCore::MediaStreamTrack::scheduleEventDispatch): New.
(WebCore::MediaStreamTrack::dispatchQueuedEvents): New.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/MediaTrackConstraint.cpp: Added.
- Modules/mediastream/MediaTrackConstraint.h: Added.
- Modules/mediastream/MediaTrackConstraint.idl: Added.
Add empty classes/IDL for track constraint objects.
- Modules/mediastream/MediaTrackConstraintSet.cpp: Added.
- Modules/mediastream/MediaTrackConstraintSet.h: Added.
- Modules/mediastream/MediaTrackConstraintSet.idl: Added.
- Modules/mediastream/MediaTrackConstraints.cpp: Added.
- Modules/mediastream/MediaTrackConstraints.h: Added.
- Modules/mediastream/MediaTrackConstraints.idl: Added.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler): Don't call the stream center, the
stream can take care of notifying interested parties.
Add a constructor and create() that take a MediaStreamTrack*.
- Modules/mediastream/VideoStreamTrack.cpp:
(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack):
- Modules/mediastream/VideoStreamTrack.h:
Create a MediaStreamSource subclass for WebAudio
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource): Call isAudioStreamSource instead
of checking deviceID.
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): Create a
MediaStreamAudioSource instead of a MediaStreamSource.
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSource.cpp: Added.
- Modules/webaudio/MediaStreamAudioSource.h: Added.
(WebCore::MediaStreamAudioSource::~MediaStreamAudioSource):
Add new generated files.
- bindings/js/JSMediaSourceStatesCustom.cpp: Added.
- bindings/js/JSMediaStreamCapabilitiesCustom.cpp: Added.
- dom/EventNames.h: Defined 'overconstrained' event.
- platform/mediastream/MediaStreamCenter.h: Get rid of all of the methods nobody uses.
It isn't clear that they are necessary, and we can add them back if/when we need them.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::~MediaStreamDescriptor): Clear the all source streams.
(WebCore::MediaStreamDescriptor::removeSource): Clear the source stream.
- platform/mediastream/MediaStreamDescriptor.h:
Make MediaStreamSource an abstract base class, and remove everyting WebAudio-specific
to MediaStreamAudioSource.
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::MediaStreamSource): Remove readyState and requiresConsumer
parameters. Create new UUID for id if non was passed.
(WebCore::MediaStreamSource::reset): Reset internal state to just-constructed. Used for testing.
(WebCore::MediaStreamSource::setReadyState): sourceChangedState -> sourceStateChanged.
(WebCore::MediaStreamSource::setStream): Remove the ASSERT that check for a source being
added to a new stream. This is still a problem, but it is required for testing and will
be fixed as a part of bug 121954.
(WebCore::MediaStreamSource::setConstraints): Added.
(WebCore::MediaStreamSource::setMuted): Notify observers when muted changes.
(WebCore::MediaStreamSource::setEnabled): Notify observers when enabled changes.
(WebCore::MediaStreamSource::readonly): New.
(WebCore::MediaStreamSource::stop): New. Set state to Ended when all of the observers has
stopped.
- platform/mediastream/MediaStreamSource.h:
Define platform versions of the Capabilities classes.
- platform/mediastream/MediaStreamSourceCapabilities.h: Added.
Update the non-functional platform stream centers for the API changes.
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
- platform/mediastream/mac/MediaStreamCenterMac.cpp:
- platform/mediastream/mac/MediaStreamCenterMac.h:
Update the Mock stream center for the API changes. Add a concrete mock MediaStreamSource
subclass.
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockSource::MockSource): New, the mock media stream source.
(WebCore::MockSource::~MockSource):
(WebCore::MockSource::capabilities):
(WebCore::MockSource::states):
(WebCore::mockSourceMap):
(WebCore::mockAudioSourceID):
(WebCore::mockVideoSourceID):
(WebCore::initializeMockSources): Create one audio and one video mock source.
(WebCore::MockMediaStreamCenter::registerMockMediaStreamCenter): Call initializeMockSources.
(WebCore::MockMediaStreamCenter::createMediaStream): Use the already allocated mock media
sources.
(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): Ditto.
- platform/mock/MockMediaStreamCenter.h:
LayoutTests:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/MediaStreamTrack.html:
- fast/mediastream/MediaStreamTrack-getSources-expected.txt:
- fast/mediastream/MediaStreamTrack-getSources.html:
- 4:43 PM Changeset in webkit [157067] by
-
- 2 edits in trunk/Tools
[GTK] Missing packages for APT on install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=121555
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-10-07
Reviewed by Martin Robinson.
- gtk/install-dependencies: add packages that are needed for
building WebKit itself and the jhbuild dependencies.
- 4:33 PM Changeset in webkit [157066] by
-
- 2 edits in trunk/Source/WTF
Fix Windows build.
- wtf/StdLibExtras.h:
(std::make_unique):
- 4:05 PM Changeset in webkit [157065] by
-
- 35 edits in trunk/Source/WebCore
CTTE: Live node lists always have an owner Node.
<https://webkit.org/b/122470>
Reviewed by Anders Carlsson.
Make LiveNodeListBase::m_ownerNode a Ref<Node> instead of a RefPtr
and have all constructors take Node&.
- 4:01 PM Changeset in webkit [157064] by
-
- 3 edits in trunk/Source/WebKit2
Reduce duplicated code in WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=122230
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2013-10-07
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): move duplicate code to resetState and call it.
(WebKit::WebPageProxy::resetState): new private method for code that is shared between
close and resetStateAfterProcessExited.
(WebKit::WebPageProxy::resetStateAfterProcessExited): move duplicate code to resetState
and call it.
- UIProcess/WebPageProxy.h:
- 3:58 PM Changeset in webkit [157063] by
-
- 3 edits in trunk/Tools
Fix test failures.
- Scripts/webkitpy/port/base.py:
(Port.to.start_helper):
- Scripts/webkitpy/port/mock_drt.py:
(MockDRTPort.start_helper):
- 3:46 PM Changeset in webkit [157062] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL memory allocator should be able to allocate data sections in non-executable memory
https://bugs.webkit.org/show_bug.cgi?id=116189
Reviewed by Sam Weinig.
Use a RefCountedArray<int64_t> for data sections. This works out great because
RefCountedArray<> knows its own size and because the reference counting makes passing
it around very easy (you don't have to stress out about ownership).
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::addDataSection):
- ftl/FTLJITCode.h:
(JSC::FTL::JITCode::dataSections):
- 3:37 PM Changeset in webkit [157061] by
-
- 29 edits in trunk/Source/WebCore
Clean up ScriptExecutionContext::Task and subclasses
https://bugs.webkit.org/show_bug.cgi?id=122469
Reviewed by Andreas Kling.
- Modules/webdatabase/Database.cpp:
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- dom/CrossThreadTask.h:
(WebCore::createCallbackTask):
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::ProcessMessagesSoonTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
- dom/ScriptExecutionContext.h:
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::WorkerThreadShutdownFinishTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
- 3:25 PM Changeset in webkit [157060] by
-
- 4 edits in trunk/Source
Modify WTF and JavaScriptCore makefiles for x64 build.
https://bugs.webkit.org/show_bug.cgi?id=122467.
<rdar://problem/15169174>.
Reviewed by Brent Fulgham.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- 3:08 PM Changeset in webkit [157059] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom()
https://bugs.webkit.org/show_bug.cgi?id=122363
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-07
Reviewed by Filip Pizlo.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- 1:34 PM Changeset in webkit [157058] by
-
- 61 edits in trunk/Source
CTTE: Use references in and around DragController
https://bugs.webkit.org/show_bug.cgi?id=122427
Patch by Sam Weinig <sam@webkit.org> on 2013-10-07
Reviewed by Andreas Kling.
Source/WebCore:
Use references to indicate non-nullness of DragController related
objects.
Source/WebKit/efl:
- WebCoreSupport/DragClientEfl.cpp:
(WebCore::DragClientEfl::willPerformDragDestinationAction):
(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::actionMaskForDrag):
(WebCore::DragClientEfl::startDrag):
- WebCoreSupport/DragClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::willPerformDragDestinationAction):
(WebKit::DragClient::willPerformDragSourceAction):
(WebKit::DragClient::actionMaskForDrag):
(WebKit::DragClient::startDrag):
- WebCoreSupport/DragClientGtk.h:
- webkit/webkitwebview.cpp:
(dragExitedCallback):
(webkit_web_view_drag_motion):
(webkit_web_view_drag_data_received):
(webkit_web_view_drag_drop):
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):
- WebView/WebFrame.mm:
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
- WebView/WebView.mm:
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):
Source/WebKit/win:
- WebCoreSupport/WebDragClient.cpp:
(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
- WebCoreSupport/WebDragClient.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):
(dragExitedCallback):
(webkitWebViewBaseDragDrop):
- UIProcess/API/mac/WKView.mm:
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
(WebKit::cachedImage):
(WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
- 1:28 PM Changeset in webkit [157057] by
-
- 5 edits in trunk/Tools
Always force discrete mode when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=122465
Reviewed by Tim Horton.
This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Link with IOKit.
- DumpRenderTree/mac/LayoutTestHelper.m:
(installLayoutTestColorProfile):
Check installColorProfile.
(restoreUserColorProfile):
Check installColorProfile.
(lockDownDiscreteGraphics):
New function to force discrete graphics.
(main):
Add '--install-color-profile' option.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run):
Always start the helper, but pass self._options.pixel_tests to it.
- Scripts/webkitpy/port/mac.py:
(MacPort.start_helper):
Pass --install-color-profile' to the helper if pixel_tests is true.
- 1:27 PM Changeset in webkit [157056] by
-
- 9 edits in trunk/Source
Animated images are not restarted when page visibility changes
https://bugs.webkit.org/show_bug.cgi?id=122464
<rdar://problem/14293474>
Reviewed by Simon Fraser.
Always kickstart animated images when the page visibility changes,
which can occur via window occlusion, and which is independent of in-window
state, which we were previously using to advance animation.
No new tests; attempts to make a test have resulted only in a flaky, timing-dependent test.
- page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
Move this call to resumeAnimatingImages() up to Page.
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
Move this call to resumeAnimatingImages() up to Page.
- WebCore.exp.in
- page/FrameView.h:
- page/Page.h:
Move resumeAnimatingImages() itself up to Page.
- page/Page.cpp:
(WebCore::Page::setIsInWindow):
Resume animated images when we move in-window.
(WebCore::Page::setVisibilityState):
Resume animated images when we become visible.
This is the one we were previously missing.
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
Resume animated images when we're told to.
(WebCore::Page::resumeAnimatingImages):
Kickstart any animated images in all frames.
- 1:04 PM Changeset in webkit [157055] by
-
- 4 edits3 adds in trunk
[Mac] Drawing video into canvas doesn't work on the first attempt
https://bugs.webkit.org/show_bug.cgi?id=122404
Patch by Jer Noble <jer.noble@apple.com> on 2013-10-07
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-canvas-drawing.html
If creating and painting from an AVPlayerItemVideoOutput fails, fall back
to the (much slower) AVAssetImageGenerator path. Make sure to revert to the
AVPlayerItemVideoOutput path when that object begins to have available
images, however.
To do so, remove the "MAC_OS_X_VERSION_MIN_REQUIRED < 1080" check around
the AVAssetImageGenerator code, and allow both the image generator and video
output to exist simultaneously.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationObjC::videoOutputHasAvailableFrame):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
LayoutTests:
- media/video-canvas-drawing-expected.png: Added.
- media/video-canvas-drawing-expected.txt: Added.
- media/video-canvas-drawing.html: Added.
- 12:12 PM Changeset in webkit [157054] by
-
- 5 edits6 moves in trunk/Source/WebCore
URLMediaSource.idl and URLMediaStream.idl are wrong
https://bugs.webkit.org/show_bug.cgi?id=122301
Reviewed by Philippe Normand.
Rename URLMediaSource and URLMediaStream to DOMURLMediaSource and DOMURLMediaStream,
respectively.
Update the build files:
- CMakeLists.txt: Rename URL -> DOMURL.
- DerivedSources.make: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
Rename the .idl and implementation files:
- Modules/mediasource/DOMURLMediaSource.cpp: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.cpp.
(WebCore::DOMURLMediaSource::createObjectURL):
- Modules/mediasource/DOMURLMediaSource.h: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.h.
- Modules/mediasource/DOMURLMediaSource.idl: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.idl.
- Modules/mediastream/DOMURLMediaStream.cpp: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.cpp.
(WebCore::DOMURLMediaStream::createObjectURL):
- Modules/mediastream/DOMURLMediaStream.h: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.h.
- Modules/mediastream/DOMURLMediaStream.idl: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.idl.
- 11:58 AM Changeset in webkit [157053] by
-
- 2 edits in trunk/LayoutTests
css3/images/cross-fade-svg-with-opacity.html fails with colorspace mismatch on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=122456
- platform/mac-wk2/TestExpectations:
Mark the test as failing for now.
- 11:52 AM Changeset in webkit [157052] by
-
- 3 edits in trunk/Tools
Properly count binding test failures as failures.
Fix the total for multiple failures in different steps too by avoiding undefined.
https://bugs.webkit.org/show_bug.cgi?id=122232
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- 11:50 AM Changeset in webkit [157051] by
-
- 1 edit36 moves1 add in trunk/LayoutTests
[CSSRegions] Move region styling tests into fast/regions/region-styling
https://bugs.webkit.org/show_bug.cgi?id=122451
Reviewed by Sam Weinig.
Create region-styling folder under fast/regions and move related region styling tests.
- fast/regions/region-styling/parse-incomplete-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule-expected.txt.
- fast/regions/region-styling/parse-incomplete-region-rule.html: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule.html.
- fast/regions/region-styling/parsing-region-style-rule-expected.txt: Renamed from LayoutTests/fast/regions/parsing-region-style-rule-expected.txt.
- fast/regions/region-styling/parsing-region-style-rule.html: Renamed from LayoutTests/fast/regions/parsing-region-style-rule.html.
- fast/regions/region-styling/region-rule-nested-region-rule-expected.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule-expected.html.
- fast/regions/region-styling/region-rule-nested-region-rule.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule.html.
- fast/regions/region-styling/region-style-block-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color-expected.html.
- fast/regions/region-styling/region-style-block-background-color.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color.html.
- fast/regions/region-styling/region-style-block-background-color2-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2-expected.html.
- fast/regions/region-styling/region-style-block-background-color2.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2.html.
- fast/regions/region-styling/region-style-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-color-expected.html.
- fast/regions/region-styling/region-style-color.html: Renamed from LayoutTests/fast/regions/region-style-color.html.
- fast/regions/region-styling/region-style-image-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color-expected.html.
- fast/regions/region-styling/region-style-image-background-color.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color.html.
- fast/regions/region-styling/region-style-in-columns-expected.html: Renamed from LayoutTests/fast/regions/region-style-in-columns-expected.html.
- fast/regions/region-styling/region-style-in-columns.html: Renamed from LayoutTests/fast/regions/region-style-in-columns.html.
- fast/regions/region-styling/region-style-inline-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color-expected.html.
- fast/regions/region-styling/region-style-inline-background-color.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color.html.
- fast/regions/region-styling/region-style-not-supported-properties-expected.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties-expected.html.
- fast/regions/region-styling/region-style-not-supported-properties.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties.html.
- fast/regions/region-styling/region-style-rule-position-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-position-expected.html.
- fast/regions/region-styling/region-style-rule-position.html: Renamed from LayoutTests/fast/regions/region-style-rule-position.html.
- fast/regions/region-styling/region-style-rule-specificity-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity-expected.html.
- fast/regions/region-styling/region-style-rule-specificity.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity.html.
- fast/regions/region-styling/region-styling-mediaquery-expected.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery-expected.html.
- fast/regions/region-styling/region-styling-mediaquery.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery.html.
- fast/regions/region-styling/remove-leftover-anon-block-crash-expected.txt: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash-expected.txt.
- fast/regions/region-styling/remove-leftover-anon-block-crash.html: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash.html.
- fast/regions/region-styling/removed-element-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash-expected.txt.
- fast/regions/region-styling/removed-element-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash.html.
- fast/regions/region-styling/render-region-custom-style-mark-expected.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark-expected.html.
- fast/regions/region-styling/render-region-custom-style-mark.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark.html.
- fast/regions/region-styling/set-box-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash-expected.txt.
- fast/regions/region-styling/set-box-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash.html.
- fast/regions/region-styling/webkit-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/webkit-region-rule-expected.txt.
- fast/regions/region-styling/webkit-region-rule.html: Renamed from LayoutTests/fast/regions/webkit-region-rule.html.
- 11:20 AM Changeset in webkit [157050] by
-
- 17 edits in trunk/Source/JavaScriptCore
Transition stack check JITStubs to CCallHelper functions
https://bugs.webkit.org/show_bug.cgi?id=122289
Reviewed by Filip Pizlo.
Replaced jit stubs cti_stack_check, cti_op_call_arityCheck and cti_op_construct_arityCheck with
jit operations operationStackCheck, operationCallArityCheck & operationConstructArityCheck.
Added new callOperationWithCallFrameRollbackOnException() in baseline and DFG JITs to call
these new functions. Added code to unwind one frame in JIT::privateCompileExceptionHandlers()
and JITCompiler::compileExceptionHandlers() for these cases that need to throw exceptions in
their caller frame when the stack is exhausted.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::andPtr): Added to handle masking a pointer with a literal.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::and64): Added to handle masking a pointer with a literal.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::exceptionCheckWithCallFrameRollback):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperationWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnExceptionSetResult):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- interpreter/CallFrame.h:
(JSC::ExecState::hostCallFrameFlag):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::jitAssertIsNull):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::jitAssertIsNull):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JIT.h:
(JSC::JIT::exceptionCheckWithCallFrameRollback):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithCallFrameRollbackOnException):
(JSC::JIT::callOperationWithCallFrameRollbackOnException):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 11:07 AM Changeset in webkit [157049] by
-
- 3 edits in trunk/Source/WTF
Remove passIn and passOut from HashTraits
https://bugs.webkit.org/show_bug.cgi?id=122452
Reviewed by Sam Weinig.
Change RefPtrHashMap to not use passOut (just like the regular HashMap) and get rid of the
passIn and passOut functions and related typedefs.
- wtf/HashTraits.h:
- wtf/RefPtrHashMap.h:
- 10:45 AM Changeset in webkit [157048] by
-
- 3 edits in trunk/Source/WebCore
Conditional support in bindings code generator for overloaded functions
https://bugs.webkit.org/show_bug.cgi?id=122443
Patch by Philippe Normand <pnormand@igalia.com> on 2013-10-07
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateOverloadedFunction): Generate conditional for overloaded
function, if it's present in the idl.
(GenerateImplementation): Close the last overloaded function
conditional before generating the distpatch function.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
Rebaseline overloaded function tests.
- 10:42 AM Changeset in webkit [157047] by
-
- 4 edits in trunk
ASSERTION FAILED: isUInt32() in jsc-layout-tests.yaml/js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122419
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
AI was using JSValue::asUInt32() incorrectly. That method presumes that the input is
both a int32 and a uint32 (it's in the range [0, 231)). The UInt32ToNumber node is
instead dealing with an input that is always represented as a int32 but that has the
meaning of a uint32 - so AI should use JSValue::asInt32() and then do the cast.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
LayoutTests:
Reviewed by Oliver Hunt.
- js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:
- 9:59 AM Changeset in webkit [157046] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Jump over maxJumpReplacementSize in revertJumpToMove.
https://bugs.webkit.org/show_bug.cgi?id=120007
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-07
Reviewed by Oliver Hunt.
Jump over maxJumpReplacementSize in revertJumpToMove, even if there is no constant
value within the area. This patch fixes debug ASSERTs failures for sh4 architecture.
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::revertJumpToMove):
- 9:48 AM Changeset in webkit [157045] by
-
- 3 edits2 adds in trunk
-webkit-cross-fade paints SVGs at full opacity during cross-fade
https://bugs.webkit.org/show_bug.cgi?id=122441
<rdar://problem/13973162>
Reviewed by Simon Fraser.
Test: css3/images/cross-fade-svg-with-opacity.html
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
Factor the image painting out into a function.
Conditionally use a transparency layer around painting if the image
we're drawing is an SVG (SVGImage is the only Image subclass that will
not respect the context's opacity).
Add a test that ensures that -cross-fade with SVG images draws correctly.
- css3/images/cross-fade-svg-with-opacity-expected.html: Added.
- css3/images/cross-fade-svg-with-opacity.html: Added.
- 9:26 AM Changeset in webkit [157044] by
-
- 251 edits in trunk/Source
Add OVERRIDE and virtual where appropriate
https://bugs.webkit.org/show_bug.cgi?id=122439
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
- API/JSAPIWrapperObject.mm:
- API/JSCallbackObject.h:
(JSC::JSCallbackObjectData::~JSCallbackObjectData):
- API/JSManagedValue.mm:
- API/JSScriptRef.cpp:
(OpaqueJSScript::~OpaqueJSScript):
- bytecode/CodeBlock.h:
- bytecode/StructureStubClearingWatchpoint.h:
- dfg/DFGArrayifySlowPathGenerator.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
- dfg/DFGFailedFinalizer.h:
- dfg/DFGJITCode.h:
- dfg/DFGJITFinalizer.h:
- dfg/DFGSaneStringGetByValSlowPathGenerator.h:
- dfg/DFGSlowPathGenerator.h:
- dfg/DFGSpeculativeJIT64.cpp:
- heap/Heap.h:
- heap/IncrementalSweeper.h:
- heap/SuperRegion.h:
- jit/ClosureCallStubRoutine.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
- jit/GCAwareJITStubRoutine.h:
- jit/JITCode.h:
- jit/JITStubs.cpp:
- jit/JITToDFGDeferredCompilationCallback.h:
- jit/JumpReplacementWatchpoint.h:
- parser/Nodes.h:
- runtime/DataView.h:
- runtime/GCActivityCallback.h:
- runtime/GenericTypedArrayView.h:
- runtime/RegExpCache.h:
- runtime/SimpleTypedArrayController.h:
- runtime/WeakMapData.h:
Source/WebCore:
- Modules/encryptedmedia/MediaKeys.h:
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AudioBasicInspectorNode.h:
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioProcessingEvent.h:
- Modules/webaudio/BiquadDSPKernel.h:
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/ChannelMergerNode.h:
- Modules/webaudio/ChannelSplitterNode.h:
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/DelayDSPKernel.h:
- Modules/webaudio/DelayProcessor.h:
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/GainNode.h:
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/OfflineAudioCompletionEvent.h:
- Modules/webaudio/OfflineAudioDestinationNode.h:
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webaudio/WaveShaperProcessor.h:
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityListBox.h:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityMediaControls.h:
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMenuListOption.h:
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityMockObject.h:
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityProgressIndicator.h:
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilitySVGRoot.h:
- accessibility/AccessibilityScrollView.h:
- accessibility/AccessibilityScrollbar.h:
- accessibility/AccessibilitySlider.h:
- accessibility/AccessibilitySpinButton.h:
- accessibility/AccessibilityTable.h:
- accessibility/AccessibilityTableCell.h:
- accessibility/AccessibilityTableColumn.h:
- accessibility/AccessibilityTableHeaderContainer.h:
- accessibility/AccessibilityTableRow.h:
- bindings/js/JSEventListener.h:
- bindings/js/WebCoreTypedArrayController.h:
- bridge/c/c_class.h:
- bridge/c/c_instance.h:
- bridge/c/c_runtime.h:
- bridge/runtime_root.h:
- css/CSSBasicShapes.h:
- css/CSSComputedStyleDeclaration.h:
- css/CSSStyleSheet.h:
- dom/Attr.h:
- dom/BeforeTextInsertedEvent.h:
- dom/CDATASection.h:
- dom/ChildNodeList.h:
- dom/DatasetDOMStringMap.h:
- dom/Document.h:
- dom/DocumentEventQueue.h:
- dom/DocumentFragment.h:
- dom/Element.h:
- dom/ErrorEvent.h:
- dom/KeyboardEvent.h:
- dom/Node.h:
- dom/PageTransitionEvent.h:
- dom/ProgressEvent.h:
- dom/PseudoElement.h:
- dom/ScriptExecutionContext.h:
- dom/ShadowRoot.h:
- dom/StyledElement.h:
- dom/TagNodeList.h:
- dom/Text.h:
- dom/TextEvent.h:
- dom/TransitionEvent.h:
- dom/UIEvent.h:
- dom/WebKitAnimationEvent.h:
- dom/WebKitTransitionEvent.h:
- editing/ApplyBlockElementCommand.h:
- editing/ApplyStyleCommand.h:
- editing/BreakBlockquoteCommand.h:
- editing/CompositeEditCommand.h:
- editing/SpellingCorrectionCommand.h:
- fileapi/File.h:
- fileapi/FileThreadTask.h:
- history/BackForwardList.h:
- html/BaseCheckableInputType.h:
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLCanvasElement.h:
- html/HTMLCollection.h:
- html/HTMLElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFormControlElementWithState.h:
- html/HTMLFormElement.h:
- html/HTMLFrameElementBase.h:
- html/HTMLImageElement.h:
- html/HTMLImageLoader.h:
- html/HTMLInputElement.h:
- html/HTMLLabelElement.h:
- html/HTMLLegendElement.h:
- html/HTMLMediaElement.h:
- html/HTMLMeterElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLPlugInImageElement.h:
- html/HTMLProgressElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTableElement.h:
- html/HTMLTextAreaElement.h:
- html/HTMLTextFormControlElement.h:
- html/HTMLVideoElement.h:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControlElements.h:
- html/shadow/SpinButtonElement.h:
- html/shadow/TextControlInnerElements.h:
- html/track/AudioTrackList.h:
- html/track/TextTrackList.h:
- html/track/TrackListBase.h:
- inspector/InspectorValues.h:
- loader/EmptyClients.h:
- loader/ImageLoader.h:
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/DOMApplicationCache.h:
- loader/archive/cf/LegacyWebArchive.h:
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h:
- loader/cache/CachedImageClient.h:
- loader/cache/CachedSVGDocumentClient.h:
- loader/cache/CachedStyleSheetClient.h:
- loader/cache/CachedXSLStyleSheet.h:
- page/Chrome.h:
- page/DOMWindow.h:
- page/FrameView.h:
- page/animation/ImplicitAnimation.h:
- platform/PODIntervalTree.h:
- platform/PODRedBlackTree.h:
- platform/ScrollView.h:
- platform/Scrollbar.h:
- platform/Timer.h:
- platform/animation/TimingFunction.h:
(WebCore::LinearTimingFunction::~LinearTimingFunction):
(WebCore::CubicBezierTimingFunction::~CubicBezierTimingFunction):
(WebCore::StepsTimingFunction::~StepsTimingFunction):
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/HRTFPanner.h:
- platform/audio/mac/AudioDestinationMac.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/filters/FilterOperation.h:
- platform/network/ResourceHandle.h:
- rendering/AutoTableLayout.h:
- rendering/ClipPathOperation.h:
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.h:
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderButton.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.h:
- rendering/RenderImage.h:
- rendering/RenderLayer.h:
- rendering/RenderLineBreak.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMenuList.h:
- rendering/RenderMeter.h:
- rendering/RenderObject.h:
- rendering/RenderReplaced.h:
- rendering/RenderSlider.h:
- rendering/RenderTable.h:
- rendering/RenderTableCell.h:
- rendering/RenderText.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderTextFragment.h:
- rendering/RenderView.h:
- rendering/RootInlineBox.h:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/style/BasicShapes.h:
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGShape.h:
- svg/SVGAnimatedBoolean.h:
- svg/SVGAnimatedString.h:
- svg/SVGAnimatedTransformList.h:
- svg/SVGDocument.h:
- svg/SVGElement.h:
- svg/SVGElementInstance.h:
- svg/SVGFontElement.h:
- svg/SVGGElement.h:
- svg/SVGGraphicsElement.h:
- svg/SVGTransformable.h:
- svg/properties/SVGAnimatedListPropertyTearOff.h:
- svg/properties/SVGAnimatedPropertyMacros.h:
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
- svg/properties/SVGListPropertyTearOff.h:
- svg/properties/SVGPropertyTearOff.h:
- workers/WorkerGlobalScope.h:
Source/WTF:
- wtf/Compiler.h:
- wtf/FilePrintStream.h:
- wtf/StringPrintStream.h:
- 8:50 AM Changeset in webkit [157043] by
-
- 4 edits in trunk
Trap 5 (most likely int $3) in jsc-layout-tests.yaml/js/script-tests/integer-division-neg2tothe32-by-neg1.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122420
Source/JavaScriptCore:
Reviewed by Michael Saboff.
For the (-231/-1)|0 case, we were returning the left operand (i.e. -231) but we were
failing to account for the possibility that this operand has high-bit garbage and
int32Result() requires that the high bits are zero.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv):
LayoutTests:
Reviewed by Michael Saboff.
- js/script-tests/integer-division-neg2tothe32-by-neg1.js:
- 8:47 AM Changeset in webkit [157042] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] UserMediaClientGtk needs API update
https://bugs.webkit.org/show_bug.cgi?id=122324
Reviewed by Martin Robinson.
Update UserMediaClientGtk API after changes made in the parent
class in r156473.
- WebCoreSupport/UserMediaClientGtk.cpp:
(WebKit::UserMediaClientGtk::requestPermission):
(WebKit::UserMediaClientGtk::cancelRequest):
- WebCoreSupport/UserMediaClientGtk.h:
- 8:32 AM Changeset in webkit [157041] by
-
- 3 edits in trunk/Source/WebCore
URLMediaStream is unguarded by ENABLE(MEDIA_STREAM)
https://bugs.webkit.org/show_bug.cgi?id=122444
Reviewed by Martin Robinson.
- Modules/mediastream/URLMediaStream.cpp: Added missing
conditional guards.
- Modules/mediastream/URLMediaStream.h: Ditto.
- 8:29 AM Changeset in webkit [157040] by
-
- 4 edits in trunk/Source/WebCore
[GTK] webkit_dom_html_style_element_{s,g}et_scoped was removed
https://bugs.webkit.org/show_bug.cgi?id=122446
Reviewed by Martin Robinson.
Added skeleton functions warning of removed functionality for
the <style scoped> GObject DOM binding.
- bindings/gobject/WebKitDOMCustom.cpp:
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols:
- 8:24 AM Changeset in webkit [157039] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed buildfix for GCC 4.6.
Changed override to OVERRIDE and final to FINAL.
- page/PageSerializer.cpp:
- workers/AbstractWorker.h:
- workers/SharedWorker.h:
- workers/Worker.h:
- 8:10 AM Changeset in webkit [157038] by
-
- 3 edits2 adds in trunk
AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.
https://bugs.webkit.org/show_bug.cgi?id=122252
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When an author uses a control-type ARIA role (like button), but then hides a native control-type inside,
AXPress needs to operate on the inside node if possible.
Test: accessibility/axpress-on-aria-button.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::isNodeActionElement):
(WebCore::nativeActionElement):
(WebCore::AccessibilityNodeObject::actionElement):
LayoutTests:
- accessibility/axpress-on-aria-button-expected.txt: Added.
- accessibility/axpress-on-aria-button.html: Added.
- 7:51 AM Changeset in webkit [157037] by
-
- 2 edits in trunk/Tools
[GTK] Fails to build with jhbuild with newer system glib
https://bugs.webkit.org/show_bug.cgi?id=122132
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.
Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
started relying on. glib is not a dependency that should change test results, and is provided in
jhbuild with the intention of supporting the other bits that do, so using a newer stable release
should not be an issue.
- gtk/jhbuild.modules:
- 7:44 AM Changeset in webkit [157036] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
https://bugs.webkit.org/show_bug.cgi?id=122437
Reviewed by Antoine Quint.
- Scripts/run-jsc-stress-tests:
- 7:36 AM Changeset in webkit [157035] by
-
- 12 edits in trunk
ASSERTION FAILED: bitwise_cast<WriteBarrier<Unknown>*>(callFrame) == m_registers in jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-capture-throw-exception.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122418
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This is pretty awesome. With stack compression, Arguments created in the DFG will point
their m_registers pointers into a different slab of stack than they would have in byte
code.
Hence OSR exit must repoint any Arguments objects' m_registers pointers. It previously
neglected to do so. This patch fixes that.
Fixing this unveiled another bug: the stack reversal broke the reification of inlined
phantom arguments.
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Arguments.h:
(JSC::Arguments::offsetOfNumArguments):
(JSC::Arguments::offsetOfRegisters):
(JSC::Arguments::offsetOfSlowArgumentData):
(JSC::Arguments::offsetOfOverrodeLength):
LayoutTests:
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
- js/script-tests/dfg-arguments-osr-exit.js:
- js/script-tests/dfg-inline-arguments-capture-throw-exception.js:
- 4:37 AM Changeset in webkit [157034] by
-
- 2 edits in trunk/LayoutTests
context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901.
https://bugs.webkit.org/show_bug.cgi?id=122414
Unreviewed gardening.
- platform/mac/TestExpectations:
Similarly to r156990, mark context-menu-suggestions-subword-selection.html as flaky.
Change-Id: I787b1d5a5a328f747799434fd7b984eec6947cd1
- 2:01 AM Changeset in webkit [157033] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed debug build fix for ports enabling the <template> element support.
- html/HTMLTagNames.in: Generate type helpers for the <template> element as they're required
by the assertions in the Element type casts for HTMLTemplateElement.
- 1:26 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:48 AM Changeset in webkit [157032] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Build fix after r157002
https://bugs.webkit.org/show_bug.cgi?id=122434
Reviewed by Sam Weinig.
- editing/markup.cpp: Changed override to OVERRIDE.
- 12:29 AM Changeset in webkit [157031] by
-
- 9 edits in releases/WebKitGTK/webkit-2.2/Source
Merge r156345 - [GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
https://bugs.webkit.org/show_bug.cgi?id=121782
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-09-24
Reviewed by Martin Robinson.
Disabled drag functions.
Source/WebCore:
- page/gtk/EventHandlerGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DragClientGtk.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
- 12:29 AM Changeset in webkit [157030] by
-
- 4 edits in trunk/Source/WebCore
MediaStreamTrack can't be FINAL
https://bugs.webkit.org/show_bug.cgi?id=122322
Reviewed by Darin Adler.
Marked the MediaStreamTrack subclasses as final.
- Modules/mediastream/AudioStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/VideoStreamTrack.h:
- 12:27 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:25 AM Changeset in webkit [157029] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r156287 - [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600
Reviewed by Gustavo Noronha Silva.
Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):
- 12:24 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:02 AM Changeset in webkit [157028] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r156003 - DFG doesn't properly keep scope alive for op_put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=121519
Reviewed by Michael Saboff.
This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- 12:01 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:01 AM Changeset in webkit [157027] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r155495 - WebKit crashes when trying to send a msg via 'today's birthdays' dialogue box on Facebook
https://bugs.webkit.org/show_bug.cgi?id=120612#add_comment
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-09-10
Reviewed by Geoffrey Garen.
The codeBlock was assumed to exist when appendSourceToMessage was set.
This was an invalid assumption. I added a check to ensure that there is a
valid codeBlock before accessing it.
- API/tests/testapi.c:
(valueToObjectExceptionCallAsFunction):
(valueToObjectExceptionTest):
(main):
- runtime/VM.cpp:
(JSC::VM::throwException):
- 12:00 AM Changeset in webkit [157026] by
-
- 35 edits4 copies2 deletes in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r154824 - CodeBlock compilation and installation should be simplified and rationalized
https://bugs.webkit.org/show_bug.cgi?id=120326
Reviewed by Oliver Hunt.
Rolling r154804 back in after fixing no-LLInt build.
Previously Executable owned the code for generating JIT code; you always had
to go through Executable. But often you also had to go through CodeBlock,
because ScriptExecutable couldn't have virtual methods, but CodeBlock could.
So you'd ask CodeBlock to do something, which would dispatch through a
virtual method that would select the appropriate Executable subtype's method.
This all meant that the same code would often be duplicated, because most of
the work needed to compile something was identical regardless of code type.
But then we tried to fix this, by having templatized helpers in
ExecutionHarness.h and JITDriver.h. The result was that if you wanted to find
out what happened when you asked for something to be compiled, you'd go on a
wild ride that started with CodeBlock, touched upon Executable, and then
ricocheted into either ExecutionHarness or JITDriver (likely both).
Another awkwardness was that for concurrent compiles, the DFG::Worklist had
super-special inside knowledge of what JITStubs.cpp's cti_optimize would have
done once the compilation finished.
Also, most of the DFG JIT drivers assumed that they couldn't install the
JITCode into the CodeBlock directly - instead they would return it via a
reference, which happened to be a reference to the JITCode pointer in
Executable. This was super weird.
Finally, there was no notion of compiling code into a special CodeBlock that
wasn't used for handling calls into an Executable. I'd like this for FTL OSR
entry.
This patch solves these problems by reducing all of that complexity into just
three primitives:
- Executable::newCodeBlock(). This gives you a new code block, either for call or for construct, and either to serve as the baseline code or the optimized code. The new code block is then owned by the caller; Executable doesn't register it anywhere. The new code block has no JITCode and isn't callable, but it has all of the bytecode.
- CodeBlock::prepareForExecution(). This takes the CodeBlock's bytecode and produces a JITCode, and then installs the JITCode into the CodeBlock. This method takes a JITType, and always compiles with that JIT. If you ask for JITCode::InterpreterThunk then you'll get JITCode that just points to the LLInt entrypoints. Once this returns, it is possible to call into the CodeBlock if you do so manually - but the Executable still won't know about it so JS calls to that Executable will still be routed to whatever CodeBlock is associated with the Executable.
- Executable::installCode(). This takes a CodeBlock and makes it the code-for- entry for that Executable. This involves unlinking the Executable's last CodeBlock, if there was one. This also tells the GC about any effect on memory usage and does a bunch of weird data structure rewiring, since Executable caches some of CodeBlock's fields for the benefit of virtual call fast paths.
This functionality is then wrapped around three convenience methods:
- Executable::prepareForExecution(). If there is no code block for that Executable, then one is created (newCodeBlock()), compiled (CodeBlock::prepareForExecution()) and installed (installCode()).
- CodeBlock::newReplacement(). Asks the Executable for a new CodeBlock that can serve as an optimized replacement of the current one.
- CodeBlock::install(). Asks the Executable to install this code block.
This patch allows me to kill *a lot* of code and to remove a lot of
specializations for functions vs. not-functions, and a lot of places where we
pass around JITCode references and such. ExecutionHarness and JITDriver are
both gone. Overall this patch has more red than green.
It also allows me to work on FTL OSR entry and tier-up:
- FTL tier-up: this will involve DFGOperations.cpp asking the DFG::Worklist to do some compilation, but it will require the DFG::Worklist to do something different than what JITStubs.cpp would want, once the compilation finishes. This patch introduces a callback mechanism for that purpose.
- FTL OSR entry: this will involve creating a special auto-jettisoned CodeBlock that is used only for FTL OSR entry. The new set of primitives allows for this: Executable can vend you a fresh new CodeBlock, and you can ask that CodeBlock to compile itself with any JIT of your choosing. Or you can take that CodeBlock and compile it yourself. Previously the act of producing a CodeBlock-for-optimization and the act of compiling code for it were tightly coupled; now you can separate them and you can create such auto-jettisoned CodeBlocks that are used for a one-shot OSR entry.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::prepareForExecutionImpl):
(JSC::CodeBlock::prepareForExecution):
(JSC::CodeBlock::prepareForExecutionAsynchronously):
(JSC::CodeBlock::install):
(JSC::CodeBlock::newReplacement):
(JSC::FunctionCodeBlock::jettisonImpl):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::hasBaselineJITProfiling):
- bytecode/DeferredCompilationCallback.cpp: Added.
(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
- bytecode/DeferredCompilationCallback.h: Added.
- dfg/DFGDriver.cpp:
(JSC::DFG::tryCompile):
- dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
- dfg/DFGFailedFinalizer.cpp:
(JSC::DFG::FailedFinalizer::finalize):
(JSC::DFG::FailedFinalizer::finalizeFunction):
- dfg/DFGFailedFinalizer.h:
- dfg/DFGFinalizer.h:
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
- dfg/DFGJITFinalizer.h:
- dfg/DFGOSRExitPreparation.cpp:
(JSC::DFG::prepareCodeOriginForOSRExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
- dfg/DFGPlan.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::runThread):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- heap/Heap.h:
(JSC::Heap::isDeferred):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- jit/JITDriver.h: Removed.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
- jit/JITToDFGDeferredCompilationCallback.cpp: Added.
(JSC::JITToDFGDeferredCompilationCallback::JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::~JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
- jit/JITToDFGDeferredCompilationCallback.h: Added.
- llint/LLIntEntrypoints.cpp:
(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
- llint/LLIntEntrypoints.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::setUpCall):
- runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
- runtime/CommonSlowPaths.cpp:
- runtime/CompilationResult.cpp:
(WTF::printInternal):
- runtime/CompilationResult.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::installCode):
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):
- runtime/Executable.h:
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor):
(JSC::ExecutableBase::offsetOfNumParametersFor):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):
- runtime/ExecutionHarness.h: Removed.
