⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 11, 2013:

11:03 PM Changeset in webkit [157332] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

Move firstPositiveWidth/adjustLogicalLineTop functions where they're actually used
​https://bugs.webkit.org/show_bug.cgi?id=122685

Reviewed by Darin Adler.

I'm working on the refactoring of RenderBlockLineLayout, progress tracked under bug #121261. For the better readability, I moved
firstPositiveWidth and adjustLogicalLineTop functions above pushShapeContentOverflowBelowTheContentBox, where these're actually used.

No new tests, no behavior change.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::firstPositiveWidth):
(WebCore::adjustLogicalLineTop):

9:52 PM Changeset in webkit [157331] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Extract an iterator/resolver class from calculateAdjustedNodes
​https://bugs.webkit.org/show_bug.cgi?id=122687

Reviewed by Darin Adler.

Extracted EventRelatedNodeResolver out of calculateAdjustedNodes and replaced calls to calculateAdjustedNodes
in updateTouchListsInEventPath and setRelatedTarget by the use of this newly added class.

  • dom/EventContext.h: Added some helper functions to TouchEventContext so that updateTouchListsInEventPath

could obtain respective TouchList* without having to hard-code the name.

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedNodeResolver::EventRelatedNodeResolver): Added.
(WebCore::EventRelatedNodeResolver::moveToParentOrShadowHost): Extracted from calculateAdjustedNodes.
(WebCore::EventPath::updateTouchListsInEventPath): Updated to use EventRelatedNodeResolver. Also made this
a member function of EventPath.
(WebCore::EventPath::updateTouchLists): Removed local Vectors to TouchList now that updateTouchListsInEventPath
can obtain TouchList* on demand.
(WebCore::EventPath::setRelatedTarget): Upsed to use EventRelatedNodeResolver.

9:16 PM Changeset in webkit [157330] by Darin Adler
  • 53 edits in trunk/Source

Change most call sites to call ICU directly instead of through WTF::Unicode
​https://bugs.webkit.org/show_bug.cgi?id=122635

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::isNonLatin1IdentStart): Take a UChar since that's what the only caller wants to pass.
Use U_GET_GC_MASK instead of WTF::Unicode::category.
(JSC::isNonLatin1IdentPart): Ditto.

  • parser/Lexer.h:

(JSC::Lexer::isWhiteSpace): Use u_charType instead of WTF::Unicode::isSeparatorSpace.

  • runtime/JSFunction.cpp: Removed "using namespace" for WTF::Unicode, this will no longer

compile since this doesn't include anything that defines that namespace.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::isStrWhiteSpace): Use u_charType instead of WTF::Unicode::isSeparatorSpace.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::atomPatternCharacter): Use u_tolower and u_toupper instead of
Unicode::toLower and Unicode::toUpper. Also added some assertions since this code assumes
it can convert any UChar to lowercase or uppercase in another UChar, with no risk of needing
a UChar32 for the result. I guess that's probably true, but it would be good to know in a
debug build if not.

Source/WebCore:

  • Modules/indexeddb/IDBKeyPath.cpp:

(isIdentifierStartCharacter): Use U_GET_GC_MASK instead of WTF::Unicode::category.
(isIdentifierCharacter): Ditto.

  • css/CSSParser.cpp:

(WebCore::makeLower): Use u_tolower instead of WTF::Unicode::toLower.
Also assert the character fits in a UChar.

  • dom/Document.cpp:

(WebCore::isValidNameStart): Use U_GET_GC_MASK instead of WTF::Unicode::category,
and u_getIntPropertyValue instead of WTF::Unicode::decompositionType.
(WebCore::isValidNamePart): Ditto.
(WebCore::canonicalizedTitle): Ditto.

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent): Use u_isPunct instead of
WTF::Unicode::isPunct.

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::append): Use u_strFoldCase instead of WTF::Unicode::foldCase.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality): Use UCharDirection instead of
WTF::Unicode::Direction.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::defaultEventHandler): Use u_isprint instead of
WTF::Unicode::isPrintableChar.

  • html/TypeAhead.cpp:

(WebCore::stripLeadingWhiteSpace): Use u_charDirection instead of
WTF::Unicode::direction.

  • html/track/TextTrackCue.cpp:

(WebCore::isCueParagraphSeparator): Use u_charType instead of
WTF::Unicode::category.
(WebCore::TextTrackCue::determineTextDirection): Use u_charDirection instead of
WTF::Unicode::direction.

  • page/ContextMenuController.cpp:

(WebCore::selectionContainsPossibleWord): Use U_GET_GC_MASK instead of
WTF::Unicode::category.

  • platform/graphics/Font.cpp:

(WebCore::Font::canReceiveTextEmphasis): Ditto.

  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::glyphDataAndPageForCharacter): Use u_toupper instead of
WTF::Unicode::toUpper. Use u_charMirror instead of WTF::Unicode::mirroredChar.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::TextRunIterator::direction): Use u_charDirection instead of
WTF::Unicode::direction.

  • platform/graphics/SVGGlyph.cpp:

(WebCore::charactersWithArabicForm): Use ublock_getCode instead of
WTF::Unicode::isArabicChar.

  • platform/graphics/SurrogatePairAwareTextIterator.cpp:

(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks): Use
u_getCombiningClass instead of WTF::Unicode::combiningClass.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal): Use u_toupper instead of
WTF::Unicode::toUpper.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::collectComplexTextRuns): Added some
assertions about the user of u_toupper and tweaked coding style a bit.

  • platform/text/BidiContext.cpp:

(WebCore::BidiContext::createUncached): Use UCharDirection instead of
WTF::Unicode::Direction.
(WebCore::BidiContext::create): Ditto.
(WebCore::copyContextAndRebaselineLevel): Ditto.

  • platform/text/BidiContext.h:

(WebCore::BidiContext::dir): Ditto.
(WebCore::BidiContext::BidiContext): Ditto.

  • platform/text/BidiResolver.h:

(WebCore::BidiStatus::BidiStatus): Ditto.
(WebCore::BidiEmbedding::BidiEmbedding): Ditto.
(WebCore::BidiEmbedding::direction): Ditto.
(WebCore::BidiCharacterRun::BidiCharacterRun): Ditto.
(WebCore::BidiResolver::BidiResolver): Ditto.
(WebCore::BidiResolver::setLastDir): Ditto.
(WebCore::BidiResolver::setLastStrongDir): Ditto.
(WebCore::BidiResolver::setEorDir): Ditto.
(WebCore::BidiResolver::dir): Ditto.
(WebCore::BidiResolver::setDir): Ditto.
(WebCore::BidiResolver::appendRun): Ditto.
(WebCore::BidiResolver::embed): Ditto.
(WebCore::BidiResolver::checkDirectionInLowerRaiseEmbeddingLevel): Ditto.
(WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Ditto.
(WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Ditto.
(WebCore::BidiResolver::commitExplicitEmbedding): Ditto.
(WebCore::BidiResolver::updateStatusLastFromCurrentDirection): Ditto.
(WebCore::BidiResolver::createBidiRunsForLine): Ditto.

  • platform/text/SegmentedString.h:

(WebCore::SegmentedString::advanceAndASSERTIgnoringCase): Use u_foldCase
instead of WTF::Unicode::foldCase.

  • platform/text/TextBoundaries.cpp:

(WebCore::findNextWordFromIndex): Use u_isalnum instead of
WTF::Unicode::isAlphanumeric.

  • platform/text/TextBoundaries.h:

(WebCore::requiresContextForWordBoundary): Use u_getIntPropertyValue directly
instead of WTF::Unicode::requiresComplexContextForWordBreaking.

  • platform/text/mac/TextBoundaries.mm: Removed explicit use of WTF::Unicode,

which was unneeded and also will no longer compile.

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): Use UCharDirection instead of WTF::Unicode::Direction.

  • rendering/InlineFlowBox.h: Ditto.
  • rendering/InlineIterator.h:

(WebCore::embedCharFromDirection): Ditto.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::InlineIterator::direction): Ditto.
(WebCore::IsolateTracker::embed): Ditto.
(WebCore::InlineBidiResolver::appendRun): Ditto.

  • rendering/RenderBlock.cpp:

(WebCore::isPunctuationForFirstLetter): Use U_GET_GC_MASK instead of
WTF::Unicode::category.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::determineDirectionality): Use u_charDirection instead of
WTF::Unicode::direction.
(WebCore::RenderBlockFlow::handleTrailingSpaces): Ditto.
(WebCore::statusWithDirection): Ditto.
(WebCore::LineBreaker::nextSegmentBreak): Use U_GET_GC_MASK instead of
WTF::Unicode::category.

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint): Use u_charDirection instead of
WTF::Unicode::direction.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle): Use UCharDirection instead of
WTF::Unicode::Direction.

  • rendering/RenderText.cpp:

(WebCore::makeCapitalized): Use u_totile instead of WTF::Unicode::toTitleCase.
Also added a comment about the fact that we need to use u_strToTitle instead.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineBreakBidiStatus): Use UCharDirection instead of
WTF::Unicode::Direction.

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::createStringWithMirroredCharacters): Use u_charMirror
instead of WTF::Unicode::mirroredChar.

  • xml/XPathParser.cpp:

(WebCore::XPath::charCat): Use U_GET_GC_MASK instead of WTF::Unicode::category.

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::isOneLeftToRightRun):
More of the same for Windows.

Source/WTF:

  • wtf/text/StringHash.h:

(WTF::CaseFoldingHash::foldCase): Use u_foldCase instead of WTF::Unicode::foldCase.
(WTF::CaseFoldingHash::hash): Added an overload for a StringImpl& because why not.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::lower): Use u_tolower rather than WTF::Unicode::toLower. Also added
an assertion to check that the lowercase version is also part of Latin-1. If this
is not guaranteed it would be good to know in a debug build at least. Use u_strToLower
rather than WTF::Unicode::toLower. Also removed #if USE(ICU_UNICODE) around the
locale-specific version.
(WTF::StringImpl::upper): Use u_toupper and u_strToUpper, as above.
(WTF::StringImpl::foldCase): Use u_tolower and u_strFoldCase, as above.
(WTF::equalIgnoringCase): Use u_foldCase instead of WTF::Unicode::foldCase.
(WTF::StringImpl::defaultWritingDirection): Use u_charDirection and UCharDirection
instead of WTF::Unicode::direction and WTF::Unicode::Direction.

  • wtf/text/StringImpl.h:

(WTF::equalIgnoringCase): Use u_memcasecmp instead of WTF::Unicode::umemcasecmp.
(WTF::isSpaceOrNewline): Use u_charDirection instead of WTF::Unicode::direction.

  • wtf/text/WTFString.h:

(WTF::String::defaultWritingDirection): Use UCharDirection instead of WTF::Unicode::Direction.

  • wtf/unicode/icu/UnicodeIcu.h: Removed almost everything.
  • wtf/unicode/wchar/UnicodeWchar.cpp: Tried to do the right thing in this file, but

I did not actually compile it. Also, the implementations here aren't really sufficient
to make WebKit work broadly. There are many things that just aren't working with this
implementation, such as parsing that uses u_charType to figure out which characters are valid.
(unorm_normalize): Added.
(u_charDirection): Added.
(u_charMirror): Added.
(u_charType): Added.
(u_getCombiningClass): Added.
(u_getIntPropertyValue): Added.
(u_memcasecmp): Added.
(convertWithFunction): Changed to work with ICU-style status code instead of error bool.
(u_strFoldCase): Added.
(u_strToLower): Added.
(u_strToUpper): Added.

  • wtf/unicode/wchar/UnicodeWchar.h: Ditto. Later this file should just be named like the

real ICU headers so the code can include it the same way it would ICU. But that will be
in a future patch.

7:21 PM Changeset in webkit [157329] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

DFG: Add JIT support for LogicalNot(String/StringIdent)
​https://bugs.webkit.org/show_bug.cgi?id=122627

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-11
Reviewed by Filip Pizlo.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStringZeroLength):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):

7:05 PM Changeset in webkit [157328] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Dramatically simplify calculateAdjustedNodes
​https://bugs.webkit.org/show_bug.cgi?id=122680

Reviewed by Antti Koivisto.

Without insertion points, we never have to worry about entering a shadow DOM we've already climbed out of.
Deleted the logic to deal with insertion points in calculateAdjustedNodes accordingly.

  • dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):
(WebCore::calculateAdjustedNodes):
(WebCore::updateTouchListsInEventPath):
(WebCore::EventPath::updateTouchLists):
(WebCore::EventPath::setRelatedTarget):

6:35 PM Changeset in webkit [157327] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

sunspider-1.0/math-spectral-norm.js.dfg-eager occasionally fails with Trap 5 (i.e int $3)
​https://bugs.webkit.org/show_bug.cgi?id=122462

Reviewed by Mark Hahnenberg.

This fixes two bugs, both of which led to GetByVal on Int32 trapping because the
array no longer had Int32 shape but the check wasn't executed:

1) We weren't snapshotting the structures of mustHandleValues. This led to an awesome

race where if a mustHandleValue JSValue's structure changed on the main thread
between runs of the AI, the AI would contradict each other and things would just
get corrupted in funny ways.


2) The constant folder has a long standing bug! It will fold a node to a constant if

the AI proved it to be a constant. But it's possible that the original node also
proved things about the constant's structure. In that case "folding" to a
JSConstant actually loses information since JSConstant doesn't guarantee anything
about a constant's structure. There are various things we could do here to ensure
that a folded constant's structure doesn't change, and that if it does, we
deoptimize the code. But for now we can just make this sound by disabling folding
in this pathological case.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

  • dfg/DFGGraph.h:
  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):

6:33 PM Changeset in webkit [157326] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fix handling of indirect stackmap locations in FTL OSR exit
​https://bugs.webkit.org/show_bug.cgi?id=122666

Reviewed by Mark Hahnenberg.

With this change, the llvm.webkit.stackmap-based OSR exit only fails one test, down from
five tests previously.

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::gpr): It's OK to call this method when kind() == Indirect, so asserting that isGPR() is wrong; change to assert that involvesGPR().
(JSC::FTL::Location::restoreInto): Stack-related registers aren't saved to the scratch buffer, so use them directly.

  • ftl/FTLLocation.h: Add comment about requirements for stack layout.
  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStubWithOSRExitStackmap): Make enough room on the stack so that saveAllRegisters() has a scratchpad to save things to. Without this, saveAllRegisters() may clobber a spilled value.

6:22 PM Changeset in webkit [157325] by ryuan.choi@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip tests that are already passing.

  • platform/efl-wk2/TestExpectations:
5:43 PM Changeset in webkit [157324] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Fix for fast/xpath test regressions caused by r157205.
​https://bugs.webkit.org/show_bug.cgi?id=122658.

Reviewed by Darin Adler.

  • xml/XPathStep.h:

(WebCore::XPath::Step::NodeTest::NodeTest):
(WebCore::XPath::Step::NodeTest::operator=):
We were incorrectly setting the predicate list to null instead of the predicate list of the NodeTest being passed in.

4:09 PM Changeset in webkit [157323] by timothy@apple.com
  • 13 edits in trunk

Remove preference support for picking the old Web Inspector.
​https://bugs.webkit.org/show_bug.cgi?id=122655

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::localizedStringsURL):
(-[WebInspectorWindowController inspectorPagePath]):

Source/WebKit2:

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector):

  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::WebInspector::localizedStringsURL):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange):

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

3:59 PM Changeset in webkit [157322] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Fix 64-bit build on everything but Windows.

Rubber stamped by Brent Fulgham.

  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):

3:45 PM Changeset in webkit [157321] by ap@apple.com
  • 2 edits in trunk/Tools

Touch a file to see how auto-update works.

Rubber-stamped by Tim Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3:12 PM Changeset in webkit [157320] by beidson@apple.com
  • 6 edits
    3 adds in trunk/Source/WebKit2

Lay the groundwork for a multi-process aware Indexed DB implementation in WebKit2.
​https://bugs.webkit.org/show_bug.cgi?id=122675

Reviewed by Alexey Proskuryakov.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/IndexedDB/WebIDBFactoryBackend.cpp: Added.

(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::~WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::getDatabaseNames):
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::deleteDatabase):

  • WebProcess/IndexedDB/WebIDBFactoryBackend.h: Added.

(WebKit::WebIDBFactoryBackend::create):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Return a WebIDBFactoryBackend.

2:14 PM Changeset in webkit [157319] by andersca@apple.com
  • 19 edits
    1 delete in trunk/Source/WebKit2

Remove ENABLE(GESTURE_EVENTS) from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=122673

Reviewed by Ryosuke Niwa.

  • Shared/WebEvent.h:
  • Shared/WebEventConversion.cpp:
  • Shared/WebEventConversion.h:
  • Shared/WebGestureEvent.cpp: Removed.
  • Shared/mac/WebEventFactory.h:
  • Shared/mac/WebEventFactory.mm:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/EventDispatcher.cpp:
  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/WebPage/EventDispatcher.messages.in:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
2:01 PM Changeset in webkit [157318] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shapes] Use the floatingObject's logical coordinates to determine its size in computeLogicalLocationForFloat
​https://bugs.webkit.org/show_bug.cgi?id=122663

Reviewed by David Hyatt.

Covered by existing float tests in fast/shapes/shape-inside.
I'll add additional tests in bug #122664.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):

12:18 PM Changeset in webkit [157317] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r157307.
​http://trac.webkit.org/changeset/157307
​https://bugs.webkit.org/show_bug.cgi?id=122671

Many assertion failures (Requested by ap on #webkit).

  • jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorPrototypeNext):

  • runtime/Intrinsic.h:
  • runtime/JSArrayIterator.cpp:

(JSC::JSArrayIterator::finishCreation):

  • runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

12:16 PM Changeset in webkit [157316] by andersca@apple.com
  • 17 edits
    3 deletes in trunk/Source

Remove gesture event support from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=122650

Reviewed by Ryosuke Niwa.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/GestureEvent.cpp: Removed.
  • dom/GestureEvent.h: Removed.
  • dom/Node.cpp:
  • dom/Node.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::sendContextMenuEventForKey):

  • page/EventHandler.h:
  • platform/PlatformGestureEvent.h: Removed.
  • platform/Scrollbar.cpp:
  • platform/Scrollbar.h:
  • platform/mac/PlatformEventFactoryMac.h:
  • platform/mac/PlatformEventFactoryMac.mm:

Source/WTF:

  • wtf/FeatureDefines.h:
  • wtf/nix/FeatureDefinesNix.h:
12:15 PM Changeset in webkit [157315] by Gustavo Noronha Silva
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Rebaseline after 157292.

  • platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
  • platform/gtk/editing/unsupported-content/table-delete-003-expected.txt:
12:04 PM Changeset in webkit [157314] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebCore

Remove some dead code from PlatformCALayer*
​https://bugs.webkit.org/show_bug.cgi?id=122641

Reviewed by Anders Carlsson.

Remove some unused getters from PlatformCALayer and its implementations.

No new tests, just removing dead code.

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
12:03 PM Changeset in webkit [157313] by mark.lam@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Transition op_new_* JITStubs to JIT operations.
​https://bugs.webkit.org/show_bug.cgi?id=122460.

Reviewed by Michael Saboff.

Also:

  • Removed the redundant operationNewFunctionExpression(). It is identical to operationNewFunctionNoCheck().
  • Sorted JIT operation signature keys in the comment in JITOperations.h.
  • Removed the unused returnValue2Register definition for X86_64.
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunctionExpression):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_with_size):
(JSC::JIT::emit_op_new_array_buffer):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_new_object):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JSInterfaceJIT.h:
11:59 AM Changeset in webkit [157312] by ap@apple.com
  • 2 edits in trunk/Tools

LeaksViewer fails to present recent results list if current build is still updating svn
​https://bugs.webkit.org/show_bug.cgi?id=122670

Fixed an obvious mistake in the previous patch.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start):

11:56 AM Changeset in webkit [157311] by ap@apple.com
  • 2 edits in trunk/Tools

LeaksViewer fails to present recent results list if current build is still updating svn
​https://bugs.webkit.org/show_bug.cgi?id=122670

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:

(RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.

11:50 AM Changeset in webkit [157310] by aroben@webkit.org
  • 6 edits in trunk/Source

Confusing CGImageRef memory management in ImageBuffer::copyImage
​https://bugs.webkit.org/show_bug.cgi?id=122605

Source/WebCore:

BitmapImage::create was adopting the CGImage passed into it, which
resulted in some strange contortions in ImageBuffer::copyImage that
made it look like it was leaking CGImages, when in fact it was just
relying on BitmapImage to adopt the extra references.

BitmapImage::create now retains the passed-in CGImage, and I updated
the two callers to it to expect that (one here, one in WebKit2). I
also changed ImageBuffer::copyNativeImage to return a RetainPtr to
reduce the number of adoptCF()s needed and make it harder to make
programming mistakes.

Reviewed by Simon Fraser.

No new tests because this is just a code cleanup.

  • platform/graphics/ImageBuffer.h: Changed copyNativeImage to return a

RetainPtr<CGImageRef.

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::BitmapImage): Adopt the passed-in CGImage,
since we're taking ownership of it. (We release it in
FrameData::clear.)

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::copyImage): Updated for copyNativeImage's new
return type and to take into account BitmapImage::create's new
retaining semantics. This makes this function not have to be so clever
about retain counts.

(WebCore::ImageBuffer::copyNativeImage): Changed to return a
RetainPtr<CGImageRef>.

(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
Updated for changes to copyNativeImage.

Source/WebKit2:

Reviewed by Simon Fraser.

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createImage): BitmapImage::create now
retains the passed-in CGImage, so we don't need to dance around it
anymore. Also changed to use nullptr instead of 0 while I was in here.

11:01 AM Changeset in webkit [157309] by betravis@adobe.com
  • 5 edits
    6 adds in trunk

[CSS Shapes] Shape-Image-Threshold should be animatable
​https://bugs.webkit.org/show_bug.cgi?id=122622

Reviewed by Darin Adler.

Source/WebCore:

Make the shape-image-threshold property respond to dynamic changes
made through JS or CSS animations. Responding to changes made to
shape-image-threshold is handled in RenderBox::updateShapeOutsideInfoAfterStyleChange,
while CSSPropertyAnimation.cpp adds the property to the list of
animatable properties.

Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-image-threshold.html

fast/shapes/shape-outside-floats/shape-outside-shape-image-threshold-animation.html

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add
shape-image-threshold to the list of animatable properties.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange): updateShapeOutsideInfoAfterStyleChange
needs to take two RenderStyle arguments to compare multiple shape properties,
rather than just the shape-outside property.
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Compare
shape-image-threshold values to see if they changed, and invalidate the layout
if necessary.

  • rendering/RenderBox.h:

LayoutTests:

Adding tests for dynamically changing shape-image threshold via JS and CSS
animations. Included are some SVG resources used as the shape image sources.

  • fast/shapes/resources/svg-shape-002.svg: Added.
  • fast/shapes/resources/svg-shape-003.svg: Added.
  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-image-threshold-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-image-threshold.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-shape-image-threshold-animation-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-shape-image-threshold-animation.html: Added.
10:57 AM Changeset in webkit [157308] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

Unreviewed gardening. Remove a Windows work-around that is not needed.

  • dom/Range.cpp:

(WebCore::rangeOfContents): Move implementation back to source file.

  • dom/Range.h: Remove inline I added to work around a compiler bug.
10:30 AM Changeset in webkit [157307] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Separate out array iteration intrinsics
​https://bugs.webkit.org/show_bug.cgi?id=122656

Reviewed by Michael Saboff.

Separate out the intrinsics for key and values iteration
of arrays.

This requires moving moving array iteration into the iterator
instance, rather than the prototype, but this is essentially
unobservable so we'll live with it for now.

  • jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):
(JSC::arrayIteratorNextKeyThunkGenerator):
(JSC::arrayIteratorNextValueThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):

  • runtime/Intrinsic.h:
  • runtime/JSArrayIterator.cpp:

(JSC::JSArrayIterator::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorNext):
(JSC::arrayIteratorNextKey):
(JSC::arrayIteratorNextValue):
(JSC::arrayIteratorNextGeneric):

  • runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

9:54 AM Changeset in webkit [157306] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r157297.
​http://trac.webkit.org/changeset/157297
​https://bugs.webkit.org/show_bug.cgi?id=122651

Caused crashes on multiple platform/mac-wk2/tiled-drawing
tests (Requested by ap on #webkit).

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::operator new):
(WebCore::RenderLayer::operator delete):
(WebCore::RenderLayer::destroy):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::RenderLayerModelObject):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::ensureLayer):

  • rendering/RenderLayerModelObject.h:

(WebCore::RenderLayerModelObject::layer):

9:53 AM Changeset in webkit [157305] by Bem Jones-Bey
  • 3 edits
    24 adds in trunk/LayoutTests

[CSS Shapes] New positioning model: Negative margins
​https://bugs.webkit.org/show_bug.cgi?id=118090

Reviewed by Darin Adler.

Tests for shape-outside with negative margins:

negative top margin
negative left margin
negative right margin
negative bottom margin
negative top margin vertical right-left writing mode
negative left margin vertical right-left writing mode
negative right margin vertical right-left writing mode
negative bottom margin vertical right-left writing mode
negative top margin vertical left-right writing mode
negative left margin vertical left-right writing mode
negative right margin vertical left-right writing mode
negative bottom margin vertical left-right writing mode

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
9:51 AM Changeset in webkit [157304] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Added new accessibility expectation after r154697
​https://bugs.webkit.org/show_bug.cgi?id=122646

Unreviewed EFL gardening

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-11

  • platform/efl-wk2/TestExpectations:
  • platform/efl/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
9:46 AM Changeset in webkit [157303] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed build fix for --64-bit target.

  • Scripts/webkitdirs.pm:

(argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
been removed by this point.
(hasArgument): Remove unused temporary.

9:34 AM Changeset in webkit [157302] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix build.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::translate): Do a const_cast when creating the
lineage, since it doesn't yet work with const pointers.

8:26 AM Changeset in webkit [157301] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Pass VM instead of ExecState to JSGenericTypedArrayViewPrototype.
<​https://webkit.org/b/122632>

Reviewed by Sam Weinig.

This code was only using the ExecState to find the VM.

8:07 AM Changeset in webkit [157300] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Do a bit of optimization and cleanup in the HTMLElement class
​https://bugs.webkit.org/show_bug.cgi?id=122640

Reviewed by Andreas Kling.

  • html/HTMLElement.cpp:

(WebCore::unicodeBidiAttributeForDirAuto): Take a reference.
(WebCore::HTMLElement::collectStyleForPresentationAttribute): Pass one.
(WebCore::mergeWithNextTextNode): Take a reference to a Text node instead
of a PassRefPtr to a Node. Also removed unnecessary check of parentNode.
Also update to new calling convention for mergeWithNextTextNode.
(WebCore::HTMLElement::setOuterHTML): Use parentElement instead of
parentNode, since Antti says that's the future, and either will work here.
Also use nullptr.
(WebCore::HTMLElement::textToFragment): Fix indentation and use nullptr.
(WebCore::HTMLElement::setOuterText): Use a RefPtr for the parent here,
since otherwise there is no guarantee it survives. Also use nullptr and
update to new calling convention for mergeWithNextTextNode.
(WebCore::HTMLElement::insertAdjacent): Use nullptr.
(WebCore::HTMLElement::insertAdjacentElement): Use nullptr.
(WebCore::contextElementForInsertion): Use nullptr.
(WebCore::HTMLElement::contentEditable): Use ASCIILiteral.
(WebCore::HTMLElement::setContentEditable): Use AtomicString::ConstructFromLiteral.
(WebCore::HTMLElement::draggable): Use fastGetAttribute.
(WebCore::HTMLElement::setDraggable): Use AtomicString::ConstructFromLiteral.
(WebCore::HTMLElement::setSpellcheck): Use AtomicString::ConstructFromLiteral.
(WebCore::HTMLElement::click): Use nullptr.
(WebCore::HTMLElement::accessKeyAction): Use nullptr.
(WebCore::HTMLElement::title): Use fastGetAttribute.
(WebCore::HTMLElement::translateAttributeMode): Use fastGetAttribute, isNull,
and isEmpty.
(WebCore::HTMLElement::translate): Use parentElement and toHTMLElement.
Use early-continue style instead of nesting the whole loop body inside an if.
(WebCore::setHasDirAutoFlagRecursively): Use nullptr.
(WebCore::HTMLElement::hasDirectionAuto): Use isNull.
(WebCore::HTMLElement::directionality): Use nullptr.
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged): Use nullptr.
(WebCore::HTMLElement::addHTMLLengthToStyle): Use longer variable names.

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::abbr): Use fastGetAttribute.
(WebCore::HTMLTableCellElement::axis): Ditto.
(WebCore::HTMLTableCellElement::headers): Ditto.
(WebCore::HTMLTableCellElement::scope): Ditto.

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::width): Ditto.

2:44 AM Changeset in webkit [157299] by dino@apple.com
  • 8 edits in trunk

Source/WebCore: Use after free in WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=121033

Patch by Darin Adler <Darin Adler> on 2013-10-10
Reviewed by Dean Jackson.

For safe iteration, use a set rather than a vector, and remove the clients from
the set if they are removed during iteration.

Test: fast/animation/request-animation-frame-remove-client.html

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor): Initialize the
m_clientsToBeNotified pointer to null.
(WebCore::DisplayRefreshMonitor::removeClient): If there is a m_clientsToBeNotified
set, remove from it as well as the real m_clients set.
(WebCore::DisplayRefreshMonitor::displayDidRefresh): Use a HashSet instead of a
vector for the copy of the clients set we iterate.

  • platform/graphics/DisplayRefreshMonitor.h: Moved some of the BlackBerry-specific

part of this out of the header. Added a new HashSet pointer, m_clientsToBeNotified,
to be used to remove clients during the notification process. Also added a FIXME.

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Moved the

DisplayAnimationClient class in here.

LayoutTests: Use after free in WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded
​http://webkit.org/b/121033

Update test to indicate it no longer crashes.

  • TestExpectations: Mark test as passing.
  • fast/animation/request-animation-frame-remove-client-expected.txt:
  • fast/animation/request-animation-frame-remove-client.html:
2:43 AM Changeset in webkit [157298] by dino@apple.com
  • 4 edits
    2 adds in trunk

Use after free in WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded
​http://webkit.org/b/121033

Reviewed by Darin Adler.

Source/WebCore:

Add an ASSERT to detect if an animation client will be removed
during the callback dispatch.

Test: fast/animation/request-animation-frame-remove-client.html

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

LayoutTests:

Test that assertion fires if you try to remove potential client while in a
animation dispatch.

  • TestExpectations: Mark test as crashing.
  • fast/animation/request-animation-frame-remove-client-expected.txt: Added.
  • fast/animation/request-animation-frame-remove-client.html: Added.
2:39 AM Changeset in webkit [157297] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Make RenderLayer not arena-allocated.
<​https://webkit.org/b/87523>

Reviewed by Antti Koivisto.

Let RenderLayerModelObject store its RenderLayer in a unique_ptr.
Layers are relatively low-volume objects and this looks neutral
on our performance tests.

1:35 AM Changeset in webkit [157296] by Alan Bujtas
  • 11 edits in trunk

REGRESSION (r155607): Javascript site does not load visually on panerabread.com
​https://bugs.webkit.org/show_bug.cgi?id=122461

Reviewed by Simon Fraser.

Do not modify the composited layer backing's internal layer structure directly
when the clipping behaviour changes.

When we directly create/destroy RenderLayerBacking::m_ancestorClippingLayer to
reflect the new clipping state, other, depending layers need updating. In order to
not to corrupt the internal hierarchy, mark the compositing layers dirty and let
the normal updating mechanism take care of creating/destroying the ancestor layers.

Source/WebCore:

Existing tests are extended.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::checkIfDescendantClippingContextNeedsUpdate):
(WebCore::RenderLayer::styleChanged):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.h:

LayoutTests:

  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html:
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html:
  • platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
  • platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
1:26 AM Changeset in webkit [157295] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] Fix build after r157209.
​https://bugs.webkit.org/show_bug.cgi?id=122643

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-11
Reviewed by Ryosuke Niwa.

  • assembler/MacroAssemblerSH4.h: Add framePointerRegister declaration.
  • assembler/SH4Assembler.h: Add firstRegister() declaration.

(JSC::SH4Assembler::firstRegister):

Oct 10, 2013:

11:41 PM Changeset in webkit [157294] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Make EventPath private to EventDispatcher.cpp
​https://bugs.webkit.org/show_bug.cgi?id=122638

Reviewed by Darin Adler.

Move the declaration of EventPath into EventDispatcher.cpp since EventPath is only used in this file.
Also make EventDispatcher a namespace since it is never instantiated since r157250.

  • dom/EventDispatcher.cpp:

(WebCore::EventPath::isEmpty):
(WebCore::EventPath::size):
(WebCore::EventPath::contextAt):
(WebCore::EventPath::lastContextIfExists):

  • dom/EventDispatcher.h:
  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willDispatchEvent):

11:37 PM Changeset in webkit [157293] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL shouldn't pass i1's into llvm.webkit.stackmap's
​https://bugs.webkit.org/show_bug.cgi?id=122629
<rdar://problem/15203037>

Reviewed by Sam Weinig and Nadav Rotem.

LLVM's stackmap support requires that we only pass operands with legal types (i.e. types
that are hardware-representable). i1, which the FTL previously used for Booleans, is not
legal.

We have two options: either add support in LLVM to legalize stackmap operands, or add
support to the FTL to legalize stackmap operands. It's easier to fix this in FTL, and
that's what this patch does.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

11:18 PM Changeset in webkit [157292] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

contentEditable with "position:relative" paragraphs is buggy
​https://bugs.webkit.org/show_bug.cgi?id=33950

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-10
Reviewed by Darin Adler.

Source/WebCore:

When paragraph is positioned(relative/absolute/fixed) then deleting
that paragraph cause wrong merging of other(below) paragraphs. This is
happening because positioned element is treated as special element and
on deletion complete paragraph element is removed. The ranges become
paragraph. This issue happens when all the content of special element
are deleted. So the merging of paragraph is avoided in this scenario.

Test: editing/deleting/deleting-relative-positioned-special-element.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::initializeStartEnd):Avoid merging
block when special candidate are included in deletion range

LayoutTests:

LayoutTests:

Added a testcase to verify that when paragraph is relative positioned
then deleting the all content of paragraph should not incorrectly collapse the
others(below) paragraphs.
And Rebaseline the test expectation.

  • editing/deleting/5546763-expected.txt: Updated.
  • editing/deleting/deleting-relative-positioned-special-element-expected.txt: Added.
  • editing/deleting/deleting-relative-positioned-special-element.html: Added.
  • editing/unsupported-content/table-delete-001.html: Adjusted to dump

as markup.

  • editing/unsupported-content/table-delete-003.html: Adjusted to dump

as markup.

Below tests had wrong cursor position previously now corrected and
both expected file has been changed to markup dump.

  • platform/mac/editing/unsupported-content/table-delete-001-expected.txt:
  • platform/mac/editing/unsupported-content/table-delete-003-expected.txt:
11:17 PM Changeset in webkit [157291] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Layout Test fast/css/font-face-download-error.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=122636

Reviewed by Darin Adler.

  • fast/css/font-face-download-error-expected.txt: TEST COMPLETE is now printed

after the test is complete.

  • fast/css/font-face-download-error.html: Changed to properly wait for fonts to load.

Also, updated to use a proper async test implementation.

11:16 PM Changeset in webkit [157290] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Track controls show metadata and chapter tracks
​https://bugs.webkit.org/show_bug.cgi?id=122468

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-10-10
Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html

  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Only show captions, descriptions and subtitles in the track controls.

LayoutTests:

Add a test to make sure we don't show metadata and chapter tracks in the track controls.

  • media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles-expected.txt: Added.
  • media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html: Added.
  • platform/efl/TestExpectations: Skip, uses caption button, not track menu.
  • platform/mac/TestExpectations: Skip, track menu tests all fail on Mac.
  • platform/win/TestExpectations: Same.
9:55 PM Changeset in webkit [157289] by bw80.lee@samsung.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

[EFL][WK2] Separate dispatch context from WorkQueue.
​https://bugs.webkit.org/show_bug.cgi?id=115332

Reviewed by Anders Carlsson.

Refactor WorkQueue to prevent dangling workqueue access.

Previously, the WorkQueue class had all context about dispatch.
WorkQueue had dispatch item queue and socket event handler,
and those were accessed on the work queue thread through WorkQueue
instance.

With reference countable WorkQueue concept, this implementation
complicates handling workqueue ref-counting and causes dangling
workqueue access problem.

To make it easy to handle WorkQueue reference count and to prevent
dangling access problem, DispatchQueue class is added to handle
dispatch tasks, and the WorkQueue instance and DispatchQueue thread
will have the reference count of the DispatchQueue instance to prevent
dangling access.

  • Platform/WorkQueue.h:
  • Platform/efl/DispatchQueueEfl.cpp: Added.

(DispatchQueue::ThreadContext::start):
(DispatchQueue::ThreadContext::ThreadContext):
(DispatchQueue::ThreadContext::function):
(DispatchQueue::create):
(DispatchQueue::DispatchQueue):
(DispatchQueue::~DispatchQueue):
(DispatchQueue::dispatch):
(DispatchQueue::stopThread):
(DispatchQueue::setSocketEventHandler):
(DispatchQueue::clearSocketEventHandler):
(DispatchQueue::performWork):
(DispatchQueue::performTimerWork):
(DispatchQueue::performFileDescriptorWork):
(DispatchQueue::insertTimerWorkItem):
(DispatchQueue::dispatchQueueThread):
(DispatchQueue::wakeUpThread):
(DispatchQueue::getNextTimeOut):

  • Platform/efl/DispatchQueueEfl.h: Added.
  • Platform/efl/DispatchQueueWorkItemEfl.h: Added.

(WorkItem::create):
(WorkItem::dispatch):
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::expirationTimeSeconds):
(TimerWorkItem::hasExpired):
(TimerWorkItem::TimerWorkItem):

  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

  • PlatformEfl.cmake:
8:56 PM Changeset in webkit [157288] by rniwa@webkit.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

EventContext should be used only in EventDispatcher.cpp
​https://bugs.webkit.org/show_bug.cgi?id=122631

Reviewed by Anders Carlsson.

Merged WindowEventContext into EventDispatcher. Moved the code to avoid dispatching load event on
window into dispatchEventInDOM so that WindowEventContext's constructor doesn't need Event.

Also replaced DOMWindow, Node, and EventPath arguments to InspectorInstrumentation::willDispatchEvent
by a single boolean indicating whether window, the origin, or the event path has an event listener.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/EventDispatcher.cpp:

(WebCore::WindowEventContext::window): Moved from WindowEventContext.
(WebCore::WindowEventContext::target): Ditto.
(WebCore::WindowEventContext::WindowEventContext): Ditto; removed the code to avoid dispatching load
event on window since that's checked in dispatchEventInDOM now.
(WebCore::WindowEventContext::handleLocalEvents): Ditto.
(WebCore::dispatchEventInDOM): Avoid calling handleLocalEvent on a load event with WindowEventContext.
(WebCore::EventDispatcher::dispatchEvent): Pass a boolean to indicate whether window, the origin, or
the event path contains any event listener to InspectorInstrumentation::willDispatchEvent to hide
EventPath from the inspector code.

  • dom/EventDispatcher.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/WindowEventContext.cpp: Removed.
  • dom/WindowEventContext.h: Removed.
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willDispatchEventImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willDispatchEvent):

8:51 PM Changeset in webkit [157287] by Darin Adler
  • 2 edits in trunk/Source/WebCore

REGRESSION (r157205?): Leaks in XPath
​https://bugs.webkit.org/show_bug.cgi?id=122609

Reviewed by Andreas Kling.

  • xml/XPathGrammar.y: Fixed warnings by adding missing "$$ = $1" to various rules.

Added local unique_ptr for NodeTest and ArgumentList in three rules, so they
won't be leaked.

8:37 PM Changeset in webkit [157286] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Add toSVGColor|Paint() to cleanup static_cast<>, and use it
​https://bugs.webkit.org/show_bug.cgi?id=122630

Reviewed by Andreas Kling.

SVGColor and SVGPaint can't use CSS_VALUE_TYPE_CASTS(), this cl adds
toSVGColor() and toSVGPaint() manually. Those functions will help to
detect bad type cast.

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • svg/SVGColor.h:

(WebCore::toSVGColor):

  • svg/SVGPaint.h:

(WebCore::toSVGPaint):

6:47 PM Changeset in webkit [157285] by akling@apple.com
  • 11 edits
    2 deletes in trunk/Source/WebCore

Kill WebCore::BindingState.
<​https://webkit.org/b/122606>

Reviewed by Darin Adler.

Just use JSC::ExecState directly instead.

6:47 PM Changeset in webkit [157284] by kov@webkit.org
  • 2 edits in trunk/Tools

webkit-patch failure-reason has a quite low limit for 'too many failures'
​https://bugs.webkit.org/show_bug.cgi?id=122556

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-10-10
Reviewed by Darin Adler.

  • Scripts/webkitpy/tool/commands/queries.py:

(FailureReason._explain_failures_for_builder): adjust the number of too many failures
to match what the layout test runners use these days.

6:41 PM Changeset in webkit [157283] by kov@webkit.org
  • 2 edits in trunk/Tools

webkit-patch failure-reason should allow specifying failures one is interested in
​https://bugs.webkit.org/show_bug.cgi?id=122554

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-10-10
Reviewed by Darin Adler.

  • Scripts/webkitpy/tool/commands/queries.py:

(FailureReason):
(FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
loop if the ones we're interested in been explained.
(FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
(FailureReason.execute): initialize failures to explain and the explained set.

6:14 PM Changeset in webkit [157282] by rniwa@webkit.org
  • 17 edits
    2 deletes in trunk/Source/WebCore

Remove EventRetargeter.h/cpp
​https://bugs.webkit.org/show_bug.cgi?id=122625

Reviewed by Anders Carlsson.

Merged the remaining contents of EventRetargeter.h and EventRetargter.cpp into EventDispatcher.cpp.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/indieui/UIRequestEvent.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingTargetRules):
(WebCore::shouldEventCrossShadowBoundary):
(WebCore::nodeOrHostIfPseudoElement):
(WebCore::EventPath::EventPath):
(WebCore::buildRelatedNodeMap):
(WebCore::addRelatedNodeForUnmapedTreeScopes):
(WebCore::calculateAdjustedNodes):
(WebCore::updateTouchListsInEventPath):
(WebCore::EventPath::updateTouchLists):
(WebCore::EventPath::setRelatedTarget):

  • dom/EventRetargeter.cpp: Removed.
  • dom/EventRetargeter.h: Removed.
  • dom/FocusEvent.cpp:
  • dom/GestureEvent.h:
  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:
  • dom/MouseEvent.h:
  • dom/TouchEvent.cpp:
  • dom/UIEvent.cpp:
  • dom/WheelEvent.cpp:
5:51 PM Changeset in webkit [157281] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit

Windows build fix attempt.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:40 PM Changeset in webkit [157280] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Making the base implementation of isAudioStreamSource, in MediaStreamSource, return the correct value
​https://bugs.webkit.org/show_bug.cgi?id=122612

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.

There is no reason for this implementation, in the base class, to always return false
if we already have the information about the type of the source.

No new tests needed.

  • Modules/webaudio/MediaStreamAudioSource.h:
  • platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::isAudioStreamSource):

5:30 PM Changeset in webkit [157279] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

Always force layout before flushing compositing layers
​https://bugs.webkit.org/show_bug.cgi?id=122626

Reviewed by Tim Horton.

[m_webView _flushCompositingChanges] only actually flushes compositing
layers if the FrameView does not need layout (FrameView::flushCompositingStateForThisFrame()
returns in this case). In this situation, flushLayers() does actually try
to force a layout, but on some platforms it's possible for something else
to dirty layout before the runloop observer fires again. This can result
in flushLayers() never actually managing to flush, which stalls visual
updates.

Fix by always calling -viewWillDraw (which updates layout) before flushing
layers. This now matches WebKit2 behavior.

  • WebView/WebView.mm:

(LayerFlushController::flushLayers):

5:17 PM Changeset in webkit [157278] by timothy@apple.com
  • 1 edit
    431 deletes in trunk/Source/WebCore

Web Inspector: Remove the old front-end from WebKit.

​https://bugs.webkit.org/show_bug.cgi?id=122295

  • inspector/front-end/AceTextEditor.js: Removed.
  • inspector/front-end/AdvancedSearchController.js: Removed.
  • inspector/front-end/ApplicationCacheItemsView.js: Removed.
  • inspector/front-end/ApplicationCacheModel.js: Removed.
  • inspector/front-end/AuditCategories.js: Removed.
  • inspector/front-end/AuditController.js: Removed.
  • inspector/front-end/AuditFormatters.js: Removed.
  • inspector/front-end/AuditLauncherView.js: Removed.
  • inspector/front-end/AuditResultView.js: Removed.
  • inspector/front-end/AuditRules.js: Removed.
  • inspector/front-end/AuditsPanel.js: Removed.
  • inspector/front-end/BottomUpProfileDataGridTree.js: Removed.
  • inspector/front-end/BreakpointManager.js: Removed.
  • inspector/front-end/BreakpointsSidebarPane.js: Removed.
  • inspector/front-end/CPUProfileView.js: Removed.
  • inspector/front-end/CSSMetadata.js: Removed.
  • inspector/front-end/CSSNamedFlowCollectionsView.js: Removed.
  • inspector/front-end/CSSNamedFlowView.js: Removed.
  • inspector/front-end/CSSSelectorProfileView.js: Removed.
  • inspector/front-end/CSSStyleModel.js: Removed.
  • inspector/front-end/CallStackSidebarPane.js: Removed.
  • inspector/front-end/CanvasProfileView.js: Removed.
  • inspector/front-end/Checkbox.js: Removed.
  • inspector/front-end/CodeMirrorTextEditor.js: Removed.
  • inspector/front-end/Color.js: Removed.
  • inspector/front-end/CompilerScriptMapping.js: Removed.
  • inspector/front-end/ConsoleMessage.js: Removed.
  • inspector/front-end/ConsoleModel.js: Removed.
  • inspector/front-end/ConsolePanel.js: Removed.
  • inspector/front-end/ConsoleView.js: Removed.
  • inspector/front-end/ContentProvider.js: Removed.
  • inspector/front-end/ContentProviderBasedProjectDelegate.js: Removed.
  • inspector/front-end/ContentProviders.js: Removed.
  • inspector/front-end/ContextMenu.js: Removed.
  • inspector/front-end/CookieItemsView.js: Removed.
  • inspector/front-end/CookieParser.js: Removed.
  • inspector/front-end/CookiesTable.js: Removed.
  • inspector/front-end/DOMAgent.js: Removed.
  • inspector/front-end/DOMBreakpointsSidebarPane.js: Removed.
  • inspector/front-end/DOMCountersGraph.js: Removed.
  • inspector/front-end/DOMExtension.js: Removed.
  • inspector/front-end/DOMPresentationUtils.js: Removed.
  • inspector/front-end/DOMStorage.js: Removed.
  • inspector/front-end/DOMStorageItemsView.js: Removed.
  • inspector/front-end/DOMSyntaxHighlighter.js: Removed.
  • inspector/front-end/DataGrid.js: Removed.
  • inspector/front-end/Database.js: Removed.
  • inspector/front-end/DatabaseQueryView.js: Removed.
  • inspector/front-end/DatabaseTableView.js: Removed.
  • inspector/front-end/DebuggerModel.js: Removed.
  • inspector/front-end/DebuggerScriptMapping.js: Removed.
  • inspector/front-end/DefaultScriptMapping.js: Removed.
  • inspector/front-end/DefaultTextEditor.js: Removed.
  • inspector/front-end/Dialog.js: Removed.
  • inspector/front-end/DirectoryContentView.js: Removed.
  • inspector/front-end/DockController.js: Removed.
  • inspector/front-end/Drawer.js: Removed.
  • inspector/front-end/ElementsPanel.js: Removed.
  • inspector/front-end/ElementsPanelDescriptor.js: Removed.
  • inspector/front-end/ElementsTreeOutline.js: Removed.
  • inspector/front-end/EmptyView.js: Removed.
  • inspector/front-end/EventListenersSidebarPane.js: Removed.
  • inspector/front-end/ExtensionAPI.js: Removed.
  • inspector/front-end/ExtensionAuditCategory.js: Removed.
  • inspector/front-end/ExtensionPanel.js: Removed.
  • inspector/front-end/ExtensionRegistryStub.js: Removed.
  • inspector/front-end/ExtensionServer.js: Removed.
  • inspector/front-end/ExtensionView.js: Removed.
  • inspector/front-end/FileContentView.js: Removed.
  • inspector/front-end/FileManager.js: Removed.
  • inspector/front-end/FileMapping.js: Removed.
  • inspector/front-end/FileSystemMapping.js: Removed.
  • inspector/front-end/FileSystemModel.js: Removed.
  • inspector/front-end/FileSystemProjectDelegate.js: Removed.
  • inspector/front-end/FileSystemView.js: Removed.
  • inspector/front-end/FileUtils.js: Removed.
  • inspector/front-end/FilteredItemSelectionDialog.js: Removed.
  • inspector/front-end/FlameChart.js: Removed.
  • inspector/front-end/FontView.js: Removed.
  • inspector/front-end/GoToLineDialog.js: Removed.
  • inspector/front-end/HAREntry.js: Removed.
  • inspector/front-end/HandlerRegistry.js: Removed.
  • inspector/front-end/HeapSnapshot.js: Removed.
  • inspector/front-end/HeapSnapshotDataGrids.js: Removed.
  • inspector/front-end/HeapSnapshotGridNodes.js: Removed.
  • inspector/front-end/HeapSnapshotLoader.js: Removed.
  • inspector/front-end/HeapSnapshotProxy.js: Removed.
  • inspector/front-end/HeapSnapshotView.js: Removed.
  • inspector/front-end/HeapSnapshotWorker.js: Removed.
  • inspector/front-end/HeapSnapshotWorkerDispatcher.js: Removed.
  • inspector/front-end/HelpScreen.js: Removed.
  • inspector/front-end/ImageView.js: Removed.
  • inspector/front-end/Images/addIcon.png: Removed.
  • inspector/front-end/Images/applicationCache.png: Removed.
  • inspector/front-end/Images/back.png: Removed.
  • inspector/front-end/Images/breakpointBorder.png: Removed.
  • inspector/front-end/Images/breakpointConditionalBorder.png: Removed.
  • inspector/front-end/Images/breakpointConditionalCounterBorder.png: Removed.
  • inspector/front-end/Images/breakpointCounterBorder.png: Removed.
  • inspector/front-end/Images/checker.png: Removed.
  • inspector/front-end/Images/closeButtons.png: Removed.
  • inspector/front-end/Images/cookie.png: Removed.
  • inspector/front-end/Images/database.png: Removed.
  • inspector/front-end/Images/databaseTable.png: Removed.
  • inspector/front-end/Images/debuggerContinue.png: Removed.
  • inspector/front-end/Images/debuggerPause.png: Removed.
  • inspector/front-end/Images/debuggerStepInto.png: Removed.
  • inspector/front-end/Images/debuggerStepOut.png: Removed.
  • inspector/front-end/Images/debuggerStepOver.png: Removed.
  • inspector/front-end/Images/deleteIcon.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallDown.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRight.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Removed.
  • inspector/front-end/Images/domain.png: Removed.
  • inspector/front-end/Images/errorIcon.png: Removed.
  • inspector/front-end/Images/errorMediumIcon.png: Removed.
  • inspector/front-end/Images/errorRedDot.png: Removed.
  • inspector/front-end/Images/fileSystem.png: Removed.
  • inspector/front-end/Images/forward.png: Removed.
  • inspector/front-end/Images/frame.png: Removed.
  • inspector/front-end/Images/glossyHeader.png: Removed.
  • inspector/front-end/Images/glossyHeaderPressed.png: Removed.
  • inspector/front-end/Images/glossyHeaderSelected.png: Removed.
  • inspector/front-end/Images/glossyHeaderSelectedPressed.png: Removed.
  • inspector/front-end/Images/goArrow.png: Removed.
  • inspector/front-end/Images/graphLabelCalloutLeft.png: Removed.
  • inspector/front-end/Images/graphLabelCalloutRight.png: Removed.
  • inspector/front-end/Images/indexedDB.png: Removed.
  • inspector/front-end/Images/indexedDBIndex.png: Removed.
  • inspector/front-end/Images/indexedDBObjectStore.png: Removed.
  • inspector/front-end/Images/localStorage.png: Removed.
  • inspector/front-end/Images/namedFlowOverflow.png: Removed.
  • inspector/front-end/Images/navigatorShowHideButton.png: Removed.
  • inspector/front-end/Images/paneAddButtons.png: Removed.
  • inspector/front-end/Images/paneBottomGrow.png: Removed.
  • inspector/front-end/Images/paneBottomGrowActive.png: Removed.
  • inspector/front-end/Images/paneElementStateButtons.png: Removed.
  • inspector/front-end/Images/paneFilterButtons.png: Removed.
  • inspector/front-end/Images/paneGrowHandleLine.png: Removed.
  • inspector/front-end/Images/paneRefreshButtons.png: Removed.
  • inspector/front-end/Images/paneSettingsButtons.png: Removed.
  • inspector/front-end/Images/popoverArrows.png: Removed.
  • inspector/front-end/Images/popoverBackground.png: Removed.
  • inspector/front-end/Images/profileGroupIcon.png: Removed.
  • inspector/front-end/Images/profileIcon.png: Removed.
  • inspector/front-end/Images/profileSmallIcon.png: Removed.
  • inspector/front-end/Images/profilesSilhouette.png: Removed.
  • inspector/front-end/Images/programCounterBorder.png: Removed.
  • inspector/front-end/Images/radioDot.png: Removed.
  • inspector/front-end/Images/regionEmpty.png: Removed.
  • inspector/front-end/Images/regionFit.png: Removed.
  • inspector/front-end/Images/regionOverset.png: Removed.
  • inspector/front-end/Images/resourceCSSIcon.png: Removed.
  • inspector/front-end/Images/resourceDocumentIcon.png: Removed.
  • inspector/front-end/Images/resourceDocumentIconSmall.png: Removed.
  • inspector/front-end/Images/resourceJSIcon.png: Removed.
  • inspector/front-end/Images/resourcePlainIcon.png: Removed.
  • inspector/front-end/Images/resourcePlainIconSmall.png: Removed.
  • inspector/front-end/Images/resourcesSizeGraphIcon.png: Removed.
  • inspector/front-end/Images/resourcesTimeGraphIcon.png: Removed.
  • inspector/front-end/Images/scriptsSilhouette.png: Removed.
  • inspector/front-end/Images/searchNext.png: Removed.
  • inspector/front-end/Images/searchPrev.png: Removed.
  • inspector/front-end/Images/searchSmallBlue.png: Removed.
  • inspector/front-end/Images/searchSmallBrightBlue.png: Removed.
  • inspector/front-end/Images/searchSmallGray.png: Removed.
  • inspector/front-end/Images/searchSmallWhite.png: Removed.
  • inspector/front-end/Images/segment.png: Removed.
  • inspector/front-end/Images/segmentEnd.png: Removed.
  • inspector/front-end/Images/segmentHover.png: Removed.
  • inspector/front-end/Images/segmentHoverEnd.png: Removed.
  • inspector/front-end/Images/segmentSelected.png: Removed.
  • inspector/front-end/Images/segmentSelectedEnd.png: Removed.
  • inspector/front-end/Images/sessionStorage.png: Removed.
  • inspector/front-end/Images/spinner.gif: Removed.
  • inspector/front-end/Images/spinnerActive.gif: Removed.
  • inspector/front-end/Images/spinnerActiveSelected.gif: Removed.
  • inspector/front-end/Images/spinnerInactive.gif: Removed.
  • inspector/front-end/Images/spinnerInactiveSelected.gif: Removed.
  • inspector/front-end/Images/splitviewDimple.png: Removed.
  • inspector/front-end/Images/splitviewDividerBackground.png: Removed.
  • inspector/front-end/Images/statusbarButtonGlyphs.png: Removed.
  • inspector/front-end/Images/statusbarButtonGlyphs2x.png: Removed.
  • inspector/front-end/Images/statusbarResizerHorizontal.png: Removed.
  • inspector/front-end/Images/statusbarResizerVertical.png: Removed.
  • inspector/front-end/Images/successGreenDot.png: Removed.
  • inspector/front-end/Images/thumbActiveHoriz.png: Removed.
  • inspector/front-end/Images/thumbActiveVert.png: Removed.
  • inspector/front-end/Images/thumbHoriz.png: Removed.
  • inspector/front-end/Images/thumbHoverHoriz.png: Removed.
  • inspector/front-end/Images/thumbHoverVert.png: Removed.
  • inspector/front-end/Images/thumbVert.png: Removed.
  • inspector/front-end/Images/tickMark.png: Removed.
  • inspector/front-end/Images/timelineHollowPillBlue.png: Removed.
  • inspector/front-end/Images/timelineHollowPillGray.png: Removed.
  • inspector/front-end/Images/timelineHollowPillGreen.png: Removed.
  • inspector/front-end/Images/timelineHollowPillOrange.png: Removed.
  • inspector/front-end/Images/timelineHollowPillPurple.png: Removed.
  • inspector/front-end/Images/timelineHollowPillRed.png: Removed.
  • inspector/front-end/Images/timelineHollowPillYellow.png: Removed.
  • inspector/front-end/Images/timelinePillBlue.png: Removed.
  • inspector/front-end/Images/timelinePillGray.png: Removed.
  • inspector/front-end/Images/timelinePillGreen.png: Removed.
  • inspector/front-end/Images/timelinePillOrange.png: Removed.
  • inspector/front-end/Images/timelinePillPurple.png: Removed.
  • inspector/front-end/Images/timelinePillRed.png: Removed.
  • inspector/front-end/Images/timelinePillYellow.png: Removed.
  • inspector/front-end/Images/toolbarIcons.png: Removed.
  • inspector/front-end/Images/toolbarIconsSmall.png: Removed.
  • inspector/front-end/Images/toolbarItemSelected.png: Removed.
  • inspector/front-end/Images/trackHoriz.png: Removed.
  • inspector/front-end/Images/trackVert.png: Removed.
  • inspector/front-end/Images/treeDownTriangleBlack.png: Removed.
  • inspector/front-end/Images/treeDownTriangleWhite.png: Removed.
  • inspector/front-end/Images/treeRightTriangleBlack.png: Removed.
  • inspector/front-end/Images/treeRightTriangleWhite.png: Removed.
  • inspector/front-end/Images/treeUpTriangleBlack.png: Removed.
  • inspector/front-end/Images/treeUpTriangleWhite.png: Removed.
  • inspector/front-end/Images/userInputIcon.png: Removed.
  • inspector/front-end/Images/userInputPreviousIcon.png: Removed.
  • inspector/front-end/Images/userInputResultIcon.png: Removed.
  • inspector/front-end/Images/warningIcon.png: Removed.
  • inspector/front-end/Images/warningMediumIcon.png: Removed.
  • inspector/front-end/Images/warningOrangeDot.png: Removed.
  • inspector/front-end/Images/warningsErrors.png: Removed.
  • inspector/front-end/IndexedDBModel.js: Removed.
  • inspector/front-end/IndexedDBViews.js: Removed.
  • inspector/front-end/InspectElementModeController.js: Removed.
  • inspector/front-end/InspectorBackend.js: Removed.
  • inspector/front-end/InspectorBackendCommands.qrc: Removed.
  • inspector/front-end/InspectorFrontendAPI.js: Removed.
  • inspector/front-end/InspectorFrontendHostStub.js: Removed.
  • inspector/front-end/InspectorView.js: Removed.
  • inspector/front-end/IsolatedFileSystem.js: Removed.
  • inspector/front-end/IsolatedFileSystemManager.js: Removed.
  • inspector/front-end/JSHeapSnapshot.js: Removed.
  • inspector/front-end/JavaScriptFormatter.js: Removed.
  • inspector/front-end/JavaScriptSourceFrame.js: Removed.
  • inspector/front-end/KeyboardShortcut.js: Removed.
  • inspector/front-end/Linkifier.js: Removed.
  • inspector/front-end/LiveEditSupport.js: Removed.
  • inspector/front-end/MemoryStatistics.js: Removed.
  • inspector/front-end/MetricsSidebarPane.js: Removed.
  • inspector/front-end/NativeBreakpointsSidebarPane.js: Removed.
  • inspector/front-end/NativeHeapSnapshot.js: Removed.
  • inspector/front-end/NativeMemoryGraph.js: Removed.
  • inspector/front-end/NavigatorOverlayController.js: Removed.
  • inspector/front-end/NavigatorView.js: Removed.
  • inspector/front-end/NetworkItemView.js: Removed.
  • inspector/front-end/NetworkLog.js: Removed.
  • inspector/front-end/NetworkManager.js: Removed.
  • inspector/front-end/NetworkPanel.js: Removed.
  • inspector/front-end/NetworkPanelDescriptor.js: Removed.
  • inspector/front-end/NetworkRequest.js: Removed.
  • inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
  • inspector/front-end/Object.js: Removed.
  • inspector/front-end/ObjectPopoverHelper.js: Removed.
  • inspector/front-end/ObjectPropertiesSection.js: Removed.
  • inspector/front-end/OverridesView.js: Removed.
  • inspector/front-end/OverviewGrid.js: Removed.
  • inspector/front-end/Panel.js: Removed.
  • inspector/front-end/PanelEnablerView.js: Removed.
  • inspector/front-end/ParsedURL.js: Removed.
  • inspector/front-end/Placard.js: Removed.
  • inspector/front-end/Popover.js: Removed.
  • inspector/front-end/PresentationConsoleMessageHelper.js: Removed.
  • inspector/front-end/ProfileDataGridTree.js: Removed.
  • inspector/front-end/ProfileLauncherView.js: Removed.
  • inspector/front-end/ProfilesPanel.js: Removed.
  • inspector/front-end/ProfilesPanelDescriptor.js: Removed.
  • inspector/front-end/Progress.js: Removed.
  • inspector/front-end/ProgressIndicator.js: Removed.
  • inspector/front-end/PropertiesSection.js: Removed.
  • inspector/front-end/PropertiesSidebarPane.js: Removed.
  • inspector/front-end/RawSourceCode.js: Removed.
  • inspector/front-end/RemoteObject.js: Removed.
  • inspector/front-end/RequestCookiesView.js: Removed.
  • inspector/front-end/RequestHTMLView.js: Removed.
  • inspector/front-end/RequestHeadersView.js: Removed.
  • inspector/front-end/RequestJSONView.js: Removed.
  • inspector/front-end/RequestPreviewView.js: Removed.
  • inspector/front-end/RequestResponseView.js: Removed.
  • inspector/front-end/RequestTimingView.js: Removed.
  • inspector/front-end/RequestView.js: Removed.
  • inspector/front-end/Resource.js: Removed.
  • inspector/front-end/ResourceScriptMapping.js: Removed.
  • inspector/front-end/ResourceTreeModel.js: Removed.
  • inspector/front-end/ResourceType.js: Removed.
  • inspector/front-end/ResourceUtils.js: Removed.
  • inspector/front-end/ResourceView.js: Removed.
  • inspector/front-end/ResourceWebSocketFrameView.js: Removed.
  • inspector/front-end/ResourcesPanel.js: Removed.
  • inspector/front-end/RevisionHistoryView.js: Removed.
  • inspector/front-end/RuntimeModel.js: Removed.
  • inspector/front-end/SASSSourceMapping.js: Removed.
  • inspector/front-end/ScopeChainSidebarPane.js: Removed.
  • inspector/front-end/Script.js: Removed.
  • inspector/front-end/ScriptFormatter.js: Removed.
  • inspector/front-end/ScriptFormatterWorker.js: Removed.
  • inspector/front-end/ScriptSnippetModel.js: Removed.
  • inspector/front-end/ScriptsNavigator.js: Removed.
  • inspector/front-end/ScriptsPanel.js: Removed.
  • inspector/front-end/ScriptsPanelDescriptor.js: Removed.
  • inspector/front-end/ScriptsSearchScope.js: Removed.
  • inspector/front-end/SearchController.js: Removed.
  • inspector/front-end/Section.js: Removed.
  • inspector/front-end/Settings.js: Removed.
  • inspector/front-end/SettingsScreen.js: Removed.
  • inspector/front-end/ShortcutsScreen.js: Removed.
  • inspector/front-end/ShowMoreDataGridNode.js: Removed.
  • inspector/front-end/SidebarOverlay.js: Removed.
  • inspector/front-end/SidebarPane.js: Removed.
  • inspector/front-end/SidebarTreeElement.js: Removed.
  • inspector/front-end/SidebarView.js: Removed.
  • inspector/front-end/SimpleWorkspaceProvider.js: Removed.
  • inspector/front-end/SnippetJavaScriptSourceFrame.js: Removed.
  • inspector/front-end/SnippetStorage.js: Removed.
  • inspector/front-end/SoftContextMenu.js: Removed.
  • inspector/front-end/SourceCSSTokenizer.js: Removed.
  • inspector/front-end/SourceCSSTokenizer.re2js: Removed.
  • inspector/front-end/SourceFrame.js: Removed.
  • inspector/front-end/SourceHTMLTokenizer.js: Removed.
  • inspector/front-end/SourceHTMLTokenizer.re2js: Removed.
  • inspector/front-end/SourceJavaScriptTokenizer.js: Removed.
  • inspector/front-end/SourceJavaScriptTokenizer.re2js: Removed.
  • inspector/front-end/SourceMap.js: Removed.
  • inspector/front-end/SourceMapping.js: Removed.
  • inspector/front-end/SourceTokenizer.js: Removed.
  • inspector/front-end/Spectrum.js: Removed.
  • inspector/front-end/SplitView.js: Removed.
  • inspector/front-end/StatusBarButton.js: Removed.
  • inspector/front-end/StyleSheetOutlineDialog.js: Removed.
  • inspector/front-end/StylesSidebarPane.js: Removed.
  • inspector/front-end/StylesSourceMapping.js: Removed.
  • inspector/front-end/SuggestBox.js: Removed.
  • inspector/front-end/TabbedEditorContainer.js: Removed.
  • inspector/front-end/TabbedPane.js: Removed.
  • inspector/front-end/TestController.js: Removed.
  • inspector/front-end/TextEditor.js: Removed.
  • inspector/front-end/TextEditorHighlighter.js: Removed.
  • inspector/front-end/TextEditorModel.js: Removed.
  • inspector/front-end/TextPrompt.js: Removed.
  • inspector/front-end/TextUtils.js: Removed.
  • inspector/front-end/TimelineFrameController.js: Removed.
  • inspector/front-end/TimelineGrid.js: Removed.
  • inspector/front-end/TimelineManager.js: Removed.
  • inspector/front-end/TimelineModel.js: Removed.
  • inspector/front-end/TimelineOverviewPane.js: Removed.
  • inspector/front-end/TimelinePanel.js: Removed.
  • inspector/front-end/TimelinePanelDescriptor.js: Removed.
  • inspector/front-end/TimelinePresentationModel.js: Removed.
  • inspector/front-end/Toolbar.js: Removed.
  • inspector/front-end/TopDownProfileDataGridTree.js: Removed.
  • inspector/front-end/UISourceCode.js: Removed.
  • inspector/front-end/UISourceCodeFrame.js: Removed.
  • inspector/front-end/UIString.js: Removed.
  • inspector/front-end/UIUtils.js: Removed.
  • inspector/front-end/UglifyJS/parse-js.js: Removed.
  • inspector/front-end/UserAgentSupport.js: Removed.
  • inspector/front-end/UserMetrics.js: Removed.
  • inspector/front-end/View.js: Removed.
  • inspector/front-end/ViewportControl.js: Removed.
  • inspector/front-end/WatchExpressionsSidebarPane.js: Removed.
  • inspector/front-end/WebKit.qrc: Removed.
  • inspector/front-end/WorkerManager.js: Removed.
  • inspector/front-end/WorkersSidebarPane.js: Removed.
  • inspector/front-end/Workspace.js: Removed.
  • inspector/front-end/ace/LICENSE.txt: Removed.
  • inspector/front-end/ace/ace.js: Removed.
  • inspector/front-end/ace/acedevtools.css: Removed.
  • inspector/front-end/ace/mode_css.js: Removed.
  • inspector/front-end/ace/mode_html.js: Removed.
  • inspector/front-end/ace/mode_javascript.js: Removed.
  • inspector/front-end/ace/theme_textmate.js: Removed.
  • inspector/front-end/auditsPanel.css: Removed.
  • inspector/front-end/breadcrumbList.css: Removed.
  • inspector/front-end/breakpointsList.css: Removed.
  • inspector/front-end/buildSystemOnly.js: Removed.
  • inspector/front-end/canvasProfiler.css: Removed.
  • inspector/front-end/cm/LICENSE: Removed.
  • inspector/front-end/cm/closebrackets.js: Removed.
  • inspector/front-end/cm/cmdevtools.css: Removed.
  • inspector/front-end/cm/codemirror.css: Removed.
  • inspector/front-end/cm/codemirror.js: Removed.
  • inspector/front-end/cm/css.js: Removed.
  • inspector/front-end/cm/htmlmixed.js: Removed.
  • inspector/front-end/cm/javascript.js: Removed.
  • inspector/front-end/cm/matchbrackets.js: Removed.
  • inspector/front-end/cm/xml.js: Removed.
  • inspector/front-end/cssNamedFlows.css: Removed.
  • inspector/front-end/dataGrid.css: Removed.
  • inspector/front-end/dialog.css: Removed.
  • inspector/front-end/elementsPanel.css: Removed.
  • inspector/front-end/externs.js: Removed.
  • inspector/front-end/filteredItemSelectionDialog.css: Removed.
  • inspector/front-end/flameChart.css: Removed.
  • inspector/front-end/heapProfiler.css: Removed.
  • inspector/front-end/helpScreen.css: Removed.
  • inspector/front-end/indexedDBViews.css: Removed.
  • inspector/front-end/inspector.css: Removed.
  • inspector/front-end/inspector.html: Removed.
  • inspector/front-end/inspector.js: Removed.
  • inspector/front-end/inspectorCommon.css: Removed.
  • inspector/front-end/inspectorSyntaxHighlight.css: Removed.
  • inspector/front-end/jsdifflib.js: Removed.
  • inspector/front-end/navigatorView.css: Removed.
  • inspector/front-end/networkLogView.css: Removed.
  • inspector/front-end/networkPanel.css: Removed.
  • inspector/front-end/panelEnablerView.css: Removed.
  • inspector/front-end/popover.css: Removed.
  • inspector/front-end/profilesPanel.css: Removed.
  • inspector/front-end/resourceView.css: Removed.
  • inspector/front-end/resourcesPanel.css: Removed.
  • inspector/front-end/revisionHistory.css: Removed.
  • inspector/front-end/scriptsPanel.css: Removed.
  • inspector/front-end/sidebarPane.css: Removed.
  • inspector/front-end/spectrum.css: Removed.
  • inspector/front-end/splitView.css: Removed.
  • inspector/front-end/tabbedPane.css: Removed.
  • inspector/front-end/test-runner.html: Removed.
  • inspector/front-end/textEditor.css: Removed.
  • inspector/front-end/textPrompt.css: Removed.
  • inspector/front-end/timelinePanel.css: Removed.
  • inspector/front-end/treeoutline.js: Removed.
  • inspector/front-end/utilities.js: Removed.
5:07 PM Changeset in webkit [157277] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add failing expectations to some tests on Mac Lion.

  • platform/mac-lion/TestExpectations:
5:05 PM Changeset in webkit [157276] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix build.

  • Interfaces/WebKit.idl:

Oops, didn't mean to remove the uuid for WebURLResponse.

5:05 PM Changeset in webkit [157275] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

Web Inspector: Remove the old front-end from WebKit
​https://bugs.webkit.org/show_bug.cgi?id=122295

Patch by Marcelo Morais <​m.morais@samsung.com> on 2013-10-10
Reviewed by Timothy Hatcher.

.:

  • Source/PlatformGTK.cmake: Removed. This file was using files from the

old inspector, not needed anymore.

Source/WebCore:

Updating the project files to remove all references from the old
inspector front-end.

  • WebCore.vcxproj/WebCore.vcxproj: Removed the references for the old

inspector front-end.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • inspector/compile-front-end.py: Removed.

Source/WebKit:

  • PlatformBlackBerry.cmake: Removed the references for the old

inspector front-end.

5:01 PM Changeset in webkit [157274] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix with ENABLE_DEVICE_ORIENTATION after r157215

Now, impl() return reference instead of a pointer.

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::acceleration):
(WebCore::JSDeviceMotionEvent::accelerationIncludingGravity):
(WebCore::JSDeviceMotionEvent::rotationRate):
(WebCore::JSDeviceMotionEvent::interval):
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::alpha):
(WebCore::JSDeviceOrientationEvent::beta):
(WebCore::JSDeviceOrientationEvent::gamma):
(WebCore::JSDeviceOrientationEvent::absolute):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

4:56 PM Changeset in webkit [157273] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk

[MediaStream API] update MediaStream object to match spec
​https://bugs.webkit.org/show_bug.cgi?id=121939

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/MediaStream-clone.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::ended):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::contextDestroyed):
(WebCore::MediaStream::scheduledEventTimerFired):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStream.idl:

LayoutTests:

  • TestExpectations:
  • fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
  • fast/mediastream/MediaStream-add-remove-tracks.html:
  • fast/mediastream/MediaStream-clone.html: Added.
  • fast/mediastream/MediaStreamConstructor-expected.txt:
  • fast/mediastream/MediaStreamConstructor.html:
4:51 PM Changeset in webkit [157272] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Calling setUsePresentationValue on MountainLion results in unrecognized selector
warnings
​https://bugs.webkit.org/show_bug.cgi?id=122624

Reviewed by Tim Horton.

Only call setUsePresentationValue if the scrollbar supports updates on a secondary
thread.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):

4:34 PM Changeset in webkit [157271] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Validate uniform input when setting texture sampler uniforms.
​https://bugs.webkit.org/show_bug.cgi?id=122610.

Reviewed by Dean Jackson.

Covered by Khronos Conformance Suite 1.0.2.
Specifically, conformance/uniforms/uniform-samplers-test.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):

4:31 PM Changeset in webkit [157270] by Seokju Kwon
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r157250

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

4:20 PM Changeset in webkit [157269] by commit-queue@webkit.org
  • 22 edits in trunk/Source/WebInspectorUI

Web Inspector: content views and managers should save/restore view state.
​https://bugs.webkit.org/show_bug.cgi?id=122546

To restore the same content view and sidebars when re-opening the
inspector, a cookie is saved whenever a new content view is shown
in the main content browser. Previously, this cookie was created
and restored using navigation sidebar-specific logic. This has two
major flaws: non-default sidebars for a represented object are not
restored correctly; and it centralizes storage of view-specific
state such as subview selections.

This patch adds ContentView methods for saving a key for the
view's represented object, and saving/restoring any view-specific
state as the view is shown. The 'type' field of the cookie
specifies the manager which deserializes the cookie into a
represented object.

Patch by Brian J. Burg <Brian Burg> on 2013-10-10
Reviewed by Timothy Hatcher.

  • UserInterface/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView):
(WebInspector.ApplicationCacheFrameContentView.prototype.saveToCookie):
(WebInspector.ApplicationCacheFrameContentView.prototype._maybeUpdate):
(WebInspector.ApplicationCacheFrameContentView.prototype._updateStatus):
(WebInspector.ApplicationCacheFrameContentView.prototype.updateStatus):
(WebInspector.ApplicationCacheFrameContentView.prototype._updateCallback):

  • UserInterface/ApplicationCacheManager.js:

(WebInspector.ApplicationCacheManager.prototype.networkStateUpdated):
(WebInspector.ApplicationCacheManager.prototype.applicationCacheStatusUpdated):
(WebInspector.ApplicationCacheManager.prototype.):
(WebInspector.ApplicationCacheManager.prototype.requestApplicationCache):
(WebInspector.ApplicationCacheManager.prototype.objectForCookie):
(WebInspector.ApplicationCacheManager.prototype._manifestForFrameLoaded):
(WebInspector.ApplicationCacheManager.prototype._framesWithManifestsLoaded):
(WebInspector.ApplicationCacheManager.prototype._frameManifestUpdated):

  • UserInterface/BackForwardEntry.js:

(WebInspector.BackForwardEntry):
(WebInspector.BackForwardEntry.prototype._restoreFromCookie):

  • UserInterface/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype.showContentViewForRepresentedObject):
(WebInspector.ContentBrowser.prototype.showContentView):

  • UserInterface/ContentView.js:

(WebInspector.ContentView.prototype.saveToCookie):
(WebInspector.ContentView.prototype.restoreFromCookie):

  • UserInterface/ContentViewContainer.js:

(WebInspector.ContentViewContainer.prototype.showContentView):

  • UserInterface/CookieStorageContentView.js:

(WebInspector.CookieStorageContentView.prototype.update):
(WebInspector.CookieStorageContentView.prototype.saveToCookie):
(WebInspector.CookieStorageContentView.prototype._rebuildTable):
(WebInspector.CookieStorageContentView.prototype._filterCookies):

  • UserInterface/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView.prototype.saveToCookie):

  • UserInterface/DatabaseContentView.js:

(WebInspector.DatabaseContentView.prototype.saveToCookie):
(WebInspector.DatabaseContentView.prototype._messagesClicked):

  • UserInterface/DatabaseTableContentView.js:

(WebInspector.DatabaseTableContentView):
(WebInspector.DatabaseTableContentView.prototype.saveToCookie):

  • UserInterface/FrameContentView.js:

(WebInspector.FrameContentView.prototype.saveToCookie):
(WebInspector.FrameContentView.prototype.restoreFromCookie):

  • UserInterface/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.objectForCookie):

  • UserInterface/InstrumentSidebarPanel.js:

(WebInspector.InstrumentSidebarPanel):
(WebInspector.InstrumentSidebarPanel.prototype.showTimeline):
(WebInspector.InstrumentSidebarPanel.prototype.shown):
(WebInspector.InstrumentSidebarPanel.prototype._timelinesTreeElementSelected):

  • UserInterface/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
(WebInspector.openURL):
(WebInspector._updateCurrentContentViewCookie):
(WebInspector._showContentViewForCookie.lastAttemptToRestoreFromCookie):
(WebInspector._showContentViewForCookie):
(WebInspector._resolveAndShowPendingContentViewCookie.delayedWork):
(WebInspector._resolveAndShowPendingContentViewCookie):
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.createMessageTextView):
(WebInspector.linkifyStringAsFragment):

  • UserInterface/NavigationSidebarPanel.js:
  • UserInterface/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.saveToCookie):
(WebInspector.ResourceClusterContentView.prototype.restoreFromCookie):

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
(WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._databaseWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._cookieStorageObjectWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._frameManifestAdded):

  • UserInterface/ScriptContentView.js:

(WebInspector.ScriptContentView.prototype.saveToCookie):
(WebInspector.ScriptContentView.prototype.restoreFromCookie):

  • UserInterface/StorageManager.js:

(WebInspector.StorageManager.prototype.findMatchingObjectInArray):
(WebInspector.StorageManager.prototype.objectForCookie):

  • UserInterface/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.get timelines):
(WebInspector.TimelineManager.prototype.objectForCookie):

  • UserInterface/TimelinesContentView.js:

(WebInspector.TimelinesContentView.prototype.saveToCookie):
(WebInspector.TimelinesContentView.prototype.restoreFromCookie):
(WebInspector.TimelinesContentView.prototype._makeColumnScopeBar):

4:17 PM Changeset in webkit [157268] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

Create MediaStream object with ended attribute set if all tracks that are being used on its creation are ended
​https://bugs.webkit.org/show_bug.cgi?id=122358

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.

Source/WebCore:

Spec tells that if all tracks that belongs to a new MediaStream object being created are ended,
then the ended attribute of this MediaStream must be set to true.
​http://www.w3.org/TR/mediacapture-streams/#widl-MediaStream-ended

Since there is no port supporting MediaStream yet, we are skipping this test for now.

Test: fast/mediastream/MediaStream-construct-with-ended-tracks.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::createFromSourceVectors):
(WebCore::MediaStream::create):

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

  • platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

  • platform/mediastream/MediaStreamDescriptor.h:
  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::createMediaStream):

LayoutTests:

Since there is no port supporting MediaStream yet, we are skipping this test for now.

  • TestExpectations:
  • fast/mediastream/MediaStream-construct-with-ended-tracks.html: Added.
4:16 PM Changeset in webkit [157267] by oliver@apple.com
  • 13 edits in trunk

Further improve ArrayIterator performance
​https://bugs.webkit.org/show_bug.cgi?id=122575

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Add an assembly thunk for ArrayIterator.@@next so that we
can avoid marshalling costs when iterating arrays.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::loadSpecificClassArgument):

  • jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):

  • runtime/Intrinsic.h:
  • runtime/JSArrayIterator.h:

(JSC::JSArrayIterator::offsetOfIterationKind):
(JSC::JSArrayIterator::offsetOfIteratedObject):
(JSC::JSArrayIterator::offsetOfNextIndex):

  • runtime/JSCJSValue.h:

(JSC::JSValue::offsetOfPayload):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::iteratorResultStructureOffset):

  • runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

LayoutTests:

Add a few new tests to make sure the new asm thunk correctly
handles non-arrays.

  • js/array-iterators-expected.txt:
  • js/script-tests/array-iterators.js:
4:10 PM Changeset in webkit [157266] by msaboff@apple.com
  • 17 edits in trunk

transition cti_op_* methods returning int to JIT operations.
​https://bugs.webkit.org/show_bug.cgi?id=122563

Reviewed by Oliver Hunt.

Moved serveral operationCompare* functions from DFGOperations to JITOperations as well as changing
dfgConvertJSValueToBoolean to operationConvertJSValueToBoolean so that they can be shared with the baseline JIT.
Added JITOperation operationHasProperty(). Added needed callOperation helpers and transitioned baseline JIT code
to use the new operations.

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_next_pname):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
4:05 PM Changeset in webkit [157265] by aestes@apple.com
  • 16 edits
    2 adds in trunk

Add SPI for telling WebKit to prefer pictograph glyphs over monochrome ones
​https://bugs.webkit.org/show_bug.cgi?id=122608

Reviewed by Dan Bernstein.

Based on patches by Dan Bernstein.

Source/WebCore:

Test: fonts/font-fallback-prefers-pictographs.html

Created a mechanism to append a font to the end of a font's fallback
list, before the system fallback list. This mechanism is used when
Settings::fontFallbackPrefersPictographs() is true to insert a
pictograph font ahead of a monochrome one from the system fallback list.

  • WebCore.exp.in: Moved

ZN7WebCore8Settings33setFontFallbackPrefersPictographsEb outside of
an iOS platform guard.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::fallbackFontDataCount): Retuned 1 if
pictograph fonts are preferred.
(WebCore::CSSFontSelector::getFallbackFontData): Returned the
pictograph font's FontData if it is preferred.

  • css/CSSFontSelector.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialized
m_fontFallbackPrefersPictographs to false.
(WebCore::Settings::setFontFallbackPrefersPictographs): Set
m_fontFallbackPrefersPictographs and called
Page::setNeedsRecalcStyleInAllFrames().

  • page/Settings.h:

(WebCore::Settings::fontFallbackPrefersPictographs):

  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::realizeFontDataAt): Realized the selector's
fallback font if necessary.

  • platform/graphics/FontSelector.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree): Removed iOS platform guards.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setFontFallbackPrefersPictographs): Set the
corresponding WebCore::Setting.

  • testing/InternalSettings.h: Defined an internal setting for the test.
  • testing/InternalSettings.idl: Ditto.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _setFontFallbackPrefersPictographs:]): Called
WebCore::Settings::setFontFallbackPrefersPictographs().

  • WebView/WebViewPrivate.h:

LayoutTests:

  • fonts/font-fallback-prefers-pictographs-expected.html: Added.
  • fonts/font-fallback-prefers-pictographs.html: Added.
3:57 PM Changeset in webkit [157264] by fpizlo@apple.com
  • 24 edits
    2 adds in trunk/Source/JavaScriptCore

OSR exit using llvm.webkit.stackmap should pass more tests
​https://bugs.webkit.org/show_bug.cgi?id=122518

Reviewed by Mark Hahnenberg.

  • Make the X86Assembler capable of dealing with all XMM registers.


  • Make the StackMaps code on WebKit's side capable of dealing with XMM registers.


  • Factor out most of the smarts of StackMaps::Location into a self-contained object. Previously you needed both StackMaps::Location and a StackMaps reference to do most things since the Location might have referred to a constant. Now you can just get a self-contained Location object.


  • Fix a bug where OSR exit generation thunk generator was assuming that the call frame register is already in argumentGPR0. In the future, the call frame will just be the machine FP and we won't have to do anything special. But for now the "call frame" is just a normal value in LLVM IR and may end up in any register. Make the OSR exit generation thunk generator polymorphic over the call frame argument's Location.


  • Move the stuff that depends on the polymorphic OSR exit generation thunk generator into the finalizer, since generating and linking one of those thunks requires a cache flush and we need to do that on the main thread.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::firstRegister):
(JSC::ARMv7Assembler::lastRegister):
(JSC::ARMv7Assembler::firstFPRegister):
(JSC::ARMv7Assembler::lastFPRegister):

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::firstFPRegister):
(JSC::AbstractMacroAssembler::lastFPRegister):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::nextFPRegister):

  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerX86Common.h:
  • assembler/X86Assembler.h:

(JSC::X86Assembler::firstFPRegister):
(JSC::X86Assembler::lastFPRegister):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLExitThunkGenerator.cpp:

(JSC::FTL::ExitThunkGenerator::emitThunk):
(JSC::FTL::ExitThunkGenerator::emitThunks):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLocation.cpp: Added.

(JSC::FTL::Location::forStackmaps):
(JSC::FTL::Location::dump):
(JSC::FTL::Location::involvesGPR):
(JSC::FTL::Location::isGPR):
(JSC::FTL::Location::gpr):
(JSC::FTL::Location::isFPR):
(JSC::FTL::Location::fpr):
(JSC::FTL::Location::restoreInto):
(WTF::printInternal):

  • ftl/FTLLocation.h: Added.

(JSC::FTL::Location::Location):
(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::forIndirect):
(JSC::FTL::Location::forConstant):
(JSC::FTL::Location::kind):
(JSC::FTL::Location::hasDwarfRegNum):
(JSC::FTL::Location::dwarfRegNum):
(JSC::FTL::Location::hasOffset):
(JSC::FTL::Location::offset):
(JSC::FTL::Location::hasConstant):
(JSC::FTL::Location::constant):
(JSC::FTL::Location::operator!):
(JSC::FTL::Location::isHashTableDeletedValue):
(JSC::FTL::Location::operator==):
(JSC::FTL::Location::hash):
(JSC::FTL::LocationHash::hash):
(JSC::FTL::LocationHash::equal):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):

  • ftl/FTLSaveRestore.cpp:

(JSC::FTL::bytesForFPRs):
(JSC::FTL::requiredScratchMemorySizeInBytes):
(JSC::FTL::offsetOfFPR):
(JSC::FTL::saveAllRegisters):
(JSC::FTL::restoreAllRegisters):

  • ftl/FTLSaveRestore.h:
  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Location::restoreInto):

  • ftl/FTLStackMaps.h:
  • ftl/FTLState.h:
  • ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationWithoutStackMapThunkGenerator):
(JSC::FTL::osrExitGenerationWithStackMapThunkGenerator):

  • ftl/FTLThunks.h:

(JSC::FTL::generateIfNecessary):
(JSC::FTL::Thunks::getOSRExitGenerationThunk):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
3:56 PM Changeset in webkit [157263] by andersca@apple.com
  • 9 edits
    4 deletes in trunk/Source/WebKit

Remove WebScrollBar
​https://bugs.webkit.org/show_bug.cgi?id=122623

Reviewed by Brent Fulgham.

Source/WebKit:

Remove files from VS projects.

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:

Source/WebKit/win:

WebScrollBar isn't used by anyone, remove it.

  • ForEachCoClass.h:
  • Interfaces/IWebScrollBarDelegatePrivate.idl: Removed.
  • Interfaces/IWebScrollBarPrivate.idl: Removed.
  • Interfaces/WebKit.idl:
  • WebKitClassFactory.cpp:

(WebKitClassFactory::CreateInstance):

  • WebScrollBar.cpp: Removed.
  • WebScrollBar.h: Removed.
3:39 PM Changeset in webkit [157262] by fpizlo@apple.com
  • 5 edits in trunk

Tools: Make sure that DataTypes.h is in the binary drop.

Rubber stamped by Michael Saboff.

  • Scripts/export-llvm-build:

WebKitLibraries: Update the binary drops to the latest version of LLVM, built without -fvisibility=hidden
now that we have soft linking. Also include DataTypes.h in the drop.

Rubber stamped by Michael Saboff.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
3:27 PM Changeset in webkit [157261] by Beth Dakin
  • 2 edits in trunk/Source/WebKit/win

Build fix after ​http://trac.webkit.org/changeset/157253

  • WebScrollBar.h:
3:19 PM Changeset in webkit [157260] by fpizlo@apple.com
  • 24 edits
    16 adds
    2 deletes in trunk

FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
​https://bugs.webkit.org/show_bug.cgi?id=122566

Source/JavaScriptCore:

Reviewed by Mark Rowe.

The JSC project now builds a libllvmForJSC.dylib. If FTL is enabled, this
gets copied into JavaScriptCore.framework/Versions/A/Libraries. JSC will
load the dylib by finding it using NSBundle APIs and then doing dlopen().
That will only happen lazily, when something happens that requires LLVM.

This mostly takes care of LLVM static initialization overhead by deferring
it until it's really needed.

This takes care of LLVM's exit-time destructors because inside
libllvmForJSC.dylib, we override cxa_atexit.

  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/LLVMForJSC.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • disassembler/LLVMDisassembler.cpp:

(JSC::tryToDisassembleWithLLVM):

  • ftl/FTLAbbreviatedTypes.h:
  • ftl/FTLAbbreviations.h:

(JSC::FTL::voidType):
(JSC::FTL::int1Type):
(JSC::FTL::int8Type):
(JSC::FTL::int16Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::floatType):
(JSC::FTL::doubleType):
(JSC::FTL::pointerType):
(JSC::FTL::structType):
(JSC::FTL::functionType):
(JSC::FTL::typeOf):
(JSC::FTL::mdKindID):
(JSC::FTL::mdString):
(JSC::FTL::mdNode):
(JSC::FTL::setMetadata):
(JSC::FTL::addFunction):
(JSC::FTL::setLinkage):
(JSC::FTL::setFunctionCallingConv):
(JSC::FTL::getParam):
(JSC::FTL::constInt):
(JSC::FTL::constReal):
(JSC::FTL::constIntToPtr):
(JSC::FTL::constBitCast):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildPhi):
(JSC::FTL::addIncoming):
(JSC::FTL::buildAlloca):
(JSC::FTL::buildAdd):
(JSC::FTL::buildSub):
(JSC::FTL::buildMul):
(JSC::FTL::buildDiv):
(JSC::FTL::buildRem):
(JSC::FTL::buildNeg):
(JSC::FTL::buildFAdd):
(JSC::FTL::buildFSub):
(JSC::FTL::buildFMul):
(JSC::FTL::buildFDiv):
(JSC::FTL::buildFRem):
(JSC::FTL::buildFNeg):
(JSC::FTL::buildAnd):
(JSC::FTL::buildOr):
(JSC::FTL::buildXor):
(JSC::FTL::buildShl):
(JSC::FTL::buildAShr):
(JSC::FTL::buildLShr):
(JSC::FTL::buildNot):
(JSC::FTL::buildLoad):
(JSC::FTL::buildStore):
(JSC::FTL::buildSExt):
(JSC::FTL::buildZExt):
(JSC::FTL::buildFPToSI):
(JSC::FTL::buildFPToUI):
(JSC::FTL::buildSIToFP):
(JSC::FTL::buildUIToFP):
(JSC::FTL::buildIntCast):
(JSC::FTL::buildFPCast):
(JSC::FTL::buildIntToPtr):
(JSC::FTL::buildPtrToInt):
(JSC::FTL::buildBitCast):
(JSC::FTL::buildICmp):
(JSC::FTL::buildFCmp):
(JSC::FTL::buildCall):
(JSC::FTL::setTailCall):
(JSC::FTL::buildExtractValue):
(JSC::FTL::buildSelect):
(JSC::FTL::buildBr):
(JSC::FTL::buildCondBr):
(JSC::FTL::buildSwitch):
(JSC::FTL::addCase):
(JSC::FTL::buildRet):
(JSC::FTL::buildUnreachable):
(JSC::FTL::dumpModule):
(JSC::FTL::verifyModule):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLFail.cpp:

(JSC::FTL::fail):

  • ftl/FTLJITCode.h:
  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLink.cpp:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::appendTo):

  • ftl/FTLState.cpp:

(JSC::FTL::State::State):
(JSC::FTL::State::~State):

  • ftl/WebKitLLVMLibraryAnchor.cpp: Removed.
  • jsc.cpp:

(jscmain):

  • llvm: Added.
  • llvm/InitializeLLVM.cpp: Added.

(JSC::initializeLLVM):

  • llvm/InitializeLLVM.h: Added.
  • llvm/InitializeLLVMMac.mm: Added.

(JSC::initializeLLVMImpl):

  • llvm/InitializeLLVMPOSIX.cpp: Added.

(JSC::initializeLLVMPOSIX):

  • llvm/InitializeLLVMPOSIX.h: Added.
  • llvm/LLVMAPI.cpp: Added.
  • llvm/LLVMAPI.h: Added.
  • llvm/LLVMAPIFunctions.h: Added.
  • llvm/LLVMHeaders.h: Added.
  • llvm/library: Added.
  • llvm/library/LLVMAnchor.cpp: Added.
  • llvm/library/LLVMExports.cpp: Added.

(initializeAndGetJSCLLVMAPI):

  • llvm/library/LLVMOverrides.cpp: Added.

(cxa_atexit):

  • llvm/library/config_llvm.h: Added.
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/Options.h:

Source/WTF:

Reviewed by Mark Rowe.

Remove all LLVM stuff from WTF since to get LLVM you need to soft-link and it's
entirely the responsibility of JSC to do that.

Also fixed an export goof that I found after fixing the weak thingy script in JSC.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/LLVMHeaders.h: Removed.
  • wtf/text/CString.h:

(WTF::CStringHash::hash):

Tools:

Reviewed by Mark Rowe.

  • Scripts/configure-llvm:
3:16 PM Changeset in webkit [157259] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Add timeout annotation to gtk-wk2-specific expectation for
editing/spelling/spellcheck-paste.html.

  • platform/gtk-wk2/TestExpectations:
3:03 PM Changeset in webkit [157258] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

currentThis and currentArguments crash if called from outside a callback
​https://bugs.webkit.org/show_bug.cgi?id=122620

Reviewed by Filip Pizlo.

The documentation for these methods claims that they will return nil if called
from somewhere other than an API callback, but currently they both crash.

  • API/JSContext.mm:

(+[JSContext currentThis]):
(+[JSContext currentArguments]):

  • API/tests/testapi.mm:
3:00 PM Changeset in webkit [157257] by fpizlo@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix changelog entry order.

2:59 PM Changeset in webkit [157256] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CallbackData unnecessarily caches the JSValue for currentThis
​https://bugs.webkit.org/show_bug.cgi?id=122616

Patch by Mark Hahnenberg <​mhahnenberg@apple.com> on 2013-10-10
Reviewed by Oliver Hunt.

CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores.
+[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for
CallbackData to do its own caching.

  • API/JSContext.mm:

(+[JSContext currentThis]):
(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):

  • API/JSContextInternal.h:
2:50 PM Changeset in webkit [157255] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused attribute in CoordinatedTile class
​https://bugs.webkit.org/show_bug.cgi?id=122619

Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Noam Rosenthal.

No new tests, covered by existing ones.

  • platform/graphics/texmap/coordinated/CoordinatedTile.h: Remove

m_localBuffer.

2:47 PM Changeset in webkit [157254] by Csaba Osztrogonác
  • 5 edits
    5 adds in trunk/Source/WebKit2

[WK2][Soup] Add platform specific stubs for NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=110115

Reviewed by Carlos Garcia Campos.

Original patch by Balazs Kelemen <​kbalazs@webkit.org> and Kwang Yul Seo <​skyul@company100.net>.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • NetworkProcess/gtk/NetworkProcessSoup.cpp: Added.

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetCacheModel):
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
Stubs.
(WebKit::NetworkProcess::clearCacheForAllOrigins):
(WebKit::NetworkProcess::platformTerminate):

  • NetworkProcess/soup/NetworkResourceLoadSchedulerSoup.cpp: Added.

(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
Added platform default based on the comment in ResourceRequestSoup.cpp.

  • UIProcess/Network/soup/NetworkProcessProxySoup.cpp: Added.

(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
Stub.

  • UIProcess/soup/WebContextSoup.cpp: Added.

(WebKit::WebContext::platformInitializeNetworkProcess):
Stub.

2:44 PM Changeset in webkit [157253] by Beth Dakin
  • 28 edits in trunk/Source

Scrollbars are updated on the main thread rather than the scrolling thread
(causing scroll bars not to appear/update quickly in some cases)
​https://bugs.webkit.org/show_bug.cgi?id=122585
-and corresponding-
<rdar://problem/10710775>

Reviewed by Simon Fraser.

Source/WebCore:

This patch does a few things in order to allow scrollbars to be updated on the
scrolling thread:

  1. This patch adds the ability to know if the lower-level APIs necessary to get

this to work right are available, AND if the content is actually capable of taking
advantage of this feature. This is currently implemented as
Scrollbar::supportsUpdateOnSecondaryThread() which makes use of a new
ScrollableArea function called updatesScrollLayerPositionOnMainThread()

  1. To update on the scrolling thread, the scrolling tree needs to know about the

ScrollbarPainters.

  1. Once it knows about them, it should update the presentation value whenever the

layer position changes.

  1. Presentation value is basically the same thing as double value. There is a bit

of code we maintain currently to compute that. This patch moves that code to a
static function on ScrollableArea that can be called from both the main thread and
the scrolling thread.

  1. ScrollbarPainter API needs to know about the layers we have created for the

vertical and horizontal scrollbars, then they will use those layers and the
presentation value that we set on the scrolling thread to move the layers around.

This is part of #1 above.

  • page/FrameView.cpp:

(WebCore::FrameView::updatesScrollLayerPositionOnMainThread):

  • page/FrameView.h:

This is part of #2. ScrollingStateScrollingNodes now have vertical and horizontal
ScrollbarPainters for Mac only.

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):

  • page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::verticalScrollbarPainter):
(WebCore::ScrollingStateScrollingNode::horizontalScrollbarPainter):

Also part of #2. Make sure to set the ScrollbarPainters for scrolling nodes when
appropriate.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):

Implement this function that was just stubbed out before. This is part of #5 in
that is will allow the ScrollbarPainter API to know about any layer changes.
(WebCore::ScrollingCoordinatorMac::scrollableAreaScrollbarLayerDidChange):

Back to #2, making sure we properly set the ScrollbarPainters to send over to the
scrolling thread.
(WebCore::ScrollingCoordinatorMac::setScrollbarPaintersForNode):

  • page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

(WebCore::ScrollingStateScrollingNode::setScrollbarPainters):

This code achieves #3. It uses new ScrollbarPainter API to adjust the position of
the scrollbars from the scrolling thread.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

This is for #5. ScrollbarPainter needs to know about our scrollbar layers.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::verticalScrollbarLayerDidChange):
(WebCore::ScrollAnimator::horizontalScrollbarLayerDidChange):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::verticalScrollbarLayerDidChange):
(WebCore::ScrollableArea::horizontalScrollbarLayerDidChange):

This is for #4. This code computes the scrollbar’s value and current overhang
amount.
(WebCore::ScrollableArea::computeScrollbarValueAndOverhang):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::layerForHorizontalScrollbar):
(WebCore::ScrollableArea::layerForVerticalScrollbar):
(WebCore::ScrollableArea::layerForScrolling):

This is for #1. We need to know if we have the ability to update scrollbars on a
different thread. We can do that only on certain versions of the OS, only when
threaded scrolling is enabled, and only when the current page is actually using
the scrolling thread to scroll.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):

  • platform/Scrollbar.h:
  • platform/ScrollbarThemeClient.h:

New ScrollbarPainter APIs.

  • platform/mac/NSScrollerImpDetails.h:

This is for #5, letting the ScrollbarPainter API know about the layers.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate convertRectToLayer:]):
(-[WebScrollbarPainterDelegate shouldUseLayerPerPartForScrollerImp:]):

Before we kick off a scroll animation, set the current painting characteristics so
they are up-to-date in case we are scrolling on the scrolling thread.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::verticalScrollbarLayerDidChange):
(WebCore::ScrollAnimatorMac::horizontalScrollbarLayerDidChange):

Only paint the scrollbars through ScrollbarThemeMac if they are NOT being updated
by the scrolling thread.

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::setCurrentPaintCharacteristics):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

Back to #1.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updatesScrollLayerPositionOnMainThread):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

  • rendering/RenderListBox.h:

Source/WebKit2:

New pure virtual function.

  • WebProcess/Plugins/PDF/PDFPlugin.h:
2:34 PM Changeset in webkit [157252] by Brent Fulgham
  • 6 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r157228

The changes in r157228 trigger a bug in VS2010. This patch works around the compiler bug
to allow this platform to build.

  • dom/Range.cpp: Move implementation to header file.
  • dom/Range.h: Inline the method.
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open): Add stub method (with pointer arguments) to call the real
method with references.

  • page/DOMWindow.h: Declare stub method taking pointer arguments to avoid compiler bug.
  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend): Use work-around method when building under
the buggy version of Visual Studio.

2:34 PM Changeset in webkit [157251] by Csaba Osztrogonác
  • 4 edits
    1 move
    2 adds in trunk/Source/WebKit2

[WK2] Port RemoteNetworkingContext for Soup
​https://bugs.webkit.org/show_bug.cgi?id=110097

Reviewed by Darin Adler.

Original patch by Balazs Kelemen <​kbalazs@webkit.org> and Kwang Yul Seo <​skyul@company100.net>.

This should be a cross-platform interface so I lifted the header from
the mac directory. Removed mac specific arguments from constructor,
added setters instead. Moved platform things behind ifdefs and added
Soup specific bits.

The following things were fixed by Csaba Osztrogonác:

  • solved conflicts in project.pbxproj
  • removed the change in the non-existent SyncNetworkResourceLoader.cpp
  • marked RemoteNetworkingContext class as FINAL
  • reordered the members for platform specific initialization
  • added initializers to m_needsSiteSpecificQuirks and m_localFileContentSniffingEnabled members on PLATFORM(MAC)
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

  • NetworkProcess/RemoteNetworkingContext.h: Renamed from Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h.

(WebKit::RemoteNetworkingContext::create):
(WebKit::RemoteNetworkingContext::RemoteNetworkingContext):
(WebKit::RemoteNetworkingContext::setNeedsSiteSpecificQuirks):
(WebKit::RemoteNetworkingContext::setLocalFileContentSniffingEnabled):

  • NetworkProcess/mac/RemoteNetworkingContext.mm:
  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp: Added.

(WebKit::RemoteNetworkingContext::~RemoteNetworkingContext):
(WebKit::RemoteNetworkingContext::isValid):
(WebKit::RemoteNetworkingContext::initiatingPageID):
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):

  • WebKit2.xcodeproj/project.pbxproj:
2:11 PM Changeset in webkit [157250] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Make all functions of EventDispatcher static
​https://bugs.webkit.org/show_bug.cgi?id=122591

Reviewed by Antti Koivisto.

Now that EventDispatchMediator is gone, we don't have to have an EventDispatcher object.
Turn EventDispatcher into an empty class with a bunch of static functions.

We can convert it to a namespace or whatever later.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:
1:50 PM Changeset in webkit [157249] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CallbackData unnecessarily caches the JSValue for currentThis
​https://bugs.webkit.org/show_bug.cgi?id=122616

Reviewed by Oliver Hunt.

CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores.
+[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for
CallbackData to do its own caching.

  • API/JSContext.mm:

(+[JSContext currentThis]):
(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):

  • API/JSContextInternal.h:
1:42 PM Changeset in webkit [157248] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Convert some OwnPtr/PassOwnPtr in CoordinatedGraphics code to std::unique_ptr's
​https://bugs.webkit.org/show_bug.cgi?id=122614

Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Anders Carlsson.

Source/WebCore:

No new tests, covered by existing ones.

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::adjustContentsScale):
(WebCore::CoordinatedGraphicsLayer::createBackingStore):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::ensureRootLayer):
(WebCore::CoordinatedGraphicsScene::purgeGLResources):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
  • platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:

(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):

  • platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h:
  • platform/graphics/texmap/coordinated/UpdateAtlas.cpp:

(WebCore::UpdateAtlas::buildLayoutIfNeeded):
(WebCore::UpdateAtlas::didSwapBuffers):

  • platform/graphics/texmap/coordinated/UpdateAtlas.h:

(WebCore::UpdateAtlas::isInUse):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
1:15 PM Changeset in webkit [157247] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebCore

Store uniform type information in WebGLUniformationLocation.
​https://bugs.webkit.org/show_bug.cgi?id=122607.

Reviewed by Dean Jackson.

Covered by Khronos Conformance Suite 1.0.2.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):

  • html/canvas/WebGLUniformLocation.cpp:

(WebCore::WebGLUniformLocation::create):
(WebCore::WebGLUniformLocation::WebGLUniformLocation):
(WebCore::WebGLUniformLocation::type):

  • html/canvas/WebGLUniformLocation.h:
1:05 PM Changeset in webkit [157246] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

Web Inspector: Remove the old front-end from WebKit
​https://bugs.webkit.org/show_bug.cgi?id=122295

Patch by Marcelo Morais <​m.morais@samsung.com> on 2013-10-10
Reviewed by Timothy Hatcher.

Skipping the tests of the old Inspector UI for all ports.

  • TestExpectations:
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac-lion/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
1:05 PM Changeset in webkit [157245] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r157203): WebKit crashes after dispatching gesture event
​https://bugs.webkit.org/show_bug.cgi?id=122615

Reviewed by Anders Carlsson.

Don't release the event until the end of the function where we call member functions on it.

  • dom/Node.cpp:

(WebCore::Node::dispatchGestureEvent):

1:04 PM Changeset in webkit [157244] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out r157193. It broke some builds.

1:02 PM Changeset in webkit [157243] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

generate-message-receiver.py can't handle nested #ifs
​https://bugs.webkit.org/show_bug.cgi?id=121877

Reviewed by Alexey Proskuryakov.

  • Scripts/webkit2/parser.py:

(parse): Exit early until proper fix instead of generating buggy output.

12:49 PM Changeset in webkit [157242] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Move the rest of EventRetargeter functions to EventPath
​https://bugs.webkit.org/show_bug.cgi?id=122586

Reviewed by Andreas Kling.

Moved the rest of EventRetargeter functiosn either static local or EventPath member functions.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPostProcess):

  • dom/EventDispatcher.h:
  • dom/EventRetargeter.cpp:

(WebCore::EventPath::EventPath):
(WebCore::calculateAdjustedNodes): Made static local. Also takes const EventPath and returns the size
to which EventPath should be shrunk; this allows us to remove EventPath::shrink.
(WebCore::updateTouchListsInEventPath): Moved and renamed from EventRetargeter::adjustTouchList.
(WebCore::EventPath::updateTouchLists): Moved and renamed from EventRetargeter::adjustForTouchEvent.
(WebCore::EventPath::setRelatedTarget): Moved.

  • dom/EventRetargeter.h:

(WebCore::eventTargetRespectingTargetRules): Renamed from EventRetargeter::eventTargetRespectingTargetRules.

12:48 PM Changeset in webkit [157241] by mrowe@apple.com
  • 33 edits in trunk

<rdar://problem/13341666> WebKit should always build against an SDK.

Have all projects default to building against the OS X Internal SDK for the Production
configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:
  • gtest/xcode/Config/ProductionProject.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
12:43 PM Changeset in webkit [157240] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics][CSS Shaders] marshal color and matrix custom filter parameters
​https://bugs.webkit.org/show_bug.cgi?id=117904

Correctly encode and decode the "matrix" and "color" custom filter parameter types.
No port currently enables this code, however with this change the relevant layout tests now pass when enabled in EFL.
Patch by Ralph Thomas <​ralpht@gmail.com> on 2013-10-10
Reviewed by Noam Rosenthal.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

12:25 PM Changeset in webkit [157239] by mrowe@apple.com
  • 4 edits in trunk/Source

Source/JavaScriptCore: <rdar://problem/13871507> JavaScriptCore fails to build with C++ 98 conformance changes

Reviewed by Andreas Kling.

  • heap/VTableSpectrum.cpp:

(JSC::VTableSpectrum::dump): strrchr returns a const char* when passed one.
Update the type of the local variable to accommodate that.

Source/WebKit2: <rdar://problem/13871522> WebKit2 fails to build with C++ 98 conformance changes

Reviewed by Andreas Kling.

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::resolveSymlinksInPath): strrchr returns a const char* when passed one.
Update the type of the local variable to accommodate that.

12:22 PM Changeset in webkit [157238] by hmuller@adobe.com
  • 4 edits in trunk/Source

[CSS Shapes] clampToUnsigned() should return unsigned, not int
​https://bugs.webkit.org/show_bug.cgi?id=122601

Source/WebCore:

Reviewed by Andreas Kling.

Corrected the return type for clampToUnsigned() in MathExtras.h. It's now unsigned.
No new tests since this is just an internal refactoring of existing code.

  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShape::marginIntervals): Use the redefined clampToUnsigned method.

Source/WTF:

Corrected the return type for clampToUnsigned() in MathExtras.h. It's now unsigned.

Reviewed by Andreas Kling.

  • wtf/MathExtras.h:

(clampToUnsigned):

11:24 AM Changeset in webkit [157237] by berto@igalia.com
  • 4 edits in trunk/LayoutTests

Unreviewed gardening.

Move the tests that only fail in wk1 to their file, and unskip the
ones that are passing in all cases.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
11:22 AM Changeset in webkit [157236] by Bem Jones-Bey
  • 13 edits
    7 copies
    1 add in trunk

[CSS Shapes] New positioning model: Shape cropped to margin box
​https://bugs.webkit.org/show_bug.cgi?id=118092

Reviewed by Alexandru Chiculita.

Source/WebCore:

Clip the shape to the margin box when it extends out the left or right
edges. Also added a few local variables to make the code easier to
read.

Tests: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref.html

csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

LayoutTests:

Add tests for shapes that extend out left/right of the margin box.

Fix polygon and image threshold tests so that they have a large enough
margin box so the shape isn't clipped.

Also update some of the top/bottom tests to have a better reference,
they should be more likely to break if the implementation fails now.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html:
11:20 AM Changeset in webkit [157235] by dbates@webkit.org
  • 6 edits in trunk/Source/WebCore

Avoid resizing the internal buffer of SharedBuffer when creating a PurgeableBuffer
​https://bugs.webkit.org/show_bug.cgi?id=122516

Reviewed by Darin Adler.

Currently when we create a PurgeableBuffer from a SharedBuffer we may
resize the internal buffer of the SharedBuffer so that it can fit the
concatenated contents of all of its segments before copying this
internal buffer to the internal buffer of the PurgeableBuffer. Instead,
we can avoid resizing the internal buffer of SharedBuffer by allocating
a PurgeableBuffer and then copying the internal buffer of SharedBuffer
and its segments directly into it.

  • platform/PurgeableBuffer.h:

(WebCore::PurgeableBuffer::createUninitialized): Add inline implementation
when building with ENABLE_PURGEABLE_MEMORY disabled.

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::createPurgeableBuffer): Implemented in terms of
SharedBuffer::{copyBufferAndClear, createUninitialized}().
(WebCore::SharedBuffer::copyBufferAndClear): Added.
(WebCore::SharedBuffer::buffer): Moved logic to copy segments/data array to
SharedBuffer::copyBufferAndClear() and modified this function to use it.

  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::copyBufferAndClear): Renamed; formerly called SharedBuffer::copyDataArrayAndClear.

  • platform/mac/PurgeableBufferMac.cpp:

(WebCore::allocatePurgeableBuffer): Added.
(WebCore::PurgeableBuffer::createUninitialized): Added.
(WebCore::PurgeableBuffer::create): Moved logic to allocate a purgeable buffer into
PurgeableBuffer::createUninitialized() and modified this function to use it.

11:20 AM Changeset in webkit [157234] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Objective-C API: blocks aren't callable via 'new'
​https://bugs.webkit.org/show_bug.cgi?id=122561

Reviewed by Oliver Hunt.

Currently the only way for clients to vend new native objects to JavaScript code
is via factory methods in the form of exported class methods or blocks. Blocks can
be called like normal functions from JavaScript code, but they cannot be invoked
with 'new'. This would give a simple way for clients to expose constructor-like
behavior to their JavaScript code.

This patch adds the ability for blocks to be invoked as if they were a constructor.
Blocks invoked as constructors are required to return an object. If the block doesn't
return an object then an error is thrown. The 'this' object is not provided to the
block and must be created within the block itself.

This patch also unifies the native 'construct' callback used in both the C and Obj-C
APIs under the APICallbackFunction struct, similar to how we unified the 'call' callback
between ObjCCallbackFunction and JSCallbackFunction before.

This patch also adds tests to make sure that different blocks generate objects that
correctly behave when queried with instanceof. It also makes sure that the correct
JS exception is thrown when a block fails to return an object.

  • API/APICallbackFunction.h:

(JSC::APICallbackFunction::call):
(JSC::APICallbackFunction::construct):

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::getConstructData):

  • API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::constructCallback):

  • API/JSCallbackFunction.h:

(JSC::JSCallbackFunction::functionCallback):

  • API/ObjCCallbackFunction.h:

(JSC::ObjCCallbackFunction::functionCallback):
(JSC::ObjCCallbackFunction::constructCallback):

  • API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsConstructor):
(JSC::ObjCCallbackFunction::ObjCCallbackFunction):
(JSC::ObjCCallbackFunction::create):
(JSC::ObjCCallbackFunction::getConstructData):

  • API/tests/testapi.mm:
11:14 AM Changeset in webkit [157233] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. plugins/document-open.html will some times timeout.

  • platform/gtk-wk2/TestExpectations:
10:54 AM Changeset in webkit [157232] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.

  • Scripts/run-gtk-tests:

(TestRunner): skip TestInspectorServer.

10:41 AM Changeset in webkit [157231] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: VoiceOver speaking too much when group elements with tabindex=-1 are used
​https://bugs.webkit.org/show_bug.cgi?id=122574

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Tests: accessibility/negative-tabindex-does-not-expose-label.html

Elements that expose tabindex=-1 are being identified as generic focusable elements for accessibility.
Which among other things, determines whether to create an accessible name for the object.
This has the negative effect of causing VoiceOver to speak way too much information when navigating inside
a <div> with this attribute.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):

LayoutTests:

  • accessibility/negative-tabindex-does-not-expose-label-expected.txt: Added.
  • accessibility/negative-tabindex-does-not-expose-label.html: Added.
10:39 AM Changeset in webkit [157230] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove custom finalizer for Node JS wrappers.
<​https://webkit.org/b/122603>

Reviewed by Geoff Garen.

Node can just use the auto-generated finalizer, the custom one was
identical to what the generator would output.

9:38 AM Changeset in webkit [157229] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Remove duplicate entry for editing/spelling/spellcheck-paste.html.

  • platform/gtk/TestExpectations:
9:31 AM Changeset in webkit [157228] by akling@apple.com
  • 11 edits in trunk/Source/WebCore

CTTE: activeDOMWindow() and firstDOMWindow() should return references.
<​https://webkit.org/b/122598>

Reviewed by Anders Carlsson.

Now that wrappers vend references to their WebCore objects, follow
up and make these two return references as well.

9:19 AM Changeset in webkit [157227] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[ATK] Missing checks in returnIfWebKitAccessibleIsInvalid
​https://bugs.webkit.org/show_bug.cgi?id=122600

Patch by Mario Sanchez Prada <​mario.prada@samsung.com> on 2013-10-10
Reviewed by Chris Fleizach.

Check that the AccessibilityObject associated to the ATK wrapper
is not NULL and contains a valid reference to the document before
calling AccessibilityObject::updateBackingStore().

  • accessibility/atk/WebKitAccessibleUtil.h: Add extra checks.
8:43 AM Changeset in webkit [157226] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Clean up JSDOMWindowShell a little.
<​https://webkit.org/b/122599>

Reviewed by Anders Carlsson.

  • Have impl() return a DOMWindow& instead of a pointer.
  • Store the DOMWrapperWorld in a Ref instead of a RefPtr.
  • Reuse TRY_TO_UNWRAP_WITH_INTERFACE in EventTarget bindings.
8:35 AM Changeset in webkit [157225] by Csaba Osztrogonác
  • 12 edits in trunk/Source/WebKit2

Buildfix for non Mac platforms with enabled NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=121793

Reviewed by Anders Carlsson.

  • Shared/ShareableResource.cpp:
  • Shared/ShareableResource.h:
  • Shared/WebResourceBuffer.cpp:
  • Shared/WebResourceBuffer.h:
  • WebKit2Prefix.h:
  • WebProcess/Network/NetworkProcessConnection.cpp:
  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
  • WebProcess/Network/WebResourceLoader.cpp:
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
8:01 AM Changeset in webkit [157224] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make XPathGrammar.y bison3-friendly again after r157205
​https://bugs.webkit.org/show_bug.cgi?id=122595

Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Anders Carlsson.

No new tests, build fix.

  • xml/XPathGrammar.y: Replace YYLEX_PARAM with %lex-param, as the

former was removed in bison3.

7:51 AM Changeset in webkit [157223] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

SVGUseElement: Use iterative traversal to find disallowed elements.
<​https://webkit.org/b/122596>

Reviewed by Antti Koivisto.

Rewrote subtreeContainsDisallowedElement() in SVGUseElement.cpp to
use iterative traversal with descendantsOfType<Element> instead of
recursing through the tree.

6:55 AM Changeset in webkit [157222] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

Move RenderObject::layout() to RenderElement.
<​https://webkit.org/b/122537>

Reviewed by Antti Koivisto.

RenderText will ASSERT_NOT_REACHED() in its layout(), so move this
to RenderElement. This allows us to use the fast firstChild()
instead of virtual dispatch.

The needsLayout() bit remains on RenderObject for now. Moving that
to RenderElement is a far more involved change.

6:42 AM Changeset in webkit [157221] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Crash at WebCore::accessibleNameForNode when visiting Facebook
​https://bugs.webkit.org/show_bug.cgi?id=122572

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Test: accessibility/aria-labeled-with-hidden-node.html

Handle the case where aria-labelledby references a non-rendered node.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::accessibleNameForNode):

LayoutTests:

  • accessibility/aria-labeled-with-hidden-node-expected.txt: Added.
  • accessibility/aria-labeled-with-hidden-node.html: Added.
6:39 AM Changeset in webkit [157220] by berto@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

dom/xhtml/level2/html/HTMLInputElement20.xhtml no longer crashes.

  • platform/gtk/TestExpectations:
6:29 AM Changeset in webkit [157219] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r157210): Crashes in WebCore::ScopedEventQueue::dispatchEvent for platforms using GCC
​https://bugs.webkit.org/show_bug.cgi?id=122592

Reviewed by Gustavo Noronha Silva.

  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::dispatchEvent): When calling EventDispatcher::dispatchEvent(), the GCC-compiled code
first creates a copy of the PassRefPtr<Event> object that's being passed into the method call. The copy will be used
in that method while the original is left with a null pointer. Only after that is the original queried for its pointer
while trying to get the Event's target, resulting in a crash due to calling the Event::target() on a null pointer.
To avoid it, pass a naked Event pointer to the method call. This will create a new PassRefPtr object without nullifying
the original one.

6:19 AM Changeset in webkit [157218] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Tools

[GTK] Provide search functionality to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=117631

Patch by Andres Gomez <Andres Gomez> on 2013-10-10
Reviewed by Carlos Garcia Campos.

Adds a search bar to MiniBrowser with the minimum functionality
and a new button to the toolbar for showing the new search
bar. Typical keyboard shortcuts are also added.

  • MiniBrowser/gtk/BrowserSearchBar.c: Added.

(doSearch):
(searchNext):
(searchPrevious):
(searchCloseButtonClickedCallback):
(searchEntryMenuIconPressedCallback):
(searchEntryClearIconReleasedCallback):
(searchEntryChangedCallback):
(searchEntryActivatedCallback):
(searchPrevButtonClickedCallback):
(searchNextButtonClickedCallback):
(searchMenuCheckButtonToggledCallback):
(browser_search_bar_init):
(browserSearchBarFinalize):
(browser_search_bar_class_init):
(browser_search_bar_new):
(browser_search_bar_add_accelerators):
(browser_search_bar_open):
(browser_search_bar_close):

  • MiniBrowser/gtk/BrowserSearchBar.h: Added.
  • MiniBrowser/gtk/BrowserWindow.c:

(webViewEnterFullScreen): Closes new search bar.
(webViewLeaveFullScreen): Opens new search bar if previously
visible.
(searchCallback): Added. Shows and hides the new search bar.
(browser_window_init): Added search button to the toolbar.
(browserWindowConstructed): Creates the new search bar.

  • MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
5:27 AM Changeset in webkit [157217] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Webkit - Updated Tamil translation
​https://bugs.webkit.org/show_bug.cgi?id=120520

Patch by Shantha kumar <​shkumar@redhat.com> on 2013-10-10
Reviewed by Gustavo Noronha Silva.

  • ta.po: updated.
5:19 AM Changeset in webkit [157216] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

Use more Element iterators in SVG code.
<​http://webkit.org/b/121127>

Reviewed by Antti Koivisto.

Use childrenOfType to iterate over only SVGElement (or even more
specific) children in a bunch of places.

Also auto-generate type helpers for SVGElement and SVGStopElement.

5:01 AM Changeset in webkit [157215] by akling@apple.com
  • 141 edits in trunk/Source

JS DOM wrappers' impl() functions should return references.
<​https://webkit.org/b/122497>

Reviewed by Antti Koivisto.

JS DOM wrappers always have a corresponding WebCore object during
their lifetime, so make impl() return a reference.

4:17 AM Changeset in webkit [157214] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix debug build after r157210
​https://bugs.webkit.org/show_bug.cgi?id=122593

Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Andreas Kling.

No new tests, build fix.

  • dom/EventContext.cpp:

(WebCore::TouchEventContext::handleLocalEvents): Fix ASSERT, now that
event is a reference instead of a pointer.

4:16 AM Changeset in webkit [157213] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Tighten some renderer access in Document.
<​https://webkit.org/b/121865>

Reviewed by Antti Koivisto.

A bit of Node/Element and RenderObject/RenderElement tightening.

3:49 AM Changeset in webkit [157212] by akling@apple.com
  • 10 edits in trunk/Source

rangeOfContents() should take a Node&.
<​https://webkit.org/b/122438>

Reviewed by Darin Adler.

All callers of rangeOfContents() either have a Node& already,
or do some kind of null-checking before calling it.

1:38 AM Changeset in webkit [157211] by svillar@igalia.com
  • 19 edits
    5 adds in trunk

[CSS Grid Layout] Implement support for grid-template
​https://bugs.webkit.org/show_bug.cgi?id=103313

Reviewed by Dean Jackson.

Source/WebCore:

Based on Blink r153427, r155199 and r155712 by <​jchaffraix@chromium.org>

Test: fast/css-grid-layout/grid-template-get-set.html

Recognize, parse, store and return properly the value of
grid-template. It required some extra parsing code because the
specs mandates to check that the defined grid areas are indeed
rectangular. Named grid areas are still not fully supported, will
be done in a follow up patch.

As validating involves building the grid areas a new CSSValue was
added to hold the computed value. Note that we have to track the
explicit size of the named grid areas as the named grid areas
(".") are not tracked in our HashMap of grid areas.

This change also involves moving GridCoordinate and GridSpan to a
separate file in order to share the code that describes the grid
area coordinates.

  • CMakeLists.txt: Added new files to the build.
  • GNUmakefile.list.am: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSGridTemplateValue.cpp: Added.

(WebCore::CSSGridTemplateValue::CSSGridTemplateValue):
(WebCore::stringForPosition):
(WebCore::CSSGridTemplateValue::customCSSText):

  • css/CSSGridTemplateValue.h: Added.

(WebCore::CSSGridTemplateValue::create):
(WebCore::CSSGridTemplateValue::~CSSGridTemplateValue):
(WebCore::CSSGridTemplateValue::gridAreaMap):
(WebCore::CSSGridTemplateValue::rowCount):
(WebCore::CSSGridTemplateValue::columnCount):
(WebCore::toCSSGridTemplateValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplate): create the grid areas and
validate that they define rectangular sections.

  • css/CSSParser.h:
  • css/CSSPropertyNames.in: Added -webkit-grid-template.
  • css/CSSValue.cpp:

(WebCore::CSSValue::equals): add support for the new CSSGridTemplateValue.
(WebCore::CSSValue::cssText): Ditto.
(WebCore::CSSValue::destroy): Ditto.

  • css/CSSValue.h:

(WebCore::CSSValue::isGridTemplateValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::cachedGridCoordinate): Replaced RenderGrid::GridSpan by WebCore::GridSpan.
(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition): Ditto.
(WebCore::RenderGrid::resolveGridPositionsFromStyle): Ditto.
(WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition): Ditto.

  • rendering/RenderGrid.h: Took GridSpan and GridCoordinate out.
  • rendering/style/GridCoordinate.h: Added.

(WebCore::GridSpan::create):
(WebCore::GridSpan::GridSpan):
(WebCore::GridSpan::operator==):
(WebCore::GridCoordinate::GridCoordinate):
(WebCore::GridCoordinate::operator==):
(WebCore::GridCoordinate::operator!=):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

  • rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):

LayoutTests:

From Blink r153427, r155199 and r155712 by <​jchaffraix@chromium.org>

Added a test to verify that we properly recognize, parse, store
and return the value of grid-template.

  • fast/css-grid-layout/grid-template-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-template-get-set.html: Added.
1:19 AM Changeset in webkit [157210] by rniwa@webkit.org
  • 14 edits in trunk/Source/WebCore

Make EventDispatcher::dispatch comprehensible
​https://bugs.webkit.org/show_bug.cgi?id=122588

Reviewed by Andreas Kling.

Merged EventDispatcher::dispatchEventAtCapturing, EventDispatcher::dispatchEventAtTarget,
EventDispatcher::dispatchEventAtBubbling, and EventDispatcher::dispatchEventPostProcess into EventDispatcher::dispatch,
and extracted static local callDefaultEventHandlersInTheBubblingOrder and dispatchEventInDOM out of it.

Also made handleLocalEvents of subclasses of EventContext and Node take Event& instead of Event*.

  • dom/EventContext.cpp: The following functions now take Event& instead of Event*.

(WebCore::EventContext::handleLocalEvents):
(WebCore::MouseOrFocusEventContext::handleLocalEvents):
(WebCore::TouchEventContext::handleLocalEvents):

  • dom/EventContext.h:
  • dom/EventDispatcher.cpp:

(WebCore::callDefaultEventHandlersInTheBubblingOrder): Extracted from EventDispatcher::dispatchEventPostProcess,
which is now merged into EventDispatcher::dispatch.
(WebCore::dispatchEventInDOM): Extracted out of EventDispatcher::dispatch, EventDispatcher::dispatchEventAtCapturing,
EventDispatcher::dispatchEventAtTarget and EventDispatcher::dispatchEventAtBubbling. This function is responsible for
dispatching the event for capturing, at the target, and then bubbling through the event path chain.
(WebCore::EventDispatcher::dispatch): EventDispatcher::dispatchEventPostProcess got merged into this. The calls to
dispatchEventAtCapturing, dispatchEventAtTarget, and dispatchEventAtBubbling are replaced by a single call to
dispatchEventInDOM.

  • dom/EventDispatcher.h:
  • dom/FocusEvent.h:

(WebCore::toFocusEvent): Added the version that takes a reference.

  • dom/MouseEvent.h:

(WebCore::toMouseEvent): Ditto.

  • dom/TouchEvent.h:

(WebCore::toTouchEvent): Ditto.

  • dom/Node.cpp:

(WebCore::Node::handleLocalEvents): Now takes Event& instead of Event*.

  • dom/Node.h:
  • dom/WindowEventContext.cpp:

(WebCore::WindowEventContext::handleLocalEvents): Ditto.

  • dom/WindowEventContext.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::handleLocalEvents): Ditto.

  • html/HTMLFormElement.h:
1:16 AM HaikuWebkit created by pulkomandy@gmail.com
1:03 AM WikiStart edited by pulkomandy@gmail.com
(diff)
Note: See TracTimeline for information about the timeline view.