⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 14, 2013:

10:55 PM Changeset in webkit [157443] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Source/WebCore: in safari,the background-color of input[type="search"] can't work
​https://bugs.webkit.org/show_bug.cgi?id=119967

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-14
Reviewed by Ryosuke Niwa.

When input type=search is styled with css background property then
it does not change the background-color of field. Its happening becasue
search field is not counted as styled control. Thus theme ignores the
css background property. With this patch search field is also counted as
styled control so background property reflects on search field.

Test: fast/forms/search/search-field-background-color.html

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isControlStyled):Now search field is also
a styled control.

LayoutTests: in safari ,the background-color of input[type="search"] can't work
​https://bugs.webkit.org/show_bug.cgi?id=119967

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-14
Reviewed by Ryosuke Niwa.

Added testcase to verify the background color of search field when
search field is styled with css background property.

  • fast/forms/search/search-field-background-color-expected.txt: Added.
  • fast/forms/search/search-field-background-color.html: Added.
  • platform/mac/fast/forms/search-styled-expected.txt: Rebaselined.
10:06 PM Changeset in webkit [157442] by zoltan@webkit.org
  • 1 edit
    22 moves
    1 add in trunk/LayoutTests

[CSS Shapes] Move shape-inside floats tests into their own subdirectory
​https://bugs.webkit.org/show_bug.cgi?id=122761

Reviewed by Sam Weinig.

I'm going to add some new float tests soon. In order to keep our shapes tests organized,
I'm moving the shape-inside with floating content tests to their own subdirectory.

  • fast/shapes/shape-inside/floats/shape-inside-floats-simple-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-floats-simple-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-floats-simple.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-floats-simple.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html.
9:08 PM Changeset in webkit [157441] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

EventPath::updateTouchLists traverses through EventPath thrice
​https://bugs.webkit.org/show_bug.cgi?id=122804

Reviewed by Benjamin Poulain.

Instead of traversing through EventPath for each TouchList, traverse through TouchList for every EventContext.
This paves our way to have one-pass traversal over EventPath, and evetually to remove EventContext altogether.

This change should also improve the cache hit rate since all Touch objects tend to be allocated at the same time
but this performance improvement is probably not observable.

  • dom/EventContext.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedNodeResolver::EventRelatedNodeResolver): Added a new constructor that takes Touch and
and TouchListType. We need to store these two values in order to update EventContext later.
(WebCore::EventRelatedNodeResolver::touch): Added,
(WebCore::EventRelatedNodeResolver::touchListType): Added.
(WebCore::addRelatedNodeResolversForTouchList): Extracted from updateTouchListsInEventPath.
(WebCore::EventPath::updateTouchLists): Moved the loop over m_path here. Notice that the outer loop iterates
over m_path instead of touchList as done in updateTouchListsInEventPath. The inner loop goes through resolvers
and adds Touch objects each EventContext as needed.

8:48 PM Changeset in webkit [157440] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Below tests don't be failed anymore after enabling subpixel layout.

fast/spatial-navigation/snav-container-white-space.html
fast/spatial-navigation/snav-fully-aligned-horizontally.html
fast/spatial-navigation/snav-iframe-no-scrollable-content.html

  • platform/efl/TestExpectations:
8:03 PM Changeset in webkit [157439] by mark.lam@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Transition *switch* and *scope* JITStubs to JIT operations.
​https://bugs.webkit.org/show_bug.cgi?id=122757.

Reviewed by Geoffrey Garen.

Transitioning:

cti_op_switch_char
cti_op_switch_imm
cti_op_switch_string
cti_op_resolve_scope
cti_op_get_from_scope
cti_op_put_to_scope

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
7:47 PM Changeset in webkit [157438] by ap@apple.com
  • 16 edits in trunk/Source/WebCore

Don't generate a wasteful isObservable check in isReachableFromOpaqueRoots
​https://bugs.webkit.org/show_bug.cgi?id=122802

Reviewed by Mark Hahnenberg.

  • bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:

Updated results.

6:06 PM Changeset in webkit [157437] by roger_fong@apple.com
  • 5 edits
    1 delete in trunk

Windows select element doesn't draw RTL properly.
​https://bugs.webkit.org/show_bug.cgi?id=122785.

Reviewed by Brent Fulgham.

Problems include the popup items not drawing on the right hand side and
not respecting the direction or the directional override styling of the option.
The selected element (drawn in the actual select element) also doesn't respect
the style settings of the selected menu option.

Tests:
Covered by fast/text/international/pop-up-button-text-alignment-and-direction.html.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):

  • platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
5:38 PM Changeset in webkit [157436] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: AX: fieldset should have GroupRole and legend should be description.
​https://bugs.webkit.org/show_bug.cgi?id=122534

Patch by Samuel White <Samuel White> on 2013-10-14
Reviewed by Chris Fleizach.

Changes fieldset to derive AXDescription from legend if one is available. Added
convenience method to AccessibilityObject to fetch element if available.

Test: accessibility/fieldset-element.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::alternativeText):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::isARIAHidden):
(WebCore::AccessibilityObject::isDOMHidden):
(WebCore::AccessibilityObject::defaultObjectInclusion):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isHidden):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::getAttribute):
(WebCore::AccessibilitySlider::valueForRange):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
(WebCore::AccessibilitySlider::setValue):
(WebCore::AccessibilitySlider::inputElement):

  • accessibility/AccessibilitySlider.h:
  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::legend):

  • html/HTMLFieldSetElement.h:

LayoutTests: Crash in WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>::createBidiRunsForLine
​https://bugs.webkit.org/show_bug.cgi?id=122776

Reviewed by Darin Adler.

  • fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash-expected.txt: Added.
  • fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash.html: Added.
5:35 PM Changeset in webkit [157435] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Adding myself to CC list for some components.

  • Scripts/webkitpy/common/config/watchlist:
5:23 PM Changeset in webkit [157434] by commit-queue@webkit.org
  • 12 edits
    2 adds
    6 deletes in trunk

AX: fieldset should have GroupRole and legend should be description.
​https://bugs.webkit.org/show_bug.cgi?id=122534

Patch by Samuel White <Samuel White> on 2013-10-14
Reviewed by Chris Fleizach.

Source/WebCore:

Changes fieldset to derive AXDescription from legend if one is available. Added
convenience method to AccessibilityObject to fetch element if available.

Test: accessibility/fieldset-element.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::alternativeText):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::isARIAHidden):
(WebCore::AccessibilityObject::isDOMHidden):
(WebCore::AccessibilityObject::defaultObjectInclusion):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isHidden):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::getAttribute):
(WebCore::AccessibilitySlider::valueForRange):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
(WebCore::AccessibilitySlider::setValue):
(WebCore::AccessibilitySlider::inputElement):

  • accessibility/AccessibilitySlider.h:
  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::legend):

  • html/HTMLFieldSetElement.h:

LayoutTests:

legend no longer treated as titleUIElement so removing tests that check this functionality.
Added test to check that legend is used as AXDescription of fieldset if present.

  • accessibility/fieldset-element.html: Added.
  • accessibility/hidden-legend-expected.txt: Removed.
  • accessibility/hidden-legend.html: Removed.
  • accessibility/legend.html: Removed.
  • platform/efl/accessibility/legend-expected.txt: Removed.
  • platform/gtk/accessibility/legend-expected.txt: Removed.
  • platform/mac/accessibility/fieldset-element-expected.txt: Added.
  • platform/mac/accessibility/legend-expected.txt: Removed.
  • platform/mac/accessibility/role-subrole-roledescription-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription.html:
5:05 PM Changeset in webkit [157433] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG PutById IC should use the ConcurrentJITLocker since it's now dealing with IC's that get read by the compiler thread
​https://bugs.webkit.org/show_bug.cgi?id=122786

Reviewed by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStub): Resetting a stub should acquire the lock since this is observable from the thread; but we should only acquire the lock if we're resetting outside of GC.

  • jit/Repatch.cpp:

(JSC::repatchPutByID): Doing the PutById patching should hold the lock.
(JSC::buildPutByIdList): Ditto.

5:02 PM Changeset in webkit [157432] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix.

  • WebCore.vcxproj/WebCoreCommon.props:
4:58 PM Changeset in webkit [157431] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Assertion failure in Range::processContentsBetweenOffsets
​https://bugs.webkit.org/show_bug.cgi?id=122777

Reviewed by Darin Adler.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/c15de182774c7859c20d97126eb844ae97b792a4

This patch changes ASSERT statements for checking |endOffset| inbound in Range::processContentsBetweenOffsets()
to limit |endOffset|. This is necessary when DOMNodeRemovedFromDocument event handler splits text nodes,
Range::insertNode() on text node, in the range calling Range::deleteContents().

Test: fast/dom/Range/range-delete-contents-mutation-event-crash.html

  • dom/Range.cpp:

(WebCore::Range::processContentsBetweenOffsets):

LayoutTests:

  • fast/dom/Range/range-delete-contents-mutation-event-crash-expected.txt: Added.
  • fast/dom/Range/range-delete-contents-mutation-event-crash.html: Added.
4:36 PM Changeset in webkit [157430] by ap@apple.com
  • 12 edits
    11 adds in trunk

Add an empty window.crypto.webkitSubtle
​https://bugs.webkit.org/show_bug.cgi?id=122778

Reviewed by Mark Hahnenberg.

Source/WebCore:

Tests: security/crypto-subtle-gc-2.html

security/crypto-subtle-gc-3.html
security/crypto-subtle-gc.html

  • DerivedSources.make: Process SubtleCrypto.idl.
  • crypto: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • bindings/js/JSSubtleCryptoCustom.cpp: Added. Empty for now, but we'll certainly

need custom bindings code here.

  • crypto/SubtleCrypto.cpp: Added.

(WebCore::SubtleCrypto::SubtleCrypto):
(WebCore::SubtleCrypto::document):

  • crypto/SubtleCrypto.h: Added.
  • crypto/SubtleCrypto.idl: Added.
  • page/Crypto.cpp:

(WebCore::Crypto::subtle):

  • page/Crypto.h:
  • page/Crypto.idl:

LayoutTests:

  • TestExpectations: The feature isn't enabled anywhere yet, so skipping the new tests.
  • security/crypto-subtle-gc-2-expected.txt: Added.
  • security/crypto-subtle-gc-2.html: Added.
  • security/crypto-subtle-gc-3-expected.txt: Added.
  • security/crypto-subtle-gc-3.html: Added.
  • security/crypto-subtle-gc-expected.txt: Added.
  • security/crypto-subtle-gc.html: Added.
4:30 PM Changeset in webkit [157429] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add FTL support for LogicalNot(string)
​https://bugs.webkit.org/show_bug.cgi?id=122765

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-14
Reviewed by Filip Pizlo.

This patch is tested by:
regress/script-tests/emscripten-cube2hash.js.ftl-eager

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):

4:26 PM Changeset in webkit [157428] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove GestureEvent leftovers from WebCore
<​https://webkit.org/b/122780>

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-10-14
Reviewed by Anders Carlsson.

  • Removed some remaining references to PlatformGestureEvent, supposed to be removed by r157316
  • TOUCH_ADJUSTMENT should be reworked after GestureEvent feature removal
  • page/EventHandler.cpp:

(WebCore::EventHandler::bestZoomableAreaForTouchPoint):

  • page/EventHandler.h:
  • platform/PlatformEvent.h:
  • platform/ScrollAnimatorNone.cpp:
  • platform/ScrollableArea.h:
4:22 PM Changeset in webkit [157427] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[sh4] Fixes after r157404 and r157411.
​https://bugs.webkit.org/show_bug.cgi?id=122782

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-14
Reviewed by Michael Saboff.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation): Add missing SH4_32BIT_DUMMY_ARG.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JITInlines.h:

(JSC::JIT::callOperation): Add missing SH4_32BIT_DUMMY_ARG.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_id): Remove unwanted BEGIN_UNINTERRUPTED_SEQUENCE.

4:17 PM Changeset in webkit [157426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r157366
​http://bugs.webkit.org/show_bug.cgi?id=122783

When TOUCH_AJUSTMENT is enabled build fails due to some
refactors in TextRender functions.

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-10-14
Reviewed by Anders Carlsson.

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::appendContextSubtargetsForNode):

4:08 PM Changeset in webkit [157425] by Alexandru Chiculita
  • 5 edits
    3 adds in trunk

The content of the DOM panel for iframes is not updated until the "onload" event
​https://bugs.webkit.org/show_bug.cgi?id=122653

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/inspector-protocol/loading-iframe-document-node.html

Renamed InspectorDOMAgent::loadEventFired to InspectorDOMAgent::didCommitLoad and moved the call site
from InspectorInstrumentation::loadEventFiredImpl to InspectorInstrumentation::didCommitLoadImpl.
This is to make sure that it will invalidate the content of the iframe as soon as the frame navigates
to a different page. This way the new node can be retrieved as soon as the page has some content, and
not just when the page is fully loaded.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didCommitLoad): Renamed from loadEventFired, as it is now called from
didCommitLoadImpl instead.
(WebCore::InspectorDOMAgent::frameDocumentUpdated): Updated comment to point to the new function name.

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::loadEventFiredImpl): Removed call do InspectorDOMAgent.loadEventFired.
(WebCore::InspectorInstrumentation::didCommitLoadImpl): Added call to InspectorDOMAgent.didCommitLoad.

LayoutTests:

Added test to check that immediately after the scripting context is created, the
inspector already has access to the nodeId of the document of the iframe.

  • http/tests/inspector-protocol/loading-iframe-document-node-expected.txt: Added.
  • http/tests/inspector-protocol/loading-iframe-document-node.html: Added.
  • http/tests/inspector-protocol/resources/slow-test-page.html: Added.
2:59 PM Changeset in webkit [157424] by commit-queue@webkit.org
  • 14 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r157413.
​http://trac.webkit.org/changeset/157413
​https://bugs.webkit.org/show_bug.cgi?id=122779

Appears to have caused frequent crashes (Requested by ap on
#webkit).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/DeferGC.cpp: Removed.
  • heap/DeferGC.h:
  • jit/JITStubs.cpp:

(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/ConcurrentJITLock.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSCellInlines.h:

(JSC::allocateCell):

  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):

  • runtime/Structure.h:
2:45 PM Changeset in webkit [157423] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=122774.
<rdar://problem/6138855>.

Reviewed by Brent Fulgham.

Add a field to keep track of hovered over index.
Use index to determine whether or not to use the existing selected index on the mouse down event.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::PopupMenuWin):
(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::wndProc):

  • platform/win/PopupMenuWin.h:
2:41 PM Changeset in webkit [157422] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

COLLECT_ON_EVERY_ALLOCATION causes assertion failures
​https://bugs.webkit.org/show_bug.cgi?id=122652

Reviewed by Filip Pizlo.

COLLECT_ON_EVERY_ALLOCATION wasn't accounting for the new GC deferral mechanism,
so we would end up ASSERTing during garbage collection.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase):

2:11 PM Changeset in webkit [157421] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, fix the paths so that the test passes.

  • js/regress/put-by-id.html:
2:08 PM Changeset in webkit [157420] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Separate out array iteration intrinsics
​https://bugs.webkit.org/show_bug.cgi?id=122656

Reviewed by Michael Saboff.

Separate out the intrinsics for key and values iteration
of arrays.

This requires moving moving array iteration into the iterator
instance, rather than the prototype, but this is essentially
unobservable so we'll live with it for now.

  • jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):
(JSC::arrayIteratorNextKeyThunkGenerator):
(JSC::arrayIteratorNextValueThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):

  • runtime/Intrinsic.h:
  • runtime/JSArrayIterator.cpp:

(JSC::JSArrayIterator::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorNext):
(JSC::arrayIteratorNextKey):
(JSC::arrayIteratorNextValue):
(JSC::arrayIteratorNextGeneric):

  • runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

1:49 PM Changeset in webkit [157419] by timothy_horton@apple.com
  • 18 edits
    3 adds in trunk/Source

Virtualize PlatformCALayer
​https://bugs.webkit.org/show_bug.cgi?id=122672

Reviewed by Anders Carlsson.

No new tests, just a refactoring.

  • WebCore.exp.in:

setGeometryFlipped is on PlatformCALayerMac now.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Add PlatformCALayer.cpp, PlatformCALayerWin.h, and let VS do its
thing with some other files.

  • WebCore.xcodeproj/project.pbxproj:

Add PlatformCALayer.cpp and PlatformCALayerMac.h.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::platformLayer):
Make a PlatformCALayerWin explicitly.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayer):
Added. Decide whether to make a PlatformCALayer{Mac, Win} based on the platform.
Later, we will decide between other subclasses based on other things.

(WebCore::GraphicsLayerCA::filtersCanBeComposited):
Do the same thing for filtersCanBeComposited.

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setContentsToSolidColor):
(WebCore::GraphicsLayerCA::setContentsToMedia):
(WebCore::GraphicsLayerCA::setContentsToCanvas):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Use createPlatformCALayer instead of PlatformCALayer::create.

  • platform/graphics/ca/mac/PlatformCAFiltersMac.mm:

For now, use the PlatformCALayerMac version of filtersCanBeComposited,
since this code is heavily tied to having CALayers in the Web process.

  • platform/graphics/ca/GraphicsLayerCA.h:

Include PlatformCALayer.h here so we can get the LayerType enum.
(NOTE-to-be-removed: if there's a better way to do this, I'm open to
suggestions; I couldn't puzzle out nested 'enum class' stuff).

Add the createPlatformCALayers.

  • platform/graphics/ca/PlatformCAAnimation.h:

Friend the subclasses too.

  • platform/graphics/ca/PlatformCALayer.cpp: Added.

(WebCore::PlatformCALayer::~PlatformCALayer):
Pull the shared part of the PlatformCALayer destructor out.

  • platform/graphics/ca/PlatformCALayer.h:

(WebCore::PlatformCALayer::platformLayer):
(WebCore::PlatformCALayer::setOwner):
(WebCore::PlatformCALayer::PlatformCALayer):
Virtualize all the things. Move platform specific members to their new subclasses.

  • platform/graphics/ca/mac/PlatformCALayerMac.h: Added.
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

Move the PLATFORM(MAC) implementations from PlatformCALayer to PlatformCALayerMac.

(PlatformCALayer::platformCALayer):
The platformCALayer lookup function is static on PlatformCALayer, so it can't
be moved to the subclasses. It might be a good idea in the future to move towards
a platform-independent mechanism for looking up PlatformCALayers from PlatformLayers,
and to avoid needing to do this as often as we do now.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

Move the PLATFORM(WIN) implementations from PlatformCALayer to PlatformCALayerWin.

(PlatformCALayerWin::create):
(PlatformCALayer::platformCALayer):

  • platform/graphics/ca/win/PlatformCALayerWin.h: Added.
  • platform/graphics/win/GraphicsContext3DWin.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::createLayerForMovie):
Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::FullscreenVideoController):
Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here.

1:44 PM Changeset in webkit [157418] by Hugo Parente Lima
  • 3 edits in trunk/Source/WebCore

[cmake] MediaControlsApple is used only by Efl port and is on CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=122772

Reviewed by Anders Carlsson.

  • CMakeLists.txt: Removed MediaControlsApple.cpp
  • PlatformEfl.cmake: Added MediaControlsApple.cpp
1:28 PM Changeset in webkit [157417] by ap@apple.com
  • 6 edits
    2 adds in trunk

window.crypto doesn't preserve custom properties
​https://bugs.webkit.org/show_bug.cgi?id=122770

Reviewed by Mark Hahnenberg.

Source/WebCore:

Test: security/crypto-gc.html

Generate isReachableFromOpaqueRoots that makes Crypto live as long as the document
lives (because that's when it's observable through window object).

  • page/Crypto.cpp:

(WebCore::Crypto::Crypto):
(WebCore::Crypto::~Crypto):
(WebCore::Crypto::document):

  • page/Crypto.h:

(WebCore::Crypto::create):
Made Crypto a ContextDestructionObserver, so that it can report its document to bindings.
Removed ScriptWrappable, because it seems to have served no purpose in this class.

  • page/Crypto.idl: Added GenerateIsReachable. Removed ImplementationLacksVTable,

because the class now has a vtable, and can be checked for bindings integrity.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::crypto): Pass a document when creating

crypto.

LayoutTests:

  • security/crypto-gc-expected.txt: Added.
  • security/crypto-gc.html: Added.
1:11 PM Changeset in webkit [157416] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE: NamedNodeMap always has a corresponding Element.
<​https://webkit.org/b/122769>

Reviewed by Anders Carlsson.

Made NamedNodeMap::m_element a reference and remove an assertion
that it's never null.

12:53 PM Changeset in webkit [157415] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r157408): Crashes in RenderFullScreen::wrapRenderer().

Unreviewed crash fix for these two tests:

  • fullscreen/full-screen-restrictions.html
  • fullscreen/empty-anonymous-block-continuation-crash.html
  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::wrapRenderer):

Get the RenderArena from Document like we did before this patch.

12:35 PM Changeset in webkit [157414] by hmuller@adobe.com
  • 4 edits
    2 adds in trunk

[CSS Shapes] Image valued shape-outside shapes should update the layout after the image has been loaded
​https://bugs.webkit.org/show_bug.cgi?id=122340

Reviewed by Simon Fraser.

Source/WebCore:

Ensure that the an image-valued shape-outside layout is updated after the image has
been loaded.

Test: http/tests/css/css-image-valued-shape.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::imageChanged): Added code for the shape-outside case.
(WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Ditto.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement): Ditto.
(WebCore::RenderElement::setStyle): Ditto.

LayoutTests:

Verify that an image-valued shape-outside layout is updated after the image has been loaded.

  • http/tests/css/css-image-valued-shape-expected.txt: Added.
  • http/tests/css/css-image-valued-shape.html: Added.
12:34 PM Changeset in webkit [157413] by mhahnenberg@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

llint_slow_path_put_by_id can deadlock on a ConcurrentJITLock
​https://bugs.webkit.org/show_bug.cgi?id=122667

Reviewed by Filip Pizlo.

The issue this patch is attempting to fix is that there are places in our codebase
where we acquire the ConcurrentJITLock for a particular CodeBlock, then we do some
operations that can initiate a garbage collection. Garbage collection then calls
some methods of CodeBlock that also take the ConcurrentJITLock (because they don't
always necessarily run during garbage collection). This causes a deadlock.

To fix this issue, this patch adds a new RAII-style object (DisallowGC) that stores
into a thread-local field that indicates that it is unsafe to perform any operation
that could trigger garbage collection on the current thread. In debug builds,
ConcurrentJITLocker contains one of these DisallowGC objects so that we can eagerly
detect deadlocks.

This patch also adds a new type of ConcurrentJITLocker, GCSafeConcurrentJITLocker,
which uses the DeferGC mechanism to prevent collections from occurring while the
lock is held.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/DeferGC.cpp: Added.
  • heap/DeferGC.h:

(JSC::DisallowGC::DisallowGC):
(JSC::DisallowGC::~DisallowGC):
(JSC::DisallowGC::isGCDisallowedOnCurrentThread):
(JSC::DisallowGC::initialize):

  • jit/JITStubs.cpp:

(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/ConcurrentJITLock.h:

(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::~ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::unlockEarly):
(JSC::GCSafeConcurrentJITLocker::GCSafeConcurrentJITLocker):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSCellInlines.h:

(JSC::allocateCell):

  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):

  • runtime/Structure.h:
12:24 PM Changeset in webkit [157412] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove some silly null checks in Element/NamedNodeMap.
<​https://webkit.org/b/122767>

Reviewed by Darin Adler.

Make shouldIgnoreAttributeCase() take a const Element&, exposing
some unnecessary null checks.

11:39 AM Changeset in webkit [157411] by fpizlo@apple.com
  • 19 edits
    3 adds in trunk

Baseline JIT should use the DFG's PutById IC
​https://bugs.webkit.org/show_bug.cgi?id=122704

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Mostly no big deal, just removing the old Baseline JIT's put_by_id IC support and forcing
that JIT to use the DFG's (i.e. JITOperations) PutById IC.

The only complicated part was that the PutById operations assumed that we first did a
cell speculation, which the baseline JIT obviously won't do. So I changed all of those
slow paths to deal with EncodedJSValue's.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • jit/JIT.h:

(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::PropertyStubCompilationInfo::slowCaseInfo):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperationWrappers.h:
  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/Repatch.cpp:

(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::resetPutByID):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • js/regress/put-by-id-expected.txt: Added.
  • js/regress/put-by-id.html: Added.
  • js/regress/script-tests/put-by-id.js: Added.

(foo):
(bar):

11:29 AM Changeset in webkit [157410] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Build fix after r122737.

  • dom/Node.h: Add explicit WebCore namespace to macro definition to work around

Visual Studio bug.

11:08 AM Changeset in webkit [157409] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

FTL should have an inefficient but correct implementation of GetById
​https://bugs.webkit.org/show_bug.cgi?id=122740

Reviewed by Mark Hahnenberg.

It took some effort to realize that the node->prediction() check in the DFG backends
are completely unnecessary since the ByteCodeParser will always insert a ForceOSRExit
if !prediction.

But other than that this was an easy patch.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetById):

10:55 AM Changeset in webkit [157408] by akling@apple.com
  • 149 edits in trunk/Source/WebCore

Pass Document directly to anonymous renderer constructors.
<​https://webkit.org/b/122752>

Reviewed by Antti Koivisto.

Added separate constructors for creating anonymous renderers that
take a Document& instead of a null Element*/Text*.

Removed setDocumentForAnonymous() and all createAnonymous() helpers.
...and RenderObject::m_node is now a Node&, wohoo!

10:50 AM Changeset in webkit [157407] by mihnea@adobe.com
  • 7 edits
    8 moves
    1 add in trunk/LayoutTests

[CSSRegions] Move style-scoped* tests into fast/regions/style-scoped
​https://bugs.webkit.org/show_bug.cgi?id=122741

Reviewed by Darin Adler.

Move files, adjust TestExpectations.

  • fast/regions/style-scoped/style-scoped-in-flow-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-expected.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style-expected.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-expected.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling.html.
  • fast/regions/style-scoped/style-scoped-in-flow.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow.html.
  • platform/efl/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
10:16 AM Changeset in webkit [157406] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[WK2][Efl][Soup] Make NetworkProcessMainUnix handle proxy settings.
​https://bugs.webkit.org/show_bug.cgi?id=118388

Reviewed by Carlos Garcia Campos.

Original patch by Kwang Yul Seo <​skyul@company100.net> .

Proxy configuration should honor the no_proxy environment variable
same to WebProcess. It is necessary not to change the current behaviour.
See ​https://bugs.webkit.org/show_bug.cgi?id=91747 for details.

The following things were fixed by Csaba Osztrogonác:

  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:

(WebKit::NetworkProcessMain):
Copied from WebProcessMainEfl.cpp.

9:52 AM Changeset in webkit [157405] by weinig@apple.com
  • 31 edits in trunk/Source/WebCore

CTTE: Add more node conversion helpers
​https://bugs.webkit.org/show_bug.cgi?id=122737

Reviewed by Darin Adler.

  • Factor NODE_TYPE_CASTS into TYPE_CASTS_BASE(ToClassName, FromClassName) to allow for DOCUMENT_TYPE_CASTS.
  • Replace more static_casts<>.
9:42 AM Changeset in webkit [157404] by mark.lam@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Transition misc cti_op_* JITStubs to JIT operations.
​https://bugs.webkit.org/show_bug.cgi?id=122645.

Reviewed by Michael Saboff.

Stubs converted:

cti_op_check_has_instance
cti_op_create_arguments
cti_op_del_by_id
cti_op_instanceof
cti_to_object
cti_op_push_activation
cti_op_get_pnames
cti_op_load_varargs

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.h:

(JSC::JIT::emitStoreCell):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_del_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_del_by_id):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
8:55 AM Changeset in webkit [157403] by Michał Pakuła vel Rutka
  • 9 edits
    31 adds in trunk/LayoutTests

Unreviewed EFL gardening

Added new baselines for tests marked as skipped.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/compositing/overflow/nested-scrolling-expected.txt: Added.
  • platform/efl/compositing/overflow/remove-overflow-crash2-expected.png: Added.
  • platform/efl/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
  • platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
  • platform/efl/editing/unsupported-content/list-delete-001-expected.png:
  • platform/efl/editing/unsupported-content/list-delete-001-expected.txt: Added.
  • platform/efl/editing/unsupported-content/list-delete-003-expected.png:
  • platform/efl/editing/unsupported-content/list-delete-003-expected.txt: Added.
  • platform/efl/editing/unsupported-content/list-type-after-expected.png:
  • platform/efl/editing/unsupported-content/list-type-after-expected.txt: Added.
  • platform/efl/editing/unsupported-content/table-delete-002-expected.png:
  • platform/efl/editing/unsupported-content/table-delete-002-expected.txt: Added.
  • platform/efl/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/efl/fast/table/click-near-anonymous-table-expected.png: Added.
  • platform/efl/fast/table/click-near-anonymous-table-expected.txt: Added.
  • platform/efl/fast/text/international/arabic-justify-expected.png: Added.
  • platform/efl/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-linebreak-001-expected.png: Added.
  • platform/efl/fast/text/international/bidi-linebreak-001-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-linebreak-002-expected.png: Added.
  • platform/efl/fast/text/international/bidi-linebreak-002-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-linebreak-003-expected.png: Added.
  • platform/efl/fast/text/international/bidi-linebreak-003-expected.txt: Added.
  • platform/efl/fast/text/unicode-variation-selector-expected.png: Added.
  • platform/efl/fast/text/unicode-variation-selector-expected.txt: Added.
  • platform/efl/media/video-colorspace-yuv420-expected.png: Added.
  • platform/efl/media/video-colorspace-yuv420-expected.txt: Added.
  • platform/efl/media/video-colorspace-yuv422-expected.png: Added.
  • platform/efl/media/video-colorspace-yuv422-expected.txt: Added.
  • platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.png: Added.
  • platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
  • platform/efl/svg/hixie/data-types/002-expected.png: Added.
  • platform/efl/svg/hixie/data-types/002-expected.txt:
  • platform/efl/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/efl/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
8:46 AM Changeset in webkit [157402] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

Static assertions in WTF::adoptPtr should point to using adoptRef for ref-counted objects
​https://bugs.webkit.org/show_bug.cgi?id=122745

Reviewed by Anders Carlsson.

  • wtf/PassOwnPtr.h:

(WTF::adoptPtr): When the object's type is convertible to the RefCountedBase or ThreadSafeRefCountedBase type,
the static assertion should note that adoptRef should be used instead.

8:45 AM Changeset in webkit [157401] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Reintroduce PassRefPtr<Event> copy in ScopedEventQueue::dispatchEvent
​https://bugs.webkit.org/show_bug.cgi?id=122742

Reviewed by Alexey Proskuryakov.

This is a follow-up to r157219 which introduced a workaround for the GCC's quirky behavior that
was resulting in crashes due to the PassRefPtr<Event> object passed to EventDispatcher::dispatchEvent
being copied and nullified first before retrieving the EventTarget of the Event object wrapped in that
PassRefPtr.

The implementation is now adjusted to first retrieve the pointer to the Event's EventTarget and store
it in a local variable. That variable is then passed as the first parameter to EventDispatcher::dispatchEvent,
and the PassRefPtr<Event> passed directly as the second parameter. Previously the pointer of that PassRefPtr
object was passed in, with a new PassRefPtr being created which would increase the reference count of the
ref-counted object. Passing in the original PassRefPtr avoids the unnecessary reference count increase by creating
a copy. That still nullifies the original PassRefPtr, but that's not a problem anymore.

  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::dispatchEvent):

8:34 AM Changeset in webkit [157400] by betravis@adobe.com
  • 4 edits
    4 adds in trunk

[CSS Shapes] Shape-Margin should be animatable
​https://bugs.webkit.org/show_bug.cgi?id=122524

Reviewed by Darin Adler.

Source/WebCore:

Mark content for relayout after shape-margin changes, and add shape-margin
to the list of animatable properties.

Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html

fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add
shape-margin to the map of animatable CSS properties.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Compare shape-margins,
and mark dependent content for relayout if they have changed.

LayoutTests:

Test that shape-margin can be set dynamically and content lays out correctly.
Also test that shape-margin can be manipulated through CSS Animations.

  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html: Added.
7:17 AM Changeset in webkit [157399] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

[EFL] Accessibility gardening
​https://bugs.webkit.org/show_bug.cgi?id=122751

Unreviewed EFL gardening.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-14

  • platform/efl-wk2/TestExpectations: Add bug numbers and marked missing tests.
7:03 AM Changeset in webkit [157398] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't crash after OpenGL robustness reset
​https://bugs.webkit.org/show_bug.cgi?id=122750

Patch by Arvid Nilsson <​anilsson@blackberry.com> on 2013-10-14
Reviewed by George Staikos.

JIRA 517132.
Just log the incident and pretend like nothing happened.

No new tests, we don't have repeatable steps to reproduce a robustness
reset.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::makeContextCurrent):

6:39 AM Changeset in webkit [157397] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

[EFL] Buildfix after r157393
​https://bugs.webkit.org/show_bug.cgi?id=122749

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-14
Reviewed by Andreas Kling.

Buildfix with error enumeration value 'CSS_FR' not handled in switch.

  • css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):

6:08 AM Changeset in webkit [157396] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

WebKit Nightlies broken by r157374
​https://bugs.webkit.org/show_bug.cgi?id=122736

Reviewed by Andreas Kling.

Add back a callOnMainThread overload that Safari is using.

  • wtf/MainThread.cpp:

(WTF::callOnMainThread):

  • wtf/MainThread.h:
5:48 AM Changeset in webkit [157395] by gyuyoung.kim@samsung.com
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed. EFL Gardening.
Add baselines for new tests which was added by r156767.

  • platform/efl/TestExpectations: Remove tests supported by this commit.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
3:41 AM Changeset in webkit [157394] by mario@webkit.org
  • 4 edits
    1 add in trunk

[EFL] Present replaced objects with 0xFFFC character
​https://bugs.webkit.org/show_bug.cgi?id=122744

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-14
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Replaced elements should be emitted in GTK/EFL and
marked their presence with the replacement character.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):

LayoutTests:

Added new accessibility expectation after r156532.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
3:36 AM Changeset in webkit [157393] by svillar@igalia.com
  • 25 edits
    9 adds in trunk

[CSS Grid Layout] Implement support for <flex>
​https://bugs.webkit.org/show_bug.cgi?id=115362

Reviewed by Andreas Kling.

From Blink r149134, r149480, r149532, r150287 and r156127 by <​jchaffraix@chromium.org>
From Blink r157820 by <​svillar@igalia.com>

Source/WebCore:

Added support for flexible lengths ('fr' unit) in CSS Grid Layout
code. This requires the addition of GridLength class to
encapsulate the knowledge of <flex> to the grid layout code.

Also updated the algorithm that computes the layout. It increases
the value of 1fr based on the grid tracks' usedBreath to fraction
ratio (called normalizedFractionValue). This enables increasing
the fraction value while updating the available space to account
for processed grid tracks. The algorithm stops when we run out of
grid tracks or available space (one grid item has an intrinsic
size too big). This matches the specs to the letter for the known
available space case (both the unknown case and the interaction
with 'span' are left out of this patch).

Tests: fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html

fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html
fast/css-grid-layout/flex-content-resolution-columns.html
fast/css-grid-layout/flex-content-resolution-rows.html

  • GNUmakefile.list.am: Added GridLength.h to the build system.
  • Target.pri: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackBreadth): Replace Length by GridLength.

  • css/CSSGrammar.y.in: Added FR support.
  • css/CSSParser.cpp: Ditto.

(WebCore::CSSParser::parseGridBreadth):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSParserValues.cpp: Added FR support.

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSParserValues.h:

(WebCore::CSSParserString::operator[]):
(WebCore::CSSParserString::equalIgnoringCase):

  • css/CSSPrimitiveValue.cpp: Added FR support.

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):

  • css/CSSPrimitiveValue.h: Added a couple of missing const.

(WebCore::CSSPrimitiveValue::isFlex):

  • css/StyleResolver.cpp: Added FR support.

(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackSize):

  • rendering/RenderGrid.cpp:

(WebCore::GridTrackForNormalization::GridTrackForNormalization):
New helper struct to ease the computation of track breadths with
flexible lengths.
(WebCore::GridTrackForNormalization::operator=):
(WebCore::RenderGrid::computePreferredTrackWidth): Replaced Length by GridLength.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Grow grid lines
having a fraction as the MaxTrackSizingFunction.
(WebCore::RenderGrid::computeUsedBreadthOfMinLength): Replaced Length by GridLength.
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength): Ditto.
(WebCore::sortByGridNormalizedFlexValue):
(WebCore::RenderGrid::computeNormalizedFractionBreadth): Increase
the fraction value while updating the available space to account
for processed grid tracks.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::distributeSpaceToTracks): Never shrink track sizes.
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):

  • rendering/RenderGrid.h:
  • rendering/style/GridLength.h: Added.

(WebCore::GridLength::GridLength):
(WebCore::GridLength::isLength):
(WebCore::GridLength::isFlex):
(WebCore::GridLength::length):
(WebCore::GridLength::flex):
(WebCore::GridLength::setFlex):
(WebCore::GridLength::operator==):

  • rendering/style/GridTrackSize.h: Replaced Length by GridLength.

(WebCore::GridTrackSize::length):
(WebCore::GridTrackSize::setLength):
(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
(WebCore::GridTrackSize::setMinMax):
(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth):

LayoutTests:

Added 4 new test cases to test the support for <flex> in CSS Grid
Layout code. Also updated some of the existing ones to check the
support for 'fr' units.

  • fast/css-grid-layout/flex-and-minmax-content-resolution-columns-expected.txt: Added.
  • fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html: Added.
  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt: Added.
  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html: Added.
  • fast/css-grid-layout/flex-content-resolution-columns-expected.txt: Added.
  • fast/css-grid-layout/flex-content-resolution-columns.html: Added.
  • fast/css-grid-layout/flex-content-resolution-rows-expected.txt: Added.
  • fast/css-grid-layout/flex-content-resolution-rows.html: Added.
  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt:
  • fast/css-grid-layout/grid-dynamic-updates-relayout.html:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
3:33 AM Changeset in webkit [157392] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Broken text rendering when input field has selection.
​https://bugs.webkit.org/show_bug.cgi?id=122716

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-14
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/text/text-rendering-with-input-selection.html.

fast/text/text-rendering-with-input-selection-expected.html.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Check that text has selection.

LayoutTests:

  • fast/text/text-rendering-with-input-selection.html: Added.
  • fast/text/text-rendering-with-input-selection-expected.html: Added.
2:43 AM Changeset in webkit [157391] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Unexpected word wrapping for wrapped content then raw content.
​https://bugs.webkit.org/show_bug.cgi?id=121130

Reviewed by Antti Koivisto.

When deciding whether a line is considered empty, we need to check if the current
object is fully responsible for the currently uncommitted width. It helps differentiating
<span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
case when we hit the second <span> the line is still considered empty, as opposed to the
second example.

Source/WebCore:

Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
  • fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
2:16 AM Changeset in webkit [157390] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Be more efficient about passing RenderStyle to attachRenderTree().
<​https://webkit.org/b/122743>

Reviewed by Antti Koivisto.

Have attachRenderTree() and createRendererTreeIfNeeded() pass the
RenderStyle in a PassRefPtr to avoid churning the ref count.

2:00 AM Changeset in webkit [157389] by svillar@igalia.com
  • 6 edits
    2 adds in trunk

[CSS Grid Layout] 2 span positions are not resolved correctly
​https://bugs.webkit.org/show_bug.cgi?id=119717

Reviewed by Andreas Kling.

From Blink r155397 by <​jchaffraix@chromium.org>

Source/WebCore:

Test: fast/css-grid-layout/grid-item-bad-resolution-double-span.html

Two opposite 'span' or 'auto' positions should be resolved using
the auto placement algorithm. We were only checking for the 'auto'
case. This also covers the case of other positions that, according
to the spec, should be treated as 'auto'.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionsFromStyle):

LayoutTests:

Added a new test case to check bad grid items resolution with two
opposite span positions. Also added a real grid container to check
also the resolution code path in some other tests.

  • fast/css-grid-layout/grid-item-area-get-set.html: Added a grid container.
  • fast/css-grid-layout/grid-item-bad-resolution-double-span-expected.txt: Added.
  • fast/css-grid-layout/grid-item-bad-resolution-double-span.html: Added.
  • fast/css-grid-layout/grid-item-end-after-get-set.html: Added a grid container.
  • fast/css-grid-layout/grid-item-start-before-get-set.html: Ditto.
12:58 AM Changeset in webkit [157388] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Use RenderElement instead of RenderObject in more places.
<​https://webkit.org/b/122734>

Reviewed by Antti Koivisto.

Convert some sites to use RenderElement (or type inference) instead
of RenderObject for less branchy code.

Oct 13, 2013:

10:58 PM Changeset in webkit [157387] by Darin Adler
  • 18 edits in trunk

Deprecate or remove deleteAllValues functions; there are only a few call sites left
​https://bugs.webkit.org/show_bug.cgi?id=122738

Reviewed by Anders Carlsson.

Source/WebCore:

  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::deleteAllCookiesAndDomains):

  • platform/network/blackberry/rss/RSSParserBase.cpp:

(WebCore::RSSFeed::clear):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::~WCDataObject):
Renamed deleteAllValues to deprecatedDeleteAllValues.

Source/WebKit/blackberry:

  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
Renamed deleteAllValues to deprecatedDeleteAllValues.

Source/WebKit2:

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::pluginDestroyed): Renamed deleteAllValues to
deprecatedDeleteAllValues.

Source/WTF:

  • wtf/Deque.h: Deleted deleteAllValues.
  • wtf/HashMap.h: Ditto.
  • wtf/HashSet.h: Ditto.
  • wtf/ListHashSet.h: Ditto.
  • wtf/Vector.h: Renamed deleteAllValues to deprecatedDeleteAllValues.

Tools:

  • DumpRenderTree/win/DRTDataObject.cpp:

(DRTDataObject::~DRTDataObject):

  • DumpRenderTree/win/UIDelegate.cpp:

(DRTUndoStack::~DRTUndoStack):
(DRTUndoStack::clear):
Renamed deleteAllValues to deprecatedDeleteAllValues.

  • Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
10:02 PM Changeset in webkit [157386] by ap@apple.com
  • 3 edits in trunk/Tools

build.webkit.org/dashboard incorrectly shows interrupted builds as green
​https://bugs.webkit.org/show_bug.cgi?id=122732

Reviewed by Tim Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
I don't see it occur any time in recent history, but judging from what happens for
status 5 (RETRY), we can just finish this function normally.
Record overall text description for iteration as BuildbotIteration.text.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
but no tests failed, make it yellow, and use buildbot-provided description for it.

5:11 PM Changeset in webkit [157385] by weinig@apple.com
  • 104 edits in trunk/Source/WebCore

Merge NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS
​https://bugs.webkit.org/show_bug.cgi?id=122735

Reviewed by Antti Koivisto.

NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS are identical. Let them become one
with one another.

3:06 PM Changeset in webkit [157384] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Uncrashify Document::head() too. (Why am I even awake?)

2:21 PM Changeset in webkit [157383] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r157381): Make Document::body() crash less when there is no documentElement.

Unreviewed.

1:45 PM Changeset in webkit [157382] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL OSR exit should perform zero extension on values smaller than 64-bit
​https://bugs.webkit.org/show_bug.cgi?id=122688

Reviewed by Gavin Barraclough.

In the DFG we usually make the simplistic assumption that a 32-bit value in a 64-bit
register will have zeros on the high bits. In the few cases where the high bits are
non-zero, the DFG sort of tells us this explicitly.

But when working with llvm.webkit.stackmap, it doesn't work that way. Consider we might
emit LLVM IR like:

%2 = trunc i64 %1 to i32
stuff %2
call @llvm.webkit.stackmap(...., %2)

LLVM may never actually emit a truncation instruction of any kind. And that's great - in
many cases it won't be needed, like if 'stuff %2' is a 32-bit op that ignores the high
bits anyway. Hence LLVM may tell us that %2 is in the register that still had the value
from before truncation, and that register may have garbage in the high bits.

This means that on our end, if we want a 32-bit value and we want that value to be
zero-extended, we should zero-extend it ourselves. This is pretty easy and should be
cheap, so we should just do it and not make it a requirement that LLVM does it on its
end.

This makes all tests pass with JSC_ftlOSRExitUsesStackmap=true.

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStubWithOSRExitStackmap):

  • ftl/FTLValueFormat.cpp:

(JSC::FTL::reboxAccordingToFormat):

12:21 PM Changeset in webkit [157381] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Rewrite Document::body and Document::head in modern style, way clearer and shorter
​https://bugs.webkit.org/show_bug.cgi?id=122717

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::body): Use iterator to make this way easier to read.
(WebCore::Document::head): Ditto.

  • html/HTMLTagNames.in: Added generateTypeHelpers for body and head.
12:17 PM Changeset in webkit [157380] by mrowe@apple.com
  • 5 edits
    5 copies in trunk

Roll depsHHHHChangeLogs.

11:52 AM Changeset in webkit [157379] by berto@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk-wk2/TestExpectations:

Add bug number to the failing animation tests.

11:39 AM Changeset in webkit [157378] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

RenderLayerBacking should have RenderLayer& backpointer.
<​https://webkit.org/b/122731>

Reviewed by Anders Carlsson.

RenderLayerBacking is always owned by a RenderLayer and so should
store its backpointer in a reference.

10:26 AM Changeset in webkit [157377] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Removing input-file-entries.html from TestExpectation
​https://bugs.webkit.org/show_bug.cgi?id=122674

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-13
Reviewed by Anders Carlsson.

input-file-entries.html has been removed in
changeset 156692. so removing references to this file.

  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
10:10 AM Changeset in webkit [157376] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Lion build.

  • Configurations/JavaScriptCore.xcconfig:
9:15 AM Changeset in webkit [157375] by Darin Adler
  • 52 edits in trunk/Source/WebCore

Make element predicates and type casts work more consistently on more types
​https://bugs.webkit.org/show_bug.cgi?id=122718

Reviewed by Antti Koivisto.

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::assertConnectedSubrameCountIsConsistent):

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::collectFrameOwners):
Updated for name change.

  • dom/Document.cpp:

(WebCore::Document::adoptNode): Use a reference instead of a pointer.
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Updated for
typecast name change and also to cast a reference, since we don't overload
for pointers.
(WebCore::Document::updateHoverActiveState): Ditto.

  • dom/Element.h: Made the isElementOfType functions take references instead

of pointers. Also use const in the type template argument. These changes go
hand in hand with the changes in the generated code and all the classes.
Also use a bit of nullptr.

  • dom/ElementIterator.h:

(WebCore::findElementAncestorOfType): Got rid of the ElementTypeWithConst
naming since this works with or without const. Added const to the call site
for isElementOfType, because it works that way now.

  • dom/ElementTraversal.h:

(WebCore::Traversal::firstChildTemplate): Add const to the type when calling
isElementOfType. Along with the corresponding changes, this makes these
templates work for const types.
(WebCore::Traversal::lastChildTemplate): Ditto.
(WebCore::Traversal::firstWithinTemplate): Ditto.
(WebCore::Traversal::lastWithinTemplate): Ditto.
(WebCore::Traversal::nextTemplate): Ditto.
(WebCore::Traversal::previousTemplate): Ditto.
(WebCore::Traversal::nextSiblingTemplate): Ditto.
(WebCore::Traversal::previousSiblingTemplate): Ditto.
(WebCore::Traversal::nextSkippingChildrenTemplate): Ditto.

  • dom/Node.cpp:

(WebCore::Node::handleLocalEvents): Check isElementNode and then call the
isDisabledFormControl member function, since we no longer have a helper that
takes a node.
(WebCore::Node::willRespondToMouseMoveEvents): Ditto.
(WebCore::Node::willRespondToMouseClickEvents): Ditto.
(WebCore::Node::willRespondToTouchEvents): Ditto.

  • dom/PseudoElement.h: Use some nullptr. Added an isPseudoElement function

that the ELEMENT_TYPE_CASTS macro can use, and also used that macro to make
the toPseudoElement functions instead of a hand-written local variant.

  • dom/make_names.pl:

(printTypeHelpers): Added unimplemented versions of the element predicate
functions that return void to catch unnecessary runtime checks of types
that are already known at compile time. Added assertions to the pointer
overloads of the predicates. Maybe later we can delete them. Added const
to the isElementOf template arguments to make these work with both const
and non-const. Put overloads in a consistent order, most specific class
first, then less specific. Changed isElementOfType to take references
rather than pointers.

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand): Updated to pass a reference.
(WebCore::Editor::setBaseWritingDirection): Ditto.
(WebCore::findFirstMarkable): Ditto.

  • html/FormAssociatedElement.h: Tweaked a comment.
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto): Updated for name change and to
pass a reference.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::translate): Removed FIXME and const_cast since the
problem is fixed.
(WebCore::HTMLElement::directionality): Use a reference.

  • html/HTMLElement.h: Use const in the type of the isElementOfType functions.

Use references for all the arguments, not pointers.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded): Use documentVersion
instead of docVersion for local variable name. Use elementDescendants instead
of elementTraversal.
(WebCore::HTMLFieldSetElement::length): Use length instead of len for name.

  • html/HTMLFormControlElement.h: Put predicates into the standard format and

did them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.

  • html/HTMLFrameElementBase.h: Ditto.
  • html/HTMLFrameOwnerElement.h: Ditto, but changed the name to match the class,

so it's now isHTMLFrameOwnerElement and toHTMLFrameOwnerElement.

  • html/HTMLLabelElement.cpp:

(WebCore::nodeAsSupportedLabelableElement): Updated to use references.

  • html/HTMLMediaElement.h: Put predicates into the standard format and did

them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.

  • html/HTMLPlugInElement.h: Ditto. Also marked isPluginElement FINAL.
  • html/HTMLPlugInImageElement.h: Ditto.
  • html/HTMLTableCellElement.cpp: Removed old hand-written cast functions.
  • html/HTMLTableCellElement.h: Did same predicate and ELEMENT_TYPE_CASTS

changes. Also fixed up the ordering of functions in the class.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl): Updated to use references and nullptr.

  • html/HTMLTextFormControlElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::removedFrom): Call isHTMLMediaElement by its new name.

  • html/LabelableElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
  • html/track/WebVTTElement.h: Made isWebVTTElement private. Changed the argument

type of setLanguage to const AtomicString& to avoid excess reference count churn.
Did the predicate and type casts thing.

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create): Update for name changes and use references.

  • mathml/MathMLElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
  • page/FocusController.cpp:

(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):

  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
Update for name change.

  • platform/Pasteboard.h: Removed unneeded forward declaration.
  • rendering/RenderWidget.h: Updated for name change.
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives): Use element iterator
and nullptr.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler): Update for name changes.

  • svg/SVGAnimateElement.cpp:

(WebCore::isSVGAnimateElement): Moved here since we don't want to inline such
a long list of tag names.

  • svg/SVGAnimateElement.h: Marked a lot more virtual functions OVERRIDE.

Did predicate and ELEMENT_TYPE_CASTS changes, but did not make the predicate
be inlined.

  • svg/SVGElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
  • svg/SVGFilterPrimitiveStandardAttributes.h: Ditto.
  • svg/SVGGradientElement.cpp:

(WebCore::isSVGGradientElement): Moved here since we don't want to inline
the two tag names.

  • svg/SVGGradientElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
  • svg/SVGGraphicsElement.h: Ditto.
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::SVGImageElement): Took out assertion, since it
was asserting the class of the obejct we just created.

  • svg/SVGPolyElement.cpp:

(WebCore::isSVGPolyElement): Moved here since we don't want to inline the
two tag names.

  • svg/SVGPolyElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
  • svg/SVGTextContentElement.h: Ditto.
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::connectConditions): Update for name changes,
to use references and nullptr, and to get rid of a non-helpful local.

  • svg/animation/SVGSMILElement.h: Added a virtual function to check if a

given SVGElement is an SVGSMILElement so we don't have to check a long list
of tag names instead. Also did the predicate and ELEMENT_TYPE_CASTS changes.

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder): Updated to use references.

9:12 AM Changeset in webkit [157374] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Change callOnMainThread to take an std::function
​https://bugs.webkit.org/show_bug.cgi?id=122698

Reviewed by Darin Adler.

This will let us pass anything that can be converted to an std::function (including lambdas and
WTF::Function objects) to callOnMainThread.

  • wtf/MainThread.cpp:

(WTF::callOnMainThread):

  • wtf/MainThread.h:
9:00 AM Changeset in webkit [157373] by Antti Koivisto
  • 13 edits in trunk/Source/WebCore

Text::renderer() should return RenderText
​https://bugs.webkit.org/show_bug.cgi?id=122729

Reviewed by Andreas Kling.

Tighten typing.

8:57 AM Changeset in webkit [157372] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Devirtualize RenderView::viewRect().
<​https://webkit.org/b/122730>

Reviewed by Antti Koivisto.

There's no need for viewRect() to be a virtual RenderObject function.
The single call site that didn't already access it through RenderView
can just go via view().

8:56 AM Changeset in webkit [157371] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Move setPseudoStyle() to RenderImage (from RenderElement.)
<​https://webkit.org/b/122726>

Reviewed by Antti Koivisto.

Only RenderImages ever use setPseudoStyle() so move it there and
remove the non-image codepath.

8:04 AM Changeset in webkit [157370] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: RenderSlider always has an HTMLInputElement.
<​https://webkit.org/b/122728>

Reviewed by Anders Carlsson.

This renderer is never anonymous and always has a corresponding
HTMLInputElement. Tighten this up by having the constructor take
the element by reference, and override element() with a stronger
return type.

7:46 AM Changeset in webkit [157369] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Remove two unused AX functions for getting a FrameView*.
<​https://webkit.org/b/122724>

Reviewed by Anders Carlsson.

6:26 AM Changeset in webkit [157368] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Add traverseNextSkippingChildren to ElementIterators
​https://bugs.webkit.org/show_bug.cgi?id=122727

Reviewed by Andreas Kling.

Also switch some code using ElementTraversal over to iterators.

4:39 AM Changeset in webkit [157367] by Antti Koivisto
  • 11 edits in trunk/Source/WebCore

Rename InlineBox::remove() to removeFromParent
​https://bugs.webkit.org/show_bug.cgi?id=122725

Reviewed by Andreas Kling.

Also make it clear from the code that all InlineTextBoxes have behavesLikeText set.

4:05 AM Changeset in webkit [157366] by Antti Koivisto
  • 11 edits in trunk/Source/WebCore

Make absoluteQuads/Rects functions return Vectors
​https://bugs.webkit.org/show_bug.cgi?id=122722

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale):
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale):

Take RenderStyle instead of RenderObject

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):

  • dom/Range.cpp:

(WebCore::Range::textRects):
(WebCore::Range::textQuads):
(WebCore::Range::getBorderAndTextQuads):

Adapt to the changes.

  • rendering/RenderObject.h:


Removed unnecessary adjustFloatQuad/RectForAbsoluteZoom functions, inline code to
adjustFloatQuads/RectForScrollAndAbsoluteZoomAndFrameScale.

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):

  • rendering/RenderText.h:
  • rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::absoluteRects):
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
(WebCore::RenderTextLineBoxes::absoluteQuads):
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange):

  • rendering/RenderTextLineBoxes.h:


Use return value instead of an out-arg, except for the virtual versions.

4:01 AM Changeset in webkit [157365] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

LiveNodeList: rootNode() and document() should return references.
<​https://webkit.org/b/122720>

Reviewed by Antti Koivisto.

Tighten up this code a bit by having rootNode() and document()
return references. Also replaced some handwritten traversal
with a call to Node::lastDescendant().

3:59 AM Changeset in webkit [157364] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Document::createRenderTree() should assert that there is no arena.
<​https://webkit.org/b/122723>

Reviewed by Antti Koivisto.

Calling createRenderTree() with a RenderArena already in place would
be a programming error.

3:16 AM Changeset in webkit [157363] by akling@apple.com
  • 13 edits
    5 deletes in trunk/Source

Remove dead ENABLE(CUSTOM_ELEMENTS) code.
<​https://webkit.org/b/122721>

Reviewed by Antti Koivisto.

There are no ports building with this flag since April and the code
has bitrotted since. Remove it for now. If someone wants to resurrect
the feature someday, getting back to this point is trivial.

2:39 AM Changeset in webkit [157362] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Move absoluteRects/Quads to RenderTextLineBoxes
​https://bugs.webkit.org/show_bug.cgi?id=122706

Reviewed by Andreas Kling.

  • rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::absoluteRects):
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
(WebCore::RenderTextLineBoxes::absoluteQuads):
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange):

These move.

(WebCore::RenderTextLineBoxes::selectionRectForRange):
(WebCore::RenderTextLineBoxes::setSelectionState):

Also moved a few smaller functions.

2:02 AM Changeset in webkit [157361] by akling@apple.com
  • 9 edits in trunk/Source

Remove dead code hiding behind ENABLE(TOUCH_EVENT_TRACKING).
<​https://webkit.org/b/122719>

Reviewed by Antti Koivisto.

Nobody is building with this flag, and it has broken-looking code
behind it anyway. Nuke from orbit.

12:17 AM Changeset in webkit [157360] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

RenderLayer: Check SVG bit instead of element namespace in isTransparent().
<​https://webkit.org/b/118171>

Reviewed by Darin Adler.

Replace the (virtual) namespaceURI() check with an isSVGElement() bit check.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::isTransparent):

12:08 AM Changeset in webkit [157359] by ap@apple.com
  • 12 edits in trunk/Tools

Remove Chromium specific code from flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=122714

Reviewed by Sam Weinig.

Also removed code related to GPU tests and virtual suites.
"Fallbacks map" was chromium only too, not sure why they needed special handling there.

  • TestResultServer/model/jsonresults_unittest.py:
  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  • TestResultServer/static-dashboards/history.js:
  • TestResultServer/static-dashboards/loader.js:
  • TestResultServer/static-dashboards/ui.js:
  • TestResultServer/templates/uploadform.html:
Note: See TracTimeline for information about the timeline view.