Context Navigation

← Previous Period
Next Period →

Timeline

Oct 19, 2013:

10:42 PM Changeset in webkit [157697] by jer.noble@apple.com

9 edits
1 delete in trunk

Unreviewed roll out of r157695; broke Mac builds.

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

LayoutTests:

platform/mac/js/dom/global-constructors-attributes-expected.txt: Removed.

10:40 PM Changeset in webkit [157696] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Simplify TempRegisterSet - it no longer needs to be convertible to a POD since it's no longer going to be a member of a union
https://bugs.webkit.org/show_bug.cgi?id=123079

Reviewed by Geoffrey Garen.

jit/TempRegisterSet.h:

9:58 PM Changeset in webkit [157695] by jer.noble@apple.com

9 edits
1 add in trunk

[MSE] [Mac] Enable MediaSource on the Mac
https://bugs.webkit.org/show_bug.cgi?id=122484

Reviewed by Darin Adler.

Source/WebCore:

Enable ENABLE_MEDIA_SOURCE.

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Enable ENABLE_MEDIA_SOURCE.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enable ENABLE_MEDIA_SOURCE.

Configurations/FeatureDefines.xcconfig:

Source/WTF:

Enable ENABLE_MEDIA_SOURCE.

wtf/FeatureDefines.h:

LayoutTests:

platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.

9:55 PM Changeset in webkit [157694] by weinig@apple.com

19 edits in trunk/Source/WebCore

CTTE: Tighten up type usage around InputType::innerTextElement()
https://bugs.webkit.org/show_bug.cgi?id=123078

Reviewed by Anders Carlsson.

editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement):

html/HTMLElement.h:

(WebCore::HTMLElement::isTextControlInnerTextElement):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::innerTextElement):

html/HTMLInputElement.h:
html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement):

html/HTMLTextAreaElement.h:
html/HTMLTextFormControlElement.cpp:

(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

html/HTMLTextFormControlElement.h:
html/InputType.h:

(WebCore::InputType::innerTextElement):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::innerTextElement):

html/TextFieldInputType.h:
html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerTextElement::renderer):

html/shadow/TextControlInnerElements.h:

(WebCore::isTextControlInnerTextElement):

rendering/RenderObject.h:

(WebCore::RenderObject::isTextControlInnerBlock):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::innerTextElement):
(WebCore::RenderTextControl::styleDidChange):
(WebCore::RenderTextControl::textBlockLogicalWidth):
(WebCore::RenderTextControl::updateFromElement):
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::hitInnerTextElement):

rendering/RenderTextControl.h:
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):

rendering/RenderTextControlSingleLine.h:

(WebCore::toRenderTextControlInnerBlock):

9:12 PM Changeset in webkit [157693] by fpizlo@apple.com

11 edits
1 move in trunk/Source/JavaScriptCore

Rename RegisterSet to TempRegisterSet
https://bugs.webkit.org/show_bug.cgi?id=123077

Reviewed by Dan Bernstein.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/StructureStubInfo.h:
dfg/DFGJITCompiler.h:
dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::usedRegisters):

jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdGenerator::JITGetByIdGenerator):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

jit/RegisterSet.h: Removed.
jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):

jit/TempRegisterSet.h: Copied from Source/JavaScriptCore/jit/RegisterSet.h.

(JSC::TempRegisterSet::TempRegisterSet):
(JSC::TempRegisterSet::asPOD):
(JSC::TempRegisterSet::copyInfo):

8:51 PM Changeset in webkit [157692] by ap@apple.com

2 edits in trunk/Tools

Mac build fix.

DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.

8:15 PM Changeset in webkit [157691] by ap@apple.com

11 edits
3 copies in trunk

Enable webaudio/ tests on DRT/Mac
https://bugs.webkit.org/show_bug.cgi?id=86914

Reviewed by Darin Adler.

Tools:

DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.

There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.

DumpRenderTree/TestRunner.cpp:

(setAudioResultCallback):
(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:

(TestRunner::audioResult):
(TestRunner::setAudioResult):
The function has a different name and argument type now, updated accordingly.
Changed buffer from std::string to std::vector<char>, because it's more idiomatic.

DumpRenderTree/mac/DumpRenderTree.mm:

(dumpAudio): Updated for the new name of audioResult accessor.
(dump): Print the result in the format webkitpy currently expects.

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
chunks made no sense.

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.

DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,

so that "SourceProvider.h" can be found.

LayoutTests:

TestExpectations: Moved webaudio/javascriptaudionode here, as garbage collection

issues with it are cross-platform.

platform/mac-wk2/TestExpectations: Moved out everything, as there is nothing

WK2 specific about WebAudio.

platform/mac/TestExpectations: WebAudio expectations here were just ignored. Replaced

with slightly updated expectations from WK2.

7:07 PM Changeset in webkit [157690] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

Restructure LinkBuffer to allow for alternate allocation strategies
https://bugs.webkit.org/show_bug.cgi?id=123071

Reviewed by Oliver Hunt.

The idea is to eventually allow a LinkBuffer to place the code into an already
allocated region of memory. That region of memory could be the nop-slide left behind
by a llvm.webkit.patchpoint.

assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::buffer):

assembler/AssemblerBuffer.h:
assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::allocate):
(JSC::LinkBuffer::shrink):

assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::didFailToAllocate):

assembler/X86Assembler.h:

(JSC::X86Assembler::buffer):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):

5:24 PM Changeset in webkit [157689] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Adding test case for text-decoration property state change on applying different command
https://bugs.webkit.org/show_bug.cgi?id=123073

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-19
Reviewed by Ryosuke Niwa.

This test case verify text-decoration property state on element after
applying editing commands related to text-decoration.

editing/style/text-decoration-state-change-expected.txt: Added.
editing/style/text-decoration-state-change.html: Added.

5:01 PM Changeset in webkit [157688] by ap@apple.com

8 edits in trunk/Source/JavaScriptCore

Some includes in JSC seem to use an incorrect style
https://bugs.webkit.org/show_bug.cgi?id=123057

Reviewed by Geoffrey Garen.

Changed pseudo-system includes to user ones.

API/JSContextRef.cpp:
API/JSStringRefCF.cpp:
API/JSValueRef.cpp:
API/OpaqueJSString.cpp:
jit/JIT.h:
parser/SyntaxChecker.h:
runtime/WeakGCMap.h:

4:38 PM Changeset in webkit [157687] by rniwa@webkit.org

3 edits in trunk/Tools

run-webkit-tests should submit time and modifiers to the new flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123070

Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
in the test expectations when this argument is set to true.

4:18 PM Changeset in webkit [157686] by ap@apple.com

3 edits in trunk/Tools

Mac DumpRenderTree builds without NDEBUG even in release mode
https://bugs.webkit.org/show_bug.cgi?id=123066

Reviewed by Dan Bernstein.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/mac/Configurations/Base.xcconfig:

Use the same pattern as WebCore and WebKitTestRunner.

4:13 PM Changeset in webkit [157685] by fpizlo@apple.com

18 edits
4 adds in trunk/Source/JavaScriptCore

Baseline JIT and DFG IC code generation should be unified and rationalized
https://bugs.webkit.org/show_bug.cgi?id=122939

Reviewed by Geoffrey Garen.

Introduce the JITInlineCacheGenerator, which takes a CodeBlock and a CodeOrigin plus
some register info and creates JIT inline caches for you. Used this to even furhter
unify the baseline and DFG ICs. In the future we can use this for FTL ICs. And my hope
is that we'll be able to use it for cascading ICs: an IC for some instruction may realize
that it needs to do the equivalent of get_by_id, so with this generator it will be able
to create an IC even though it wasn't associated with a get_by_id bytecode instruction.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::DataLabelCompact::label):

bytecode/CodeBlock.h:

(JSC::CodeBlock::ecmaMode):

dfg/DFGInlineCacheWrapper.h: Added.

(JSC::DFG::InlineCacheWrapper::InlineCacheWrapper):

dfg/DFGInlineCacheWrapperInlines.h: Added.

(JSC::DFG::::finalize):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addGetById):
(JSC::DFG::JITCompiler::addPutById):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::isStrictModeFor):
(JSC::AssemblyHelpers::strictModeFor):

jit/GPRInfo.h:

(JSC::JSValueRegs::tagGPR):

jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

jit/JIT.h:
jit/JITInlineCacheGenerator.cpp: Added.

(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastPathChecks):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::slowPathFunction):

jit/JITInlineCacheGenerator.h: Added.

(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITInlineCacheGenerator::stubInfo):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITByIdGenerator::reportSlowPathCall):
(JSC::JITByIdGenerator::slowPathJump):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

jit/RegisterSet.h:

(JSC::RegisterSet::set):

2:56 PM Changeset in webkit [157684] by ap@apple.com

2 edits in trunk/Source/JavaScriptCore

APICast.h uses functions from JSCJSValueInlines.h, but doesn't include it
https://bugs.webkit.org/show_bug.cgi?id=123067

Reviewed by Geoffrey Garen.

API/APICast.h: Include it.

2:43 PM Changeset in webkit [157683] by weinig@apple.com

20 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Andreas Kling.

Fix classes derived from RenderBlockFlow that were still calling up to RenderBlock rather than RenderBlockFlow.

rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::paint):

rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::computePreferredLogicalWidths):
(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):

rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::styleDidChange):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::nodeAtPoint):

rendering/RenderFullScreen.cpp:

(RenderFullScreenPlaceholder::willBeDestroyed):

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::styleDidChange):

rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::styleDidChange):
(WebCore::RenderMultiColumnBlock::updateLogicalWidthAndColumnWidth):
(WebCore::RenderMultiColumnBlock::addChild):

rendering/RenderProgress.cpp:

(WebCore::RenderProgress::updateFromElement):

rendering/RenderRuby.cpp:

(WebCore::RenderRubyAsBlock::styleDidChange):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):

rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::layout):

rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::textAlignmentForLine):
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):

rendering/RenderTableCaption.cpp:

(WebCore::RenderTableCaption::willBeRemovedFromTree):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::willBeRemovedFromTree):
(WebCore::RenderTableCell::computePreferredLogicalWidths):
(WebCore::RenderTableCell::offsetFromContainer):
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::styleDidChange):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::paint):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):

rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::layout):

rendering/RenderView.cpp:

(WebCore::RenderView::layoutContent):
(WebCore::RenderView::addChild):
(WebCore::RenderView::visualOverflowRect):
(WebCore::RenderView::styleDidChange):

rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::setStyle):
(WebCore::RenderSVGBlock::updateFromStyle):
(WebCore::RenderSVGBlock::willBeDestroyed):
(WebCore::RenderSVGBlock::styleWillChange):
(WebCore::RenderSVGBlock::styleDidChange):

rendering/svg/SVGTextQuery.cpp:

(WebCore::flowBoxForRenderer):

2:25 PM Changeset in webkit [157682] by zandobersek@gmail.com

24 edits
3 adds in trunk/Tools

REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
https://bugs.webkit.org/show_bug.cgi?id=123064

Reviewed by Ryosuke Niwa.

Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.

Scripts/webkitpy/common/config/ports.py: Added.

(DeprecatedPort):
(DeprecatedPort.name):
(DeprecatedPort.flag):
(DeprecatedPort.script_path):
(DeprecatedPort.script_shell_command):
(DeprecatedPort.port):
(DeprecatedPort.makeArgs):
(DeprecatedPort.update_webkit_command):
(DeprecatedPort.check_webkit_style_command):
(DeprecatedPort.prepare_changelog_command):
(DeprecatedPort.build_webkit_command):
(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort.run_webkit_unit_tests_command):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_perl_unittests_command):
(DeprecatedPort.run_bindings_tests_command):
(MacPort):
(MacWK2Port):
(MacWK2Port.run_webkit_tests_command):
(WinPort):
(WinPort.run_bindings_tests_command):
(GtkPort):
(GtkPort.build_webkit_command):
(GtkPort.run_webkit_tests_command):
(GtkWK2Port):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port.run_webkit_tests_command):
(QtPort):
(QtPort.build_webkit_command):
(QtPort.run_webkit_tests_command):
(QtWK2Port):
(QtWK2Port.build_webkit_command):
(QtWK2Port.run_webkit_tests_command):
(EflPort):
(EflPort.build_webkit_command):
(EflWK2Port):
(EflWK2Port.build_webkit_command):

Scripts/webkitpy/common/config/ports_mock.py: Added.

(MockPort):
(MockPort.name):
(MockPort.check_webkit_style_command):
(MockPort.update_webkit_command):
(MockPort.build_webkit_command):
(MockPort.prepare_changelog_command):
(MockPort.run_python_unittests_command):
(MockPort.run_perl_unittests_command):
(MockPort.run_javascriptcore_tests_command):
(MockPort.run_webkit_unit_tests_command):
(MockPort.run_webkit_tests_command):
(MockPort.run_bindings_tests_command):

Scripts/webkitpy/common/config/ports_unittest.py: Added.

(DeprecatedPortTest):
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_gtk_wk2_port):
(DeprecatedPortTest.test_efl_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_qt_wk2_port):

Scripts/webkitpy/port/base.py:

(Port._port_flag_for_scripts):
(Port._wk2_port_name):

Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_build_path):

Scripts/webkitpy/port/efl_unittest.py:

(EflPortTest.test_show_results_html_file):

Scripts/webkitpy/port/gtk_unittest.py:

(GtkPortTest.test_get_crash_log):

Scripts/webkitpy/port/mac_unittest.py:

(test_64bit):

Scripts/webkitpy/port/test.py:

(TestPort.virtual_test_suites):

Scripts/webkitpy/tool/bot/flakytestreporter.py:

(FlakyTestReporter.init):

Scripts/webkitpy/tool/bot/irc_command.py:

(Rollout._update_working_copy):

Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.run_command):

Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue.begin_work_queue):
(CommitQueue.run_command):

Scripts/webkitpy/tool/main.py:

(WebKitPatch.init):
(WebKitPatch.deprecated_port):
(WebKitPatch.handle_global_options):

Scripts/webkitpy/tool/mocktool.py:

(MockTool.init):
(MockTool.deprecated_port):

Scripts/webkitpy/tool/steps/build.py:

(Build.build):

Scripts/webkitpy/tool/steps/checkstyle.py:

(CheckStyle.run):

Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.run):

Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:

(PrepareChangeLogForRevert.run):

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_runtests_args):

Scripts/webkitpy/tool/steps/update.py:

(Update._update_command):

Scripts/webkitpy/tool/steps/update_unittest.py:

(UpdateTest.test_update_command_non_interactive):
(UpdateTest.test_update_command_interactive):

2:09 PM Changeset in webkit [157681] by mitz@apple.com

20 edits in trunk/Source/WebKit2

Fix the Mac 32-bit build by reverting r157676, r157678, and r157679.

2:03 PM Changeset in webkit [157680] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

FTL::Location should treat the offset as an addend in the case of a Register location
https://bugs.webkit.org/show_bug.cgi?id=123062

Reviewed by Sam Weinig.

ftl/FTLLocation.cpp:

(JSC::FTL::Location::forStackmaps):
(JSC::FTL::Location::dump):
(JSC::FTL::Location::restoreInto):

ftl/FTLLocation.h:

(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::hasAddend):
(JSC::FTL::Location::addend):

1:56 PM Changeset in webkit [157679] by mitz@apple.com

3 edits in trunk/Source/WebKit2

Try to fix the Mac 32-bit build.

UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

1:47 PM Changeset in webkit [157678] by mitz@apple.com

5 edits in trunk/Source/WebKit2

Try to fix the Mac 32-bit build.

UIProcess/API/mac/WKView.h:
UIProcess/API/mac/WKView.mm:
UIProcess/API/mac/WKViewInternal.h:
UIProcess/API/mac/WKViewPrivate.h:

1:26 PM Changeset in webkit [157677] by weinig@apple.com

6 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Andreas Kling.

Move containsNonZeroBidiLevel to RenderBlockFlow.

editing/Editor.cpp:

(WebCore::Editor::hasBidiSelection):

rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::containsNonZeroBidiLevel):

rendering/RenderBlockFlow.h:

1:18 PM Changeset in webkit [157676] by mitz@apple.com

14 edits in trunk/Source/WebKit2

[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065

Reviewed by Sam Weinig.

UIProcess/API/mac/WKBrowsingContextController.h: Added WK_API_ENABLED guard. Removed _data

ivar and WKBrowsingContextControllerData class declaration.

UIProcess/API/mac/WKBrowsingContextController.mm: Added WK_API_ENABLED guard. Removed

WKBrowsingContextControllerData class and moved _pageRef ivar directly into
WKBrowsingContextController, declaring it in the @implementation. Removed ivar and accessors
for the loadDelegate property, letting the compiler synthesize them.
(-[WKBrowsingContextController dealloc]): Removed indirection via _data.
(-[WKBrowsingContextController _pageRef]): Ditto.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.

UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Added WK_API_ENABLED guard.
UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.

UIProcess/API/mac/WKBrowsingContextGroup.h: Added WK_API_ENABLED guard. Removed _data ivar

and WKBrowsingContextGroupData class declaration.

UIProcess/API/mac/WKBrowsingContextGroup.mm: Added WK_API_ENABLED guard. Removed

WKBrowsingContextGroupData class and moved _pageGroupRef ivar directly info
WKBrowsingContextGroup, declaring it in the @implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup _pageGroupRef]): Ditto.

UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Added WK_API_ENABLED guard.

UIProcess/API/mac/WKConnection.h: Added WK_API_ENABLED guard. Removed _data ivar and

WKConnectionData class declaration.

UIProcess/API/mac/WKConnection.mm: Added WK_API_ENABLED guard. Removed WKConnectionData

class and moved _connectionRef ivar directly into WKConnection, declaring it in the
@implementation. Removed ivar and accessors for the delegate property, letting the compiler
synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.

UIProcess/API/mac/WKConnectionInternal.h: Added WK_API_ENABLED guard.

UIProcess/API/mac/WKProcessGroup.h: Added WK_API_ENABLED guard. Replaced forward

declaration of WKConnection with an import. Removed _data ivar and WKProcessGroupData class
declaration.

UIProcess/API/mac/WKProcessGroup.mm: Added WK_API_ENABLED guard. Removed

WKProcessGroupData class and moved _contextRef ivar directly into WKProcessGroup, declaring
it in the @implementation. Removed ivar and accessors for the delegate property, letting the
compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.

UIProcess/API/mac/WKProcessGroupPrivate.h: Added WK_API_ENABLED guard.

1:11 PM Changeset in webkit [157675] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

DFG dominators: document and rename stuff.
https://bugs.webkit.org/show_bug.cgi?id=123056

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-19
Reviewed by Filip Pizlo.

Documented the code and renamed some variables.

dfg/DFGDominators.cpp:

(JSC::DFG::Dominators::compute):
(JSC::DFG::Dominators::pruneDominators):

dfg/DFGDominators.h:

12:55 PM Changeset in webkit [157674] by weinig@apple.com

9 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Antti Koivisto.

Move truncation (e.g. line clamp and ellipse) support to RenderBlockFlow.

rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::EllipsisBox):
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::markupBox):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):

rendering/EllipsisBox.h:
rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:

(WebCore::shouldCheckLines):
(WebCore::RenderBlockFlow::lineAtIndex):
(WebCore::RenderBlockFlow::lineCount):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlockFlow::heightForLineCount):
(WebCore::RenderBlockFlow::clearTruncation):

rendering/RenderBlockFlow.h:
rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis):

12:55 PM Changeset in webkit [157673] by akling@apple.com

4 edits in trunk

RefPtr::releaseNonNull() incorrectly increments the refcount.
<https://webkit.org/b/123063>

Source/WTF:

Make releaseNonNull() use adoptRef(T&), mirroring release().

Reviewed by Anders Carlsson.

Tools:

Add an API test to verify that no extra refs are added when calling
RefPtr::releaseNonNull().

Reviewed by Anders Carlsson.

9:48 AM Changeset in webkit [157672] by akling@apple.com

4 edits in trunk/Source/WebCore

StyleResolver should deal in PassRef<RenderStyle> where possible.
<https://webkit.org/b/123061>

Make StyleResolver functions that returned or took RenderStyles
by PassRefPtr use PassRef instead where possible.

Reviewed by Anders Carlsson.

9:41 AM Changeset in webkit [157671] by beidson@apple.com

16 edits in trunk/Source/WebCore

Global rename of the class "IDBBackingStore" to "IDBBackingStoreLevelDB"

Rubberstamped by Anders Carlsson (And Andreas Kling wanted to, but he wasn’t around)

Modules/indexeddb/IDBTransactionBackendInterface.h:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:

9:41 AM Changeset in webkit [157670] by ap@apple.com

1 edit
2 copies
1 add
1 delete in trunk/LayoutTests

WebAudio Mac expected results were misplaced - they apply equally to WK1 and WK2.
We didn't notice before because all these tests are disabled on WK1.

platform/mac-wk2/webaudio: Removed.
platform/mac/webaudio: Added.
platform/mac/webaudio/audiobuffersource-playbackrate-expected.wav: Copied from LayoutTests/platform/mac-wk2/webaudio/audiobuffersource-playbackrate-expected.wav.
platform/mac/webaudio/codec-tests: Copied from LayoutTests/platform/mac-wk2/webaudio/codec-tests.

platform/mac-wk2/webaudio/audiobuffersource-loop-points-expected.wav: Removed.

This test is skipped, because it times out.

7:42 AM Changeset in webkit [157669] by commit-queue@webkit.org

3 edits
1 add in trunk/Source/WebCore

[WinCairo] Link fails.
https://bugs.webkit.org/show_bug.cgi?id=123019

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-19
Reviewed by Darin Adler.

Added empty CertificateInfo implementation for Curl.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
platform/network/curl/CertificateInfoCurl.cpp: Added.

(WebCore::CertificateInfo::CertificateInfo):
(WebCore::CertificateInfo::~CertificateInfo):

7:34 AM Changeset in webkit [157668] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Fix build failure for architectures with 4 argument registers.
https://bugs.webkit.org/show_bug.cgi?id=123060

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-19
Reviewed by Michael Saboff.

Add missing setupArgumentsWithExecState() prototypes for architecture with 4 argument registers.
Remove SH4 specific code no longer needed since callOperation prototype change in r157660.

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

jit/JITInlines.h:

(JSC::JIT::callOperation):

7:33 AM Changeset in webkit [157667] by fpizlo@apple.com

3 edits in trunk/Source/WebCore

libWebCoreTestSupport should have explicit exports
https://bugs.webkit.org/show_bug.cgi?id=123053

Reviewed by Oliver Hunt.

No new tests because there is no change in behavior.

Configurations/WebCoreTestSupport.xcconfig:
testing/js/WebCoreTestSupport.h:

7:26 AM Changeset in webkit [157666] by akling@apple.com

4 edits in trunk/Source

Attempt to get Lion building.

Source/WebKit/mac:

WebView/WebDataSource.mm:

Source/WebKit2:

UIProcess/mac/WebColorPickerMac.h:

6:58 AM Changeset in webkit [157665] by akling@apple.com

48 edits in trunk/Source

Start passing RenderStyle around with PassRef.
<https://webkit.org/b/123051>

Source/WebCore:

Made the RenderStyle::create methods return PassRef<RenderStyle>
and RenderElement::setStyle take a PassRef<RenderStyle>.

Reviewed by Darin Adler.

Source/WTF:

Added some new PassRef tricks to make this patch possible.

Reviewed by Darin Adler.

wtf/PassRef.h:

(WTF::PassRef::get):

Added a get() helper to facilitate writing functions that
construct a new object and call some functions on it before
returning it.

(WTF::PassRef::dropRef):

This will deref() the referenced object and mark the PassRef
as "passed." This is used in code paths where the PassRef is
going to go out of scope with nobody to take it over.

(WTF::PassRef::leakRef):

Renamed takeReference() to leakRef() and made it public so
we don't have to awkwardly sink the PassRef into a Ref for
e.g static locals.

wtf/RefPtr.h:

(WTF::RefPtr::releaseNonNull):

Added RefPtr::releaseNonNull() for a convenient way of creating
a PassRef<T> from a RefPtr<T>. This function may only be called
if the RefPtr is known to be non-null.

Oct 18, 2013:

11:47 PM Changeset in webkit [157664] by jinwoo7.song@samsung.com

3 edits
5 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Remove EFL-specific test expectations that were identical to generic expectations
and rebaseline test cases.

platform/efl-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
platform/efl-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Removed.
platform/efl/compositing/backing/no-backing-for-clip-overhang-expected.txt: Removed.
platform/efl/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Removed.
platform/efl/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Removed.
platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Rebaselined after r154896.
platform/efl/svg/batik/paints/gradientLimit-expected.txt: Updating baselines after enabling the subpixel layout.

9:28 PM Changeset in webkit [157663] by jinwoo7.song@samsung.com

2 edits in trunk/LayoutTests

Update EFL test expectations.

platform/efl/TestExpectations:

8:14 PM Changeset in webkit [157662] by weinig@apple.com

17 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Dan Bernstein.

Make the RootInlineBox constructor take a RenderBlockFlow.
Move createRootInlineBox, and createAndAppendRootInlineBox to RenderBlockFlow.

editing/VisibleUnits.cpp:

(WebCore::absoluteLineDirectionPointToLocalPointInBlock):

rendering/InlineBox.cpp:

(WebCore::InlineBox::locationIncludingFlipping):
(WebCore::InlineBox::flipForWritingMode):

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):

rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderBlockFlow.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createRootInlineBox):
(WebCore::RenderBlockFlow::createAndAppendRootInlineBox):
(WebCore::createInlineBoxForRenderer):
(WebCore::RenderBlockFlow::createLineBoxes):

rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::localSelectionRect):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::localSelectionRect):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::rendererLineBoxes):
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::setContainingRegion):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::lineSnapAdjustment):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::computeCaretRect):
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
(WebCore::RootInlineBox::selectionBottom):
(WebCore::RootInlineBox::blockDirectionPointInLine):
(WebCore::RootInlineBox::blockFlow):
(WebCore::RootInlineBox::closestLeafChildForPoint):
(WebCore::RootInlineBox::removeLineBoxFromRenderObject):
(WebCore::RootInlineBox::extractLineBoxFromRenderObject):
(WebCore::RootInlineBox::attachLineBoxToRenderObject):

rendering/RootInlineBox.h:
rendering/TrailingFloatsRootInlineBox.h:
rendering/svg/RenderSVGText.h:

(WebCore::toRenderSVGText):

rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::renderSVGText):
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutRootBox):

rendering/svg/SVGRootInlineBox.h:

7:37 PM Changeset in webkit [157661] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix FTL build.

ftl/FTLIntrinsicRepository.h:
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetById):

7:20 PM Changeset in webkit [157660] by fpizlo@apple.com

30 edits
1 add in trunk/Source

A CodeBlock's StructureStubInfos shouldn't be in a Vector that we search using code origins and machine code PCs
https://bugs.webkit.org/show_bug.cgi?id=122940

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This accomplishes a number of simplifications. StructureStubInfo is now non-moving,
whereas previously it was in a Vector, so it moved. This allows you to use pointers to
StructureStubInfo. This also eliminates the use of return PC as a way of finding the
StructureStubInfo's. It removes some of the need for the compile-time property access
records; for example the DFG no longer has to save information about registers in a
property access record only to later save it to the stub info.

The main thing is accomplishes is that it makes it easier to add StructureStubInfo's
at any stage of compilation.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::addStubInfo):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::shrinkToFit):

bytecode/CodeBlock.h:

(JSC::CodeBlock::begin):
(JSC::CodeBlock::end):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):

bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isHashTableDeletedValue):
(JSC::CodeOrigin::hash):
(JSC::CodeOriginHash::hash):
(JSC::CodeOriginHash::equal):

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

bytecode/GetByIdStatus.h:
bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

bytecode/PutByIdStatus.h:
bytecode/StructureStubInfo.h:

(JSC::getStructureStubInfoCodeOrigin):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::InRecord::InRecord):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):
(JSC::JIT::privateCompile):

jit/JIT.h:

(JSC::PropertyStubCompilationInfo::slowCaseInfo):

jit/JITInlines.h:

(JSC::JIT::callOperation):

jit/JITOperations.cpp:
jit/JITOperations.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

jit/Repatch.cpp:

(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::resetPutByID):

Source/WTF:

Reviewed by Oliver Hunt.

GNUmakefile.list.am:
WTF.vcxproj/WTF.vcxproj:
WTF.xcodeproj/project.pbxproj:
wtf/BagToHashMap.h: Added.

(WTF::toHashMap):

wtf/CMakeLists.txt:

6:47 PM Changeset in webkit [157659] by rniwa@webkit.org

4 edits
4 adds in trunk/Websites/test-results

New flakiness dashboard should support showing the failing tests per builder
https://bugs.webkit.org/show_bug.cgi?id=123011

Reviewed by Timothy Hatcher.

Added the feature. Also did some refactoring to add this feature.

ChangeLog: Added.
api/failing-tests.php: Added.
api/manifest.php: Removed the code to make maps by id. The work is now done in index.html.
api/results.php:
common.css: Added. Extracted from index.html.
include/test-results.php: Extracted parse_revisions_array and format_result_rows from results.php.
index.html:
main.css: Added.

(TestResultsView.setAvailableTests): Added.
(TestResultsView.showTooltip): Fixed the code to compute x and y coordinates of the tooltip to take
scrolled positions into account.
(TestResultsView._createTestResultRow): Extracted from _populateTestPane.
(TestResultsView.fetchTest): Added the code to show "Loading..." in the pane while loading the JSON.
(TestResultsView.fetchTests): Respect the doNotUpdateHash flag.
(TestResultsView._populateBuilderPane): Added.
(TestResultsView.fetchFailingTestsForBuilder): Added.
(TestResultsView.updateLocationHash): Serialize builder & builderDays.
(TestResultsView.locationHashChanged): Don't delete existing test panes since that's now done in
loadTestsFromLocationHash.
(TestResultsView.loadTestsFromLocationHash): Take care of both 'tests' and 'builder' components.
(fetchManifest): Setup the UI to select a builder.

5:51 PM Changeset in webkit [157658] by timothy_horton@apple.com

9 edits in trunk/Source

Remote Layer Tree: Double-buffering and minimization of repaints
https://bugs.webkit.org/show_bug.cgi?id=123043

Reviewed by Simon Fraser.

No new tests, not yet testable.

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::ensureBackingStore):
Don't worry about isOpaque with RemoteLayerBackingStore; this is a
optimization that is causing trouble; we can re-add it later.

(PlatformCALayerRemote::setBounds):
Make sure that we will repaint if our bounds change.

WebProcess/WebPage/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::bitmap):
Keep a front and back buffer; return the front buffer when being asked for the bitmap.
Keep a Region of repaint areas.

WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
Serialize only the front buffer, since the UI process only needs that.

(RemoteLayerBackingStore::setNeedsDisplay):
Store repaint rects instead of always setting the whole layer to be dirty.

(RemoteLayerBackingStore::display):
Paint into the back buffer (copying valid parts over from the front buffer),
then swap it to the front buffer. Use drawLayerContents so we get repaint counters, etc.

WebCore.exp.in:

Export one version of drawLayerContents and Region::contains.

WebCore.xcodeproj/project.pbxproj:

Expose WebLayer.h as a private header.

platform/graphics/mac/WebLayer.h:

Clean up this header, and add a new drawLayerContents that can operate without a CALayer.

platform/graphics/mac/WebLayer.mm:

(WebCore::drawLayerContents):
Split drawLayerContents into one method that acquires properties CALayer,
and one that just does the painting.

5:46 PM Changeset in webkit [157657] by andersca@apple.com

4 edits in trunk/Source

Try to fix the Lion build.

Source/WebCore:

bindings/objc/ObjCNodeFilterCondition.h:

Source/WebKit2:

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

5:09 PM Changeset in webkit [157656] by oliver@apple.com

36 edits in trunk

Spread operator should be performing direct "puts" and not triggering setters
https://bugs.webkit.org/show_bug.cgi?id=123047

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add a new opcode -- op_put_by_val_directue -- and make use of it in the spread
to array construct. This required a new PutByValDirect node to be introduced to
the DFG. The current implementation simply changes the slow path function that
is called, but in future this could be made faster as it does not need to check
the prototype chain.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

bytecode/Opcode.h:

(JSC::padOpcodeName):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDirectPutByVal):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.h:

(JSC::DFG::Graph::clobbersWorld):

dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):
(JSC::DFG::operationPutByValInternal):

dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:

(JSC::JIT::compileDirectPutByVal):

jit/JITOperations.cpp:
jit/JITOperations.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompilePutByVal):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_put_by_val):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

LayoutTests:

Add a new testcase for the setter case. run-javascriptcore-tests hits this with
the llint, baseline, and dfg.

js/basic-spread-expected.txt:
js/script-tests/basic-spread.js:

(Array):

5:05 PM Changeset in webkit [157655] by dbates@webkit.org

2 edits in trunk/Source/JavaScriptCore

[iOS] Export symbol for VM::sharedInstanceExists()
https://bugs.webkit.org/show_bug.cgi?id=123046

Reviewed by Mark Hahnenberg.

runtime/VM.h:

4:57 PM Changeset in webkit [157654] by dbates@webkit.org

8 edits
2 adds in trunk/Source

[iOS] Upstream WebSafe{GCActivityCallback, IncrementalSweeper}IOS
https://bugs.webkit.org/show_bug.cgi?id=123049

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

heap/Heap.cpp:

(JSC::Heap::setIncrementalSweeper):

heap/Heap.h:
heap/HeapTimer.h:
heap/IncrementalSweeper.h: Make protected and export CF-variant of constructor.

Removed unused include of header RetainPtr.h. Also forward declare class MarkedBlock
(we include its header in the .cpp file) and remove include for header wtf/HashSet.h
(duplicates the include in the .cpp).

heap/MachineStackMarker.h: Export function makeUsableFromMultipleThreads(). We aren't

making use of this now, but we'll make use of it in a subsequent patch.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:
platform/ios/WebSafeGCActivityCallbackIOS.h: Added.
platform/ios/WebSafeIncrementalSweeperIOS.h: Added.

4:41 PM Changeset in webkit [157653] by andersca@apple.com

573 edits in trunk/Source

Remove spaces between template angle brackets
https://bugs.webkit.org/show_bug.cgi?id=123040

Reviewed by Andreas Kling.

Source/JavaScriptCore:

API/JSCallbackObject.cpp:

(JSC::::create):

API/JSObjectRef.cpp:
bytecode/CodeBlock.h:

(JSC::CodeBlock::constants):
(JSC::CodeBlock::setConstantRegisters):

bytecode/DFGExitProfile.h:
bytecode/EvalCodeCache.h:
bytecode/Operands.h:
bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::constantRegisters):

bytecode/Watchpoint.h:
bytecompiler/BytecodeGenerator.h:
bytecompiler/StaticPropertyAnalysis.h:
bytecompiler/StaticPropertyAnalyzer.h:
dfg/DFGArgumentsSimplificationPhase.cpp:
dfg/DFGBlockInsertionSet.h:
dfg/DFGCSEPhase.cpp:

(JSC::DFG::performCSE):
(JSC::DFG::performStoreElimination):

dfg/DFGCommonData.h:
dfg/DFGDesiredStructureChains.h:
dfg/DFGDesiredWatchpoints.h:
dfg/DFGJITCompiler.h:
dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGWorklist.h:
heap/BlockAllocator.h:

(JSC::CopiedBlock):
(JSC::MarkedBlock):
(JSC::WeakBlock):
(JSC::MarkStackSegment):
(JSC::CopyWorkListSegment):
(JSC::HandleBlock):

heap/Heap.h:
heap/Local.h:
heap/MarkedBlock.h:
heap/Strong.h:
jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::decodedCodeMapFor):

jit/AssemblyHelpers.h:
jit/SpecializedThunkJIT.h:
parser/Nodes.h:
parser/Parser.cpp:

(JSC::::parseIfStatement):

parser/Parser.h:

(JSC::Scope::copyCapturedVariablesToVector):
(JSC::parse):

parser/ParserArena.h:
parser/SourceProviderCacheItem.h:
profiler/LegacyProfiler.cpp:

(JSC::dispatchFunctionToProfiles):

profiler/LegacyProfiler.h:

(JSC::LegacyProfiler::currentProfiles):

profiler/ProfileNode.h:

(JSC::ProfileNode::children):

profiler/ProfilerDatabase.h:
runtime/Butterfly.h:

(JSC::Butterfly::contiguousInt32):
(JSC::Butterfly::contiguous):

runtime/GenericTypedArrayViewInlines.h:

(JSC::::create):

runtime/Identifier.h:

(JSC::Identifier::add):

runtime/JSPromise.h:
runtime/PropertyMapHashTable.h:
runtime/PropertyNameArray.h:
runtime/RegExpCache.h:
runtime/SparseArrayValueMap.h:
runtime/SymbolTable.h:
runtime/VM.h:
tools/CodeProfile.cpp:

(JSC::truncateTrace):

tools/CodeProfile.h:
yarr/YarrInterpreter.cpp:
yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileBody):

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):

yarr/YarrPattern.h:

Source/WebCore:

Modules/encryptedmedia/MediaKeySession.h:
Modules/encryptedmedia/MediaKeys.h:
Modules/geolocation/Geolocation.h:
Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):

Modules/geolocation/GeolocationController.h:
Modules/indexeddb/IDBCallbacks.h:
Modules/indexeddb/IDBDatabase.h:
Modules/indexeddb/IDBDatabaseBackendInterface.h:
Modules/indexeddb/IDBEventDispatcher.cpp:

(WebCore::IDBEventDispatcher::dispatch):

Modules/indexeddb/IDBEventDispatcher.h:
Modules/indexeddb/IDBKey.h:
Modules/indexeddb/IDBObjectStore.h:
Modules/indexeddb/IDBPendingTransactionMonitor.cpp:
Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

Modules/indexeddb/IDBRequest.h:

(WebCore::IDBRequest::onSuccessWithPrefetch):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::dispatchEvent):

Modules/indexeddb/IDBTransaction.h:
Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::sortedTrackListForMenu):

Modules/mediacontrols/MediaControlsHost.h:
Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::activeRanges):

Modules/mediasource/MediaSource.h:
Modules/mediasource/MediaSourceBase.cpp:

(WebCore::MediaSourceBase::buffered):

Modules/mediasource/MediaSourceBase.h:
Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::unregisterURL):

Modules/mediasource/MediaSourceRegistry.h:
Modules/mediasource/SourceBufferList.h:
Modules/mediasource/WebKitMediaSource.cpp:

(WebCore::WebKitMediaSource::activeRanges):

Modules/mediasource/WebKitMediaSource.h:
Modules/mediasource/WebKitSourceBufferList.h:
Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::scheduledEventTimerFired):

Modules/mediastream/MediaStream.h:
Modules/mediastream/MediaStreamRegistry.h:
Modules/mediastream/MediaStreamTrack.h:
Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::scheduledEventTimerFired):

Modules/mediastream/RTCDTMFSender.h:
Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::scheduledEventTimerFired):

Modules/mediastream/RTCDataChannel.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):

Modules/mediastream/RTCPeerConnection.h:
Modules/mediastream/RTCStatsResponse.h:

(WebCore::RTCStatsResponse::result):

Modules/notifications/Notification.h:
Modules/notifications/NotificationCenter.h:
Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::getVoices):

Modules/speech/SpeechSynthesis.h:
Modules/webaudio/AudioBuffer.h:
Modules/webaudio/AudioNode.h:
Modules/webaudio/AudioNodeOutput.h:
Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::setAudioFormat):
(WebCore::MediaStreamAudioSource::consumeAudio):

Modules/webaudio/PeriodicWave.h:
Modules/webaudio/ScriptProcessorNode.h:
Modules/webdatabase/AbstractDatabaseServer.h:
Modules/webdatabase/DatabaseBackend.h:
Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::origins):

Modules/webdatabase/DatabaseManager.h:
Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::origins):

Modules/webdatabase/DatabaseServer.h:
Modules/webdatabase/DatabaseThread.h:
Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteAllDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

Modules/webdatabase/DatabaseTracker.h:
Modules/webdatabase/SQLStatementBackend.cpp:
Modules/webdatabase/SQLTransactionBackend.cpp:
Modules/webdatabase/SQLTransactionBackend.h:
Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::shutdown):

Modules/webdatabase/SQLTransactionCoordinator.h:
Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):

Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

Modules/websockets/WebSocket.h:
Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):

Modules/websockets/WebSocketChannel.h:
Modules/websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::didReceiveBinaryData):

Modules/websockets/WebSocketExtensionDispatcher.h:
Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerGlobalScopeDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

Modules/websockets/WorkerThreadableWebSocketChannel.h:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):

accessibility/AXObjectCache.h:
accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::ariaLabeledByText):

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityText::AccessibilityText):

bindings/js/DOMWrapperWorld.h:
bindings/js/JSDOMBinding.h:

(WebCore::toRefPtrNativeArray):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSMutationCallback.cpp:

(WebCore::JSMutationCallback::call):

bindings/js/JSMutationCallback.h:
bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::getAttachedShaders):

bindings/js/PageScriptDebugServer.h:
bindings/js/ScheduledAction.h:
bindings/js/ScriptController.cpp:

(WebCore::ScriptController::collectIsolatedContexts):

bindings/js/ScriptController.h:
bindings/js/ScriptDebugServer.h:
bindings/js/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor):

bindings/objc/ObjCNodeFilterCondition.h:
bridge/objc/objc_class.h:
bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):

bridge/runtime_root.h:
css/BasicShapeFunctions.cpp:

(WebCore::basicShapeForValue):

css/CSSBasicShapes.h:

(WebCore::CSSBasicShapePolygon::values):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForFilter):

css/CSSFontFace.h:
css/CSSFontFaceSource.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontFace):
(WebCore::CSSFontSelector::beginLoadTimerFired):

css/CSSFontSelector.h:
css/CSSGroupingRule.h:
css/CSSImageGeneratorValue.h:
css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::adoptSelectorVector):

css/CSSParserValues.h:
css/CSSPropertySourceData.h:
css/CSSRuleList.h:

(WebCore::StaticCSSRuleList::rules):

css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::fontLoaded):

css/CSSSegmentedFontFace.h:
css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::adoptSelectorVector):

css/CSSSelectorList.h:
css/CSSStyleSheet.h:
css/CSSValue.h:

(WebCore::compareCSSValueVector):

css/CSSValuePool.h:
css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets):
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):

css/DocumentRuleSets.h:
css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchedRuleList):

css/ElementRuleCollector.h:
css/FontLoader.h:
css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):

css/InspectorCSSOMWrappers.h:
css/MediaList.cpp:

(WebCore::MediaQuerySet::parse):
(WebCore::MediaList::item):
(WebCore::reportMediaQueryWarningIfNeeded):

css/MediaList.h:

(WebCore::MediaQuerySet::queryVector):

css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::eval):

css/MediaQueryMatcher.h:
css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

css/PropertySetCSSStyleDeclaration.h:
css/RuleSet.cpp:

(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addChildRules):
(WebCore::RuleSet::addRulesFromSheet):

css/RuleSet.h:
css/SelectorFilter.h:
css/StyleInvalidationAnalysis.cpp:

(WebCore::StyleInvalidationAnalysis::analyzeStyleSheet):

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

css/StyleResolver.cpp:

(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::styleRulesForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::loadPendingShaders):

css/StyleResolver.h:
css/StyleRule.cpp:

(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
(WebCore::StyleRuleGroup::StyleRuleGroup):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleSupports::StyleRuleSupports):
(WebCore::StyleRuleRegion::StyleRuleRegion):

css/StyleRule.h:

(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleGroup::childRules):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleSupports::create):
(WebCore::StyleRuleRegion::create):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::StyleRuleHost):

css/StyleScopeResolver.h:
css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::childRulesHaveFailedOrCanceledSubresources):

css/StyleSheetContents.h:

(WebCore::StyleSheetContents::childRules):
(WebCore::StyleSheetContents::importRules):

css/StyleSheetList.cpp:

(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::item):

css/StyleSheetList.h:
css/WebKitCSSKeyframesRule.h:

(WebCore::StyleRuleKeyframes::keyframes):

dom/CheckedRadioButtons.h:
dom/ClientRectList.h:
dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):

dom/CrossThreadTask.h:
dom/Document.cpp:

(WebCore::Document::webkitCancelFullScreen):
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):

dom/Document.h:
dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::removeMarkers):

dom/DocumentMarkerController.h:
dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets):
(WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

dom/DocumentStyleSheetCollection.h:
dom/Element.cpp:

(WebCore::Element::attrNodeList):
(WebCore::Element::webkitGetRegionFlowRanges):

dom/Element.h:
dom/EventListenerMap.h:
dom/EventSender.h:

(WebCore::EventSender::timerFired):

dom/IdTargetObserverRegistry.h:
dom/MutationCallback.h:
dom/MutationObserver.cpp:

(WebCore::MutationObserver::takeRecords):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::deliverAllMutations):

dom/MutationObserver.h:
dom/MutationObserverRegistration.h:
dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::namedFlows):

dom/NamedFlowCollection.h:
dom/Node.cpp:

(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):

dom/Node.h:
dom/NodeRareData.h:
dom/Range.cpp:

(WebCore::Range::processContents):
(WebCore::Range::processNodes):
(WebCore::Range::processAncestorsAndTheirSiblings):

dom/Range.h:
dom/ScopedEventQueue.h:
dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::reportException):

dom/ScriptExecutionContext.h:
dom/ScriptedAnimationController.h:
editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::removeChildrenInRange):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

editing/CompositeEditCommand.h:
editing/EditingStyle.cpp:

(WebCore::htmlElementEquivalents):
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement):
(WebCore::htmlAttributeEquivalents):
(WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes):
(WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::styleFromMatchedRulesForElement):

editing/Editor.cpp:

(WebCore::Editor::countMatchesForText):

editing/Editor.h:
editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock):
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
(WebCore::InsertParagraphSeparatorCommand::doApply):

editing/InsertParagraphSeparatorCommand.h:
editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):

editing/RemoveNodePreservingChildrenCommand.cpp:

(WebCore::RemoveNodePreservingChildrenCommand::doApply):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeUnrenderedNodes):

editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):

editing/SimplifyMarkupCommand.h:
editing/SpellChecker.h:
editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::executeApply):
(WebCore::SplitElementCommand::doUnapply):

editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::executeApply):
(WebCore::WrapContentsInDummySpanCommand::doUnapply):

editing/mac/AlternativeTextUIController.h:
fileapi/FileList.h:
history/BackForwardList.h:
history/HistoryItem.cpp:

(WebCore::HistoryItem::setRedirectURLs):

history/HistoryItem.h:
history/mac/HistoryItemMac.mm:

(WebCore::HistoryItem::setTransientProperty):

html/FormController.h:
html/HTMLAnchorElement.cpp:
html/HTMLCollection.cpp:

(WebCore::HTMLCollection::append):

html/HTMLCollection.h:
html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity):

html/HTMLFormControlElement.h:
html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::checkValidity):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):

html/HTMLFormElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::platformTextTracks):
(WebCore::HTMLMediaElement::configureTextTrackGroup):

html/HTMLMediaElement.h:
html/HTMLPlugInImageElement.cpp:
html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setLength):

html/MediaController.cpp:

(MediaController::asyncEventTimerFired):

html/MediaController.h:
html/MediaFragmentURIParser.h:
html/ValidationMessage.h:
html/canvas/WebGLFramebuffer.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getAttachedShaders):

html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLTexture.h:
html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):

html/parser/BackgroundHTMLParser.h:

(WebCore::BackgroundHTMLParser::create):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::startBackgroundParser):

html/parser/HTMLDocumentParser.h:
html/parser/HTMLMetaCharsetParser.h:
html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):

html/parser/HTMLResourcePreloader.h:
html/parser/XSSAuditor.h:
html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ensureInsertionPointList):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):

html/shadow/ContentDistributor.h:
html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

html/shadow/MediaControlElements.h:
html/track/InbandGenericTextTrack.h:
html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newCuesParsed):

html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable):
(WebCore::LoadableTextTrack::newRegionsAvailable):

html/track/TextTrackCueList.h:
html/track/TextTrackList.cpp:

(TextTrackList::invalidateTrackIndexesAfterTrack):
(TextTrackList::remove):
(TextTrackList::contains):

html/track/TextTrackList.h:
html/track/TrackListBase.cpp:

(TrackListBase::asyncEventTimerFired):

html/track/TrackListBase.h:
html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::getNewCues):
(WebCore::WebVTTParser::getNewRegions):

html/track/WebVTTParser.h:
inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::addToFrontend):

inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::lineEndings):
(WebCore::ContentSearchUtils::searchInTextByLines):

inspector/ContentSearchUtils.h:
inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):

inspector/DOMPatchSupport.h:
inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::getInternalProperties):
(WebCore::InjectedScript::wrapCallFrames):

inspector/InjectedScript.h:
inspector/InjectedScriptHost.h:
inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::enable):

inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):

inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorBaseAgent.h:
inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::toInspectorObject):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow):

inspector/InspectorCSSAgent.h:
inspector/InspectorConsoleAgent.h:
inspector/InspectorDOMAgent.cpp:

(WebCore::RevalidateStyleAttributeTask::onTimer):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):

inspector/InspectorDOMAgent.h:
inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):

inspector/InspectorDOMStorageAgent.h:
inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

inspector/InspectorDatabaseAgent.h:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::currentCallFrames):

inspector/InspectorDebuggerAgent.h:
inspector/InspectorHeapProfilerAgent.cpp:

(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):

inspector/InspectorHeapProfilerAgent.h:
inspector/InspectorHistory.h:
inspector/InspectorIndexedDBAgent.cpp:
inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):

inspector/InspectorLayerTreeAgent.h:
inspector/InspectorMemoryAgent.h:
inspector/InspectorPageAgent.cpp:

(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

inspector/InspectorPageAgent.h:
inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):

inspector/InspectorProfilerAgent.h:
inspector/InspectorResourceAgent.h:
inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

inspector/InspectorRuntimeAgent.h:
inspector/InspectorState.h:
inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::InspectorStyle::styleWithProperties):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::lineEndings):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::lineEndings):

inspector/InspectorStyleSheet.h:
inspector/InspectorValues.cpp:

(WebCore::InspectorArrayBase::writeJSON):

inspector/InspectorValues.h:
inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::reportExecutionContextCreation):

inspector/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::buildInspectorArray):

inspector/ScriptCallStack.h:
loader/CrossOriginPreflightResultCache.h:
loader/DocumentLoader.cpp:

(WebCore::cancelAll):
(WebCore::setAllDefersLoading):
(WebCore::DocumentLoader::getSubresources):

loader/DocumentLoader.h:
loader/FormState.h:
loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

loader/ProgressTracker.h:
loader/ResourceLoadScheduler.h:
loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::getNewCues):
(WebCore::TextTrackLoader::getNewRegions):

loader/TextTrackLoader.h:
loader/WorkerThreadableLoader.cpp:

(WebCore::workerGlobalScopeDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):

loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::dump):

loader/appcache/ApplicationCache.h:
loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::getOriginsWithCache):

loader/archive/Archive.cpp:

(WebCore::Archive::clearAllSubframeArchives):
(WebCore::Archive::clearAllSubframeArchivesImpl):

loader/archive/Archive.h:

(WebCore::Archive::subresources):
(WebCore::Archive::subframeArchives):

loader/archive/ArchiveResourceCollection.cpp:

(WebCore::ArchiveResourceCollection::addAllResources):

loader/archive/ArchiveResourceCollection.h:
loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

loader/archive/cf/LegacyWebArchive.h:
loader/archive/mhtml/MHTMLParser.h:
loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.h:
loader/cache/MemoryCache.h:
loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::notifyPendingLoadDecisions):

loader/icon/IconDatabase.h:
page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu):

page/CaptionUserPreferencesMediaAF.h:
page/ChromeClient.h:

(WebCore::ChromeClient::didAssociateFormControls):

page/Console.h:
page/ContentSecurityPolicy.h:
page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

page/DeviceController.cpp:

(WebCore::DeviceController::dispatchDeviceEvent):
(WebCore::DeviceController::fireDeviceEvent):

page/DeviceController.h:
page/EditorClient.h:
page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

page/EventHandler.h:
page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

page/Page.cpp:

(WebCore::Page::findStringMatchingRanges):

page/Page.h:
page/PageGroup.h:
page/Performance.cpp:

(WebCore::Performance::webkitGetEntriesByType):
(WebCore::Performance::webkitGetEntriesByName):

page/Performance.h:
page/PerformanceEntryList.cpp:

(WebCore::PerformanceEntryList::appendAll):

page/PerformanceEntryList.h:
page/SecurityOriginHash.h:
page/SecurityPolicy.cpp:
page/SpeechInputResult.h:
page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

page/animation/AnimationControllerPrivate.h:
page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

page/animation/CompositeAnimation.h:
page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::appendChild):

page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::children):

page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

page/scrolling/ScrollingThread.h:
page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::appendChild):

page/scrolling/ScrollingTreeNode.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::syncChildPositions):

platform/CrossThreadCopier.cpp:
platform/CrossThreadCopier.h:
platform/DragData.h:
platform/MainThreadTask.h:
platform/PODFreeListArena.h:

(WebCore::PODFreeListArena::freeObject):
(WebCore::PODFreeListArena::allocate):

platform/PODIntervalTree.h:
platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::voiceList):

platform/PlatformSpeechSynthesizer.h:
platform/RunLoop.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::frameRectsChanged):
(WebCore::ScrollView::clipRectChanged):
(WebCore::ScrollView::setParentVisible):
(WebCore::ScrollView::show):
(WebCore::ScrollView::hide):

platform/ScrollView.h:
platform/SharedBuffer.h:
platform/Supplementable.h:

(WebCore::Supplement::provideTo):
(WebCore::Supplementable::provideSupplement):

platform/URL.cpp:

(WebCore::findHostnamesInMailToURL):
(WebCore::encodeHostnames):

platform/audio/AudioBus.h:
platform/audio/AudioDSPKernelProcessor.h:
platform/audio/AudioResampler.h:
platform/audio/DynamicsCompressor.h:
platform/audio/DynamicsCompressorKernel.h:
platform/audio/HRTFDatabase.h:
platform/audio/HRTFKernel.h:
platform/audio/MultiChannelResampler.h:
platform/audio/Reverb.h:
platform/audio/ReverbConvolver.h:
platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::copySomeDataFromDataArray):

platform/graphics/FloatPolygon.cpp:

(WebCore::FloatPolygon::FloatPolygon):

platform/graphics/FloatPolygon.h:
platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::purgeInactiveFontData):

platform/graphics/GlyphMetricsMap.h:

(WebCore::::locatePageSlowCase):

platform/graphics/GlyphPageTreeNode.h:
platform/graphics/GraphicsContext3D.h:
platform/graphics/GraphicsLayer.cpp:
platform/graphics/GraphicsLayer.h:
platform/graphics/PlatformTextTrackMenu.h:
platform/graphics/SimpleFontData.h:
platform/graphics/WidthCache.h:
platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks):

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
(WebCore::GraphicsLayerCA::fetchCloneLayers):

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/PlatformCAAnimation.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/mac/LayerPool.h:
platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(PlatformCAAnimation::setValues):

platform/graphics/ca/mac/TileController.h:
platform/graphics/cg/SubimageCacheWithTimer.h:
platform/graphics/filters/CustomFilterParameterList.h:
platform/graphics/filters/FilterEffect.h:
platform/graphics/filters/FilterOperations.h:

(WebCore::FilterOperations::operations):

platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::Texture):
(WebCore::Texture::create):

platform/graphics/gpu/Texture.h:
platform/graphics/mac/ComplexTextController.h:
platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

platform/graphics/transforms/TransformOperations.h:

(WebCore::TransformOperations::operations):

platform/ios/PasteboardIOS.mm:

(WebCore::documentFragmentWithRTF):

platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):

platform/mediastream/MediaStreamDescriptor.h:
platform/mediastream/MediaStreamSource.h:
platform/mediastream/RTCConfiguration.h:
platform/network/BlobRegistryImpl.h:
platform/network/HTTPHeaderMap.h:
platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::parseCacheHeader):

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::clientCerts):
(WebCore::ResourceHandle::createCFURLConnection):

platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForNullKey):
(WebCore::::createValueForKey):
(WebCore::cfLocaleCache):

plugins/PluginMainThreadScheduler.h:
rendering/HitTestResult.h:
rendering/InlineFlowBox.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):

rendering/RenderBlock.h:
rendering/RenderButton.h:
rendering/RenderCounter.cpp:
rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator):

rendering/RenderGrid.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::collectLayers):

rendering/RenderLayer.h:
rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

rendering/RenderNamedFlowThread.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::getRanges):

rendering/RenderRegion.h:
rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):

rendering/RootInlineBox.h:
rendering/shapes/PolygonShape.cpp:

(WebCore::computeShapePaddingBounds):
(WebCore::computeShapeMarginBounds):

rendering/shapes/PolygonShape.h:

(WebCore::PolygonShape::PolygonShape):

rendering/shapes/Shape.cpp:

(WebCore::createPolygonShape):
(WebCore::Shape::createShape):

rendering/shapes/ShapeInfo.h:
rendering/shapes/ShapeInterval.h:
rendering/style/QuotesData.cpp:

(WebCore::QuotesData::create):
(WebCore::QuotesData::QuotesData):

rendering/style/QuotesData.h:
rendering/style/RenderStyle.cpp:

(WebCore::requireTransformOrigin):
(WebCore::RenderStyle::applyTransform):

rendering/style/StyleGridData.h:
rendering/svg/RenderSVGResourceGradient.h:
rendering/svg/RenderSVGResourcePattern.h:
rendering/svg/SVGResourcesCache.h:
storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames):

storage/StorageEventDispatcher.h:
storage/StorageNamespaceImpl.h:
storage/StorageThread.h:
storage/StorageTracker.cpp:

(WebCore::StorageTracker::origins):

storage/StorageTracker.h:
svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):

svg/SVGAnimatedTypeAnimator.cpp:

(WebCore::SVGElementAnimatedProperties::SVGElementAnimatedProperties):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):

svg/SVGAnimatedTypeAnimator.h:
svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::addElementReferencingTarget):
(WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget):

svg/SVGDocumentExtensions.h:
svg/SVGFontElement.h:
svg/SVGGlyphMap.h:
svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::orientTypeAnimated):

svg/SVGMarkerElement.h:
svg/SVGPathSegList.h:
svg/animation/SMILTimeContainer.h:
svg/graphics/SVGImageCache.h:
svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::addBuiltinEffects):

svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:

(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):

svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::create):

svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::create):

svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::create):

svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::animatedPropertiesForAttribute):

svg/properties/SVGAttributeToPropertyMap.h:
svg/properties/SVGStaticListPropertyTearOff.h:

(WebCore::SVGStaticListPropertyTearOff::create):

svg/properties/SVGTransformListPropertyTearOff.h:

(WebCore::SVGTransformListPropertyTearOff::create):
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
(WebCore::SVGTransformListPropertyTearOff::consolidate):

workers/DefaultSharedWorkerRepository.h:
workers/WorkerMessagingProxy.h:
xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):

xml/XMLHttpRequestProgressEventThrottle.h:
xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::sort):
(WebCore::XPath::NodeSet::traversalSort):

xml/XSLStyleSheet.h:
xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/mac:

History/WebHistory.mm:

(-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):

History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]):

Plugins/Hosted/NetscapePluginHostProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::stopAllStreams):

Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView destroyPlugin]):

Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager origins]):

Storage/WebStorageManager.mm:

(-[WebStorageManager origins]):

WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache originsWithCache]):

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::getClientPasteboardDataForRange):
(WebEditorClient::documentFragmentFromAttributedString):

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebNotificationClient.h:
WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):

WebView/WebArchive.mm:

(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):

WebView/WebDataSource.mm:

(-[WebDataSource subresources]):

WebView/WebViewData.h:

Source/WebKit2:

UIProcess/mac/WebColorPickerMac.h:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setProcessSuppressionEnabled):

Source/WTF:

wtf/AVLTree.h:
wtf/CheckedArithmetic.h:
wtf/Compression.h:
wtf/Functional.h:

(WTF::R):

wtf/HashFunctions.h:
wtf/HashIterators.h:
wtf/HashSet.h:

(WTF::::contains):

wtf/ListHashSet.h:

(WTF::::contains):

wtf/RefCountedLeakCounter.cpp:
wtf/RetainPtr.h:
wtf/SentinelLinkedList.h:

(WTF::::remove):

wtf/SizeLimits.cpp:
wtf/StreamBuffer.h:
wtf/Vector.h:
wtf/VectorTraits.h:
wtf/WeakPtr.h:

(WTF::WeakReference::create):
(WTF::WeakReference::createUnbound):
(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtrFactory::WeakPtrFactory):

wtf/text/AtomicString.cpp:

(WTF::AtomicString::add):
(WTF::findString):

wtf/text/StringConcatenate.h:
wtf/text/StringImpl.h:
wtf/text/StringOperators.h:

(WTF::operator+):

4:35 PM Changeset in webkit [157652] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Cleaning warning messages from StyleResolveTree
https://bugs.webkit.org/show_bug.cgi?id=123030

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-18
Reviewed by Andreas Kling.

No new tests needed.

style/StyleResolveTree.cpp:

(WebCore::Style::elementInsideRegionNeedsRenderer):
(WebCore::Style::createRendererIfNeeded):

4:23 PM Changeset in webkit [157651] by beidson@apple.com

13 edits in trunk/Source

Get rid of IDBFactoryBackendLevelDB and IDBTransactionBackendLevelDB in IDBDatabaseBackendLevelDB.
https://bugs.webkit.org/show_bug.cgi?id=123039

Reviewed by Anders Carlsson.

Source/WebCore:

Add a few concepts to the interfaces to make this work:

Modules/indexeddb/IDBFactoryBackendInterface.h:
Modules/indexeddb/IDBTransactionBackendInterface.h:

(WebCore::IDBTransactionBackendInterface::id):
(WebCore::IDBTransactionBackendInterface::IDBTransactionBackendInterface):

Adapt to using Interface ptr’s instead of LevelDB ptr’s:

Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::create):
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::createObjectStore):
(WebCore::IDBDatabaseBackendLevelDB::deleteObjectStore):
(WebCore::IDBDatabaseBackendLevelDB::createIndex):
(WebCore::IDBDatabaseBackendLevelDB::deleteIndex):
(WebCore::IDBDatabaseBackendLevelDB::get):
(WebCore::IDBDatabaseBackendLevelDB::put):
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::setIndexesReady):
(WebCore::IDBDatabaseBackendLevelDB::openCursor):
(WebCore::IDBDatabaseBackendLevelDB::count):
(WebCore::IDBDatabaseBackendLevelDB::deleteRange):
(WebCore::IDBDatabaseBackendLevelDB::clear):
(WebCore::IDBDatabaseBackendLevelDB::transactionStarted):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinished):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinishedAndCompleteFired):
(WebCore::IDBDatabaseBackendLevelDB::runIntVersionChangeTransaction):

Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:

Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:

(WebCore::IDBObjectStoreBackendLevelDB::makeIndexWriters):

Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:

Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:

(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::abort):
(WebCore::IDBTransactionBackendLevelDB::commit):

Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

Source/WebKit2:

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend): Stub out this new interface method.

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

3:57 PM Changeset in webkit [157650] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

Remove excess reserved space in ctiTrampoline frames for X86 and X86_64.
https://bugs.webkit.org/show_bug.cgi?id=123037.

Reviewed by Geoffrey Garen.

jit/JITStubsMSVC64.asm:
jit/JITStubsX86.h:
jit/JITStubsX86_64.h:

2:41 PM Changeset in webkit [157649] by Alexandru Chiculita

9 edits
4 adds in trunk/Source/WebInspectorUI

Web Inspector: CSS Regions: Add the list of flows in the FrameTreeElement
https://bugs.webkit.org/show_bug.cgi?id=122924

Reviewed by Timothy Hatcher.

Added code to collect the flows from the backend into the DOMTree object
on the frontend. Added ContentFlow to represent the flows on the frontend
side and created ContentFlowTreeElement to display the flows in the FrameTreeElement.

Localizations/en.lproj/localizedStrings.js:
Scripts/copy-user-interface-resources.sh:
UserInterface/CSSObserver.js:

(WebInspector.CSSObserver.prototype.namedFlowCreated):
(WebInspector.CSSObserver.prototype.namedFlowRemoved):
(WebInspector.CSSObserver.prototype.regionLayoutUpdated):
(WebInspector.CSSObserver.prototype.regionOversetChanged):

UserInterface/ContentFlow.js: Added.

(WebInspector.ContentFlow):
(WebInspector.ContentFlow.prototype.get id):
(WebInspector.ContentFlow.prototype.get documentNodeIdentifier):
(WebInspector.ContentFlow.prototype.get name):
(WebInspector.ContentFlow.prototype.get overset):
(WebInspector.ContentFlow.prototype.set overset):

UserInterface/ContentFlowIcon.css: Added.

(.content-flow-icon .icon):

UserInterface/ContentFlowTreeElement.js: Added.

(WebInspector.ContentFlowTreeElement):

UserInterface/DOMTree.js:

(WebInspector.DOMTree):
(WebInspector.DOMTree.prototype.get flowMap):
(WebInspector.DOMTree.prototype.get flowsCount):
(WebInspector.DOMTree.prototype._framePageExecutionContextChanged):
(WebInspector.DOMTree.prototype.requestContentFlowList):
(WebInspector.DOMTree.prototype._isContentFlowInCurrentDocument):
(WebInspector.DOMTree.prototype._contentFlowListWasUpdated):
(WebInspector.DOMTree.prototype._contentFlowWasAdded):
(WebInspector.DOMTree.prototype._contentFlowWasRemoved):

UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager._flowPayloadHashKey):
(WebInspector.DOMTreeManager.prototype._buildHighlightConfig):
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype.getNamedFlowCollection):
(WebInspector.DOMTreeManager.prototype.namedFlowCreated):
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved):
(WebInspector.DOMTreeManager.prototype._sendNamedFlowUpdateEvents):
(WebInspector.DOMTreeManager.prototype.regionLayoutUpdated):
(WebInspector.DOMTreeManager.prototype.regionOversetChanged):

UserInterface/FrameTreeElement.js:

(WebInspector.FrameTreeElement):
(WebInspector.FrameTreeElement.prototype.onpopulate):
(WebInspector.FrameTreeElement.prototype.onexpand):
(WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
(WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
(WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
(WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._compareResourceTreeElements):
(WebInspector.FrameTreeElement.prototype._insertResourceTreeElement):
(WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):

UserInterface/Images/ContentFlow.svg: Added.
UserInterface/Main.html:
UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):

2:09 PM Changeset in webkit [157648] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Cocoa] WKBrowsingController accessors crash instead of returning nil
https://bugs.webkit.org/show_bug.cgi?id=123036

Reviewed by Anders Carlsson.

UIProcess/API/mac/WKBrowsingContextController.mm:

(autoreleased): Return nil if the object is NULL.

1:53 PM Changeset in webkit [157647] by dino@apple.com

4 edits
4 adds in trunk

Unable to upload <img src="foo.svg"> as WebGL texture
https://bugs.webkit.org/show_bug.cgi?id=123035

Reviewed by Tim Horton.

Source/WebCore:

If the HTMLImageElement passed to texture2D is an SVG
image, paint it first into a bitmap buffer and upload that.
Note that the SVG image still needs to have an intrinsic
or explicit size - see how the test case must set width and
height.

I also renamed the cache of ImageBuffers since it is
no longer only being used for video frames.

Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext): Rename m_videoCache to m_generatedImageCache.
(WebCore::WebGLRenderingContext::drawImageIntoBuffer): New method that creates an ImageBuffer
of the appropriate size and renders into that.
(WebCore::WebGLRenderingContext::texImage2D): If we see an SVG image, render it first.
(WebCore::WebGLRenderingContext::videoFrameToImage): Renamed m_generatedImageCache.
(WebCore::WebGLRenderingContext::texSubImage2D): If we see an SVG image, render it first.

html/canvas/WebGLRenderingContext.h: Renaming.

LayoutTests:

Test that creates an HTMLImageElement, sets its source
to an SVG file, and then uploads as a WebGLTexture. Based
on the existing WebGL conformance tests.

fast/canvas/webgl/resources/red-green.svg: Added.
fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-svg-image.js: Added.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image-expected.txt: Added.
fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html: Added.

1:28 PM Changeset in webkit [157646] by cabanier@adobe.com

2 edits in trunk/Tools

Add Rik Cabanier to list of committers
https://bugs.webkit.org/show_bug.cgi?id=123031

reviewed by Dirk Schulze.

Tools/Scripts/webkitpy/common/config/contributors.json: Added name.

1:21 PM Changeset in webkit [157645] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Frequent RELEASE_ASSERT crashes in Structure::checkOffsetConsistency on WebGL swizzler tests
https://bugs.webkit.org/show_bug.cgi?id=121661

Reviewed by Mark Hahnenberg.

This method shouldn't have been called from the concurrent JIT thread. That's hard to prevent
so I added a return-early check using isCompilationThread().

Here's why this makes sense. Structure has two ways to tell you about the layout of the objects
it is describing: m_offset and the property table. Most structures only have m_offset and report
null for the property table. If the property table is there, it will tell you additional
information and that information subsumes m_offset - but the m_offset is still there. So, when
we have a property table, we have to keep it in sync with the m_offset. There is a bunch of
machinery to do this.

Changing the property table only happens on the main thread.

Because the machinery to change the property table is so complex, especially with respect to
keeping it in sync with m_offset, we have the checkOffsetConsistency method. It's meant to be
called at key points before and after changes to the property table or the offset.

Most clients of Structure who care about object layout, including the concurrent thread, will
want to know m_offset and not the property table. If they want the property table, they will
already be super careful. The concurrent thread has special methods for this, like
Structure::getConcurrently(), which uses fine-grained locking to ensure that it sees a coherent
view of the property table.

Adding locking to checkOffsetConsistency() is probably a bad idea since that method may be
called when the relevant lock is already held. So, we'd have awkward recursive locking issues.

But right now, the concurrent JIT thread may call a method, like Structure::outOfLineCapacity(),
which has a call to checkOffsetConsistency(). The call to checkOffsetConsistency() is there
because we have found that it helps quickly identify situations where the property table and
m_offset get out of sync - mainly because code that changes either of those things will usually
also want to know the outOfLineCapacity(). But Structure::outOfLineCapacity() doesn't *actually*
need the property table; it uses the m_offset. The concurrent JIT is correct to call
outOfLineCapacity(), and is right to do so without holding any locks (since in all cases where
it calls outOfLineCapacity() it has already proven that m_offset is immutable). But because
outOfLineCapacity() calls checkOffsetConsistency(), and checkOffsetConsistency() doesn't grab
locks, and that same structure is having its property table modified by the main thread, we end
up with these spurious assertion failures. FWIW, the structure isn't *actually* having *its*
property table modified - instead what happens is that some downstream structure steals the
property table and then starts adding things to it. The concurrent thread loads the property
table before it's stolen, and hence the badness.

I suspect there are other code paths that lead to the concurrent JIT calling some Structure
method that it is fine and safe to call, but then that method calls checkOffsetConsistency(),
and then you have a possible crash.

The most sensible solution to this appears to be to make sure that checkOffsetConsistency() is
aware of its uselessness to the concurrent JIT thread. This change makes it return early if
it's in the concurrent JIT.

runtime/StructureInlines.h:

(JSC::Structure::checkOffsetConsistency):

1:19 PM Changeset in webkit [157644] by beidson@apple.com

10 edits
3 adds in trunk/Source/WebCore

[GTK] Generate API documentation for GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=121538

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-10-18
Reviewed by Gustavo Noronha Silva.

GNUmakefile.am: Initialize gdom_symbol_files variable.

12:17 PM Changeset in webkit [157643] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Remove some Windows specific code from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=123034

Reviewed by Beth Dakin.

Platform/PlatformProcessIdentifier.h:
Shared/API/c/WKDeclarationSpecifiers.h:
UIProcess/API/C/WKNativeEvent.h:
UIProcess/API/C/WKPreferencesPrivate.h:
config.h:

12:11 PM Changeset in webkit [157642] by Beth Dakin

4 edits in trunk/Source/WebCore

Rubber-banding is often not smooth on infinitely scrolling websites
https://bugs.webkit.org/show_bug.cgi?id=122985

Reviewed by Simon Fraser.

totalContentsSize is an important part of the calculation for
maximumScrollPosition(). This function is called repeatedly throughout the curve
of a rubber-band to determine the stretch amount. To keep the rubber-band
animation smooth, it should be allowed to finish its animation using the old
totalContentsSize. This patch does that by adding a new variable,
m_totalContentsSizeForRubberBand. This value should almost always be equivalent to
m_totalContentsSize. It will only vary if m_totalContentsSize has changed in the
middle of a rubber-band, and in that case, it will stay equivalent to the old
totalContentSize value until the rubber band animation finishes.

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::totalContentsSizeForRubberBand):
(WebCore::ScrollingTreeScrollingNode::setTotalContentsSizeForRubberBand):

page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::stopSnapRubberbandTimer):
(WebCore::ScrollingTreeScrollingNodeMac::maximumScrollPosition):

10:22 AM Changeset in webkit [157641] by dbates@webkit.org

2 edits in trunk/Source/JavaScriptCore

Add SPI to disable the garbage collector timer
https://bugs.webkit.org/show_bug.cgi?id=122921

Add null check to Heap::setGarbageCollectionTimerEnabled() that I inadvertently
omitted.

heap/Heap.cpp:

(JSC::Heap::setGarbageCollectionTimerEnabled):

10:11 AM Changeset in webkit [157640] by commit-queue@webkit.org

2 edits in trunk/Websites/webkit.org

Mixed content error when accessing webkit.org/team.html over https
https://bugs.webkit.org/show_bug.cgi?id=123020

Patch by Tibor Meszaros <tmeszaros@inf.u-szeged.hu> on 2013-10-18
Reviewed by Alexey Proskuryakov.

When the webkit.org/team.html page is accessed over https most browsers report
Mixed Content error, which is caused by the fact that the contributos.json file
is accessed over a plain http connection and not https.

team.html:

10:03 AM Changeset in webkit [157639] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Group 64-bit specific and 32-bit specific callOperation implementations.
https://bugs.webkit.org/show_bug.cgi?id=123024

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-18
Reviewed by Michael Saboff.

This is not a big deal, but could be less confusing when reading the code.

jit/JITInlines.h:

(JSC::JIT::callOperation):
(JSC::JIT::callOperationWithCallFrameRollbackOnException):
(JSC::JIT::callOperationNoExceptionCheck):

10:03 AM Changeset in webkit [157638] by commit-queue@webkit.org

2 edits in trunk/Websites/webkit.org

Cleanup webkit.org/team.html
https://bugs.webkit.org/show_bug.cgi?id=123022

Patch by Tibor Meszaros <tmeszaros@inf.u-szeged.hu> on 2013-10-18
Reviewed by Alexey Proskuryakov.

Removed the annoteWithWikiData function, because data it tries to fetch does not exists.

team.html:

9:55 AM Changeset in webkit [157637] by commit-queue@webkit.org

3 edits
3 adds in trunk

Fix a FlushLiveness problem.
https://bugs.webkit.org/show_bug.cgi?id=122984

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-18
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

dfg/DFGFlushLivenessAnalysisPhase.cpp:

(JSC::DFG::FlushLivenessAnalysisPhase::process):

LayoutTests:

js/regress/script-tests/stepanov_container.js: Added.
js/regress/stepanov_container-expected.txt: Added.
js/regress/stepanov_container.html: Added.

9:25 AM Changeset in webkit [157636] by msaboff@apple.com

26 edits in trunk/Source/JavaScriptCore

Change native function call stubs to use JIT operations instead of ctiVMHandleException
https://bugs.webkit.org/show_bug.cgi?id=122982

Reviewed by Geoffrey Garen.

Change ctiVMHandleException to operationVMHandleException. Change all exception operations to
return the catch callFrame and entryPC via vm.callFrameForThrow and vm.targetMachinePCForThrow.
This removed calling convention headaches, fixing https://bugs.webkit.org/show_bug.cgi?id=122980
in the process.

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):

jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler):

jit/JIT.cpp:

(JSC::JIT::privateCompileExceptionHandlers):

jit/JIT.h:
jit/JITExceptions.cpp:

(JSC::genericUnwind):

jit/JITExceptions.h:
jit/JITInlines.h:

(JSC::JIT::callOperationNoExceptionCheck):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_throw):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_throw):

jit/JITOperations.cpp:
jit/JITOperations.h:
jit/JITStubs.cpp:
jit/JITStubs.h:
jit/JITStubsARM.h:
jit/JITStubsARM64.h:
jit/JITStubsARMv7.h:
jit/JITStubsMIPS.h:
jit/JITStubsMSVC64.asm:
jit/JITStubsSH4.h:
jit/JITStubsX86.h:
jit/JITStubsX86_64.h:
jit/Repatch.cpp:

(JSC::tryBuildGetByIDList):

jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::nativeForGenerator):

runtime/VM.h:

(JSC::VM::callFrameForThrowOffset):
(JSC::VM::targetMachinePCForThrowOffset):

9:06 AM Changeset in webkit [157635] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Removed the MAC_OS_X_VERSION_MIN_REQUIRED condition from the definition of WK_API_ENABLED.

Rubber-stamped by Anders Carlsson.

Shared/API/Cocoa/WKFoundation.h:

9:05 AM Changeset in webkit [157634] by ChangSeok Oh

2 edits in trunk/Source/WebCore

Unreviewed build fix for --no-svg option.
m_svgStyle of RenderStyle is guarded with the ENABLE_SVG flag.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

8:23 AM Changeset in webkit [157633] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix J_JITOperation_EAapJ call for MIPS and ARM EABI.
https://bugs.webkit.org/show_bug.cgi?id=123023

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-18
Reviewed by Michael Saboff.

jit/JITInlines.h:

(JSC::JIT::callOperation): EncodedJSValue parameter do not need alignment
using EABI_32BIT_DUMMY_ARG here.

7:52 AM Changeset in webkit [157632] by beidson@apple.com

2 edits in trunk/Source/WebCore

Cleanup the Modules group in the WebCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=123009

Rubberstamped by Antti Koivisto.

WebCore.xcodeproj/project.pbxproj:

6:07 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu

(diff)

5:01 AM QtWebKitGardening edited by zarvai@inf.u-szeged.hu

(diff)

4:40 AM WebKitGTK/2.2.x edited by mario@webkit.org

(diff)

4:26 AM Changeset in webkit [157631] by commit-queue@webkit.org

5 edits in trunk

[ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
https://bugs.webkit.org/show_bug.cgi?id=122970

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-10-18
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Removed an invalid signal to set objects to an unknown state
layout-complete. This signal was originally generated to notify DRT
and WKTR in case of page load complete.
It was replaced by ATK:AtkDocument:load-complete, which is already sent
by AXObjectCache::frameLoadingEventPlatformNotification().

There is no new test since the changes are covered by existing ones
(e.g. accessibility/loading-iframe-sends-notification.html).

accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Removed an invalid
signal to set objects to an unknown state layout-complete.

Tools:

Removed an invalid signal to set an object state to layout-complete
that does not exist. It was replaced by ATK:AtkDocument:load-complete.

DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:

(axObjectEventListener): Replaced layout-complete with load-complete.
(connectAccessibilityCallbacks): Connect callback to new listener for
ATK:AtkDocument:load-complete.
(disconnectAccessibilityCallbacks): Disconnect callback to new listener
for ATK:AtkDocument:load-complete.

WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(axObjectEventListener): Replaced layout-complete with load-complete.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connect callback to new listener for ATK:AtkDocument:load-complete.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnect callback to new listener for ATK:AtkDocument:load-complete.

3:33 AM Changeset in webkit [157630] by Carlos Garcia Campos

7 edits
1 add in trunk

[GTK] Generate API documentation for GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=121538

Reviewed by Gustavo Noronha Silva.

GNUmakefile.am: Initialize gdom_symbol_files variable.

Source/WebCore:

bindings/gobject/GNUmakefile.am: Add a explicit rule for all

.symbols file making them depend on the corresponding header file,
since the .symbols file is generated by the bindings generator.

Tools:

The .symbols file that is now generated for checking GObject DOM
bindings API compatibility while building can also be used to
generate the files needed to produce the gtk-doc
documentation. The new script generate-webkitdom-doc-files can
generate the docs.sgml and sections.txt files from the given list
of .symbols files.

gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml

and webkitdomgtk-sections.txt as well as rules to install the
generated WebKitDOMGTK documentation.

gtk/generate-gtkdoc:

(webkitdom_docs_html_path): New helper function that returns the
path where the DOM API documentation has been generated.
(get_webkit2_options): Include DOM API docs to the list of xref
dependencies.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Return the gtk-doc options to generate
the DOM API docs.
(get_webkitdom_options.derived_sources_path):
(get_webkitdom_options.src_path):

gtk/generate-webkitdom-doc-files: Added.

(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.write_header):
(WebKitDOMDocGenerator.write_section):
(WebKitDOMDocGenerator.write_footer):
(WebKitDOMDocGeneratorDocs):
(WebKitDOMDocGeneratorDocs.write_header):
(write_section):
(write_footer):
(WebKitDOMDocGeneratorSections):
(WebKitDOMDocGeneratorSections.init):
(WebKitDOMDocGeneratorSections._dom_class):
(WebKitDOMDocGeneratorSections._dom_class_decamelize):
(WebKitDOMDocGeneratorSections._symbol_list):
(WebKitDOMDocGeneratorSections.write_section):

3:21 AM Changeset in webkit [157629] by jinwoo7.song@samsung.com

8 edits
1 add in trunk/LayoutTests

Unreviewed EFL gardening.

platform/efl-wk2/TestExpectations: Remove passing testcase.
platform/efl/TestExpectations: fast/backgrounds/background-opaque-images-over-color.html is failing.
platform/efl/fast/dom/Range/getClientRects-expected.txt: Rebaseline after r152872.
platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Rebaseline after r152793.
platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Rebaseline after r152911.
platform/efl/tables/mozilla/marvin/backgr_index-expected.png: Rebaseline after r152793.
platform/efl/tables/mozilla/marvin/backgr_index-expected.txt: Rebaseline after r152793.

3:15 AM Changeset in webkit [157628] by mario@webkit.org

3 edits in trunk/Source/WebCore

[ATK] Simplify implementation of atk_text_get_text
https://bugs.webkit.org/show_bug.cgi?id=122644

Reviewed by Chris Fleizach.

Simplified code so we only call textUnderElement() directly once
and only when needed. Also, moved the specific code for ColorWell
objects up to the beginning of that function, so we don't do any
additional efforts like computing text ranges in those cases.

No new tests are needed, just to make sure that the current layout
and unit tests are still passing, which they are.

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(textForObject): Fixed a issue that got detected while working on
this patch, which was causing a '\n' to be artificially appended
at the end of text controls all the time.
(webkitAccessibleTextGetText): Simplified function.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::doAXStringForRange): Removed
the check that prevents from pass ranges exceeding the limits of
the element's text, since those will be checked anyway when
calling String::substring().

2:17 AM Changeset in webkit [157627] by jinwoo7.song@samsung.com

3 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r153852.

platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt:
platform/efl/security/block-test-no-port-expected.txt:

12:37 AM Changeset in webkit [157626] by ap@apple.com

2 edits in trunk/LayoutTests

Layout Test media/W3C/audio/networkState/networkState_during_loadstart.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123010

platform/mac/TestExpectations: Marked as such.

12:29 AM Changeset in webkit [157625] by ap@apple.com

2 edits in trunk/LayoutTests

css3/filters/composited-during-animation-layertree.html sometimes produces empty results
https://bugs.webkit.org/show_bug.cgi?id=95622

platform/mac/TestExpectations: Marking as flaky.

12:17 AM Changeset in webkit [157624] by commit-queue@webkit.org

9 edits in trunk/Source

[GStreamer][GTK] Add GRefPtr::outPtr()
https://bugs.webkit.org/show_bug.cgi?id=122996

Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-18
Reviewed by Philippe Normand.

Source/WebCore:

No new tests because this is just simplifying existing code.

platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Add GRefPtr specialization for GstToc.
platform/graphics/gstreamer/GRefPtrGStreamer.h: Same.
platform/graphics/gstreamer/GStreamerGWorld.cpp: Use GRefPtr::outPtr() to simplify code.

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
(WebCore::GStreamerGWorld::removePlatformVideoSink):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Same.

(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Same.

(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):

platform/network/soup/ResourceHandleSoup.cpp: Same.

(WebCore::HostTLSCertificateSet::computeCertificateHash):

Source/WTF:

wtf/gobject/GRefPtr.h:

(WTF::GRefPtr::outPtr): Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed