⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 21, 2013:

10:19 PM Changeset in webkit [157777] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to make the 32-bit Mac build happy.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(setUpPageLoaderClient):

10:16 PM Changeset in webkit [157776] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Add load delegate method for didChangeBackForwardList
​https://bugs.webkit.org/show_bug.cgi?id=123136

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didChangeBackForwardList): Added. Calls new delegate method.
(setUpPageLoaderClient): Hook up new client function.

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declare new delegate method.
9:42 PM Changeset in webkit [157775] by rniwa@webkit.org
  • 8 edits
    5 adds in trunk/Websites/test-results

New flakiness dashboard should hyperlink test names, WebKit revisions, and bubbles
​https://bugs.webkit.org/show_bug.cgi?id=123134

Reviewed by Stephanie Lewis.

Copied admin.css, admin-header.php, admin-footer.php, builders.php, repositories.php from WebKit Perf Monitor.
(Unfortunately WebKit Perf Monitor hasn't been committed into WebKit repository just yet.)

Updated various parts of index.html to linkify test names, build numbers, and bubbles (to results page).

  • admin/admin.css: Added.
  • admin/builders.php: Added.
  • admin/index.php: Removed the duplicated code now that it uses admin-header.php.
  • admin/repositories.php: Added.
  • api/manifest.php: Use camelCase for blame_url and build_url to be consistent with other JSON properties.

Also exported testCategories from config so that we can linkify test names in the dashboard.

  • include/admin-footer.php: Added.
  • include/admin-header.php: Added.
  • include/config.json: Added test categories. This avoids hard-coding the URL to trac in php/js.
  • include/init-database.sql: Added name and build_url to builders table and category to tests.
  • include/test-results.php: Assume the test category to be LayoutTest for now.
  • index.html:

(TestResultsView): Initialize _builders, _slaves, _repositories, _testCategories as dictionaries as intended.
(TestResultsView.setTestCategories): Added.
(TestResultsView._createResultCell): Dynamically resolve URLs of results page and and build page.
(TestResultsView._populateTestPane): Linkify the test name. Unfortunately we don't have a test object anywhere.
We need to figure out a way to find the test object here eventually. For now, hard-coding "LayoutTest" works.
(TestResultsView._linkifiedTestName): Added.
(TestResultsView._createBuildsAndComputeSlownessOfResults): Takes builderId to set "builder" property on each
result object as it's used by Build class.
(TestResultsView._populateBuilderPane):
(fetchManigest):

  • js/build.js:

(Build.buildUrl): Support $builderName so that we don't have to keep repeating builder names in the database.
(Build.revision): Don't access [0] if revisions[repositoryId] was undefined.

7:17 PM Changeset in webkit [157774] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Run tests as if they are expected to pass when --force is given.
​https://bugs.webkit.org/show_bug.cgi?id=112890

Patch by Tamas Gergely <​gertom@inf.u-szeged.hu> on 2013-10-21
Reviewed by Ryosuke Niwa.

The --force switch of new-run-webkit-tests is now forces all tests to
be run with 'PASS' as expected result.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):
(TestExpectations._add_expectations):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):
(_set_up_derived_options):

7:05 PM Changeset in webkit [157773] by Brent Fulgham
  • 6 edits in trunk/Source/WebCore

[WIN] Properly support reverse animations without needing software fallback.
​https://bugs.webkit.org/show_bug.cgi?id=85121

Reviewed by Dean Jackson.

Testing is provided by existing animation tests.

  • platform/animation/TimingFunction.h:

(WebCore::CubicBezierTimingFunction::createReversed): Added.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::addAnimation): The early return when performing a reverse or
autoreverse animation is no longer needed.

  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(toCAMediaTimingFunction): Use new reversed function.

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFTimingFunction): Ditto.
(PlatformCAAnimation::setTimingFunction): Pass 'reverse' flag.
(PlatformCAAnimation::setTimingFunctions): Ditto.

6:51 PM Changeset in webkit [157772] by rniwa@webkit.org
  • 5 edits in trunk/Websites/test-results

New flakiness dashboard should align results by revision numbers
​https://bugs.webkit.org/show_bug.cgi?id=123129

Reviewed by Tim Horton.

  • include/config.json: Specify the default cache time to be 10 minutes.
  • include/json-shared.php: Added Expires and Cache-Control headers. It's configurable via config.json.
  • index.html:

(TestResultsView._createResultCell): Don't put '-' in a result cell without time.
(TestResultsView._populateTestPane): Create an array of build times ordered from the newest to the oldest.
Not that build.time() is the newest commit time among all repository for each result. e.g. if we had
both WebKit and Safari repository information in a given result, the newer of the two will be used.
(TestResultsView._createTestResultHeader): Added.
(TestResultsView._createBuildsAndComputeSlownessOfResults): Extracted from _createTestResultRow so
that _populateTestPane could use Build object before calling _createTestResultRow.
(TestResultsView._createTestResultRow): Takes buildTimes. Insert an empty cell for a build time if
the current row doesn't contain that a result for that build time.
(TestResultsView._populateBuilderPane):

  • main.css: Tweaked the style so that bubbles are aligned vertically without '-'.

(.resultsTable):
(.resultsTable thead th):
(.resultsTable .resultCell):
(.resultsTable a):
(.resultsTable span a):

6:31 PM Changeset in webkit [157771] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceMavericks.a

Set svn:mime-type on libWebKitSystemInterfaceMavericks.a so that future changes don't generate giant commit emails.

6:27 PM Changeset in webkit [157770] by mrowe@apple.com
  • 9 edits
    1 add in trunk

Add a version of WebKitSystemInterface for Mavericks.

Reviewed by Ryosuke Niwa.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • Scripts/copy-webkitlibraries-to-product-directory:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:

WebKitLibraries:

  • libWebKitSystemInterfaceMavericks.a: Added.
6:25 PM Changeset in webkit [157769] by gyuyoung.kim@samsung.com
  • 33 edits in trunk/Source/WebCore

Use TYPE_CASTS_BASE for CSS_VALUE_TYPE_CASTS
​https://bugs.webkit.org/show_bug.cgi?id=123126

Reviewed by Andreas Kling.

TYPE_CASTS_BASE was moved to common place to be used by all toFoo().
CSS_VALUE_TYPE_CASTS starts to use it for CSS child value. This change
generates plenty more helper functions for toCSSFooValue().

Additionally, this use support that toWebKitCSSFooValue, which couldn't
use CSS_VALUE_TYPE_CASTS macro.

No new tests, no behavior change.

  • css/CSSAspectRatioValue.h:
  • css/CSSBorderImageSliceValue.h:
  • css/CSSCalculationValue.h:
  • css/CSSCanvasValue.h:
  • css/CSSCrossfadeValue.h:
  • css/CSSCursorImageValue.h:
  • css/CSSFilterImageValue.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFontFeatureValue.h:
  • css/CSSFontValue.h:
  • css/CSSFunctionValue.h:
  • css/CSSGradientValue.h:
  • css/CSSGridTemplateValue.h:
  • css/CSSImageSetValue.h:
  • css/CSSImageValue.h:
  • css/CSSInheritedValue.h:
  • css/CSSInitialValue.h:
  • css/CSSLineBoxContainValue.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.h:
  • css/CSSShadowValue.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSUnicodeRangeValue.h:
  • css/CSSValue.h:
  • css/CSSValueList.h:
  • css/CSSVariableValue.h:
  • css/WebKitCSSArrayFunctionValue.h:
  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSMatFunctionValue.h:
  • css/WebKitCSSMixFunctionValue.h:
  • css/WebKitCSSSVGDocumentValue.h:
  • css/WebKitCSSShaderValue.h:
5:29 PM Changeset in webkit [157768] by joone.hur@intel.com
  • 2 edits in trunk/Source/WebCore

Bad cast with toRenderBoxModelObject in RenderBlock::updateFirstLetter()
​https://bugs.webkit.org/show_bug.cgi?id=123013

Reviewed by Andreas Kling.

No new tests because this was reported by Google ClusterFuzz.
​https://codereview.chromium.org/25713009/

There is a case that toRenderBoxModelObject causes a crash in RenderBlock::updateFirstLetter()
due to bad cast, so we need to check whether the RenderObject is a RenderBoxModelObject
by running isBoxModelObject() before calling toRenderBoxModelObject.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

5:18 PM Changeset in webkit [157767] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154289. <rdar://problem/15109381>

5:18 PM Changeset in webkit [157766] by beidson@apple.com
  • 10 edits
    2 moves in trunk/Source/WebCore

Make IDBTransactionCoordinatorLevelDB cross platform
​https://bugs.webkit.org/show_bug.cgi?id=123124

Enthusiastically reviewed by Tim Horton.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:

Make more methods pure virtual in the interface:

  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

Update the name of the class, and use IDBTransactionBackendInterface instead of IDBTransactionBackendLeveDB:

  • Modules/indexeddb/IDBTransactionCoordinator.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp.

(WebCore::IDBTransactionCoordinator::create):
(WebCore::IDBTransactionCoordinator::IDBTransactionCoordinator):
(WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator):
(WebCore::IDBTransactionCoordinator::didCreateTransaction):
(WebCore::IDBTransactionCoordinator::didStartTransaction):
(WebCore::IDBTransactionCoordinator::didFinishTransaction):
(WebCore::IDBTransactionCoordinator::isActive):
(WebCore::IDBTransactionCoordinator::processStartedTransactions):
(WebCore::doScopesOverlap):
(WebCore::IDBTransactionCoordinator::canRunTransaction):

  • Modules/indexeddb/IDBTransactionCoordinator.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h.

Update the name of the class elsewhere:

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:

(WebCore::IDBDatabaseBackendLevelDB::transactionCoordinator):

  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
4:55 PM Changeset in webkit [157765] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-537.73-branch

Merged r154217. <rdar://problem/15109395>

4:54 PM Changeset in webkit [157764] by dbates@webkit.org
  • 11 edits in trunk/Source

[iOS] Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout()
​https://bugs.webkit.org/show_bug.cgi?id=123045

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • jsc.cpp: Add function pointer for shouldInterruptScriptBeforeTimeout

to global method table.

  • runtime/JSGlobalObject.cpp: Ditto.
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::shouldInterruptScriptBeforeTimeout): Added.

Source/WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::shouldInterruptScriptToPreventInfiniteRecursionWhenClosingPage): Added.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Extracted comment and assertion
about null Page object into WebCore::shouldInterruptScriptToPreventInfiniteRecursionWhenClosingPage()
so that it can be shared by both this function and JSDOMWindowBase::shouldInterruptScriptBeforeTimeout().
(WebCore::JSDOMWindowBase::shouldInterruptScriptBeforeTimeout):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::shouldInterruptScriptBeforeTimeout): Added.

  • bindings/js/JSWorkerGlobalScopeBase.h:
  • loader/EmptyClients.h: Added isStopping(). We'll land the iOS chrome client implementation

in a subsequent patch.

  • page/ChromeClient.h: Added isStopping().
4:35 PM Changeset in webkit [157763] by Lucas Forschler
  • 16 edits
    5 copies
    4 deletes in branches/safari-537.73-branch/Source

Merged r154183. <rdar://problem/15109466>

4:35 PM Changeset in webkit [157762] by Alexandru Chiculita
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: [CSS Regions] Flows are not loading if you refresh the page several times
​https://bugs.webkit.org/show_bug.cgi?id=123123

Reviewed by Joseph Pecoraro.

There was a typo in the code where an exception was thrown because "flowKey" was undefined.

  • UserInterface/DOMTree.js:

(WebInspector.DOMTree.prototype._contentFlowListWasUpdated):

4:28 PM Changeset in webkit [157761] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[iOS] Upstream JSC Objective-C API compiler warning fixes
​https://bugs.webkit.org/show_bug.cgi?id=123125

Reviewed by Mark Hahnenberg.

Based on a patch by Mark Hahnenberg.

  • API/JSValue.mm:

(-[JSValue toPoint]): Cast to CGFloat to fix some compiler warnings about double narrowing to float.
(-[JSValue toSize]): Ditto.

  • API/tests/testapi.mm: Changed a test that was failing due to overflow of 32-bit NSUInteger on armv7.
4:15 PM Changeset in webkit [157760] by Lucas Forschler
  • 10 edits in branches/safari-537.73-branch/Source/WebKit/mac

Merged r154078. <rdar://problem/15109379>

4:11 PM Changeset in webkit [157759] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r154085. <rdar://problem/15109354>

4:09 PM Changeset in webkit [157758] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r154077. <rdar://problem/15109354>

4:06 PM Changeset in webkit [157757] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r153848. <rdar://problem/15109354>

3:55 PM Changeset in webkit [157756] by andersca@apple.com
  • 4 edits
    2 adds in trunk

Navigation policy callback not called when performing the same fragment navigation twice
​https://bugs.webkit.org/show_bug.cgi?id=123121
<rdar://problem/15230466>

Reviewed by Beth Dakin.

Source/WebCore:

There's code in PolicyChecker::checkNavigationPolicy that will call the decision function right away
if the requests are equal, without consulting any policy client. Because of this, make sure to empty out
the last checked request of the document loader when doing a fragment navigation.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):

Tools:

Add a test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
  • TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.

(+[WebKit1FragmentNavigationTestDelegate shared]):
(-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
(-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
(-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
(-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
(TestWebKitAPI::TEST):

3:49 PM Changeset in webkit [157755] by dbates@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[iOS] Mark classes JS{Context, ManagedValue, Value, VirtualMachine} as
available since iOS 7.0
​https://bugs.webkit.org/show_bug.cgi?id=123122

Reviewed by Dan Bernstein.

  • API/JSContext.h:
  • API/JSManagedValue.h:
  • API/JSValue.h:
  • API/JSVirtualMachine.h:
3:48 PM Changeset in webkit [157754] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Try to fix the Mac 32-bit build.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:
3:46 PM Changeset in webkit [157753] by dbates@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

Remove platform #ifdefs from WebDataSourcePrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=123120
<rdar://problem/15275533>

Reviewed by Anders Carlsson.

  • WebView/WebDataSource.mm:

(-[WebDataSource _setAllowToBeMemoryMapped]): Define empty implementation when building without
disk image cache enabled.
(-[WebDataSource setDataSourceDelegate:]): Ditto.
(-[WebDataSource dataSourceDelegate]): Return nullptr when building without disk image cache
enabled on iOS.

  • WebView/WebDataSourcePrivate.h: Removed platform #ifdefs added in

<​http://trac.webkit.org/changeset/156918> (​https://bugs.webkit.org/show_bug.cgi?id=121985)

3:40 PM Changeset in webkit [157752] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Give up on building RemoteLayerTreeTransaction::dump on Lion, it just won't work.

This definitely ought to fix the build.

  • Shared/mac/RemoteLayerTreeTransaction.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:
  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):

3:25 PM Changeset in webkit [157751] by rniwa@webkit.org
  • 8 edits in trunk/Websites/test-results

New flakiness dashboard show test time, modifiers, and flaky tests
​https://bugs.webkit.org/show_bug.cgi?id=123119

Reviewed by Tim Horton.

  • api/failing-tests.php: Manually serialize each row in the results to avoid hitting the memory limit.
  • include/db.php:

(Database::query): Added.
(Database::fetch_next_row): Added.

  • include/init-database.sql: Added modifiers and time columns to results table.
  • include/test-results.php:

(store_test_results): Update start_time and end_time to the union of the new interval and the existing interval.
(recursively_add_test_results): Handle empty $full_name to eliminate the loop over tests in store_test_results.
Also verify that each test name, expected and actual results conform to the specific format to prevent XSS.
Also use insert_row instead of select_or_insert_row to avoid issuing an unnecessary SQL query.
(format_result): Extracted from format_result_rows. Used in failing-tests.php.

  • index.html:

(TestResultsView): Added _currentBuilderFailureType and _currentBuilderDays.
(TestResultsView._createResultCell): Show the test time and the expected result.
(TestResultsView._createTestResultRow): Compute the slowest run and also round time to tenth of second for time
less than 10s or second if it's more than 10s so that the test time will always be shown in two digits.
Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers.
(TestResultsView._matchesFailureType): Added. Determines whether results is of a particular failure type.
(TestResultsView._populateBuilderPane):
(TestResultsView.fetchFailingTestsForBuilder): Store the failure type such as flaky, wrongtestexpectations.
(TestResultsView.updateLocationHash):
(TestResultsView.loadTestsFromLocationHash):
(fetchManifest):

  • js/dom.js:

(element): appendChild if an item is a Node. Otherwise, e.g. integer, create a text node out of toString() call.

  • main.css: Updated styles.
3:21 PM Changeset in webkit [157750] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Maybe a Lion build fix after r157731, part 2.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):

3:11 PM Changeset in webkit [157749] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; unprotect the declaration of updateSleepDisabling();

  • html/HTMLMediaElement.h:
3:09 PM Changeset in webkit [157748] by mitz@apple.com
  • 9 edits
    4 moves
    12 adds in trunk/Source/WebKit2

[Cocoa] Back/forward list UI process API
​https://bugs.webkit.org/show_bug.cgi?id=123109

Reviewed by Darin Adler.

  • CMakeLists.txt: Updated for renames.
  • GNUmakefile.list.am: Ditto.
  • Shared/Cocoa: Added.
  • Shared/Cocoa/WKNSArray.h: Added. WKNSArray is an internal NSArray subclass backed by

a WebKit::ImmutableArray.

  • Shared/Cocoa/WKNSArray.mm: Added.

(+[WKNSArray web_arrayWithImmutableArray:]): Added.
(-[WKNSArray web_initWithImmutableArray:]): Added.
(-[WKNSArray count]): Added.
(-[WKNSArray objectAtIndex:]): Added.
(-[WKNSArray copyWithZone:]): Added.

  • Shared/Cocoa/WKNSObjectExtras.h: Added. Declares a category on NSObject that allows us to

vend WebKit API objects as Objective-C objects.

  • Shared/Cocoa/WKNSObjectExtras.mm: Added.

(-[WKObject initWithAPIObject:]): WKObject is the generic Cocoa wrapper for API objects.
(-[WKObject isEqual:]): Check for equality of the underlying object.
(-[WKObject hash]): Return a pointer to the underlying object.
(-[WKObject description]): Added.
(+[NSObject _web_objectWithAPIObject:]): Added. Returns an appropriate Objective-C object
for the given API object. Currently returns a WKBackForwardListItem for a back/forward list
item and a generic WKObject for all other types.

  • UIProcess/API/C/WKBackForwardList.cpp: Renamed.
  • UIProcess/API/C/WKBackForwardList.h: Renamed.
  • UIProcess/API/C/WKBackForwardListItem.cpp: Renamed.
  • UIProcess/API/C/WKBackForwardListItem.h: Renamed.
  • UIProcess/API/C/WKBackForwardListItemRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
  • UIProcess/API/C/WKBackForwardListItemRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
  • UIProcess/API/C/WKBackForwardListRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
  • UIProcess/API/C/WKBackForwardListRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardList.h.
  • UIProcess/API/C/WebKit2_C.h: Updated for header renames.
  • UIProcess/API/efl/ewk_back_forward_list.cpp: Updated for rename.
  • UIProcess/API/efl/ewk_back_forward_list_item.cpp: Ditto.
  • UIProcess/API/mac/WKBrowsingContextController.h: Declared backForwardList property.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController backForwardList]): Added this accessor.

  • UIProcess/Cocoa: Added.
  • UIProcess/Cocoa/WKBackForwardList.h: Added.
  • UIProcess/Cocoa/WKBackForwardList.mm: Added.

(toWKBackForwardListItem): Added this helper.
(-[WKBackForwardList currentItem]): Added.
(-[WKBackForwardList backItem]): Added.
(-[WKBackForwardList forwardItem]): Added.
(-[WKBackForwardList itemAtIndex:]): Added.
(-[WKBackForwardList backListCount]): Added.
(-[WKBackForwardList forwardListCount]): Added.
(-[WKBackForwardList backListWithLimit:]): Added.
(-[WKBackForwardList forwardListWithLimit:]): Added.
(-[WKBackForwardList _initWithList:]): Added.

  • UIProcess/Cocoa/WKBackForwardListInternal.h: Added.
  • UIProcess/Cocoa/WKBackForwardListItem.h: Added.
  • UIProcess/Cocoa/WKBackForwardListItem.mm: Added.

(-[WKBackForwardListItem URL]): Added.
(-[WKBackForwardListItem title]): Added.
(-[WKBackForwardListItem originalURL]): Added.
(-[WKBackForwardListItem isEqual:]): Check for equality of the underlying object.
(-[WKBackForwardListItem hash]): Return a pointer to the underlying object
(-[WKBackForwardListItem _initWithItem:]): Added.

  • UIProcess/Cocoa/WKBackForwardListItemInternal.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Updated for renames and additions.
3:06 PM Changeset in webkit [157747] by mitz@apple.com
  • 3 edits in trunk/Tools

Style checker should allow a space after the @property keyword
​https://bugs.webkit.org/show_bug.cgi?id=123117

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing_for_function_call): Allow a space between @property and the following (

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_spacing_for_fncall): Added a test case.

3:00 PM Changeset in webkit [157746] by mark.lam@apple.com
  • 14 edits in trunk/Source

Avoid JSC debugger overhead unless needed.
​https://bugs.webkit.org/show_bug.cgi?id=123084.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • If no breakpoints are set, we now avoid calling the debug hook callbacks.
  • If no break on exception is set, we also avoid exception event debug callbacks.
  • When we return from the ScriptDebugServer to the JSC::Debugger, we may no longer call the debug hook callbacks if not needed. Hence, the m_currentCallFrame pointer in the ScriptDebugServer may become stale. To avoid this issue, before returning, the ScriptDebugServer will clear its m_currentCallFrame if needsOpDebugCallbacks() is false.
  • debugger/Debugger.cpp:

(JSC::Debugger::Debugger):
(JSC::Debugger::setNeedsExceptionCallbacks):
(JSC::Debugger::setShouldPause):
(JSC::Debugger::updateNumberOfBreakpoints):
(JSC::Debugger::updateNeedForOpDebugCallbacks):

  • debugger/Debugger.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_debug):

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LowLevelInterpreter.asm:

Source/WebCore:

No new tests.

  • If no breakpoints are set, we now avoid calling the debug hook callbacks.
  • If no break on exception is set, we also avoid exception event debug callbacks.
  • When we return from the ScriptDebugServer to the JSC::Debugger, we may no longer call the debug hook callbacks if not needed. Hence, the m_currentCallFrame pointer in the ScriptDebugServer may become stale. To avoid this issue, before returning, the ScriptDebugServer will clear its m_currentCallFrame if needsOpDebugCallbacks() is false.
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::didReachBreakpoint):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::reset):

Source/WebKit/mac:

  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):

2:48 PM Changeset in webkit [157745] by Lucas Forschler
  • 6 edits in branches/safari-537.73-branch/Source

Merged r154067. <rdar://problem/15109373>

2:43 PM Changeset in webkit [157744] by Lucas Forschler
  • 1 edit
    2 copies in branches/safari-537.73-branch/LayoutTests

Merged r153982. <rdar://problem/15109382>

2:42 PM Changeset in webkit [157743] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r153975. <rdar://problem/15109382>

2:39 PM Changeset in webkit [157742] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r153920. <rdar://problem/15109364>

2:36 PM Changeset in webkit [157741] by Lucas Forschler
  • 8 edits
    2 copies in branches/safari-537.73-branch

Merged r153913. <rdar://problem/15109360>

2:33 PM Changeset in webkit [157740] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r153909. <rdar://problem/15109368>

2:31 PM Changeset in webkit [157739] by commit-queue@webkit.org
  • 11 edits in trunk

Grammar markers are not updated when switching between 1x and 2x
​https://bugs.webkit.org/show_bug.cgi?id=122146

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-10-21
Reviewed by Dean Jackson.

Source/WebCore:

When running editing/spelling/grammar-markers-hidpi.html, the 2x
grammar/spelling dot resources are cached. If you then run
editing/spelling/grammar-markers.html without tearing down WebKit,
it re-uses the 2x dots. The difference between the two tests is a call
to testRunner.setBackingScaleFactor().

We create a NSColor from an NSImage, and remember it in a static
variable. However, NSColor inspects the current graphics context to
determine which resolution to use, and then remembers that decision.
Therefore, we want to recreate the NSColor whenever the device pixel
ratio changes. This patch adds a new static function to GraphicsContext
which recreates this NSColor every time the ratio changes.

Tests: editing/spelling/grammar-markers.html

editing/spelling/inline_spelling_markers.html

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::makePattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):

LayoutTests:

  • platform/mac/editing/spelling/grammar-markers-expected.png:
  • platform/mac/editing/spelling/inline_spelling_markers-expected.png:
  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::makePattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):

2:26 PM Changeset in webkit [157738] by Lucas Forschler
  • 11 edits
    2 copies in branches/safari-537.73-branch

Merged r153877. <rdar://problem/15109353>

2:26 PM Changeset in webkit [157737] by Brent Fulgham
  • 3 edits in trunk/Source/JavaScriptCore

[WIN] Unreviewed build correction.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Handle new JIT files as C++ implementation sources, not header files.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
2:22 PM Changeset in webkit [157736] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Use pink layer borders for compositing layers with a contents layer
​https://bugs.webkit.org/show_bug.cgi?id=123118

Reviewed by Dean Jackson.

With the existing layer border colors, it's not possible to distinguish an empty
layer from one with solid color, image or video contents. So use a pink color
for those. This makes it easier to diagnose bugs like 122784.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::getDebugBorderInfo):

2:20 PM Changeset in webkit [157735] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebCore

Limit use of display sleep assertion when <video> element is off-screen.
​https://bugs.webkit.org/show_bug.cgi?id=123041

Reviewed by Darin Adler.

Use page visibility changes to suspend and resume the use of sleep assertions in
HTMLMediaElement.

Page will propogate the page visibility change notifications to its Documents, which
will further propogate those notifications to registered elements. Upon receiving
these notifications, HTMLMediaElement will release or take a DisplaySleepDisabler
token if necessary.

Also, rename HTMLMediaElement's updateDisableSleep() to updateSleepDisabling() and wrap
the implementation in a PLATFORM(MAC) guard rather than at each call site.

  • dom/Document.cpp:

(WebCore::Document::registerForVisibilityStateCallbacks): Added registration method.
(WebCore::Document::unregisterForVisibilityStateCallbacks): Added unregistration method.
(WebCore::Document::visibilityStateChanged): Call all registered clients.

  • dom/Document.h:
  • dom/Element.h:

(WebCore::Element::visibilityStateChanged): Added default virtual method to be overridden

by subclasses.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Register for the notification, and check the

current status of Document::hidden().

(WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for the notification.
(WebCore::HTMLMediaElement::visibilityStateChanged): Set m_displaySleepDisablingSuspended

and call updateSleepDisabling().

(WebCore::HTMLMediaElement::shouldDisableSleep): Add a check for m_displaySleepDisablingSuspended.

  • html/HTMLMediaElement.h:
  • page/Page.cpp:

(WebCore::Page::setVisibilityState): Pass to every child document.

Rename updateDisableSleep() -> updateSleepDisabling():

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::stop):

2:20 PM Changeset in webkit [157734] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Maybe a Lion build fix after r157731.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):

2:14 PM Changeset in webkit [157733] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

MediaStreamTrack now tracks its own state
​https://bugs.webkit.org/show_bug.cgi?id=123025

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-21
Reviewed by Jer Noble.

The spec says that a MediaStreamSource can be shared by different tracks,
so a track must have its own state tracking, synchronizing with its MediaStreamSource when
the underlying MediaStreamSource changes the readyState.
In the old implementation if a user invoked the stop method, its readyState method was still
returning the MediaStreamSource state, which was wrong.
This also adds a setEnabled method, which can be used to set the state of a track when a
remote peer ends it, for instance.

No new tests needed.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::setState):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::ended):
(WebCore::MediaStreamTrack::sourceStateChanged):
(WebCore::MediaStreamTrack::trackDidEnd):

  • Modules/mediastream/MediaStreamTrack.h:
1:59 PM Changeset in webkit [157732] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WTF

Merged r153767. <rdar://problem/15109338>

1:42 PM Changeset in webkit [157731] by timothy_horton@apple.com
  • 4 edits in trunk/Source

Remote Layer Tree: Clean up transaction logging
​https://bugs.webkit.org/show_bug.cgi?id=123116

Reviewed by Anders Carlsson.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::RemoteLayerTreeTextStream):
(WebKit::RemoteLayerTreeTextStream::increaseIndent):
(WebKit::RemoteLayerTreeTextStream::decreaseIndent):
(WebKit::RemoteLayerTreeTextStream::writeIndent):
(WebKit::RemoteLayerTreeTextStream::operator<<):
Add some stream operator overrides for various types we need to dump.
Add a notion of current indent to our TextStream subclass to make it
easy to keep track of where we are.

(WebKit::dumpProperty):
Added, hand any arbitrary type to RemoteLayerTreeTransaction.

(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::dump):
Make use of TextStream.

  • WebCore.exp.in:

Export some TextStream functions.

1:31 PM Changeset in webkit [157730] by beidson@apple.com
  • 22 edits in trunk/Source

Transition most use of IDBBackingStoreLevelDB to IDBBackingStoreInterface
​https://bugs.webkit.org/show_bug.cgi?id=123105

Reviewed by Anders Carlsson.

Source/WebCore:

Export more required headers:

  • WebCore.xcodeproj/project.pbxproj:

Flesh out many of the pure virtual methods on IDBBackingStoreInterface, as well as
the RecordIdentifier and Cursor classes:

  • Modules/indexeddb/IDBBackingStoreInterface.h:

(WebCore::IDBBackingStoreInterface::RecordIdentifier::~RecordIdentifier):
(WebCore::IDBBackingStoreInterface::Cursor::~Cursor):

Use IDBBackingStoreInterface, IDBBackingStoreInterface::RecordIdentifier, and
IDBBackingStoreInterface::Cursor wherever possible:

  • Modules/indexeddb/IDBFactoryBackendInterface.cpp:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::IndexKeyCursorImpl::clone):
(WebCore::IndexCursorImpl::clone):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
(WebCore::IDBBackingStoreLevelDB::Transaction::Transaction):
(WebCore::IDBBackingStoreLevelDB::Transaction::begin):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

(WebCore::IDBBackingStoreLevelDB::RecordIdentifier::RecordIdentifier):

  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:

(WebCore::IDBCursorBackendLevelDB::IDBCursorBackendLevelDB):

  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:

(WebCore::IDBCursorBackendLevelDB::create):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::create):
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::backingStore):
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::createTransaction):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::createTransactionBackend):

  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:

(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::verifyIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::addingKeyAllowed):
(WebCore::IDBObjectStoreBackendLevelDB::makeIndexWriters):
(WebCore::IDBObjectStoreBackendLevelDB::generateKey):
(WebCore::IDBObjectStoreBackendLevelDB::updateKeyGenerator):

  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:

(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:

(WebCore::GetOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:

(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):

Source/WebKit2:

Stub out a new pure virtual method:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::createTransactionBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
1:18 PM Changeset in webkit [157729] by zoltan@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Shapes][CSS Regions] Don't apply shape-inside when we have multiple auto-height regions and the height is not resolved
​https://bugs.webkit.org/show_bug.cgi?id=123103

Reviewed by David Hyatt.

When we have multiple regions with auto-height, the region's height is not resolved from other elements we can't apply the
the shape on the region. This patch prevents to apply the shape and fixes the behavior for these cases.

Source/WebCore:

Test: fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutShapeInsideInfo):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):

LayoutTests:

  • fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html: Added.
1:16 PM Changeset in webkit [157728] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Remote Layer Tree: Backing store should take contentsScale into account
​https://bugs.webkit.org/show_bug.cgi?id=123106

Reviewed by Simon Fraser.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::ensureBackingStore):
(PlatformCALayerRemote::setNeedsDisplay):
(PlatformCALayerRemote::setContentsScale):
Inform the backing store of the contentsScale, and when it changes.

  • WebProcess/WebPage/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::scale): Added.
(WebKit::RemoteLayerBackingStore::mapToContentCoordinates): Added.

  • WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
(RemoteLayerBackingStore::mapToContentCoordinates):
Factor out flipping so we can use it for repaints in multiple places.

(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Create a buffer scaled up by contentsScale, take the scale into account
when copying clean bits from the front buffer, and apply the scale before
painting into the back buffer.

  • WebCore.exp.in:

Export FloatRect::scale.

1:15 PM Changeset in webkit [157727] by oliver@apple.com
  • 1 edit
    3 adds in trunk/Source/WebInspectorUI

Restore accidentally removed files.

1:10 PM Changeset in webkit [157726] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderScrollbarPart doesn't need styleWillChange().
<​https://webkit.org/b/123113>

We will call setInline(false) in styleDidChange(), there's no need
to override styleWillChange() just to do it twice.

Reviewed by Darin Adler.

12:38 PM Changeset in webkit [157725] by commit-queue@webkit.org
  • 29 edits
    20 adds in trunk

[CSS Regions] The layers from the flow thread should be collected under the regions' layers.
​https://bugs.webkit.org/show_bug.cgi?id=120457

Patch by Mihai Maerean <Mihai Maerean> on 2013-10-21
Reviewed by David Hyatt.

Source/WebCore:

This patch is based on the work of Alexandru Chiculita at ​https://bugs.webkit.org/attachment.cgi?id=203872&action=review

The composited layers inside the named flow threads are collected as part of the regions (as children of the
GraphicsLayer of the layer that corresponds to the region (which is attached to the parent renderer of
RenderNameFlowFragment)).
When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
that region too (inside RenderLayerCompositor::computeRegionCompositingRequirements).

This patch has landed before (as ​http://trac.webkit.org/changeset/156451), but was reverted because
fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited
that only enables compositing for layers inside flow threads that collect the graphics layers under the regions.

Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under
the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's
parent renderer, not in the region renderer (RenderNamedFlowFragment).

Tests: compositing/regions/crash-transform-inside-region.html

compositing/regions/floated-region-with-transformed-child.html
compositing/regions/move-layer-from-one-region-to-another.html
compositing/regions/propagate-region-box-shadow-border-padding-for-video.html
compositing/regions/propagate-region-box-shadow-border-padding.html
compositing/regions/region-as-layer-in-another-flowthread.html
compositing/regions/transform-transparent-positioned-video-inside-region.html
compositing/regions/transformed-layer-inside-transformed-layer.html
compositing/regions/z-index-update.html
compositing/regions/z-index.html

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
through the RenderView::styleDidChange function.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
we update all the mappings between the layers inside the flow thread and the regions where those layers will be
painted.
(WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
(WebCore::RenderFlowThread::collectsGraphicsLayersUnderRegions):
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
from a region to another since the last update.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):

  • rendering/RenderFlowThread.h:
  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::pushRenderFlowThread):

  • rendering/RenderGeometryMap.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::enclosingFlowThreadAncestor):
(WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateLayerBounds): When we calculate the bounds of the RenderView, we ignore those
flow threads that collect the graphics layers under the regions.
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's a flow thread that collects the graphics
layers under the regions
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
its borders, paddings, outlines or box-shadows to layers inside it.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly if
we are going to collect the composited layers as part of regions.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
use composited RenderRegions to render the background of the RenderFlowThread.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a container of a css region.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowFragment.h:

(WebCore::RenderNamedFlowFragment::layerOwner): When the content inside the region requires the region to have a
layer, the layer will be created on the region's parent renderer instead. This method returns that renderer
holding the layer. The return value may be null.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
(WebCore::RenderNamedFlowThread::collectsGraphicsLayersUnderRegions):

  • rendering/RenderNamedFlowThread.h: m_flowThreadChildList is now allocated through an OwnPtr to keep the render

arena under the size limit.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):

  • rendering/RenderRegion.h:

(WebCore::toRenderRegion):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • WebCore.exp.in: WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions

LayoutTests:

  • compositing/regions/crash-transform-inside-region-expected.html: Added.
  • compositing/regions/crash-transform-inside-region.html: Added.
  • compositing/regions/floated-region-with-transformed-child-expected.html: Added.
  • compositing/regions/floated-region-with-transformed-child.html: Added.
  • compositing/regions/move-layer-from-one-region-to-another-expected.html: Added.
  • compositing/regions/move-layer-from-one-region-to-another.html: Added.
  • compositing/regions/propagate-region-box-shadow-border-padding-expected.html: Added.
  • compositing/regions/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
  • compositing/regions/propagate-region-box-shadow-border-padding-for-video.html: Added.
  • compositing/regions/propagate-region-box-shadow-border-padding.html: Added.
  • compositing/regions/region-as-layer-in-another-flowthread-expected.html: Added.
  • compositing/regions/region-as-layer-in-another-flowthread.html: Added.
  • compositing/regions/transform-transparent-positioned-video-inside-region-expected.html: Added.
  • compositing/regions/transform-transparent-positioned-video-inside-region.html: Added.
  • compositing/regions/transformed-layer-inside-transformed-layer-expected.html: Added.
  • compositing/regions/transformed-layer-inside-transformed-layer.html: Added.
  • compositing/regions/webkit-flow-renderer-layer-compositing-expected.html:
  • compositing/regions/webkit-flow-renderer-layer-compositing.html:
  • compositing/regions/z-index-expected.html: Added.
  • compositing/regions/z-index-update-expected.html: Added.
  • compositing/regions/z-index-update.html: Added.
  • compositing/regions/z-index.html: Added.
  • fast/multicol/mixed-positioning-stacking-order-expected.html:
  • fast/multicol/mixed-positioning-stacking-order.html:
  • fast/repaint/region-painting-composited-element-expected.html:
  • fast/repaint/region-painting-composited-element.html:
  • platform/mac-wk2/TestExpectations:
12:23 PM Changeset in webkit [157724] by oliver@apple.com
  • 10 edits
    3 adds in trunk

Source/JavaScriptCore: Support computed property names in object literals
​https://bugs.webkit.org/show_bug.cgi?id=123112

Reviewed by Michael Saboff.

Add support for computed property names to the parser.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::getName):

  • parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode):

  • parser/Nodes.h:

(JSC::PropertyNode::expressionName):
(JSC::PropertyNode::name):

  • parser/Parser.cpp:

(JSC::::parseProperty):
(JSC::::parseStrictObjectLiteral):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::Property::Property):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::operatorStackPop):

LayoutTests: Support expression property names in object literals
​https://bugs.webkit.org/show_bug.cgi?id=123112

Reviewed by Michael Saboff.

Add tests

  • js/basic-computed-property-name-expected.txt: Added.
  • js/basic-computed-property-name.html: Added.
  • js/parser-syntax-check-expected.txt:
  • js/script-tests/basic-computed-property-name.js: Added.

(a.string_appeared_here.runTest):

  • js/script-tests/parser-syntax-check.js:
12:02 PM Changeset in webkit [157723] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixing mediastream debug build
​https://bugs.webkit.org/show_bug.cgi?id=123104

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-21
Reviewed by Andreas Kling.

No new tests needed.

  • Modules/mediastream/RTCDTMFToneChangeEvent.cpp:

(WebCore::RTCDTMFToneChangeEvent::create):

11:29 AM Changeset in webkit [157722] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Merge RenderListMarker::styleWillChange() into styleDidChange().
<​https://webkit.org/b/123098>

If the marker's list-style-type or list-style-position changed, we
need to dirty the layout. Move this logic to styleDidChange() so we
can get rid of one styleWillChange() overload.

Reviewed by Antti Koivisto.

10:04 AM Changeset in webkit [157721] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/media-controller-time-clamp.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=123099

  • platform/mac/TestExpectations: Marking as such.
9:53 AM Changeset in webkit [157720] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

[CSS Regions] Fix WHITESPACE issues in the CSS grammar.
​https://bugs.webkit.org/show_bug.cgi?id=123082

Patch by Mihai Maerean <Mihai Maerean> on 2013-10-21
Reviewed by Andreas Kling.

This is a port of Rune Lillesveen's patch from ​https://codereview.chromium.org/25607005

Source/WebCore:

Fix WHITESPACE issues in the CSS grammar.

A single WHITESPACE token consumes consecutive spaces, but does not consume
spaces separated by comments. That means S* and S+ in CSS grammars need to
accept multiple WHITESPACE tokens. Additionally, white spaces are not
mandatory to separate an @-symbol and the rest of the prelude.

Use space non-terminal instead of WHITESPACE for S+ in calc expressions.

Use maybe_space non-terminal instead of WHITESPACE for S* after @-webkit-filter
and @-webkit-region.

Tests: fast/css/calc-comments-allowed.html

fast/regions/webkit-region-syntax-space.html

  • css/CSSGrammar.y.in:

LayoutTests:

  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt:
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js:
  • fast/css/calc-comments-allowed-expected.html: Added.
  • fast/css/calc-comments-allowed.html: Added.
  • fast/regions/webkit-region-syntax-space-expected.txt: Added.
  • fast/regions/webkit-region-syntax-space.html: Added.
8:41 AM Changeset in webkit [157719] by dbates@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Add option so that JSC will crash if it can't allocate executable memory for the JITs
​https://bugs.webkit.org/show_bug.cgi?id=123048
<rdar://problem/12856193>

Patch by Michael Saboff <​msaboff@apple.com> on 2013-10-21
Reviewed by Geoffrey Garen.

Added new option, called crashIfCantAllocateJITMemory. If this option is true then we crash
when checking the validity of the executable allocator. The default value for this option is
false, but jsc sets it to true when built for iOS to make it straightforward to identify whether
the app can obtain executable memory.

  • jsc.cpp: Explicitly enable crashIfCantAllocateJITMemory on iOS.

(main):

  • runtime/Options.h: Added option crashIfCantAllocateJITMemory.
  • runtime/VM.cpp:

(JSC::enableAssembler): Modified to crash if option crashIfCantAllocateJITMemory
is enabled.

7:02 AM Changeset in webkit [157718] by mario@webkit.org
  • 4 edits in trunk/Source/WebCore

[ATK] Use atk_object_notify_state_change instead of manually emitting signals
​https://bugs.webkit.org/show_bug.cgi?id=122968

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-21
Reviewed by Mario Sanchez Prada.

Refactor emitting "state-change" event to use atk_object_notify_state_change
instead of using g_signal_emit_by_name.

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleDetach):

  • editing/atk/FrameSelectionAtk.cpp:

(WebCore::maybeEmitTextFocusChange):

2:53 AM Changeset in webkit [157717] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source

Make TYPE_CASTS_BASE more flexible
​https://bugs.webkit.org/show_bug.cgi?id=122951

Reviewed by Andreas Kling.

TYPE_CASTS_BASE is being used by node|element type casts. However, it is difficult
to be used by other type casts. For instance, CSSValue, Accessibility and so on.
This patch modifies TYPE_CASTS_BASE which can support other type casts.

Besides TYPE_CASTS_BASE body is moved from node.h to Assertions.h.

Source/WebCore:

No new tests, no behavior changes.

  • dom/Document.h:
  • dom/Node.h:

Source/WTF:

  • wtf/Assertions.h:
2:44 AM Changeset in webkit [157716] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Build does not start.
​https://bugs.webkit.org/show_bug.cgi?id=123059

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-21
Reviewed by Csaba Osztrogonác.

The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.

  • Scripts/build-webkit:
2:43 AM Changeset in webkit [157715] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk

Remove .qmake.conf files
​https://bugs.webkit.org/show_bug.cgi?id=123091

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-10-21
Reviewed by Csaba Osztrogonác.

  • .qmake.conf: Removed.
2:32 AM Changeset in webkit [157714] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/Source/JavaScriptCore

Remove AllInOneFile.cpp
​https://bugs.webkit.org/show_bug.cgi?id=123055

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-21
Reviewed by Csaba Osztrogonác.

  • AllInOneFile.cpp: Removed.
2:31 AM Changeset in webkit [157713] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove qt from generate-forwarding-headers.pl
​https://bugs.webkit.org/show_bug.cgi?id=123090

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-10-21
Reviewed by Andreas Kling.

  • Scripts/generate-forwarding-headers.pl:
2:00 AM Changeset in webkit [157712] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Jhbuild] Bump the required Jhbuild revision
​https://bugs.webkit.org/show_bug.cgi?id=123089

Reviewed by Carlos Garcia Campos.

  • jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild

due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
in the Jhbuild source so a more recent revision of it should be used.

1:57 AM Changeset in webkit [157711] by zandobersek@gmail.com
  • 4 edits in trunk/Source

[GTK] g-ir-scanner should use the configured C compiler
​https://bugs.webkit.org/show_bug.cgi?id=123088

Reviewed by Carlos Garcia Campos.

Source/WebKit/gtk:

  • GNUmakefile.am: Pass the C compiler that was detected at configuration to the g-ir-scanner command

via the CC environment variable. This solves the issue of the scanner running the GCC compiler with
the Clang-specific CFLAGS.

Source/WebKit2:

  • GNUmakefile.am: Pass the C compiler that was detected at configuration to the g-ir-scanner command

via the CC environment variable. This solves the issue of the scanner running the GCC compiler with
the Clang-specific CFLAGS.

12:11 AM Changeset in webkit [157710] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty
​https://bugs.webkit.org/show_bug.cgi?id=122097

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

When remove format command is called we pushdown the ancestor style
down to its children. Currently applying inline style to iframe
while pushing down style which causes iframe to be reinserted in tree and
triggres again subframe loading which repeats everytime and finally
crash happens. So we should avoid applying inline style to iframe
element as it doesnot reflect in its content while pushing down style
on it.

And ASSERT call has been removed from setTextDecoration property as
the scenario is perfectly valid case.

Test: editing/execCommand/remove-format-textdecoration-in-iframe.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Return if
element is iframe.

  • editing/EditingStyle.cpp:

(WebCore::StyleChange::setTextDecorationProperty): Remove ASSERT.

LayoutTests:

Added Test cases to verify that crash does not happen in scenario when
remove format command is executed on selection containing the iframe
element and when textdecoration style is defined as !important and
need to pushDown to iframe.

  • editing/execCommand/remove-format-textdecoration-in-iframe-expected.txt: Added.
  • editing/execCommand/remove-format-textdecoration-in-iframe.html: Added.

Oct 20, 2013:

11:08 PM Changeset in webkit [157709] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Update EFL test expectations.

  • platform/efl/TestExpectations: Skip authentication tests that are failing.
10:14 PM Changeset in webkit [157708] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, cleanup a FIXME comment.

  • jit/Repatch.cpp:
9:48 PM Changeset in webkit [157707] by fpizlo@apple.com
  • 19 edits
    3 adds in trunk/Source

StructureStubInfo's usedRegisters set should be able to track all registers, not just the ones that our JIT's view as temporaries
​https://bugs.webkit.org/show_bug.cgi?id=123076

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Start preparing for a world in which we are patching code generated by LLVM, which may have
very different register usage conventions than our JITs. This requires us being more explicit
about the registers we are using. For example, the repatching code shouldn't take for granted
that tagMaskRegister holds the TagMask or that the register is even in use.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::numberOfRegisters):
(JSC::MacroAssembler::registerIndex):
(JSC::MacroAssembler::numberOfFPRegisters):
(JSC::MacroAssembler::fpRegisterIndex):
(JSC::MacroAssembler::totalNumberOfRegisters):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::usedRegisters):

  • dfg/DFGSpeculativeJIT.h:
  • ftl/FTLSaveRestore.cpp:

(JSC::FTL::bytesForGPRs):
(JSC::FTL::bytesForFPRs):
(JSC::FTL::offsetOfGPR):
(JSC::FTL::offsetOfFPR):

  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdGenerator::JITGetByIdGenerator):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/RegisterSet.cpp: Added.

(JSC::RegisterSet::specialRegisters):

  • jit/RegisterSet.h: Added.

(JSC::RegisterSet::RegisterSet):
(JSC::RegisterSet::set):
(JSC::RegisterSet::clear):
(JSC::RegisterSet::get):
(JSC::RegisterSet::merge):

  • jit/Repatch.cpp:

(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::tryRepatchIn):
(JSC::linkClosureCall):

  • jit/TempRegisterSet.cpp: Added.

(JSC::TempRegisterSet::TempRegisterSet):

  • jit/TempRegisterSet.h:

Source/WTF:

Reviewed by Sam Weinig.

Teach BitVector how to efficiently merge (i.e. bitvector |=).

  • wtf/BitVector.cpp:

(WTF::BitVector::mergeSlow):

  • wtf/BitVector.h:

(WTF::BitVector::merge):
(WTF::BitVector::cleanseInlineBits):

6:02 PM Changeset in webkit [157706] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Update EFL test expectations.

  • platform/efl/TestExpectations: Mark fast/workers/worker-call.html as failure.
3:57 PM Changeset in webkit [157705] by weinig@apple.com
  • 9 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 5)
​https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Antti Koivisto.

  • Move m_lineBoxes to RenderBlockFlow.
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::innerTextIfTruncated):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::removeFromDelayedUpdateScrollInfoSet):
(WebCore::RenderBlock::paintContents):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::hitTestContents):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::inlineBlockBaseline):
(WebCore::RenderBlock::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlock::addFocusRingRects):
(WebCore::RenderBlock::showLineTreeAndMark):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::hasInlineBoxChildren):
(WebCore::RenderBlock::paintInlineChildren):
(WebCore::RenderBlock::hitTestInlineChildren):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::deleteLineBoxTree):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):
(WebCore::RenderBlockFlow::markLinesDirtyInBlockRange):
(WebCore::RenderBlockFlow::firstLineBoxBaseline):
(WebCore::RenderBlockFlow::inlineBlockBaseline):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::positionForBox):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::relayoutForPagination):
(WebCore::RenderBlockFlow::showLineTreeAndMark):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::lineBoxes):
(WebCore::RenderBlockFlow::firstLineBox):
(WebCore::RenderBlockFlow::lastLineBox):
(WebCore::RenderBlockFlow::firstRootBox):
(WebCore::RenderBlockFlow::lastRootBox):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):

11:33 AM Changeset in webkit [157704] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Avoid unnecessary vector copy in AnimationController event dispatch.
<​https://webkit.org/b/122994>

Use Vector's move constructor instead of making a copy of the pending
events queue and then clearing it.

Reviewed by Simon Fraser.

9:36 AM Changeset in webkit [157703] by beidson@apple.com
  • 11 edits
    1 add in trunk/Source/WebCore

Add abstract IDBBackingStoreInterface, use it to get IDBDatabaseBackendLevelDB closer to going cross-platform
​https://bugs.webkit.org/show_bug.cgi?id=123074

Reviewed by Andreas Kling.

  • Modules/indexeddb/IDBBackingStoreInterface.h: Added.

(WebCore::IDBBackingStoreInterface::~IDBBackingStoreInterface):
(WebCore::IDBBackingStoreInterface::Transaction::~Transaction):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

(WebCore::IDBBackingStoreLevelDB::Transaction::reset):
(WebCore::IDBBackingStoreLevelDB::Transaction::levelDBTransactionFrom):

  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:

(WebCore::IDBCursorBackendLevelDB::deleteFunction):

  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:

(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::verifyIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::addingKeyAllowed):

  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

(WebCore::IDBTransactionBackendLevelDB::backingStoreTransaction):

  • WebCore.xcodeproj/project.pbxproj:
  • GNUmakefile.list.am:
9:12 AM Changeset in webkit [157702] by akling@apple.com
  • 17 edits in trunk/Source

Use PassRef for StyleSheetContents.
<​https://webkit.org/b/123083>

Let functions that return newly-constructed StyleSheetContents
objects vend PassRef<StyleSheetContents> instead of PassRefPtr.

Updated functions that take StyleSheetContents in arguments
accordingly. And CSSStyleSheet now has a Ref internally. Woo!

Reviewed by Antti Koivisto.

8:43 AM Changeset in webkit [157701] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

[Cocoa] Loading progress API
​https://bugs.webkit.org/show_bug.cgi?id=123069

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKBrowsingContextController.h: Declared estimatedProgress property.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController estimatedProgress]): Added.
(didStartProgress): Added. Calls new delegate method
-browsingContextControllerDidStartProgress:.
(didChangeProgress): Added. Calls new delegate method
-browsingContextController:estimatedProgressChangedTo:.
(didFinishProgress): Added. Calls new delegate method
-browsingContextControllerDidFinishProgress:.
(setUpPageLoaderClient): Hook up new client functions.

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declared new delegate methods.
7:14 AM Changeset in webkit [157700] by commit-queue@webkit.org
  • 15 edits in trunk/Source

Removing "unused parameter" compiling warnings from WebKit2 and WebCore
​https://bugs.webkit.org/show_bug.cgi?id=123075

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-20
Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

  • Modules/mediastream/RTCDTMFToneChangeEvent.cpp:

(WebCore::RTCDTMFToneChangeEvent::create):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(lineAtPositionForAtkBoundary):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):

Source/WebKit2:

  • NetworkProcess/NetworkProcessPlatformStrategies.cpp:

(WebKit::NetworkProcessPlatformStrategies::loadResourceSynchronously):

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetPluginSiteDataManager):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorUsesWebKitUserInterface):
(WKPreferencesGetInspectorUsesWebKitUserInterface):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetFullScreenClient):
(WKBundlePageWillEnterFullScreen):
(WKBundlePageDidEnterFullScreen):
(WKBundlePageWillExitFullScreen):
(WKBundlePageDidExitFullScreen):

  • WebProcess/MediaCache/WebMediaCacheManager.cpp:

(WebKit::WebMediaCacheManager::clearCacheForHostname):

  • WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteAllEntries):
(WebKit::WebOriginDataManager::startObservingChanges):
(WebKit::WebOriginDataManager::stopObservingChanges):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
(WebKit::WebFrameLoaderClient::recreatePlugin):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::canPluginHandleResponse):

4:06 AM Changeset in webkit [157699] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] Fix build (broken since r157690).
​https://bugs.webkit.org/show_bug.cgi?id=123081

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-20
Reviewed by Andreas Kling.

  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::buffer):
(JSC::SH4Assembler::readCallTarget):

3:49 AM Changeset in webkit [157698] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Use PassRef for constructing StyleRules.
<​https://webkit.org/b/123072>

Let functions that return newly-constructed StyleRuleFoo objects
vend PassRef<StyleRuleFoo> instead of PassRefPtr.

Since StyleRuleBase::copy() has to return something, we can't rely
on ASSERT_NOT_REACHED() + return nullptr anymore, so I've replaced
those with CRASH(). No call sites actually handled null anyway.

Reviewed by Sam Weinig.

Note: See TracTimeline for information about the timeline view.