Timeline
Oct 22, 2013:
- 11:50 PM Changeset in webkit [157851] by
-
- 6 edits in trunk
Refactor LineBreaker::nextSegmentBreak, add BreakingContext that holds all its state
https://bugs.webkit.org/show_bug.cgi?id=123038
Reviewed by David Hyatt.
Source/WebCore:
I followed Levi's logic on Blink's nextSegmentBreak refactoring (https://chromiumcodereview.appspot.com/25054004).
I mostly did the same changes, but the code is too diverged at this point to just apply that patch on our trunk. The patch
introduces BreakingContext as a separate class. I added new methods for each condition, which were originally located in
nextSegmentBreak. I also removed the goto-s from the code. All the new methods are inline in order to avoid introducing any
performance regression. The change makes the code so much cleaner and understandable.
This change would be the first step of the nextSegmentBreak refactoring, I wanted to keep things in place in RenderBlockLineLayout.cpp
for now, but I'm planning to separate BreakingContext into a new file and do additional changes to make things nicer. I'm tracking
the entire progress under http://webkit.org/b/121261 meta bug.
No new tests, covered by existing tests.
- I updated 1 expected result, because there was a 1 pixel difference on the result, which I believe comes from a rounding situation.
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::lineBreak):
(WebCore::BreakingContext::lineBreakRef):
(WebCore::BreakingContext::lineWidth):
(WebCore::BreakingContext::atEnd):
(WebCore::BreakingContext::clearLineBreakIfFitsOnLine):
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::increment):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::nextCharacter):
(WebCore::BreakingContext::handleText):
(WebCore::textBeginsWithBreakablePosition):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::BreakingContext::handleEndOfLine):
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- platform/mac/editing/selection/after-line-wrap-expected.png:
- platform/mac/editing/selection/after-line-wrap-expected.txt: I updated the test, there was 1 pixel difference on the
output I think I run into a rounding error.
- 11:03 PM Changeset in webkit [157850] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed build fix attempt on Soup based port after r157842.
WebCore::CertificateInfo was reverted to WebKit::PlatformCertificateInfo.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):
- 9:42 PM Changeset in webkit [157849] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix attempt on EFL port after r157842.
- Shared/soup/PlatformCertificateInfo.h: Removed message of merge confliction.
- 9:16 PM Changeset in webkit [157848] by
-
- 15 edits in trunk/Source/WebCore
Unreviewed, rolling out r157826.
http://trac.webkit.org/changeset/157826
https://bugs.webkit.org/show_bug.cgi?id=123197
Caused some regions tests to assert (Requested by smfr on
#webkit).
- dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::styleForRenderer):
- dom/Element.h:
- dom/ElementRareData.h:
(WebCore::ElementRareData::setComputedStyle):
(WebCore::ElementRareData::resetComputedStyle):
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::textWithDirection):
- page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
- rendering/RenderElement.h:
(WebCore::RenderElement::setStyleInternal):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
(WebCore::RenderRegion::setObjectStyleInRegion):
- rendering/RenderRegion.h:
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveLocal):
- 9:09 PM Changeset in webkit [157847] by
-
- 4 edits in trunk
[EFL] Remove HAVE_GLX macro
https://bugs.webkit.org/show_bug.cgi?id=123191
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/OptionsEfl.cmake: Removed unnecessary HAVE_GLX macro
Source/WebCore:
Since r138313, HAVE(GLX) was replaced to USE(GLX) except in GraphicsSurfaceToken.h.
- platform/graphics/surfaces/GraphicsSurfaceToken.h:
Replace HAVE(GLX) to USE(GLX)
- 9:04 PM Changeset in webkit [157846] by
-
- 2 edits in trunk/Source/WebKit2
Fix build failures after r157842.
- WebProcess/WebProcess.h: Don't try to #include a file that was deleted.
It won't work.
- 8:39 PM Changeset in webkit [157845] by
-
- 3 edits in trunk/Source/WebCore
Gardening: fix broken build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=123174.
Not reviewed.
No new tests.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 8:23 PM Changeset in webkit [157844] by
-
- 18 edits2 adds2 deletes in trunk/Source
Get rid of IDBObjectStoreBackendLevelDB
https://bugs.webkit.org/show_bug.cgi?id=123174
Reviewed by Tim Horton.
Source/WebCore:
This file was kind of a dumping ground.
Its contents can be merged into IDBBackingStoreInterface and a new IDBIndexWriter class.
Also took the opportunity to do a little bit of RefPtr<> and pointer-vs-reference cleanup.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp: Removed.
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h: Removed.
- Modules/indexeddb/IDBIndexWriter.cpp: Added.
(WebCore::IDBIndexWriter::IDBIndexWriter):
(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):
- Modules/indexeddb/IDBIndexWriter.h: Added.
(WebCore::IDBIndexWriter::create):
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBMetadata.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
(WebCore::IDBBackingStoreLevelDB::generateKey):
(WebCore::IDBBackingStoreLevelDB::updateKeyGenerator):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::setIndexesReady):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::schedulePutOperation):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::PutOperation::perform):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- 6:52 PM Changeset in webkit [157843] by
-
- 19 edits in trunk/Source
[WebGL] Implement a software rendering option on Mac
https://bugs.webkit.org/show_bug.cgi?id=123177
Reviewed by Tim Horton.
Implement a way to force software OpenGL rendering
for WebGL, via a Setting/Preference.
Source/WebCore:
No new tests. We intentionally hide the capabilities of
the renderer from the content, so you can't test for
this setting. However, manual inspection is pretty
obvious. Just go to a page with a complex shader
such as https://www.shadertoy.com/view/lss3WS.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create): If we're forcing software
rendering, mark the context attributes as such.
- page/Settings.in: New setting key.
- platform/graphics/GraphicsContext3D.h: New flag in Attributes.
(WebCore::GraphicsContext3D::Attributes::Attributes):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): Slight update to the
algorithm that sets a pixel format. If we're forcing software rendering,
obviously we never want to create an accelerated pixel format.
- platform/graphics/filters/CustomFilterGlobalContext.cpp:
(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded): Set the attribute
here before trying to create the context.
- platform/graphics/filters/CustomFilterGlobalContext.h: Add a forceSoftwareRendering
flag to prepareContextIfNeeded.
- rendering/FilterEffectRenderer.cpp:
(WebCore::createCustomFilterEffect): Check the Setting before creating a custom
filter context.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h: New WebKitForceSoftwareWebGLRendering key.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences forceSoftwareWebGLRendering]):
(-[WebPreferences setForceSoftwareWebGLRendering:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesStore.h: New ForceSoftwareWebGLRendering entry.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetForceSoftwareWebGLRendering):
(WKPreferencesGetForceSoftwareWebGLRendering):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- mac/WebKit2.order:
- 6:15 PM Changeset in webkit [157842] by
-
- 50 edits3 moves1 add1 delete in trunk/Source
Revert r157445 since it broke certificates on Mac.
<rdar://problem/15246926&15254017&15269117>
Source/WebCore:
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/ResourceErrorBase.h:
- platform/network/ResourceResponseBase.h:
- platform/network/cf/CertificateInfoCFNet.cpp: Removed.
- platform/network/cf/ResourceResponse.h:
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::setCertificateChain):
(WebCore::ResourceResponse::certificateChain):
- platform/network/soup/ResourceError.h:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::tlsErrors):
(WebCore::ResourceError::setTLSErrors):
(WebCore::ResourceError::certificate):
(WebCore::ResourceError::setCertificate):
- platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::tlsError):
(WebCore::ResourceError::platformCopy):
(WebCore::ResourceError::platformCompare):
- platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::soupMessageCertificate):
(WebCore::ResourceResponse::setSoupMessageCertificate):
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::toSoupMessage):
(WebCore::ResourceResponse::updateFromSoupMessage):
Source/WebKit2:
- GNUmakefile.list.am:
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
- Shared/Authentication/AuthenticationManager.h:
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/PlatformCertificateInfo.h: Renamed from Source/WebCore/platform/network/soup/CertificateInfoSoup.cpp.
(WebKit::PlatformCertificateInfo::certificateChain):
- Shared/mac/PlatformCertificateInfo.mm: Renamed from Source/WebCore/platform/network/mac/CertificateInfoMac.mm.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- Shared/soup/PlatformCertificateInfo.cpp: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
- Shared/soup/PlatformCertificateInfo.h: Renamed from Source/WebCore/platform/network/CertificateInfo.h.
(WebKit::PlatformCertificateInfo::certificate):
(WebKit::PlatformCertificateInfo::tlsErrors):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_tls_info):
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- 6:03 PM Changeset in webkit [157841] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/regions/region-as-layer-in-another-flowthread.html as an image failure.
- platform/mac/TestExpectations:
- 5:55 PM Changeset in webkit [157840] by
-
- 2 edits in trunk/Tools
Dashboard repaints constantly
https://bugs.webkit.org/show_bug.cgi?id=122133
Reviewed by Tim Horton.
Pulsing shadows are really bad for battery life.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line.bad .bubble):
(.status-line.bad .message):
- 5:48 PM Changeset in webkit [157839] by
-
- 5 edits in trunk
Unreviewed, rolling out r157835.
http://trac.webkit.org/changeset/157835
https://bugs.webkit.org/show_bug.cgi?id=123192
broke 32-bit builds (Requested by smfr on #webkit).
Source/WTF:
- wtf/MediaTime.cpp:
(WTF::signum):
- wtf/MediaTime.h:
Tools:
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
- 5:44 PM Changeset in webkit [157838] by
-
- 3 edits in trunk/Websites/test-results
New flakiness dashboard's test pane should show the latest WebKit revision for each builder
https://bugs.webkit.org/show_bug.cgi?id=123189
Reviewed by Simon Fraser.
- index.html:
(TestResultsView._populateTestPane): Call _createTestResultHeader and _createTestResultRow with
a list of repository information.
(TestResultsView._createTestResultHeader): Optionally creates headers for a list of repositories.
(TestResultsView._createTestResultRow): Add a hyperlinked revision information for each builder.
Also add a hyperlink to file a Bugzilla bug when there is no bug associated with the test already.
- js/build.js:
(Build.formattedRevision): Extracted from Build.formattedRevisions.
(Build.formattedRevisions):
- 5:39 PM Changeset in webkit [157837] by
-
- 4 edits in trunk/Source/WebKit2
Remote Layer Tree: Disable threaded scrolling for RemoteLayerTreeDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=123187
Reviewed by Dean Jackson.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::supportsThreadedScrolling):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Threaded scrolling doesn't work with remote layer trees yet.
Let the DrawingArea subclass tell WebPage if it supports threaded
scrolling, and make TiledCoreAnimationDrawingArea say that it does.
- 5:26 PM Changeset in webkit [157836] by
-
- 6 edits in trunk/Source/JavaScriptCore
Minor VM* -> VM& cleanups in HashTable and Keywords.
<https://webkit.org/b/123183>
Turn some VM* variables that will never be null into VM&.
Reviewed by Geoffrey Garen.
- 5:18 PM Changeset in webkit [157835] by
-
- 5 edits in trunk
[WTF] Add a multiplication operator (and a few others) to MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123137
Reviewed by Eric Carlson.
Source/WTF:
Add a multiplication operator and an inequality operator to the
MediaTime class for use by MSE.
- wtf/MediaTime.cpp:
(WTF::signum): Moved to top of file.
(WTF::MediaTime::operator*): Added.
(WTF::MediaTime::operator!=): Added.
- wtf/MediaTime.h:
(WTF::operator*): Added non-class version of operator*.
Tools:
Add tests for new MediaTime operators.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
- 5:14 PM Changeset in webkit [157834] by
-
- 16 edits in trunk/Source/WebCore
[Media] Refactor supportsType() factory method to take a parameters object.
https://bugs.webkit.org/show_bug.cgi?id=122489
Reviewed by Eric Carlson.
In order to support adding new conditional properties with which to decide
what MediaPlayerPrivate subclass to create, replace the two versions of the
supportsType() factory method with a single one taking a parameters object.
At the same time, add a 'isMediaSource' parameter to that object, allowing
MediaPlayerPrivate subclasses which support the same type and codecs but
which do not both support MediaSource to be distinguised.
- platform/graphics/MediaPlayer.cpp:
(WebCore::bestMediaEngineForSupportParameters): Renamed from
bestMediaEngineForTypeAndCodecs.
(WebCore::MediaPlayer::nextBestMediaEngine): Added convenience function.
(WebCore::MediaPlayer::loadWithNextMediaEngine): Call nextBestMediaEngine()
(WebCore::MediaPlayer::supportsType): Pass parameter object.
(WebCore::MediaPlayer::networkStateChanged): Call nextBestMediaEngine().
- platform/graphics/MediaPlayer.h:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::supportsType): Handle parameter object.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine): Remove extraneous
extendedSupportsType method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Handle parameter object.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::supportsType): Ditto.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Remove extraneous
extendedSupportsType method.
(WebCore::MediaPlayerPrivateQTKit::supportsType): Handle parameter object.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::supportsType): Ditto.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/wince/MediaPlayerPrivateWinCE.h:
- 5:12 PM Changeset in webkit [157833] by
-
- 3 edits in trunk/Source/WebCore
Merge SVGRenderBlock::styleWillChange() into styleDidChange().
<https://webkit.org/b/123181>
I meant to do this one in r157787, but better late than never.
Reviewed by Geoffrey Garen.
- 5:08 PM Changeset in webkit [157832] by
-
- 3 edits in trunk/Websites/test-results
Make tables on the new flakiness dashboard sortable
https://bugs.webkit.org/show_bug.cgi?id=123141
Reviewed by Simon Fraser.
Use jquery.tablesorter.js to make test and builder tables sortable. The jquery plugin is already used by run-perf-tests.
- index.html:
(TestResultsView._populateTestPane): Add tablesorter to the class name and wrap tr's inside a tbody so that tablesorter
could sort them.
(TestResultsView._populateBuilderPane): Ditto.
- main.css:
(.resultsTable thead): Use cursor: pointer to signify the fact it's clickable.
(.resultsTable th): Don't repeat arrows.
(.resultsTable th.headerSortUp): Inline SVG up arrow.
(.resultsTable th.headerSortDown): Inline SVG down arrow.
- 5:05 PM Changeset in webkit [157831] by
-
- 8 edits in trunk/Tools
Educate webkitpy about Mavericks.
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_os_version):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
- Scripts/webkitpy/port/builders.py:
- Scripts/webkitpy/port/mac.py:
(MacPort):
- Scripts/webkitpy/port/mac_unittest.py:
(test_versions):
(test_baseline_search_path):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory):
(TestRebaselineExpectations.test_rebaseline_expectations):
- 5:00 PM Changeset in webkit [157830] by
-
- 6 edits in trunk
REGRESSION:
if (false === (true && undefined)) console.log("wrong!");logs "wrong!", shouldn't!
https://bugs.webkit.org/show_bug.cgi?id=123179
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- parser/NodeConstructors.h:
(JSC::LogicalOpNode::LogicalOpNode):
- parser/ResultType.h:
(JSC::ResultType::forLogicalOp): Don't assume that && produces a boolean.
This is JavaScript (aka Sparta).
LayoutTests:
- js/dom/branch-fold-correctness.html: Added a test for this case.
- 4:59 PM Changeset in webkit [157829] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix on EFL port after r157823
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode): renamed getOperationType() to type().
- 4:59 PM Changeset in webkit [157828] by
-
- 19 edits in trunk/Source/WebCore
CTTE: Modernize RenderBlock a bit
https://bugs.webkit.org/show_bug.cgi?id=123162
Reviewed by Andreas Kling.
Start threading references through RenderBlock. While we
are here, do some selective modernization as well.
- 4:55 PM Changeset in webkit [157827] by
-
- 2 edits in trunk/Tools
Update the build trigger list for Mavericks.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
- 4:32 PM Changeset in webkit [157826] by
-
- 15 edits in trunk/Source/WebCore
Even more PassRef<RenderStyle>!
<https://webkit.org/b/123147>
Convert the remaining WebCore code to use PassRef for RenderStyle
wherever they are known to be non-null.
Reviewed by Antti Koivisto.
- 3:58 PM Changeset in webkit [157825] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r157819.
http://trac.webkit.org/changeset/157819
https://bugs.webkit.org/show_bug.cgi?id=123180
Broke 32-bit builds (Requested by smfr on #webkit).
Source/JavaScriptCore:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig:
Source/WebCore:
- Configurations/WebCore.xcconfig:
- 3:37 PM Changeset in webkit [157824] by
-
- 10 edits in trunk/Source/WebCore
Rename deleteLineBoxTree to deleteLines
https://bugs.webkit.org/show_bug.cgi?id=123176
Reviewed by Andreas Kling.
RenderBlock::deleteLineBoxTree -> RenderBlock::deleteLines
RenderInline::deleteLineBoxTree -> RenderInline::deleteLines
- 3:33 PM Changeset in webkit [157823] by
-
- 28 edits in trunk/Source
{ClipPathOperation, FilterOperation}::getOperationType() should not include 'get'
https://bugs.webkit.org/show_bug.cgi?id=123172
Reviewed by Simon Fraser.
No new tests, just a rename.
"get" in WebCore tends to mean that the function has out arguments; these have no arguments.
Rename FilterOperation::getOperationType() to FilterOperation::type().
I noticed that ClipPathOperation had the same mistake, so I fixed it there too.
Removed long and useless list of WebCore files.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeFilterOperation):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):
Adopt the new name.
- 3:32 PM Changeset in webkit [157822] by
-
- 2 edits in trunk/Tools
Add Mavericks bots to the dashboard.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- 3:30 PM Changeset in webkit [157821] by
-
- 17 edits2 adds in trunk
AX: Add paramAttrs to fetch start and end text markers in a given rect.
https://bugs.webkit.org/show_bug.cgi?id=122164
Patch by Samuel White <Samuel White> on 2013-10-22
Reviewed by Chris Fleizach.
Source/WebCore:
Added ability to fetch end and start text markers inside a given bounds. This gives ScreenReaders
like VoiceOver a way to retrieve the text markers for a specified column of page text.
Test: platform/mac/accessibility/text-marker-for-bounds.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::mainFrame):
(WebCore::AccessibilityObject::topDocument):
(WebCore::AccessibilityObject::visiblePositionForBounds):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper screenToContents:]):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Tools:
Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
- DumpRenderTree/AccessibilityUIElement.cpp:
(endTextMarkerForBoundsCallback):
(startTextMarkerForBoundsCallback):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
LayoutTests:
Added test to ensure end/start text marker for bounds works as
expected. Updated bounds for range test to include new API.
- platform/mac/accessibility/bounds-for-range-expected.txt:
- platform/mac/accessibility/text-marker-for-bounds-expected.txt: Added.
- platform/mac/accessibility/text-marker-for-bounds.html: Added.
- 3:07 PM Changeset in webkit [157820] by
-
- 2 edits in trunk/Source/WebCore
[CSS Shapes] Match adjustLogicalLineTopAndLogicalHeightIfNeeded's implementation with Blink's
https://bugs.webkit.org/show_bug.cgi?id=123033
Reviewed by David Hyatt.
In Blink I made this function in a bit different way. This change modifies it
to be identical, which helps a lot in the future cross-merging patches.
No new tests, covered by existing texts.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):
- 3:02 PM Changeset in webkit [157819] by
-
- 5 edits in trunk/Source
[iOS] Upstream more ARMv7s bits
https://bugs.webkit.org/show_bug.cgi?id=123052
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig: Enable CLANG_ENABLE_OBJC_ARC for i386 as I'm
modifying a file in JavaScriptCore/Configurations.
Source/WebCore:
- Configurations/WebCore.xcconfig:
- 2:49 PM Changeset in webkit [157818] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Mavericks build; use <> for framework include.
- page/CaptionUserPreferencesMediaAF.cpp:
- 2:45 PM Changeset in webkit [157817] by
-
- 4 edits in trunk/Source/WebKit2
URTBF after r157803 for !ENABLE(CSS_FILTERS) platforms.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- Shared/WebCoreArgumentCoders.cpp:
- 2:40 PM Changeset in webkit [157816] by
-
- 3 edits in trunk/Source/WebCore
GammaFilterOperation seems to be dead code
https://bugs.webkit.org/show_bug.cgi?id=123173
Reviewed by Simon Fraser.
- platform/graphics/filters/FilterOperation.cpp:
- platform/graphics/filters/FilterOperation.h:
Remove dead code.
- 2:24 PM Changeset in webkit [157815] by
-
- 3 edits in trunk/Tools
There should be a way to specify additional repository paths in NRWT
https://bugs.webkit.org/show_bug.cgi?id=123135
Reviewed by Alexey Proskuryakov.
Added --additional-repository-name and --additional-repository-path options to NRWT.
These options allow us to submit addtional repository information, such as of Safari's
to the new flakiness dashboard.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/port/base.py:
(Port.repository_paths):
- 2:23 PM Changeset in webkit [157814] by
-
- 3 edits in tags/Safari-538.2.1/Source/WebKit/mac
Merged r157753.
- 2:20 PM Changeset in webkit [157813] by
-
- 5 edits in tags/Safari-538.2.1/Source
Versioning.
- 2:18 PM Changeset in webkit [157812] by
-
- 1 copy in tags/Safari-538.2.1
New Tag.
- 2:08 PM Changeset in webkit [157811] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py
add mac-mavericks to wkbuild_unittest.py.
- 2:03 PM Changeset in webkit [157810] by
-
- 31 edits in trunk/Source/WebCore
Rename some line box functions to be just about lines
https://bugs.webkit.org/show_bug.cgi?id=123168
Reviewed by Dave Hyatt.
firstLineBoxBaseline -> firstLineBaseline
hasInlineBoxChildren -> hasLines
Also use hasLines in a bunch of places where firstLineBox() was used.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Also use hasRenderedText() instead of firstTextBox()
- rendering/RenderFullScreen.cpp:
Fix namespace.
- 1:40 PM Changeset in webkit [157809] by
-
- 3 edits in trunk/Source/JavaScriptCore
[iOS] Upstream JSLock changes
https://bugs.webkit.org/show_bug.cgi?id=123107
Reviewed by Geoffrey Garen.
- runtime/JSLock.cpp:
(JSC::JSLock::unlock):
(JSC::JSLock::dropAllLocks): Modified to take a SpinLock, used only on iOS.
(JSC::JSLock::dropAllLocksUnconditionally): Modified to take a SpinLock, used only on iOS. Also
use pre-increment instead of post-increment when we're not using the return value of the instruction.
(JSC::JSLock::grabAllLocks): Modified to take a SpinLock, used only on iOS. Also change
places where we were using post-increment/post-decrement to use pre-increment/pre-decrement,
since we don't use the return value of such instructions.
(JSC::JSLock::DropAllLocks::DropAllLocks): Modified to support releasing all locks unconditionally.
Take a spin lock before releasing all locks on iOS. Also, use nullptr instead of 0.
(JSC::JSLock::DropAllLocks::~DropAllLocks): Take a spin lock before acquiring all locks on iOS.
- runtime/JSLock.h: Remove extraneous argument name "exec" from DropAllLocks as the data type of
the argument is sufficiently descriptive of its purpose.
- 1:18 PM Changeset in webkit [157808] by
-
- 7 edits1 copy4 adds in trunk/Source/WebCore
Adding Mock class to test RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=122848
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-22
Reviewed by Eric Carlson.
The following tests can be run:
RTCPeerConnection-createAnswer.html
RTCPeerConnection-createOffer.html
RTCPeerConnection-ice.html
RTCPeerConnection-localDescription.html
RTCPeerConnection-remoteDescription.html
RTCPeerConnection-state.html
Tests that require a MediaStream object, by invoking getUserMedia,
are not ready to run yet.
No new tests needed.
- CMakeLists.txt:
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(WebCore::createHandler):
- platform/mediastream/RTCPeerConnectionHandler.h:
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
- platform/mock/RTCNotifiersMock.cpp: Added.
- platform/mock/RTCNotifiersMock.h: Added.
- platform/mock/RTCPeerConnectionHandlerMock.cpp: Added.
- platform/mock/RTCPeerConnectionHandlerMock.h: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h.
- platform/mock/TimerEventBasedMock.h: Added.
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::enableMockRTCPeerConnectionHandler):
- testing/Internals.h:
- 1:16 PM Changeset in webkit [157807] by
-
- 2 edits in trunk/Source/WebCore
WebCore::fillWithEmptyClients adopts new empty clients before leaking their pointers
https://bugs.webkit.org/show_bug.cgi?id=122945
Reviewed by Anders Carlsson.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients): Store the static empty clients as NeverDestroyed, rather than
adopting the pointer of each heap-allocated object and then immediately leaking that pointer.
- 1:10 PM Changeset in webkit [157806] by
-
- 3 edits in trunk/Source/WebCore
Simplify HRTFDatabaseLoader's load map
https://bugs.webkit.org/show_bug.cgi?id=122944
Reviewed by Eric Carlson.
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::loaderMap): Return a reference to a NeverDestroyed HashMap that maps sample rates to loaders.
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
- platform/audio/HRTFDatabaseLoader.h: Remove the LoaderMap type definition, the private singleton of that type
and the singleton's unused getter.
- 12:46 PM Changeset in webkit [157805] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py
add mac-mavericks to the target_platform list.
- 12:28 PM Changeset in webkit [157804] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r157774.
http://trac.webkit.org/changeset/157774
https://bugs.webkit.org/show_bug.cgi?id=123167
causes python test to fail (Requested by smfr on #webkit).
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.init):
(TestExpectations._add_expectations):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
- 12:25 PM Changeset in webkit [157803] by
-
- 14 edits in trunk/Source
Remote Layer Tree: Support hardware accelerated filters
https://bugs.webkit.org/show_bug.cgi?id=123139
Reviewed by Anders Carlsson.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::ArgumentCoder<Length>::encode):
(CoreIPC::ArgumentCoder<Length>::decode):
Add simple coders for Length.
(CoreIPC::encodeFilterOperation):
(CoreIPC::decodeFilterOperation):
Serialize and deserialize FilterOperations, except for CUSTOM and VALIDATED_CUSTOM.
(CoreIPC::ArgumentCoder<Length>::encode):
(CoreIPC::ArgumentCoder<Length>::decode):
Add coders for FilterOperations that delegate to {en,de}codeFilterOperation
for each operation in the list.
- Shared/WebCoreArgumentCoders.h:
Drive-by fix indentation.
Expose the Length and FilterOperations coders.
- Shared/mac/RemoteLayerTreeTransaction.h:
Add FiltersChanged and LayerProperties::filters.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Encode and decode our FilterOperations.
(WebKit::dumpChangedLayers):
Dump information about the layers' filters.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
Use PlatformCAFilters code to apply a FilterOperations object to our CALayer.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setFilters):
Replace existing filters with our new set, and note that they've changed.
(PlatformCALayerRemote::copyFiltersFrom):
Not yet implemented. Not critical for this feature, either.
(PlatformCALayerRemote::filtersCanBeComposited):
For now, this is the same as the Mac version.
- WebCore.exp.in:
Export a variety of filter-related things.
- platform/graphics/ca/PlatformCAFilters.h:
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::setFilters):
- platform/graphics/ca/win/PlatformCAFiltersWin.cpp:
(PlatformCAFilters::setFiltersOnLayer):
setFiltersOnLayer should take a PlatformLayer instead of a PlatformCALayer
as its argument, because it doesn't need a PlatformCALayer, and this way
we can share code with the RemoteLayerTreeHost, which only has PlatformLayers
and not PlatformCALayers.
- 12:16 PM Changeset in webkit [157802] by
-
- 2 edits in trunk/Tools
Prepare WebKit Buildbot master for Mavericks.
This adds the following bot configurations:
Mavericks Release/Debug builders
Mavericks Release/Debug WK1 Testers
Mavericks Release/Debug WK2 Testers
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:46 AM Changeset in webkit [157801] by
-
- 5 edits3 adds in trunk
cue.text fails for some track element cues
https://bugs.webkit.org/show_bug.cgi?id=81123
Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-22
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-long-captions-file.html
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::parseBytes): Use buffer when we don't have full lines.
(WebCore::WebVTTParser::fileFinished): Force file to finish parsing.
(WebCore::WebVTTParser::hasRequiredFileIdentifier): Simplify due to using String.
(WebCore::WebVTTParser::collectCueText): Don't automatically create cues when we run out of data.
(WebCore::WebVTTParser::collectNextLine): Use buffer.
- html/track/WebVTTParser.h: Add m_buffer and Finished state.
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::notifyFinished): Call m_parser->fileFinished() when done.
LayoutTests:
- media/track/captions-webvtt/captions-long.vtt: Added.
- media/track/track-long-captions-file-expected.txt: Added.
- media/track/track-long-captions-file.html: Added.
- 10:33 AM Changeset in webkit [157800] by
-
- 2 edits in trunk/Source/JavaScriptCore
[arm] Add missing setupArgumentsWithExecState() prototypes to fix build.
https://bugs.webkit.org/show_bug.cgi?id=123166
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 10:13 AM Changeset in webkit [157799] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=123161
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-22
Reviewed by Brent Fulgham.
- rendering/RenderFlowThread.h: Move USE(ACCELERATED_COMPOSITING) guard to expose needed type.
- 10:08 AM Changeset in webkit [157798] by
-
- 10 edits1 add in trunk/Source/WebCore
Add a cross-platform IDBRecordIdentifier
https://bugs.webkit.org/show_bug.cgi?id=123138
Reviewed by Andreas Kling.
Add the cross-platform header:
- Modules/indexeddb/IDBRecordIdentifier.h: Added.
(WebCore::IDBRecordIdentifier::create):
(WebCore::IDBRecordIdentifier::encodedPrimaryKey):
(WebCore::IDBRecordIdentifier::version):
(WebCore::IDBRecordIdentifier::reset):
(WebCore::IDBRecordIdentifier::IDBRecordIdentifier):
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.list.am:
Remove the old abstract and LevelDB classes:
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
Use the cross-platform one everywhere:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::PutOperation::perform):
- 10:04 AM Changeset in webkit [157797] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4][mips][arm] Fix crashes in JSC (32-bit only).
https://bugs.webkit.org/show_bug.cgi?id=123165
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.
- jit/JITInlines.h:
(JSC::JIT::callOperationNoExceptionCheck): Add missing EABI_32BIT_DUMMY_ARG.
(JSC::JIT::callOperation): The last TrustedImm32(arg3) is a bit overkill for SH4 :)
(JSC::JIT::callOperation): Add missing EABI_32BIT_DUMMY_ARG.
(JSC::JIT::callOperation): Fix tag and payload order for V_JITOperation_EJJJ prototype.
- 8:51 AM Changeset in webkit [157796] by
-
- 5 edits in trunk/Source/JavaScriptCore
REGRESSION(r157690, r157699) Fix architectures using AssemblerBufferWithConstantPool.
https://bugs.webkit.org/show_bug.cgi?id=123092
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.
Impacted architectures are SH4 and ARM_TRADITIONAL.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::buffer):
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::flushConstantPool):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::linkCode):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::buffer):
- 8:46 AM Changeset in webkit [157795] by
-
- 9 edits in trunk/Source/JavaScriptCore
Remove unused stuff in JIT stubs.
https://bugs.webkit.org/show_bug.cgi?id=123155
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.
- jit/JITStubs.h:
- jit/JITStubsARM.h:
(JSC::ctiTrampoline):
- jit/JITStubsARM64.h:
- jit/JITStubsARMv7.h:
- jit/JITStubsMIPS.h:
- jit/JITStubsSH4.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- 8:45 AM Changeset in webkit [157794] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] Upstream OS-version-specific install paths for JavaScriptCore.framework
https://bugs.webkit.org/show_bug.cgi?id=123115
<rdar://problem/13696872>
Reviewed by Andy Estes.
Based on a patch by Mark Hahnenberg.
Add support for running JavaScriptCore-based apps, built against the iOS 7 SDK, on older versions of iOS.
- API/JSBase.cpp:
- 7:50 AM Changeset in webkit [157793] by
-
- 18 edits in trunk/Source/WebCore
[CSS Regions] Possible performance regression after r157567
https://bugs.webkit.org/show_bug.cgi?id=123016
Reviewed by Andreas Kling.
The revision 157567 http://trac.webkit.org/changeset/157567 may have regressed
Parser/html5-full-render by ~1.1% and Parser/html-parser by ~2%. These changes
try to optimize the initial patch, based on Andreas Kling's review.
The patch also adds a couple of refactorings that should make the code easier to read:
- the CSS Shapes functions are now wrapped in a single #if clause
- the CSS Shapes and CSS Regions pre-layout preparations are wrapped in a helper function
The RenderFlowThread::logicalWidthChangedInRegionsForBlock function is optimized by passing
it information about the state of the relayout children flag. If the flag is true already,
some of the steps are skipped.
Tests: no new tests.
- dom/Element.cpp:
(WebCore::Element::webkitGetRegionFlowRanges):
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementInfo):
- rendering/RenderBlock.cpp:
(WebCore::shapeInfoRequiresRelayout):
(WebCore::RenderBlock::updateShapesBeforeBlockLayout):
(WebCore::RenderBlock::computeShapeSize):
(WebCore::RenderBlock::prepareShapesAndPaginationBeforeBlockLayout):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):
(WebCore::RenderBlockFlow::ensureRareData):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderElement::isRenderNamedFlowFragmentContainer):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderElement.h:
(WebCore::RenderElement::generatingElement):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
- rendering/RenderFlowThread.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
- style/StyleResolveTree.cpp:
(WebCore::Style::elementInsideRegionNeedsRenderer):
- 7:43 AM Changeset in webkit [157792] by
-
- 5 edits in trunk/Source/WebCore
CSSStyleSheet constructor functions should return PassRef.
<https://webkit.org/b/123156>
Make CSSStyleSheet::create*() return PassRef and tighten some call
sites that were using them. Most callers didn't need any tweaks to
take advantage of PassRef.
Reviewed by Antti Koivisto.
- 7:43 AM Changeset in webkit [157791] by
-
- 3 edits in trunk/Source/WebCore
CTTE: RenderMathMLFraction always has a MathMLInlineContainerElement.
<https://webkit.org/b/123154>
This renderer is never anonymous and always has a corresponding
MathMLInlineContainerElement. Overload element() with a tighter
return type.
Also marked the class FINAL and made most member functions private.
Reviewed by Antti Koivisto.
- 7:42 AM Changeset in webkit [157790] by
-
- 3 edits in trunk/Source/WebCore
FontGlyphs constructor functions should return PassRef.
<https://webkit.org/b/123159>
Made the two FontGlyphs creator functions return PassRef and tweaked
the FontGlyphsCache in Font.cpp to make more efficient use of it.
Reviewed by Antti Koivisto.
- 6:45 AM Changeset in webkit [157789] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Add missing lastRegister(), firstFPRegister() and lastFPRegister().
https://bugs.webkit.org/show_bug.cgi?id=123157
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Andreas Kling.
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::lastRegister):
(JSC::SH4Assembler::firstFPRegister):
(JSC::SH4Assembler::lastFPRegister):
- 6:12 AM Changeset in webkit [157788] by
-
- 2 edits in trunk/Source/WebCore
Fix some more code to use RenderElement instead of RenderObject.
<https://webkit.org/b/123149>
Using RenderElement where possible lets us skip the isRenderElement()
branch in RenderObject::style() and generates much tighter code.
Reviewed by Antti Koivisto.
- 6:04 AM Changeset in webkit [157787] by
-
- 7 edits in trunk/Source/WebCore
Merge SVG renderers' styleWillChange() into styleDidChange().
<https://webkit.org/b/123108>
This work can just as well be done after setting the style.
Three more styleWillChange() overloads gone.
Reviewed by Antti Koivisto.
- 6:04 AM Changeset in webkit [157786] by
-
- 4 edits in trunk/Source/WebCore
CSSValueList constructor functions should return PassRef.
<https://webkit.org/b/123151>
These functions always return objects, and thus can return PassRef.
Also made CSSValueList::createFromParserValueList() take a reference
since that function is only ever called with a non-null value.
Reviewed by Antti Koivisto.
- 6:03 AM Changeset in webkit [157785] by
-
- 2 edits in trunk/Source/WebCore
Avoid parent style ref churn in createTextRendererIfNeeded().
<https://webkit.org/b/123148>
There's no need to take a temporary ref on the parent's RenderStyle
while creating a text renderer. It's not going away, and the text
renderer is not going to participate in ownership afterwards.
Reviewed by Antti Koivisto.
- 4:57 AM Changeset in webkit [157784] by
-
- 3 edits in trunk/Source/JavaScriptCore
Build break on ARMv7 after r157209
https://bugs.webkit.org/show_bug.cgi?id=122890
Patch by Brian Holt <brian.holt@samsung.com> on 2013-10-22
Reviewed by Csaba Osztrogonác.
Add framePointerRegister and first/last register helpers for ARM_TRADITIONAL.
- assembler/ARMAssembler.h:
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::firstRegister):
(JSC::MacroAssemblerARM::lastRegister):
(JSC::MacroAssemblerARM::firstFPRegister):
(JSC::MacroAssemblerARM::lastFPRegister):
- 3:58 AM Changeset in webkit [157783] by
-
- 2 edits in trunk/Source/WebCore
Remove some unnecessary null checks in RenderElement::setStyle().
<https://webkit.org/b/123146>
After assigning the new style to RenderElement::m_style, we know that
it'll be non-null, so remove all the checking for this.
Reviewed by Antti Koivisto.
- 3:10 AM Changeset in webkit [157782] by
-
- 11 edits in trunk/Source/WebCore
Introduce ACCESSIBILITY_OBJECT_TYPE_CASTS to replace manual toFoo() in accessibility child class
https://bugs.webkit.org/show_bug.cgi?id=123140
Reviewed by Andreas Kling.
As a step to let toFoo use TYPE_CASTS_BASE, DEFINE_TYPE_CASTS can be used for toFoo() in accessibility
child class. The DEFINE_TYPE_CASTS will generate plenty more helper functions for accessibility type cast.
No new tests, no behavior changes.
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMockObject.h:
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilitySVGRoot.h:
- accessibility/AccessibilityScrollView.h:
- accessibility/AccessibilitySpinButton.h:
- accessibility/AccessibilityTable.h:
- 2:09 AM Changeset in webkit [157781] by
-
- 21 edits3 adds in trunk/Source
[GTK] Add WebKit2 API for TLS errors
https://bugs.webkit.org/show_bug.cgi?id=120160
Patch by Brian Holt <brian.holt@samsung.com> on 2013-10-22
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Added a new constructor for CertificateInfo under Soup.
- platform/network/CertificateInfo.h:
- platform/network/soup/CertificateInfoSoup.cpp:
(WebCore::CertificateInfo::CertificateInfo): New constructor using
GTlsCertificateFlags and GTlsCertificate.
Source/WebKit2:
Add a new signal load-failed-with-tls-errors that is emitted with
a WebKitCertificateInfo boxed type to allow users to deal with TLS
errors. A new API is exposed in WebKitWebContext to allow
exceptions for TLS errors on a given host.
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- UIProcess/API/gtk/WebKitCertificateInfo.cpp: Added.
(webkitCertificateInfoGetCertificateInfo):
(webkit_certificate_info_copy):
(webkit_certificate_info_free):
(webkit_certificate_info_get_tls_certificate):
(webkit_certificate_info_get_tls_errors):
- UIProcess/API/gtk/WebKitCertificateInfo.h: Added.
- UIProcess/API/gtk/WebKitCertificateInfoPrivate.h: Added.
(_WebKitCertificateInfo::_WebKitCertificateInfo):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_allow_tls_certificate_for_host): Support TLS
exceptions for a given host.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Added new signal.
(webkitWebViewLoadFailedWithTLSErrors): Emit new signal with
WebKitCertificateInfo and host.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/docs/webkit2gtk.types:
- UIProcess/API/gtk/tests/TestSSL.cpp:
(testLoadFailedWithTLSErrors):
(httpsServerCallback):
(beforeAll): Added new test.
- UIProcess/API/gtk/webkit2.h:
- UIProcess/API/gtk/webkit2marshal.list:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost): Send
message to WebProcess to allow a certificate and host pair.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: New message to tell
WebProcess to allow a specific TLS certificate for a given host.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost): Allow
certificate and host pair.
- 1:39 AM Changeset in webkit [157780] by
-
- 5 edits1 move2 deletes in trunk/LayoutTests
[EFL] accessibility/plugin.html passes incorrectly
https://bugs.webkit.org/show_bug.cgi?id=122889
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-10-22
Reviewed by Chris Fleizach.
Sharing test.swf by all existing layout tests accessing it.
- accessibility/plugin.html:
- fast/loader/sandboxed-plugin-crash.html:
- fast/replaced/border-radius-clip.html:
- fast/replaced/embed-display-none.html:
- fast/replaced/resources/test.swf: Removed.
- platform/mac/accessibility/resources/test.swf: Removed.
- resources/test.swf: Renamed from LayoutTests/fast/loader/resources/test.swf.
- 1:28 AM Changeset in webkit [157779] by
-
- 8 edits in trunk/Source/WebCore
[CSSRegions] Use RenderStyle::hasFlowFrom when needed
https://bugs.webkit.org/show_bug.cgi?id=122543
Reviewed by David Hyatt.
Rename RenderStyle::hasStyleRegion -> RenderStyle::hasFlowFrom.
Use RenderStyle::hasFlowFrom() helper function instead of directly
checking the value of RenderStyle::regionThread().
No change of functionality, covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::didAttachRenderers):
- dom/PseudoElement.h:
(WebCore::pseudoElementRendererIsNeeded):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
- rendering/style/RenderStyle.h:
- 12:32 AM Changeset in webkit [157778] by
-
- 2 edits in trunk/Source/WebKit2
Try to make the 32-bit Mac build happy.
- UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:
Oct 21, 2013:
- 10:19 PM Changeset in webkit [157777] by
-
- 2 edits in trunk/Source/WebKit2
Try to make the 32-bit Mac build happy.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(setUpPageLoaderClient):
- 10:16 PM Changeset in webkit [157776] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Add load delegate method for didChangeBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=123136
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(didChangeBackForwardList): Added. Calls new delegate method.
(setUpPageLoaderClient): Hook up new client function.
- UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declare new delegate method.
- 9:42 PM Changeset in webkit [157775] by
-
- 8 edits5 adds in trunk/Websites/test-results
New flakiness dashboard should hyperlink test names, WebKit revisions, and bubbles
https://bugs.webkit.org/show_bug.cgi?id=123134
Reviewed by Stephanie Lewis.
Copied admin.css, admin-header.php, admin-footer.php, builders.php, repositories.php from WebKit Perf Monitor.
(Unfortunately WebKit Perf Monitor hasn't been committed into WebKit repository just yet.)
Updated various parts of index.html to linkify test names, build numbers, and bubbles (to results page).
- admin/admin.css: Added.
- admin/builders.php: Added.
- admin/index.php: Removed the duplicated code now that it uses admin-header.php.
- admin/repositories.php: Added.
- api/manifest.php: Use camelCase for blame_url and build_url to be consistent with other JSON properties.
Also exported testCategories from config so that we can linkify test names in the dashboard.
- include/admin-footer.php: Added.
- include/admin-header.php: Added.
- include/config.json: Added test categories. This avoids hard-coding the URL to trac in php/js.
- include/init-database.sql: Added name and build_url to builders table and category to tests.
- include/test-results.php: Assume the test category to be LayoutTest for now.
- index.html:
(TestResultsView): Initialize _builders, _slaves, _repositories, _testCategories as dictionaries as intended.
(TestResultsView.setTestCategories): Added.
(TestResultsView._createResultCell): Dynamically resolve URLs of results page and and build page.
(TestResultsView._populateTestPane): Linkify the test name. Unfortunately we don't have a test object anywhere.
We need to figure out a way to find the test object here eventually. For now, hard-coding "LayoutTest" works.
(TestResultsView._linkifiedTestName): Added.
(TestResultsView._createBuildsAndComputeSlownessOfResults): Takes builderId to set "builder" property on each
result object as it's used by Build class.
(TestResultsView._populateBuilderPane):
(fetchManigest):
- js/build.js:
(Build.buildUrl): Support $builderName so that we don't have to keep repeating builder names in the database.
(Build.revision): Don't access [0] if revisions[repositoryId] was undefined.
- 7:17 PM Changeset in webkit [157774] by
-
- 4 edits in trunk/Tools
Run tests as if they are expected to pass when --force is given.
https://bugs.webkit.org/show_bug.cgi?id=112890
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-10-21
Reviewed by Ryosuke Niwa.
The --force switch of new-run-webkit-tests is now forces all tests to
be run with 'PASS' as expected result.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.init):
(TestExpectations._add_expectations):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
- 7:05 PM Changeset in webkit [157773] by
-
- 6 edits in trunk/Source/WebCore
[WIN] Properly support reverse animations without needing software fallback.
https://bugs.webkit.org/show_bug.cgi?id=85121
Reviewed by Dean Jackson.
Testing is provided by existing animation tests.
- platform/animation/TimingFunction.h:
(WebCore::CubicBezierTimingFunction::createReversed): Added.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::addAnimation): The early return when performing a reverse or
autoreverse animation is no longer needed.
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(toCAMediaTimingFunction): Use new reversed function.
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFTimingFunction): Ditto.
(PlatformCAAnimation::setTimingFunction): Pass 'reverse' flag.
(PlatformCAAnimation::setTimingFunctions): Ditto.
- 6:51 PM Changeset in webkit [157772] by
-
- 5 edits in trunk/Websites/test-results
New flakiness dashboard should align results by revision numbers
https://bugs.webkit.org/show_bug.cgi?id=123129
Reviewed by Tim Horton.
- include/config.json: Specify the default cache time to be 10 minutes.
- include/json-shared.php: Added Expires and Cache-Control headers. It's configurable via config.json.
- index.html:
(TestResultsView._createResultCell): Don't put '-' in a result cell without time.
(TestResultsView._populateTestPane): Create an array of build times ordered from the newest to the oldest.
Not that build.time() is the newest commit time among all repository for each result. e.g. if we had
both WebKit and Safari repository information in a given result, the newer of the two will be used.
(TestResultsView._createTestResultHeader): Added.
(TestResultsView._createBuildsAndComputeSlownessOfResults): Extracted from _createTestResultRow so
that _populateTestPane could use Build object before calling _createTestResultRow.
(TestResultsView._createTestResultRow): Takes buildTimes. Insert an empty cell for a build time if
the current row doesn't contain that a result for that build time.
(TestResultsView._populateBuilderPane):
- main.css: Tweaked the style so that bubbles are aligned vertically without '-'.
(.resultsTable):
(.resultsTable thead th):
(.resultsTable .resultCell):
(.resultsTable a):
(.resultsTable span a):
- 6:31 PM Changeset in webkit [157771] by
-
- 1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceMavericks.a
Set svn:mime-type on libWebKitSystemInterfaceMavericks.a so that future changes don't generate giant commit emails.
- 6:27 PM Changeset in webkit [157770] by
-
- 9 edits1 add in trunk
Add a version of WebKitSystemInterface for Mavericks.
Reviewed by Ryosuke Niwa.
Source/WebKit/mac:
- Configurations/DebugRelease.xcconfig:
Source/WebKit2:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- Scripts/copy-webkitlibraries-to-product-directory:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
WebKitLibraries:
- libWebKitSystemInterfaceMavericks.a: Added.
- 6:25 PM Changeset in webkit [157769] by
-
- 33 edits in trunk/Source/WebCore
Use TYPE_CASTS_BASE for CSS_VALUE_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=123126
Reviewed by Andreas Kling.
TYPE_CASTS_BASE was moved to common place to be used by all toFoo().
CSS_VALUE_TYPE_CASTS starts to use it for CSS child value. This change
generates plenty more helper functions for toCSSFooValue().
Additionally, this use support that toWebKitCSSFooValue, which couldn't
use CSS_VALUE_TYPE_CASTS macro.
No new tests, no behavior change.
- css/CSSAspectRatioValue.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSCalculationValue.h:
- css/CSSCanvasValue.h:
- css/CSSCrossfadeValue.h:
- css/CSSCursorImageValue.h:
- css/CSSFilterImageValue.h:
- css/CSSFontFaceSrcValue.h:
- css/CSSFontFeatureValue.h:
- css/CSSFontValue.h:
- css/CSSFunctionValue.h:
- css/CSSGradientValue.h:
- css/CSSGridTemplateValue.h:
- css/CSSImageSetValue.h:
- css/CSSImageValue.h:
- css/CSSInheritedValue.h:
- css/CSSInitialValue.h:
- css/CSSLineBoxContainValue.h:
- css/CSSPrimitiveValue.h:
- css/CSSReflectValue.h:
- css/CSSShadowValue.h:
- css/CSSTimingFunctionValue.h:
- css/CSSUnicodeRangeValue.h:
- css/CSSValue.h:
- css/CSSValueList.h:
- css/CSSVariableValue.h:
- css/WebKitCSSArrayFunctionValue.h:
- css/WebKitCSSFilterValue.h:
- css/WebKitCSSMatFunctionValue.h:
- css/WebKitCSSMixFunctionValue.h:
- css/WebKitCSSSVGDocumentValue.h:
- css/WebKitCSSShaderValue.h:
- 5:29 PM Changeset in webkit [157768] by
-
- 2 edits in trunk/Source/WebCore
Bad cast with toRenderBoxModelObject in RenderBlock::updateFirstLetter()
https://bugs.webkit.org/show_bug.cgi?id=123013
Reviewed by Andreas Kling.
No new tests because this was reported by Google ClusterFuzz.
https://codereview.chromium.org/25713009/
There is a case that toRenderBoxModelObject causes a crash in RenderBlock::updateFirstLetter()
due to bad cast, so we need to check whether the RenderObject is a RenderBoxModelObject
by running isBoxModelObject() before calling toRenderBoxModelObject.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
- 5:18 PM Changeset in webkit [157767] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154289. <rdar://problem/15109381>
- 5:18 PM Changeset in webkit [157766] by
-
- 10 edits2 moves in trunk/Source/WebCore
Make IDBTransactionCoordinatorLevelDB cross platform
https://bugs.webkit.org/show_bug.cgi?id=123124
Enthusiastically reviewed by Tim Horton.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
Make more methods pure virtual in the interface:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
Update the name of the class, and use IDBTransactionBackendInterface instead of IDBTransactionBackendLeveDB:
- Modules/indexeddb/IDBTransactionCoordinator.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp.
(WebCore::IDBTransactionCoordinator::create):
(WebCore::IDBTransactionCoordinator::IDBTransactionCoordinator):
(WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator):
(WebCore::IDBTransactionCoordinator::didCreateTransaction):
(WebCore::IDBTransactionCoordinator::didStartTransaction):
(WebCore::IDBTransactionCoordinator::didFinishTransaction):
(WebCore::IDBTransactionCoordinator::isActive):
(WebCore::IDBTransactionCoordinator::processStartedTransactions):
(WebCore::doScopesOverlap):
(WebCore::IDBTransactionCoordinator::canRunTransaction):
- Modules/indexeddb/IDBTransactionCoordinator.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h.
Update the name of the class elsewhere:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
(WebCore::IDBDatabaseBackendLevelDB::transactionCoordinator):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- 4:55 PM Changeset in webkit [157765] by
-
- 4 edits3 copies in branches/safari-537.73-branch
Merged r154217. <rdar://problem/15109395>
- 4:54 PM Changeset in webkit [157764] by
-
- 11 edits in trunk/Source
[iOS] Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout()
https://bugs.webkit.org/show_bug.cgi?id=123045
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- jsc.cpp: Add function pointer for shouldInterruptScriptBeforeTimeout
to global method table.
- runtime/JSGlobalObject.cpp: Ditto.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::shouldInterruptScriptBeforeTimeout): Added.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::shouldInterruptScriptToPreventInfiniteRecursionWhenClosingPage): Added.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Extracted comment and assertion
about null Page object into WebCore::shouldInterruptScriptToPreventInfiniteRecursionWhenClosingPage()
so that it can be shared by both this function and JSDOMWindowBase::shouldInterruptScriptBeforeTimeout().
(WebCore::JSDOMWindowBase::shouldInterruptScriptBeforeTimeout):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::shouldInterruptScriptBeforeTimeout): Added.
- bindings/js/JSWorkerGlobalScopeBase.h:
- loader/EmptyClients.h: Added isStopping(). We'll land the iOS chrome client implementation
in a subsequent patch.
- page/ChromeClient.h: Added isStopping().
- 4:35 PM Changeset in webkit [157763] by
-
- 16 edits5 copies4 deletes in branches/safari-537.73-branch/Source
Merged r154183. <rdar://problem/15109466>
- 4:35 PM Changeset in webkit [157762] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: [CSS Regions] Flows are not loading if you refresh the page several times
https://bugs.webkit.org/show_bug.cgi?id=123123
Reviewed by Joseph Pecoraro.
There was a typo in the code where an exception was thrown because "flowKey" was undefined.
- UserInterface/DOMTree.js:
(WebInspector.DOMTree.prototype._contentFlowListWasUpdated):
- 4:28 PM Changeset in webkit [157761] by
-
- 3 edits in trunk/Source/JavaScriptCore
[iOS] Upstream JSC Objective-C API compiler warning fixes
https://bugs.webkit.org/show_bug.cgi?id=123125
Reviewed by Mark Hahnenberg.
Based on a patch by Mark Hahnenberg.
- API/JSValue.mm:
(-[JSValue toPoint]): Cast to CGFloat to fix some compiler warnings about double narrowing to float.
(-[JSValue toSize]): Ditto.
- API/tests/testapi.mm: Changed a test that was failing due to overflow of 32-bit NSUInteger on armv7.
- 4:15 PM Changeset in webkit [157760] by
-
- 10 edits in branches/safari-537.73-branch/Source/WebKit/mac
Merged r154078. <rdar://problem/15109379>
- 4:11 PM Changeset in webkit [157759] by
-
- 3 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r154085. <rdar://problem/15109354>
- 4:09 PM Changeset in webkit [157758] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r154077. <rdar://problem/15109354>
- 4:06 PM Changeset in webkit [157757] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r153848. <rdar://problem/15109354>
- 3:55 PM Changeset in webkit [157756] by
-
- 4 edits2 adds in trunk
Navigation policy callback not called when performing the same fragment navigation twice
https://bugs.webkit.org/show_bug.cgi?id=123121
<rdar://problem/15230466>
Reviewed by Beth Dakin.
Source/WebCore:
There's code in PolicyChecker::checkNavigationPolicy that will call the decision function right away
if the requests are equal, without consulting any policy client. Because of this, make sure to empty out
the last checked request of the document loader when doing a fragment navigation.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
Tools:
Add a test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
- TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
(+[WebKit1FragmentNavigationTestDelegate shared]):
(-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
(-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
(-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
(-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
(TestWebKitAPI::TEST):
- 3:49 PM Changeset in webkit [157755] by
-
- 5 edits in trunk/Source/JavaScriptCore
[iOS] Mark classes JS{Context, ManagedValue, Value, VirtualMachine} as
available since iOS 7.0
https://bugs.webkit.org/show_bug.cgi?id=123122
Reviewed by Dan Bernstein.
- API/JSContext.h:
- API/JSManagedValue.h:
- API/JSValue.h:
- API/JSVirtualMachine.h:
- 3:48 PM Changeset in webkit [157754] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix the Mac 32-bit build.
- UIProcess/API/mac/WKBrowsingContextController.h:
- UIProcess/API/mac/WKBrowsingContextController.mm:
- 3:46 PM Changeset in webkit [157753] by
-
- 3 edits in trunk/Source/WebKit/mac
Remove platform #ifdefs from WebDataSourcePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=123120
<rdar://problem/15275533>
Reviewed by Anders Carlsson.
- WebView/WebDataSource.mm:
(-[WebDataSource _setAllowToBeMemoryMapped]): Define empty implementation when building without
disk image cache enabled.
(-[WebDataSource setDataSourceDelegate:]): Ditto.
(-[WebDataSource dataSourceDelegate]): Return nullptr when building without disk image cache
enabled on iOS.
- WebView/WebDataSourcePrivate.h: Removed platform #ifdefs added in
<http://trac.webkit.org/changeset/156918> (https://bugs.webkit.org/show_bug.cgi?id=121985)
- 3:40 PM Changeset in webkit [157752] by
-
- 4 edits in trunk/Source/WebKit2
Give up on building RemoteLayerTreeTransaction::dump on Lion, it just won't work.
This definitely ought to fix the build.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
- 3:25 PM Changeset in webkit [157751] by
-
- 8 edits in trunk/Websites/test-results
New flakiness dashboard show test time, modifiers, and flaky tests
https://bugs.webkit.org/show_bug.cgi?id=123119
Reviewed by Tim Horton.
- api/failing-tests.php: Manually serialize each row in the results to avoid hitting the memory limit.
- include/db.php:
(Database::query): Added.
(Database::fetch_next_row): Added.
- include/init-database.sql: Added modifiers and time columns to results table.
- include/test-results.php:
(store_test_results): Update start_time and end_time to the union of the new interval and the existing interval.
(recursively_add_test_results): Handle empty $full_name to eliminate the loop over tests in store_test_results.
Also verify that each test name, expected and actual results conform to the specific format to prevent XSS.
Also use insert_row instead of select_or_insert_row to avoid issuing an unnecessary SQL query.
(format_result): Extracted from format_result_rows. Used in failing-tests.php.
- index.html:
(TestResultsView): Added _currentBuilderFailureType and _currentBuilderDays.
(TestResultsView._createResultCell): Show the test time and the expected result.
(TestResultsView._createTestResultRow): Compute the slowest run and also round time to tenth of second for time
less than 10s or second if it's more than 10s so that the test time will always be shown in two digits.
Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers.
(TestResultsView._matchesFailureType): Added. Determines whether results is of a particular failure type.
(TestResultsView._populateBuilderPane):
(TestResultsView.fetchFailingTestsForBuilder): Store the failure type such as flaky, wrongtestexpectations.
(TestResultsView.updateLocationHash):
(TestResultsView.loadTestsFromLocationHash):
(fetchManifest):
- js/dom.js:
(element): appendChild if an item is a Node. Otherwise, e.g. integer, create a text node out of toString() call.
- main.css: Updated styles.
- 3:21 PM Changeset in webkit [157750] by
-
- 2 edits in trunk/Source/WebKit2
Maybe a Lion build fix after r157731, part 2.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):
- 3:11 PM Changeset in webkit [157749] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; unprotect the declaration of updateSleepDisabling();
- html/HTMLMediaElement.h:
- 3:09 PM Changeset in webkit [157748] by
-
- 9 edits4 moves12 adds in trunk/Source/WebKit2
[Cocoa] Back/forward list UI process API
https://bugs.webkit.org/show_bug.cgi?id=123109
Reviewed by Darin Adler.
- CMakeLists.txt: Updated for renames.
- GNUmakefile.list.am: Ditto.
- Shared/Cocoa: Added.
- Shared/Cocoa/WKNSArray.h: Added. WKNSArray is an internal NSArray subclass backed by
a WebKit::ImmutableArray.
- Shared/Cocoa/WKNSArray.mm: Added.
(+[WKNSArray web_arrayWithImmutableArray:]): Added.
(-[WKNSArray web_initWithImmutableArray:]): Added.
(-[WKNSArray count]): Added.
(-[WKNSArray objectAtIndex:]): Added.
(-[WKNSArray copyWithZone:]): Added.
- Shared/Cocoa/WKNSObjectExtras.h: Added. Declares a category on NSObject that allows us to
vend WebKit API objects as Objective-C objects.
- Shared/Cocoa/WKNSObjectExtras.mm: Added.
(-[WKObject initWithAPIObject:]): WKObject is the generic Cocoa wrapper for API objects.
(-[WKObject isEqual:]): Check for equality of the underlying object.
(-[WKObject hash]): Return a pointer to the underlying object.
(-[WKObject description]): Added.
(+[NSObject _web_objectWithAPIObject:]): Added. Returns an appropriate Objective-C object
for the given API object. Currently returns a WKBackForwardListItem for a back/forward list
item and a generic WKObject for all other types.
- UIProcess/API/C/WKBackForwardList.cpp: Renamed.
- UIProcess/API/C/WKBackForwardList.h: Renamed.
- UIProcess/API/C/WKBackForwardListItem.cpp: Renamed.
- UIProcess/API/C/WKBackForwardListItem.h: Renamed.
- UIProcess/API/C/WKBackForwardListItemRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
- UIProcess/API/C/WKBackForwardListItemRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
- UIProcess/API/C/WKBackForwardListRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
- UIProcess/API/C/WKBackForwardListRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardList.h.
- UIProcess/API/C/WebKit2_C.h: Updated for header renames.
- UIProcess/API/efl/ewk_back_forward_list.cpp: Updated for rename.
- UIProcess/API/efl/ewk_back_forward_list_item.cpp: Ditto.
- UIProcess/API/mac/WKBrowsingContextController.h: Declared backForwardList property.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController backForwardList]): Added this accessor.
- UIProcess/Cocoa: Added.
- UIProcess/Cocoa/WKBackForwardList.h: Added.
- UIProcess/Cocoa/WKBackForwardList.mm: Added.
(toWKBackForwardListItem): Added this helper.
(-[WKBackForwardList currentItem]): Added.
(-[WKBackForwardList backItem]): Added.
(-[WKBackForwardList forwardItem]): Added.
(-[WKBackForwardList itemAtIndex:]): Added.
(-[WKBackForwardList backListCount]): Added.
(-[WKBackForwardList forwardListCount]): Added.
(-[WKBackForwardList backListWithLimit:]): Added.
(-[WKBackForwardList forwardListWithLimit:]): Added.
(-[WKBackForwardList _initWithList:]): Added.
- UIProcess/Cocoa/WKBackForwardListInternal.h: Added.
- UIProcess/Cocoa/WKBackForwardListItem.h: Added.
- UIProcess/Cocoa/WKBackForwardListItem.mm: Added.
(-[WKBackForwardListItem URL]): Added.
(-[WKBackForwardListItem title]): Added.
(-[WKBackForwardListItem originalURL]): Added.
(-[WKBackForwardListItem isEqual:]): Check for equality of the underlying object.
(-[WKBackForwardListItem hash]): Return a pointer to the underlying object
(-[WKBackForwardListItem _initWithItem:]): Added.
- UIProcess/Cocoa/WKBackForwardListItemInternal.h: Added.
- WebKit2.xcodeproj/project.pbxproj: Updated for renames and additions.
- 3:06 PM Changeset in webkit [157747] by
-
- 3 edits in trunk/Tools
Style checker should allow a space after the @property keyword
https://bugs.webkit.org/show_bug.cgi?id=123117
Reviewed by Anders Carlsson.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing_for_function_call): Allow a space between @property and the following (
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_fncall): Added a test case.
- 3:00 PM Changeset in webkit [157746] by
-
- 14 edits in trunk/Source
Avoid JSC debugger overhead unless needed.
https://bugs.webkit.org/show_bug.cgi?id=123084.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- If no breakpoints are set, we now avoid calling the debug hook callbacks.
- If no break on exception is set, we also avoid exception event debug callbacks.
- When we return from the ScriptDebugServer to the JSC::Debugger, we may no longer call the debug hook callbacks if not needed. Hence, the m_currentCallFrame pointer in the ScriptDebugServer may become stale. To avoid this issue, before returning, the ScriptDebugServer will clear its m_currentCallFrame if needsOpDebugCallbacks() is false.
- debugger/Debugger.cpp:
(JSC::Debugger::Debugger):
(JSC::Debugger::setNeedsExceptionCallbacks):
(JSC::Debugger::setShouldPause):
(JSC::Debugger::updateNumberOfBreakpoints):
(JSC::Debugger::updateNeedForOpDebugCallbacks):
- debugger/Debugger.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LowLevelInterpreter.asm:
Source/WebCore:
No new tests.
- If no breakpoints are set, we now avoid calling the debug hook callbacks.
- If no break on exception is set, we also avoid exception event debug callbacks.
- When we return from the ScriptDebugServer to the JSC::Debugger, we may no longer call the debug hook callbacks if not needed. Hence, the m_currentCallFrame pointer in the ScriptDebugServer may become stale. To avoid this issue, before returning, the ScriptDebugServer will clear its m_currentCallFrame if needsOpDebugCallbacks() is false.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::didReachBreakpoint):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::reset):
Source/WebKit/mac:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
- 2:48 PM Changeset in webkit [157745] by
-
- 6 edits in branches/safari-537.73-branch/Source
Merged r154067. <rdar://problem/15109373>
- 2:43 PM Changeset in webkit [157744] by
-
- 1 edit2 copies in branches/safari-537.73-branch/LayoutTests
Merged r153982. <rdar://problem/15109382>
- 2:42 PM Changeset in webkit [157743] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r153975. <rdar://problem/15109382>
- 2:39 PM Changeset in webkit [157742] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r153920. <rdar://problem/15109364>
- 2:36 PM Changeset in webkit [157741] by
-
- 8 edits2 copies in branches/safari-537.73-branch
Merged r153913. <rdar://problem/15109360>
- 2:33 PM Changeset in webkit [157740] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r153909. <rdar://problem/15109368>
- 2:31 PM Changeset in webkit [157739] by
-
- 11 edits in trunk
Grammar markers are not updated when switching between 1x and 2x
https://bugs.webkit.org/show_bug.cgi?id=122146
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-21
Reviewed by Dean Jackson.
Source/WebCore:
When running editing/spelling/grammar-markers-hidpi.html, the 2x
grammar/spelling dot resources are cached. If you then run
editing/spelling/grammar-markers.html without tearing down WebKit,
it re-uses the 2x dots. The difference between the two tests is a call
to testRunner.setBackingScaleFactor().
We create a NSColor from an NSImage, and remember it in a static
variable. However, NSColor inspects the current graphics context to
determine which resolution to use, and then remembers that decision.
Therefore, we want to recreate the NSColor whenever the device pixel
ratio changes. This patch adds a new static function to GraphicsContext
which recreates this NSColor every time the ratio changes.
Tests: editing/spelling/grammar-markers.html
editing/spelling/inline_spelling_markers.html
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::makePattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
LayoutTests:
- platform/mac/editing/spelling/grammar-markers-expected.png:
- platform/mac/editing/spelling/inline_spelling_markers-expected.png:
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::makePattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
- 2:26 PM Changeset in webkit [157738] by
-
- 11 edits2 copies in branches/safari-537.73-branch
Merged r153877. <rdar://problem/15109353>
- 2:26 PM Changeset in webkit [157737] by
-
- 3 edits in trunk/Source/JavaScriptCore
[WIN] Unreviewed build correction.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Handle new JIT files as C++ implementation sources, not header files.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- 2:22 PM Changeset in webkit [157736] by
-
- 2 edits in trunk/Source/WebCore
Use pink layer borders for compositing layers with a contents layer
https://bugs.webkit.org/show_bug.cgi?id=123118
Reviewed by Dean Jackson.
With the existing layer border colors, it's not possible to distinguish an empty
layer from one with solid color, image or video contents. So use a pink color
for those. This makes it easier to diagnose bugs like 122784.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::getDebugBorderInfo):
- 2:20 PM Changeset in webkit [157735] by
-
- 7 edits in trunk/Source/WebCore
Limit use of display sleep assertion when <video> element is off-screen.
https://bugs.webkit.org/show_bug.cgi?id=123041
Reviewed by Darin Adler.
Use page visibility changes to suspend and resume the use of sleep assertions in
HTMLMediaElement.
Page will propogate the page visibility change notifications to its Documents, which
will further propogate those notifications to registered elements. Upon receiving
these notifications, HTMLMediaElement will release or take a DisplaySleepDisabler
token if necessary.
Also, rename HTMLMediaElement's updateDisableSleep() to updateSleepDisabling() and wrap
the implementation in a PLATFORM(MAC) guard rather than at each call site.
- dom/Document.cpp:
(WebCore::Document::registerForVisibilityStateCallbacks): Added registration method.
(WebCore::Document::unregisterForVisibilityStateCallbacks): Added unregistration method.
(WebCore::Document::visibilityStateChanged): Call all registered clients.
- dom/Document.h:
- dom/Element.h:
(WebCore::Element::visibilityStateChanged): Added default virtual method to be overridden
by subclasses.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Register for the notification, and check the
current status of Document::hidden().
(WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for the notification.
(WebCore::HTMLMediaElement::visibilityStateChanged): Set m_displaySleepDisablingSuspended
and call updateSleepDisabling().
(WebCore::HTMLMediaElement::shouldDisableSleep): Add a check for m_displaySleepDisablingSuspended.
- html/HTMLMediaElement.h:
- page/Page.cpp:
(WebCore::Page::setVisibilityState): Pass to every child document.
Rename updateDisableSleep() -> updateSleepDisabling():
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::stop):
- 2:20 PM Changeset in webkit [157734] by
-
- 2 edits in trunk/Source/WebKit2
Maybe a Lion build fix after r157731.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):
- 2:14 PM Changeset in webkit [157733] by
-
- 3 edits in trunk/Source/WebCore
MediaStreamTrack now tracks its own state
https://bugs.webkit.org/show_bug.cgi?id=123025
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-21
Reviewed by Jer Noble.
The spec says that a MediaStreamSource can be shared by different tracks,
so a track must have its own state tracking, synchronizing with its MediaStreamSource when
the underlying MediaStreamSource changes the readyState.
In the old implementation if a user invoked the stop method, its readyState method was still
returning the MediaStreamSource state, which was wrong.
This also adds a setEnabled method, which can be used to set the state of a track when a
remote peer ends it, for instance.
No new tests needed.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::setState):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::ended):
(WebCore::MediaStreamTrack::sourceStateChanged):
(WebCore::MediaStreamTrack::trackDidEnd):
- Modules/mediastream/MediaStreamTrack.h:
- 1:59 PM Changeset in webkit [157732] by
-
- 2 edits in branches/safari-537.73-branch/Source/WTF
Merged r153767. <rdar://problem/15109338>
- 1:42 PM Changeset in webkit [157731] by
-
- 4 edits in trunk/Source
Remote Layer Tree: Clean up transaction logging
https://bugs.webkit.org/show_bug.cgi?id=123116
Reviewed by Anders Carlsson.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::RemoteLayerTreeTextStream):
(WebKit::RemoteLayerTreeTextStream::increaseIndent):
(WebKit::RemoteLayerTreeTextStream::decreaseIndent):
(WebKit::RemoteLayerTreeTextStream::writeIndent):
(WebKit::RemoteLayerTreeTextStream::operator<<):
Add some stream operator overrides for various types we need to dump.
Add a notion of current indent to our TextStream subclass to make it
easy to keep track of where we are.
(WebKit::dumpProperty):
Added, hand any arbitrary type to RemoteLayerTreeTransaction.
(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::dump):
Make use of TextStream.
- WebCore.exp.in:
Export some TextStream functions.
- 1:31 PM Changeset in webkit [157730] by
-
- 22 edits in trunk/Source
Transition most use of IDBBackingStoreLevelDB to IDBBackingStoreInterface
https://bugs.webkit.org/show_bug.cgi?id=123105
Reviewed by Anders Carlsson.
Source/WebCore:
Export more required headers:
- WebCore.xcodeproj/project.pbxproj:
Flesh out many of the pure virtual methods on IDBBackingStoreInterface, as well as
the RecordIdentifier and Cursor classes:
- Modules/indexeddb/IDBBackingStoreInterface.h:
(WebCore::IDBBackingStoreInterface::RecordIdentifier::~RecordIdentifier):
(WebCore::IDBBackingStoreInterface::Cursor::~Cursor):
Use IDBBackingStoreInterface, IDBBackingStoreInterface::RecordIdentifier, and
IDBBackingStoreInterface::Cursor wherever possible:
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::IndexKeyCursorImpl::clone):
(WebCore::IndexCursorImpl::clone):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
(WebCore::IDBBackingStoreLevelDB::Transaction::Transaction):
(WebCore::IDBBackingStoreLevelDB::Transaction::begin):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
(WebCore::IDBBackingStoreLevelDB::RecordIdentifier::RecordIdentifier):
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
(WebCore::IDBCursorBackendLevelDB::IDBCursorBackendLevelDB):
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
(WebCore::IDBCursorBackendLevelDB::create):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::create):
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::backingStore):
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::createTransaction):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::createTransactionBackend):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::verifyIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::addingKeyAllowed):
(WebCore::IDBObjectStoreBackendLevelDB::makeIndexWriters):
(WebCore::IDBObjectStoreBackendLevelDB::generateKey):
(WebCore::IDBObjectStoreBackendLevelDB::updateKeyGenerator):
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::GetOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):
Source/WebKit2:
Stub out a new pure virtual method:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createTransactionBackend):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 1:18 PM Changeset in webkit [157729] by
-
- 4 edits2 adds in trunk
[CSS Shapes][CSS Regions] Don't apply shape-inside when we have multiple auto-height regions and the height is not resolved
https://bugs.webkit.org/show_bug.cgi?id=123103
Reviewed by David Hyatt.
When we have multiple regions with auto-height, the region's height is not resolved from other elements we can't apply the
the shape on the region. This patch prevents to apply the shape and fixes the behavior for these cases.
Source/WebCore:
Test: fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutShapeInsideInfo):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
LayoutTests:
- fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html: Added.
- 1:16 PM Changeset in webkit [157728] by
-
- 6 edits in trunk/Source
Remote Layer Tree: Backing store should take contentsScale into account
https://bugs.webkit.org/show_bug.cgi?id=123106
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::ensureBackingStore):
(PlatformCALayerRemote::setNeedsDisplay):
(PlatformCALayerRemote::setContentsScale):
Inform the backing store of the contentsScale, and when it changes.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::scale): Added.
(WebKit::RemoteLayerBackingStore::mapToContentCoordinates): Added.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
(RemoteLayerBackingStore::mapToContentCoordinates):
Factor out flipping so we can use it for repaints in multiple places.
(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Create a buffer scaled up by contentsScale, take the scale into account
when copying clean bits from the front buffer, and apply the scale before
painting into the back buffer.
- WebCore.exp.in:
Export FloatRect::scale.
- 1:15 PM Changeset in webkit [157727] by
-
- 1 edit3 adds in trunk/Source/WebInspectorUI
Restore accidentally removed files.
- 1:10 PM Changeset in webkit [157726] by
-
- 3 edits in trunk/Source/WebCore
RenderScrollbarPart doesn't need styleWillChange().
<https://webkit.org/b/123113>
We will call setInline(false) in styleDidChange(), there's no need
to override styleWillChange() just to do it twice.
Reviewed by Darin Adler.
- 12:38 PM Changeset in webkit [157725] by
-
- 29 edits20 adds in trunk
[CSS Regions] The layers from the flow thread should be collected under the regions' layers.
https://bugs.webkit.org/show_bug.cgi?id=120457
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-21
Reviewed by David Hyatt.
Source/WebCore:
This patch is based on the work of Alexandru Chiculita at https://bugs.webkit.org/attachment.cgi?id=203872&action=review
The composited layers inside the named flow threads are collected as part of the regions (as children of the
GraphicsLayer of the layer that corresponds to the region (which is attached to the parent renderer of
RenderNameFlowFragment)).
When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
that region too (inside RenderLayerCompositor::computeRegionCompositingRequirements).
This patch has landed before (as http://trac.webkit.org/changeset/156451), but was reverted because
fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited
that only enables compositing for layers inside flow threads that collect the graphics layers under the regions.
Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under
the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's
parent renderer, not in the region renderer (RenderNamedFlowFragment).
Tests: compositing/regions/crash-transform-inside-region.html
compositing/regions/floated-region-with-transformed-child.html
compositing/regions/move-layer-from-one-region-to-another.html
compositing/regions/propagate-region-box-shadow-border-padding-for-video.html
compositing/regions/propagate-region-box-shadow-border-padding.html
compositing/regions/region-as-layer-in-another-flowthread.html
compositing/regions/transform-transparent-positioned-video-inside-region.html
compositing/regions/transformed-layer-inside-transformed-layer.html
compositing/regions/z-index-update.html
compositing/regions/z-index.html
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
through the RenderView::styleDidChange function.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
we update all the mappings between the layers inside the flow thread and the regions where those layers will be
painted.
(WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
(WebCore::RenderFlowThread::collectsGraphicsLayersUnderRegions):
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
from a region to another since the last update.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
- rendering/RenderFlowThread.h:
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::pushRenderFlowThread):
- rendering/RenderGeometryMap.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::enclosingFlowThreadAncestor):
(WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateLayerBounds): When we calculate the bounds of the RenderView, we ignore those
flow threads that collect the graphics layers under the regions.
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's a flow thread that collects the graphics
layers under the regions
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
its borders, paddings, outlines or box-shadows to layers inside it.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly if
we are going to collect the composited layers as part of regions.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
use composited RenderRegions to render the background of the RenderFlowThread.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a container of a css region.
- rendering/RenderLayerCompositor.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.h:
(WebCore::RenderNamedFlowFragment::layerOwner): When the content inside the region requires the region to have a
layer, the layer will be created on the region's parent renderer instead. This method returns that renderer
holding the layer. The return value may be null.
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
(WebCore::RenderNamedFlowThread::collectsGraphicsLayersUnderRegions):
- rendering/RenderNamedFlowThread.h: m_flowThreadChildList is now allocated through an OwnPtr to keep the render
arena under the size limit.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderRegion.h:
(WebCore::toRenderRegion):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
- WebCore.exp.in: WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions
LayoutTests:
- compositing/regions/crash-transform-inside-region-expected.html: Added.
- compositing/regions/crash-transform-inside-region.html: Added.
- compositing/regions/floated-region-with-transformed-child-expected.html: Added.
- compositing/regions/floated-region-with-transformed-child.html: Added.
- compositing/regions/move-layer-from-one-region-to-another-expected.html: Added.
- compositing/regions/move-layer-from-one-region-to-another.html: Added.
- compositing/regions/propagate-region-box-shadow-border-padding-expected.html: Added.
- compositing/regions/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
- compositing/regions/propagate-region-box-shadow-border-padding-for-video.html: Added.
- compositing/regions/propagate-region-box-shadow-border-padding.html: Added.
- compositing/regions/region-as-layer-in-another-flowthread-expected.html: Added.
- compositing/regions/region-as-layer-in-another-flowthread.html: Added.
- compositing/regions/transform-transparent-positioned-video-inside-region-expected.html: Added.
- compositing/regions/transform-transparent-positioned-video-inside-region.html: Added.
- compositing/regions/transformed-layer-inside-transformed-layer-expected.html: Added.
- compositing/regions/transformed-layer-inside-transformed-layer.html: Added.
- compositing/regions/webkit-flow-renderer-layer-compositing-expected.html:
- compositing/regions/webkit-flow-renderer-layer-compositing.html:
- compositing/regions/z-index-expected.html: Added.
- compositing/regions/z-index-update-expected.html: Added.
- compositing/regions/z-index-update.html: Added.
- compositing/regions/z-index.html: Added.
- fast/multicol/mixed-positioning-stacking-order-expected.html:
- fast/multicol/mixed-positioning-stacking-order.html:
- fast/repaint/region-painting-composited-element-expected.html:
- fast/repaint/region-painting-composited-element.html:
- platform/mac-wk2/TestExpectations:
- 12:23 PM Changeset in webkit [157724] by
-
- 10 edits3 adds in trunk
Source/JavaScriptCore: Support computed property names in object literals
https://bugs.webkit.org/show_bug.cgi?id=123112
Reviewed by Michael Saboff.
Add support for computed property names to the parser.
- bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::getName):
- parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode):
- parser/Nodes.h:
(JSC::PropertyNode::expressionName):
(JSC::PropertyNode::name):
- parser/Parser.cpp:
(JSC::::parseProperty):
(JSC::::parseStrictObjectLiteral):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::Property::Property):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::operatorStackPop):
LayoutTests: Support expression property names in object literals
https://bugs.webkit.org/show_bug.cgi?id=123112
Reviewed by Michael Saboff.
Add tests
- js/basic-computed-property-name-expected.txt: Added.
- js/basic-computed-property-name.html: Added.
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-computed-property-name.js: Added.
(a.string_appeared_here.runTest):
- js/script-tests/parser-syntax-check.js:
- 12:02 PM Changeset in webkit [157723] by
-
- 2 edits in trunk/Source/WebCore
Fixing mediastream debug build
https://bugs.webkit.org/show_bug.cgi?id=123104
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-21
Reviewed by Andreas Kling.
No new tests needed.
- Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
(WebCore::RTCDTMFToneChangeEvent::create):
- 11:29 AM Changeset in webkit [157722] by
-
- 3 edits in trunk/Source/WebCore
Merge RenderListMarker::styleWillChange() into styleDidChange().
<https://webkit.org/b/123098>
If the marker's list-style-type or list-style-position changed, we
need to dirty the layout. Move this logic to styleDidChange() so we
can get rid of one styleWillChange() overload.
Reviewed by Antti Koivisto.
- 10:04 AM Changeset in webkit [157721] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/media-controller-time-clamp.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123099
- platform/mac/TestExpectations: Marking as such.
- 9:53 AM Changeset in webkit [157720] by
-
- 5 edits4 adds in trunk
[CSS Regions] Fix WHITESPACE issues in the CSS grammar.
https://bugs.webkit.org/show_bug.cgi?id=123082
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-21
Reviewed by Andreas Kling.
This is a port of Rune Lillesveen's patch from https://codereview.chromium.org/25607005
Source/WebCore:
Fix WHITESPACE issues in the CSS grammar.
A single WHITESPACE token consumes consecutive spaces, but does not consume
spaces separated by comments. That means S* and S+ in CSS grammars need to
accept multiple WHITESPACE tokens. Additionally, white spaces are not
mandatory to separate an @-symbol and the rest of the prelude.
Use space non-terminal instead of WHITESPACE for S+ in calc expressions.
Use maybe_space non-terminal instead of WHITESPACE for S* after @-webkit-filter
and @-webkit-region.
Tests: fast/css/calc-comments-allowed.html
fast/regions/webkit-region-syntax-space.html
- css/CSSGrammar.y.in:
LayoutTests:
- css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js:
- fast/css/calc-comments-allowed-expected.html: Added.
- fast/css/calc-comments-allowed.html: Added.
- fast/regions/webkit-region-syntax-space-expected.txt: Added.
- fast/regions/webkit-region-syntax-space.html: Added.
- 8:41 AM Changeset in webkit [157719] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add option so that JSC will crash if it can't allocate executable memory for the JITs
https://bugs.webkit.org/show_bug.cgi?id=123048
<rdar://problem/12856193>
Patch by Michael Saboff <msaboff@apple.com> on 2013-10-21
Reviewed by Geoffrey Garen.
Added new option, called crashIfCantAllocateJITMemory. If this option is true then we crash
when checking the validity of the executable allocator. The default value for this option is
false, but jsc sets it to true when built for iOS to make it straightforward to identify whether
the app can obtain executable memory.
- jsc.cpp: Explicitly enable crashIfCantAllocateJITMemory on iOS.
(main):
- runtime/Options.h: Added option crashIfCantAllocateJITMemory.
- runtime/VM.cpp:
(JSC::enableAssembler): Modified to crash if option crashIfCantAllocateJITMemory
is enabled.
- 7:02 AM Changeset in webkit [157718] by
-
- 4 edits in trunk/Source/WebCore
[ATK] Use atk_object_notify_state_change instead of manually emitting signals
https://bugs.webkit.org/show_bug.cgi?id=122968
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-21
Reviewed by Mario Sanchez Prada.
Refactor emitting "state-change" event to use atk_object_notify_state_change
instead of using g_signal_emit_by_name.
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleDetach):
- editing/atk/FrameSelectionAtk.cpp:
(WebCore::maybeEmitTextFocusChange):
- 2:53 AM Changeset in webkit [157717] by
-
- 5 edits in trunk/Source
Make TYPE_CASTS_BASE more flexible
https://bugs.webkit.org/show_bug.cgi?id=122951
Reviewed by Andreas Kling.
TYPE_CASTS_BASE is being used by node|element type casts. However, it is difficult
to be used by other type casts. For instance, CSSValue, Accessibility and so on.
This patch modifies TYPE_CASTS_BASE which can support other type casts.
Besides TYPE_CASTS_BASE body is moved from node.h to Assertions.h.
Source/WebCore:
No new tests, no behavior changes.
- dom/Document.h:
- dom/Node.h:
Source/WTF:
- wtf/Assertions.h:
- 2:44 AM Changeset in webkit [157716] by
-
- 2 edits in trunk/Tools
[WinCairo] Build does not start.
https://bugs.webkit.org/show_bug.cgi?id=123059
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-21
Reviewed by Csaba Osztrogonác.
The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
- Scripts/build-webkit:
- 2:43 AM Changeset in webkit [157715] by
-
- 1 edit1 delete in trunk
Remove .qmake.conf files
https://bugs.webkit.org/show_bug.cgi?id=123091
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-10-21
Reviewed by Csaba Osztrogonác.
- .qmake.conf: Removed.
- 2:32 AM Changeset in webkit [157714] by
-
- 1 edit1 delete in trunk/Source/JavaScriptCore
Remove AllInOneFile.cpp
https://bugs.webkit.org/show_bug.cgi?id=123055
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-21
Reviewed by Csaba Osztrogonác.
- AllInOneFile.cpp: Removed.
- 2:31 AM Changeset in webkit [157713] by
-
- 2 edits in trunk/Source/WebKit2
Remove qt from generate-forwarding-headers.pl
https://bugs.webkit.org/show_bug.cgi?id=123090
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-10-21
Reviewed by Andreas Kling.
- Scripts/generate-forwarding-headers.pl:
- 2:00 AM Changeset in webkit [157712] by
-
- 2 edits in trunk/Tools
[Jhbuild] Bump the required Jhbuild revision
https://bugs.webkit.org/show_bug.cgi?id=123089
Reviewed by Carlos Garcia Campos.
- jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
in the Jhbuild source so a more recent revision of it should be used.
- 1:57 AM Changeset in webkit [157711] by
-
- 4 edits in trunk/Source
[GTK] g-ir-scanner should use the configured C compiler
https://bugs.webkit.org/show_bug.cgi?id=123088
Reviewed by Carlos Garcia Campos.
Source/WebKit/gtk:
- GNUmakefile.am: Pass the C compiler that was detected at configuration to the g-ir-scanner command
via the CC environment variable. This solves the issue of the scanner running the GCC compiler with
the Clang-specific CFLAGS.
Source/WebKit2:
- GNUmakefile.am: Pass the C compiler that was detected at configuration to the g-ir-scanner command
via the CC environment variable. This solves the issue of the scanner running the GCC compiler with
the Clang-specific CFLAGS.
- 12:11 AM Changeset in webkit [157710] by
-
- 4 edits2 adds in trunk
ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty
https://bugs.webkit.org/show_bug.cgi?id=122097
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-21
Reviewed by Ryosuke Niwa.
Source/WebCore:
When remove format command is called we pushdown the ancestor style
down to its children. Currently applying inline style to iframe
while pushing down style which causes iframe to be reinserted in tree and
triggres again subframe loading which repeats everytime and finally
crash happens. So we should avoid applying inline style to iframe
element as it doesnot reflect in its content while pushing down style
on it.
And ASSERT call has been removed from setTextDecoration property as
the scenario is perfectly valid case.
Test: editing/execCommand/remove-format-textdecoration-in-iframe.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Return if
element is iframe.
- editing/EditingStyle.cpp:
(WebCore::StyleChange::setTextDecorationProperty): Remove ASSERT.
LayoutTests:
Added Test cases to verify that crash does not happen in scenario when
remove format command is executed on selection containing the iframe
element and when textdecoration style is defined as !important and
need to pushDown to iframe.
- editing/execCommand/remove-format-textdecoration-in-iframe-expected.txt: Added.
- editing/execCommand/remove-format-textdecoration-in-iframe.html: Added.
