Context Navigation

← Previous Period
Next Period →

Timeline

Oct 25, 2013:

11:37 PM Changeset in webkit [158081] by Csaba Osztrogonác

3 edits in trunk/Source/WebKit2

Fix the ENABLE(CSS_FILTERS) && USE(COORDINATED_GRAPHICS) build after r157803
https://bugs.webkit.org/show_bug.cgi?id=123330

Reviewed by Darin Adler.

Shared/WebCoreArgumentCoders.cpp:
Shared/WebCoreArgumentCoders.h:

11:13 PM Changeset in webkit [158080] by rniwa@webkit.org

2 edits in trunk/Websites/test-results

Build fix. The query results weren't sorted by the latest commit time,
yielding wrong set of tests to be listed in the builder pane.

public/include/test-results.php:

10:50 PM Changeset in webkit [158079] by rniwa@webkit.org

2 edits in trunk/Websites/test-results

Links in new flakiness dashboard could benefit from tooltips
https://bugs.webkit.org/show_bug.cgi?id=123381

Reviewed by Alexey Proskuryakov.

Add title content attribute on each hyperlink in the builder pane.

public/index.html:

(TestResultsView._populateBuilderPane):

10:41 PM Changeset in webkit [158078] by ap@apple.com

2 edits
1 move
1 add
1 delete in trunk/LayoutTests

REGRESSION (r158069): platform/mac/fast/loader/file-url-mimetypes.html
is failing on all Mountain Lion bots.

platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt: Removed.
platform/mac-mountainlion/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from LayoutTests/platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt.

Mountain Lion results for platform/mac tests need to be in this crazy place apparently.

platform/mac/fast/loader/file-url-mimetypes-expected.txt:
platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Removed.

Mavericks results should be in platform/mac, not platform/mac/platform/mac.
Yes, the latter works and takes precedence, but it's wrong.

6:23 PM Changeset in webkit [158077] by rniwa@webkit.org

2 edits in trunk/Websites/test-results

Commit the right change.

public/index.html:

6:19 PM Changeset in webkit [158076] by rniwa@webkit.org

2 edits in trunk/Websites/test-results

The new flakiness dashboard should sort builder and test names
https://bugs.webkit.org/show_bug.cgi?id=123363

Reviewed by Simon Fraser.

Sort the forgotten builders in the menu.

public/index.html:

5:29 PM Changeset in webkit [158075] by beidson@apple.com

5 edits in trunk/Source/WebKit2

WebIconDatabase can miss private browsing state changes.
<rdar://problem/15322318> and https://bugs.webkit.org/show_bug.cgi?id=123375

Reviewed by Beth Dakin.

UIProcess/WebContext.cpp:

(WebKit::WebContext::willStartUsingPrivateBrowsing): Call setPrivateBrowsingEnabled(true) on each context.
(WebKit::WebContext::willStopUsingPrivateBrowsing): Call setPrivateBrowsingEnabled(false) on each context.
(WebKit::WebContext::setPrivateBrowsingEnabled): In addition to notifying other processes, notify WebIconDatabase.

UIProcess/WebContext.h:

UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setPrivateBrowsingEnabled):

UIProcess/WebIconDatabase.h:

5:25 PM Changeset in webkit [158074] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

Refactor parser rollback logic
https://bugs.webkit.org/show_bug.cgi?id=123372

Reviewed by Brady Eidson.

Add a sane abstraction for rollbacks in the parser.

parser/Parser.cpp:

(JSC::::parseSourceElements):
(JSC::::parseObjectLiteral):

parser/Parser.h:

(JSC::Parser::createSavePoint):
(JSC::Parser::restoreSavePoint):

5:02 PM Changeset in webkit [158073] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r156315. <rdar://problem/15109335>

4:53 PM Changeset in webkit [158072] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: PrettyPrinting tool should have save button
https://bugs.webkit.org/show_bug.cgi?id=123371

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-25
Reviewed by Timothy Hatcher.

Add buttons to save as a URL to share or to save/clear to
localStorage for easier reloads testing local changes.

Tools/PrettyPrinting/index.html:

4:46 PM Changeset in webkit [158071] by Simon Fraser

2 edits in trunk/LayoutTests

Tweak some test expectations.

platform/mac/TestExpectations:

4:35 PM Changeset in webkit [158070] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Mark skipped webgl conformance tests as either flakey or failures.

Also reorganize expectations for WebGL a bit.

platform/mac/TestExpectations:

4:33 PM Changeset in webkit [158069] by Simon Fraser

2 edits
1 copy
8 adds in trunk/LayoutTests

Add Mavericks-specific results for some tests.

platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt: Added.
platform/mac-mountainlion/http/tests/xmlhttprequest/head-redirection-expected.txt: Copied from LayoutTests/platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt.
platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Added.
platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt:
platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.

4:29 PM Changeset in webkit [158068] by Lucas Forschler

3 edits
3 copies
2 adds in branches/safari-537.73-branch

Merged r156214. <rdar://problem/15109485>

4:22 PM Changeset in webkit [158067] by Lucas Forschler

7 edits
2 copies in branches/safari-537.73-branch

Merged r155665. <rdar://problem/15109475>

4:16 PM Changeset in webkit [158066] by Simon Fraser

2 edits in trunk/LayoutTests

Mark some CSS filters and SVG ref tests as failing, and two WebGL tests are flakey.

platform/mac/TestExpectations:

4:03 PM Changeset in webkit [158065] by Lucas Forschler

4 edits
2 copies in branches/safari-537.73-branch

Merged r155608. <rdar://problem/15109361>

3:52 PM Changeset in webkit [158064] by Simon Fraser

2 edits
1 copy
8 adds in trunk/LayoutTests

Mavericks results with MountainLion variants.

platform/mac-mountainlion/fast/repaint/search-field-cancel-expected.txt: Added.
platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt.
platform/mac-mountainlion/fast/text/international/cjk-segmentation-expected.txt: Added.
platform/mac/fast/repaint/search-field-cancel-expected.txt: Added.
platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
platform/mac/fast/text/international/cjk-segmentation-expected.txt: Added.
platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.

3:45 PM Changeset in webkit [158063] by Lucas Forschler

3 edits
4 copies in branches/safari-537.73-branch

Merged r155546. <rdar://problem/15109351>

3:24 PM Changeset in webkit [158062] by Alexandru Chiculita

2 edits
2 adds in trunk/LayoutTests

Web Inspector: CSS Regions: Add layout tests for the new events in the DOMTreeManager
https://bugs.webkit.org/show_bug.cgi?id=123361

Reviewed by Timothy Hatcher.

Created a test to check that WebInspector.DOMTree.Event.ContentFlowWasAdded and
WebInspector.DOMTree.Event.ContentFlowWasRemoved are dispatched when a flow is added
and removed.

http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.assert): Similar to InspectorTest.log, but also takes a boolean and prefixes the message
with "FAIL" or "PASS" depending on the value.
(InspectorTest.importInspectorScripts): Added the required CSS Agent scripts to enable the flow thread events.

inspector-protocol/model/content-flow-list-expected.txt: Added.
inspector-protocol/model/content-flow-list.html: Added.

3:23 PM Changeset in webkit [158061] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Command+Click on url(…) should go to image not source line
https://bugs.webkit.org/show_bug.cgi?id=123362

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-25
Reviewed by Timothy Hatcher.

CodeMirror changed "url" from being type "variable-2" to "string-2".

UserInterface/CodeMirrorAdditions.js:

3:10 PM Changeset in webkit [158060] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r155468.

3:08 PM Changeset in webkit [158059] by Lucas Forschler

8 edits
4 copies in branches/safari-537.73-branch

Merged r155461. <rdar://problem/15109345>

3:03 PM Changeset in webkit [158058] by mark.lam@apple.com

3 edits in trunk/Source/WebCore

DatabaseManager's ProposedDatabases need to be thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=123313.

Reviewed by Geoffrey Garen.

No new tests.

Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):

Modules/webdatabase/DatabaseManager.h:

3:01 PM Changeset in webkit [158057] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

[Win] Javascript crash with DFG JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=121001

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-25
Reviewed by Geoffrey Garen.

On windows, using register GPRInfo::regT0 as parameter to e.g. JIT::storeDouble(..., GPRInfo::regT0)),
results in a call to JIT::storeDouble(FPRegisterID src, const void* address),
where the address parameter gets the value of GPRInfo::regT0, which is 0 (eax on Windows).
This causes the register to be written to address 0, hence the crash.

assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::storeDouble): Assert if we try to generate code which writes to a null pointer.

dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit): Use address in regT0 as parameter.

dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator): Ditto.

3:01 PM Changeset in webkit [158056] by rniwa@webkit.org

2 edits in trunk/Websites/test-results

The new flakiness dashboard should sort builder and test names
https://bugs.webkit.org/show_bug.cgi?id=123363

Reviewed by Simon Fraser.

Sort builders and tests by their name in each pane.

public/index.html:

(TestResultsView._populateTestPane): Lexicologically sort builders by their name.
(TestResultsView._sortObjectsByName): Added.
(TestResultsView._populateBuilderPane): Lexicologically sort builders by their name.

2:57 PM Changeset in webkit [158055] by rniwa@webkit.org

4 edits in trunk/Websites/test-results

Merge revision columns in flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123360

Reviewed by Simon Fraser.

Merge revision numbers into one cell separated by /, and clearly label them as "latest revisions".
Also add colors for missing & audio failures so that they won't be an empty cell.

public/index.html:

(TestResultsView._createTestResultHeader): Create a single th for the list of repository names.
(TestResultsView._createTestResultRow): Use single td for all revision numbers.

public/js/build.js:

(.this.formattedRevision): Don't prefix revision numbers with '@' when we're not in the tooltip.

public/main.css:

(.resultsTable .AUDIO a): Added.
(.resultsTable .MISSING a): Added.

2:54 PM Changeset in webkit [158054] by Lucas Forschler

3 edits in branches/safari-537.73-branch/Source/WebKit/win

Merged r155212. <rdar://problem/15109471>

2:51 PM Changeset in webkit [158053] by Lucas Forschler

4 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r155153. <rdar://problem/15109457>

2:32 PM Changeset in webkit [158052] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r155127. <rdar://problem/15109454>

2:31 PM Changeset in webkit [158051] by oliver@apple.com

7 edits in trunk

Fix a number of problems with destructuring of arguments
https://bugs.webkit.org/show_bug.cgi?id=123357

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This renames the destructuring node's emitBytecode to bindValue
in order to remove the existing confusion over what was happening.

We then fix an incorrect fall through in the destructuring arguments
logic, and fix the then exposed bug where we placed the index rather
than value into the bound property.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::DeconstructingAssignmentNode::emitBytecode):
(JSC::ArrayPatternNode::bindValue):
(JSC::ArrayPatternNode::emitDirectBinding):
(JSC::ObjectPatternNode::bindValue):
(JSC::BindingNode::bindValue):

parser/Nodes.h:

LayoutTests:

Add additional testing

js/destructuring-assignment-expected.txt:
js/script-tests/destructuring-assignment.js:

1:59 PM Changeset in webkit [158050] by Joseph Pecoraro

25 edits
16 adds in trunk/Source

Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac
https://bugs.webkit.org/show_bug.cgi?id=123111

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
WebCore.exp.in:

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/cf:

WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/ios:

iOS does not have a local inspector, only remote. So give it a custom
implementation separate from the WebKit/mac WebInspectorClient
implementation which handles an attaching/detaching local inspector.

WebKit.xcodeproj/project.pbxproj:
ios/WebCoreSupport/WebInspectorClientIOS.mm: Added.

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::bringFrontendToFront):
(WebInspectorClient::closeInspectorFrontend):
(WebInspectorClient::didResizeMainFrame):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorClient::didSetSearchingForNode):
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::sendMessageToBackend):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):
(WebInspectorClient::hasLocalSession):
(WebInspectorClient::canBeRemotelyInspected):
(WebInspectorClient::inspectedWebView):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::attachAvailabilityChanged):
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::localizedStringsURL):
(WebInspectorFrontendClient::bringToFront):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::setAttachedWindowHeight):
(WebInspectorFrontendClient::setAttachedWindowWidth):
(WebInspectorFrontendClient::setToolbarHeight):
(WebInspectorFrontendClient::inspectedURLChanged):
(WebInspectorFrontendClient::updateWindowTitle):
(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):

Source/WebKit/mac:

The actual implementation at the WebCoreSupport/WebInspectorClient level
is the same as INSPECTOR_SERVER. Give debuggable pages a pageIdentifer.

Configurations/FeatureDefines.xcconfig:
Misc/WebKitLogging.h:

Misc.

WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::pageId):
(WebInspectorClient::setPageId):
Give WebInspectorClient's a page identifier.

WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::sendMessageToBackend):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):
(WebInspectorClient::hasLocalSession):
(WebInspectorClient::canBeRemotelyInspected):
(WebInspectorClient::inspectedWebView):
A WebInspectorClient can be either local or remote. Add handling
for remote connections.

WebInspector/remote/WebInspectorClientRegistry.h: Added.
WebInspector/remote/WebInspectorClientRegistry.mm: Added.

(+[WebInspectorClientRegistry sharedRegistry]):
(-[WebInspectorClientRegistry init]):
(-[WebInspectorClientRegistry _getNextAvailablePageId]):
(-[WebInspectorClientRegistry registerClient:]):
(-[WebInspectorClientRegistry unregisterClient:]):
(-[WebInspectorClientRegistry clientForPageId:]):
(-[WebInspectorClientRegistry inspectableWebViews]):
Registry for all potentially debuggable pages. All WebInspectorClient instances.

WebInspector/remote/WebInspectorRelayDefinitions.h: Added.

Constants (message keys) shared between WebKit and the XPC process.

WebInspector/remote/WebInspectorServer.h: Added.
WebInspector/remote/WebInspectorServer.mm: Added.

(-[WebInspectorServer init]):
(-[WebInspectorServer dealloc]):
(-[WebInspectorServer start]):
(-[WebInspectorServer stop]):
(-[WebInspectorServer isEnabled]):
(-[WebInspectorServer xpcConnection]):
(-[WebInspectorServer setupXPCConnectionIfNeeded]):
(-[WebInspectorServer pushListing]):
(-[WebInspectorServer hasActiveDebugSession]):
(-[WebInspectorServer setHasActiveDebugSession:]):
(-[WebInspectorServer xpcConnection:receivedMessage:userInfo:]):
(-[WebInspectorServer xpcConnectionFailed:]):
(-[WebInspectorServer didRegisterClient:]):
(-[WebInspectorServer didUnregisterClient:]):
Singleton to start/stop remote inspection. Handles the connection to the XPC
and hands off connections to the connection controller.

WebInspector/remote/WebInspectorServerWebViewConnection.h: Added.
WebInspector/remote/WebInspectorServerWebViewConnection.mm: Added.

(-[WebInspectorServerWebViewConnection initWithController:connectionIdentifier:destination:identifier:]):
(-[WebInspectorServerWebViewConnection setupChannel]):
(-[WebInspectorServerWebViewConnection dealloc]):
(-[WebInspectorServerWebViewConnection connectionIdentifier]):
(-[WebInspectorServerWebViewConnection identifier]):
(-[WebInspectorServerWebViewConnection clearChannel]):
(-[WebInspectorServerWebViewConnection sendMessageToFrontend:]):
(-[WebInspectorServerWebViewConnection sendMessageToBackend:]):
(-[WebInspectorServerWebViewConnection receivedData:]):
(-[WebInspectorServerWebViewConnection receivedDidClose:]):
An individual remote debug session connection.

WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Added.
WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Added.

(-[WebInspectorServerWebViewConnectionController initWithServer:]):
(-[WebInspectorServerWebViewConnectionController dealloc]):
(-[WebInspectorServerWebViewConnectionController closeAllConnections]):
(-[WebInspectorServerWebViewConnectionController _listingForWebView:pageId:registry:]):
(-[WebInspectorServerWebViewConnectionController _pushListing:]):
(-[WebInspectorServerWebViewConnectionController pushListing:]):
(-[WebInspectorServerWebViewConnectionController pushListing]):
(-[WebInspectorServerWebViewConnectionController _receivedSetup:]):
(-[WebInspectorServerWebViewConnectionController _receivedData:]):
(-[WebInspectorServerWebViewConnectionController _receivedDidClose:]):
(-[WebInspectorServerWebViewConnectionController _receivedGetListing:]):
(-[WebInspectorServerWebViewConnectionController _receivedIndicate:]):
(-[WebInspectorServerWebViewConnectionController _receivedConnectionDied:]):
(-[WebInspectorServerWebViewConnectionController receivedMessage:userInfo:]):
(-[WebInspectorServerWebViewConnectionController connectionClosing:]):
(-[WebInspectorServerWebViewConnectionController sendMessageToFrontend:userInfo:]):
ConnectionController:

Holds all the current ongoing remote debug connections.
Simplifies multi-threaded work on iOS.
Dispatches incoming messages from the remote connection.

WebInspector/remote/WebInspectorRemoteChannel.h: Added.
WebInspector/remote/WebInspectorRemoteChannel.mm: Added.

(+[WebInspectorRemoteChannel createChannelForPageId:connection:]):
(-[WebInspectorRemoteChannel initWithRemote:local:]):
(-[WebInspectorRemoteChannel closeFromLocalSide]):
(-[WebInspectorRemoteChannel closeFromRemoteSide]):
(-[WebInspectorRemoteChannel sendMessageToFrontend:]):
(-[WebInspectorRemoteChannel sendMessageToBackend:]):
Thin interface between the remote connection and web inspector client.
This simplifies breaking the connection from either side, e.g. the
page closing, or the remote connection disconnecting.

WebInspector/remote/WebInspectorXPCWrapper.h: Added.
WebInspector/remote/WebInspectorXPCWrapper.m: Added.

(-[WebInspectorXPCWrapper initWithConnection:]):
(-[WebInspectorXPCWrapper close]):
(-[WebInspectorXPCWrapper dealloc]):
(-[WebInspectorXPCWrapper _deserializeMessage:]):
(-[WebInspectorXPCWrapper _handleEvent:]):
(-[WebInspectorXPCWrapper sendMessage:userInfo:]):
(-[WebInspectorXPCWrapper available]):

WebKit.exp:

XPC Connection wrapper handling a simple message format.

WebView/WebViewData.h:
WebView/WebViewData.mm:

(-[WebViewPrivate init]):
(-[WebViewPrivate dealloc]):

WebView/WebViewInternal.h:
WebView/WebViewPrivate.h:
WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView sharedWebInspectorServer]):
(+[WebView _enableRemoteInspector]):
(+[WebView _disableRemoteInspector]):
(+[WebView _disableAutoStartRemoteInspector]):
(+[WebView _isRemoteInspectorEnabled]):
(+[WebView _hasRemoteInspectorSession]):
(-[WebView canBeRemotelyInspected]):
(-[WebView allowsRemoteInspection]):
(-[WebView setAllowsRemoteInspection:]):
(-[WebView setIndicatingForRemoteInspector:]):
(-[WebView setRemoteInspectorUserInfo:]):
(-[WebView remoteInspectorUserInfo]):
Remote inspector private API.

Enable / disable globally
Allow / disallow per webview
Optionally attach a userInfo dictionary on the WebView that is published with listing.
Indicate a WebView (implementation to land later)

(-[WebView _didCommitLoadForFrame:]):

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidReceiveTitle):
Pages changed, pushed page listing.

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

1:41 PM Changeset in webkit [158049] by Lucas Forschler

2 edits in branches/safari-537-branch/Tools

Merged r157995.

1:40 PM Changeset in webkit [158048] by Lucas Forschler

3 edits in branches/safari-537-branch/Tools

Merged r157815.

1:39 PM Changeset in webkit [158047] by Lucas Forschler

3 edits in branches/safari-537-branch/Tools

Merged r157687.

1:38 PM Changeset in webkit [158046] by Lucas Forschler

3 edits in branches/safari-537-branch/Tools

Merged r157553.

1:37 PM Changeset in webkit [158045] by Lucas Forschler

5 edits in branches/safari-537-branch/Tools

Merged r154450.

1:36 PM Changeset in webkit [158044] by hmuller@adobe.com

12 edits
3 adds
2 deletes in trunk

[CSS Shapes] CORS-enabled fetch for shape image values
https://bugs.webkit.org/show_bug.cgi?id=123114

Reviewed by Andreas Kling.

Source/WebCore:

Access to shape images is now controlled by CORS CSS shape per
http://dev.w3.org/csswg/css-shapes/#shape-outside-property.
Previously shape images had to be same-origin.

Shape image URL access is defined by the same logic that defines
canvas tainting: same-origin and data URLs are allowed and images
with a "Access-Control-Allow-Origin:" header that's either "*" or
that matches the document's origin.

A PotentiallyCrossOriginEnabled RequestOriginPolicy was added to
ResourceLoaderOptions, to indicate that a "potentially CORS-enabled fetch"
was to be undertaken. The CSSImageValue::cachedImage() method handles this
option by effectively setting the "Origin:" request header (see
updateRequestForAccessControl() in CrossOriginAccessControl.cpp).
StyleResolver::loadPendingShapeImage() uses the new ResourceLoaderOption.

The static ShapeInsideInfo and ShapeOutsideInfo isEnabledFor() method
now performs the CORS check for image valued shapes. The private
isOriginClean() method from CanvasRenderingContext2D has been moved to
the CachedImage class so that it can be shared by the Canvas and Shape
implementations. It checks the response headers per the CORS spec.

Test: http/tests/security/shape-image-cors.html

css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage): Handle the new ResourceLoaderOption.

css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingShapeImage): Set the new ResourceLoaderOption.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createPattern): Use the CachedImage::isOriginClean().

loader/ResourceLoaderOptions.h: Added PotentiallyCrossOriginEnabled to RequestOriginPolicy.
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::isOriginClean): Migrated from CanvasRenderingContext2D.

loader/cache/CachedImage.h:
rendering/shapes/ShapeInfo.cpp:

(WebCore::::checkImageOrigin): Do the CORS check and log an error message if neccessary.

rendering/shapes/ShapeInfo.h:
rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::isEnabledFor): Call checkImageOrigin() for images.

rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::isEnabledFor): Ditto.

LayoutTests:

Verify that images not allowed by CORS don't affect the layout
and that same-origin images, data URLs, and images with a
"Access-Control-Allow-Origin: *" header do define the layout.
Added a simple PHP script that optionally adds the allow origin header.

Replaced and renamed the original shape same-origin-only test.

http/tests/security/resources/image-access-control.php: Added.
http/tests/security/shape-image-cors-expected.html: Added.
http/tests/security/shape-image-cors.html: Added.
http/tests/security/shape-inside-image-origin-expected.txt: Removed.
http/tests/security/shape-inside-image-origin.html: Removed.

1:36 PM Changeset in webkit [158043] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Tools

Merged r157995.

1:35 PM Changeset in webkit [158042] by Lucas Forschler

3 edits in branches/safari-537.73-branch/Tools

Merged r157815.

1:35 PM Changeset in webkit [158041] by Simon Fraser

7 edits
6 copies
8 adds in trunk/LayoutTests

Mavericks results with MountainLion variants.

platform/mac-mountainlion/canvas/philip/tests/2d.line.join.parallel-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt.
platform/mac-mountainlion/fast/css/line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-expected.txt.
platform/mac-mountainlion/fast/text/drawBidiText-expected.txt: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.txt.
platform/mac-mountainlion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
platform/mac-mountainlion/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt.
platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt:
platform/mac/fast/css/line-height-expected.txt:
platform/mac/fast/text/drawBidiText-expected.txt:
platform/mac/fast/text/hyphenate-locale-expected.txt:
platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:

1:35 PM Changeset in webkit [158040] by jer.noble@apple.com

6 edits in trunk/Source/WebCore

[MSE] Fix runtime errors caused by mediasource IDL attributes.
https://bugs.webkit.org/show_bug.cgi?id=123352

Reviewed by Eric Carlson.

Due to http://webkit.org/b/123178, MediaSource classes must add a GenerateIsReachable
(and also a JSGenerateToJSObject) attribute to avoid runtime asserts and crashes.

Modules/mediasource/MediaSource.idl:
Modules/mediasource/SourceBuffer.idl:
Modules/mediasource/SourceBufferList.idl:
Modules/mediasource/WebKitMediaSource.idl:
Modules/mediasource/WebKitSourceBufferList.idl:

1:34 PM Changeset in webkit [158039] by Lucas Forschler

3 edits in branches/safari-537.73-branch/Tools

Merged r157687.

1:33 PM Changeset in webkit [158038] by Lucas Forschler

3 edits in branches/safari-537.73-branch/Tools

Merged r157553.

1:32 PM Changeset in webkit [158037] by Lucas Forschler

5 edits in branches/safari-537.73-branch/Tools

Merged r154450.

1:16 PM Changeset in webkit [158036] by mrowe@apple.com

3 edits in trunk/Source/WebKit/mac

Fix or disable some deprecation warnings.

Reviewed by Darin Adler.

Panels/WebAuthenticationPanel.m:

(-[WebAuthenticationPanel cancel:]): On newer OS versions, use the modern API.
(-[WebAuthenticationPanel logIn:]): Ditto.
(-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): Ditto. Translate the
response code in to the form that -sheetDidEnd:responseCode:contextInfo: expects.

WebView/WebClipView.mm:

(-[WebClipView initWithFrame:]): Disable deprecation warnings since it's not obvious
how to avoid calling -releaseGState here.

12:55 PM Changeset in webkit [158035] by Simon Fraser

1 edit
3 moves
2 adds in trunk/LayoutTests

Apparently we need results in platform/mac-mountainlion/platform/mac/ for MountionLion.

platform/mac-mountainlion/accessibility/aria-readonly-expected.txt: Added.
platform/mac-mountainlion/platform/mac/accessibility/form-control-value-settable-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/form-control-value-settable-expected.txt.
platform/mac-mountainlion/platform/mac/accessibility/press-action-is-first-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/press-action-is-first-expected.txt.
platform/mac-mountainlion/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/role-subrole-roledescription-expected.txt.

12:44 PM Changeset in webkit [158034] by barraclough@apple.com

4 edits in trunk/Source/WebKit2

Merge viewInWindowStateDidChange into viewStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=123351

Reviewed by Tim Horton.

UIProcess/API/mac/WKView.mm:

(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):

viewInWindowStateDidChange -> viewStateDidChange

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

removed viewInWindowStateDidChange, renamed parameter to viewStateDidChange

UIProcess/WebPageProxy.h:
- removed viewInWindowStateDidChange, named parameter to viewStateDidChange

12:15 PM Changeset in webkit [158033] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

One more URTBF for GTK after r158028.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseMap):
(webkitWebViewBaseUnmap):

12:07 PM Changeset in webkit [158032] by Csaba Osztrogonác

4 edits in trunk/Source/WebKit2

URTBF from non-Mac platforms after r158028.

GNUmakefile.list.am:
UIProcess/API/gtk/WebKitWebViewBase.cpp:

(toplevelWindowFocusInEvent):
(toplevelWindowFocusOutEvent):
(toplevelWindowVisibilityEvent):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseSetFocus):

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::setActive):
(WebKit::WebView::setFocused):
(WebKit::WebView::setVisible):

12:06 PM Changeset in webkit [158031] by Antti Koivisto

2 edits in trunk/LayoutTests

fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
https://bugs.webkit.org/show_bug.cgi?id=123354

TestExpectations: Skip for now.

11:42 AM Changeset in webkit [158030] by zhajiang@rim.com

2 edits in trunk/Source/WebCore

[BlackBerry] Browser crashed at PlatformGraphicsContext::addDrawLineForText() when trying to upload a video to youtube
https://bugs.webkit.org/show_bug.cgi?id=123349

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-10-25.
Reviewed by George Staikos.
Internally reviewed by George Staikos, Konrad Piascik, Eli Fidler and Arvid Nilsson.

Browser crashed when dereferencing null PlatformGraphicsContext*.
In FrameView::paintControlTints(), we intentionally constructed GraphicsContext
with null PlatformGraphicsContext* and disabled painting by doing
context.setUpdatingControlTints(true). So we should not go further in
GraphicsContext::drawLineForText() if painting is disabled.
Check paintingDisabled() for the other functions in PathBlackBerry.cpp
as well; otherwise, it is likely we will crash at those places.

platform/graphics/blackberry/PathBlackBerry.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):

11:38 AM Changeset in webkit [158029] by Simon Fraser

45 edits
44 copies
35 adds in trunk/LayoutTests

Mavericks results with MountainLion variants.

platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt.
platform/mac-mountainlion/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt.
platform/mac-mountainlion/fast/css/input-search-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.txt.
platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
platform/mac-mountainlion/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
platform/mac-mountainlion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt.
platform/mac-mountainlion/fast/dom/isindex-001-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-001-expected.txt.
platform/mac-mountainlion/fast/dom/isindex-002-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-002-expected.txt.
platform/mac-mountainlion/fast/dynamic/008-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.txt.
platform/mac-mountainlion/fast/events/context-no-deselect-expected.txt: Copied from LayoutTests/platform/mac/fast/events/context-no-deselect-expected.txt.
platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.txt.
platform/mac-mountainlion/fast/lists/dynamic-marker-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/dynamic-marker-crash-expected.txt.
platform/mac-mountainlion/fast/overflow/overflow-x-y-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt.
platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt.
platform/mac-mountainlion/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
platform/mac-mountainlion/fast/parser/entity-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt.
platform/mac-mountainlion/fast/parser/open-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt.
platform/mac-mountainlion/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt.
platform/mac-mountainlion/fast/repaint/subtree-root-skipped-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.txt.
platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
platform/mac-mountainlion/fast/replaced/replaced-breaking-mixture-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt.
platform/mac-mountainlion/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
platform/mac-mountainlion/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt.
platform/mac-mountainlion/fast/table/003-expected.txt: Copied from LayoutTests/platform/mac/fast/table/003-expected.txt.
platform/mac-mountainlion/fast/table/colspanMinWidth-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-expected.txt.
platform/mac-mountainlion/fast/table/colspanMinWidth-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt.
platform/mac-mountainlion/fast/table/spanOverlapRepaint-expected.txt: Copied from LayoutTests/platform/mac/fast/table/spanOverlapRepaint-expected.txt.
platform/mac-mountainlion/fast/table/text-field-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/table/text-field-baseline-expected.txt.
platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt.
platform/mac-mountainlion/fast/text/updateNewFont-expected.txt: Copied from LayoutTests/platform/mac/fast/text/updateNewFont-expected.txt.
platform/mac-mountainlion/fast/transforms/transformed-focused-text-input-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/transformed-focused-text-input-expected.txt.
platform/mac-mountainlion/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt.
platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.txt.
platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt.
platform/mac-mountainlion/plugins/mouse-click-plugin-clears-selection-expected.txt: Copied from LayoutTests/platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt.
platform/mac-mountainlion/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
platform/mac-mountainlion/svg/custom/use-on-symbol-inside-pattern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt.
platform/mac-mountainlion/svg/hixie/mixed/003-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.txt.
platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/zoom-menulist-expected.txt.
platform/mac-mountainlion/transforms/3d/general/perspective-non-layer-expected.txt: Copied from LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt.
platform/mac/fast/block/margin-collapse/103-expected.txt:
platform/mac/fast/css/continuationCrash-expected.txt:
platform/mac/fast/css/css2-system-fonts-expected.txt:
platform/mac/fast/css/input-search-padding-expected.txt:
platform/mac/fast/css/text-overflow-input-expected.txt:
platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
platform/mac/fast/dom/isindex-001-expected.txt:
platform/mac/fast/dom/isindex-002-expected.txt:
platform/mac/fast/dynamic/008-expected.txt:
platform/mac/fast/events/context-no-deselect-expected.txt:
platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
platform/mac/fast/overflow/overflow-x-y-expected.txt:
platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
platform/mac/fast/parser/document-write-option-expected.txt:
platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
platform/mac/fast/replaced/replaced-breaking-expected.txt:
platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
platform/mac/fast/selectors/064-expected.txt:
platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
platform/mac/fast/table/003-expected.txt:
platform/mac/fast/table/colspanMinWidth-expected.txt:
platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
platform/mac/fast/table/spanOverlapRepaint-expected.txt:
platform/mac/fast/table/text-field-baseline-expected.txt:
platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
platform/mac/fast/text/updateNewFont-expected.txt:
platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
platform/mac/platform/mac/fast/text/systemFont-expected.txt:
platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
platform/mac/svg/hixie/mixed/003-expected.txt:
platform/mac/transforms/2d/zoom-menulist-expected.txt:
platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:

11:26 AM Changeset in webkit [158028] by barraclough@apple.com

5 edits
1 add in trunk/Source/WebKit2

Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323

Reviewed by Sam Weinig.

WebPageProxy contains an enum and typedef that provide a bitfield
of flags describing the visibility of the view containing the page.
We're going to want to use this bitfield in a message to the
WebProcess, so moving out from the UIProcess to shared code.
Creating struct 'ViewState' to scope the enum and typedef.
Renamed ViewStateFlags to ViewState::Flags, and removed redundant
'View' from enum entries.

Shared/ViewState.h: Added.
UIProcess/API/mac/WKView.mm:

(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

UIProcess/WebPageProxy.h:
WebKit2.xcodeproj/project.pbxproj:

11:24 AM Changeset in webkit [158027] by barraclough@apple.com

5 edits
1 delete in trunk/Source/WebKit2

Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323

Unreviewed

Rolling out 158026 - landed extra chnages!

Shared/ViewState.h: Removed.
UIProcess/API/mac/WKView.mm:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewInWindowStateDidChange):
(WebKit::WebPageProxy::viewStateDidChange):

UIProcess/WebPageProxy.h:
WebKit2.xcodeproj/project.pbxproj:

11:20 AM Changeset in webkit [158026] by barraclough@apple.com

5 edits
1 add in trunk/Source/WebKit2

Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323

Reviewed by Sam Weinig.

Shared/ViewState.h: Added.
UIProcess/API/mac/WKView.mm:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

UIProcess/WebPageProxy.h:
WebKit2.xcodeproj/project.pbxproj:

11:06 AM Changeset in webkit [158025] by Simon Fraser

2 edits
1 copy
9 adds in trunk/LayoutTests

New results for some accessibility tests.

platform/mac-mountainlion/accessibility/form-control-value-settable-expected.txt: Added.
platform/mac-mountainlion/accessibility/lists-expected.txt: Copied from LayoutTests/platform/mac/accessibility/lists-expected.txt.
platform/mac-mountainlion/accessibility/press-action-is-first-expected.txt: Added.
platform/mac-mountainlion/accessibility/role-subrole-roledescription-expected.txt: Added.
platform/mac/accessibility/aria-readonly-expected.txt: Added.
platform/mac/accessibility/lists-expected.txt:
platform/mac/platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
platform/mac/platform/mac/accessibility/press-action-is-first-expected.txt: Added.
platform/mac/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.

11:04 AM Changeset in webkit [158024] by Lucas Forschler

4 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154915. <rdar://problem/15109453>

11:02 AM Changeset in webkit [158023] by Lucas Forschler

9 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154914. <rdar://problem/15109453>

11:01 AM Changeset in webkit [158022] by jberlin@webkit.org

2 edits in trunk/Source/WebInspectorUI

Ran update-localizable-strings after changes made in r157947.

Rubber-stamped by Timothy Hatcher.

Localizations/en.lproj/localizedStrings.js:

10:59 AM Changeset in webkit [158021] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix MSVC again

10:47 AM Changeset in webkit [158020] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154890. <rdar://problem/15109453>

10:44 AM Changeset in webkit [158019] by Lucas Forschler

3 edits
2 copies in branches/safari-537.73-branch

Merged r154856. <rdar://problem/15109399>

10:35 AM Changeset in webkit [158018] by commit-queue@webkit.org

11 edits
2 adds in trunk/Source/WebCore

Adding platform implementation of MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=123301

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-25
Reviewed by Eric Carlson.

No new tests needed.

CMakeLists.txt:
Modules/mediastream/AudioStreamTrack.cpp:

(WebCore::AudioStreamTrack::create): Create method now receives a MediaStreamTrackPrivate as parameter.

(WebCore::AudioStreamTrack::AudioStreamTrack):

Modules/mediastream/AudioStreamTrack.h:
Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream): Constructor now iterates through a set of MediaStreamTrackPrivate
instances to create each MediaStreamTrack of MediaStream.

(WebCore::MediaStream::addRemoteSource): Calling AudioStreamTrack and VideoStreamTrack with
MediaStreamTrackPrivate as parameter.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack): Constructor now receives a MediaStreamTrackPrivate, instead of a
MediaStreamSource.

(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind): Calling method from MediaStreamTrackPrivate.

(WebCore::MediaStreamTrack::setSource): Ditto.

(WebCore::MediaStreamTrack::id): Ditto.

(WebCore::MediaStreamTrack::label): Ditto.

(WebCore::MediaStreamTrack::enabled): Ditto.

(WebCore::MediaStreamTrack::setEnabled): Ditto.

(WebCore::MediaStreamTrack::muted): Ditto.

(WebCore::MediaStreamTrack::readonly): Ditto.

(WebCore::MediaStreamTrack::remote): Ditto.

(WebCore::MediaStreamTrack::readyState): Ditto.

(WebCore::MediaStreamTrack::states):
(WebCore::MediaStreamTrack::capabilities):
(WebCore::MediaStreamTrack::clone):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::ended): Ditto.

(WebCore::MediaStreamTrack::sourceStateChanged): Ditto.

(WebCore::MediaStreamTrack::sourceMutedChanged): Ditto.

(WebCore::MediaStreamTrack::sourceEnabledChanged): Ditto.
(WebCore::MediaStreamTrack::configureTrackRendering):
(WebCore::MediaStreamTrack::stopped): Ditto.

(WebCore::MediaStreamTrack::trackDidEnd): Setting Ended ready state in MediaStreamTrackPrivate.

(WebCore::MediaStreamTrack::trackReadyStateChanged): Dispatches Live or Ended event.

(WebCore::MediaStreamTrack::trackMutedChanged): Dispatches Muted event.

Modules/mediastream/MediaStreamTrack.h: Now inheriting from MediaStreamTrackPrivateClient.

(WebCore::MediaStreamTrack::source): Calling method from MediaStreamTrackPrivate.
(WebCore::MediaStreamTrack::privateTrack):

Modules/mediastream/VideoStreamTrack.cpp:

(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack): Create method now receives a MediaStreamTrackPrivate as parameter.

Modules/mediastream/VideoStreamTrack.h:
platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Stores the private tracks in a Vector (property of
MediaStreamDescriptor class).

(WebCore::MediaStreamDescriptor::addTrack): Adds a private track to the tracks' Vector

(WebCore::MediaStreamDescriptor::removeTrack): Removes a private track from the tracks' Vector

platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::numberOfAudioSources): Renamed from numberOfAudioStreams.

(WebCore::MediaStreamDescriptor::audioSources): Renamed from audioStreams.

(WebCore::MediaStreamDescriptor::numberOfVideoSources): Renamed from numberOfVideoStreams.

(WebCore::MediaStreamDescriptor::videoSources): Renamed from videoStreams.

(WebCore::MediaStreamDescriptor::numberOfAudioTracks): Returns the number of audio tracks this MediaStreamDescriptor
has.

(WebCore::MediaStreamDescriptor::audioTracks): Returns a audio track, given an index

(WebCore::MediaStreamDescriptor::numberOfVideoTracks): Returns the number of video tracks this MediaStreamDescriptor
has.
(WebCore::MediaStreamDescriptor::videoTracks): Returns a video track, given an index

platform/mediastream/MediaStreamTrackPrivate.cpp: Added.
platform/mediastream/MediaStreamTrackPrivate.h: Added.

10:30 AM Changeset in webkit [158017] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix MSVC

10:27 AM Changeset in webkit [158016] by zoltan@webkit.org

2 edits in trunk/Source/WebCore

[CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with multiple regions
<https://webkit.org/b/123210>

Reviewed by David Hyatt.

I simplified the determination of the next region part of updateShapeAndSegmentsForCurrentLineInFlowThread's implementation
in order to make the code more straightforward. I also tried to avoid using regionAtBlockOffset(...) function where it's possible,
since it's not always that reliable, what I'll will report in a separate bug.

No new tests, covered by existing tests.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):

10:26 AM Changeset in webkit [158015] by zoltan@webkit.org

2 edits in trunk/Source/WebCore

[CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with the first lines
<https://bugs.webkit.org/show_bug.cgi?id=123275>

Reviewed by David Hyatt.

We have a complex condition in updateShapeAndSegmentsForCurrentLineInFlowThread, which is
adjusting the first line to the shape's top. This patch adds two boolean to make that clear.

No new tests, no behavior change.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):

10:13 AM Changeset in webkit [158014] by oliver@apple.com

207 edits in trunk

Improve JSC Parser error messages
https://bugs.webkit.org/show_bug.cgi?id=123341

Reviewed by Andreas Kling.

Source/JavaScriptCore:

This patch moves away from the current cludgy mechanisms used to produce
error messages and moves to something closer to case by case errors.

This results in a large change size as previously we may just have
'failIfFalse(foo)', but now the logic becomes either
'failIfFalseWithMessage(foo, "Cannot do blah with ", foo->thing())'
Or alternatively

if (!foo)

check for 'interesting' errors, before falling back to generic error

This means that this patch is large, but produces no semantic changes, and
only hits slow (e.g. error) paths.

parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::parseDeconstructionPattern):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::stringForFunctionMode):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::operatorString):
(JSC::::parseUnaryExpression):
(JSC::::printUnexpectedTokenText):

parser/Parser.h:

(JSC::Scope::hasDeclaredVariable):
(JSC::Scope::hasDeclaredParameter):
(JSC::Parser::hasDeclaredVariable):
(JSC::Parser::hasDeclaredParameter):
(JSC::Parser::setErrorMessage):

LayoutTests:

Update a vast array of layout test results

fast/events/window-onerror5-expected.txt:
js/basic-strict-mode-expected.txt:
js/break-ASI-expected.txt:
js/dom/assign-expected.txt:
js/dom/object-extra-comma-expected.txt:
js/dom/parse-error-external-script-in-eval-expected.txt:
js/dom/parse-error-external-script-in-new-Function-expected.txt:
js/dom/reserved-words-as-property-expected.txt:
js/function-constructor-error-expected.txt:
js/function-declaration-expected.txt:
js/function-toString-object-literals-expected.txt:
js/function-toString-parentheses-expected.txt:
js/js-continue-break-restrictions-expected.txt:
js/kde/garbage-n-expected.txt:
js/kde/parse-expected.txt:
js/no-semi-insertion-at-end-of-script-expected.txt:
js/object-literal-syntax-expected.txt:
js/parser-xml-close-comment-expected.txt:
js/regexp-compile-crash-expected.txt:
js/script-tests/function-constructor-error.js:
js/script-tests/reserved-words-strict.js:

(isReserved):

sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T2-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T2-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T3-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.3_T2-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.4_T2-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T4-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.10-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.13-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.14-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.16-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.17-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.2-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.20-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.22-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.24-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.25-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.3-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.4-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.5-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.8-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.9-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.10-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.11-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.16-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.5-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.6-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.7-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.9-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T2-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T3-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T3-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T3-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T3-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T7-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T8-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T9-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T3-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T6-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T4-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T8-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T4-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T8-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A4-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T5-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T6-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T8-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T9-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T4-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T5-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T6-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T7-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.4_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T6-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T7-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T8-expected.txt:
sputnik/Conformance/08_Types/8.2_The_Null_Type/S8.2_A2-expected.txt:
sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T3-expected.txt:
sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T3-expected.txt:
sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T1-expected.txt:
sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T2-expected.txt:
sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T3-expected.txt:
sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T4-expected.txt:
sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T1-expected.txt:
sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T2-expected.txt:
sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T3-expected.txt:
sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T4-expected.txt:
sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A2_T1-expected.txt:
sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T2-expected.txt:
sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T3-expected.txt:
sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T5-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T1-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T11-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T12-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T14-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T15-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T2-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T3-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T4-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T6-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8-expected.txt:
sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T9-expected.txt:
sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T1-expected.txt:
sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T2-expected.txt:
sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T3-expected.txt:
sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T4-expected.txt:
sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T5-expected.txt:
sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T6-expected.txt:
sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T7-expected.txt:
sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T8-expected.txt:
sputnik/Conformance/12_Statement/12.4_Expression_Statement/S12.4_A1-expected.txt:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A11-expected.txt:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1-expected.txt:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2-expected.txt:
sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A9_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A12-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A13_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A15-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T1-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T2-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T4-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T5-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T6-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A13_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A15-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T1-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T2-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T4-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T5-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T6-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4.1-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T1-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T2-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T1-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T2-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T1-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T2-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A13_T3-expected.txt:
sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.1_eval/S15.1.2.1_A2_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A1_T1-expected.txt:

9:37 AM Changeset in webkit [158013] by svillar@igalia.com

9 edits in trunk/Source/WebKit2

[GTK][WK2] Build break after r157967 and r157972
https://bugs.webkit.org/show_bug.cgi?id=123325

Reviewed by Carlos Garcia Campos.

DrawingArea::visibilityDidChange was removed in favour of a new
message called SetIsVisible which is sent to the WebPage. This
means that {suspend|resume}Paiting are now implemented in a
cross-platform way in WebPage and do not require specific code
from the DrawingArea implementations.

This means that we have to track the toplevel window visibility
and notify the WebPage appropriately about its changes.

UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::isWindowVisible):

UIProcess/API/gtk/PageClientImpl.h:
UIProcess/API/gtk/WebKitWebViewBase.cpp:

(toplevelWindowVisibilityEvent):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseIsWindowVisible):

UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
UIProcess/DrawingAreaProxyImpl.cpp:
UIProcess/DrawingAreaProxyImpl.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::suspendPainting):
(WebKit::DrawingAreaImpl::resumePainting):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndWebPageAreFocused):

8:58 AM Changeset in webkit [158012] by Antti Koivisto

5 edits in trunk/Source/WebCore

Faster way for simple line layout to check if text has fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=123342

Reviewed by Andreas Kling.

Don't use RenderText::knownToHaveNoOverflowAndNoFallbackFonts as it is slow.

Simple text code path test already guarantees there is no overflow. Test for fallback
fonts explicitly.

platform/graphics/SimpleFontData.h:

Make FINAL.

rendering/RenderText.cpp:
rendering/RenderText.h:

Remove knownToHaveNoOverflowAndNoFallbackFonts() as it has no clients.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

Check if all characters can be found from the primary font.

7:42 AM Changeset in webkit [158011] by akling@apple.com

7 edits in trunk/Source/WebCore

SVGResourcesCache::clientDestroyed() should take a RenderElement&.
<https://webkit.org/b/123339>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

6:52 AM Changeset in webkit [158010] by akling@apple.com

8 edits in trunk/Source/WebCore

SVGResourcesCache::clientLayoutChanged() should take a RenderElement&.
<https://webkit.org/b/123336>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

6:49 AM Changeset in webkit [158009] by akling@apple.com

9 edits in trunk/Source/WebCore

SVGResourcesCache::clientStyleChanged() should take a RenderElement&.
<https://webkit.org/b/123335>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

6:48 AM Changeset in webkit [158008] by akling@apple.com

14 edits in trunk/Source/WebCore

SVG: postApplyResource() should take a RenderElement&.
<https://webkit.org/b/123334>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

6:46 AM Changeset in webkit [158007] by Antti Koivisto

2 edits in trunk/Source/WebCore

REGRESSION(r157950): It made many tests assert on Windows, EFL, GTK
https://bugs.webkit.org/show_bug.cgi?id=123309

Reviewed by Andreas Kling.

Disable simple line layout on non-Mac plaforms for now.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

6:20 AM Changeset in webkit [158006] by rniwa@webkit.org

2 edits in trunk/Websites/test-results

One more build fix. Put each latest revision information in an actual td.

public/index.html:

5:43 AM Changeset in webkit [158005] by rniwa@webkit.org

3 edits in trunk/Websites/test-results

Yet another set of build fixes.

Manually strip / from revisions JSON if there is any.
Suppress warnings from ob_end_flush.
Allow "+" in actual and expected results as used in "TEXT+IMAGE".

public/api/report.php:
public/include/test-results.php:

5:28 AM Changeset in webkit [158004] by akling@apple.com

20 edits in trunk/Source/WebCore

SVG: applyResource() should take a RenderElement&.
<https://webkit.org/b/123286>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

5:00 AM Changeset in webkit [158003] by akling@apple.com

15 edits in trunk/Source/WebCore

RenderElement::styleWillChange() should pass newStyle as reference.
<https://webkit.org/b/123332>

When styleWillChange() is called, there is always a new style getting
set so there's no need to handle the null style case.
This flushed out a couple of unnecessary checks.

Reviewed by Antti Koivisto.

4:57 AM Changeset in webkit [158002] by commit-queue@webkit.org

4 edits in trunk

[GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-25
Reviewed by Martin Robinson.

Source/WebKit2:

Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.

WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformCanHandleRequest):

Tools:

Scripts/run-gtk-tests:

(TestRunner):

4:49 AM Changeset in webkit [158001] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=123269

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-25
Reviewed by Csaba Osztrogonác.

platform/graphics/win/ImageCairoWin.cpp: Added new parameter to BitmapImage::draw() calls.

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

4:19 AM Changeset in webkit [158000] by rniwa@webkit.org

1 edit
1 move in trunk/Websites/test-results

Another build fix. Move .htaccess to public.

.htaccess: Removed.
public/.htaccess: Copied from .htaccess.

3:31 AM Changeset in webkit [157999] by svillar@igalia.com

4 edits
1 add in trunk

Use a Vector instead of HashSet to computed the orderValues in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=118620

Reviewed by Antti Koivisto.

PerformanceTests:

From Blink r152960 by <ojan@chromium.org>

New performance test for layouts in flexboxes.

Layout/flexbox-lots-of-data.html: Added.

Source/WebCore:

Turns out that order is extremelly uncommon so using a Vector is
much less expensive. This also special-cases the much common case
of only having order of value 0 by using Vectors with just one
preallocated member.

Also added the performance test that shows a ~1% win when using a
vector instead of the HashSet.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):

rendering/RenderFlexibleBox.h:

2:52 AM Changeset in webkit [157998] by svillar@igalia.com

2 edits in trunk/Source/WebCore

Non-SVG build broken after r157950
https://bugs.webkit.org/show_bug.cgi?id=123328

Reviewed by Xan Lopez.

The isSVGInlineTest() check should be done only if SVG is enabled.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

2:50 AM Changeset in webkit [157997] by Manuel Rego Casasnovas

11 edits in trunk/LayoutTests

[CSS Regions] Rename CSS classes and JS methods in vertical layout tests about selection
https://bugs.webkit.org/show_bug.cgi?id=123327

Reviewed by Mihnea Ovidenie.

For consistency with Blink we use Vertical instead of Vert in CSS
classes and JS methods related to the selection layout tests for CSS
Regions.

fast/regions/resources/helper.js:

(selectContentByIdsVertical):

fast/regions/resources/region-style.css:
fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html:
fast/regions/selection/selecting-text-ignoring-region-vert-lr.html:
fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html:
fast/regions/selection/selecting-text-ignoring-region-vert-rl.html:
fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:

1:44 AM Changeset in webkit [157996] by Csaba Osztrogonác

8 edits in trunk/Source/WebKit2

[EFL][WK2] Build break after r157967 and r157972
https://bugs.webkit.org/show_bug.cgi?id=123324

Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-10-25
Reviewed by Tim Horton.

Since r157967 and r157972, visibilityDidChange was removed from DrawingAreaProxy.

UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::visibilityDidChange):
Removed common logic which r157967 moved to WebProcess.

UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:

Make visibilityDidChange to public method.

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::setVisible):
(WebKit::WebView::isWindowVisible): Added.

UIProcess/CoordinatedGraphics/WebView.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setWindowIsVisible):

WebProcess/WebPage/WebPage.h:

Moved m_windowIsVisible to use at all WK2 based port.
(WebKit::WebPage::windowIsVisible):

WebProcess/WebPage/WebPage.messages.in:

Moved SetWindowIsVisible message to use at all WK2 based port.

1:32 AM Changeset in webkit [157995] by rniwa@webkit.org

2 edits in trunk/Tools

Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.

Scripts/webkitpy/port/base.py:

(Port.repository_paths):

1:31 AM Changeset in webkit [157994] by Manuel Rego Casasnovas

2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Several fast/regions/selection tests are failing in WK2.

Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-10-25

platform/gtk-wk2/TestExpectations:

12:47 AM Changeset in webkit [157993] by rniwa@webkit.org

2 edits in trunk/Websites/test-results

It turns out that the current instruction only works on Mountain Lion.

Also fixed some typos.

Install.md:

12:13 AM Changeset in webkit [157992] by jer.noble@apple.com

5 edits in trunk

[WTF] Add a multiplication operator (and a few others) to MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123137

Reviewed by Eric Carlson.

Source/WTF:

Add a multiplication operator and an inequality operator to the
MediaTime class for use by MSE.

wtf/MediaTime.cpp:

(WTF::signum): Moved to top of file.
(WTF::MediaTime::operator*): Added.
(WTF::MediaTime::operator!=): Added.

wtf/MediaTime.h:

(WTF::operator*): Added non-class version of operator*.

Tools:

Add tests for new MediaTime operators.

TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST):

12:07 AM Changeset in webkit [157991] by jer.noble@apple.com

7 edits
2 copies in trunk/Source

[Mac] Add helper methods to convert CMTime <--> MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123285

Reviewed by Eric Carlson.

Source/WebCore:

Add utility methods to convert between CMTime (a rational time class) and MediaTime.
Once there, PlatformClockCM can now vend and accept MediaTimes for currentTime.

platform/mac/MediaTimeMac.h:
platform/mac/MediaTimeMac.cpp:

(WebCore::toMediaTime): Added conversion utility method.
(WebCore::toCMTime): Ditto.

platform/mac/PlatformClockCM.h:
platform/mac/PlatformClockCM.mm:

(PlatformClockCM::setCurrentMediaTime): Added.
(PlatformClockCM::currentMediaTime): Added.

WebCore.xcodeproj/project.pbxproj: Add new files to project.

Source/WTF:

Add a #ifdef header_h protector.

wtf/MediaTime.h:

Oct 24, 2013:

10:17 PM Changeset in webkit [157990] by rniwa@webkit.org

2 edits
1 move
1 add in trunk/Websites/test-results

Add an instruction on how to setup test-results app
https://bugs.webkit.org/show_bug.cgi?id=123321

Rubber-stamped by Stephanie Lewis.

Added Install.md and updated config.json accordingly.

Also moved init-database.sql out of public/include since it doesn't need to be accessible via httpd.

Install.md: Added.
config.json:
init-database.sql: Moved from public/include/init-database.sql.

9:43 PM Changeset in webkit [157989] by rniwa@webkit.org

2 edits
1 copy
7 moves
1 add
1 delete in trunk/Websites/test-results

Move everything except ChangeLog and config.json into public directory.
https://bugs.webkit.org/show_bug.cgi?id=123319

Rubber-stamped by Stephanie Lewis.

admin: Removed.
admin/admin.css: Removed.
admin/builders.php: Removed.
admin/index.php: Removed.
admin/repositories.php: Removed.
api: Removed.
api/failing-tests.php: Removed.
api/manifest.php: Removed.
api/report.php: Removed.
api/results.php: Removed.
common.css: Removed.
config.json: Copied from include/config.json.
include: Removed.
include/admin-footer.php: Removed.
include/admin-header.php: Removed.
include/config.json: Removed.
include/db.php: Removed.
include/init-database.sql: Removed.
include/json-shared.php: Removed.
include/test-results.php: Removed.
index.html: Removed.
js: Removed.
js/autocompleter.js: Removed.
js/build.js: Removed.
js/dom.js: Removed.
main.css: Removed.
public: Added.
public/admin: Copied from admin.
public/api: Copied from api.
public/common.css: Copied from common.css.
public/include: Copied from include.
public/include/config.json: Removed.
public/include/db.php:
public/index.html: Copied from index.html.
public/js: Copied from js.
public/main.css: Copied from main.css.

9:22 PM Changeset in webkit [157988] by rniwa@webkit.org

9 edits in trunk/Websites/test-results

Showing lists of flaky tests for a builder takes too long
https://bugs.webkit.org/show_bug.cgi?id=123311

Reviewed by Sam Weinig.

Generate JSONs for tests failing, flaky, or with wrong expectation at the time a builder reports results
instead when the frontend requests to those those results since it takes multiple seconds or minutes to
generate those JSON files.

api/failing-tests.php: Moved and renamed to manually generate all JSON files for a given builder.

(main):

api/report.php: Manually flush and end the request (to avoid blocking run-webkit-tests on the other side

for minutes), then generate JSONs for tests that are failing, are flaky, and have wrong expectations.

api/results.php: Merge format_result_rows here since it's not used anywhere else.

include/config.json: Added the path to the data directory into which JSON files are generated.

include/db.php:

(configPath): Takes a relative path value from config.json, and resolves it.

include/json-shared.php:

(echo_success): Extracted from exit_with_success.
(exit_with_success):

include/test-results.php:

(add_builder): Extracted from add_build.
(add_build):
(ResultsJSONWriter): Extracted from api/failing-tests.php.
(ResultsJSONWriter.construct):
(ResultsJSONWriter.start):
(ResultsJSONWriter.end):
(ResultsJSONWriter.add_results_for_test_if_matches):
(ResultsJSONWriter.pass_for_failure_type):
(FailingResultsJSONWriter): Extracted from index.html's TestResultsView._matchesFailureType.
(FailingResultsJSONWriter.construct):
(FailingResultsJSONWriter.pass_for_failure_type):
(FlakyResultsJSONWriter): Ditto.
(FlakyResultsJSONWriter.construct):
(FlakyResultsJSONWriter.pass_for_failure_type):
(WrongExpectationsResultsJSONWriter): Ditto.
(WrongExpectationsResultsJSONWriter.construct):
(WrongExpectationsResultsJSONWriter.pass_for_failure_type):
(ResultsJSONGenerator): Ditto.
(ResultsJSONGenerator.construct):
(ResultsJSONGenerator.generate):
(ResultsJSONGenerator.open_json_for_failure_type):
(ResultsJSONGenerator.write_jsons):

index.html:

(TestResultsView):
(TestResultsView.setBuilders):
(TestResultsView._createResultCell): Add a hyperlink to results.html in the tooltip.
(TestResultsView.fetchFailingTestsForBuilder): Fetch the generated JSON files.

9:04 PM Changeset in webkit [157987] by mrowe@apple.com

44 edits in trunk

Remove references to OS X 10.7 from Xcode configuration settings.

Now that we're not building for OS X 10.7 they're no longer needed.

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/ThirdParty:

gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit/mac:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:
Configurations/BaseXPCService.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:
Configurations/WebContentProcess.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MiniBrowser/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/DebugRelease.xcconfig:
WebKitLauncher/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/DebugRelease.xcconfig:

8:59 PM Changeset in webkit [157986] by Simon Fraser

20 edits
19 copies
6 adds in trunk/LayoutTests

New Mavericks results for editing and fast/html, with MountainLion fallbacks.

platform/mac-mountainlion/editing/input/caret-at-the-edge-of-input-expected.txt: Copied from LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt.
platform/mac-mountainlion/editing/inserting/before-after-input-element-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.txt.
platform/mac-mountainlion/editing/pasteboard/4806874-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/4806874-expected.txt.
platform/mac-mountainlion/editing/pasteboard/drop-text-without-selection-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt.
platform/mac-mountainlion/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/input-field-1-expected.txt.
platform/mac-mountainlion/editing/selection/3690703-2-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt.
platform/mac-mountainlion/editing/selection/3690703-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.txt.
platform/mac-mountainlion/editing/selection/3690719-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.txt.
platform/mac-mountainlion/editing/selection/4895428-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.txt.
platform/mac-mountainlion/editing/selection/4975120-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.txt.
platform/mac-mountainlion/editing/selection/drag-select-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/drag-select-1-expected.txt.
platform/mac-mountainlion/editing/selection/replaced-boundaries-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.txt.
platform/mac-mountainlion/editing/selection/select-from-textfield-outwards-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-from-textfield-outwards-expected.txt.
platform/mac-mountainlion/fast/html/details-no-summary4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt.
platform/mac-mountainlion/fast/html/details-open-javascript-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open-javascript-expected.txt.
platform/mac-mountainlion/fast/html/details-open2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open2-expected.txt.
platform/mac-mountainlion/fast/html/details-open4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open4-expected.txt.
platform/mac-mountainlion/fast/html/details-replace-summary-child-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt.
platform/mac-mountainlion/fast/html/details-replace-text-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt.
platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
platform/mac/editing/inserting/before-after-input-element-expected.txt:
platform/mac/editing/pasteboard/4806874-expected.txt:
platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
platform/mac/editing/pasteboard/input-field-1-expected.txt:
platform/mac/editing/selection/3690703-2-expected.txt:
platform/mac/editing/selection/3690703-expected.txt:
platform/mac/editing/selection/3690719-expected.txt:
platform/mac/editing/selection/4895428-3-expected.txt:
platform/mac/editing/selection/4975120-expected.txt:
platform/mac/editing/selection/drag-select-1-expected.txt:
platform/mac/editing/selection/replaced-boundaries-3-expected.txt:
platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
platform/mac/fast/html/details-no-summary4-expected.txt:
platform/mac/fast/html/details-open-javascript-expected.txt:
platform/mac/fast/html/details-open2-expected.txt:
platform/mac/fast/html/details-open4-expected.txt:
platform/mac/fast/html/details-replace-summary-child-expected.txt:
platform/mac/fast/html/details-replace-text-expected.txt:

7:33 PM Changeset in webkit [157985] by Antti Koivisto

5 edits in trunk/Source/WebCore

Cache line layout path
https://bugs.webkit.org/show_bug.cgi?id=123298

Reviewed by Sam Weinig.

Determining the path can be non-trivial. Avoid computing it repeatedly on relayouts.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::invalidateLineLayoutPath):
(WebCore::RenderBlock::removeChild):

Invalidate the path when children change.

rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::styleDidChange):

Invalidate the path when style changes.

(WebCore::RenderBlockFlow::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderBlockFlow::ensureLineBoxes):

rendering/RenderText.cpp:

(WebCore::RenderText::setText):

Invalidate the path when text changes.

6:48 PM Changeset in webkit [157984] by barraclough@apple.com

3 edits in trunk/Source/WebKit2

Coalesce calls to viewStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=123307

Reviewed by Tim Horton.

UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):

coalesce calls to viewStateDidChange

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

handle changes to view visibility & active state in correct order.

6:46 PM Changeset in webkit [157983] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154694. <rdar://problem/15109413>

6:44 PM Changeset in webkit [157982] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154693. <rdar://problem/15109413>

6:42 PM Changeset in webkit [157981] by mrowe@apple.com

44 edits in trunk

<rdar://problem/15312643> Prepare for the mysterious future.

Reviewed by David Kilzer.

Source/JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/ThirdParty:

gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit/mac:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:
Configurations/BaseXPCService.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:
Configurations/WebContentProcess.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MiniBrowser/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/DebugRelease.xcconfig:
WebKitLauncher/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/DebugRelease.xcconfig:

6:41 PM Changeset in webkit [157980] by Lucas Forschler

3 edits
1 copy in branches/safari-537.73-branch

Merged r154681. <rdar://problem/15109418>

6:35 PM Changeset in webkit [157979] by akling@apple.com

5 edits in trunk/Source/WebCore

DocumentLoader::cachedResourceLoader() should return a reference.
<https://webkit.org/b/123303>

..and while we're at it, make DocumentLoader::m_cachedResourceLoader
a Ref, and have CachedResourceLoader::create return a PassRef.

Reviewed by Sam Weinig.

6:34 PM Changeset in webkit [157978] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/WTF

Merged r154655. <rdar://problem/15109412>

6:32 PM Changeset in webkit [157977] by Lucas Forschler

35 edits
1 delete in branches/safari-537.73-branch

Merged r154647. <rdar://problem/15109412>

6:27 PM Changeset in webkit [157976] by Lucas Forschler

3 edits in branches/safari-537.73-branch/Source/WebKit

Merged r154642. <rdar://problem/15109339>

6:25 PM Changeset in webkit [157975] by Lucas Forschler

1 edit
3 copies in branches/safari-537.73-branch/Source/WebKit/win

Merged r154634. <rdar://problem/15109339>

6:23 PM Changeset in webkit [157974] by Lucas Forschler

10 edits
2 copies in branches/safari-537.73-branch/Source/WebKit

Merged r154627. <rdar://problem/15109339>

6:21 PM Changeset in webkit [157973] by Lucas Forschler

24 edits in branches/safari-537.73-branch

Merged r154527. <rdar://problem/15109367>

6:17 PM Changeset in webkit [157972] by barraclough@apple.com

8 edits in trunk/Source/WebKit2

Stop bringing in the std namespace
https://bugs.webkit.org/show_bug.cgi?id=123273

Patch by Anders Carlsson <andersca@apple.com> on 2013-10-24
Reviewed by Andreas Kling.

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):

6:15 PM Changeset in webkit [157971] by andersca@apple.com

143 edits in trunk/Source

Stop bringing in the std namespace
https://bugs.webkit.org/show_bug.cgi?id=123273

Reviewed by Andreas Kling.

Source/WebCore:

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::startGrain):
(WebCore::AudioBufferSourceNode::totalPitchRate):

Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::numberOfChannels):

Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
(WebCore::AudioScheduledSourceNode::stop):

Modules/webaudio/AudioSummingJunction.cpp:
Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::process):

Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::offlineRender):

Modules/webaudio/OscillatorNode.cpp:
Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::dopplerRate):

Modules/webaudio/WaveShaperDSPKernel.cpp:

(WebCore::WaveShaperDSPKernel::processCurve):

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):

Modules/websockets/WebSocket.cpp:

(WebCore::saturateAdd):

Modules/websockets/WebSocketChannel.cpp:
Modules/websockets/WebSocketFrame.cpp:

(WebCore::WebSocketFrame::parseFrame):

accessibility/AccessibilityARIAGrid.cpp:
accessibility/AccessibilityARIAGridCell.cpp:
accessibility/AccessibilityARIAGridRow.cpp:
accessibility/AccessibilityList.cpp:
accessibility/AccessibilityListBox.cpp:
accessibility/AccessibilityListBoxOption.cpp:
accessibility/AccessibilityNodeObject.cpp:
accessibility/AccessibilityObject.cpp:
accessibility/AccessibilityRenderObject.cpp:
accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):

accessibility/AccessibilityTableCell.cpp:
accessibility/AccessibilityTableColumn.cpp:
accessibility/AccessibilityTableHeaderContainer.cpp:
accessibility/AccessibilityTableRow.cpp:
accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::getOwnPropertyNames):

bindings/js/JSGeolocationCustom.cpp:

(WebCore::setTimeout):
(WebCore::setMaximumAge):

bindings/js/ScriptController.cpp:
bindings/js/SerializedScriptValue.cpp:

(WebCore::writeLittleEndian):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::readString):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::getFontFace):

css/CSSGradientValue.cpp:

(WebCore::CSSRadialGradientValue::createGradient):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColorParameters):
(WebCore::CSSParser::parseHSLParameters):

css/CSSReflectValue.cpp:
css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyFontSize::applyValue):

css/PropertySetCSSStyleDeclaration.cpp:
css/SVGCSSParser.cpp:
css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

css/StyleResolver.cpp:

(WebCore::StyleResolver::viewportPercentageValue):

dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):

dom/ContainerNode.cpp:
dom/Document.cpp:

(WebCore::Document::minimumLayoutDelay):

dom/Node.cpp:

(WebCore::Node::compareDocumentPosition):

dom/Range.cpp:

(WebCore::Range::toString):
(WebCore::Range::textRects):
(WebCore::Range::textQuads):

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::scheduleAnimation):

dom/StyledElement.cpp:

(WebCore::StyledElement::makePresentationAttributeCacheKey):

dom/Text.cpp:
dom/ViewportArguments.cpp:

(WebCore::clampLengthValue):
(WebCore::clampScaleValue):
(WebCore::ViewportArguments::resolve):
(WebCore::computeMinimumScaleFactorForContentContained):
(WebCore::restrictMinimumScaleFactorToViewportSize):

editing/AlternativeTextController.cpp:
editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

editing/Editor.cpp:

(WebCore::Editor::setComposition):
(WebCore::Editor::compositionRange):

editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance):

editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
(WebCore::CharacterIterator::string):
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::append):
(WebCore::SearchBuffer::prependContext):
(WebCore::SearchBuffer::search):

editing/VisibleUnits.cpp:

(WebCore::startOfParagraph):

editing/htmlediting.cpp:
editing/markup.cpp:
fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::didReceiveResponse):
(WebCore::FileReaderLoader::didReceiveData):

history/BackForwardList.cpp:

(WebCore::BackForwardList::backListWithLimit):
(WebCore::BackForwardList::forwardListWithLimit):

history/PageCache.cpp:

(WebCore::PageCache::setCapacity):

html/BaseDateAndTimeInputType.cpp:
html/FTPDirectoryDocument.cpp:
html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::getRegion):

html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):
(WebCore::parseColorStringWithCrazyLegacyRules):

html/HTMLFormControlElement.cpp:
html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getTextFieldValues):

html/HTMLImageElement.cpp:
html/HTMLInputElement.cpp:
html/HTMLMapElement.cpp:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::textTrackAddCue):
(WebCore::HTMLMediaElement::textTrackRemoveCue):
(WebCore::HTMLMediaElement::rewind):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::duration):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::updateListBoxSelection):

html/HTMLSourceElement.cpp:
html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::colSpan):
(WebCore::HTMLTableCellElement::rowSpan):

html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::parseAttribute):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionStart):
(WebCore::HTMLTextFormControlElement::setSelectionEnd):
(WebCore::HTMLTextFormControlElement::select):
(WebCore::HTMLTextFormControlElement::setSelectionRange):

html/HTMLTrackElement.cpp:
html/ImageDocument.cpp:

(WebCore::ImageDocument::scale):

html/InputType.cpp:

(WebCore::InputType::valueAsDouble):

html/MediaController.cpp:

(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::updateReadyState):

html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsDouble):
(WebCore::NumberInputType::setValueAsDecimal):
(WebCore::NumberInputType::createStepRange):

html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

html/SearchInputType.cpp:

(WebCore::SearchInputType::startSearchEventTimer):

html/StepRange.cpp:

(WebCore::StepRange::clampValue):
(WebCore::StepRange::parseStep):

html/TimeRanges.cpp:
html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::adjustBubblePosition):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeRect):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlRewindButtonElement::defaultEventHandler):

html/shadow/MediaControlsApple.cpp:
html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

inspector/ContentSearchUtils.cpp:
inspector/DOMEditor.cpp:
inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):

inspector/InjectedScriptHost.cpp:
loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::incrementProgress):

loader/cache/CachedImage.cpp:
page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

page/EventHandler.cpp:

(WebCore::MaximumDurationTracker::~MaximumDurationTracker):

page/FrameTree.cpp:
page/FrameView.cpp:

(WebCore::FrameView::adjustedDeferredRepaintDelay):
(WebCore::FrameView::autoSizeIfEnabled):

page/PrintContext.cpp:

(WebCore::PrintContext::computeAutomaticScaleFactor):

page/SpatialNavigation.cpp:

(WebCore::entryAndExitPointsForDirection):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFilterOperations):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):

platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::FloatRect):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::uniteEvenIfEmpty):
(WebCore::FloatRect::extend):
(WebCore::FloatRect::fitToPoints):

platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):
(WebCore::GlyphPageTreeNode::getChild):

platform/graphics/IntRect.cpp:

(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):
(WebCore::IntRect::uniteIfNonZero):

platform/graphics/LayoutRect.cpp:

(WebCore::LayoutRect::intersect):
(WebCore::LayoutRect::unite):
(WebCore::LayoutRect::uniteIfNonZero):

platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApplySoftware):

platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):

platform/text/TextCodecICU.cpp:
rendering/LineWidth.cpp:

(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):

rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::availableLogicalWidthForContent):

rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::computePreferredLogicalWidths):
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
(WebCore::RenderFieldset::paintBoxDecorations):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::addForcedRegionBreak):

rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::layoutWithFlattening):

rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layOutAxis):

rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

rendering/RenderTableCell.h:
rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

rendering/RootInlineBox.h:

(WebCore::RootInlineBox::selectionHeight):
(WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock):

rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::layout):

rendering/style/RenderStyle.h:
rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::imageSize):

style/StyleFontSizeFunctions.cpp:

(WebCore::Style::fontSizeForKeyword):

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setCurrentTime):

Source/WebKit/mac:

WebView/WebFrameView.mm:

(-[WebFrameView _verticalPageScrollDistance]):
(-[WebFrameView _horizontalPageScrollDistance]):

WebView/WebHTMLView.mm:

(-[WebHTMLView _scaleFactorForPrintOperation:]):

WebView/WebView.mm:

(+[WebView _setCacheModel:]):
(+[WebView _maxCacheModelInAnyInstance]):
(+[WebView _cacheModelChangedNotification:]):
(+[WebView _preferencesRemovedNotification:]):

Source/WebKit2:

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):

6:12 PM Changeset in webkit [157970] by Simon Fraser

2 edits
1 delete in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=123304

The focus-option-control-on-page.html test has behavior that depends on the system
"Full Keyboard Access" prefs, so mark it as passing or failing, and remove a bogus
result that I added.

platform/mac-mountainlion/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Removed.
platform/mac/TestExpectations:

5:48 PM Changeset in webkit [157969] by Simon Fraser

57 edits
56 copies
41 adds in trunk/LayoutTests

More new test results for Mavericks, and MountainLion results where necessary.

platform/mac-mountainlion/css3/selectors3/html/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt.
platform/mac-mountainlion/css3/selectors3/html/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt.
platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt.
platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
platform/mac-mountainlion/css3/selectors3/html/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt.
platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt.
platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt.
platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt.
platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt.
platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt.
platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt.
platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt.
platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt.
platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug120107-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug12384-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug12384-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug1271-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug12908-2-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug12910-2-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug131020-2-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug13169-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug137388-1-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug137388-2-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug137388-3-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug138725-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug138725-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug157890-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug1818-3-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug1818-6-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug196870-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug222336-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug222467-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug24200-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug24200-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug2479-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug26178-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug269566-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug277062-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug28928-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug28933-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug29314-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug29326-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug29326-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug2954-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug30692-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug4382-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4382-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug46368-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug46368-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug50695-2-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug51037-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51037-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug51727-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51727-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug52505-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug52505-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug55545-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug55545-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug56201-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug59354-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug68912-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug68912-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug8032-2-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug9024-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/bugs/bug96334-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.txt.
platform/mac-mountainlion/tables/mozilla/bugs/bug99948-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug99948-expected.txt.
platform/mac-mountainlion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt.
platform/mac-mountainlion/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Added.
platform/mac-mountainlion/tables/mozilla/core/margins-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/core/margins-expected.txt.
platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.txt.
platform/mac-mountainlion/tables/mozilla/other/move_row-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/other/move_row-expected.txt.
platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt.
platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt.
platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt.
platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt.
platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt:
platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt:
platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt:
platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt:
platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt:
platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt:
platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
platform/mac/tables/mozilla/bugs/bug29326-expected.txt:
platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
platform/mac/tables/mozilla/bugs/bug68912-expected.txt:
platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
platform/mac/tables/mozilla/core/margins-expected.txt:
platform/mac/tables/mozilla/dom/tableDom-expected.txt:
platform/mac/tables/mozilla/other/move_row-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:

5:43 PM Changeset in webkit [157968] by barraclough@apple.com

4 edits in trunk/Source/WebKit2

Simplify window occlusion detection code
https://bugs.webkit.org/show_bug.cgi?id=123300

Reviewed by Tim Horton.

Currently the WKView tries to maintain a copy of the window's occluded state,
but forced to NO when occlusion detection is disabled (and capable of handling
dectection being dynamically toggled). Simpler to just rely on the actual value
from the window, && the enabled setting. Cleaning this up revealed that we're
not sending a viewStateDidChange to the WebPageProxy when the occlusion state
changes, which we probably should be.

UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::isViewVisible):

check the real value of occlusion state from the window.

UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):

don't update cached value.

(-[WKView _windowDidChangeOcclusionState:]):

don't update cached value, but do send viewStateDidChange to the WebPageProxy.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

removed _isWindowOccluded.

(-[WKView windowOcclusionDetectionEnabled]):
(-[WKView setWindowOcclusionDetectionEnabled:]):

Just toggle the flag - no cached state to update any more.

UIProcess/API/mac/WKViewInternal.h:
- removed _isWindowOccluded.

5:42 PM Changeset in webkit [157967] by barraclough@apple.com

12 edits in trunk/Source/WebKit2

SetIsVisible message should be sent to WebPage
https://bugs.webkit.org/show_bug.cgi?id=123296

Reviewed by Tim Horton.

UIProcess/DrawingAreaProxy.h:
- remove visibilityDidChange - WebPageProxy now mesages WebPage.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

Send view visibility updates to the WebPage, not the drawing area.

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
- remove visibilityDidChange - WebPageProxy now mesages WebPage.
WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::suspendPainting):
(WebKit::DrawingArea::resumePainting):

WebProcess/WebPage/DrawingArea.messages.in:
- Instead of suspendPainting/resumePainting being private in the WebProcess but avaialble to the UIProcess, make them private to the WebProcess but accessible from WebPage.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewIsVisible):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
- Added SetViewIsVisible message.
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- Instead of suspendPainting/resumePainting being private in the WebProcess but avaialble to the UIProcess, make them private to the WebProcess but accessible from WebPage.
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):

Moved animation suspend code out to WebPage.

5:15 PM Changeset in webkit [157966] by timothy@apple.com

2 edits in trunk/Source/WebInspectorUI

Allow editing CSS resources after they have been pretty printed.

https://bugs.webkit.org/show_bug.cgi?id=123297

Reviewed by Joseph Pecoraro.

UserInterface/TextEditor.js:

(WebInspector.TextEditor): Remove the need for _readOnly.
(WebInspector.TextEditor.prototype.set readOnly): Set CodeMirror readOnly directly.
(WebInspector.TextEditor.prototype.set formatted): Don't call _updateCodeMirrorReadOnly.
(WebInspector.TextEditor.prototype._updateCodeMirrorReadOnly): Removed.
(WebInspector.TextEditor.prototype._contentChanged): Clear _formatted and _formatterSourceMap
on edit and notify the delegate and fire the FormattingDidChange event.

5:14 PM Changeset in webkit [157965] by Lucas Forschler

3 edits
3 copies in branches/safari-537.73-branch

Merged r154346. <rdar://problem/15109376>

5:06 PM Changeset in webkit [157964] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/JavaScriptCore/dfg

Merge fix for <rdar://problem/15109401>

5:02 PM Changeset in webkit [157963] by Lucas Forschler

4 edits
8 deletes in branches/safari-537.73-branch

Rollout r157962.

4:59 PM Changeset in webkit [157962] by Lucas Forschler

4 edits
8 copies in branches/safari-537.73-branch

Merged r154344. <rdar://problem/15109401>

4:45 PM Changeset in webkit [157961] by Simon Fraser

99 edits
97 copies
26 adds in trunk/LayoutTests

Update fast/forms tests for Mavericks, adding results for MountainLion when necessary.

platform/mac-mountainlion/fast/forms/HTMLOptionElement_label01-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt.
platform/mac-mountainlion/fast/forms/HTMLOptionElement_label02-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt.
platform/mac-mountainlion/fast/forms/HTMLOptionElement_label03-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt.
platform/mac-mountainlion/fast/forms/HTMLOptionElement_label04-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt.
platform/mac-mountainlion/fast/forms/HTMLOptionElement_label05-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt.
platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt.
platform/mac-mountainlion/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt.
platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt.
platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt.
platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt.
platform/mac-mountainlion/fast/forms/button-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.txt.
platform/mac-mountainlion/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
platform/mac-mountainlion/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
platform/mac-mountainlion/fast/forms/button-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt.
platform/mac-mountainlion/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.txt.
platform/mac-mountainlion/fast/forms/button-text-transform-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt.
platform/mac-mountainlion/fast/forms/button-white-space-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.txt.
platform/mac-mountainlion/fast/forms/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.txt.
platform/mac-mountainlion/fast/forms/control-clip-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt.
platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt.
platform/mac-mountainlion/fast/forms/encoding-test-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/encoding-test-expected.txt.
platform/mac-mountainlion/fast/forms/fieldset-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.txt.
platform/mac-mountainlion/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.txt.
platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt.
platform/mac-mountainlion/fast/forms/hidden-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/hidden-listbox-expected.txt.
platform/mac-mountainlion/fast/forms/input-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-default-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-preventDefault-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-readonly-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-visibility-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-visibility-expected.txt.
platform/mac-mountainlion/fast/forms/input-appearance-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.txt.
platform/mac-mountainlion/fast/forms/input-baseline-expected.txt: Added.
platform/mac-mountainlion/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
platform/mac-mountainlion/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
platform/mac-mountainlion/fast/forms/input-double-click-selection-gap-bug-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt.
platform/mac-mountainlion/fast/forms/input-field-text-truncated-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.txt.
platform/mac-mountainlion/fast/forms/input-placeholder-visibility-1-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt.
platform/mac-mountainlion/fast/forms/input-placeholder-visibility-3-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt.
platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.txt.
platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
platform/mac-mountainlion/fast/forms/input-readonly-empty-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-empty-expected.txt.
platform/mac-mountainlion/fast/forms/input-set-composition-scroll-expected.txt: Added.
platform/mac-mountainlion/fast/forms/input-spaces-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-spaces-expected.txt.
platform/mac-mountainlion/fast/forms/input-table-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.txt.
platform/mac-mountainlion/fast/forms/input-text-click-inside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.txt.
platform/mac-mountainlion/fast/forms/input-text-click-outside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.txt.
platform/mac-mountainlion/fast/forms/input-text-double-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.txt.
platform/mac-mountainlion/fast/forms/input-text-drag-down-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.txt.
platform/mac-mountainlion/fast/forms/input-text-option-delete-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-option-delete-expected.txt.
platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt.
platform/mac-mountainlion/fast/forms/input-text-self-emptying-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-self-emptying-click-expected.txt.
platform/mac-mountainlion/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
platform/mac-mountainlion/fast/forms/input-type-text-min-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-type-text-min-width-expected.txt.
platform/mac-mountainlion/fast/forms/input-value-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-value-expected.txt.
platform/mac-mountainlion/fast/forms/input-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-width-expected.txt.
platform/mac-mountainlion/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt.
platform/mac-mountainlion/fast/forms/listbox-width-change-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.txt.
platform/mac-mountainlion/fast/forms/menulist-no-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-no-overflow-expected.txt.
platform/mac-mountainlion/fast/forms/menulist-option-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-option-wrap-expected.txt.
platform/mac-mountainlion/fast/forms/menulist-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.txt.
platform/mac-mountainlion/fast/forms/minWidthPercent-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/minWidthPercent-expected.txt.
platform/mac-mountainlion/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.txt.
platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt.
platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt.
platform/mac-mountainlion/fast/forms/placeholder-position-expected.txt: Added.
platform/mac-mountainlion/fast/forms/placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt.
platform/mac-mountainlion/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
platform/mac-mountainlion/fast/forms/search-cancel-button-style-sharing-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt.
platform/mac-mountainlion/fast/forms/search-display-none-cancel-button-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-display-none-cancel-button-expected.txt.
platform/mac-mountainlion/fast/forms/search-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.txt.
platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.txt.
platform/mac-mountainlion/fast/forms/search/search-size-with-decorations-expected.txt: Added.
platform/mac-mountainlion/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.txt.
platform/mac-mountainlion/fast/forms/select-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.txt.
platform/mac-mountainlion/fast/forms/select-change-listbox-to-popup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt.
platform/mac-mountainlion/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
platform/mac-mountainlion/fast/forms/select-disabled-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.txt.
platform/mac-mountainlion/fast/forms/select-empty-option-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-empty-option-height-expected.txt.
platform/mac-mountainlion/fast/forms/select-initial-position-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-initial-position-expected.txt.
platform/mac-mountainlion/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
platform/mac-mountainlion/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
platform/mac-mountainlion/fast/forms/select/popup-closes-on-blur-expected.txt: Added.
platform/mac-mountainlion/fast/forms/stuff-on-my-optgroup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt.
platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.txt.
platform/mac-mountainlion/fast/forms/text-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.txt.
platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt.
platform/mac-mountainlion/fast/forms/textarea-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt.
platform/mac-mountainlion/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt.
platform/mac-mountainlion/fast/forms/textarea-scrolled-type-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt.
platform/mac-mountainlion/fast/forms/textarea-setinnerhtml-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.txt.
platform/mac-mountainlion/fast/forms/textfield-focus-ring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.txt.
platform/mac-mountainlion/fast/forms/textfield-outline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.txt.
platform/mac-mountainlion/fast/forms/textfield-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-overflow-expected.txt.
platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.txt.
platform/mac-mountainlion/fast/forms/visual-hebrew-text-field-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.txt.
platform/mac-mountainlion/platform/mac/fast/forms/attributed-strings-expected.txt: Added.
platform/mac-mountainlion/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
platform/mac-mountainlion/platform/mac/fast/forms/indeterminate-progress-inline-height-expected.txt: Added.
platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-size-expected.txt: Added.
platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt.
platform/mac-mountainlion/platform/mac/fast/forms/input-number-click-expected.txt: Added.
platform/mac/TestExpectations:
platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt:
platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt:
platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt:
platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt:
platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt:
platform/mac/fast/forms/basic-inputs-expected.txt:
platform/mac/fast/forms/basic-selects-expected.txt:
platform/mac/fast/forms/basic-textareas-expected.txt:
platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
platform/mac/fast/forms/box-shadow-override-expected.txt:
platform/mac/fast/forms/button-align-expected.txt:
platform/mac/fast/forms/button-positioned-expected.txt:
platform/mac/fast/forms/button-sizes-expected.txt:
platform/mac/fast/forms/button-style-color-expected.txt:
platform/mac/fast/forms/button-table-styles-expected.txt:
platform/mac/fast/forms/button-text-transform-expected.txt:
platform/mac/fast/forms/button-white-space-expected.txt:
platform/mac/fast/forms/control-clip-expected.txt:
platform/mac/fast/forms/control-clip-overflow-expected.txt:
platform/mac/fast/forms/control-restrict-line-height-expected.txt:
platform/mac/fast/forms/encoding-test-expected.txt:
platform/mac/fast/forms/fieldset-align-expected.txt:
platform/mac/fast/forms/file/input-file-re-render-expected.txt:
platform/mac/fast/forms/form-element-geometry-expected.txt:
platform/mac/fast/forms/hidden-listbox-expected.txt:
platform/mac/fast/forms/input-align-expected.txt:
platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
platform/mac/fast/forms/input-appearance-disabled-expected.txt:
platform/mac/fast/forms/input-appearance-focus-expected.txt:
platform/mac/fast/forms/input-appearance-height-expected.txt:
platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
platform/mac/fast/forms/input-appearance-readonly-expected.txt:
platform/mac/fast/forms/input-appearance-selection-expected.txt:
platform/mac/fast/forms/input-appearance-visibility-expected.txt:
platform/mac/fast/forms/input-appearance-width-expected.txt:
platform/mac/fast/forms/input-baseline-expected.txt: Added.
platform/mac/fast/forms/input-button-sizes-expected.txt:
platform/mac/fast/forms/input-disabled-color-expected.txt:
platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
platform/mac/fast/forms/input-field-text-truncated-expected.txt:
platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
platform/mac/fast/forms/input-readonly-empty-expected.txt:
platform/mac/fast/forms/input-spaces-expected.txt:
platform/mac/fast/forms/input-table-expected.txt:
platform/mac/fast/forms/input-text-click-inside-expected.txt:
platform/mac/fast/forms/input-text-click-outside-expected.txt:
platform/mac/fast/forms/input-text-double-click-expected.txt:
platform/mac/fast/forms/input-text-drag-down-expected.txt:
platform/mac/fast/forms/input-text-option-delete-expected.txt:
platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
platform/mac/fast/forms/input-text-word-wrap-expected.txt:
platform/mac/fast/forms/input-type-text-min-width-expected.txt:
platform/mac/fast/forms/input-value-expected.txt:
platform/mac/fast/forms/input-width-expected.txt:
platform/mac/fast/forms/listbox-bidi-align-expected.txt:
platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
platform/mac/fast/forms/listbox-width-change-expected.txt:
platform/mac/fast/forms/menulist-no-overflow-expected.txt:
platform/mac/fast/forms/menulist-option-wrap-expected.txt:
platform/mac/fast/forms/menulist-restrict-line-height-expected.txt:
platform/mac/fast/forms/minWidthPercent-expected.txt:
platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
platform/mac/fast/forms/placeholder-position-expected.txt: Added.
platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
platform/mac/fast/forms/plaintext-mode-2-expected.txt:
platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
platform/mac/fast/forms/search-rtl-expected.txt:
platform/mac/fast/forms/search-vertical-alignment-expected.txt:
platform/mac/fast/forms/search/search-size-with-decorations-expected.txt: Added.
platform/mac/fast/forms/searchfield-heights-expected.txt:
platform/mac/fast/forms/select-align-expected.txt:
platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
platform/mac/fast/forms/select-disabled-appearance-expected.txt:
platform/mac/fast/forms/select-empty-option-height-expected.txt:
platform/mac/fast/forms/select-initial-position-expected.txt:
platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
platform/mac/fast/forms/select-selected-expected.txt:
platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt:
platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
platform/mac/fast/forms/text-style-color-expected.txt:
platform/mac/fast/forms/textAreaLineHeight-expected.txt:
platform/mac/fast/forms/textarea-align-expected.txt:
platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
platform/mac/fast/forms/textfield-focus-ring-expected.txt:
platform/mac/fast/forms/textfield-outline-expected.txt:
platform/mac/fast/forms/textfield-overflow-expected.txt:
platform/mac/fast/forms/validation-message-appearance-expected.txt:
platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:

4:35 PM Changeset in webkit [157960] by akling@apple.com

11 edits in trunk/Source/WebCore

Uncomplicate some of SVGTextRunRenderingContext.
<https://webkit.org/b/123294>

This class was weird about a few things, so I've taken these steps
to clear things up:

FINAL and OVERRIDE all the things.
Constructor now takes a RenderObject&.
renderer() now returns a RenderObject&.
drawSVGGlyphs() no longer takes a TextRun.
glyphDataForCharacter() no longer takes a TextRun.

To expand on the last two, there was also some awkward hoop-jumping
where we'd go through the TextRun passed by argument to find its
rendering context, which was really just |this| all along.

Reviewed by Antti Koivisto.

4:14 PM Changeset in webkit [157959] by roger_fong@apple.com

4 edits in trunk

Add texture level dependent size checks to textureImage2D calls.
https://bugs.webkit.org/show_bug.cgi?id=123290
<rdar://problem/15201382>

Reviewed by Dean Jackson.

Test covered by WebGL Conformance suite 1.0.2 test, textures/texture-size-limit.html.

There are different size limits when calling textureImage2D on different texture levels.
We should be throwing an error if our texture size exceeds these limits.

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateTexFuncParameters):

platform/mac/TestExpectations: Unskip now passing test texture-size-limit.html.

3:22 PM Changeset in webkit [157958] by commit-queue@webkit.org

9 edits in trunk/Source/WebCore

[MediaStream API] allow a stream source to be shared
https://bugs.webkit.org/show_bug.cgi?id=121954

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-24
Reviewed by Eric Carlson.

Now, the MediaStreamSource don't know about the MediaStream that owns it,
since there can be more than one MediaStream that has it as source for some track.
MediaStreamTrack classes now have observers registered, in case there are more than
one MediaStream owning that track

No new tests, no change in functionality.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream): Adding the MediaStream as an observer for each track it owns.

(WebCore::MediaStream::addTrack): Now adding the MediaStream as an observer the new added track
and adding the source to the MediaStreamDescriptor.

(WebCore::MediaStream::removeTrack): Instead of removing the source right away, we first check if
there isn't any other track using that source, if not we remove the source.

(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::addRemoteSource): MediaStreamSource has no information about the MediaStream
that uses it, so now we don't set the stream in the source anymore.

(WebCore::MediaStream::removeRemoteSource): There can be more than on track using the source. So we
get each track that is using the source and then remove it and fire the ended event.

Modules/mediastream/MediaStream.h:
Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::addObserver):
(WebCore::MediaStreamTrack::removeObserver):
(WebCore::MediaStreamTrack::trackDidEnd): Does not get the client from the MediaStreamDescriptor, it now
notify each of its observers that the track ended.

Modules/mediastream/MediaStreamTrack.h: Adding Observer class.

platform/mediastream/MediaStreamDescriptor.cpp: Destructor now does nothing. Previously it was setting

each MediaStreamSource's descriptor to null.

(WebCore::MediaStreamDescriptor::removeSource): Not setting the stream in source anymore.

(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Ditto.

(WebCore::MediaStreamDescriptor::setEnded): Not setting the state of the source to Ended

platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::~MediaStreamDescriptor):

platform/mediastream/MediaStreamSource.cpp: Removing references to MediaStream object

(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::reset):

platform/mediastream/MediaStreamSource.h:

2:40 PM Changeset in webkit [157957] by dbates@webkit.org

4 edits
2 adds in trunk

Crash in WebCore::NavigationScheduler::startTimer()
https://bugs.webkit.org/show_bug.cgi?id=123288
<rdar://problem/14055644>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Currently NavigationScheduler::startTimer() synchronously notifies the client
before the Web Inspector of a scheduled redirect. If a client cancels this
redirect then NavigationScheduler::m_redirect will become null and we'll
subsequently crash when informing the Web Inspector of this formerly scheduled
redirect. Instead, NavigationScheduler::startTimer() should notify the Web
Inspector before it notifies the client of a scheduled redirect.

As a side benefit of this change, the Web Inspector is notified of a scheduled
redirect before being notified of it being canceled when a client chooses to cancel
a scheduled redirect.

loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::startTimer):

Tools:

Add API test.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.

2:31 PM Changeset in webkit [157956] by Lucas Forschler

3 edits
2 copies in branches/safari-537.73-branch

Merged r154308. <rdar://problem/15109394>

2:28 PM Changeset in webkit [157955] by Lucas Forschler

2 edits in branches/safari-537.73-branch/Source/JavaScriptCore

Merged r154303. <rdar://problem/15109405>

2:23 PM Changeset in webkit [157954] by Lucas Forschler

11 edits
3 adds in branches/safari-537.73-branch

Merge fix for <rdar://problem/15109389>

1:55 PM Changeset in webkit [157953] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Tried to fix the Mountain Lion build.

Shared/API/Cocoa/WKFoundation.h:

1:46 PM Changeset in webkit [157952] by Antti Koivisto

2 edits in trunk/Source/WebCore

Try to fix build without CSS_SHAPES.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

1:39 PM Changeset in webkit [157951] by mitz@apple.com

8 edits in trunk/Source/WebKit2

[Cocoa] Add -[WKBrowsingContextController goToBackForwardItem:]
https://bugs.webkit.org/show_bug.cgi?id=123289

Reviewed by Sam Weinig.

Shared/API/Cocoa/WKFoundation.h: Defined WK_API_CLASS.
UIProcess/API/mac/WKBrowsingContextController.h: Declared -goToBackForwardListItem:.
UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController goToBackForwardListItem:]): Added.

UIProcess/Cocoa/WKBackForwardList.h: Deployed WK_API_CLASS to make the class exported.
UIProcess/Cocoa/WKBackForwardListItem.h: Ditto.
UIProcess/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem _item]): Added. Returns the underlying WebBackForwardListItem.

UIProcess/Cocoa/WKBackForwardListItemInternal.h: Declared _item.

1:31 PM Changeset in webkit [157950] by Antti Koivisto

15 edits
5 adds in trunk/Source/WebCore

Simple line layout
https://bugs.webkit.org/show_bug.cgi?id=122458

Reviewed by Darin Adler.

Line box based inline layout is powerful but also rather slow and memory intensive. Simple line layout
is a compact alternative data structure and fast code path to cover common cases without requiring line
boxes.

This patch handles a case single left-aligned text renderer inside flow with no floats. Even this very basic
case is sufficiently common to handle up to 25% of all text lines on some popular new sites. The decision
which path to use is made per block flow (paragraph).

Simple line layout aims to produce pixel-exact rendering result when compared to the line box layout.

The goal is to handle everything that requires line level access in cases that allow use of simple lines.
This is not quite the case yet. For example selections and outline painting are not supported. In these
cases we seamlessly switch to the line boxes.

The simple line data structure currently uses 12 bytes per line. Lineboxes take ~160 bytes minimum per line.
Laying out the lines is also several times faster as is iterating over them.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:
dom/Position.cpp:

(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::getInlineBoxAndOffset):

Creating positions within a simple line flow causes switch to line boxes.

editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):

TextIterator traverses line boxes if available. In case simple line case we need to replicate the
same results (for compatibility but especially to avoid changing test results). This is done here
by just traversing the string without actually using the layout.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layoutShapeInsideInfo):

rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutInlineChildren):

Select the layout path to use.

(WebCore::RenderBlockFlow::deleteLines):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::firstLineBaseline):
(WebCore::RenderBlockFlow::inlineBlockBaseline):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::clearTruncation):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::hasLines):
(WebCore::RenderBlockFlow::layoutSimpleLines):

Do simple layout.

(WebCore::RenderBlockFlow::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderBlockFlow::ensureLineBoxes):

This function switches from simple lines to line boxes. The switching can be done outside normal layout.
This is used to cover some cases that are not yet supported by simple lines (like selections).

rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::simpleLines):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutLineBoxes):

Rename the line box layout function.

(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):

rendering/RenderText.cpp:

(WebCore::RenderText::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::knownToHaveNoOverflowAndNoFallbackFonts):
(WebCore::RenderText::setSelectionState):
(WebCore::RenderText::setTextWithOffset):
(WebCore::RenderText::ensureLineBoxes):
(WebCore::RenderText::simpleLines):
(WebCore::RenderText::linesBoundingBox):
(WebCore::RenderText::linesVisualOverflowBoundingBox):
(WebCore::RenderText::selectionRectForRepaint):
(WebCore::RenderText::caretMinOffset):
(WebCore::RenderText::caretMaxOffset):
(WebCore::RenderText::countRenderedCharacterOffsetsUntil):
(WebCore::RenderText::containsRenderedCharacterOffset):
(WebCore::RenderText::containsCaretOffset):
(WebCore::RenderText::hasRenderedText):

rendering/RenderText.h:
rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeSimpleLine):
(WebCore::write):

rendering/SimpleLineLayout.cpp: Added.

(WebCore::SimpleLineLayout::canUseFor):

This check for the cases supported by the simple line layout path.

(WebCore::SimpleLineLayout::isWhitespace):
(WebCore::SimpleLineLayout::skipWhitespaces):
(WebCore::SimpleLineLayout::textWidth):
(WebCore::SimpleLineLayout::createLines):

The main layout functions that breaks text to lines. It only handles the cases allowed by
SimpleLineLayout::canUseFor. What it handles it aims to break exactly as line box layout does.

rendering/SimpleLineLayout.h: Added.
rendering/SimpleLineLayoutFunctions.cpp: Added.

(WebCore::SimpleLineLayout::paintFlow):
(WebCore::SimpleLineLayout::hitTestFlow):
(WebCore::SimpleLineLayout::collectFlowOverflow):
(WebCore::SimpleLineLayout::computeTextBoundingBox):

rendering/SimpleLineLayoutFunctions.h: Added.

(WebCore::SimpleLineLayout::computeFlowHeight):
(WebCore::SimpleLineLayout::computeFlowFirstLineBaseline):
(WebCore::SimpleLineLayout::computeFlowLastLineBaseline):
(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):
(WebCore::SimpleLineLayout::lineHeightFromFlow):

Support functions called from RenderBlockFlow and RenderText. They are equivalent to
similar line box functions.

(WebCore::SimpleLineLayout::baselineFromFlow):

rendering/SimpleLineLayoutResolver.h: Added.

(WebCore::SimpleLineLayout::Resolver::Line::Line):
(WebCore::SimpleLineLayout::Resolver::Line::rect):
(WebCore::SimpleLineLayout::Resolver::Line::baseline):
(WebCore::SimpleLineLayout::Resolver::Line::text):
(WebCore::SimpleLineLayout::Resolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator++):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator--):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator==):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator!=):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator*):

Lazy iterator for deriving line metrics. This keeps the line data structure small as
we don't need to keep easily derived values around.

(WebCore::SimpleLineLayout::Resolver::Resolver):
(WebCore::SimpleLineLayout::Resolver::size):
(WebCore::SimpleLineLayout::Resolver::begin):
(WebCore::SimpleLineLayout::Resolver::end):
(WebCore::SimpleLineLayout::Resolver::last):
(WebCore::SimpleLineLayout::Resolver::operator[]):

12:59 PM Changeset in webkit [157949] by g.czajkowski@samsung.com

7 edits in trunk/LayoutTests

dumpAsText() is unnecessarily called in spellchecking tests
https://bugs.webkit.org/show_bug.cgi?id=123266

Reviewed by Darin Adler.

dumpAsText is already called either by notifyDone (js-test-post.js) or
by finishJSTest() when asynchrononous spell checking is used.

editing/spelling/spellcheck-async-mutation.html:
editing/spelling/spellcheck-async.html:
editing/spelling/spellcheck-attribute-expected.txt:
editing/spelling/spellcheck-attribute.html:
editing/spelling/spelling-insert-html.html:
editing/spelling/spelling-unified-emulation.html:

12:53 PM Changeset in webkit [157948] by commit-queue@webkit.org

4 edits
2 adds in trunk

Gaps between underlines in adjacent underlined text runs
https://bugs.webkit.org/show_bug.cgi?id=123236

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-24
Reviewed by Simon Fraser and Darin Adler.

Source/WebCore:

There are two pieces to this change. The first piece is in
InlineTextBox::paint(). We were putting floating-point
extents into a LayoutSize, which simply uses ints (for now),
and then immediately converting this back to a FloatSize.
Instead, we should be using floats throughout all of
this code.

In addition, inside GraphicsContext::drawLineForText(), we are
rounding the underline to pixel boundaries so that it appears
very crisp on the screen. However, we should round once after
performing computations, rather than rounding twice and then
performing computations on the rounded numbers.

Test: fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes.html

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText): Change rounding mode

to perform computations before rounding

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Don't convert to a LayoutSize

just to convert to a FloatSize

LayoutTests:

Added a test that checks that we have accurate precision in our
floating-point computations. We should perform calculations before
rounding, instead of rouding twice and performing calculations on
the rounded values.

fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes.html: Added.
platform/mac/fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes-expected.png: Added.
platform/mac/fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes-expected.txt: Added.

12:39 PM Changeset in webkit [157947] by timothy@apple.com

2 edits in trunk/Source/WebInspectorUI

Adjust the precision of byte strings in Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=123281

Reviewed by Joseph Pecoraro.

UserInterface/Utilities.js:

(Number.bytesToString): More precision for MB and less precision for 10..1023 KB.

12:38 PM Changeset in webkit [157946] by Joseph Pecoraro

2 edits in trunk/LayoutTests

Fix unnecessary alerted value leaking into another test.

Rubber-stamped by Alexey Proskuryakov.

inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html:

12:36 PM Changeset in webkit [157945] by akling@apple.com

10 edits in trunk/Source/WebCore

SVGRenderingContext should wrap a RenderElement.
<https://webkit.org/b/123283>

The SVG rendering context class is never used with text renderers
so we can have it wrap a RenderElement for tighter code.

Also renamed SVGRenderingContext::m_object to m_renderer.

Reviewed by Antti Koivisto.

12:18 PM Changeset in webkit [157944] by commit-queue@webkit.org

3 edits
2 adds in trunk

[contenteditable] Content after non-editable element disappears when merging lines using backspace
https://bugs.webkit.org/show_bug.cgi?id=122748

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-24
Reviewed by Ryosuke Niwa.

Source/WebCore:

In case of paragraph merging after deletion if second paragraph
contains non-editable element, then content after the non-editable
element(including non-editable element) will be removed while the
content before the element will be merged with the first paragraph.
This happens becasue endOfParagraphToMove calculation in merging function
stop at editing boundary so endOfParagraphToMove becomes position just
before non-editable content.
With this patch now endOfParagraphToMove is calculated by skipping
over the non-editable element.

Test: editing/deleting/merge-paragraph-contatining-noneditable.html

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): use CanSkipOverEditingBoundary
condition while calculating endOfParagraphToMove.

LayoutTests:

Adding test to verify that on merging the paragraph containing
non-editable element does not cause loss of non-editable content after
merging.

editing/deleting/merge-paragraph-contatining-noneditable-expected.txt: Added.
editing/deleting/merge-paragraph-contatining-noneditable.html: Added.

12:12 PM Changeset in webkit [157943] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Unreviewed, rolling out r157931.
http://trac.webkit.org/changeset/157931
https://bugs.webkit.org/show_bug.cgi?id=123284

Seems to have caused a lot of assertions on debug bots
(Requested by ap on #webkit).

wtf/text/StringStatics.cpp:

(WTF::StringImpl::empty):

12:10 PM Changeset in webkit [157942] by Antoine Quint

3 edits in trunk/Source/WebCore

Web Inspector: Inspector doesn't show webkitTransitionEnd events in the timeline
https://bugs.webkit.org/show_bug.cgi?id=123263

Reviewed by Timothy Hatcher.

A legacy event type is only set on an event in EventTarget::fireEventListeners(Event*)
which is called after we used to call InspectorInstrumentation::willDispatchEvent(), the method
that would ultimately yield the creation of a TimelineRecord for the event in the Web Inspector
frontend, and as a result we would try to dispatch an event with an unprefixed event type to
the frontend, which wouldn't even happen because most likely it wouldn't have listeners for this
unprefixed type.

We now move the call to InspectorInstrumentation::willDispatchEvent() in
EventTarget::fireEventListeners(Event*, EventTargetData*, EventListenerVector&) such that the
correct event type and list of listeners is used to determine what event to dispatch to the frontend.

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):
Remove calls to InspectorInstrumentation::willDispatchEvent() and InspectorInstrumentation::didDispatchEvent().

dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):
Add call to InspectorInstrumentation::willDispatchEvent() before we go through each listener and
call InspectorInstrumentation::willHandleEvent(). Additionally, we refactor some code since we're
getting references to the ScriptExecutionContext and Document upfront now.

11:58 AM Changeset in webkit [157941] by ap@apple.com

2 edits in trunk/LayoutTests

Layout Test compositing/regions/propagate-region-box-shadow-border-padding-for-video.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123282

platform/mac/TestExpectations: Marking as such.

11:41 AM Changeset in webkit [157940] by akling@apple.com

20 edits in trunk/Source/WebCore

SVG: RenderElement-ize intersectRepaintRectWithResources().
<https://webkit.org/b/123278>

SVGRenderSupport::intersectRepaintRectWithResources() is only ever
called with non-text renderers so make it take RenderElement&.

Had to tweak RenderSVGResource::resourceBoundingBox() to take the
renderer by reference.

Reviewed by Antti Koivisto.

11:22 AM Changeset in webkit [157939] by commit-queue@webkit.org

5 edits
2 adds in trunk

Web Inspector: Breakpoints in sourceURL named scripts do not work
https://bugs.webkit.org/show_bug.cgi?id=123231

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-24
Reviewed by Timothy Hatcher.

Source/WebCore:

Remember a Script's sourceURL and sourceMappingURL. When setting a
breakpoint by URL, check it against the sourceURL or original URL.
If a script had a sourceURL that would have been the only URL sent
to the frontend, so that receives priority.

Test: inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html

inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didParseSource):

inspector/InspectorDebuggerAgent.h:
inspector/ScriptDebugListener.h:

LayoutTests:

inspector-protocol/debugger/setBreakpointByUrl-sourceURL-expected.txt: Added.
inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html: Added.

10:08 AM Changeset in webkit [157938] by Alexandru Chiculita

6 edits
5 adds in trunk

Web Inspector: Add a way to test the Manager and model classes
https://bugs.webkit.org/show_bug.cgi?id=123223

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

Moved some global functions out of Main.js, so that they can be used in the
layout tests without including Main.js.

UserInterface/Main.html: Referenced the new JS files.
UserInterface/Main.js:
UserInterface/MessageDispatcher.js: Added.

(WebInspector.dispatchNextQueuedMessageFromBackend):
(WebInspector.dispatchMessageFromBackend):

UserInterface/URLUtilities.js: Added.

(removeURLFragment):
(relativePath):
(parseURL):
(absoluteURL):
(parseLocationQueryParameters):
(parseQueryString):
(WebInspector.displayNameForURL):
(WebInspector.displayNameForHost):

UserInterface/Utilities.js:

LayoutTests:

Added the first new WebInspector layout test file. The test is using InspectorTest.importInspectorScripts
to bootstrap some of the managers/observers/models from the new WebInspector.

http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.importScript):
(InspectorTest.importInspectorScripts):

inspector-protocol/model/main-frame-resource-expected.txt: Added.
inspector-protocol/model/main-frame-resource.html: Added.

10:05 AM Changeset in webkit [157937] by mark.lam@apple.com

6 edits in trunk/Source/JavaScriptCore

Better way to fix part of broken C Loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=123271.

Reviewed by Geoffrey Garen.

Undoing offline asm hackery.

llint/LowLevelInterpreter.cpp:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
offlineasm/cloop.rb:
offlineasm/instructions.rb:

10:05 AM Changeset in webkit [157936] by ap@apple.com

5 edits
8 adds in trunk/Source/WebCore

Add CryptoKey base class and bindings
https://bugs.webkit.org/show_bug.cgi?id=123216

Reviewed by Sam Weinig.

crypto/CryptoKey.idl: Added.

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.list.am:

Process the IDL.

WebCore.xcodeproj/project.pbxproj: Added files.

bindings/js/JSCryptoKeyCustom.cpp: Added.

(WebCore::JSCryptoKey::algorithm): Use a visitor to build algorithm dictionary
for the key.

crypto/CryptoAlgorithmDescriptionBuilder.cpp: Added.
crypto/CryptoAlgorithmDescriptionBuilder.h: Added.

An interface for a visitor we'll use to expose CrytoKey.algorithm in bindings,
and possibly also for storage serialization. Not complete yet, we'll need support
for a few more simple types, and less trivially, for nested algorithms.

bindings/js/JSCryptoAlgorithmBuilder.cpp: Added.
bindings/js/JSCryptoAlgorithmBuilder.h: Added.

An implementation that builds an algorithm description dictionary for JS bindings.

crypto/CryptoKey.cpp: Added.

(WebCore::CryptoKey::~CryptoKey):
(WebCore::CryptoKey::buildAlgorithmDescription):

crypto/CryptoKey.h: Added.

Added an almost empty implementation. Some of the functions that are currently
marked as pure virtual will likely be implemented in this base class.

9:38 AM Changeset in webkit [157935] by ap@apple.com

2 edits in trunk/LayoutTests

Freshly landed webgl-1.0.1 tests are failing.

platform/mac/TestExpectations: Correcting a late-night typo in TetExpectations.

It's [Failure], not [Fail].

9:35 AM Changeset in webkit [157934] by commit-queue@webkit.org

4 edits
1 delete in trunk

Unreviewed, rolling out r157916.
http://trac.webkit.org/changeset/157916
https://bugs.webkit.org/show_bug.cgi?id=123274

Broke Layout/flexbox-lots-of-data.html on perfbot (Requested
by ap on #webkit).

PerformanceTests:

Layout/flexbox-lots-of-data.html: Removed.

Source/WebCore:

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::OrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::isDeletedValue):
(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):

rendering/RenderFlexibleBox.h:

9:22 AM Changeset in webkit [157933] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Comment in ScopedEventQueue::dispatchEvent is unnecessarily verbose
https://bugs.webkit.org/show_bug.cgi?id=123252

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-10-24
Reviewed by Darin Adler.

Shorten the comment about the crash avoidance in ScopedEventQueue::dispatchEvent due to
the calling convention in C++ is left unspecified. The problem was already fixed in r157219
and later adjusted in r157401, but the comment could have been shorter and simpler in both cases.

dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::dispatchEvent):

9:10 AM Changeset in webkit [157932] by mark.lam@apple.com

11 edits in trunk/Source/JavaScriptCore

Fix broken C Loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=123271.

Reviewed by Michael Saboff.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus): Added an UNUSED_PARAM().
(JSC::CodeBlock::dumpBytecode): Added #if ENABLE(JIT) to JIT only code.

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor): Added an UNUSED_PARAM().

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor): Added an UNUSED_PARAM().

bytecode/StructureStubInfo.h:
Added a stub StubInfoMap for non-JIT builds. StubInfoMap is still used in function prototypes even when !ENABLE(JIT). Rather that adding #if's in many places, we just provide a stub/placeholder implementation that is unused but keeps the compiler happy.
jit/JITOperations.h: Added #if ENABLE(JIT).
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
The putByVal() macro reifies a slow path which is never taken in one case. This translates into a label that is never used in the C Loop LLINT. The C++ compiler doesn't like unused labels. So, we fix this by adding a cloopUnusedLabel offline asm instruction that synthesizes the following:

if (false) goto unusedLabel;

This keeps the C++ compiler happy without changing code behavior.

offlineasm/cloop.rb: Implementing cloopUnusedLabel.
offlineasm/instructions.rb: Declaring cloopUnusedLabel.
runtime/Executable.cpp:

(JSC::setupJIT): Added UNUSED_PARAM()s.
(JSC::ScriptExecutable::prepareForExecutionImpl):

run-javascriptcore-tests have phases that forces the LLINT to be off which in turn asserts that the JIT is enabled. With the C Loop LLINT, this combination is illegal. So, we override the setup code here to always use the LLINT if !ENABLE(JIT) regardless of what options are passed in.

9:09 AM Changeset in webkit [157931] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Remove PCRE workaround.
https://bugs.webkit.org/show_bug.cgi?id=123265

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Darin Adler.

wtf/text/StringStatics.cpp:

(WTF::StringImpl::empty):

9:06 AM Changeset in webkit [157930] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Uninitialized member causes crash when DFG JIT is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=123270

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-24
Reviewed by Brent Fulgham.

The data member sizeOfLastScratchBuffer in the VM class is only initialized if DFG JIT is enabled, even though it's defined regardless.
This causes an early crash on Windows, which doesn't have DFG JIT enabled.

runtime/VM.cpp:

(JSC::VM::VM): Initialize sizeOfLastScratchBuffer member regardless of whether DFG JIT is enabled.

9:00 AM Changeset in webkit [157929] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

[GTK] Disable css-image-orientation
https://bugs.webkit.org/show_bug.cgi?id=123257

Reviewed by Martin Robinson.

CSS image orientation isn't stable yet. So, test regression happen since r157909.
This feature should be enabled again after it is stable.

Scripts/webkitperl/FeatureList.pm:

7:32 AM Changeset in webkit [157928] by commit-queue@webkit.org

3 edits
3 deletes in trunk/Source/WebCore

Removed unused ThreadSafeCoordinatedSurface and CertificateInfoCurl files.
https://bugs.webkit.org/show_bug.cgi?id=123246

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-24
Reviewed by Noam Rosenthal.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:

Removed references to ThreadSafeCoordinatedSurface and CertificateInfoCurl.

platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Removed.
platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Removed.
platform/network/curl/CertificateInfoCurl.cpp: Removed.

7:27 AM Changeset in webkit [157927] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Remove Clang workaround.
https://bugs.webkit.org/show_bug.cgi?id=123262

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Anders Carlsson.

wtf/CheckedArithmetic.h:

(WTF::Checked::Checked):

6:30 AM Changeset in webkit [157926] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Removed Qt workaround.
https://bugs.webkit.org/show_bug.cgi?id=123258

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Csaba Osztrogonác.

No change of functionality, no new tests needed.

!$defines case can be removed, because Qt and Android aren't in WebKit trunk,
all ports (Mac,EFL,GTK,Windows) call this script with --defines option now

css/make-css-file-arrays.pl:

6:28 AM Changeset in webkit [157925] by Antti Koivisto

2 edits in trunk/Source/WebCore

Remove a stray space.

Not reviewed.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addImageMapChildren):

6:26 AM Changeset in webkit [157924] by Antti Koivisto

49 edits in trunk/Source/WebCore

Element iterator functions should take reference
https://bugs.webkit.org/show_bug.cgi?id=123267

Reviewed by Andreas Kling.

The argument has to be non-null.

5:26 AM Changeset in webkit [157923] by commit-queue@webkit.org

3 edits in trunk/Tools

Fix argument passing for jhbuild.
https://bugs.webkit.org/show_bug.cgi?id=123253

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Gustavo Noronha Silva.

The update-webkit-libs-jhbuild previously didn't allowed
extra arguments to be passed to jhbuild.

Scripts/update-webkit-libs-jhbuild:

(runJhbuild):

Scripts/update-webkitefl-libs:

4:41 AM Changeset in webkit [157922] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
https://bugs.webkit.org/show_bug.cgi?id=123251

Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-10-24
Reviewed by Csaba Osztrogonác.

Replace %llu by PRIu64 macro to print an uint64_t value and silent a
compilation warning on 64-Bit.

DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededDatabaseQuota):

3:26 AM Changeset in webkit [157921] by commit-queue@webkit.org

2 edits
3 adds in trunk/LayoutTests

[GTK] Removing flags for tests fixed in bug 121828
https://bugs.webkit.org/show_bug.cgi?id=122967

Unreviewed GTK gardening. Rebaselining after r156767.

Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-10-24

platform/gtk/TestExpectations:
platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.

3:01 AM Changeset in webkit [157920] by ryuan.choi@samsung.com

21 edits in trunk

[EFL] Build break with latest EFL 1.8 libraries.
https://bugs.webkit.org/show_bug.cgi?id=123245

Reviewed by Gyuyoung Kim.

After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
Eo typedef and splitted header files which contain version macro.

Source/cmake/EFLHelpers.cmake: Checked whether include path exist.
Source/cmake/FindEcore.cmake: Added 1.8 Header which have version macro.
Source/cmake/FindEdje.cmake: Ditto.
Source/cmake/FindEina.cmake: Ditto.
Source/cmake/FindEo.cmake: Ditto.
Source/cmake/FindEvas.cmake: Ditto.

Source/JavaScriptCore:

PlatformEfl.cmake: Added EO path to include directories.
heap/HeapTimer.h: Changed Ecore_Timer typedef when EO exist.

Source/WebCore:

platform/Widget.h: Changed Eo typedef.
platform/efl/EflScreenUtilities.h: Ditto.
platform/graphics/Image.h: Ditto.

Source/WTF:

wtf/OwnPtrCommon.h: Changed Eo typedef.
wtf/efl/RefPtrEfl.h: Ditto.

Tools:

TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
WebKitTestRunner/PlatformWebView.h: Ditto.

2:59 AM Changeset in webkit [157919] by akling@apple.com

6 edits in trunk/Source/WebCore

RenderSVGResource: Pass RenderElement to fill/strokePaintingResource.
<https://webkit.org/b/123242>

We never pass text renderers to these functions, so make them take
RenderElement instead.

Reviewed by Anders Carlsson.

2:08 AM Changeset in webkit [157918] by Carlos Garcia Campos

14 edits in trunk

[GObject bindings] Make EventTarget interface introspectable
https://bugs.webkit.org/show_bug.cgi?id=77835

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to be
used by GObject instrospection bindings. Instead of receving a
GCallback, which makes the function not introspectable, they
receive a GClosure.

bindings/gobject/GObjectEventListener.cpp:

(WebCore::GObjectEventListener::GObjectEventListener):
(WebCore::GObjectEventListener::~GObjectEventListener):
(WebCore::GObjectEventListener::gobjectDestroyed):
(WebCore::GObjectEventListener::handleEvent):
(WebCore::GObjectEventListener::operator==):

bindings/gobject/GObjectEventListener.h:

(WebCore::GObjectEventListener::addEventListener):
(WebCore::GObjectEventListener::removeEventListener):

bindings/gobject/WebKitDOMEventTarget.cpp:

(webkit_dom_event_target_dispatch_event):
(webkit_dom_event_target_add_event_listener):
(webkit_dom_event_target_remove_event_listener):
(webkit_dom_event_target_add_event_listener_with_closure):
(webkit_dom_event_target_remove_event_listener_with_closure):

bindings/gobject/WebKitDOMEventTarget.h:
bindings/scripts/CodeGeneratorGObject.pm:

(GenerateEventTargetIface):

bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(webkit_dom_test_event_target_dispatch_event):
(webkit_dom_test_event_target_add_event_listener):
(webkit_dom_test_event_target_remove_event_listener):

bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(webkit_dom_test_node_dispatch_event):
(webkit_dom_test_node_add_event_listener):
(webkit_dom_test_node_remove_event_listener):

Source/WTF:

Add support for use GRefPtr with GClosure.

wtf/gobject/GRefPtr.cpp:

(WTF::refGPtr):
(WTF::derefGPtr):

wtf/gobject/GRefPtr.h:
wtf/gobject/GTypedefs.h:

Tools:

Scripts/webkitpy/style/checker.py: Add exceptions for custom

GObject DOM bindings headers.

12:10 AM Changeset in webkit [157917] by ap@apple.com

357 edits
25 deletes in trunk/LayoutTests

Revert <http://trac.webkit.org/changeset/157893>
(Mavericks test results mega-patch).

It didn't fix Mavericks, which still has dozens of failures, and it broke Mountain
Lion bots, which need to remain green for tools like EWS to work.

At a glance, there are multiple systemic issues with this change:

some results went to broken locations like platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png;
WK2 expectations also went to platform/mac/platform/mac-wk2/TestExpectations.
some tests like js/dom/global-constructors-attributes.html used to match cross-platform

baseline, but copying Mavericks results over to platform/mac made it so that those results
are now ignored on Mountain Lion.

I think that starting over will be easier that fixing these issues incrementally.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed