⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 26, 2013:

7:36 PM Changeset in webkit [158096] by timothy_horton@apple.com
  • 8 edits in trunk/Source

[mac] Remove WebTiledLayer
​https://bugs.webkit.org/show_bug.cgi?id=123395

Reviewed by Anders Carlsson.

Source/WebCore:

Mac doesn't use CATiledLayer at all anymore. We have to keep
LayerTypeTiledLayer around for Windows, for now, but we can
get rid of WebTiledLayer and some related Mac-specific code.

No new tests, just removing dead code.

  • WebCore.xcodeproj/project.pbxproj:

Remove WebTiledLayer.*

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::PlatformCALayerMac):
Remove synchronouslyDisplayTilesInRect, which was only used for WebTiledLayer on Mac.
Remove WebTiledLayer instantiation and setup code.

  • platform/graphics/mac/WebTiledLayer.h: Removed.
  • platform/graphics/mac/WebTiledLayer.mm: Removed.

Source/WebKit2:

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Remove synchronouslyDisplayTilesInRect.

5:48 PM Changeset in webkit [158095] by rniwa@webkit.org
  • 4 edits in trunk/Websites/test-results

Make new bug link in flakiness dashboard configurable
​https://bugs.webkit.org/show_bug.cgi?id=123386

Reviewed by Alexey Proskuryakov.

  • config.json: Added Bugzilla as the default destination for new bugs.
  • public/api/manifest.php: Include newBugLinks in the manifest.
  • public/index.html:

(TestResultsView): Initialize _newBugLinks.
(TestResultsView.setNewBugLinks): Added.
(TestResultsView._populateTestPane):
(TestResultsView._createTestResultRow): Replaced the hard-coded Bugzilla URL by the code
to generate hyper-links based on _newBugLinks. Also added a nullity check while formatting
revision checks so that we don't blow up when some build doesn't contain all revision info.
(TestResultsView._populateBuilderPane):

5:48 PM Changeset in webkit [158094] by rniwa@webkit.org
  • 3 edits in trunk/Websites/test-results

New flakiness dashboard should support substring matching
​https://bugs.webkit.org/show_bug.cgi?id=123393

Reviewed by Alexey Proskuryakov.

Addressed the use cases by

  1. Always showing the candidate even when there is exactly one test matching the current value.
  2. Adding all tests that match the current value upon the user pressing enter key.
  • public/index.html:

(fetchManifest): Add all tests that match the current value. Confirm whether the user really
want to add all the tests when there are more than 15 tests to add.

  • public/js/autocompleter.js:

(Autocompleter.prototype.filterCandidates): Extracted from _updateCandidates.
(Autocompleter.prototype._updateCandidates): Show the candidate window even when there is
exactly one test that matches the criteria so that the user can select this test.

5:47 PM Changeset in webkit [158093] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

New flakiness dashboard shouldn't treat tests with right expectations as failing
​https://bugs.webkit.org/show_bug.cgi?id=123385

Reviewed by Alexey Proskuryakov.

We define failing tests to be tests with wrong expectations whose actual results are not PASS
since tests with TEXT, IMAGE, etc... failures do not turn the bots red as long as the expectation
of the same type is specified in TestExpectation files.

  • public/include/test-results.php:

(FailingResultsJSONWriter): Inherit from WrongExpectationsResultsJSONWriter.

1:42 PM Changeset in webkit [158092] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Crashy WebGL test is crashy.

  • platform/mac/TestExpectations:
1:23 PM Changeset in webkit [158091] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] -[WKBackForwardList forwardItem] returns the back item
​https://bugs.webkit.org/show_bug.cgi?id=123391

Reviewed by Mark Rowe.

  • UIProcess/Cocoa/WKBackForwardList.mm:

(-[WKBackForwardList forwardItem]): Changed back to forward.

11:59 AM Changeset in webkit [158090] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: RenderImageResourceStyleImage always has a StyleImage.
<​https://webkit.org/b/123390>

Codify the fact that RenderImageResourceStyleImage always wraps an
existing StyleImage object.

Reviewed by Antti Koivisto.

11:45 AM Changeset in webkit [158089] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Skip two WebGL tests that either crash or fail.

  • platform/mac/TestExpectations:
11:39 AM Changeset in webkit [158088] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Revert some accidental changes.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontSelector.cpp:
  • css/CSSFontSelector.h:
10:09 AM Changeset in webkit [158087] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Unreviewed, rolling out r158075.
​http://trac.webkit.org/changeset/158075
​https://bugs.webkit.org/show_bug.cgi?id=123389

Broke WebKit2.PrivateBrowsingPushStateNoHistoryCallback API
test (Requested by ap on #webkit).

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::willStartUsingPrivateBrowsing):
(WebKit::WebContext::willStopUsingPrivateBrowsing):

  • UIProcess/WebContext.h:
  • UIProcess/WebIconDatabase.cpp:
  • UIProcess/WebIconDatabase.h:
9:11 AM Changeset in webkit [158086] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

Gardening: fixed broken build.
​https://bugs.webkit.org/show_bug.cgi?id=123354.

  • css/CSSFontSelector.h:
8:44 AM Changeset in webkit [158085] by Antti Koivisto
  • 7 edits in trunk

Source/WebCore: fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
​https://bugs.webkit.org/show_bug.cgi?id=123354

Reviewed by Andreas Kling.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

Don't enable simple line layout if the primary font is loading. The code expects
to use the primary font metrics for all lines but those won't match the fallbacks
when font is not loaded.

LayoutTests: fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
​https://bugs.webkit.org/show_bug.cgi?id=123354

Reviewed by Andreas Kling.

8:17 AM Changeset in webkit [158084] by jae.park@company100.net
  • 2 edits in trunk/Source/WebKit2

Remove Coordinated Graphics bits from DrawingAreaProxyImpl
​https://bugs.webkit.org/show_bug.cgi?id=123382

Reviewed by Anders Carlsson.

As of r156861, Coordinated Graphics does not use DrawingAreaProxyImpl.
So, Coordinated Graphics bits should be removed from DrawingAreaProxyImpl.

  • UIProcess/DrawingAreaProxyImpl.h:
4:02 AM Changeset in webkit [158083] by Carlos Garcia Campos
  • 14 edits in trunk/Source/WebCore

[GTK] Deprecate public dispatch_event method in objects implementing EventTarget interface
​https://bugs.webkit.org/show_bug.cgi?id=123261

Reviewed by Gustavo Noronha Silva.

The interface function should be used instead.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetFunctionDeprecationInformation): Helper function to return the
version when the function was deprecated and the function
replacing the deprecated one.
(GenerateFunction): Check if the function is deprecated to mark it
as such in the header and API docs.

  • bindings/scripts/gobject-generate-headers.pl: Replace the unused

WEBKIT_OBSOLETE_API macro with new macros to mark function as
deprecated, using the glib macros so that we don't need checks for
the platform.

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
  • bindings/scripts/test/GObject/WebKitDOMTestException.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
  • bindings/scripts/test/GObject/WebKitDOMattribute.h:
12:16 AM Changeset in webkit [158082] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] clang static analyzer warns about object being autoreleased too many times in +[WKNSArray web_arrayWithImmutableArray:]
​https://bugs.webkit.org/show_bug.cgi?id=123384

Reviewed by Mark Rowe.

  • Shared/Cocoa/WKNSArray.h: Annotated -web_initWithImmutableArray: as an init method.

Oct 25, 2013:

11:37 PM Changeset in webkit [158081] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

Fix the ENABLE(CSS_FILTERS) && USE(COORDINATED_GRAPHICS) build after r157803
​https://bugs.webkit.org/show_bug.cgi?id=123330

Reviewed by Darin Adler.

  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
11:13 PM Changeset in webkit [158080] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

Build fix. The query results weren't sorted by the latest commit time,
yielding wrong set of tests to be listed in the builder pane.

  • public/include/test-results.php:
10:50 PM Changeset in webkit [158079] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

Links in new flakiness dashboard could benefit from tooltips
​https://bugs.webkit.org/show_bug.cgi?id=123381

Reviewed by Alexey Proskuryakov.

Add title content attribute on each hyperlink in the builder pane.

  • public/index.html:

(TestResultsView._populateBuilderPane):

10:41 PM Changeset in webkit [158078] by ap@apple.com
  • 2 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

REGRESSION (r158069): platform/mac/fast/loader/file-url-mimetypes.html
is failing on all Mountain Lion bots.

  • platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt: Removed.
  • platform/mac-mountainlion/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from LayoutTests/platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt.

Mountain Lion results for platform/mac tests need to be in this crazy place apparently.

  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Removed.

Mavericks results should be in platform/mac, not platform/mac/platform/mac.
Yes, the latter works and takes precedence, but it's wrong.

6:23 PM Changeset in webkit [158077] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

Commit the right change.

  • public/index.html:
6:19 PM Changeset in webkit [158076] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

The new flakiness dashboard should sort builder and test names
​https://bugs.webkit.org/show_bug.cgi?id=123363

Reviewed by Simon Fraser.

Sort the forgotten builders in the menu.

  • public/index.html:
5:29 PM Changeset in webkit [158075] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

WebIconDatabase can miss private browsing state changes.
<rdar://problem/15322318> and ​https://bugs.webkit.org/show_bug.cgi?id=123375

Reviewed by Beth Dakin.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::willStartUsingPrivateBrowsing): Call setPrivateBrowsingEnabled(true) on each context.
(WebKit::WebContext::willStopUsingPrivateBrowsing): Call setPrivateBrowsingEnabled(false) on each context.
(WebKit::WebContext::setPrivateBrowsingEnabled): In addition to notifying other processes, notify WebIconDatabase.

  • UIProcess/WebContext.h:
  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setPrivateBrowsingEnabled):

  • UIProcess/WebIconDatabase.h:
5:25 PM Changeset in webkit [158074] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Refactor parser rollback logic
​https://bugs.webkit.org/show_bug.cgi?id=123372

Reviewed by Brady Eidson.

Add a sane abstraction for rollbacks in the parser.

  • parser/Parser.cpp:

(JSC::::parseSourceElements):
(JSC::::parseObjectLiteral):

  • parser/Parser.h:

(JSC::Parser::createSavePoint):
(JSC::Parser::restoreSavePoint):

5:02 PM Changeset in webkit [158073] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r156315. <rdar://problem/15109335>

4:53 PM Changeset in webkit [158072] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: PrettyPrinting tool should have save button
​https://bugs.webkit.org/show_bug.cgi?id=123371

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-25
Reviewed by Timothy Hatcher.

Add buttons to save as a URL to share or to save/clear to
localStorage for easier reloads testing local changes.

  • Tools/PrettyPrinting/index.html:
4:46 PM Changeset in webkit [158071] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Tweak some test expectations.

  • platform/mac/TestExpectations:
4:35 PM Changeset in webkit [158070] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Mark skipped webgl conformance tests as either flakey or failures.

Also reorganize expectations for WebGL a bit.

  • platform/mac/TestExpectations:
4:33 PM Changeset in webkit [158069] by Simon Fraser
  • 2 edits
    1 copy
    8 adds in trunk/LayoutTests

Add Mavericks-specific results for some tests.

  • platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/mac-mountainlion/http/tests/xmlhttprequest/head-redirection-expected.txt: Copied from LayoutTests/platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt.
  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Added.
  • platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
  • platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
4:29 PM Changeset in webkit [158068] by Lucas Forschler
  • 3 edits
    3 copies
    2 adds in branches/safari-537.73-branch

Merged r156214. <rdar://problem/15109485>

4:22 PM Changeset in webkit [158067] by Lucas Forschler
  • 7 edits
    2 copies in branches/safari-537.73-branch

Merged r155665. <rdar://problem/15109475>

4:16 PM Changeset in webkit [158066] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark some CSS filters and SVG ref tests as failing, and two WebGL tests are flakey.

  • platform/mac/TestExpectations:
4:03 PM Changeset in webkit [158065] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537.73-branch

Merged r155608. <rdar://problem/15109361>

3:52 PM Changeset in webkit [158064] by Simon Fraser
  • 2 edits
    1 copy
    8 adds in trunk/LayoutTests

Mavericks results with MountainLion variants.

  • platform/mac-mountainlion/fast/repaint/search-field-cancel-expected.txt: Added.
  • platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt.
  • platform/mac-mountainlion/fast/text/international/cjk-segmentation-expected.txt: Added.
  • platform/mac/fast/repaint/search-field-cancel-expected.txt: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/mac/fast/text/international/cjk-segmentation-expected.txt: Added.
  • platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
  • platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
3:45 PM Changeset in webkit [158063] by Lucas Forschler
  • 3 edits
    4 copies in branches/safari-537.73-branch

Merged r155546. <rdar://problem/15109351>

3:24 PM Changeset in webkit [158062] by Alexandru Chiculita
  • 2 edits
    2 adds in trunk/LayoutTests

Web Inspector: CSS Regions: Add layout tests for the new events in the DOMTreeManager
​https://bugs.webkit.org/show_bug.cgi?id=123361

Reviewed by Timothy Hatcher.

Created a test to check that WebInspector.DOMTree.Event.ContentFlowWasAdded and
WebInspector.DOMTree.Event.ContentFlowWasRemoved are dispatched when a flow is added
and removed.

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.assert): Similar to InspectorTest.log, but also takes a boolean and prefixes the message
with "FAIL" or "PASS" depending on the value.
(InspectorTest.importInspectorScripts): Added the required CSS Agent scripts to enable the flow thread events.

  • inspector-protocol/model/content-flow-list-expected.txt: Added.
  • inspector-protocol/model/content-flow-list.html: Added.
3:23 PM Changeset in webkit [158061] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Command+Click on url(…) should go to image not source line
​https://bugs.webkit.org/show_bug.cgi?id=123362

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-25
Reviewed by Timothy Hatcher.

CodeMirror changed "url" from being type "variable-2" to "string-2".

  • UserInterface/CodeMirrorAdditions.js:
3:10 PM Changeset in webkit [158060] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r155468.

3:08 PM Changeset in webkit [158059] by Lucas Forschler
  • 8 edits
    4 copies in branches/safari-537.73-branch

Merged r155461. <rdar://problem/15109345>

3:03 PM Changeset in webkit [158058] by mark.lam@apple.com
  • 3 edits in trunk/Source/WebCore

DatabaseManager's ProposedDatabases need to be thread-safe.
​https://bugs.webkit.org/show_bug.cgi?id=123313.

Reviewed by Geoffrey Garen.

No new tests.

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):

  • Modules/webdatabase/DatabaseManager.h:
3:01 PM Changeset in webkit [158057] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[Win] Javascript crash with DFG JIT enabled.
​https://bugs.webkit.org/show_bug.cgi?id=121001

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-25
Reviewed by Geoffrey Garen.

On windows, using register GPRInfo::regT0 as parameter to e.g. JIT::storeDouble(..., GPRInfo::regT0)),
results in a call to JIT::storeDouble(FPRegisterID src, const void* address),
where the address parameter gets the value of GPRInfo::regT0, which is 0 (eax on Windows).
This causes the register to be written to address 0, hence the crash.

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::storeDouble): Assert if we try to generate code which writes to a null pointer.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit): Use address in regT0 as parameter.

  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator): Ditto.

3:01 PM Changeset in webkit [158056] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

The new flakiness dashboard should sort builder and test names
​https://bugs.webkit.org/show_bug.cgi?id=123363

Reviewed by Simon Fraser.

Sort builders and tests by their name in each pane.

  • public/index.html:

(TestResultsView._populateTestPane): Lexicologically sort builders by their name.
(TestResultsView._sortObjectsByName): Added.
(TestResultsView._populateBuilderPane): Lexicologically sort builders by their name.

2:57 PM Changeset in webkit [158055] by rniwa@webkit.org
  • 4 edits in trunk/Websites/test-results

Merge revision columns in flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=123360

Reviewed by Simon Fraser.

Merge revision numbers into one cell separated by /, and clearly label them as "latest revisions".
Also add colors for missing & audio failures so that they won't be an empty cell.

  • public/index.html:

(TestResultsView._createTestResultHeader): Create a single th for the list of repository names.
(TestResultsView._createTestResultRow): Use single td for all revision numbers.

  • public/js/build.js:

(.this.formattedRevision): Don't prefix revision numbers with '@' when we're not in the tooltip.

  • public/main.css:

(.resultsTable .AUDIO a): Added.
(.resultsTable .MISSING a): Added.

2:54 PM Changeset in webkit [158054] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/Source/WebKit/win

Merged r155212. <rdar://problem/15109471>

2:51 PM Changeset in webkit [158053] by Lucas Forschler
  • 4 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r155153. <rdar://problem/15109457>

2:32 PM Changeset in webkit [158052] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r155127. <rdar://problem/15109454>

2:31 PM Changeset in webkit [158051] by oliver@apple.com
  • 7 edits in trunk

Fix a number of problems with destructuring of arguments
​https://bugs.webkit.org/show_bug.cgi?id=123357

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This renames the destructuring node's emitBytecode to bindValue
in order to remove the existing confusion over what was happening.

We then fix an incorrect fall through in the destructuring arguments
logic, and fix the then exposed bug where we placed the index rather
than value into the bound property.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::DeconstructingAssignmentNode::emitBytecode):
(JSC::ArrayPatternNode::bindValue):
(JSC::ArrayPatternNode::emitDirectBinding):
(JSC::ObjectPatternNode::bindValue):
(JSC::BindingNode::bindValue):

  • parser/Nodes.h:

LayoutTests:

Add additional testing

  • js/destructuring-assignment-expected.txt:
  • js/script-tests/destructuring-assignment.js:
1:59 PM Changeset in webkit [158050] by Joseph Pecoraro
  • 25 edits
    16 adds in trunk/Source

Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac
​https://bugs.webkit.org/show_bug.cgi?id=123111

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/ios:

iOS does not have a local inspector, only remote. So give it a custom
implementation separate from the WebKit/mac WebInspectorClient
implementation which handles an attaching/detaching local inspector.

  • WebKit.xcodeproj/project.pbxproj:
  • ios/WebCoreSupport/WebInspectorClientIOS.mm: Added.

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::bringFrontendToFront):
(WebInspectorClient::closeInspectorFrontend):
(WebInspectorClient::didResizeMainFrame):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorClient::didSetSearchingForNode):
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::sendMessageToBackend):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):
(WebInspectorClient::hasLocalSession):
(WebInspectorClient::canBeRemotelyInspected):
(WebInspectorClient::inspectedWebView):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::attachAvailabilityChanged):
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::localizedStringsURL):
(WebInspectorFrontendClient::bringToFront):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::setAttachedWindowHeight):
(WebInspectorFrontendClient::setAttachedWindowWidth):
(WebInspectorFrontendClient::setToolbarHeight):
(WebInspectorFrontendClient::inspectedURLChanged):
(WebInspectorFrontendClient::updateWindowTitle):
(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):

Source/WebKit/mac:

The actual implementation at the WebCoreSupport/WebInspectorClient level
is the same as INSPECTOR_SERVER. Give debuggable pages a pageIdentifer.

  • Configurations/FeatureDefines.xcconfig:
  • Misc/WebKitLogging.h:

Misc.

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::pageId):
(WebInspectorClient::setPageId):
Give WebInspectorClient's a page identifier.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::sendMessageToBackend):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):
(WebInspectorClient::hasLocalSession):
(WebInspectorClient::canBeRemotelyInspected):
(WebInspectorClient::inspectedWebView):
A WebInspectorClient can be either local or remote. Add handling
for remote connections.

(+[WebInspectorClientRegistry sharedRegistry]):
(-[WebInspectorClientRegistry init]):
(-[WebInspectorClientRegistry _getNextAvailablePageId]):
(-[WebInspectorClientRegistry registerClient:]):
(-[WebInspectorClientRegistry unregisterClient:]):
(-[WebInspectorClientRegistry clientForPageId:]):
(-[WebInspectorClientRegistry inspectableWebViews]):
Registry for all potentially debuggable pages. All WebInspectorClient instances.

Constants (message keys) shared between WebKit and the XPC process.

(-[WebInspectorServer init]):
(-[WebInspectorServer dealloc]):
(-[WebInspectorServer start]):
(-[WebInspectorServer stop]):
(-[WebInspectorServer isEnabled]):
(-[WebInspectorServer xpcConnection]):
(-[WebInspectorServer setupXPCConnectionIfNeeded]):
(-[WebInspectorServer pushListing]):
(-[WebInspectorServer hasActiveDebugSession]):
(-[WebInspectorServer setHasActiveDebugSession:]):
(-[WebInspectorServer xpcConnection:receivedMessage:userInfo:]):
(-[WebInspectorServer xpcConnectionFailed:]):
(-[WebInspectorServer didRegisterClient:]):
(-[WebInspectorServer didUnregisterClient:]):
Singleton to start/stop remote inspection. Handles the connection to the XPC
and hands off connections to the connection controller.

  • WebInspector/remote/WebInspectorServerWebViewConnection.h: Added.
  • WebInspector/remote/WebInspectorServerWebViewConnection.mm: Added.

(-[WebInspectorServerWebViewConnection initWithController:connectionIdentifier:destination:identifier:]):
(-[WebInspectorServerWebViewConnection setupChannel]):
(-[WebInspectorServerWebViewConnection dealloc]):
(-[WebInspectorServerWebViewConnection connectionIdentifier]):
(-[WebInspectorServerWebViewConnection identifier]):
(-[WebInspectorServerWebViewConnection clearChannel]):
(-[WebInspectorServerWebViewConnection sendMessageToFrontend:]):
(-[WebInspectorServerWebViewConnection sendMessageToBackend:]):
(-[WebInspectorServerWebViewConnection receivedData:]):
(-[WebInspectorServerWebViewConnection receivedDidClose:]):
An individual remote debug session connection.

  • WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Added.
  • WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Added.

(-[WebInspectorServerWebViewConnectionController initWithServer:]):
(-[WebInspectorServerWebViewConnectionController dealloc]):
(-[WebInspectorServerWebViewConnectionController closeAllConnections]):
(-[WebInspectorServerWebViewConnectionController _listingForWebView:pageId:registry:]):
(-[WebInspectorServerWebViewConnectionController _pushListing:]):
(-[WebInspectorServerWebViewConnectionController pushListing:]):
(-[WebInspectorServerWebViewConnectionController pushListing]):
(-[WebInspectorServerWebViewConnectionController _receivedSetup:]):
(-[WebInspectorServerWebViewConnectionController _receivedData:]):
(-[WebInspectorServerWebViewConnectionController _receivedDidClose:]):
(-[WebInspectorServerWebViewConnectionController _receivedGetListing:]):
(-[WebInspectorServerWebViewConnectionController _receivedIndicate:]):
(-[WebInspectorServerWebViewConnectionController _receivedConnectionDied:]):
(-[WebInspectorServerWebViewConnectionController receivedMessage:userInfo:]):
(-[WebInspectorServerWebViewConnectionController connectionClosing:]):
(-[WebInspectorServerWebViewConnectionController sendMessageToFrontend:userInfo:]):
ConnectionController:

  • Holds all the current ongoing remote debug connections.
  • Simplifies multi-threaded work on iOS.
  • Dispatches incoming messages from the remote connection.

(+[WebInspectorRemoteChannel createChannelForPageId:connection:]):
(-[WebInspectorRemoteChannel initWithRemote:local:]):
(-[WebInspectorRemoteChannel closeFromLocalSide]):
(-[WebInspectorRemoteChannel closeFromRemoteSide]):
(-[WebInspectorRemoteChannel sendMessageToFrontend:]):
(-[WebInspectorRemoteChannel sendMessageToBackend:]):
Thin interface between the remote connection and web inspector client.
This simplifies breaking the connection from either side, e.g. the
page closing, or the remote connection disconnecting.

(-[WebInspectorXPCWrapper initWithConnection:]):
(-[WebInspectorXPCWrapper close]):
(-[WebInspectorXPCWrapper dealloc]):
(-[WebInspectorXPCWrapper _deserializeMessage:]):
(-[WebInspectorXPCWrapper _handleEvent:]):
(-[WebInspectorXPCWrapper sendMessage:userInfo:]):
(-[WebInspectorXPCWrapper available]):

  • WebKit.exp:

XPC Connection wrapper handling a simple message format.

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):
(-[WebViewPrivate dealloc]):

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView sharedWebInspectorServer]):
(+[WebView _enableRemoteInspector]):
(+[WebView _disableRemoteInspector]):
(+[WebView _disableAutoStartRemoteInspector]):
(+[WebView _isRemoteInspectorEnabled]):
(+[WebView _hasRemoteInspectorSession]):
(-[WebView canBeRemotelyInspected]):
(-[WebView allowsRemoteInspection]):
(-[WebView setAllowsRemoteInspection:]):
(-[WebView setIndicatingForRemoteInspector:]):
(-[WebView setRemoteInspectorUserInfo:]):
(-[WebView remoteInspectorUserInfo]):
Remote inspector private API.

  • Enable / disable globally
  • Allow / disallow per webview
  • Optionally attach a userInfo dictionary on the WebView that is published with listing.
  • Indicate a WebView (implementation to land later)

(-[WebView _didCommitLoadForFrame:]):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidReceiveTitle):
Pages changed, pushed page listing.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:
1:41 PM Changeset in webkit [158049] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Tools

Merged r157995.

1:40 PM Changeset in webkit [158048] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Tools

Merged r157815.

1:39 PM Changeset in webkit [158047] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Tools

Merged r157687.

1:38 PM Changeset in webkit [158046] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Tools

Merged r157553.

1:37 PM Changeset in webkit [158045] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Tools

Merged r154450.

1:36 PM Changeset in webkit [158044] by hmuller@adobe.com
  • 12 edits
    3 adds
    2 deletes in trunk

[CSS Shapes] CORS-enabled fetch for shape image values
​https://bugs.webkit.org/show_bug.cgi?id=123114

Reviewed by Andreas Kling.

Source/WebCore:

Access to shape images is now controlled by CORS CSS shape per
​http://dev.w3.org/csswg/css-shapes/#shape-outside-property.
Previously shape images had to be same-origin.

Shape image URL access is defined by the same logic that defines
canvas tainting: same-origin and data URLs are allowed and images
with a "Access-Control-Allow-Origin:" header that's either "*" or
that matches the document's origin.

A PotentiallyCrossOriginEnabled RequestOriginPolicy was added to
ResourceLoaderOptions, to indicate that a "potentially CORS-enabled fetch"
was to be undertaken. The CSSImageValue::cachedImage() method handles this
option by effectively setting the "Origin:" request header (see
updateRequestForAccessControl() in CrossOriginAccessControl.cpp).
StyleResolver::loadPendingShapeImage() uses the new ResourceLoaderOption.

The static ShapeInsideInfo and ShapeOutsideInfo isEnabledFor() method
now performs the CORS check for image valued shapes. The private
isOriginClean() method from CanvasRenderingContext2D has been moved to
the CachedImage class so that it can be shared by the Canvas and Shape
implementations. It checks the response headers per the CORS spec.

Test: http/tests/security/shape-image-cors.html

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage): Handle the new ResourceLoaderOption.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingShapeImage): Set the new ResourceLoaderOption.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createPattern): Use the CachedImage::isOriginClean().

  • loader/ResourceLoaderOptions.h: Added PotentiallyCrossOriginEnabled to RequestOriginPolicy.
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::isOriginClean): Migrated from CanvasRenderingContext2D.

  • loader/cache/CachedImage.h:
  • rendering/shapes/ShapeInfo.cpp:

(WebCore::::checkImageOrigin): Do the CORS check and log an error message if neccessary.

  • rendering/shapes/ShapeInfo.h:
  • rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::isEnabledFor): Call checkImageOrigin() for images.

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::isEnabledFor): Ditto.

LayoutTests:

Verify that images not allowed by CORS don't affect the layout
and that same-origin images, data URLs, and images with a
"Access-Control-Allow-Origin: *" header do define the layout.
Added a simple PHP script that optionally adds the allow origin header.

Replaced and renamed the original shape same-origin-only test.

  • http/tests/security/resources/image-access-control.php: Added.
  • http/tests/security/shape-image-cors-expected.html: Added.
  • http/tests/security/shape-image-cors.html: Added.
  • http/tests/security/shape-inside-image-origin-expected.txt: Removed.
  • http/tests/security/shape-inside-image-origin.html: Removed.
1:36 PM Changeset in webkit [158043] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Tools

Merged r157995.

1:35 PM Changeset in webkit [158042] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/Tools

Merged r157815.

1:35 PM Changeset in webkit [158041] by Simon Fraser
  • 7 edits
    6 copies
    8 adds in trunk/LayoutTests

Mavericks results with MountainLion variants.

  • platform/mac-mountainlion/canvas/philip/tests/2d.line.join.parallel-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt.
  • platform/mac-mountainlion/fast/css/line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-expected.txt.
  • platform/mac-mountainlion/fast/text/drawBidiText-expected.txt: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.txt.
  • platform/mac-mountainlion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
  • platform/mac-mountainlion/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
  • platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt.
  • platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
  • platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
  • platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/text/drawBidiText-expected.txt:
  • platform/mac/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
1:35 PM Changeset in webkit [158040] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

[MSE] Fix runtime errors caused by mediasource IDL attributes.
​https://bugs.webkit.org/show_bug.cgi?id=123352

Reviewed by Eric Carlson.

Due to ​http://webkit.org/b/123178, MediaSource classes must add a GenerateIsReachable
(and also a JSGenerateToJSObject) attribute to avoid runtime asserts and crashes.

  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediasource/WebKitMediaSource.idl:
  • Modules/mediasource/WebKitSourceBufferList.idl:
1:34 PM Changeset in webkit [158039] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/Tools

Merged r157687.

1:33 PM Changeset in webkit [158038] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/Tools

Merged r157553.

1:32 PM Changeset in webkit [158037] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Tools

Merged r154450.

1:16 PM Changeset in webkit [158036] by mrowe@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix or disable some deprecation warnings.

Reviewed by Darin Adler.

  • Panels/WebAuthenticationPanel.m:

(-[WebAuthenticationPanel cancel:]): On newer OS versions, use the modern API.
(-[WebAuthenticationPanel logIn:]): Ditto.
(-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): Ditto. Translate the
response code in to the form that -sheetDidEnd:responseCode:contextInfo: expects.

  • WebView/WebClipView.mm:

(-[WebClipView initWithFrame:]): Disable deprecation warnings since it's not obvious
how to avoid calling -releaseGState here.

12:55 PM Changeset in webkit [158035] by Simon Fraser
  • 1 edit
    3 moves
    2 adds in trunk/LayoutTests

Apparently we need results in platform/mac-mountainlion/platform/mac/ for MountionLion.

  • platform/mac-mountainlion/accessibility/aria-readonly-expected.txt: Added.
  • platform/mac-mountainlion/platform/mac/accessibility/form-control-value-settable-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/form-control-value-settable-expected.txt.
  • platform/mac-mountainlion/platform/mac/accessibility/press-action-is-first-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/press-action-is-first-expected.txt.
  • platform/mac-mountainlion/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/role-subrole-roledescription-expected.txt.
12:44 PM Changeset in webkit [158034] by barraclough@apple.com
  • 4 edits in trunk/Source/WebKit2

Merge viewInWindowStateDidChange into viewStateDidChange
​https://bugs.webkit.org/show_bug.cgi?id=123351

Reviewed by Tim Horton.

  • UIProcess/API/mac/WKView.mm:

(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):

  • viewInWindowStateDidChange -> viewStateDidChange
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

  • removed viewInWindowStateDidChange, renamed parameter to viewStateDidChange
  • UIProcess/WebPageProxy.h:
    • removed viewInWindowStateDidChange, named parameter to viewStateDidChange
12:15 PM Changeset in webkit [158033] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more URTBF for GTK after r158028.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseMap):
(webkitWebViewBaseUnmap):

12:07 PM Changeset in webkit [158032] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebKit2

URTBF from non-Mac platforms after r158028.

  • GNUmakefile.list.am:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(toplevelWindowFocusInEvent):
(toplevelWindowFocusOutEvent):
(toplevelWindowVisibilityEvent):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseSetFocus):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::setActive):
(WebKit::WebView::setFocused):
(WebKit::WebView::setVisible):

12:06 PM Changeset in webkit [158031] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
​https://bugs.webkit.org/show_bug.cgi?id=123354

11:42 AM Changeset in webkit [158030] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Browser crashed at PlatformGraphicsContext::addDrawLineForText() when trying to upload a video to youtube
​https://bugs.webkit.org/show_bug.cgi?id=123349

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-10-25.
Reviewed by George Staikos.
Internally reviewed by George Staikos, Konrad Piascik, Eli Fidler and Arvid Nilsson.

Browser crashed when dereferencing null PlatformGraphicsContext*.
In FrameView::paintControlTints(), we intentionally constructed GraphicsContext
with null PlatformGraphicsContext* and disabled painting by doing
context.setUpdatingControlTints(true). So we should not go further in
GraphicsContext::drawLineForText() if painting is disabled.
Check paintingDisabled() for the other functions in PathBlackBerry.cpp
as well; otherwise, it is likely we will crash at those places.

  • platform/graphics/blackberry/PathBlackBerry.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):

11:38 AM Changeset in webkit [158029] by Simon Fraser
  • 45 edits
    44 copies
    35 adds in trunk/LayoutTests

Mavericks results with MountainLion variants.

  • platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt.
  • platform/mac-mountainlion/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
  • platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt.
  • platform/mac-mountainlion/fast/css/input-search-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.txt.
  • platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
  • platform/mac-mountainlion/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
  • platform/mac-mountainlion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
  • platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt.
  • platform/mac-mountainlion/fast/dom/isindex-001-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-001-expected.txt.
  • platform/mac-mountainlion/fast/dom/isindex-002-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-002-expected.txt.
  • platform/mac-mountainlion/fast/dynamic/008-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.txt.
  • platform/mac-mountainlion/fast/events/context-no-deselect-expected.txt: Copied from LayoutTests/platform/mac/fast/events/context-no-deselect-expected.txt.
  • platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.txt.
  • platform/mac-mountainlion/fast/lists/dynamic-marker-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/dynamic-marker-crash-expected.txt.
  • platform/mac-mountainlion/fast/overflow/overflow-x-y-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt.
  • platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt.
  • platform/mac-mountainlion/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
  • platform/mac-mountainlion/fast/parser/entity-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt.
  • platform/mac-mountainlion/fast/parser/open-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt.
  • platform/mac-mountainlion/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt.
  • platform/mac-mountainlion/fast/repaint/subtree-root-skipped-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.txt.
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-mixture-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt.
  • platform/mac-mountainlion/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
  • platform/mac-mountainlion/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt.
  • platform/mac-mountainlion/fast/table/003-expected.txt: Copied from LayoutTests/platform/mac/fast/table/003-expected.txt.
  • platform/mac-mountainlion/fast/table/colspanMinWidth-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-expected.txt.
  • platform/mac-mountainlion/fast/table/colspanMinWidth-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt.
  • platform/mac-mountainlion/fast/table/spanOverlapRepaint-expected.txt: Copied from LayoutTests/platform/mac/fast/table/spanOverlapRepaint-expected.txt.
  • platform/mac-mountainlion/fast/table/text-field-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/table/text-field-baseline-expected.txt.
  • platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt.
  • platform/mac-mountainlion/fast/text/updateNewFont-expected.txt: Copied from LayoutTests/platform/mac/fast/text/updateNewFont-expected.txt.
  • platform/mac-mountainlion/fast/transforms/transformed-focused-text-input-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/transformed-focused-text-input-expected.txt.
  • platform/mac-mountainlion/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
  • platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt.
  • platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.txt.
  • platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt.
  • platform/mac-mountainlion/plugins/mouse-click-plugin-clears-selection-expected.txt: Copied from LayoutTests/platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt.
  • platform/mac-mountainlion/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
  • platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
  • platform/mac-mountainlion/svg/custom/use-on-symbol-inside-pattern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt.
  • platform/mac-mountainlion/svg/hixie/mixed/003-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.txt.
  • platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/zoom-menulist-expected.txt.
  • platform/mac-mountainlion/transforms/3d/general/perspective-non-layer-expected.txt: Copied from LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt.
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/css/continuationCrash-expected.txt:
  • platform/mac/fast/css/css2-system-fonts-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/dynamic/008-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/overflow/overflow-x-y-expected.txt:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/mac/fast/parser/document-write-option-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/selectors/064-expected.txt:
  • platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
  • platform/mac/fast/table/003-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/text/updateNewFont-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/platform/mac/fast/text/systemFont-expected.txt:
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/transforms/2d/zoom-menulist-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
11:26 AM Changeset in webkit [158028] by barraclough@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Move ViewStateFlags out of WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=123323

Reviewed by Sam Weinig.

WebPageProxy contains an enum and typedef that provide a bitfield
of flags describing the visibility of the view containing the page.
We're going to want to use this bitfield in a message to the
WebProcess, so moving out from the UIProcess to shared code.
Creating struct 'ViewState' to scope the enum and typedef.
Renamed ViewStateFlags to ViewState::Flags, and removed redundant
'View' from enum entries.

  • Shared/ViewState.h: Added.
  • UIProcess/API/mac/WKView.mm:

(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
11:24 AM Changeset in webkit [158027] by barraclough@apple.com
  • 5 edits
    1 delete in trunk/Source/WebKit2

Move ViewStateFlags out of WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=123323

Unreviewed

Rolling out 158026 - landed extra chnages!

  • Shared/ViewState.h: Removed.
  • UIProcess/API/mac/WKView.mm:

(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewInWindowStateDidChange):
(WebKit::WebPageProxy::viewStateDidChange):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
11:20 AM Changeset in webkit [158026] by barraclough@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Move ViewStateFlags out of WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=123323

Reviewed by Sam Weinig.

WebPageProxy contains an enum and typedef that provide a bitfield
of flags describing the visibility of the view containing the page.
We're going to want to use this bitfield in a message to the
WebProcess, so moving out from the UIProcess to shared code.
Creating struct 'ViewState' to scope the enum and typedef.
Renamed ViewStateFlags to ViewState::Flags, and removed redundant
'View' from enum entries.

  • Shared/ViewState.h: Added.
  • UIProcess/API/mac/WKView.mm:

(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
11:06 AM Changeset in webkit [158025] by Simon Fraser
  • 2 edits
    1 copy
    9 adds in trunk/LayoutTests

New results for some accessibility tests.

  • platform/mac-mountainlion/accessibility/form-control-value-settable-expected.txt: Added.
  • platform/mac-mountainlion/accessibility/lists-expected.txt: Copied from LayoutTests/platform/mac/accessibility/lists-expected.txt.
  • platform/mac-mountainlion/accessibility/press-action-is-first-expected.txt: Added.
  • platform/mac-mountainlion/accessibility/role-subrole-roledescription-expected.txt: Added.
  • platform/mac/accessibility/aria-readonly-expected.txt: Added.
  • platform/mac/accessibility/lists-expected.txt:
  • platform/mac/platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
  • platform/mac/platform/mac/accessibility/press-action-is-first-expected.txt: Added.
  • platform/mac/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
11:04 AM Changeset in webkit [158024] by Lucas Forschler
  • 4 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154915. <rdar://problem/15109453>

11:02 AM Changeset in webkit [158023] by Lucas Forschler
  • 9 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154914. <rdar://problem/15109453>

11:01 AM Changeset in webkit [158022] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Ran update-localizable-strings after changes made in r157947.

Rubber-stamped by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
10:59 AM Changeset in webkit [158021] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix MSVC again

10:47 AM Changeset in webkit [158020] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154890. <rdar://problem/15109453>

10:44 AM Changeset in webkit [158019] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537.73-branch

Merged r154856. <rdar://problem/15109399>

10:35 AM Changeset in webkit [158018] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Adding platform implementation of MediaStreamTrack
​https://bugs.webkit.org/show_bug.cgi?id=123301

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-25
Reviewed by Eric Carlson.

No new tests needed.

  • CMakeLists.txt:
  • Modules/mediastream/AudioStreamTrack.cpp:

(WebCore::AudioStreamTrack::create): Create method now receives a MediaStreamTrackPrivate as parameter.

(WebCore::AudioStreamTrack::AudioStreamTrack):

  • Modules/mediastream/AudioStreamTrack.h:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream): Constructor now iterates through a set of MediaStreamTrackPrivate
instances to create each MediaStreamTrack of MediaStream.

(WebCore::MediaStream::addRemoteSource): Calling AudioStreamTrack and VideoStreamTrack with
MediaStreamTrackPrivate as parameter.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack): Constructor now receives a MediaStreamTrackPrivate, instead of a
MediaStreamSource.

(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind): Calling method from MediaStreamTrackPrivate.

(WebCore::MediaStreamTrack::setSource): Ditto.

(WebCore::MediaStreamTrack::id): Ditto.

(WebCore::MediaStreamTrack::label): Ditto.

(WebCore::MediaStreamTrack::enabled): Ditto.

(WebCore::MediaStreamTrack::setEnabled): Ditto.

(WebCore::MediaStreamTrack::muted): Ditto.

(WebCore::MediaStreamTrack::readonly): Ditto.

(WebCore::MediaStreamTrack::remote): Ditto.

(WebCore::MediaStreamTrack::readyState): Ditto.

(WebCore::MediaStreamTrack::states):
(WebCore::MediaStreamTrack::capabilities):
(WebCore::MediaStreamTrack::clone):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::ended): Ditto.

(WebCore::MediaStreamTrack::sourceStateChanged): Ditto.

(WebCore::MediaStreamTrack::sourceMutedChanged): Ditto.

(WebCore::MediaStreamTrack::sourceEnabledChanged): Ditto.
(WebCore::MediaStreamTrack::configureTrackRendering):
(WebCore::MediaStreamTrack::stopped): Ditto.

(WebCore::MediaStreamTrack::trackDidEnd): Setting Ended ready state in MediaStreamTrackPrivate.

(WebCore::MediaStreamTrack::trackReadyStateChanged): Dispatches Live or Ended event.

(WebCore::MediaStreamTrack::trackMutedChanged): Dispatches Muted event.

  • Modules/mediastream/MediaStreamTrack.h: Now inheriting from MediaStreamTrackPrivateClient.

(WebCore::MediaStreamTrack::source): Calling method from MediaStreamTrackPrivate.
(WebCore::MediaStreamTrack::privateTrack):

  • Modules/mediastream/VideoStreamTrack.cpp:

(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack): Create method now receives a MediaStreamTrackPrivate as parameter.

  • Modules/mediastream/VideoStreamTrack.h:
  • platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Stores the private tracks in a Vector (property of
MediaStreamDescriptor class).

(WebCore::MediaStreamDescriptor::addTrack): Adds a private track to the tracks' Vector

(WebCore::MediaStreamDescriptor::removeTrack): Removes a private track from the tracks' Vector

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::numberOfAudioSources): Renamed from numberOfAudioStreams.

(WebCore::MediaStreamDescriptor::audioSources): Renamed from audioStreams.

(WebCore::MediaStreamDescriptor::numberOfVideoSources): Renamed from numberOfVideoStreams.

(WebCore::MediaStreamDescriptor::videoSources): Renamed from videoStreams.

(WebCore::MediaStreamDescriptor::numberOfAudioTracks): Returns the number of audio tracks this MediaStreamDescriptor
has.

(WebCore::MediaStreamDescriptor::audioTracks): Returns a audio track, given an index

(WebCore::MediaStreamDescriptor::numberOfVideoTracks): Returns the number of video tracks this MediaStreamDescriptor
has.
(WebCore::MediaStreamDescriptor::videoTracks): Returns a video track, given an index

  • platform/mediastream/MediaStreamTrackPrivate.cpp: Added.
  • platform/mediastream/MediaStreamTrackPrivate.h: Added.
10:30 AM Changeset in webkit [158017] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix MSVC

10:27 AM Changeset in webkit [158016] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with multiple regions
<​https://webkit.org/b/123210>

Reviewed by David Hyatt.

I simplified the determination of the next region part of updateShapeAndSegmentsForCurrentLineInFlowThread's implementation
in order to make the code more straightforward. I also tried to avoid using regionAtBlockOffset(...) function where it's possible,
since it's not always that reliable, what I'll will report in a separate bug.

No new tests, covered by existing tests.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):

10:26 AM Changeset in webkit [158015] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with the first lines
<​https://bugs.webkit.org/show_bug.cgi?id=123275>

Reviewed by David Hyatt.

We have a complex condition in updateShapeAndSegmentsForCurrentLineInFlowThread, which is
adjusting the first line to the shape's top. This patch adds two boolean to make that clear.

No new tests, no behavior change.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):

10:13 AM Changeset in webkit [158014] by oliver@apple.com
  • 207 edits in trunk

Improve JSC Parser error messages
​https://bugs.webkit.org/show_bug.cgi?id=123341

Reviewed by Andreas Kling.

Source/JavaScriptCore:

This patch moves away from the current cludgy mechanisms used to produce
error messages and moves to something closer to case by case errors.

This results in a large change size as previously we may just have
'failIfFalse(foo)', but now the logic becomes either
'failIfFalseWithMessage(foo, "Cannot do blah with ", foo->thing())'
Or alternatively

if (!foo)

check for 'interesting' errors, before falling back to generic error

This means that this patch is large, but produces no semantic changes, and
only hits slow (e.g. error) paths.

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::parseDeconstructionPattern):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::stringForFunctionMode):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::operatorString):
(JSC::::parseUnaryExpression):
(JSC::::printUnexpectedTokenText):

  • parser/Parser.h:

(JSC::Scope::hasDeclaredVariable):
(JSC::Scope::hasDeclaredParameter):
(JSC::Parser::hasDeclaredVariable):
(JSC::Parser::hasDeclaredParameter):
(JSC::Parser::setErrorMessage):

LayoutTests:

Update a vast array of layout test results

  • fast/events/window-onerror5-expected.txt:
  • js/basic-strict-mode-expected.txt:
  • js/break-ASI-expected.txt:
  • js/dom/assign-expected.txt:
  • js/dom/object-extra-comma-expected.txt:
  • js/dom/parse-error-external-script-in-eval-expected.txt:
  • js/dom/parse-error-external-script-in-new-Function-expected.txt:
  • js/dom/reserved-words-as-property-expected.txt:
  • js/function-constructor-error-expected.txt:
  • js/function-declaration-expected.txt:
  • js/function-toString-object-literals-expected.txt:
  • js/function-toString-parentheses-expected.txt:
  • js/js-continue-break-restrictions-expected.txt:
  • js/kde/garbage-n-expected.txt:
  • js/kde/parse-expected.txt:
  • js/no-semi-insertion-at-end-of-script-expected.txt:
  • js/object-literal-syntax-expected.txt:
  • js/parser-xml-close-comment-expected.txt:
  • js/regexp-compile-crash-expected.txt:
  • js/script-tests/function-constructor-error.js:
  • js/script-tests/reserved-words-strict.js:

(isReserved):

  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.3_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.4_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.10-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.13-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.14-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.16-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.17-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.20-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.22-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.24-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.25-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.5-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.8-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.9-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.10-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.11-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.16-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.5-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.7-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.9-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T2-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T7-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T8-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T9-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T8-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T8-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T5-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T8-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T9-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T5-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T7-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.4_T1-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T6-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T7-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T8-expected.txt:
  • sputnik/Conformance/08_Types/8.2_The_Null_Type/S8.2_A2-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T3-expected.txt:
  • sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T3-expected.txt:
  • sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T1-expected.txt:
  • sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T2-expected.txt:
  • sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T3-expected.txt:
  • sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T4-expected.txt:
  • sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T1-expected.txt:
  • sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T2-expected.txt:
  • sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T3-expected.txt:
  • sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A2_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T5-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T11-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T12-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T14-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T15-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T6-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8-expected.txt:
  • sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T9-expected.txt:
  • sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T5-expected.txt:
  • sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T6-expected.txt:
  • sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T7-expected.txt:
  • sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T8-expected.txt:
  • sputnik/Conformance/12_Statement/12.4_Expression_Statement/S12.4_A1-expected.txt:
  • sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A11-expected.txt:
  • sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A9_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A12-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A13_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A15-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T5-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T6-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A13_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A15-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T5-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T6-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4.1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A13_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
  • sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.1_eval/S15.1.2.1_A2_T2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A1_T1-expected.txt:
9:37 AM Changeset in webkit [158013] by svillar@igalia.com
  • 9 edits in trunk/Source/WebKit2

[GTK][WK2] Build break after r157967 and r157972
​https://bugs.webkit.org/show_bug.cgi?id=123325

Reviewed by Carlos Garcia Campos.

DrawingArea::visibilityDidChange was removed in favour of a new
message called SetIsVisible which is sent to the WebPage. This
means that {suspend|resume}Paiting are now implemented in a
cross-platform way in WebPage and do not require specific code
from the DrawingArea implementations.

This means that we have to track the toplevel window visibility
and notify the WebPage appropriately about its changes.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::isWindowVisible):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(toplevelWindowVisibilityEvent):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseIsWindowVisible):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::suspendPainting):
(WebKit::DrawingAreaImpl::resumePainting):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndWebPageAreFocused):

8:58 AM Changeset in webkit [158012] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Faster way for simple line layout to check if text has fallback fonts
​https://bugs.webkit.org/show_bug.cgi?id=123342

Reviewed by Andreas Kling.

Don't use RenderText::knownToHaveNoOverflowAndNoFallbackFonts as it is slow.

Simple text code path test already guarantees there is no overflow. Test for fallback
fonts explicitly.

  • platform/graphics/SimpleFontData.h:


Make FINAL.

  • rendering/RenderText.cpp:
  • rendering/RenderText.h:


Remove knownToHaveNoOverflowAndNoFallbackFonts() as it has no clients.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

Check if all characters can be found from the primary font.

7:42 AM Changeset in webkit [158011] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

SVGResourcesCache::clientDestroyed() should take a RenderElement&.
<​https://webkit.org/b/123339>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

6:52 AM Changeset in webkit [158010] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

SVGResourcesCache::clientLayoutChanged() should take a RenderElement&.
<​https://webkit.org/b/123336>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

6:49 AM Changeset in webkit [158009] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

SVGResourcesCache::clientStyleChanged() should take a RenderElement&.
<​https://webkit.org/b/123335>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

6:48 AM Changeset in webkit [158008] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

SVG: postApplyResource() should take a RenderElement&.
<​https://webkit.org/b/123334>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

6:46 AM Changeset in webkit [158007] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION(r157950): It made many tests assert on Windows, EFL, GTK
​https://bugs.webkit.org/show_bug.cgi?id=123309

Reviewed by Andreas Kling.

Disable simple line layout on non-Mac plaforms for now.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

6:20 AM Changeset in webkit [158006] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

One more build fix. Put each latest revision information in an actual td.

  • public/index.html:
5:43 AM Changeset in webkit [158005] by rniwa@webkit.org
  • 3 edits in trunk/Websites/test-results

Yet another set of build fixes.

  1. Manually strip / from revisions JSON if there is any.
  2. Suppress warnings from ob_end_flush.
  3. Allow "+" in actual and expected results as used in "TEXT+IMAGE".
  • public/api/report.php:
  • public/include/test-results.php:
5:28 AM Changeset in webkit [158004] by akling@apple.com
  • 20 edits in trunk/Source/WebCore

SVG: applyResource() should take a RenderElement&.
<​https://webkit.org/b/123286>

This function is always called with an object, and that object
is guaranteed to never be a text renderer.

Reviewed by Antti Koivisto.

5:00 AM Changeset in webkit [158003] by akling@apple.com
  • 15 edits in trunk/Source/WebCore

RenderElement::styleWillChange() should pass newStyle as reference.
<​https://webkit.org/b/123332>

When styleWillChange() is called, there is always a new style getting
set so there's no need to handle the null style case.
This flushed out a couple of unnecessary checks.

Reviewed by Antti Koivisto.

4:57 AM Changeset in webkit [158002] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] [WebKit2] CanHandleRequest API test fails
​https://bugs.webkit.org/show_bug.cgi?id=88453

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-25
Reviewed by Martin Robinson.

Source/WebKit2:

Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformCanHandleRequest):

Tools:

  • Scripts/run-gtk-tests:

(TestRunner):

4:49 AM Changeset in webkit [158001] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile fixes.
​https://bugs.webkit.org/show_bug.cgi?id=123269

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-25
Reviewed by Csaba Osztrogonác.

  • platform/graphics/win/ImageCairoWin.cpp: Added new parameter to BitmapImage::draw() calls.

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

4:19 AM Changeset in webkit [158000] by rniwa@webkit.org
  • 1 edit
    1 move in trunk/Websites/test-results

Another build fix. Move .htaccess to public.

  • .htaccess: Removed.
  • public/.htaccess: Copied from .htaccess.
3:31 AM Changeset in webkit [157999] by svillar@igalia.com
  • 4 edits
    1 add in trunk

Use a Vector instead of HashSet to computed the orderValues in RenderFlexibleBox
​https://bugs.webkit.org/show_bug.cgi?id=118620

Reviewed by Antti Koivisto.

PerformanceTests:

From Blink r152960 by <​ojan@chromium.org>

New performance test for layouts in flexboxes.

  • Layout/flexbox-lots-of-data.html: Added.

Source/WebCore:

Turns out that order is extremelly uncommon so using a Vector is
much less expensive. This also special-cases the much common case
of only having order of value 0 by using Vectors with just one
preallocated member.

Also added the performance test that shows a ~1% win when using a
vector instead of the HashSet.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):

  • rendering/RenderFlexibleBox.h:
2:52 AM Changeset in webkit [157998] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

Non-SVG build broken after r157950
​https://bugs.webkit.org/show_bug.cgi?id=123328

Reviewed by Xan Lopez.

The isSVGInlineTest() check should be done only if SVG is enabled.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

2:50 AM Changeset in webkit [157997] by Manuel Rego Casasnovas
  • 11 edits in trunk/LayoutTests

[CSS Regions] Rename CSS classes and JS methods in vertical layout tests about selection
​https://bugs.webkit.org/show_bug.cgi?id=123327

Reviewed by Mihnea Ovidenie.

For consistency with Blink we use Vertical instead of Vert in CSS
classes and JS methods related to the selection layout tests for CSS
Regions.

  • fast/regions/resources/helper.js:

(selectContentByIdsVertical):

  • fast/regions/resources/region-style.css:
  • fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html:
  • fast/regions/selection/selecting-text-ignoring-region-vert-lr.html:
  • fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html:
  • fast/regions/selection/selecting-text-ignoring-region-vert-rl.html:
  • fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
  • fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
  • fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
  • fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:
1:44 AM Changeset in webkit [157996] by Csaba Osztrogonác
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Build break after r157967 and r157972
​https://bugs.webkit.org/show_bug.cgi?id=123324

Patch by Ryuan Choi <​ryuan.choi@samsung.com> on 2013-10-25
Reviewed by Tim Horton.

Since r157967 and r157972, visibilityDidChange was removed from DrawingAreaProxy.

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::visibilityDidChange):
Removed common logic which r157967 moved to WebProcess.

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:

Make visibilityDidChange to public method.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::setVisible):
(WebKit::WebView::isWindowVisible): Added.

  • UIProcess/CoordinatedGraphics/WebView.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setWindowIsVisible):

  • WebProcess/WebPage/WebPage.h:

Moved m_windowIsVisible to use at all WK2 based port.
(WebKit::WebPage::windowIsVisible):

  • WebProcess/WebPage/WebPage.messages.in:

Moved SetWindowIsVisible message to use at all WK2 based port.

1:32 AM Changeset in webkit [157995] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.

  • Scripts/webkitpy/port/base.py:

(Port.repository_paths):

1:31 AM Changeset in webkit [157994] by Manuel Rego Casasnovas
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Several fast/regions/selection tests are failing in WK2.

Patch by Javier Fernandez <​jfernandez@igalia.com> on 2013-10-25

  • platform/gtk-wk2/TestExpectations:
12:47 AM Changeset in webkit [157993] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

It turns out that the current instruction only works on Mountain Lion.

Also fixed some typos.

  • Install.md:
12:13 AM Changeset in webkit [157992] by jer.noble@apple.com
  • 5 edits in trunk

[WTF] Add a multiplication operator (and a few others) to MediaTime
​https://bugs.webkit.org/show_bug.cgi?id=123137

Reviewed by Eric Carlson.

Source/WTF:

Add a multiplication operator and an inequality operator to the
MediaTime class for use by MSE.

  • wtf/MediaTime.cpp:

(WTF::signum): Moved to top of file.
(WTF::MediaTime::operator*): Added.
(WTF::MediaTime::operator!=): Added.

  • wtf/MediaTime.h:

(WTF::operator*): Added non-class version of operator*.

Tools:

Add tests for new MediaTime operators.

  • TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST):

12:07 AM Changeset in webkit [157991] by jer.noble@apple.com
  • 7 edits
    2 copies in trunk/Source

[Mac] Add helper methods to convert CMTime <--> MediaTime
​https://bugs.webkit.org/show_bug.cgi?id=123285

Reviewed by Eric Carlson.

Source/WebCore:

Add utility methods to convert between CMTime (a rational time class) and MediaTime.
Once there, PlatformClockCM can now vend and accept MediaTimes for currentTime.

  • platform/mac/MediaTimeMac.h:
  • platform/mac/MediaTimeMac.cpp:

(WebCore::toMediaTime): Added conversion utility method.
(WebCore::toCMTime): Ditto.

  • platform/mac/PlatformClockCM.h:
  • platform/mac/PlatformClockCM.mm:

(PlatformClockCM::setCurrentMediaTime): Added.
(PlatformClockCM::currentMediaTime): Added.

  • WebCore.xcodeproj/project.pbxproj: Add new files to project.

Source/WTF:

Add a #ifdef header_h protector.

  • wtf/MediaTime.h:
Note: See TracTimeline for information about the timeline view.