Timeline

Oct 28, 2013:

10:18 PM Changeset in webkit [158181] by akling@apple.com

• 5 edits in trunk/Source/WebCore

applyTextTransform() should take a const RenderStyle&.
<​https://webkit.org/b/123434>

This function is always called with an existing RenderStyle object.

Reviewed by Anders Carlsson.

10:14 PM Changeset in webkit [158180] by akling@apple.com

• 19 edits in trunk/Source/WebCore

RenderSVGResource::applyResource() should take a const RenderStyle&.
<​https://webkit.org/b/123433>

These functions are always called with an existing RenderStyle object
so let them take a const reference instead of a raw pointer.
Also sprinkled some missing OVERRIDEs.

Reviewed by Anders Carlsson.

10:13 PM Changeset in webkit [158179] by akling@apple.com

• 1 edit in trunk/Source/WebCore/ChangeLog

Fix bug URL in ChangeLog.

10:09 PM Changeset in webkit [158178] by akling@apple.com

• 6 edits in trunk/Source/WebCore

Remove unused RenderTextControl::textBaseStyle().
<​https://webkit.org/b/123423>

Reviewed by Anders Carlsson.

9:42 PM Changeset in webkit [158177] by Simon Fraser

• 2 edits in trunk/LayoutTests

Fix path for xss-DENIED-xsl-document-redirect test, and mark
editing/selection/5057506-2.html as image-only failure.

• platform/mac-wk2/TestExpectations:

9:38 PM Changeset in webkit [158176] by Simon Fraser

• 2 edits in trunk/Tools

Floating left the header broke other pages, and this CSS has no way to customize
per-page.

• BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

9:34 PM Changeset in webkit [158175] by Simon Fraser

• 2 edits in trunk/Tools

Remove underlines on the bot names in the header.

• BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(td.LastBuild a):

9:33 PM Changeset in webkit [158174] by gyuyoung.kim@samsung.com

• 3 edits
  1 add in trunk/Tools

Add EFL release bots to the buildbot dashboard
​https://bugs.webkit.org/show_bug.cgi?id=123430

Reviewed by Darin Adler.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.

9:32 PM Changeset in webkit [158173] by Simon Fraser

• 2 edits in trunk/Tools

More waterfall tweaking.

• BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(body > .header):
(td.LastBuild):
(td.LastBuild a):
(td.LastBuild,td.Activity a,td.Change a,td.Builder a):

9:27 PM Changeset in webkit [158172] by Simon Fraser

• 2 edits in trunk/Tools

More waterfall tweaking.

• BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(body.interface):
(body > hr):
(div.content h1):
(body > .header):
(td.Activity a,td.Change a,td.Builder a):
(td.Builder):

9:20 PM Changeset in webkit [158171] by commit-queue@webkit.org

• 51 edits in trunk/Source/WebCore

HTML input type objects should be managed through std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=123160

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-10-28
Reviewed by Darin Adler.

Make the constructors of the InputType subclasses public. This makes it possible to use std::make_unique on these classes
and makes the T::create() helpers redundant. New instances of these classes are now managed through std::unique_ptr.

InputType::create() now uses a NeverDestroyed InputTypeFactoryMap that maps type names to InputTypeFactoryFunctions and
gets populated when the method is first called and the map is still empty. Certain types are not added to the factory map
if they're disabled at runtime.

The factory is used to create the new InputType object if the requested type was found in the map, and TextInputType is used otherwise.

• html/ButtonInputType.cpp:
• html/ButtonInputType.h:

(WebCore::ButtonInputType::ButtonInputType):

• html/CheckboxInputType.cpp:
• html/CheckboxInputType.h:

(WebCore::CheckboxInputType::CheckboxInputType):

• html/ColorInputType.cpp:
• html/ColorInputType.h:

(WebCore::ColorInputType::ColorInputType):

• html/DateInputType.cpp:
• html/DateInputType.h:
• html/DateTimeInputType.cpp:
• html/DateTimeInputType.h:

(WebCore::DateTimeInputType::DateTimeInputType):

• html/DateTimeLocalInputType.cpp:
• html/DateTimeLocalInputType.h:

(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):

• html/EmailInputType.cpp:
• html/EmailInputType.h:

(WebCore::EmailInputType::EmailInputType):

• html/FileInputType.cpp:
• html/FileInputType.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

• html/HTMLInputElement.h:
• html/HiddenInputType.cpp:
• html/HiddenInputType.h:

(WebCore::HiddenInputType::HiddenInputType):

• html/ImageInputType.cpp:

(WebCore::ImageInputType::ImageInputType):

• html/ImageInputType.h:
• html/InputType.cpp:

(WebCore::createInputType): A templated helper that constructs a new InputType subclass object through std::make_unique.
(WebCore::populateInputTypeFactoryMap): Populates the passed-in map with type-createInputType<T> pairs.
(WebCore::InputType::create): Get the InputTypeFactoryFunction for the specified type, or fall back to TextInputType.
(WebCore::InputType::createText):

• html/InputType.h:
• html/MonthInputType.cpp:
• html/MonthInputType.h:

(WebCore::MonthInputType::MonthInputType):

• html/NumberInputType.cpp:
• html/NumberInputType.h:

(WebCore::NumberInputType::NumberInputType):

• html/PasswordInputType.cpp:
• html/PasswordInputType.h:

(WebCore::PasswordInputType::PasswordInputType):

• html/RadioInputType.cpp:
• html/RadioInputType.h:

(WebCore::RadioInputType::RadioInputType):

• html/RangeInputType.cpp:
• html/RangeInputType.h:
• html/ResetInputType.cpp:
• html/ResetInputType.h:

(WebCore::ResetInputType::ResetInputType):

• html/SearchInputType.cpp:

(WebCore::SearchInputType::SearchInputType):

• html/SearchInputType.h:
• html/SubmitInputType.cpp:
• html/SubmitInputType.h:

(WebCore::SubmitInputType::SubmitInputType):

• html/TelephoneInputType.cpp:
• html/TelephoneInputType.h:

(WebCore::TelephoneInputType::TelephoneInputType):

• html/TextInputType.cpp:
• html/TextInputType.h:

(WebCore::TextInputType::TextInputType):

• html/TimeInputType.cpp:
• html/TimeInputType.h:
• html/URLInputType.cpp:
• html/URLInputType.h:

(WebCore::URLInputType::URLInputType):

• html/WeekInputType.cpp:
• html/WeekInputType.h:

(WebCore::WeekInputType::WeekInputType):

9:19 PM Changeset in webkit [158170] by beidson@apple.com

• 24 edits in trunk/Source

Refactor IDB factory creation.
​https://bugs.webkit.org/show_bug.cgi?id=123347

Reviewed by Andreas Kling.

• Rework how database directory location is passed around.
• Make (some) SecurityOrigin arguments be references instead of pointers.
• Add two SecurityOrigin arguments to opening databases for future use.

Source/WebCore:

• Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):

• Modules/indexeddb/IDBFactoryBackendInterface.cpp:

(WebCore::IDBFactoryBackendInterface::create):

• Modules/indexeddb/IDBFactoryBackendInterface.h:

• Modules/indexeddb/PageGroupIndexedDatabase.cpp:

(WebCore::PageGroupIndexedDatabase::PageGroupIndexedDatabase):
(WebCore::PageGroupIndexedDatabase::from):
(WebCore::PageGroupIndexedDatabase::factoryBackend):

• Modules/indexeddb/PageGroupIndexedDatabase.h:

• Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:

(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):

• Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h:

• Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::open):
(WebCore::IDBBackingStoreLevelDB::openInMemory):

• Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

• Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::computeFileIdentifier):
(WebCore::computeUniqueIdentifier):
(WebCore::IDBFactoryBackendLevelDB::IDBFactoryBackendLevelDB):
(WebCore::IDBFactoryBackendLevelDB::getDatabaseNames):
(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::openBackingStore):
(WebCore::IDBFactoryBackendLevelDB::open):

• Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

(WebCore::IDBFactoryBackendLevelDB::create):

• WebCore.exp.in:

• platform/DatabaseStrategy.cpp:

(WebCore::DatabaseStrategy::createIDBFactoryBackend):

• platform/DatabaseStrategy.h:

Source/WebKit2:

• Shared/Databases/IndexedDB/IDBUtilities.cpp:

(WebKit::uniqueDatabaseIdentifier):

• Shared/Databases/IndexedDB/IDBUtilities.h:

• WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::open):

• WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:

(WebKit::WebIDBFactoryBackend::create):

• WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:

(WebKit::WebProcessIDBDatabaseBackend::WebProcessIDBDatabaseBackend):

• WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createIDBFactoryBackend):

• WebProcess/WebCoreSupport/WebPlatformStrategies.h:

9:16 PM Changeset in webkit [158169] by Simon Fraser

• 3 edits in trunk/Tools

Apply changes to default.css, revert buildbot.css which seems to be unused.

• BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:

(body):
(body, td):
(a:link,a:visited,a:active):
(td.Time):
(td.Activity):
(.exception, td.offline):

• BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(body.interface):
(.auth):
(td.LastBuild):
(td.Time):
(td.Activity):
(.offline,td.offline,.retry):

9:03 PM Changeset in webkit [158168] by Simon Fraser

• 2 edits in trunk/Tools

Prettify the waterfall page, and make it a little more space-efficient.

• BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:

(body, td):
(body.interface):
(.auth):
(.header):
(div.content h1):
(a):
(a:link,a:active):
(a:link,a:visited,a:active):
(td.LastBuild):
(td.Time):
(td.Activity):
(.exception, td.offline, .retry):

8:29 PM Changeset in webkit [158167] by Simon Fraser

• 2 edits in trunk/Tools

Fix Lion readableName (spotted by Dan Bernstein).

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

8:18 PM Changeset in webkit [158166] by Lucas Forschler

• 5 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r157561. <rdar://problem/15292382>

8:10 PM Changeset in webkit [158165] by Lucas Forschler

• 4 edits
  2 copies in branches/safari-537.73-branch

Merged r157298. <rdar://problem/15292359>

8:05 PM Changeset in webkit [158164] by Lucas Forschler

• 4 edits
  4 copies in branches/safari-537.73-branch

Merged r155554. <rdar://problem/15292361>

7:58 PM Changeset in webkit [158163] by akling@apple.com

• 260 edits in trunk/Source

RenderElement::style() should return a reference.
<​https://webkit.org/b/123414>

Now that renderers always have style, go ahead and make style()
return a RenderStyle&.

There are countless opportunities for further cleanup enabled by
this change. I'm simply passing &style() in many cases where we
can really do something nicer instead.

Reviewed by Anders Carlsson.

7:52 PM Changeset in webkit [158162] by Lucas Forschler

• 7 edits
  2 copies in branches/safari-537.73-branch

Merged r155665. <rdar://problem/15109475>

7:45 PM Changeset in webkit [158161] by Lucas Forschler

• 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r155664. <rdar://problem/15168243>

7:45 PM Changeset in webkit [158160] by timothy_horton@apple.com

• 10 edits in trunk/Source

Make TileController create the appropriate PlatformCALayer subclasses
​https://bugs.webkit.org/show_bug.cgi?id=123418

Reviewed by Simon Fraser.

Add PlatformCALayer::createCompatibleLayer, which is overridden in
each of the subclasses to create a PlatformCALayer instance of the same
subclass. This is used in TileController to make bare PlatformCALayers
of the correct type (Mac, Win, or Remote).

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/mac/PlatformCALayerMac.h:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::createCompatibleLayer):

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::createCompatibleLayer):

• platform/graphics/ca/win/PlatformCALayerWin.h:

Add createCompatibleLayer and implement it in the subclasses.

• platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
(WebCore::TileController::tiledScrollingIndicatorLayer):
(WebCore::TileController::createTileLayer):
Make use of createCompatibleLayer when creating PlatformCALayers.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::createCompatibleLayer):

• WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Add createCompatibleLayer and implement it in the subclasses.

7:38 PM Changeset in webkit [158159] by Alexandru Chiculita

• 13 edits
  2 adds in trunk

Web Inspector: CSS Regions: Add protocol API to expose content nodes addition/removal
​https://bugs.webkit.org/show_bug.cgi?id=123424

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector-protocol/model/content-flow-content-nodes.html

Adding two new inspector-protocol APIs to handle the cases when new elements are
added or removed from a named flow. These APIs will trigger even though there
is no region associated with the named flow.

• inspector/Inspector.json:
• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):

• inspector/InspectorCSSAgent.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElementImpl):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElementImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElement):

• rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):

Source/WebInspectorUI:

Exposed the new CSS Agent events to the ContentFlow class that will now maintain
a list of nodes in the "contentNodes" property.

• UserInterface/CSSObserver.js:

(WebInspector.CSSObserver.prototype.regionOversetChanged):
(WebInspector.CSSObserver.prototype.registeredNamedFlowContentElement):
(WebInspector.CSSObserver.prototype.unregisteredNamedFlowContentElement):

• UserInterface/ContentFlow.js:

(WebInspector.ContentFlow):
(WebInspector.ContentFlow.prototype.set overset):
(WebInspector.ContentFlow.prototype.get contentNodes):
(WebInspector.ContentFlow.prototype.insertContentNodeBefore):
(WebInspector.ContentFlow.prototype.appendContentNode):
(WebInspector.ContentFlow.prototype.removeContentNode):

• UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype.regionOversetChanged):
(WebInspector.DOMTreeManager.prototype.registeredNamedFlowContentElement):
(WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):

• UserInterface/InspectorBackendCommands.js:

LayoutTests:

Added test to check that the two new events are triggered correctly and can be used to maintain
the flow content nodes list on the inspector side.

• inspector-protocol/model/content-flow-content-nodes-expected.txt: Added.
• inspector-protocol/model/content-flow-content-nodes.html: Added.

7:37 PM Changeset in webkit [158158] by Lucas Forschler

• 7 edits
  2 deletes in branches/safari-537.73-branch

rollout r158067.

7:13 PM Changeset in webkit [158157] by Lucas Forschler

• 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r156099. <rdar://problem/15168245>

7:10 PM Changeset in webkit [158156] by Lucas Forschler

• 4 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r156479. <rdar://problem/15168235>

7:07 PM Changeset in webkit [158155] by Lucas Forschler

• 3 edits
  2 copies in branches/safari-537.73-branch

Merged r156222. <rdar://problem/15168254>

7:05 PM Changeset in webkit [158154] by Lucas Forschler

• 3 edits
  2 copies in branches/safari-537.73-branch

Merged r157231. <rdar://problem/15333294>

6:53 PM Changeset in webkit [158153] by Lucas Forschler

• 2 edits in branches/safari-537.73-branch/WebKitLibraries

Merged r157608. <rdar://problem/15323809>

6:50 PM Changeset in webkit [158152] by Lucas Forschler

• 2 edits in branches/safari-537.73-branch/Source/WTF

Merged r155717. <rdar://problem/15292366>

6:38 PM Changeset in webkit [158151] by Simon Fraser

• 3 edits in trunk/Tools

Add tooltips to the platform icons in Dashboard
​https://bugs.webkit.org/show_bug.cgi?id=123429

Reviewed by Alexey Proskuryakov.

Add a human readable name to Buildbot.Platform entries, and use it to
show a tooltip on the ring image.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(documentReady):

6:38 PM Changeset in webkit [158150] by Simon Fraser

• 2 edits in trunk/LayoutTests

Last few Mavericks WK2 failures.

• platform/mac-wk2/TestExpectations:

6:34 PM Changeset in webkit [158149] by Lucas Forschler

• 6 edits in branches/safari-537.73-branch

Merged r157830. <rdar://problem/15303898>

6:15 PM Changeset in webkit [158148] by Brent Fulgham

• 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore

Debug build correction after r158124.

• runtime/JSObject.h:

(JSC::JSObject::setStructure): Use external hasIndexingHeader function since
the member function did not exist at the time of this branch.

5:56 PM Changeset in webkit [158147] by commit-queue@webkit.org

• 1 edit
  1 delete in trunk/Source/WebCore

Web Inspector: Remove unused inspector/inline-javascript-imports.py
​https://bugs.webkit.org/show_bug.cgi?id=123425

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.

• inspector/inline-javascript-imports.py: Removed.

5:52 PM Changeset in webkit [158146] by commit-queue@webkit.org

• 1 edit
  2 deletes in trunk/Source/WebCore

Web Inspector: Remove unused "externs" files and generators
​https://bugs.webkit.org/show_bug.cgi?id=123427

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.

• inspector/InjectedScriptExterns.js: Removed.
• inspector/generate_protocol_externs.py: Removed.

4:52 PM Changeset in webkit [158145] by Simon Fraser

• 2 edits in trunk/LayoutTests

Mark some more Mavericks/WK2 tests as failing.

We have no way currently to land new results for just
WK2 on Mavericks.

• platform/mac-wk2/TestExpectations:

4:14 PM Changeset in webkit [158144] by Lucas Forschler

• 5 edits in branches/safari-537.60-branch/Source

Versioning.

4:13 PM Changeset in webkit [158143] by Lucas Forschler

• 1 copy in tags/Safari-537.60.4

New Tag.

3:44 PM Changeset in webkit [158142] by Lucas Forschler

• 2 edits in branches/safari-537.60-branch/WebKitLibraries

Merged r157608. <rdar://problem/15323836>

3:32 PM Changeset in webkit [158141] by fpizlo@apple.com

• 13 edits in trunk/Source/JavaScriptCore

OSRExit::m_watchpointIndex should be in OSRExitCompilationInfo
​https://bugs.webkit.org/show_bug.cgi?id=123423

Reviewed by Mark Hahnenberg.

Also enable ExitKind to tell you if it's a watchpoint.

• bytecode/ExitKind.cpp:

(JSC::exitKindToString):

• bytecode/ExitKind.h:

(JSC::isWatchpoint):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::appendExitInfo):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

• dfg/DFGOSRExit.h:
• dfg/DFGOSRExitCompilationInfo.h:

(JSC::DFG::OSRExitCompilationInfo::OSRExitCompilationInfo):

• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculationWatchpoint):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:22 PM Changeset in webkit [158140] by Lucas Forschler

• 2 edits in branches/safari-537.73-branch/Source/WebKit/win

Merged r156433. <rdar://problem/15109489>

3:20 PM Changeset in webkit [158139] by Lucas Forschler

• 5 edits in branches/safari-537.73-branch/Source

Merged r156416. <rdar://problem/15109488>

3:13 PM Changeset in webkit [158138] by Lucas Forschler

• 5 edits in branches/safari-537.73-branch/Source

Merged r156219. <rdar://problem/15109342>

3:08 PM Changeset in webkit [158137] by commit-queue@webkit.org

• 19 edits
  2 adds in trunk/Source

Upstream remaining PLATFORM(IOS) and ENABLE(REMOTE_INSPECTOR) pieces
​https://bugs.webkit.org/show_bug.cgi?id=123411

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.

Source/WebCore:

Include an InspectorClient hook for when node searching is enabled / disabled.

• inspector/InspectorClient.h:

(WebCore::InspectorClient::didSetSearchingForNode):

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setSearchingForNode):

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::didSetSearchingForNode):

• inspector/InspectorOverlay.h:

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Upstream iOS node highlighting and view indication.

• WebCoreSupport/WebInspectorClient.h:
• WebInspector/WebInspector.h:
• WebInspector/WebInspector.mm:
• WebInspector/WebNodeHighlight.h:
• WebInspector/WebNodeHighlight.mm:

(-[WebHighlightLayer initWithHighlightView:webView:]):
(-[WebHighlightLayer layoutSublayers]):
(-[WebHighlightLayer actionForKey:]):
(-[WebNodeHighlight initWithTargetView:inspectorController:]):
(-[WebNodeHighlight dealloc]):
(-[WebNodeHighlight attach]):

• WebInspector/WebNodeHighlightView.h:
• WebInspector/WebNodeHighlightView.mm:

(-[WebNodeHighlightView initWithWebNodeHighlight:]):
(-[WebNodeHighlightView dealloc]):
(-[WebNodeHighlightView _attach:numLayers:]):
(findIntersectionOnLineBetweenPoints):
(quadIntersection):
(layerPathWithHole):
(layerPath):
(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
(-[WebNodeHighlightView _layoutForRectsHighlight:parent:]):
(-[WebNodeHighlightView layoutSublayers:]):

• WebInspector/WebNodeHighlighter.mm:

(-[WebNodeHighlighter highlight]):

• WebView/WebIndicateLayer.h: Added.
• WebView/WebIndicateLayer.mm: Added.

(-[WebIndicateLayer layoutSublayers]):
(-[WebIndicateLayer actionForKey:]):

• WebView/WebView.mm:

(-[WebView setIndicatingForRemoteInspector:]):
(-[WebView setHostApplicationBundleId:name:]):
(-[WebView hostApplicationBundleId]):
(-[WebView hostApplicationName]):

• WebView/WebViewData.h:
• WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]):

3:01 PM Changeset in webkit [158136] by Simon Fraser

• 4 edits in trunk/Tools

Allow explicit sort order for Dashboard platforms
​https://bugs.webkit.org/show_bug.cgi?id=123419

Reviewed by Tim Hatcher.

Assign a specific sort order to Dashboard platforms, rather than
just using object property order.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(documentReady):

3:00 PM Changeset in webkit [158135] by Simon Fraser

• 2 edits in trunk/LayoutTests

Add skipped or failing expectations for Mavericks WK2.

• platform/mac-wk2/TestExpectations:

2:55 PM Changeset in webkit [158134] by Lucas Forschler

• 20 edits in branches/safari-537.73-branch

Merged r156302.

2:43 PM Changeset in webkit [158133] by Lucas Forschler

• 20 edits in branches/safari-537.60-branch

Merged r156302.

2:32 PM Changeset in webkit [158132] by mark.lam@apple.com

• 1 edit
  2 adds in branches/safari-537.73-branch/LayoutTests

Merge r155471.
​https://bugs.webkit.org/show_bug.cgi?id=123409.

Missing files from previous merge commit for r155471.

• inspector-protocol/debugger/resources: Added.
• inspector-protocol/debugger/resources/exception.js: Added.

(exceptionBasic):
(exceptionDOM):
(throwString):
(throwParam):
(exceptionInHostFunction):
(catchNested):
(noException):

2:27 PM Changeset in webkit [158131] by Simon Fraser

• 2 edits in trunk/LayoutTests

WebGL flake.

• platform/mac/TestExpectations:

2:24 PM Changeset in webkit [158130] by Simon Fraser

• 2 edits in trunk/Tools

Tidy up main ​http://build.webkit.org page
​https://bugs.webkit.org/show_bug.cgi?id=123413

Reviewed by Alexey Proskuryakov.

Break the list of links into sections. Add some font style.

• BuildSlaveSupport/build.webkit.org-config/templates/root.html:

2:19 PM Changeset in webkit [158129] by benjamin@webkit.org

• 9 edits in trunk/Source

Rename applyPageScaleFactorInCompositor to delegatesPageScaling
​https://bugs.webkit.org/show_bug.cgi?id=123417

Reviewed by Simon Fraser.

Source/WebCore:

• page/Frame.cpp:

(WebCore::Frame::frameScaleFactor):

• page/FrameView.cpp:

(WebCore::FrameView::visibleContentScaleFactor):

• page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

• page/Settings.in:
• platform/ScrollView.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):

2:09 PM Changeset in webkit [158128] by Lucas Forschler

• 2 edits in branches/safari-537.73-branch/Source/WTF

Merged r156933. <rdar://problem/15323812>

2:05 PM Changeset in webkit [158127] by commit-queue@webkit.org

• 22 edits
  3 adds in trunk

Parsing support for -webkit-text-decoration-skip: ink
​https://bugs.webkit.org/show_bug.cgi?id=123358

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-10-28
Reviewed by Dean Jackson.

Source/JavaScriptCore:

Adding ENABLE(CSS3_TEXT_DECORATION)

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Adds initial parsing support for parsing -webkit-text-decoration-skip with
values of "none" and "ink". This work is behind the new
ENABLE(CSS3_TEXT_DECORATION) compile-time flag.

Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html

• Configurations/FeatureDefines.xcconfig: Adding ENABLE(CSS3_TEXT_DECORATION)
• css/CSSComputedStyleDeclaration.cpp: Mapping internal representation of text-decoration-skip

to a CSSValue
(WebCore::renderTextDecorationSkipFlagsToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp: Actually parsing tokens

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextDecorationSkip):

• css/CSSParser.h:
• css/CSSPropertyNames.in: adding -webkit-text-decoration-skip
• css/CSSValueKeywords.in: adding ink
• css/DeprecatedStyleBuilder.cpp: Mapping from CSSValue to internal representation

(WebCore::ApplyPropertyTextDecorationSkip::valueToDecorationSkip):
(WebCore::ApplyPropertyTextDecorationSkip::applyValue):
(WebCore::ApplyPropertyTextDecorationSkip::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

• css/StyleResolver.cpp: decoration-skip uses DeprecatedStyleBuilder

(WebCore::StyleResolver::applyProperty):

• rendering/style/RenderStyle.h: Adding functions for modifying and accessing decoration-skip properties
• rendering/style/RenderStyleConstants.h: Definition of internal representation
• rendering/style/StyleRareInheritedData.cpp: Setting up constructors and comparators

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

• rendering/style/StyleRareInheritedData.h: Holds actual value of internal representation

Source/WebKit/mac:

Adding ENABLE(CSS3_TEXT_DECORATION)

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Adding ENABLE(CSS3_TEXT_DECORATION)

• Configurations/FeatureDefines.xcconfig:

Tools:

Adding ENABLE(CSS3_TEXT_DECORATION)

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Adds a test which makes sure that we can parse the
-webkit-text-decoration-skip CSS property, as well
as values for "ink" and "none". We can use the CSSOM
to test the roundtrip of these values

• fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: Added.

1:59 PM Changeset in webkit [158126] by Lucas Forschler

• 2 edits in branches/safari-537.60-branch/Source/WTF

Merged r156933.

1:56 PM Changeset in webkit [158125] by Lucas Forschler

• 8 edits in branches/safari-537.73-branch/Source/WebKit/win

Merged r154508. <rdar://problem/15109410>

1:30 PM Changeset in webkit [158124] by Lucas Forschler

• 5 edits in branches/safari-537.73-branch/Source/JavaScriptCore

Merged r154366. <rdar://problem/15109352>

1:10 PM Changeset in webkit [158123] by andersca@apple.com

• 6 edits in trunk/Source

RunLoop::dispatch should take an std::function
​https://bugs.webkit.org/show_bug.cgi?id=123407

Reviewed by Andreas Kling.

Source/WebCore:

• WebCore.exp.in:
• platform/RunLoop.cpp:

(WebCore::RunLoop::performWork):
(WebCore::RunLoop::dispatch):

• platform/RunLoop.h:

Source/WTF:

• wtf/FunctionDispatcher.h:

1:01 PM Changeset in webkit [158122] by timothy_horton@apple.com

• 32 edits
  2 deletes in trunk/Source

Make TileController manipulate PlatformCALayers instead of CALayers
​https://bugs.webkit.org/show_bug.cgi?id=123279

Reviewed by Simon Fraser.

In the interest of making TileController more platform-independent
(so that it can be used with the remote layer tree, and maybe Windows),
move TileController onto our PlatformCALayer abstraction instead of
direct manipulation of CALayers.

Some fallout from this includes getting rid of special Mac-specific
TileController-specific CALayer subclasses, and reworking tile
painting to work in a more generic way.

This is a first step, and doesn't get us all the way to a platform independent
TileController, but more patches are forthcoming.

No new tests, just a (largeish) refactor.

• WebCore.exp.in:

The signature of some methods has changed.

• WebCore.xcodeproj/project.pbxproj:

Remove WebTileLayer.*

• page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):
Use the "isTile" key on the CALayer dictionary instead of the layer's
class to determine if it's a tile. TileController will set this on a tile
when it is created, for now.

• platform/graphics/TiledBacking.h:

tiledScrollingIndicatorLayer() should return a PlatformCALayer.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerPaintContents):

• platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount):

• platform/graphics/ca/PlatformCALayerClient.h:

The PlatformCALayerClient paintContents and incrementRepaintCount callbacks
should include the platformCALayer that caused the callback.

• platform/graphics/ca/PlatformCALayer.h:

Add LayerTypeSimpleLayer, which is similar to LayerTypeWebLayer
except it just calls back its client to paint, instead of doing
complicated things with repaint rects. This is so that TileController
doesn't re-enter drawLayerContents when asking its GraphicsLayer
to paint for each PlatformCALayer (it will be entering drawLayerContents
for the first time for each layer). It also happens to be useful
for things like the tile controller overlay, which don't need
all that complication.

Add LayerTypeTiledBackingTileLayer, which is used simply to distinguish
TileController Tile layers from other LayerTypeSimpleLayers.

• platform/graphics/ca/mac/LayerPool.h:
• platform/graphics/ca/mac/LayerPool.mm:

(WebCore::LayerPool::addLayer):
(WebCore::LayerPool::takeLayerWithSize):
LayerPool should operate on PlatformCALayers now.

• platform/graphics/ca/mac/PlatformCALayerMac.h:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::PlatformCALayerMac):
Set the "isTile" key on the CALayer to true for TiledBackingTileLayers,
so that the scrolling performance logging can tell a tile apart from
any other layer, on the scrolling thread, without touching PlatformCALayers
or the TileController or any other main-thread data structures.

(PlatformCALayerMac::setEdgeAntialiasingMask): Added.

• platform/graphics/ca/mac/TileController.h:

Remove references to Objective-C classes; instead use PlatformCALayer everywhere.
TileController is now a PlatformCALayerClient, and the layers it owns are
all PlatformCALayers (and it is constructed with a PlatformCALayer, etc.).
Hand in the tile debug border color as a WebCore color, instead of a CGColorRef.
blankPixelCountForTiles() now operates on a list of PlatformLayers instead of
WebTileLayers specifically, since WebTileLayer is gone.
Make drawTileMapContents private because WebTileCacheMapLayer no longer exists.

(WebCore::TileController::platformCALayerDrawsContent):
All of the layers who have TileController as their client paint their contents.

(WebCore::TileController::platformCALayerContentsOpaque):
This will only be called for layers which paint via drawLayerContents,
so it's OK that we don't special-case the debugging overlay here.

(WebCore::TileController::owningGraphicsLayer):
Return the GraphicsLayer that owns the TileController's main
layer, via its conformance to PlatformCALayerClient. This is
a bit strange (because it's not strictly a GraphicsLayer, despite
always being so at the moment), but is done for clarity inside
TileController itself.

• platform/graphics/ca/mac/TileController.mm:

Remove CALayer (WebCALayerDetails), WebTiledScrollingIndicatorLayer,
and a bunch of includes that we don't need anymore.

(WebCore::TileController::create):
(WebCore::TileController::TileController):
TileController is passed a PlatformCALayer for the tile cache root layer,
instead of a WebTiledBackingLayer. It also creates a PlatformCALayer with
LayerTypeLayer instead of a bare CALayer for the container layer.
It's OK to remove the transaction because it was only used to stop
the implicit animation, which PlatformCALayer will do for us.

(WebCore::TileController::~TileController):
Clear the owner of the PlatformCALayers which the TileController previously owned,
so they don't try to call back a destroyed TileController.

(WebCore::TileController::tileCacheLayerBoundsChanged):
(WebCore::TileController::setNeedsDisplay):
Straightforward adjustments towards use of PlatformCALayer.

(WebCore::TileController::setTileNeedsDisplayInRect):
Adjustments towards use of PlatformCALayer; we need FloatRects so we can
pass pointers to PlatformCALayer::setNeedsDisplay.

(WebCore::TileController::platformCALayerPaintContents):
Replace drawLayer with platformCALayerPaintContents, which will be called
back from our various WebSimpleLayers. If the PlatformCALayer is our
tiled scrolling debug indicator, paint that. Otherwise, it's a tile.
Make use of drawLayerContents() to paint the tile contents.
Make use of drawRepaintIndicator() to paint the repaint indicator if needed.
Move scrolling performance logging code that used to be in WebTileLayer here.

(WebCore::TileController::platformCALayerDeviceScaleFactor):
(WebCore::TileController::platformCALayerShowDebugBorders):
(WebCore::TileController::platformCALayerShowRepaintCounter):
Forward these to the owning GraphicsLayerCA, because it will have the right answers.

(WebCore::TileController::setScale):
Adjustments towards use of PlatformCALayer; remove some code that Simon
caused to be unused in 156291 but did not remove.

(WebCore::TileController::setAcceleratesDrawing):
(WebCore::TileController::setTilesOpaque):
(WebCore::TileController::setVisibleRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::setTileDebugBorderWidth):
(WebCore::TileController::setTileDebugBorderColor):
(WebCore::TileController::bounds):
(WebCore::TileController::blankPixelCount):
(WebCore::TileController::blankPixelCountForTiles):
(WebCore::queueTileForRemoval):
(WebCore::TileController::setNeedsRevalidateTiles):
(WebCore::TileController::ensureTilesForRect):
(WebCore::TileController::retainedTileBackingStoreMemory):
Straightforward adjustments towards use of PlatformCALayer.

(WebCore::TileController::updateTileCoverageMap):
Adjustments towards use of PlatformCALayer; rename backgroundColor
to visibleRectIndicatorColor, since it's actually a border, not a background.

(WebCore::TileController::tiledScrollingIndicatorLayer):
Create a LayerTypeSimpleLayer PlatformCALayer for the tiled scrolling indicator.
It will be asked to paint straightforwardly, like a CALayer would.
Create a LayerTypeLayer PlatformCALayer for the visible rect indicator.
It doesn't need to paint anything, so it doesn't get an owner.

(WebCore::TileController::createTileLayer):
When creating a new tile layer, adopt it by setting its owner.
Otherwise, straightforward adjustments towards use of PlatformCALayer.

(WebCore::TileController::platformCALayerIncrementRepaintCount):
Manage repaint counts for tiles in TileController now.

(WebCore::TileController::drawTileMapContents):
Adjustments towards use of PlatformCALayer.

• platform/graphics/ca/mac/WebTileLayer.h: Removed.
• platform/graphics/ca/mac/WebTileLayer.mm: Removed.

We don't need WebTileLayer anymore, tiles are now just WebSimpleLayers
owned by TileController. Its behavior has been moved into TileController.

• platform/graphics/ca/mac/WebTiledBackingLayer.h:
• platform/graphics/ca/mac/WebTiledBackingLayer.mm:

(-[WebTiledBackingLayer createTileController:]):
Add createTileController: so that the WebTiledBackingLayer's owner can
hand the TileController the PlatformCALayer for the WebTiledBackingLayer
without propagating additional usage of PlatformCALayer::platformCALayer(),
which we need to remove in light of the remote layer tree work.

(-[WebTiledBackingLayer setBorderColor:]):

• platform/graphics/ca/win/PlatformCALayerWin.h:

Add an empty implementation of setEdgeAntialiasingMask.
We'll probably want to implement it before adopting TileController on Windows.

• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::displayCallback):

• platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerPaintContents):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerIncrementRepaintCount):

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerPaintContents):
(WebCore::LayerClient::platformCALayerIncrementRepaintCount):
Adjust for new parameters on PlatformCALayerClient callbacks.

• platform/graphics/mac/WebLayer.h:

Add WebSimpleLayer, which inherits directly from CALayer, and make
our standard WebLayer (which is used for compositing layers in web content)
inherit from that.

• platform/graphics/mac/WebLayer.mm:

Move most of the behavior of WebLayer onto WebSimpleLayer, except for its
complex painting code. That stays as an override on WebLayer.

(WebCore::drawLayerContents):
Use the PlatformCALayer's PlatformLayer - if it exists - to extract
fine-grained repaint rects. If it doesn't, we'll just use the CGContext's
clip rect as our single repaint rect.
Rename platformLayer to platformCALayer for accuracy.
Remove special code for CATiledLayer since we ought not use it on Mac anymore.

(WebCore::drawRepaintIndicator):
Factor repaint indicator code out into its own function so that TileController
can use it. It can't be called from drawLayerContents for TileController, since
the PlatformCALayer that TileController passes in to drawLayerContents is actually
that of the tile cache's root layer, not the tile itself.
Also, add a custom background color parameter so TileController can override
the default green color with its own standard purple.

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer drawInContext:]):

• platform/graphics/mac/WebTiledLayer.mm:

(-[WebTiledLayer drawInContext:]):
Removed a param from drawLayerContents because it's trivially acquirable
from the PlatformCALayer.

• FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerPaintContents):
(FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
Adjust for new parameters on PlatformCALayerClient callbacks.

• Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::dump):
Support the new LayerTypes.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::setEdgeAntialiasingMask):

• WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Add an empty implementation of setEdgeAntialiasingMask.

• WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::display):
Removed a parameter from drawLayerContents.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateDebugInfoLayer):
TiledCoreAnimationDrawingArea still operates in terms of CALayers, so
grab the PlatformLayer out from TileController's indicator.

12:22 PM Changeset in webkit [158121] by weinig@apple.com

• 7 edits in trunk/Source/WebCore

Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
​https://bugs.webkit.org/show_bug.cgi?id=123318

Reviewed by David Hyatt.

• rendering/LineLayoutState.h:

Move FloatWithRect from RenderBlock.

• rendering/RenderBlock.cpp:
• rendering/RenderBlock.h:
• rendering/RenderBlockFlow.cpp:
• rendering/RenderBlockFlow.h:
• rendering/RenderBlockLineLayout.cpp:

Move pagination and float functions.

11:48 AM Changeset in webkit [158120] by Simon Fraser

• 2 edits in trunk/LayoutTests

Expunge Lion and SnowLeopard from TestExpectations.

• platform/mac/TestExpectations:

11:46 AM Changeset in webkit [158119] by Simon Fraser

• 2 edits in trunk/LayoutTests

Some test expectations for Mavericks.

• platform/mac/TestExpectations:

11:42 AM Changeset in webkit [158118] by Lucas Forschler

• 2 edits in trunk/Tools

Add additional Apple Mavericks test bots.

Unreviewed.

• BuildSlaveSupport/build.webkit.org-config/config.json:

11:31 AM Changeset in webkit [158117] by mark.lam@apple.com

• 5 edits
  6 copies in branches/safari-537.73-branch

Merge r155471.
​https://bugs.webkit.org/show_bug.cgi?id=123409.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Re-implemented fix based on the frame iteration mechanhism before the
StackVisitor was available.

2013-09-10 Joseph Pecoraro <Joseph Pecoraro>

Web Inspector: [JSC] Caught exception is treated as uncaught
​https://bugs.webkit.org/show_bug.cgi?id=93607

Reviewed by Geoff Garen.

Check up the entire call stack to see if there is an exception handler.

• interpreter/Interpreter.cpp: (JSC::GetExceptionHandlerFunctor::GetExceptionHandlerFunctor): (JSC::GetExceptionHandlerFunctor::handler): (JSC::GetExceptionHandlerFunctor::operator()):

LayoutTests:

Re-based test results from merge.

• http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.checkForError): This is needed for the merged tests.

2013-09-10 Joseph Pecoraro <Joseph Pecoraro>

Web Inspector: [JSC] Caught exception is treated as uncaught
​https://bugs.webkit.org/show_bug.cgi?id=93607

Reviewed by Geoff Garen.

Add tests for different inspector pause on exceptions states.

• inspector-protocol/debugger/resources/exception.js: Added.
• inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt: Added.
• inspector-protocol/debugger/setPauseOnExceptions-all.html: Added.
• inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt: Added.
• inspector-protocol/debugger/setPauseOnExceptions-none.html: Added.
• inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt: Added.
• inspector-protocol/debugger/setPauseOnExceptions-uncaught.html: Added.

11:03 AM Changeset in webkit [158116] by fpizlo@apple.com

• 16 edits in trunk/Source/JavaScriptCore

Get rid of InlineStart so that I don't have to implement it in FTL
​https://bugs.webkit.org/show_bug.cgi?id=123302

Reviewed by Geoffrey Garen.

InlineStart was a special instruction that we would insert at the top of inlined code,
so that the backend could capture the OSR state of arguments to an inlined call. It used
to be that only the backend had this information, so this instruction was sort of an ugly
callback from the backend for filling in some data structures.

But in the time since when that code was written (two years ago?), we rationalized how
variables work. It's now the case that variables that the runtime must know about are
treated specially in IR (they are "flushed") and we know how we will represent them even
before we get to the backend. The last place that makes changes to their representation
is the StackLayoutPhase.

So, this patch gets rid of InlineStart, but keeps around the special meta-data that the
instruction had. Instead of handling the bookkeeping in the backend, we handle it in
StackLayoutPhase. This means that the DFG and FTL can share code for handling this
bookkeeping. This also means that now the FTL can compile code blocks that had inlining.

Of course, giving the FTL the ability to handle code blocks that had inlining means that
we're going to have new bugs. Sure enough, the FTL's linker didn't handle inline call
frames. This patch also fixes that.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.h:
• dfg/DFGNode.h:
• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:
• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

10:35 AM Changeset in webkit [158115] by svillar@igalia.com

• 10 edits
  6 adds in trunk

[CSS Grid Layout] Add support for order inside grid items
​https://bugs.webkit.org/show_bug.cgi?id=123208

Reviewed by Antti Koivisto.

Source/WebCore:

Based on Blink r153457 and r153536 by <​jchaffraix@chromium.org>

Added support for sorting grid items by using -webkit-order
property. Used OrderIterator to implement it so it had to be moved
out of RenderFlexibleBox to be shared with RenderGrid.

Tests: fast/css-grid-layout/grid-item-order-auto-flow-resolution.html

fast/css-grid-layout/grid-item-order-paint-order.html

• CMakeLists.txt: Added new file.
• GNUmakefile.list.am: Ditto.
• WebCore.vcxproj/WebCore.vcxproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• rendering/OrderIterator.cpp: Added. Ripped out of RenderFlexibleBox.

(WebCore::OrderIterator::OrderIterator):
(WebCore::OrderIterator::setOrderValues): Use std::move semantics.
(WebCore::OrderIterator::first): Use an integer as iterator.
(WebCore::OrderIterator::next): Ditto.
(WebCore::OrderIterator::reset): Ditto.

• rendering/OrderIterator.h: Added.

(WebCore::OrderIterator::currentChild):

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::layoutBlock):

• rendering/RenderFlexibleBox.h:
• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::RenderGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::paintChildren):

• rendering/RenderGrid.h:

LayoutTests:

From Blink r153536 by <​jchaffraix@chromium.org>

Added a couple of tests to verify that we respect the specified
order of grid items both in the auto-placement algorithm and in
the final painting.

• fast/css-grid-layout/grid-item-order-auto-flow-resolution-expected.txt: Added.
• fast/css-grid-layout/grid-item-order-auto-flow-resolution.html: Added.
• fast/css-grid-layout/grid-item-order-paint-order-expected.html: Added.
• fast/css-grid-layout/grid-item-order-paint-order.html: Added.

10:20 AM Changeset in webkit [158114] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

The GetById->GetByOffset AI-based optimization should actually do things
​https://bugs.webkit.org/show_bug.cgi?id=123299

Reviewed by Oliver Hunt.

20% speed-up on Octane/gbemu.

• bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor): Actually finish filling in the Status by setting the state. Previously it would remain set to NoInformation, meaning that this whole method was a no-op.

9:15 AM Changeset in webkit [158113] by commit-queue@webkit.org

• 337 edits in trunk

Methods on window.internals shouldn't pass a document.
​https://bugs.webkit.org/show_bug.cgi?id=107301

Patch by Afonso R. Costa Jr. <​afonso.costa@samsung.com> on 2013-10-28
Reviewed by Alexey Proskuryakov.

Each 'Internals' instance is associated with a 'Document'. So, it
is not necessary to pass a document as argument. Only nodesFromRect and
layerTreeAsText methods were kept because, in some Layout Tests, the
'Document' object is not the same used by Internals::contextDocument.

Source/WebCore:

• testing/Internals.cpp: Removed 'document' parameter.

(WebCore::Internals::animationsAreSuspended):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::setScrollViewPosition):
(WebCore::Internals::setPagination):
(WebCore::Internals::configurationForViewport):
(WebCore::Internals::paintControlTints):
(WebCore::Internals::setDelegatesScrolling):
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::touchNodeAdjustedToBestClickableNode):
(WebCore::Internals::touchPositionAdjustedToBestContextMenuNode):
(WebCore::Internals::touchNodeAdjustedToBestContextMenuNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):
(WebCore::Internals::lastSpellCheckRequestSequence):
(WebCore::Internals::lastSpellCheckProcessedSequence):
(WebCore::Internals::wheelEventHandlerCount):
(WebCore::Internals::touchEventHandlerCount):
(WebCore::Internals::setBatteryStatus):
(WebCore::Internals::setNetworkInformation):
(WebCore::Internals::setDeviceProximity):
(WebCore::Internals::hasSpellingMarker):
(WebCore::Internals::hasAutocorrectedMarker):
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore::Internals::toggleOverwriteModeEnabled):
(WebCore::Internals::consoleMessageArgumentCounts):
(WebCore::Internals::hasGrammarMarker):
(WebCore::Internals::numberOfScrollableAreas):
(WebCore::Internals::isPageBoxVisible):
(WebCore::Internals::repaintRectsAsText):
(WebCore::Internals::scrollingStateTreeAsText):
(WebCore::Internals::mainThreadScrollingReasons):
(WebCore::Internals::nonFastScrollableRects):
(WebCore::Internals::garbageCollectDocumentResources):
(WebCore::Internals::insertAuthorCSS):
(WebCore::Internals::insertUserCSS):
(WebCore::Internals::shortcutIconURLs):
(WebCore::Internals::allIconURLs):
(WebCore::Internals::setHeaderHeight):
(WebCore::Internals::setFooterHeight):
(WebCore::Internals::webkitWillEnterFullScreenForElement):
(WebCore::Internals::webkitDidEnterFullScreenForElement):
(WebCore::Internals::webkitWillExitFullScreenForElement):
(WebCore::Internals::webkitDidExitFullScreenForElement):
(WebCore::Internals::startTrackingRepaints):
(WebCore::Internals::stopTrackingRepaints):
(WebCore::Internals::getCurrentCursorInfo):

• testing/Internals.h:

(WebCore::Internals::setPagination):

• testing/Internals.idl:

LayoutTests:

• animations/added-while-suspended.html: Removed 'document' parameter.
• animations/play-state-suspend.html:
• animations/stop-animation-on-suspend.html:
• animations/suspend-resume-animation-events.html:
• animations/suspend-resume-animation.html:
• animations/suspend-transform-animation.html:
• batterystatus/resources/event-after-navigation-new.html:
• batterystatus/script-tests/add-listener-from-callback.js:

(firstListener):

• batterystatus/script-tests/basic-all-types-of-events.js:
• batterystatus/script-tests/basic-operation.js:
• batterystatus/script-tests/multiple-frames.js:
• batterystatus/script-tests/updates.js:

(setBatteryStatus):

• compositing/columns/ancestor-clipped-in-paginated.html:
• compositing/columns/clipped-in-paginated.html:
• compositing/columns/composited-columns-vertical-rl.html:
• compositing/columns/composited-in-paginated-rl.html:
• compositing/columns/composited-in-paginated-writing-mode-rl.html:
• compositing/columns/composited-in-paginated.html:
• compositing/columns/composited-lr-paginated-repaint.html:
• compositing/columns/composited-rl-paginated-repaint.html:
• compositing/columns/geometry-map-paginated-assert.html:
• compositing/columns/hittest-composited-in-paginated.html:
• compositing/columns/rotated-in-paginated.html:
• compositing/columns/untransformed-composited-in-paginated.html:
• compositing/iframes/iframe-composited-scrolling.html:
• compositing/layer-creation/fixed-position-in-view-dynamic.html:
• compositing/layer-creation/fixed-position-no-content-scroll-reason.html:
• compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
• compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
• compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
• compositing/overflow/dynamic-composited-scrolling-status.html:
• compositing/overflow/scrolling-without-painting.html:
• compositing/overflow/updating-scrolling-content.html:
• compositing/repaint/absolute-painted-into-composited-ancestor.html:
• compositing/repaint/fixed-background-scroll.html:
• compositing/repaint/invalidations-on-composited-layers.html:
• compositing/repaint/positioned-movement.html:
• compositing/repaint/repaint-on-layer-grouping-change.html:
• compositing/repaint/resize-repaint.html:
• compositing/repaint/scroll-fixed-layer-no-content.html:
• compositing/repaint/scroll-fixed-layer-out-of-view.html:
• editing/caret/selection-with-caret-type-progress.html:
• editing/execCommand/overtype.html:
• editing/selection/block-cursor-overtype-mode.html:
• editing/spelling/design-mode-spellcheck-off.html:
• editing/spelling/grammar-edit-word-expected.txt:
• editing/spelling/grammar-edit-word.html:
• editing/spelling/grammar-markers-hidpi.html:
• editing/spelling/grammar-markers.html:
• editing/spelling/grammar.html:
• editing/spelling/script-tests/spellcheck-paste.js:

(verifyMarker):

• editing/spelling/script-tests/spelling-attribute-at-child.js:

(childHasSpellingMarker):

• editing/spelling/script-tests/spelling-attribute-change.js:

(testSpellCheckingEnabled):

• editing/spelling/script-tests/spelling-backspace-between-lines.js:

(testWithDelete):
(testWithForwardDelete):

• editing/spelling/script-tests/spelling-hasspellingmarker.js:

(hasMarked):

• editing/spelling/spellcheck-async-mutation.html:
• editing/spelling/spellcheck-attribute-expected.txt:
• editing/spelling/spellcheck-attribute.html:
• editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
• editing/spelling/spellcheck-paste-continuous-disabled.html:
• editing/spelling/spellcheck-paste-disabled-expected.txt:
• editing/spelling/spellcheck-paste-disabled.html:
• editing/spelling/spellcheck-sequencenum.html:
• editing/spelling/spelling-attribute-change-expected.txt:
• editing/spelling/spelling-backspace-between-lines-expected.txt:
• editing/spelling/spelling-linebreak.html:
• fast/box-shadow/shadow-repaint.html:
• fast/css/webkit-mask-crash-fieldset-legend.html:
• fast/css/webkit-mask-crash-figure.html:
• fast/css/webkit-mask-crash-table.html:
• fast/css/webkit-mask-crash-td-2.html:
• fast/css/webkit-mask-crash-td.html:
• fast/dom/icon-url-change.html:
• fast/dom/icon-url-list-apple-touch.html:
• fast/dom/icon-url-list.html:
• fast/dom/icon-url-property.html:
• fast/events/mouse-cursor-change.html:
• fast/events/mouse-cursor-image-set.html:
• fast/events/mouse-cursor-multiframecur.html:
• fast/events/mouse-cursor-no-mousemove.html:
• fast/events/mouse-cursor.html:
• fast/events/touch/touch-handler-count-expected.txt:
• fast/events/touch/touch-handler-count.html:
• fast/events/touch/touch-input-element-change-documents-expected.txt:
• fast/events/touch/touch-input-element-change-documents.html:
• fast/multicol/hit-test-gap-between-pages-flipped.html:
• fast/multicol/hit-test-gap-between-pages.html:
• fast/multicol/pagination-h-horizontal-bt.html:
• fast/multicol/pagination-h-horizontal-tb.html:
• fast/multicol/pagination-h-vertical-lr.html:
• fast/multicol/pagination-h-vertical-rl.html:
• fast/multicol/pagination-v-horizontal-bt.html:
• fast/multicol/pagination-v-horizontal-tb.html:
• fast/multicol/pagination-v-vertical-lr.html:
• fast/multicol/pagination-v-vertical-rl.html:
• fast/multicol/pagination/BottomToTop-bt.html:
• fast/multicol/pagination/BottomToTop-lr.html:
• fast/multicol/pagination/BottomToTop-rl.html:
• fast/multicol/pagination/BottomToTop-tb.html:
• fast/multicol/pagination/LeftToRight-bt.html:
• fast/multicol/pagination/LeftToRight-lr.html:
• fast/multicol/pagination/LeftToRight-rl.html:
• fast/multicol/pagination/LeftToRight-tb.html:
• fast/multicol/pagination/RightToLeft-bt.html:
• fast/multicol/pagination/RightToLeft-lr.html:
• fast/multicol/pagination/RightToLeft-rl.html:
• fast/multicol/pagination/RightToLeft-tb.html:
• fast/multicol/pagination/TopToBottom-bt.html:
• fast/multicol/pagination/TopToBottom-lr.html:
• fast/multicol/pagination/TopToBottom-rl.html:
• fast/multicol/pagination/TopToBottom-tb.html:
• fast/multicol/shrink-to-column-height-for-pagination.html:
• fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
• fast/repaint/obscured-background-no-repaint.html:
• fast/repaint/resources/text-based-repaint.js:

(runRepaintTest):

• fast/scrolling/resources/scrollable-area.js:

(end):

• fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html:
• fast/viewport/viewport-1.html:
• fast/viewport/viewport-10.html:
• fast/viewport/viewport-100.html:
• fast/viewport/viewport-101.html:
• fast/viewport/viewport-102.html:
• fast/viewport/viewport-103.html:
• fast/viewport/viewport-104.html:
• fast/viewport/viewport-105.html:
• fast/viewport/viewport-106.html:
• fast/viewport/viewport-107.html:
• fast/viewport/viewport-108.html:
• fast/viewport/viewport-109.html:
• fast/viewport/viewport-11.html:
• fast/viewport/viewport-110.html:
• fast/viewport/viewport-111.html:
• fast/viewport/viewport-112.html:
• fast/viewport/viewport-113.html:
• fast/viewport/viewport-114.html:
• fast/viewport/viewport-115.html:
• fast/viewport/viewport-116.html:
• fast/viewport/viewport-117.html:
• fast/viewport/viewport-118.html:
• fast/viewport/viewport-119.html:
• fast/viewport/viewport-12.html:
• fast/viewport/viewport-120.html:
• fast/viewport/viewport-121.html:
• fast/viewport/viewport-122.html:
• fast/viewport/viewport-123.html:
• fast/viewport/viewport-124.html:
• fast/viewport/viewport-125.html:
• fast/viewport/viewport-126.html:
• fast/viewport/viewport-127.html:
• fast/viewport/viewport-128.html:
• fast/viewport/viewport-129.html:
• fast/viewport/viewport-13.html:
• fast/viewport/viewport-130.html:
• fast/viewport/viewport-131.html:
• fast/viewport/viewport-132.html:
• fast/viewport/viewport-133.html:
• fast/viewport/viewport-134.html:
• fast/viewport/viewport-14.html:
• fast/viewport/viewport-15.html:
• fast/viewport/viewport-16.html:
• fast/viewport/viewport-17.html:
• fast/viewport/viewport-18.html:
• fast/viewport/viewport-19.html:
• fast/viewport/viewport-2.html:
• fast/viewport/viewport-20.html:
• fast/viewport/viewport-21.html:
• fast/viewport/viewport-22.html:
• fast/viewport/viewport-23.html:
• fast/viewport/viewport-24.html:
• fast/viewport/viewport-25.html:
• fast/viewport/viewport-26.html:
• fast/viewport/viewport-27.html:
• fast/viewport/viewport-28.html:
• fast/viewport/viewport-29.html:
• fast/viewport/viewport-3.html:
• fast/viewport/viewport-30.html:
• fast/viewport/viewport-31.html:
• fast/viewport/viewport-32.html:
• fast/viewport/viewport-33.html:
• fast/viewport/viewport-34.html:
• fast/viewport/viewport-35.html:
• fast/viewport/viewport-36.html:
• fast/viewport/viewport-37.html:
• fast/viewport/viewport-38.html:
• fast/viewport/viewport-39.html:
• fast/viewport/viewport-4.html:
• fast/viewport/viewport-40.html:
• fast/viewport/viewport-41.html:
• fast/viewport/viewport-42.html:
• fast/viewport/viewport-43.html:
• fast/viewport/viewport-44.html:
• fast/viewport/viewport-45.html:
• fast/viewport/viewport-46.html:
• fast/viewport/viewport-47.html:
• fast/viewport/viewport-48.html:
• fast/viewport/viewport-49.html:
• fast/viewport/viewport-5.html:
• fast/viewport/viewport-50.html:
• fast/viewport/viewport-51.html:
• fast/viewport/viewport-52.html:
• fast/viewport/viewport-53.html:
• fast/viewport/viewport-54.html:
• fast/viewport/viewport-55.html:
• fast/viewport/viewport-56.html:
• fast/viewport/viewport-57.html:
• fast/viewport/viewport-58.html:
• fast/viewport/viewport-59.html:
• fast/viewport/viewport-6.html:
• fast/viewport/viewport-60.html:
• fast/viewport/viewport-61.html:
• fast/viewport/viewport-62.html:
• fast/viewport/viewport-63.html:
• fast/viewport/viewport-64.html:
• fast/viewport/viewport-65.html:
• fast/viewport/viewport-66.html:
• fast/viewport/viewport-67.html:
• fast/viewport/viewport-68.html:
• fast/viewport/viewport-69.html:
• fast/viewport/viewport-7.html:
• fast/viewport/viewport-70.html:
• fast/viewport/viewport-71.html:
• fast/viewport/viewport-72.html:
• fast/viewport/viewport-73.html:
• fast/viewport/viewport-74.html:
• fast/viewport/viewport-75.html:
• fast/viewport/viewport-76.html:
• fast/viewport/viewport-77.html:
• fast/viewport/viewport-78.html:
• fast/viewport/viewport-79.html:
• fast/viewport/viewport-8.html:
• fast/viewport/viewport-80.html:
• fast/viewport/viewport-81.html:
• fast/viewport/viewport-82.html:
• fast/viewport/viewport-83.html:
• fast/viewport/viewport-84.html:
• fast/viewport/viewport-85.html:
• fast/viewport/viewport-86.html:
• fast/viewport/viewport-87.html:
• fast/viewport/viewport-88.html:
• fast/viewport/viewport-9.html:
• fast/viewport/viewport-90.html:
• fast/viewport/viewport-91.html:
• fast/viewport/viewport-legacy-handheldfriendly.html:
• fast/viewport/viewport-legacy-mobileoptimized-2.html:
• fast/viewport/viewport-legacy-mobileoptimized-3.html:
• fast/viewport/viewport-legacy-mobileoptimized.html:
• fast/viewport/viewport-legacy-ordering-1.html:
• fast/viewport/viewport-legacy-ordering-2.html:
• fast/viewport/viewport-legacy-ordering-3.html:
• fast/viewport/viewport-legacy-ordering-4.html:
• fast/viewport/viewport-legacy-ordering-5.html:
• fast/viewport/viewport-legacy-ordering-6.html:
• fast/viewport/viewport-legacy-ordering-7.html:
• fast/viewport/viewport-legacy-ordering-8.html:
• fast/viewport/viewport-legacy-ordering-9.html:
• fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html:
• fast/viewport/viewport-legacy-xhtmlmp-ordering.html:
• fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:
• fast/viewport/viewport-legacy-xhtmlmp.html:
• fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
• fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:
• fast/viewport/viewport-warnings-1.html:
• fast/viewport/viewport-warnings-2.html:
• fast/viewport/viewport-warnings-3.html:
• fast/viewport/viewport-warnings-4.html:
• fast/viewport/viewport-warnings-5.html:
• fast/viewport/viewport-warnings-6.html:
• fullscreen/video-cursor-auto-hide-expected.txt:
• fullscreen/video-cursor-auto-hide.html:
• http/tests/inspector-enabled/resources/console-clear-arguments-test.js:

(dumpConsoleMessageArgumentCounts):

• http/tests/inspector/elements-test.js:
• networkinformation/resources/event-after-navigation-new.html:
• networkinformation/script-tests/add-listener-from-callback.js:

(firstListener):

• networkinformation/script-tests/basic-all-types-of-events.js:
• networkinformation/script-tests/basic-operation.js:
• networkinformation/script-tests/multiple-frames.js:
• networkinformation/script-tests/updates.js:

(setNetworkInformation):

• platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
• platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html:
• platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html:
• platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html:
• platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html:
• platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html:
• platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html:
• platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:
• platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
• platform/mac-wk2/tiled-drawing/fixed/four-bars.html:
• platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html:
• platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html:
• platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html:
• platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html:
• platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame.html:
• platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html:
• platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing.html:
• platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html:
• platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html:
• platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html:
• platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html:
• platform/mac-wk2/tiled-drawing/slow-scrolling.html:
• platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html:
• platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html:
• platform/mac-wk2/tiled-drawing/sticky/sticky-vertical.html:
• platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
• platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
• platform/mac/editing/spelling/delete-into-misspelled-word.html:
• platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
• platform/mac/editing/spelling/editing-word-with-marker-1.html:
• platform/mac/editing/spelling/editing-word-with-marker-2.html:
• platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
• platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
• printing/page-format-data-expected.txt:
• printing/page-format-data.html:
• proximity/add-listener-from-callback.html:
• proximity/basic-operation.html:
• proximity/multiple-frames.html:
• proximity/resources/event-after-navigation-new.html:
• proximity/updates.html:
• scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:

(runNonFastScrollableRegionTest):

• touchadjustment/big-div.html:
• touchadjustment/event-triggered-widgets.html:
• touchadjustment/iframe.html:
• touchadjustment/nested-shadow-node.html:
• touchadjustment/resources/touchadjustment.js:

(testTouchPoint):
(testTouchPointContextMenu):
(adjustTouchPoint):
(adjustTouchPointContextMenu):

• touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html:
• touchadjustment/scroll-offset.html:
• touchadjustment/search-cancel.html:
• touchadjustment/zoom-basic.html:
• touchadjustment/zoom-fatfinger.html:
• transitions/created-while-suspended.html:
• transitions/started-while-suspended.html:
• transitions/suspend-transform-transition.html:
• userscripts/insert-stylesheets.html:

9:11 AM Changeset in webkit [158112] by calvaris@igalia.com

• 10 edits
  2 deletes in trunk

Remove HTMLMediaElement.startTime
​https://bugs.webkit.org/show_bug.cgi?id=123264

Reviewed by Eric Carlson.

Source/WebCore:

Patch based on one by: ​philipj@opera.com
Blink review URL: ​https://codereview.chromium.org/32583003

startTime has been removed from the HTMLMediaElement and its use
in the rest of components.

• Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handleRewindButtonClicked):
(Controller.prototype.handleTimelineMouseMove):
(Controller.prototype.updateDuration):
(Controller.prototype.updateTime): Removed used of startTime().

• bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_media_element_get_start_time):

• bindings/gobject/WebKitDOMCustom.h:
• bindings/gobject/WebKitDOMCustom.symbols: Added phony function.
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::isBlockedOnMediaController): Removed
use of startTime()

• html/HTMLMediaElement.h:
• html/HTMLMediaElement.idl: Removed startTime()
• rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::paintSliderThumb): Removed use of
startTime()

LayoutTests:

Removed test about startTime.

Blink review URL: ​https://codereview.chromium.org/32583003

• media/media-startTime-expected.txt: Removed.
• media/media-startTime.html: Removed.

8:48 AM Changeset in webkit [158111] by akling@apple.com

• 5 edits in trunk/Source

RenderElement::m_style should be a Ref.
<​https://webkit.org/b/123401>

Source/WebCore:

Made RenderElement::m_style a Ref. This codifies the fact that it
can never be null after construction.

Removed a couple of unnecessary null checks that were exposed as
compilation failures.

Reviewed by Antti Koivisto.

Source/WTF:

Added a Ref::replace() so we can Indiana Jones the new style in
RenderElement::setStyle() while keeping a handle on the old style
for a while longer.

Reviewed by Antti Koivisto.

8:22 AM Changeset in webkit [158110] by commit-queue@webkit.org

• 16 edits in trunk

Name all the GLib timeout sources
​https://bugs.webkit.org/show_bug.cgi?id=123229

Patch by Bastien Nocera <​hadess@hadess.net> on 2013-10-28
Reviewed by Anders Carlsson.

Source/WebCore:

Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.

No new tests, no change in functionality.

Source/WebKit/gtk:

Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.

Source/WebKit2:

Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.

Tools:

Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.

8:16 AM Changeset in webkit [158109] by Philippe Normand

• 2 edits in trunk/Source/WebCore

MediaStreamTrackPrivate's m_client uninitialized
​https://bugs.webkit.org/show_bug.cgi?id=123403

Reviewed by Eric Carlson.

No new tests, no change in functionality.

• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
Initialize the m_client member variable.

6:44 AM Changeset in webkit [158108] by Carlos Garcia Campos

• 9 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

• GNUmakefile.list.am: Add missing files to compilation.

Source/WebCore:

• GNUmakefile.am: Add crypto idl files to EXTRA_DIST and remove

css/fullscreenQuickTime.css that was removed.

Source/WebKit2:

• GNUmakefile.am: Add messages.in files in

UIProcess/Network/CustomProtocols/ to EXTRA_DIST.

• GNUmakefile.list.am: Remove

WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp from
compilation because it depends on code generated only when
database process is enabled.

Source/WTF:

• GNUmakefile.list.am: Remove unexistent file from compilation.

6:39 AM Changeset in webkit [158107] by Antti Koivisto

• 13 edits in trunk/Source/WebCore

Prepare simple line layout to support multiple runs per line
​https://bugs.webkit.org/show_bug.cgi?id=123400

Reviewed by Andreas Kling.

Bunch of renaming and some refactoring for future support for text runs.

SimpleLineLayout::Lines -> SimpleLineLayout::Layout and becomes a class instead of a typedef.
SimpleLineLayout::Resolver::Line -> SimpleLineLayout::Resolver::Run
SimpleLineLayout::createLines() -> SimpleLineLayout::create()
RenderBlockFlow::simpleLines() -> RenderBlockFlow::simpleLineLayout()
RenderText::simpleLines() -> RenderText::simpleLineLayout()

Added resolver construction functions:

SimpleLineLayout::runResolver()
SimpleLineLayout::lineResolver()

5:32 AM Changeset in webkit [158106] by gyuyoung.kim@samsung.com

• 3 edits in trunk/LayoutTests

Unreviewed, EFL gardening.

fast/canvas/webgl/drawingbuffer-test.html is passing on efl-wk2.
Move it to efl-wk1 TestExpectations file.

• platform/efl-wk1/TestExpectations:
• platform/efl/TestExpectations:

3:36 AM Changeset in webkit [158105] by berto@igalia.com

• 4 edits in trunk/Source/WebKit2

[WK2] [GTK] Allow running the web process with an arbitrary prefix command
​https://bugs.webkit.org/show_bug.cgi?id=123201

Reviewed by Carlos Garcia Campos.

Launch the web process using WEB_PROCESS_CMD_PREFIX as a
prefix. Useful for debugging the web process with gdb, valgrind,
etc.

• UIProcess/Launcher/ProcessLauncher.h:
• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/gtk/WebProcessProxyGtk.cpp:

(WebKit::WebProcessProxy::platformGetLaunchOptions):

2:57 AM Changeset in webkit [158104] by mario@webkit.org

• 5 edits
  1 move
  1 delete in trunk

[GTK] Expose title and alternative text for links in image maps
​https://bugs.webkit.org/show_bug.cgi?id=84045

Reviewed by Chris Fleizach.

Source/WebCore:

Change the way we decide when the title attribute should be
used for the accessible description, by not relying in the
titleTagShouldBeUsedInDescriptionField() helper function but
in whether we have found a visible text for it or not.

This actually mimics what the Mac port does and so makes possible
to share both the layout test and its expected results.

• accessibility/atk/WebKitAccessibleUtil.cpp:

(accessibilityDescription): Update the method to determine
whether the title attribute should be used for the description.

LayoutTests:

Share test expectations among Mac, GTK and EFL ports and
remove expected failures for GTK and EFL.

• accessibility/image-map1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/image-map1-expected.txt.
• platform/gtk/accessibility/image-map1-expected.txt: Removed.
• platform/efl/TestExpectations: Removed failure expectations.
• platform/gtk/TestExpectations: Ditto.

2:29 AM Changeset in webkit [158103] by commit-queue@webkit.org

• 12 edits in trunk

Replace 0 timeouts g_timeout_add() by g_idle_add()
​https://bugs.webkit.org/show_bug.cgi?id=123260

Patch by Bastien Nocera <​hadess@hadess.net> on 2013-10-28
Reviewed by Carlos Garcia Campos.

A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
without the nagging feeling that the wrong API was used.

Source/WebCore:

No new tests, no change in functionality.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Use g_idle_add() instead

of 0-timer.
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Ditto.

(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):

• platform/gtk/GtkDragAndDropHelper.cpp: Ditto.

(WebCore::GtkDragAndDropHelper::handleDragLeave):

Source/WebKit/gtk:

• WebCoreSupport/ChromeClientGtk.cpp: Use g_idle_add() instead

of 0-timer.
(WebKit::ChromeClient::closeWindowSoon):
(WebKit::ChromeClient::widgetSizeChanged):

• WebCoreSupport/GtkAdjustmentWatcher.cpp: Ditto.

(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):

• webkit/webkitwebview.cpp: Ditto.

(webkit_web_view_get_subresources):

Source/WTF:

• wtf/gtk/MainThreadGtk.cpp: Use g_idle_add() instead

of 0-timer.
(WTF::scheduleDispatchFunctionsOnMainThread):

Tools:

• DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead

of 0-timer.
(topLoadingFrameLoadFinished):

• DumpRenderTree/gtk/EventSender.cpp: Ditto.

(scheduleAsynchronousClickCallback):
(scheduleAsynchronousKeyDownCallback):

12:29 AM Changeset in webkit [158102] by zandobersek@gmail.com

• 4 edits in trunk/Source

Re-enable simple line layout for GTK
​https://bugs.webkit.org/show_bug.cgi?id=123388

Reviewed by Andreas Kling.

Source/WebCore:

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for the GTK port, so the port
can use the simple line layout.

Source/WTF:

• wtf/FeatureDefines.h: Enable the 8-bit TextRun support for the GTK port.

Oct 27, 2013:

10:42 PM Changeset in webkit [158101] by beidson@apple.com

• 5 edits in trunk/Source/WebKit2

WebIconDatabase can miss private browsing state changes.
<rdar://problem/15322318> and ​https://bugs.webkit.org/show_bug.cgi?id=123375

Reviewed by Alexey Proskuryakov.

• UIProcess/WebContext.cpp:

(WebKit::WebContext::willStartUsingPrivateBrowsing): Call setAnyPageGroupMightHavePrivateBrowsingEnabled(true) on each context.
(WebKit::WebContext::willStopUsingPrivateBrowsing): Call setAnyPageGroupMightHavePrivateBrowsingEnabled(false) on each context.
(WebKit::WebContext::setPrivateBrowsingEnabled): In addition to notifying other processes about private browsing

sessions, notify the context’s WebIconDatabase about the change in value.

• UIProcess/WebContext.h:

• UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setDatabasePath): Prime the IconDatabase with an initial private browsing value.
(WebKit::WebIconDatabase::setAnyPageGroupMightHavePrivateBrowsingEnabled):

• UIProcess/WebIconDatabase.h:

6:59 PM Changeset in webkit [158100] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Fix 4 asserting SVG tests after r158097.

RenderElement::setStyle() is, quite surprisingly, a virtual function
with a single override in RenderSVGBlock.
To match the old behavior, we have to rewrite the display type from
any inline type to block instead.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::initializeStyle):

5:17 PM Changeset in webkit [158099] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Tone down overzealous assertion from r158097.

RenderElement::initializeStyle() really only cares that there are no
text renderers that we should be calling styleDidChange() on.

Tweak the code to only check that there are no text children.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::initializeStyle):

4:06 PM Changeset in webkit [158098] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Enable center and right text alignment for simple lines
​https://bugs.webkit.org/show_bug.cgi?id=123398

Reviewed by Andreas Kling.

Support text-align:center and text-align:right on simple line layout path.

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

text-align:justify is still not supported.

(WebCore::SimpleLineLayout::computeLineLeft):
(WebCore::SimpleLineLayout::createLines):

Do a rounding dance that matches the line boxes.

• rendering/SimpleLineLayout.h:

Add left position to lines.

• rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::Resolver::Line::rect):

We now do rounding during layout.

(WebCore::SimpleLineLayout::Resolver::Line::baseline):

3:54 PM Changeset in webkit [158097] by akling@apple.com

• 346 edits in trunk/Source/WebCore

Renderers should receive their style at construction.
<​https://webkit.org/b/123396>

Pass the RenderStyle to all non-text renderer constructors.
After construction, initializeStyle() must be called (as a stopgap
measure) until we are able to do style-derived initialization
without virtual function calls.

With this change, RenderElement::m_style is never null. Subsequent
patches will add enforcement for this and also make style() return
a RenderStyle&.

I'm adding three FIXME's in this patch:

• createRendererIfNeeded() calls AnimationController to set up the initial style manually instead of asking RenderElement's setAnimatedStyle() to do it. This can probably be done in a nicer way, but it's not clear yet how.

• ImageContentData::createRenderer() does a bit of unnecessary work. This should be easy to clean up but got too distracting to be part of this patch.

• Document::createRenderTree() creates the RenderView with an initial dummy RenderStyle. I've done this because resolving the document style assumes we already have a RenderView.

For styleWillChange() implementations to detect that they are
reacting to the initial style, I've added a hasInitializedStyle()
function on RenderElement. This will return false until you've
called initializeStyle() on the renderer. This should go away
along with initializeStyle() eventually.

Reviewed by Antti Koivisto.